Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
2
3         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
4         https://bugs.webkit.org/show_bug.cgi?id=181950
5         <rdar://problem/43357371>
6
7         Reviewed by Brent Fulgham.
8
9         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
10         (TestWebKitAPI::TEST_F):
11
12 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
13
14         Remove webkitpy and bindings EWS queues from dashboard
15         https://bugs.webkit.org/show_bug.cgi?id=197475
16
17         Reviewed by Alexey Proskuryakov.
18
19         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
20
21 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
22
23         Remove webkitpy and bindings test queues from old EWS
24         https://bugs.webkit.org/show_bug.cgi?id=197468
25
26         Reviewed by Alexey Proskuryakov.
27
28         * QueueStatusServer/config/queues.py:
29
30 2019-04-30  Tim Horton  <timothy_horton@apple.com>
31
32         Fix the WebKitTestRunner build
33         https://bugs.webkit.org/show_bug.cgi?id=197449
34         <rdar://problem/50334169>
35
36         Reviewed by Alexey Proskuryakov.
37
38         * WebKitTestRunner/mac/EventSenderProxy.mm:
39         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
40         (WTR::EventSenderProxy::mouseForceChanged):
41         Use some SPI instead of IPI.
42
43 2019-04-30  Chris Dumez  <cdumez@apple.com>
44
45         Regression(PSON) URL scheme handlers can no longer respond asynchronously
46         https://bugs.webkit.org/show_bug.cgi?id=197426
47         <rdar://problem/50256169>
48
49         Reviewed by Brady Eidson.
50
51         Add API test coverage.
52
53         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
54         (-[PSONScheme setShouldRespondAsynchronously:]):
55         (-[PSONScheme webView:startURLSchemeTask:]):
56         (-[PSONScheme webView:stopURLSchemeTask:]):
57
58 2019-04-30  Chris Dumez  <cdumez@apple.com>
59
60         Unreviewed, rolling out r244802.
61
62         Caused an API test failure
63
64         Reverted changeset:
65
66         "Regression(PSON) URL scheme handlers can no longer respond
67         asynchronously"
68         https://bugs.webkit.org/show_bug.cgi?id=197426
69         https://trac.webkit.org/changeset/244802
70
71 2019-04-30  Chris Dumez  <cdumez@apple.com>
72
73         Regression(PSON) URL scheme handlers can no longer respond asynchronously
74         https://bugs.webkit.org/show_bug.cgi?id=197426
75         <rdar://problem/50256169>
76
77         Reviewed by Brady Eidson.
78
79         Add API test coverage.
80
81         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
82         (-[PSONScheme setShouldRespondAsynchronously:]):
83         (-[PSONScheme webView:startURLSchemeTask:]):
84         (-[PSONScheme webView:stopURLSchemeTask:]):
85
86 2019-04-30  Chris Dumez  <cdumez@apple.com>
87
88         Only use a related page's process if that page has not been closed yet
89         https://bugs.webkit.org/show_bug.cgi?id=197393
90         <rdar://problem/50302423>
91
92         Reviewed by Tim Horton.
93
94         Add API test coverage.
95
96         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
97
98 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
99
100         [ews-build] Enable Bindings tests queue on new EWS
101         https://bugs.webkit.org/show_bug.cgi?id=197424
102
103         Reviewed by Lucas Forschler.
104
105         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
106         (StatusBubble):
107         * BuildSlaveSupport/ews-build/config.json:
108
109 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
110
111         [ews-build] Configure ews151 for running various tests
112         https://bugs.webkit.org/show_bug.cgi?id=197419
113
114         Reviewed by Lucas Forschler.
115
116         * BuildSlaveSupport/ews-build/config.json:
117
118 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
119
120         [ews-build] Parse and display bindings test failures
121         https://bugs.webkit.org/show_bug.cgi?id=197423
122
123         Reviewed by Lucas Forschler.
124
125         * BuildSlaveSupport/ews-build/steps.py:
126         (RunBindingsTests.__init__): Set timeout of 5 minutes.
127         (RunBindingsTests.start): Initialize log_observer for json output.
128         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
129         (RunBindingsTests._addToLog): Method to add message to log.
130         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
131
132 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
133
134         Unreviewed. Add myself as a committer.
135
136         * Scripts/webkitpy/common/config/contributors.json:
137
138 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
139
140         [ews-build] Enable webkitpy queue on new EWS
141         https://bugs.webkit.org/show_bug.cgi?id=197396
142
143         Reviewed by Lucas Forschler.
144
145         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
146         (StatusBubble):
147         * BuildSlaveSupport/ews-build/config.json:
148
149 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
150
151         [ews-build] Parse and display webkitpy failures
152         https://bugs.webkit.org/show_bug.cgi?id=197395
153
154         Reviewed by Lucas Forschler.
155
156         * BuildSlaveSupport/ews-build/steps.py:
157         (RunWebKitPyTests.start): Initialize log_observer for json output.
158         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
159         (RunWebKitPyTests._addToLog): Method to add message to log.
160         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
161
162 2019-04-29  Alex Christensen  <achristensen@webkit.org>
163
164         <rdar://problem/50299396> Fix internal High Sierra build
165         https://bugs.webkit.org/show_bug.cgi?id=197388
166
167         * DumpRenderTree/mac/Configurations/Base.xcconfig:
168         * MiniBrowser/Configurations/Base.xcconfig:
169         * MobileMiniBrowser/Configurations/Base.xcconfig:
170         * TestWebKitAPI/Configurations/Base.xcconfig:
171         * WebKitTestRunner/Configurations/Base.xcconfig:
172
173 2019-04-29  Youenn Fablet  <youenn@apple.com>
174
175         Remove spurious GVA printf logging
176         https://bugs.webkit.org/show_bug.cgi?id=197368
177         <rdar://problem/35975256>
178
179         Reviewed by Alexey Proskuryakov.
180
181         * Scripts/webkitpy/port/mac.py:
182         (MacPort.logging_patterns_to_strip):
183
184 2019-04-29  Youenn Fablet  <youenn@apple.com>
185
186         getDisplayMedia should be called on user gesture
187         https://bugs.webkit.org/show_bug.cgi?id=197356
188         <rdar://problem/50296074>
189
190         Reviewed by Eric Carlson.
191
192         Update test configuration to inject internals
193         so that we can use it to simulate a user click to call getDisplayMedia.
194
195         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
196         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
197         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
198
199 2019-04-26  Stephanie Lewis  <slewis@apple.com>
200
201         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
202         https://bugs.webkit.org/show_bug.cgi?id=197339
203
204         Reviewed by Dewei Zhu.
205
206         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
207         test run for setup steps that are too expensive to do every iteration.
208
209         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
210         (BenchmarkRunner._run_benchmark):
211         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
212         (BrowserDriver):
213         (BrowserDriver.prepare_initial_env):
214         (BrowserDriver.restore_env_after_all_testing):
215         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
216         (LinuxBrowserDriver.prepare_initial_env):
217         (LinuxBrowserDriver.restore_env_after_all_testing):
218         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
219         (OSXBrowserDriver.prepare_initial_env):
220         (OSXBrowserDriver.restore_env_after_all_testing):
221
222 2019-04-28  Andy Estes  <aestes@apple.com>
223
224         Fix the watchOS engineering build.
225
226         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
227         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
228
229 2019-04-27  Chris Dumez  <cdumez@apple.com>
230
231         [WKTR] Move test timeout handling to the UIProcess
232         https://bugs.webkit.org/show_bug.cgi?id=197333
233
234         Reviewed by Darin Adler.
235
236         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
237         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
238         every WebContent process in the case of swapping.
239
240         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
241         would lead to crashes when firing the timer.
242
243         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
244         (WTR::InjectedBundle::didReceiveMessageToPage):
245         (WTR::InjectedBundle::done):
246         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
247         (WTR::InjectedBundle::shouldDumpPixels const):
248         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
249         (WTR::TestRunner::TestRunner):
250         (WTR::TestRunner::waitUntilDone):
251         (WTR::TestRunner::setWaitUntilDone):
252         * WebKitTestRunner/InjectedBundle/TestRunner.h:
253         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
254         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
255         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
256         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
257         * WebKitTestRunner/TestInvocation.cpp:
258         (WTR::TestInvocation::TestInvocation):
259         (WTR::TestInvocation::createTestSettingsDictionary):
260         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
261         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
262         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
263         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
264         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
265         (WTR::TestInvocation::setWaitUntilDone):
266         (WTR::TestInvocation::done):
267         * WebKitTestRunner/TestInvocation.h:
268
269 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
270
271         [JSC] linkPolymorphicCall now does GC
272         https://bugs.webkit.org/show_bug.cgi?id=197306
273
274         Reviewed by Saam Barati.
275
276         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
277         To add this test, we add `runWithoutBaseOption`.
278
279         * Scripts/run-jsc-stress-tests:
280
281 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
282
283         Update inactive reviewers' status to 'contributor'.
284
285         Accidentally skipped one at first.
286
287         * Scripts/webkitpy/common/config/contributors.json:
288
289 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
290
291         Update inactive reviewers' status to 'contributor'.
292
293         * Scripts/webkitpy/common/config/contributors.json: The change.
294
295         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
296         * Scripts/webkitpy/common/checkout/checkout_mock.py:
297         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
298         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
299         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
300         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
301         * Scripts/webkitpy/tool/commands/queries_unittest.py:
302         * Scripts/webkitpy/tool/commands/upload_unittest.py:
303         Sadly, regression tests operate on a crazy mix of mock and live data for
304         contributors.json. It would be a substantial project to mock all code paths,
305         so changing the tests instead.
306
307 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
308
309         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
310         https://bugs.webkit.org/show_bug.cgi?id=197171
311         <rdar://problem/47454979>
312
313         Reviewed by Youenn Fablet.
314
315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
316         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
317         (TestWebKitAPI::TEST):
318
319 2019-04-26  David Kilzer  <ddkilzer@apple.com>
320
321         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
322         <https://webkit.org/b/197314>
323         <rdar://problem/50245252>
324
325         Reviewed by Simon Fraser.
326
327         * WebKitTestRunner/UIScriptControllerCocoa.mm:
328         (WTR::UIScriptController::lastUndoLabel const):
329         (WTR::UIScriptController::firstRedoLabel const):
330         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
331
332         * WebKitTestRunner/ios/HIDEventGenerator.mm:
333         (-[HIDEventGenerator sendEventStream:completionBlock:]):
334         - Call -autorelease to fix leak of NSDictionary.
335
336         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
337         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
338         (WTR::UIScriptController::selectFormPopoverTitle const):
339         (WTR::UIScriptController::textContentType const):
340         (WTR::UIScriptController::formInputLabel const):
341         (WTR::UIScriptController::scrollingTreeAsText const):
342         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
343
344 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
345
346         webkitpy: Running a single test will always use the default device
347         https://bugs.webkit.org/show_bug.cgi?id=195472
348         <rdar://problem/48724825>
349
350         Reviewed by Lucas Forschler.
351
352         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
353         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
354         requested will be run regardless of what shard they are in.
355
356         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
357         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
358         * Scripts/webkitpy/layout_tests/controllers/manager.py:
359         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
360         on the default device type.
361         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
362         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
363         (RunTest.test_run_part): Ditto.
364
365 2019-04-26  Alex Christensen  <achristensen@webkit.org>
366
367         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
368         https://bugs.webkit.org/show_bug.cgi?id=197165
369
370         Reviewed by Youenn Fablet.
371
372         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
373
374 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
375
376         Replace iOS build queue hardware
377         https://bugs.webkit.org/show_bug.cgi?id=197312
378
379         Reviewed by Aakash Jain.
380
381         * BuildSlaveSupport/build.webkit.org-config/config.json:
382         Use newer hardware that supports macOS Mojave.
383
384 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
385
386         check-webkit-style complains the first block in while loop.
387         https://bugs.webkit.org/show_bug.cgi?id=197307
388
389         The style checker shouldn't complain about an open brace on
390         its own line if the last non-whitespace character on the previous
391         non-blank line is another open brace, because it's likely to
392         indicate the begining of a nested code block.
393
394         Reviewed by Alex Christensen.
395
396         * Scripts/webkitpy/style/checkers/cpp.py:
397         (check_braces):
398         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
399         (WebKitStyleTest.test_braces):
400
401 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
402
403         Stop IDB transactions to release locked database files when network process is ready to suspend
404         https://bugs.webkit.org/show_bug.cgi?id=196372
405         <rdar://problem/48930116>
406
407         Reviewed by Brady Eidson.
408
409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
410         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
411         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
412         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
413         (runTestAndCheckResult):
414         (keepNetworkProcessActive):
415         (TEST):
416
417 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
418
419         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
420         https://bugs.webkit.org/show_bug.cgi?id=188357
421         <rdar://problem/42986633>
422
423         Reviewed by Dean Jackson.
424
425         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
426         tests would fall into low memory mode and have different behavior.
427         
428         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
429         to Internals, so it's shared by DRT and WTR.
430         
431         We no longer need the WK2 C SPI glue.
432
433         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
434         (WTR::InjectedBundlePage::prepare):
435
436 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
437
438         webkitpy: Including skipped tests in the final count
439         https://bugs.webkit.org/show_bug.cgi?id=197298
440         <rdar://problem/49705424>
441
442         Reviewed by Lucas Forschler.
443
444         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
445         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
446
447 2019-04-25  Timothy Hatcher  <timothy@apple.com>
448
449         Disable date and time inputs on iOSMac.
450         https://bugs.webkit.org/show_bug.cgi?id=197287
451         rdar://problem/46794376
452
453         Reviewed by Wenson Hsieh.
454
455         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
456
457 2019-04-25  Alex Christensen  <achristensen@webkit.org>
458
459         Fix test-webkitpy after r244653
460         https://bugs.webkit.org/show_bug.cgi?id=197131
461
462         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
463         Also use C++17.
464
465 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
466
467         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
468         https://bugs.webkit.org/show_bug.cgi?id=196991
469         <rdar://problem/45507423>
470
471         Reviewed by Alex Christensen.
472
473         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
474         (-[NavigationTestDelegate init]):
475         (-[NavigationTestDelegate waitForDidFinishNavigation]):
476         (-[NavigationTestDelegate webView:didFinishNavigation:]):
477         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
478         (TestWebKitAPI::TEST):
479         (TEST): Deleted.
480
481 2019-04-25  Alex Christensen  <achristensen@webkit.org>
482
483         Revert some code accidentally committed with r244653
484         https://bugs.webkit.org/show_bug.cgi?id=197131
485
486         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
487         (TestWebKitAPI::TEST):
488
489 2019-04-25  Alex Christensen  <achristensen@webkit.org>
490
491         Start using C++17
492         https://bugs.webkit.org/show_bug.cgi?id=197131
493
494         Reviewed by Darin Adler.
495
496         * DumpRenderTree/mac/Configurations/Base.xcconfig:
497         * MiniBrowser/Configurations/Base.xcconfig:
498         * MobileMiniBrowser/Configurations/Base.xcconfig:
499         * TestWebKitAPI/Configurations/Base.xcconfig:
500         * WebKitTestRunner/Configurations/Base.xcconfig:
501
502 2019-04-25  Commit Queue  <commit-queue@webkit.org>
503
504         Unreviewed, rolling out r244627.
505         https://bugs.webkit.org/show_bug.cgi?id=197282
506
507         Causing internal build failures (Requested by ShawnRoberts on
508         #webkit).
509
510         Reverted changeset:
511
512         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
513         https://bugs.webkit.org/show_bug.cgi?id=197171
514         https://trac.webkit.org/changeset/244627
515
516 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
517
518         [GTK] Hardcoded text color in input fields
519         https://bugs.webkit.org/show_bug.cgi?id=126907
520
521         Reviewed by Michael Catanzaro.
522
523         Add dark-mode command line option to MiniBrowser.
524
525         * MiniBrowser/gtk/main.c:
526         (main):
527
528 2019-04-24  Zalan Bujtas  <zalan@apple.com>
529
530         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
531         https://bugs.webkit.org/show_bug.cgi?id=196948
532         <rdar://problem/49927131>
533
534         Reviewed by Tim Horton.
535
536         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
537         (TEST):
538         The expected order of incoming events is
539         1. didInvalidateIntrinsicContentSize
540         2. didFirstLayout
541         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
542         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
543         (and remember, all we care about is ordering).
544
545 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
546
547         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
548         https://bugs.webkit.org/show_bug.cgi?id=197171
549         <rdar://problem/47454979>
550
551         Reviewed by Youenn Fablet.
552
553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
554         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
555         (TestWebKitAPI::TEST):
556
557 2019-04-24  Brady Eidson  <beidson@apple.com>
558
559         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
560         https://bugs.webkit.org/show_bug.cgi?id=191362
561
562         Reviewed by Alex Christensen.
563
564         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
565           from an XHR to a custom protocol.
566
567 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
568
569         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
570         https://bugs.webkit.org/show_bug.cgi?id=197273
571
572         Reviewed by Dean Jackson.
573
574         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
575         so that WebCoreTestSupport::resetInternalsObject() is always run.
576
577         * DumpRenderTree/mac/DumpRenderTree.mm:
578         (resetWebViewToConsistentStateBeforeTesting):
579         (runTest):
580
581 2019-04-24  John Wilander  <wilander@apple.com>
582
583         Age out unconverted Ad Click Attributions after one week.
584         https://bugs.webkit.org/show_bug.cgi?id=197238
585         <rdar://problem/50177349>
586
587         Reviewed by Chris Dumez.
588
589         This patch adds infrastructure to allow tests to expire all unconverted
590         attributions early.
591
592         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
593         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
594         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
595         * WebKitTestRunner/InjectedBundle/TestRunner.h:
596         * WebKitTestRunner/TestController.cpp:
597         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
598         * WebKitTestRunner/TestController.h:
599         * WebKitTestRunner/TestInvocation.cpp:
600         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
601
602 2019-04-24  Chris Dumez  <cdumez@apple.com>
603
604         Fix flaky crashes in a couple of PSON API tests
605         https://bugs.webkit.org/show_bug.cgi?id=197239
606
607         Reviewed by Tim Horton.
608
609         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
610
611         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
612
613 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
614
615         Make it possible to control the renderTreeAsText output by setting options on testRunner
616         https://bugs.webkit.org/show_bug.cgi?id=197133
617
618         Reviewed by Sam Weinig.
619
620         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
621         that make sense in testing (those that don't dump unstable data like addresses), and plumb
622         these flags through the various framework layers.
623
624         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
625
626         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
627         and hand-code DumpRenderTree bindings.
628
629         Some cleanup of the TestRunners, using member initializers.
630
631         * DumpRenderTree/TestRunner.cpp:
632         (TestRunner::TestRunner):
633         (setRenderTreeDumpOptionsCallback):
634         (TestRunner::staticFunctions):
635         (TestRunner::setRenderTreeDumpOptions):
636         * DumpRenderTree/TestRunner.h:
637         (TestRunner::renderTreeDumpOptions const):
638         * DumpRenderTree/mac/DumpRenderTree.mm:
639         (dump):
640         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
641         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
642         (WTR::InjectedBundlePage::dump):
643         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
644         (WTR::TestRunner::TestRunner):
645         (WTR::TestRunner::setRenderTreeDumpOptions):
646         * WebKitTestRunner/InjectedBundle/TestRunner.h:
647         (WTR::TestRunner::renderTreeDumpOptions const):
648
649 2019-04-24  Alex Christensen  <achristensen@webkit.org>
650
651         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
652         https://bugs.webkit.org/show_bug.cgi?id=197078
653         <rdar://problem/49564348>
654
655         Reviewed by Geoff Garen.
656
657         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
658         (TEST_F):
659         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
660         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
661         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
662
663 2019-04-24  Alex Christensen  <achristensen@webkit.org>
664
665         Add unit test for r239322
666         https://bugs.webkit.org/show_bug.cgi?id=197236
667
668         Reviewed by Chris Dumez.
669
670         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
671         May as well add the test infrastructure which was needed before and will be needed in the future.
672
673         * TestWebKitAPI/TCPServer.cpp:
674         (TestWebKitAPI::TCPServer::TCPServer):
675         * TestWebKitAPI/TCPServer.h:
676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
677         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
678         (TestWebKitAPI::TEST):
679         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
680         (TestWebKitAPI::downloadAtRate):
681         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
682         (TEST):
683         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
684         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
685         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
686         (TestWebKitAPI::TEST):
687         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
688         (TEST):
689
690 2019-04-24  Chris Dumez  <cdumez@apple.com>
691
692         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
693         https://bugs.webkit.org/show_bug.cgi?id=197214
694         <rdar://problem/49237544>
695
696         Reviewed by Alex Christensen.
697
698         Extend API test coverage.
699
700         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
701         (TEST):
702
703 2019-04-24  Philippe Normand  <pnormand@igalia.com>
704
705         [Build][GStreamer] Update to 1.16.0
706         https://bugs.webkit.org/show_bug.cgi?id=197157
707
708         Reviewed by Xabier Rodriguez-Calvar.
709
710         The upstreamed patches were removed and a new one was added for a
711         regression detected in the scaletempo GStreamer element. The GNOME
712         Flatpak was migrated to 3.32 and I switched a few modules to Meson
713         on the way, as it is the preferred build system now in GStreamer
714         1.16.
715
716         * flatpak/files/httpd-autogen.sh:
717         * flatpak/flatpakutils.py:
718         (FlatpakPackage.install):
719         (WebkitFlatpak.run_in_sandbox):
720         * flatpak/org.webkit.CommonModules.yaml:
721         * flatpak/org.webkit.WebKit.yaml:
722         * gstreamer/jhbuild.modules:
723         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
724         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
725         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
726         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
727         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
728         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
729         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
730         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
731         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
732         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
733         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
734         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
735         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
736         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
737         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
738         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
739         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
740         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
741         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
742         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
743         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
744         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
745
746 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
747
748         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
749         https://bugs.webkit.org/show_bug.cgi?id=197156
750
751         Reviewed by Michael Catanzaro.
752
753         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
754         support was added.
755
756         * MiniBrowser/gtk/BrowserTab.c:
757         (browser_tab_set_background_color): Set the passed in color as web view background color.
758         * MiniBrowser/gtk/BrowserTab.h:
759         * MiniBrowser/gtk/BrowserWindow.c:
760         (browser_window_init): Initialize backgroundColor.
761         (browser_window_append_view): Call browser_tab_set_background_color().
762         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
763         are added.
764         * MiniBrowser/gtk/main.c:
765         (main): Call browser_window_set_background_color() before creating the tabs.
766
767 2019-04-23  John Wilander  <wilander@apple.com>
768
769         Move Ad Click Attribution from internal feature to experimental feature
770         https://bugs.webkit.org/show_bug.cgi?id=197218
771         <rdar://problem/47651691>
772
773         Reviewed by Brent Fulgham.
774
775         * DumpRenderTree/TestOptions.cpp:
776         (TestOptions::TestOptions):
777
778 2019-04-23  Andy Estes  <aestes@apple.com>
779
780         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
781         https://bugs.webkit.org/show_bug.cgi?id=196749
782         <rdar://problem/35773454>
783
784         Reviewed by Daniel Bates.
785
786         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
787
788         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
789         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
790         (-[QuickLookDelegate webView:didFinishNavigation:]):
791         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
792         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
793         (runTest):
794         (runTestDecideBeforeLoading):
795         (runTestDecideAfterLoading):
796         (TEST):
797
798 2019-04-23  John Wilander  <wilander@apple.com>
799
800         Remove Ad Click Attribution data when removing website data
801         https://bugs.webkit.org/show_bug.cgi?id=197215
802         <rdar://problem/47668988>
803
804         Reviewed by Chris Dumez.
805
806         This patch adds test infrastructure to delete Ad Click Attribution data
807         through WebsiteDataStore::removeData().
808
809         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
810         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
811         (WTR::TestRunner::clearAdClickAttribution):
812         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
813         * WebKitTestRunner/InjectedBundle/TestRunner.h:
814         * WebKitTestRunner/TestController.cpp:
815         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
816         * WebKitTestRunner/TestController.h:
817         * WebKitTestRunner/TestInvocation.cpp:
818         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
819
820 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
821
822         webkitpy: Kill unresponsive worker processes
823         https://bugs.webkit.org/show_bug.cgi?id=197205
824         <rdar://problem/50104388>
825
826         Reviewed by Lucas Forschler.
827
828         * Scripts/webkitpy/common/message_pool.py:
829         (_MessagePool.__init__): Add close timeout.
830         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
831
832 2019-04-23  Alex Christensen  <achristensen@webkit.org>
833
834         Add unit tests for WKWebView.serverTrust
835         https://bugs.webkit.org/show_bug.cgi?id=197202
836
837         Reviewed by Youenn Fablet
838
839         * TestWebKitAPI/TCPServer.cpp:
840         (TestWebKitAPI::deleter<BIO>::operator()):
841         (TestWebKitAPI::deleter<SSL>::operator()):
842         (TestWebKitAPI::deleter<X509>::operator()):
843         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
844         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
845         (TestWebKitAPI::TCPServer::TCPServer):
846         (TestWebKitAPI::TCPServer::listenForConnections):
847         * TestWebKitAPI/TCPServer.h:
848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
849         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
850         (TestWebKitAPI::TEST):
851         (verifyCertificateAndPublicKey):
852         (-[ServerTrustDelegate webView:didFinishNavigation:]):
853         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
854         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
855         (TestWebKitAPI::downloadAtRate):
856         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
857         (TEST):
858         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
859         (TEST):
860
861 2019-04-23  Commit Queue  <commit-queue@webkit.org>
862
863         Unreviewed, rolling out r244556.
864         https://bugs.webkit.org/show_bug.cgi?id=197212
865
866         Causing build failures on multiple builders (Requested by
867         ShawnRoberts on #webkit).
868
869         Reverted changeset:
870
871         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
872         https://bugs.webkit.org/show_bug.cgi?id=197171
873         https://trac.webkit.org/changeset/244556
874
875 2019-04-23  Alex Christensen  <achristensen@webkit.org>
876
877         Fix iOS build.
878         https://bugs.webkit.org/show_bug.cgi?id=195537
879
880         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
881         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
882         AdoptWK constructor is private now.  Use adoptWK instead.
883
884 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
885
886         Accessibility text search and selection API enhancements.
887         https://bugs.webkit.org/show_bug.cgi?id=197095
888         <rdar://problem/48181791>
889
890         Reviewed by Chris Fleizach.
891
892         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
893
894         * DumpRenderTree/AccessibilityTextMarker.h:
895         * DumpRenderTree/AccessibilityUIElement.cpp:
896         (searchTextWithCriteriaCallback):
897         (AccessibilityUIElement::getJSClass):
898         * DumpRenderTree/AccessibilityUIElement.h:
899         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
900         (convertVectorToObjectArray):
901         (convertNSArrayToVector):
902         (searchTextParameterizedAttributeForCriteria):
903         (AccessibilityUIElement::getLinkedUIElements):
904         (AccessibilityUIElement::getDocumentLinks):
905         (AccessibilityUIElement::getChildren):
906         (AccessibilityUIElement::getChildrenWithRange):
907         (AccessibilityUIElement::rowHeaders const):
908         (AccessibilityUIElement::columnHeaders const):
909         (AccessibilityUIElement::uiElementArrayAttributeValue const):
910         (AccessibilityUIElement::searchTextWithCriteria):
911         (AccessibilityUIElement::attributesOfColumnHeaders):
912         (AccessibilityUIElement::attributesOfRowHeaders):
913         (AccessibilityUIElement::attributesOfColumns):
914         (AccessibilityUIElement::attributesOfRows):
915         (AccessibilityUIElement::attributesOfVisibleCells):
916         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
917         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
918         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
919         (WTR::convertVectorToObjectArray):
920         (WTR::convertNSArrayToVector):
921         (WTR::searchTextParameterizedAttributeForCriteria):
922         (WTR::AccessibilityUIElement::getLinkedUIElements):
923         (WTR::AccessibilityUIElement::getDocumentLinks):
924         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
925         (WTR::AccessibilityUIElement::getChildren):
926         (WTR::AccessibilityUIElement::getChildrenWithRange):
927         (WTR::AccessibilityUIElement::rowHeaders const):
928         (WTR::AccessibilityUIElement::columnHeaders const):
929         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
930         (WTR::AccessibilityUIElement::searchTextWithCriteria):
931         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
932         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
933         (WTR::AccessibilityUIElement::attributesOfColumns):
934         (WTR::AccessibilityUIElement::attributesOfRows):
935         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
936         (WTR::convertElementsToObjectArray): Deleted.
937
938 2019-04-23  Guy Lewin  <guy@lewin.co.il>
939
940         Multiple File Input Icon Set Regardless of File List
941         https://bugs.webkit.org/show_bug.cgi?id=195537
942
943         Reviewed by Alexey Proskuryakov.
944
945         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
946         display string in iOS file inputs
947
948         * DumpRenderTree/TestRunner.cpp:
949         (SetOpenPanelFilesMediaIconCallback):
950         (TestRunner::staticFunctions):
951         (TestRunner::setOpenPanelFilesMediaIcon):
952         * DumpRenderTree/TestRunner.h:
953         (TestRunner::openPanelFilesMediaIcon const):
954         * DumpRenderTree/mac/UIDelegate.mm:
955         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
956         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
957         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
958         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
959         * WebKitTestRunner/InjectedBundle/TestRunner.h:
960         * WebKitTestRunner/TestController.cpp:
961         (WTR::runOpenPanel):
962         (WTR::TestController::resetStateToConsistentValues):
963         * WebKitTestRunner/TestController.h:
964         (WTR::TestController::openPanelFileURLsMediaIcon const):
965         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
966         * WebKitTestRunner/TestInvocation.cpp:
967         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
968
969 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
970
971         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
972         https://bugs.webkit.org/show_bug.cgi?id=197171
973         <rdar://problem/47454979>
974
975         Reviewed by Youenn Fablet.
976
977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
978         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
979         (TestWebKitAPI::TEST):
980
981 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
982
983         [ews-build] Add unit tests for UnApplyPatchIfRequired
984         https://bugs.webkit.org/show_bug.cgi?id=197197
985
986         Reviewed by Lucas Forschler.
987
988         * BuildSlaveSupport/ews-build/steps_unittest.py:
989         (TestUnApplyPatchIfRequired):
990         (TestUnApplyPatchIfRequired.test_success):
991         (TestUnApplyPatchIfRequired.test_failure):
992         (TestUnApplyPatchIfRequired.test_skip):
993
994 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
995
996         [ews-build] Add unit tests for CleanWorkingDirectory
997         https://bugs.webkit.org/show_bug.cgi?id=197195
998
999         Reviewed by Lucas Forschler.
1000
1001         * BuildSlaveSupport/ews-build/steps_unittest.py:
1002         (TestCleanWorkingDirectory):
1003         (TestCleanWorkingDirectory.test_success):
1004         (TestCleanWorkingDirectory.test_failure):
1005
1006 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1007
1008         [ews-build] Use explicit imports instead of wildcard imports
1009         https://bugs.webkit.org/show_bug.cgi?id=197194
1010
1011         Reviewed by Lucas Forschler.
1012
1013         * BuildSlaveSupport/ews-build/factories.py:
1014         * BuildSlaveSupport/ews-build/loadConfig.py:
1015         * BuildSlaveSupport/ews-build/steps_unittest.py:
1016
1017 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1018
1019         [ews-build] Add unit tests for DownloadBuiltProduct
1020         https://bugs.webkit.org/show_bug.cgi?id=197193
1021
1022         Reviewed by Lucas Forschler.
1023
1024         * BuildSlaveSupport/ews-build/steps_unittest.py:
1025         (TestDownloadBuiltProduct):
1026         (TestDownloadBuiltProduct.setUp):
1027         (TestDownloadBuiltProduct.tearDown):
1028         (TestDownloadBuiltProduct.test_success):
1029         (TestDownloadBuiltProduct.test_failure):
1030
1031 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1032
1033         [ews-app] Exception while loading status-bubble when no build step has started
1034         https://bugs.webkit.org/show_bug.cgi?id=196676
1035
1036         Reviewed by Lucas Forschler.
1037
1038         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1039         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1040
1041 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1042
1043         [PlayStation] Support running of JSC tests on remote playstation devices
1044         https://bugs.webkit.org/show_bug.cgi?id=197170
1045
1046         Reviewed by Ross Kirsling.
1047
1048         Script changes
1049
1050         * Scripts/run-javascriptcore-tests:
1051         (runJSCStressTests): Pass arguments for playstation to
1052         run-jsc-stress-tests
1053         * Scripts/run-jsc-stress-tests:
1054         Handle $hostOS=="playstation" for determineArchitecture, turning
1055         off $isFTLPlatform and runProfiler and defaulting test writer.
1056         * Scripts/webkitdirs.pm:
1057         (jscPath): PlayStation WebKit executables have .elf extension
1058         (executableProductDir): PlayStation builds on Windows hosts but
1059         uses bin directory rather than bin64/bin32 for executable output
1060         location.
1061         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1062
1063 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1064
1065         [CMake][Win] Use target oriented design for WebKit
1066         https://bugs.webkit.org/show_bug.cgi?id=197173
1067
1068         Reviewed by Alex Christensen.
1069
1070         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1071         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1072
1073 2019-04-23  Chris Dumez  <cdumez@apple.com>
1074
1075         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1076         https://bugs.webkit.org/show_bug.cgi?id=197097
1077         <rdar://problem/50048318>
1078
1079         Reviewed by Alex Christensen.
1080
1081         Add API test coverage.
1082
1083         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1084         (-[PSONScheme webView:startURLSchemeTask:]):
1085
1086 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1087
1088         [ATK] Implement AtkComponentIface scroll_to methods
1089         https://bugs.webkit.org/show_bug.cgi?id=196856
1090
1091         Reviewed by Michael Catanzaro.
1092
1093         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1094         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1095         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1096         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1097
1098 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1099
1100         [ews-build] Improve summary for UploadBuiltProduct step
1101         https://bugs.webkit.org/show_bug.cgi?id=197182
1102
1103         Reviewed by Lucas Forschler.
1104
1105         * BuildSlaveSupport/ews-build/steps.py:
1106         (UploadBuiltProduct): Added descriptionDone.
1107         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1108         * BuildSlaveSupport/ews-build/steps_unittest.py:
1109         (TestUploadBuiltProduct.test_success): Updated unit-test.
1110         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1111
1112 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1113
1114         [ews-build] Trigger queues only after uploading the archive
1115         https://bugs.webkit.org/show_bug.cgi?id=197180
1116
1117         Reviewed by Lucas Forschler.
1118
1119         * BuildSlaveSupport/ews-build/factories.py:
1120         (Factory.__init__):
1121         (BuildFactory.__init__): Remove trigger step from factories.
1122         (BuildFactory.propertiesToPassToTriggers): Deleted.
1123         * BuildSlaveSupport/ews-build/steps.py:
1124         (ConfigureBuild.__init__): Confiure triggers property.
1125         (Trigger): Step to trigger other queues.
1126         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1127         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1128
1129 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1130
1131         Deprecate WKContextCreateWithInjectedBundlePath
1132         https://bugs.webkit.org/show_bug.cgi?id=197169
1133
1134         Reviewed by Youenn Fablet.
1135
1136         * TestWebKitAPI/PlatformUtilities.cpp:
1137         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1138         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1139
1140 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1141
1142         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1143         https://bugs.webkit.org/show_bug.cgi?id=197093
1144         <rdar://problem/49708268>
1145
1146         Reviewed by Chris Dumez.
1147
1148         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1149         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1150         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1151         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1152         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1153
1154         * TestWebKitAPI/TCPServer.cpp:
1155         (TestWebKitAPI::TCPServer::TCPServer):
1156         (TestWebKitAPI::TCPServer::~TCPServer):
1157         (TestWebKitAPI::TCPServer::socketBindListen):
1158         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1159         * TestWebKitAPI/TCPServer.h:
1160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1161         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1162         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1163         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1164         (respondWithChallengeThenOK):
1165         (TestWebKitAPI::TEST):
1166         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1167         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1168         (TEST):
1169
1170 2019-04-22  Chris Dumez  <cdumez@apple.com>
1171
1172         Delayed WebProcessLaunch may break the _relatedWebView SPI
1173         https://bugs.webkit.org/show_bug.cgi?id=197160
1174
1175         Reviewed by Alex Christensen.
1176
1177         Add API test coverage.
1178
1179         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1180
1181 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1182
1183         Use curl to download packages for webkitpy autoinstaller
1184         https://bugs.webkit.org/show_bug.cgi?id=197164
1185
1186         Reviewed by Darin Adler.
1187
1188         * Scripts/webkitpy/common/system/autoinstall.py:
1189         (AutoInstaller._download): Use curl(1) to download packages necessary for
1190         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1191         errors which are not present when using curl(1).
1192
1193 2019-04-22  Chris Dumez  <cdumez@apple.com>
1194
1195         Unreviewed, rolling out r244502.
1196
1197         Caused crashes on the bots
1198
1199         Reverted changeset:
1200
1201         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1202         https://bugs.webkit.org/show_bug.cgi?id=197160
1203         https://trac.webkit.org/changeset/244502
1204
1205 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1206
1207         Unreviewed, rolling out r244437.
1208
1209         Still breaks internal tests.
1210
1211         Reverted changeset:
1212
1213         "InjectedBundle parameters often need initialization function
1214         called before unarchiving"
1215         https://bugs.webkit.org/show_bug.cgi?id=189709
1216         https://trac.webkit.org/changeset/244437
1217
1218 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1219
1220         [ews-build] Use singular verb in failure description in case of single api test failure
1221         https://bugs.webkit.org/show_bug.cgi?id=197013
1222
1223         Reviewed by Lucas Forschler.
1224
1225         * BuildSlaveSupport/ews-build/steps.py:
1226         (AnalyzeAPITestsResults.analyzeResults):
1227
1228 2019-04-22  Chris Dumez  <cdumez@apple.com>
1229
1230         Delayed WebProcessLaunch may break the _relatedWebView SPI
1231         https://bugs.webkit.org/show_bug.cgi?id=197160
1232
1233         Reviewed by Alex Christensen.
1234
1235         Add API test coverage.
1236
1237         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1238
1239 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1240
1241         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1242         https://bugs.webkit.org/show_bug.cgi?id=194630
1243
1244         Reviewed by Michael Catanzaro.
1245
1246         Return early from getAttributeSet() is passed in accessible is nullptr.
1247
1248         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1249
1250 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1251
1252         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1253         https://bugs.webkit.org/show_bug.cgi?id=197145
1254         <rdar://problem/50078170>
1255
1256         Reviewed by Darin Adler.
1257
1258         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1259         focus, or showing the font manager.
1260
1261         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1262         (TestWebKitAPI::TEST):
1263         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1264         (TEST):
1265         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1266         (TestWebKitAPI::TEST):
1267
1268 2019-04-21  Brian Burg  <bburg@apple.com>
1269
1270         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1271         https://bugs.webkit.org/show_bug.cgi?id=197125
1272         <rdar://problem/50061468>
1273
1274         Reviewed by Darin Adler.
1275
1276         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1277         using this class rather than making our own ./wpt serve invocation.
1278
1279         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1280         (WebDriverW3CWebServer):
1281         (WebDriverW3CWebServer.document_root): Expose this to clients.
1282         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1283
1284         (WebDriverW3CWebServer.__enter__):
1285         (WebDriverW3CWebServer.__exit__):
1286         Make it possible to use the web server with a 'with' statement.
1287
1288 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1289
1290         [CMake][Win] Use target oriented design for WebKitLegacy
1291         https://bugs.webkit.org/show_bug.cgi?id=197112
1292
1293         Reviewed by Konstantin Tokarev.
1294
1295         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1296
1297         * DumpRenderTree/CMakeLists.txt:
1298         * DumpRenderTree/PlatformWin.cmake:
1299         * DumpRenderTree/win/EventSender.cpp:
1300
1301 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1302
1303         Update text for old EWS submit button
1304         https://bugs.webkit.org/show_bug.cgi?id=197140
1305
1306         Reviewed by Alexey Proskuryakov.
1307
1308         * QueueStatusServer/templates/statusbubble.html:
1309
1310 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1311
1312         [ews-app] New EWS should poll bugzilla more frequently
1313         https://bugs.webkit.org/show_bug.cgi?id=197138
1314
1315         Reviewed by Alexey Proskuryakov.
1316
1317         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1318         (FetchLoop.__init__):
1319
1320 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1321
1322         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1323         https://bugs.webkit.org/show_bug.cgi?id=197139
1324
1325         Reviewed by Alexey Proskuryakov.
1326
1327         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1328         * QueueStatusServer/templates/statusbubble.html:
1329
1330 2019-04-20  Chris Dumez  <cdumez@apple.com>
1331
1332         Unreviewed, fix iOS build with recent SDKs.
1333
1334         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1335
1336 2019-04-19  Keith Miller  <keith_miller@apple.com>
1337
1338         Add script to merge run_benchmark jsons
1339         https://bugs.webkit.org/show_bug.cgi?id=197107
1340
1341         Reviewed by Michael Saboff.
1342
1343         The script basically recursively decends through all json objects until it gets
1344         to an array or JSON primitive and concats or takes the first value, respectively.
1345
1346         This patch also adds +x bits to the compare-results script so it
1347         can be run directly from the command line. I had to add a new line so that svn
1348         will accept the change... yay svn!
1349
1350         * Scripts/compare-results:
1351         * Scripts/merge-result-jsons: Added.
1352         (readJSONFile):
1353         (deepAppend):
1354         (mergeJSONs):
1355         (main):
1356
1357 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1358
1359         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1360         https://bugs.webkit.org/show_bug.cgi?id=197079
1361
1362         Reviewed by Darin Adler.
1363
1364         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1365
1366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1367         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1368
1369 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1370
1371         Unreviewed, rolling out r244434.
1372         https://bugs.webkit.org/show_bug.cgi?id=197089
1373
1374         caused 1 API test failure (Requested by zalan on #webkit).
1375
1376         Reverted changeset:
1377
1378         "Regression (r244291): Broken API Test
1379         AutoLayoutRenderingProgressRelativeOrdering"
1380         https://bugs.webkit.org/show_bug.cgi?id=196948
1381         https://trac.webkit.org/changeset/244434
1382
1383 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1384
1385         Add new compatibility mode API on WKNavigation
1386         https://bugs.webkit.org/show_bug.cgi?id=197069
1387         <rdar://problem/50025800>
1388
1389         Reviewed by Tim Horton.
1390
1391         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1392
1393         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1394         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1395         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1396
1397 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1398
1399         [CMake] Make WebCore headers copies
1400         https://bugs.webkit.org/show_bug.cgi?id=182512
1401         <rdar://problem/37510435>
1402
1403         Reviewed by Alex Christensen.
1404
1405         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1406         ports.
1407
1408         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1409         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1410
1411         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1412         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1413         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1414         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1415         * TestWebKitAPI/CMakeLists.txt:
1416         * TestWebKitAPI/PlatformWin.cmake:
1417         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1418         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1419         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1420
1421 2019-04-18  Jer Noble  <jer.noble@apple.com>
1422
1423         Add support for parsing FairPlayStreaming PSSH boxes.
1424         https://bugs.webkit.org/show_bug.cgi?id=197064
1425
1426         Reviewed by Eric Carlson.
1427
1428         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1429         (TestWebKitAPI::TEST):
1430
1431 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1432
1433         InjectedBundle parameters often need initialization function called before unarchiving
1434         https://bugs.webkit.org/show_bug.cgi?id=189709
1435         <rdar://problem/44573653>
1436
1437         Reviewed by Ryosuke Niwa.
1438
1439         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1440         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1441
1442 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1443
1444         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1445         https://bugs.webkit.org/show_bug.cgi?id=196948
1446         <rdar://problem/49927131>
1447
1448         Reviewed by Tim Horton.
1449
1450         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1451         (TEST): 
1452         The expected order of incoming events is
1453         1. didInvalidateIntrinsicContentSize
1454         2. didFirstLayout
1455         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1456         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1457         (and remember, all we care about is ordering).
1458
1459 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1460
1461         Unreviewed, rolling out r244299.
1462
1463         Breaks internal tests.
1464
1465         Reverted changeset:
1466
1467         "InjectedBundle parameters often need initialization function
1468         called before unarchiving"
1469         https://bugs.webkit.org/show_bug.cgi?id=189709
1470         https://trac.webkit.org/changeset/244299
1471
1472 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1473
1474         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1475         https://bugs.webkit.org/show_bug.cgi?id=197053
1476
1477         Reviewed by Saam Barati.
1478
1479         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1480         (TestWebKitAPI::TEST):
1481
1482 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1483
1484         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1485         https://bugs.webkit.org/show_bug.cgi?id=197028
1486         <rdar://problem/49985290>
1487
1488         Reviewed by Wenson Hsieh.
1489
1490         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1491         (TEST):
1492         Liberal application of waitForNextPresentationUpdate works around a race
1493         where if the page rapidly changes its viewport arguments (or an API client
1494         rapidly changes its viewport arguments), we'd get stuck thinking that the
1495         user had intentionally zoomed the page, and stop resetting the initial scale.
1496         This deserves a separate bug, but no need to keep the test failing while
1497         we think about it.
1498
1499 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1500
1501         REGRESSION (r241988): Switching tabs is slow
1502         https://bugs.webkit.org/show_bug.cgi?id=197037
1503         <rdar://problem/49951473>
1504
1505         Reviewed by Simon Fraser.
1506
1507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1508         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1509         (TEST):
1510         * TestWebKitAPI/cocoa/TestWKWebView.h:
1511         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1512         (-[TestWKWebView addToTestWindow]):
1513         Add a test that hangs without this fix.
1514
1515 2019-04-17  Truitt Savell  <tsavell@apple.com>
1516
1517         Unreviewed, rolling out r244400.
1518
1519         Caused testing to exit early with assertionon Debug WK2
1520
1521         Reverted changeset:
1522
1523         "UI↔Web deadlock when printing with a JavaScript alert
1524         visible"
1525         https://bugs.webkit.org/show_bug.cgi?id=196839
1526         https://trac.webkit.org/changeset/244400
1527
1528 2019-04-17  Brady Eidson  <beidson@apple.com>
1529
1530         Link clicks in PDFs shouldn't send referrer headers.
1531         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1532
1533         Reviewed by Tim Horton.
1534
1535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1536         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1537         (putPDFBytesCallback):
1538         (emptyReleaseInfoCallback):
1539         (createPDFWithLinkToURL):
1540         (TEST):
1541
1542 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1543
1544         UI↔Web deadlock when printing with a JavaScript alert visible
1545         https://bugs.webkit.org/show_bug.cgi?id=196839
1546         <rdar://problem/49157642>
1547
1548         Reviewed by Andy Estes.
1549
1550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1551         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1552         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1553         (TEST):
1554
1555 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1556
1557         WKRetainPtr's adoption constructor should be private
1558         https://bugs.webkit.org/show_bug.cgi?id=197019
1559
1560         Reviewed by Tim Horton.
1561
1562         * DumpRenderTree/mac/DumpRenderTree.mm:
1563         (dumpFramesAsText):
1564         * TestWebKitAPI/InjectedBundleController.cpp:
1565         (TestWebKitAPI::InjectedBundleController::initialize):
1566         * TestWebKitAPI/PlatformUtilities.cpp:
1567         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1568         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1569         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1570         (TestWebKitAPI::Util::toWK):
1571         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1572         (TestWebKitAPI::TEST):
1573         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1574         (TestWebKitAPI::TEST):
1575         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1576         (TestWebKitAPI::TEST):
1577         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1578         (TestWebKitAPI::TEST):
1579         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1580         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1581         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1582         (TestWebKitAPI::TEST):
1583         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1584         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1585         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1586         (TestWebKitAPI::TEST):
1587         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1588         (TestWebKitAPI::TEST):
1589         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1590         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1591         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1592         (TestWebKitAPI::TEST):
1593         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1594         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1595         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1596         (TestWebKitAPI::TEST):
1597         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1598         (TestWebKitAPI::TEST):
1599         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1600         (TestWebKitAPI::TEST):
1601         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1602         (TestWebKitAPI::TEST):
1603         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1604         (TestWebKitAPI::TEST):
1605         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1606         (TestWebKitAPI::TEST):
1607         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1608         (TestWebKitAPI::TEST):
1609         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1610         (TestWebKitAPI::TEST):
1611         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1612         (TestWebKitAPI::TEST):
1613         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1614         (TestWebKitAPI::TEST):
1615         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1616         (TestWebKitAPI::TEST):
1617         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1618         (TestWebKitAPI::TEST):
1619         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1620         (TestWebKitAPI::TEST):
1621         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1622         (TestWebKitAPI::TEST):
1623         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1624         (TestWebKitAPI::TEST):
1625         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1626         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1627         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1628         (TestWebKitAPI::TEST):
1629         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1630         (TestWebKitAPI::TEST):
1631         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1632         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1633         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1634         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1635         (TestWebKitAPI::TEST):
1636         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1637         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1638         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1639         (TestWebKitAPI::TEST):
1640         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1641         (TestWebKitAPI::TEST):
1642         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1643         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1644         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1645         (TestWebKitAPI::TEST):
1646         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1647         (TestWebKitAPI::loadAlternateHTMLString):
1648         (TestWebKitAPI::TEST):
1649         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1650         (TestWebKitAPI::TEST):
1651         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1652         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1653         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1654         (TestWebKitAPI::buildAndPerformTest):
1655         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1656         (TestWebKitAPI::TEST):
1657         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1658         (TestWebKitAPI::TEST):
1659         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1660         (TestWebKitAPI::TEST):
1661         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1662         (TestWebKitAPI::TEST):
1663         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1664         (TestWebKitAPI::TEST):
1665         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1666         (TestWebKitAPI::TEST):
1667         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1668         (TestWebKitAPI::TEST):
1669         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1670         (TestWebKitAPI::TEST):
1671         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1672         (TestWebKitAPI::TEST):
1673         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1674         (TestWebKitAPI::TEST):
1675         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1676         (TestWebKitAPI::TEST):
1677         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1678         (TestWebKitAPI::TEST):
1679         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1680         (TestWebKitAPI::TEST):
1681         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1682         (TestWebKitAPI::TEST):
1683         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1684         (TestWebKitAPI::TEST):
1685         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1686         (TestWebKitAPI::TEST):
1687         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1688         (TestWebKitAPI::TEST):
1689         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1690         (TestWebKitAPI::TEST):
1691         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1692         (TestWebKitAPI::TEST):
1693         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1694         (TestWebKitAPI::TEST):
1695         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1696         (TestWebKitAPI::TEST):
1697         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1698         (TestWebKitAPI::TEST):
1699         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1700         (TestWebKitAPI::TEST):
1701         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1702         (TestWebKitAPI::TEST):
1703         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1704         (TestWebKitAPI::TEST):
1705         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1706         (TestWebKitAPI::TEST):
1707         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1708         (TestWebKitAPI::TEST):
1709         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1710         (TestWebKitAPI::TEST):
1711         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1712         (TestWebKitAPI::TEST):
1713         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1714         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1715         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1716         (TestWebKitAPI::TEST):
1717         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1718         (TestWebKitAPI::TEST):
1719         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1720         (TestWebKitAPI::TEST):
1721         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1722         (TestWebKitAPI::TEST):
1723         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1724         (TestWebKitAPI::TEST):
1725         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1726         (TestWebKitAPI::TEST):
1727         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1728         (TestWebKitAPI::TEST):
1729         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1730         (TestWebKitAPI::TEST):
1731         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1732         (TestWebKitAPI::TEST):
1733         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1734         (TestWebKitAPI::TEST):
1735         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1736         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1737         (TEST):
1738         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1739         (TEST):
1740         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1741         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1742         (TEST):
1743         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1744         (TestWebKitAPI::TEST):
1745         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1746         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1747         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1748         (WTR::getMenuItemTitleCallback):
1749         (WTR::createMouseMessageBody):
1750         (WTR::EventSendingController::mouseDown):
1751         (WTR::EventSendingController::mouseUp):
1752         (WTR::EventSendingController::mouseMoveTo):
1753         (WTR::EventSendingController::mouseForceClick):
1754         (WTR::EventSendingController::startAndCancelMouseForceClick):
1755         (WTR::EventSendingController::mouseForceDown):
1756         (WTR::EventSendingController::mouseForceUp):
1757         (WTR::EventSendingController::mouseForceChanged):
1758         (WTR::EventSendingController::leapForward):
1759         (WTR::EventSendingController::scheduleAsynchronousClick):
1760         (WTR::createKeyDownMessageBody):
1761         (WTR::EventSendingController::keyDown):
1762         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1763         (WTR::EventSendingController::mouseScrollBy):
1764         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1765         (WTR::EventSendingController::continuousMouseScrollBy):
1766         (WTR::EventSendingController::addTouchPoint):
1767         (WTR::EventSendingController::updateTouchPoint):
1768         (WTR::EventSendingController::setTouchModifier):
1769         (WTR::EventSendingController::setTouchPointRadius):
1770         (WTR::EventSendingController::touchStart):
1771         (WTR::EventSendingController::touchMove):
1772         (WTR::EventSendingController::touchEnd):
1773         (WTR::EventSendingController::touchCancel):
1774         (WTR::EventSendingController::clearTouchPoints):
1775         (WTR::EventSendingController::releaseTouchPoint):
1776         (WTR::EventSendingController::cancelTouchPoint):
1777         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1778         (WTR::InjectedBundle::didCreatePage):
1779         (WTR::InjectedBundle::didReceiveMessage):
1780         (WTR::InjectedBundle::didReceiveMessageToPage):
1781         (WTR::InjectedBundle::booleanForKey):
1782         (WTR::InjectedBundle::done):
1783         (WTR::InjectedBundle::dumpToStdErr):
1784         (WTR::InjectedBundle::outputText):
1785         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1786         (WTR::InjectedBundle::postAddChromeInputField):
1787         (WTR::InjectedBundle::postRemoveChromeInputField):
1788         (WTR::InjectedBundle::postFocusWebView):
1789         (WTR::InjectedBundle::postSetBackingScaleFactor):
1790         (WTR::InjectedBundle::postSetWindowIsKey):
1791         (WTR::InjectedBundle::postSetViewSize):
1792         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1793         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1794         (WTR::InjectedBundle::setGeolocationPermission):
1795         (WTR::InjectedBundle::setMockGeolocationPosition):
1796         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1797         (WTR::InjectedBundle::isGeolocationProviderActive const):
1798         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1799         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1800         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1801         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1802         (WTR::InjectedBundle::setCustomPolicyDelegate):
1803         (WTR::InjectedBundle::setHidden):
1804         (WTR::InjectedBundle::setCacheModel):
1805         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1806         (WTR::InjectedBundle::processWorkQueue):
1807         (WTR::InjectedBundle::queueBackNavigation):
1808         (WTR::InjectedBundle::queueForwardNavigation):
1809         (WTR::InjectedBundle::queueLoad):
1810         (WTR::InjectedBundle::queueLoadHTMLString):
1811         (WTR::InjectedBundle::queueReload):
1812         (WTR::InjectedBundle::queueLoadingScript):
1813         (WTR::InjectedBundle::queueNonLoadingScript):
1814         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1815         (WTR::frameToStr):
1816         (WTR::InjectedBundlePage::InjectedBundlePage):
1817         (WTR::dumpFrameDescriptionSuitableForTestResult):
1818         (WTR::dumpFrameScrollPosition):
1819         (WTR::dumpDescendantFrameScrollPositions):
1820         (WTR::dumpFrameText):
1821         (WTR::dumpDescendantFramesText):
1822         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1823         (WTR::TestRunner::shouldDumpPixels const):
1824         (WTR::TestRunner::setDumpPixels):
1825         (WTR::TestRunner::whatToDump const):
1826         (WTR::TestRunner::setWhatToDump):
1827         (WTR::TestRunner::setWaitUntilDone):
1828         (WTR::TestRunner::shouldWaitUntilDone const):
1829         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1830         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1831         (WTR::TestRunner::clearAllDatabases):
1832         (WTR::TestRunner::setIDBPerOriginQuota):
1833         (WTR::TestRunner::originsWithApplicationCache):
1834         (WTR::TestRunner::setCanOpenWindows):
1835         (WTR::TestRunner::setXSSAuditorEnabled):
1836         (WTR::TestRunner::setMediaDevicesEnabled):
1837         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1838         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1839         (WTR::TestRunner::setCustomUserAgent):
1840         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1841         (WTR::TestRunner::setModernMediaControlsEnabled):
1842         (WTR::TestRunner::setWebGL2Enabled):
1843         (WTR::TestRunner::setWritableStreamAPIEnabled):
1844         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1845         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1846         (WTR::TestRunner::setAllowsAnySSLCertificate):
1847         (WTR::TestRunner::setPluginsEnabled):
1848         (WTR::TestRunner::setValueForUser):
1849         (WTR::TestRunner::setAudioResult):
1850         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1851         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1852         (WTR::TestRunner::setAlwaysAcceptCookies):
1853         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1854         (WTR::TestRunner::isDoingMediaCapture const):
1855         (WTR::TestRunner::queueLoad):
1856         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1857         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1858         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1859         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1860         (WTR::TestRunner::setAuthenticationUsername):
1861         (WTR::TestRunner::setAuthenticationPassword):
1862         (WTR::TestRunner::secureEventInputIsEnabled const):
1863         (WTR::TestRunner::setBlockAllPlugins):
1864         (WTR::TestRunner::setPluginSupportedMode):
1865         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1866         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1867         (WTR::TestRunner::setNavigationGesturesEnabled):
1868         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1869         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1870         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1871         (WTR::TestRunner::terminateNetworkProcess):
1872         (WTR::TestRunner::terminateServiceWorkerProcess):
1873         (WTR::TestRunner::runUIScript):
1874         (WTR::TestRunner::setStatisticsDebugMode):
1875         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1876         (WTR::TestRunner::setStatisticsLastSeen):
1877         (WTR::TestRunner::setStatisticsPrevalentResource):
1878         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1879         (WTR::TestRunner::dumpResourceLoadStatistics):
1880         (WTR::TestRunner::isStatisticsPrevalentResource):
1881         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1882         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1883         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1884         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1885         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1886         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1887         (WTR::TestRunner::setStatisticsGrandfathered):
1888         (WTR::TestRunner::isStatisticsGrandfathered):
1889         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1890         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1891         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1892         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1893         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1894         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1895         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1896         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1897         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1898         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1899         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1900         (WTR::TestRunner::statisticsSubmitTelemetry):
1901         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1902         (WTR::TestRunner::setStatisticsIsRunningTest):
1903         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1904         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1905         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1906         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1907         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1908         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1909         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1910         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1911         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1912         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1913         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1914         (WTR::TestRunner::statisticsResetToConsistentState):
1915         (WTR::TestRunner::setStorageAccessAPIEnabled):
1916         (WTR::TestRunner::getAllStorageAccessEntries):
1917         (WTR::TestRunner::addMockMediaDevice):
1918         (WTR::TestRunner::clearMockMediaDevices):
1919         (WTR::TestRunner::removeMockMediaDevice):
1920         (WTR::TestRunner::resetMockMediaDevices):
1921         (WTR::TestRunner::connectMockGamepad):
1922         (WTR::TestRunner::disconnectMockGamepad):
1923         (WTR::TestRunner::setMockGamepadDetails):
1924         (WTR::TestRunner::setMockGamepadAxisValue):
1925         (WTR::TestRunner::setMockGamepadButtonValue):
1926         (WTR::TestRunner::removeAllSessionCredentials):
1927         (WTR::TestRunner::clearDOMCache):
1928         (WTR::TestRunner::clearDOMCaches):
1929         (WTR::TestRunner::hasDOMCache):
1930         (WTR::TestRunner::domCacheSize):
1931         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1932         (WTR::TestRunner::getApplicationManifestThen):
1933         (WTR::TestRunner::injectUserScript):
1934         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1935         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1936         (WTR::TestRunner::addTestKeyToKeychain):
1937         (WTR::TestRunner::cleanUpKeychain):
1938         (WTR::TestRunner::keyExistsInKeychain):
1939         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1940         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1941         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1942         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1943         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1944         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1945         * WebKitTestRunner/TestController.cpp:
1946         (WTR::TestController::initialize):
1947         (WTR::parseStringTestHeaderValueAsRelativePath):
1948         (WTR::updateTestOptionsFromTestHeader):
1949         (WTR::TestController::runTest):
1950         (WTR::TestController::didReceiveLiveDocumentsList):
1951         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1952         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1953         (WTR::TestController::didFinishNavigation):
1954         (WTR::TestController::didReceiveAuthenticationChallenge):
1955         * WebKitTestRunner/TestInvocation.cpp:
1956         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1957         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1958         (WTR::TestInvocation::uiScriptDidComplete):
1959         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1960         * WebKitTestRunner/WebNotificationProvider.cpp:
1961         (WTR::WebNotificationProvider::closeWebNotification):
1962         * WebKitTestRunner/WorkQueueManager.cpp:
1963         (WTR::ScriptItem::ScriptItem):
1964         (WTR::WorkQueueManager::queueLoad):
1965         (WTR::WorkQueueManager::queueLoadHTMLString):
1966
1967 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1968
1969         Add a comment to make my test from r244139 less mysterious.
1970         https://bugs.webkit.org/show_bug.cgi?id=196744
1971
1972         As suggested by Darin Adler.
1973
1974         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1975         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1976
1977 2019-04-17  Chris Dumez  <cdumez@apple.com>
1978
1979         Remember device orientation permission for the duration of the browsing session
1980         https://bugs.webkit.org/show_bug.cgi?id=196992
1981         <rdar://problem/49946067>
1982
1983         Reviewed by Alex Christensen.
1984
1985         Add API test coverage.
1986
1987         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1988         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1989         (TEST):
1990
1991 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1992
1993         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1994         https://bugs.webkit.org/show_bug.cgi?id=196675
1995
1996         Reviewed by Lucas Forschler.
1997
1998         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1999         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2000
2001 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2002
2003         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2004         https://bugs.webkit.org/show_bug.cgi?id=196919
2005         <rdar://problem/41630459>
2006
2007         Reviewed by Tim Horton.
2008
2009         Add iOS support for several new testing hooks. See below for more detail.
2010
2011         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2012         (WTR::UIScriptController::isDismissingMenu const):
2013
2014         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2015         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2016         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2017
2018         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2019         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2020         (WTR::UIScriptController::isDismissingMenu const):
2021         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2022         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2023         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2024         (WTR::InjectedBundle::didReceiveMessageToPage):
2025         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2026         (WTR::TestRunner::setAllowedMenuActions):
2027
2028         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2029         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2030         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2031         against the name of the custom action.
2032
2033         (WTR::TestRunner::installCustomMenuAction):
2034
2035         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2036         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2037         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2038         triggered.
2039
2040         (WTR::TestRunner::performCustomMenuAction):
2041
2042         Invoked when the custom menu action is triggered.
2043
2044         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2045         * WebKitTestRunner/TestController.cpp:
2046         (WTR::TestController::installCustomMenuAction):
2047         (WTR::TestController::setAllowedMenuActions):
2048         * WebKitTestRunner/TestController.h:
2049         * WebKitTestRunner/TestInvocation.cpp:
2050         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2051         (WTR::TestInvocation::performCustomMenuAction):
2052
2053         Add plumbing to call back into the injected bundle when performing the custom action.
2054
2055         * WebKitTestRunner/TestInvocation.h:
2056         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2057         (WTR::TestController::installCustomMenuAction):
2058         (WTR::TestController::setAllowedMenuActions):
2059         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2060         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2061         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2062         (-[TestRunnerWKWebView becomeFirstResponder]):
2063         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2064
2065         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2066         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2067         in the Mail app on iOS.
2068
2069         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2070         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2071         (-[TestRunnerWKWebView resetCustomMenuAction]):
2072         (-[TestRunnerWKWebView performCustomAction:]):
2073         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2074         (-[TestRunnerWKWebView _willHideMenu]):
2075         (-[TestRunnerWKWebView _didHideMenu]):
2076         * WebKitTestRunner/ios/TestControllerIOS.mm:
2077         (WTR::TestController::platformResetStateToConsistentValues):
2078
2079         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2080         if specified.
2081
2082         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2083         (WTR::UIScriptController::isDismissingMenu const):
2084
2085 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2086
2087         Allow sharing from imageSheet on an image document
2088         https://bugs.webkit.org/show_bug.cgi?id=196891
2089         <rdar://problem/25377386>
2090
2091         Reviewed by Tim Horton.
2092
2093         Test to make sure that the correct imageURL is extracted from an image element.
2094
2095         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2096         (TestWebKitAPI::TEST):
2097
2098 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2099
2100         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2101         https://bugs.webkit.org/show_bug.cgi?id=196995
2102
2103         Reviewed by Brady Eidson.
2104
2105         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2106         (TEST):
2107
2108 2019-04-16  Chris Dumez  <cdumez@apple.com>
2109
2110         URL set by document.open() is not communicated to the UIProcess
2111         https://bugs.webkit.org/show_bug.cgi?id=196941
2112         <rdar://problem/49237544>
2113
2114         Reviewed by Geoff Garen.
2115
2116         Add API test coverage.
2117
2118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2119         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2120         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2121         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2122         (TEST):
2123
2124 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2125
2126         Unreviewed, rolling out r244321.
2127         https://bugs.webkit.org/show_bug.cgi?id=196968
2128
2129         Causing all WK2 Debug builds to exit early after Assertion
2130         failures. (Requested by ShawnRoberts on #webkit).
2131
2132         Reverted changeset:
2133
2134         "URL set by document.open() is not communicated to the
2135         UIProcess"
2136         https://bugs.webkit.org/show_bug.cgi?id=196941
2137         https://trac.webkit.org/changeset/244321
2138
2139 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2140
2141         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2142         https://bugs.webkit.org/show_bug.cgi?id=196948
2143
2144         Reviewed by Zalan Bujtas.
2145
2146         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2147         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2148
2149 2019-04-15  Chris Dumez  <cdumez@apple.com>
2150
2151         URL set by document.open() is not communicated to the UIProcess
2152         https://bugs.webkit.org/show_bug.cgi?id=196941
2153         <rdar://problem/49237544>
2154
2155         Reviewed by Geoffrey Garen.
2156
2157         Add API test coverage.
2158
2159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2160         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2161         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2162         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2163         (TEST):
2164
2165 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2166
2167         Using Tools/Scripts/clean-webkit should not install requests
2168         https://bugs.webkit.org/show_bug.cgi?id=196940
2169
2170         Reviewed by Lucas Forschler.
2171
2172         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2173         existing, depending on the path autoinstalled is run through.
2174         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2175         needed.
2176         (Port.configuration_for_upload):
2177         (Port.commits_for_upload):
2178
2179 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2180
2181         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2182         https://bugs.webkit.org/show_bug.cgi?id=196773
2183
2184         Reviewed by Jer Noble.
2185
2186         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2187         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2188         (TEST):
2189
2190 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2191
2192         ews-build should clearly indicate flaky test failures
2193         https://bugs.webkit.org/show_bug.cgi?id=196947
2194
2195         Reviewed by Lucas Forschler.
2196
2197         * BuildSlaveSupport/ews-build/steps.py:
2198         (AnalyzeAPITestsResults.analyzeResults):
2199
2200 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2201
2202         InjectedBundle parameters often need initialization function called before unarchiving
2203         https://bugs.webkit.org/show_bug.cgi?id=189709
2204         <rdar://problem/44573653>
2205
2206         Reviewed by Ryosuke Niwa.
2207
2208         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2209         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2210
2211 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2212
2213         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2214         https://bugs.webkit.org/show_bug.cgi?id=196681
2215
2216         Reviewed by Darin Adler.
2217
2218         Added tests.
2219
2220         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2221         (WTF_HashSet.RemoveIf):
2222         (WTF_HashSet.RemoveIfShrinkToBestSize):
2223
2224 2019-04-15  John Wilander  <wilander@apple.com>
2225
2226         Send delayed Ad Click Attribution conversion requests to the click source
2227         https://bugs.webkit.org/show_bug.cgi?id=196838
2228         <rdar://problem/47650157>
2229
2230         Reviewed by Chris Dumez and Youenn Fablet.
2231
2232         This patch adds test infrastructure to override the default behavior in
2233         WebKit::NetworkAdClickAttribution.
2234
2235         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2236         (TestWebKitAPI::TEST):
2237         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2238         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2239         (WTR::TestRunner::dumpAdClickAttribution):
2240         (WTR::TestRunner::clearAdClickAttribution):
2241         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2242         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2243         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2244         * WebKitTestRunner/TestController.cpp:
2245         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2246         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2247         * WebKitTestRunner/TestController.h:
2248         * WebKitTestRunner/TestInvocation.cpp:
2249         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2250
2251 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2252
2253         [ews-app] status-bubble should display position in queue
2254         https://bugs.webkit.org/show_bug.cgi?id=196607
2255
2256         Reviewed by Lucas Forschler.
2257
2258         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2259         (StatusBubble._build_bubble):
2260         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2261
2262 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2263
2264         [ews-build] Do not run clean build by default on EWS builders
2265         https://bugs.webkit.org/show_bug.cgi?id=196897
2266
2267         Reviewed by Lucas Forschler.
2268
2269         * BuildSlaveSupport/ews-build/steps.py:
2270         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2271         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2272         untracked directories like WebKitBuild).
2273         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2274         untracked files/directories (like WebKitBuild).
2275
2276 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2277
2278         TestRunner::notifyDone() should be safely reentrant
2279         https://bugs.webkit.org/show_bug.cgi?id=196898
2280
2281         Reviewed by Darin Adler.
2282
2283         It is currently possible that TestRunner::notifyDone() will call itself, since
2284         notifyDone() will force a repaint, which can start executing JavaScript, which
2285         may call notifyDone() again. This can lead to test failures and flakiness.
2286         Fix this by setting the m_waitToDump flag before calling the dump() method.
2287
2288         * DumpRenderTree/mac/TestRunnerMac.mm:
2289         (TestRunner::notifyDone):
2290         (TestRunner::forceImmediateCompletion):
2291         * DumpRenderTree/win/TestRunnerWin.cpp:
2292         (TestRunner::notifyDone):
2293         (TestRunner::forceImmediateCompletion):
2294
2295 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2296
2297         [GTK][WPE] Add enable-media websetting
2298         https://bugs.webkit.org/show_bug.cgi?id=196863
2299
2300         Reviewed by Michael Catanzaro.
2301
2302         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2303         (testWebKitSettings): Add test for the enable-media web-setting.
2304
2305 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2306
2307         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2308         https://bugs.webkit.org/show_bug.cgi?id=196905
2309         <rdar://problem/49886096>
2310
2311         Reviewed by Tim Horton.
2312
2313         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2314         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2315         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2316         delay timer, we end up with this sequence of events in the problematic (failure) case:
2317
2318         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2319             ...IPC from UI to web process...
2320         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2321             ...IPC from web to UI process...
2322         (c) [UI]    Invoke completion handler for script #1
2323         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2324             ...IPC from UI to web process...
2325         (e) [Web]   Evaluate script #2 in the web process
2326         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2327
2328         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2329         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2330         #2 is run in step (e).
2331
2332         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2333         the UI process by waiting on a script message posted by the web process, after attachment updates are
2334         dispatched.
2335
2336         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2337         (TestWebKitAPI::TEST):
2338
2339 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2340
2341         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2342         https://bugs.webkit.org/show_bug.cgi?id=196909
2343
2344         Reviewed by Wenson Hsieh.
2345
2346         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2347         (TestWebKitAPI::TEST):
2348
2349 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2350
2351         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2352         https://bugs.webkit.org/show_bug.cgi?id=196880
2353
2354         Reviewed by Yusuke Suzuki.
2355
2356         Add a new function for bytecode cache tests that does not forceDiskCache
2357         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2358         test added in this patch, since the code is invalid and therefore won't be
2359         cached. It should also be useful for tests that evaluate dynamically
2360         generated code.
2361
2362         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2363         * Scripts/run-jsc-stress-tests:
2364
2365 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2366
2367         Update AudioSession route sharing policy
2368         https://bugs.webkit.org/show_bug.cgi?id=196776
2369         <rdar://problem/46501611>
2370
2371         Reviewed by Jer Noble.
2372
2373         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2374         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2375         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2376         (TestWebKitAPI::TEST):
2377
2378 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2379
2380         [iOS] Software keyboard is shown too frequently on some websites
2381         https://bugs.webkit.org/show_bug.cgi?id=195856
2382         <rdar://problem/49191395>
2383
2384         Reviewed by Darin Adler.
2385
2386         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2387
2388         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2389         (WTR::UIScriptController::setHardwareKeyboardAttached):
2390         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2391         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2392         (WTR::UIScriptController::setHardwareKeyboardAttached):
2393         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2394         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2395
2396         Additionally link against GraphicsServices in WebKitTestRunner.
2397
2398         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2399         (WTR::TestController::platformResetStateToConsistentValues):
2400         (WTR::UIScriptController::setHardwareKeyboardAttached):
2401
2402 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2403
2404         [GTK][WPE] Fix pacman install-dependencies packages
2405         https://bugs.webkit.org/show_bug.cgi?id=196817
2406
2407         Reviewed by Žan Doberšek.
2408         
2409         python3-setuptools is called python-setuptools
2410         ruby-highline is only available on AUR
2411         libv4l-devel is incorporated in v4l-utils
2412
2413         * gtk/install-dependencies:
2414         * wpe/install-dependencies:
2415
2416 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2417
2418         [GTK] REGRESSION(r243860): Many tests failing
2419         https://bugs.webkit.org/show_bug.cgi?id=196791
2420
2421         Reviewed by Joanmarie Diggs.
2422
2423         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2424         multiple documents and check that accessibility hierarchy is updated after a navigation.
2425
2426         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2427         (loadChangedCallback):
2428         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2429         (AccessibilityTest::AccessibilityTest):
2430         (AccessibilityTest::~AccessibilityTest):
2431         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2432         (AccessibilityTest::findTestServerApplication):
2433         (AccessibilityTest::findDocumentWeb):
2434         (AccessibilityTest::findRootObject):
2435         (AccessibilityTest::waitUntilChildrenRemoved):
2436         (AccessibilityTest::ensureProxy):
2437         (testAtspiBasicHierarchy):
2438         (beforeAll):
2439         (afterAll):
2440
2441 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2442
2443         [ews-build] Handle bug titles with unicode characters
2444         https://bugs.webkit.org/show_bug.cgi?id=196802
2445
2446         Reviewed by Dewei Zhu.
2447
2448         * BuildSlaveSupport/ews-build/steps.py:
2449         (ValidatePatch._is_bug_closed):
2450
2451 2019-04-11  Michael Saboff  <msaboff@apple.com>
2452
2453         Improve the Inline Cache Stats code
2454         https://bugs.webkit.org/show_bug.cgi?id=196836
2455
2456         Reviewed by Saam Barati.
2457
2458         Added a new script to consolidate and arrange the output of --useICStats option.
2459
2460         This script merges the output from every group into one large table and sorts it from most common to
2461         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2462         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2463         Put together, this is useful to see what property accesses are not getting cached.
2464
2465         * Scripts/ic-stats.py: Added.
2466         (ICStats):
2467         (ICStats.__init__):
2468         (ICStats.parse):
2469         (ICStats.dumpStats):
2470         (usage):
2471
2472 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2473
2474         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2475         https://bugs.webkit.org/show_bug.cgi?id=196809
2476         <rdar://49800762>
2477
2478         Reviewed by Brady Eidson.
2479
2480         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2481         (TEST):
2482
2483 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2484
2485         requestAnimationFrame should execute before the next frame
2486         https://bugs.webkit.org/show_bug.cgi?id=177484
2487
2488         Reviewed by Simon Fraser.
2489
2490         Add trace points for the page RenderingUpdate.
2491
2492         * Tracing/SystemTracePoints.plist:
2493
2494 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2495
2496         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2497         https://bugs.webkit.org/show_bug.cgi?id=196760
2498
2499         Reviewed by Don Olmstead.
2500
2501         vswhere.exe has been bundled since Visual Studio 2017 version
2502         15.2. We shouldn't download vswhere.exe.
2503
2504         * Scripts/build-jsc: Do not call update-vswhere.py.
2505         * Scripts/build-webkit: Ditto.
2506         * Scripts/update-vswhere.py: Removed.
2507         * Scripts/webkitdirs.pm:
2508         (requireModulesForVSWhere): Deleted.
2509         (pickCurrentVisualStudioInstallation): Deleted.
2510         (visualStudioInstallDirVSWhere): Return the latest installed VS
2511         installation path by using the bundled vswhere.exe.
2512         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2513         (visualStudioInstallDirFallback): Removed.
2514
2515 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2516
2517         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2518         https://bugs.webkit.org/show_bug.cgi?id=196780
2519
2520         Reviewed by Alexey Proskuryakov.
2521
2522         * BuildSlaveSupport/ews-build/steps.py:
2523         * BuildSlaveSupport/ews-build/steps_unittest.py:
2524
2525 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2526
2527         Add SPI WKNavigationResponse._downloadAttribute
2528         https://bugs.webkit.org/show_bug.cgi?id=196755
2529         <rdar://49587365>
2530
2531         Reviewed by Brady Eidson.
2532
2533         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2534         (-[NavigationResponseTestDelegate navigationResponse]):
2535         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2536         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2537         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2538         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2539         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2540         (readRequest):
2541         (writeResponse):
2542         (TEST):
2543
2544 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2545
2546         Add modern API for overriding the page's specified viewport configuration
2547         https://bugs.webkit.org/show_bug.cgi?id=167734
2548         <rdar://problem/30331795>
2549
2550         Reviewed by Simon Fraser.
2551
2552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2553         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2554
2555 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2556
2557         Add support for incremental bytecode cache updates
2558         https://bugs.webkit.org/show_bug.cgi?id=195000
2559
2560         Reviewed by Filip Pizlo.
2561
2562         Exit when the initial run to generate bytecode fails.
2563
2564         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2565
2566 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2567
2568         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2569         https://bugs.webkit.org/show_bug.cgi?id=196744
2570         <rdar://49415309>
2571
2572         Reviewed by Chris Dumez.
2573
2574         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2575         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2576
2577 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2578
2579         Add a way to opt into modern compatibility mode in layout tests
2580         https://bugs.webkit.org/show_bug.cgi?id=196770
2581         <rdar://problem/49777550>
2582
2583         Reviewed by Antoine Quint.
2584
2585         Add a new test option to enable modern compatibility mode in layout tests.
2586
2587         * WebKitTestRunner/TestController.cpp:
2588         (WTR::updateTestOptionsFromTestHeader):
2589         * WebKitTestRunner/TestController.h:
2590         * WebKitTestRunner/TestOptions.h:
2591         (WTR::TestOptions::hasSameInitializationOptions const):
2592         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2593         (WTR::TestController::platformCreateWebView):
2594         (WTR::TestController::enableModernCompatibilityMode):
2595
2596 2019-04-10  Andy Estes  <aestes@apple.com>
2597
2598         Try to fix the 32-bit watchOS build.
2599
2600         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2601         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2602
2603 2019-04-10  Antoine Quint  <graouts@apple.com>
2604
2605         Enable Pointer Events on watchOS
2606         https://bugs.webkit.org/show_bug.cgi?id=196771
2607         <rdar://problem/49040909>
2608
2609         Reviewed by Dean Jackson.
2610
2611         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2612
2613 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2614
2615         Unreviewed. Fix WPE accessibility tests after r244059.
2616
2617         We are failing to load the injected bundle due to undefined symbol
2618         AccessibilityUIElement::replaceTextInRange().
2619
2620         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2621         (WTR::AccessibilityUIElement::replaceTextInRange):
2622
2623 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2624
2625         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2626         https://bugs.webkit.org/show_bug.cgi?id=196727
2627
2628         Reviewed by Fujii Hironori.
2629
2630         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2631         (WebKitBrowserWindow::create):
2632
2633 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2634
2635         [ews-build] Add unit tests for PrintConfiguration
2636         https://bugs.webkit.org/show_bug.cgi?id=196752
2637
2638         Reviewed by Dewei Zhu.
2639
2640         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2641
2642 2019-04-09  Keith Rollin  <krollin@apple.com>
2643
2644         Unreviewed build maintenance -- update .xcfilelists.
2645
2646         * DumpRenderTree/DerivedSources-input.xcfilelist:
2647         * DumpRenderTree/DerivedSources-output.xcfilelist:
2648
2649 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2650
2651         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2652         https://bugs.webkit.org/show_bug.cgi?id=196743
2653         <rdar://problem/43897551>
2654
2655         Reviewed by Tim Horton.
2656
2657         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2658         (TEST):
2659
2660 2019-04-09  Youenn Fablet  <youenn@apple.com>
2661
2662         Close service worker database on network process suspension
2663         https://bugs.webkit.org/show_bug.cgi?id=196623
2664         <rdar://problem/48930869>
2665
2666         Reviewed by Alex Christensen.
2667
2668         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2669
2670 2019-04-09  Daniel Bates  <dabates@apple.com>
2671
2672         [iPad] Should open popover when the spacebar is pressed
2673         https://bugs.webkit.org/show_bug.cgi?id=196360
2674         <rdar://problem/49389129>
2675
2676         Reviewed by Brent Fulgham.
2677
2678         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2679
2680         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2681         (WTR::UIScriptController::isShowingPopover const): Added.
2682         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2683         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2684         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2685         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2686         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2687         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2688         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2689         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2690         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2691         (WTR::UIScriptController::isShowingPopover const): Added.
2692         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2693         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2694         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2695         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2696         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2697         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2698         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2699         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2700         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2701         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2702         (WTR::UIScriptController::isShowingPopover const): Added.
2703         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2704         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2705
2706 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2707
2708         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2709         https://bugs.webkit.org/show_bug.cgi?id=196665
2710         <rdar://45115669>
2711
2712         Reviewed by Geoff Garen.
2713
2714         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2715         (goBack):
2716         (+[SimpleLookupContext sharedLookupContext]):
2717         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2718         (TEST):
2719         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2720         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2721
2722 2019-04-09  John Wilander  <wilander@apple.com>
2723
2724         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2725         https://bugs.webkit.org/show_bug.cgi?id=196558
2726         <rdar://problem/47650245>
2727
2728         Reviewed by Youenn Fablet.
2729
2730         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2731         (TestWebKitAPI::TEST):
2732             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2733
2734 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2735
2736         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2737         https://bugs.webkit.org/show_bug.cgi?id=196720
2738
2739         Reviewed by Konstantin Tokarev.
2740
2741         * TestWebKitAPI/PlatformMac.cmake:
2742
2743 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2744
2745         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2746         https://bugs.webkit.org/show_bug.cgi?id=196694
2747         <rdar://problem/48388734>
2748
2749         Rubber-stamped by Aakash Jain.
2750
2751         * Scripts/webkitpy/port/image_diff.py:
2752         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2753         * Scripts/webkitpy/port/server_process.py:
2754         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2755         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2756         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2757         * Scripts/webkitpy/port/server_process_mock.py:
2758         (MockServerProcess.has_available_stdout):
2759         * Scripts/webkitpy/port/server_process_unittest.py:
2760         (TestServerProcess.serial_test_basic):
2761
2762 2019-04-09  Jer Noble  <jer.noble@apple.com>
2763
2764         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2765         https://bugs.webkit.org/show_bug.cgi?id=196097
2766
2767         Reviewed by Eric Carlson.
2768
2769         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2770
2771         * DumpRenderTree/mac/DumpRenderTree.mm:
2772         (resetWebPreferencesToConsistentValues):
2773         * WebKitTestRunner/TestController.cpp:
2774         (WTR::TestController::resetPreferencesToConsistentValues):
2775
2776 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2777
2778         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2779         https://bugs.webkit.org/show_bug.cgi?id=196690
2780
2781         Reviewed by Michael Catanzaro.
2782
2783         * QueueStatusServer/config/queues.py:
2784         * Scripts/webkitpy/common/config/ews.json:
2785         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2786         (test_ews_name):
2787
2788 2019-04-09  Chris Dumez  <cdumez@apple.com>
2789
2790         Loads using loadHTMLString() cause flashing when process-swapping
2791         https://bugs.webkit.org/show_bug.cgi?id=196714
2792         <rdar://problem/49637354>
2793
2794         Reviewed by Antti Koivisto.
2795
2796         Add API test coverage.
2797
2798         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2799
2800 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2801
2802         Unreviewed. Fix ATK accessibility tests after r244059.
2803
2804         We are failing to load the injected bundle due to undefined symbol
2805         AccessibilityUIElement::replaceTextInRange().
2806
2807         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2808         (WTR::AccessibilityUIElement::replaceTextInRange):
2809
2810 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2811
2812         AX: Support API: accessibilityReplaceRange:withText
2813         https://bugs.webkit.org/show_bug.cgi?id=196636
2814
2815         Unreviewed build fix for Windows port.
2816
2817         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2818         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2819
2820 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2821
2822         [CMake][WinCairo] Separate copied headers into different directories
2823         https://bugs.webkit.org/show_bug.cgi?id=196655
2824
2825         Reviewed by Michael Catanzaro.
2826
2827         * DumpRenderTree/CMakeLists.txt:
2828         * MiniBrowser/win/CMakeLists.txt:
2829         * TestWebKitAPI/CMakeLists.txt:
2830         * TestWebKitAPI/PlatformWin.cmake:
2831
2832 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2833
2834         Log stack-trace for run-webkit-tests when interrupted
2835         https://bugs.webkit.org/show_bug.cgi?id=176393
2836         <rdar://problem/34262310>
2837
2838         Reviewed by Lucas Forschler.
2839
2840         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2841         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2842         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2843         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2844         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2845         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2846         (main): Set handlers to log stack trace on interruption.
2847
2848 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2849
2850         AX: Support API: accessibilityReplaceRange:withText
2851         https://bugs.webkit.org/show_bug.cgi?id=196636
2852
2853         Unreviewed build fix for Windows port.
2854
2855         * DumpRenderTree/AccessibilityUIElement.cpp:
2856         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2857
2858 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2859
2860         [ews-build] Scripts using Buildbot API have CORS error
2861         https://bugs.webkit.org/show_bug.cgi?id=196709
2862
2863         Reviewed by Alexey Proskuryakov.
2864
2865         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2866
2867 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2868
2869         AX: Support API: accessibilityReplaceRange:withText
2870         https://bugs.webkit.org/show_bug.cgi?id=196636
2871
2872         Reviewed by Daniel Bates.
2873
2874         * DumpRenderTree/AccessibilityUIElement.cpp:
2875         (replaceTextInRangeCallback):
2876         (AccessibilityUIElement::replaceTextInRange):
2877         (AccessibilityUIElement::getJSClass):
2878         * DumpRenderTree/AccessibilityUIElement.h:
2879         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2880         (AccessibilityUIElement::replaceTextInRange):
2881         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2882         (AccessibilityUIElement::replaceTextInRange):
2883         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2884         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2885         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2886         (WTR::AccessibilityUIElement::replaceTextInRange):
2887         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2888         (WTR::AccessibilityUIElement::replaceTextInRange):
2889
2890 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2891
2892         [iOS] Do not allow starting selection drags when selection views are not visible
2893         https://bugs.webkit.org/show_bug.cgi?id=196686
2894         <rdar://problem/49399192>
2895
2896         Reviewed by Tim Horton.
2897
2898         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2899         also add some new API tests to cover scenarios where the web view is not first responder.
2900
2901         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2902         (TestWebKitAPI::TEST):
2903         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2904
2905         Add a switch to optionally make the web view first responder when starting the simulated drag.
2906
2907         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2908         (-[DragAndDropSimulator initWithWebView:]):
2909         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2910
2911 2019-04-08  Justin Fan  <justin_fan@apple.com>
2912
2913         [Web GPU] Fix Web GPU experimental feature on iOS
2914         https://bugs.webkit.org/show_bug.cgi?id=196632
2915
2916         Reviewed by Myles C. Maxfield.
2917
2918         Properly make Web GPU available on iOS 11+.
2919
2920         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2921
2922 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2923
2924         [ews-build] Do not upload archive when Compile Fails
2925         https://bugs.webkit.org/show_bug.cgi?id=196674
2926
2927         Reviewed by Alexey Proskuryakov.
2928
2929         * BuildSlaveSupport/ews-build/factories.py:
2930         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2931         * BuildSlaveSupport/ews-build/steps.py:
2932         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2933         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2934         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2935
2936 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2937
2938         Enable DFG on MIPS
2939         https://bugs.webkit.org/show_bug.cgi?id=196689
2940
2941         Reviewed by Žan Doberšek.
2942
2943         Since the bytecode change, we enabled the baseline JIT on mips in
2944         r240432, but DFG is still missing. With this change, all tests are
2945         passing on a ci20 board.
2946
2947         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2948
2949 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2950
2951         [Flatpak] Second run update-webkitwpe-flatpak fails
2952         https://bugs.webkit.org/show_bug.cgi?id=192702
2953
2954         Reviewed by Carlos Garcia Campos.
2955
2956         * flatpak/flatpakutils.py:
2957         (FlatpakObject.flatpak): Fix typo.
2958         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2959         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2960
2961 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2962
2963         [GTK][WPE] outlook.live.com displays old-fashioned UI
2964         https://bugs.webkit.org/show_bug.cgi?id=196642
2965
2966         Reviewed by Carlos Garcia Campos.
2967
2968         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2969         (TestWebKitAPI::TEST): New Mac platform quirk test.
2970
2971 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2972
2973         Unreviewed, rolling out r243956.
2974         https://bugs.webkit.org/show_bug.cgi?id=196688
2975
2976         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2977         by aakashjain on #webkit).
2978
2979         Reverted changeset:
2980
2981         "Clicking "Go Back" from a safe browsing warning from an
2982         iframe should navigate the WKWebView back to the previous
2983         page"
2984         https://bugs.webkit.org/show_bug.cgi?id=196665
2985         https://trac.webkit.org/changeset/243956
2986
2987 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2988
2989         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2990         https://bugs.webkit.org/show_bug.cgi?id=196669
2991
2992         Reviewed by Geoffrey Garen.
2993
2994         Added three new unit tests for WeakHashSet.
2995
2996         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2997         (WTF_WeakPtr.WeakHashSetConstObjects):
2998         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2999         (WTF_WeakPtr.WeakHashSetComputeSize):
3000
3001 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3002
3003         Hide next and previous form control buttons when WKWebView is editable
3004         https://bugs.webkit.org/show_bug.cgi?id=196672
3005         <rdar://problem/35625321>
3006
3007         Reviewed by Tim Horton.
3008
3009         Add a new API test.
3010
3011         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3012         (-[TestWKWebView lastTrailingBarButtonGroup]):
3013         (TestWebKitAPI::TEST):
3014         * TestWebKitAPI/ios/UIKitSPI.h:
3015
3016 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3017
3018         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3019         https://bugs.webkit.org/show_bug.cgi?id=196077
3020         <rdar://problem/49108202>
3021
3022         Reviewed by Chris Dumez.
3023
3024         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3025         on new web view.
3026
3027         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3028
3029 2019-04-05  Saam Barati  <sbarati@apple.com>
3030
3031         Make compare-results understand MotionMark
3032         https://bugs.webkit.org/show_bug.cgi?id=196666
3033
3034         Reviewed by Yusuke Suzuki.
3035
3036         * Scripts/compare-results:
3037         (PLT5Results):
3038         (detectMotionMark):
3039         (detectMotionMark1_1):
3040         (motionMarkResults):
3041         (motionMark1_1Results):
3042         (detectBenchmark):
3043         (biggerIsBetter):
3044         (main):
3045
3046 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3047
3048         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3049         https://bugs.webkit.org/show_bug.cgi?id=196665
3050         <rdar://45115669>
3051
3052         Reviewed by Geoff Garen.
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3055         (goBack):
3056         (+[SimpleLookupContext sharedLookupContext]):
3057         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3058         (TEST):
3059         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3060         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3061
3062 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3063
3064         [ews-build] Add configuration and architecture for windows builders
3065         https://bugs.webkit.org/show_bug.cgi?id=196660
3066
3067         Reviewed by Lucas Forschler.
3068
3069         * BuildSlaveSupport/ews-build/config.json:
3070
3071 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3072
3073         webkitpy: Don't run subsequent rounds if interrupted
3074         https://bugs.webkit.org/show_bug.cgi?id=196646
3075
3076         Reviewed by Aakash Jain.
3077
3078         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3079         (Manager.run): Bail out if interrupted.
3080
3081 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3082
3083         Test sessionStorage in PSON private browsing mode
3084         https://bugs.webkit.org/show_bug.cgi?id=196561
3085
3086         Reviewed by Alex Christensen.
3087
3088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3089
3090 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3091
3092         Unreviewed, rolling out r243833.
3093         https://bugs.webkit.org/show_bug.cgi?id=196645
3094
3095         This change breaks build of WPE and GTK ports (Requested by
3096         annulen on #webkit).
3097
3098         Reverted changeset:
3099
3100         "[CMake][WTF] Mirror XCode header directories"
3101         https://bugs.webkit.org/show_bug.cgi?id=191662
3102         https://trac.webkit.org/changeset/243833
3103
3104 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3105
3106         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3107         https://bugs.webkit.org/show_bug.cgi?id=196635
3108
3109         Reviewed by Antti Koivisto.
3110         
3111         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3112         for a test to enable async frame scrolling via:
3113             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3114         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3115         
3116         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3117
3118         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3119         (WTR::InjectedBundle::beginTesting):
3120         * WebKitTestRunner/TestController.cpp:
3121         (WTR::TestController::resetPreferencesToConsistentValues):
3122
3123 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3124
3125         Use a correct LC_RPATH when building with ASan
3126         https://bugs.webkit.org/show_bug.cgi?id=196576
3127
3128         Reviewed by David Kilzer.
3129
3130         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3131         so that ../Frameworks is checked. This is simpler and more reliable than updating
3132         each SPC service xcconfig.
3133
3134 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3135
3136         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3137         https://bugs.webkit.org/show_bug.cgi?id=196629
3138
3139         Reviewed by Lucas Forschler.
3140
3141         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3142
3143 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3144
3145         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3146         https://bugs.webkit.org/show_bug.cgi?id=196618
3147
3148         Reviewed by Lucas Forschler.
3149
3150         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3151         (StatusBubble): Added QUEUE_TRIGGERS.
3152         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3153         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3154         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3155         its parent(builder).
3156
3157 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3158
3159         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3160         https://bugs.webkit.org/show_bug.cgi?id=196625
3161
3162         Reviewed by Lucas Forschler.
3163
3164         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3165         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3166
3167 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3168
3169         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3170         https://bugs.webkit.org/show_bug.cgi?id=196630
3171
3172         Reviewed by Wenson Hsieh.
3173
3174         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3175
3176 2019-04-04  Youenn Fablet  <youenn@apple.com>
3177
3178         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3179         https://bugs.webkit.org/show_bug.cgi?id=196543
3180
3181         Reviewed by Alex Christensen.
3182
3183         * WebKitTestRunner/TestController.cpp:
3184         (WTR::TestController::generatePageConfiguration):
3185
3186 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3187
3188         [ews-app] Status bubble should not display skipped buildbot steps
3189         https://bugs.webkit.org/show_bug.cgi?id=196584
3190
3191         Reviewed by Lucas Forschler.
3192
3193         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3194
3195 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3196
3197         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3198         https://bugs.webkit.org/show_bug.cgi?id=196620
3199
3200         Reviewed by Lucas Forschler.
3201
3202         * BuildSlaveSupport/ews-app/ews/config.py:
3203
3204 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3205
3206         [Win] DumpRenderTreeWatchDog.py is not checked into source
3207         https://bugs.webkit.org/show_bug.cgi?id=196567
3208         <rdar://problem/49525901>
3209
3210         Reviewed by Lucas Forschler.
3211
3212         This script is used on Win EWS bots to terminate hanging DRT processes.
3213
3214         * EWSTools/dumprendertreewatchdog.py: Added.
3215
3216 2019-04-04  Chris Dumez  <cdumez@apple.com>
3217
3218         Unreviewed, roll out r243858 which made tests time out.
3219
3220         Disable new API tests on Windows instead.
3221
3222         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3223         (TestWebKitAPI::TEST):
3224
3225 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3226
3227         [ATK] Cleanup WebPageAccessibilityObjectAtk
3228         https://bugs.webkit.org/show_bug.cgi?id=196537
3229
3230         Reviewed by Michael Catanzaro.
3231
3232         Also consider files under atk directories as exceptions for GObject conventions.
3233
3234         * Scripts/webkitpy/style/checkers/cpp.py:
3235         (check_identifier_name_in_declaration):
3236
3237 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3238
3239         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3240         https://bugs.webkit.org/show_bug.cgi?id=196588
3241         <rdar://problem/49365787>
3242
3243         Unreviewed build fix for Windows port.
3244
3245         error C3861: 'kill': identifier not found
3246
3247         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3248         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3249
3250 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3251
3252         [ews-build] Cancel build and similar operations should have authentication
3253         https://bugs.webkit.org/show_bug.cgi?id=196520
3254
3255         Reviewed by Dewei Zhu.
3256
3257         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3258         environment variables.
3259
3260 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3261
3262         [ews-build] Do not trigger queues which are not in production yet
3263         https://bugs.webkit.org/show_bug.cgi?id=196581
3264
3265         Reviewed by Dewei Zhu.
3266
3267         * BuildSlaveSupport/ews-build/config.json:
3268
3269 2019-04-03  Chris Dumez  <cdumez@apple.com>
3270
3271         Unreviewed, fix typo in the name of API test added in r243848.
3272
3273         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3274         (TestWebKitAPI::TEST):
3275
3276 2019-04-03  Chris Dumez  <cdumez@apple.com>
3277
3278         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3279         https://bugs.webkit.org/show_bug.cgi?id=196588
3280         <rdar://problem/49365787>
3281
3282         Reviewed by Ryosuke Niwa.
3283
3284         Add API test coverage.
3285
3286         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3287         (TestWebKitAPI::nullJavaScriptCallback):
3288         (TestWebKitAPI::didCrashCheckFrames):
3289         (TestWebKitAPI::TEST):
3290
3291 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3292
3293         run-webkit-tests: Upload test results (new results database)
3294         https://bugs.webkit.org/show_bug.cgi?id=196577
3295         <rdar://problem/34841155>
3296
3297         Reviewed by Lucas Forschler.
3298
3299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3300         (Manager.run): Upload results after each device shard, since the configuration will be
3301         different for each device.
3302         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3303         uploaded to a results database.
3304         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3305         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3306
3307 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3308
3309         -apple-trailing-word is needed for browser detection
3310         https://bugs.webkit.org/show_bug.cgi?id=196575
3311
3312         Unreviewed.
3313
3314         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3315
3316 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3317
3318         [CMake][WTF] Mirror XCode header directories
3319         https://bugs.webkit.org/show_bug.cgi?id=191662
3320
3321         Reviewed by Konstantin Tokarev.
3322
3323         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3324         builds.
3325
3326         * CMakeLists.txt:
3327         * DumpRenderTree/CMakeLists.txt:
3328         * DumpRenderTree/PlatformWin.cmake:
3329         * MiniBrowser/win/CMakeLists.txt:
3330         * TestWebKitAPI/CMakeLists.txt:
3331         * TestWebKitAPI/PlatformWin.cmake:
3332         * WebKitTestRunner/PlatformGTK.cmake:
3333         * WebKitTestRunner/PlatformWin.cmake:
3334
3335 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3336
3337         [ews-app] Status bubble should not display certain infrastructure status messages
3338         https://bugs.webkit.org/show_bug.cgi?id=196550
3339
3340         Reviewed by Lucas Forschler.
3341
3342         Do not display the steps which are un-needed for end-user. This information is still avaiable
3343         if the user click on the bubble and look at the Buildbot build.
3344         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3345         (StatusBubble._steps_messages):
3346         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3347
3348 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3349
3350         [ews-build] Use https for sending data to ews-app
3351         https://bugs.webkit.org/show_bug.cgi?id=196492
3352
3353         Reviewed by Lucas Forschler.
3354
3355         * BuildSlaveSupport/ews-build/events.py:
3356
3357 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3358
3359         Remove support for -apple-trailing-word
3360         https://bugs.webkit.org/show_bug.cgi?id=196525
3361
3362         Reviewed by Zalan Bujtas.
3363
3364         This CSS property is nonstandard and not used.
3365
3366         * Scripts/webkitperl/FeatureList.pm:
3367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3368
3369 2019-04-03  Youenn Fablet  <youenn@apple.com>
3370
3371         Add a test for DOMCache on multiple browsing in case of private browsing
3372         https://bugs.webkit.org/show_bug.cgi?id=196524
3373
3374         Reviewed by Alex Christensen.
3375
3376         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3377         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3378
3379 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3380
3381         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3382         https://bugs.webkit.org/show_bug.cgi?id=196540
3383
3384         Reviewed by Aakash Jain.
3385
3386         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3387
3388 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3389
3390         Add plumbing for a compatibility mode preference in WebKit
3391         https://bugs.webkit.org/show_bug.cgi?id=196005
3392
3393         Reviewed by Tim Horton.
3394
3395         Add new API tests.
3396
3397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3398         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3399
3400 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3401
3402         [WPE][GTK] Update libsrtp dependency package for Debian
3403         https://bugs.webkit.org/show_bug.cgi?id=196528
3404
3405         Reviewed by Frédéric Wang.
3406
3407         * gtk/install-dependencies:
3408         * wpe/install-dependencies:
3409
3410 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3411
3412         [WK2] Add support for Window's beforeprint / afterprint events
3413         https://bugs.webkit.org/show_bug.cgi?id=196478
3414         <rdar://problem/49535124>
3415
3416         Unreviewed build fix for MSVC.
3417
3418         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3419
3420         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3421
3422         * WebKitTestRunner/TestController.cpp:
3423         (WTR::printFrame): Use int and float literals.
3424
3425 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3426
3427         [ews-build] Reassign bots to queues
3428
3429         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3430
3431 2019-04-02  Chris Dumez  <cdumez@apple.com>
3432
3433         [WK2] Add support for Window's beforeprint / afterprint events
3434         https://bugs.webkit.org/show_bug.cgi?id=196478
3435
3436         Reviewed by Alex Christensen.
3437
3438         Add minimal implementation for printFrame in WebKitTestRunner.
3439
3440         * WebKitTestRunner/TestController.cpp:
3441         (WTR::printFrame):
3442         (WTR::TestController::createOtherPage):
3443         (WTR::TestController::createWebViewWithOptions):
3444
3445 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3446
3447         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3448         https://bugs.webkit.org/show_bug.cgi?id=196491
3449
3450         Reviewed by Lucas Forschler.
3451
3452         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3453
3454 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3455
3456         [ews-build] Configure buildbot try credentials in environment variables
3457         https://bugs.webkit.org/show_bug.cgi?id=196501
3458
3459         Reviewed by Lucas Forschler.
3460
3461         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3462         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3463         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3464
3465 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3466
3467         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3468         https://bugs.webkit.org/show_bug.cgi?id=196496
3469         <rdar://problem/49521634>
3470
3471         Reviewed by Chris Dumez.
3472
3473         Add new API tests (see WebKit ChangeLog for more detail).
3474
3475         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3476         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3477         (TEST):
3478
3479 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3480
3481         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3482         <https://webkit.org/b/196499>
3483
3484         Reviewed by Alexey Proskuryakov.
3485
3486         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3487         ENABLE_ADDRESS_SANITIZER.
3488
3489 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3490
3491         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3492         https://bugs.webkit.org/show_bug.cgi?id=182757
3493
3494         Reviewed by Don Olmstead.
3495
3496         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3497         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3498
3499 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3500
3501         run-api-tests: Upload test results
3502         https://bugs.webkit.org/show_bug.cgi?id=196323
3503         <rdar://problem/49356714>
3504
3505         Reviewed by Lucas Forschler.
3506
3507         * Scripts/webkitpy/api_tests/manager.py:
3508         (Manager):
3509         (Manager.run): Upload results to a results database.
3510         * Scripts/webkitpy/api_tests/run_api_tests.py:
3511         (parse_args): Add upload arguments.
3512         * Scripts/webkitpy/port/base.py:
3513         (Port):
3514         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3515         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3516         with commits from any other associated repositories.
3517         * Scripts/webkitpy/port/device.py:
3518         (Device):
3519         (Device.build_version): Access build_versoin of underlying platform device.
3520         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3521         (IOSSimulatorTest):
3522         (IOSSimulatorTest.test_configuration_for_upload):
3523         * Scripts/webkitpy/port/device_port.py:
3524         (DevicePort):
3525         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3526         the same as the machine uploading results.
3527         * Scripts/webkitpy/port/mac.py:
3528         (MacPort):
3529         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3530         * Scripts/webkitpy/port/mac_unittest.py:
3531         (MacTest):
3532         (MacTest.test_configuration_for_upload):
3533         * Scripts/webkitpy/xcode/simulated_device.py:
3534         (SimulatedDeviceManager._create_device_with_runtime):
3535         (SimulatedDevice.__init__): Create simulated device with a build_version.
3536         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3537         (test_existing_simulator):
3538
3539 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3540
3541         Remove extra newline characters (Follow-up fix to r243707)
3542
3543         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3544
3545 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3546
3547         [ews-app] Use API_KEY to accept results data
3548         https://bugs.webkit.org/show_bug.cgi?id=196461
3549
3550         Reviewed by Dewei Zhu.
3551
3552         * BuildSlaveSupport/ews-app/ews/views/results.py:
3553         (Results.post): Validate EWS_API_KEY before accepting any data.
3554         * BuildSlaveSupport/ews-build/events.py:
3555         (Events.sendData): Send EWS_API_KEY if available along with event data.
3556
3557 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3558
3559         Unable to copy and paste a PDF from Notes into Mail compose body
3560         https://bugs.webkit.org/show_bug.cgi?id=196442
3561         <rdar://problem/48573098>
3562
3563         Reviewed by Tim Horton.
3564
3565         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3566         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3567         to be specified on the item providers.
3568
3569         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3570         (TestWebKitAPI::mapItemForTesting):
3571         (TestWebKitAPI::contactItemForTesting):
3572
3573 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3574
3575         Make UIWKDocumentContext rects per-character instead of per-word
3576         https://bugs.webkit.org/show_bug.cgi?id=196459
3577
3578         Reviewed by Wenson Hsieh.
3579
3580         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3581         (TEST):
3582         Adjust test results due to switching to per-character rects.
3583
3584 2019-04-01  Chris Dumez  <cdumez@apple.com>
3585
3586         UIProcess crash when a prewarmed process is terminated
3587         https://bugs.webkit.org/show_bug.cgi?id=196451
3588         <rdar://problem/49245471>
3589
3590         Reviewed by Geoffrey Garen.
3591
3592         Add API test coverage.
3593
3594         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3595         (TEST):
3596
3597 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3598
3599         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3600         https://bugs.webkit.org/show_bug.cgi?id=196449
3601
3602         Reviewed by Lucas Forschler.
3603
3604         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3605         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3606         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3607         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3608
3609 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3610
3611         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3612         https://bugs.webkit.org/show_bug.cgi?id=196444
3613
3614         Reviewed by Lucas Forschler.
3615
3616         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3617
3618 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3619
3620         Add SPI to canonicalize NSURLs with WTF::URL
3621         https://bugs.webkit.org/show_bug.cgi?id=196415
3622         <rdar://problem/44980271>
3623
3624         Reviewed by Darin Adler.
3625
3626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3627         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3628         (TestWebKitAPI::TEST):
3629
3630 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3631
3632         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3633         https://bugs.webkit.org/show_bug.cgi?id=196441
3634
3635         Reviewed by Carlos Garcia Campos.
3636
3637         Don't cache the wpe_view_backend object that might not exist yet at the
3638         time of EventSenderProxy constructor invocation, but instead retrieve
3639         that object whenever it's required for event dispatching. This should
3640         avoid crashes in this constructor now that it's invoked before any
3641         PlatformWindow has been set up (as changed in r243496).
3642
3643         * WebKitTestRunner/EventSenderProxy.h:
3644         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3645         (WTR::viewBackend):
3646         (WTR::EventSenderProxy::EventSenderProxy):
3647         (WTR::EventSenderProxy::mouseDown):
3648         (WTR::EventSenderProxy::mouseUp):
3649         (WTR::EventSenderProxy::mouseMoveTo):
3650         (WTR::EventSenderProxy::mouseScrollBy):
3651         (WTR::EventSenderProxy::keyDown):
3652         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3653
3654 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3655
3656         [Win][WebKit] MiniBrowser should support high DPI display
3657         https://bugs.webkit.org/show_bug.cgi?id=196391
3658
3659         Reviewed by Alex Christensen.
3660
3661         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3662         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3663         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3664         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3665
3666 2019-03-31  Sam Weinig  <weinig@apple.com>
3667
3668         Remove more i386 specific configurations
3669         https://bugs.webkit.org/show_bug.cgi?id=196430
3670
3671         Reviewed by Alexey Proskuryakov.
3672
3673         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3674         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3675
3676 2019-03-31  Andy Estes  <aestes@apple.com>
3677
3678         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3679         https://bugs.webkit.org/show_bug.cgi?id=196433
3680         <rdar://problem/49293305>
3681
3682         Reviewed by Tim Horton.
3683
3684         Enhanced API test coverage to include all navigation response policy decisions in both
3685         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3686
3687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3688         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3689         (TestWebKitAPI::TEST):
3690         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3691         (readFile):
3692         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3693         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3694         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3695         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3696         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3697         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3698         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3699         (-[QuickLookDelegate _downloadDidStart:]):
3700         (-[QuickLookDelegate _download:didReceiveResponse:]):
3701         (-[QuickLookDelegate _download:didReceiveData:]):
3702         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3703         (-[QuickLookDelegate _downloadDidFinish:]):
3704         (-[QuickLookDelegate _download:didFailWithError:]):
3705         (-[QuickLookDelegate _downloadDidCancel:]):
3706         (-[QuickLookDelegate verifyDownload]):
3707         (runTest):
3708         (runTestDecideBeforeLoading):
3709         (runTestDecideAfterLoading):
3710         (TEST):
3711         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3712         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3713         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3714         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3715         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3716         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3717         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3718         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3719         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3720         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3721         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3722         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3723         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3724         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3725
3726 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3727
3728         [CMake] add testdfg as target with build-jsc
3729         https://bugs.webkit.org/show_bug.cgi?id=196393
3730
3731         Reviewed by Saam Barati.
3732
3733         Added testdfg as one of the targets to build when
3734         using CMake.
3735
3736         * Scripts/build-jsc:
3737
3738 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3739
3740         Delete WebMetal implementation in favor of WebGPU
3741         https://bugs.webkit.org/show_bug.cgi?id=195418
3742
3743         Reviewed by Dean Jackson.
3744
3745         * DumpRenderTree/mac/DumpRenderTree.mm:
3746         (enableExperimentalFeatures):
3747         (resetWebPreferencesToConsistentValues):
3748         * Scripts/webkitperl/FeatureList.pm:
3749         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3751         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3752         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3753         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3754         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3755         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3756         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3757         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3758         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3759         (WTR::InjectedBundle::beginTesting):
3760         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3761         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3762         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3763
3764 2019-03-29  Chris Dumez  <cdumez@apple.com>
3765
3766         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3767         https://bugs.webkit.org/show_bug.cgi?id=196405
3768         <rdar://problem/49428130>
3769
3770         Reviewed by Wenson Hsieh.
3771
3772         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3773         the popover presentation methods to be no-ops. Use this in the new test added in
3774         r243523 so that we do not swizzle those methods for all tests. This is needed because
3775         those WatchOS tests rely on the popover getting presented and interactive.
3776
3777         * WebKitTestRunner/TestController.cpp:
3778         (WTR::updateTestOptionsFromTestHeader):
3779         * WebKitTestRunner/TestController.h:
3780         * WebKitTestRunner/TestOptions.h:
3781         (WTR::TestOptions::hasSameInitializationOptions const):
3782         * WebKitTestRunner/ios/TestControllerIOS.mm:
3783         (WTR::TestController::platformInitialize):
3784         (WTR::TestController::platformResetStateToConsistentValues):
3785
3786 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3787
3788         [Curl] Add Server Trust Evaluation Support.
3789         https://bugs.webkit.org/show_bug.cgi?id=191646
3790
3791         Reviewed by Fujii Hironori.
3792
3793         Implemented MiniBrowser UI for asking if user trusts the server.
3794
3795         * MiniBrowser/win/Common.cpp:
3796         (askServerTrustEvaluation):
3797         (replaceString):
3798         * MiniBrowser/win/Common.h:
3799         * MiniBrowser/win/MiniBrowserLib.rc:
3800         * MiniBrowser/win/MiniBrowserLibResource.h:
3801         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3802         (createPEMString):
3803         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3804         (WebKitBrowserWindow::canTrustServerCertificate):
3805         * MiniBrowser/win/WebKitBrowserWindow.h:
3806
3807 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3808
3809         Implement ResizeObserver.
3810         https://bugs.webkit.org/show_bug.cgi?id=157743
3811
3812         Reviewed by Simon Fraser.
3813
3814         Support resizeObserverEnabled webPreferences.
3815
3816         * DumpRenderTree/TestOptions.cpp:
3817         (TestOptions::TestOptions):
3818         * DumpRenderTree/TestOptions.h:
3819         * DumpRenderTree/mac/DumpRenderTree.mm:
3820         (setWebPreferencesForTestOptions):
3821         * DumpRenderTree/win/DumpRenderTree.cpp:
3822         (enableExperimentalFeatures):
3823         * Scripts/webkitperl/FeatureList.pm:
3824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3825
3826 2019-03-28  John Wilander  <wilander@apple.com>
3827
3828         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3829         https://bugs.webkit.org/show_bug.cgi?id=196281
3830         <rdar://problem/48938748>
3831
3832         Reviewed by Alex Christensen.
3833
3834         This patch adds the function isStatisticsHasLocalStorage() to the
3835         TestRunner. With it, the page can query the WebsiteDataStore in the
3836         UI process to make sure that it sees LocalStorage.
3837
3838         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3840         (WTR::TestRunner::isStatisticsHasLocalStorage):
3841         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3842         * WebKitTestRunner/TestController.cpp:
3843         (WTR::TestController::isStatisticsHasLocalStorage):
3844         * WebKitTestRunner/TestController.h:
3845         * WebKitTestRunner/TestInvocation.cpp:
3846         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3847
3848 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3849
3850         API::Data::createWithoutCopying should do a null check before calling CFRelease
3851         https://bugs.webkit.org/show_bug.cgi?id=196276
3852         <rdar://problem/48059859>
3853
3854         Reviewed by Alex Christensen.
3855
3856         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3857
3858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3859         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3860         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3861         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3862         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3863         (TestWebKitAPI::TEST):
3864
3865 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3866
3867         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3868         https://bugs.webkit.org/show_bug.cgi?id=186276
3869
3870         Reviewed by Carlos Garcia Campos.
3871
3872         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3873         (webViewLoadChanged):
3874         (testWebResourceGetDataError):
3875         (testWebResourceGetDataEmpty):
3876         (beforeAll):
3877         (webViewloadChanged): Deleted.
3878
3879 2019-03-27  Andy Estes  <aestes@apple.com>
3880
3881         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3882         https://bugs.webkit.org/show_bug.cgi?id=196317
3883
3884         Reviewed by Dan Bernstein.
3885
3886         package-root copies built products into a staging directory using ditto(1), which does not
3887         follow symbolic links as it traverses a directory. Now that the files in
3888         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3889         itself, these become broken links when ditto'd into the staging directory.
3890
3891         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3892
3893         * Scripts/package-root:
3894
3895 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3896
3897         [ews-app] Update display text of Submit for ews analysis
3898         https://bugs.webkit.org/show_bug.cgi?id=196309
3899
3900         Reviewed by Dewei Zhu.
3901
3902         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3903
3904 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3905
3906         run-webkit-tests should check for leaks in WebKit processes
3907         <https://webkit.org/b/193772>
3908         <rdar://problem/46526680>
3909
3910         Reviewed by Ryosuke Niwa.
3911
3912         This works by doing the following:
3913         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3914           The list of child processes are returned one per line:
3915           process.name: pid
3916         - Run the "#LIST CHILD PROCESSES" command just before the
3917           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3918           processes on the ServerProcess object.
3919         - When the `--leaks` switch is handled, run check_for_leaks() on
3920           each child process after the main test harness.
3921
3922         * DumpRenderTree/mac/DumpRenderTree.mm:
3923         (handleControlCommand):
3924         - Use strncmp() instead of strcmp().
3925         - Add support for handling "#LIST CHILD PROCESSES" command.
3926
3927         * Scripts/webkitpy/port/base.py:
3928         (Port.check_for_leaks):
3929         * Scripts/webkitpy/port/darwin.py:
3930         (DarwinPort.check_for_leaks):
3931         - Rename redundant 'process_pid' argument to 'process_id'.
3932
3933         * Scripts/webkitpy/port/driver.py:
3934         (Driver.do_post_tests_work):
3935         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3936           longer the only command this sends to WebKitTestRunner.
3937         - If the `--leaks` switch is present, send the
3938           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3939           result using Port.set_webkit_processes().
3940         (Driver._parse_child_processes_output):
3941         - Add helper method to parse list of child process names and
3942           process IDs returned from WebKitTestRunner.
3943
3944         * Scripts/webkitpy/port/ios_device.py:
3945         (IOSDevicePort.check_for_leaks):
3946         - Rename redundant 'process_pid' argument to 'process_id'.
3947
3948         * Scripts/webkitpy/port/leakdetector.py:
3949         (LeakDetector._parse_leaks_output):
3950         - Return early if there is no leaks_output.
3951         (LeakDetector.check_for_leaks):
3952         - Rename redundant 'process_pid' argument to 'process_id'.
3953
3954         * Scripts/webkitpy/port/server_process.py:
3955         (ServerProcess.__init__):
3956         (ServerProcess.child_processes):
3957         (ServerProcess.set_child_processes):
3958         - Add instance variable to Port to store list of child process
3959           names and process IDs returned from WebKitTestRunner.
3960         (ServerProcess._start):
3961         - Clear self._child_processes.
3962         (ServerProcess.stop):
3963         - If self._child_processes is set, call
3964           self._port.check_for_leaks() for each child process.
3965
3966         * Scripts/webkitpy/port/server_process_unittest.py:
3967         (TrivialMockPort.check_for_leaks):
3968         - Rename redundant 'process_pid' argument to 'process_id'.
3969
3970         * Scripts/webkitpy/port/simulator_process.py:
3971         (SimulatorProcess.stop):
3972         - If self._child_processes is set, call
3973           self._port.check_for_leaks() for each child process.
3974
3975         * Scripts/webkitpy/port/watch_device.py:
3976         (WatchDevicePort.check_for_leaks):
3977         - Rename redundant 'process_pid' argument to 'process_id'.
3978
3979         * WebKitTestRunner/TestController.cpp:
3980         (WTR::TestController::dumpResponse):
3981         - Extract method from findAndDumpWorldLeaks() so that it may be
3982           reused by findAndDumpWebKitProcessIdentifiers().
3983         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3984         - Add method to output process name and process ID of both the
3985           WebContent and Networking processes.
3986         (WTR::TestController::findAndDumpWorldLeaks):
3987         - Fix missing newline in output when there were no abandoned
3988           documents.
3989         - Call dumpResponse() for extracted code.
3990         (WTR::TestController::handleControlCommand):
3991         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3992         - Use strncmp() instead of strcmp().
3993         - Call findAndDumpWebKitProcessIdentifiers() when
3994           "#LIST CHILD PROCESSES" command is sent.
3995         * WebKitTestRunner/TestController.h:
3996         (WTR::TestController::dumpResponse):
3997         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3998         - Declare methods.
3999
4000 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4001
4002         Unreviewed. Add GLib API test cases after r243434.
4003
4004         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4005         (testWebViewActiveURI):
4006         (serverCallback):
4007         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4008         (sendRequestCallback):
4009
4010 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4011
4012         Geolocation request not complete when watch request was started in a different web process
4013         https://bugs.webkit.org/show_bug.cgi?id=195996
4014
4015         Reviewed by Alex Christensen.
4016
4017         Add a test case.
4018
4019         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
4020         (TestWebKitAPI::runJavaScriptAlert):
4021         (TestWebKitAPI::TEST):
4022
4023 2019-03-26  Keith Rollin  <krollin@apple.com>
4024
4025         Update the way generate-xcfilelists returns strings from functions
4026         https://bugs.webkit.org/show_bug.cgi?id=195975
4027         <rdar://problem/49040807>
4028
4029         Reviewed by Dean Jackson.
4030
4031         There are places where generate-xcfilelists executes assignments with
4032         statements like:
4033
4034             FOO=$(some_function)
4035
4036         where "some_function" return a string by echoing it. E.g.
4037
4038             some_function()
4039             {
4040                 echo "Hello, World"
4041             }
4042
4043         This is a common idiom, but it has a problem if "some_function" needs
4044         to call "exit" in an attempt to halt the entire script right then and
4045         there. Since "some_function" is called inside of $(), it's being
4046         executed in a sub-shell. Calling exit in that sub-shell simply exits
4047         that shell; it doesn't not exit the outer shell in which the main part
4048         of the script is still running. As such, the main script keeps
4049         executing when the intent was for the script to halt.
4050
4051         The solution to this is to use a different idiom for returning
4052         strings. The one we now is to pass in the name of the variable to
4053         receive the string result:
4054
4055             some_function()
4056             {
4057                 variable_name=$1
4058                 eval $variable_name ="Hello, World"
4059             }
4060
4061         The call site now looks like
4062
4063             some_function FOO
4064
4065         Because there's no invocation of a sub-shell, some_function can now
4066         call "exit" if it wants to, and the entire script will exit at that
4067         point.
4068
4069         * Scripts/generate-xcfilelists:
4070
4071 2019-03-26  Chris Dumez  <cdumez@apple.com>
4072
4073         Add basic layout test coverage for File Picker on iOS
4074         https://bugs.webkit.org/show_bug.cgi?id=196265
4075
4076         Reviewed by Wenson Hsieh.
4077
4078         Add layout test infrastructure to test the file picker on iOS.
4079
4080         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4081         (WTR::UIScriptController::dismissFilePicker):
4082         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4083         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4084         (WTR::UIScriptController::dismissFilePicker):
4085         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4086         * WebKitTestRunner/TestController.cpp:
4087         (WTR::TestController::createWebViewWithOptions):
4088         (WTR::updateTestOptionsFromTestHeader):
4089         * WebKitTestRunner/TestOptions.h:
4090         (WTR::TestOptions::hasSameInitializationOptions const):
4091         * WebKitTestRunner/ios/TestControllerIOS.mm:
4092         (overridePresentViewController):
4093         (WTR::TestController::platformInitialize):
4094         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4095         (WTR::UIScriptController::dismissFilePicker):
4096
4097 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
4098
4099         Implement async paste method on UIWKInteractionViewProtocol
4100         https://bugs.webkit.org/show_bug.cgi?id=196267
4101         <rdar://problem/49236346>
4102
4103         Reviewed by Tim Horton.
4104
4105         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
4106         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
4107         are now a part of all iOS 12 internal SDKs.
4108
4109         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
4110
4111         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
4112         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
4113
4114         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4115         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4116         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
4117         * TestWebKitAPI/ios/UIKitSPI.h:
4118
4119 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4120
4121         [ews-build] Use PostgreSQL for ews.webkit.org database
4122         https://bugs.webkit.org/show_bug.cgi?id=196270
4123
4124         Reviewed by Lucas Forschler.
4125
4126         * BuildSlaveSupport/ews-app/ews-app/settings.py:
4127
4128 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
4129
4130         [ews] Reset simctl states on reboot
4131         https://bugs.webkit.org/show_bug.cgi?id=196260
4132
4133         Rubber-stamped by Aakash Jain.
4134
4135         * EWSTools/start-queue-mac.sh:
4136
4137 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4138
4139         [ews-build] Use PostgreSQL for ews-build database
4140         https://bugs.webkit.org/show_bug.cgi?id=196229
4141
4142         Reviewed by Lucas Forschler.
4143
4144         * BuildSlaveSupport/ews-build/master.cfg:
4145
4146 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4147
4148         [ews-build] Get master_hostname dynamically in master.cfg
4149         https://bugs.webkit.org/show_bug.cgi?id=196255
4150
4151         Reviewed by Lucas Forschler.
4152
4153         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
4154         send events data in test mode.
4155
4156 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4157
4158         [ews-app] Set db_constraint to False for Foreign Keys
4159         https://bugs.webkit.org/show_bug.cgi?id=196252
4160
4161         Reviewed by Lucas Forschler.
4162
4163         * BuildSlaveSupport/ews-app/ews/models/build.py:
4164         * BuildSlaveSupport/ews-app/ews/models/step.py:
4165
4166 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4167
4168         [ews-build] is_test_mode_enabled should default to True
4169         https://bugs.webkit.org/show_bug.cgi?id=196248
4170
4171         Reviewed by Lucas Forschler.
4172
4173         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
4174
4175 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4176
4177         [ews-app] Add webkitperl to ENABLED_QUEUES
4178         https://bugs.webkit.org/show_bug.cgi?id=196253
4179
4180         Reviewed by Lucas Forschler.
4181
4182         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4183
4184 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
4185
4186         Address NSWindow sometimes using WebKitTestRunnerEvent too early
4187         https://bugs.webkit.org/show_bug.cgi?id=196211
4188         rdar://problem/49110552
4189
4190         Reviewed by Tim Horton.
4191
4192         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
4193         Make sure that EventSenderProxy always exists when running tests. We used to create
4194         it when resetting before the first test, which is a bit too late.
4195
4196         * WebKitTestRunner/TestController.h:
4197         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4198         (WTR::TestController::platformCreateWebView):
4199         (WTR::TestController::platformCreateOtherPage):
4200         (WTR::TestController::finishCreatingPlatformWebView):
4201         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4202         (WTR::PlatformWebView::PlatformWebView):
4203         Moved some code that made NSWindow use NSEvent during web view creation. We may
4204         need to move more if some other case us found, but this is enough for now.
4205
4206 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
4207
4208         Unreviewed. Fix typo in GLib geolocation API after r243285.
4209
4210         gelocation -> geolocation.
4211
4212         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
4213         (testGeolocationManagerWatchPosition):
4214
4215 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4216
4217         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4218         https://bugs.webkit.org/show_bug.cgi?id=196213
4219
4220         Reviewed by Geoff Garen.
4221
4222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4223         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4224         (credentialWithIdentityAndKeychainPath):
4225         (-[ChallengeDelegate webView:didFinishNavigation:]):
4226         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4227         (TestWebKitAPI::TEST):
4228
4229 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4230
4231         Expected shouldn't assume its contained types are copyable
4232         https://bugs.webkit.org/show_bug.cgi?id=195986
4233
4234         Reviewed by JF Bastien.
4235
4236         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4237         (TestWebKitAPI::NonCopyable::operator== const):
4238         (TestWebKitAPI::NonCopyable::operator!= const):
4239         (TestWebKitAPI::TEST):
4240
4241 2019-03-25  Tim Horton  <timothy_horton@apple.com>
4242
4243         Remove some now-unnecessary dynamic class lookup
4244         https://bugs.webkit.org/show_bug.cgi?id=196237
4245
4246         Reviewed by Simon Fraser.
4247
4248         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4249         (makeRequest):
4250         (TEST):
4251
4252 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
4253
4254         Unreviewed, rolling out r243450.
4255
4256         AppleWin and WinCairo port builds get broken.
4257
4258         Reverted changeset:
4259
4260         "Add test for fix of #196095"
4261         https://bugs.webkit.org/show_bug.cgi?id=196097
4262         https://trac.webkit.org/changeset/243450
4263
4264 2019-03-25  Commit Queue  <commit-queue@webkit.org>
4265
4266         Unreviewed, rolling out r243465.
4267         https://bugs.webkit.org/show_bug.cgi?id=196226
4268
4269         the test doesn't build (Requested by thorton on #webkit).
4270
4271         Reverted changeset:
4272
4273         "Do not terminate the NetworkProcess if a third party
4274         application sends a NSCredential with a SecIdentityRef"
4275         https://bugs.webkit.org/show_bug.cgi?id=196213
4276         https://trac.webkit.org/changeset/243465
4277
4278 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4279
4280         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4281         https://bugs.webkit.org/show_bug.cgi?id=196213
4282
4283         Reviewed by Geoff Garen.
4284
4285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4286         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4287         (credentialWithIdentityAndKeychainPath):
4288         (-[ChallengeDelegate webView:didFinishNavigation:]):
4289         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4290         (TestWebKitAPI::TEST):
4291
4292 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4293
4294         [ews-build] Gracefully handle missing patch_id in events
4295         https://bugs.webkit.org/show_bug.cgi?id=196216
4296
4297         Reviewed by Lucas Forschler.
4298
4299         * BuildSlaveSupport/ews-build/events.py:
4300
4301 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4302
4303         [ews-build] use lz4 compression for improving buildbot performance
4304         https://bugs.webkit.org/show_bug.cgi?id=196155
4305
4306         Reviewed by Lucas Forschler.
4307
4308         * BuildSlaveSupport/ews-build/master.cfg:
4309
4310 2019-03-25  Wenson Hsieh  <