WK1 mouse events are missing movementX and movementY for pointerlock.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
2
3         WK1 mouse events are missing movementX and movementY for pointerlock.
4         https://bugs.webkit.org/show_bug.cgi?id=167775
5         rdar://problem/30343810
6
7         Reviewed by Alexey Proskuryakov.
8
9         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
10
11         * DumpRenderTree/mac/EventSendingController.mm:
12         (-[EventSendingController mouseMoveToX:Y:]):
13         * WebKitTestRunner/mac/EventSenderProxy.mm:
14         (WTR::EventSenderProxy::mouseMoveTo):
15
16 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
17
18         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
19         https://bugs.webkit.org/show_bug.cgi?id=167774
20
21         Reviewed by Tim Horton.
22
23         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
24         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
25         web process are async, so the callback fires after the web process gets the new state.
26
27         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
28         (WTR::UIScriptController::removeViewFromWindow):
29         (WTR::UIScriptController::addViewToWindow):
30         * DumpRenderTree/mac/DumpRenderTree.mm:
31         (createWebViewAndOffscreenWindow):
32         (resetWebViewToConsistentStateBeforeTesting):
33         * DumpRenderTree/mac/DumpRenderTreeMac.h:
34         * DumpRenderTree/mac/UIScriptControllerMac.mm:
35         (WTR::UIScriptController::removeViewFromWindow):
36         (WTR::UIScriptController::addViewToWindow):
37         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
38         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
39         (WTR::UIScriptController::removeViewFromWindow):
40         (WTR::UIScriptController::addViewToWindow):
41         * TestRunnerShared/UIScriptContext/UIScriptController.h:
42         * WebKitTestRunner/PlatformWebView.h:
43         * WebKitTestRunner/TestController.cpp:
44         (WTR::TestController::resetStateToConsistentValues):
45         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
46         (WTR::PlatformWebView::removeFromWindow):
47         (WTR::PlatformWebView::addToWindow):
48         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
49         (WTR::UIScriptController::removeViewFromWindow):
50         (WTR::UIScriptController::addViewToWindow):
51         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
52         (WTR::PlatformWebView::removeFromWindow):
53         (WTR::PlatformWebView::addToWindow):
54         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
55         (WTR::UIScriptController::removeViewFromWindow):
56         (WTR::UIScriptController::addViewToWindow):
57
58 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
59
60         Remove check for SkipSafariExecutableEntitlementChecks
61         https://bugs.webkit.org/show_bug.cgi?id=167762
62
63         Reviewed by Dan Bernstein.
64
65         Follow-up fix: don't break internal behavior.
66
67         * Scripts/webkitdirs.pm:
68         (safariPath):
69         (executableHasEntitlements): Deleted.
70         (safariPathFromSafariBundle): Deleted.
71         (installedSafariPath): Deleted.
72
73 2017-02-03  Daniel Bates  <dabates@apple.com>
74
75         [Mac][WK2] Add SPI to override the Content Security Policy of a page
76         https://bugs.webkit.org/show_bug.cgi?id=167810
77         <rdar://problem/30102568>
78
79         Reviewed by Anders Carlsson.
80
81         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
82
83         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
84         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
85         (TEST):
86         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
87         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
88         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
89         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
90
91 2017-02-02  Alex Christensen  <achristensen@webkit.org>
92
93         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
94         https://bugs.webkit.org/show_bug.cgi?id=167773
95         <rdar://problem/30221102>
96
97         Reviewed by Ryosuke Niwa.
98
99         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
100         (TestWebKitAPI::TEST_F):
101
102 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
103
104         Remove check for SkipSafariExecutableEntitlementChecks
105         https://bugs.webkit.org/show_bug.cgi?id=167762
106         rdar://problem/22480673
107
108         Reviewed by Dan Bernstein.
109
110         * Scripts/webkitdirs.pm:
111         (safariPathFromSafariBundle):
112         (skipSafariExecutableEntitlementChecks): Deleted.
113
114 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
115
116         Undefined subroutine in svn-create-patch
117         https://bugs.webkit.org/show_bug.cgi?id=167742
118
119         Unreviewed build-fix after r211543.
120
121         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
122
123 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
124
125         Unreviewed. Fix jhbuild dependencies build.
126
127         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
128         Patch updated.
129
130 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
131
132         [EME][GStreamer] Fixed decryptor selection
133         https://bugs.webkit.org/show_bug.cgi?id=167588
134
135         Reviewed by Žan Doberšek.
136
137         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
138
139         * gtk/jhbuild.modules: Added patches to gstreamer and
140         gst-plugins-good packages.
141         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
142         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
143
144 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
145
146         Make run-benchmark script supports 'config' key in test plan.
147         https://bugs.webkit.org/show_bug.cgi?id=167715
148
149         Reviewed by Ryosuke Niwa.
150
151         Add support for 'config' key in test paln.
152         'config' key is a dictionary that specifies environment configurations while test is running.
153         Specifies orientation to be portrait in MotionMark benchmark.
154
155         * Scripts/webkitpy/benchmark_runner/README.md:
156         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
157         (BenchmarkRunner.__init__):
158         (BenchmarkRunner._run_benchmark):
159         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
160         (BrowserDriver.prepare_env):
161         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
162         (LinuxBrowserDriver.prepare_env):
163         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
164         (OSXBrowserDriver.prepare_env):
165         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
166         (OSXSafariDriver.prepare_env):
167         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
168
169 2017-02-01  Daniel Bates  <dabates@apple.com>
170
171         REGRESSION (r210820): svn-create-patch does not emit property change only diff
172         https://bugs.webkit.org/show_bug.cgi?id=167169
173
174         Reviewed by David Kilzer.
175
176         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
177         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
178         header from the output of "svn diff" on a file that was copied or moved.
179
180         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
181         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
182         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
183         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
184         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
185         of a file with only a property change also does not contain any chunk range lines. Therefore
186         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
187         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
188         we should directly test for the presence of a leading SVN diff header with an empty body and
189         remove such lines from the diff.
190
191         * Scripts/VCSUtils.pm:
192         (fixSVNPatchForAdditionWithHistory): Added.
193         * Scripts/svn-create-patch:
194         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
195         we have a non empty patch for an added file with history (i.e. a copied or moved file).
196         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
197
198 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
199
200         [Mac] Update CARingBuffer class
201         https://bugs.webkit.org/show_bug.cgi?id=167656
202
203         Reviewed by Jer Noble.
204
205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
206         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
207         (TestWebKitAPI::CARingBufferTest::SetUp):
208         (TestWebKitAPI::CARingBufferTest::setup):
209         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
210         (TestWebKitAPI::CARingBufferTest::description):
211         (TestWebKitAPI::CARingBufferTest::bufferList):
212         (TestWebKitAPI::CARingBufferTest::ringBuffer):
213         (TestWebKitAPI::CARingBufferTest::capacity):
214         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
215         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
216         (TestWebKitAPI::TEST_F):
217         (TestWebKitAPI::MixingTest::run):
218
219 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
220
221         [Mac] TestWebKitAPI includes system frameworks incorrectly
222         https://bugs.webkit.org/show_bug.cgi?id=167703
223         rdar://problem/30301498
224
225         Reviewed by Ryosuke Niwa.
226
227         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
228         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
229
230         Also, reduced the number of subframework search paths, looks like we only need one now.
231
232         * TestWebKitAPI/Configurations/Base.xcconfig:
233
234 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
235
236         Correct "filesHaveSameVolume" predicate
237         https://bugs.webkit.org/show_bug.cgi?id=167696
238         <rdar://problem/30298722>
239
240         Reviewed by David Kilzer.
241
242         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
243         percent-escaped path inputs.
244
245         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
246         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
247         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
248         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
249         (TestWebKitAPI::TEST_F):
250
251 2017-02-01  Tomas Popela  <tpopela@redhat.com>
252
253         Unreviewed. Fix coding style in MiniBrowser
254
255         * MiniBrowser/gtk/BrowserWindow.c:
256         (editingCommandCallback):
257         (insertImageCommandCallback):
258         (insertLinkCommandCallback):
259
260 2017-02-01  Tomas Popela  <tpopela@redhat.com>
261
262         [GTK] Add an API to add a custom tab into the print dialog
263         https://bugs.webkit.org/show_bug.cgi?id=151998
264
265         Reviewed by Carlos Garcia Campos.
266
267         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
268         that is testing a newly added API.
269
270         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
271         (testPrintCustomWidget):
272         (beforeAll):
273
274 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
275
276         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
277         https://bugs.webkit.org/show_bug.cgi?id=166529
278
279         Reviewed by Xabier Rodriguez-Calvar.
280
281         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
282         New patch version accepted in GStreamer upstream.
283
284 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
285
286         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
287         https://bugs.webkit.org/show_bug.cgi?id=167498
288
289         Reviewed by Carlos Garcia Campos.
290
291         Depending on the distro version you can need either libxfont1-dev
292         or libfont-dev to build with jhbuild.
293
294         * gtk/install-dependencies:
295
296 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
297
298         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
299         https://bugs.webkit.org/show_bug.cgi?id=167594
300
301         Unreviewed test gardening.
302
303         Disabling this test while we investigate the cause of a timeout on ios-simulator.
304
305         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
306         (TEST):
307
308 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
309
310         Move slow-running microbenchmarks out of JSTests/microbenchmarks
311         https://bugs.webkit.org/show_bug.cgi?id=167676
312
313         Reviewed by Saam Barati.
314
315         * Scripts/run-javascriptcore-tests:
316         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
317
318 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
319
320         Make Dump Render Tree not crash
321         https://bugs.webkit.org/show_bug.cgi?id=167667
322
323         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
324         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
325         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
326         This does not fix any tests, it just fixes the crash.
327         
328         Reviewed by Simon Fraser.
329
330         * DumpRenderTree/TestRunner.cpp:
331         (TestRunner::callUIScriptCallback):
332
333 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
334
335         Workaround for simctl install failing to report install failure
336         https://bugs.webkit.org/show_bug.cgi?id=167654
337
338         Reviewed by Daniel Bates.
339
340         simctl install will sometimes report success even though install has failed.
341         To workaround this bug, we attempt an app launch after install to ensure
342         install has succeeded.
343
344         * Scripts/webkitpy/xcode/simulator.py:
345         (Device.install_app): Attempt app launch after install, retry install if launch fails.
346         (Device.launch_app): Correct comment.
347
348 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
349
350         Unreviewed webkitpy fix after r211405.
351
352         * Scripts/webkitpy/xcode/simulator.py:
353         (Device.launch_app): Remove @staticmethod on _log_debug_error.
354
355 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
356
357         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
358
359         * gtk/manifest.txt.in:
360
361 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
362
363         AX: enable search predication for iOS
364         https://bugs.webkit.org/show_bug.cgi?id=167558
365         <rdar://problem/30251367>
366
367         Reviewed by Joanmarie Diggs.
368
369         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
370         (AccessibilityUIElement::uiElementForSearchPredicate):
371         * DumpRenderTree/mac/AccessibilityCommonMac.h:
372         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
373         (searchPredicateParameterizedAttributeForSearchCriteria):
374         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
375         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
376         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
377         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
378         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
379         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
380         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
381         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
382         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
383         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
384         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
385
386 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
387
388         Workaround for simctl launch bug
389         https://bugs.webkit.org/show_bug.cgi?id=167613
390
391         Reviewed by Daniel Bates.
392
393         simctl launch will sometimes fail because of a race condition when many
394         simulators are being run simultaneously. These failures will always have
395         an exit code of 1. This change attempts to launch an app multiple times
396         before reporting a failure to workaround this bug.
397
398         * Scripts/webkitpy/xcode/simulator.py:
399         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
400
401 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
402
403         Commit queue fails to look at real name aliases for the reviewer
404         https://bugs.webkit.org/show_bug.cgi?id=167422
405
406         Reviewed by Joseph Pecoraro.
407
408         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
409         (test_has_valid_reviewer): Added tests.
410
411         * Scripts/webkitpy/common/config/committers.py:
412         (CommitterList._name_to_contributor_map):
413         Made _name_to_contributor_map include alias names.
414
415         * Scripts/webkitpy/common/config/committers_unittest.py:
416         (CommittersTest.test_contributors_by_fuzzy_match):
417         Removed subtests that are now obsolete, as these matches are strict. It is not
418         obvious if distance based fuzzy matching for names is useful at all, but we can
419         look into that some other time.
420
421 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
422
423         QueueStatusServer should have an explicit timeout for _fetch_url
424         https://bugs.webkit.org/show_bug.cgi?id=167467
425
426         Reviewed by Alexey Proskuryakov.
427
428         * Scripts/webkitpy/common/net/statusserver.py:
429         (StatusServer._fetch_url): Add an explicit timeout of 300s.
430
431 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
432
433         Add support for Trac instances that host multiple projects.
434         https://bugs.webkit.org/show_bug.cgi?id=167524
435
436         Reviewed by Alexey Proskuryakov.
437
438         When multiple projects are hosted on a single Trac instance, the current
439         behavior will retrieve changesets from all tracked projects.
440         This patch teaches Trac.js to get project-specific changesets from Trac.
441         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
442         when querying the Trac timeline.
443
444         To tell Trac to be aware of multi-project instances we leverage the 
445         `options` parameter when creating a new instance: 
446
447             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
448
449         If this option is not provided, the original behaviour will prevail.
450         Additionally, add corresponding tests.
451
452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
453         (Trac): Reason about new optional parameter 'projectIdentifier'.
454         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
455         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
456         replace default parameter `changeset=on` with `repo-projectname=on`.
457         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
459         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
461         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
462         Add the following tests:
463             test("revisionURL")
464             test("revisionURL with Trac Identifier")
465             test("_xmlTimelineURL")
466             test("_xmlTimelineURL with Trac Identifier")
467         (this.view._latestProductiveIteration): Fix missing ';'.
468
469 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
470
471         Correct spacing regression on inter-element complex path shaping on some fonts
472         https://bugs.webkit.org/show_bug.cgi?id=166013
473
474         Reviewed by Simon Fraser.
475
476         Unskip existing tests and make some new tests:
477         - Testing complex text with no origins
478         - Testing initial expansions
479         - Testing the sign of vertical advances
480
481         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
482         (TestWebKitAPI::TEST_F):
483
484 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
485
486         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
487         https://bugs.webkit.org/show_bug.cgi?id=167596
488
489         Reviewed by Daniel Bates.
490
491         We avoid needing a thin directory by invoking the zip program with
492         the list of directories from the build directory to be zipped,
493         and by using the zip feature to exclude files matching a pattern.
494
495         * BuildSlaveSupport/built-product-archive:
496         (copyBuildFiles):
497         (createZipFromList):
498         (archiveBuiltProduct):
499
500 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
501
502         Use simctl instead of LayoutTestRelay
503         https://bugs.webkit.org/show_bug.cgi?id=165927
504
505         Reviewed by Daniel Bates.
506
507         Part 1
508
509         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
510         simulators through simctl (iOS 10 and later), use this functionality instead.
511
512         * Scripts/webkitpy/port/base.py:
513         (Port.__init__): Added _test_runner_process_constructor.
514         * Scripts/webkitpy/port/darwin.py:
515         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
516         * Scripts/webkitpy/port/driver.py:
517         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
518         (IOSSimulatorDriver): Deleted.
519         * Scripts/webkitpy/port/driver_unittest.py:
520         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
521         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
522         (DriverTest.test_start_actually_starts): Ditto.
523         * Scripts/webkitpy/port/ios.py:
524         (IOSSimulatorPort): Remove relay_name.
525         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
526         (IOSSimulatorPort._create_simulators): Formatting change.
527         (IOSSimulatorPort.relay_path): Deleted.
528         (IOSSimulatorPort._check_relay): Deleted.
529         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
530         (IOSSimulatorPort._build_relay): Deleted.
531         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
532         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
533         * Scripts/webkitpy/port/ios_unittest.py:
534         (iosTest.test_32bit): Update test.
535         (iosTest.test_64bit): Update test.
536         * Scripts/webkitpy/port/server_process.py:
537         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
538         (ServerProcess._set_file_nonblocking): Added to share common code.
539         * Scripts/webkitpy/port/server_process_mock.py:
540         (MockServerProcess.__init__): Added argument worker_number.
541         * Scripts/webkitpy/port/simulator_process.py: Added.
542         (SimulatorProcess): Added.
543         (SimulatorProcess.Popen): Added.
544         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
545         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
546         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
547         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
548         (SimulatorProcess._reset): Added. Unlink fifos.
549         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
550         (SimulatorProcess._kill): Added. Shutdown app on simulator.
551         * Scripts/webkitpy/xcode/simulator.py:
552         (Device.__init__): Accept host to run install/launch/terminate.
553         (Device.install_app): Install app to target Device.
554         (Device.launch_app): Launch app on target Device.
555         (Device.terminate_app): Shutdown app on target Device.
556         (Simulator._parse_devices): Pass host to Device.
557
558 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
559
560         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
561         https://bugs.webkit.org/show_bug.cgi?id=167411
562
563         Reviewed by Michael Catanzaro.
564
565         Disable the ARM iwMMXt fast path for pixman, because it triggers
566         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
567
568         * gtk/jhbuild.modules:
569
570 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
571
572         [GTK] Add API to handle the accelerated compositing policy
573         https://bugs.webkit.org/show_bug.cgi?id=167509
574
575         Reviewed by Michael Catanzaro.
576
577         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
578         as a special case. Also add test cases to the get/set API.
579
580         * MiniBrowser/gtk/BrowserSettingsDialog.c:
581         (hardwareAccelerationPolicyToString):
582         (stringToHardwareAccelerationPolicy):
583         (cellRendererChanged):
584         (browserSettingsDialogConstructed):
585         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
586         (testWebKitSettings):
587
588 2017-01-29  Andy Estes  <aestes@apple.com>
589
590         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
591         https://bugs.webkit.org/show_bug.cgi?id=167563
592         <rdar://problem/30253207>
593
594         Reviewed by Andreas Kling.
595
596         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
597         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
598         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
599         (runTest):
600         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
601         (TEST):
602
603 2017-01-29  Dan Bernstein  <mitz@apple.com>
604
605         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
606         https://bugs.webkit.org/show_bug.cgi?id=167565
607
608         Reviewed by Sam Weinig.
609
610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
611         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
612         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
613         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
614         (TEST):
615         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
616         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
617         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
618         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
619
620 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
621
622         Add Link Preload as an off-by-default experimental feature menu item.
623         https://bugs.webkit.org/show_bug.cgi?id=167201
624
625         Reviewed by Ryosuke Niwa.
626
627         * DumpRenderTree/mac/DumpRenderTree.mm:
628         (resetWebPreferencesToConsistentValues):
629         * DumpRenderTree/win/DumpRenderTree.cpp:
630         (resetWebPreferencesToConsistentValues):
631
632 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
633
634         Add User Timing Experimental Feature
635         https://bugs.webkit.org/show_bug.cgi?id=167542
636         <rdar://problem/22746307>
637
638         Reviewed by Ryosuke Niwa.
639
640         * DumpRenderTree/mac/DumpRenderTree.mm:
641         (enableExperimentalFeatures):
642         (resetWebPreferencesToConsistentValues):
643         * DumpRenderTree/win/DumpRenderTree.cpp:
644         (enableExperimentalFeatures):
645
646 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
647
648         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
649         https://bugs.webkit.org/show_bug.cgi?id=167519
650
651         Reviewed by Ryosuke Niwa.
652
653         * QueueStatusServer/templates/statusbubble.html:
654         To measure the bubbleContainer's width, it must not be wrapping based
655         on its parent container. So when measuring the width temporarily set
656         the parent to a very large width so as to not artificially wrap us.
657         Restore the parent's width after measuring.
658
659 2017-01-27  Andy Estes  <aestes@apple.com>
660
661         [iOS] Add a test for _WKNSFileManagerExtras
662         https://bugs.webkit.org/show_bug.cgi?id=167478
663
664         Reviewed by Andreas Kling.
665
666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
667         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
668         (expectAttributes):
669         (TEST):
670
671 2017-01-27  Keith Miller  <keith_miller@apple.com>
672
673         run-benchmarks should make sure it passes the test url to the right application
674         https://bugs.webkit.org/show_bug.cgi?id=167533
675
676         Reviewed by Joseph Pecoraro.
677
678         This fixes an issue when trying to run-benchmark script with the
679         system default browser set to STP. Previously, it would run
680         the test in STP rather than the provided build. Now, it should run
681         in the provided build.
682
683         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
684         (OSXSafariDriver.launch_url):
685
686 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
687
688         [Cocoa] Prepare ComplexTextController for unit testing
689         https://bugs.webkit.org/show_bug.cgi?id=167493
690
691         Reviewed by Simon Fraser.
692
693         Addressing post-review comments from Simon Fraser.
694
695         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
696         (TestWebKitAPI::TEST_F):
697
698 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
699
700         [Cocoa] Prepare ComplexTextController for unit testing
701         https://bugs.webkit.org/show_bug.cgi?id=167493
702
703         Reviewed by Dean Jackson.
704
705         Create four unit tests.
706
707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
709         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
710         (TestWebKitAPI::TEST_F):
711
712 2017-01-26  Chris Dumez  <cdumez@apple.com>
713
714         Crash when navigating back to a page in PacheCache when one of its frames has been removed
715         https://bugs.webkit.org/show_bug.cgi?id=167421
716         <rdar://problem/30188490>
717
718         Reviewed by Darin Adler.
719
720         Add a new setting allowing layout tests to enable PageCache in a window
721         that has an opener, for convenience.
722
723         * DumpRenderTree/mac/DumpRenderTree.mm:
724         (resetWebPreferencesToConsistentValues):
725         * DumpRenderTree/win/DumpRenderTree.cpp:
726         (resetWebPreferencesToConsistentValues):
727         * WebKitTestRunner/TestController.cpp:
728         (WTR::TestController::resetPreferencesToConsistentValues):
729
730 2017-01-26  Keith Miller  <keith_miller@apple.com>
731
732         classInfo should take a VM so it is not materialized from the object on each call
733         https://bugs.webkit.org/show_bug.cgi?id=167424
734
735         Rubber Stamped by Michael Saboff.
736
737         Previously, classInfo() would get the VM from the target's
738         MarkedBlock.  Most callers already have a VM on hand, so it is
739         wasteful to compute the VM from the marked block every time. This
740         patch refactors some of the most common callers of classInfo(),
741         jsDynamicCast and inherits to take a VM as well.
742
743         * DumpRenderTree/TestRunner.cpp:
744         (setAudioResultCallback):
745
746 2017-01-26  Jer Noble  <jer.noble@apple.com>
747
748         Autoplay muted videos stop playback of any streaming app in the background
749         https://bugs.webkit.org/show_bug.cgi?id=163993
750         <rdar://problem/29020431>
751
752         Reviewed by Eric Carlson.
753
754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
755         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
756         (TestWebKitAPI::TEST):
757         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
758
759 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
760
761         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
762         https://bugs.webkit.org/show_bug.cgi?id=167466
763
764         Unreviewed test gardening.
765
766         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
767         (TEST):
768
769 2017-01-26  Matt Rajca  <mrajca@apple.com>
770
771         Notify clients when the user plays media otherwise prevented from autoplaying
772         https://bugs.webkit.org/show_bug.cgi?id=167390
773
774         Reviewed by Alex Christensen.
775
776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
777         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
778         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
779         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
780         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
781         (TEST):
782         * TestWebKitAPI/cocoa/TestWKWebView.h:
783         * TestWebKitAPI/cocoa/TestWKWebView.mm:
784         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
785         (-[TestWKWebView waitForLoad]):
786         (-[TestWKWebView mouseUpAtPoint:]):
787         * WebKitTestRunner/TestController.cpp:
788         (WTR::TestController::createOtherPage):
789         (WTR::TestController::createWebViewWithOptions):
790
791 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
792
793         Crash when setting custom scale factor.
794         https://bugs.webkit.org/show_bug.cgi?id=167369
795
796         Reviewed by Sam Weinig.
797
798         Added API test.
799
800         * TestWebKitAPI/PlatformWin.cmake:
801         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
802         (TestWebKitAPI::WebKitCreateInstance):
803         (TestWebKitAPI::ScaleWebView::SetUp):
804         (TestWebKitAPI::ScaleWebView::TearDown):
805         (TestWebKitAPI::TEST_F):
806
807 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
808
809         run-benchmark nests MotionMark results by the suite name twice
810         https://bugs.webkit.org/show_bug.cgi?id=164948
811
812         Reviewed by Said Abou-Hallawa.
813
814         Use a single level MotionMark now that this is the name of the benchmark,
815         and we no longer have tests that aren't part of the MotionMark suite.
816
817         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
818
819 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
820
821         Unreviewed, rolling out r211193.
822
823         This change broke internal builds.
824
825         Reverted changeset:
826
827         "Notify clients when the user plays media otherwise prevented
828         from autoplaying"
829         https://bugs.webkit.org/show_bug.cgi?id=167390
830         http://trac.webkit.org/changeset/211193
831
832 2017-01-25  Matt Rajca  <mrajca@apple.com>
833
834         Notify clients when the user plays media otherwise prevented from autoplaying
835         https://bugs.webkit.org/show_bug.cgi?id=167390
836
837         Reviewed by Alex Christensen.
838
839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
840         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
841         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
842         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
843         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
844         (TEST):
845         * TestWebKitAPI/cocoa/TestWKWebView.h:
846         * TestWebKitAPI/cocoa/TestWKWebView.mm:
847         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
848         (-[TestWKWebView waitForLoad]):
849         (-[TestWKWebView mouseUpAtPoint:]):
850         * WebKitTestRunner/TestController.cpp:
851         (WTR::TestController::createOtherPage):
852         (WTR::TestController::createWebViewWithOptions):
853
854 2017-01-25  Matt Rajca  <mrajca@apple.com>
855
856         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
857         https://bugs.webkit.org/show_bug.cgi?id=167385
858
859         Reviewed by Alex Christensen.
860
861         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
862         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
863         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
864         (TEST): Allow inline (rather than full screen) media playback on iOS.
865
866 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
867
868         [GTK] Icon Database should be in private browsing mode for ephemeral web views
869         https://bugs.webkit.org/show_bug.cgi?id=167414
870
871         Reviewed by Michael Catanzaro.
872
873         Add a test case to check ephemeral web views don't write favicons to the database.
874
875         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
876         (ephemeralViewLoadChanged):
877         (testPrivateBrowsing):
878         (testFaviconDatabase):
879
880 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
881
882         [GTK] Add a private browsing mode to MiniBrowser
883         https://bugs.webkit.org/show_bug.cgi?id=167413
884
885         Reviewed by Michael Catanzaro.
886
887         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
888         private windows, even on non-private instances.
889
890         * MiniBrowser/gtk/BrowserWindow.c:
891         (webViewTitleChanged): Add [Private] to title window for private windows.
892         (webViewCreate): Pass web context to browser_window_new.
893         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
894         (browserWindowFinalize): Disconnect web context signal handlers.
895         (browser_window_init): Add shortcut for opening private window.
896         (browser_window_new): It now receives the context and connect to download-started here.
897         (browser_window_get_web_context): Return the context.
898         * MiniBrowser/gtk/BrowserWindow.h:
899         * MiniBrowser/gtk/main.c:
900         (createBrowserTab): Create the web view for the window web context.
901         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
902         (aboutDataHandleRequest): Ditto.
903         (aboutURISchemeRequestCallback): Ditto.
904         (main): Create ephemeral web context if private command line option is used.
905
906 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
907
908         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
909         https://bugs.webkit.org/show_bug.cgi?id=167409
910
911         Reviewed by Antti Koivisto.
912
913         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
914         as well as tests for the newly added matchingElementInFlatTree.
915
916         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
917         (TestWebKitAPI::runJavaScriptAlert):
918         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
919         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
920         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
921
922 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
923
924         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
925         https://bugs.webkit.org/show_bug.cgi?id=167370
926
927         Reviewed by Michael Catanzaro.
928
929         Add several test cases of ephemeral web views.
930
931         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
932         (testWebViewAuthenticationStorage):
933         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
934         (ephemeralViewloadChanged):
935         (testCookieManagerEphemeral):
936         (beforeAll):
937         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
938         (testWebKitSettings):
939         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
940         (testWebContextEphemeral):
941         (ephemeralViewloadChanged):
942         (testWebContextProxySettings):
943         (beforeAll):
944         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
945         (ephemeralViewloadChanged):
946         (testWebViewEphemeral):
947         (beforeAll):
948         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
949         (ephemeralViewloadChanged):
950         (testWebsiteDataEphemeral):
951         (beforeAll):
952
953 2017-01-24  Alex Christensen  <achristensen@webkit.org>
954
955         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
956         https://bugs.webkit.org/show_bug.cgi?id=167402
957
958         Reviewed by Ryosuke Niwa.
959
960         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
961         (TestWebKitAPI::TEST):
962
963 2017-01-24  Zalan Bujtas  <zalan@apple.com>
964
965         Add simple line layout toggle to MiniBrowser
966         https://bugs.webkit.org/show_bug.cgi?id=167405
967
968         Reviewed by Andreas Kling.
969
970         * MiniBrowser/mac/SettingsController.h:
971         * MiniBrowser/mac/SettingsController.m:
972         (-[SettingsController _populateMenu]):
973         (-[SettingsController validateMenuItem:]):
974         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
975         (-[SettingsController simpleLineLayoutEnabled]):
976         * MiniBrowser/mac/WK1BrowserWindowController.m:
977         (-[WK1BrowserWindowController didChangeSettings]):
978         * MiniBrowser/mac/WK2BrowserWindowController.m:
979         (-[WK2BrowserWindowController didChangeSettings]):
980
981 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
982
983         WKR does not include my nick when commit-queue lands my patch
984         https://bugs.webkit.org/show_bug.cgi?id=167388
985
986         Reviewed by Ryosuke Niwa.
987
988         * Scripts/webkitpy/tool/commands/newcommitbot.py:
989         (NewCommitBot._summarize_commit_log):
990         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
991         Perform nickname insertion before grabbing "Patch by" details.
992         This way we can include the nickname with the full name.
993
994 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
995
996         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
997         https://bugs.webkit.org/show_bug.cgi?id=167394
998
999         Reviewed by Ryosuke Niwa.
1000
1001         * Scripts/webkitperl/FeatureList.pm:
1002         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1003
1004 2017-01-24  Youenn Fablet  <youenn@apple.com>
1005
1006         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1007         https://bugs.webkit.org/show_bug.cgi?id=167353
1008
1009         Reviewed by Alex Christensen.
1010
1011         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1012         (CMakeGenerator.initialize_targets):
1013
1014 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1015
1016         WKR should not confuse Miguel Gomez with Andres Gomez
1017         https://bugs.webkit.org/show_bug.cgi?id=167389
1018
1019         Reviewed by Lucas Forschler.
1020
1021         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1022         "mAndres Gomez". Fix this.
1023
1024         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1025         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1026         space on each side of the email address, so expect both spaces to be there before
1027         considering the email for replacement.
1028         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1029
1030 2017-01-24  Matt Rajca  <mrajca@apple.com>
1031
1032         Pass down website autoplay policies to media elements
1033         https://bugs.webkit.org/show_bug.cgi?id=167355
1034
1035         Reviewed by Alex Christensen.
1036
1037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1038         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1039         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1040         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1041         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1042         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1043         (TEST):
1044
1045 2017-01-24  Nan Wang  <n_wang@apple.com>
1046
1047         AX: Speak Selection does not work in an iframe
1048         https://bugs.webkit.org/show_bug.cgi?id=166794
1049         <rdar://problem/29913013>
1050
1051         Reviewed by Chris Fleizach.
1052
1053         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1054         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1055         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1056         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1057         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1058         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1059         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1060         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1061         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1062         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1063         (-[TestRunnerWKWebView dealloc]):
1064         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1065         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1066         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1067         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1068         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1069
1070 2017-01-24  Daniel Bates  <dabates@apple.com>
1071
1072         StringView.split() should use an iterator design pattern instead of allocating a Vector
1073         https://bugs.webkit.org/show_bug.cgi?id=163225
1074
1075         Reviewed by Darin Adler.
1076
1077         Add unit tests for StringView.split().
1078
1079         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1080         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1081         used in the StringView.split() unit tests.
1082         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1083         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1084         object to a Vector of String objects.
1085         (TestWebKitAPI::TEST): Added the following tests:
1086             - WTF.StringViewSplitEmptyAndNullStrings
1087             - WTF.StringViewSplitBasic
1088             - WTF.StringViewSplitWithConsecutiveSeparators
1089
1090 2017-01-23  Anders Carlsson  <andersca@apple.com>
1091
1092         The Score Esports crashes on launch
1093         https://bugs.webkit.org/show_bug.cgi?id=167338
1094         rdar://problem/29948645
1095
1096         Reviewed by Dan Bernstein.
1097
1098         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1099         (TestWebKitAPI::TEST):
1100         Add a test.
1101
1102 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1103
1104         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1105         https://bugs.webkit.org/show_bug.cgi?id=146589
1106
1107         Reviewed by Michael Catanzaro.
1108
1109         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1110         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1111
1112         * MiniBrowser/gtk/BrowserWindow.c:
1113         (webViewDecidePolicy):
1114         (newTabCallback):
1115         * MiniBrowser/gtk/main.c:
1116         (createBrowserTab):
1117         (aboutDataRequestFree):
1118         (aboutDataRequestNew):
1119         (aboutDataRequestForView):
1120         (websiteDataRemovedCallback):
1121         (websiteDataClearedCallback):
1122         (aboutDataScriptMessageReceivedCallback):
1123         (domainListFree):
1124         (aboutDataFillTable):
1125         (gotWebsiteDataCallback):
1126         (aboutDataHandleRequest):
1127         (aboutURISchemeRequestCallback):
1128         (main):
1129         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1130         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1131         (serverCallback):
1132         (beforeAll):
1133         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1134         (serverCallback):
1135         (WebsiteDataTest::WebsiteDataTest):
1136         (WebsiteDataTest::~WebsiteDataTest):
1137         (WebsiteDataTest::fetch):
1138         (WebsiteDataTest::remove):
1139         (WebsiteDataTest::clear):
1140         (testWebsiteDataConfiguration):
1141         (testWebsiteDataCache):
1142         (testWebsiteDataStorage):
1143         (testWebsiteDataDatabases):
1144         (testWebsiteDataAppcache):
1145         (beforeAll):
1146         (afterAll):
1147
1148 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1149
1150         Unreviewed, rolling out r211062.
1151         https://bugs.webkit.org/show_bug.cgi?id=167354
1152
1153         broke API tests (Requested by alexchristensen on #webkit).
1154
1155         Reverted changeset:
1156
1157         "Pass down website autoplay policies to media elements"
1158         https://bugs.webkit.org/show_bug.cgi?id=167132
1159         http://trac.webkit.org/changeset/211062
1160
1161 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1162
1163         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1164         https://bugs.webkit.org/show_bug.cgi?id=167330
1165
1166         Reviewed by Tim Horton.
1167
1168         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1169         (TestWebKitAPI::TEST_F):
1170
1171 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1172
1173         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1174         https://bugs.webkit.org/show_bug.cgi?id=167317
1175
1176         Reviewed by Sam Weinig.
1177
1178         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1179         (TestWebKitAPI::TEST_F):
1180
1181 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1182
1183         svn-create-patch should emit properties when files are moved or copied
1184         https://bugs.webkit.org/show_bug.cgi?id=167264
1185
1186         Reviewed by Daniel Bates.
1187
1188         * Scripts/svn-create-patch:
1189         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1190
1191 2017-01-23  Youenn Fablet  <youenn@apple.com>
1192
1193         [WebRTC] Filter libwebrtc link flags
1194         https://bugs.webkit.org/show_bug.cgi?id=167287
1195
1196         Reviewed by Alex Christensen.
1197
1198         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1199         (CMakeGenerator._compute_link_flags):
1200         (CMakeGenerator._compute_link_flags.keep_flag):
1201         (CMakeGenerator._generate_compile_target_options):
1202
1203 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1204
1205         [WebRTC] Make VP8 optional in libwebrtc
1206         https://bugs.webkit.org/show_bug.cgi?id=167257
1207
1208         Reviewed by Darin Adler.
1209
1210         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1211         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1212
1213 2017-01-23  Jer Noble  <jer.noble@apple.com>
1214
1215         Video details does not apear and missing scrubber in Control Center
1216         https://bugs.webkit.org/show_bug.cgi?id=167233
1217
1218         Reviewed by Alex Christensen.
1219
1220         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1221         NowPlayingControlTests for iOS.
1222
1223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1224         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1225         (-[NowPlayingTestWebView setWindowVisible:]):
1226         (TestWebKitAPI::TEST):
1227         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1228         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1229         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1230         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1231         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1232         (SOFT_LINK_CLASS):
1233         (-[TestMessageHandler addMessage:withHandler:]):
1234         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1235         (__simulated_forceClickAssociatedEventsMask):
1236         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1237         (-[TestWKWebViewHostWindow isKeyWindow]):
1238         (-[TestWKWebViewHostWindow makeKeyWindow]):
1239         (-[TestWKWebViewHostWindow resignKeyWindow]):
1240         (-[TestWKWebView initWithFrame:]):
1241         (-[TestWKWebView initWithFrame:configuration:]):
1242         (-[TestWKWebView _setUpTestWindow:]):
1243         (-[TestWKWebView performAfterReceivingMessage:action:]):
1244         (-[TestWKWebView loadTestPageNamed:]):
1245         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1246         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1247         (-[TestWKWebView waitForMessage:]):
1248         (-[TestWKWebView performAfterLoading:]):
1249         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1250         (-[TestWKWebView typeCharacter:]):
1251
1252 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1253
1254         Unreviewed. Bring back gtk-doc error messages after r209981.
1255
1256         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1257         impossible to know what's wrong.
1258
1259         * gtk/gtkdoc.py:
1260         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1261
1262 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1263
1264         [WebRTC] Update build system to make G711 optional in libwebrtc
1265         https://bugs.webkit.org/show_bug.cgi?id=167256
1266
1267         Reviewed by Alex Christensen.
1268
1269         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1270         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1271
1272 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1273
1274         Cleanup RuntimeEnabledFeatures
1275         https://bugs.webkit.org/show_bug.cgi?id=167228
1276
1277         Reviewed by Simon Fraser.
1278
1279         * DumpRenderTree/mac/DumpRenderTree.mm:
1280         (enableExperimentalFeatures):
1281         (resetWebPreferencesToConsistentValues):
1282         (setWebPreferencesForTestOptions):
1283         (resetWebViewToConsistentStateBeforeTesting):
1284         * DumpRenderTree/win/DumpRenderTree.cpp:
1285         (enableExperimentalFeatures):
1286         (resetWebPreferencesToConsistentValues):
1287         More closely match WebKitTestRunner initialization of preferences
1288         for experimental features.
1289
1290 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1291
1292         Build Fix for Windows DumpRenderTree after r210976
1293         https://bugs.webkit.org/show_bug.cgi?id=167115
1294
1295         * DumpRenderTree/win/DumpRenderTree.cpp:
1296         (resetWebPreferencesToConsistentValues):
1297
1298 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1299
1300         Remove outdated ENABLE(CSP_NEXT) build flag
1301         https://bugs.webkit.org/show_bug.cgi?id=167252
1302
1303         Reviewed by Brent Fulgham.
1304
1305         * Scripts/webkitperl/FeatureList.pm:
1306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1307
1308 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1309
1310         Build Fix for Windows DumpRenderTree after r210976
1311
1312         * DumpRenderTree/win/DumpRenderTree.cpp:
1313         (resetWebPreferencesToConsistentValues):
1314
1315 2017-01-20  Antoine Quint  <graouts@apple.com>
1316
1317         Web Animations should be off by default and enabled as an experimental feature
1318         https://bugs.webkit.org/show_bug.cgi?id=167115
1319         <rdar://problem/30048963>
1320
1321         Reviewed by Joseph Pecoraro.
1322
1323         Turn Web Animations on in DRT.
1324
1325         * DumpRenderTree/mac/DumpRenderTree.mm:
1326         (resetWebPreferencesToConsistentValues):
1327         * DumpRenderTree/win/DumpRenderTree.cpp:
1328         (resetWebPreferencesToConsistentValues):
1329
1330 2017-01-20  Youenn Fablet  <youenn@apple.com>
1331
1332         [WebRTC] Add libwebrtc build infrastructure
1333         https://bugs.webkit.org/show_bug.cgi?id=167207
1334
1335         Reviewed by Alex Christensen.
1336
1337         Adding a script doing the libwebrtc project json to CMake file conversion.
1338
1339         * Scripts/generate-libwebrtc-cmake: Added.
1340         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1341         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1342
1343 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1344
1345         Mini Browser: Show tooltip for Experimental Features
1346         https://bugs.webkit.org/show_bug.cgi?id=167225
1347
1348         Reviewed by Alex Christensen.
1349
1350         * MiniBrowser/mac/SettingsController.m:
1351         (-[SettingsController _populateMenu]):
1352         Include the full details string as a tooltip.
1353
1354 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1355
1356         [Win] Test output results should not be written twice.
1357         https://bugs.webkit.org/show_bug.cgi?id=167197
1358
1359         Reviewed by Brent Fulgham.
1360
1361         Prevent test output from being written twice by returning early from
1362         the dump() function, if it already has been called.
1363         This patch also adds a missing newline to a test output line. 
1364         
1365         * DumpRenderTree/win/DumpRenderTree.cpp:
1366         (dump):
1367
1368 2017-01-20  Antoine Quint  <graouts@apple.com>
1369
1370         [Modern Media Controls] Turn modern media controls on by default
1371         https://bugs.webkit.org/show_bug.cgi?id=165668
1372
1373         Reviewed by Dean Jackson.
1374
1375         Enabled modern media controls by default in test runners.
1376
1377         * DumpRenderTree/TestOptions.h:
1378         * WebKitTestRunner/TestOptions.h:
1379
1380 2017-01-19  Chris Dumez  <cdumez@apple.com>
1381
1382         iterable<> should be enabled on WK1
1383         https://bugs.webkit.org/show_bug.cgi?id=167221
1384         <rdar://problem/30108531>
1385
1386         Reviewed by Youenn Fablet.
1387
1388         * DumpRenderTree/mac/DumpRenderTree.mm:
1389         (resetWebPreferencesToConsistentValues):
1390         * DumpRenderTree/win/DumpRenderTree.cpp:
1391         (resetWebPreferencesToConsistentValues):
1392         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1393         (WTR::InjectedBundle::beginTesting):
1394         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1395         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1396         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1397
1398 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1399
1400         Ensure status server logs go to log file
1401         https://bugs.webkit.org/show_bug.cgi?id=167210
1402
1403         Reviewed by Alexey Proskuryakov.
1404
1405         * Scripts/webkitpy/common/net/statusserver.py:
1406         (StatusServer.next_work_item): Change log level from debug to info in
1407         order to facilitate deubgging issues.
1408         (StatusServer.update_work_items): Same.
1409
1410 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1411
1412         Additional selection tests and interpolation fix
1413         https://bugs.webkit.org/show_bug.cgi?id=167171
1414
1415         Reviewed by Simon Fraser.
1416
1417         We weren't adding the final event when interpolating event streams.
1418
1419         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1420         (-[HIDEventGenerator interpolatedEvents:]):
1421
1422 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1423
1424         [Cocoa] Variation fonts are erroneously disabled on iOS
1425         https://bugs.webkit.org/show_bug.cgi?id=167172
1426
1427         Reviewed by Simon Fraser.
1428
1429         OpenSource builders don't seem to understand sdk=embedded*.
1430
1431         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1432
1433 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1434
1435         Unreviewed. Fix GTK+ unit tests failing since r210531.
1436
1437         Avoid using paths to files that don't actually exist.
1438
1439         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1440         (testWebKitConsoleMessageNetworkError):
1441         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1442         (testContextMenuDefaultMenu):
1443         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1444         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1445         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1446
1447 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1448
1449         [GTK] Provide API to set proxy settings
1450         https://bugs.webkit.org/show_bug.cgi?id=128674
1451
1452         Reviewed by Michael Catanzaro.
1453
1454         Add tests for new proxy settings API.
1455
1456         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1457         (serverCallback):
1458         (ProxyTest::ProxyTest):
1459         (ProxyTest::~ProxyTest):
1460         (ProxyTest::loadURIAndGetMainResourceData):
1461         (ProxyTest::proxyServerPortAsString):
1462         (testWebContextProxySettings):
1463         (beforeAll):
1464
1465 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1466
1467         Add back my old email address so old commits will still match it.
1468
1469         * Scripts/webkitpy/common/config/contributors.json:
1470
1471 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1472
1473         Remove my old email address from contributors.json and watchlist.
1474
1475         * Scripts/validate-committer-lists:
1476         (CommitterListFromGit): Change the mapping to the correct email.
1477         * Scripts/webkitpy/common/config/contributors.json:
1478         * Scripts/webkitpy/common/config/watchlist:
1479
1480 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1481
1482         Unreviewed, rolling out r210848.
1483
1484         This change introduced media-related LayoutTest failures and
1485         crashes on macOS.
1486
1487         Reverted changeset:
1488
1489         "[Modern Media Controls] Turn modern media controls on by
1490         default"
1491         https://bugs.webkit.org/show_bug.cgi?id=165668
1492         http://trac.webkit.org/changeset/210848
1493
1494 2017-01-18  Andreas Kling  <akling@apple.com>
1495
1496         Document::securityOrigin() should return a reference.
1497         <https://webkit.org/b/167124>
1498
1499         Reviewed by Sam Weinig.
1500
1501         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1502         (TestWebKitAPI::TEST_F):
1503
1504 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1505
1506         [Win] Clipboard tests are flaky.
1507         https://bugs.webkit.org/show_bug.cgi?id=167088
1508
1509         Reviewed by Brent Fulgham.
1510
1511         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1512         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1513
1514         * DumpRenderTree/win/DumpRenderTree.cpp:
1515         (main):
1516
1517 2017-01-18  Antoine Quint  <graouts@apple.com>
1518
1519         [Modern Media Controls] Turn modern media controls on by default
1520         https://bugs.webkit.org/show_bug.cgi?id=165668
1521
1522         Reviewed by Dean Jackson.
1523
1524         Enabled modern media controls by default in test runners. 
1525
1526         * DumpRenderTree/TestOptions.h:
1527         * WebKitTestRunner/TestOptions.h:
1528
1529 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1530
1531         Unreviewed, rolling out r210834
1532         https://bugs.webkit.org/show_bug.cgi?id=165668
1533
1534         It introduced dozens of test timeouts.
1535
1536         Reverted changeset:
1537         "[Modern Media Controls] Turn modern media controls on by default"
1538         https://bugs.webkit.org/show_bug.cgi?id=165668
1539         http://trac.webkit.org/changeset/210834
1540
1541 2017-01-17  Antoine Quint  <graouts@apple.com>
1542
1543         [Modern Media Controls] Turn modern media controls on by default
1544         https://bugs.webkit.org/show_bug.cgi?id=165668
1545
1546         Reviewed by Dean Jackson.
1547
1548         Enabled modern media controls by default in test runners. 
1549
1550         * DumpRenderTree/TestOptions.h:
1551         * WebKitTestRunner/TestOptions.h:
1552
1553 2017-01-17  Chris Dumez  <cdumez@apple.com>
1554
1555         Document title changed twice when setting document.title
1556         https://bugs.webkit.org/show_bug.cgi?id=167065
1557
1558         Reviewed by Darin Adler.
1559
1560         Add WebKit2GTK API test that was written by Michael Catanzaro.
1561
1562         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1563         (testWebViewTitleChange):
1564         (beforeAll):
1565
1566 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1567
1568         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1569         https://bugs.webkit.org/show_bug.cgi?id=116551
1570         <rdar://problem/13949830>
1571
1572         Reviewed by Alex Christensen.
1573
1574         * Scripts/webkitperl/FeatureList.pm:
1575         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1576         that is part of the existing WEB_TIMING feature.
1577
1578         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1579
1580 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1581
1582         'webkit-patch post' no longer works with moved/copied files
1583         https://bugs.webkit.org/show_bug.cgi?id=166914
1584         <rdar://problem/29979707>
1585
1586         Reviewed by Daniel Bates.
1587
1588         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1589         file outputs only the "Index:" line with an empty body.  This workaround
1590         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1591         public email list tracking this bug is below.
1592         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1593         
1594
1595         * Scripts/svn-create-patch:
1596         (generateDiff): Ignore an "Index:" line with an empty body.
1597
1598 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1599
1600         Remove the REQUEST_ANIMATION_FRAME flag
1601         https://bugs.webkit.org/show_bug.cgi?id=156980
1602         <rdar://problem/25906849>
1603
1604         Reviewed by Simon Fraser.
1605
1606         * Scripts/webkitperl/FeatureList.pm:
1607         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1608
1609 2017-01-15  Sam Weinig  <sam@webkit.org>
1610
1611         Add the ability to use numbers in makeString()
1612         https://bugs.webkit.org/show_bug.cgi?id=167087
1613
1614         Reviewed by Darin Adler.
1615
1616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1617         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1618         Add tests for StringConcatenate, focusing on new numeric additions.
1619
1620 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1621
1622         Unreviewed, remove stale comment.
1623
1624         This test was fixed by r163173.
1625
1626         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1627
1628 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1629
1630         Annotate large string tests with largeHeap
1631         https://bugs.webkit.org/show_bug.cgi?id=167054
1632
1633         Reviewed by Filip Pizlo.
1634
1635         * Scripts/run-javascriptcore-tests:
1636         * Scripts/run-jsc-stress-tests:
1637
1638 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1639
1640         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1641         https://bugs.webkit.org/show_bug.cgi?id=167043
1642
1643         Reviewed by Darin Adler.
1644
1645         * Scripts/webkitperl/FeatureList.pm:
1646
1647 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1648
1649         Remove ENABLE(DETAILS_ELEMENT) guards
1650         https://bugs.webkit.org/show_bug.cgi?id=167042
1651
1652         Reviewed by Alex Christensen.
1653
1654         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1655
1656 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1657
1658         26 MotionMark performance tests failing
1659         https://bugs.webkit.org/show_bug.cgi?id=166854
1660
1661         Reviewed by Ryosuke Niwa.
1662
1663         Unrelated change. This is the last place that we need to rename Animometer
1664         to MotionMark.
1665
1666         * Scripts/webkitpy/common/config/watchlist:
1667
1668 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1669
1670         run-jsc-benchmarks' echo should have -e option
1671         https://bugs.webkit.org/show_bug.cgi?id=167009
1672
1673         Reviewed by Sam Weinig.
1674
1675         echo requires `-e` option to use escape sequence.
1676         Without it, in some environment (in my Fedora 25), the escape sequence is not
1677         recognized and just dumped as `\c` etc.
1678
1679         * Scripts/run-jsc-benchmarks:
1680
1681 2017-01-12  Chris Dumez  <cdumez@apple.com>
1682
1683         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1684         https://bugs.webkit.org/show_bug.cgi?id=166995
1685
1686         Reviewed by Jer Noble.
1687
1688         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1689         as some people are having trouble building without it.
1690
1691         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1692
1693 2017-01-12  Sam Weinig  <sam@webkit.org>
1694
1695         Add the ability to filter the set of bindings tests you want to run
1696         https://bugs.webkit.org/show_bug.cgi?id=166977
1697
1698         Reviewed by Tim Horton.
1699
1700         Allows doing things like:
1701             run-bindings-tests TestObj* TestCEReactions*
1702         
1703         to run only those tests that match the patterns.
1704
1705         * Scripts/run-bindings-tests:
1706         (main):
1707         Switch to using optparse and pass the remaining args as the filters.
1708
1709         * Scripts/webkitpy/bindings/main.py:
1710         (BindingsTests.__init__):
1711         Store the pattens.
1712
1713         (BindingsTests.test_matches_patterns):
1714         Add helper predicate to determine if a test should be run. When no
1715         patterns are present, all tests should run.
1716
1717         (BindingsTests.run_tests):
1718         Filter tests using the passed in patterns.
1719
1720 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1721
1722         Followup fix after r210503.
1723         https://bugs.webkit.org/show_bug.cgi?id=166887
1724
1725         Reviewed by Alex Christensen.
1726
1727         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1728         duplicated file handle on Windows. This patch fixes the remaining call sites.
1729
1730         * DumpRenderTree/PixelDumpSupport.cpp:
1731         * DumpRenderTree/TestRunner.cpp:
1732         (TestRunner::waitToDumpWatchdogTimerFired):
1733         * DumpRenderTree/TestRunner.h:
1734         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1735         * DumpRenderTree/win/DumpRenderTree.cpp:
1736         * DumpRenderTree/win/DumpRenderTreeWin.h:
1737         * DumpRenderTree/win/TestRunnerWin.cpp:
1738         (TestRunner::setSpellCheckerLoggingEnabled):
1739
1740 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1741
1742         Add committer status for Megan
1743         https://bugs.webkit.org/show_bug.cgi?id=166954
1744
1745         Reviewed by Tim Horton.
1746
1747         Add committer status for Megan Gardner
1748
1749         * Scripts/webkitpy/common/config/contributors.json:
1750
1751 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1752
1753         Unreviewed test fix after r210599.
1754
1755         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1756         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1757
1758 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1759
1760         Unreviewed build fix after r210599.
1761
1762         Add missing files.
1763
1764         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1765         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1766
1767 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1768
1769         File scheme should not allow access of a resource on a different volume.
1770         https://bugs.webkit.org/show_bug.cgi?id=158552
1771         <rdar://problem/15307582>
1772
1773         Reviewed by Alex Christensen.
1774
1775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1776         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1777         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1778
1779 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1780
1781         Unreviewed, rolling out r210571.
1782
1783         This change broke the 32-bit macOS build and caused LayoutTest
1784         failures.
1785
1786         Reverted changeset:
1787
1788         "File scheme should not allow access of a resource on a
1789         different volume."
1790         https://bugs.webkit.org/show_bug.cgi?id=158552
1791         http://trac.webkit.org/changeset/210571
1792
1793 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1794
1795         [GTK] install-dependencies script misses gdb
1796         https://bugs.webkit.org/show_bug.cgi?id=166917
1797
1798         Reviewed by Michael Catanzaro.
1799
1800         gdb is needed for generating the crash logs.
1801
1802         * gtk/install-dependencies:
1803
1804 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1805
1806         [GTK] No way for applications to set notification permissions without waiting for permission request
1807         https://bugs.webkit.org/show_bug.cgi?id=163366
1808
1809         Reviewed by Carlos Garcia Campos.
1810
1811         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1812         (testWebViewNotification):
1813         (setInitialNotificationPermissionsAllowedCallback):
1814         (setInitialNotificationPermissionsDisallowedCallback):
1815         (testWebViewNotificationInitialPermissionAllowed):
1816         (testWebViewNotificationInitialPermissionDisallowed):
1817         (beforeAll):
1818         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1819         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1820         (WebViewTest::WebViewTest):
1821         (WebViewTest::initializeWebView):
1822         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1823
1824 2017-01-10  Tim Horton  <timothy_horton@apple.com>
1825
1826         MobileMiniBrowser tests don't work by default
1827         https://bugs.webkit.org/show_bug.cgi?id=166910
1828
1829         Reviewed by Alex Christensen.
1830
1831         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
1832         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
1833
1834 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
1835
1836         File scheme should not allow access of a resource on a different volume.
1837         https://bugs.webkit.org/show_bug.cgi?id=158552
1838         <rdar://problem/15307582>
1839
1840         Reviewed by Alex Christensen.
1841
1842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1843         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1844         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1845
1846 2017-01-10  Mark Lam  <mark.lam@apple.com>
1847
1848         Reverting run-jsc-stress-tests' $buildType to use string values.
1849         https://bugs.webkit.org/show_bug.cgi?id=166912
1850
1851         Rubber stamped by Filip Pizlo.
1852
1853         This is so that we can test for it in the tests e.g.
1854         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
1855
1856         * Scripts/run-jsc-stress-tests:
1857
1858 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1859
1860         Temporarily add back the file removed in r210463 to unbreak internal bots.
1861
1862         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1863
1864 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
1865
1866         svn-apply failed to apply a patch (deleting file with svn property)
1867         https://bugs.webkit.org/show_bug.cgi?id=165953
1868
1869         Reviewed by Daniel Bates.
1870
1871         * Scripts/VCSUtils.pm:
1872         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
1873         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
1874
1875 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1876
1877         Update flakiness dashboard configuration.
1878         https://bugs.webkit.org/show_bug.cgi?id=166869
1879
1880         Reviewed by Alexey Proskuryakov.
1881
1882         * TestResultServer/static-dashboards/builders.jsonp:
1883         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1884
1885 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1886
1887         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
1888         https://bugs.webkit.org/show_bug.cgi?id=165232
1889
1890         Unreviewed follow-up patch after r210539 and r210523.
1891
1892         Instead of using that environment variable, the argument
1893         --display-server=xorg should be passed now.
1894
1895         The GTK+ performance bot was the only bot using this, and is
1896         already passing --display-server=xorg after r210539.
1897
1898         * Scripts/webkitpy/port/gtk.py:
1899         (GtkPort._driver_class):
1900
1901 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1902
1903         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
1904         https://bugs.webkit.org/show_bug.cgi?id=166872
1905
1906         Reviewed by Michael Catanzaro.
1907
1908         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
1909         Define the required "--display-server=driver" in the bot additionalArguments config entry.
1910         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
1911         The step RunWebKitTests already has support for it.
1912
1913         * BuildSlaveSupport/build.webkit.org-config/config.json:
1914         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1915         (RunGtkAPITests.start):
1916         (RunAndUploadPerfTests.start):
1917         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1918
1919 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
1920
1921         Unreviewed, rolling out r210531.
1922
1923         This change broke the 32-bit macOS build and caused LayoutTest
1924         failures.
1925
1926         Reverted changeset:
1927
1928         "File scheme should not allow access of a resource on a
1929         different volume."
1930         https://bugs.webkit.org/show_bug.cgi?id=158552
1931         http://trac.webkit.org/changeset/210531
1932
1933 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
1934
1935         File scheme should not allow access of a resource on a different volume.
1936         https://bugs.webkit.org/show_bug.cgi?id=158552
1937         <rdar://problem/15307582>
1938
1939         Reviewed by Alex Christensen.
1940
1941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1942         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1943         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1944
1945 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1946
1947         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
1948         https://bugs.webkit.org/show_bug.cgi?id=165232
1949
1950         Reviewed by Michael Catanzaro.
1951
1952         Add a new WaylandDriver to run the tests in the user current wayland session.
1953
1954         Also merge all the configuration options for selecting the display server inside one
1955         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
1956
1957         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
1958
1959         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
1960         (TestRunner._create_driver):
1961         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1962         (parse_args):
1963         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1964         (PerfTestsRunner._parse_args):
1965         * Scripts/webkitpy/port/gtk.py:
1966         (GtkPort.__init__):
1967         (GtkPort._driver_class):
1968         (GtkPort._search_paths):
1969         * Scripts/webkitpy/port/waylanddriver.py: Added.
1970         (WaylandDriver):
1971         (WaylandDriver.check_driver):
1972         (WaylandDriver._setup_environ_for_test):
1973         (WaylandDriver._start):
1974
1975 2017-01-09  Andy Estes  <aestes@apple.com>
1976
1977         [QuickLook] Add a layout test for webkit.org/b/135651
1978         https://bugs.webkit.org/show_bug.cgi?id=166855
1979
1980         Reviewed by Andreas Kling.
1981
1982         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1983         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
1984         errors with code WebKitErrorCannotShowURL.
1985         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1986         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
1987         not specific to WebKit2 error codes.
1988
1989 2017-01-09  Antoine Quint  <graouts@apple.com>
1990
1991         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
1992         https://bugs.webkit.org/show_bug.cgi?id=166837
1993
1994         Reviewed by Alex Christensen.
1995
1996         We now correctly handle the --absolutePath argument in DumpRenderTree and use
1997         the provided value when trying to determine the path to the test file. Failing
1998         that, we use the computed URL or the raw path provided to cover all cases.
1999         
2000         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2001         by applying this patch and seeing the number test failures dramatically reduced
2002         with WK1 due to the option to turn modern media controls off for older media controls
2003         tests.
2004
2005         * DumpRenderTree/DumpRenderTree.h:
2006         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2007         (parseInputLine):
2008         * DumpRenderTree/TestOptions.h:
2009         * DumpRenderTree/TestOptions.mm:
2010         (TestOptions::TestOptions):
2011         * DumpRenderTree/mac/DumpRenderTree.mm:
2012         (runTest):
2013
2014 2017-01-09  Milan Crha  <mcrha@redhat.com>
2015
2016         prepare-ChangeLog: Correct help string for --style option
2017         https://bugs.webkit.org/show_bug.cgi?id=166725
2018
2019         Reviewed by Alexey Proskuryakov.
2020
2021         * Scripts/prepare-ChangeLog:
2022         (main):
2023
2024 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2025
2026         https://bugs.webkit.org/show_bug.cgi?id=166839
2027         Add php7 support for macOS.
2028         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2029
2030         Reviewed by Alexey Proskuryakov.
2031
2032         * Scripts/webkitpy/port/base.py:
2033         (Port._is_darwin_php_version_7):
2034         (Port._debian_php_version):
2035         (Port):
2036         (Port._darwin_php_version):
2037         (Port._apache_config_file_name_for_platform):
2038
2039 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2040
2041         [GTK] Should support key and code properties on keyboard events
2042         https://bugs.webkit.org/show_bug.cgi?id=166759
2043
2044         Reviewed by Carlos Garcia Campos.
2045
2046         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2047         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2048         on tests.
2049
2050 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2051
2052         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2053         https://bugs.webkit.org/show_bug.cgi?id=166760
2054
2055         Reviewed by Darin Adler.
2056
2057         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2058         We can work around that by duplicating and redirecting stdout.
2059
2060         * DumpRenderTree/PixelDumpSupport.cpp:
2061         (dumpWebViewAsPixelsAndCompareWithExpected):
2062         (printPNG):
2063         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2064         (logEventProc):
2065         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2066         (DRTDesktopNotificationPresenter::showDesktopNotification):
2067         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2068         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2069         * DumpRenderTree/win/DumpRenderTree.cpp:
2070         (dumpFrameScrollPosition):
2071         (dumpHistoryItem):
2072         (dumpBackForwardList):
2073         (dump):
2074         (runTest):
2075         (main):
2076         * DumpRenderTree/win/DumpRenderTreeWin.h:
2077         * DumpRenderTree/win/EditingDelegate.cpp:
2078         (EditingDelegate::shouldBeginEditingInDOMRange):
2079         (EditingDelegate::shouldEndEditingInDOMRange):
2080         (EditingDelegate::shouldInsertNode):
2081         (EditingDelegate::shouldInsertText):
2082         (EditingDelegate::shouldDeleteDOMRange):
2083         (EditingDelegate::shouldChangeSelectedDOMRange):
2084         (EditingDelegate::shouldApplyStyle):
2085         (EditingDelegate::shouldChangeTypingStyle):
2086         (EditingDelegate::doPlatformCommand):
2087         (EditingDelegate::webViewDidBeginEditing):
2088         (EditingDelegate::webViewDidChange):
2089         (EditingDelegate::webViewDidEndEditing):
2090         (EditingDelegate::webViewDidChangeTypingStyle):
2091         (EditingDelegate::webViewDidChangeSelection):
2092         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2093         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2094         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2095         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2096         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2097         (FrameLoadDelegate::didCommitLoadForFrame):
2098         (FrameLoadDelegate::didReceiveTitle):
2099         (FrameLoadDelegate::didFinishLoadForFrame):
2100         (FrameLoadDelegate::didFailLoadWithError):
2101         (FrameLoadDelegate::willPerformClientRedirectToURL):
2102         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2103         (FrameLoadDelegate::windowScriptObjectAvailable):
2104         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2105         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2106         (FrameLoadDelegate::didDisplayInsecureContent):
2107         (FrameLoadDelegate::didRunInsecureContent):
2108         (FrameLoadDelegate::webViewProgressFinishedNotification):
2109         * DumpRenderTree/win/HistoryDelegate.cpp:
2110         (HistoryDelegate::didNavigateWithNavigationData):
2111         (HistoryDelegate::didPerformClientRedirectFromURL):
2112         (HistoryDelegate::didPerformServerRedirectFromURL):
2113         (HistoryDelegate::updateHistoryTitle):
2114         (HistoryDelegate::populateVisitedLinksForWebView):
2115         * DumpRenderTree/win/PolicyDelegate.cpp:
2116         (PolicyDelegate::decidePolicyForNavigationAction):
2117         (PolicyDelegate::unableToImplementPolicyWithError):
2118         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2119         (ResourceLoadDelegate::willSendRequest):
2120         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2121         (ResourceLoadDelegate::didReceiveResponse):
2122         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2123         (ResourceLoadDelegate::didFailLoadingWithError):
2124         * DumpRenderTree/win/TestRunnerWin.cpp:
2125         (TestRunner::addDisallowedURL):
2126         (TestRunner::originsWithApplicationCache):
2127         (TestRunner::setStorageDatabaseIdleInterval):
2128         (TestRunner::closeIdleLocalStorageDatabases):
2129         (TestRunner::copyDecodedHostName):
2130         (TestRunner::copyEncodedHostName):
2131         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2132         (TestRunner::isGeolocationProviderActive):
2133         (TestRunner::pathToLocalResource):
2134         (TestRunner::setMockDeviceOrientation):
2135         (TestRunner::setMockGeolocationPosition):
2136         (TestRunner::setMockGeolocationPositionUnavailableError):
2137         (TestRunner::setSpatialNavigationEnabled):
2138         (TestRunner::setAutomaticLinkDetectionEnabled):
2139         (TestRunner::isCommandEnabled):
2140         (TestRunner::authenticateSession):
2141         (TestRunner::addChromeInputField):
2142         (TestRunner::removeChromeInputField):
2143         (TestRunner::focusWebView):
2144         (TestRunner::grantWebNotificationPermission):
2145         (TestRunner::denyWebNotificationPermission):
2146         (TestRunner::removeAllWebNotificationPermissions):
2147         (TestRunner::simulateWebNotificationClick):
2148         (TestRunner::imageCountInGeneralPasteboard):
2149         * DumpRenderTree/win/UIDelegate.cpp:
2150         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2151         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2152         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2153         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2154         (UIDelegate::webViewAddMessageToConsole):
2155         (UIDelegate::exceededDatabaseQuota):
2156         (UIDelegate::setStatusText):
2157         (UIDelegate::didPressMissingPluginButton):
2158
2159 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2160
2161         Add a setting to create editable MiniBrowser windows by default
2162         https://bugs.webkit.org/show_bug.cgi?id=166806
2163
2164         Reviewed by Beth Dakin.
2165
2166         * MiniBrowser/mac/AppDelegate.m:
2167         (-[BrowserAppDelegate createBrowserWindowController:]):
2168         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2169         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2170         * MiniBrowser/mac/SettingsController.h:
2171         * MiniBrowser/mac/SettingsController.m:
2172         (-[SettingsController _populateMenu]):
2173         (-[SettingsController validateMenuItem:]):
2174         (-[SettingsController toggleCreateEditorByDefault:]):
2175         (-[SettingsController createEditorByDefault]):
2176         Add a setting and update the key equivalents accordingly.
2177         Also make sure to make the right kind of window on launch.
2178
2179 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2180
2181         Fix the 32-bit build.
2182
2183         * MiniBrowser/mac/BrowserWindowController.h:
2184         * MiniBrowser/mac/BrowserWindowController.m:
2185
2186 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2187
2188         Fix the 32-bit build.
2189
2190         * MiniBrowser/mac/BrowserWindowController.m:
2191
2192 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2193
2194         Make it possible to drop HTML files on the MiniBrowser icon
2195         https://bugs.webkit.org/show_bug.cgi?id=166802
2196
2197         Reviewed by Simon Fraser.
2198
2199         * MiniBrowser/mac/AppDelegate.m:
2200         (-[BrowserAppDelegate application:openFile:]):
2201         * MiniBrowser/mac/Info.plist:
2202         If you're using an editable window, the usual trick of dropping on the
2203         window doesn't work anymore (it makes an <attachment> instead).
2204
2205 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2206
2207         MiniBrowser window gets smaller each time it is instantiated
2208         https://bugs.webkit.org/show_bug.cgi?id=166807
2209
2210         Reviewed by Andy Estes.
2211
2212         * MiniBrowser/mac/BrowserWindowController.m:
2213         (-[BrowserWindowController windowDidLoad]):
2214         * MiniBrowser/mac/BrowserWindow.xib:
2215         Turn on full-window content view support with IB, instead of waiting
2216         until after the views have been loaded. This seems to resolve the
2217         longstanding ever-shrinking-window problem.
2218
2219 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2220
2221         Add indent/outdent items to MiniBrowser's new format menu
2222         https://bugs.webkit.org/show_bug.cgi?id=166805
2223
2224         Reviewed by Dan Bernstein.
2225
2226         * MiniBrowser/mac/MainMenu.xib:
2227
2228 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2229
2230         Add a stock Format menu to MiniBrowser
2231         https://bugs.webkit.org/show_bug.cgi?id=166804
2232
2233         Reviewed by Andy Estes.
2234
2235         * MiniBrowser/mac/MainMenu.xib:
2236         Many of the features automatically work with editable web views.
2237         However, this seems to expose a bug where none of the font-related features
2238         (Cmd-B, for example) work until the first time the font panel is shown,
2239         per process, which will need to be investigated separately.
2240
2241 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2242
2243         Remove unused applicationWillTerminate methods from MiniBrowser
2244         https://bugs.webkit.org/show_bug.cgi?id=166803
2245
2246         Reviewed by Andy Estes.
2247
2248         * MiniBrowser/mac/AppDelegate.m:
2249         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2250         * MiniBrowser/mac/BrowserWindowController.h:
2251         * MiniBrowser/mac/BrowserWindowController.m:
2252         (-[BrowserWindowController applicationTerminating]): Deleted.
2253         * MiniBrowser/mac/WK1BrowserWindowController.m:
2254         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2255         * MiniBrowser/mac/WK2BrowserWindowController.m:
2256         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2257
2258 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2259
2260         Add the ability to create empty contentEditable windows in MiniBrowser
2261         https://bugs.webkit.org/show_bug.cgi?id=166801
2262
2263         Reviewed by Wenson Hsieh.
2264
2265         * MiniBrowser/mac/AppDelegate.h:
2266         * MiniBrowser/mac/AppDelegate.m:
2267         (-[BrowserAppDelegate createBrowserWindowController:]):
2268         (-[BrowserAppDelegate newWindow:]):
2269         (-[BrowserAppDelegate newEditorWindow:]):
2270         (-[BrowserAppDelegate openDocument:]):
2271         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2272         * MiniBrowser/mac/BrowserWindowController.h:
2273         * MiniBrowser/mac/BrowserWindowController.m:
2274         (-[BrowserWindowController loadHTMLString:]):
2275         (-[BrowserWindowController toggleEditable:]):
2276         * MiniBrowser/mac/MainMenu.xib:
2277         * MiniBrowser/mac/WK1BrowserWindowController.m:
2278         (-[WK1BrowserWindowController awakeFromNib]):
2279         (-[WK1BrowserWindowController loadHTMLString:]):
2280         (-[WK1BrowserWindowController validateMenuItem:]):
2281         (-[WK1BrowserWindowController setEditable:]):
2282         (-[WK1BrowserWindowController updateTitle:]):
2283         * MiniBrowser/mac/WK2BrowserWindowController.m:
2284         (-[WK2BrowserWindowController awakeFromNib]):
2285         (-[WK2BrowserWindowController validateMenuItem:]):
2286         (-[WK2BrowserWindowController setEditable:]):
2287         (-[WK2BrowserWindowController updateTitle:]):
2288         (-[WK2BrowserWindowController loadHTMLString:]):
2289         Merge more functionality from WebEditingTester.
2290         Add two menu items for creating empty editable WebKit1/2 windows.
2291         Add a menu item to the Edit menu to toggle editability on any window.
2292
2293 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2294
2295         Implement find-in-page in MiniBrowser
2296         https://bugs.webkit.org/show_bug.cgi?id=166799
2297
2298         Reviewed by Andy Estes.
2299
2300         * MiniBrowser/mac/BrowserWindow.xib:
2301         * MiniBrowser/mac/BrowserWindowController.h:
2302         * MiniBrowser/mac/BrowserWindowController.m:
2303         (-[BrowserWindowController find:]): Deleted.
2304         * MiniBrowser/mac/MainMenu.xib:
2305         * MiniBrowser/mac/WK1BrowserWindowController.m:
2306         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2307         (-[WK1BrowserWindowController find:]): Deleted.
2308         * MiniBrowser/mac/WK2BrowserWindowController.m:
2309         (-[WK2BrowserWindowController awakeFromNib]):
2310         (-[WK2BrowserWindowController dealloc]):
2311         (-[WK2BrowserWindowController validateMenuItem:]):
2312         (-[WK2BrowserWindowController performTextFinderAction:]):
2313         (-[WK2BrowserWindowController findBarView]):
2314         (-[WK2BrowserWindowController setFindBarView:]):
2315         (-[WK2BrowserWindowController isFindBarVisible]):
2316         (-[WK2BrowserWindowController setFindBarVisible:]):
2317         (-[WK2BrowserWindowController contentView]):
2318         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2319         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2320         (-[WK2BrowserWindowController find:]): Deleted.
2321         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2322         protocol. At first glance, it's pretty broken, but vaguely works.
2323
2324 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2325
2326         Share the implementation of MiniBrowser view hiding functionality
2327         https://bugs.webkit.org/show_bug.cgi?id=166800
2328
2329         Reviewed by Andy Estes.
2330
2331         * MiniBrowser/mac/BrowserWindowController.m:
2332         (-[BrowserWindowController showHideWebView:]):
2333         (-[BrowserWindowController removeReinsertWebView:]):
2334         * MiniBrowser/mac/WK1BrowserWindowController.m:
2335         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2336         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2337         * MiniBrowser/mac/WK2BrowserWindowController.m:
2338         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2339         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2340         Move the implementation of these two things to the shared superclass,
2341         since they don't depend on WebKit-specific things.
2342         Also, there was no reason to retain the (WK)WebView while it was unparented,
2343         as the BrowserWindowController maintains a reference the entire time.
2344
2345 2017-01-06  Andy Estes  <aestes@apple.com>
2346
2347         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2348         https://bugs.webkit.org/show_bug.cgi?id=166789
2349
2350         Reviewed by Alex Christensen.
2351
2352         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2353         * DumpRenderTree/PlatformMac.cmake:
2354         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2355         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2356         * DumpRenderTree/mac/DumpRenderTree.mm:
2357         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2358         createXMLStringFromWebArchiveData().
2359         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2360         * WebKitTestRunner/Configurations/Base.xcconfig:
2361         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2362         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2363         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2364         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2365         createXMLStringFromWebArchiveData().
2366         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2367         * WebKitTestRunner/PlatformMac.cmake:
2368         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2369         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2370
2371 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2372
2373         Minor cleanups to IndentOutdentCommand and related code
2374         https://bugs.webkit.org/show_bug.cgi?id=166791
2375
2376         Reviewed by Simon Fraser.
2377
2378         * WebEditingTester/EditingOperations.m:
2379         (editingOperations):
2380         Add the outdent operation to WebEditingTester.
2381
2382 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2383
2384         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2385         https://bugs.webkit.org/show_bug.cgi?id=166785
2386
2387         Reviewed by Ryosuke Niwa.
2388
2389         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2390         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2391
2392 2017-01-06  Antoine Quint  <graouts@apple.com>
2393
2394         Support webkit-test-runner key-value pairs in http tests
2395         https://bugs.webkit.org/show_bug.cgi?id=149812
2396
2397         Reviewed by Alex Christensen.
2398
2399         We pass the absolute path for a test through to WKTR so that we can parse
2400         tests that are running as URLs for webkit-test-runner options.
2401
2402         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2403         (parseInputLine):
2404
2405         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2406
2407         * Scripts/webkitpy/port/driver.py:
2408         (Driver._command_from_driver_input):
2409
2410         Pass the absolute path to the file through the CLI.
2411
2412         * WebKitTestRunner/TestController.cpp:
2413         (WTR::updateTestOptionsFromTestHeader):
2414         (WTR::TestController::testOptionsForTest):
2415         (WTR::parseInputLine):
2416         (WTR::TestController::runTest):
2417         * WebKitTestRunner/TestController.h:
2418
2419 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2420
2421         Warning about unconnectable outlets when opening a MiniBrowser window
2422         https://bugs.webkit.org/show_bug.cgi?id=166756
2423
2424         Reviewed by Dan Bernstein.
2425
2426         * MiniBrowser/mac/BrowserWindow.xib:
2427         When launching MiniBrowser, it says:
2428         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2429             (MBToolbarItem): missing setter or instance variable
2430         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2431             (NSButtonCell): missing setter or instance variable.
2432
2433         It looks like someone added the connection from the share button
2434         to the BrowserWindowController three times; only one of the connections
2435         is valid. Remove the other two.
2436
2437 2017-01-05  Keith Rollin  <krollin@apple.com>
2438
2439         Add WebCore::URL::protocolHostAndPort
2440         https://bugs.webkit.org/show_bug.cgi?id=166426
2441
2442         Reviewed by Alex Christensen.
2443
2444         Add test for protocolHostAndPort.
2445
2446         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2447         (TestWebKitAPI::TEST_F):
2448
2449 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2450
2451         [Win] Archive test result is failing.
2452         https://bugs.webkit.org/show_bug.cgi?id=166720
2453
2454         Reviewed by Alex Christensen.
2455
2456         Deleting the layout test result folder is sometimes failing
2457         on Windows. This is not a critical error.
2458
2459         * BuildSlaveSupport/test-result-archive:
2460         (archiveTestResults):
2461
2462 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2463
2464         [GTK] Minibrowser: Add printing support
2465         https://bugs.webkit.org/show_bug.cgi?id=165298
2466
2467         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2468         an error during the print, it's printed on the console.
2469
2470         Reviewed by Michael Catanzaro.
2471
2472         * MiniBrowser/gtk/BrowserWindow.c:
2473         (webKitPrintOperationFailedCallback):
2474         (printPage):
2475         (browser_window_init):
2476
2477 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2478
2479         [css-grid] Fix crash clamping grid lines
2480         https://bugs.webkit.org/show_bug.cgi?id=166637
2481
2482         Reviewed by Darin Adler.
2483
2484         Creates new unit test to verify that the maximum tracks limit
2485         is used in GridPosition too.
2486
2487         * TestWebKitAPI/PlatformEfl.cmake:
2488         * TestWebKitAPI/PlatformGTK.cmake:
2489         * TestWebKitAPI/PlatformWin.cmake:
2490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2491         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2492         (TestWebKitAPI::TEST):
2493
2494 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2495
2496         Move editing history scripts to WebCore PrivateHeaders
2497         https://bugs.webkit.org/show_bug.cgi?id=166709
2498         <rdar://problem/29876612>
2499
2500         Reviewed by Dan Bernstein.
2501
2502         Update references to editing script files in WebCore that were moved.
2503
2504         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2505
2506 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2507
2508         Unreviewed, build fix after r210313 part 2
2509         https://bugs.webkit.org/show_bug.cgi?id=166676
2510
2511         Add 'U' suffix.
2512
2513         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2514         (TestWebKitAPI::TEST):
2515         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2516         (TestWebKitAPI::TEST):
2517
2518 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2519
2520         Limit thread name appropriately
2521         https://bugs.webkit.org/show_bug.cgi?id=166676
2522
2523         Reviewed by Sam Weinig.
2524
2525         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2526         (TestWebKitAPI::TEST):
2527         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2528         (TestWebKitAPI::TEST):
2529
2530 2017-01-04  Andy Estes  <aestes@apple.com>
2531
2532         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2533         https://bugs.webkit.org/show_bug.cgi?id=166696
2534
2535         Reviewed by Tim Horton.
2536
2537         * TestWebKitAPI/PlatformGTK.cmake:
2538         * TestWebKitAPI/PlatformWin.cmake:
2539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2540         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2541         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2542         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2543         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2544         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2545         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2546
2547 2017-01-03  Brian Burg  <bburg@apple.com>
2548
2549         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2550         https://bugs.webkit.org/show_bug.cgi?id=166003
2551         <rdar://problem/28718990>
2552
2553         Reviewed by Joseph Pecoraro.
2554
2555         Teach run-inspector-generator-tests to generate test output using the platform name
2556         derived from the directory that the test is in. For example, tests in the /generic/
2557         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2558
2559         * Scripts/webkitpy/inspector/main.py:
2560         (InspectorGeneratorTests.generate_from_json):
2561         (InspectorGeneratorTests.run_tests):
2562         (InspectorGeneratorTests.main):
2563
2564 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2565
2566         Unreviewed cmake buildfix after r210266.
2567
2568         * DumpRenderTree/PlatformMac.cmake:
2569
2570 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2571
2572         Provide a setting for clients to always prefer low-power WebGL
2573         https://bugs.webkit.org/show_bug.cgi?id=166675
2574         <rdar://problem/29834093>
2575
2576         Reviewed by Dan Bernstein.
2577
2578         * MiniBrowser/mac/Info.plist:
2579         Have MiniBrowser claim to be a modern app that supports
2580         automatic graphics switching. WebKit needs to support automatic
2581         graphics switching, so our test app might as well. Without this
2582         Info.plist parameter, this change has no effect, and bringing up
2583         a WebGL context still brings up the discrete GPU (also true of the
2584         existing web-exposed preferLowPowerToHighPerformance API).
2585
2586 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2587
2588         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2589         https://bugs.webkit.org/show_bug.cgi?id=166645
2590
2591         Reviewed by Carlos Garcia Campos.
2592
2593         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2594         (TestWebKitAPI::TEST):
2595
2596 2017-01-03  Andy Estes  <aestes@apple.com>
2597
2598         Place all the Cocoa WebCore API tests in the same directory
2599         https://bugs.webkit.org/show_bug.cgi?id=166673
2600
2601         Reviewed by Michael Catanzaro.
2602
2603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2604         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2605         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2606         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2607
2608 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2609
2610         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2611         https://bugs.webkit.org/show_bug.cgi?id=166450
2612         <rdar://problem/29447824>
2613
2614         Reviewed by Darin Adler.
2615
2616         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2617         * DumpRenderTree/TestRunner.cpp:
2618         (TestRunner::staticFunctions):
2619         * DumpRenderTree/mac/TestRunnerMac.mm:
2620         (setSpellCheckerLoggingEnabledCallback):
2621         * DumpRenderTree/win/TestRunnerWin.cpp:
2622         (setSpellCheckerLoggingEnabledCallback):
2623         * DumpRenderTree/mac/DumpRenderTree.mm:
2624         (resetWebViewToConsistentStateBeforeTesting):
2625         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2626         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2627         (stringForCorrectionResponse):
2628         (drt_NSSpellChecker_recordResponseToCorrection):
2629         (swizzleNSSpellCheckerMethodsIfNeeded):
2630         (setSpellCheckerLoggingEnabled):
2631         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2632         set to true, logs to stdout (which ends up in the test result) whenever
2633         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2634         is called, and then calls the original method. It is reset to false between tests.
2635
2636 2017-01-03  Sam Weinig  <sam@webkit.org>
2637
2638         Make WTF::Expected support Ref template parameters
2639         https://bugs.webkit.org/show_bug.cgi?id=166662
2640
2641         Reviewed by Alex Christensen.
2642
2643         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2644         (TestWebKitAPI::TEST):
2645         Add tests for using Ref with Expected.
2646
2647 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2648
2649         [GTK] Expose WebKitSecurityOrigin API
2650         https://bugs.webkit.org/show_bug.cgi?id=166632
2651
2652         Reviewed by Carlos Garcia Campos.
2653
2654         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2655         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2656         (testSecurityOriginBasicConstructor):
2657         (testSecurityOriginURIConstructor):
2658         (testSecurityOriginDefaultPort):
2659         (testSecurityOriginFileURI):
2660         (testSecurityOriginDataURI):
2661         (beforeAll):
2662         (afterAll):
2663
2664 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2665
2666         [GTK] HTTP auth layout tests are flaky
2667         https://bugs.webkit.org/show_bug.cgi?id=158919
2668
2669         Reviewed by Michael Catanzaro.
2670
2671         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2672         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2673         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2674         missing valac in the bots.
2675
2676 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2677
2678         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2679         https://bugs.webkit.org/show_bug.cgi?id=165797
2680
2681         Reviewed by Michael Catanzaro.
2682
2683         Move directory ruleset after all exclude rules of Source rulset.
2684
2685         * gtk/manifest.txt.in:
2686
2687 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2688
2689         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2690         https://bugs.webkit.org/show_bug.cgi?id=166636
2691
2692         Reviewed by Darin Adler.
2693
2694         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2695         (TestWebKitAPI::TEST):
2696
2697 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2698
2699         [GTK] WebCore/CSSParser unit test is not being built
2700         https://bugs.webkit.org/show_bug.cgi?id=166492
2701
2702         Reviewed by Michael Catanzaro.
2703
2704         This test was introduced in r175930, but we were not building
2705         it on GTK+ port since r176015.
2706         This patch marks the test to be built again on GTK+.
2707         JFTR, the test is passing right now.
2708
2709         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2710         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2711
2712 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2713
2714         AX: Expose block quote level to iOS API
2715         https://bugs.webkit.org/show_bug.cgi?id=166629
2716         <rdar://problem/29834793>
2717
2718         Reviewed by Darin Adler.
2719
2720         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2721         (AccessibilityUIElement::numberAttributeValue):
2722         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2723         (WTR::AccessibilityUIElement::numberAttributeValue):
2724
2725 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2726
2727         SecurityOrigin::create triplet constructor does not canonicalize port
2728         https://bugs.webkit.org/show_bug.cgi?id=166624
2729
2730         Reviewed by Daniel Bates.
2731
2732         * TestWebKitAPI/PlatformGTK.cmake:
2733         * TestWebKitAPI/PlatformWin.cmake:
2734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2735         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2736         (TestWebKitAPI::SecurityOriginTest::SetUp):
2737         (TestWebKitAPI::TEST_F):
2738
2739 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2740
2741         [GTK] Improve user agent construction
2742         https://bugs.webkit.org/show_bug.cgi?id=142074
2743
2744         Reviewed by Carlos Garcia Campos.
2745
2746         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2747         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2748         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2749         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2750         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2751         (TestWebKitAPI::TEST):
2752
2753 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2754
2755         [GTK] Improve user agent construction
2756         https://bugs.webkit.org/show_bug.cgi?id=142074
2757
2758         Reviewed by Carlos Garcia Campos.
2759
2760         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2761         (TestWebKitAPI::TEST):
2762
2763 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2764
2765         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2766         https://bugs.webkit.org/show_bug.cgi?id=166472
2767         rdar://problem/29675551
2768
2769         Reviewed by Tim Horton.
2770
2771         These changes are necessary to allow the mouse to leave the WTR window while
2772         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2773         (which DRT does); we'd always go through mouseMoved, which hits an early return
2774         in WebViewImpl::mouseMoved() when the point is outside the view.
2775
2776         * WebKitTestRunner/mac/EventSenderProxy.mm:
2777         (WTR::EventSenderProxy::mouseMoveTo):
2778
2779 2016-12-23  Andy Estes  <aestes@apple.com>
2780
2781         [iOS] Fix some crashing webarchive tests
2782         https://bugs.webkit.org/show_bug.cgi?id=166470
2783
2784         Reviewed by Andreas Kling.
2785
2786         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2787         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2788         so this change uses that on both platforms.
2789
2790         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2791         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2792         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2793         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2794         * WebKitTestRunner/PlatformMac.cmake:
2795         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2796         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
2797
2798 2016-12-22  Saam Barati  <sbarati@apple.com>
2799
2800         WebAssembly: Silence the output of the spec-tests
2801         https://bugs.webkit.org/show_bug.cgi?id=166417
2802
2803         Reviewed by Mark Lam.
2804
2805         * Scripts/run-jsc-stress-tests:
2806
2807 2016-12-22  Zhuo Li  <zachli@apple.com>
2808
2809         [Cocoa] SPI for setloadsImagesAutomatically.
2810         https://bugs.webkit.org/show_bug.cgi?id=166401.
2811
2812         Reviewed by Darin Adler.
2813
2814         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2815         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
2816         _loadsImagesAutomatically returns YES.
2817
2818 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2819
2820         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
2821         https://bugs.webkit.org/show_bug.cgi?id=161328
2822         <rdar://problem/28475977>
2823
2824         Reviewed by Darin Adler.
2825
2826         Running a test that scales the viewport and listens to a didEndZooming callback (such as
2827         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
2828         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
2829         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
2830         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
2831         load, should prevent this from happening, but from reading documentation and code inspection, this is not
2832         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
2833         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
2834         we finish running a test and before we load the next test.
2835
2836         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
2837         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
2838         previous test started zooming and then finished before zooming completed. Since this happens before the next
2839         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
2840
2841         * WebKitTestRunner/ios/TestControllerIOS.mm:
2842         (WTR::TestController::platformResetStateToConsistentValues):
2843
2844 2016-12-22  Jer Noble  <jer.noble@apple.com>
2845
2846         Muted media element playback should not interrupt other audio playback
2847         https://bugs.webkit.org/show_bug.cgi?id=166347
2848
2849         Reviewed by Eric Carlson.
2850
2851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2852         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2853         (TestWebKitAPI::TEST):
2854         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
2855
2856 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
2857
2858         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
2859         https://bugs.webkit.org/show_bug.cgi?id=166346
2860
2861         Reviewed by Carlos Garcia Campos.
2862
2863         Enable WebRTC by default to simplify testing.
2864
2865         * MiniBrowser/gtk/main.c:
2866         (main):
2867
2868 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2869
2870         REGRESSION: API test failure: WKWebView.LocalStorageClear
2871         https://bugs.webkit.org/show_bug.cgi?id=166032
2872         <rdar://problem/29758423>
2873
2874         Reviewed by Simon Fraser.
2875
2876         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2877         to ensure that the view is destroyed before the callback fires.
2878
2879         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2880         (TEST):
2881
2882 2016-12-21  Saam Barati  <sbarati@apple.com>
2883
2884         WebAssembly: Import spec tests
2885         https://bugs.webkit.org/show_bug.cgi?id=166395
2886
2887         Rubber stamped by Keith Miller.
2888
2889         * Scripts/run-jsc-stress-tests:
2890
2891 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2892
2893         REGRESSION: API test failure: _WKDownload.OriginatingWebView
2894         https://bugs.webkit.org/show_bug.cgi?id=166033
2895         <rdar://problem/29758428>
2896
2897         Reviewed by Simon Fraser.
2898
2899         Add an @autoreleasepool around the code that allocates the WKWebView, 
2900         so that it can be destroyed by removing the last reference in _downloadDidStart.
2901
2902         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2903         (TEST):
2904
2905 2016-12-21  Daniel Bates  <dabates@apple.com>
2906
2907         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
2908         https://bugs.webkit.org/show_bug.cgi?id=166356
2909
2910         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
2911         as a means to allow a test to explicit allow an embedding client to open a new windows
2912         such that the default behavior is for the embedding client to forbid such an action.
2913         The test plugins/get-url-with-blank-target.html assumes this default behavior though
2914         it is currently skipped on WebKit2 because questions were raised in the patch for
2915         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
2916         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
2917         this test.
2918
2919         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2920         (WTR::TestRunner::setCanOpenWindows):
2921
2922 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
2923
2924         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
2925         https://bugs.webkit.org/show_bug.cgi?id=166031
2926
2927         Reviewed by Tim Horton.
2928         
2929         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2930         to ensure that the view is destroyed before the callback fires.
2931
2932         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2933
2934 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
2935
2936         Throw Exception when test doesn't clean up HID Events properly
2937         https://bugs.webkit.org/show_bug.cgi?id=166271
2938
2939         Reviewed by Simon Fraser.
2940
2941         Add in a check when UIScriptController is deleted to make sure that the HID event
2942         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
2943         the program to crash without any good information. Crashes are race-y, and will still
2944         happen with malformed test, but the information will be much more helpful. 
2945
2946         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2947         (WTR::UIScriptController::checkForClean):
2948         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2949         (UIScriptContext::~UIScriptContext):
2950         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2951         (WTR::UIScriptController::checkForClean):
2952         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2953         * WebKitTestRunner/ios/HIDEventGenerator.h:
2954         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2955         (-[HIDEventGenerator checkHIDCallbacksClear]):
2956         * WebKitTestRunner/ios/TestControllerIOS.mm:
2957         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2958         (WTR::UIScriptController::checkForClean):
2959
2960 2016-12-20  Andy Estes  <aestes@apple.com>
2961
2962         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
2963         https://bugs.webkit.org/show_bug.cgi?id=165992
2964
2965         Reviewed by Brady Eidson.
2966
2967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2968         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
2969         (expectException):
2970         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2971         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2972         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2973         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2974         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2975         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
2976         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
2977         (TEST):
2978         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
2979
2980 2016-12-20  Dean Jackson  <dino@apple.com>
2981
2982         Remove INDIE_UI
2983         https://bugs.webkit.org/show_bug.cgi?id=165881
2984         <rdar://problem/29672532>
2985
2986         Reviewed by Simon Fraser.
2987
2988         The Indie UI work has been discontinued.
2989
2990         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2991
2992 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2993
2994         [ES6] Enable ES6 Modules
2995         https://bugs.webkit.org/show_bug.cgi?id=165849
2996
2997         Reviewed by Geoffrey Garen.
2998
2999         * DumpRenderTree/mac/DumpRenderTree.mm:
3000         (resetWebPreferencesToConsistentValues):
3001         * DumpRenderTree/win/DumpRenderTree.cpp:
3002         (resetWebPreferencesToConsistentValues):
3003         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3004         (WTR::InjectedBundle::beginTesting):
3005         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3006         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3007         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3008
3009 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3010
3011         Repurpose bots and clean up dashboard.
3012         https://bugs.webkit.org/show_bug.cgi?id=166045
3013
3014         Reviewed by Lucas Forschler.
3015
3016         * BuildSlaveSupport/build.webkit.org-config/config.json:
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3018         (BubbleQueueServer):
3019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3020         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3021         (WebKitBuildbot):
3022         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3023         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3024
3025 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3026
3027         [CMake] TestWebKitAPIBase links to itself
3028         https://bugs.webkit.org/show_bug.cgi?id=165985
3029
3030         Reviewed by Alex Christensen.
3031
3032         Fix CMake warning about a target linking to itself, which makes no sense.
3033
3034         * TestWebKitAPI/CMakeLists.txt:
3035
3036 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3037
3038         [GTK] GtkDoc build should be quieter
3039         https://bugs.webkit.org/show_bug.cgi?id=165994
3040
3041         Reviewed by Carlos Garcia Campos.
3042
3043         Make it not print by default.
3044
3045         * gtk/generate-gtkdoc:
3046         (get_generator_for_config):
3047         (generate_doc):
3048         * gtk/gtkdoc.py:
3049         (GTKDoc._run_command):
3050         (GTKDoc._copy_doc_files_to_output_dir):
3051
3052 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3053
3054         Expose a way for MiniBrowser to simulate header and footer banners
3055         https://bugs.webkit.org/show_bug.cgi?id=166005
3056
3057         Reviewed by Wenson Hsieh.
3058         
3059         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3060         banners. This only works in WebKit2.
3061         
3062         We need to reset these on each navigation, since newly created FrameViews
3063         don't re-fetch the header and footer height stored on Page.
3064         
3065         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3066         as well as fixing webViewWebContentProcessDidTerminate:
3067
3068         * MiniBrowser/mac/SettingsController.h:
3069         * MiniBrowser/mac/SettingsController.m:
3070         (-[SettingsController _populateMenu]):
3071         (-[SettingsController validateMenuItem:]):
3072         (-[SettingsController toggleReserveSpaceForBanners:]):
3073         (-[SettingsController isSpaceReservedForBanners]):
3074         * MiniBrowser/mac/WK2BrowserWindowController.m:
3075         (-[WK2BrowserWindowController didChangeSettings]):
3076         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3077         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3078         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3079         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3080
3081 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3082
3083         Fix iOS test results after r209967.
3084         
3085         Subtracting out the status bar height was erroneously happening for all tests,
3086         not just for flexible viewport tests.
3087         
3088         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3089
3090         * WebKitTestRunner/PlatformWebView.h:
3091         * WebKitTestRunner/TestController.cpp:
3092         (WTR::TestController::resetStateToConsistentValues):
3093         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3094         (WTR::PlatformWebView::resizeTo):
3095         (WTR::PlatformWebView::setWindowFrame):
3096         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3097         (WTR::PlatformWebView::resizeTo):
3098         (WTR::PlatformWebView::setWindowFrame):
3099         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3100         (WTR::PlatformWebView::resizeTo):
3101         (WTR::PlatformWebView::setWindowFrame):
3102         * WebKitTestRunner/ios/TestControllerIOS.mm:
3103         (WTR::TestController::platformConfigureViewForTest):
3104         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3105         (WTR::PlatformWebView::resizeTo):
3106         (WTR::PlatformWebView::setWindowFrame):
3107
3108 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3109
3110         [EFL] bump EFL version to 1.18.4
3111         https://bugs.webkit.org/show_bug.cgi?id=166004
3112
3113         Reviewed by Gyuyoung Kim.
3114
3115         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3116
3117 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3118
3119         Visual viewports: bottom fixed elements disappear behind the keyboard
3120         https://bugs.webkit.org/show_bug.cgi?id=165983
3121         <rdar://problem/29409852>
3122
3123         Reviewed by Simon Fraser.
3124
3125         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3126         the keyboard when it is up.
3127
3128         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3129         (WTR::UIScriptController::inputViewBounds):
3130         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3131         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3132         (WTR::UIScriptController::inputViewBounds):
3133         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3134         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3135         (WTR::viewRectForWindowRect):
3136
3137         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3138         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3139         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3140
3141         (WTR::PlatformWebView::PlatformWebView):
3142         (WTR::PlatformWebView::setWindowFrame):
3143         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3144         (WTR::UIScriptController::inputViewBounds):
3145
3146 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3147
3148         Deleting a character converted from pinyin after an image causes a Safari crash
3149         https://bugs.webkit.org/show_bug.cgi?id=165839
3150         <rdar://problem/27951933>
3151
3152         Reviewed by Wenson Hsieh.
3153
3154         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3155         while the proposed range contains an image. This should not cause a WebProcess to crash
3156         or send an invalid message to the UIProcess.
3157
3158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3159         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3160         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3161         (TestWebKitAPI::didFinishLoadForFrame):
3162         (TestWebKitAPI::processDidCrash):
3163         (TestWebKitAPI::invalidMessageFunction):
3164         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3165
3166 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3167
3168         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3169         https://bugs.webkit.org/show_bug.cgi?id=165767
3170         <rdar://problem/29602382>
3171
3172         Reviewed by Simon Fraser.
3173
3174         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3175         WebKit2 ChangeLog for more details.
3176
3177         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3178         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3179         (WTR::UIScriptController::textSelectionCaretRect):
3180         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3181         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3182         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3183         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3184         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3185         (WTR::UIScriptController::textSelectionCaretRect):
3186         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3187         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3188         (-[TestRunnerWKWebView _setStableStateOverride:]):
3189
3190         Force the WKWebView to update its visible content rects when changing the stable state override.
3191
3192         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3193         (WTR::toNSDictionary):
3194         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3195         (WTR::UIScriptController::selectionRangeViewRects):
3196         (WTR::UIScriptController::textSelectionCaretRect):
3197         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3198         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3199
3200 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3201
3202         Arguments called in wrong order
3203         https://bugs.webkit.org/show_bug.cgi?id=165923
3204
3205         Reviewed by Simon Fraser.
3206
3207         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3208         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3209
3210         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3211         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3212         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3213
3214 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3215
3216         [EFL] Disable non-srcdir builds for failing libraries
3217         https://bugs.webkit.org/show_bug.cgi?id=165896
3218
3219         Reviewed by Gyuyoung Kim.
3220
3221         * efl/jhbuild.modules: Set non srcdir builds to no
3222
3223 2016-12-15  Daniel Bates  <dabates@apple.com>
3224
3225         check-style should not complain about code in icu directories
3226         https://bugs.webkit.org/show_bug.cgi?id=53929
3227
3228         Reviewed by Darin Adler.
3229
3230         Skip style checking of imported ICU headers to avoid a deluge of style issues
3231         as they do not conform to the WebKit Code Style guideline. We want to preserve
3232         the formatting of these headers so as to make it straightforward to merge
3233         changes to them, if necessary.
3234
3235         * Scripts/webkitpy/style/checker.py:
3236
3237 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3238
3239         Move JSC testers from Yosemite to Sierra
3240         https://bugs.webkit.org/show_bug.cgi?id=165925
3241
3242         Reviewed by Lucas Forschler.
3243
3244         * BuildSlaveSupport/build.webkit.org-config/config.json:
3245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3246         (WebKitBuildbot):
3247
3248 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3249
3250         Add coordinate space to event streams and streamline tests
3251         https://bugs.webkit.org/show_bug.cgi?id=165119
3252
3253         Reviewed by Simon Fraser.
3254
3255         Update event streams to allow for both content and global coordinate space.
3256         Update example script to more accurately show all the available options.
3257
3258         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3259         * WebKitTestRunner/ios/HIDEventGenerator.h:
3260         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3261         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3262         (WTR::convertCoordinates):
3263         (WTR::UIScriptController::sendEventStream):
3264
3265 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3266
3267         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3268         https://bugs.webkit.org/show_bug.cgi?id=165855
3269
3270         Reviewed by Philippe Normand.
3271
3272         GStreamer's autogen.sh enables gtk-doc always so we end up building
3273         docs even if we disable them. Use the configure script instead, since
3274         we build from packages and these include it already.
3275
3276         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3277         upstream gstreamer packages.
3278
3279 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3280
3281         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3282         https://bugs.webkit.org/show_bug.cgi?id=165885
3283         <rdar://problem/29476917>
3284
3285         Reviewed by Darin Adler.
3286
3287         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3288         (TestWebKitAPI::utf16String): Deleted.
3289         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3290         (TestWebKitAPI::TEST_F):
3291         * TestWebKitAPI/WTFStringUtilities.h:
3292         (utf16String):
3293         Moved from URLParser to share with other tests.
3294
3295 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3296
3297         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3298         https://bugs.webkit.org/show_bug.cgi?id=165843
3299
3300         Reviewed by Antti Koivisto.
3301
3302         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3303         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3304         and DumpRenderTree's runUIScript would hit an assertion :(
3305
3306         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3307         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3308         (WTR::TestRunner::isWebKit2):
3309
3310 2016-12-14  Brady Eidson  <beidson@apple.com>
3311
3312         IndexedDB 2.0: Massively speedup IDBIndex.get().
3313         https://bugs.webkit.org/show_bug.cgi?id=165802
3314
3315         Reviewed by Alex Christensen.
3316
3317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3318         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3319         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3320         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3321         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3322
3323 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3324
3325         [GTK][EFL] Update the JHBuild version.
3326         https://bugs.webkit.org/show_bug.cgi?id=165838
3327
3328         Reviewed by Michael Catanzaro.
3329
3330         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3331         usage of the JHBUILD_MIRROR feature with git repositories.
3332
3333 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3334
3335         [GTK] Yasm is needed for building the JHBuild after r208940
3336         https://bugs.webkit.org/show_bug.cgi?id=165837
3337
3338         Reviewed by Alejandro G. Castro.
3339
3340         * gtk/install-dependencies: Yasm is needed for building libvpx.
3341
3342 2016-12-14  Youenn Fablet  <youenn@apple.com>
3343
3344         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3345         https://bugs.webkit.org/show_bug.cgi?id=161310
3346
3347         Reviewed by Ryosuke Niwa.
3348
3349         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3350         When set, WTR and DRT output JS console log in the stderr and not the test output.
3351         This allows removing potentially flaky information while still being able to read it for investigation.
3352
3353         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3354
3355         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3356         This test should have this option when fetch API will start logging resource loader errors.
3357
3358         * DumpRenderTree/DumpRenderTree.h:
3359         (TestCommand::TestCommand): Deleted.
3360         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3361         (parseInputLine):
3362         * DumpRenderTree/TestRunner.h:
3363         (TestRunner::setDumpJSConsoleLogInStdErr):
3364         (TestRunner::dumpJSConsoleLogInStdErr):
3365         * DumpRenderTree/mac/DumpRenderTree.mm:
3366         (runTest):
3367         * DumpRenderTree/mac/UIDelegate.mm:
3368         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3369         * DumpRenderTree/win/DumpRenderTree.cpp:
3370         (runTest):
3371         * DumpRenderTree/win/UIDelegate.cpp:
3372         (UIDelegate::webViewAddMessageToConsole):
3373         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3374         (TestExpectationParser._tokenize_line):
3375         * Scripts/webkitpy/port/driver.py:
3376         (Driver._command_from_driver_input):
3377         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3378         (WTR::InjectedBundle::didReceiveMessageToPage):
3379         (WTR::InjectedBundle::dumpToStdErr):
3380         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3381         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3382         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3383         (WTR::InjectedBundlePage::willAddMessageToConsole):
3384         * WebKitTestRunner/TestController.cpp:
3385         (WTR::parseInputLine):
3386         (WTR::TestController::runTest):
3387         (WTR::TestCommand::TestCommand): Deleted.
3388         * WebKitTestRunner/TestInvocation.cpp:
3389         (WTR::TestInvocation::invoke):
3390         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3391         * WebKitTestRunner/TestInvocation.h:
3392         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3393
3394
3395 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3396
3397         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3398         https://bugs.webkit.org/show_bug.cgi?id=164022
3399
3400         Reviewed by Xabier Rodriguez-Calvar.
3401
3402         * Scripts/webkitperl/FeatureList.pm:
3403           Re-enable MEDIA_SOURCE for the GTK+ port.
3404
3405 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3406
3407         Fix CMake build.
3408
3409         * DumpRenderTree/PlatformMac.cmake:
3410         Define NS_RETURNS_RETAINED as nothing for now.
3411
3412 2016-12-13  Jer Noble  <jer.noble@apple.com>
3413
3414         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3415         https://bugs.webkit.org/show_bug.cgi?id=165697
3416
3417         Reviewed by Tim Horton.
3418
3419         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3420         (TestWebKitAPI::TEST):
3421
3422 2016-12-13  Andy Estes  <aestes@apple.com>
3423
3424         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3425         https://bugs.webkit.org/show_bug.cgi?id=165785
3426         <rdar://problem/26929398>
3427
3428         Reviewed by Darin Adler.
3429
3430         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3431         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3432         expectations for the text, range, and action.
3433         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3434         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3435         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3436         text in the web view did not change.
3437         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3438         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3439         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3440         parameter.
3441         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3442         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3443         and returned the value of _editingDelegateShouldInsertText.
3444         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3445         -shouldInsertText:replacingRange:givenAction:.
3446
3447 2016-12-13  Chris Dumez  <cdumez@apple.com>
3448
3449         Unreviewed, rolling out r209544.
3450
3451         Looks like r209489 did not cause the performance regression
3452         after all
3453
3454         Reverted changeset:
3455
3456         "Unreviewed, rolling out r209489."
3457         https://bugs.webkit.org/show_bug.cgi?id=165550
3458         http://trac.webkit.org/changeset/209544
3459
3460 2016-12-12  Sam Weinig  <sam@webkit.org>
3461
3462         [WebIDL] Remove use of Dictionary in ApplePaySession
3463         https://bugs.webkit.org/show_bug.cgi?id=165787
3464
3465         Reviewed by Anders Carlsson.
3466
3467         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3468         (WTR::initializeWebViewConfiguration):
3469         (WTR::TestController::platformCreateWebView):
3470         Enable ApplePay for the tests (where supported).
3471
3472 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3473
3474         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3475         https://bugs.webkit.org/show_bug.cgi?id=165251
3476
3477         Reviewed by Youenn Fablet.
3478
3479         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3480         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3481         the preferences have been set.
3482
3483 2016-12-08  Antti Koivisto  <antti@apple.com>
3484
3485         Enable network cache speculative revalidation in MiniBrowser
3486         https://bugs.webkit.org/show_bug.cgi?id=165616
3487
3488         Reviewed by Darin Adler.
3489
3490         Match Safari. Also add a menu item to disable it.
3491
3492         * MiniBrowser/mac/AppDelegate.m:
3493         (defaultConfiguration):
3494         * MiniBrowser/mac/SettingsController.h:
3495         * MiniBrowser/mac/SettingsController.m:
3496         (-[SettingsController _populateMenu]):
3497         (-[SettingsController validateMenuItem:]):
3498         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3499         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3500
3501 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3502
3503         ChangeLogs become readonly after resolving a conflict
3504         https://bugs.webkit.org/show_bug.cgi?id=165440
3505         rdar://problem/29491002
3506
3507         Reviewed by Darin Adler.
3508
3509         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3510         moving the file.
3511
3512 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3513
3514         Re-enable collectContinuously since it doesn't crash anymore
3515
3516         Rubber stamped by Michael Saboff.
3517
3518         * Scripts/run-jsc-stress-tests:
3519
3520 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3521
3522         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3523         https://bugs.webkit.org/show_bug.cgi?id=165686
3524
3525         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3526         so that right config.h comes first in include path.
3527
3528 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3529
3530         [CSS Parser] Make sure content extensions initialize AtomicString
3531         https://bugs.webkit.org/show_bug.cgi?id=165737
3532
3533         Reviewed by Darin Adler.
3534
3535         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3536         (TestWebKitAPI::makeBackend):
3537
3538 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3539
3540         [CSS Parser] Remove the old CSS Parser
3541         https://bugs.webkit.org/show_bug.cgi?id=165645
3542
3543         Reviewed by Daniel Bates.
3544
3545         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3546         (TestWebKitAPI::TEST):
3547
3548 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3549
3550         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3551         https://bugs.webkit.org/show_bug.cgi?id=165686
3552
3553         Reviewed by Michael Catanzaro.
3554
3555         This change reduces duplication of include path lists between modules,
3556         and reduces future need for fixes like r209605 (broken build because of
3557         WebCore header suddenly becoming used in WebKit2).
3558
3559         * DumpRenderTree/CMakeLists.txt:
3560         * DumpRenderTree/PlatformMac.cmake:
3561         * ImageDiff/CMakeLists.txt:
3562         * MiniBrowser/gtk/CMakeLists.txt:
3563         * MiniBrowser/mac/CMakeLists.txt:
3564         * MiniBrowser/win/CMakeLists.txt:
3565         * TestWebKitAPI/CMakeLists.txt:
3566         * TestWebKitAPI/PlatformEfl.cmake:
3567         * TestWebKitAPI/PlatformJSCOnly.cmake:
3568         * TestWebKitAPI/PlatformMac.cmake:
3569         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3570         * WebKitTestRunner/CMakeLists.txt:
3571         * WebKitTestRunner/PlatformGTK.cmake:
3572         * WebKitTestRunner/PlatformMac.cmake:
3573
3574 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3575
3576         Unreviewed buildfix after r209630.
3577
3578         * Scripts/build-jsc: Remove building the non-existing testWASM.
3579
3580 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3581
3582         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3583         https://bugs.webkit.org/show_bug.cgi?id=165251
3584
3585         Reviewed by Dean Jackson.
3586
3587         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3588
3589         * DumpRenderTree/mac/DumpRenderTree.mm:
3590         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3591
3592         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3593         (WTR::InjectedBundle::beginTesting): Ditto.
3594
3595         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3596         (WTR::TestRunner::setMediaStreamEnabled): New.
3597         (WTR::TestRunner::setPeerConnectionEnabled): New.
3598         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3599
3600 2016-12-09  Brady Eidson  <beidson@apple.com> 
3601  
3602         Re-landing:
3603         Add _WKIconLoadingDelegate SPI. 
3604         https://bugs.webkit.org/show_bug.cgi?id=164894 
3605  
3606         Reviewed by Alex Christensen. 
3607         
3608         Add MiniBrowser support for this new SPI, configurable with a setting. 
3609  
3610         * MiniBrowser/mac/SettingsController.h: 
3611         * MiniBrowser/mac/SettingsController.m: 
3612         (-[SettingsController _populateMenu]): 
3613         (-[SettingsController validateMenuItem:]): 
3614         (-[SettingsController loadsAllSiteIcons]): 
3615         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3616         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3617         (-[WK2BrowserWindowController awakeFromNib]): 
3618         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3619
3620 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3621
3622         Fix the 32-bit build.
3623
3624         Unreviewed build fix.
3625
3626         * MiniBrowser/mac/SettingsController.h:
3627
3628 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3629
3630         Fedora also needs a PHP7 config file alternative
3631         https://bugs.webkit.org/show_bug.cgi?id=165606
3632
3633         Reviewed by Michael Catanzaro.
3634
3635         * Scripts/webkitpy/port/base.py:
3636         (Port._is_fedora_php_version_7): check for the php7 library.
3637         (Port._fedora_php_version): get the appropriate filename for Fedora.
3638         (Port._apache_config_file_name_for_platform):
3639
3640 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3641
3642         Complete the revert of r208865.
3643         https://bugs.webkit.org/show_bug.cgi?id=164894
3644
3645         Unreviewed build fix.
3646
3647         * MiniBrowser/mac/SettingsController.h:
3648         * MiniBrowser/mac/SettingsController.m:
3649         (-[SettingsController _populateMenu]):
3650         (-[SettingsController validateMenuItem:]):
3651         (-[SettingsController loadsAllSiteIcons]): Deleted.
3652         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3653         * MiniBrowser/mac/WK2BrowserWindowController.m:
3654         (-[WK2BrowserWindowController awakeFromNib]):
3655         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3656
3657 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3658
3659         [GTK] Force GDK backend to x11 when running with XvfbDriver
3660         https://bugs.webkit.org/show_bug.cgi?id=165612
3661
3662         Reviewed by Michael Catanzaro.
3663
3664         When the developer is running a Wayland session, GDK may get confused
3665         and try to use its Wayland backend (which is higher priority) instead.
3666         This ensures it will use the appropriate backend when running under
3667         Xvfb.
3668
3669         * Scripts/webkitpy/port/gtk.py:
3670         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3671         force GDK_BACKEND to x11.
3672
3673 2016-12-08  Keith Miller  <keith_miller@apple.com>
3674
3675         Add 64-bit signed LEB decode method
3676         https://bugs.webkit.org/show_bug.cgi?id=165630
3677
3678         Reviewed by Ryosuke Niwa.
3679
3680         Add tests for LEB int64 and uint64 decode since I guess
3681         I forgot to add tests before.
3682
3683         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3684         (TestWebKitAPI::testUInt32LEBDecode):
3685         (TestWebKitAPI::TEST):
3686         (TestWebKitAPI::testUInt64LEBDecode):
3687         (TestWebKitAPI::testInt32LEBDecode):
3688         (TestWebKitAPI::testInt64LEBDecode):
3689         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3690
3691 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3692
3693         Make it easy to enable --force-collectContinuously
3694         https://bugs.webkit.org/show_bug.cgi?id=165638
3695
3696         Reviewed by Keith Miller.
3697
3698         * Scripts/run-javascriptcore-tests:
3699         (runJSCStressTests):
3700
3701 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3702
3703         Disable the collectContinuously mode until I investigate failures.
3704
3705         Rubber stamped by Keith Miller.
3706         
3707         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3708         while I investigate.
3709
3710         * Scripts/run-jsc-stress-tests:
3711
3712 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3713
3714         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3715         https://bugs.webkit.org/show_bug.cgi?id=165621
3716
3717         Reviewed by Dan Bernstein.
3718
3719         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3720         (TestWebKitAPI::TEST_F):
3721
3722 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3723
3724         Concurrent GC should be stable enough to land enabled
3725         https://bugs.webkit.org/show_bug.cgi?id=164990
3726
3727         Reviewed by Geoffrey Garen.
3728         
3729         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3730         
3731         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3732         safe for debug. It might be too slow for debug.
3733
3734         * Scripts/run-jsc-stress-tests:
3735
3736 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3737
3738         Add SPI for sending WebsiteSettings to WebProcess during navigation
3739         https://bugs.webkit.org/show_bug.cgi?id=165517
3740         <rdar://29341068>
3741
3742         Reviewed by Anders Carlsson.
3743
3744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3745         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3746         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3747         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3748         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3749         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3750         (TEST):
3751
3752 2016-12-08  Chris Dumez  <cdumez@apple.com>
3753
3754         Unreviewed, rolling out r209489.
3755
3756         Likely caused large regressions on JetStream, Sunspider and
3757         Speedometer
3758
3759         Reverted changeset:
3760
3761         "Add system trace points for JavaScript VM entry/exit"
3762         https://bugs.webkit.org/show_bug.cgi?id=165550
3763         http://trac.webkit.org/changeset/209489
3764
3765 2016-12-08  Keith Miller  <keith_miller@apple.com>
3766
3767         Move LEB tests to API tests
3768         https://bugs.webkit.org/show_bug.cgi?id=165586
3769
3770         Reviewed by Saam Barati.
3771
3772         Move the tests from testWasm.cpp and make them functions
3773         rather than macros.
3774
3775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3776         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
3777         (TestWebKitAPI::testUnsignedLEBDecode):
3778         (TestWebKitAPI::TEST):
3779         (TestWebKitAPI::testInt32LEBDecode):
3780
3781 2016-12-08  Chris Dumez  <cdumez@apple.com>
3782
3783         Support running the layout tests offline
3784         https://bugs.webkit.org/show_bug.cgi?id=165534
3785
3786         Reviewed by Ryosuke Niwa.
3787
3788         * Scripts/webkitpy/common/system/autoinstall.py:
3789         (AutoInstaller._download_to_stream):
3790         getcode() returns None for file URLs so handle this.
3791
3792         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3793         (WebPlatformTestServer._install_modules):
3794         Deal with local path in the json file and resolve them into file URLs
3795         before using AutoInstall.
3796
3797 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3798
3799         Fix CMake build.
3800
3801         * DumpRenderTree/PlatformMac.cmake:
3802         Remove CheckedMalloc.cpp after r209516.
3803
3804 2016-12-07  Mark Lam  <mark.lam@apple.com>
3805
3806         DumpRenderTree should stop using CheckedMalloc.
3807         https://bugs.webkit.org/show_bug.cgi?id=165563
3808         <rdar://problem/28945820>
3809
3810         Reviewed by Geoffrey Garen.
3811
3812         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
3813            in CheckedMalloc.
3814         2. bmalloc does not honor the settings of CheckedMalloc.
3815
3816         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
3817         malloc.  As a result, DRT exhibits different behavior from the normal way we run
3818         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
3819         with WKTR.
3820
3821         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3822         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
3823         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
3824         * DumpRenderTree/mac/DumpRenderTree.mm:
3825         (prepareConsistentTestingEnvironment):
3826
3827 2016-12-07  Dean Jackson  <dino@apple.com>
3828
3829         Remove runtime toggle for pointer-lock
3830         https://bugs.webkit.org/show_bug.cgi?id=165577
3831         <rdar://problems/29566996>
3832
3833         Reviewed by Jon Lee.
3834
3835         Remove any runtime calls to check if pointer-lock is enabled. It's
3836         either compiled in or out.
3837
3838         * DumpRenderTree/mac/DumpRenderTree.mm:
3839         (resetWebPreferencesToConsistentValues):
3840         * WebKitTestRunner/TestController.cpp:
3841         (WTR::TestController::resetPreferencesToConsistentValues):
3842
3843 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
3844
3845         [MediaStream][Mac] Revoke sandbox extensions when capture ends
3846         https://bugs.webkit.org/show_bug.cgi?id=165476
3847
3848         Reviewed by Brady Eidson.
3849         
3850         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
3851         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
3852         is reset and recreated when a web page exits and is reloaded.
3853
3854         * TestWebKitAPI/PlatformGTK.cmake:
3855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3856         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
3857         (TestWebKitAPI::checkUserMediaPermissionCallback):
3858         (TestWebKitAPI::TEST):
3859         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
3860
3861 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
3862
3863         One esc to exit fullscreen and pointer lock
3864         https://bugs.webkit.org/show_bug.cgi?id=165416
3865         rdar://problem/29430711
3866
3867         Reviewed by Jer Noble.
3868
3869         Implement WKPageUIClientV8 for pointer lock support.
3870         Add "escape" key support in EventSenderProxy.
3871
3872         * WebKitTestRunner/TestController.cpp:
3873         (WTR::requestPointerLock):
3874         (WTR::TestController::createOtherPage):
3875         (WTR::TestController::createWebViewWithOptions):
3876         * WebKitTestRunner/mac/EventSenderProxy.mm:
3877         (WTR::EventSenderProxy::keyDown):
3878
3879 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3880
3881         Add system trace points for JavaScript VM entry/exit
3882         https://bugs.webkit.org/show_bug.cgi?id=165550
3883
3884         Reviewed by Tim Horton.
3885
3886         Add trace points for entry/exit into/out of the JS VM.
3887
3888         * Tracing/SystemTracePoints.plist:
3889
3890 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
3891
3892         [GTK] Cannot build GTK+ with CUPS 2.* versions
3893         https://bugs.webkit.org/show_bug.cgi?id=163591
3894
3895         Reviewed by Michael Catanzaro.
3896
3897         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
3898         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
3899         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
3900         old gtk+ since it requires not only bumping up glib accordingly and its consequence
3901         causes many printing test failures. So, I propose to fix the configuration issue by
3902         applying the change to the configure file directly. By doing this, we don't need to
3903         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
3904
3905         * gtk/jhbuild.modules:
3906         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
3907
3908 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3909
3910         Fix use of enum in a WK2 C SPI header.
3911         rdar://problem/28725583
3912
3913         Followup to correctly prefix the enum values.
3914
3915         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3916         (WTR::InjectedBundlePage::prepare):
3917
3918 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3919
3920         Fix use of enum in a WK2 C SPI header.
3921         rdar://problem/28725583
3922
3923         Reviewed by Dan Bernstein.
3924
3925         Use correct enum style for a C SPI header and fix the callers.
3926
3927         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3928         (WTR::InjectedBundlePage::prepare):
3929
3930 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3931
3932         Add a new project for recording and playing back editing commands in editable web content
3933         https://bugs.webkit.org/show_bug.cgi?id=165114
3934         <rdar://problem/29408135>
3935
3936         Reviewed by Beth Dakin.
3937
3938         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
3939         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
3940         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
3941         then be dragged into the playback test harness.
3942
3943         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
3944         steps:
3945
3946         1. Load the capture harness and perform test-specific editing on the web view.
3947         2. Let originalState be a dump of the DOM at this point in time.
3948         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
3949         4. Rewind all editing to the beginning.
3950         5. Playback all editing to the end.
3951         6. Dump the state of the DOM. This should be identical to originalState.
3952
3953         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
3954         * EditingHistory/EditingHistory/Info.plist: Added.
3955         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
3956         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
3957         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
3958         * EditingHistory/EditingHistory/TestRunner.h: Added.
3959         * EditingHistory/EditingHistory/TestRunner.m: Added.
3960         (injectedMessageEventHandlerScript):
3961         (-[TestRunner init]):
3962         (-[TestRunner deleteBackwards:]):
3963         (-[TestRunner typeString:]):
3964         (-[TestRunner bodyElementSubtree]):
3965         (-[TestRunner bodyTextContent]):
3966         (-[TestRunner editingHistoryJSON]):
3967         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
3968         (-[TestRunner numberOfUpdates]):
3969         (-[TestRunner jumpToUpdateIndex:]):
3970         (-[TestRunner expectEvents:afterPerforming:]):
3971         (-[TestRunner loadCaptureTestHarness]):
3972         (-[TestRunner setTextObfuscationEnabled:]):
3973         (-[TestRunner isDoneWaitingForPendingEvents]):
3974         (-[TestRunner userContentController:didReceiveScriptMessage:]):
3975
3976         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
3977         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
3978
3979         * EditingHistory/EditingHistory/TestUtil.h: Added.
3980         * EditingHistory/EditingHistory/TestUtil.m: Added.
3981         (waitUntilWithTimeout):
3982         (waitUntil):
3983
3984         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
3985
3986         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
3987         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
3988         (-[WKWebView loadPageFromBundleNamed:]):
3989         (-[WKWebView typeCharacter:]):
3990         (-[WKWebView keyPressWithCharacters:keyCode:]):
3991         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
3992
3993         Provides utilities for simulating interaction in a web view.
3994
3995         * EditingHistory/EditingHistory/main.m: Added.
3996         (main):
3997         * EditingHistory/EditingHistoryTests/Info.plist: Added.
3998         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
3999         (-[RewindAndPlaybackTests setUp]):
4000         (-[RewindAndPlaybackTests tearDown]):
4001         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
4002         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
4003         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
4004         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
4005         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
4006
4007 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4008
4009         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
4010         https://bugs.webkit.org/show_bug.cgi?id=165525
4011
4012         Reviewed by Carlos Garcia Campos.
4013
4014         * gtk/jhbuild.modules: gst-plugins-good should depend on the
4015         libvpx package built within jhbuild.
4016
4017 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4018
4019         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
4020         https://bugs.webkit.org/show_bug.cgi?id=165520
4021
4022         Reviewed by Carlos Garcia Campos.
4023
4024         * gtk/jhbuild.modules: Added missing dependency on openh264 in
4025         gst-plugins-bad, along with 2 upstream patches fixing the build
4026         against OpenSSL 1.1.0.
4027         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
4028         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
4029
4030 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
4031
4032         Correct SDKROOT values in xcconfig files
4033         https://bugs.webkit.org/show_bug.cgi?id=165487
4034         rdar://problem/29539209
4035
4036         Reviewed by Dan Bernstein.
4037
4038         Fix suggested by Dan Bernstein.
4039
4040         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
4041         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4042         * MiniBrowser/Configurations/DebugRelease.xcconfig:
4043         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
4044         * WebEditingTester/Configurations/DebugRelease.xcconfig:
4045         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4046
4047 2016-12-06  Daniel Bates  <dabates@apple.com>
4048
4049         WebKitTestRunner: Plugins are disabled in new windows
4050         https://bugs.webkit.org/show_bug.cgi?id=165410
4051
4052         Reviewed by Alex Christensen.
4053
4054         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
4055         a new window and loads a plugin will fail. We should enable plugins in all windows by
4056         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
4057
4058         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
4059         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
4060         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
4061
4062         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4063         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
4064         WKBundleSetPluginsEnabled().
4065         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4066         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
4067         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
4068
4069 2016-12-05  Dean Jackson  <dino@apple.com>
4070
4071         pointer lock needs to be feature detectable
4072         https://bugs.webkit.org/show_bug.cgi?id=165426
4073         <rdar://problem/29486715>
4074
4075         Reviewed by Antoine Quint.
4076
4077         Expose the comment line to turn on/off pointer lock.
4078
4079         * DumpRenderTree/TestOptions.h:
4080         * DumpRenderTree/TestOptions.mm:
4081         (TestOptions::TestOptions):
4082         * DumpRenderTree/mac/DumpRenderTree.mm:
4083         (resetWebPreferencesToConsistentValues):
4084         * WebKitTestRunner/TestController.cpp:
4085         (WTR::TestController::resetPreferencesToConsistentValues):
4086         (WTR::updateTestOptionsFromTestHeader):
4087         * WebKitTestRunner/TestOptions.h:
4088         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4089         (WTR::PlatformWebView::viewSupportsOptions):
4090         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4091         (WTR::PlatformWebView::viewSupportsOptions):
4092
4093 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
4094
4095         Make it possible to use an existing simulator instance for one-off testing
4096         https://bugs.webkit.org/show_bug.cgi?id=164568
4097         <rdar://problem/29189133>
4098
4099         Reviewed by Daniel Bates.
4100
4101         With this patch, if a simulator is currently running on the machine and
4102         '--dedicated-simulators' is not passed into the application, only one simulator
4103         instance will be used, and this instance will be the existing instance.
4104         If no simulator is running or '--dedicated-simulators' is passed to the script,
4105         previous behavior will be used.
4106
4107         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4108         (parse_args):
4109         * Scripts/webkitpy/port/ios.py:
4110         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
4111         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
4112         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
4113         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
4114         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
4115         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
4116         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
4117         * Scripts/webkitpy/xcode/simulator.py:
4118         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
4119         (Simulator.current_device): Get currently running device.
4120
4121 2016-12-05  Dan Bernstein  <mitz@apple.com>
4122
4123         Disable a crashing test on iOS.
4124
4125         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4126
4127 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4128
4129         Fix a build break on EFL since r209303.
4130
4131         Unreviewed build fix.
4132
4133         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
4134
4135 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
4136
4137         Refactor SymbolImpl layout
4138         https://bugs.webkit.org/show_bug.cgi?id=165247
4139
4140         Reviewed by Darin Adler.
4141
4142         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4143         (TestWebKitAPI::TEST):
4144
4145 2016-12-03  Dan Bernstein  <mitz@apple.com>
4146
4147         Fixed the build after r209307.
4148
4149         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4150         (TEST):
4151
4152 2016-12-03  Dan Bernstein  <mitz@apple.com>
4153
4154         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
4155         https://bugs.webkit.org/show_bug.cgi?id=165276
4156         <rdar://problem/29467040>
4157
4158         Reviewed by Darin Adler.
4159
4160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4161         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
4162         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
4163         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
4164         (TEST):
4165         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
4166         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4167         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
4168         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
4169         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
4170         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
4171
4172 2016-12-02  Andy Estes  <aestes@apple.com>
4173
4174         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
4175         https://bugs.webkit.org/show_bug.cgi?id=164492
4176
4177         Reviewed by Dan Bernstein.
4178
4179         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
4180         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
4181         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
4182         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
4183         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
4184         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
4185         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
4186         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
4187         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4188         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4189         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4190         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4191         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
4192         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4193         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
4194         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4195         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4196         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4197         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4198         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4199         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4200         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4201         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4202         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
4203         value ${PRODUCT_BUNDLE_IDENTIFIER}.
4204         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4205         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4206         com.apple.WebKitTestRunner.InjectedBundle.
4207         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
4208         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4209         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4210         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
4211         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
4212         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
4213         ${PRODUCT_BUNDLE_IDENTIFIER}.
4214
4215 2016-12-02  Brady Eidson  <beidson@apple.com>
4216
4217         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
4218         https://bugs.webkit.org/show_bug.cgi?id=165330
4219
4220         Reviewed by Alex Christensen.
4221
4222         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
4223
4224         Problem is that doesn't reliably destroy the view.
4225         We should explicitly kill the process instead.
4226
4227         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
4228         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
4229
4230         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
4231         (TEST):
4232
4233 2016-12-02  Commit Queue  <commit-queue@webkit.org>
4234
4235         Unreviewed, rolling out r209136.
4236         https://bugs.webkit.org/show_bug.cgi?id=165337
4237
4238         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
4239
4240         Reverted changeset:
4241
4242         "Make it possible to use an existing simulator instance for
4243         one-off testing"
4244         https://bugs.webkit.org/show_bug.cgi?id=164568
4245         http://trac.webkit.org/changeset/209136
4246
4247 2016-12-02  Chris Dumez  <cdumez@apple.com>
4248
4249         [Mac][WK1] Implement new HTML interactive form validation user interface
4250         https://bugs.webkit.org/show_bug.cgi?id=164483
4251
4252         Reviewed by Simon Fraser.
4253
4254         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
4255         on Mac DRT as this is needed by the HTML form validation layout tests.
4256
4257         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4258         (WTR::UIScriptController::contentsOfUserInterfaceItem):
4259
4260 2016-12-02  Brady Eidson  <beidson@apple.com>
4261
4262         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
4263         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
4264
4265         Reviewed by Alexey Proskuryakov.
4266
4267         These tests had "run-loop races."
4268         
4269         The test spins the runloop waiting for one message.
4270         Two messages might come in from the WebProcess in short succession, and both be delivered to the
4271         UIProcess in the same spin of the runloop.
4272
4273         Therefore by the time the test stops spinning the runloop, notified that a message was received,
4274         the first message has been overwritten by the second.
4275
4276         These tests are fixed by queueing the incoming messages instead of just storing one.
4277
4278         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4279         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
4280         (getNextMessage):
4281         (TEST):
4282
4283         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
4284         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
4285         (getNextMessage):
4286         (TEST):
4287
4288 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
4289
4290         Add a runtime flag for SubtleCrypto
4291         https://bugs.webkit.org/show_bug.cgi?id=164982
4292
4293         Reviewed by Brent Fulgham.
4294
4295         * DumpRenderTree/mac/DumpRenderTree.mm:
4296         (resetWebPreferencesToConsistentValues):
4297         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4298