[iOS] Software keyboard is shown too frequently on some websites
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [iOS] Software keyboard is shown too frequently on some websites
4         https://bugs.webkit.org/show_bug.cgi?id=195856
5         <rdar://problem/49191395>
6
7         Reviewed by Darin Adler.
8
9         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
10
11         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
12         (WTR::UIScriptController::setHardwareKeyboardAttached):
13         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
14         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
15         (WTR::UIScriptController::setHardwareKeyboardAttached):
16         * TestRunnerShared/UIScriptContext/UIScriptController.h:
17         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
18
19         Additionally link against GraphicsServices in WebKitTestRunner.
20
21         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
22         (WTR::TestController::platformResetStateToConsistentValues):
23         (WTR::UIScriptController::setHardwareKeyboardAttached):
24
25 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
26
27         [GTK][WPE] Fix pacman install-dependencies packages
28         https://bugs.webkit.org/show_bug.cgi?id=196817
29
30         Reviewed by Žan Doberšek.
31         
32         python3-setuptools is called python-setuptools
33         ruby-highline is only available on AUR
34         libv4l-devel is incorporated in v4l-utils
35
36         * gtk/install-dependencies:
37         * wpe/install-dependencies:
38
39 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
40
41         [GTK] REGRESSION(r243860): Many tests failing
42         https://bugs.webkit.org/show_bug.cgi?id=196791
43
44         Reviewed by Joanmarie Diggs.
45
46         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
47         multiple documents and check that accessibility hierarchy is updated after a navigation.
48
49         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
50         (loadChangedCallback):
51         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
52         (AccessibilityTest::AccessibilityTest):
53         (AccessibilityTest::~AccessibilityTest):
54         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
55         (AccessibilityTest::findTestServerApplication):
56         (AccessibilityTest::findDocumentWeb):
57         (AccessibilityTest::findRootObject):
58         (AccessibilityTest::waitUntilChildrenRemoved):
59         (AccessibilityTest::ensureProxy):
60         (testAtspiBasicHierarchy):
61         (beforeAll):
62         (afterAll):
63
64 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
65
66         [ews-build] Handle bug titles with unicode characters
67         https://bugs.webkit.org/show_bug.cgi?id=196802
68
69         Reviewed by Dewei Zhu.
70
71         * BuildSlaveSupport/ews-build/steps.py:
72         (ValidatePatch._is_bug_closed):
73
74 2019-04-11  Michael Saboff  <msaboff@apple.com>
75
76         Improve the Inline Cache Stats code
77         https://bugs.webkit.org/show_bug.cgi?id=196836
78
79         Reviewed by Saam Barati.
80
81         Added a new script to consolidate and arrange the output of --useICStats option.
82
83         This script merges the output from every group into one large table and sorts it from most common to
84         least common.  It also counts the slow path GetById and PutById variants and then calculates the
85         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
86         Put together, this is useful to see what property accesses are not getting cached.
87
88         * Scripts/ic-stats.py: Added.
89         (ICStats):
90         (ICStats.__init__):
91         (ICStats.parse):
92         (ICStats.dumpStats):
93         (usage):
94
95 2019-04-10  Alex Christensen  <achristensen@webkit.org>
96
97         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
98         https://bugs.webkit.org/show_bug.cgi?id=196809
99         <rdar://49800762>
100
101         Reviewed by Brady Eidson.
102
103         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
104         (TEST):
105
106 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
107
108         requestAnimationFrame should execute before the next frame
109         https://bugs.webkit.org/show_bug.cgi?id=177484
110
111         Reviewed by Simon Fraser.
112
113         Add trace points for the page RenderingUpdate.
114
115         * Tracing/SystemTracePoints.plist:
116
117 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
118
119         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
120         https://bugs.webkit.org/show_bug.cgi?id=196760
121
122         Reviewed by Don Olmstead.
123
124         vswhere.exe has been bundled since Visual Studio 2017 version
125         15.2. We shouldn't download vswhere.exe.
126
127         * Scripts/build-jsc: Do not call update-vswhere.py.
128         * Scripts/build-webkit: Ditto.
129         * Scripts/update-vswhere.py: Removed.
130         * Scripts/webkitdirs.pm:
131         (requireModulesForVSWhere): Deleted.
132         (pickCurrentVisualStudioInstallation): Deleted.
133         (visualStudioInstallDirVSWhere): Return the latest installed VS
134         installation path by using the bundled vswhere.exe.
135         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
136         (visualStudioInstallDirFallback): Removed.
137
138 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
139
140         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
141         https://bugs.webkit.org/show_bug.cgi?id=196780
142
143         Reviewed by Alexey Proskuryakov.
144
145         * BuildSlaveSupport/ews-build/steps.py:
146         * BuildSlaveSupport/ews-build/steps_unittest.py:
147
148 2019-04-10  Alex Christensen  <achristensen@webkit.org>
149
150         Add SPI WKNavigationResponse._downloadAttribute
151         https://bugs.webkit.org/show_bug.cgi?id=196755
152         <rdar://49587365>
153
154         Reviewed by Brady Eidson.
155
156         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
157         (-[NavigationResponseTestDelegate navigationResponse]):
158         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
159         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
160         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
161         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
162         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
163         (readRequest):
164         (writeResponse):
165         (TEST):
166
167 2019-04-10  Tim Horton  <timothy_horton@apple.com>
168
169         Add modern API for overriding the page's specified viewport configuration
170         https://bugs.webkit.org/show_bug.cgi?id=167734
171         <rdar://problem/30331795>
172
173         Reviewed by Simon Fraser.
174
175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
176         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
177
178 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
179
180         Add support for incremental bytecode cache updates
181         https://bugs.webkit.org/show_bug.cgi?id=195000
182
183         Reviewed by Filip Pizlo.
184
185         Exit when the initial run to generate bytecode fails.
186
187         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
188
189 2019-04-10  Alex Christensen  <achristensen@webkit.org>
190
191         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
192         https://bugs.webkit.org/show_bug.cgi?id=196744
193         <rdar://49415309>
194
195         Reviewed by Chris Dumez.
196
197         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
198         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
199
200 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
201
202         Add a way to opt into modern compatibility mode in layout tests
203         https://bugs.webkit.org/show_bug.cgi?id=196770
204         <rdar://problem/49777550>
205
206         Reviewed by Antoine Quint.
207
208         Add a new test option to enable modern compatibility mode in layout tests.
209
210         * WebKitTestRunner/TestController.cpp:
211         (WTR::updateTestOptionsFromTestHeader):
212         * WebKitTestRunner/TestController.h:
213         * WebKitTestRunner/TestOptions.h:
214         (WTR::TestOptions::hasSameInitializationOptions const):
215         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
216         (WTR::TestController::platformCreateWebView):
217         (WTR::TestController::enableModernCompatibilityMode):
218
219 2019-04-10  Andy Estes  <aestes@apple.com>
220
221         Try to fix the 32-bit watchOS build.
222
223         * TestWebKitAPI/cocoa/TestWKWebView.mm:
224         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
225
226 2019-04-10  Antoine Quint  <graouts@apple.com>
227
228         Enable Pointer Events on watchOS
229         https://bugs.webkit.org/show_bug.cgi?id=196771
230         <rdar://problem/49040909>
231
232         Reviewed by Dean Jackson.
233
234         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
235
236 2019-04-10  Philippe Normand  <pnormand@igalia.com>
237
238         Unreviewed. Fix WPE accessibility tests after r244059.
239
240         We are failing to load the injected bundle due to undefined symbol
241         AccessibilityUIElement::replaceTextInRange().
242
243         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
244         (WTR::AccessibilityUIElement::replaceTextInRange):
245
246 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
247
248         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
249         https://bugs.webkit.org/show_bug.cgi?id=196727
250
251         Reviewed by Fujii Hironori.
252
253         * MiniBrowser/win/WebKitBrowserWindow.cpp:
254         (WebKitBrowserWindow::create):
255
256 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
257
258         [ews-build] Add unit tests for PrintConfiguration
259         https://bugs.webkit.org/show_bug.cgi?id=196752
260
261         Reviewed by Dewei Zhu.
262
263         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
264
265 2019-04-09  Keith Rollin  <krollin@apple.com>
266
267         Unreviewed build maintenance -- update .xcfilelists.
268
269         * DumpRenderTree/DerivedSources-input.xcfilelist:
270         * DumpRenderTree/DerivedSources-output.xcfilelist:
271
272 2019-04-09  Zalan Bujtas  <zalan@apple.com>
273
274         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
275         https://bugs.webkit.org/show_bug.cgi?id=196743
276         <rdar://problem/43897551>
277
278         Reviewed by Tim Horton.
279
280         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
281         (TEST):
282
283 2019-04-09  Youenn Fablet  <youenn@apple.com>
284
285         Close service worker database on network process suspension
286         https://bugs.webkit.org/show_bug.cgi?id=196623
287         <rdar://problem/48930869>
288
289         Reviewed by Alex Christensen.
290
291         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
292
293 2019-04-09  Daniel Bates  <dabates@apple.com>
294
295         [iPad] Should open popover when the spacebar is pressed
296         https://bugs.webkit.org/show_bug.cgi?id=196360
297         <rdar://problem/49389129>
298
299         Reviewed by Brent Fulgham.
300
301         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
302
303         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
304         (WTR::UIScriptController::isShowingPopover const): Added.
305         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
306         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
307         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
308         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
309         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
310         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
311         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
312         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
313         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
314         (WTR::UIScriptController::isShowingPopover const): Added.
315         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
316         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
317         * TestRunnerShared/UIScriptContext/UIScriptController.h:
318         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
319         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
320         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
321         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
322         (-[TestRunnerWKWebView _willPresentPopover]): Added.
323         (-[TestRunnerWKWebView _didDismissPopover]): Added.
324         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
325         (WTR::UIScriptController::isShowingPopover const): Added.
326         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
327         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
328
329 2019-04-09  Alex Christensen  <achristensen@webkit.org>
330
331         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
332         https://bugs.webkit.org/show_bug.cgi?id=196665
333         <rdar://45115669>
334
335         Reviewed by Geoff Garen.
336
337         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
338         (goBack):
339         (+[SimpleLookupContext sharedLookupContext]):
340         (-[SimpleLookupContext lookUpURL:completionHandler:]):
341         (TEST):
342         (+[Simple3LookupContext sharedLookupContext]): Deleted.
343         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
344
345 2019-04-09  John Wilander  <wilander@apple.com>
346
347         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
348         https://bugs.webkit.org/show_bug.cgi?id=196558
349         <rdar://problem/47650245>
350
351         Reviewed by Youenn Fablet.
352
353         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
354         (TestWebKitAPI::TEST):
355             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
356
357 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
358
359         [CMake] Apple builds should use ICU_INCLUDE_DIRS
360         https://bugs.webkit.org/show_bug.cgi?id=196720
361
362         Reviewed by Konstantin Tokarev.
363
364         * TestWebKitAPI/PlatformMac.cmake:
365
366 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
367
368         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
369         https://bugs.webkit.org/show_bug.cgi?id=196694
370         <rdar://problem/48388734>
371
372         Rubber-stamped by Aakash Jain.
373
374         * Scripts/webkitpy/port/image_diff.py:
375         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
376         * Scripts/webkitpy/port/server_process.py:
377         (ServerProcess.has_available_stdout): Check if stdout has data in it.
378         (ServerProcess._wait_for_data_and_update_buffers_using_select):
379         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
380         * Scripts/webkitpy/port/server_process_mock.py:
381         (MockServerProcess.has_available_stdout):
382         * Scripts/webkitpy/port/server_process_unittest.py:
383         (TestServerProcess.serial_test_basic):
384
385 2019-04-09  Jer Noble  <jer.noble@apple.com>
386
387         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
388         https://bugs.webkit.org/show_bug.cgi?id=196097
389
390         Reviewed by Eric Carlson.
391
392         Drive-by bug fix: allow tests to play audio without a user gesture by default.
393
394         * DumpRenderTree/mac/DumpRenderTree.mm:
395         (resetWebPreferencesToConsistentValues):
396         * WebKitTestRunner/TestController.cpp:
397         (WTR::TestController::resetPreferencesToConsistentValues):
398
399 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
400
401         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
402         https://bugs.webkit.org/show_bug.cgi?id=196690
403
404         Reviewed by Michael Catanzaro.
405
406         * QueueStatusServer/config/queues.py:
407         * Scripts/webkitpy/common/config/ews.json:
408         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
409         (test_ews_name):
410
411 2019-04-09  Chris Dumez  <cdumez@apple.com>
412
413         Loads using loadHTMLString() cause flashing when process-swapping
414         https://bugs.webkit.org/show_bug.cgi?id=196714
415         <rdar://problem/49637354>
416
417         Reviewed by Antti Koivisto.
418
419         Add API test coverage.
420
421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
422
423 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
424
425         Unreviewed. Fix ATK accessibility tests after r244059.
426
427         We are failing to load the injected bundle due to undefined symbol
428         AccessibilityUIElement::replaceTextInRange().
429
430         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
431         (WTR::AccessibilityUIElement::replaceTextInRange):
432
433 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
434
435         AX: Support API: accessibilityReplaceRange:withText
436         https://bugs.webkit.org/show_bug.cgi?id=196636
437
438         Unreviewed build fix for Windows port.
439
440         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
441         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
442
443 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
444
445         [CMake][WinCairo] Separate copied headers into different directories
446         https://bugs.webkit.org/show_bug.cgi?id=196655
447
448         Reviewed by Michael Catanzaro.
449
450         * DumpRenderTree/CMakeLists.txt:
451         * MiniBrowser/win/CMakeLists.txt:
452         * TestWebKitAPI/CMakeLists.txt:
453         * TestWebKitAPI/PlatformWin.cmake:
454
455 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
456
457         Log stack-trace for run-webkit-tests when interrupted
458         https://bugs.webkit.org/show_bug.cgi?id=176393
459         <rdar://problem/34262310>
460
461         Reviewed by Lucas Forschler.
462
463         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
464         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
465         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
466         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
467         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
468         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
469         (main): Set handlers to log stack trace on interruption.
470
471 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
472
473         AX: Support API: accessibilityReplaceRange:withText
474         https://bugs.webkit.org/show_bug.cgi?id=196636
475
476         Unreviewed build fix for Windows port.
477
478         * DumpRenderTree/AccessibilityUIElement.cpp:
479         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
480
481 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
482
483         [ews-build] Scripts using Buildbot API have CORS error
484         https://bugs.webkit.org/show_bug.cgi?id=196709
485
486         Reviewed by Alexey Proskuryakov.
487
488         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
489
490 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
491
492         AX: Support API: accessibilityReplaceRange:withText
493         https://bugs.webkit.org/show_bug.cgi?id=196636
494
495         Reviewed by Daniel Bates.
496
497         * DumpRenderTree/AccessibilityUIElement.cpp:
498         (replaceTextInRangeCallback):
499         (AccessibilityUIElement::replaceTextInRange):
500         (AccessibilityUIElement::getJSClass):
501         * DumpRenderTree/AccessibilityUIElement.h:
502         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
503         (AccessibilityUIElement::replaceTextInRange):
504         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
505         (AccessibilityUIElement::replaceTextInRange):
506         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
507         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
508         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
509         (WTR::AccessibilityUIElement::replaceTextInRange):
510         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
511         (WTR::AccessibilityUIElement::replaceTextInRange):
512
513 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
514
515         [iOS] Do not allow starting selection drags when selection views are not visible
516         https://bugs.webkit.org/show_bug.cgi?id=196686
517         <rdar://problem/49399192>
518
519         Reviewed by Tim Horton.
520
521         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
522         also add some new API tests to cover scenarios where the web view is not first responder.
523
524         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
525         (TestWebKitAPI::TEST):
526         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
527
528         Add a switch to optionally make the web view first responder when starting the simulated drag.
529
530         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
531         (-[DragAndDropSimulator initWithWebView:]):
532         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
533
534 2019-04-08  Justin Fan  <justin_fan@apple.com>
535
536         [Web GPU] Fix Web GPU experimental feature on iOS
537         https://bugs.webkit.org/show_bug.cgi?id=196632
538
539         Reviewed by Myles C. Maxfield.
540
541         Properly make Web GPU available on iOS 11+.
542
543         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
544
545 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
546
547         [ews-build] Do not upload archive when Compile Fails
548         https://bugs.webkit.org/show_bug.cgi?id=196674
549
550         Reviewed by Alexey Proskuryakov.
551
552         * BuildSlaveSupport/ews-build/factories.py:
553         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
554         * BuildSlaveSupport/ews-build/steps.py:
555         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
556         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
557         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
558
559 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
560
561         Enable DFG on MIPS
562         https://bugs.webkit.org/show_bug.cgi?id=196689
563
564         Reviewed by Žan Doberšek.
565
566         Since the bytecode change, we enabled the baseline JIT on mips in
567         r240432, but DFG is still missing. With this change, all tests are
568         passing on a ci20 board.
569
570         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
571
572 2019-04-08  Philippe Normand  <pnormand@igalia.com>
573
574         [Flatpak] Second run update-webkitwpe-flatpak fails
575         https://bugs.webkit.org/show_bug.cgi?id=192702
576
577         Reviewed by Carlos Garcia Campos.
578
579         * flatpak/flatpakutils.py:
580         (FlatpakObject.flatpak): Fix typo.
581         (FlatpakPackage.install): When installing, also update to the configured remote commit.
582         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
583
584 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
585
586         [GTK][WPE] outlook.live.com displays old-fashioned UI
587         https://bugs.webkit.org/show_bug.cgi?id=196642
588
589         Reviewed by Carlos Garcia Campos.
590
591         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
592         (TestWebKitAPI::TEST): New Mac platform quirk test.
593
594 2019-04-07  Commit Queue  <commit-queue@webkit.org>
595
596         Unreviewed, rolling out r243956.
597         https://bugs.webkit.org/show_bug.cgi?id=196688
598
599         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
600         by aakashjain on #webkit).
601
602         Reverted changeset:
603
604         "Clicking "Go Back" from a safe browsing warning from an
605         iframe should navigate the WKWebView back to the previous
606         page"
607         https://bugs.webkit.org/show_bug.cgi?id=196665
608         https://trac.webkit.org/changeset/243956
609
610 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
611
612         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
613         https://bugs.webkit.org/show_bug.cgi?id=196669
614
615         Reviewed by Geoffrey Garen.
616
617         Added three new unit tests for WeakHashSet.
618
619         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
620         (WTF_WeakPtr.WeakHashSetConstObjects):
621         (WTF_WeakPtr.WeakHashSetComputesEmpty):
622         (WTF_WeakPtr.WeakHashSetComputeSize):
623
624 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
625
626         Hide next and previous form control buttons when WKWebView is editable
627         https://bugs.webkit.org/show_bug.cgi?id=196672
628         <rdar://problem/35625321>
629
630         Reviewed by Tim Horton.
631
632         Add a new API test.
633
634         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
635         (-[TestWKWebView lastTrailingBarButtonGroup]):
636         (TestWebKitAPI::TEST):
637         * TestWebKitAPI/ios/UIKitSPI.h:
638
639 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
640
641         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
642         https://bugs.webkit.org/show_bug.cgi?id=196077
643         <rdar://problem/49108202>
644
645         Reviewed by Chris Dumez.
646
647         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
648         on new web view.
649
650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
651
652 2019-04-05  Saam Barati  <sbarati@apple.com>
653
654         Make compare-results understand MotionMark
655         https://bugs.webkit.org/show_bug.cgi?id=196666
656
657         Reviewed by Yusuke Suzuki.
658
659         * Scripts/compare-results:
660         (PLT5Results):
661         (detectMotionMark):
662         (detectMotionMark1_1):
663         (motionMarkResults):
664         (motionMark1_1Results):
665         (detectBenchmark):
666         (biggerIsBetter):
667         (main):
668
669 2019-04-05  Alex Christensen  <achristensen@webkit.org>
670
671         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
672         https://bugs.webkit.org/show_bug.cgi?id=196665
673         <rdar://45115669>
674
675         Reviewed by Geoff Garen.
676
677         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
678         (goBack):
679         (+[SimpleLookupContext sharedLookupContext]):
680         (-[SimpleLookupContext lookUpURL:completionHandler:]):
681         (TEST):
682         (+[Simple3LookupContext sharedLookupContext]): Deleted.
683         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
684
685 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
686
687         [ews-build] Add configuration and architecture for windows builders
688         https://bugs.webkit.org/show_bug.cgi?id=196660
689
690         Reviewed by Lucas Forschler.
691
692         * BuildSlaveSupport/ews-build/config.json:
693
694 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
695
696         webkitpy: Don't run subsequent rounds if interrupted
697         https://bugs.webkit.org/show_bug.cgi?id=196646
698
699         Reviewed by Aakash Jain.
700
701         * Scripts/webkitpy/layout_tests/controllers/manager.py:
702         (Manager.run): Bail out if interrupted.
703
704 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
705
706         Test sessionStorage in PSON private browsing mode
707         https://bugs.webkit.org/show_bug.cgi?id=196561
708
709         Reviewed by Alex Christensen.
710
711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
712
713 2019-04-05  Commit Queue  <commit-queue@webkit.org>
714
715         Unreviewed, rolling out r243833.
716         https://bugs.webkit.org/show_bug.cgi?id=196645
717
718         This change breaks build of WPE and GTK ports (Requested by
719         annulen on #webkit).
720
721         Reverted changeset:
722
723         "[CMake][WTF] Mirror XCode header directories"
724         https://bugs.webkit.org/show_bug.cgi?id=191662
725         https://trac.webkit.org/changeset/243833
726
727 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
728
729         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
730         https://bugs.webkit.org/show_bug.cgi?id=196635
731
732         Reviewed by Antti Koivisto.
733         
734         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
735         for a test to enable async frame scrolling via:
736             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
737         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
738         
739         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
740
741         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
742         (WTR::InjectedBundle::beginTesting):
743         * WebKitTestRunner/TestController.cpp:
744         (WTR::TestController::resetPreferencesToConsistentValues):
745
746 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
747
748         Use a correct LC_RPATH when building with ASan
749         https://bugs.webkit.org/show_bug.cgi?id=196576
750
751         Reviewed by David Kilzer.
752
753         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
754         so that ../Frameworks is checked. This is simpler and more reliable than updating
755         each SPC service xcconfig.
756
757 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
758
759         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
760         https://bugs.webkit.org/show_bug.cgi?id=196629
761
762         Reviewed by Lucas Forschler.
763
764         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
765
766 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
767
768         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
769         https://bugs.webkit.org/show_bug.cgi?id=196618
770
771         Reviewed by Lucas Forschler.
772
773         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
774         (StatusBubble): Added QUEUE_TRIGGERS.
775         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
776         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
777         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
778         its parent(builder).
779
780 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
781
782         [ews-app] Status-bubble steps are sometimes displayed in reverse order
783         https://bugs.webkit.org/show_bug.cgi?id=196625
784
785         Reviewed by Lucas Forschler.
786
787         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
788         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
789
790 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
791
792         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
793         https://bugs.webkit.org/show_bug.cgi?id=196630
794
795         Reviewed by Wenson Hsieh.
796
797         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
798
799 2019-04-04  Youenn Fablet  <youenn@apple.com>
800
801         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
802         https://bugs.webkit.org/show_bug.cgi?id=196543
803
804         Reviewed by Alex Christensen.
805
806         * WebKitTestRunner/TestController.cpp:
807         (WTR::TestController::generatePageConfiguration):
808
809 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
810
811         [ews-app] Status bubble should not display skipped buildbot steps
812         https://bugs.webkit.org/show_bug.cgi?id=196584
813
814         Reviewed by Lucas Forschler.
815
816         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
817
818 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
819
820         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
821         https://bugs.webkit.org/show_bug.cgi?id=196620
822
823         Reviewed by Lucas Forschler.
824
825         * BuildSlaveSupport/ews-app/ews/config.py:
826
827 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
828
829         [Win] DumpRenderTreeWatchDog.py is not checked into source
830         https://bugs.webkit.org/show_bug.cgi?id=196567
831         <rdar://problem/49525901>
832
833         Reviewed by Lucas Forschler.
834
835         This script is used on Win EWS bots to terminate hanging DRT processes.
836
837         * EWSTools/dumprendertreewatchdog.py: Added.
838
839 2019-04-04  Chris Dumez  <cdumez@apple.com>
840
841         Unreviewed, roll out r243858 which made tests time out.
842
843         Disable new API tests on Windows instead.
844
845         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
846         (TestWebKitAPI::TEST):
847
848 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
849
850         [ATK] Cleanup WebPageAccessibilityObjectAtk
851         https://bugs.webkit.org/show_bug.cgi?id=196537
852
853         Reviewed by Michael Catanzaro.
854
855         Also consider files under atk directories as exceptions for GObject conventions.
856
857         * Scripts/webkitpy/style/checkers/cpp.py:
858         (check_identifier_name_in_declaration):
859
860 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
861
862         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
863         https://bugs.webkit.org/show_bug.cgi?id=196588
864         <rdar://problem/49365787>
865
866         Unreviewed build fix for Windows port.
867
868         error C3861: 'kill': identifier not found
869
870         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
871         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
872
873 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
874
875         [ews-build] Cancel build and similar operations should have authentication
876         https://bugs.webkit.org/show_bug.cgi?id=196520
877
878         Reviewed by Dewei Zhu.
879
880         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
881         environment variables.
882
883 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
884
885         [ews-build] Do not trigger queues which are not in production yet
886         https://bugs.webkit.org/show_bug.cgi?id=196581
887
888         Reviewed by Dewei Zhu.
889
890         * BuildSlaveSupport/ews-build/config.json:
891
892 2019-04-03  Chris Dumez  <cdumez@apple.com>
893
894         Unreviewed, fix typo in the name of API test added in r243848.
895
896         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
897         (TestWebKitAPI::TEST):
898
899 2019-04-03  Chris Dumez  <cdumez@apple.com>
900
901         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
902         https://bugs.webkit.org/show_bug.cgi?id=196588
903         <rdar://problem/49365787>
904
905         Reviewed by Ryosuke Niwa.
906
907         Add API test coverage.
908
909         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
910         (TestWebKitAPI::nullJavaScriptCallback):
911         (TestWebKitAPI::didCrashCheckFrames):
912         (TestWebKitAPI::TEST):
913
914 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
915
916         run-webkit-tests: Upload test results (new results database)
917         https://bugs.webkit.org/show_bug.cgi?id=196577
918         <rdar://problem/34841155>
919
920         Reviewed by Lucas Forschler.
921
922         * Scripts/webkitpy/layout_tests/controllers/manager.py:
923         (Manager.run): Upload results after each device shard, since the configuration will be
924         different for each device.
925         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
926         uploaded to a results database.
927         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
928         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
929
930 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
931
932         -apple-trailing-word is needed for browser detection
933         https://bugs.webkit.org/show_bug.cgi?id=196575
934
935         Unreviewed.
936
937         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
938
939 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
940
941         [CMake][WTF] Mirror XCode header directories
942         https://bugs.webkit.org/show_bug.cgi?id=191662
943
944         Reviewed by Konstantin Tokarev.
945
946         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
947         builds.
948
949         * CMakeLists.txt:
950         * DumpRenderTree/CMakeLists.txt:
951         * DumpRenderTree/PlatformWin.cmake:
952         * MiniBrowser/win/CMakeLists.txt:
953         * TestWebKitAPI/CMakeLists.txt:
954         * TestWebKitAPI/PlatformWin.cmake:
955         * WebKitTestRunner/PlatformGTK.cmake:
956         * WebKitTestRunner/PlatformWin.cmake:
957
958 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
959
960         [ews-app] Status bubble should not display certain infrastructure status messages
961         https://bugs.webkit.org/show_bug.cgi?id=196550
962
963         Reviewed by Lucas Forschler.
964
965         Do not display the steps which are un-needed for end-user. This information is still avaiable
966         if the user click on the bubble and look at the Buildbot build.
967         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
968         (StatusBubble._steps_messages):
969         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
970
971 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
972
973         [ews-build] Use https for sending data to ews-app
974         https://bugs.webkit.org/show_bug.cgi?id=196492
975
976         Reviewed by Lucas Forschler.
977
978         * BuildSlaveSupport/ews-build/events.py:
979
980 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
981
982         Remove support for -apple-trailing-word
983         https://bugs.webkit.org/show_bug.cgi?id=196525
984
985         Reviewed by Zalan Bujtas.
986
987         This CSS property is nonstandard and not used.
988
989         * Scripts/webkitperl/FeatureList.pm:
990         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
991
992 2019-04-03  Youenn Fablet  <youenn@apple.com>
993
994         Add a test for DOMCache on multiple browsing in case of private browsing
995         https://bugs.webkit.org/show_bug.cgi?id=196524
996
997         Reviewed by Alex Christensen.
998
999         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1000         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1001
1002 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1003
1004         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1005         https://bugs.webkit.org/show_bug.cgi?id=196540
1006
1007         Reviewed by Aakash Jain.
1008
1009         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1010
1011 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1012
1013         Add plumbing for a compatibility mode preference in WebKit
1014         https://bugs.webkit.org/show_bug.cgi?id=196005
1015
1016         Reviewed by Tim Horton.
1017
1018         Add new API tests.
1019
1020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1021         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1022
1023 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1024
1025         [WPE][GTK] Update libsrtp dependency package for Debian
1026         https://bugs.webkit.org/show_bug.cgi?id=196528
1027
1028         Reviewed by Frédéric Wang.
1029
1030         * gtk/install-dependencies:
1031         * wpe/install-dependencies:
1032
1033 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1034
1035         [WK2] Add support for Window's beforeprint / afterprint events
1036         https://bugs.webkit.org/show_bug.cgi?id=196478
1037         <rdar://problem/49535124>
1038
1039         Unreviewed build fix for MSVC.
1040
1041         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1042
1043         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1044
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::printFrame): Use int and float literals.
1047
1048 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1049
1050         [ews-build] Reassign bots to queues
1051
1052         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1053
1054 2019-04-02  Chris Dumez  <cdumez@apple.com>
1055
1056         [WK2] Add support for Window's beforeprint / afterprint events
1057         https://bugs.webkit.org/show_bug.cgi?id=196478
1058
1059         Reviewed by Alex Christensen.
1060
1061         Add minimal implementation for printFrame in WebKitTestRunner.
1062
1063         * WebKitTestRunner/TestController.cpp:
1064         (WTR::printFrame):
1065         (WTR::TestController::createOtherPage):
1066         (WTR::TestController::createWebViewWithOptions):
1067
1068 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1069
1070         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1071         https://bugs.webkit.org/show_bug.cgi?id=196491
1072
1073         Reviewed by Lucas Forschler.
1074
1075         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1076
1077 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1078
1079         [ews-build] Configure buildbot try credentials in environment variables
1080         https://bugs.webkit.org/show_bug.cgi?id=196501
1081
1082         Reviewed by Lucas Forschler.
1083
1084         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1085         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1086         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1087
1088 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1089
1090         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1091         https://bugs.webkit.org/show_bug.cgi?id=196496
1092         <rdar://problem/49521634>
1093
1094         Reviewed by Chris Dumez.
1095
1096         Add new API tests (see WebKit ChangeLog for more detail).
1097
1098         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1099         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1100         (TEST):
1101
1102 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1103
1104         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1105         <https://webkit.org/b/196499>
1106
1107         Reviewed by Alexey Proskuryakov.
1108
1109         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1110         ENABLE_ADDRESS_SANITIZER.
1111
1112 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1113
1114         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1115         https://bugs.webkit.org/show_bug.cgi?id=182757
1116
1117         Reviewed by Don Olmstead.
1118
1119         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1120         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1121
1122 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1123
1124         run-api-tests: Upload test results
1125         https://bugs.webkit.org/show_bug.cgi?id=196323
1126         <rdar://problem/49356714>
1127
1128         Reviewed by Lucas Forschler.
1129
1130         * Scripts/webkitpy/api_tests/manager.py:
1131         (Manager):
1132         (Manager.run): Upload results to a results database.
1133         * Scripts/webkitpy/api_tests/run_api_tests.py:
1134         (parse_args): Add upload arguments.
1135         * Scripts/webkitpy/port/base.py:
1136         (Port):
1137         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1138         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1139         with commits from any other associated repositories.
1140         * Scripts/webkitpy/port/device.py:
1141         (Device):
1142         (Device.build_version): Access build_versoin of underlying platform device.
1143         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1144         (IOSSimulatorTest):
1145         (IOSSimulatorTest.test_configuration_for_upload):
1146         * Scripts/webkitpy/port/device_port.py:
1147         (DevicePort):
1148         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1149         the same as the machine uploading results.
1150         * Scripts/webkitpy/port/mac.py:
1151         (MacPort):
1152         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1153         * Scripts/webkitpy/port/mac_unittest.py:
1154         (MacTest):
1155         (MacTest.test_configuration_for_upload):
1156         * Scripts/webkitpy/xcode/simulated_device.py:
1157         (SimulatedDeviceManager._create_device_with_runtime):
1158         (SimulatedDevice.__init__): Create simulated device with a build_version.
1159         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1160         (test_existing_simulator):
1161
1162 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1163
1164         Remove extra newline characters (Follow-up fix to r243707)
1165
1166         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1167
1168 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1169
1170         [ews-app] Use API_KEY to accept results data
1171         https://bugs.webkit.org/show_bug.cgi?id=196461
1172
1173         Reviewed by Dewei Zhu.
1174
1175         * BuildSlaveSupport/ews-app/ews/views/results.py:
1176         (Results.post): Validate EWS_API_KEY before accepting any data.
1177         * BuildSlaveSupport/ews-build/events.py:
1178         (Events.sendData): Send EWS_API_KEY if available along with event data.
1179
1180 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1181
1182         Unable to copy and paste a PDF from Notes into Mail compose body
1183         https://bugs.webkit.org/show_bug.cgi?id=196442
1184         <rdar://problem/48573098>
1185
1186         Reviewed by Tim Horton.
1187
1188         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1189         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1190         to be specified on the item providers.
1191
1192         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1193         (TestWebKitAPI::mapItemForTesting):
1194         (TestWebKitAPI::contactItemForTesting):
1195
1196 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1197
1198         Make UIWKDocumentContext rects per-character instead of per-word
1199         https://bugs.webkit.org/show_bug.cgi?id=196459
1200
1201         Reviewed by Wenson Hsieh.
1202
1203         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1204         (TEST):
1205         Adjust test results due to switching to per-character rects.
1206
1207 2019-04-01  Chris Dumez  <cdumez@apple.com>
1208
1209         UIProcess crash when a prewarmed process is terminated
1210         https://bugs.webkit.org/show_bug.cgi?id=196451
1211         <rdar://problem/49245471>
1212
1213         Reviewed by Geoffrey Garen.
1214
1215         Add API test coverage.
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1218         (TEST):
1219
1220 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1221
1222         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1223         https://bugs.webkit.org/show_bug.cgi?id=196449
1224
1225         Reviewed by Lucas Forschler.
1226
1227         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1228         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1229         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1230         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1231
1232 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1233
1234         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1235         https://bugs.webkit.org/show_bug.cgi?id=196444
1236
1237         Reviewed by Lucas Forschler.
1238
1239         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1240
1241 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1242
1243         Add SPI to canonicalize NSURLs with WTF::URL
1244         https://bugs.webkit.org/show_bug.cgi?id=196415
1245         <rdar://problem/44980271>
1246
1247         Reviewed by Darin Adler.
1248
1249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1250         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1251         (TestWebKitAPI::TEST):
1252
1253 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1254
1255         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1256         https://bugs.webkit.org/show_bug.cgi?id=196441
1257
1258         Reviewed by Carlos Garcia Campos.
1259
1260         Don't cache the wpe_view_backend object that might not exist yet at the
1261         time of EventSenderProxy constructor invocation, but instead retrieve
1262         that object whenever it's required for event dispatching. This should
1263         avoid crashes in this constructor now that it's invoked before any
1264         PlatformWindow has been set up (as changed in r243496).
1265
1266         * WebKitTestRunner/EventSenderProxy.h:
1267         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1268         (WTR::viewBackend):
1269         (WTR::EventSenderProxy::EventSenderProxy):
1270         (WTR::EventSenderProxy::mouseDown):
1271         (WTR::EventSenderProxy::mouseUp):
1272         (WTR::EventSenderProxy::mouseMoveTo):
1273         (WTR::EventSenderProxy::mouseScrollBy):
1274         (WTR::EventSenderProxy::keyDown):
1275         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1276
1277 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1278
1279         [Win][WebKit] MiniBrowser should support high DPI display
1280         https://bugs.webkit.org/show_bug.cgi?id=196391
1281
1282         Reviewed by Alex Christensen.
1283
1284         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1285         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1286         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1287         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1288
1289 2019-03-31  Sam Weinig  <weinig@apple.com>
1290
1291         Remove more i386 specific configurations
1292         https://bugs.webkit.org/show_bug.cgi?id=196430
1293
1294         Reviewed by Alexey Proskuryakov.
1295
1296         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1297         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1298
1299 2019-03-31  Andy Estes  <aestes@apple.com>
1300
1301         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1302         https://bugs.webkit.org/show_bug.cgi?id=196433
1303         <rdar://problem/49293305>
1304
1305         Reviewed by Tim Horton.
1306
1307         Enhanced API test coverage to include all navigation response policy decisions in both
1308         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1309
1310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1311         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1312         (TestWebKitAPI::TEST):
1313         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1314         (readFile):
1315         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1316         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1317         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1318         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1319         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1320         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1321         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1322         (-[QuickLookDelegate _downloadDidStart:]):
1323         (-[QuickLookDelegate _download:didReceiveResponse:]):
1324         (-[QuickLookDelegate _download:didReceiveData:]):
1325         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1326         (-[QuickLookDelegate _downloadDidFinish:]):
1327         (-[QuickLookDelegate _download:didFailWithError:]):
1328         (-[QuickLookDelegate _downloadDidCancel:]):
1329         (-[QuickLookDelegate verifyDownload]):
1330         (runTest):
1331         (runTestDecideBeforeLoading):
1332         (runTestDecideAfterLoading):
1333         (TEST):
1334         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1335         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1336         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1337         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1338         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1339         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1340         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1341         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1342         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1343         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1344         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1345         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1346         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1347         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1348
1349 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1350
1351         [CMake] add testdfg as target with build-jsc
1352         https://bugs.webkit.org/show_bug.cgi?id=196393
1353
1354         Reviewed by Saam Barati.
1355
1356         Added testdfg as one of the targets to build when
1357         using CMake.
1358
1359         * Scripts/build-jsc:
1360
1361 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1362
1363         Delete WebMetal implementation in favor of WebGPU
1364         https://bugs.webkit.org/show_bug.cgi?id=195418
1365
1366         Reviewed by Dean Jackson.
1367
1368         * DumpRenderTree/mac/DumpRenderTree.mm:
1369         (enableExperimentalFeatures):
1370         (resetWebPreferencesToConsistentValues):
1371         * Scripts/webkitperl/FeatureList.pm:
1372         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1374         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1375         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1376         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1377         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1378         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1379         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1380         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1381         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1382         (WTR::InjectedBundle::beginTesting):
1383         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1384         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1385         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1386
1387 2019-03-29  Chris Dumez  <cdumez@apple.com>
1388
1389         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1390         https://bugs.webkit.org/show_bug.cgi?id=196405
1391         <rdar://problem/49428130>
1392
1393         Reviewed by Wenson Hsieh.
1394
1395         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1396         the popover presentation methods to be no-ops. Use this in the new test added in
1397         r243523 so that we do not swizzle those methods for all tests. This is needed because
1398         those WatchOS tests rely on the popover getting presented and interactive.
1399
1400         * WebKitTestRunner/TestController.cpp:
1401         (WTR::updateTestOptionsFromTestHeader):
1402         * WebKitTestRunner/TestController.h:
1403         * WebKitTestRunner/TestOptions.h:
1404         (WTR::TestOptions::hasSameInitializationOptions const):
1405         * WebKitTestRunner/ios/TestControllerIOS.mm:
1406         (WTR::TestController::platformInitialize):
1407         (WTR::TestController::platformResetStateToConsistentValues):
1408
1409 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1410
1411         [Curl] Add Server Trust Evaluation Support.
1412         https://bugs.webkit.org/show_bug.cgi?id=191646
1413
1414         Reviewed by Fujii Hironori.
1415
1416         Implemented MiniBrowser UI for asking if user trusts the server.
1417
1418         * MiniBrowser/win/Common.cpp:
1419         (askServerTrustEvaluation):
1420         (replaceString):
1421         * MiniBrowser/win/Common.h:
1422         * MiniBrowser/win/MiniBrowserLib.rc:
1423         * MiniBrowser/win/MiniBrowserLibResource.h:
1424         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1425         (createPEMString):
1426         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1427         (WebKitBrowserWindow::canTrustServerCertificate):
1428         * MiniBrowser/win/WebKitBrowserWindow.h:
1429
1430 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1431
1432         Implement ResizeObserver.
1433         https://bugs.webkit.org/show_bug.cgi?id=157743
1434
1435         Reviewed by Simon Fraser.
1436
1437         Support resizeObserverEnabled webPreferences.
1438
1439         * DumpRenderTree/TestOptions.cpp:
1440         (TestOptions::TestOptions):
1441         * DumpRenderTree/TestOptions.h:
1442         * DumpRenderTree/mac/DumpRenderTree.mm:
1443         (setWebPreferencesForTestOptions):
1444         * DumpRenderTree/win/DumpRenderTree.cpp:
1445         (enableExperimentalFeatures):
1446         * Scripts/webkitperl/FeatureList.pm:
1447         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1448
1449 2019-03-28  John Wilander  <wilander@apple.com>
1450
1451         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1452         https://bugs.webkit.org/show_bug.cgi?id=196281
1453         <rdar://problem/48938748>
1454
1455         Reviewed by Alex Christensen.
1456
1457         This patch adds the function isStatisticsHasLocalStorage() to the
1458         TestRunner. With it, the page can query the WebsiteDataStore in the
1459         UI process to make sure that it sees LocalStorage.
1460
1461         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1462         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1463         (WTR::TestRunner::isStatisticsHasLocalStorage):
1464         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1465         * WebKitTestRunner/TestController.cpp:
1466         (WTR::TestController::isStatisticsHasLocalStorage):
1467         * WebKitTestRunner/TestController.h:
1468         * WebKitTestRunner/TestInvocation.cpp:
1469         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1470
1471 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1472
1473         API::Data::createWithoutCopying should do a null check before calling CFRelease
1474         https://bugs.webkit.org/show_bug.cgi?id=196276
1475         <rdar://problem/48059859>
1476
1477         Reviewed by Alex Christensen.
1478
1479         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1480
1481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1482         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1483         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1484         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1485         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1486         (TestWebKitAPI::TEST):
1487
1488 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1489
1490         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1491         https://bugs.webkit.org/show_bug.cgi?id=186276
1492
1493         Reviewed by Carlos Garcia Campos.
1494
1495         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1496         (webViewLoadChanged):
1497         (testWebResourceGetDataError):
1498         (testWebResourceGetDataEmpty):
1499         (beforeAll):
1500         (webViewloadChanged): Deleted.
1501
1502 2019-03-27  Andy Estes  <aestes@apple.com>
1503
1504         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1505         https://bugs.webkit.org/show_bug.cgi?id=196317
1506
1507         Reviewed by Dan Bernstein.
1508
1509         package-root copies built products into a staging directory using ditto(1), which does not
1510         follow symbolic links as it traverses a directory. Now that the files in
1511         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1512         itself, these become broken links when ditto'd into the staging directory.
1513
1514         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1515
1516         * Scripts/package-root:
1517
1518 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1519
1520         [ews-app] Update display text of Submit for ews analysis
1521         https://bugs.webkit.org/show_bug.cgi?id=196309
1522
1523         Reviewed by Dewei Zhu.
1524
1525         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1526
1527 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1528
1529         run-webkit-tests should check for leaks in WebKit processes
1530         <https://webkit.org/b/193772>
1531         <rdar://problem/46526680>
1532
1533         Reviewed by Ryosuke Niwa.
1534
1535         This works by doing the following:
1536         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1537           The list of child processes are returned one per line:
1538           process.name: pid
1539         - Run the "#LIST CHILD PROCESSES" command just before the
1540           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1541           processes on the ServerProcess object.
1542         - When the `--leaks` switch is handled, run check_for_leaks() on
1543           each child process after the main test harness.
1544
1545         * DumpRenderTree/mac/DumpRenderTree.mm:
1546         (handleControlCommand):
1547         - Use strncmp() instead of strcmp().
1548         - Add support for handling "#LIST CHILD PROCESSES" command.
1549
1550         * Scripts/webkitpy/port/base.py:
1551         (Port.check_for_leaks):
1552         * Scripts/webkitpy/port/darwin.py:
1553         (DarwinPort.check_for_leaks):
1554         - Rename redundant 'process_pid' argument to 'process_id'.
1555
1556         * Scripts/webkitpy/port/driver.py:
1557         (Driver.do_post_tests_work):
1558         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1559           longer the only command this sends to WebKitTestRunner.
1560         - If the `--leaks` switch is present, send the
1561           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1562           result using Port.set_webkit_processes().
1563         (Driver._parse_child_processes_output):
1564         - Add helper method to parse list of child process names and
1565           process IDs returned from WebKitTestRunner.
1566
1567         * Scripts/webkitpy/port/ios_device.py:
1568         (IOSDevicePort.check_for_leaks):
1569         - Rename redundant 'process_pid' argument to 'process_id'.
1570
1571         * Scripts/webkitpy/port/leakdetector.py:
1572         (LeakDetector._parse_leaks_output):
1573         - Return early if there is no leaks_output.
1574         (LeakDetector.check_for_leaks):
1575         - Rename redundant 'process_pid' argument to 'process_id'.
1576
1577         * Scripts/webkitpy/port/server_process.py:
1578         (ServerProcess.__init__):
1579         (ServerProcess.child_processes):
1580         (ServerProcess.set_child_processes):
1581         - Add instance variable to Port to store list of child process
1582           names and process IDs returned from WebKitTestRunner.
1583         (ServerProcess._start):
1584         - Clear self._child_processes.
1585         (ServerProcess.stop):
1586         - If self._child_processes is set, call
1587           self._port.check_for_leaks() for each child process.
1588
1589         * Scripts/webkitpy/port/server_process_unittest.py:
1590         (TrivialMockPort.check_for_leaks):
1591         - Rename redundant 'process_pid' argument to 'process_id'.
1592
1593         * Scripts/webkitpy/port/simulator_process.py:
1594         (SimulatorProcess.stop):
1595         - If self._child_processes is set, call
1596           self._port.check_for_leaks() for each child process.
1597
1598         * Scripts/webkitpy/port/watch_device.py:
1599         (WatchDevicePort.check_for_leaks):
1600         - Rename redundant 'process_pid' argument to 'process_id'.
1601
1602         * WebKitTestRunner/TestController.cpp:
1603         (WTR::TestController::dumpResponse):
1604         - Extract method from findAndDumpWorldLeaks() so that it may be
1605           reused by findAndDumpWebKitProcessIdentifiers().
1606         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1607         - Add method to output process name and process ID of both the
1608           WebContent and Networking processes.
1609         (WTR::TestController::findAndDumpWorldLeaks):
1610         - Fix missing newline in output when there were no abandoned
1611           documents.
1612         - Call dumpResponse() for extracted code.
1613         (WTR::TestController::handleControlCommand):
1614         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1615         - Use strncmp() instead of strcmp().
1616         - Call findAndDumpWebKitProcessIdentifiers() when
1617           "#LIST CHILD PROCESSES" command is sent.
1618         * WebKitTestRunner/TestController.h:
1619         (WTR::TestController::dumpResponse):
1620         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1621         - Declare methods.
1622
1623 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1624
1625         Unreviewed. Add GLib API test cases after r243434.
1626
1627         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1628         (testWebViewActiveURI):
1629         (serverCallback):
1630         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1631         (sendRequestCallback):
1632
1633 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1634
1635         Geolocation request not complete when watch request was started in a different web process
1636         https://bugs.webkit.org/show_bug.cgi?id=195996
1637
1638         Reviewed by Alex Christensen.
1639
1640         Add a test case.
1641
1642         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1643         (TestWebKitAPI::runJavaScriptAlert):
1644         (TestWebKitAPI::TEST):
1645
1646 2019-03-26  Keith Rollin  <krollin@apple.com>
1647
1648         Update the way generate-xcfilelists returns strings from functions
1649         https://bugs.webkit.org/show_bug.cgi?id=195975
1650         <rdar://problem/49040807>
1651
1652         Reviewed by Dean Jackson.
1653
1654         There are places where generate-xcfilelists executes assignments with
1655         statements like:
1656
1657             FOO=$(some_function)
1658
1659         where "some_function" return a string by echoing it. E.g.
1660
1661             some_function()
1662             {
1663                 echo "Hello, World"
1664             }
1665
1666         This is a common idiom, but it has a problem if "some_function" needs
1667         to call "exit" in an attempt to halt the entire script right then and
1668         there. Since "some_function" is called inside of $(), it's being
1669         executed in a sub-shell. Calling exit in that sub-shell simply exits
1670         that shell; it doesn't not exit the outer shell in which the main part
1671         of the script is still running. As such, the main script keeps
1672         executing when the intent was for the script to halt.
1673
1674         The solution to this is to use a different idiom for returning
1675         strings. The one we now is to pass in the name of the variable to
1676         receive the string result:
1677
1678             some_function()
1679             {
1680                 variable_name=$1
1681                 eval $variable_name ="Hello, World"
1682             }
1683
1684         The call site now looks like
1685
1686             some_function FOO
1687
1688         Because there's no invocation of a sub-shell, some_function can now
1689         call "exit" if it wants to, and the entire script will exit at that
1690         point.
1691
1692         * Scripts/generate-xcfilelists:
1693
1694 2019-03-26  Chris Dumez  <cdumez@apple.com>
1695
1696         Add basic layout test coverage for File Picker on iOS
1697         https://bugs.webkit.org/show_bug.cgi?id=196265
1698
1699         Reviewed by Wenson Hsieh.
1700
1701         Add layout test infrastructure to test the file picker on iOS.
1702
1703         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1704         (WTR::UIScriptController::dismissFilePicker):
1705         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1706         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1707         (WTR::UIScriptController::dismissFilePicker):
1708         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1709         * WebKitTestRunner/TestController.cpp:
1710         (WTR::TestController::createWebViewWithOptions):
1711         (WTR::updateTestOptionsFromTestHeader):
1712         * WebKitTestRunner/TestOptions.h:
1713         (WTR::TestOptions::hasSameInitializationOptions const):
1714         * WebKitTestRunner/ios/TestControllerIOS.mm:
1715         (overridePresentViewController):
1716         (WTR::TestController::platformInitialize):
1717         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1718         (WTR::UIScriptController::dismissFilePicker):
1719
1720 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1721
1722         Implement async paste method on UIWKInteractionViewProtocol
1723         https://bugs.webkit.org/show_bug.cgi?id=196267
1724         <rdar://problem/49236346>
1725
1726         Reviewed by Tim Horton.
1727
1728         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1729         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1730         are now a part of all iOS 12 internal SDKs.
1731
1732         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1733
1734         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1735         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1736
1737         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1738         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1739         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1740         * TestWebKitAPI/ios/UIKitSPI.h:
1741
1742 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1743
1744         [ews-build] Use PostgreSQL for ews.webkit.org database
1745         https://bugs.webkit.org/show_bug.cgi?id=196270
1746
1747         Reviewed by Lucas Forschler.
1748
1749         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1750
1751 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1752
1753         [ews] Reset simctl states on reboot
1754         https://bugs.webkit.org/show_bug.cgi?id=196260
1755
1756         Rubber-stamped by Aakash Jain.
1757
1758         * EWSTools/start-queue-mac.sh:
1759
1760 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1761
1762         [ews-build] Use PostgreSQL for ews-build database
1763         https://bugs.webkit.org/show_bug.cgi?id=196229
1764
1765         Reviewed by Lucas Forschler.
1766
1767         * BuildSlaveSupport/ews-build/master.cfg:
1768
1769 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1770
1771         [ews-build] Get master_hostname dynamically in master.cfg
1772         https://bugs.webkit.org/show_bug.cgi?id=196255
1773
1774         Reviewed by Lucas Forschler.
1775
1776         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1777         send events data in test mode.
1778
1779 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1780
1781         [ews-app] Set db_constraint to False for Foreign Keys
1782         https://bugs.webkit.org/show_bug.cgi?id=196252
1783
1784         Reviewed by Lucas Forschler.
1785
1786         * BuildSlaveSupport/ews-app/ews/models/build.py:
1787         * BuildSlaveSupport/ews-app/ews/models/step.py:
1788
1789 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1790
1791         [ews-build] is_test_mode_enabled should default to True
1792         https://bugs.webkit.org/show_bug.cgi?id=196248
1793
1794         Reviewed by Lucas Forschler.
1795
1796         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1797
1798 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1799
1800         [ews-app] Add webkitperl to ENABLED_QUEUES
1801         https://bugs.webkit.org/show_bug.cgi?id=196253
1802
1803         Reviewed by Lucas Forschler.
1804
1805         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1806
1807 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1808
1809         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1810         https://bugs.webkit.org/show_bug.cgi?id=196211
1811         rdar://problem/49110552
1812
1813         Reviewed by Tim Horton.
1814
1815         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1816         Make sure that EventSenderProxy always exists when running tests. We used to create
1817         it when resetting before the first test, which is a bit too late.
1818
1819         * WebKitTestRunner/TestController.h:
1820         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1821         (WTR::TestController::platformCreateWebView):
1822         (WTR::TestController::platformCreateOtherPage):
1823         (WTR::TestController::finishCreatingPlatformWebView):
1824         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1825         (WTR::PlatformWebView::PlatformWebView):
1826         Moved some code that made NSWindow use NSEvent during web view creation. We may
1827         need to move more if some other case us found, but this is enough for now.
1828
1829 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1830
1831         Unreviewed. Fix typo in GLib geolocation API after r243285.
1832
1833         gelocation -> geolocation.
1834
1835         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1836         (testGeolocationManagerWatchPosition):
1837
1838 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1839
1840         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1841         https://bugs.webkit.org/show_bug.cgi?id=196213
1842
1843         Reviewed by Geoff Garen.
1844
1845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1846         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1847         (credentialWithIdentityAndKeychainPath):
1848         (-[ChallengeDelegate webView:didFinishNavigation:]):
1849         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1850         (TestWebKitAPI::TEST):
1851
1852 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1853
1854         Expected shouldn't assume its contained types are copyable
1855         https://bugs.webkit.org/show_bug.cgi?id=195986
1856
1857         Reviewed by JF Bastien.
1858
1859         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1860         (TestWebKitAPI::NonCopyable::operator== const):
1861         (TestWebKitAPI::NonCopyable::operator!= const):
1862         (TestWebKitAPI::TEST):
1863
1864 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1865
1866         Remove some now-unnecessary dynamic class lookup
1867         https://bugs.webkit.org/show_bug.cgi?id=196237
1868
1869         Reviewed by Simon Fraser.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1872         (makeRequest):
1873         (TEST):
1874
1875 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1876
1877         Unreviewed, rolling out r243450.
1878
1879         AppleWin and WinCairo port builds get broken.
1880
1881         Reverted changeset:
1882
1883         "Add test for fix of #196095"
1884         https://bugs.webkit.org/show_bug.cgi?id=196097
1885         https://trac.webkit.org/changeset/243450
1886
1887 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1888
1889         Unreviewed, rolling out r243465.
1890         https://bugs.webkit.org/show_bug.cgi?id=196226
1891
1892         the test doesn't build (Requested by thorton on #webkit).
1893
1894         Reverted changeset:
1895
1896         "Do not terminate the NetworkProcess if a third party
1897         application sends a NSCredential with a SecIdentityRef"
1898         https://bugs.webkit.org/show_bug.cgi?id=196213
1899         https://trac.webkit.org/changeset/243465
1900
1901 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1902
1903         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1904         https://bugs.webkit.org/show_bug.cgi?id=196213
1905
1906         Reviewed by Geoff Garen.
1907
1908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1909         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1910         (credentialWithIdentityAndKeychainPath):
1911         (-[ChallengeDelegate webView:didFinishNavigation:]):
1912         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1913         (TestWebKitAPI::TEST):
1914
1915 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1916
1917         [ews-build] Gracefully handle missing patch_id in events
1918         https://bugs.webkit.org/show_bug.cgi?id=196216
1919
1920         Reviewed by Lucas Forschler.
1921
1922         * BuildSlaveSupport/ews-build/events.py:
1923
1924 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1925
1926         [ews-build] use lz4 compression for improving buildbot performance
1927         https://bugs.webkit.org/show_bug.cgi?id=196155
1928
1929         Reviewed by Lucas Forschler.
1930
1931         * BuildSlaveSupport/ews-build/master.cfg:
1932
1933 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1934
1935         Pull some API testing helper methods out of TestWKWebView
1936         https://bugs.webkit.org/show_bug.cgi?id=196212
1937
1938         Reviewed by Tim Horton.
1939
1940         Refactor some more API testing utility methods, so that they can be used in
1941         tests that do not use TestWKWebView.
1942
1943         * TestWebKitAPI/cocoa/TestWKWebView.h:
1944         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1945         (-[WKWebView loadTestPageNamed:]):
1946         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1947         (-[WKWebView synchronouslyLoadHTMLString:]):
1948         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1949         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1950         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1951         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1952         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1953
1954 2019-03-25  Jer Noble  <jer.noble@apple.com>
1955
1956         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1957         https://bugs.webkit.org/show_bug.cgi?id=196097
1958
1959         Reviewed by Eric Carlson.
1960
1961         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1962
1963         * DumpRenderTree/mac/DumpRenderTree.mm:
1964         (resetWebPreferencesToConsistentValues):
1965         * WebKitTestRunner/TestController.cpp:
1966         (WTR::TestController::resetPreferencesToConsistentValues):
1967
1968 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1969
1970         Pull IPadUserInterfaceSwizzler out into a separate header file
1971         https://bugs.webkit.org/show_bug.cgi?id=196193
1972
1973         Reviewed by Anders Carlsson.
1974
1975         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1976         be used in other API tests.
1977
1978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1979         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1980         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1981         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1982         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1983         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1984         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1985
1986 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1987
1988         Remove NavigatorContentUtils in WebCore/Modules
1989         https://bugs.webkit.org/show_bug.cgi?id=196070
1990
1991         Reviewed by Alex Christensen.
1992
1993         NavigatorContentUtils was to support the custom scheme spec [1].
1994         However, in WebKit side, no port has supported the feature in
1995         WebKit layer after EFL port was removed. So there has been the
1996         only IDL implementation of the NavigatorContentUtils in WebCore.
1997         So we don't need to keep the implementation in WebCore anymore.
1998
1999         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2000
2001         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2002
2003 2019-03-24  Andy Estes  <aestes@apple.com>
2004
2005         [watchOS] Remove unused Proximity Networking code
2006         https://bugs.webkit.org/show_bug.cgi?id=196188
2007
2008         Reviewed by Tim Horton.
2009
2010         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2011         (TEST):
2012
2013 2019-03-23  Keith Miller  <keith_miller@apple.com>
2014
2015         Refactor clz/ctz and fix getLSBSet.
2016         https://bugs.webkit.org/show_bug.cgi?id=196162
2017
2018         Reviewed by Saam Barati.
2019
2020         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2021
2022         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2023         (TestWebKitAPI::TEST):
2024
2025 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2026
2027         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2028         https://bugs.webkit.org/show_bug.cgi?id=196143
2029
2030         Reviewed by Michael Catanzaro.
2031
2032         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2033         directories.
2034
2035         * Scripts/webkitpy/style/checkers/cpp.py:
2036         (check_identifier_name_in_declaration):
2037         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2038         (WebKitStyleTest.test_names):
2039
2040 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2041
2042         [Flatpak] Manifest expanding fails for qt WPE extension
2043         https://bugs.webkit.org/show_bug.cgi?id=196148
2044
2045         Reviewed by Alex Christensen.
2046
2047         * flatpak/flatpakutils.py:
2048         (expand_submodules_recurse): The last recurse manifest expand
2049         iteration might lead to a single module so take it into account
2050         and don't try to recurse further.
2051
2052 2019-03-22  Chris Dumez  <cdumez@apple.com>
2053
2054         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2055         https://bugs.webkit.org/show_bug.cgi?id=195348
2056         <rdar://problem/48622090>
2057
2058         Reviewed by Alex Christensen.
2059
2060         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2061         to NO when test.options().shouldIgnoreMetaViewport is false.
2062
2063         * WebKitTestRunner/ios/TestControllerIOS.mm:
2064         (WTR::TestController::platformConfigureViewForTest):
2065
2066 2019-03-22  Chris Dumez  <cdumez@apple.com>
2067
2068         Prewarmed processes should be usable with any website data store
2069         https://bugs.webkit.org/show_bug.cgi?id=196104
2070
2071         Reviewed by Alex Christensen.
2072
2073         Add API test coverage.
2074
2075         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2076         (runInitialWarmedProcessUsedTest):
2077         (TEST):
2078
2079 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2080
2081         Back out local changes to Alex's Subversion working directory
2082
2083         They were accidentally committed.
2084
2085         * Scripts/webkitpy/common/system/abstractexecutive.py:
2086         (AbstractExecutive.wait_newest):
2087         * Scripts/webkitpy/common/system/executive.py:
2088         (Executive.running_pids):
2089         * Scripts/webkitpy/common/system/executive_mock.py:
2090         (MockExecutive.running_pids):
2091         * Scripts/webkitpy/common/system/executive_unittest.py:
2092         (ExecutiveTest.serial_test_running_pids):
2093         * Scripts/webkitpy/port/darwin.py:
2094         (DarwinPort.check_for_leaks):
2095         * Scripts/webkitpy/port/leakdetector.py:
2096         (LeakDetector.check_for_leaks):
2097         - This was the hack attached to Bug 193772.
2098
2099         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2100         (+[WebKitTestRunnerEvent mouseLocation]):
2101         - This works around a crash on an internal build.
2102
2103 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2104
2105         Fix the build after r243354
2106         https://bugs.webkit.org/show_bug.cgi?id=196138
2107         <rdar://problem/49145951>
2108
2109         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2110         (TEST):
2111         * TestWebKitAPI/ios/UIKitSPI.h:
2112
2113 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2114
2115         Adopt UIWKDocumentContext
2116         https://bugs.webkit.org/show_bug.cgi?id=196040
2117         <rdar://problem/48642440>
2118
2119         Reviewed by Ryosuke Niwa.
2120
2121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2122         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2123         (makeRequest):
2124         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2125         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2126         (applyStyle):
2127         (TEST):
2128         Add tests for UIWKDocumentContext.
2129
2130         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2131         (TEST):
2132         (recursiveFindWKContentView): Deleted.
2133         * TestWebKitAPI/cocoa/TestWKWebView.h:
2134         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2135         (recursiveFindWKContentView):
2136         (-[TestWKWebView wkContentView]):
2137         * TestWebKitAPI/ios/UIKitSPI.h:
2138         Share the WKContentView finding code between tests.
2139
2140 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2141
2142         [iOS WK2] Turn on async overflow scrolling by default
2143         https://bugs.webkit.org/show_bug.cgi?id=196011
2144         rdar://problem/48453859
2145
2146         Reviewed by Antti Koivisto.
2147         
2148         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2149         since so many basic layout tests have different results when compositing is triggered for
2150         overflow.
2151         
2152         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2153
2154         * WebKitTestRunner/TestController.cpp:
2155         (WTR::TestController::resetPreferencesToConsistentValues):
2156
2157 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2158
2159         [ews-build] Retry API test in case of failures
2160         https://bugs.webkit.org/show_bug.cgi?id=196004
2161
2162         Reviewed by Lucas Forschler.
2163
2164         * BuildSlaveSupport/ews-build/steps.py:
2165         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2166         (CompileWebKitToT.doStepIf): Ditto.
2167         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2168         (ReRunAPITests): Re-run API tests.
2169         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2170         (RunAPITestsWithoutPatch): Run API tests without patch.
2171         (RunAPITestsWithoutPatch.doStepIf):
2172         (RunAPITestsWithoutPatch.hideStepIf):
2173         (RunAPITestsWithoutPatch.evaluateCommand):
2174         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2175         (AnalyzeAPITestsResults.start):
2176         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2177         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2178         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2179         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2180
2181 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2182
2183         [ews-build] Update queues configurations
2184         https://bugs.webkit.org/show_bug.cgi?id=196074
2185
2186         Reviewed by Dewei Zhu.
2187
2188         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2189         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2190
2191 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2192
2193         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2194         https://bugs.webkit.org/show_bug.cgi?id=195680
2195         <rdar://problem/48903534>
2196
2197         Unreviewed infrastructure fix.
2198
2199         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2200         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2201
2202 2019-03-21  Andy Estes  <aestes@apple.com>
2203
2204         [iOS] Apple Pay should be available in documents with no user agent scripts
2205         https://bugs.webkit.org/show_bug.cgi?id=196061
2206         <rdar://problem/48649391>
2207
2208         Reviewed by Brady Eidson.
2209
2210         Added API tests and related infrastructure.
2211
2212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2213         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2214         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2215         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2216         (TestWebKitAPI::TEST):
2217         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2218         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2219         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2220         * TestWebKitAPI/cocoa/TestProtocol.mm:
2221         (-[TestProtocol startLoading]):
2222         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2223         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2224         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2225         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2226
2227 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2228
2229         REGRESSSION (r243297): webkitpy tests broken
2230         https://bugs.webkit.org/show_bug.cgi?id=196108
2231
2232         Reviewed by Aakash Jain.
2233
2234         r243297 updated contributors.json, which broke a few unit tests.
2235
2236         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2237         (IRCCommandTest.test_whois):
2238         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2239
2240 2019-03-21  Chris Dumez  <cdumez@apple.com>
2241
2242         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2243         https://bugs.webkit.org/show_bug.cgi?id=196041
2244         <rdar://problem/49083230>
2245
2246         Reviewed by Alex Christensen.
2247
2248         Add API test coverage.
2249
2250         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2251         (TEST):
2252
2253 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2254
2255         Add SPI to inform applications of WKContentRuleList actions
2256         https://bugs.webkit.org/show_bug.cgi?id=195965
2257         <rdar://problem/42664365>
2258
2259         Reviewed by Geoff Garen.
2260
2261         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2262         (TestWebKitAPI::allActionsForResourceLoad):
2263         (TestWebKitAPI::testRequest):
2264         (TestWebKitAPI::TEST_F):
2265         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2266         (Notification::description):
2267         (Notification::operator== const):
2268         (toVector):
2269         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2270         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2271         (makeContentRuleList):
2272         (TEST):
2273         (makeWarnContentRuleList): Deleted.
2274
2275 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2276
2277         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2278         https://bugs.webkit.org/show_bug.cgi?id=196088
2279
2280         Reviewed by Brian Burg.
2281
2282         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2283         Support checks when only one platform is specified. Also deprecate macosx() and
2284         force the use of macos() instead.
2285
2286         * Scripts/webkitpy/style/checkers/cpp.py:
2287         (check_min_versions_of_wk_api_available):
2288         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2289         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2290
2291 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2292
2293         Update status inactive committers' status to 'contributor'.
2294
2295         * Scripts/webkitpy/common/config/contributors.json:
2296
2297 2019-03-21  Xan Lopez  <xan@igalia.com>
2298
2299         [JSC][x86] Drop support for x87 floating point
2300         https://bugs.webkit.org/show_bug.cgi?id=194853
2301
2302         Reviewed by Don Olmstead.
2303
2304         Force SSE2 on x86/32bit builds.
2305
2306         * Scripts/webkitdirs.pm:
2307         (generateBuildSystemFromCMakeProject):
2308
2309 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2310
2311         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2312         https://bugs.webkit.org/show_bug.cgi?id=196073
2313
2314         Reviewed by Michael Catanzaro.
2315
2316         Add test cases to check functions and constructors with no arguments but receiving user data.
2317
2318         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2319         (checkUserData):
2320         (testJSCFunction):
2321         (fooCreateWithUserData):
2322         (testJSCClass):
2323
2324 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2325
2326         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2327
2328         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2329
2330         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2331
2332 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2333
2334         [GTK][WPE] Add API to provide geolocation information
2335         https://bugs.webkit.org/show_bug.cgi?id=195940
2336
2337         Reviewed by Michael Catanzaro.
2338
2339         Add a new test to check the new API.
2340
2341         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2342         (testGeolocationManagerCurrentPosition):
2343         (testGeolocationManagerWatchPosition):
2344         (beforeAll):
2345         (afterAll):
2346         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2347         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2348         (beforeAll): Ditto.
2349         * TestWebKitAPI/glib/CMakeLists.txt:
2350
2351 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2352
2353         [GLib] Returning G_TYPE_OBJECT from a method does not work
2354         https://bugs.webkit.org/show_bug.cgi?id=195574
2355
2356         Reviewed by Michael Catanzaro.
2357
2358         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2359
2360         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2361         (getGFile):
2362         (getParent):
2363         (createGString):
2364         (getGString):
2365         (getGStringCopyWillRaise):
2366         (getGStringCopy):
2367         (getGStringStr):
2368         (getGStringLen):
2369         (freeGString):
2370         (testJSCClass):
2371
2372 2019-03-20  Saam Barati  <sbarati@apple.com>
2373
2374         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2375         https://bugs.webkit.org/show_bug.cgi?id=195721
2376
2377         Reviewed by Filip Pizlo.
2378
2379         * Scripts/run-javascriptcore-tests:
2380
2381 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2382
2383         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2384         https://bugs.webkit.org/show_bug.cgi?id=196049
2385
2386         Reviewed by Tim Horton.
2387
2388         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2389         overflow scrolling in general, so rename it.
2390
2391         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2392
2393 2019-03-20  Daniel Bates  <dabates@apple.com>
2394
2395         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2396         https://bugs.webkit.org/show_bug.cgi?id=196031
2397         <rdar://problem/49078172>
2398
2399         Reviewed by Tim Horton.
2400
2401         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2402         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2403         same code path used when the Done button is pressed to dismiss the <select> picker.
2404
2405         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2406         (TestWebKitAPI::TEST):
2407
2408 2019-03-20  Chris Dumez  <cdumez@apple.com>
2409
2410         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2411         https://bugs.webkit.org/show_bug.cgi?id=196029
2412         <rdar://problem/48954651>
2413
2414         Reviewed by Tim Horton.
2415
2416         Add API test coverage.
2417
2418         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2419
2420 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2421
2422         [ews-build] Improve failure summary string for ApplyPatch step
2423         https://bugs.webkit.org/show_bug.cgi?id=195995
2424
2425         Reviewed by Alexey Proskuryakov.
2426
2427         * BuildSlaveSupport/ews-build/steps.py:
2428         (ApplyPatch.getResultSummary): Override getResultSummary.
2429
2430 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2431
2432         AX: Implement support for new meter ARIA role
2433         https://bugs.webkit.org/show_bug.cgi?id=195966
2434
2435         Reviewed by Chris Fleizach.
2436
2437         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2438         to AXLevelIndicator.
2439
2440         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2441
2442 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2443
2444         [WebAuthN] Implement FIDO AppID extension
2445         https://bugs.webkit.org/show_bug.cgi?id=143491
2446         <rdar://problem/48298273>
2447
2448         Reviewed by Brent Fulgham.
2449
2450         Add a test that covers the new flag of convertToU2fSignCommand.
2451
2452         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2453         (TestWebKitAPI::TEST):
2454         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2455         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2456         (TestWebKitAPI::TEST):
2457
2458 2019-03-19  Keith Rollin  <krollin@apple.com>
2459
2460         Add support for more platforms to generate-xcfilelists
2461         https://bugs.webkit.org/show_bug.cgi?id=195977
2462
2463         Reviewed by Alexey Proskuryakov.
2464
2465         generate-xcfilelists incorrectly complains when involved with building
2466         WebKit for iphonesimulator:
2467
2468             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2469             …
2470             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2471
2472         Address this by teaching generate-xcfilelists about more platforms.
2473
2474         * Scripts/generate-xcfilelists:
2475
2476 2019-03-19  John Wilander  <wilander@apple.com>
2477
2478         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2479         https://bugs.webkit.org/show_bug.cgi?id=195923
2480         <rdar://problem/49001272>
2481
2482         Reviewed by Alex Christensen.
2483
2484         This patch does the following to the TestRunner:
2485         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2486         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2487         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2488
2489         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2490         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2491         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2492         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2493         * WebKitTestRunner/TestController.cpp:
2494         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2495         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2496         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2497         * WebKitTestRunner/TestController.h:
2498         * WebKitTestRunner/TestInvocation.cpp:
2499         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2500
2501 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2502
2503         [CMake] Support more clang and gcc sanitizers
2504         https://bugs.webkit.org/show_bug.cgi?id=195956
2505
2506         Reviewed by Michael Catanzaro.
2507
2508         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2509
2510 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2511
2512         [ews-build] Improve summary for PrintConfiguration step
2513         https://bugs.webkit.org/show_bug.cgi?id=195945
2514
2515         Reviewed by Lucas Forschler.
2516
2517         * BuildSlaveSupport/ews-build/steps.py:
2518         (PrintConfiguration.getResultSummary): Override getResultSummary.
2519
2520 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2521
2522         [ews-build] Improve summary for CheckOutSource step
2523         https://bugs.webkit.org/show_bug.cgi?id=195963
2524
2525         Reviewed by Lucas Forschler.
2526
2527         * BuildSlaveSupport/ews-build/steps.py:
2528         (CheckOutSource.getResultSummary):
2529
2530 2019-03-19  Daniel Bates  <dabates@apple.com>
2531
2532         [iOS] Focus not preserved when switching between tabs
2533         https://bugs.webkit.org/show_bug.cgi?id=195820
2534         <rdar://problem/43614450>
2535
2536         Reviewed by Brent Fulgham.
2537
2538         Add tests to ensure that we restore focus when resigning and becoming first responder.
2539
2540         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2541         (TestWebKitAPI::TEST):
2542
2543 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2544
2545         Make WTFLogChannelState and WTFLogLevel enum classes
2546         https://bugs.webkit.org/show_bug.cgi?id=195904
2547
2548         Reviewed by Eric Carlson.
2549
2550         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2551         (TestWebKitAPI::TEST_F):
2552
2553 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2554
2555         [GStreamer][EME] Backported mssdemux protection data crash fix
2556         https://bugs.webkit.org/show_bug.cgi?id=195918
2557
2558         Reviewed by Philippe Normand.
2559
2560         * gstreamer/jhbuild.modules:
2561         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2562
2563 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2564
2565         Unreviewed, rolling out r243132.
2566
2567         Broke GTK build
2568
2569         Reverted changeset:
2570
2571         "Make WTFLogChannelState and WTFLogLevel enum classes"
2572         https://bugs.webkit.org/show_bug.cgi?id=195904
2573         https://trac.webkit.org/changeset/243132
2574
2575 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2576
2577         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2578
2579         * Scripts/webkitdirs.pm:
2580         (builtDylibPathForName): Adjust the shared library name that's changed
2581         with the API version bump in r243073.
2582
2583 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2584
2585         Make WTFLogChannelState and WTFLogLevel enum classes
2586         https://bugs.webkit.org/show_bug.cgi?id=195904
2587
2588         Reviewed by Eric Carlson.
2589
2590         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2591         (TestWebKitAPI::TEST_F):
2592
2593 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2594
2595         Disable flaky test added in r2431100
2596         https://webkit.org/b/195785
2597
2598         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2599         (TestWebKitAPI::TEST):
2600         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2601
2602 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2603
2604         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2605         https://bugs.webkit.org/show_bug.cgi?id=195916
2606
2607         Reviewed by Tim Horton.
2608
2609         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2610         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2611
2612 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2613
2614         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2615
2616         * Scripts/webkitpy/common/config/contributors.json:
2617
2618 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2619
2620         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2621         https://bugs.webkit.org/show_bug.cgi?id=195785
2622
2623         Reviewed by Geoffrey Garen.
2624
2625         * TestWebKitAPI/TCPServer.cpp: Added.
2626         (TestWebKitAPI::TCPServer::TCPServer):
2627         (TestWebKitAPI::TCPServer::~TCPServer):
2628         (TestWebKitAPI::TCPServer::socketBindListen):
2629         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2630         * TestWebKitAPI/TCPServer.h: Added.
2631         (TestWebKitAPI::TCPServer::port const):
2632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2633         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2634         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2635         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2636         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2637         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2638         (TestWebKitAPI::respondSlowly):
2639         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2640         (TestWebKitAPI::downloadAtRate):
2641         (TestWebKitAPI::TEST):
2642
2643 2019-03-18  Saam Barati  <sbarati@apple.com>
2644
2645         Add a plan file for JetStream 2
2646         https://bugs.webkit.org/show_bug.cgi?id=190734
2647
2648         Reviewed by Mark Lam.
2649
2650         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2651
2652 2019-03-18  Chris Dumez  <cdumez@apple.com>
2653
2654         Delay WebProcess launch until a load is triggered in a Web view
2655         https://bugs.webkit.org/show_bug.cgi?id=195758
2656         <rdar://problem/48126013>
2657
2658         Reviewed by Geoff Garen.
2659
2660         Add API test coverage. Also update some existing API tests to not expect
2661         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2662
2663         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2664         (TestWebKitAPI::TEST):
2665         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2666         (TestWebKitAPI::TEST):
2667         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2668         (TEST):
2669         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2670         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2671         (TEST):
2672         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2673         (TEST):
2674         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2675
2676 2019-03-18  Xan Lopez  <xan@igalia.com>
2677
2678         [CMake] Prevent potential warning when determining $architecture
2679         https://bugs.webkit.org/show_bug.cgi?id=195891
2680
2681         Reviewed by Michael Catanzaro.
2682
2683         It's possible for generateBuildSystemForCMakeProject to be called
2684         before determineArchitecture() is ever called. This will make the
2685         first eq check with $architecture to be bogus (and print a
2686         warning). Change that to an eq check with architecture(), which
2687         implicitly calls determineArchitecture() if needed, and change all
2688         the other similar cases in the method in the same way to prevent
2689         future bugs like this one.
2690
2691         * Scripts/webkitdirs.pm:
2692         (generateBuildSystemFromCMakeProject):
2693
2694 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2695
2696         [WPE] Tarballs generated with “make dist” cannot build documentation
2697         https://bugs.webkit.org/show_bug.cgi?id=195885
2698
2699         Reviewed by Carlos Garcia Campos.
2700
2701         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2702
2703 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2704
2705         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2706         https://bugs.webkit.org/show_bug.cgi?id=195883
2707
2708         Reviewed by Carlos Garcia Campos.
2709
2710         * gtkdoc/gtkdoc.py:
2711         (GTKDoc._run_command): When commands fail to run, include the full command line for
2712         the program invocation and the output it has generated on the standard error stream.
2713
2714 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2715
2716         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2717         https://bugs.webkit.org/show_bug.cgi?id=195786
2718
2719         Reviewed by Philippe Normand.
2720
2721         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2722         * wpe/jhbuild.modules: Ditto.
2723
2724 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2725
2726         [ews-build] Don't run clean builds on EWS builders
2727         https://bugs.webkit.org/show_bug.cgi?id=195851
2728
2729         Reviewed by Geoffrey Garen.
2730
2731         * BuildSlaveSupport/ews-build/factories.py:
2732
2733 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2734
2735         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2736         https://bugs.webkit.org/show_bug.cgi?id=195849
2737
2738         Reviewed by Chris Dumez.
2739
2740         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2741
2742         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2743         (runWebsiteDataStoreCustomPaths):
2744
2745 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2746
2747         webkitpy: Upload test results
2748         https://bugs.webkit.org/show_bug.cgi?id=195755
2749         <rdar://problem/48896182>
2750
2751         Reviewed by Aakash Jain.
2752
2753         Establish a new format for uploading results that is not tied to layout tests, apply
2754         that format to webkitpy tests.
2755
2756         * Scripts/webkitpy/common/checkout/scm/git.py:
2757         (Git.native_branch): Return what branch the current checkout is on.
2758         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2759         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2760         * Scripts/webkitpy/common/checkout/scm/svn.py:
2761         (SVN.native_branch): Ditto.
2762         * Scripts/webkitpy/common/system/platforminfo.py:
2763         (PlatformInfo.build_version): Return a build version for Mac.
2764         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2765         (MockPlatformInfo.__init__):
2766         (MockPlatformInfo.build_version):
2767         * Scripts/webkitpy/results: Added.
2768         * Scripts/webkitpy/results/__init__.py: Added.
2769         * Scripts/webkitpy/results/options.py: Added.
2770         (upload_options): OptParse list for upload options.
2771         * Scripts/webkitpy/results/upload.py: Added.
2772         (Upload): Class which enforces the upload format expected by the results server.
2773         (Upload.Expectations):
2774         (Upload.create_configuration):
2775         (Upload.create_commit):
2776         (Upload.create_details):
2777         (Upload.create_run_stats):
2778         (Upload.create_test_result):
2779         (Upload.__init__):
2780         (Upload.Encoder): Encode Upload object as json.
2781         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2782         * Scripts/webkitpy/results/upload_unittest.py: Added.
2783         * Scripts/webkitpy/test/main.py:
2784         (Tester._parse_args): Add upload arguments.
2785         (Tester._run_tests): Allow results to be uploaded.
2786         * Scripts/webkitpy/test/runner.py:
2787         (Runner.__init__): Record which tests were run, rather than just counting them.
2788         (Runner.handle):
2789         * Scripts/webkitpy/test/runner_unittest.py:
2790         (RunnerTest.test_run):
2791         * Scripts/webkitpy/thirdparty/__init__.py:
2792         (AutoinstallImportHook.find_module): Add requests auto-install.
2793         (AutoinstallImportHook._install_requests):
2794         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2795         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2796
2797 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2798
2799         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2800         https://bugs.webkit.org/show_bug.cgi?id=195810
2801
2802         Reviewed by Tim Horton.
2803
2804         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2805         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2806         ending certain layout tests.
2807
2808         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2809         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2810         (-[TestRunnerWKWebView dealloc]):
2811         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2812
2813         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2814         helper method when destroying the web view, and when resetting state between tests.
2815
2816         * WebKitTestRunner/ios/TestControllerIOS.mm:
2817         (WTR::TestController::platformResetStateToConsistentValues):
2818
2819         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2820
2821 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2822
2823         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2824         https://bugs.webkit.org/show_bug.cgi?id=190350
2825         <rdar://problem/45089503>
2826
2827         Reviewed by Geoffrey Garen.
2828
2829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2830         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2831         (TEST):
2832         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2833         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2834         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2835         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2836         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2837         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2838         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2839         (runTest):
2840         (createDirectories):
2841         (TEST):
2842         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2843         (TEST):
2844         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2845         (TEST):
2846
2847 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2848
2849         Add support to WebPage for getting the contents as an attributed string.
2850         https://bugs.webkit.org/show_bug.cgi?id=195636
2851         rdar://problem/45055697
2852
2853         Reviewed by Tim Horton.
2854
2855         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2856         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2857
2858 2019-03-15  Chris Dumez  <cdumez@apple.com>
2859
2860         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2861         https://bugs.webkit.org/show_bug.cgi?id=195747
2862
2863         Reviewed by Geoff Garen.
2864
2865         Add API test coverage.
2866
2867         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2868
2869 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2870
2871         Unreviewed, rolling out r242952.
2872
2873         Causing API failures on iOS Simulator
2874
2875         Reverted changeset:
2876
2877         "[PSON] Make sure the WebProcessCache is leverage when
2878         relaunching a process after termination"
2879         https://bugs.webkit.org/show_bug.cgi?id=195747
2880         https://trac.webkit.org/changeset/242952
2881
2882 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2883
2884         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2885         https://bugs.webkit.org/show_bug.cgi?id=195740
2886
2887         Reviewed by Ross Kirsling.
2888
2889         window.open doesn't work for WebKitBrowserWindow because it is not
2890         implemented yet.
2891
2892         1. Implemented createNewPage callback of WKPageUIClient.
2893         2. Changed MainWindow to take a BrowserWindow factory function
2894           instead of BrowserWindowType to be flexible to create
2895           BrowserWindow with extra settings.
2896         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2897           because it is not relevant with MainWindow anymore.
2898
2899         * MiniBrowser/win/Common.cpp:
2900         (parseCommandLine):
2901         * MiniBrowser/win/Common.h:
2902         (CommandLineOptions::CommandLineOptions):
2903         * MiniBrowser/win/MainWindow.cpp:
2904         (MainWindow::MainWindow):
2905         (MainWindow::create):
2906         (MainWindow::init):
2907         (MainWindow::WndProc):
2908         * MiniBrowser/win/MainWindow.h:
2909         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2910         (PrintWebUIDelegate::createWebViewWithRequest):
2911         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2912         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2913         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2914         (WebKitBrowserWindow::updateProxySettings):
2915         (WebKitBrowserWindow::createNewPage):
2916         * MiniBrowser/win/WebKitBrowserWindow.h:
2917         * MiniBrowser/win/WinMain.cpp:
2918         (wWinMain):
2919
2920 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2921
2922         Make it possible to test scrolling tree layer manipulation more easily
2923         https://bugs.webkit.org/show_bug.cgi?id=195780
2924
2925         Reviewed by Tim Horton.
2926         
2927         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2928         cuts off communication of scrolling tree scrolls back to the web process
2929         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2930         allows tests to trigger scrolls which run the scrolling tree layer positioning
2931         logic, but never get another commit from the web process that might mask
2932         scrolling tree bugs.
2933         
2934         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2935         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2936         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2937
2938         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2939         (WTR::UIScriptController::scrollUpdatesDisabled const):
2940         (WTR::UIScriptController::setScrollUpdatesDisabled):
2941         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2942         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2943         (WTR::UIScriptController::scrollUpdatesDisabled const):
2944         (WTR::UIScriptController::setScrollUpdatesDisabled):
2945         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2946         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2947         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2948         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2949         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2950         * WebKitTestRunner/ios/TestControllerIOS.mm:
2951         (WTR::TestController::platformResetStateToConsistentValues):
2952         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2953         (WTR::UIScriptController::scrollUpdatesDisabled const):
2954         (WTR::UIScriptController::setScrollUpdatesDisabled):
2955
2956 2019-03-14  Youenn Fablet  <youenn@apple.com>
2957
2958         Move IDB storage in private browsing mode to NetworkProcess
2959         https://bugs.webkit.org/show_bug.cgi?id=195602
2960
2961         Reviewed by Brady Eidson.
2962
2963         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2964         (TEST):
2965
2966 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2967
2968         [ews-build] Make descriptionDone messages more readable
2969         https://bugs.webkit.org/show_bug.cgi?id=195760
2970
2971         Reviewed by Lucas Forschler.
2972
2973         * BuildSlaveSupport/ews-build/steps.py:
2974         * BuildSlaveSupport/ews-build/steps_unittest.py:
2975
2976 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2977
2978         [ews-build] Generate status-bubble hover-over messages
2979         https://bugs.webkit.org/show_bug.cgi?id=195680
2980
2981         Reviewed by Lucas Forschler.
2982
2983         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2984         (StatusBubble):
2985         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2986         on hover-over.
2987         (StatusBubble._iso_time):
2988         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2989         hover-over message.
2990         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2991
2992 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2993
2994         [ews-app] Gracefully handle the case when state_string is None
2995         https://bugs.webkit.org/show_bug.cgi?id=195753
2996
2997         Reviewed by Lucas Forschler.
2998
2999         * BuildSlaveSupport/ews-app/ews/models/build.py:
3000         * BuildSlaveSupport/ews-app/ews/models/step.py:
3001
3002 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3003
3004         [ews-app] Status bubble display pending for currently running build step
3005         https://bugs.webkit.org/show_bug.cgi?id=195744
3006
3007         Reviewed by Lucas Forschler.
3008
3009         * BuildSlaveSupport/ews-build/events.py:
3010         (Events.stepStarted): If state_string is pending, replace it with step name.
3011
3012 2019-03-14  Chris Dumez  <cdumez@apple.com>
3013
3014         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3015         https://bugs.webkit.org/show_bug.cgi?id=195750
3016
3017         Reviewed by Geoffrey Garen.
3018
3019         Add API test coverage.
3020
3021         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3022         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3023         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3024         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3025
3026 2019-03-14  Chris Dumez  <cdumez@apple.com>
3027
3028         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3029         https://bugs.webkit.org/show_bug.cgi?id=195747
3030
3031         Reviewed by Geoff Garen.
3032
3033         Add API test coverage.
3034
3035         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3036
3037 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3038
3039         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3040         https://bugs.webkit.org/show_bug.cgi?id=195725
3041         <rdar://problem/48545062>
3042
3043         Reviewed by Tim Horton.
3044
3045         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3046         handler is nil.
3047
3048         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3049         (TestWebKitAPI::TEST):
3050
3051 2019-03-13  Sam Weinig  <sam@webkit.org>
3052
3053         Add utility function to allow easy reverse range-based iteration of a container
3054         https://bugs.webkit.org/show_bug.cgi?id=195542
3055
3056         Reviewed by Antti Koivisto.
3057
3058         * TestWebKitAPI/CMakeLists.txt:
3059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3060         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3061         (TestWebKitAPI::TEST):
3062         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3063
3064 2019-03-13  Chris Dumez  <cdumez@apple.com>
3065
3066         Use a ServiceWorker process per registrable domain
3067         https://bugs.webkit.org/show_bug.cgi?id=195649
3068
3069         Reviewed by Youenn Fablet.
3070
3071         Update API test coverage.
3072
3073         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3074
3075 2019-03-13  Chris Dumez  <cdumez@apple.com>
3076
3077         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3078         https://bugs.webkit.org/show_bug.cgi?id=195684
3079         <rdar://problem/48294714>
3080
3081         Reviewed by Antti Koivisto.
3082
3083         Add API test coverage.
3084
3085         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3086
3087 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3088
3089         [ews-app] Remove unused patch view
3090         https://bugs.webkit.org/show_bug.cgi?id=195669
3091
3092         Reviewed by Lucas Forschler.
3093
3094         * BuildSlaveSupport/ews-app/ews/urls.py:
3095         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3096
3097 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3098
3099         [ews-app] Use Buildbot result code variables
3100         https://bugs.webkit.org/show_bug.cgi?id=195668
3101
3102         Reviewed by Alexey Proskuryakov.
3103
3104         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3105         (Buildbot): Added Buildbot result code variables.
3106         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3107         (StatusBubble._build_bubble): Used Buildbot result code variables.
3108
3109 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3110
3111         [Flatpak] Expand submodule recursively
3112         https://bugs.webkit.org/show_bug.cgi?id=195672
3113
3114         Building WPE with flatpak was impossible without that as it was raising an exception.
3115         Also update wpebackend-fdo to match what is built in jhbuild
3116
3117         Reviewed by Philippe Normand.
3118
3119         * flatpak/flatpakutils.py:
3120         (expand_submodules_recurse):
3121         (expand_manifest):
3122         * flatpak/org.webkit.WPEModules.yaml:
3123
3124 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3125
3126         [ews-app] status bubble should be hidden for certain builds
3127         https://bugs.webkit.org/show_bug.cgi?id=194597
3128
3129         Reviewed by Dewei Zhu.
3130
3131         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3132         (StatusBubble._build_bubble):
3133         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3134         because the patch didn't have relevant changes.
3135         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3136         in production yet.
3137
3138 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3139
3140         [Win] Fix a slew of simple clang-cl warnings.
3141         https://bugs.webkit.org/show_bug.cgi?id=195652
3142
3143         Reviewed by Don Olmstead.
3144
3145         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3146         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3147
3148 2019-03-12  Justin Fan  <justin_fan@apple.com>
3149
3150         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3151         https://bugs.webkit.org/show_bug.cgi?id=195518
3152         <rdar://problem/46322356>
3153
3154         Reviewed by Myles C. Maxfield.
3155
3156         * DumpRenderTree/DerivedSources-input.xcfilelist:
3157         * DumpRenderTree/DerivedSources-output.xcfilelist:
3158
3159 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3160
3161         Unreviewed, rolling out r242825.
3162         https://bugs.webkit.org/show_bug.cgi?id=195648
3163
3164         "Broke webkitpy tests with my change to
3165         lldb_dump_class_layout.py" (Requested by rmorisset on
3166         #webkit).
3167
3168         Reverted changeset:
3169
3170         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3171         classes with suspicious padding"
3172         https://bugs.webkit.org/show_bug.cgi?id=195573
3173         https://trac.webkit.org/changeset/242825
3174
3175 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3176
3177         [ews-build] Show status bubbles while the patch is waiting in queue
3178         https://bugs.webkit.org/show_bug.cgi?id=195618
3179
3180         Reviewed by Lucas Forschler.
3181
3182         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3183         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3184         enabled in initial deployment.
3185         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3186         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3187         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3188         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3189         (StatusBubble._build_bubbles_for_patch):
3190
3191 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3192
3193         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3194         https://bugs.webkit.org/show_bug.cgi?id=195573
3195
3196         Reviewed by Simon Fraser.
3197
3198         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3199
3200         * Scripts/dump-class-layout:
3201         (main):
3202         * lldb/lldb_dump_class_layout.py:
3203         (ClassLayout.__init__):
3204         (ClassLayout._compute_padding_recursive):
3205         (LLDBDebuggerInstance.dump_layout_for_classname):
3206         (LLDBDebuggerInstance):
3207         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3208         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3209
3210 2019-03-12  Chris Dumez  <cdumez@apple.com>
3211
3212         Device Orientation access permission should be denied unless explicitly granted by the client
3213         https://bugs.webkit.org/show_bug.cgi?id=195625
3214
3215         Reviewed by Youenn Fablet.
3216
3217         add API test coverage.
3218
3219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3220         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3221         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3222         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3223         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3224         (runDeviceOrientationTest):
3225         (TEST):
3226         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3227         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3228
3229 2019-03-12  Jer Noble  <jer.noble@apple.com>
3230
3231         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3232         https://bugs.webkit.org/show_bug.cgi?id=195137
3233         <rdar://problem/48810307>
3234
3235         Reviewed by Eric Carlson.
3236
3237         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3238         (TestWebKitAPI::TEST):
3239
3240 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3241
3242         [ews-build] Change urls from uat to production
3243         https://bugs.webkit.org/show_bug.cgi?id=195566
3244
3245         Reviewed by Lucas Forschler.
3246
3247         * BuildSlaveSupport/ews-app/ews/config.py:
3248         * BuildSlaveSupport/ews-build/events.py:
3249         * BuildSlaveSupport/ews-build/steps.py:
3250
3251 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3252
3253         [ews-build] change max_builds for local-worker to 1
3254         https://bugs.webkit.org/show_bug.cgi?id=195568
3255
3256         Reviewed by Lucas Forschler.
3257
3258         * BuildSlaveSupport/ews-build/loadConfig.py:
3259
3260 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3261
3262         Fix the build
3263
3264         * TestRunnerShared/spi/PencilKitTestSPI.h:
3265         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3266
3267 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3268
3269         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3270         https://bugs.webkit.org/show_bug.cgi?id=194131
3271
3272         Reviewed by Michael Catanzaro.
3273
3274         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3275         (uriChanged):
3276         (testUnfinishedSubresourceLoad):
3277         (serverCallback):
3278         (beforeAll):
3279
3280 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3281
3282         WTF::Expected should use std::addressof instead of operator&
3283         https://bugs.webkit.org/show_bug.cgi?id=195604
3284
3285         Reviewed by Myles Maxfield.
3286
3287         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3288         (TestWebKitAPI::Unique::Unique):
3289         (TestWebKitAPI::Unique::operator&):
3290         (TestWebKitAPI::TEST):
3291
3292 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3293
3294         Add Optional to Forward.h.
3295         https://bugs.webkit.org/show_bug.cgi?id=195586
3296
3297         Reviewed by Darin Adler.
3298
3299         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3300         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3301         Remove unnecessary includes from headers.
3302
3303 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3304
3305         Add testing API to hit-test and scroll overflow scrollers
3306         https://bugs.webkit.org/show_bug.cgi?id=195278
3307
3308         Reviewed by Antti Koivisto.
3309         
3310         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3311         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3312         
3313         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3314
3315         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3316         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3317         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3318         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3319         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3320         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3321         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3322         (WTR::enclosingScrollViewIncludingSelf):
3323         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3324
3325 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3326
3327         API test WebKit.RequestTextInputContext fails on iOS
3328         https://bugs.webkit.org/show_bug.cgi?id=195585
3329
3330         Reviewed by Wenson Hsieh and Simon Fraser.
3331
3332         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3333         (applyStyle):
3334         (TEST):
3335         Add a viewport, so that the coordinates match up on iOS.
3336         Scroll by moving the UIScrollView's contentOffset.
3337
3338 2019-03-11  Chris Dumez  <cdumez@apple.com>
3339
3340         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3341         https://bugs.webkit.org/show_bug.cgi?id=195506
3342         <rdar://problem/48733477>
3343
3344         Reviewed by Alex Christensen.
3345
3346         Add API test coverage.
3347
3348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3349
3350 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3351
3352         Adding myself to contributors.json
3353
3354         Unreviewed, addming myself to contributors.json .
3355
3356         * Scripts/webkitpy/common/config/contributors.json:
3357
3358 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3359
3360         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3361         https://bugs.webkit.org/show_bug.cgi?id=195511
3362         <rdar://problem/44873269>
3363
3364         Reviewed by Darin Adler.
3365
3366         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3367         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3368         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3369         (TEST_F):
3370
3371 2019-03-11  Chris Dumez  <cdumez@apple.com>
3372
3373         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3374         https://bugs.webkit.org/show_bug.cgi?id=195561
3375
3376         Reviewed by Youenn Fablet.
3377
3378         Make sure the JS in the test requests for permission to receive device orientation events.
3379
3380         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3381
3382 2019-03-11  Youenn Fablet  <youenn@apple.com>
3383
3384         Allow storage quota increase by default in WTR
3385         https://bugs.webkit.org/show_bug.cgi?id=195541
3386
3387         Reviewed by Geoffrey Garen.
3388
3389         Allow storage quota increase by default in WTR.
3390         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3391         Use this for tests that explicitly need cache increase.
3392
3393         Instead of increasing quota by 2, make sure the next request is
3394         granted by adding all given parameters.
3395
3396         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3398         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3399         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3400         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3401         * WebKitTestRunner/TestController.cpp:
3402         (WTR::TestController::setAllowStorageQuotaIncrease):
3403         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3404         * WebKitTestRunner/TestController.h:
3405         * WebKitTestRunner/TestInvocation.cpp:
3406         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3407         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3408         (WTR::TestController::cocoaResetStateToConsistentValues):
3409         (WTR::TestController::setAllowStorageQuotaIncrease):
3410         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3411         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3412         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3413
3414 2019-03-11  Xan Lopez  <xan@igalia.com>
3415
3416         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3417         https://bugs.webkit.org/show_bug.cgi?id=194147
3418
3419         Reviewed by Michael Saboff.
3420
3421         To make --32-bit work correctly on Linux/64bit we need to:
3422
3423         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3424         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3425         unfortunately CMake only allows us to do this during
3426         crosscompilation, which is overkill here.
3427         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3428         pkg-config detection module uses the x86 .pc files instead of the
3429         x86_64 ones.
3430         - Set the -m32 flags for the compiler.
3431
3432         * Scripts/webkitdirs.pm:
3433         (generateBuildSystemFromCMakeProject):
3434
3435 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3436
3437         Add MotionMark-1.1 plan file for run-benchmark script.
3438         https://bugs.webkit.org/show_bug.cgi?id=195481
3439
3440         Rubber-stamped by Darin Adler.
3441
3442         Run-benchmark script should support MontionMark-1.1.
3443
3444         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3445
3446 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3447
3448         [ews-app] Add support for submit-to-ews url
3449         https://bugs.webkit.org/show_bug.cgi?id=195477
3450
3451         Reviewed by Lucas Forschler.
3452
3453         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3454         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3455         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3456         * BuildSlaveSupport/ews-app/ews/urls.py:
3457         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3458
3459 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3460
3461         Unreviewed, rolling out r242688, r242643, r242624.
3462
3463         Caused multiple layout test failures and crashes on iOS and macOS.
3464
3465         Reverted changeset:
3466
3467         "requestAnimationFrame should execute before the next frame"
3468         https://bugs.webkit.org/show_bug.cgi?id=177484
3469         https://trac.webkit.org/changeset/242624/webkit
3470
3471         * Tracing/SystemTracePoints.plist:
3472
3473 2019-03-11  John Wilander  <wilander@apple.com>
3474
3475         Resource Load Statistics: Make it possible exclude localhost from classification
3476         https://bugs.webkit.org/show_bug.cgi?id=195474
3477         <rdar://problem/47520577>
3478
3479         Reviewed by Brent Fulgham.
3480
3481         This patch allows for localhost to be excluded from classification and
3482         treatment as a prevalent resource.
3483
3484         The WebKit Tools change adds a new function called
3485         testRunner.setStatisticsIsRunningTest() which can be used to control this
3486         behavior.
3487
3488         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3489         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3490         (WTR::TestRunner::setStatisticsIsRunningTest):
3491         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3492         * WebKitTestRunner/TestController.cpp:
3493         (WTR::TestController::setStatisticsIsRunningTest):
3494         * WebKitTestRunner/TestController.h:
3495         * WebKitTestRunner/TestInvocation.cpp:
3496         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3497
3498 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3499
3500         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3501         https://bugs.webkit.org/show_bug.cgi?id=195560
3502
3503         Reviewed by Lucas Forschler.
3504
3505         * BuildSlaveSupport/ews-build/master.cfg:
3506
3507 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3508
3509         Unreviewed, rolling out r242698.
3510
3511         API test crashes on bots.
3512
3513         Reverted changeset:
3514
3515         "Add a WKContentRuleList variant that uses copied memory
3516         instead of mmap'd shared memory for class A containerized
3517         apps"
3518         https://bugs.webkit.org/show_bug.cgi?id=195511
3519         https://trac.webkit.org/changeset/242698
3520
3521 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3522
3523         [WPE] Enable web process sandbox
3524         https://bugs.webkit.org/show_bug.cgi?id=195169
3525
3526         Reviewed by Daniel Bates.
3527
3528         * wpe/install-dependencies:
3529         * wpe/jhbuild.modules:
3530
3531 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3532
3533         [ews-app] Use port 17000 for worker communication
3534         https://bugs.webkit.org/show_bug.cgi?id=195558
3535
3536         Reviewed by Lucas Forschler.
3537
3538         * BuildSlaveSupport/ews-build/master.cfg:
3539
3540 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3541
3542         [ews-build] unit-tests fail when passwords.json is missing
3543         https://bugs.webkit.org/show_bug.cgi?id=195557
3544
3545         Reviewed by Lucas Forschler.
3546
3547         * BuildSlaveSupport/ews-build/loadConfig.py:
3548         (loadBuilderConfig):
3549         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3550         (ConfigDotJSONTest.test_configuration):
3551         * BuildSlaveSupport/ews-build/master.cfg:
3552
3553 2019-03-11  Truitt Savell  <tsavell@apple.com>
3554
3555         Unreviewed, rolling out r242702.
3556
3557         Broke High Sierra builders.
3558
3559         Reverted changeset:
3560
3561         "Add utility function to allow easy reverse range-based
3562         iteration of a container"
3563         https://bugs.webkit.org/show_bug.cgi?id=195542
3564         https://trac.webkit.org/changeset/242702
3565
3566 2019-03-11  Sam Weinig  <sam@webkit.org>
3567
3568         Add utility function to allow easy reverse range-based iteration of a container
3569         https://bugs.webkit.org/show_bug.cgi?id=195542
3570
3571         Reviewed by Antti Koivisto.
3572
3573         * TestWebKitAPI/CMakeLists.txt:
3574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3575         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3576         (TestWebKitAPI::TEST):
3577         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3578
3579 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3580
3581         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3582         https://bugs.webkit.org/show_bug.cgi?id=195511
3583         <rdar://problem/44873269>
3584
3585         Reviewed by Darin Adler.
3586
3587         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3588         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3589         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3590         (TEST_F):
3591
3592 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3593
3594         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3595         https://bugs.webkit.org/show_bug.cgi?id=195499
3596
3597         Reviewed by Darin Adler.
3598
3599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3600         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3601         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3602         (-[WKWebView synchronouslyFocusTextInputContext:]):
3603         (applyStyle):
3604         (applyIframe):
3605         (TEST):
3606         Add some tests for this SPI.
3607
3608 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3609
3610         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3611         https://bugs.webkit.org/show_bug.cgi?id=181151
3612
3613         Reviewed by Don Olmstead.
3614
3615         * TestWebKitAPI/CMakeLists.txt:
3616         * TestWebKitAPI/PlatformWin.cmake:
3617         Enable TestWTF RunLoop tests in all platforms.
3618
3619         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3620         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3621         (TestWebKitAPI::DerivedOneShotTimer::fired):
3622         (TestWebKitAPI::TEST):
3623         Only a few platforms support nested RunLoop.
3624
3625         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3626         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3627
3628 2019-03-10  David Quesada  <david_quesada@apple.com>
3629
3630         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3631         https://bugs.webkit.org/show_bug.cgi?id=152480
3632
3633         Reviewed by Chris Dumez.
3634
3635         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3636         there are no additional references to the process pool besides the one held by
3637         the download, waits for the download to finish (in the sense that the
3638         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3639         measure, also check that the process pool has been deallocated at the end of the
3640         test. The test wouldn't be meaningful if the process pool were still alive.
3641
3642         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3643         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3644         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3645             The download will be canceled because the delegate does not implement the
3646             method to decide the download's destination, so this is where we know the
3647             DownloadProxyMap is done with the DownloadProxy.
3648         (TEST):
3649
3650 2019-03-08  Chris Dumez  <cdumez@apple.com>
3651
3652         Add support for Device Orientation / Motion permission API
3653         https://bugs.webkit.org/show_bug.cgi?id=195329
3654         <rdar://problem/47645367>
3655
3656         Reviewed by Geoffrey Garen.
3657
3658         Add test infrastructure to help test the Device Orientation / Motion permission API.
3659
3660         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3661         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3662         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3663         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3664         * WebKitTestRunner/TestController.cpp:
3665         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3666         (WTR::TestController::createWebViewWithOptions):
3667         (WTR::TestController::resetStateToConsistentValues):
3668         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3669         * WebKitTestRunner/TestController.h:
3670         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3671         * WebKitTestRunner/TestInvocation.cpp:
3672         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3673
3674 2019-03-08  Saam barati  <sbarati@apple.com>
3675
3676         Add a compare-results script to compare benchmark results
3677         https://bugs.webkit.org/show_bug.cgi?id=195486
3678         <rdar://problem/48723397>
3679
3680         Reviewed by Geoffrey Garen.
3681
3682         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3683         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3684         to extend it to learn about our other benchmarks.
3685
3686         * Scripts/compare-results: Added.
3687         (readJSONFile):
3688         (detectJetStream2):
3689         (JetStream2Results):
3690         (detectSpeedometer2):
3691         (Speedometer2Results):
3692         (detectPLT5):
3693         (PLT5Results):
3694         (detectBenchmark):
3695         (biggerIsBetter):
3696         (ttest):
3697         (getOptions):
3698         (main):
3699
3700 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3701
3702         Ensure old tab state is cleared between iterations of run-benchmark
3703         https://bugs.webkit.org/show_bug.cgi?id=195393
3704         <rdar://problem/46885583>
3705
3706         Reviewed by Dewei Zhu.
3707
3708         a) ensure the default to restore state is not set
3709         b) terminate Safari correctly
3710         c) Set the system default to ignore Persistent State in Safari
3711
3712         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3713         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3714         (OSXBrowserDriver.prepare_env): 
3715         (OSXBrowserDriver.restore_env):
3716         (OSXBrowserDriver.close_browsers):
3717         (OSXBrowserDriver._terminate_processes):
3718         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3719         (OSXChromeDriver):
3720         (OSXChromeCanaryDriver):
3721         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3722         (OSXFirefoxDriver):
3723         (OSXFirefoxNightlyDriver):
3724         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3725         (OSXSafariDriver):
3726         (OSXSafariDriver.prepare_env):
3727
3728 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3729
3730         [GTK] Several InputMethodFilter tests are failing
3731         https://bugs.webkit.org/show_bug.cgi?id=195408
3732
3733         Reviewed by Carlos Garcia Campos.
3734
3735         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3736         Regressed in r241751.
3737         Hexadecimal values of keycodes are expressed now in upper letters.
3738         Composited characters should be cast to UTF8 strings.
3739
3740         (TestWebKitAPI::TEST):
3741
3742 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3743
3744         [GTK] Make Tools/gtkdoc python3 compatible
3745         https://bugs.webkit.org/show_bug.cgi?id=195359
3746
3747         Reviewed by Carlos Garcia Campos.
3748
3749         * gtkdoc/generate-gtkdoc:
3750         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3751         work with Python 2 and 3.
3752         (get_gtkdoc_module_paths):
3753         The iteritems() was removed in Python 3, so let's use items() that's
3754         available in Python 2 and 3.
3755         (get_generator_for_config):
3756         * gtkdoc/gtkdoc.py:
3757         (GTKDoc._run_command):
3758         The sys.stdout.write() is expecting str in Python 3 and not bytes
3759         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3760         for passing the bytes there.
3761
3762 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3763
3764         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3765         https://bugs.webkit.org/show_bug.cgi?id=195346
3766         <rdar://problem/48667048>
3767
3768         Unreviewed build fix for clang-cl.
3769
3770         * DumpRenderTree/win/DumpRenderTree.cpp:
3771         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3772
3773 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3774
3775         requestAnimationFrame should execute before the next frame
3776         https://bugs.webkit.org/show_bug.cgi?id=177484
3777
3778         Reviewed by Simon Fraser.
3779
3780         Add trace points for the page RenderingUpdate.
3781
3782         * Tracing/SystemTracePoints.plist:
3783
3784 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3785
3786         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3787         https://bugs.webkit.org/show_bug.cgi?id=195353
3788         <rdar://problem/48626394>
3789
3790         Reviewed by Simon Fraser.
3791
3792         * WebKitTestRunner/ios/TestControllerIOS.mm:
3793         (WTR::TestController::platformResetPreferencesToConsistentValues):
3794
3795 2019-03-07  John Wilander  <wilander@apple.com>
3796
3797         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3798         https://bugs.webkit.org/show_bug.cgi?id=195383
3799         <rdar://problem/48570136>
3800
3801         Reviewed by Brent Fulgham.
3802
3803         This patch adds test infrastructure to purge only script-accessible cookies,
3804         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3805
3806         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3807         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3808         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3809         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3810         * WebKitTestRunner/TestController.cpp:
3811         (WTR::TestController::statisticsDeleteCookiesForHost):
3812         * WebKitTestRunner/TestController.h:
3813         * WebKitTestRunner/TestInvocation.cpp:
3814         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3815
3816 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3817
3818         Unreviewed, rolling out r242354.
3819         https://bugs.webkit.org/show_bug.cgi?id=195402
3820
3821         breaks layout tests in all configurations (Requested by
3822         zdobersek on #webkit).
3823
3824         Reverted changeset:
3825
3826         "[WPE] Enable web process sandbox"
3827         https://bugs.webkit.org/show_bug.cgi?id=195169
3828         https://trac.webkit.org/changeset/242354
3829
3830 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3831
3832         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3833         https://bugs.webkit.org/show_bug.cgi?id=195346
3834
3835         Reviewed by Fujii Hironori.
3836
3837         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3838         (TestWebKitAPI::TEST):
3839         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3840
3841         * DumpRenderTree/win/DumpRenderTree.cpp:
3842         (findFontFallback):
3843         (addFontFallbackIfPresent):
3844         (removeFontFallbackIfPresent):
3845         (main):
3846         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3847         (TestWebKitAPI::Util::moduleDirectory):
3848         (TestWebKitAPI::Util::createInjectedBundlePath):
3849         Use wchar helpers as needed.
3850
3851 2019-03-06  Rob Buis  <rbuis@igalia.com>
3852
3853         Consider supporting the `referrerpolicy` attribute.
3854         https://bugs.webkit.org/show_bug.cgi?id=179053
3855
3856         Reviewed by Darin Adler.
3857
3858         Add a runtime flag for referrerpolicy attribute.
3859
3860         * DumpRenderTree/mac/DumpRenderTree.mm:
3861         (enableExperimentalFeatures):
3862
3863 2019-03-05  Daniel Bates  <dabates@apple.com>
3864
3865         Update expected API test result following r242379
3866         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3867
3868         Update expected x-coordinate of selection rect now that the left padding of
3869         a textarea is sized in ems (so dependent on the font size) just like the left
3870         padding of a text field.
3871
3872         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3873         (TestWebKitAPI::TEST):
3874
3875 2019-03-05  David Quesada  <david_quesada@apple.com>
3876
3877         [WK2] It should be possible to follow links with 'download' attributes
3878         https://bugs.webkit.org/show_bug.cgi?id=195145
3879         rdar://problem/48462642
3880
3881         Reviewed by Alex Christensen.
3882
3883         Add a unit test to verify that activating links with 'download' attributes now
3884         navigates to the linked resource, rather than starts downloading it. Add another
3885         to verify that it is still possible to explicitly download the link via the
3886         'Download' navigation action policy.
3887
3888         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3889         (-[DownloadAttributeTestDelegate init]):
3890         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3891         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3892         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3893         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3894         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3895         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3896         (TEST):
3897         * WebKitTestRunner/TestController.cpp:
3898         (WTR::TestController::decidePolicyForNavigationAction):
3899         * WebKitTestRunner/TestController.h:
3900
3901 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3902
3903         [Curl] Implement Cookie Accept Policy.
3904         https://bugs.webkit.org/show_bug.cgi?id=191645
3905
3906         Reviewed by Fujii Hironori.
3907
3908         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3909         (TestWebKitAPI::Curl::TEST_F):
3910
3911 2019-03-05  Youenn Fablet  <youenn@apple.com>
3912
3913         Rename requestCacheStorageSpace to requestStorageSpace
3914         https://bugs.webkit.org/show_bug.cgi?id=195282
3915
3916         Reviewed by Chris Dumez.
3917
3918         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3919         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3920         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3921
3922 2019-03-05  Brady Eidson  <beidson@apple.com>
3923
3924         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3925         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3926
3927         Reviewed by Tim Horton.
3928
3929         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3930         different directory into that same WKWebView should work.
3931
3932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3933         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3934
3935 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3936
3937         Add WeakHashSet
3938         https://bugs.webkit.org/show_bug.cgi?id=195152
3939
3940         Reviewed by Antti Koivisto.
3941
3942         Added tests for WeakHashSet.
3943
3944         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3945         (TestWebKitAPI::Base::Base): Moved.
3946         (TestWebKitAPI::Derived::foo): Moved.
3947         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3948         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3949         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3950         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3951
3952 2019-03-04  Chris Dumez  <cdumez@apple.com>
3953
3954         Do not share WebProcesses between private and regular sessions
3955         https://bugs.webkit.org/show_bug.cgi?id=195189
3956         <rdar://problem/48421064>
3957
3958         Reviewed by Alex Christensen.
3959
3960         Add API test coverage.
3961
3962         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3963         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3964
3965 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3966
3967         [WPE] Enable web process sandbox
3968         https://bugs.webkit.org/show_bug.cgi?id=195169
3969
3970         Reviewed by Daniel Bates.
3971
3972         * wpe/install-dependencies:
3973         * wpe/jhbuild.modules:
3974
3975 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3976
3977         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3978         https://bugs.webkit.org/show_bug.cgi?id=195206
3979
3980         Reviewed by Žan Doberšek.
3981
3982         Add a new test case.
3983
3984         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3985         (testJSCClass):
3986
3987 2019-03-04  Charlie Turner  <cturner@igalia.com>
3988
3989         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3990         https://bugs.webkit.org/show_bug.cgi?id=194898
3991
3992         Reviewed by Žan Doberšek.
3993
3994         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3995         a GCC extension that permits arithmetic on void* pointer. Inline
3996         the macro until this issue is fixed upstream.
3997
3998 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3999
4000         Rid the world of WK_API_ENABLED
4001         https://bugs.webkit.org/show_bug.cgi?id=195263
4002
4003         Reviewed by Dan Bernstein.
4004
4005         List of changed files elided because it's useless.
4006
4007 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4008
4009         Unreviewed follow-up to r242292.
4010
4011         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4012
4013         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4014         (TestWebKitAPI::testStrip): Renamed from strip.
4015         (TestWebKitAPI::TEST):
4016
4017 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4018
4019         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4020
4021         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4022         and bug #194272 for details.
4023
4024         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4025
4026 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4027
4028         Remove some more unused 32-bit code
4029         https://bugs.webkit.org/show_bug.cgi?id=195255
4030
4031         Reviewed by Darin Adler.
4032
4033         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4034         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4035         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4036         (NPP_New):
4037         (NPP_HandleEvent):
4038         (handleEventCarbon): Deleted.
4039
4040 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4041
4042         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4043
4044         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4045         (TestWebKitAPI::TEST):
4046
4047 2019-03-01  Darin Adler  <darin@apple.com>
4048
4049         Finish removing String::format
4050         https://bugs.webkit.org/show_bug.cgi?id=194893
4051
4052         Reviewed by Daniel Bates.
4053 '
4054         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4055
4056 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4057
4058         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4059         https://bugs.webkit.org/show_bug.cgi?id=195229
4060         <rdar://problem/48520362>
4061
4062         Reviewed by Chris Dumez.
4063
4064         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4065         (TEST):
4066
4067 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4068
4069         Add a system trace scope for event region building
4070         https://bugs.webkit.org/show_bug.cgi?id=195226
4071
4072         Reviewed by Jon Lee.
4073
4074         This trace scope measures the time spend converting element rects into Region objects,
4075         which can be large on some pages.
4076
4077         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4078
4079         * Tracing/SystemTracePoints.plist:
4080
4081 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4082
4083         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4084         https://bugs.webkit.org/show_bug.cgi?id=194612
4085
4086         Reviewed by Alex Christensen.
4087
4088         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4089         Just test the new string-processing function and don't touch the actual environment.
4090         (Test cases are all as before, but based on operator== instead of strcmp.)
4091
4092 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4093
4094         [ews-app] Update primary keys for handling multiple Buildbot instances
4095         https://bugs.webkit.org/show_bug.cgi?id=195120
4096
4097         Reviewed by Stephanie Lewis.
4098
4099         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4100         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4101         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4102
4103         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4104         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4105         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4106         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4107         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4108         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4109
4110 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4111
4112         [WinCairo] Enable service worker
4113         https://bugs.webkit.org/show_bug.cgi?id=188318
4114
4115         Reviewed by Youenn Fablet.
4116
4117         * DumpRenderTree/DumpRenderTreePrefix.h:
4118         * TestWebKitAPI/PlatformWin.cmake:
4119         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4120         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4121         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4122
4123 2019-03-01  Justin Fan  <justin_fan@apple.com>
4124
4125         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4126         https://bugs.webkit.org/show_bug.cgi?id=195191
4127
4128         Rubber-stamped by Dean Jackson.
4129
4130         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4131
4132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4133
4134 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4135
4136         Unreviewed, fix lldb webkitpy tests
4137         https://bugs.webkit.org/show_bug.cgi?id=194375
4138
4139         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4140
4141         * lldb/lldb_webkit.py:
4142         (WTFStringImplProvider.is_8bit):
4143
4144 2019-02-28  David Quesada  <david_quesada@apple.com>
4145
4146         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4147         https://bugs.webkit.org/show_bug.cgi?id=195121
4148         rdar://problem/48450302
4149
4150         Reviewed by Alex Christensen.
4151
4152         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4153         configurations where the 'download' attribute is absent, blank, or populated
4154         with a filename, and where the anchor element is same-origin or cross-origin
4155         (meaning the 'download' attribute shouldn't be honored).
4156
4157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4158         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4159         (-[NavigationActionTestDelegate init]):
4160         (-[NavigationActionTestDelegate navigationAction]):
4161         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4162         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4163         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4164         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4165         (TEST):
4166
4167 2019-02-28  Antoine Quint  <graouts@apple.com>
4168
4169         Enable the Pointer Events runtime flag by default
4170         https://bugs.webkit.org/show_bug.cgi?id=195156
4171
4172         Reviewed by Dean Jackson.
4173
4174         * DumpRenderTree/mac/DumpRenderTree.mm:
4175         (enableExperimentalFeatures):
4176
4177 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4178
4179         Several PasteImage API tests are flaky
4180         https://bugs.webkit.org/show_bug.cgi?id=195160
4181
4182         Reviewed by Tim Horton.
4183
4184         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4185         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4186         listening for a "load" event after image load is already complete.
4187
4188         To address this, make these tests first register a "load" event handler, then run script to insert an image
4189         element into the document, and finally wait until the load event is observed before checking image size.
4190
4191         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4192
4193 2019-02-28  Chris Dumez  <cdumez@apple.com>
4194
4195         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4196         https://bugs.webkit.org/show_bug.cgi?id=195107
4197
4198         Reviewed by Alex Christensen.
4199
4200         Give some time for the zoom level to get restored.
4201
4202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4203
4204 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4205
4206         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4207         https://bugs.webkit.org/show_bug.cgi?id=194958
4208
4209         Reviewed by Geoffrey Garen.
4210
4211         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4212         (TEST):
4213
4214 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4215
4216         [ews-app] Update method to save build to handle builder_display_name
4217         https://bugs.webkit.org/show_bug.cgi?id=195047
4218
4219         Reviewed by Dewei Zhu.
4220
4221         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4222         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4223
4224 2019-02-28  Justin Fan  <justin_fan@apple.com>
4225
4226         [Web GPU] Enable Web GPU only on 64-bit
4227         https://bugs.webkit.org/show_bug.cgi?id=195139
4228
4229         Because Metal is only supported on 64 bit apps.
4230
4231         Unreviewed build fix.
4232
4233         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4234
4235 2019-02-27  Youenn Fablet  <youenn@apple.com>
4236
4237         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4238         https://bugs.webkit.org/show_bug.cgi?id=194959
4239
4240         Reviewed by Chris Dumez.
4241
4242         Spin loop until getting the condition to remove flakiness.
4243
4244         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4245
4246 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4247
4248         [ews-build] Buildbot should include builder_display_name in the build events
4249         https://bugs.webkit.org/show_bug.cgi?id=195045
4250
4251         Reviewed by Dewei Zhu.
4252
4253         * BuildSlaveSupport/ews-build/events.py:
4254         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4255         buildername to builder_name to be consistent in naming style.
4256         (Events.buildFinished): Ditto.
4257
4258 2019-02-27  Chris Dumez  <cdumez@apple.com>
4259
4260         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4261         https://bugs.webkit.org/show_bug.cgi?id=194480
4262
4263         Reviewed by Brady Eidson.
4264
4265         Update existing API test to make it more likely to reproduce the issue.
4266
4267         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4268
4269 2019-02-27  Brady Eidson  <beidson@apple.com>
4270
4271         Universal links from Google search results pages don't open the app.
4272         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4273
4274         Reviewed by Geoffrey Garen.
4275
4276         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4277         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4278         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4279         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4280
4281 2019-02-27  Chris Dumez  <cdumez@apple.com>
4282
4283         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4284         https://bugs.webkit.org/show_bug.cgi?id=195102
4285
4286         Reviewed by Geoffrey Garen.
4287
4288         If the number of processes is not yet what we expect, wait a bit and check again to give
4289         processes some time to exit.
4290
4291         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4292
4293 2019-02-27  Chris Dumez  <cdumez@apple.com>
4294
4295         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4296         https://bugs.webkit.org/show_bug.cgi?id=194545
4297
4298         Reviewed by Brady Eidson.
4299
4300         Make sure the test navigates forward and then back only once. Previously, navigating
4301         back would trigger a navigation again in a timer.
4302
4303         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4304
4305 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4306
4307         High Sierra Debug JSC test queue should use faster hardware
4308         https://bugs.webkit.org/show_bug.cgi?id=194603
4309
4310         Rubber-stamped by Alexey Proskuryakov.
4311
4312         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4313
4314         * BuildSlaveSupport/build.webkit.org-config/config.json:
4315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4316         (BubbleQueueServer):
4317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4318         (WebKitBuildbot):
4319         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4320         * QueueStatusServer/config/queues.py:
4321         * Scripts/webkitpy/common/config/ews.json:
4322         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4323         (test_ews_name):
4324
4325 2019-02-27  John Wilander  <wilander@apple.com>
4326
4327         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4328         https://bugs.webkit.org/show_bug.cgi?id=195071
4329         <rdar://problem/48417690>
4330
4331         Reviewed by Alex Christensen and Brent Fulgham.
4332
4333         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4334         (TestWebKitAPI::createURL):
4335             Convenience function.
4336         (TestWebKitAPI::TEST):
4337             WebCore::AdClickAttribution now takes a URL when creating Source and
4338             Destination.
4339         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4340         (TestWebKitAPI::TEST):
4341             WebCore::AdClickAttribution now takes a URL when creating Source and
4342             Destination.
4343
4344 2019-02-27  Antoine Quint  <graouts@apple.com>
4345
4346         Support Pointer Events on macOS
4347         https://bugs.webkit.org/show_bug.cgi?id=195008
4348         <rdar://problem/47454419>
4349
4350         Reviewed by Dean Jackson.
4351
4352         * DumpRenderTree/mac/DumpRenderTree.mm:
4353         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4354         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4355
4356 2019-02-26  Mark Lam  <mark.lam@apple.com>
4357
4358         Remove remaining poisoning code.
4359         https://bugs.webkit.org/show_bug.cgi?id=194138
4360
4361         Reviewed by Saam Barati.
4362
4363         * TestWebKitAPI/CMakeLists.txt:
4364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4365         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4366         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4367         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4368         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4369         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4370         * TestWebKitAPI/Tests/WTF/PoisonedUn