AX: Support API: accessibilityReplaceRange:withText
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         AX: Support API: accessibilityReplaceRange:withText
4         https://bugs.webkit.org/show_bug.cgi?id=196636
5
6         Unreviewed build fix for Windows port.
7
8         * DumpRenderTree/AccessibilityUIElement.cpp:
9         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
10
11 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-build] Scripts using Buildbot API have CORS error
14         https://bugs.webkit.org/show_bug.cgi?id=196709
15
16         Reviewed by Alexey Proskuryakov.
17
18         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
19
20 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
21
22         AX: Support API: accessibilityReplaceRange:withText
23         https://bugs.webkit.org/show_bug.cgi?id=196636
24
25         Reviewed by Daniel Bates.
26
27         * DumpRenderTree/AccessibilityUIElement.cpp:
28         (replaceTextInRangeCallback):
29         (AccessibilityUIElement::replaceTextInRange):
30         (AccessibilityUIElement::getJSClass):
31         * DumpRenderTree/AccessibilityUIElement.h:
32         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
33         (AccessibilityUIElement::replaceTextInRange):
34         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
35         (AccessibilityUIElement::replaceTextInRange):
36         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
37         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
38         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
39         (WTR::AccessibilityUIElement::replaceTextInRange):
40         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
41         (WTR::AccessibilityUIElement::replaceTextInRange):
42
43 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
44
45         [iOS] Do not allow starting selection drags when selection views are not visible
46         https://bugs.webkit.org/show_bug.cgi?id=196686
47         <rdar://problem/49399192>
48
49         Reviewed by Tim Horton.
50
51         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
52         also add some new API tests to cover scenarios where the web view is not first responder.
53
54         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
55         (TestWebKitAPI::TEST):
56         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
57
58         Add a switch to optionally make the web view first responder when starting the simulated drag.
59
60         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
61         (-[DragAndDropSimulator initWithWebView:]):
62         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
63
64 2019-04-08  Justin Fan  <justin_fan@apple.com>
65
66         [Web GPU] Fix Web GPU experimental feature on iOS
67         https://bugs.webkit.org/show_bug.cgi?id=196632
68
69         Reviewed by Myles C. Maxfield.
70
71         Properly make Web GPU available on iOS 11+.
72
73         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
74
75 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
76
77         [ews-build] Do not upload archive when Compile Fails
78         https://bugs.webkit.org/show_bug.cgi?id=196674
79
80         Reviewed by Alexey Proskuryakov.
81
82         * BuildSlaveSupport/ews-build/factories.py:
83         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
84         * BuildSlaveSupport/ews-build/steps.py:
85         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
86         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
87         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
88
89 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
90
91         Enable DFG on MIPS
92         https://bugs.webkit.org/show_bug.cgi?id=196689
93
94         Reviewed by Žan Doberšek.
95
96         Since the bytecode change, we enabled the baseline JIT on mips in
97         r240432, but DFG is still missing. With this change, all tests are
98         passing on a ci20 board.
99
100         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
101
102 2019-04-08  Philippe Normand  <pnormand@igalia.com>
103
104         [Flatpak] Second run update-webkitwpe-flatpak fails
105         https://bugs.webkit.org/show_bug.cgi?id=192702
106
107         Reviewed by Carlos Garcia Campos.
108
109         * flatpak/flatpakutils.py:
110         (FlatpakObject.flatpak): Fix typo.
111         (FlatpakPackage.install): When installing, also update to the configured remote commit.
112         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
113
114 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
115
116         [GTK][WPE] outlook.live.com displays old-fashioned UI
117         https://bugs.webkit.org/show_bug.cgi?id=196642
118
119         Reviewed by Carlos Garcia Campos.
120
121         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
122         (TestWebKitAPI::TEST): New Mac platform quirk test.
123
124 2019-04-07  Commit Queue  <commit-queue@webkit.org>
125
126         Unreviewed, rolling out r243956.
127         https://bugs.webkit.org/show_bug.cgi?id=196688
128
129         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
130         by aakashjain on #webkit).
131
132         Reverted changeset:
133
134         "Clicking "Go Back" from a safe browsing warning from an
135         iframe should navigate the WKWebView back to the previous
136         page"
137         https://bugs.webkit.org/show_bug.cgi?id=196665
138         https://trac.webkit.org/changeset/243956
139
140 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
141
142         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
143         https://bugs.webkit.org/show_bug.cgi?id=196669
144
145         Reviewed by Geoffrey Garen.
146
147         Added three new unit tests for WeakHashSet.
148
149         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
150         (WTF_WeakPtr.WeakHashSetConstObjects):
151         (WTF_WeakPtr.WeakHashSetComputesEmpty):
152         (WTF_WeakPtr.WeakHashSetComputeSize):
153
154 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
155
156         Hide next and previous form control buttons when WKWebView is editable
157         https://bugs.webkit.org/show_bug.cgi?id=196672
158         <rdar://problem/35625321>
159
160         Reviewed by Tim Horton.
161
162         Add a new API test.
163
164         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
165         (-[TestWKWebView lastTrailingBarButtonGroup]):
166         (TestWebKitAPI::TEST):
167         * TestWebKitAPI/ios/UIKitSPI.h:
168
169 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
170
171         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
172         https://bugs.webkit.org/show_bug.cgi?id=196077
173         <rdar://problem/49108202>
174
175         Reviewed by Chris Dumez.
176
177         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
178         on new web view.
179
180         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
181
182 2019-04-05  Saam Barati  <sbarati@apple.com>
183
184         Make compare-results understand MotionMark
185         https://bugs.webkit.org/show_bug.cgi?id=196666
186
187         Reviewed by Yusuke Suzuki.
188
189         * Scripts/compare-results:
190         (PLT5Results):
191         (detectMotionMark):
192         (detectMotionMark1_1):
193         (motionMarkResults):
194         (motionMark1_1Results):
195         (detectBenchmark):
196         (biggerIsBetter):
197         (main):
198
199 2019-04-05  Alex Christensen  <achristensen@webkit.org>
200
201         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
202         https://bugs.webkit.org/show_bug.cgi?id=196665
203         <rdar://45115669>
204
205         Reviewed by Geoff Garen.
206
207         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
208         (goBack):
209         (+[SimpleLookupContext sharedLookupContext]):
210         (-[SimpleLookupContext lookUpURL:completionHandler:]):
211         (TEST):
212         (+[Simple3LookupContext sharedLookupContext]): Deleted.
213         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
214
215 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
216
217         [ews-build] Add configuration and architecture for windows builders
218         https://bugs.webkit.org/show_bug.cgi?id=196660
219
220         Reviewed by Lucas Forschler.
221
222         * BuildSlaveSupport/ews-build/config.json:
223
224 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
225
226         webkitpy: Don't run subsequent rounds if interrupted
227         https://bugs.webkit.org/show_bug.cgi?id=196646
228
229         Reviewed by Aakash Jain.
230
231         * Scripts/webkitpy/layout_tests/controllers/manager.py:
232         (Manager.run): Bail out if interrupted.
233
234 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
235
236         Test sessionStorage in PSON private browsing mode
237         https://bugs.webkit.org/show_bug.cgi?id=196561
238
239         Reviewed by Alex Christensen.
240
241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
242
243 2019-04-05  Commit Queue  <commit-queue@webkit.org>
244
245         Unreviewed, rolling out r243833.
246         https://bugs.webkit.org/show_bug.cgi?id=196645
247
248         This change breaks build of WPE and GTK ports (Requested by
249         annulen on #webkit).
250
251         Reverted changeset:
252
253         "[CMake][WTF] Mirror XCode header directories"
254         https://bugs.webkit.org/show_bug.cgi?id=191662
255         https://trac.webkit.org/changeset/243833
256
257 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
258
259         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
260         https://bugs.webkit.org/show_bug.cgi?id=196635
261
262         Reviewed by Antti Koivisto.
263         
264         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
265         for a test to enable async frame scrolling via:
266             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
267         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
268         
269         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
270
271         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
272         (WTR::InjectedBundle::beginTesting):
273         * WebKitTestRunner/TestController.cpp:
274         (WTR::TestController::resetPreferencesToConsistentValues):
275
276 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
277
278         Use a correct LC_RPATH when building with ASan
279         https://bugs.webkit.org/show_bug.cgi?id=196576
280
281         Reviewed by David Kilzer.
282
283         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
284         so that ../Frameworks is checked. This is simpler and more reliable than updating
285         each SPC service xcconfig.
286
287 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
288
289         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
290         https://bugs.webkit.org/show_bug.cgi?id=196629
291
292         Reviewed by Lucas Forschler.
293
294         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
295
296 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
297
298         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
299         https://bugs.webkit.org/show_bug.cgi?id=196618
300
301         Reviewed by Lucas Forschler.
302
303         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
304         (StatusBubble): Added QUEUE_TRIGGERS.
305         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
306         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
307         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
308         its parent(builder).
309
310 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
311
312         [ews-app] Status-bubble steps are sometimes displayed in reverse order
313         https://bugs.webkit.org/show_bug.cgi?id=196625
314
315         Reviewed by Lucas Forschler.
316
317         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
318         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
319
320 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
321
322         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
323         https://bugs.webkit.org/show_bug.cgi?id=196630
324
325         Reviewed by Wenson Hsieh.
326
327         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
328
329 2019-04-04  Youenn Fablet  <youenn@apple.com>
330
331         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
332         https://bugs.webkit.org/show_bug.cgi?id=196543
333
334         Reviewed by Alex Christensen.
335
336         * WebKitTestRunner/TestController.cpp:
337         (WTR::TestController::generatePageConfiguration):
338
339 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
340
341         [ews-app] Status bubble should not display skipped buildbot steps
342         https://bugs.webkit.org/show_bug.cgi?id=196584
343
344         Reviewed by Lucas Forschler.
345
346         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
347
348 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
349
350         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
351         https://bugs.webkit.org/show_bug.cgi?id=196620
352
353         Reviewed by Lucas Forschler.
354
355         * BuildSlaveSupport/ews-app/ews/config.py:
356
357 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
358
359         [Win] DumpRenderTreeWatchDog.py is not checked into source
360         https://bugs.webkit.org/show_bug.cgi?id=196567
361         <rdar://problem/49525901>
362
363         Reviewed by Lucas Forschler.
364
365         This script is used on Win EWS bots to terminate hanging DRT processes.
366
367         * EWSTools/dumprendertreewatchdog.py: Added.
368
369 2019-04-04  Chris Dumez  <cdumez@apple.com>
370
371         Unreviewed, roll out r243858 which made tests time out.
372
373         Disable new API tests on Windows instead.
374
375         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
376         (TestWebKitAPI::TEST):
377
378 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
379
380         [ATK] Cleanup WebPageAccessibilityObjectAtk
381         https://bugs.webkit.org/show_bug.cgi?id=196537
382
383         Reviewed by Michael Catanzaro.
384
385         Also consider files under atk directories as exceptions for GObject conventions.
386
387         * Scripts/webkitpy/style/checkers/cpp.py:
388         (check_identifier_name_in_declaration):
389
390 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
391
392         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
393         https://bugs.webkit.org/show_bug.cgi?id=196588
394         <rdar://problem/49365787>
395
396         Unreviewed build fix for Windows port.
397
398         error C3861: 'kill': identifier not found
399
400         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
401         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
402
403 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
404
405         [ews-build] Cancel build and similar operations should have authentication
406         https://bugs.webkit.org/show_bug.cgi?id=196520
407
408         Reviewed by Dewei Zhu.
409
410         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
411         environment variables.
412
413 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
414
415         [ews-build] Do not trigger queues which are not in production yet
416         https://bugs.webkit.org/show_bug.cgi?id=196581
417
418         Reviewed by Dewei Zhu.
419
420         * BuildSlaveSupport/ews-build/config.json:
421
422 2019-04-03  Chris Dumez  <cdumez@apple.com>
423
424         Unreviewed, fix typo in the name of API test added in r243848.
425
426         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
427         (TestWebKitAPI::TEST):
428
429 2019-04-03  Chris Dumez  <cdumez@apple.com>
430
431         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
432         https://bugs.webkit.org/show_bug.cgi?id=196588
433         <rdar://problem/49365787>
434
435         Reviewed by Ryosuke Niwa.
436
437         Add API test coverage.
438
439         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
440         (TestWebKitAPI::nullJavaScriptCallback):
441         (TestWebKitAPI::didCrashCheckFrames):
442         (TestWebKitAPI::TEST):
443
444 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
445
446         run-webkit-tests: Upload test results (new results database)
447         https://bugs.webkit.org/show_bug.cgi?id=196577
448         <rdar://problem/34841155>
449
450         Reviewed by Lucas Forschler.
451
452         * Scripts/webkitpy/layout_tests/controllers/manager.py:
453         (Manager.run): Upload results after each device shard, since the configuration will be
454         different for each device.
455         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
456         uploaded to a results database.
457         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
458         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
459
460 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
461
462         -apple-trailing-word is needed for browser detection
463         https://bugs.webkit.org/show_bug.cgi?id=196575
464
465         Unreviewed.
466
467         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
468
469 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
470
471         [CMake][WTF] Mirror XCode header directories
472         https://bugs.webkit.org/show_bug.cgi?id=191662
473
474         Reviewed by Konstantin Tokarev.
475
476         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
477         builds.
478
479         * CMakeLists.txt:
480         * DumpRenderTree/CMakeLists.txt:
481         * DumpRenderTree/PlatformWin.cmake:
482         * MiniBrowser/win/CMakeLists.txt:
483         * TestWebKitAPI/CMakeLists.txt:
484         * TestWebKitAPI/PlatformWin.cmake:
485         * WebKitTestRunner/PlatformGTK.cmake:
486         * WebKitTestRunner/PlatformWin.cmake:
487
488 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
489
490         [ews-app] Status bubble should not display certain infrastructure status messages
491         https://bugs.webkit.org/show_bug.cgi?id=196550
492
493         Reviewed by Lucas Forschler.
494
495         Do not display the steps which are un-needed for end-user. This information is still avaiable
496         if the user click on the bubble and look at the Buildbot build.
497         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
498         (StatusBubble._steps_messages):
499         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
500
501 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
502
503         [ews-build] Use https for sending data to ews-app
504         https://bugs.webkit.org/show_bug.cgi?id=196492
505
506         Reviewed by Lucas Forschler.
507
508         * BuildSlaveSupport/ews-build/events.py:
509
510 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
511
512         Remove support for -apple-trailing-word
513         https://bugs.webkit.org/show_bug.cgi?id=196525
514
515         Reviewed by Zalan Bujtas.
516
517         This CSS property is nonstandard and not used.
518
519         * Scripts/webkitperl/FeatureList.pm:
520         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
521
522 2019-04-03  Youenn Fablet  <youenn@apple.com>
523
524         Add a test for DOMCache on multiple browsing in case of private browsing
525         https://bugs.webkit.org/show_bug.cgi?id=196524
526
527         Reviewed by Alex Christensen.
528
529         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
530         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
531
532 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
533
534         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
535         https://bugs.webkit.org/show_bug.cgi?id=196540
536
537         Reviewed by Aakash Jain.
538
539         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
540
541 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
542
543         Add plumbing for a compatibility mode preference in WebKit
544         https://bugs.webkit.org/show_bug.cgi?id=196005
545
546         Reviewed by Tim Horton.
547
548         Add new API tests.
549
550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
551         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
552
553 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
554
555         [WPE][GTK] Update libsrtp dependency package for Debian
556         https://bugs.webkit.org/show_bug.cgi?id=196528
557
558         Reviewed by Frédéric Wang.
559
560         * gtk/install-dependencies:
561         * wpe/install-dependencies:
562
563 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
564
565         [WK2] Add support for Window's beforeprint / afterprint events
566         https://bugs.webkit.org/show_bug.cgi?id=196478
567         <rdar://problem/49535124>
568
569         Unreviewed build fix for MSVC.
570
571         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
572
573         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
574
575         * WebKitTestRunner/TestController.cpp:
576         (WTR::printFrame): Use int and float literals.
577
578 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
579
580         [ews-build] Reassign bots to queues
581
582         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
583
584 2019-04-02  Chris Dumez  <cdumez@apple.com>
585
586         [WK2] Add support for Window's beforeprint / afterprint events
587         https://bugs.webkit.org/show_bug.cgi?id=196478
588
589         Reviewed by Alex Christensen.
590
591         Add minimal implementation for printFrame in WebKitTestRunner.
592
593         * WebKitTestRunner/TestController.cpp:
594         (WTR::printFrame):
595         (WTR::TestController::createOtherPage):
596         (WTR::TestController::createWebViewWithOptions):
597
598 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
599
600         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
601         https://bugs.webkit.org/show_bug.cgi?id=196491
602
603         Reviewed by Lucas Forschler.
604
605         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
606
607 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
608
609         [ews-build] Configure buildbot try credentials in environment variables
610         https://bugs.webkit.org/show_bug.cgi?id=196501
611
612         Reviewed by Lucas Forschler.
613
614         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
615         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
616         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
617
618 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
619
620         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
621         https://bugs.webkit.org/show_bug.cgi?id=196496
622         <rdar://problem/49521634>
623
624         Reviewed by Chris Dumez.
625
626         Add new API tests (see WebKit ChangeLog for more detail).
627
628         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
629         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
630         (TEST):
631
632 2019-04-02  David Kilzer  <ddkilzer@apple.com>
633
634         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
635         <https://webkit.org/b/196499>
636
637         Reviewed by Alexey Proskuryakov.
638
639         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
640         ENABLE_ADDRESS_SANITIZER.
641
642 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
643
644         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
645         https://bugs.webkit.org/show_bug.cgi?id=182757
646
647         Reviewed by Don Olmstead.
648
649         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
650         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
651
652 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
653
654         run-api-tests: Upload test results
655         https://bugs.webkit.org/show_bug.cgi?id=196323
656         <rdar://problem/49356714>
657
658         Reviewed by Lucas Forschler.
659
660         * Scripts/webkitpy/api_tests/manager.py:
661         (Manager):
662         (Manager.run): Upload results to a results database.
663         * Scripts/webkitpy/api_tests/run_api_tests.py:
664         (parse_args): Add upload arguments.
665         * Scripts/webkitpy/port/base.py:
666         (Port):
667         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
668         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
669         with commits from any other associated repositories.
670         * Scripts/webkitpy/port/device.py:
671         (Device):
672         (Device.build_version): Access build_versoin of underlying platform device.
673         * Scripts/webkitpy/port/ios_simulator_unittest.py:
674         (IOSSimulatorTest):
675         (IOSSimulatorTest.test_configuration_for_upload):
676         * Scripts/webkitpy/port/device_port.py:
677         (DevicePort):
678         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
679         the same as the machine uploading results.
680         * Scripts/webkitpy/port/mac.py:
681         (MacPort):
682         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
683         * Scripts/webkitpy/port/mac_unittest.py:
684         (MacTest):
685         (MacTest.test_configuration_for_upload):
686         * Scripts/webkitpy/xcode/simulated_device.py:
687         (SimulatedDeviceManager._create_device_with_runtime):
688         (SimulatedDevice.__init__): Create simulated device with a build_version.
689         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
690         (test_existing_simulator):
691
692 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
693
694         Remove extra newline characters (Follow-up fix to r243707)
695
696         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
697
698 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
699
700         [ews-app] Use API_KEY to accept results data
701         https://bugs.webkit.org/show_bug.cgi?id=196461
702
703         Reviewed by Dewei Zhu.
704
705         * BuildSlaveSupport/ews-app/ews/views/results.py:
706         (Results.post): Validate EWS_API_KEY before accepting any data.
707         * BuildSlaveSupport/ews-build/events.py:
708         (Events.sendData): Send EWS_API_KEY if available along with event data.
709
710 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
711
712         Unable to copy and paste a PDF from Notes into Mail compose body
713         https://bugs.webkit.org/show_bug.cgi?id=196442
714         <rdar://problem/48573098>
715
716         Reviewed by Tim Horton.
717
718         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
719         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
720         to be specified on the item providers.
721
722         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
723         (TestWebKitAPI::mapItemForTesting):
724         (TestWebKitAPI::contactItemForTesting):
725
726 2019-04-01  Tim Horton  <timothy_horton@apple.com>
727
728         Make UIWKDocumentContext rects per-character instead of per-word
729         https://bugs.webkit.org/show_bug.cgi?id=196459
730
731         Reviewed by Wenson Hsieh.
732
733         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
734         (TEST):
735         Adjust test results due to switching to per-character rects.
736
737 2019-04-01  Chris Dumez  <cdumez@apple.com>
738
739         UIProcess crash when a prewarmed process is terminated
740         https://bugs.webkit.org/show_bug.cgi?id=196451
741         <rdar://problem/49245471>
742
743         Reviewed by Geoffrey Garen.
744
745         Add API test coverage.
746
747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
748         (TEST):
749
750 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
751
752         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
753         https://bugs.webkit.org/show_bug.cgi?id=196449
754
755         Reviewed by Lucas Forschler.
756
757         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
758         (StatusBubble.get_os_details): Method to get OS and Xcode details.
759         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
760         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
761
762 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
763
764         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
765         https://bugs.webkit.org/show_bug.cgi?id=196444
766
767         Reviewed by Lucas Forschler.
768
769         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
770
771 2019-04-01  Alex Christensen  <achristensen@webkit.org>
772
773         Add SPI to canonicalize NSURLs with WTF::URL
774         https://bugs.webkit.org/show_bug.cgi?id=196415
775         <rdar://problem/44980271>
776
777         Reviewed by Darin Adler.
778
779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
780         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
781         (TestWebKitAPI::TEST):
782
783 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
784
785         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
786         https://bugs.webkit.org/show_bug.cgi?id=196441
787
788         Reviewed by Carlos Garcia Campos.
789
790         Don't cache the wpe_view_backend object that might not exist yet at the
791         time of EventSenderProxy constructor invocation, but instead retrieve
792         that object whenever it's required for event dispatching. This should
793         avoid crashes in this constructor now that it's invoked before any
794         PlatformWindow has been set up (as changed in r243496).
795
796         * WebKitTestRunner/EventSenderProxy.h:
797         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
798         (WTR::viewBackend):
799         (WTR::EventSenderProxy::EventSenderProxy):
800         (WTR::EventSenderProxy::mouseDown):
801         (WTR::EventSenderProxy::mouseUp):
802         (WTR::EventSenderProxy::mouseMoveTo):
803         (WTR::EventSenderProxy::mouseScrollBy):
804         (WTR::EventSenderProxy::keyDown):
805         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
806
807 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
808
809         [Win][WebKit] MiniBrowser should support high DPI display
810         https://bugs.webkit.org/show_bug.cgi?id=196391
811
812         Reviewed by Alex Christensen.
813
814         * MiniBrowser/win/WebKitBrowserWindow.cpp:
815         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
816         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
817         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
818
819 2019-03-31  Sam Weinig  <weinig@apple.com>
820
821         Remove more i386 specific configurations
822         https://bugs.webkit.org/show_bug.cgi?id=196430
823
824         Reviewed by Alexey Proskuryakov.
825
826         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
827         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
828
829 2019-03-31  Andy Estes  <aestes@apple.com>
830
831         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
832         https://bugs.webkit.org/show_bug.cgi?id=196433
833         <rdar://problem/49293305>
834
835         Reviewed by Tim Horton.
836
837         Enhanced API test coverage to include all navigation response policy decisions in both
838         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
839
840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
841         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
842         (TestWebKitAPI::TEST):
843         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
844         (readFile):
845         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
846         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
847         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
848         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
849         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
850         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
851         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
852         (-[QuickLookDelegate _downloadDidStart:]):
853         (-[QuickLookDelegate _download:didReceiveResponse:]):
854         (-[QuickLookDelegate _download:didReceiveData:]):
855         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
856         (-[QuickLookDelegate _downloadDidFinish:]):
857         (-[QuickLookDelegate _download:didFailWithError:]):
858         (-[QuickLookDelegate _downloadDidCancel:]):
859         (-[QuickLookDelegate verifyDownload]):
860         (runTest):
861         (runTestDecideBeforeLoading):
862         (runTestDecideAfterLoading):
863         (TEST):
864         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
865         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
866         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
867         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
868         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
869         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
870         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
871         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
872         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
873         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
874         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
875         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
876         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
877         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
878
879 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
880
881         [CMake] add testdfg as target with build-jsc
882         https://bugs.webkit.org/show_bug.cgi?id=196393
883
884         Reviewed by Saam Barati.
885
886         Added testdfg as one of the targets to build when
887         using CMake.
888
889         * Scripts/build-jsc:
890
891 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
892
893         Delete WebMetal implementation in favor of WebGPU
894         https://bugs.webkit.org/show_bug.cgi?id=195418
895
896         Reviewed by Dean Jackson.
897
898         * DumpRenderTree/mac/DumpRenderTree.mm:
899         (enableExperimentalFeatures):
900         (resetWebPreferencesToConsistentValues):
901         * Scripts/webkitperl/FeatureList.pm:
902         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
904         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
905         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
906         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
907         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
908         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
909         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
910         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
911         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
912         (WTR::InjectedBundle::beginTesting):
913         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
914         (WTR::TestRunner::setWebMetalEnabled): Deleted.
915         * WebKitTestRunner/InjectedBundle/TestRunner.h:
916
917 2019-03-29  Chris Dumez  <cdumez@apple.com>
918
919         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
920         https://bugs.webkit.org/show_bug.cgi?id=196405
921         <rdar://problem/49428130>
922
923         Reviewed by Wenson Hsieh.
924
925         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
926         the popover presentation methods to be no-ops. Use this in the new test added in
927         r243523 so that we do not swizzle those methods for all tests. This is needed because
928         those WatchOS tests rely on the popover getting presented and interactive.
929
930         * WebKitTestRunner/TestController.cpp:
931         (WTR::updateTestOptionsFromTestHeader):
932         * WebKitTestRunner/TestController.h:
933         * WebKitTestRunner/TestOptions.h:
934         (WTR::TestOptions::hasSameInitializationOptions const):
935         * WebKitTestRunner/ios/TestControllerIOS.mm:
936         (WTR::TestController::platformInitialize):
937         (WTR::TestController::platformResetStateToConsistentValues):
938
939 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
940
941         [Curl] Add Server Trust Evaluation Support.
942         https://bugs.webkit.org/show_bug.cgi?id=191646
943
944         Reviewed by Fujii Hironori.
945
946         Implemented MiniBrowser UI for asking if user trusts the server.
947
948         * MiniBrowser/win/Common.cpp:
949         (askServerTrustEvaluation):
950         (replaceString):
951         * MiniBrowser/win/Common.h:
952         * MiniBrowser/win/MiniBrowserLib.rc:
953         * MiniBrowser/win/MiniBrowserLibResource.h:
954         * MiniBrowser/win/WebKitBrowserWindow.cpp:
955         (createPEMString):
956         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
957         (WebKitBrowserWindow::canTrustServerCertificate):
958         * MiniBrowser/win/WebKitBrowserWindow.h:
959
960 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
961
962         Implement ResizeObserver.
963         https://bugs.webkit.org/show_bug.cgi?id=157743
964
965         Reviewed by Simon Fraser.
966
967         Support resizeObserverEnabled webPreferences.
968
969         * DumpRenderTree/TestOptions.cpp:
970         (TestOptions::TestOptions):
971         * DumpRenderTree/TestOptions.h:
972         * DumpRenderTree/mac/DumpRenderTree.mm:
973         (setWebPreferencesForTestOptions):
974         * DumpRenderTree/win/DumpRenderTree.cpp:
975         (enableExperimentalFeatures):
976         * Scripts/webkitperl/FeatureList.pm:
977         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
978
979 2019-03-28  John Wilander  <wilander@apple.com>
980
981         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
982         https://bugs.webkit.org/show_bug.cgi?id=196281
983         <rdar://problem/48938748>
984
985         Reviewed by Alex Christensen.
986
987         This patch adds the function isStatisticsHasLocalStorage() to the
988         TestRunner. With it, the page can query the WebsiteDataStore in the
989         UI process to make sure that it sees LocalStorage.
990
991         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
992         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
993         (WTR::TestRunner::isStatisticsHasLocalStorage):
994         * WebKitTestRunner/InjectedBundle/TestRunner.h:
995         * WebKitTestRunner/TestController.cpp:
996         (WTR::TestController::isStatisticsHasLocalStorage):
997         * WebKitTestRunner/TestController.h:
998         * WebKitTestRunner/TestInvocation.cpp:
999         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1000
1001 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1002
1003         API::Data::createWithoutCopying should do a null check before calling CFRelease
1004         https://bugs.webkit.org/show_bug.cgi?id=196276
1005         <rdar://problem/48059859>
1006
1007         Reviewed by Alex Christensen.
1008
1009         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1010
1011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1012         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1013         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1014         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1015         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1016         (TestWebKitAPI::TEST):
1017
1018 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1019
1020         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1021         https://bugs.webkit.org/show_bug.cgi?id=186276
1022
1023         Reviewed by Carlos Garcia Campos.
1024
1025         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1026         (webViewLoadChanged):
1027         (testWebResourceGetDataError):
1028         (testWebResourceGetDataEmpty):
1029         (beforeAll):
1030         (webViewloadChanged): Deleted.
1031
1032 2019-03-27  Andy Estes  <aestes@apple.com>
1033
1034         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1035         https://bugs.webkit.org/show_bug.cgi?id=196317
1036
1037         Reviewed by Dan Bernstein.
1038
1039         package-root copies built products into a staging directory using ditto(1), which does not
1040         follow symbolic links as it traverses a directory. Now that the files in
1041         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1042         itself, these become broken links when ditto'd into the staging directory.
1043
1044         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1045
1046         * Scripts/package-root:
1047
1048 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1049
1050         [ews-app] Update display text of Submit for ews analysis
1051         https://bugs.webkit.org/show_bug.cgi?id=196309
1052
1053         Reviewed by Dewei Zhu.
1054
1055         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1056
1057 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1058
1059         run-webkit-tests should check for leaks in WebKit processes
1060         <https://webkit.org/b/193772>
1061         <rdar://problem/46526680>
1062
1063         Reviewed by Ryosuke Niwa.
1064
1065         This works by doing the following:
1066         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1067           The list of child processes are returned one per line:
1068           process.name: pid
1069         - Run the "#LIST CHILD PROCESSES" command just before the
1070           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1071           processes on the ServerProcess object.
1072         - When the `--leaks` switch is handled, run check_for_leaks() on
1073           each child process after the main test harness.
1074
1075         * DumpRenderTree/mac/DumpRenderTree.mm:
1076         (handleControlCommand):
1077         - Use strncmp() instead of strcmp().
1078         - Add support for handling "#LIST CHILD PROCESSES" command.
1079
1080         * Scripts/webkitpy/port/base.py:
1081         (Port.check_for_leaks):
1082         * Scripts/webkitpy/port/darwin.py:
1083         (DarwinPort.check_for_leaks):
1084         - Rename redundant 'process_pid' argument to 'process_id'.
1085
1086         * Scripts/webkitpy/port/driver.py:
1087         (Driver.do_post_tests_work):
1088         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1089           longer the only command this sends to WebKitTestRunner.
1090         - If the `--leaks` switch is present, send the
1091           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1092           result using Port.set_webkit_processes().
1093         (Driver._parse_child_processes_output):
1094         - Add helper method to parse list of child process names and
1095           process IDs returned from WebKitTestRunner.
1096
1097         * Scripts/webkitpy/port/ios_device.py:
1098         (IOSDevicePort.check_for_leaks):
1099         - Rename redundant 'process_pid' argument to 'process_id'.
1100
1101         * Scripts/webkitpy/port/leakdetector.py:
1102         (LeakDetector._parse_leaks_output):
1103         - Return early if there is no leaks_output.
1104         (LeakDetector.check_for_leaks):
1105         - Rename redundant 'process_pid' argument to 'process_id'.
1106
1107         * Scripts/webkitpy/port/server_process.py:
1108         (ServerProcess.__init__):
1109         (ServerProcess.child_processes):
1110         (ServerProcess.set_child_processes):
1111         - Add instance variable to Port to store list of child process
1112           names and process IDs returned from WebKitTestRunner.
1113         (ServerProcess._start):
1114         - Clear self._child_processes.
1115         (ServerProcess.stop):
1116         - If self._child_processes is set, call
1117           self._port.check_for_leaks() for each child process.
1118
1119         * Scripts/webkitpy/port/server_process_unittest.py:
1120         (TrivialMockPort.check_for_leaks):
1121         - Rename redundant 'process_pid' argument to 'process_id'.
1122
1123         * Scripts/webkitpy/port/simulator_process.py:
1124         (SimulatorProcess.stop):
1125         - If self._child_processes is set, call
1126           self._port.check_for_leaks() for each child process.
1127
1128         * Scripts/webkitpy/port/watch_device.py:
1129         (WatchDevicePort.check_for_leaks):
1130         - Rename redundant 'process_pid' argument to 'process_id'.
1131
1132         * WebKitTestRunner/TestController.cpp:
1133         (WTR::TestController::dumpResponse):
1134         - Extract method from findAndDumpWorldLeaks() so that it may be
1135           reused by findAndDumpWebKitProcessIdentifiers().
1136         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1137         - Add method to output process name and process ID of both the
1138           WebContent and Networking processes.
1139         (WTR::TestController::findAndDumpWorldLeaks):
1140         - Fix missing newline in output when there were no abandoned
1141           documents.
1142         - Call dumpResponse() for extracted code.
1143         (WTR::TestController::handleControlCommand):
1144         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1145         - Use strncmp() instead of strcmp().
1146         - Call findAndDumpWebKitProcessIdentifiers() when
1147           "#LIST CHILD PROCESSES" command is sent.
1148         * WebKitTestRunner/TestController.h:
1149         (WTR::TestController::dumpResponse):
1150         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1151         - Declare methods.
1152
1153 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1154
1155         Unreviewed. Add GLib API test cases after r243434.
1156
1157         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1158         (testWebViewActiveURI):
1159         (serverCallback):
1160         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1161         (sendRequestCallback):
1162
1163 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1164
1165         Geolocation request not complete when watch request was started in a different web process
1166         https://bugs.webkit.org/show_bug.cgi?id=195996
1167
1168         Reviewed by Alex Christensen.
1169
1170         Add a test case.
1171
1172         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1173         (TestWebKitAPI::runJavaScriptAlert):
1174         (TestWebKitAPI::TEST):
1175
1176 2019-03-26  Keith Rollin  <krollin@apple.com>
1177
1178         Update the way generate-xcfilelists returns strings from functions
1179         https://bugs.webkit.org/show_bug.cgi?id=195975
1180         <rdar://problem/49040807>
1181
1182         Reviewed by Dean Jackson.
1183
1184         There are places where generate-xcfilelists executes assignments with
1185         statements like:
1186
1187             FOO=$(some_function)
1188
1189         where "some_function" return a string by echoing it. E.g.
1190
1191             some_function()
1192             {
1193                 echo "Hello, World"
1194             }
1195
1196         This is a common idiom, but it has a problem if "some_function" needs
1197         to call "exit" in an attempt to halt the entire script right then and
1198         there. Since "some_function" is called inside of $(), it's being
1199         executed in a sub-shell. Calling exit in that sub-shell simply exits
1200         that shell; it doesn't not exit the outer shell in which the main part
1201         of the script is still running. As such, the main script keeps
1202         executing when the intent was for the script to halt.
1203
1204         The solution to this is to use a different idiom for returning
1205         strings. The one we now is to pass in the name of the variable to
1206         receive the string result:
1207
1208             some_function()
1209             {
1210                 variable_name=$1
1211                 eval $variable_name ="Hello, World"
1212             }
1213
1214         The call site now looks like
1215
1216             some_function FOO
1217
1218         Because there's no invocation of a sub-shell, some_function can now
1219         call "exit" if it wants to, and the entire script will exit at that
1220         point.
1221
1222         * Scripts/generate-xcfilelists:
1223
1224 2019-03-26  Chris Dumez  <cdumez@apple.com>
1225
1226         Add basic layout test coverage for File Picker on iOS
1227         https://bugs.webkit.org/show_bug.cgi?id=196265
1228
1229         Reviewed by Wenson Hsieh.
1230
1231         Add layout test infrastructure to test the file picker on iOS.
1232
1233         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1234         (WTR::UIScriptController::dismissFilePicker):
1235         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1236         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1237         (WTR::UIScriptController::dismissFilePicker):
1238         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1239         * WebKitTestRunner/TestController.cpp:
1240         (WTR::TestController::createWebViewWithOptions):
1241         (WTR::updateTestOptionsFromTestHeader):
1242         * WebKitTestRunner/TestOptions.h:
1243         (WTR::TestOptions::hasSameInitializationOptions const):
1244         * WebKitTestRunner/ios/TestControllerIOS.mm:
1245         (overridePresentViewController):
1246         (WTR::TestController::platformInitialize):
1247         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1248         (WTR::UIScriptController::dismissFilePicker):
1249
1250 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1251
1252         Implement async paste method on UIWKInteractionViewProtocol
1253         https://bugs.webkit.org/show_bug.cgi?id=196267
1254         <rdar://problem/49236346>
1255
1256         Reviewed by Tim Horton.
1257
1258         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1259         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1260         are now a part of all iOS 12 internal SDKs.
1261
1262         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1263
1264         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1265         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1266
1267         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1268         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1269         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1270         * TestWebKitAPI/ios/UIKitSPI.h:
1271
1272 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1273
1274         [ews-build] Use PostgreSQL for ews.webkit.org database
1275         https://bugs.webkit.org/show_bug.cgi?id=196270
1276
1277         Reviewed by Lucas Forschler.
1278
1279         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1280
1281 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1282
1283         [ews] Reset simctl states on reboot
1284         https://bugs.webkit.org/show_bug.cgi?id=196260
1285
1286         Rubber-stamped by Aakash Jain.
1287
1288         * EWSTools/start-queue-mac.sh:
1289
1290 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1291
1292         [ews-build] Use PostgreSQL for ews-build database
1293         https://bugs.webkit.org/show_bug.cgi?id=196229
1294
1295         Reviewed by Lucas Forschler.
1296
1297         * BuildSlaveSupport/ews-build/master.cfg:
1298
1299 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1300
1301         [ews-build] Get master_hostname dynamically in master.cfg
1302         https://bugs.webkit.org/show_bug.cgi?id=196255
1303
1304         Reviewed by Lucas Forschler.
1305
1306         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1307         send events data in test mode.
1308
1309 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-app] Set db_constraint to False for Foreign Keys
1312         https://bugs.webkit.org/show_bug.cgi?id=196252
1313
1314         Reviewed by Lucas Forschler.
1315
1316         * BuildSlaveSupport/ews-app/ews/models/build.py:
1317         * BuildSlaveSupport/ews-app/ews/models/step.py:
1318
1319 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1320
1321         [ews-build] is_test_mode_enabled should default to True
1322         https://bugs.webkit.org/show_bug.cgi?id=196248
1323
1324         Reviewed by Lucas Forschler.
1325
1326         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1327
1328 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1329
1330         [ews-app] Add webkitperl to ENABLED_QUEUES
1331         https://bugs.webkit.org/show_bug.cgi?id=196253
1332
1333         Reviewed by Lucas Forschler.
1334
1335         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1336
1337 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1338
1339         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1340         https://bugs.webkit.org/show_bug.cgi?id=196211
1341         rdar://problem/49110552
1342
1343         Reviewed by Tim Horton.
1344
1345         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1346         Make sure that EventSenderProxy always exists when running tests. We used to create
1347         it when resetting before the first test, which is a bit too late.
1348
1349         * WebKitTestRunner/TestController.h:
1350         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1351         (WTR::TestController::platformCreateWebView):
1352         (WTR::TestController::platformCreateOtherPage):
1353         (WTR::TestController::finishCreatingPlatformWebView):
1354         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1355         (WTR::PlatformWebView::PlatformWebView):
1356         Moved some code that made NSWindow use NSEvent during web view creation. We may
1357         need to move more if some other case us found, but this is enough for now.
1358
1359 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1360
1361         Unreviewed. Fix typo in GLib geolocation API after r243285.
1362
1363         gelocation -> geolocation.
1364
1365         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1366         (testGeolocationManagerWatchPosition):
1367
1368 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1369
1370         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1371         https://bugs.webkit.org/show_bug.cgi?id=196213
1372
1373         Reviewed by Geoff Garen.
1374
1375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1376         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1377         (credentialWithIdentityAndKeychainPath):
1378         (-[ChallengeDelegate webView:didFinishNavigation:]):
1379         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1380         (TestWebKitAPI::TEST):
1381
1382 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1383
1384         Expected shouldn't assume its contained types are copyable
1385         https://bugs.webkit.org/show_bug.cgi?id=195986
1386
1387         Reviewed by JF Bastien.
1388
1389         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1390         (TestWebKitAPI::NonCopyable::operator== const):
1391         (TestWebKitAPI::NonCopyable::operator!= const):
1392         (TestWebKitAPI::TEST):
1393
1394 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1395
1396         Remove some now-unnecessary dynamic class lookup
1397         https://bugs.webkit.org/show_bug.cgi?id=196237
1398
1399         Reviewed by Simon Fraser.
1400
1401         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1402         (makeRequest):
1403         (TEST):
1404
1405 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1406
1407         Unreviewed, rolling out r243450.
1408
1409         AppleWin and WinCairo port builds get broken.
1410
1411         Reverted changeset:
1412
1413         "Add test for fix of #196095"
1414         https://bugs.webkit.org/show_bug.cgi?id=196097
1415         https://trac.webkit.org/changeset/243450
1416
1417 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1418
1419         Unreviewed, rolling out r243465.
1420         https://bugs.webkit.org/show_bug.cgi?id=196226
1421
1422         the test doesn't build (Requested by thorton on #webkit).
1423
1424         Reverted changeset:
1425
1426         "Do not terminate the NetworkProcess if a third party
1427         application sends a NSCredential with a SecIdentityRef"
1428         https://bugs.webkit.org/show_bug.cgi?id=196213
1429         https://trac.webkit.org/changeset/243465
1430
1431 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1432
1433         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1434         https://bugs.webkit.org/show_bug.cgi?id=196213
1435
1436         Reviewed by Geoff Garen.
1437
1438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1439         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1440         (credentialWithIdentityAndKeychainPath):
1441         (-[ChallengeDelegate webView:didFinishNavigation:]):
1442         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1443         (TestWebKitAPI::TEST):
1444
1445 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1446
1447         [ews-build] Gracefully handle missing patch_id in events
1448         https://bugs.webkit.org/show_bug.cgi?id=196216
1449
1450         Reviewed by Lucas Forschler.
1451
1452         * BuildSlaveSupport/ews-build/events.py:
1453
1454 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1455
1456         [ews-build] use lz4 compression for improving buildbot performance
1457         https://bugs.webkit.org/show_bug.cgi?id=196155
1458
1459         Reviewed by Lucas Forschler.
1460
1461         * BuildSlaveSupport/ews-build/master.cfg:
1462
1463 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1464
1465         Pull some API testing helper methods out of TestWKWebView
1466         https://bugs.webkit.org/show_bug.cgi?id=196212
1467
1468         Reviewed by Tim Horton.
1469
1470         Refactor some more API testing utility methods, so that they can be used in
1471         tests that do not use TestWKWebView.
1472
1473         * TestWebKitAPI/cocoa/TestWKWebView.h:
1474         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1475         (-[WKWebView loadTestPageNamed:]):
1476         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1477         (-[WKWebView synchronouslyLoadHTMLString:]):
1478         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1479         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1480         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1481         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1482         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1483
1484 2019-03-25  Jer Noble  <jer.noble@apple.com>
1485
1486         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1487         https://bugs.webkit.org/show_bug.cgi?id=196097
1488
1489         Reviewed by Eric Carlson.
1490
1491         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1492
1493         * DumpRenderTree/mac/DumpRenderTree.mm:
1494         (resetWebPreferencesToConsistentValues):
1495         * WebKitTestRunner/TestController.cpp:
1496         (WTR::TestController::resetPreferencesToConsistentValues):
1497
1498 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1499
1500         Pull IPadUserInterfaceSwizzler out into a separate header file
1501         https://bugs.webkit.org/show_bug.cgi?id=196193
1502
1503         Reviewed by Anders Carlsson.
1504
1505         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1506         be used in other API tests.
1507
1508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1509         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1510         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1511         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1512         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1513         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1514         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1515
1516 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1517
1518         Remove NavigatorContentUtils in WebCore/Modules
1519         https://bugs.webkit.org/show_bug.cgi?id=196070
1520
1521         Reviewed by Alex Christensen.
1522
1523         NavigatorContentUtils was to support the custom scheme spec [1].
1524         However, in WebKit side, no port has supported the feature in
1525         WebKit layer after EFL port was removed. So there has been the
1526         only IDL implementation of the NavigatorContentUtils in WebCore.
1527         So we don't need to keep the implementation in WebCore anymore.
1528
1529         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1530
1531         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1532
1533 2019-03-24  Andy Estes  <aestes@apple.com>
1534
1535         [watchOS] Remove unused Proximity Networking code
1536         https://bugs.webkit.org/show_bug.cgi?id=196188
1537
1538         Reviewed by Tim Horton.
1539
1540         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1541         (TEST):
1542
1543 2019-03-23  Keith Miller  <keith_miller@apple.com>
1544
1545         Refactor clz/ctz and fix getLSBSet.
1546         https://bugs.webkit.org/show_bug.cgi?id=196162
1547
1548         Reviewed by Saam Barati.
1549
1550         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1551
1552         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1553         (TestWebKitAPI::TEST):
1554
1555 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1556
1557         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1558         https://bugs.webkit.org/show_bug.cgi?id=196143
1559
1560         Reviewed by Michael Catanzaro.
1561
1562         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1563         directories.
1564
1565         * Scripts/webkitpy/style/checkers/cpp.py:
1566         (check_identifier_name_in_declaration):
1567         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1568         (WebKitStyleTest.test_names):
1569
1570 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1571
1572         [Flatpak] Manifest expanding fails for qt WPE extension
1573         https://bugs.webkit.org/show_bug.cgi?id=196148
1574
1575         Reviewed by Alex Christensen.
1576
1577         * flatpak/flatpakutils.py:
1578         (expand_submodules_recurse): The last recurse manifest expand
1579         iteration might lead to a single module so take it into account
1580         and don't try to recurse further.
1581
1582 2019-03-22  Chris Dumez  <cdumez@apple.com>
1583
1584         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1585         https://bugs.webkit.org/show_bug.cgi?id=195348
1586         <rdar://problem/48622090>
1587
1588         Reviewed by Alex Christensen.
1589
1590         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1591         to NO when test.options().shouldIgnoreMetaViewport is false.
1592
1593         * WebKitTestRunner/ios/TestControllerIOS.mm:
1594         (WTR::TestController::platformConfigureViewForTest):
1595
1596 2019-03-22  Chris Dumez  <cdumez@apple.com>
1597
1598         Prewarmed processes should be usable with any website data store
1599         https://bugs.webkit.org/show_bug.cgi?id=196104
1600
1601         Reviewed by Alex Christensen.
1602
1603         Add API test coverage.
1604
1605         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1606         (runInitialWarmedProcessUsedTest):
1607         (TEST):
1608
1609 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1610
1611         Back out local changes to Alex's Subversion working directory
1612
1613         They were accidentally committed.
1614
1615         * Scripts/webkitpy/common/system/abstractexecutive.py:
1616         (AbstractExecutive.wait_newest):
1617         * Scripts/webkitpy/common/system/executive.py:
1618         (Executive.running_pids):
1619         * Scripts/webkitpy/common/system/executive_mock.py:
1620         (MockExecutive.running_pids):
1621         * Scripts/webkitpy/common/system/executive_unittest.py:
1622         (ExecutiveTest.serial_test_running_pids):
1623         * Scripts/webkitpy/port/darwin.py:
1624         (DarwinPort.check_for_leaks):
1625         * Scripts/webkitpy/port/leakdetector.py:
1626         (LeakDetector.check_for_leaks):
1627         - This was the hack attached to Bug 193772.
1628
1629         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1630         (+[WebKitTestRunnerEvent mouseLocation]):
1631         - This works around a crash on an internal build.
1632
1633 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1634
1635         Fix the build after r243354
1636         https://bugs.webkit.org/show_bug.cgi?id=196138
1637         <rdar://problem/49145951>
1638
1639         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1640         (TEST):
1641         * TestWebKitAPI/ios/UIKitSPI.h:
1642
1643 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1644
1645         Adopt UIWKDocumentContext
1646         https://bugs.webkit.org/show_bug.cgi?id=196040
1647         <rdar://problem/48642440>
1648
1649         Reviewed by Ryosuke Niwa.
1650
1651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1652         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1653         (makeRequest):
1654         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1655         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1656         (applyStyle):
1657         (TEST):
1658         Add tests for UIWKDocumentContext.
1659
1660         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1661         (TEST):
1662         (recursiveFindWKContentView): Deleted.
1663         * TestWebKitAPI/cocoa/TestWKWebView.h:
1664         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1665         (recursiveFindWKContentView):
1666         (-[TestWKWebView wkContentView]):
1667         * TestWebKitAPI/ios/UIKitSPI.h:
1668         Share the WKContentView finding code between tests.
1669
1670 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1671
1672         [iOS WK2] Turn on async overflow scrolling by default
1673         https://bugs.webkit.org/show_bug.cgi?id=196011
1674         rdar://problem/48453859
1675
1676         Reviewed by Antti Koivisto.
1677         
1678         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1679         since so many basic layout tests have different results when compositing is triggered for
1680         overflow.
1681         
1682         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1683
1684         * WebKitTestRunner/TestController.cpp:
1685         (WTR::TestController::resetPreferencesToConsistentValues):
1686
1687 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1688
1689         [ews-build] Retry API test in case of failures
1690         https://bugs.webkit.org/show_bug.cgi?id=196004
1691
1692         Reviewed by Lucas Forschler.
1693
1694         * BuildSlaveSupport/ews-build/steps.py:
1695         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1696         (CompileWebKitToT.doStepIf): Ditto.
1697         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1698         (ReRunAPITests): Re-run API tests.
1699         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1700         (RunAPITestsWithoutPatch): Run API tests without patch.
1701         (RunAPITestsWithoutPatch.doStepIf):
1702         (RunAPITestsWithoutPatch.hideStepIf):
1703         (RunAPITestsWithoutPatch.evaluateCommand):
1704         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1705         (AnalyzeAPITestsResults.start):
1706         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1707         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1708         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1709         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1710
1711 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1712
1713         [ews-build] Update queues configurations
1714         https://bugs.webkit.org/show_bug.cgi?id=196074
1715
1716         Reviewed by Dewei Zhu.
1717
1718         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1719         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1720
1721 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1722
1723         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1724         https://bugs.webkit.org/show_bug.cgi?id=195680
1725         <rdar://problem/48903534>
1726
1727         Unreviewed infrastructure fix.
1728
1729         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1730         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1731
1732 2019-03-21  Andy Estes  <aestes@apple.com>
1733
1734         [iOS] Apple Pay should be available in documents with no user agent scripts
1735         https://bugs.webkit.org/show_bug.cgi?id=196061
1736         <rdar://problem/48649391>
1737
1738         Reviewed by Brady Eidson.
1739
1740         Added API tests and related infrastructure.
1741
1742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1743         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1744         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1745         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1746         (TestWebKitAPI::TEST):
1747         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1748         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1749         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1750         * TestWebKitAPI/cocoa/TestProtocol.mm:
1751         (-[TestProtocol startLoading]):
1752         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1753         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1754         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1755         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1756
1757 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1758
1759         REGRESSSION (r243297): webkitpy tests broken
1760         https://bugs.webkit.org/show_bug.cgi?id=196108
1761
1762         Reviewed by Aakash Jain.
1763
1764         r243297 updated contributors.json, which broke a few unit tests.
1765
1766         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1767         (IRCCommandTest.test_whois):
1768         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1769
1770 2019-03-21  Chris Dumez  <cdumez@apple.com>
1771
1772         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1773         https://bugs.webkit.org/show_bug.cgi?id=196041
1774         <rdar://problem/49083230>
1775
1776         Reviewed by Alex Christensen.
1777
1778         Add API test coverage.
1779
1780         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1781         (TEST):
1782
1783 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1784
1785         Add SPI to inform applications of WKContentRuleList actions
1786         https://bugs.webkit.org/show_bug.cgi?id=195965
1787         <rdar://problem/42664365>
1788
1789         Reviewed by Geoff Garen.
1790
1791         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1792         (TestWebKitAPI::allActionsForResourceLoad):
1793         (TestWebKitAPI::testRequest):
1794         (TestWebKitAPI::TEST_F):
1795         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1796         (Notification::description):
1797         (Notification::operator== const):
1798         (toVector):
1799         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1800         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1801         (makeContentRuleList):
1802         (TEST):
1803         (makeWarnContentRuleList): Deleted.
1804
1805 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1806
1807         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1808         https://bugs.webkit.org/show_bug.cgi?id=196088
1809
1810         Reviewed by Brian Burg.
1811
1812         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1813         Support checks when only one platform is specified. Also deprecate macosx() and
1814         force the use of macos() instead.
1815
1816         * Scripts/webkitpy/style/checkers/cpp.py:
1817         (check_min_versions_of_wk_api_available):
1818         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1819         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1820
1821 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1822
1823         Update status inactive committers' status to 'contributor'.
1824
1825         * Scripts/webkitpy/common/config/contributors.json:
1826
1827 2019-03-21  Xan Lopez  <xan@igalia.com>
1828
1829         [JSC][x86] Drop support for x87 floating point
1830         https://bugs.webkit.org/show_bug.cgi?id=194853
1831
1832         Reviewed by Don Olmstead.
1833
1834         Force SSE2 on x86/32bit builds.
1835
1836         * Scripts/webkitdirs.pm:
1837         (generateBuildSystemFromCMakeProject):
1838
1839 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1840
1841         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1842         https://bugs.webkit.org/show_bug.cgi?id=196073
1843
1844         Reviewed by Michael Catanzaro.
1845
1846         Add test cases to check functions and constructors with no arguments but receiving user data.
1847
1848         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1849         (checkUserData):
1850         (testJSCFunction):
1851         (fooCreateWithUserData):
1852         (testJSCClass):
1853
1854 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1855
1856         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1857
1858         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1859
1860         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1861
1862 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1863
1864         [GTK][WPE] Add API to provide geolocation information
1865         https://bugs.webkit.org/show_bug.cgi?id=195940
1866
1867         Reviewed by Michael Catanzaro.
1868
1869         Add a new test to check the new API.
1870
1871         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1872         (testGeolocationManagerCurrentPosition):
1873         (testGeolocationManagerWatchPosition):
1874         (beforeAll):
1875         (afterAll):
1876         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1877         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1878         (beforeAll): Ditto.
1879         * TestWebKitAPI/glib/CMakeLists.txt:
1880
1881 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1882
1883         [GLib] Returning G_TYPE_OBJECT from a method does not work
1884         https://bugs.webkit.org/show_bug.cgi?id=195574
1885
1886         Reviewed by Michael Catanzaro.
1887
1888         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1889
1890         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1891         (getGFile):
1892         (getParent):
1893         (createGString):
1894         (getGString):
1895         (getGStringCopyWillRaise):
1896         (getGStringCopy):
1897         (getGStringStr):
1898         (getGStringLen):
1899         (freeGString):
1900         (testJSCClass):
1901
1902 2019-03-20  Saam Barati  <sbarati@apple.com>
1903
1904         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1905         https://bugs.webkit.org/show_bug.cgi?id=195721
1906
1907         Reviewed by Filip Pizlo.
1908
1909         * Scripts/run-javascriptcore-tests:
1910
1911 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1912
1913         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1914         https://bugs.webkit.org/show_bug.cgi?id=196049
1915
1916         Reviewed by Tim Horton.
1917
1918         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1919         overflow scrolling in general, so rename it.
1920
1921         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1922
1923 2019-03-20  Daniel Bates  <dabates@apple.com>
1924
1925         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1926         https://bugs.webkit.org/show_bug.cgi?id=196031
1927         <rdar://problem/49078172>
1928
1929         Reviewed by Tim Horton.
1930
1931         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1932         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1933         same code path used when the Done button is pressed to dismiss the <select> picker.
1934
1935         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1936         (TestWebKitAPI::TEST):
1937
1938 2019-03-20  Chris Dumez  <cdumez@apple.com>
1939
1940         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1941         https://bugs.webkit.org/show_bug.cgi?id=196029
1942         <rdar://problem/48954651>
1943
1944         Reviewed by Tim Horton.
1945
1946         Add API test coverage.
1947
1948         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1949
1950 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1951
1952         [ews-build] Improve failure summary string for ApplyPatch step
1953         https://bugs.webkit.org/show_bug.cgi?id=195995
1954
1955         Reviewed by Alexey Proskuryakov.
1956
1957         * BuildSlaveSupport/ews-build/steps.py:
1958         (ApplyPatch.getResultSummary): Override getResultSummary.
1959
1960 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1961
1962         AX: Implement support for new meter ARIA role
1963         https://bugs.webkit.org/show_bug.cgi?id=195966
1964
1965         Reviewed by Chris Fleizach.
1966
1967         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1968         to AXLevelIndicator.
1969
1970         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1971
1972 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1973
1974         [WebAuthN] Implement FIDO AppID extension
1975         https://bugs.webkit.org/show_bug.cgi?id=143491
1976         <rdar://problem/48298273>
1977
1978         Reviewed by Brent Fulgham.
1979
1980         Add a test that covers the new flag of convertToU2fSignCommand.
1981
1982         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1983         (TestWebKitAPI::TEST):
1984         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1985         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1986         (TestWebKitAPI::TEST):
1987
1988 2019-03-19  Keith Rollin  <krollin@apple.com>
1989
1990         Add support for more platforms to generate-xcfilelists
1991         https://bugs.webkit.org/show_bug.cgi?id=195977
1992
1993         Reviewed by Alexey Proskuryakov.
1994
1995         generate-xcfilelists incorrectly complains when involved with building
1996         WebKit for iphonesimulator:
1997
1998             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1999             …
2000             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2001
2002         Address this by teaching generate-xcfilelists about more platforms.
2003
2004         * Scripts/generate-xcfilelists:
2005
2006 2019-03-19  John Wilander  <wilander@apple.com>
2007
2008         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2009         https://bugs.webkit.org/show_bug.cgi?id=195923
2010         <rdar://problem/49001272>
2011
2012         Reviewed by Alex Christensen.
2013
2014         This patch does the following to the TestRunner:
2015         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2016         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2017         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2018
2019         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2020         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2021         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2022         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2023         * WebKitTestRunner/TestController.cpp:
2024         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2025         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2026         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2027         * WebKitTestRunner/TestController.h:
2028         * WebKitTestRunner/TestInvocation.cpp:
2029         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2030
2031 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2032
2033         [CMake] Support more clang and gcc sanitizers
2034         https://bugs.webkit.org/show_bug.cgi?id=195956
2035
2036         Reviewed by Michael Catanzaro.
2037
2038         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2039
2040 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2041
2042         [ews-build] Improve summary for PrintConfiguration step
2043         https://bugs.webkit.org/show_bug.cgi?id=195945
2044
2045         Reviewed by Lucas Forschler.
2046
2047         * BuildSlaveSupport/ews-build/steps.py:
2048         (PrintConfiguration.getResultSummary): Override getResultSummary.
2049
2050 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2051
2052         [ews-build] Improve summary for CheckOutSource step
2053         https://bugs.webkit.org/show_bug.cgi?id=195963
2054
2055         Reviewed by Lucas Forschler.
2056
2057         * BuildSlaveSupport/ews-build/steps.py:
2058         (CheckOutSource.getResultSummary):
2059
2060 2019-03-19  Daniel Bates  <dabates@apple.com>
2061
2062         [iOS] Focus not preserved when switching between tabs
2063         https://bugs.webkit.org/show_bug.cgi?id=195820
2064         <rdar://problem/43614450>
2065
2066         Reviewed by Brent Fulgham.
2067
2068         Add tests to ensure that we restore focus when resigning and becoming first responder.
2069
2070         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2071         (TestWebKitAPI::TEST):
2072
2073 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2074
2075         Make WTFLogChannelState and WTFLogLevel enum classes
2076         https://bugs.webkit.org/show_bug.cgi?id=195904
2077
2078         Reviewed by Eric Carlson.
2079
2080         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2081         (TestWebKitAPI::TEST_F):
2082
2083 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2084
2085         [GStreamer][EME] Backported mssdemux protection data crash fix
2086         https://bugs.webkit.org/show_bug.cgi?id=195918
2087
2088         Reviewed by Philippe Normand.
2089
2090         * gstreamer/jhbuild.modules:
2091         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2092
2093 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2094
2095         Unreviewed, rolling out r243132.
2096
2097         Broke GTK build
2098
2099         Reverted changeset:
2100
2101         "Make WTFLogChannelState and WTFLogLevel enum classes"
2102         https://bugs.webkit.org/show_bug.cgi?id=195904
2103         https://trac.webkit.org/changeset/243132
2104
2105 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2106
2107         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2108
2109         * Scripts/webkitdirs.pm:
2110         (builtDylibPathForName): Adjust the shared library name that's changed
2111         with the API version bump in r243073.
2112
2113 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2114
2115         Make WTFLogChannelState and WTFLogLevel enum classes
2116         https://bugs.webkit.org/show_bug.cgi?id=195904
2117
2118         Reviewed by Eric Carlson.
2119
2120         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2121         (TestWebKitAPI::TEST_F):
2122
2123 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2124
2125         Disable flaky test added in r2431100
2126         https://webkit.org/b/195785
2127
2128         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2129         (TestWebKitAPI::TEST):
2130         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2131
2132 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2133
2134         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2135         https://bugs.webkit.org/show_bug.cgi?id=195916
2136
2137         Reviewed by Tim Horton.
2138
2139         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2140         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2141
2142 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2143
2144         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2145
2146         * Scripts/webkitpy/common/config/contributors.json:
2147
2148 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2149
2150         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2151         https://bugs.webkit.org/show_bug.cgi?id=195785
2152
2153         Reviewed by Geoffrey Garen.
2154
2155         * TestWebKitAPI/TCPServer.cpp: Added.
2156         (TestWebKitAPI::TCPServer::TCPServer):
2157         (TestWebKitAPI::TCPServer::~TCPServer):
2158         (TestWebKitAPI::TCPServer::socketBindListen):
2159         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2160         * TestWebKitAPI/TCPServer.h: Added.
2161         (TestWebKitAPI::TCPServer::port const):
2162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2163         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2164         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2165         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2166         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2167         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2168         (TestWebKitAPI::respondSlowly):
2169         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2170         (TestWebKitAPI::downloadAtRate):
2171         (TestWebKitAPI::TEST):
2172
2173 2019-03-18  Saam Barati  <sbarati@apple.com>
2174
2175         Add a plan file for JetStream 2
2176         https://bugs.webkit.org/show_bug.cgi?id=190734
2177
2178         Reviewed by Mark Lam.
2179
2180         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2181
2182 2019-03-18  Chris Dumez  <cdumez@apple.com>
2183
2184         Delay WebProcess launch until a load is triggered in a Web view
2185         https://bugs.webkit.org/show_bug.cgi?id=195758
2186         <rdar://problem/48126013>
2187
2188         Reviewed by Geoff Garen.
2189
2190         Add API test coverage. Also update some existing API tests to not expect
2191         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2192
2193         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2194         (TestWebKitAPI::TEST):
2195         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2196         (TestWebKitAPI::TEST):
2197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2198         (TEST):
2199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2200         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2201         (TEST):
2202         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2203         (TEST):
2204         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2205
2206 2019-03-18  Xan Lopez  <xan@igalia.com>
2207
2208         [CMake] Prevent potential warning when determining $architecture
2209         https://bugs.webkit.org/show_bug.cgi?id=195891
2210
2211         Reviewed by Michael Catanzaro.
2212
2213         It's possible for generateBuildSystemForCMakeProject to be called
2214         before determineArchitecture() is ever called. This will make the
2215         first eq check with $architecture to be bogus (and print a
2216         warning). Change that to an eq check with architecture(), which
2217         implicitly calls determineArchitecture() if needed, and change all
2218         the other similar cases in the method in the same way to prevent
2219         future bugs like this one.
2220
2221         * Scripts/webkitdirs.pm:
2222         (generateBuildSystemFromCMakeProject):
2223
2224 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2225
2226         [WPE] Tarballs generated with “make dist” cannot build documentation
2227         https://bugs.webkit.org/show_bug.cgi?id=195885
2228
2229         Reviewed by Carlos Garcia Campos.
2230
2231         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2232
2233 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2234
2235         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2236         https://bugs.webkit.org/show_bug.cgi?id=195883
2237
2238         Reviewed by Carlos Garcia Campos.
2239
2240         * gtkdoc/gtkdoc.py:
2241         (GTKDoc._run_command): When commands fail to run, include the full command line for
2242         the program invocation and the output it has generated on the standard error stream.
2243
2244 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2245
2246         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2247         https://bugs.webkit.org/show_bug.cgi?id=195786
2248
2249         Reviewed by Philippe Normand.
2250
2251         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2252         * wpe/jhbuild.modules: Ditto.
2253
2254 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2255
2256         [ews-build] Don't run clean builds on EWS builders
2257         https://bugs.webkit.org/show_bug.cgi?id=195851
2258
2259         Reviewed by Geoffrey Garen.
2260
2261         * BuildSlaveSupport/ews-build/factories.py:
2262
2263 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2264
2265         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2266         https://bugs.webkit.org/show_bug.cgi?id=195849
2267
2268         Reviewed by Chris Dumez.
2269
2270         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2271
2272         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2273         (runWebsiteDataStoreCustomPaths):
2274
2275 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2276
2277         webkitpy: Upload test results
2278         https://bugs.webkit.org/show_bug.cgi?id=195755
2279         <rdar://problem/48896182>
2280
2281         Reviewed by Aakash Jain.
2282
2283         Establish a new format for uploading results that is not tied to layout tests, apply
2284         that format to webkitpy tests.
2285
2286         * Scripts/webkitpy/common/checkout/scm/git.py:
2287         (Git.native_branch): Return what branch the current checkout is on.
2288         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2289         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2290         * Scripts/webkitpy/common/checkout/scm/svn.py:
2291         (SVN.native_branch): Ditto.
2292         * Scripts/webkitpy/common/system/platforminfo.py:
2293         (PlatformInfo.build_version): Return a build version for Mac.
2294         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2295         (MockPlatformInfo.__init__):
2296         (MockPlatformInfo.build_version):
2297         * Scripts/webkitpy/results: Added.
2298         * Scripts/webkitpy/results/__init__.py: Added.
2299         * Scripts/webkitpy/results/options.py: Added.
2300         (upload_options): OptParse list for upload options.
2301         * Scripts/webkitpy/results/upload.py: Added.
2302         (Upload): Class which enforces the upload format expected by the results server.
2303         (Upload.Expectations):
2304         (Upload.create_configuration):
2305         (Upload.create_commit):
2306         (Upload.create_details):
2307         (Upload.create_run_stats):
2308         (Upload.create_test_result):
2309         (Upload.__init__):
2310         (Upload.Encoder): Encode Upload object as json.
2311         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2312         * Scripts/webkitpy/results/upload_unittest.py: Added.
2313         * Scripts/webkitpy/test/main.py:
2314         (Tester._parse_args): Add upload arguments.
2315         (Tester._run_tests): Allow results to be uploaded.
2316         * Scripts/webkitpy/test/runner.py:
2317         (Runner.__init__): Record which tests were run, rather than just counting them.
2318         (Runner.handle):
2319         * Scripts/webkitpy/test/runner_unittest.py:
2320         (RunnerTest.test_run):
2321         * Scripts/webkitpy/thirdparty/__init__.py:
2322         (AutoinstallImportHook.find_module): Add requests auto-install.
2323         (AutoinstallImportHook._install_requests):
2324         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2325         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2326
2327 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2328
2329         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2330         https://bugs.webkit.org/show_bug.cgi?id=195810
2331
2332         Reviewed by Tim Horton.
2333
2334         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2335         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2336         ending certain layout tests.
2337
2338         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2339         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2340         (-[TestRunnerWKWebView dealloc]):
2341         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2342
2343         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2344         helper method when destroying the web view, and when resetting state between tests.
2345
2346         * WebKitTestRunner/ios/TestControllerIOS.mm:
2347         (WTR::TestController::platformResetStateToConsistentValues):
2348
2349         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2350
2351 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2352
2353         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2354         https://bugs.webkit.org/show_bug.cgi?id=190350
2355         <rdar://problem/45089503>
2356
2357         Reviewed by Geoffrey Garen.
2358
2359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2360         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2361         (TEST):
2362         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2363         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2364         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2365         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2366         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2367         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2368         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2369         (runTest):
2370         (createDirectories):
2371         (TEST):
2372         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2373         (TEST):
2374         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2375         (TEST):
2376
2377 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2378
2379         Add support to WebPage for getting the contents as an attributed string.
2380         https://bugs.webkit.org/show_bug.cgi?id=195636
2381         rdar://problem/45055697
2382
2383         Reviewed by Tim Horton.
2384
2385         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2386         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2387
2388 2019-03-15  Chris Dumez  <cdumez@apple.com>
2389
2390         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2391         https://bugs.webkit.org/show_bug.cgi?id=195747
2392
2393         Reviewed by Geoff Garen.
2394
2395         Add API test coverage.
2396
2397         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2398
2399 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2400
2401         Unreviewed, rolling out r242952.
2402
2403         Causing API failures on iOS Simulator
2404
2405         Reverted changeset:
2406
2407         "[PSON] Make sure the WebProcessCache is leverage when
2408         relaunching a process after termination"
2409         https://bugs.webkit.org/show_bug.cgi?id=195747
2410         https://trac.webkit.org/changeset/242952
2411
2412 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2413
2414         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2415         https://bugs.webkit.org/show_bug.cgi?id=195740
2416
2417         Reviewed by Ross Kirsling.
2418
2419         window.open doesn't work for WebKitBrowserWindow because it is not
2420         implemented yet.
2421
2422         1. Implemented createNewPage callback of WKPageUIClient.
2423         2. Changed MainWindow to take a BrowserWindow factory function
2424           instead of BrowserWindowType to be flexible to create
2425           BrowserWindow with extra settings.
2426         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2427           because it is not relevant with MainWindow anymore.
2428
2429         * MiniBrowser/win/Common.cpp:
2430         (parseCommandLine):
2431         * MiniBrowser/win/Common.h:
2432         (CommandLineOptions::CommandLineOptions):
2433         * MiniBrowser/win/MainWindow.cpp:
2434         (MainWindow::MainWindow):
2435         (MainWindow::create):
2436         (MainWindow::init):
2437         (MainWindow::WndProc):
2438         * MiniBrowser/win/MainWindow.h:
2439         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2440         (PrintWebUIDelegate::createWebViewWithRequest):
2441         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2442         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2443         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2444         (WebKitBrowserWindow::updateProxySettings):
2445         (WebKitBrowserWindow::createNewPage):
2446         * MiniBrowser/win/WebKitBrowserWindow.h:
2447         * MiniBrowser/win/WinMain.cpp:
2448         (wWinMain):
2449
2450 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2451
2452         Make it possible to test scrolling tree layer manipulation more easily
2453         https://bugs.webkit.org/show_bug.cgi?id=195780
2454
2455         Reviewed by Tim Horton.
2456         
2457         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2458         cuts off communication of scrolling tree scrolls back to the web process
2459         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2460         allows tests to trigger scrolls which run the scrolling tree layer positioning
2461         logic, but never get another commit from the web process that might mask
2462         scrolling tree bugs.
2463         
2464         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2465         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2466         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2467
2468         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2469         (WTR::UIScriptController::scrollUpdatesDisabled const):
2470         (WTR::UIScriptController::setScrollUpdatesDisabled):
2471         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2472         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2473         (WTR::UIScriptController::scrollUpdatesDisabled const):
2474         (WTR::UIScriptController::setScrollUpdatesDisabled):
2475         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2476         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2477         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2478         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2479         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2480         * WebKitTestRunner/ios/TestControllerIOS.mm:
2481         (WTR::TestController::platformResetStateToConsistentValues):
2482         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2483         (WTR::UIScriptController::scrollUpdatesDisabled const):
2484         (WTR::UIScriptController::setScrollUpdatesDisabled):
2485
2486 2019-03-14  Youenn Fablet  <youenn@apple.com>
2487
2488         Move IDB storage in private browsing mode to NetworkProcess
2489         https://bugs.webkit.org/show_bug.cgi?id=195602
2490
2491         Reviewed by Brady Eidson.
2492
2493         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2494         (TEST):
2495
2496 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2497
2498         [ews-build] Make descriptionDone messages more readable
2499         https://bugs.webkit.org/show_bug.cgi?id=195760
2500
2501         Reviewed by Lucas Forschler.
2502
2503         * BuildSlaveSupport/ews-build/steps.py:
2504         * BuildSlaveSupport/ews-build/steps_unittest.py:
2505
2506 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2507
2508         [ews-build] Generate status-bubble hover-over messages
2509         https://bugs.webkit.org/show_bug.cgi?id=195680
2510
2511         Reviewed by Lucas Forschler.
2512
2513         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2514         (StatusBubble):
2515         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2516         on hover-over.
2517         (StatusBubble._iso_time):
2518         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2519         hover-over message.
2520         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2521
2522 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2523
2524         [ews-app] Gracefully handle the case when state_string is None
2525         https://bugs.webkit.org/show_bug.cgi?id=195753
2526
2527         Reviewed by Lucas Forschler.
2528
2529         * BuildSlaveSupport/ews-app/ews/models/build.py:
2530         * BuildSlaveSupport/ews-app/ews/models/step.py:
2531
2532 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2533
2534         [ews-app] Status bubble display pending for currently running build step
2535         https://bugs.webkit.org/show_bug.cgi?id=195744
2536
2537         Reviewed by Lucas Forschler.
2538
2539         * BuildSlaveSupport/ews-build/events.py:
2540         (Events.stepStarted): If state_string is pending, replace it with step name.
2541
2542 2019-03-14  Chris Dumez  <cdumez@apple.com>
2543
2544         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2545         https://bugs.webkit.org/show_bug.cgi?id=195750
2546
2547         Reviewed by Geoffrey Garen.
2548
2549         Add API test coverage.
2550
2551         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2552         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2553         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2554         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2555
2556 2019-03-14  Chris Dumez  <cdumez@apple.com>
2557
2558         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2559         https://bugs.webkit.org/show_bug.cgi?id=195747
2560
2561         Reviewed by Geoff Garen.
2562
2563         Add API test coverage.
2564
2565         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2566
2567 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2568
2569         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2570         https://bugs.webkit.org/show_bug.cgi?id=195725
2571         <rdar://problem/48545062>
2572
2573         Reviewed by Tim Horton.
2574
2575         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2576         handler is nil.
2577
2578         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2579         (TestWebKitAPI::TEST):
2580
2581 2019-03-13  Sam Weinig  <sam@webkit.org>
2582
2583         Add utility function to allow easy reverse range-based iteration of a container
2584         https://bugs.webkit.org/show_bug.cgi?id=195542
2585
2586         Reviewed by Antti Koivisto.
2587
2588         * TestWebKitAPI/CMakeLists.txt:
2589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2590         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2591         (TestWebKitAPI::TEST):
2592         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2593
2594 2019-03-13  Chris Dumez  <cdumez@apple.com>
2595
2596         Use a ServiceWorker process per registrable domain
2597         https://bugs.webkit.org/show_bug.cgi?id=195649
2598
2599         Reviewed by Youenn Fablet.
2600
2601         Update API test coverage.
2602
2603         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2604
2605 2019-03-13  Chris Dumez  <cdumez@apple.com>
2606
2607         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2608         https://bugs.webkit.org/show_bug.cgi?id=195684
2609         <rdar://problem/48294714>
2610
2611         Reviewed by Antti Koivisto.
2612
2613         Add API test coverage.
2614
2615         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2616
2617 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2618
2619         [ews-app] Remove unused patch view
2620         https://bugs.webkit.org/show_bug.cgi?id=195669
2621
2622         Reviewed by Lucas Forschler.
2623
2624         * BuildSlaveSupport/ews-app/ews/urls.py:
2625         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2626
2627 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2628
2629         [ews-app] Use Buildbot result code variables
2630         https://bugs.webkit.org/show_bug.cgi?id=195668
2631
2632         Reviewed by Alexey Proskuryakov.
2633
2634         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2635         (Buildbot): Added Buildbot result code variables.
2636         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2637         (StatusBubble._build_bubble): Used Buildbot result code variables.
2638
2639 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2640
2641         [Flatpak] Expand submodule recursively
2642         https://bugs.webkit.org/show_bug.cgi?id=195672
2643
2644         Building WPE with flatpak was impossible without that as it was raising an exception.
2645         Also update wpebackend-fdo to match what is built in jhbuild
2646
2647         Reviewed by Philippe Normand.
2648
2649         * flatpak/flatpakutils.py:
2650         (expand_submodules_recurse):
2651         (expand_manifest):
2652         * flatpak/org.webkit.WPEModules.yaml:
2653
2654 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2655
2656         [ews-app] status bubble should be hidden for certain builds
2657         https://bugs.webkit.org/show_bug.cgi?id=194597
2658
2659         Reviewed by Dewei Zhu.
2660
2661         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2662         (StatusBubble._build_bubble):
2663         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2664         because the patch didn't have relevant changes.
2665         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2666         in production yet.
2667
2668 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2669
2670         [Win] Fix a slew of simple clang-cl warnings.
2671         https://bugs.webkit.org/show_bug.cgi?id=195652
2672
2673         Reviewed by Don Olmstead.
2674
2675         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2676         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2677
2678 2019-03-12  Justin Fan  <justin_fan@apple.com>
2679
2680         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2681         https://bugs.webkit.org/show_bug.cgi?id=195518
2682         <rdar://problem/46322356>
2683
2684         Reviewed by Myles C. Maxfield.
2685
2686         * DumpRenderTree/DerivedSources-input.xcfilelist:
2687         * DumpRenderTree/DerivedSources-output.xcfilelist:
2688
2689 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2690
2691         Unreviewed, rolling out r242825.
2692         https://bugs.webkit.org/show_bug.cgi?id=195648
2693
2694         "Broke webkitpy tests with my change to
2695         lldb_dump_class_layout.py" (Requested by rmorisset on
2696         #webkit).
2697
2698         Reverted changeset:
2699
2700         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2701         classes with suspicious padding"
2702         https://bugs.webkit.org/show_bug.cgi?id=195573
2703         https://trac.webkit.org/changeset/242825
2704
2705 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2706
2707         [ews-build] Show status bubbles while the patch is waiting in queue
2708         https://bugs.webkit.org/show_bug.cgi?id=195618
2709
2710         Reviewed by Lucas Forschler.
2711
2712         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2713         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2714         enabled in initial deployment.
2715         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2716         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2717         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2718         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2719         (StatusBubble._build_bubbles_for_patch):
2720
2721 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2722
2723         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2724         https://bugs.webkit.org/show_bug.cgi?id=195573
2725
2726         Reviewed by Simon Fraser.
2727
2728         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2729
2730         * Scripts/dump-class-layout:
2731         (main):
2732         * lldb/lldb_dump_class_layout.py:
2733         (ClassLayout.__init__):
2734         (ClassLayout._compute_padding_recursive):
2735         (LLDBDebuggerInstance.dump_layout_for_classname):
2736         (LLDBDebuggerInstance):
2737         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2738         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2739
2740 2019-03-12  Chris Dumez  <cdumez@apple.com>
2741
2742         Device Orientation access permission should be denied unless explicitly granted by the client
2743         https://bugs.webkit.org/show_bug.cgi?id=195625
2744
2745         Reviewed by Youenn Fablet.
2746
2747         add API test coverage.
2748
2749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2750         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2751         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2752         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2753         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2754         (runDeviceOrientationTest):
2755         (TEST):
2756         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2757         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2758
2759 2019-03-12  Jer Noble  <jer.noble@apple.com>
2760
2761         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2762         https://bugs.webkit.org/show_bug.cgi?id=195137
2763         <rdar://problem/48810307>
2764
2765         Reviewed by Eric Carlson.
2766
2767         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2768         (TestWebKitAPI::TEST):
2769
2770 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2771
2772         [ews-build] Change urls from uat to production
2773         https://bugs.webkit.org/show_bug.cgi?id=195566
2774
2775         Reviewed by Lucas Forschler.
2776
2777         * BuildSlaveSupport/ews-app/ews/config.py:
2778         * BuildSlaveSupport/ews-build/events.py:
2779         * BuildSlaveSupport/ews-build/steps.py:
2780
2781 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2782
2783         [ews-build] change max_builds for local-worker to 1
2784         https://bugs.webkit.org/show_bug.cgi?id=195568
2785
2786         Reviewed by Lucas Forschler.
2787
2788         * BuildSlaveSupport/ews-build/loadConfig.py:
2789
2790 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2791
2792         Fix the build
2793
2794         * TestRunnerShared/spi/PencilKitTestSPI.h:
2795         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2796
2797 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2798
2799         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2800         https://bugs.webkit.org/show_bug.cgi?id=194131
2801
2802         Reviewed by Michael Catanzaro.
2803
2804         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2805         (uriChanged):
2806         (testUnfinishedSubresourceLoad):
2807         (serverCallback):
2808         (beforeAll):
2809
2810 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2811
2812         WTF::Expected should use std::addressof instead of operator&
2813         https://bugs.webkit.org/show_bug.cgi?id=195604
2814
2815         Reviewed by Myles Maxfield.
2816
2817         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2818         (TestWebKitAPI::Unique::Unique):
2819         (TestWebKitAPI::Unique::operator&):
2820         (TestWebKitAPI::TEST):
2821
2822 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2823
2824         Add Optional to Forward.h.
2825         https://bugs.webkit.org/show_bug.cgi?id=195586
2826
2827         Reviewed by Darin Adler.
2828
2829         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2830         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2831         Remove unnecessary includes from headers.
2832
2833 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2834
2835         Add testing API to hit-test and scroll overflow scrollers
2836         https://bugs.webkit.org/show_bug.cgi?id=195278
2837
2838         Reviewed by Antti Koivisto.
2839         
2840         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2841         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2842         
2843         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2844
2845         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2846         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2847         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2848         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2849         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2850         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2851         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2852         (WTR::enclosingScrollViewIncludingSelf):
2853         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2854
2855 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2856
2857         API test WebKit.RequestTextInputContext fails on iOS
2858         https://bugs.webkit.org/show_bug.cgi?id=195585
2859
2860         Reviewed by Wenson Hsieh and Simon Fraser.
2861
2862         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2863         (applyStyle):
2864         (TEST):
2865         Add a viewport, so that the coordinates match up on iOS.
2866         Scroll by moving the UIScrollView's contentOffset.
2867
2868 2019-03-11  Chris Dumez  <cdumez@apple.com>
2869
2870         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2871         https://bugs.webkit.org/show_bug.cgi?id=195506
2872         <rdar://problem/48733477>
2873
2874         Reviewed by Alex Christensen.
2875
2876         Add API test coverage.
2877
2878         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2879
2880 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2881
2882         Adding myself to contributors.json
2883
2884         Unreviewed, addming myself to contributors.json .
2885
2886         * Scripts/webkitpy/common/config/contributors.json:
2887
2888 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2889
2890         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2891         https://bugs.webkit.org/show_bug.cgi?id=195511
2892         <rdar://problem/44873269>
2893
2894         Reviewed by Darin Adler.
2895
2896         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2897         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2898         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2899         (TEST_F):
2900
2901 2019-03-11  Chris Dumez  <cdumez@apple.com>
2902
2903         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2904         https://bugs.webkit.org/show_bug.cgi?id=195561
2905
2906         Reviewed by Youenn Fablet.
2907
2908         Make sure the JS in the test requests for permission to receive device orientation events.
2909
2910         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2911
2912 2019-03-11  Youenn Fablet  <youenn@apple.com>
2913
2914         Allow storage quota increase by default in WTR
2915         https://bugs.webkit.org/show_bug.cgi?id=195541
2916
2917         Reviewed by Geoffrey Garen.
2918
2919         Allow storage quota increase by default in WTR.
2920         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2921         Use this for tests that explicitly need cache increase.
2922
2923         Instead of increasing quota by 2, make sure the next request is
2924         granted by adding all given parameters.
2925
2926         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2927         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2928         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2929         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2930         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2931         * WebKitTestRunner/TestController.cpp:
2932         (WTR::TestController::setAllowStorageQuotaIncrease):
2933         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2934         * WebKitTestRunner/TestController.h:
2935         * WebKitTestRunner/TestInvocation.cpp:
2936         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2937         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2938         (WTR::TestController::cocoaResetStateToConsistentValues):
2939         (WTR::TestController::setAllowStorageQuotaIncrease):
2940         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2941         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2942         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2943
2944 2019-03-11  Xan Lopez  <xan@igalia.com>
2945
2946         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2947         https://bugs.webkit.org/show_bug.cgi?id=194147
2948
2949         Reviewed by Michael Saboff.
2950
2951         To make --32-bit work correctly on Linux/64bit we need to:
2952
2953         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2954         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2955         unfortunately CMake only allows us to do this during
2956         crosscompilation, which is overkill here.
2957         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2958         pkg-config detection module uses the x86 .pc files instead of the
2959         x86_64 ones.
2960         - Set the -m32 flags for the compiler.
2961
2962         * Scripts/webkitdirs.pm:
2963         (generateBuildSystemFromCMakeProject):
2964
2965 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2966
2967         Add MotionMark-1.1 plan file for run-benchmark script.
2968         https://bugs.webkit.org/show_bug.cgi?id=195481
2969
2970         Rubber-stamped by Darin Adler.
2971
2972         Run-benchmark script should support MontionMark-1.1.
2973
2974         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2975
2976 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2977
2978         [ews-app] Add support for submit-to-ews url
2979         https://bugs.webkit.org/show_bug.cgi?id=195477
2980
2981         Reviewed by Lucas Forschler.
2982
2983         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2984         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2985         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2986         * BuildSlaveSupport/ews-app/ews/urls.py:
2987         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2988
2989 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2990
2991         Unreviewed, rolling out r242688, r242643, r242624.
2992
2993         Caused multiple layout test failures and crashes on iOS and macOS.
2994
2995         Reverted changeset:
2996
2997         "requestAnimationFrame should execute before the next frame"
2998         https://bugs.webkit.org/show_bug.cgi?id=177484
2999         https://trac.webkit.org/changeset/242624/webkit
3000
3001         * Tracing/SystemTracePoints.plist:
3002
3003 2019-03-11  John Wilander  <wilander@apple.com>
3004
3005         Resource Load Statistics: Make it possible exclude localhost from classification
3006         https://bugs.webkit.org/show_bug.cgi?id=195474
3007         <rdar://problem/47520577>
3008
3009         Reviewed by Brent Fulgham.
3010
3011         This patch allows for localhost to be excluded from classification and
3012         treatment as a prevalent resource.
3013
3014         The WebKit Tools change adds a new function called
3015         testRunner.setStatisticsIsRunningTest() which can be used to control this
3016         behavior.
3017
3018         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3019         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3020         (WTR::TestRunner::setStatisticsIsRunningTest):
3021         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3022         * WebKitTestRunner/TestController.cpp:
3023         (WTR::TestController::setStatisticsIsRunningTest):
3024         * WebKitTestRunner/TestController.h:
3025         * WebKitTestRunner/TestInvocation.cpp:
3026         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3027
3028 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3029
3030         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3031         https://bugs.webkit.org/show_bug.cgi?id=195560
3032
3033         Reviewed by Lucas Forschler.
3034
3035         * BuildSlaveSupport/ews-build/master.cfg:
3036
3037 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3038
3039         Unreviewed, rolling out r242698.
3040
3041         API test crashes on bots.
3042
3043         Reverted changeset:
3044
3045         "Add a WKContentRuleList variant that uses copied memory
3046         instead of mmap'd shared memory for class A containerized
3047         apps"
3048         https://bugs.webkit.org/show_bug.cgi?id=195511
3049         https://trac.webkit.org/changeset/242698
3050
3051 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3052
3053         [WPE] Enable web process sandbox
3054         https://bugs.webkit.org/show_bug.cgi?id=195169
3055
3056         Reviewed by Daniel Bates.
3057
3058         * wpe/install-dependencies:
3059         * wpe/jhbuild.modules:
3060
3061 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3062
3063         [ews-app] Use port 17000 for worker communication
3064         https://bugs.webkit.org/show_bug.cgi?id=195558
3065
3066         Reviewed by Lucas Forschler.
3067
3068         * BuildSlaveSupport/ews-build/master.cfg:
3069
3070 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3071
3072         [ews-build] unit-tests fail when passwords.json is missing
3073         https://bugs.webkit.org/show_bug.cgi?id=195557
3074
3075         Reviewed by Lucas Forschler.
3076
3077         * BuildSlaveSupport/ews-build/loadConfig.py:
3078         (loadBuilderConfig):
3079         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3080         (ConfigDotJSONTest.test_configuration):
3081         * BuildSlaveSupport/ews-build/master.cfg:
3082
3083 2019-03-11  Truitt Savell  <tsavell@apple.com>
3084
3085         Unreviewed, rolling out r242702.
3086
3087         Broke High Sierra builders.
3088
3089         Reverted changeset:
3090
3091         "Add utility function to allow easy reverse range-based
3092         iteration of a container"
3093         https://bugs.webkit.org/show_bug.cgi?id=195542
3094         https://trac.webkit.org/changeset/242702
3095
3096 2019-03-11  Sam Weinig  <sam@webkit.org>
3097
3098         Add utility function to allow easy reverse range-based iteration of a container
3099         https://bugs.webkit.org/show_bug.cgi?id=195542
3100
3101         Reviewed by Antti Koivisto.
3102
3103         * TestWebKitAPI/CMakeLists.txt:
3104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3105         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3106         (TestWebKitAPI::TEST):
3107         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3108
3109 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3110
3111         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3112         https://bugs.webkit.org/show_bug.cgi?id=195511
3113         <rdar://problem/44873269>
3114
3115         Reviewed by Darin Adler.
3116
3117         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3118         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3119         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3120         (TEST_F):
3121
3122 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3123
3124         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3125         https://bugs.webkit.org/show_bug.cgi?id=195499
3126
3127         Reviewed by Darin Adler.
3128
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3131         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3132         (-[WKWebView synchronouslyFocusTextInputContext:]):
3133         (applyStyle):
3134         (applyIframe):
3135         (TEST):
3136         Add some tests for this SPI.
3137
3138 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3139
3140         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3141         https://bugs.webkit.org/show_bug.cgi?id=181151
3142
3143         Reviewed by Don Olmstead.
3144
3145         * TestWebKitAPI/CMakeLists.txt:
3146         * TestWebKitAPI/PlatformWin.cmake:
3147         Enable TestWTF RunLoop tests in all platforms.
3148
3149         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3150         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3151         (TestWebKitAPI::DerivedOneShotTimer::fired):
3152         (TestWebKitAPI::TEST):
3153         Only a few platforms support nested RunLoop.
3154
3155         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3156         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3157
3158 2019-03-10  David Quesada  <david_quesada@apple.com>
3159
3160         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3161         https://bugs.webkit.org/show_bug.cgi?id=152480
3162
3163         Reviewed by Chris Dumez.
3164
3165         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3166         there are no additional references to the process pool besides the one held by
3167         the download, waits for the download to finish (in the sense that the
3168         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3169         measure, also check that the process pool has been deallocated at the end of the
3170         test. The test wouldn't be meaningful if the process pool were still alive.
3171
3172         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3173         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3174         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3175             The download will be canceled because the delegate does not implement the
3176             method to decide the download's destination, so this is where we know the
3177             DownloadProxyMap is done with the DownloadProxy.
3178         (TEST):
3179
3180 2019-03-08  Chris Dumez  <cdumez@apple.com>
3181
3182         Add support for Device Orientation / Motion permission API
3183         https://bugs.webkit.org/show_bug.cgi?id=195329
3184         <rdar://problem/47645367>
3185
3186         Reviewed by Geoffrey Garen.
3187
3188         Add test infrastructure to help test the Device Orientation / Motion permission API.
3189
3190         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3192         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3193         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3194         * WebKitTestRunner/TestController.cpp:
3195         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3196         (WTR::TestController::createWebViewWithOptions):
3197         (WTR::TestController::resetStateToConsistentValues):
3198         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3199         * WebKitTestRunner/TestController.h:
3200         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3201         * WebKitTestRunner/TestInvocation.cpp:
3202         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3203
3204 2019-03-08  Saam barati  <sbarati@apple.com>
3205
3206         Add a compare-results script to compare benchmark results
3207         https://bugs.webkit.org/show_bug.cgi?id=195486
3208         <rdar://problem/48723397>
3209
3210         Reviewed by Geoffrey Garen.
3211
3212         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3213         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3214         to extend it to learn about our other benchmarks.
3215
3216         * Scripts/compare-results: Added.
3217         (readJSONFile):
3218         (detectJetStream2):
3219         (JetStream2Results):
3220         (detectSpeedometer2):
3221         (Speedometer2Results):
3222         (detectPLT5):
3223         (PLT5Results):
3224         (detectBenchmark):
3225         (biggerIsBetter):
3226         (ttest):
3227         (getOptions):
3228         (main):
3229
3230 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3231
3232         Ensure old tab state is cleared between iterations of run-benchmark
3233         https://bugs.webkit.org/show_bug.cgi?id=195393
3234         <rdar://problem/46885583>
3235
3236         Reviewed by Dewei Zhu.
3237
3238         a) ensure the default to restore state is not set
3239         b) terminate Safari correctly
3240         c) Set the system default to ignore Persistent State in Safari
3241
3242         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3243         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3244         (OSXBrowserDriver.prepare_env): 
3245         (OSXBrowserDriver.restore_env):
3246         (OSXBrowserDriver.close_browsers):
3247         (OSXBrowserDriver._terminate_processes):
3248         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3249         (OSXChromeDriver):
3250         (OSXChromeCanaryDriver):
3251         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3252         (OSXFirefoxDriver):
3253         (OSXFirefoxNightlyDriver):
3254         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3255         (OSXSafariDriver):
3256         (OSXSafariDriver.prepare_env):
3257
3258 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3259
3260         [GTK] Several InputMethodFilter tests are failing
3261         https://bugs.webkit.org/show_bug.cgi?id=195408
3262
3263         Reviewed by Carlos Garcia Campos.
3264
3265         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3266         Regressed in r241751.
3267         Hexadecimal values of keycodes are expressed now in upper letters.
3268         Composited characters should be cast to UTF8 strings.
3269
3270         (TestWebKitAPI::TEST):
3271
3272 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3273
3274         [GTK] Make Tools/gtkdoc python3 compatible
3275         https://bugs.webkit.org/show_bug.cgi?id=195359
3276
3277         Reviewed by Carlos Garcia Campos.
3278
3279         * gtkdoc/generate-gtkdoc:
3280         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3281         work with Python 2 and 3.
3282         (get_gtkdoc_module_paths):
3283         The iteritems() was removed in Python 3, so let's use items() that's
3284         available in Python 2 and 3.
3285         (get_generator_for_config):
3286         * gtkdoc/gtkdoc.py:
3287         (GTKDoc._run_command):
3288         The sys.stdout.write() is expecting str in Python 3 and not bytes
3289         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3290         for passing the bytes there.
3291
3292 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3293
3294         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3295         https://bugs.webkit.org/show_bug.cgi?id=195346
3296         <rdar://problem/48667048>
3297
3298         Unreviewed build fix for clang-cl.
3299
3300         * DumpRenderTree/win/DumpRenderTree.cpp:
3301         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3302
3303 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3304
3305         requestAnimationFrame should execute before the next frame
3306         https://bugs.webkit.org/show_bug.cgi?id=177484
3307
3308         Reviewed by Simon Fraser.
3309
3310         Add trace points for the page RenderingUpdate.
3311
3312         * Tracing/SystemTracePoints.plist:
3313
3314 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3315
3316         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3317         https://bugs.webkit.org/show_bug.cgi?id=195353
3318         <rdar://problem/48626394>
3319
3320         Reviewed by Simon Fraser.
3321
3322         * WebKitTestRunner/ios/TestControllerIOS.mm:
3323         (WTR::TestController::platformResetPreferencesToConsistentValues):
3324
3325 2019-03-07  John Wilander  <wilander@apple.com>
3326
3327         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3328         https://bugs.webkit.org/show_bug.cgi?id=195383
3329         <rdar://problem/48570136>
3330
3331         Reviewed by Brent Fulgham.
3332
3333         This patch adds test infrastructure to purge only script-accessible cookies,
3334         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3335
3336         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3337         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3338         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3339         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3340         * WebKitTestRunner/TestController.cpp:
3341         (WTR::TestController::statisticsDeleteCookiesForHost):
3342         * WebKitTestRunner/TestController.h:
3343         * WebKitTestRunner/TestInvocation.cpp:
3344         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3345
3346 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3347
3348         Unreviewed, rolling out r242354.
3349         https://bugs.webkit.org/show_bug.cgi?id=195402
3350
3351         breaks layout tests in all configurations (Requested by
3352         zdobersek on #webkit).
3353
3354         Reverted changeset:
3355
3356         "[WPE] Enable web process sandbox"
3357         https://bugs.webkit.org/show_bug.cgi?id=195169
3358         https://trac.webkit.org/changeset/242354
3359
3360 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3361
3362         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3363         https://bugs.webkit.org/show_bug.cgi?id=195346
3364
3365         Reviewed by Fujii Hironori.
3366
3367         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3368         (TestWebKitAPI::TEST):
3369         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3370
3371         * DumpRenderTree/win/DumpRenderTree.cpp:
3372         (findFontFallback):
3373         (addFontFallbackIfPresent):
3374         (removeFontFallbackIfPresent):
3375         (main):
3376         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3377         (TestWebKitAPI::Util::moduleDirectory):
3378         (TestWebKitAPI::Util::createInjectedBundlePath):
3379         Use wchar helpers as needed.
3380
3381 2019-03-06  Rob Buis  <rbuis@igalia.com>
3382
3383         Consider supporting the `referrerpolicy` attribute.
3384         https://bugs.webkit.org/show_bug.cgi?id=179053
3385
3386         Reviewed by Darin Adler.
3387
3388         Add a runtime flag for referrerpolicy attribute.
3389
3390         * DumpRenderTree/mac/DumpRenderTree.mm:
3391         (enableExperimentalFeatures):
3392
3393 2019-03-05  Daniel Bates  <dabates@apple.com>
3394
3395         Update expected API test result following r242379
3396         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3397
3398         Update expected x-coordinate of selection rect now that the left padding of
3399         a textarea is sized in ems (so dependent on the font size) just like the left
3400         padding of a text field.
3401
3402         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3403         (TestWebKitAPI::TEST):
3404
3405 2019-03-05  David Quesada  <david_quesada@apple.com>
3406
3407         [WK2] It should be possible to follow links with 'download' attributes
3408         https://bugs.webkit.org/show_bug.cgi?id=195145
3409         rdar://problem/48462642
3410
3411         Reviewed by Alex Christensen.
3412
3413         Add a unit test to verify that activating links with 'download' attributes now
3414         navigates to the linked resource, rather than starts downloading it. Add another
3415         to verify that it is still possible to explicitly download the link via the
3416         'Download' navigation action policy.
3417
3418         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3419         (-[DownloadAttributeTestDelegate init]):
3420         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3421         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3422         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3423         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3424         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3425         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3426         (TEST):
3427         * WebKitTestRunner/TestController.cpp:
3428         (WTR::TestController::decidePolicyForNavigationAction):
3429         * WebKitTestRunner/TestController.h:
3430
3431 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3432
3433         [Curl] Implement Cookie Accept Policy.
3434         https://bugs.webkit.org/show_bug.cgi?id=191645
3435
3436         Reviewed by Fujii Hironori.
3437
3438         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3439         (TestWebKitAPI::Curl::TEST_F):
3440
3441 2019-03-05  Youenn Fablet  <youenn@apple.com>
3442
3443         Rename requestCacheStorageSpace to requestStorageSpace
3444         https://bugs.webkit.org/show_bug.cgi?id=195282
3445
3446         Reviewed by Chris Dumez.
3447
3448         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3449         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3450         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3451
3452 2019-03-05  Brady Eidson  <beidson@apple.com>
3453
3454         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3455         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3456
3457         Reviewed by Tim Horton.
3458
3459         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3460         different directory into that same WKWebView should work.
3461
3462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3463         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3464
3465 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3466
3467         Add WeakHashSet
3468         https://bugs.webkit.org/show_bug.cgi?id=195152
3469
3470         Reviewed by Antti Koivisto.
3471
3472         Added tests for WeakHashSet.
3473
3474         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3475         (TestWebKitAPI::Base::Base): Moved.
3476         (TestWebKitAPI::Derived::foo): Moved.
3477         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3478         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3479         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3480         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3481
3482 2019-03-04  Chris Dumez  <cdumez@apple.com>
3483
3484         Do not share WebProcesses between private and regular sessions
3485         https://bugs.webkit.org/show_bug.cgi?id=195189
3486         <rdar://problem/48421064>
3487
3488         Reviewed by Alex Christensen.
3489
3490         Add API test coverage.
3491
3492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3493         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3494
3495 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3496
3497         [WPE] Enable web process sandbox
3498         https://bugs.webkit.org/show_bug.cgi?id=195169
3499
3500         Reviewed by Daniel Bates.
3501
3502         * wpe/install-dependencies:
3503         * wpe/jhbuild.modules:
3504
3505 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3506
3507         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3508         https://bugs.webkit.org/show_bug.cgi?id=195206
3509
3510         Reviewed by Žan Doberšek.
3511
3512         Add a new test case.
3513
3514         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3515         (testJSCClass):
3516
3517 2019-03-04  Charlie Turner  <cturner@igalia.com>
3518
3519         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3520         https://bugs.webkit.org/show_bug.cgi?id=194898
3521
3522         Reviewed by Žan Doberšek.
3523
3524         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3525         a GCC extension that permits arithmetic on void* pointer. Inline
3526         the macro until this issue is fixed upstream.
3527
3528 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3529
3530         Rid the world of WK_API_ENABLED
3531         https://bugs.webkit.org/show_bug.cgi?id=195263
3532
3533         Reviewed by Dan Bernstein.
3534
3535         List of changed files elided because it's useless.
3536
3537 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3538
3539         Unreviewed follow-up to r242292.
3540
3541         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3542
3543         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3544         (TestWebKitAPI::testStrip): Renamed from strip.
3545         (TestWebKitAPI::TEST):
3546
3547 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3548
3549         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3550
3551         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3552         and bug #194272 for details.
3553
3554         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3555
3556 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3557
3558         Remove some more unused 32-bit code
3559         https://bugs.webkit.org/show_bug.cgi?id=195255
3560
3561         Reviewed by Darin Adler.
3562
3563         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3564         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3565         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3566         (NPP_New):
3567         (NPP_HandleEvent):
3568         (handleEventCarbon): Deleted.
3569
3570 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3571
3572         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3573
3574         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3575         (TestWebKitAPI::TEST):
3576
3577 2019-03-01  Darin Adler  <darin@apple.com>
3578
3579         Finish removing String::format
3580         https://bugs.webkit.org/show_bug.cgi?id=194893
3581
3582         Reviewed by Daniel Bates.
3583 '
3584         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3585
3586 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3587
3588         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3589         https://bugs.webkit.org/show_bug.cgi?id=195229
3590         <rdar://problem/48520362>
3591
3592         Reviewed by Chris Dumez.
3593
3594         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3595         (TEST):
3596
3597 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3598
3599         Add a system trace scope for event region building
3600         https://bugs.webkit.org/show_bug.cgi?id=195226
3601
3602         Reviewed by Jon Lee.
3603
3604         This trace scope measures the time spend converting element rects into Region objects,
3605         which can be large on some pages.
3606
3607         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3608
3609         * Tracing/SystemTracePoints.plist:
3610
3611 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3612
3613         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3614         https://bugs.webkit.org/show_bug.cgi?id=194612
3615
3616         Reviewed by Alex Christensen.
3617
3618         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3619         Just test the new string-processing function and don't touch the actual environment.
3620         (Test cases are all as before, but based on operator== instead of strcmp.)
3621
3622 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3623
3624         [ews-app] Update primary keys for handling multiple Buildbot instances
3625         https://bugs.webkit.org/show_bug.cgi?id=195120
3626
3627         Reviewed by Stephanie Lewis.
3628
3629         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3630         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3631         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3632
3633         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3634         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3635         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3636         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3637         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3638         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3639
3640 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3641
3642         [WinCairo] Enable service worker
3643         https://bugs.webkit.org/show_bug.cgi?id=188318
3644
3645         Reviewed by Youenn Fablet.
3646
3647         * DumpRenderTree/DumpRenderTreePrefix.h:
3648         * TestWebKitAPI/PlatformWin.cmake:
3649         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3650         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3651         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3652
3653 2019-03-01  Justin Fan  <justin_fan@apple.com>
3654
3655         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3656         https://bugs.webkit.org/show_bug.cgi?id=195191
3657
3658         Rubber-stamped by Dean Jackson.
3659
3660         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3661
3662         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3663
3664 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3665
3666         Unreviewed, fix lldb webkitpy tests
3667         https://bugs.webkit.org/show_bug.cgi?id=194375
3668
3669         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3670
3671         * lldb/lldb_webkit.py:
3672         (WTFStringImplProvider.is_8bit):
3673
3674 2019-02-28  David Quesada  <david_quesada@apple.com>
3675
3676         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3677         https://bugs.webkit.org/show_bug.cgi?id=195121
3678         rdar://problem/48450302
3679
3680         Reviewed by Alex Christensen.
3681
3682         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3683         configurations where the 'download' attribute is absent, blank, or populated
3684         with a filename, and where the anchor element is same-origin or cross-origin
3685         (meaning the 'download' attribute shouldn't be honored).
3686
3687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3688         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3689         (-[NavigationActionTestDelegate init]):
3690         (-[NavigationActionTestDelegate navigationAction]):
3691         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3692         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3693         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3694         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3695         (TEST):
3696
3697 2019-02-28  Antoine Quint  <graouts@apple.com>
3698
3699         Enable the Pointer Events runtime flag by default
3700         https://bugs.webkit.org/show_bug.cgi?id=195156
3701
3702         Reviewed by Dean Jackson.
3703
3704         * DumpRenderTree/mac/DumpRenderTree.mm:
3705         (enableExperimentalFeatures):
3706
3707 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3708
3709         Several PasteImage API tests are flaky
3710         https://bugs.webkit.org/show_bug.cgi?id=195160
3711
3712         Reviewed by Tim Horton.
3713
3714         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3715         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3716         listening for a "load" event after image load is already complete.
3717
3718         To address this, make these tests first register a "load" event handler, then run script to insert an image
3719         element into the document, and finally wait until the load event is observed before checking image size.
3720
3721         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3722
3723 2019-02-28  Chris Dumez  <cdumez@apple.com>
3724
3725         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3726         https://bugs.webkit.org/show_bug.cgi?id=195107
3727
3728         Reviewed by Alex Christensen.
3729
3730         Give some time for the zoom level to get restored.
3731
3732         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3733
3734 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3735
3736         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3737         https://bugs.webkit.org/show_bug.cgi?id=194958
3738
3739         Reviewed by Geoffrey Garen.
3740
3741         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3742         (TEST):
3743
3744 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3745
3746         [ews-app] Update method to save build to handle builder_display_name
3747         https://bugs.webkit.org/show_bug.cgi?id=195047
3748
3749         Reviewed by Dewei Zhu.
3750
3751         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3752         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3753
3754 2019-02-28  Justin Fan  <justin_fan@apple.com>
3755
3756         [Web GPU] Enable Web GPU only on 64-bit
3757         https://bugs.webkit.org/show_bug.cgi?id=195139
3758
3759         Because Metal is only supported on 64 bit apps.
3760
3761         Unreviewed build fix.
3762
3763         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3764
3765 2019-02-27  Youenn Fablet  <youenn@apple.com>
3766
3767         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3768         https://bugs.webkit.org/show_bug.cgi?id=194959
3769
3770         Reviewed by Chris Dumez.
3771
3772         Spin loop until getting the condition to remove flakiness.
3773
3774         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3775
3776 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3777
3778         [ews-build] Buildbot should include builder_display_name in the build events
3779         https://bugs.webkit.org/show_bug.cgi?id=195045
3780
3781         Reviewed by Dewei Zhu.
3782
3783         * BuildSlaveSupport/ews-build/events.py:
3784         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3785         buildername to builder_name to be consistent in naming style.
3786         (Events.buildFinished): Ditto.
3787
3788 2019-02-27  Chris Dumez  <cdumez@apple.com>
3789
3790         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3791         https://bugs.webkit.org/show_bug.cgi?id=194480
3792
3793         Reviewed by Brady Eidson.
3794
3795         Update existing API test to make it more likely to reproduce the issue.
3796
3797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3798
3799 2019-02-27  Brady Eidson  <beidson@apple.com>
3800
3801         Universal links from Google search results pages don't open the app.
3802         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3803
3804         Reviewed by Geoffrey Garen.
3805
3806         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3807         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3808         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3809         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3810
3811 2019-02-27  Chris Dumez  <cdumez@apple.com>
3812
3813         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3814         https://bugs.webkit.org/show_bug.cgi?id=195102
3815
3816         Reviewed by Geoffrey Garen.
3817
3818         If the number of processes is not yet what we expect, wait a bit and check again to give
3819         processes some time to exit.
3820
3821         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3822
3823 2019-02-27  Chris Dumez  <cdumez@apple.com>
3824
3825         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3826         https://bugs.webkit.org/show_bug.cgi?id=194545
3827
3828         Reviewed by Brady Eidson.
3829
3830         Make sure the test navigates forward and then back only once. Previously, navigating
3831         back would trigger a navigation again in a timer.
3832
3833         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3834
3835 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3836
3837         High Sierra Debug JSC test queue should use faster hardware
3838         https://bugs.webkit.org/show_bug.cgi?id=194603
3839
3840         Rubber-stamped by Alexey Proskuryakov.
3841
3842         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3843
3844         * BuildSlaveSupport/build.webkit.org-config/config.json:
3845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3846         (BubbleQueueServer):
3847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3848         (WebKitBuildbot):
3849         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3850         * QueueStatusServer/config/queues.py:
3851         * Scripts/webkitpy/common/config/ews.json:
3852         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3853         (test_ews_name):
3854
3855 2019-02-27  John Wilander  <wilander@apple.com>
3856
3857         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3858         https://bugs.webkit.org/show_bug.cgi?id=195071
3859         <rdar://problem/48417690>
3860
3861         Reviewed by Alex Christensen and Brent Fulgham.
3862
3863         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3864         (TestWebKitAPI::createURL):
3865             Convenience function.
3866         (TestWebKitAPI::TEST):
3867             WebCore::AdClickAttribution now takes a URL when creating Source and
3868             Destination.
3869         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3870         (TestWebKitAPI::TEST):
3871             WebCore::AdClickAttribution now takes a URL when creating Source and
3872             Destination.
3873
3874 2019-02-27  Antoine Quint  <graouts@apple.com>
3875
3876         Support Pointer Events on macOS
3877         https://bugs.webkit.org/show_bug.cgi?id=195008
3878         <rdar://problem/47454419>
3879
3880         Reviewed by Dean Jackson.
3881
3882         * DumpRenderTree/mac/DumpRenderTree.mm:
3883         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3884         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3885
3886 2019-02-26  Mark Lam  <mark.lam@apple.com>
3887
3888         Remove remaining poisoning code.
3889         https://bugs.webkit.org/show_bug.cgi?id=194138
3890
3891         Reviewed by Saam Barati.
3892
3893         * TestWebKitAPI/CMakeLists.txt:
3894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3895         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3896         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3897         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3898         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3899         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3900         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3901
3902 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3903
3904         Move ephemeral local storage from WebProcess to UIProcess
3905         https://bugs.webkit.org/show_bug.cgi?id=195074
3906         <rdar://problem/47937975>
3907
3908         Reviewed by Geoff Garen.
3909
3910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3911
3912 2019-02-20  Jer Noble  <jer.noble@apple.com>
3913
3914         [Cocoa] Media elements will restart network buffering just before suspending
3915         https://bugs.webkit.org/show_bug.cgi?id=193691
3916
3917         Reviewed by Eric Carlson.
3918
3919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3920         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3921         (TEST):
3922
3923 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3924
3925         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3926         https://bugs.webkit.org/show_bug.cgi?id=191652
3927
3928         Reviewed by Alex Christensen.
3929
3930         Fix WinCairo MiniBrowser behavior of authentication dialog.
3931
3932         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3933         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3934
3935 2019-02-26  Youenn Fablet  <youenn@apple.com>
3936
3937         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3938         https://bugs.webkit.org/show_bug.cgi?id=195028
3939         <rdar://problem/48243733>
3940
3941         Reviewed by Eric Carlson.
3942
3943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3944
3945 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3946
3947         [WPE] Add API for webview background color configuration
3948         https://bugs.webkit.org/show_bug.cgi?id=192305
3949
3950         Reviewed by Michael Catanzaro.
3951
3952         * MiniBrowser/wpe/main.cpp:
3953         (main): Add a new option to configure the webview background
3954         color. Example: --bg-color=transparent.
3955         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3956         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3957         (beforeAll): Ditto.
3958
3959 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3960
3961         scalableNativeWebpageParameters() is not preserved on new page navigation.
3962         https://bugs.webkit.org/show_bug.cgi?id=194892
3963         <rdar://problem/47538280>
3964
3965         Reviewed by Wenson Hsieh.
3966         
3967         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3968
3969         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3970         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3971         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3972         (WTR::UIScriptController::allowsViewportShrinkToFit):
3973         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3974         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3975         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3976         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3977         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3978         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3979
3980 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3981
3982         [ews-app] Add model for handling multiple Buildbot instances
3983         https://bugs.webkit.org/show_bug.cgi?id=194863
3984
3985         Reviewed by Stephanie Lewis.
3986
3987         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3988
3989 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3990
3991         [ews-app] Remove BuilderMapping table
3992         https://bugs.webkit.org/show_bug.cgi?id=194961
3993
3994         Reviewed by Stephanie Lewis.
3995
3996         Store builder name directly in build table, instead of having a separate
3997         table for it.
3998
3999         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4000         * BuildSlaveSupport/ews-app/ews/models/build.py:
4001         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4002         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4003
4004 2019-02-25  John Wilander  <wilander@apple.com>
4005
4006         Introduce and adopt new class RegistrableDomain for eTLD+1
4007         https://bugs.webkit.org/show_bug.cgi?id=194791
4008         <rdar://problem/48179240>
4009
4010         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4011
4012         This patch adds an API test and replaces two instances of
4013         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4014
4015         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4016         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4017         (TestWebKitAPI::TEST):
4018             Changed two strings to make sure the registrable domains are still considered
4019             invalid and pass the test.
4020         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4021         (TestWebKitAPI::TEST):
4022         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4023         (WTR::InjectedBundle::didReceiveMessageToPage):
4024
4025 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4026
4027         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4028         https://bugs.webkit.org/show_bug.cgi?id=195001
4029
4030         Reviewed by Carlos Garcia Campos.
4031
4032         API version 1.0 always includes the functionality previously guarded with
4033         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4034         unconditionally.
4035
4036         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4037         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4038         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4039         (WebViewTest::showInWindow): Ditto.
4040         (WebViewTest::hideView): Ditto.
4041         * wpe/backends/HeadlessViewBackend.cpp:
4042         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4043         * wpe/backends/ViewBackend.cpp:
4044         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4045         * wpe/backends/WindowViewBackend.cpp:
4046         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4047         WPE_BACKEND_CHECK_VERSION().
4048         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4049
4050 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4051
4052         [Flatpak] Add support for flatpak > 1.1.2
4053         https://bugs.webkit.org/show_bug.cgi?id=194088
4054
4055         Flatpak 1.2 is now out so we need to support that
4056         version now.
4057
4058         Reviewed by Michael Catanzaro.
4059
4060         * flatpak/flatpakutils.py:
4061         (check_flatpak):
4062         (FlatpakPackages.__init__):
4063         (FlatpakPackages.__detect_packages):
4064         (FlatpakPackages.__detect_packages.in):
4065         (FlatpakRepos.update):
4066
4067 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4068
4069         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4070         https://bugs.webkit.org/show_bug.cgi?id=194998
4071
4072         Reviewed by Carlos Garcia Campos.
4073
4074         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4075         to a Git checkout and using the latest commit containing various fixes
4076         and improvements.
4077
4078 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4079
4080         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4081         https://bugs.webkit.org/show_bug.cgi?id=194981
4082
4083         Reviewed by Žan Doberšek.
4084
4085         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4086         (TestWebKitAPI::TEST):
4087
4088 2019-02-23  Keith Miller  <keith_miller@apple.com>
4089
4090         Add new mac target numbers
4091         https://bugs.webkit.org/show_bug.cgi?id=194955
4092
4093         Reviewed by Tim Horton.
4094
4095         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4096         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4097         * MiniBrowser/Configurations/Base.xcconfig:
4098         * TestWebKitAPI/Configurations/Base.xcconfig:
4099         * WebKitTestRunner/Configurations/Base.xcconfig:
4100
4101 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4102
4103         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4104         https://bugs.webkit.org/show_bug.cgi?id=194846
4105
4106         Reviewed by Don Olmstead.
4107
4108         Added _search_paths() and _port_specific_expectations_files() for
4109         WinCairoPort.
4110
4111         * Scripts/webkitpy/port/win.py:
4112         (WinCairoPort.default_baseline_search_path):
4113         (WinCairoPort):
4114         (WinCairoPort._port_specific_expectations_files):
4115         (WinCairoPort._search_paths):
4116
4117 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4118
4119         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4120         https://bugs.webkit.org/show_bug.cgi?id=194963
4121
4122         Reviewed by Dean Jackson.
4123
4124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4125         Do a `contains` check instead of `equals`, because in debug builds we
4126         put the GraphicsLayer pointer in a prefix.
4127
4128 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4129
4130         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4131         https://bugs.webkit.org/show_bug.cgi?id=194873
4132         <rdar://problem/46701974>
4133
4134         Reviewed by Tim Horton.
4135
4136         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4137
4138         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4139         (WTR::UIScriptController::menuRect const):
4140         (WTR::UIScriptController::isShowingMenu const):
4141         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4142         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4143         (WTR::UIScriptController::menuRect const):
4144
4145         Add a function to query the bounds of the callout menu in content coordinates.
4146
4147         (WTR::UIScriptController::isShowingMenu const):
4148
4149         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4150
4151         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4152         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4153         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4154         (WTR::UIScriptController::rectForMenuAction const):
4155         (WTR::UIScriptController::menuRect const):
4156         (WTR::UIScriptController::isShowingMenu const):
4157         (WTR::findViewInHierarchyOfType): Deleted.
4158
4159 2019-02-22  Chris Dumez  <cdumez@apple.com>
4160
4161         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4162         https://bugs.webkit.org/show_bug.cgi?id=194954
4163         <rdar://problem/48127957>
4164
4165         Reviewed by Alex Christensen.
4166
4167         Add API test coverage.
4168
4169         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4170         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4171         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4172         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4173
4174 2019-02-22  Chris Dumez  <cdumez@apple.com>
4175
4176         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4177         https://bugs.webkit.org/show_bug.cgi?id=194924
4178         <rdar://problem/48216125>
4179
4180         Reviewed by Geoffrey Garen.
4181
4182         Add API test coverage.
4183
4184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4185
4186 2019-02-22  Chris Dumez  <cdumez@apple.com>
4187
4188         Unreviewed, disable API test added in r241928 on iOS.
4189
4190         The cache is not enabled on devices with less than 3GB of RAM.
4191
4192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4193
4194 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4195
4196         Hardcode Visual Viewports on everywhere except iOS WK1
4197         https://bugs.webkit.org/show_bug.cgi?id=194928
4198
4199         Reviewed by Zalan Bujtas.
4200
4201         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4202         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4203         set it to false. The setting has shipped for several years and there's no need to turn
4204         it off now.
4205
4206         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4207         Visual Viewports are not enabled.
4208         
4209         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4210         that only runs in WK2
4211
4212         * MiniBrowser/mac/SettingsController.h:
4213         * MiniBrowser/mac/SettingsController.m:
4214         (-[SettingsController init]):
4215         (-[SettingsController _populateMenu]):
4216         (-[SettingsController validateMenuItem:]):
4217         (-[SettingsController visualViewportEnabled]): Deleted.
4218         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4219         * MiniBrowser/mac/WK1BrowserWindowController.m:
4220         (-[WK1BrowserWindowController didChangeSettings]):
4221         * MiniBrowser/mac/WK2BrowserWindowController.m:
4222         (-[WK2BrowserWindowController didChangeSettings]):
4223
4224 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4225
4226         Discard cached processes when clearing website data store
4227         https://bugs.webkit.org/show_bug.cgi?id=194894
4228
4229         Reviewed by Chris Dumez.
4230
4231         Added a test case.
4232
4233         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4234         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4235
4236 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4237
4238         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4239         https://bugs.webkit.org/show_bug.cgi?id=194914
4240         <rdar://problem/47586889>
4241
4242         Reviewed by Geoffrey Garen.
4243
4244         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4245         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4246         (TEST):
4247         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4248
4249 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4250
4251         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4252         <https://webkit.org/b/194761>
4253
4254         Reviewed by Myles Maxfield.
4255
4256         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4257         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4258         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4259         to use ARC-compliant cast.
4260         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4261         ARC-compliant cast.
4262         (WTR::installFakeHelvetica): Log `error` to console if
4263         CTFontManagerRegisterFontsForURL() fails, but only on supported
4264         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4265         Call CFRelease() on `error` to fix the leak.  Update to use
4266         ARC-compliant cast.
4267         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4268         cast.
4269
4270 2019-02-21  Chris Dumez  <cdumez@apple.com>
4271
4272         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4273         https://bugs.webkit.org/show_bug.cgi?id=194481
4274
4275         Reviewed by Alex Christensen.
4276
4277         Give the processes a chance to shutdown and wait until we reached the expected number
4278         of processes.
4279
4280         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4281
4282 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4283
4284         Fix the macOS build
4285
4286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4287
4288 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4289
4290         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4291
4292         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4293         I am a backwards.
4294
4295 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4296
4297         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4298
4299         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4300         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4301         We could force on UI-side compositing, but I feel like the test might be more
4302         valuable exercising the normal path on each platform (though the original
4303         bug was also UI-side specific). Though we can't validate that the overlay
4304         layer was installed successfully, there are layout tests that do that.
4305
4306 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4307
4308         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4309         https://bugs.webkit.org/show_bug.cgi?id=194845
4310         <rdar://problem/47944579>
4311
4312         Reviewed by Antti Koivisto.
4313
4314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4315         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4316
4317 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4318
4319         [LFC][Floats] Add support for placing formatting roots in-between floats.
4320         https://bugs.webkit.org/show_bug.cgi?id=194902
4321
4322         Reviewed by Antti Koivisto.
4323
4324         * LayoutReloaded/misc/LFC-passing-tests.txt:
4325
4326 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4327
4328         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4329         https://bugs.webkit.org/show_bug.cgi?id=194901
4330
4331         Unreviewed build fix.
4332
4333         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4334         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4335         WPEBackend-fdo-0.1 as library name.
4336
4337 2019-02-21  Rob Buis  <rbuis@igalia.com>
4338
4339         Update MIME type parser
4340         https://bugs.webkit.org/show_bug.cgi?id=180526
4341
4342         Reviewed by Darin Adler.
4343
4344         Add tests involving leading and trailing whitespace, non-token
4345         characters and quoted strings.
4346
4347         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4348         (TestWebKitAPI::TEST):
4349
4350 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4351
4352         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4353         https://bugs.webkit.org/show_bug.cgi?id=194884
4354
4355         Reviewed by Michael Catanzaro.
4356
4357         * PlatformWin.cmake:
4358
4359 2019-02-20  Chris Dumez  <cdumez@apple.com>
4360
4361         Add API test for <rdar://problem/47471222>
4362         https://bugs.webkit.org/show_bug.cgi?id=194847
4363
4364         Reviewed by Alex Christensen.
4365
4366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4367
4368 2019-02-20  Chris Dumez  <cdumez@apple.com>
4369
4370         Regression(PSON) "Reload without content extensions" does not wo