Unreviewed, add WebKitGTK+ Bugzilla email to committers list
[WebKit-https.git] / Tools / ChangeLog
1 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
4
5         This is to make it easy to CC it on Bugzilla.
6
7         * Scripts/webkitpy/common/config/contributors.json:
8
9 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
10
11         Pasteboard get messed up after running kill-old-processes
12         https://bugs.webkit.org/show_bug.cgi?id=152426
13
14         Reviewed by Alexey Proskuryakov.
15
16         * BuildSlaveSupport/kill-old-processes:
17         (main): Do not kill pasteboard anymore.
18
19 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
20
21         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
22         https://bugs.webkit.org/show_bug.cgi?id=152157
23         <rdar://problem/23851817>
24
25         Reviewed by Alexey Proskuryakov.
26
27         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
28         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
29         * Scripts/webkitpy/layout_tests/controllers/manager.py:
30         (Manager._get_test_inputs): Common method to calculate test_inputs.
31         (Manager._update_worker_count): Calculate and update required number of workers.
32
33 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
34
35         run-webkit-tests fails to delete Simulator device during cleanup
36         https://bugs.webkit.org/show_bug.cgi?id=152363
37
38         Reviewed by Alexey Proskuryakov.
39
40         * Scripts/webkitpy/xcode/simulator.py:
41         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
42
43 2015-12-16  Tim Horton  <timothy_horton@apple.com>
44
45         [mac-wk2] fast/events force click tests crashing
46         https://bugs.webkit.org/show_bug.cgi?id=152339
47
48         Reviewed by Beth Dakin.
49
50         * WebKitTestRunner/mac/EventSenderProxy.mm:
51         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
52         Set the NSEvent's _type member in addition to overriding -type,
53         because there are assertions in touch event handling code that depend on it.
54
55 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
56
57         Enforce temporarily bots to sync WebKit and WPT testharness.js
58         https://bugs.webkit.org/show_bug.cgi?id=152334
59
60         Reviewed by Darin Adler.
61
62         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
63         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
64
65 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
66
67         [Fetch API] Add fetch API compile time flag
68         https://bugs.webkit.org/show_bug.cgi?id=152254
69
70         Reviewed by Darin Adler.
71
72         * Scripts/webkitperl/FeatureList.pm:
73
74 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
75
76         Unreviewed.
77
78         Added files that have impact in building Streams API to the watchlist.
79
80         * Scripts/webkitpy/common/config/watchlist:
81
82 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
83
84         Unreviewed.
85
86         Added imported tests to Streams API watchlist.
87
88         * Scripts/webkitpy/common/config/watchlist:
89
90 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
91
92         Remove default copy of wpt testharness.js when launching wpt server
93         https://bugs.webkit.org/show_bug.cgi?id=152298
94
95         Reviewed by Darin Adler.
96
97         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
98         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
99
100 2015-12-15  David Kilzer  <ddkilzer@apple.com>
101
102         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
103         <http://webkit.org/b/152314>
104
105         Reviewed by Daniel Bates.
106
107         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
108         code path to exit immediately when calling main().
109         Unfortunately, DumpRenderTreeMain.mm was used for both
110         DumpRenderTree command-line binary and DumpRenderTree.app, which
111         meant that the app would exit immediately with no error code
112         when run!
113
114         The workaround is to introduce a separate source file called
115         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
116         already does.
117
118         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
119         DumpRenderTreeAppMain.mm to the project.  Make it the only
120         compiled source for the DumpRenderTree.app target.
121         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
122         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
123         case someone tries mistakenly to use the app.
124         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
125         Link to JavaScriptCore.framework on iOS for the assert.
126         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
127         Link to JavaScriptCore.framework on OS X for the assert.  Remove
128         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
129         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
130         (main): Add assert for iOS so that a crash occurs if someone
131         tries to run the wrong command.
132
133 2015-12-14  Tim Horton  <timothy_horton@apple.com>
134
135         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
136         https://bugs.webkit.org/show_bug.cgi?id=152266
137         <rdar://problem/22092676>
138
139         Reviewed by Simon Fraser.
140
141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
142         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
143         Add a test that crashed before this change, and doesn't crash after.
144
145 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
146
147         AX: iOS: Text field variations do not have the correct traits
148         https://bugs.webkit.org/show_bug.cgi?id=152237
149
150         Reviewed by Mario Sanchez Prada.
151
152         Add iOS calls for determing if an object is a search field or a text area.
153
154         * DumpRenderTree/AccessibilityUIElement.cpp:
155         (getIsSearchFieldCallback):
156         (getIsTextAreaCallback):
157         (stringForSelectionCallback):
158         (AccessibilityUIElement::getJSClass):
159         * DumpRenderTree/AccessibilityUIElement.h:
160         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
161         (AccessibilityUIElement::identifier):
162         (AccessibilityUIElement::isTextArea):
163         (AccessibilityUIElement::isSearchField):
164         (AccessibilityUIElement::traits):
165         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
166         (WTR::AccessibilityUIElement::scrollPageRight):
167         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
168         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
169         (WTR::AccessibilityUIElement::isSearchField):
170         (WTR::AccessibilityUIElement::isTextArea):
171         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
172         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
173         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
174         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
175         (WTR::AccessibilityUIElement::isTextArea):
176         (WTR::AccessibilityUIElement::isSearchField):
177         (WTR::AccessibilityUIElement::rowCount):
178
179 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
180
181         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
182         https://bugs.webkit.org/show_bug.cgi?id=152252
183
184         Reviewed by Sergio Villar Senin.
185
186         * gtk/install-dependencies: Add libtool-bin to the list of packages required
187         for building the JHBuild on Debian systems.
188
189 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
190
191         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
192         https://bugs.webkit.org/show_bug.cgi?id=152156
193
194         Reviewed by Dan Bernstein.
195
196         Our frameworks should appropriately prefix all ObjC classes,
197         not just external symbols.
198
199         * Scripts/check-for-inappropriate-objc-class-names:
200         Remove the -g switch to check all ObjC class names.
201
202 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
203
204         [MediaStream] Expose media capture devices persistent permissions to WebCore
205         https://bugs.webkit.org/show_bug.cgi?id=152087
206
207         Add support for the new user media permission checker page UI client method.
208
209         Reviewed by Chris Dumez.
210
211         * WebKitTestRunner/TestController.cpp:
212         (WTR::decidePolicyForUserMediaPermissionRequest):
213         (WTR::checkUserMediaPermissionForOrigin):
214         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
215         (WTR::TestController::createWebViewWithOptions): Ditto.
216         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
217         (WTR::originUserVisibleName): New, create a string for the origin.
218         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
219           according to the state of the origin permission map.
220         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
221           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
222         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
223           origin permission map.
224         * WebKitTestRunner/TestController.h:
225
226 2015-12-10  Alex Christensen  <achristensen@webkit.org>
227
228         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
229         https://bugs.webkit.org/show_bug.cgi?id=152022
230         rdar://problem/23763584
231
232         Reviewed by Darin Adler.
233
234         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
235         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
236         (WTR::InjectedBundlePage::willSendRequestForFrame):
237         * WebKitTestRunner/InjectedBundle/TestRunner.h:
238         (WTR::TestRunner::setWillSendRequestReturnsNull):
239         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
240         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
241         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
242         (WTR::TestRunner::willSendRequestHTTPBody):
243         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
244
245 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
246
247         Remove additional simulator checks before running layout-tests
248         https://bugs.webkit.org/show_bug.cgi?id=152146
249
250         Reviewed by Darin Adler.
251
252         * Scripts/webkitpy/port/ios.py:
253         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
254         * Scripts/webkitpy/xcode/simulator.py:
255         (Simulator._boot_and_shutdown_simulator_device): Deleted.
256         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
257
258 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
259
260         Run atleast one simulator even if max process limit is low
261         https://bugs.webkit.org/show_bug.cgi?id=152081
262         <rdar://problem/23819694>
263
264         Reviewed by Alexey Proskuryakov.
265
266 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
267
268         [GTK] Crash in WebProcess when loading large content with custom URI schemes
269         https://bugs.webkit.org/show_bug.cgi?id=144262
270
271         Reviewed by Carlos Garcia Campos.
272
273         Added new unit test to check the additional scenarios we now
274         handle for custom URI schemes.
275
276         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
277         (generateHTMLContent): New helper function to generate big enough content.
278         (testWebContextURIScheme): New unit test.
279
280 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
281
282         [EFL] Fix unhandled web process message when launching MiniBrowser
283         https://bugs.webkit.org/show_bug.cgi?id=152048
284
285         Reviewed by Gyuyoung Kim.
286
287         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
288         (TestWebKitAPI::TEST):
289
290 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
291
292         [GTK] Add API to handle beforeunload events
293         https://bugs.webkit.org/show_bug.cgi?id=139090
294
295         Reviewed by Gustavo Noronha Silva.
296
297         * MiniBrowser/gtk/BrowserWindow.c:
298         (browserWindowConstructed):
299         (browserWindowDeleteEvent):
300         (browser_window_class_init):
301         Handle delete-event to prevent the window from being closed when
302         the page has beforeunload handlers. Use
303         webkit_web_view_try_close() when the window is requested to be
304         closed.
305         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
306         (testWebViewJavaScriptDialogs):
307         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
308         script dialog type.
309
310 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
311
312         Refactored initialization code in LoadTrackingTest.
313
314         Rubber-stamped by Carlos Garcia Campos.
315
316         Small refactoring to make sure that the state of a LoadTrackingTest
317         gets properly reset before loading new web content.
318
319         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
320         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
321         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
322         functions and reset the remaining local variables.
323         (LoadTrackingTest::loadURI): Call reset();
324         (LoadTrackingTest::loadHtml): Ditto.
325         (LoadTrackingTest::loadPlainText): Ditto.
326         (LoadTrackingTest::loadBytes): Ditto.
327         (LoadTrackingTest::loadRequest): Ditto.
328         (LoadTrackingTest::reload): Ditto.
329         (LoadTrackingTest::goBack): Ditto.
330         (LoadTrackingTest::goForward): Ditto.
331
332 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
333
334         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
335         https://bugs.webkit.org/show_bug.cgi?id=151942
336
337         Reviewed by Darin Adler.
338
339         * MiniBrowser/efl/main.c:
340         (window_create): Enable offline web application cache feature on MiniBrowser.
341         (elm_main):
342
343 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
344
345         https://bugs.webkit.org/show_bug.cgi?id=151243
346         <rdar://problem/22955197>
347
348         Reviewed by Alexey Proskuryakov.
349
350         * LayoutTestRelay/LayoutTestRelay/main.m:
351         (getTestingSimDevice): Use separate testing device for each worker.
352         * Scripts/webkitpy/layout_tests/controllers/manager.py:
353         (Manager.run): Perform cleanup even if setup fails.
354         * Scripts/webkitpy/port/ios.py:
355         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
356         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
357         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
358         (IOSSimulatorPort._quit_ios_simulator): Same
359         (IOSSimulatorPort.clean_up_test_run): Same
360         (IOSSimulatorPort.check_sys_deps): Same
361         (IOSSimulatorPort.testing_device): Same
362         (IOSSimulatorPort.reset_preferences): Same
363         (IOSSimulatorPort.get_simulator_path): Return simulator path.
364         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
365         * Scripts/webkitpy/xcode/simulator.py:
366         (Device.delete): Delete the simulator device.
367         (Simulator.delete_device): Same
368         (Simulator.wait_until_device_is_booted): Wait for device booting.
369
370 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
371
372         [EFL] Add API to provide preferences before creating ewk_view
373         https://bugs.webkit.org/show_bug.cgi?id=151587
374
375         Reviewed by Gyuyoung Kim.
376
377         * MiniBrowser/efl/main.c:
378         (on_key_down):
379         (quit):
380         (window_create):
381         Moved settings related code to configuration() not to update settings
382         whenever ewk_view is created.
383         (configuration):
384         (elm_main):
385
386 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
387
388         Unreviewed. Fix GTK+ API tests after r193639.
389
390         The new jhbuild version needs some more variables ot be present in
391         the builtin dict, even if they are set to None.
392
393         * jhbuild/jhbuildutils.py:
394         (enter_jhbuild_environment_if_available):
395
396 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
397
398         [GTK] Notify WebCore when notification is clicked
399         https://bugs.webkit.org/show_bug.cgi?id=151951
400
401         Reviewed by Carlos Garcia Campos.
402
403         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
404         (testWebViewNotification): test the new API.
405
406 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
407
408         'jhbuild build' should fail immediately when building any module fails
409         https://bugs.webkit.org/show_bug.cgi?id=145697
410
411         Reviewed by Carlos Garcia Campos.
412
413         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
414         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
415         Everything is placed under lib instead of lib64 now.
416         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
417         --exit-on-error when running 'jhbuild build'.
418         * jhbuild/jhbuildrc_common.py:
419         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
420         jhbuild should be able to handle these for us without breaking things....
421
422 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
423
424         Add support to import w3c tests from a repository with a different root that the main repo dir
425         https://bugs.webkit.org/show_bug.cgi?id=151751
426
427         Reviewed by Ryosuke Niwa and Youenn Fablet.
428
429         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
430         in a different directory than the repository root.
431
432         This patch introduces a new parameter tests_directory that we will use as root directory to search for
433         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
434         requires having the copy_path lists including tuples of origin and destination directories.
435
436         * Scripts/webkitpy/w3c/test_downloader.py:
437         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
438         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
439         * Scripts/webkitpy/w3c/test_importer_unittest.py:
440         (TestImporterTest.test_tests_directory): Test.
441
442 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
443
444         Mock TestRepositories in W3C importer tests
445         https://bugs.webkit.org/show_bug.cgi?id=151938
446
447         Reviewed by Youenn Fablet.
448
449         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
450         is because the test repository method reading the file was using the filesystem directly instead of taking the
451         host one. This patch changes that.
452
453         * Scripts/webkitpy/w3c/test_downloader.py:
454         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
455         default one.
456         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
457         * Scripts/webkitpy/w3c/test_importer_unittest.py:
458         (TestImporterTest.test_harnesslinks_conversion):
459         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
460
461 2015-12-07  David Kilzer  <ddkilzer@apple.com>
462
463         TestNetscapePlugIn: Address review comment on 193607
464         <http://webkit.org/b/151881>
465
466         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
467         (testSetStatus): Initializing std::unique_ptr<char[]> with
468         nullptr is redundant.
469
470 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
471
472         [GTK] Add webkit_uri_request_get_http_method
473         https://bugs.webkit.org/show_bug.cgi?id=151601
474
475         Reviewed by Martin Robinson.
476
477         Add test case to check HTTP method of WebKitURIRequest.
478
479         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
480         (testURIRequestHTTPMethod):
481         (serverCallback):
482         (beforeAll):
483         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
484         (sendRequestCallback):
485
486 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
487
488         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
489         https://bugs.webkit.org/show_bug.cgi?id=79918
490
491         Reviewed by Gustavo Noronha Silva.
492
493         Add unit tests to check the different console messages.
494
495         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
496         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
497         (ConsoleMessageTest::ConsoleMessage::operator==):
498         (ConsoleMessageTest::consoleMessageReceivedCallback):
499         (ConsoleMessageTest::ConsoleMessageTest):
500         (ConsoleMessageTest::~ConsoleMessageTest):
501         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
502         (testWebKitConsoleMessageConsoleAPI):
503         (testWebKitConsoleMessageJavaScriptException):
504         (testWebKitConsoleMessageNetworkError):
505         (testWebKitConsoleMessageSecurityError):
506         (beforeAll):
507         (afterAll):
508         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
509         (consoleMessageSentCallback):
510         (pageCreatedCallback):
511
512 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
513
514         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
515         https://bugs.webkit.org/show_bug.cgi?id=151934
516
517         Reviewed by Csaba Osztrogonác.
518
519         * MiniBrowser/efl/main.c:
520         (on_window_deletion): Revert the changes of r192767.
521
522 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
523
524         [GTK] update-webkitgtk-libs cannot build mesa
525         https://bugs.webkit.org/show_bug.cgi?id=151535
526
527         Reviewed by Martin Robinson.
528
529         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
530         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
531         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
532         does not have a stable API and we cannot expect mesa to be buildable unless we control the
533         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
534         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
535
536         * gtk/jhbuild.modules:
537
538 2015-12-07  Philippe Normand  <pnormand@igalia.com>
539
540         [GTK][Mac] libWebExtensionTest link error
541         https://bugs.webkit.org/show_bug.cgi?id=150802
542
543         Reviewed by Carlos Garcia Campos.
544
545         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
546
547 2015-12-06  David Kilzer  <ddkilzer@apple.com>
548
549         TestNetscapePlugIn: Fix leaks found by static analyzer
550         <http://webkit.org/b/151881>
551
552         Reviewed by Darin Adler.
553
554         Fixes the following leaks found by the static analyzer:
555             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
556                     return false;
557                            ^~~~~
558             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
559                     return false;
560                            ^~~~~
561             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
562                     return false;
563                            ^~~~~
564
565         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
566         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
567         early return if allocation fails.
568         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
569         Make sure to call fclose() on filehandle, even for an early
570         return.
571         (testSetStatus): Switch to using std::unique_ptr<char[]>.
572
573 2015-12-05  David Kilzer  <ddkilzer@apple.com>
574
575         prepare-ChangeLog: Fix some warning messages when using svn
576         <http://webkit.org/b/151914>
577
578         Reviewed by Daniel Bates.
579
580         * Scripts/prepare-ChangeLog:
581         (generateFunctionLists): Simplify logic so that we never call
582         normalizePath() with an undefined value.
583         (attributeCommand): Quote $subPath for the shell so that we
584         don't try to run "svn propget" on invalid paths.
585
586 2015-12-04  David Kilzer  <ddkilzer@apple.com>
587
588         TestNetscapePlugIn: Fix remaining static analyzer warnings
589         <http://webkit.org/b/151888>
590
591         Reviewed by Alexey Proskuryakov.
592
593         Fixes the following static analyzer warnings:
594             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
595                     CRASH();
596                     ^~~~~~~
597             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
598                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
599                 ^~~~~~~~~~~~~~~~
600             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
601                 return obj->pluginTest->NPP_SetWindow(window);
602                        ^~~~~~~~~~~~~~~
603             2 warnings generated.
604
605         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
606         (CRASH): Use __builtin_trap() for gcc/clang.
607         (NPP_SetWindow): Add early return if obj is nullptr.
608
609 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
610
611         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
612         https://bugs.webkit.org/show_bug.cgi?id=151797
613
614         Reviewed by Martin Robinson.
615
616         Since we switched to use the network process to run the unit tests
617         the test /webkit2/WebKitWebResource/get-data sometimes fails and
618         sometimes passes. We are now also getting the notification for the
619         css image. Since we wait for 3 resources, sometimes the css image
620         is loaded before and then checkResourceData is called for it, but
621         not handled. When the css image is the last one loaded the test
622         passes. So, we just need to wait for the 4 resources.
623
624         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
625         (testWebResourceGetData):
626
627 2015-12-03  David Kilzer  <ddkilzer@apple.com>
628
629         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
630         <http://webkit.org/b/151845>
631
632         Reviewed by Simon Fraser.
633
634         Fixes the following static analyzer warning:
635             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
636                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
637                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
638
639         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
640         (createBitmapContext): Free 'buffer' after using it in logging
641         to fix the use-after-free.  Assign a value of nullptr to buffer
642         so we don't return with it set to a freed address.
643
644 2015-12-03  Jer Noble  <jer.noble@apple.com>
645
646         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
647         https://bugs.webkit.org/show_bug.cgi?id=151830
648
649         Reviewed by Anders Carlsson.
650
651         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
652
653         * DumpRenderTree/mac/DumpRenderTree.mm:
654         (resetWebPreferencesToConsistentValues):
655         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
656         (WTR::initializeWebViewConfiguration):
657
658 2015-12-03  Anders Carlsson  <andersca@apple.com>
659
660         Remove Objective-C GC support
661         https://bugs.webkit.org/show_bug.cgi?id=151819
662         rdar://problem/23746991
663
664         Reviewed by Dan Bernstein.
665
666         * asan/asan.xcconfig:
667
668 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
669
670         Allow nil for unspecified benchmark pathes
671         https://bugs.webkit.org/show_bug.cgi?id=151784
672
673         Reviewed by Filip Pizlo.
674
675         `Pathname.new(nil)` will raise an error.
676         Only generate Pathname if the benchmark path is specified.
677
678         * Scripts/run-jsc-benchmarks:
679
680 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
681
682         [Win] Run non-http tests without Cygwin
683         https://bugs.webkit.org/show_bug.cgi?id=151721
684
685         Reviewed by Andy Estes.
686
687         Support native 32-bit and 64-bit Python (and Perl) builds
688         for running tests:
689
690         1. Use "startswith('win')", rather than "== 'win32'" to support
691         various Windows build types.
692         2. Supply full path for some native Windows utilities, since the
693         path environment does not always have the specified, and they are
694         guaranteed to exist in those specific locations.
695         3. Make sure native Windows Python test runs pass proper environment
696         variables to run programs.
697         4. Append 'exe' suffix when running Windows executables.
698         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
699         command doesn't exist.
700         
701         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
702         the current Perl executable, rather than requiring a new path search.
703         * Scripts/webkitpy/common/find_files_unittest.py:
704         (TestWinNormalize.test_win): Use startswith('win').
705         * Scripts/webkitpy/common/prettypatch_unittest.py:
706         (test_pretty_diff_encodings): Ditto.
707         * Scripts/webkitpy/common/system/executive.py:
708         (Executive._should_close_fds): Ditto.
709         (Executive.shell_command_for_script): Use startswith('win').
710         (Executive.kill_process): Use full path to killall executable.
711         (Executive.check_running_pid): Use startswith('win').
712         (Executive.running_pids): Ditto.
713         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
714         running under native Windows Python.
715         (Executive._child_process_encoding): Use startswith('win').
716         (Executive._should_encode_child_process_arguments): Ditto.
717         (Executive.popen): Recognize proper script engine on Windows, since it
718         does not support the shebang syntax.
719         (Executive.run_in_parallel): Use startswith('win').
720         * Scripts/webkitpy/common/system/executive_unittest.py:
721         (never_ending_command): Ditto.
722         (ExecutiveTest.test_run_command_with_unicode): Ditto.
723         (ExecutiveTest.serial_test_kill_process): Ditto.
724         (ExecutiveTest.serial_test_kill_all): Ditto.
725         (ExecutiveTest.serial_test_check_running_pid): Ditto.
726         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
727         (main): Ditto.
728         * Scripts/webkitpy/common/system/file_lock.py:
729         (FileLock._create_lock): Ditto.
730         (FileLock._remove_lock): Ditto.
731         * Scripts/webkitpy/common/system/filesystem_unittest.py:
732         (RealFileSystemTest.test_chdir): Ditto.
733         (RealFileSystemTest.test_chdir__notexists): Ditto.
734         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
735         * Scripts/webkitpy/common/system/path_unittest.py:
736         (AbspathTest.test_abspath_to_uri_win): Ditto.
737         * Scripts/webkitpy/common/system/platforminfo.py:
738         (PlatformInfo._determine_os_name): Ditto.
739         * Scripts/webkitpy/common/system/user.py: Ditto.
740         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
741         (ManagerTest.integration_test_needs_servers): Ditto.
742         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
743         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
744         driver letters.
745         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
746         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
747         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
748         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
749         (HttpServerBase._check_that_all_ports_are_available): Ditto.
750         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
751         (TestHttpServer.test_start_cmd): Ditto.
752         * Scripts/webkitpy/port/base.py:
753         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
754         and 'SYSTEMROOT' in environment passed to test runners.
755         (Port._apache_config_file_name_for_platform): Use startswith('win').
756         (Port._build_path): Ditto.
757         (Port._path_to_driver): Include 'exe' suffix when running under native
758         Windows.
759         * Scripts/webkitpy/port/driver.py:
760         (Driver._setup_environ_for_driver): Explicitly make some environment
761         variables strings.
762         * Scripts/webkitpy/port/server_process.py:
763         (ServerProcess.__init__): Use startswith('win').
764         * Scripts/webkitpy/port/win.py:
765         (WinPort): Use the win32 registry utilities on Windows, and appropriate
766         registry key formats.
767         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
768         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
769         and regtool on Cygwin.
770         (WinPort.write_registry_value): Ditto.
771         (WinPort.setup_crash_log_saving): Ditto.
772         (WinPort.restore_crash_log_saving): Ditto.
773         (WinPort.prevent_error_dialogs): Ditto.
774         (WinPort.allow_error_dialogs): Ditto.
775         (WinPort.find_system_pid): Revise to use Windows management
776         infrastructure on native Windows, continue using 'ps' on Cygwin.
777         (WinPort.read_registry_string): Deleted.
778         (WinPort.write_registry_string): Deleted.
779         * Scripts/webkitpy/test/main.py:
780         (main): Use startswith('win').
781         (Tester._parse_args): Ditto.
782
783 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
784
785         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
786         https://bugs.webkit.org/show_bug.cgi?id=150792
787
788         Reviewed by Saam Barati.
789
790         * Scripts/webkitperl/FeatureList.pm:
791
792 2015-12-01  Commit Queue  <commit-queue@webkit.org>
793
794         Unreviewed, rolling out r192914.
795         https://bugs.webkit.org/show_bug.cgi?id=151734
796
797         JSC tests for this change are failing on 32 and 64-bit bots
798         (Requested by ryanhaddad on #webkit).
799
800         Reverted changeset:
801
802         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
803         enable this feature"
804         https://bugs.webkit.org/show_bug.cgi?id=150792
805         http://trac.webkit.org/changeset/192914
806
807 2015-12-01  David Kilzer  <ddkilzer@apple.com>
808
809         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
810         <http://webkit.org/b/151726>
811
812         Reviewed by Simon Fraser.
813
814         * WebKitTestRunner/mac/EventSenderProxy.mm:
815         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
816         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
817
818 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
819
820         Give String and AtomicString an existingHash() function
821         https://bugs.webkit.org/show_bug.cgi?id=151717
822
823         Reviewed by Andreas Kling.
824
825         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
826         (TestWebKitAPI::TEST):
827         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
828         (TestWebKitAPI::TEST):
829
830 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
831
832         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
833         https://bugs.webkit.org/show_bug.cgi?id=150792
834
835         Reviewed by Saam Barati.
836
837         * Scripts/webkitperl/FeatureList.pm:
838
839 2015-12-01  Sam Weinig  <sam@webkit.org>
840
841         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
842         <rdar://problem/23320863>
843         https://bugs.webkit.org/show_bug.cgi?id=151708
844
845         Reviewed by Anders Carlsson.
846
847         * WebKitTestRunner/TestController.cpp:
848         (WTR::TestController::createOtherPage):
849         (WTR::TestController::createWebViewWithOptions):
850         Update for new WKPageUIClient.
851
852 2015-12-01  Anders Carlsson  <andersca@apple.com>
853
854         Remove WebKit2.framework
855         https://bugs.webkit.org/show_bug.cgi?id=151715
856
857         Reviewed by Dan Bernstein.
858
859         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
860         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
861         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
862         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
863         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
864         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
865         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
866
867 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
868
869         Unreviewed common typo fix "occurance" => "occurrence".
870
871         * Scripts/webkitpy/tool/commands/queries.py:
872         (FindFlakyTests._print_statistics):
873
874 2015-11-30  Alex Christensen  <achristensen@webkit.org>
875
876         Make ProcessModel always MultipleSecondaryProcesses
877         https://bugs.webkit.org/show_bug.cgi?id=151662
878
879         Reviewed by Antti Koivisto.
880
881         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
882         (TestWebKitAPI::TEST):
883         * WebKitTestRunner/TestController.cpp:
884         (WTR::TestController::generatePageConfiguration):
885
886 2015-11-30  Alex Christensen  <achristensen@webkit.org>
887
888         Make usesNetworkProcess always true
889         https://bugs.webkit.org/show_bug.cgi?id=151580
890
891         Reviewed by Darin Adler.
892
893         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
894         (TestWebKitAPI::TEST):
895         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
896         (TestWebKitAPI::TEST):
897         * WebKitTestRunner/TestController.cpp:
898         (WTR::TestController::generatePageConfiguration):
899
900 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
901
902         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
903
904         Add a way to skip unit tests only for Debug or Release builds and
905         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
906
907         * Scripts/run-gtk-tests:
908         (SkippedTest):
909         (SkippedTest.__init__):
910         (SkippedTest.__str__):
911         (SkippedTest.skip_entire_suite):
912         (SkippedTest.skip_for_build_type):
913         (TestRunner):
914         (TestRunner.__init__):
915
916 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
917
918         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
919
920         It's an assert hit because we are reloading a view loaded with
921         HTML data which is not supported. Use loadURI instead.
922
923         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
924         (testWebViewCustomCharset):
925
926 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
927
928         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
929         https://bugs.webkit.org/show_bug.cgi?id=151633
930
931         Reviewed by Csaba Osztrogonác.
932
933         * TestWebKitAPI/PlatformGTK.cmake:
934         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
935
936 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
937
938         [GTK] Remove the remaining uses of GMainLoopSource
939         https://bugs.webkit.org/show_bug.cgi?id=151632
940
941         Reviewed by Žan Doberšek.
942
943         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
944         (testWebViewSyncRequestOnMaxConns):
945         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
946         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
947         (WTR::TestRunner::TestRunner):
948         * WebKitTestRunner/InjectedBundle/TestRunner.h:
949         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
950         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
951         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
952         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
953         (WTR::timeoutSource):
954         (WTR::TestController::notifyDone):
955         (WTR::TestController::platformRunUntil):
956
957 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
958
959         [cmake] Add testb3 to the build system
960         https://bugs.webkit.org/show_bug.cgi?id=151619
961
962         Reviewed by Gyuyoung Kim.
963
964         * Scripts/build-jsc:
965
966 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
967
968         [jhbuild] Fix pixman build with clang
969         https://bugs.webkit.org/show_bug.cgi?id=151441
970
971         Reviewed by Carlos Garcia Campos.
972
973         * efl/jhbuild.modules:
974         * gtk/jhbuild.modules:
975
976 2015-11-26  David Kilzer  <ddkilzer@apple.com>
977
978         Extract prependToEnvironmentVariableList
979         <http://webkit.org/b/151536>
980
981         Reviewed by Daniel Bates.
982
983         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
984                webkitdirs_unittest/prependToEnvironmentVariableList.pl
985
986         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
987         and prependToEnvironmentVariableList.
988         (appendToEnvironmentVariableList): Simplify variable name.
989         Switch to use $Config{path_sep}.
990         (prependToEnvironmentVariableList): Add new method.
991         (setupMacWebKitEnvironment): Switch to use
992         prependToEnvironmentVariableList().
993         (setupIOSWebKitEnvironment): Ditto.
994
995         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
996         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
997
998 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
999
1000         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1001         https://bugs.webkit.org/show_bug.cgi?id=151567
1002
1003         Reviewed by Darin Adler.
1004
1005         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1006         (on_window_deletion):
1007
1008 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1009
1010         [GTK] Use the network process unconditionally
1011         https://bugs.webkit.org/show_bug.cgi?id=151541
1012
1013         Reviewed by Alex Christensen.
1014
1015         Fix TestInspectorServer test. Do not assume we already have the
1016         title we want when the page has been loaded, since the title is
1017         changed afterwards. So, check if the title has already been set,
1018         and if not wait for it.
1019
1020         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1021         (openRemoteDebuggingSession):
1022
1023 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1024
1025         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1026         https://bugs.webkit.org/show_bug.cgi?id=151532
1027
1028         Reviewed by Benjamin Poulain.
1029
1030         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1031         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1032         (TestWebKitAPI::TEST):
1033         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1034         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1035         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1036         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1037         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1038         so it was calling a function on a test object that had gone out of scope.
1039         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1040         but that will become the default soon and that call will be removed.
1041
1042 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1043
1044         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1045         <http://webkit.org/b/151542>
1046
1047         Reviewed by Daniel Bates.
1048
1049         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1050         (base_url): Use the Port object (already passed in) to give us
1051         the path to the LayoutTests directory, which already checks for a
1052         --layout-tests-directory command-line switch.
1053         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1054         argument since we can get this from the Port object already
1055         passed in via Port.results_directory().  Also switch to use
1056         Port.layout_tests_dir() to get the LayoutTests directory.
1057
1058         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1059         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1060         Add test case for custom LayoutTests directory.
1061         (TestWebPlatformTestServer.test_previously_spawned_instance):
1062         Update Port object to set mock results directory as if it was
1063         set on the command-line.  Remove unneeded argument from
1064         WebPlatformTestServer constructor.
1065         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1066
1067         * Scripts/webkitpy/port/base.py:
1068         (Port.to.start_web_platform_test_server): Remove unneeded
1069         argument from WebPlatformTestServer constuctor.
1070
1071 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1072
1073         [GTK] Some unit tests fail when using the network process
1074         https://bugs.webkit.org/show_bug.cgi?id=151490
1075
1076         Reviewed by Martin Robinson.
1077
1078         Run the soup server in a separate thread in TestResources test to
1079         avoid deadlocks.
1080
1081         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1082         /webkit2/WebKitWebResource/get-data when using the network process.
1083
1084         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1085         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1086         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1087         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1088         present, create a WorkQueue to run the server.
1089         (WebKitTestServer::run): Run the server in the work queue if it
1090         has been created.
1091         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1092         type into server options as flags.
1093
1094 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1095
1096         [GTK] ImageDiff should normalize the diff image
1097         https://bugs.webkit.org/show_bug.cgi?id=151261
1098
1099         Reviewed by Sergio Villar Senin.
1100
1101         * ImageDiff/gtk/ImageDiff.cpp:
1102         (readPixbufFromStdin): Fix memory leak.
1103         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1104         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1105
1106 == Rolled over to ChangeLog-2015-11-21 ==