[CMake] build-webkit should print the cmake command executed
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         [CMake] build-webkit should print the cmake command executed
4         https://bugs.webkit.org/show_bug.cgi?id=168318
5
6         Reviewed by Michael Catanzaro.
7
8         Run the cmake commands to configure or start the build through
9         a wrapper that prints the command before executing it.
10
11         * Scripts/webkitdirs.pm:
12         (systemVerbose):
13         (generateBuildSystemFromCMakeProject):
14         (buildCMakeGeneratedProject):
15         (cleanCMakeGeneratedProject):
16
17 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
18
19         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
20         https://bugs.webkit.org/show_bug.cgi?id=168150
21
22         Reviewed by Alexey Proskuryakov.
23
24         * Scripts/webkitpy/port/simulator_process.py:
25         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
26         (SimulatorProcess._kill): Move closing of app into stop().
27         * Scripts/webkitpy/xcode/simulator.py:
28         (Device.launch_app):
29         (Device.terminate_app): Deleted.
30
31 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
32
33         REGRESSION(r212192): [GTK] Broke downloads API tests
34         https://bugs.webkit.org/show_bug.cgi?id=168193
35
36         Unreviewed. Update test expectations after r212192.
37
38         The suggested filename now includes a file extensions if the MIME type is known.
39
40         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
41         (testDownloadRemoteFile):
42         (testDownloadMIMEType):
43
44 2017-02-14  Commit Queue  <commit-queue@webkit.org>
45
46         Unreviewed, rolling out r212237.
47         https://bugs.webkit.org/show_bug.cgi?id=168298
48
49         This was a wrong fix (Requested by rniwa on #webkit).
50
51         Reverted changeset:
52
53         "Nwtr unexpectedly passes mismatch ref test if the hashes
54         doesn't match but no diff"
55         https://bugs.webkit.org/show_bug.cgi?id=168221
56         http://trac.webkit.org/changeset/212237
57
58 2017-02-13  Alex Christensen  <achristensen@webkit.org>
59
60         URLs with an invalid IPv4 address should be invalid
61         https://bugs.webkit.org/show_bug.cgi?id=168260
62
63         Reviewed by Tim Horton.
64
65         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
66         (TestWebKitAPI::TEST_F):
67         Update tests to reflect new correct behavior.
68
69 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
70
71         [WinCairo] Add Build Slave
72         https://bugs.webkit.org/show_bug.cgi?id=168263
73
74         Reviewed by Lucas Forschler.
75
76         * BuildSlaveSupport/build.webkit.org-config/config.json:
77
78 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
79
80         Fix the build after r212254
81
82         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
83         (-[DataInteractionSimulator _currentLocation]):
84
85 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
86
87         [WK2] Add test infrastructure and unit tests for data interaction
88         https://bugs.webkit.org/show_bug.cgi?id=168159
89         <rdar://problem/30477634>
90
91         Reviewed by Tim Horton.
92
93         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
94         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
95         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
96         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
97         gesture has already been recognized) at regular intervals over the course of the test.
98
99         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
100         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
101         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
102         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
103
104         New test pages for data interaction.
105
106         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
107         (TestWebKitAPI::runTestsExpectingToObserveEvents):
108         (TestWebKitAPI::TEST):
109         * TestWebKitAPI/cocoa/TestWKWebView.mm:
110         (-[TestWKWebView stringByEvaluatingJavaScript:]):
111         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
112         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
113         (-[MockLongPressGestureRecognizer initWithWindow:]):
114         (-[MockLongPressGestureRecognizer locationInView:]):
115         (-[MockLongPressGestureRecognizer state]):
116         (-[MockLongPressGestureRecognizer numberOfTouches]):
117         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
118         (-[DataInteractionSimulator dealloc]):
119         (-[DataInteractionSimulator run]):
120
121         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
122         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
123         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
124
125         (-[DataInteractionSimulator _advanceProgress]):
126
127         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
128         completed, and calls _finishDataInteraction when progress is at 1.
129
130         (-[DataInteractionSimulator _finishDataInteraction]):
131         (-[DataInteractionSimulator _currentLocation]):
132         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
133         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
134         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
135         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
136         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
137
138 2017-02-13  Alex Christensen  <achristensen@webkit.org>
139
140         Percent should be allowed in non-special URL hosts
141         https://bugs.webkit.org/show_bug.cgi?id=168255
142
143         Reviewed by Tim Horton.
144
145         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
146         (TestWebKitAPI::TEST_F):
147
148 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
149
150         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
151         https://bugs.webkit.org/show_bug.cgi?id=168221
152
153         Reviewed by Ryosuke Niwa.
154
155         There is a logic error in comparing mismatch ref test images. In
156         mismatch ref tests, it should be failed if two images has no diff.
157         But, if the hashes are different, nwtr unexpectedly pass the
158         mismatch ref test.
159
160         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
161         (SingleTestRunner._compare_output_with_reference): Fail the
162         mismatch ref test if hashes of two images are equal. Invoke
163         ImageDiff if the hashes don't match.
164
165 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
166
167         Update custom line breaking iterators to the latest version of Unicode
168         https://bugs.webkit.org/show_bug.cgi?id=168182
169
170         Reviewed by Zalan Bujtas.
171
172         Treat the system's ICU as the source of truth to compare breaking positions against.
173
174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
175         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
176         (generateJavaScriptForTest):
177         (breakingLocationsFromICU):
178         (testAFewStrings):
179         (TEST):
180         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
181         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
182
183 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
184
185         [GTK] Several failing WebViewEditor API tests
186         https://bugs.webkit.org/show_bug.cgi?id=161608
187
188         Reviewed by Carlos Garcia Campos.
189
190         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
191         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
192         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
193         except the first one, which is still broken due to unrelated bug #151654.
194
195         * Scripts/run-gtk-tests:
196         (TestRunner):
197         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
198
199 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
200
201         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
202
203         * Scripts/run-gtk-tests:
204         (TestRunner):
205
206 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
207
208         Unreviewed, skip flaky form-controls-associated-signal test
209
210         * Scripts/run-gtk-tests:
211         (TestRunner):
212
213 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
214
215         [GTK] Handle caps lock indicator in event modifiers
216         https://bugs.webkit.org/show_bug.cgi?id=168186
217
218         Reviewed by Michael Catanzaro.
219
220         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
221         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
222
223 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
224
225         MiniBrowser WK1 fails to update URL for within-page navigations
226         https://bugs.webkit.org/show_bug.cgi?id=168173
227
228         Reviewed by Tim Horton.
229         
230         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
231         anchors updates the URL field.
232
233         * MiniBrowser/mac/WK1BrowserWindowController.m:
234         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
235
236 2017-02-10  John Wilander  <wilander@apple.com>
237
238         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
239         https://bugs.webkit.org/show_bug.cgi?id=167474
240         <rdar://problem/24681808>
241         <rdar://problem/24703286>
242         <rdar://problem/30290270>
243
244         This patch adds test infrastructure to allow testing 
245         of the various rules in place for data records removal.
246
247         Reviewed by Andy Estes.
248
249         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
250         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
251         (WTR::InjectedBundle::didReceiveMessageToPage):
252             Callback mechanism to tell pages that a website data store
253             scan has happened.
254         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
255         (WTR::TestRunner::setStatisticsPrevalentResource):
256         (WTR::TestRunner::isStatisticsPrevalentResource):
257         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
258         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
259         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
260         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
261         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
262         (WTR::TestRunner::statisticsFireDataModificationHandler):
263         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
264         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
265         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
266         (WTR::TestRunner::statisticsResetToConsistentState):
267         * WebKitTestRunner/InjectedBundle/TestRunner.h:
268         * WebKitTestRunner/TestController.cpp:
269         (WTR::TestController::setStatisticsPrevalentResource):
270         (WTR::TestController::isStatisticsPrevalentResource):
271         (WTR::TestController::setStatisticsHasHadUserInteraction):
272         (WTR::TestController::isStatisticsHasHadUserInteraction):
273         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
274         (WTR::TestController::statisticsFireDataModificationHandler):
275         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
276         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
277         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
278         (WTR::TestController::statisticsResetToConsistentState):
279         * WebKitTestRunner/TestController.h:
280             These are all configuration and test functions.
281         * WebKitTestRunner/TestInvocation.cpp:
282         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
283
284 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
285
286         REGRESSION(r182916) run-perf-tests never timeouts
287         https://bugs.webkit.org/show_bug.cgi?id=167626
288
289         Reviewed by Ryosuke Niwa.
290
291         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
292         was beeing ignored because the driver was created with no_timeout=True
293         unconditionally.
294         This adds a new parameter --no-timeout (disabled by default), that
295         allows to use the driver with the expected timeout values.
296         It also passes --no-timeout to DRT/WTR to ensure that timeouts
297         are always controlled by the Python Driver.
298
299         * Scripts/webkitpy/performance_tests/perftest.py:
300         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
301         (PerfTest.run): Disabling timeout should be done when the Driver is created.
302         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
303         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
304         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
305         (_run_tests_set): Pass the no-timeout parameter.
306         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
307         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
308         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
309         (MainTest.test_parse_args): Test that the argument no-timeout.
310
311 2017-02-10  Daniel Bates  <dabates@apple.com>
312
313         Detach frame from document when entering page cache
314         https://bugs.webkit.org/show_bug.cgi?id=166774
315         <rdar://problem/29904368>
316
317         Reviewed by Chris Dumez.
318
319         * DumpRenderTree/mac/DumpRenderTree.mm:
320         (resetWebPreferencesToConsistentValues):
321         * DumpRenderTree/win/DumpRenderTree.cpp:
322         (resetWebPreferencesToConsistentValues):
323         * WebKitTestRunner/TestController.cpp:
324         (WTR::TestController::resetPreferencesToConsistentValues):
325
326 2017-02-10  Tim Horton  <timothy_horton@apple.com>
327
328         Infinite UI process hang under ensurePositionInformationIsUpToDate
329         https://bugs.webkit.org/show_bug.cgi?id=168154
330         <rdar://problem/30428673>
331
332         Reviewed by Simon Fraser.
333
334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
335         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
336         (recursiveFindHighlightLongPressRecognizer):
337         (TEST):
338         Add a somewhat nasty test that does an async interaction information update, but
339         kills the Web process before it arrives, and then does a sync interaction
340         information update, which will wait for the oustanding async interaction
341         information update if we still think it's coming. Before the patch, this
342         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
343
344 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
345
346         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
347         https://bugs.webkit.org/show_bug.cgi?id=168127
348         rdar://problem/30467120
349
350         Reviewed by Tim Horton.
351
352         Reparent the web view before we try to fetch it via:
353             [[[window contentView] subviews] objectAtIndex:0];
354         which would throw an exception if the test unparented it.
355
356         * DumpRenderTree/mac/DumpRenderTree.mm:
357         (resetWebViewToConsistentStateBeforeTesting):
358         (runTest):
359
360 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
361
362         [Resource Timing] Enable Resource Timing by default in Tests
363         https://bugs.webkit.org/show_bug.cgi?id=168145
364
365         Reviewed by Ryosuke Niwa.
366
367         * DumpRenderTree/mac/DumpRenderTree.mm:
368         (resetWebPreferencesToConsistentValues):
369         * DumpRenderTree/win/DumpRenderTree.cpp:
370         (resetWebPreferencesToConsistentValues):
371         * WebKitTestRunner/TestController.cpp:
372         (WTR::TestController::resetPreferencesToConsistentValues):
373
374 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
375
376         Removing LayoutTestRelay
377         https://bugs.webkit.org/show_bug.cgi?id=165927
378
379         Reviewed by Daniel Bates.
380         Part 2
381
382         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
383         simulators through simctl (iOS 10 and later), use this functionality instead.
384
385         * BuildSlaveSupport/built-product-archive:
386         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
387         Added a FIXME that we will need to implement similar archiving machinery once we build
388         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
389         * BuildSlaveSupport/kill-old-processes:
390         (main): Remove LayoutTestRelay from list of processes.
391         * LayoutTestRelay: Removed LayoutTestRelay.
392         * Makefile:
393         * Scripts/build-layouttestrelay: Removed.
394         * Scripts/build-webkit: Removed LayoutTestRelay references.
395
396 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
397
398         [WebCrypto] Add WebCryptoAPI to watchlist
399         https://bugs.webkit.org/show_bug.cgi?id=168138
400
401         Reviewed by Youenn Fablet.
402
403         * Scripts/webkitpy/common/config/watchlist:
404
405 2017-02-10  Brady Eidson  <beidson@apple.com>
406
407         Replace all WebKit Library Version checks in WK2 with SDK version checks.
408         https://bugs.webkit.org/show_bug.cgi?id=168124
409
410         Reviewed by Geoffrey Garen.
411
412         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
413         
414         * MiniBrowser/mac/main.m:
415         (main):
416         * MobileMiniBrowser/MobileMiniBrowser/main.m:
417         (main):
418         * TestWebKitAPI/ios/mainIOS.mm:
419         (main):
420         * TestWebKitAPI/mac/mainMac.mm:
421         (main):
422         * WebKitTestRunner/ios/mainIOS.mm:
423         (main):
424         * WebKitTestRunner/mac/main.mm:
425         (setDefaultsToConsistentValuesForTesting):
426
427 2017-02-10  Alex Christensen  <achristensen@webkit.org>
428
429         Fix El Capitan build.
430
431         * Scripts/build-webkit:
432         Don't build libwebrtc anywhere for now.
433
434 2017-02-10  Andy Estes  <aestes@apple.com>
435
436         Move two MiniBrowserBundle settings out of the .pbxproj
437         https://bugs.webkit.org/show_bug.cgi?id=168106
438
439         Reviewed by Tim Horton.
440
441         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
442         the project file. This removes the project file override.
443
444         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
445
446         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
447         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
448
449 2017-02-10  Alex Christensen  <achristensen@webkit.org>
450
451         Fix 32-and-64-bit build on El Capitan.
452
453         * Scripts/build-webkit:
454         Somebody's building with something like this:
455         build-webkit ARCHS="i386 x86_64"
456         We want this to also not build libwebrtc for now.
457
458 2017-02-10  Alex Christensen  <achristensen@webkit.org>
459
460         Fix 32-bit build on El Capitan.
461
462         * Scripts/build-webkit:
463         The bot uses ARCHS=i386 instead of --32-bit.
464         This is a hack, but it should fix the bot until I can do a better fix in the morning.
465
466 2017-02-10  Alex Christensen  <achristensen@webkit.org>
467
468         Fix 32-bit build on El Capitan.
469
470         * Scripts/build-webkit:
471         Don't build i386 libwebrtc.
472
473 2017-02-09  Alex Christensen  <achristensen@webkit.org>
474
475         Unreviewed, rolling out r212040.
476
477         Broke build.  I'm not surprised
478
479         Reverted changeset:
480
481         "[WebRTC][Mac] Activate libwebrtc"
482         https://bugs.webkit.org/show_bug.cgi?id=167293
483         http://trac.webkit.org/changeset/212040
484
485 2017-02-09  Alex Christensen  <achristensen@webkit.org>
486
487         Build libwebrtc on bots without using it yet
488         https://bugs.webkit.org/show_bug.cgi?id=168062
489
490         Reviewed by Brent Fulgham.
491
492         * Scripts/build-webkit:
493
494 2017-02-09  Alex Christensen  <achristensen@webkit.org>
495
496         Don't build libwebrtc.
497
498         * Scripts/build-webkit:
499         Not ready yet.  It broke El Capitan and iOS.
500
501 2017-02-09  Alex Christensen  <achristensen@webkit.org>
502
503         Build libwebrtc on bots without using it yet
504         https://bugs.webkit.org/show_bug.cgi?id=168062
505
506         Reviewed by Brent Fulgham.
507
508         * Scripts/build-webkit:
509
510 2017-02-09  Alex Christensen  <achristensen@webkit.org>
511
512         Rename isAppleMacWebKit to isAppleCocoaWebKit
513         https://bugs.webkit.org/show_bug.cgi?id=168075
514
515         Reviewed by Geoffrey Garen.
516
517         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
518
519         * Scripts/build-api-tests:
520         * Scripts/build-dumprendertree:
521         * Scripts/build-jsc:
522         (buildMyProject):
523         * Scripts/build-layouttestrelay:
524         * Scripts/build-webkit:
525         * Scripts/build-webkittestrunner:
526         * Scripts/run-api-tests:
527         (isSupportedPlatform):
528         (runTest):
529         (listAllTests):
530         (prepareEnvironmentForRunningTestTool):
531         * Scripts/run-content-extension-tester:
532         * Scripts/run-javascriptcore-tests:
533         * Scripts/run-minibrowser:
534         * Scripts/show-pretty-diff:
535         * Scripts/webkitdirs.pm:
536         (determineBaseProductDir):
537         (determineArchitecture):
538         (determinePassedArchitecture):
539         (safariPath):
540         (builtDylibPathForName):
541         (checkFrameworks):
542         (isAppleWebKit):
543         (isAppleCocoaWebKit):
544         (determineNmPath):
545         (launcherName):
546         (wrapperPrefixIfNeeded):
547         (isCMakeBuild):
548         (mobileSafariBundle):
549         (debugSafari):
550         (runSafari):
551         (runMiniBrowser):
552         (debugMiniBrowser):
553         (runWebKitTestRunner):
554         (debugWebKitTestRunner):
555         (isAppleMacWebKit): Deleted.
556         * Scripts/webkitperl/FeatureList.pm:
557
558 2017-02-09  Alex Christensen  <achristensen@webkit.org>
559
560         Revert r211991
561         https://bugs.webkit.org/show_bug.cgi?id=168062
562
563         * Scripts/build-webkit:
564         Not quite ready yet.
565
566 2017-02-09  Alex Christensen  <achristensen@webkit.org>
567
568         Build libwebrtc on bots without using it yet
569         https://bugs.webkit.org/show_bug.cgi?id=168062
570
571         Reviewed by Brent Fulgham.
572
573         * Scripts/build-webkit:
574         Build libwebrtc on Mac when we build ANGLE.
575
576 2017-02-09  Youenn Fablet  <youenn@apple.com>
577
578         Improve W3C importer command line options
579         https://bugs.webkit.org/show_bug.cgi?id=167448
580
581         Reviewed by Ryosuke Niwa.
582
583         Making the list of test paths to import the main arguments of the script.
584         Allow passing the source directory to import as a -s option.
585         Adding a warning when given test paths are skipped by default in ImportExpectations.
586
587         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
588         Link conversion rules do not change when imported tests are downloaded by the script.
589
590         * Scripts/webkitpy/w3c/test_importer.py:
591         (main):
592         (parse_args):
593         (TestImporter.__init__):
594         (TestImporter.do_import):
595         (TestImporter):
596         (TestImporter.check_imported_expectations):
597
598 2017-02-08  Chris Dumez  <cdumez@apple.com>
599
600         Update web-platform-tests resources
601         https://bugs.webkit.org/show_bug.cgi?id=168026
602
603         Reviewed by Youenn Fablet.
604
605         Stop copying testharness.js from resources/ to web-platform-tests/resources.
606
607         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
608         (WebPlatformTestServer._copy_webkit_test_files):
609
610 2017-02-08  Andy Estes  <aestes@apple.com>
611
612         Custom protocols should not continue loading after a network process crash
613         https://bugs.webkit.org/show_bug.cgi?id=168028
614         <rdar://problem/27607520>
615
616         Reviewed by Brady Eidson.
617
618         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
619         (processGroup):
620         (-[CloseWhileStartingProtocol startLoading]):
621         (-[CloseWhileStartingProtocol stopLoading]):
622         (TestWebKitAPI::runTest):
623         (TestWebKitAPI::TEST):
624
625 2017-02-08  Dan Bernstein  <mitz@apple.com>
626
627         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
628         https://bugs.webkit.org/show_bug.cgi?id=168031
629
630         Reviewed by Tim Horton.
631
632         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
633         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
634         (TEST):
635         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
636         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
637
638 2017-02-08  Chris Dumez  <cdumez@apple.com>
639
640         Use smaller tiles in windows that are not active to facilitate App Napping
641         https://bugs.webkit.org/show_bug.cgi?id=167997
642         <rdar://problem/30358835>
643
644         Reviewed by Simon Fraser.
645
646         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
647         (WTR::PlatformWebView::setWindowIsKey):
648         Actually update windowIsKey state of NSWindow so the WebView
649         properly updates its activity state.
650
651 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
652
653         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
654         https://bugs.webkit.org/show_bug.cgi?id=167942
655         <rdar://problem/30315079>
656
657         Reviewed by Tim Horton.
658
659         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
660         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
661         contenteditable in these cases.
662
663         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
664         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
665         performDragOperation:) directly.
666
667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
668         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
669         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
670         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
671         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
672         (-[DragSource draggingSourceOperationMaskForLocal:]):
673         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
674         (-[DragInfo lastMousePosition]):
675         (-[DragInfo setLastMousePosition:]):
676         (-[DragInfo draggingDestinationWindow]):
677         (-[DragInfo draggingSourceOperationMask]):
678         (-[DragInfo draggingLocation]):
679         (-[DragInfo draggedImageLocation]):
680         (-[DragInfo draggedImage]):
681         (-[DragInfo draggingPasteboard]):
682         (-[DragInfo draggingSource]):
683         (-[DragInfo draggingSequenceNumber]):
684         (-[DragInfo slideDraggedImageTo:]):
685         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
686         (-[DragInfo draggingFormation]):
687         (-[DragInfo setDraggingFormation:]):
688         (-[DragInfo animatesToDestination]):
689         (-[DragInfo setAnimatesToDestination:]):
690         (-[DragInfo numberOfValidItemsForDrop]):
691         (-[DragInfo setNumberOfValidItemsForDrop:]):
692         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
693         (-[DragInfo springLoadingHighlight]):
694         (-[DragInfo resetSpringLoading]):
695         (TestWebKitAPI::getTestImage):
696         (TestWebKitAPI::webViewAfterPerformingDragOperation):
697         (TestWebKitAPI::TEST):
698         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
699
700 2017-02-08  Jer Noble  <jer.noble@apple.com>
701
702         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
703         https://bugs.webkit.org/show_bug.cgi?id=168007
704
705         Reviewed by Alex Christensen.
706
707         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
708         (didFinishLoadForFrame):
709         (TestWebKitAPI::TEST):
710
711 2017-02-08  Commit Queue  <commit-queue@webkit.org>
712
713         Unreviewed, rolling out r211873.
714         https://bugs.webkit.org/show_bug.cgi?id=168001
715
716         It's in jhbuild for consistent layout tests (Requested by
717         mcatanzaro on #webkit).
718
719         Reverted changeset:
720
721         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
722         https://bugs.webkit.org/show_bug.cgi?id=167993
723         http://trac.webkit.org/changeset/211873
724
725 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
726
727         [GTK] Add icu packages to Tools/gtk/install-dependencies
728         https://bugs.webkit.org/show_bug.cgi?id=167993
729
730         Reviewed by Michael Catanzaro.
731
732         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
733         depending in the GNU/Linux distribution)
734
735 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
736
737         Update flakiness dashboard configuration.
738         https://bugs.webkit.org/show_bug.cgi?id=167957
739
740         Reviewed by Alexey Proskuryakov.
741
742         * TestResultServer/static-dashboards/builders.jsonp:
743
744 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
745
746         Replace a bot that has an incorrect configuration.
747         https://bugs.webkit.org/show_bug.cgi?id=167747
748
749         Rubber-stamped by Alexey Proskuryakov.
750
751         * BuildSlaveSupport/build.webkit.org-config/config.json:
752
753 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
754
755         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
756         https://bugs.webkit.org/show_bug.cgi?id=167927
757
758         Reviewed by Brent Fulgham.
759
760         Enable ComplexTextController API tests on the Win and GTK ports.
761
762         * TestWebKitAPI/PlatformGTK.cmake:
763         * TestWebKitAPI/PlatformWin.cmake:
764
765 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
766
767         File index appended to previous file in svn-create-patch with SVN 1.9
768         https://bugs.webkit.org/show_bug.cgi?id=167903
769         <rdar://problem/30387395>
770
771         Reviewed by Daniel Bates.
772
773         * Scripts/VCSUtils.pm:
774         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
775         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
776         trailing newline character from the expected result before comparing it to the actual result.
777
778 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
779
780         [webkitdirs] remove unused host_processor variable in determineArchitecture()
781         https://bugs.webkit.org/show_bug.cgi?id=167936
782
783         Reviewed by Michael Catanzaro.
784
785         * Scripts/webkitdirs.pm:
786         (determineArchitecture):
787         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
788         since r195083.
789
790 2017-02-07  Youenn Fablet  <youenn@apple.com>
791
792         Use a JSON file to define which WPT files/folders to import
793         https://bugs.webkit.org/show_bug.cgi?id=167923
794
795         Reviewed by Alex Christensen.
796
797         * Scripts/webkitpy/w3c/test_downloader.py:
798         (TestDownloader.__init__):
799         (TestDownloader._init_paths_from_expectations):
800         * Scripts/webkitpy/w3c/test_importer.py:
801         (parse_args):
802         * Scripts/webkitpy/w3c/test_importer_unittest.py:
803
804 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
805
806         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
807         https://bugs.webkit.org/show_bug.cgi?id=167916
808
809         Reviewed by Carlos Garcia Campos.
810
811         URL of mesa-11.0.6.tar.xz has been moved.
812
813         * gtk/jhbuild.modules: Fix the module path.
814
815 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
816
817         Static Analyzer: Address some leaks in MiniBrowser
818         https://bugs.webkit.org/show_bug.cgi?id=167897
819
820         Reviewed by Alexey Proskuryakov.
821
822         * MiniBrowser/mac/BrowserWindowController.m:
823         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
824         * MiniBrowser/mac/ExtensionManagerWindowController.m:
825         (-[ExtensionManagerWindowController add:]):
826         (-[ExtensionManagerWindowController remove:]):
827         * MiniBrowser/mac/SettingsController.m:
828         (-[SettingsController _populateMenu]):
829         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
830         Address obvious leaks caught by the static analyzer.
831
832 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
833
834         Migrate ComplexTextController to use platform-independent types
835         https://bugs.webkit.org/show_bug.cgi?id=167833
836
837         Reviewed by Brent Fulgham.
838
839         Migrate tests away from platform-dependent types.
840
841         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
842         (TestWebKitAPI::TEST_F):
843
844 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
845
846         Correct File Path Handling in SecurityOrigin and FileSystem
847         https://bugs.webkit.org/show_bug.cgi?id=167894
848         <rdar://problem/30380080>
849
850         Reviewed by Alexey Proskuryakov.
851
852         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
853         and perform same-volume checks using filesystem-compatible paths.        
854         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
855         filesystem paths, and perform validation of same-volume checks.
856         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
857         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
858         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
859         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
860
861 2017-02-06  Jer Noble  <jer.noble@apple.com>
862
863         Playback stalls when a SourceBuffer append causes frame eviction
864         https://bugs.webkit.org/show_bug.cgi?id=167834
865
866         Reviewed by Eric Carlson.
867
868         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
869         for the WTF::MediaTime class.
870
871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
872         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
873         (TestWebKitAPI::TEST):
874         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
875         (WTF::operator<<):
876         (TestWebKitAPI::TestSample::create):
877         (TestWebKitAPI::TestSample::TestSample):
878         (TestWebKitAPI::TEST_F):
879
880 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
881
882         Change capitalization in platform name after r211735.
883
884         Unreviewed dashboard fix.
885
886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
887         (WebKitBuildbot):
888
889 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
890
891         Move the Leaks bot to Sierra
892         https://bugs.webkit.org/show_bug.cgi?id=167886
893
894         Reviewed by Daniel Bates.
895
896         * BuildSlaveSupport/build.webkit.org-config/config.json:
897         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
898         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
899         (LeaksViewer._displayURLPrompt):
900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
901         (WebKitBuildbot):
902
903 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
904
905         Prevent app crash on launch during simctl install workaround
906         https://bugs.webkit.org/show_bug.cgi?id=167685
907
908         Reviewed by Daniel Bates.
909
910         * Scripts/webkitpy/port/simulator_process.py:
911         (SimulatorProcess.__init__): Pass environment to install.
912         * Scripts/webkitpy/xcode/simulator.py:
913         (Device.install_app): Accept environment, pass environment to launch.
914
915 2017-02-06  Alex Christensen  <achristensen@webkit.org>
916
917         Rebase API tests after r211638
918         https://bugs.webkit.org/show_bug.cgi?id=167779
919
920         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
921         (TestWebKitAPI::TEST_F):
922         URLs with non-special schemes and characters like % in the host now fail to parse,
923         more like their special counterparts and according to spec.
924
925 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
926
927         Unreviewed trivial fix after r211697.
928         https://bugs.webkit.org/show_bug.cgi?id=167863
929
930         * Scripts/run-javascriptcore-tests:
931         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
932
933 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
934
935         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
936         https://bugs.webkit.org/show_bug.cgi?id=167850
937
938         Reviewed by Tim Horton.
939
940         * DumpRenderTree/TestRunner.cpp:
941         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
942
943 2017-02-04  Andreas Kling  <akling@apple.com>
944
945         Plug some leaks in TestController and UIScriptContext.
946         <https://webkit.org/b/167839>
947
948         Reviewed by Alexey Proskuryakov.
949
950         Fix a couple of the leaks seen on the leaks bot.
951
952         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
953         (UIScriptContext::runUIScript):
954         * WebKitTestRunner/TestController.cpp:
955         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
956         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
957
958 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
959
960         WK1 mouse events are missing movementX and movementY for pointerlock.
961         https://bugs.webkit.org/show_bug.cgi?id=167775
962         rdar://problem/30343810
963
964         Reviewed by Alexey Proskuryakov.
965
966         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
967
968         * DumpRenderTree/mac/EventSendingController.mm:
969         (-[EventSendingController mouseMoveToX:Y:]):
970         * WebKitTestRunner/mac/EventSenderProxy.mm:
971         (WTR::EventSenderProxy::mouseMoveTo):
972
973 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
974
975         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
976         https://bugs.webkit.org/show_bug.cgi?id=167774
977
978         Reviewed by Tim Horton.
979
980         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
981         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
982         web process are async, so the callback fires after the web process gets the new state.
983
984         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
985         (WTR::UIScriptController::removeViewFromWindow):
986         (WTR::UIScriptController::addViewToWindow):
987         * DumpRenderTree/mac/DumpRenderTree.mm:
988         (createWebViewAndOffscreenWindow):
989         (resetWebViewToConsistentStateBeforeTesting):
990         * DumpRenderTree/mac/DumpRenderTreeMac.h:
991         * DumpRenderTree/mac/UIScriptControllerMac.mm:
992         (WTR::UIScriptController::removeViewFromWindow):
993         (WTR::UIScriptController::addViewToWindow):
994         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
995         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
996         (WTR::UIScriptController::removeViewFromWindow):
997         (WTR::UIScriptController::addViewToWindow):
998         * TestRunnerShared/UIScriptContext/UIScriptController.h:
999         * WebKitTestRunner/PlatformWebView.h:
1000         * WebKitTestRunner/TestController.cpp:
1001         (WTR::TestController::resetStateToConsistentValues):
1002         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1003         (WTR::PlatformWebView::removeFromWindow):
1004         (WTR::PlatformWebView::addToWindow):
1005         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1006         (WTR::UIScriptController::removeViewFromWindow):
1007         (WTR::UIScriptController::addViewToWindow):
1008         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1009         (WTR::PlatformWebView::removeFromWindow):
1010         (WTR::PlatformWebView::addToWindow):
1011         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1012         (WTR::UIScriptController::removeViewFromWindow):
1013         (WTR::UIScriptController::addViewToWindow):
1014
1015 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1016
1017         Remove check for SkipSafariExecutableEntitlementChecks
1018         https://bugs.webkit.org/show_bug.cgi?id=167762
1019
1020         Reviewed by Dan Bernstein.
1021
1022         Follow-up fix: don't break internal behavior.
1023
1024         * Scripts/webkitdirs.pm:
1025         (safariPath):
1026         (executableHasEntitlements): Deleted.
1027         (safariPathFromSafariBundle): Deleted.
1028         (installedSafariPath): Deleted.
1029
1030 2017-02-03  Daniel Bates  <dabates@apple.com>
1031
1032         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1033         https://bugs.webkit.org/show_bug.cgi?id=167810
1034         <rdar://problem/30102568>
1035
1036         Reviewed by Anders Carlsson.
1037
1038         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1039
1040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1041         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1042         (TEST):
1043         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1044         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1045         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1046         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1047
1048 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1049
1050         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1051         https://bugs.webkit.org/show_bug.cgi?id=167773
1052         <rdar://problem/30221102>
1053
1054         Reviewed by Ryosuke Niwa.
1055
1056         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1057         (TestWebKitAPI::TEST_F):
1058
1059 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1060
1061         Remove check for SkipSafariExecutableEntitlementChecks
1062         https://bugs.webkit.org/show_bug.cgi?id=167762
1063         rdar://problem/22480673
1064
1065         Reviewed by Dan Bernstein.
1066
1067         * Scripts/webkitdirs.pm:
1068         (safariPathFromSafariBundle):
1069         (skipSafariExecutableEntitlementChecks): Deleted.
1070
1071 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1072
1073         Undefined subroutine in svn-create-patch
1074         https://bugs.webkit.org/show_bug.cgi?id=167742
1075
1076         Unreviewed build-fix after r211543.
1077
1078         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1079
1080 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1081
1082         Unreviewed. Fix jhbuild dependencies build.
1083
1084         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1085         Patch updated.
1086
1087 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1088
1089         [EME][GStreamer] Fixed decryptor selection
1090         https://bugs.webkit.org/show_bug.cgi?id=167588
1091
1092         Reviewed by Žan Doberšek.
1093
1094         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1095
1096         * gtk/jhbuild.modules: Added patches to gstreamer and
1097         gst-plugins-good packages.
1098         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1099         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1100
1101 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1102
1103         Make run-benchmark script supports 'config' key in test plan.
1104         https://bugs.webkit.org/show_bug.cgi?id=167715
1105
1106         Reviewed by Ryosuke Niwa.
1107
1108         Add support for 'config' key in test paln.
1109         'config' key is a dictionary that specifies environment configurations while test is running.
1110         Specifies orientation to be portrait in MotionMark benchmark.
1111
1112         * Scripts/webkitpy/benchmark_runner/README.md:
1113         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1114         (BenchmarkRunner.__init__):
1115         (BenchmarkRunner._run_benchmark):
1116         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1117         (BrowserDriver.prepare_env):
1118         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1119         (LinuxBrowserDriver.prepare_env):
1120         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1121         (OSXBrowserDriver.prepare_env):
1122         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1123         (OSXSafariDriver.prepare_env):
1124         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1125
1126 2017-02-01  Daniel Bates  <dabates@apple.com>
1127
1128         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1129         https://bugs.webkit.org/show_bug.cgi?id=167169
1130
1131         Reviewed by David Kilzer.
1132
1133         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1134         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1135         header from the output of "svn diff" on a file that was copied or moved.
1136
1137         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1138         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1139         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1140         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1141         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1142         of a file with only a property change also does not contain any chunk range lines. Therefore
1143         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1144         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1145         we should directly test for the presence of a leading SVN diff header with an empty body and
1146         remove such lines from the diff.
1147
1148         * Scripts/VCSUtils.pm:
1149         (fixSVNPatchForAdditionWithHistory): Added.
1150         * Scripts/svn-create-patch:
1151         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1152         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1153         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1154
1155 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1156
1157         [Mac] Update CARingBuffer class
1158         https://bugs.webkit.org/show_bug.cgi?id=167656
1159
1160         Reviewed by Jer Noble.
1161
1162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1163         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1164         (TestWebKitAPI::CARingBufferTest::SetUp):
1165         (TestWebKitAPI::CARingBufferTest::setup):
1166         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1167         (TestWebKitAPI::CARingBufferTest::description):
1168         (TestWebKitAPI::CARingBufferTest::bufferList):
1169         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1170         (TestWebKitAPI::CARingBufferTest::capacity):
1171         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1172         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1173         (TestWebKitAPI::TEST_F):
1174         (TestWebKitAPI::MixingTest::run):
1175
1176 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1177
1178         [Mac] TestWebKitAPI includes system frameworks incorrectly
1179         https://bugs.webkit.org/show_bug.cgi?id=167703
1180         rdar://problem/30301498
1181
1182         Reviewed by Ryosuke Niwa.
1183
1184         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1185         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1186
1187         Also, reduced the number of subframework search paths, looks like we only need one now.
1188
1189         * TestWebKitAPI/Configurations/Base.xcconfig:
1190
1191 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1192
1193         Correct "filesHaveSameVolume" predicate
1194         https://bugs.webkit.org/show_bug.cgi?id=167696
1195         <rdar://problem/30298722>
1196
1197         Reviewed by David Kilzer.
1198
1199         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1200         percent-escaped path inputs.
1201
1202         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1203         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1204         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1205         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1206         (TestWebKitAPI::TEST_F):
1207
1208 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1209
1210         Unreviewed. Fix coding style in MiniBrowser
1211
1212         * MiniBrowser/gtk/BrowserWindow.c:
1213         (editingCommandCallback):
1214         (insertImageCommandCallback):
1215         (insertLinkCommandCallback):
1216
1217 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1218
1219         [GTK] Add an API to add a custom tab into the print dialog
1220         https://bugs.webkit.org/show_bug.cgi?id=151998
1221
1222         Reviewed by Carlos Garcia Campos.
1223
1224         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1225         that is testing a newly added API.
1226
1227         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1228         (testPrintCustomWidget):
1229         (beforeAll):
1230
1231 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1232
1233         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1234         https://bugs.webkit.org/show_bug.cgi?id=166529
1235
1236         Reviewed by Xabier Rodriguez-Calvar.
1237
1238         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1239         New patch version accepted in GStreamer upstream.
1240
1241 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1242
1243         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1244         https://bugs.webkit.org/show_bug.cgi?id=167498
1245
1246         Reviewed by Carlos Garcia Campos.
1247
1248         Depending on the distro version you can need either libxfont1-dev
1249         or libfont-dev to build with jhbuild.
1250
1251         * gtk/install-dependencies:
1252
1253 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1254
1255         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1256         https://bugs.webkit.org/show_bug.cgi?id=167594
1257
1258         Unreviewed test gardening.
1259
1260         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1261
1262         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1263         (TEST):
1264
1265 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1266
1267         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1268         https://bugs.webkit.org/show_bug.cgi?id=167676
1269
1270         Reviewed by Saam Barati.
1271
1272         * Scripts/run-javascriptcore-tests:
1273         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1274
1275 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1276
1277         Make Dump Render Tree not crash
1278         https://bugs.webkit.org/show_bug.cgi?id=167667
1279
1280         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1281         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1282         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1283         This does not fix any tests, it just fixes the crash.
1284         
1285         Reviewed by Simon Fraser.
1286
1287         * DumpRenderTree/TestRunner.cpp:
1288         (TestRunner::callUIScriptCallback):
1289
1290 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1291
1292         Workaround for simctl install failing to report install failure
1293         https://bugs.webkit.org/show_bug.cgi?id=167654
1294
1295         Reviewed by Daniel Bates.
1296
1297         simctl install will sometimes report success even though install has failed.
1298         To workaround this bug, we attempt an app launch after install to ensure
1299         install has succeeded.
1300
1301         * Scripts/webkitpy/xcode/simulator.py:
1302         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1303         (Device.launch_app): Correct comment.
1304
1305 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1306
1307         Unreviewed webkitpy fix after r211405.
1308
1309         * Scripts/webkitpy/xcode/simulator.py:
1310         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1311
1312 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1313
1314         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1315
1316         * gtk/manifest.txt.in:
1317
1318 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1319
1320         AX: enable search predication for iOS
1321         https://bugs.webkit.org/show_bug.cgi?id=167558
1322         <rdar://problem/30251367>
1323
1324         Reviewed by Joanmarie Diggs.
1325
1326         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1327         (AccessibilityUIElement::uiElementForSearchPredicate):
1328         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1329         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1330         (searchPredicateParameterizedAttributeForSearchCriteria):
1331         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1332         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1333         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1334         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1335         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1336         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1337         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1338         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1339         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1340         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1341         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1342
1343 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1344
1345         Workaround for simctl launch bug
1346         https://bugs.webkit.org/show_bug.cgi?id=167613
1347
1348         Reviewed by Daniel Bates.
1349
1350         simctl launch will sometimes fail because of a race condition when many
1351         simulators are being run simultaneously. These failures will always have
1352         an exit code of 1. This change attempts to launch an app multiple times
1353         before reporting a failure to workaround this bug.
1354
1355         * Scripts/webkitpy/xcode/simulator.py:
1356         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1357
1358 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1359
1360         Commit queue fails to look at real name aliases for the reviewer
1361         https://bugs.webkit.org/show_bug.cgi?id=167422
1362
1363         Reviewed by Joseph Pecoraro.
1364
1365         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1366         (test_has_valid_reviewer): Added tests.
1367
1368         * Scripts/webkitpy/common/config/committers.py:
1369         (CommitterList._name_to_contributor_map):
1370         Made _name_to_contributor_map include alias names.
1371
1372         * Scripts/webkitpy/common/config/committers_unittest.py:
1373         (CommittersTest.test_contributors_by_fuzzy_match):
1374         Removed subtests that are now obsolete, as these matches are strict. It is not
1375         obvious if distance based fuzzy matching for names is useful at all, but we can
1376         look into that some other time.
1377
1378 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1379
1380         QueueStatusServer should have an explicit timeout for _fetch_url
1381         https://bugs.webkit.org/show_bug.cgi?id=167467
1382
1383         Reviewed by Alexey Proskuryakov.
1384
1385         * Scripts/webkitpy/common/net/statusserver.py:
1386         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1387
1388 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1389
1390         Add support for Trac instances that host multiple projects.
1391         https://bugs.webkit.org/show_bug.cgi?id=167524
1392
1393         Reviewed by Alexey Proskuryakov.
1394
1395         When multiple projects are hosted on a single Trac instance, the current
1396         behavior will retrieve changesets from all tracked projects.
1397         This patch teaches Trac.js to get project-specific changesets from Trac.
1398         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1399         when querying the Trac timeline.
1400
1401         To tell Trac to be aware of multi-project instances we leverage the 
1402         `options` parameter when creating a new instance: 
1403
1404             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1405
1406         If this option is not provided, the original behaviour will prevail.
1407         Additionally, add corresponding tests.
1408
1409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1410         (Trac): Reason about new optional parameter 'projectIdentifier'.
1411         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1412         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1413         replace default parameter `changeset=on` with `repo-projectname=on`.
1414         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1416         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1417         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1418         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1419         Add the following tests:
1420             test("revisionURL")
1421             test("revisionURL with Trac Identifier")
1422             test("_xmlTimelineURL")
1423             test("_xmlTimelineURL with Trac Identifier")
1424         (this.view._latestProductiveIteration): Fix missing ';'.
1425
1426 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1427
1428         Correct spacing regression on inter-element complex path shaping on some fonts
1429         https://bugs.webkit.org/show_bug.cgi?id=166013
1430
1431         Reviewed by Simon Fraser.
1432
1433         Unskip existing tests and make some new tests:
1434         - Testing complex text with no origins
1435         - Testing initial expansions
1436         - Testing the sign of vertical advances
1437
1438         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1439         (TestWebKitAPI::TEST_F):
1440
1441 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1442
1443         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1444         https://bugs.webkit.org/show_bug.cgi?id=167596
1445
1446         Reviewed by Daniel Bates.
1447
1448         We avoid needing a thin directory by invoking the zip program with
1449         the list of directories from the build directory to be zipped,
1450         and by using the zip feature to exclude files matching a pattern.
1451
1452         * BuildSlaveSupport/built-product-archive:
1453         (copyBuildFiles):
1454         (createZipFromList):
1455         (archiveBuiltProduct):
1456
1457 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1458
1459         Use simctl instead of LayoutTestRelay
1460         https://bugs.webkit.org/show_bug.cgi?id=165927
1461
1462         Reviewed by Daniel Bates.
1463
1464         Part 1
1465
1466         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1467         simulators through simctl (iOS 10 and later), use this functionality instead.
1468
1469         * Scripts/webkitpy/port/base.py:
1470         (Port.__init__): Added _test_runner_process_constructor.
1471         * Scripts/webkitpy/port/darwin.py:
1472         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1473         * Scripts/webkitpy/port/driver.py:
1474         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1475         (IOSSimulatorDriver): Deleted.
1476         * Scripts/webkitpy/port/driver_unittest.py:
1477         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1478         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1479         (DriverTest.test_start_actually_starts): Ditto.
1480         * Scripts/webkitpy/port/ios.py:
1481         (IOSSimulatorPort): Remove relay_name.
1482         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1483         (IOSSimulatorPort._create_simulators): Formatting change.
1484         (IOSSimulatorPort.relay_path): Deleted.
1485         (IOSSimulatorPort._check_relay): Deleted.
1486         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1487         (IOSSimulatorPort._build_relay): Deleted.
1488         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1489         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1490         * Scripts/webkitpy/port/ios_unittest.py:
1491         (iosTest.test_32bit): Update test.
1492         (iosTest.test_64bit): Update test.
1493         * Scripts/webkitpy/port/server_process.py:
1494         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1495         (ServerProcess._set_file_nonblocking): Added to share common code.
1496         * Scripts/webkitpy/port/server_process_mock.py:
1497         (MockServerProcess.__init__): Added argument worker_number.
1498         * Scripts/webkitpy/port/simulator_process.py: Added.
1499         (SimulatorProcess): Added.
1500         (SimulatorProcess.Popen): Added.
1501         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1502         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1503         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1504         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1505         (SimulatorProcess._reset): Added. Unlink fifos.
1506         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1507         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1508         * Scripts/webkitpy/xcode/simulator.py:
1509         (Device.__init__): Accept host to run install/launch/terminate.
1510         (Device.install_app): Install app to target Device.
1511         (Device.launch_app): Launch app on target Device.
1512         (Device.terminate_app): Shutdown app on target Device.
1513         (Simulator._parse_devices): Pass host to Device.
1514
1515 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1516
1517         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1518         https://bugs.webkit.org/show_bug.cgi?id=167411
1519
1520         Reviewed by Michael Catanzaro.
1521
1522         Disable the ARM iwMMXt fast path for pixman, because it triggers
1523         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1524
1525         * gtk/jhbuild.modules:
1526
1527 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1528
1529         [GTK] Add API to handle the accelerated compositing policy
1530         https://bugs.webkit.org/show_bug.cgi?id=167509
1531
1532         Reviewed by Michael Catanzaro.
1533
1534         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1535         as a special case. Also add test cases to the get/set API.
1536
1537         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1538         (hardwareAccelerationPolicyToString):
1539         (stringToHardwareAccelerationPolicy):
1540         (cellRendererChanged):
1541         (browserSettingsDialogConstructed):
1542         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1543         (testWebKitSettings):
1544
1545 2017-01-29  Andy Estes  <aestes@apple.com>
1546
1547         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1548         https://bugs.webkit.org/show_bug.cgi?id=167563
1549         <rdar://problem/30253207>
1550
1551         Reviewed by Andreas Kling.
1552
1553         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1554         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1555         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1556         (runTest):
1557         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1558         (TEST):
1559
1560 2017-01-29  Dan Bernstein  <mitz@apple.com>
1561
1562         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1563         https://bugs.webkit.org/show_bug.cgi?id=167565
1564
1565         Reviewed by Sam Weinig.
1566
1567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1568         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1569         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1570         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1571         (TEST):
1572         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1573         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1574         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1575         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1576
1577 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1578
1579         Add Link Preload as an off-by-default experimental feature menu item.
1580         https://bugs.webkit.org/show_bug.cgi?id=167201
1581
1582         Reviewed by Ryosuke Niwa.
1583
1584         * DumpRenderTree/mac/DumpRenderTree.mm:
1585         (resetWebPreferencesToConsistentValues):
1586         * DumpRenderTree/win/DumpRenderTree.cpp:
1587         (resetWebPreferencesToConsistentValues):
1588
1589 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1590
1591         Add User Timing Experimental Feature
1592         https://bugs.webkit.org/show_bug.cgi?id=167542
1593         <rdar://problem/22746307>
1594
1595         Reviewed by Ryosuke Niwa.
1596
1597         * DumpRenderTree/mac/DumpRenderTree.mm:
1598         (enableExperimentalFeatures):
1599         (resetWebPreferencesToConsistentValues):
1600         * DumpRenderTree/win/DumpRenderTree.cpp:
1601         (enableExperimentalFeatures):
1602
1603 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1604
1605         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1606         https://bugs.webkit.org/show_bug.cgi?id=167519
1607
1608         Reviewed by Ryosuke Niwa.
1609
1610         * QueueStatusServer/templates/statusbubble.html:
1611         To measure the bubbleContainer's width, it must not be wrapping based
1612         on its parent container. So when measuring the width temporarily set
1613         the parent to a very large width so as to not artificially wrap us.
1614         Restore the parent's width after measuring.
1615
1616 2017-01-27  Andy Estes  <aestes@apple.com>
1617
1618         [iOS] Add a test for _WKNSFileManagerExtras
1619         https://bugs.webkit.org/show_bug.cgi?id=167478
1620
1621         Reviewed by Andreas Kling.
1622
1623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1624         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1625         (expectAttributes):
1626         (TEST):
1627
1628 2017-01-27  Keith Miller  <keith_miller@apple.com>
1629
1630         run-benchmarks should make sure it passes the test url to the right application
1631         https://bugs.webkit.org/show_bug.cgi?id=167533
1632
1633         Reviewed by Joseph Pecoraro.
1634
1635         This fixes an issue when trying to run-benchmark script with the
1636         system default browser set to STP. Previously, it would run
1637         the test in STP rather than the provided build. Now, it should run
1638         in the provided build.
1639
1640         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1641         (OSXSafariDriver.launch_url):
1642
1643 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1644
1645         [Cocoa] Prepare ComplexTextController for unit testing
1646         https://bugs.webkit.org/show_bug.cgi?id=167493
1647
1648         Reviewed by Simon Fraser.
1649
1650         Addressing post-review comments from Simon Fraser.
1651
1652         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1653         (TestWebKitAPI::TEST_F):
1654
1655 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1656
1657         [Cocoa] Prepare ComplexTextController for unit testing
1658         https://bugs.webkit.org/show_bug.cgi?id=167493
1659
1660         Reviewed by Dean Jackson.
1661
1662         Create four unit tests.
1663
1664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1665         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1666         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1667         (TestWebKitAPI::TEST_F):
1668
1669 2017-01-26  Chris Dumez  <cdumez@apple.com>
1670
1671         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1672         https://bugs.webkit.org/show_bug.cgi?id=167421
1673         <rdar://problem/30188490>
1674
1675         Reviewed by Darin Adler.
1676
1677         Add a new setting allowing layout tests to enable PageCache in a window
1678         that has an opener, for convenience.
1679
1680         * DumpRenderTree/mac/DumpRenderTree.mm:
1681         (resetWebPreferencesToConsistentValues):
1682         * DumpRenderTree/win/DumpRenderTree.cpp:
1683         (resetWebPreferencesToConsistentValues):
1684         * WebKitTestRunner/TestController.cpp:
1685         (WTR::TestController::resetPreferencesToConsistentValues):
1686
1687 2017-01-26  Keith Miller  <keith_miller@apple.com>
1688
1689         classInfo should take a VM so it is not materialized from the object on each call
1690         https://bugs.webkit.org/show_bug.cgi?id=167424
1691
1692         Rubber Stamped by Michael Saboff.
1693
1694         Previously, classInfo() would get the VM from the target's
1695         MarkedBlock.  Most callers already have a VM on hand, so it is
1696         wasteful to compute the VM from the marked block every time. This
1697         patch refactors some of the most common callers of classInfo(),
1698         jsDynamicCast and inherits to take a VM as well.
1699
1700         * DumpRenderTree/TestRunner.cpp:
1701         (setAudioResultCallback):
1702
1703 2017-01-26  Jer Noble  <jer.noble@apple.com>
1704
1705         Autoplay muted videos stop playback of any streaming app in the background
1706         https://bugs.webkit.org/show_bug.cgi?id=163993
1707         <rdar://problem/29020431>
1708
1709         Reviewed by Eric Carlson.
1710
1711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1712         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1713         (TestWebKitAPI::TEST):
1714         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1715
1716 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1717
1718         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1719         https://bugs.webkit.org/show_bug.cgi?id=167466
1720
1721         Unreviewed test gardening.
1722
1723         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1724         (TEST):
1725
1726 2017-01-26  Matt Rajca  <mrajca@apple.com>
1727
1728         Notify clients when the user plays media otherwise prevented from autoplaying
1729         https://bugs.webkit.org/show_bug.cgi?id=167390
1730
1731         Reviewed by Alex Christensen.
1732
1733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1734         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1735         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1736         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1737         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1738         (TEST):
1739         * TestWebKitAPI/cocoa/TestWKWebView.h:
1740         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1741         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1742         (-[TestWKWebView waitForLoad]):
1743         (-[TestWKWebView mouseUpAtPoint:]):
1744         * WebKitTestRunner/TestController.cpp:
1745         (WTR::TestController::createOtherPage):
1746         (WTR::TestController::createWebViewWithOptions):
1747
1748 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1749
1750         Crash when setting custom scale factor.
1751         https://bugs.webkit.org/show_bug.cgi?id=167369
1752
1753         Reviewed by Sam Weinig.
1754
1755         Added API test.
1756
1757         * TestWebKitAPI/PlatformWin.cmake:
1758         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1759         (TestWebKitAPI::WebKitCreateInstance):
1760         (TestWebKitAPI::ScaleWebView::SetUp):
1761         (TestWebKitAPI::ScaleWebView::TearDown):
1762         (TestWebKitAPI::TEST_F):
1763
1764 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1765
1766         run-benchmark nests MotionMark results by the suite name twice
1767         https://bugs.webkit.org/show_bug.cgi?id=164948
1768
1769         Reviewed by Said Abou-Hallawa.
1770
1771         Use a single level MotionMark now that this is the name of the benchmark,
1772         and we no longer have tests that aren't part of the MotionMark suite.
1773
1774         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1775
1776 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1777
1778         Unreviewed, rolling out r211193.
1779
1780         This change broke internal builds.
1781
1782         Reverted changeset:
1783
1784         "Notify clients when the user plays media otherwise prevented
1785         from autoplaying"
1786         https://bugs.webkit.org/show_bug.cgi?id=167390
1787         http://trac.webkit.org/changeset/211193
1788
1789 2017-01-25  Matt Rajca  <mrajca@apple.com>
1790
1791         Notify clients when the user plays media otherwise prevented from autoplaying
1792         https://bugs.webkit.org/show_bug.cgi?id=167390
1793
1794         Reviewed by Alex Christensen.
1795
1796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1797         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1798         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1799         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1800         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1801         (TEST):
1802         * TestWebKitAPI/cocoa/TestWKWebView.h:
1803         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1804         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1805         (-[TestWKWebView waitForLoad]):
1806         (-[TestWKWebView mouseUpAtPoint:]):
1807         * WebKitTestRunner/TestController.cpp:
1808         (WTR::TestController::createOtherPage):
1809         (WTR::TestController::createWebViewWithOptions):
1810
1811 2017-01-25  Matt Rajca  <mrajca@apple.com>
1812
1813         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1814         https://bugs.webkit.org/show_bug.cgi?id=167385
1815
1816         Reviewed by Alex Christensen.
1817
1818         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1819         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1820         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1821         (TEST): Allow inline (rather than full screen) media playback on iOS.
1822
1823 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1824
1825         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1826         https://bugs.webkit.org/show_bug.cgi?id=167414
1827
1828         Reviewed by Michael Catanzaro.
1829
1830         Add a test case to check ephemeral web views don't write favicons to the database.
1831
1832         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1833         (ephemeralViewLoadChanged):
1834         (testPrivateBrowsing):
1835         (testFaviconDatabase):
1836
1837 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1838
1839         [GTK] Add a private browsing mode to MiniBrowser
1840         https://bugs.webkit.org/show_bug.cgi?id=167413
1841
1842         Reviewed by Michael Catanzaro.
1843
1844         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1845         private windows, even on non-private instances.
1846
1847         * MiniBrowser/gtk/BrowserWindow.c:
1848         (webViewTitleChanged): Add [Private] to title window for private windows.
1849         (webViewCreate): Pass web context to browser_window_new.
1850         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1851         (browserWindowFinalize): Disconnect web context signal handlers.
1852         (browser_window_init): Add shortcut for opening private window.
1853         (browser_window_new): It now receives the context and connect to download-started here.
1854         (browser_window_get_web_context): Return the context.
1855         * MiniBrowser/gtk/BrowserWindow.h:
1856         * MiniBrowser/gtk/main.c:
1857         (createBrowserTab): Create the web view for the window web context.
1858         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1859         (aboutDataHandleRequest): Ditto.
1860         (aboutURISchemeRequestCallback): Ditto.
1861         (main): Create ephemeral web context if private command line option is used.
1862
1863 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1864
1865         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1866         https://bugs.webkit.org/show_bug.cgi?id=167409
1867
1868         Reviewed by Antti Koivisto.
1869
1870         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1871         as well as tests for the newly added matchingElementInFlatTree.
1872
1873         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1874         (TestWebKitAPI::runJavaScriptAlert):
1875         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1876         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1877         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1878
1879 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1880
1881         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1882         https://bugs.webkit.org/show_bug.cgi?id=167370
1883
1884         Reviewed by Michael Catanzaro.
1885
1886         Add several test cases of ephemeral web views.
1887
1888         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1889         (testWebViewAuthenticationStorage):
1890         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1891         (ephemeralViewloadChanged):
1892         (testCookieManagerEphemeral):
1893         (beforeAll):
1894         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1895         (testWebKitSettings):
1896         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1897         (testWebContextEphemeral):
1898         (ephemeralViewloadChanged):
1899         (testWebContextProxySettings):
1900         (beforeAll):
1901         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1902         (ephemeralViewloadChanged):
1903         (testWebViewEphemeral):
1904         (beforeAll):
1905         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1906         (ephemeralViewloadChanged):
1907         (testWebsiteDataEphemeral):
1908         (beforeAll):
1909
1910 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1911
1912         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1913         https://bugs.webkit.org/show_bug.cgi?id=167402
1914
1915         Reviewed by Ryosuke Niwa.
1916
1917         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1918         (TestWebKitAPI::TEST):
1919
1920 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1921
1922         Add simple line layout toggle to MiniBrowser
1923         https://bugs.webkit.org/show_bug.cgi?id=167405
1924
1925         Reviewed by Andreas Kling.
1926
1927         * MiniBrowser/mac/SettingsController.h:
1928         * MiniBrowser/mac/SettingsController.m:
1929         (-[SettingsController _populateMenu]):
1930         (-[SettingsController validateMenuItem:]):
1931         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1932         (-[SettingsController simpleLineLayoutEnabled]):
1933         * MiniBrowser/mac/WK1BrowserWindowController.m:
1934         (-[WK1BrowserWindowController didChangeSettings]):
1935         * MiniBrowser/mac/WK2BrowserWindowController.m:
1936         (-[WK2BrowserWindowController didChangeSettings]):
1937
1938 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1939
1940         WKR does not include my nick when commit-queue lands my patch
1941         https://bugs.webkit.org/show_bug.cgi?id=167388
1942
1943         Reviewed by Ryosuke Niwa.
1944
1945         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1946         (NewCommitBot._summarize_commit_log):
1947         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1948         Perform nickname insertion before grabbing "Patch by" details.
1949         This way we can include the nickname with the full name.
1950
1951 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1952
1953         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1954         https://bugs.webkit.org/show_bug.cgi?id=167394
1955
1956         Reviewed by Ryosuke Niwa.
1957
1958         * Scripts/webkitperl/FeatureList.pm:
1959         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1960
1961 2017-01-24  Youenn Fablet  <youenn@apple.com>
1962
1963         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1964         https://bugs.webkit.org/show_bug.cgi?id=167353
1965
1966         Reviewed by Alex Christensen.
1967
1968         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1969         (CMakeGenerator.initialize_targets):
1970
1971 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1972
1973         WKR should not confuse Miguel Gomez with Andres Gomez
1974         https://bugs.webkit.org/show_bug.cgi?id=167389
1975
1976         Reviewed by Lucas Forschler.
1977
1978         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1979         "mAndres Gomez". Fix this.
1980
1981         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1982         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1983         space on each side of the email address, so expect both spaces to be there before
1984         considering the email for replacement.
1985         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1986
1987 2017-01-24  Matt Rajca  <mrajca@apple.com>
1988
1989         Pass down website autoplay policies to media elements
1990         https://bugs.webkit.org/show_bug.cgi?id=167355
1991
1992         Reviewed by Alex Christensen.
1993
1994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1995         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1996         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1997         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1998         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1999         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2000         (TEST):
2001
2002 2017-01-24  Nan Wang  <n_wang@apple.com>
2003
2004         AX: Speak Selection does not work in an iframe
2005         https://bugs.webkit.org/show_bug.cgi?id=166794
2006         <rdar://problem/29913013>
2007
2008         Reviewed by Chris Fleizach.
2009
2010         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2011         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2012         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2013         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2014         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2015         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2016         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2017         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2018         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2019         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2020         (-[TestRunnerWKWebView dealloc]):
2021         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2022         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2023         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2024         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2025         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2026
2027 2017-01-24  Daniel Bates  <dabates@apple.com>
2028
2029         StringView.split() should use an iterator design pattern instead of allocating a Vector
2030         https://bugs.webkit.org/show_bug.cgi?id=163225
2031
2032         Reviewed by Darin Adler.
2033
2034         Add unit tests for StringView.split().
2035
2036         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2037         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2038         used in the StringView.split() unit tests.
2039         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2040         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2041         object to a Vector of String objects.
2042         (TestWebKitAPI::TEST): Added the following tests:
2043             - WTF.StringViewSplitEmptyAndNullStrings
2044             - WTF.StringViewSplitBasic
2045             - WTF.StringViewSplitWithConsecutiveSeparators
2046
2047 2017-01-23  Anders Carlsson  <andersca@apple.com>
2048
2049         The Score Esports crashes on launch
2050         https://bugs.webkit.org/show_bug.cgi?id=167338
2051         rdar://problem/29948645
2052
2053         Reviewed by Dan Bernstein.
2054
2055         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2056         (TestWebKitAPI::TEST):
2057         Add a test.
2058
2059 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2060
2061         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2062         https://bugs.webkit.org/show_bug.cgi?id=146589
2063
2064         Reviewed by Michael Catanzaro.
2065
2066         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2067         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2068
2069         * MiniBrowser/gtk/BrowserWindow.c:
2070         (webViewDecidePolicy):
2071         (newTabCallback):
2072         * MiniBrowser/gtk/main.c:
2073         (createBrowserTab):
2074         (aboutDataRequestFree):
2075         (aboutDataRequestNew):
2076         (aboutDataRequestForView):
2077         (websiteDataRemovedCallback):
2078         (websiteDataClearedCallback):
2079         (aboutDataScriptMessageReceivedCallback):
2080         (domainListFree):
2081         (aboutDataFillTable):
2082         (gotWebsiteDataCallback):
2083         (aboutDataHandleRequest):
2084         (aboutURISchemeRequestCallback):
2085         (main):
2086         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2087         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2088         (serverCallback):
2089         (beforeAll):
2090         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2091         (serverCallback):
2092         (WebsiteDataTest::WebsiteDataTest):
2093         (WebsiteDataTest::~WebsiteDataTest):
2094         (WebsiteDataTest::fetch):
2095         (WebsiteDataTest::remove):
2096         (WebsiteDataTest::clear):
2097         (testWebsiteDataConfiguration):
2098         (testWebsiteDataCache):
2099         (testWebsiteDataStorage):
2100         (testWebsiteDataDatabases):
2101         (testWebsiteDataAppcache):
2102         (beforeAll):
2103         (afterAll):
2104
2105 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2106
2107         Unreviewed, rolling out r211062.
2108         https://bugs.webkit.org/show_bug.cgi?id=167354
2109
2110         broke API tests (Requested by alexchristensen on #webkit).
2111
2112         Reverted changeset:
2113
2114         "Pass down website autoplay policies to media elements"
2115         https://bugs.webkit.org/show_bug.cgi?id=167132
2116         http://trac.webkit.org/changeset/211062
2117
2118 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2119
2120         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2121         https://bugs.webkit.org/show_bug.cgi?id=167330
2122
2123         Reviewed by Tim Horton.
2124
2125         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2126         (TestWebKitAPI::TEST_F):
2127
2128 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2129
2130         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2131         https://bugs.webkit.org/show_bug.cgi?id=167317
2132
2133         Reviewed by Sam Weinig.
2134
2135         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2136         (TestWebKitAPI::TEST_F):
2137
2138 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2139
2140         svn-create-patch should emit properties when files are moved or copied
2141         https://bugs.webkit.org/show_bug.cgi?id=167264
2142
2143         Reviewed by Daniel Bates.
2144
2145         * Scripts/svn-create-patch:
2146         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2147
2148 2017-01-23  Youenn Fablet  <youenn@apple.com>
2149
2150         [WebRTC] Filter libwebrtc link flags
2151         https://bugs.webkit.org/show_bug.cgi?id=167287
2152
2153         Reviewed by Alex Christensen.
2154
2155         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2156         (CMakeGenerator._compute_link_flags):
2157         (CMakeGenerator._compute_link_flags.keep_flag):
2158         (CMakeGenerator._generate_compile_target_options):
2159
2160 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2161
2162         [WebRTC] Make VP8 optional in libwebrtc
2163         https://bugs.webkit.org/show_bug.cgi?id=167257
2164
2165         Reviewed by Darin Adler.
2166
2167         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2168         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2169
2170 2017-01-23  Jer Noble  <jer.noble@apple.com>
2171
2172         Video details does not apear and missing scrubber in Control Center
2173         https://bugs.webkit.org/show_bug.cgi?id=167233
2174
2175         Reviewed by Alex Christensen.
2176
2177         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2178         NowPlayingControlTests for iOS.
2179
2180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2181         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2182         (-[NowPlayingTestWebView setWindowVisible:]):
2183         (TestWebKitAPI::TEST):
2184         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2185         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2186         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2187         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2188         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2189         (SOFT_LINK_CLASS):
2190         (-[TestMessageHandler addMessage:withHandler:]):
2191         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2192         (__simulated_forceClickAssociatedEventsMask):
2193         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2194         (-[TestWKWebViewHostWindow isKeyWindow]):
2195         (-[TestWKWebViewHostWindow makeKeyWindow]):
2196         (-[TestWKWebViewHostWindow resignKeyWindow]):
2197         (-[TestWKWebView initWithFrame:]):
2198         (-[TestWKWebView initWithFrame:configuration:]):
2199         (-[TestWKWebView _setUpTestWindow:]):
2200         (-[TestWKWebView performAfterReceivingMessage:action:]):
2201         (-[TestWKWebView loadTestPageNamed:]):
2202         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2203         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2204         (-[TestWKWebView waitForMessage:]):
2205         (-[TestWKWebView performAfterLoading:]):
2206         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2207         (-[TestWKWebView typeCharacter:]):
2208
2209 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2210
2211         Unreviewed. Bring back gtk-doc error messages after r209981.
2212
2213         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2214         impossible to know what's wrong.
2215
2216         * gtk/gtkdoc.py:
2217         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2218
2219 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2220
2221         [WebRTC] Update build system to make G711 optional in libwebrtc
2222         https://bugs.webkit.org/show_bug.cgi?id=167256
2223
2224         Reviewed by Alex Christensen.
2225
2226         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2227         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2228
2229 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2230
2231         Cleanup RuntimeEnabledFeatures
2232         https://bugs.webkit.org/show_bug.cgi?id=167228
2233
2234         Reviewed by Simon Fraser.
2235
2236         * DumpRenderTree/mac/DumpRenderTree.mm:
2237         (enableExperimentalFeatures):
2238         (resetWebPreferencesToConsistentValues):
2239         (setWebPreferencesForTestOptions):
2240         (resetWebViewToConsistentStateBeforeTesting):
2241         * DumpRenderTree/win/DumpRenderTree.cpp:
2242         (enableExperimentalFeatures):
2243         (resetWebPreferencesToConsistentValues):
2244         More closely match WebKitTestRunner initialization of preferences
2245         for experimental features.
2246
2247 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2248
2249         Build Fix for Windows DumpRenderTree after r210976
2250         https://bugs.webkit.org/show_bug.cgi?id=167115
2251
2252         * DumpRenderTree/win/DumpRenderTree.cpp:
2253         (resetWebPreferencesToConsistentValues):
2254
2255 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2256
2257         Remove outdated ENABLE(CSP_NEXT) build flag
2258         https://bugs.webkit.org/show_bug.cgi?id=167252
2259
2260         Reviewed by Brent Fulgham.
2261
2262         * Scripts/webkitperl/FeatureList.pm:
2263         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2264
2265 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2266
2267         Build Fix for Windows DumpRenderTree after r210976
2268
2269         * DumpRenderTree/win/DumpRenderTree.cpp:
2270         (resetWebPreferencesToConsistentValues):
2271
2272 2017-01-20  Antoine Quint  <graouts@apple.com>
2273
2274         Web Animations should be off by default and enabled as an experimental feature
2275         https://bugs.webkit.org/show_bug.cgi?id=167115
2276         <rdar://problem/30048963>
2277
2278         Reviewed by Joseph Pecoraro.
2279
2280         Turn Web Animations on in DRT.
2281
2282         * DumpRenderTree/mac/DumpRenderTree.mm:
2283         (resetWebPreferencesToConsistentValues):
2284         * DumpRenderTree/win/DumpRenderTree.cpp:
2285         (resetWebPreferencesToConsistentValues):
2286
2287 2017-01-20  Youenn Fablet  <youenn@apple.com>
2288
2289         [WebRTC] Add libwebrtc build infrastructure
2290         https://bugs.webkit.org/show_bug.cgi?id=167207
2291
2292         Reviewed by Alex Christensen.
2293
2294         Adding a script doing the libwebrtc project json to CMake file conversion.
2295
2296         * Scripts/generate-libwebrtc-cmake: Added.
2297         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2298         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2299
2300 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2301
2302         Mini Browser: Show tooltip for Experimental Features
2303         https://bugs.webkit.org/show_bug.cgi?id=167225
2304
2305         Reviewed by Alex Christensen.
2306
2307         * MiniBrowser/mac/SettingsController.m:
2308         (-[SettingsController _populateMenu]):
2309         Include the full details string as a tooltip.
2310
2311 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2312
2313         [Win] Test output results should not be written twice.
2314         https://bugs.webkit.org/show_bug.cgi?id=167197
2315
2316         Reviewed by Brent Fulgham.
2317
2318         Prevent test output from being written twice by returning early from
2319         the dump() function, if it already has been called.
2320         This patch also adds a missing newline to a test output line. 
2321         
2322         * DumpRenderTree/win/DumpRenderTree.cpp:
2323         (dump):
2324
2325 2017-01-20  Antoine Quint  <graouts@apple.com>
2326
2327         [Modern Media Controls] Turn modern media controls on by default
2328         https://bugs.webkit.org/show_bug.cgi?id=165668
2329
2330         Reviewed by Dean Jackson.
2331
2332         Enabled modern media controls by default in test runners.
2333
2334         * DumpRenderTree/TestOptions.h:
2335         * WebKitTestRunner/TestOptions.h:
2336
2337 2017-01-19  Chris Dumez  <cdumez@apple.com>
2338
2339         iterable<> should be enabled on WK1
2340         https://bugs.webkit.org/show_bug.cgi?id=167221
2341         <rdar://problem/30108531>
2342
2343         Reviewed by Youenn Fablet.
2344
2345         * DumpRenderTree/mac/DumpRenderTree.mm:
2346         (resetWebPreferencesToConsistentValues):
2347         * DumpRenderTree/win/DumpRenderTree.cpp:
2348         (resetWebPreferencesToConsistentValues):
2349         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2350         (WTR::InjectedBundle::beginTesting):
2351         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2352         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2353         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2354
2355 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2356
2357         Ensure status server logs go to log file
2358         https://bugs.webkit.org/show_bug.cgi?id=167210
2359
2360         Reviewed by Alexey Proskuryakov.
2361
2362         * Scripts/webkitpy/common/net/statusserver.py:
2363         (StatusServer.next_work_item): Change log level from debug to info in
2364         order to facilitate deubgging issues.
2365         (StatusServer.update_work_items): Same.
2366
2367 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2368
2369         Additional selection tests and interpolation fix
2370         https://bugs.webkit.org/show_bug.cgi?id=167171
2371
2372         Reviewed by Simon Fraser.
2373
2374         We weren't adding the final event when interpolating event streams.
2375
2376         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2377         (-[HIDEventGenerator interpolatedEvents:]):
2378
2379 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2380
2381         [Cocoa] Variation fonts are erroneously disabled on iOS
2382         https://bugs.webkit.org/show_bug.cgi?id=167172
2383
2384         Reviewed by Simon Fraser.
2385
2386         OpenSource builders don't seem to understand sdk=embedded*.
2387
2388         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2389
2390 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2391
2392         Unreviewed. Fix GTK+ unit tests failing since r210531.
2393
2394         Avoid using paths to files that don't actually exist.
2395
2396         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2397         (testWebKitConsoleMessageNetworkError):
2398         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2399         (testContextMenuDefaultMenu):
2400         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2401         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2402         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2403
2404 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2405
2406         [GTK] Provide API to set proxy settings
2407         https://bugs.webkit.org/show_bug.cgi?id=128674
2408
2409         Reviewed by Michael Catanzaro.
2410
2411         Add tests for new proxy settings API.
2412
2413         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2414         (serverCallback):
2415         (ProxyTest::ProxyTest):
2416         (ProxyTest::~ProxyTest):
2417         (ProxyTest::loadURIAndGetMainResourceData):
2418         (ProxyTest::proxyServerPortAsString):
2419         (testWebContextProxySettings):
2420         (beforeAll):
2421
2422 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2423
2424         Add back my old email address so old commits will still match it.
2425
2426         * Scripts/webkitpy/common/config/contributors.json:
2427
2428 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2429
2430         Remove my old email address from contributors.json and watchlist.
2431
2432         * Scripts/validate-committer-lists:
2433         (CommitterListFromGit): Change the mapping to the correct email.
2434         * Scripts/webkitpy/common/config/contributors.json:
2435         * Scripts/webkitpy/common/config/watchlist:
2436
2437 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2438
2439         Unreviewed, rolling out r210848.
2440
2441         This change introduced media-related LayoutTest failures and
2442         crashes on macOS.
2443
2444         Reverted changeset:
2445
2446         "[Modern Media Controls] Turn modern media controls on by
2447         default"
2448         https://bugs.webkit.org/show_bug.cgi?id=165668
2449         http://trac.webkit.org/changeset/210848
2450
2451 2017-01-18  Andreas Kling  <akling@apple.com>
2452
2453         Document::securityOrigin() should return a reference.
2454         <https://webkit.org/b/167124>
2455
2456         Reviewed by Sam Weinig.
2457
2458         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2459         (TestWebKitAPI::TEST_F):
2460
2461 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2462
2463         [Win] Clipboard tests are flaky.
2464         https://bugs.webkit.org/show_bug.cgi?id=167088
2465
2466         Reviewed by Brent Fulgham.
2467
2468         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2469         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2470
2471         * DumpRenderTree/win/DumpRenderTree.cpp:
2472         (main):
2473
2474 2017-01-18  Antoine Quint  <graouts@apple.com>
2475
2476         [Modern Media Controls] Turn modern media controls on by default
2477         https://bugs.webkit.org/show_bug.cgi?id=165668
2478
2479         Reviewed by Dean Jackson.
2480
2481         Enabled modern media controls by default in test runners. 
2482
2483         * DumpRenderTree/TestOptions.h:
2484         * WebKitTestRunner/TestOptions.h:
2485
2486 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2487
2488         Unreviewed, rolling out r210834
2489         https://bugs.webkit.org/show_bug.cgi?id=165668
2490
2491         It introduced dozens of test timeouts.
2492
2493         Reverted changeset:
2494         "[Modern Media Controls] Turn modern media controls on by default"
2495         https://bugs.webkit.org/show_bug.cgi?id=165668
2496         http://trac.webkit.org/changeset/210834
2497
2498 2017-01-17  Antoine Quint  <graouts@apple.com>
2499
2500         [Modern Media Controls] Turn modern media controls on by default
2501         https://bugs.webkit.org/show_bug.cgi?id=165668
2502
2503         Reviewed by Dean Jackson.
2504
2505         Enabled modern media controls by default in test runners. 
2506
2507         * DumpRenderTree/TestOptions.h:
2508         * WebKitTestRunner/TestOptions.h:
2509
2510 2017-01-17  Chris Dumez  <cdumez@apple.com>
2511
2512         Document title changed twice when setting document.title
2513         https://bugs.webkit.org/show_bug.cgi?id=167065
2514
2515         Reviewed by Darin Adler.
2516
2517         Add WebKit2GTK API test that was written by Michael Catanzaro.
2518
2519         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2520         (testWebViewTitleChange):
2521         (beforeAll):
2522
2523 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2524
2525         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2526         https://bugs.webkit.org/show_bug.cgi?id=116551
2527         <rdar://problem/13949830>
2528
2529         Reviewed by Alex Christensen.
2530
2531         * Scripts/webkitperl/FeatureList.pm:
2532         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2533         that is part of the existing WEB_TIMING feature.
2534
2535         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2536
2537 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2538
2539         'webkit-patch post' no longer works with moved/copied files
2540         https://bugs.webkit.org/show_bug.cgi?id=166914
2541         <rdar://problem/29979707>
2542
2543         Reviewed by Daniel Bates.
2544
2545         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2546         file outputs only the "Index:" line with an empty body.  This workaround
2547         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2548         public email list tracking this bug is below.
2549         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2550         
2551
2552         * Scripts/svn-create-patch:
2553         (generateDiff): Ignore an "Index:" line with an empty body.
2554
2555 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2556
2557         Remove the REQUEST_ANIMATION_FRAME flag
2558         https://bugs.webkit.org/show_bug.cgi?id=156980
2559         <rdar://problem/25906849>
2560
2561         Reviewed by Simon Fraser.
2562
2563         * Scripts/webkitperl/FeatureList.pm:
2564         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2565
2566 2017-01-15  Sam Weinig  <sam@webkit.org>
2567
2568         Add the ability to use numbers in makeString()
2569         https://bugs.webkit.org/show_bug.cgi?id=167087
2570
2571         Reviewed by Darin Adler.
2572
2573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2574         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2575         Add tests for StringConcatenate, focusing on new numeric additions.
2576
2577 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2578
2579         Unreviewed, remove stale comment.
2580
2581         This test was fixed by r163173.
2582
2583         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2584
2585 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2586
2587         Annotate large string tests with largeHeap
2588         https://bugs.webkit.org/show_bug.cgi?id=167054
2589
2590         Reviewed by Filip Pizlo.
2591
2592         * Scripts/run-javascriptcore-tests:
2593         * Scripts/run-jsc-stress-tests:
2594
2595 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2596
2597         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2598         https://bugs.webkit.org/show_bug.cgi?id=167043
2599
2600         Reviewed by Darin Adler.
2601
2602         * Scripts/webkitperl/FeatureList.pm:
2603
2604 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2605
2606         Remove ENABLE(DETAILS_ELEMENT) guards
2607         https://bugs.webkit.org/show_bug.cgi?id=167042
2608
2609         Reviewed by Alex Christensen.
2610
2611         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2612
2613 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2614
2615         26 MotionMark performance tests failing
2616         https://bugs.webkit.org/show_bug.cgi?id=166854
2617
2618         Reviewed by Ryosuke Niwa.
2619
2620         Unrelated change. This is the last place that we need to rename Animometer
2621         to MotionMark.
2622
2623         * Scripts/webkitpy/common/config/watchlist:
2624
2625 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2626
2627         run-jsc-benchmarks' echo should have -e option
2628         https://bugs.webkit.org/show_bug.cgi?id=167009
2629
2630         Reviewed by Sam Weinig.
2631
2632         echo requires `-e` option to use escape sequence.
2633         Without it, in some environment (in my Fedora 25), the escape sequence is not
2634         recognized and just dumped as `\c` etc.
2635
2636         * Scripts/run-jsc-benchmarks:
2637
2638 2017-01-12  Chris Dumez  <cdumez@apple.com>
2639
2640         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2641         https://bugs.webkit.org/show_bug.cgi?id=166995
2642
2643         Reviewed by Jer Noble.
2644
2645         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2646         as some people are having trouble building without it.
2647
2648         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2649
2650 2017-01-12  Sam Weinig  <sam@webkit.org>
2651
2652         Add the ability to filter the set of bindings tests you want to run
2653         https://bugs.webkit.org/show_bug.cgi?id=166977
2654
2655         Reviewed by Tim Horton.
2656
2657         Allows doing things like:
2658             run-bindings-tests TestObj* TestCEReactions*
2659         
2660         to run only those tests that match the patterns.
2661
2662         * Scripts/run-bindings-tests:
2663         (main):
2664         Switch to using optparse and pass the remaining args as the filters.
2665
2666         * Scripts/webkitpy/bindings/main.py:
2667         (BindingsTests.__init__):
2668         Store the pattens.
2669
2670         (BindingsTests.test_matches_patterns):
2671         Add helper predicate to determine if a test should be run. When no
2672         patterns are present, all tests should run.
2673
2674         (BindingsTests.run_tests):
2675         Filter tests using the passed in patterns.
2676
2677 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2678
2679         Followup fix after r210503.
2680         https://bugs.webkit.org/show_bug.cgi?id=166887
2681
2682         Reviewed by Alex Christensen.
2683
2684         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2685         duplicated file handle on Windows. This patch fixes the remaining call sites.
2686
2687         * DumpRenderTree/PixelDumpSupport.cpp:
2688         * DumpRenderTree/TestRunner.cpp:
2689         (TestRunner::waitToDumpWatchdogTimerFired):
2690         * DumpRenderTree/TestRunner.h:
2691         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2692         * DumpRenderTree/win/DumpRenderTree.cpp:
2693         * DumpRenderTree/win/DumpRenderTreeWin.h:
2694         * DumpRenderTree/win/TestRunnerWin.cpp:
2695         (TestRunner::setSpellCheckerLoggingEnabled):
2696
2697 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2698
2699         Add committer status for Megan
2700         https://bugs.webkit.org/show_bug.cgi?id=166954
2701
2702         Reviewed by Tim Horton.
2703
2704         Add committer status for Megan Gardner
2705
2706         * Scripts/webkitpy/common/config/contributors.json:
2707
2708 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2709
2710         Unreviewed test fix after r210599.
2711
2712         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2713         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2714
2715 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2716
2717         Unreviewed build fix after r210599.
2718
2719         Add missing files.
2720
2721         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2722         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2723
2724 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2725
2726         File scheme should not allow access of a resource on a different volume.
2727         https://bugs.webkit.org/show_bug.cgi?id=158552
2728         <rdar://problem/15307582>
2729
2730         Reviewed by Alex Christensen.
2731
2732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2733         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2734         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2735
2736 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2737
2738         Unreviewed, rolling out r210571.
2739
2740         This change broke the 32-bit macOS build and caused LayoutTest
2741         failures.
2742
2743         Reverted changeset:
2744
2745         "File scheme should not allow access of a resource on a
2746         different volume."
2747         https://bugs.webkit.org/show_bug.cgi?id=158552
2748         http://trac.webkit.org/changeset/210571
2749
2750 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2751
2752         [GTK] install-dependencies script misses gdb
2753         https://bugs.webkit.org/show_bug.cgi?id=166917
2754
2755         Reviewed by Michael Catanzaro.
2756
2757         gdb is needed for generating the crash logs.
2758
2759         * gtk/install-dependencies:
2760
2761 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2762
2763         [GTK] No way for applications to set notification permissions without waiting for permission request
2764         https://bugs.webkit.org/show_bug.cgi?id=163366
2765
2766         Reviewed by Carlos Garcia Campos.
2767
2768         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2769         (testWebViewNotification):
2770         (setInitialNotificationPermissionsAllowedCallback):
2771         (setInitialNotificationPermissionsDisallowedCallback):
2772         (testWebViewNotificationInitialPermissionAllowed):
2773         (testWebViewNotificationInitialPermissionDisallowed):
2774         (beforeAll):
2775         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2776         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2777         (WebViewTest::WebViewTest):
2778         (WebViewTest::initializeWebView):
2779         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2780
2781 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2782
2783         MobileMiniBrowser tests don't work by default
2784         https://bugs.webkit.org/show_bug.cgi?id=166910
2785
2786         Reviewed by Alex Christensen.
2787
2788         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2789         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2790
2791 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2792
2793         File scheme should not allow access of a resource on a different volume.
2794         https://bugs.webkit.org/show_bug.cgi?id=158552
2795         <rdar://problem/15307582>
2796
2797         Reviewed by Alex Christensen.
2798
2799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2800         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2801         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2802
2803 2017-01-10  Mark Lam  <mark.lam@apple.com>
2804
2805         Reverting run-jsc-stress-tests' $buildType to use string values.
2806         https://bugs.webkit.org/show_bug.cgi?id=166912
2807
2808         Rubber stamped by Filip Pizlo.
2809
2810         This is so that we can test for it in the tests e.g.
2811         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2812
2813         * Scripts/run-jsc-stress-tests:
2814
2815 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2816
2817         Temporarily add back the file removed in r210463 to unbreak internal bots.
2818
2819         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2820
2821 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2822
2823         svn-apply failed to apply a patch (deleting file with svn property)
2824         https://bugs.webkit.org/show_bug.cgi?id=165953
2825
2826         Reviewed by Daniel Bates.
2827
2828         * Scripts/VCSUtils.pm:
2829         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2830         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2831
2832 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2833
2834         Update flakiness dashboard configuration.
2835         https://bugs.webkit.org/show_bug.cgi?id=166869
2836
2837         Reviewed by Alexey Proskuryakov.
2838
2839         * TestResultServer/static-dashboards/builders.jsonp:
2840         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2841
2842 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2843
2844         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2845         https://bugs.webkit.org/show_bug.cgi?id=165232
2846
2847         Unreviewed follow-up patch after r210539 and r210523.
2848
2849         Instead of using that environment variable, the argument
2850         --display-server=xorg should be passed now.
2851
2852         The GTK+ performance bot was the only bot using this, and is
2853         already passing --display-server=xorg after r210539.
2854
2855         * Scripts/webkitpy/port/gtk.py:
2856         (GtkPort._driver_class):
2857
2858 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2859
2860         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2861         https://bugs.webkit.org/show_bug.cgi?id=166872
2862
2863         Reviewed by Michael Catanzaro.
2864
2865         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2866         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2867         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2868         The step RunWebKitTests already has support for it.
2869
2870         * BuildSlaveSupport/build.webkit.org-config/config.json:
2871         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2872         (RunGtkAPITests.start):
2873         (RunAndUploadPerfTests.start):
2874         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2875
2876 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2877
2878         Unreviewed, rolling out r210531.
2879
2880         This change broke the 32-bit macOS build and caused LayoutTest
2881         failures.
2882
2883         Reverted changeset:
2884
2885         "File scheme should not allow access of a resource on a
2886         different volume."
2887         https://bugs.webkit.org/show_bug.cgi?id=158552
2888         http://trac.webkit.org/changeset/210531
2889
2890 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2891
2892         File scheme should not allow access of a resource on a different volume.
2893         https://bugs.webkit.org/show_bug.cgi?id=158552
2894         <rdar://problem/15307582>
2895
2896         Reviewed by Alex Christensen.
2897
2898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2899         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2900         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2901
2902 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2903
2904         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2905         https://bugs.webkit.org/show_bug.cgi?id=165232
2906
2907         Reviewed by Michael Catanzaro.
2908
2909         Add a new WaylandDriver to run the tests in the user current wayland session.
2910
2911         Also merge all the configuration options for selecting the display server inside one
2912         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2913
2914         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2915
2916         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2917         (TestRunner._create_driver):
2918         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2919         (parse_args):
2920         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2921         (PerfTestsRunner._parse_args):
2922         * Scripts/webkitpy/port/gtk.py:
2923         (GtkPort.__init__):
2924         (GtkPort._driver_class):
2925         (GtkPort._search_paths):
2926         * Scripts/webkitpy/port/waylanddriver.py: Added.
2927         (WaylandDriver):
2928         (WaylandDriver.check_driver):
2929         (WaylandDriver._setup_environ_for_test):
2930         (WaylandDriver._start):
2931
2932 2017-01-09  Andy Estes  <aestes@apple.com>
2933
2934         [QuickLook] Add a layout test for webkit.org/b/135651
2935         https://bugs.webkit.org/show_bug.cgi?id=166855
2936
2937         Reviewed by Andreas Kling.
2938
2939         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2940         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2941         errors with code WebKitErrorCannotShowURL.
2942         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2943         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2944         not specific to WebKit2 error codes.
2945
2946 2017-01-09  Antoine Quint  <graouts@apple.com>
2947
2948         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2949         https://bugs.webkit.org/show_bug.cgi?id=166837
2950
2951         Reviewed by Alex Christensen.
2952
2953         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2954         the provided value when trying to determine the path to the test file. Failing
2955         that, we use the computed URL or the raw path provided to cover all cases.
2956         
2957         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2958         by applying this patch and seeing the number test failures dramatically reduced
2959         with WK1 due to the option to turn modern media controls off for older media controls
2960         tests.
2961
2962         * DumpRenderTree/DumpRenderTree.h:
2963         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2964         (parseInputLine):
2965         * DumpRenderTree/TestOptions.h:
2966         * DumpRenderTree/TestOptions.mm:
2967         (TestOptions::TestOptions):
2968         * DumpRenderTree/mac/DumpRenderTree.mm:
2969         (runTest):
2970
2971 2017-01-09  Milan Crha  <mcrha@redhat.com>
2972
2973         prepare-ChangeLog: Correct help string for --style option
2974         https://bugs.webkit.org/show_bug.cgi?id=166725
2975
2976         Reviewed by Alexey Proskuryakov.
2977
2978         * Scripts/prepare-ChangeLog:
2979         (main):
2980
2981 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2982
2983         https://bugs.webkit.org/show_bug.cgi?id=166839
2984         Add php7 support for macOS.
2985         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2986
2987         Reviewed by Alexey Proskuryakov.
2988
2989         * Scripts/webkitpy/port/base.py:
2990         (Port._is_darwin_php_version_7):
2991         (Port._debian_php_version):
2992         (Port):
2993         (Port._darwin_php_version):
2994         (Port._apache_config_file_name_for_platform):
2995
2996 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2997
2998         [GTK] Should support key and code properties on keyboard events
2999         https://bugs.webkit.org/show_bug.cgi?id=166759
3000
3001         Reviewed by Carlos Garcia Campos.
3002
3003         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3004         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
3005         on tests.
3006
3007 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
3008
3009         [Win] Some tests are flaky because certain DLLs are writing to stdout.
3010         https://bugs.webkit.org/show_bug.cgi?id=166760
3011
3012         Reviewed by Darin Adler.
3013
3014         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
3015         We can work around that by duplicating and redirecting stdout.
3016
3017         * DumpRenderTree/PixelDumpSupport.cpp:
3018         (dumpWebViewAsPixelsAndCompareWithExpected):
3019         (printPNG):
3020         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3021         (logEventProc):
3022         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3023         (DRTDesktopNotificationPresenter::showDesktopNotification):
3024         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3025         (DRTDesktopNotificationPresenter::requestNotificationPermission):
3026         * DumpRenderTree/win/DumpRenderTree.cpp:
3027         (dumpFrameScrollPosition):
3028         (dumpHistoryItem):
3029         (dumpBackForwardList):
3030         (dump):
3031         (runTest):
3032         (main):
3033         * DumpRenderTree/win/DumpRenderTreeWin.h:
3034         * DumpRenderTree/win/EditingDelegate.cpp:
3035         (EditingDelegate::shouldBeginEditingInDOMRange):
3036         (EditingDelegate::shouldEndEditingInDOMRange):
3037         (EditingDelegate::shouldInsertNode):
3038         (EditingDelegate::shouldInsertText):
3039         (EditingDelegate::shouldDeleteDOMRange):
3040         (EditingDelegate::shouldChangeSelectedDOMRange):
3041         (EditingDelegate::shouldApplyStyle):
3042         (EditingDelegate::shouldChangeTypingStyle):
3043         (EditingDelegate::doPlatformCommand):
3044         (EditingDelegate::webViewDidBeginEditing):
3045         (EditingDelegate::webViewDidChange):
3046         (EditingDelegate::webViewDidEndEditing):
3047         (EditingDelegate::webViewDidChangeTypingStyle):
3048         (EditingDelegate::webViewDidChangeSelection):
3049         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3050         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3051         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3052         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3053         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3054         (FrameLoadDelegate::didCommitLoadForFrame):
3055         (FrameLoadDelegate::didReceiveTitle):
3056         (FrameLoadDelegate::didFinishLoadForFrame):
3057         (FrameLoadDelegate::didFailLoadWithError):
3058         (FrameLoadDelegate::willPerformClientRedirectToURL):
3059         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3060         (FrameLoadDelegate::windowScriptObjectAvailable):
3061         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3062         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3063         (FrameLoadDelegate::didDisplayInsecureContent):
3064         (FrameLoadDelegate::didRunInsecureContent):
3065         (FrameLoadDelegate::webViewProgressFinishedNotification):
3066         * DumpRenderTree/win/HistoryDelegate.cpp:
3067         (HistoryDelegate::didNavigateWithNavigationData):
3068         (HistoryDelegate::didPerformClientRedirectFromURL):
3069         (HistoryDelegate::didPerformServerRedirectFromURL):
3070         (HistoryDelegate::updateHistoryTitle):
3071         (HistoryDelegate::populateVisitedLinksForWebView):
3072         * DumpRenderTree/win/PolicyDelegate.cpp:
3073         (PolicyDelegate::decidePolicyForNavigationAction):
3074         (PolicyDelegate::unableToImplementPolicyWithError):
3075         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3076         (ResourceLoadDelegate::willSendRequest):
3077         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3078         (ResourceLoadDelegate::didReceiveResponse):
3079         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3080         (ResourceLoadDelegate::didFailLoadingWithError):
3081         * DumpRenderTree/win/TestRunnerWin.cpp:
3082         (TestRunner::addDisallowedURL):
3083         (TestRunner::originsWithApplicationCache):
3084         (TestRunner::setStorageDatabaseIdleInterval):
3085         (TestRunner::closeIdleLocalStorageDatabases):
3086         (TestRunner::copyDecodedHostName):
3087         (TestRunner::copyEncodedHostName):
3088         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3089         (TestRunner::isGeolocationProviderActive):
3090         (TestRunner::pathToLocalResource):
3091         (TestRunner::setMockDeviceOrientation):
3092         (TestRunner::setMockGeolocationPosition):
3093         (TestRunner::setMockGeolocationPositionUnavailableError):
3094         (TestRunner::setSpatialNavigationEnabled):
3095         (TestRunner::setAutomaticLinkDetectionEnabled):
3096         (TestRunner::isCommandEnabled):
3097         (TestRunner::authenticateSession):
3098         (TestRunner::addChromeInputField):
3099         (TestRunner::removeChromeInputField):
3100         (TestRunner::focusWebView):
3101         (TestRunner::grantWebNotificationPermission):
3102         (TestRunner::denyWebNotificationPermission):
3103         (TestRunner::removeAllWebNotificationPermissions):
3104         (TestRunner::simulateWebNotificationClick):
3105         (TestRunner::imageCountInGeneralPasteboard):
3106         * DumpRenderTree/win/UIDelegate.cpp:
3107         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3108         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3109         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3110         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3111         (UIDelegate::webViewAddMessageToConsole):
3112         (UIDelegate::exceededDatabaseQuota):
3113         (UIDelegate::setStatusText):
3114         (UIDelegate::didPressMissingPluginButton):
3115
3116 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3117
3118         Add a setting to create editable MiniBrowser windows by default
3119         https://bugs.webkit.org/show_bug.cgi?id=166806
3120
3121         Reviewed by Beth Dakin.
3122
3123         * MiniBrowser/mac/AppDelegate.m:
3124         (-[BrowserAppDelegate createBrowserWindowController:]):
3125         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3126         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3127         * MiniBrowser/mac/SettingsController.h:
3128         * MiniBrowser/mac/SettingsController.m:
3129         (-[SettingsController _populateMenu]):
3130         (-[SettingsController validateMenuItem:]):
3131         (-[SettingsController toggleCreateEditorByDefault:]):
3132         (-[SettingsController createEditorByDefault]):
3133         Add a setting and update the key equivalents accordingly.
3134         Also make sure to make the right kind of window on launch.
3135
3136 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3137
3138         Fix the 32-bit build.
3139
3140         * MiniBrowser/mac/BrowserWindowController.h:
3141         * MiniBrowser/mac/BrowserWindowController.m:
3142
3143 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3144
3145         Fix the 32-bit build.
3146
3147         * MiniBrowser/mac/BrowserWindowController.m:
3148
3149 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3150
3151         Make it possible to drop HTML files on the MiniBrowser icon
3152         https://bugs.webkit.org/show_bug.cgi?id=166802
3153
3154         Reviewed by Simon Fraser.
3155
3156         * MiniBrowser/mac/AppDelegate.m:
3157         (-[BrowserAppDelegate application:openFile:]):
3158         * MiniBrowser/mac/Info.plist:
3159         If you're using an editable window, the usual trick of dropping on the
3160         window doesn't work anymore (it makes an <attachment> instead).
3161
3162 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3163
3164         MiniBrowser window gets smaller each time it is instantiated
3165         https://bugs.webkit.org/show_bug.cgi?id=166807
3166
3167         Reviewed by Andy Estes.
3168
3169         * MiniBrowser/mac/BrowserWindowController.m:
3170         (-[BrowserWindowController windowDidLoad]):
3171         * MiniBrowser/mac/BrowserWindow.xib:
3172         Turn on full-window content view support with IB, instead of waiting
3173         until after the views have been loaded. This seems to resolve the
3174         longstanding ever-shrinking-window problem.
3175
3176 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3177
3178         Add indent/outdent items to MiniBrowser's new format menu
3179         https://bugs.webkit.org/show_bug.cgi?id=166805
3180
3181         Reviewed by Dan Bernstein.
3182
3183         * MiniBrowser/mac/MainMenu.xib:
3184
3185 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3186
3187         Add a stock Format menu to MiniBrowser
3188         https://bugs.webkit.org/show_bug.cgi?id=166804
3189
3190         Reviewed by Andy Estes.
3191
3192         * MiniBrowser/mac/MainMenu.xib:
3193         Many of the features automatically work with editable web views.
3194         However, this seems to expose a bug where none of the font-related features
3195         (Cmd-B, for example) work until the first time the font panel is shown,
3196         per process, which will need to be investigated separately.
3197
3198 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3199
3200         Remove unused applicationWillTerminate methods from MiniBrowser
3201         https://bugs.webkit.org/show_bug.cgi?id=166803
3202
3203         Reviewed by Andy Estes.
3204
3205         * MiniBrowser/mac/AppDelegate.m:
3206         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3207         * MiniBrowser/mac/BrowserWindowController.h:
3208         * MiniBrowser/mac/BrowserWindowController.m:
3209         (-[BrowserWindowController applicationTerminating]): Deleted.
3210         * MiniBrowser/mac/WK1BrowserWindowController.m:
3211         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3212         * MiniBrowser/mac/WK2BrowserWindowController.m:
3213         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3214
3215 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3216
3217         Add the ability to create empty contentEditable windows in MiniBrowser
3218         https://bugs.webkit.org/show_bug.cgi?id=166801
3219
3220         Reviewed by Wenson Hsieh.
3221
3222         * MiniBrowser/mac/AppDelegate.h:
3223         * MiniBrowser/mac/AppDelegate.m:
3224         (-[BrowserAppDelegate createBrowserWindowController:]):
3225         (-[BrowserAppDelegate newWindow:]):
3226         (-[BrowserAppDelegate newEditorWindow:]):
3227         (-[BrowserAppDelegate openDocument:]):
3228         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3229         * MiniBrowser/mac/BrowserWindowController.h:
3230         * MiniBrowser/mac/BrowserWindowController.m:
3231         (-[BrowserWindowController loadHTMLString:]):
3232         (-[BrowserWindowController toggleEditable:]):
3233         * MiniBrowser/mac/MainMenu.xib:
3234         * MiniBrowser/mac/WK1BrowserWindowController.m:
3235         (-[WK1BrowserWindowController awakeFromNib]):
3236         (-[WK1BrowserWindowController loadHTMLString:]):
3237         (-[WK1BrowserWindowController validateMenuItem:]):
3238         (-[WK1BrowserWindowController setEditable:]):
3239         (-[WK1BrowserWindowController updateTitle:]):
3240         * MiniBrowser/mac/WK2BrowserWindowController.m:
3241         (-[WK2BrowserWindowController awakeFromNib]):
3242         (-[WK2BrowserWindowController validateMenuItem:]):
3243         (-[WK2BrowserWindowController setEditable:]):
3244         (-[WK2BrowserWindowController updateTitle:]):
3245         (-[WK2BrowserWindowController loadHTMLString:]):
3246         Merge more functionality from WebEditingTester.
3247         Add two menu items for creating empty editable WebKit1/2 windows.
3248         Add a menu item to the Edit menu to toggle editability on any window.
3249
3250 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3251
3252         Implement find-in-page in MiniBrowser
3253         https://bugs.webkit.org/show_bug.cgi?id=166799
3254
3255         Reviewed by Andy Estes.
3256
3257         * MiniBrowser/mac/BrowserWindow.xib:
3258         * MiniBrowser/mac/BrowserWindowController.h:
3259         * MiniBrowser/mac/BrowserWindowController.m:
3260         (-[BrowserWindowController find:]): Deleted.
3261         * MiniBrowser/mac/MainMenu.xib:
3262         * MiniBrowser/mac/WK1BrowserWindowController.m:
3263         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3264         (-[WK1BrowserWindowController find:]): Deleted.
3265         * MiniBrowser/mac/WK2BrowserWindowController.m:
3266         (-[WK2BrowserWindowController awakeFromNib]):
3267         (-[WK2BrowserWindowController dealloc]):
3268         (-[WK2BrowserWindowController validateMenuItem:]):
3269         (-[WK2BrowserWindowController performTextFinderAction:]):
3270         (-[WK2BrowserWindowController findBarView]):
3271         (-[WK2BrowserWindowController setFindBarView:]):
3272         (-[WK2BrowserWindowController isFindBarVisible]):
3273         (-[WK2BrowserWindowController setFindBarVisible:]):
3274         (-[WK2BrowserWindowController contentView]):
3275         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3276         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3277         (-[WK2BrowserWindowController find:]): Deleted.
3278         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3279         protocol. At first glance, it's pretty broken, but vaguely works.
3280
3281 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3282
3283         Share the implementation of MiniBrowser view hiding functionality
3284         https://bugs.webkit.org/show_bug.cgi?id=166800
3285
3286         Reviewed by Andy Estes.
3287
3288         * MiniBrowser/mac/BrowserWindowController.m:
3289         (-[BrowserWindowController showHideWebView:]):
3290         (-[BrowserWindowController removeReinsertWebView:]):
3291         * MiniBrowser/mac/WK1BrowserWindowController.m:
3292         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3293         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3294         * MiniBrowser/mac/WK2BrowserWindowController.m:
3295         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3296         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3297         Move the implementation of these two things to the shared superclass,
3298         since they don't depend on WebKit-specific things.
3299         Also, there was no reason to retain the (WK)WebView while it was unparented,
3300         as the BrowserWindowController maintains a reference the entire time.
3301
3302 2017-01-06  Andy Estes  <aestes@apple.com>
3303
3304         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3305         https://bugs.webkit.org/show_bug.cgi?id=166789
3306
3307         Reviewed by Alex Christensen.
3308
3309         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3310         * DumpRenderTree/PlatformMac.cmake:
3311         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3312         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3313         * DumpRenderTree/mac/DumpRenderTree.mm:
3314         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3315         createXMLStringFromWebArchiveData().
3316         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3317         * WebKitTestRunner/Configurations/Base.xcconfig:
3318         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3319         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3320         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3321         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3322         createXMLStringFromWebArchiveData().
3323         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3324         * WebKitTestRunner/PlatformMac.cmake:
3325         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3326         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3327
3328 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3329
3330         Minor cleanups to IndentOutdentCommand and related code
3331         https://bugs.webkit.org/show_bug.cgi?id=166791
3332
3333         Reviewed by Simon Fraser.
3334
3335         * WebEditingTester/EditingOperations.m:
3336         (editingOperations):
3337         Add the outdent operation to WebEditingTester.
3338
3339 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3340
3341         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3342         https://bugs.webkit.org/show_bug.cgi?id=166785
3343
3344         Reviewed by Ryosuke Niwa.
3345
3346         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3347         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3348
3349 2017-01-06  Antoine Quint  <graouts@apple.com>
3350
3351         Support webkit-test-runner key-value pairs in http tests
3352         https://bugs.webkit.org/show_bug.cgi?id=149812
3353
3354         Reviewed by Alex Christensen.
3355
3356         We pass the absolute path for a test through to WKTR so that we can parse
3357         tests that are running as URLs for webkit-test-runner options.
3358
3359         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3360         (parseInputLine):
3361
3362         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3363
3364         * Scripts/webkitpy/port/driver.py:
3365         (Driver._command_from_driver_input):
3366
3367         Pass the absolute path to the file through the CLI.
3368
3369         * WebKitTestRunner/TestController.cpp:
3370         (WTR::updateTestOptionsFromTestHeader):
3371         (WTR::TestController::testOptionsForTest):
3372         (WTR::parseInputLine):
3373         (WTR::TestController::runTest):
3374         * WebKitTestRunner/TestController.h:
3375
3376 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3377
3378         Warning about unconnectable outlets when opening a MiniBrowser window
3379         https://bugs.webkit.org/show_bug.cgi?id=166756
3380
3381         Reviewed by Dan Bernstein.
3382
3383         * MiniBrowser/mac/BrowserWindow.xib:
3384         When launching MiniBrowser, it says:
3385         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3386             (MBToolbarItem): missing setter or instance variable
3387         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3388             (NSButtonCell): missing setter or instance variable.
3389
3390         It looks like someone added the connection from the share button
3391         to the BrowserWindowController three times; only one of the connections
3392         is valid. Remove the other two.
3393
3394 2017-01-05  Keith Rollin  <krollin@apple.com>
3395
3396         Add WebCore::URL::protocolHostAndPort
3397         https://bugs.webkit.org/show_bug.cgi?id=166426
3398
3399         Reviewed by Alex Christensen.
3400
3401         Add test for protocolHostAndPort.
3402
3403         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3404         (TestWebKitAPI::TEST_F):
3405
3406 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3407
3408         [Win] Archive test result is failing.
3409         https://bugs.webkit.org/show_bug.cgi?id=166720
3410
3411         Reviewed by Alex Christensen.
3412
3413         Deleting the layout test result folder is sometimes failing
3414         on Windows. This is not a critical error.
3415
3416         * BuildSlaveSupport/test-result-archive:
3417         (archiveTestResults):
3418
3419 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3420
3421         [GTK] Minibrowser: Add printing support
3422         https://bugs.webkit.org/show_bug.cgi?id=165298
3423
3424         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3425         an error during the print, it's printed on the console.
3426
3427         Reviewed by Michael Catanzaro.
3428
3429         * MiniBrowser/gtk/BrowserWindow.c:
3430         (webKitPrintOperationFailedCallback):
3431         (printPage):
3432         (browser_window_init):
3433
3434 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3435
3436         [css-grid] Fix crash clamping grid lines
3437         https://bugs.webkit.org/show_bug.cgi?id=166637
3438
3439         Reviewed by Darin Adler.
3440
3441         Creates new unit test to verify that the maximum tracks limit
3442         is used in GridPosition too.
3443
3444         * TestWebKitAPI/PlatformEfl.cmake:
3445         * TestWebKitAPI/PlatformGTK.cmake:
3446         * TestWebKitAPI/PlatformWin.cmake:
3447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3448         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3449         (TestWebKitAPI::TEST):
3450
3451 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3452
3453         Move editing history scripts to WebCore PrivateHeaders
3454         https://bugs.webkit.org/show_bug.cgi?id=166709
3455         <rdar://problem/29876612>
3456
3457         Reviewed by Dan Bernstein.
3458
3459         Update references to editing script files in WebCore that were moved.
3460
3461         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3462
3463 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3464
3465         Unreviewed, build fix after r210313 part 2
3466         https://bugs.webkit.org/show_bug.cgi?id=166676
3467
3468         Add 'U' suffix.
3469
3470         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3471         (TestWebKitAPI::TEST):
3472         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3473         (TestWebKitAPI::TEST):
3474
3475 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3476
3477         Limit thread name appropriately
3478         https://bugs.webkit.org/show_bug.cgi?id=166676
3479
3480         Reviewed by Sam Weinig.
3481
3482         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3483         (TestWebKitAPI::TEST):
3484         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3485         (TestWebKitAPI::TEST):
3486
3487 2017-01-04  Andy Estes  <aestes@apple.com>
3488
3489         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3490         https://bugs.webkit.org/show_bug.cgi?id=166696
3491
3492         Reviewed by Tim Horton.
3493
3494         * TestWebKitAPI/PlatformGTK.cmake:
3495         * TestWebKitAPI/PlatformWin.cmake:
3496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3497         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3498         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3499         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3500         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3501         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3502         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3503
3504 2017-01-03  Brian Burg  <bburg@apple.com>
3505
3506         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3507         https://bugs.webkit.org/show_bug.cgi?id=166003
3508         <rdar://problem/28718990>
3509
3510         Reviewed by Joseph Pecoraro.
3511
3512         Teach run-inspector-generator-tests to generate test output using the platform name
3513         derived from the directory that the test is in. For example, tests in the /generic/
3514         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3515
3516         * Scripts/webkitpy/inspector/main.py:
3517         (InspectorGeneratorTests.generate_from_json):
3518         (InspectorGeneratorTests.run_tests):
3519         (InspectorGeneratorTests.main):
3520
3521 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3522
3523         Unreviewed cmake buildfix after r210266.
3524
3525         * DumpRenderTree/PlatformMac.cmake:
3526
3527 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3528
3529         Provide a setting for clients to always prefer low-power WebGL
3530         https://bugs.webkit.org/show_bug.cgi?id=166675
3531         <rdar://problem/29834093>
3532
3533         Reviewed by Dan Bernstein.
3534
3535         * MiniBrowser/mac/Info.plist:
3536         Have MiniBrowser claim to be a modern app that supports
3537         automatic graphics switching. WebKit needs to support automatic
3538         graphics switching, so our test app might as well. Without this
3539         Info.plist parameter, this change has no effect, and bringing up
3540         a WebGL context still brings up the discrete GPU (also true of the
3541         existing web-exposed preferLowPowerToHighPerformance API).
3542
3543 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3544
3545         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3546         https://bugs.webkit.org/show_bug.cgi?id=166645
3547
3548         Reviewed by Carlos Garcia Campos.
3549
3550         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3551         (TestWebKitAPI::TEST):
3552
3553 2017-01-03  Andy Estes  <aestes@apple.com>
3554
3555         Place all the Cocoa WebCore API tests in the same directory
3556         https://bugs.webkit.org/show_bug.cgi?id=166673
3557
3558         Reviewed by Michael Catanzaro.
3559
3560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3561         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3562         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3563         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3564
3565 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3566
3567         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3568         https://bugs.webkit.org/show_bug.cgi?id=166450
3569         <rdar://problem/29447824>
3570
3571         Reviewed by Darin Adler.
3572
3573         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3574         * DumpRenderTree/TestRunner.cpp:
3575         (TestRunner::staticFunctions):
3576         * DumpRenderTree/mac/TestRunnerMac.mm:
3577         (setSpellCheckerLoggingEnabledCallback):
3578         * DumpRenderTree/win/TestRunnerWin.cpp:
3579         (setSpellCheckerLoggingEnabledCallback):
3580         * DumpRenderTree/mac/DumpRenderTree.mm:
3581         (resetWebViewToConsistentStateBeforeTesting):
3582         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3583         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3584         (stringForCorrectionResponse):
3585         (drt_NSSpellChecker_recordResponseToCorrection):
3586         (swizzleNSSpellCheckerMethodsIfNeeded):
3587         (setSpellCheckerLoggingEnabled):
3588         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3589         set to true, logs to stdout (which ends up in the test result) whenever
3590         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3591         is called, and then calls the original method. It is reset to false between tests.
3592
3593 2017-01-03  Sam Weinig  <sam@webkit.org>
3594
3595         Make WTF::Expected support Ref template parameters
3596         https://bugs.webkit.org/show_bug.cgi?id=166662
3597
3598         Reviewed by Alex Christensen.
3599
3600         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3601         (TestWebKitAPI::TEST):
3602         Add tests for using Ref with Expected.
3603
3604 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3605
3606         [GTK] Expose WebKitSecurityOrigin API
3607         https://bugs.webkit.org/show_bug.cgi?id=166632
3608
3609         Reviewed by Carlos Garcia Campos.
3610
3611         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3612         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3613         (testSecurityOriginBasicConstructor):
3614         (testSecurityOriginURIConstructor):
3615         (testSecurityOriginDefaultPort):
3616         (testSecurityOriginFileURI):
3617         (testSecurityOriginDataURI):
3618         (beforeAll):
3619         (afterAll):
3620
3621 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3622
3623         [GTK] HTTP auth layout tests are flaky
3624         https://bugs.webkit.org/show_bug.cgi?id=158919
3625
3626         Reviewed by Michael Catanzaro.
3627
3628         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3629         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3630         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3631         missing valac in the bots.
3632
3633 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3634
3635         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3636         https://bugs.webkit.org/show_bug.cgi?id=165797
3637
3638         Reviewed by Michael Catanzaro.
3639
3640         Move directory ruleset after all exclude rules of Source rulset.
3641
3642         * gtk/manifest.txt.in:
3643
3644 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3645
3646         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3647         https://bugs.webkit.org/show_bug.cgi?id=166636
3648
3649         Reviewed by Darin Adler.
3650
3651         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3652         (TestWebKitAPI::TEST):
3653
3654 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3655
3656         [GTK] WebCore/CSSParser unit test is not being built
3657         https://bugs.webkit.org/show_bug.cgi?id=166492
3658
3659         Reviewed by Michael Catanzaro.
3660
3661         This test was introduced in r175930, but we were not building
3662         it on GTK+ port since r176015.
3663         This patch marks the test to be built again on GTK+.
3664         JFTR, the test is passing right now.
3665
3666         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3667         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3668
3669 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3670
3671         AX: Expose block quote level to iOS API
3672         https://bugs.webkit.org/show_bug.cgi?id=166629
3673         <rdar://problem/29834793>
3674
3675         Reviewed by Darin Adler.
3676
3677         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3678         (AccessibilityUIElement::numberAttributeValue):
3679         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3680         (WTR::AccessibilityUIElement::numberAttributeValue):
3681
3682 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3683
3684         SecurityOrigin::create triplet constructor does not canonicalize port
3685         https://bugs.webkit.org/show_bug.cgi?id=166624
3686
3687         Reviewed by Daniel Bates.
3688
3689         * TestWebKitAPI/PlatformGTK.cmake:
3690         * TestWebKitAPI/PlatformWin.cmake:
3691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3692         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3693         (TestWebKitAPI::SecurityOriginTest::SetUp):
3694         (TestWebKitAPI::TEST_F):
3695
3696 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3697
3698         [GTK] Improve user agent construction
3699         https://bugs.webkit.org/show_bug.cgi?id=142074
3700
3701         Reviewed by Carlos Garcia Campos.
3702
3703         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3704         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3705         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3706         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3707         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3708         (TestWebKitAPI::TEST):
3709
3710 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3711
3712         [GTK] Improve user agent construction
3713         https://bugs.webkit.org/show_bug.cgi?id=142074
3714
3715         Reviewed by Carlos Garcia Campos.
3716
3717         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3718         (TestWebKitAPI::TEST):
3719
3720 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3721
3722         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3723         https://bugs.webkit.org/show_bug.cgi?id=166472
3724         rdar://problem/29675551
3725
3726         Reviewed by Tim Horton.
3727
3728         These changes are necessary to allow the mouse to leave the WTR window while
3729         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3730         (which DRT does); we'd always go through mouseMoved, which hits an early return
3731         in WebViewImpl::mouseMoved() when the point is outside the view.
3732
3733         * WebKitTestRunner/mac/EventSenderProxy.mm:
3734         (WTR::EventSenderProxy::mouseMoveTo):
3735
3736 2016-12-23  Andy Estes  <aestes@apple.com>
3737
3738         [iOS] Fix some crashing webarchive tests
3739         https://bugs.webkit.org/show_bug.cgi?id=166470
3740
3741         Reviewed by Andreas Kling.
3742
3743         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3744         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3745         so this change uses that on both platforms.
3746
3747         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3748         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3749         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3750         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3751         * WebKitTestRunner/PlatformMac.cmake:
3752         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3753         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3754
3755 2016-12-22  Saam Barati  <sbarati@apple.com>
3756
3757         WebAssembly: Silence the output of the spec-tests
3758         https://bugs.webkit.org/show_bug.cgi?id=166417
3759
3760         Reviewed by Mark Lam.
3761
3762         * Scripts/run-jsc-stress-tests:
3763
3764 2016-12-22  Zhuo Li  <zachli@apple.com>
3765
3766         [Cocoa] SPI for setloadsImagesAutomatically.
3767         https://bugs.webkit.org/show_bug.cgi?id=166401.
3768
3769         Reviewed by Darin Adler.
3770
3771         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3772         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3773         _loadsImagesAutomatically returns YES.
3774
3775 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3776
3777         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3778         https://bugs.webkit.org/show_bug.cgi?id=161328
3779         <rdar://problem/28475977>
3780
3781         Reviewed by Darin Adler.
3782
3783         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3784         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3785         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3786         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3787         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3788         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3789         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3790         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3791         we finish running a test and before we load the next test.
3792
3793         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3794         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3795         previous test started zooming and then finished before zooming completed. Since this happens before the next
3796         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3797
3798         * WebKitTestRunner/ios/TestControllerIOS.mm:
3799         (WTR::TestController::platformResetStateToConsistentValues):
3800
3801 2016-12-22  Jer Noble  <jer.noble@apple.com>
3802
3803         Muted media element playback should not interrupt other audio playback
3804         https://bugs.webkit.org/show_bug.cgi?id=166347
3805
3806         Reviewed by Eric Carlson.
3807
3808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3809         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3810         (TestWebKitAPI::TEST):
3811         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3812
3813 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3814
3815         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3816         https://bugs.webkit.org/show_bug.cgi?id=166346
3817
3818         Reviewed by Carlos Garcia Campos.
3819
3820         Enable WebRTC by default to simplify testing.
3821
3822         * MiniBrowser/gtk/main.c:
3823         (main):
3824
3825 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3826
3827         REGRESSION: API test failure: WKWebView.LocalStorageClear
3828         https://bugs.webkit.org/show_bug.cgi?id=166032
3829         <rdar://problem/29758423>
3830
3831         Reviewed by Simon Fraser.
3832
3833         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3834         to ensure that the view is destroyed before the callback fires.
3835
3836         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3837         (TEST):
3838
3839 2016-12-21  Saam Barati  <sbarati@apple.com>
3840
3841         WebAssembly: Import spec tests
3842         https://bugs.webkit.org/show_bug.cgi?id=166395
3843
3844         Rubber stamped by Keith Miller.
3845
3846         * Scripts/run-jsc-stress-tests:
3847
3848 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3849
3850         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3851         https://bugs.webkit.org/show_bug.cgi?id=166033
3852         <rdar://problem/29758428>
3853
3854         Reviewed by Simon Fraser.
3855
3856         Add an @autoreleasepool around the code that allocates the WKWebView, 
3857         so that it can be destroyed by removing the last reference in _downloadDidStart.
3858
3859         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3860         (TEST):
3861
3862 2016-12-21  Daniel Bates  <dabates@apple.com>
3863
3864         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3865         https://bugs.webkit.org/show_bug.cgi?id=166356
3866
3867         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3868         as a means to allow a test to explicit allow an embedding client to open a new windows
3869         such that the default behavior is for the embedding client to forbid such an action.
3870         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3871         it is currently skipped on WebKit2 because questions were raised in the patch for
3872         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3873         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3874         this test.
3875
3876         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3877         (WTR::TestRunner::setCanOpenWindows):
3878
3879 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3880
3881         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3882         https://bugs.webkit.org/show_bug.cgi?id=166031
3883
3884         Reviewed by Tim Horton.
3885         
3886         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3887         to ensure that the view is destroyed before the callback fires.
3888
3889         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3890
3891 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3892
3893         Throw Exception when test doesn't clean up HID Events properly
3894         https://bugs.webkit.org/show_bug.cgi?id=166271
3895
3896         Reviewed by Simon Fraser.
3897
3898         Add in a check when UIScriptController is deleted to make sure that the HID event
3899         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3900         the program to crash without any good information. Crashes are race-y, and will still
3901         happen with malformed test, but the information will be much more helpful. 
3902
3903         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3904         (WTR::UIScriptController::checkForClean):
3905         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3906         (UIScriptContext::~UIScriptContext):
3907         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3908         (WTR::UIScriptController::checkForClean):
3909         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3910         * WebKitTestRunner/ios/HIDEventGenerator.h:
3911         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3912         (-[HIDEventGenerator checkHIDCallbacksClear]):
3913         * WebKitTestRunner/ios/TestControllerIOS.mm:
3914         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3915         (WTR::UIScriptController::checkForClean):
3916
3917 2016-12-20  Andy Estes  <aestes@apple.com>
3918
3919         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3920         https://bugs.webkit.org/show_bug.cgi?id=165992
3921
3922         Reviewed by Brady Eidson.
3923
3924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3925         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3926         (expectException):
3927         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3928         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3929         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3930         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3931         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3932         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3933         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3934         (TEST):
3935         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3936
3937 2016-12-20  Dean Jackson  <dino@apple.com>
3938
3939         Remove INDIE_UI
3940         https://bugs.webkit.org/show_bug.cgi?id=165881
3941         <rdar://problem/29672532>
3942
3943         Reviewed by Simon Fraser.
3944
3945         The Indie UI work has been discontinued.
3946
3947         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3948
3949 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3950
3951         [ES6] Enable ES6 Modules
3952         https://bugs.webkit.org/show_bug.cgi?id=165849
3953
3954         Reviewed by Geoffrey Garen.
3955
3956         * DumpRenderTree/mac/DumpRenderTree.mm:
3957         (resetWebPreferencesToConsistentValues):
3958         * DumpRenderTree/win/DumpRenderTree.cpp:
3959         (resetWebPreferencesToConsistentValues):
3960         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3961         (WTR::InjectedBundle::beginTesting):
3962         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3963         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3964         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3965
3966 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3967
3968         Repurpose bots and clean up dashboard.
3969         https://bugs.webkit.org/show_bug.cgi?id=166045
3970
3971         Reviewed by Lucas Forschler.
3972
3973         * BuildSlaveSupport/build.webkit.org-config/config.json:
3974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3975         (BubbleQueueServer):
3976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3978         (WebKitBuildbot):
3979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3980         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3981
3982 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3983
3984         [CMake] TestWebKitAPIBase links to itself
3985         https://bugs.webkit.org/show_bug.cgi?id=165985
3986
3987         Reviewed by Alex Christensen.
3988
3989         Fix CMake warning about a target linking to itself, which makes no sense.
3990
3991         * TestWebKitAPI/CMakeLists.txt:
3992
3993 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3994
3995         [GTK] GtkDoc build should be quieter
3996         https://bugs.webkit.org/show_bug.cgi?id=165994
3997
3998         Reviewed by Carlos Garcia Campos.
3999
4000         Make it not print by default.
4001
4002         * gtk/generate-gtkdoc:
4003         (get_generator_for_config):
4004         (generate_doc):
4005         * gtk/gtkdoc.py:
4006         (GTKDoc._run_command):
4007         (GTKDoc._copy_doc_files_to_output_dir):
4008
4009 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
4010
4011         Expose a way for MiniBrowser to simulate header and footer banners
4012         https://bugs.webkit.org/show_bug.cgi?id=166005
4013
4014         Reviewed by Wenson Hsieh.
4015         
4016         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
4017         banners. This only works in WebKit2.
4018         
4019         We need to reset these on each navigation, since newly created FrameViews
4020         don't re-fetch the header and footer height stored on Page.
4021         
4022         Also fix the signature of webView:didFinishNavigation: to follow API changes,
4023         as well as fixing webViewWebContentProcessDidTerminate:
4024
4025         * MiniBrowser/mac/SettingsController.h:
4026         * MiniBrowser/mac/SettingsController.m:
4027         (-[SettingsController _populateMenu]):
4028         (-[SettingsController validateMenuItem:]):
4029         (-[SettingsController toggleReserveSpaceForBanners:]):
4030         (-[SettingsController isSpaceReservedForBanners]):
4031         * MiniBrowser/mac/WK2BrowserWindowController.m:
4032         (-[WK2BrowserWindowController didChangeSettings]):
4033         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
4034         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
4035         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
4036         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
4037
4038 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
4039
4040         Fix iOS test results after r209967.
4041         
4042         Subtracting out the status bar height was erroneously happening for all tests,
4043         not just for flexible viewport tests.
4044         
4045         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
4046
4047         * WebKitTestRunner/PlatformWebView.h:
4048         * WebKitTestRunner/TestController.cpp:
4049         (WTR::TestController::resetStateToConsistentValues):
4050         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4051         (WTR::PlatformWebView::resizeTo):
4052         (WTR::PlatformWebView::setWindowFrame):
4053         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4054         (WTR::PlatformWebView::resizeTo):
4055         (WTR::PlatformWebView::setWindowFrame):
4056         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4057         (WTR::PlatformWebView::resizeTo):
4058         (WTR::PlatformWebView::setWindowFrame):
4059         * WebKitTestRunner/ios/TestControllerIOS.mm:
4060         (WTR::TestController::platformConfigureViewForTest):
4061         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4062         (WTR::PlatformWebView::resizeTo):
4063         (WTR::PlatformWebView::setWindowFrame):
4064
4065 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
4066
4067         [EFL] bump EFL version to 1.18.4
4068         https://bugs.webkit.org/show_bug.cgi?id=166004
4069
4070         Reviewed by Gyuyoung Kim.
4071
4072         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
4073
4074 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4075
4076         Visual viewports: bottom fixed elements disappear behind the keyboard
4077         https://bugs.webkit.org/show_bug.cgi?id=165983
4078         <rdar://problem/29409852>
4079
4080         Reviewed by Simon Fraser.
4081
4082         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
4083         the keyboard when it is up.
4084
4085         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4086         (WTR::UIScriptController::inputViewBounds):
4087         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4088         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4089         (WTR::UIScriptController::inputViewBounds):
4090         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4091         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4092         (WTR::viewRectForWindowRect):
4093
4094         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
4095         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
4096         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
4097
4098         (WTR::PlatformWebView::PlatformWebView):
4099         (WTR::PlatformWebView::setWindowFrame):
4100         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4101         (WTR::UIScriptController::inputViewBounds):
4102
4103 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
4104
4105         Deleting a character converted from pinyin after an image causes a Safari crash
4106         https://bugs.webkit.org/show_bug.cgi?id=165839
4107         <rdar://problem/27951933>
4108
4109         Reviewed by Wenson Hsieh.
4110
4111         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
4112         while the proposed range contains an image. This should not cause a WebProcess to crash
4113         or send an invalid message to the UIProcess.
4114
4115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4116         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
4117         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
4118         (TestWebKitAPI::didFinishLoadForFrame):
4119         (TestWebKitAPI::processDidCrash):
4120         (TestWebKitAPI::invalidMessageFunction):
4121         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
4122
4123 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
4124
4125         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
4126         https://bugs.webkit.org/show_bug.cgi?id=165767
4127         <rdar://problem/29602382>
4128
4129         Reviewed by Simon Fraser.
4130
4131         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
4132         WebKit2 ChangeLog for more details.
4133
4134         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4135         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4136         (WTR::UIScriptController::textSelectionCaretRect):
4137         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4138         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4139         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4140         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4141         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4142         (WTR::UIScriptController::textSelectionCaretRect):
4143         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4144         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4145         (-[TestRunnerWKWebView _setStableStateOverride:]):
4146
4147         Force the WKWebView to update its visible content rects when changing the stable state override.
4148
4149         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4150         (WTR::toNSDictionary):
4151         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4152         (WTR::UIScriptController::selectionRangeViewRects):
4153         (WTR::UIScriptController::textSelectionCaretRect):
4154         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4155         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4156
4157 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
4158
4159         Arguments called in wrong order
4160         https://bugs.webkit.org/show_bug.cgi?id=165923
4161
4162         Reviewed by Simon Fraser.
4163
4164         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
4165         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
4166
4167         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
4168         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
4169         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
4170
4171 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
4172
4173         [EFL] Disable non-srcdir builds for failing libraries
4174         https://bugs.webkit.org/show_bug.cgi?id=165896
4175
4176         Reviewed by Gyuyoung Kim.
4177
4178         * efl/jhbuild.modules: Set non srcdir builds to no
4179
4180 2016-12-15  Daniel Bates  <dabates@apple.com>
4181
4182         check-style should not complain about code in icu directories
4183         https://bugs.webkit.org/show_bug.cgi?id=53929
4184
4185         Reviewed by Darin Adler.
4186
4187         Skip style checking of imported ICU headers to avoid a deluge of style issues
4188         as they do not conform to the WebKit Code Style guideline. We want to preserve
4189         the formatting of these headers so as to make it straightforward to merge
4190         changes to them, if necessary.
4191
4192         * Scripts/webkitpy/style/checker.py:
4193
4194 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
4195
4196         Move JSC testers from Yosemite to Sierra
4197         https://bugs.webkit.org/show_bug.cgi?id=165925
4198
4199         Reviewed by Lucas Forschler.
4200
4201         * BuildSlaveSupport/build.webkit.org-config/config.json:
4202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4203         (WebKitBuildbot):
4204
4205 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
4206
4207         Add coordinate space to event streams and streamline tests
4208         https://bugs.webkit.org/show_bug.cgi?id=165119
4209
4210         Reviewed by Simon Fraser.
4211
4212         Update event streams to allow for both content and global coordinate space.
4213         Update example script to more accurately show all the available options.
4214
4215         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4216         * WebKitTestRunner/ios/HIDEventGenerator.h:
4217         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4218         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4219         (WTR::convertCoordinates):
4220         (WTR::UIScriptController::sendEventStream):
4221
4222 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
4223
4224         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
4225         https://bugs.webkit.org/show_bug.cgi?id=165855
4226
4227         Reviewed by Philippe Normand.
4228
4229         GStreamer's autogen.sh enables gtk-doc always so we end up building
4230         docs even if we disable them. Use the configure script instead, since
4231         we build from packages and these include it already.
4232
4233         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
4234         upstream gstreamer packages.
4235
4236 2016-12-15  Alex Christensen  <achristensen@webkit.org>
4237
4238         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
4239         https://bugs.webkit.org/show_bug.cgi?id=165885
4240         <rdar://problem/29476917>
4241
4242         Reviewed by Darin Adler.
4243
4244         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4245         (TestWebKitAPI::utf16String): Deleted.
4246         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
4247         (TestWebKitAPI::TEST_F):
4248         * TestWebKitAPI/WTFStringUtilities.h:
4249         (utf16String):
4250         Moved from URLParser to share with other tests.
4251
4252 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
4253
4254         iOS: An element with tabindex is not focusable unless there is no mouse event handler
4255         https://bugs.webkit.org/show_bug.cgi?id=165843
4256
4257         Reviewed by Antti Koivisto.
4258
4259         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
4260         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
4261         and DumpRenderTree's runUIScript would hit an assertion :(
4262
4263         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4264         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4265         (WTR::TestRunner::isWebKit2):
4266
4267 2016-12-14  Brady Eidson  <beidson@apple.com>
4268
4269         IndexedDB 2.0: Massively speedup IDBIndex.get().
4270         https://bugs.webkit.org/show_bug.cgi?id=165802
4271
4272         Reviewed by Alex Christensen.
4273
4274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4275         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
4276         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
4277         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
4278         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
4279
4280 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4281
4282         [GTK][EFL] Update the JHBuild version.
4283         https://bugs.webkit.org/show_bug.cgi?id=165838
4284
4285         Reviewed by Michael Catanzaro.
4286
4287         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
4288         usage of the JHBUILD_MIRROR feature with git repositories.
4289
4290 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4291
4292         [GTK] Yasm is needed for building the JHBuild after r208940
4293         https://bugs.webkit.org/show_bug.cgi?id=165837
4294
4295         Reviewed by Alejandro G. Castro.
4296
4297         * gtk/install-dependencies: Yasm is needed for building libvpx.
4298
4299 2016-12-14  Youenn Fablet  <youenn@apple.com>
4300
4301         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
4302         https://bugs.webkit.org/show_bug.cgi?id=161310
4303
4304         Reviewed by Ryosuke Niwa.
4305
4306         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
4307         When set, WTR and DRT output JS console log in the stderr and not the test output.
4308         This allows removing potentially flaky information while still being able to read it for investigation.
4309
4310         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
4311
4312         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.