Add timing information to build output
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-19  Keith Rollin  <krollin@apple.com>
2
3         Add timing information to build output
4         https://bugs.webkit.org/show_bug.cgi?id=194839
5         <rdar://problem/48219609>
6
7         Reviewed by Alexey Proskuryakov.
8
9         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
10         emit each project's build time to its output. E.g.,
11
12             ** BUILD SUCCEEDED ** [0.132 sec]
13
14         * Scripts/webkitdirs.pm:
15         (XcodeOptions):
16
17 2019-02-19  Truitt Savell  <tsavell@apple.com>
18
19         Unreviewed, rolling out r241784.
20
21         Broke all OpenSource builds.
22
23         Reverted changeset:
24
25         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
26         instances view"
27         https://bugs.webkit.org/show_bug.cgi?id=172848
28         https://trac.webkit.org/changeset/241784
29
30 2019-02-19  Zalan Bujtas  <zalan@apple.com>
31
32         [LFC][Floats] Remove redundant intersecting logic
33         https://bugs.webkit.org/show_bug.cgi?id=194804
34
35         Reviewed by Antti Koivisto.
36
37         * LayoutReloaded/misc/LFC-passing-tests.txt:
38
39 2019-02-19  Dean Jackson  <dino@apple.com>
40
41         Clean-up output from generate-xcfilelists so it can be filtered
42         https://bugs.webkit.org/show_bug.cgi?id=194795
43
44         Reviewed by Joseph Pecoraro (and Keith Rollin).
45
46         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
47         make a slight tweak to filter-build-webkit so such lines are marked
48         as plain.
49
50         * Scripts/filter-build-webkit:
51         * Scripts/generate-xcfilelists:
52
53 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
54
55         pytest is not correctly auto-installed
56         https://bugs.webkit.org/show_bug.cgi?id=194707
57
58         Reviewed by Carlos Garcia Campos.
59
60         * Scripts/webkitpy/thirdparty/__init__.py:
61         (AutoinstallImportHook._install_pytest):
62
63 2019-02-18  Chris Dumez  <cdumez@apple.com>
64
65         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
66         https://bugs.webkit.org/show_bug.cgi?id=194797
67         <rdar://problem/48055151>
68
69         Reviewed by Geoffrey Garen.
70
71         Add API test coverage.
72
73         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
74
75 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
76
77         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
78         https://bugs.webkit.org/show_bug.cgi?id=194670
79         <rdar://problem/39066529>
80
81         Reviewed by Tim Horton.
82
83         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
84         pasted in an editable area as attachment elements.
85
86         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
87         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
88         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
89         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
90         (TestWebKitAPI::TEST):
91         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
92         (WTR::InjectedBundlePage::InjectedBundlePage):
93
94 2019-02-18  Alex Christensen  <achristensen@webkit.org>
95
96         Fix API test after r241728
97        ​https://bugs.webkit.org/show_bug.cgi?id=194723
98
99         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
100         (TEST):
101         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
102
103 2019-02-18  Daniel Bates  <dabates@apple.com>
104
105         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
106         https://bugs.webkit.org/show_bug.cgi?id=192824
107         <rdar://problem/47100332>
108
109         Reviewed by Wenson Hsieh.
110
111         Fix a bug where the wrong usage code was used for F13 thru F24.
112
113         * WebKitTestRunner/ios/HIDEventGenerator.mm:
114         (keyCodeForDOMFunctionKey):
115
116 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
117
118         Bytecode cache should a have a boot-specific validation
119         https://bugs.webkit.org/show_bug.cgi?id=194769
120         <rdar://problem/48149509>
121
122         Reviewed by Keith Miller.
123
124         Add test for WTF::bootSessionUUIDString()
125
126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
127         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
128         (TEST):
129
130 2019-02-18  Alex Christensen  <achristensen@webkit.org>
131
132         Disable safe browsing in WKWebView and remove its WKPreferences API
133         https://bugs.webkit.org/show_bug.cgi?id=194723
134         <rdar://problem/48122993>
135
136         Reviewed by Geoffrey Garen.
137
138         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
139         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
140         (TEST):
141         (safeBrowsingView):
142         Make tests use SPI instead of API.
143
144 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
145
146         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
147         https://bugs.webkit.org/show_bug.cgi?id=194586
148
149         Reviewed by Ross Kirsling.
150
151         * DumpRenderTree/win/DumpRenderTree.cpp:
152         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
153         * Scripts/webkitpy/port/driver.py:
154         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
155
156 2019-02-17  David Kilzer  <ddkilzer@apple.com>
157
158         Unreviewed, rolling out r241620.
159
160         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
161         (Requested by ddkilzer on #webkit.)
162
163         Reverted changeset:
164
165         "[WTF] Add environment variable helpers"
166         https://bugs.webkit.org/show_bug.cgi?id=192405
167         https://trac.webkit.org/changeset/241620
168
169 2019-02-16  Zalan Bujtas  <zalan@apple.com>
170
171         [LFC] RenderImage's default intrinsic size is 0.
172         https://bugs.webkit.org/show_bug.cgi?id=194745
173
174         Reviewed by Antti Koivisto.
175
176         * LayoutReloaded/misc/LFC-passing-tests.txt:
177
178 2019-02-16  Zalan Bujtas  <zalan@apple.com>
179
180         [LFC][BFC] Add support for block replaced intrinsic width.
181         https://bugs.webkit.org/show_bug.cgi?id=194705
182
183         Reviewed by Simon Fraser.
184
185         * LayoutReloaded/misc/LFC-passing-tests.txt:
186
187 2019-02-16  Zalan Bujtas  <zalan@apple.com>
188
189         [LFC] Apply min/max width constraints to preferred width computation
190         https://bugs.webkit.org/show_bug.cgi?id=194739
191
192         Reviewed by Simon Fraser.
193
194         * LayoutReloaded/misc/LFC-passing-tests.txt:
195
196 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
197
198         [WTF] Add environment variable helpers
199         https://bugs.webkit.org/show_bug.cgi?id=192405
200
201         Reviewed by Michael Catanzaro.
202
203         * DumpRenderTree/mac/DumpRenderTree.mm:
204         (libraryPathForDumpRenderTree):
205         * DumpRenderTree/win/DumpRenderTree.cpp:
206         (libraryPathForDumpRenderTree):
207         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
208         (setUpIOSLayoutTestCommunication):
209         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
210         (beforeAll):
211         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
212         (main):
213         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
214         (WebKitTestBus::run):
215         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
216         (WTR::getOutputDir):
217         (WTR::initializeFontConfigSetting):
218         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
219         (WTR::InjectedBundle::platformInitialize):
220         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
221         (WTR::topLevelPath):
222         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
223         (WTR::topLevelPath):
224         (WTR::getOutputDir):
225         (WTR::activateFonts):
226         * WebKitTestRunner/TestController.cpp:
227         (WTR::TestController::libraryPathForTesting):
228         (WTR::TestController::generateContextConfiguration const):
229         (WTR::TestController::generatePageConfiguration):
230         (WTR::TestController::decideDestinationWithSuggestedFilename):
231         (WTR::TestController::platformAdjustContext):
232         * WebKitTestRunner/TestController.h:
233         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
234         (WTR::TestController::cocoaPlatformInitialize):
235         (WTR::TestController::platformAdjustContext):
236         * WebKitTestRunner/gtk/main.cpp:
237         (main):
238         * WebKitTestRunner/mac/TestControllerMac.mm:
239         (WTR::TestController::configureContentExtensionForTest):
240         * WebKitTestRunner/wpe/main.cpp:
241         (main):
242         Utilize WTF::Environment where possible.
243
244 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
245
246         [iOS] WKWebView callout bar is missing Change Writing Direction item
247         https://bugs.webkit.org/show_bug.cgi?id=190015
248         <rdar://problem/44810366>
249
250         Reviewed by Tim Horton.
251
252         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
253         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
254
255         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
256         (TestWebKitAPI::TEST):
257
258 2019-02-15  Chris Dumez  <cdumez@apple.com>
259
260         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
261         https://bugs.webkit.org/show_bug.cgi?id=194717
262         <rdar://problem/47884404>
263
264         Reviewed by Brady Eidson.
265
266         Add API test coverage.
267
268         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
269
270 2019-02-15  Youenn Fablet  <youenn@apple.com>
271
272         Make navigator.mediaDevices SecureContext
273         https://bugs.webkit.org/show_bug.cgi?id=194666
274
275         Reviewed by Eric Carlson.
276
277         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
278         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
279         (TEST_F):
280
281 2019-02-15  Brian Burg  <bburg@apple.com>
282
283         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
284         https://bugs.webkit.org/show_bug.cgi?id=194411
285         <rdar://problem/47787614>
286
287         Reviewed by Joseph Pecoraro.
288
289         Remove unnecessary soft linking macro usage.
290
291         * DumpRenderTree/mac/TestRunnerMac.mm:
292         (TestRunner::inspectorTestStubURL):
293         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
294         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
295         (WTR::TestRunner::inspectorTestStubURL):
296
297 2019-02-15  Commit Queue  <commit-queue@webkit.org>
298
299         Unreviewed, rolling out r241559 and r241566.
300         https://bugs.webkit.org/show_bug.cgi?id=194710
301
302         Causes layout test crashes under GuardMalloc (Requested by
303         ryanhaddad on #webkit).
304
305         Reverted changesets:
306
307         "[WTF] Add environment variable helpers"
308         https://bugs.webkit.org/show_bug.cgi?id=192405
309         https://trac.webkit.org/changeset/241559
310
311         "Unreviewed build fix for WinCairo Debug after r241559."
312         https://trac.webkit.org/changeset/241566
313
314 2019-02-15  Zalan Bujtas  <zalan@apple.com>
315
316         [LFC] Out-of-flow box is never a float box
317         https://bugs.webkit.org/show_bug.cgi?id=194704
318
319         Reviewed by Antti Koivisto.
320
321         * LayoutReloaded/misc/LFC-passing-tests.txt:
322
323 2019-02-10  Darin Adler  <darin@apple.com>
324
325         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
326         https://bugs.webkit.org/show_bug.cgi?id=194487
327
328         Reviewed by Daniel Bates.
329
330         * DumpRenderTree/win/DumpRenderTree.cpp:
331         (applicationId): Use makeString instead of String::format.
332         (main): Ditto.
333         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
334         (TestWebKitAPI::Util::createURLForResource): Ditto.
335         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
336         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
337
338         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
339         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
340         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
341         (WTR::createStringWithAttributes): Use appendLiteral.
342         (WTR::AccessibilityUIElement::helpText const): Ditto.
343         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
344         directly instead of using String::format.
345         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
346         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
347
348 2019-02-15  Truitt Savell  <tsavell@apple.com>
349
350         Unreviewed, rolling out r241564.
351
352         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
353
354         Reverted changeset:
355
356         "[Mac] WebInspectorUI.framework does not need to be soft-
357         linked anymore"
358         https://bugs.webkit.org/show_bug.cgi?id=194411
359         https://trac.webkit.org/changeset/241564
360
361 2019-02-15  Saam barati  <sbarati@apple.com>
362
363         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
364         https://bugs.webkit.org/show_bug.cgi?id=194036
365
366         Reviewed by Yusuke Suzuki.
367
368         * Scripts/run-jsc-stress-tests:
369
370 2019-02-14  Tim Horton  <timothy_horton@apple.com>
371
372         Fix the build.
373
374         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
375         (WTR::UIScriptController::drawSquareInEditableImage):
376         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
377         (TestWebKitAPI::drawSquareInEditableImage):
378
379 2019-02-14  Tim Horton  <timothy_horton@apple.com>
380
381         Fix the build.
382
383         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
384         (WTR::UIScriptController::drawSquareInEditableImage):
385         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
386         (TestWebKitAPI::drawSquareInEditableImage):
387
388 2019-02-14  Brian Burg  <bburg@apple.com>
389
390         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
391         https://bugs.webkit.org/show_bug.cgi?id=194411
392         <rdar://problem/47787614>
393
394         Reviewed by Joseph Pecoraro.
395
396         Remove unnecessary soft linking macro usage.
397
398         * DumpRenderTree/mac/TestRunnerMac.mm:
399         (TestRunner::inspectorTestStubURL):
400         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
401         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
402         (WTR::TestRunner::inspectorTestStubURL):
403
404 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
405
406         [ews-app] status bubble should fetch builder name info from BuilderMapping table
407         https://bugs.webkit.org/show_bug.cgi?id=194599
408
409         Reviewed by Lucas Forschler.
410
411         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
412         (StatusBubble._build_bubble):
413
414 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
415
416         [ews-app] Set Foreign Key in Django build model
417         https://bugs.webkit.org/show_bug.cgi?id=194667
418
419         Reviewed by Lucas Forschler.
420
421         * BuildSlaveSupport/ews-app/ews/models/build.py:
422         (Build):
423
424 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
425
426         [WTF] Add environment variable helpers
427         https://bugs.webkit.org/show_bug.cgi?id=192405
428
429         Reviewed by Michael Catanzaro.
430
431         * DumpRenderTree/mac/DumpRenderTree.mm:
432         (libraryPathForDumpRenderTree):
433         * DumpRenderTree/win/DumpRenderTree.cpp:
434         (libraryPathForDumpRenderTree):
435         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
436         (setUpIOSLayoutTestCommunication):
437         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
438         (TestWebKitAPI::strip):
439         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
440         (beforeAll):
441         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
442         (main):
443         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
444         (WebKitTestBus::run):
445         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
446         (WTR::getOutputDir):
447         (WTR::initializeFontConfigSetting):
448         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
449         (WTR::InjectedBundle::platformInitialize):
450         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
451         (WTR::topLevelPath):
452         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
453         (WTR::topLevelPath):
454         (WTR::getOutputDir):
455         (WTR::activateFonts):
456         * WebKitTestRunner/TestController.cpp:
457         (WTR::TestController::libraryPathForTesting):
458         (WTR::TestController::generateContextConfiguration const):
459         (WTR::TestController::generatePageConfiguration):
460         (WTR::TestController::decideDestinationWithSuggestedFilename):
461         (WTR::TestController::platformAdjustContext):
462         * WebKitTestRunner/TestController.h:
463         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
464         (WTR::TestController::cocoaPlatformInitialize):
465         (WTR::TestController::platformAdjustContext):
466         * WebKitTestRunner/gtk/main.cpp:
467         (main):
468         * WebKitTestRunner/mac/TestControllerMac.mm:
469         (WTR::TestController::configureContentExtensionForTest):
470         * WebKitTestRunner/wpe/main.cpp:
471         (main):
472         Utilize WTF::Environment where possible.
473
474 2019-02-14  Chris Dumez  <cdumez@apple.com>
475
476         [PSON] Introduce a WebContent Process cache
477         https://bugs.webkit.org/show_bug.cgi?id=194594
478         <rdar://problem/46793397>
479
480         Reviewed by Geoff Garen.
481
482         Update API tests to turn on the WebContent Process cache.
483
484         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
485
486 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
487
488         Unreviewed, build fix after r241480
489
490         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
491         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
492         (-[DragAndDropSimulator initWithWebView:]):
493
494 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
495
496         AX: ARIA Reflection was disabled in error
497         https://bugs.webkit.org/show_bug.cgi?id=194647
498         <rdar://problem/48068336>
499
500         Reviewed by Ryosuke Niwa.
501
502         Remove test override now that this feature should be enabled by default.
503
504         * WebKitTestRunner/TestController.cpp:
505         (WTR::TestController::resetPreferencesToConsistentValues):
506
507 2019-02-14  Commit Queue  <commit-queue@webkit.org>
508
509         Unreviewed, rolling out r241486.
510         https://bugs.webkit.org/show_bug.cgi?id=194655
511
512         causing API failures in builds (Requested by ShawnRoberts on
513         #webkit).
514
515         Reverted changeset:
516
517         "[Cocoa] Media elements will restart network buffering just
518         before suspending"
519         https://bugs.webkit.org/show_bug.cgi?id=193691
520         https://trac.webkit.org/changeset/241486
521
522 2019-02-14  Zalan Bujtas  <zalan@apple.com>
523
524         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
525         https://bugs.webkit.org/show_bug.cgi?id=194622
526
527         Reviewed by Antti Koivisto.
528
529         * LayoutReloaded/misc/LFC-passing-tests.txt:
530
531 2019-02-14  Zalan Bujtas  <zalan@apple.com>
532
533         [LFC] Shrink-to-fit-width should be constrained by min/max width
534         https://bugs.webkit.org/show_bug.cgi?id=194653
535
536         Reviewed by Antti Koivisto.
537
538         * LayoutReloaded/misc/LFC-passing-tests.txt:
539
540 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
541
542         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
543         https://bugs.webkit.org/show_bug.cgi?id=194641
544
545         Reviewed by Geoffrey Garen.
546
547         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
548         so that the test would fail without this fix.
549
550         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
551         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
552
553 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
554
555         [ews-app] Change log level for a log statement
556
557         Unreviewed minor fix.
558
559         * BuildSlaveSupport/ews-app/ews/models/patch.py:
560         (Patch.save_patch):
561
562 2019-02-13  Jer Noble  <jer.noble@apple.com>
563
564         [Cocoa] Media elements will restart network buffering just before suspending
565         https://bugs.webkit.org/show_bug.cgi?id=193691
566
567         Reviewed by Eric Carlson.
568
569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
570         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
571         (TEST):
572
573 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
574
575         [ews-app] Fetch builder id to name mapping
576         https://bugs.webkit.org/show_bug.cgi?id=194355
577
578         Reviewed by Lucas Forschler.
579
580         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
581         (Buildbot.get_builder_id_to_name_mapping):
582         (Buildbot._get_display_name_from_builder_name):
583
584 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
585
586         Further restricting webarchive loads
587         https://bugs.webkit.org/show_bug.cgi?id=194567
588         <rdar://problem/47610130>
589
590         Reviewed by Youenn Fablet.
591
592         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
593         navigations on drop.
594
595         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
596         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
597         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
598         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
599         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
600         (TestWebKitAPI::TEST):
601         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
602         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
603         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
604         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
605         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
606         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
607         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
608
609 2019-02-13  John Wilander  <wilander@apple.com>
610
611         Store Ad Click Attribution requests in the network process
612         https://bugs.webkit.org/show_bug.cgi?id=194510
613         <rdar://problem/47650118>
614
615         Reviewed by Alex Christensen and Daniel Bates.
616
617         This patch adds two TestRunner functions:
618         - dumpAdClickAttribution()
619         - clearAdClickAttribution()
620
621         They call into the network process to dump and clear Ad Click
622         Attribution state, respectively.
623
624         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
625         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
626         (WTR::TestRunner::dumpAdClickAttribution):
627         (WTR::TestRunner::clearAdClickAttribution):
628         * WebKitTestRunner/InjectedBundle/TestRunner.h:
629         * WebKitTestRunner/TestController.cpp:
630         (WTR::TestController::resetStateToConsistentValues):
631         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
632         (WTR::adClickAttributionStringResultCallback):
633         (WTR::TestController::dumpAdClickAttribution):
634         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
635         (WTR::adClickAttributionVoidCallback):
636         (WTR::TestController::clearAdClickAttribution):
637         * WebKitTestRunner/TestController.h:
638         * WebKitTestRunner/TestInvocation.cpp:
639         (WTR::TestInvocation::dumpResults):
640         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
641         (WTR::TestInvocation::dumpAdClickAttribution):
642         * WebKitTestRunner/TestInvocation.h:
643
644 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
645
646         [ews-app] Generate status-bubble
647         https://bugs.webkit.org/show_bug.cgi?id=194572
648
649         Reviewed by Lucas Forschler.
650
651         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
652         (StatusBubble._build_bubble):
653         (StatusBubble._should_show_bubble_for):
654         (StatusBubble._build_bubbles_for_patch):
655
656 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
657
658         [ews-app] Add status bubble html template
659         https://bugs.webkit.org/show_bug.cgi?id=194571
660
661         Reviewed by Lucas Forschler.
662
663         * BuildSlaveSupport/ews-app/ews/templates: Added.
664         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
665
666 2019-02-12  Chris Dumez  <cdumez@apple.com>
667
668         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
669         https://bugs.webkit.org/show_bug.cgi?id=194568
670         <rdar://problem/47944490>
671
672         Reviewed by Ryosuke Niwa.
673
674         Add API test coverage.
675
676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
677         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
678
679 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
680
681         webkitpy: Remove bug_dummy from parsed test expectations
682         https://bugs.webkit.org/show_bug.cgi?id=194562
683         <rdar://problem/47853999>
684
685         Reviewed by Lucas Forschler.
686
687         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
688         (TestExpectationParser):
689         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
690         skipped tests.
691         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
692
693 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
694
695         [ews-app] Add method to fetch patch
696         https://bugs.webkit.org/show_bug.cgi?id=194518
697
698         Reviewed by Lucas Forschler.
699
700         * BuildSlaveSupport/ews-app/ews/models/patch.py:
701         (Patch.get_patch):
702
703 2019-02-12  Zalan Bujtas  <zalan@apple.com>
704
705         [LFC] Expand tests coverage (60 new tests -> 860)
706
707         Unreviewed test gardening (run-singly, --child-processes=1).
708
709         * LayoutReloaded/misc/LFC-passing-tests.txt:
710
711 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
712
713         Allow pages to trigger programmatic paste from script on iOS
714         https://bugs.webkit.org/show_bug.cgi?id=194271
715         <rdar://problem/47808810>
716
717         Reviewed by Tim Horton.
718
719         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
720
721         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
722         (WTR::UIScriptController::platformSetDidShowMenuCallback):
723         (WTR::UIScriptController::platformSetDidHideMenuCallback):
724         (WTR::UIScriptController::rectForMenuAction const):
725
726         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
727         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
728         for when the menu is shown or hidden.
729
730         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
731         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
732         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
733         (WTR::UIScriptController::setDidShowMenuCallback):
734         (WTR::UIScriptController::didShowMenuCallback const):
735         (WTR::UIScriptController::setDidHideMenuCallback):
736         (WTR::UIScriptController::didHideMenuCallback const):
737         (WTR::UIScriptController::platformSetDidShowMenuCallback):
738         (WTR::UIScriptController::platformSetDidHideMenuCallback):
739         (WTR::UIScriptController::rectForMenuAction const):
740         * TestRunnerShared/UIScriptContext/UIScriptController.h:
741         * WebKitTestRunner/TestController.cpp:
742         (WTR::TestController::resetPreferencesToConsistentValues):
743         (WTR::updateTestOptionsFromTestHeader):
744         * WebKitTestRunner/TestOptions.h:
745
746         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
747         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
748
749         (WTR::TestOptions::hasSameInitializationOptions const):
750         * WebKitTestRunner/UIScriptControllerCocoa.mm:
751         (WTR::UIScriptController::calendarType const):
752         (WTR::UIScriptController::platformUndoManager const):
753         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
754         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
755         (-[TestRunnerWKWebView initWithFrame:configuration:]):
756         (-[TestRunnerWKWebView dealloc]):
757         (-[TestRunnerWKWebView _didShowMenu]):
758         (-[TestRunnerWKWebView _didHideMenu]):
759
760         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
761
762         * WebKitTestRunner/ios/TestControllerIOS.mm:
763         (WTR::handleMenuWillHideNotification):
764         (WTR::handleMenuDidHideNotification):
765         (WTR::TestController::platformInitialize):
766         (WTR::TestController::platformDestroy):
767         (WTR::TestController::platformResetStateToConsistentValues):
768
769         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
770         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
771
772         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
773         (WTR::forEachViewInHierarchy):
774         (WTR::findViewInHierarchyOfType):
775
776         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
777         functions that dig through a given view's hierarchy in search of a view of a given class.
778
779         (WTR::UIScriptController::selectionStartGrabberViewRect const):
780         (WTR::UIScriptController::selectionEndGrabberViewRect const):
781         (WTR::UIScriptController::selectionCaretViewRect const):
782         (WTR::UIScriptController::selectionRangeViewRects const):
783         (WTR::UIScriptController::platformSetDidShowMenuCallback):
784         (WTR::UIScriptController::platformSetDidHideMenuCallback):
785
786         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
787
788         (WTR::UIScriptController::rectForMenuAction const):
789
790         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
791         callout bar) whose label matches the given string.
792
793         (WTR::UIScriptController::platformContentView const):
794
795         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
796         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
797         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
798
799         (WTR::UIScriptController::platformUndoManager const): Deleted.
800         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
801         (WTR::UIScriptController::platformContentView const):
802         (WTR::UIScriptController::platformUndoManager const): Deleted.
803
804 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
805
806         webkitpy: No option to only show unexpected failures in results.html for iPad
807         https://bugs.webkit.org/show_bug.cgi?id=194554
808         <rdar://problem/47922442>
809
810         Rubber-stamped by Aakash Jain.
811
812         Just because a TestExpecations file does not exist for a specific platform does not mean that
813         TestExpecations are not being used, given that platforms inherit test expectations.
814
815         * Scripts/webkitpy/port/base.py:
816         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
817         * Scripts/webkitpy/port/base_unittest.py:
818         (PortTest.test_uses_test_expectations_file):
819
820 2019-02-12  Alex Christensen  <achristensen@webkit.org>
821
822         Remove setDefersLoading infrastructure from WebKit2
823         https://bugs.webkit.org/show_bug.cgi?id=194506
824
825         Reviewed by Brady Eidson.
826
827         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
828         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
829         (WTR::TestRunner::setDefersLoading): Deleted.
830         * WebKitTestRunner/InjectedBundle/TestRunner.h:
831
832 2019-02-12  Alex Christensen  <achristensen@webkit.org>
833
834         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
835         https://bugs.webkit.org/show_bug.cgi?id=194522
836         <rdar://problem/47789393>
837
838         Reviewed by Chris Dumez.
839
840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
841         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
842         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
843         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
844
845 2019-02-12  Andy Estes  <aestes@apple.com>
846
847         [iOSMac] Enable Parental Controls Content Filtering
848         https://bugs.webkit.org/show_bug.cgi?id=194521
849         <rdar://39732376>
850
851         Reviewed by Tim Horton.
852
853         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
854
855 2019-02-12  Zalan Bujtas  <zalan@apple.com>
856
857         [LFC][IFC] Add intrinsic width support for float boxes.
858         https://bugs.webkit.org/show_bug.cgi?id=194528
859
860         Reviewed by Antti Koivisto.
861
862         Expand tests coverage (2 new tests -> 800).
863         (This is the correct test ordering --runs-singly --child-processes=1)
864
865         * LayoutReloaded/misc/LFC-passing-tests.txt:
866
867 2019-02-12  Rob Buis  <rbuis@igalia.com>
868
869         Implement serializing in MIME type parser
870         https://bugs.webkit.org/show_bug.cgi?id=193909
871
872         Reviewed by Darin Adler.
873
874         Add various tests involving upper case, non-ASCII, control/null characters,
875         various HTTP whitespace, single quotes and an unpaired surrogate.
876
877         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
878         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
879         (TestWebKitAPI::serializeIfValid):
880         (TestWebKitAPI::TEST):
881
882 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
883
884         [Cocoa] Ask platform for generic font family mappings
885         https://bugs.webkit.org/show_bug.cgi?id=187723
886         <rdar://problem/41892438>
887
888         Reviewed by Brent Fulgham.
889
890         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
891
892         * DumpRenderTree/mac/DumpRenderTree.mm:
893         (allowedFontFamilySet):
894         * WebKitTestRunner/mac/TestControllerMac.mm:
895         (WTR::allowedFontFamilySet):
896
897 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
898
899         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
900         https://bugs.webkit.org/show_bug.cgi?id=193622
901
902         Reviewed by Michael Catanzaro.
903
904         This adds support for loading content extension rule sets from the JSON files which
905         accompany the corresponding layout test, using the C API. The Cocoa specific parts
906         of WKTR for this could be removed, but that is left for a follow-up patch with
907         cleanups.
908
909         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
910         * WebKitTestRunner/TestController.cpp:
911         (WTR::testPath): Subtract one from the length when constructing the result std::string to
912         avoid having the null-terminator copied into the result.
913         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
914         part of the preparations to run a test.
915         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
916         (WTR::contentExtensionStoreCallback): Added.
917         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
918         used for content extensions test.
919         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
920         extensions and compiling the JSON rule set for tests involving content extensions.
921         (WTR::TestController::resetContentExtensions): Removes the content extension built for
922         testing and disables content extensions.
923         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
924         resetContentExtensions().
925         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
926         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
927         configureContentExtensionForTest(), and userContentController().
928
929 2019-02-11  Daniel Bates  <dabates@apple.com>
930
931         [iOS] Mouse/Touch/Pointer events are missing modifier keys
932         https://bugs.webkit.org/show_bug.cgi?id=191446
933         <rdar://problem/45929460>
934
935         Reviewed by Tim Horton.
936
937         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
938
939         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
940         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
941         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
942         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
943         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
944         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
945         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
946         * TestRunnerShared/UIScriptContext/UIScriptController.h:
947         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
948         (WTR::arrayLength):
949         (WTR::parseModifierArray):
950         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
951         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
952         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
953         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
954
955 2019-02-11  Commit Queue  <commit-queue@webkit.org>
956
957         Unreviewed, rolling out r241272 and r241276.
958         https://bugs.webkit.org/show_bug.cgi?id=194514
959
960         Broke the Apple Internal build and the fix requires human
961         intervention :( (Requested by dydz on #webkit).
962
963         Reverted changesets:
964
965         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
966         https://bugs.webkit.org/show_bug.cgi?id=191446
967         https://trac.webkit.org/changeset/241272
968
969         "Fix internal iOS build after r241272"
970         https://bugs.webkit.org/show_bug.cgi?id=191446
971         https://trac.webkit.org/changeset/241276
972
973 2019-02-11  Truitt Savell  <tsavell@apple.com>
974
975         Unreviewed, rolling out r241269.
976
977         Caused 5 layout tests crashes on Mac WK1
978
979         Reverted changeset:
980
981         "DumpRenderTree should report unknown options"
982         https://bugs.webkit.org/show_bug.cgi?id=191303
983         https://trac.webkit.org/changeset/241269
984
985 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
986
987         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
988         https://bugs.webkit.org/show_bug.cgi?id=194313
989
990         Reviewed by Tim Horton.
991
992         Add a helper to determine whether the web view is presenting modal UI.
993
994         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
995         (WTR::UIScriptController::isPresentingModally const):
996         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
997         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
998         (WTR::UIScriptController::isPresentingModally const):
999         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1000         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1001         (WTR::UIScriptController::calendarType const): Deleted.
1002         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1003         (WTR::UIScriptController::isPresentingModally const):
1004         (WTR::UIScriptController::calendarType const):
1005         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1006         (WTR::UIScriptController::calendarType const):
1007
1008 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1009
1010         GCHeapInspector: Show the retained sizes in more places
1011         https://bugs.webkit.org/show_bug.cgi?id=194464
1012
1013         Reviewed by Simon Fraser.
1014
1015         * GCHeapInspector/gc-heap-inspector.html:
1016         * GCHeapInspector/script/interface.js:
1017         (HeapInspectorUtils.humanReadableSize):
1018         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1019         (HeapInspectorUtils.spanForNode.span.span):
1020         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1021         (HeapSnapshotInspector.prototype.buildRoots):
1022
1023 2019-02-11  Daniel Bates  <dabates@apple.com>
1024
1025         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1026         https://bugs.webkit.org/show_bug.cgi?id=191446
1027         <rdar://problem/45929460>
1028
1029         Reviewed by Tim Horton.
1030
1031         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1032
1033         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1034         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1035         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1036         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1037         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1038         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1039         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1040         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1041         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1042         (WTR::arrayLength):
1043         (WTR::parseModifierArray):
1044         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1045         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1046         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1047         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1048
1049 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1050
1051         DumpRenderTree should report unknown options
1052         https://bugs.webkit.org/show_bug.cgi?id=191303
1053
1054         Reviewed by Frédéric Wang.
1055
1056         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1057         to report unknown options.
1058         Added and assigned test options which are currently used in tests.
1059
1060         * DumpRenderTree/TestOptions.cpp:
1061         (TestOptions::TestOptions):
1062
1063 2019-02-11  Truitt Savell  <tsavell@apple.com>
1064
1065         Unreviewed, rolling out r241229.
1066
1067         Revision broke internal builds for watchOS.
1068
1069         Reverted changeset:
1070
1071         "[Cocoa] Ask platform for generic font family mappings"
1072         https://bugs.webkit.org/show_bug.cgi?id=187723
1073         https://trac.webkit.org/changeset/241229
1074
1075 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1076
1077         [WinCairo][MiniBrowser] Basic authentication always fails.
1078         https://bugs.webkit.org/show_bug.cgi?id=194496
1079
1080         Reviewed by Don Olmstead.
1081
1082         * MiniBrowser/win/DialogHelper.h:
1083         (Dialog::getText):
1084
1085 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1086
1087         [GStreamer] GstMappedBuffer testsuite build fails
1088         https://bugs.webkit.org/show_bug.cgi?id=194495
1089
1090         Reviewed by Carlos Garcia Campos.
1091
1092         Fix the build by explicitely adding the gstreamer1.0-audio include
1093         directories to the include path.
1094
1095         * TestWebKitAPI/PlatformGTK.cmake:
1096         * TestWebKitAPI/PlatformWPE.cmake:
1097
1098 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1099
1100         [GTK][WPE] Add enable-javascript-markup setting
1101         https://bugs.webkit.org/show_bug.cgi?id=193439
1102
1103         Reviewed by Michael Catanzaro.
1104
1105         Add test cases to check the new setting.
1106
1107         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1108         (testWebKitSettings):
1109         (testWebKitSettingsJavaScriptMarkup):
1110         (beforeAll):
1111
1112 2019-02-10  Darin Adler  <darin@apple.com>
1113
1114         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1115         https://bugs.webkit.org/show_bug.cgi?id=194485
1116
1117         Reviewed by Daniel Bates.
1118
1119         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1120
1121 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1122
1123         Add more tests for clampTo<>()
1124         https://bugs.webkit.org/show_bug.cgi?id=194462
1125
1126         Reviewed by Geoffrey Garen.
1127
1128         Darin suggested to test the very last floating point number
1129         at the boundaries when truncating to integer.
1130         I added test for max/min and max-1/min-1.
1131
1132         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1133         (TestWebKitAPI::TEST):
1134
1135 2019-02-09  Darin Adler  <darin@apple.com>
1136
1137         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1138         https://bugs.webkit.org/show_bug.cgi?id=194021
1139
1140         Reviewed by Geoffrey Garen.
1141
1142         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1143         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1144         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1145
1146 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1147
1148         [LFC][IFC] Add intrinsic width support for basic inline containers
1149         https://bugs.webkit.org/show_bug.cgi?id=194473
1150
1151         Reviewed by Antti Koivisto.
1152
1153         Expand tests coverage (11 new tests -> 798)
1154
1155         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1156
1157 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1158
1159         Fix MiniBrowser's entitlements
1160         https://bugs.webkit.org/show_bug.cgi?id=192431
1161
1162         Reviewed by Joseph Pecoraro.
1163
1164         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1165         files, making it impossible to load any extension.
1166
1167         * MiniBrowser/MiniBrowser.entitlements:
1168
1169 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1170
1171         [Cocoa] Ask platform for generic font family mappings
1172         https://bugs.webkit.org/show_bug.cgi?id=187723
1173         <rdar://problem/41892438>
1174
1175         Reviewed by Brent Fulgham.
1176
1177         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1178
1179         * DumpRenderTree/mac/DumpRenderTree.mm:
1180         (allowedFontFamilySet):
1181         * WebKitTestRunner/mac/TestControllerMac.mm:
1182         (WTR::allowedFontFamilySet):
1183
1184 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1185
1186         [GTK] Implement back/forward touchpad gesture
1187         https://bugs.webkit.org/show_bug.cgi?id=193919
1188
1189         Reviewed by Michael Catanzaro.
1190
1191         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1192         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1193
1194 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1195
1196         Add SPI to use networking daemon instead of XPC service
1197         https://bugs.webkit.org/show_bug.cgi?id=194427
1198
1199         Reviewed by Geoffrey Garen
1200
1201         * MiniBrowser/MiniBrowser.entitlements:
1202
1203 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1204
1205         [ews-build] Ensure that every builder in config.json has short name
1206         https://bugs.webkit.org/show_bug.cgi?id=194461
1207
1208         Reviewed by Lucas Forschler.
1209
1210         * BuildSlaveSupport/ews-build/loadConfig.py:
1211         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1212
1213 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1214
1215         [ews-build] Add short name to config.json
1216         https://bugs.webkit.org/show_bug.cgi?id=194456
1217
1218         Reviewed by Lucas Forschler.
1219
1220         * BuildSlaveSupport/ews-build/config.json: Added short name.
1221         * BuildSlaveSupport/ews-build/loadConfig.py:
1222         (loadBuilderConfig): Set the short name as the builder description.
1223
1224 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1225
1226         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1227         https://bugs.webkit.org/show_bug.cgi?id=194418
1228
1229         Reviewed by Lucas Forschler.
1230
1231         Do not include errors trying when finding crashlogs at the end of
1232         a run-webkit-tests run since we don't process those errors.
1233
1234         * Scripts/webkitpy/port/darwin.py:
1235         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1236         * Scripts/webkitpy/port/ios_device.py:
1237         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1238         * Scripts/webkitpy/port/watch_device.py:
1239         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1240
1241 2019-02-08  Beth Dakin  <bdakin@apple.com>
1242
1243         Add afterScreenUpdates to WKSnapshotConfiguration
1244         https://bugs.webkit.org/show_bug.cgi?id=194362
1245         -and corresponding-
1246         <rdar://problem/40655528> Please add an "after screen updates" property to 
1247         WKSnapshotConfiguration (to solve blank snapshots)
1248
1249         Reviewed by Tim Horton.
1250
1251         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1252         (TEST):
1253
1254 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1255
1256         clampTo(): do not convert the input to double when dealing with integers
1257         https://bugs.webkit.org/show_bug.cgi?id=194263
1258         <rdar://problem/47692312>
1259
1260         Reviewed by Darin Adler.
1261
1262         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1263         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1264         (TestWebKitAPI::testClampFloatingPointToInteger):
1265         (TestWebKitAPI::testClampSameSignIntegers):
1266         (TestWebKitAPI::testClampUnsignedToSigned):
1267         (TestWebKitAPI::testClampSignedToUnsigned):
1268
1269 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1270
1271         webkitpy: Respect --dedicated-simulators flag
1272         https://bugs.webkit.org/show_bug.cgi?id=194416
1273         <rdar://problem/47894722>
1274
1275         Reviewed by Lucas Forschler.
1276
1277         * Scripts/webkitpy/port/device_port.py:
1278         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1279         available devices can be safely ignored.
1280
1281 2019-02-07  Keith Rollin  <krollin@apple.com>
1282
1283         Remove extra copy of 100x100-red.tga
1284         https://bugs.webkit.org/show_bug.cgi?id=194371
1285         <rdar://problem/47873465>
1286
1287         Reviewed by Said Abou-Hallawa.
1288
1289         In order to help it pass its tests, Bug 194190 added a second copy of
1290         the file 100x100-red.tga. However, it turns out that this additional
1291         file wasn't actually needed, and that that sole previous copy was
1292         sufficient. At the same time, this second copy -- which was copied to
1293         the same location in the build output as the first copy -- now caused
1294         XCBuild to complain because there were two production rules for the
1295         same output file. Address this by removing the newly-added extra copy.
1296
1297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1298         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1299
1300 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1301
1302         Deprecate WKBundlePageSetDefersLoading
1303         https://bugs.webkit.org/show_bug.cgi?id=191394
1304
1305         Reviewed by Dean Jackson.
1306
1307         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1308         (WTR::TestRunner::setDefersLoading):
1309
1310 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1311
1312         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1313         https://bugs.webkit.org/show_bug.cgi?id=194391
1314
1315         Reviewed by Antti Koivisto.
1316
1317         * LayoutReloaded/misc/LFC-passing-tests.txt:
1318
1319 2019-02-06  Keith Rollin  <krollin@apple.com>
1320
1321         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1322         https://bugs.webkit.org/show_bug.cgi?id=193975
1323         <rdar://problem/47643306>
1324
1325         Reviewed by Tim Horton.
1326
1327         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1328         the Info.plist file into the bundle. This step is not necessary as the
1329         implicit "bundle up all the build products into a framework" build
1330         phase does this already. Having the Copy Bundle Resources phase do
1331         this causes a conflict under XCBuild, which objects to two build
1332         phases producing the same file (Info.plist). Address this by removing
1333         Info.plist from the Copy Bundle Resources phase.
1334
1335         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1336
1337 2019-02-06  Keith Rollin  <krollin@apple.com>
1338
1339         Really enable the automatic checking and regenerations of .xcfilelists during builds
1340         https://bugs.webkit.org/show_bug.cgi?id=194357
1341         <rdar://problem/47861231>
1342
1343         Reviewed by Chris Dumez.
1344
1345         Bug 194124 was supposed to enable the automatic checking and
1346         regenerating of .xcfilelist files during the build. While related
1347         changes were included in that patch, the change to actually enable the
1348         operation somehow was omitted. This patch actually enables the
1349         operation. The check-xcfilelist.sh scripts now check
1350         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1351         from the checking.
1352
1353         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1354         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1355
1356 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1357
1358         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1359         <https://webkit.org/b/194286>
1360         <rdar://problem/47815558>
1361
1362         Reviewed by Alexey Proskuryakov.
1363
1364         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1365         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1366         WKRetainPtr<> to avoid leaking the WKDataRef.
1367
1368 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1369
1370         Unreviewed, fix a typo
1371
1372         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1373
1374 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1375
1376         [GTK][WPE] force libpsl build to use ICU in jhbuild
1377         https://bugs.webkit.org/show_bug.cgi?id=194288
1378
1379         Reviewed by Carlos Garcia Campos.
1380
1381         * gtk/jhbuild.modules:
1382         Require ICU for libpsl build in jhbuild, like done in WPE.
1383
1384 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1385
1386         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1387         https://bugs.webkit.org/show_bug.cgi?id=194209
1388
1389         Reviewed by Carlos Garcia Campos.
1390
1391         Enhance TestCookieManager to ensure this doesn't happen again.
1392
1393         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1394         (testCookieManagerPersistentStorage):
1395         (beforeAll):
1396
1397 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1398
1399         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1400         https://bugs.webkit.org/show_bug.cgi?id=194324
1401
1402         Reviewed by Andy Estes.
1403
1404         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1405         part of the name is already implicit, since this is in testing code in TestOptions.
1406
1407         * WebKitTestRunner/TestController.cpp:
1408         (WTR::TestController::generateContextConfiguration const):
1409         (WTR::updateTestOptionsFromTestHeader):
1410         * WebKitTestRunner/TestOptions.h:
1411         (WTR::TestOptions::hasSameInitializationOptions const):
1412
1413 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1414
1415         [ews-build] Allow * as platform for builders and workers
1416         https://bugs.webkit.org/show_bug.cgi?id=188533
1417
1418         Reviewed by Lucas Forschler.
1419
1420         * BuildSlaveSupport/ews-build/loadConfig.py:
1421         (checkWorkersAndBuildersForConsistency):
1422
1423 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1424
1425         [ews-build] Add few bots to config.json
1426         https://bugs.webkit.org/show_bug.cgi?id=194304
1427
1428         Reviewed by Lucas Forschler.
1429
1430         * BuildSlaveSupport/ews-build/config.json:
1431
1432 2019-02-05  Keith Rollin  <krollin@apple.com>
1433
1434         Enable the automatic checking and regenerations of .xcfilelists during builds
1435         https://bugs.webkit.org/show_bug.cgi?id=194124
1436         <rdar://problem/47721277>
1437
1438         Reviewed by Tim Horton.
1439
1440         Bug 193790 add a facility for checking -- during build time -- that
1441         any needed .xcfilelist files are up-to-date and for updating them if
1442         they are not. This facility was initially opt-in by setting
1443         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1444         the process seemed robust. Its now time to enable this facility and
1445         make it opt-out. If there is a need to disable this facility, set and
1446         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1447         running `make` or `build-webkit`, or before running Xcode from the
1448         command line.
1449
1450         Additionally, remove the step that generates a list of source files
1451         going into the UnifiedSources build step. It's only necessarily to
1452         specify Sources.txt and SourcesCocoa.txt as inputs.
1453
1454         * Scripts/generate-xcfilelists:
1455
1456 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1457
1458         [GTK][WPE] force libpsl build to use ICU in jhbuild
1459         https://bugs.webkit.org/show_bug.cgi?id=194288
1460
1461         Reviewed by Philippe Normand.
1462
1463         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1464         This can cause build failures if libidn is detected but libunistring is not available.
1465
1466         Make sure that ICU is used for runtime and builtin PSL data.
1467
1468         * gtk/jhbuild.modules:
1469         * wpe/jhbuild.modules:
1470
1471 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1472
1473         [ews-app] Modified timestamp should be updated on updating data
1474         https://bugs.webkit.org/show_bug.cgi?id=194295
1475
1476         Reviewed by Lucas Forschler.
1477
1478         * BuildSlaveSupport/ews-app/ews/models/build.py:
1479         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1480         * BuildSlaveSupport/ews-app/ews/models/step.py:
1481
1482 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1483
1484         Unreviewed, rolling out r240742.
1485
1486         Causes crashes on iOS simulator.
1487
1488         Reverted changeset:
1489
1490         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1491         not focused in a content-editable element"
1492         https://bugs.webkit.org/show_bug.cgi?id=192824
1493         https://trac.webkit.org/changeset/240742
1494
1495 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1496
1497         run-webkit-tests emits message "...running None" when running tests
1498         https://bugs.webkit.org/show_bug.cgi?id=194133
1499         <rdar://problem/47724738>
1500
1501         Reviewed by Lucas Forschler.
1502
1503         * Scripts/webkitpy/xcode/device_type.py:
1504         (DeviceType.__str__): Use both version mapping tables and use just the variant
1505         name if no version name is available.
1506         * Scripts/webkitpy/xcode/device_type_unittest.py:
1507         (DeviceTypeTest):
1508         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1509         an associated named.
1510
1511 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1512
1513         [WPE] require python3-setuptools for meson build in jhbuild
1514         https://bugs.webkit.org/show_bug.cgi?id=194287
1515
1516         Reviewed by Philippe Normand.
1517
1518         python3-setuptools is needed to build meson in jhbuild.
1519         It is already required by the GTK port.
1520
1521         * wpe/install-dependencies:
1522
1523 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1524
1525         [ews-app] Add method to save BuilderMapping to database
1526         https://bugs.webkit.org/show_bug.cgi?id=194264
1527
1528         Reviewed by Lucas Forschler.
1529
1530         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1531         (BuilderMapping.__str__):
1532         (BuilderMapping):
1533         (BuilderMapping.save_mapping):
1534         (BuilderMapping.update_mapping):
1535         (BuilderMapping.get_existing_mapping):
1536         (BuilderMapping.is_valid_mapping):
1537
1538 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1539
1540         [ews-app] Add timestamp fields for BuilderMappings
1541         https://bugs.webkit.org/show_bug.cgi?id=194266
1542
1543         Reviewed by Lucas Forschler.
1544
1545         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1546         (BuilderMapping):
1547
1548 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1549
1550         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1551         https://bugs.webkit.org/show_bug.cgi?id=174816
1552
1553         Reviewed by Michael Catanzaro.
1554
1555         Add tests for webkit_uri_for_display().
1556
1557         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1558         (testURIForDisplayUnaffected):
1559         (testURIForDisplayAffected):
1560         (beforeAll):
1561         (afterAll):
1562         * TestWebKitAPI/glib/CMakeLists.txt:
1563
1564 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1565
1566         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1567         https://bugs.webkit.org/show_bug.cgi?id=194158
1568         <rdar://problem/47737268>
1569
1570         Rubber-stamped by Aakash Jain.
1571
1572         * Scripts/webkitpy/port/device_port.py:
1573         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1574
1575 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1576
1577         [CG] Enable setAdditionalSupportedImageTypes for WK1
1578         https://bugs.webkit.org/show_bug.cgi?id=194190
1579
1580         Reviewed by Tim Horton.
1581
1582         Add a test similar to the one under WebKit Cocoa but make it create a
1583         WebView instead of a WKWebView.
1584
1585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1586         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1587         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1588         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1589         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1590         (TestWebKitAPI::runTest):
1591         (TestWebKitAPI::TEST):
1592
1593 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1594
1595         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1596         https://bugs.webkit.org/show_bug.cgi?id=194168
1597
1598         Reviewed by Simon Fraser.
1599
1600         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1601
1602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1603         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1604         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1605         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1606         (TEST):
1607         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1608         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1609
1610 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1611
1612         REGRESSION (r237269): webkit-patch what-broke is broken 
1613         https://bugs.webkit.org/show_bug.cgi?id=193025
1614
1615         Reviewed by Aakash Jain.
1616
1617         * Scripts/webkitpy/common/host.py:
1618         (Host.buildbot):
1619         (Host.bugzilla): Renamed to 'buildbot'.
1620
1621 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1622
1623         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1624         https://bugs.webkit.org/show_bug.cgi?id=194207
1625
1626         Reviewed by Tim Horton.
1627
1628         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1629         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1630         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1631         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1632         start and delete forwards to remove the original attachment.
1633
1634         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1635         (TestWebKitAPI::TEST):
1636
1637 2019-02-04  Youenn Fablet  <youenn@apple.com>
1638
1639         Capture state should be managed consistently when doing process swapping
1640         https://bugs.webkit.org/show_bug.cgi?id=194122
1641         <rdar://problem/47609293>
1642
1643         Reviewed by Eric Carlson.
1644
1645         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1646         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1647         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1648         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1649         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1650         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1651         (WTR::TestRunner::isDoingMediaCapture const):
1652         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1653         * WebKitTestRunner/TestController.cpp:
1654         (WTR::TestController::isDoingMediaCapture const):
1655         * WebKitTestRunner/TestController.h:
1656         * WebKitTestRunner/TestInvocation.cpp:
1657         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1658         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1659         (WTR::TestController::isDoingMediaCapture const):
1660
1661 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1662
1663         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1664         https://bugs.webkit.org/show_bug.cgi?id=194142
1665
1666         Reviewed by Ross Kirsling.
1667
1668         There three 'separator' variables in TestController.cpp. Renamed
1669         it 'pathSeparator', and unified them.
1670
1671         * WebKitTestRunner/TestController.cpp:
1672         (WTR::TestController::generateContextConfiguration const):
1673         (WTR::createTestURL):
1674         (WTR::TestController::platformAdjustContext):
1675
1676 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1677
1678         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1679         https://bugs.webkit.org/show_bug.cgi?id=194198
1680
1681         Reviewed by Antti Koivisto.
1682
1683         No need to set the banner heights on navigation now, since Page stores them.
1684
1685         * MiniBrowser/mac/WK2BrowserWindowController.m:
1686         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1687
1688 2019-02-03  John Wilander  <wilander@apple.com>
1689
1690         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1691         https://bugs.webkit.org/show_bug.cgi?id=194104
1692         <rdar://problem/47649991>
1693
1694         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1695
1696         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1697         (TestWebKitAPI::TEST):
1698             Changed numeric types from unsigned short to uint32_t.
1699
1700 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1701
1702         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1703         <https://webkit.org/b/194178>
1704         <rdar://problem/47753473>
1705
1706         Reviewed by Alexey Proskuryakov.
1707
1708         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1709         (WTR::uninstallFakeHelvetica): Pass nullptr into
1710         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1711
1712 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1713
1714         [LFC] Initialize ICB's style with fixed width/height.
1715         https://bugs.webkit.org/show_bug.cgi?id=194188
1716
1717         Reviewed by Antti Koivisto.
1718
1719         * LayoutReloaded/misc/LFC-passing-tests.txt:
1720
1721 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1722
1723         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1724         https://bugs.webkit.org/show_bug.cgi?id=194185
1725
1726         Reviewed by Antti Koivisto.
1727
1728         * LayoutReloaded/misc/LFC-passing-tests.txt:
1729
1730 2018-12-16  Darin Adler  <darin@apple.com>
1731
1732         Convert additional String::format clients to alternative approaches
1733         https://bugs.webkit.org/show_bug.cgi?id=192746
1734
1735         Reviewed by Alexey Proskuryakov.
1736
1737         * WebKitTestRunner/TestController.cpp:
1738         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1739         as an intermediate in code that ultimately constructs a WTF::String.
1740         (WTR::userMediaOriginHash): Use makeString.
1741         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1742         (WTR::TestController::didPerformClientRedirect): Ditto.
1743         (WTR::TestController::didPerformServerRedirect): Ditto.
1744         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1745
1746 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1747
1748         [ews-build] Add unit test to verify builder keys
1749         https://bugs.webkit.org/show_bug.cgi?id=194152
1750
1751         Reviewed by Lucas Forschler.
1752
1753         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1754         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1755
1756 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1757
1758         [LFC] Expand tests coverage (12 new tests -> 787)
1759
1760         Unreviewed test gardening.
1761
1762         * LayoutReloaded/misc/LFC-passing-tests.txt:
1763
1764 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1765
1766         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1767         https://bugs.webkit.org/show_bug.cgi?id=194163
1768
1769         Reviewed by Simon Fraser.
1770
1771         775
1772
1773         * LayoutReloaded/misc/LFC-passing-tests.txt:
1774
1775 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1776
1777         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1778         https://bugs.webkit.org/show_bug.cgi?id=194140
1779         <rdar://problem/47728098>
1780
1781         Reviewed by Tim Horton.
1782
1783         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1784         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1785         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1786
1787         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1788         test to induce an IPC deadlock when presenting a modal alert during touch start.
1789
1790         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1791         * WebKitTestRunner/TestController.cpp:
1792         (WTR::runJavaScriptAlert):
1793
1794         Add a client callback function for running JavaScript alerts.
1795
1796         (WTR::TestController::createOtherPage):
1797         (WTR::TestController::generateContextConfiguration const):
1798
1799         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1800         the fix in this patch.
1801
1802         (WTR::TestController::createWebViewWithOptions):
1803
1804         Plumb TestOptions to generateContextConfiguration.
1805
1806         (WTR::TestController::resetPreferencesToConsistentValues):
1807         (WTR::TestController::resetStateToConsistentValues):
1808         (WTR::updateTestOptionsFromTestHeader):
1809         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1810         (WTR::TestController::handleJavaScriptAlert):
1811         * WebKitTestRunner/TestController.h:
1812         * WebKitTestRunner/TestInvocation.cpp:
1813         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1814         * WebKitTestRunner/TestOptions.h:
1815         (WTR::TestOptions::hasSameInitializationOptions const):
1816
1817 2019-02-01  Chris Dumez  <cdumez@apple.com>
1818
1819         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1820         https://bugs.webkit.org/show_bug.cgi?id=193740
1821         <rdar://problem/47527267>
1822
1823         Reviewed by Alex Christensen.
1824
1825         Add API test coverage.
1826
1827         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1828
1829 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1830
1831         [ews-app] Add display name field to BuilderMapping model
1832         https://bugs.webkit.org/show_bug.cgi?id=194153
1833
1834         Reviewed by Lucas Forschler.
1835
1836         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1837         (BuilderMapping):
1838
1839 2019-02-01  Youenn Fablet  <youenn@apple.com>
1840
1841         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1842         https://bugs.webkit.org/show_bug.cgi?id=194155
1843
1844         Reviewed by Eric Carlson.
1845
1846         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1847         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1848         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1849
1850 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1851
1852         [LFC] Adjust replaced element's intrinsic ratio
1853         https://bugs.webkit.org/show_bug.cgi?id=194154
1854
1855         Reviewed by Antti Koivisto.
1856
1857         761
1858
1859         * LayoutReloaded/misc/LFC-passing-tests.txt:
1860
1861 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1862
1863         [WPE] Show test results in minibrowser
1864         https://bugs.webkit.org/show_bug.cgi?id=194150
1865
1866         Reviewed by Žan Doberšek.
1867
1868         * Scripts/webkitpy/port/wpe.py:
1869         (WPEPort.show_results_html_file):
1870
1871 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1872
1873         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1874         https://bugs.webkit.org/show_bug.cgi?id=194151
1875
1876         Reviewed by Žan Doberšek.
1877
1878         ALT + <- go back
1879         ALT + -> go forward
1880
1881         * MiniBrowser/wpe/main.cpp:
1882         (main):
1883
1884 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1885
1886         [LFC] Set intrinsic size on Layout::Replaced
1887         https://bugs.webkit.org/show_bug.cgi?id=194139
1888
1889         Reviewed by Antti Koivisto.
1890
1891         744
1892
1893         * LayoutReloaded/misc/LFC-passing-tests.txt:
1894
1895 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1896
1897         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1898         https://bugs.webkit.org/show_bug.cgi?id=194146
1899
1900         Reviewed by Xabier Rodriguez-Calvar.
1901
1902         It allows to open relative paths.
1903
1904         * MiniBrowser/wpe/main.cpp:
1905         (main):
1906
1907 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1908
1909         Update flakiness dashboard configuration after recent queue changes
1910         https://bugs.webkit.org/show_bug.cgi?id=194127
1911
1912         Rubber-stamped by Aakash Jain.
1913
1914         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1915
1916         * TestResultServer/static-dashboards/builders.jsonp:
1917
1918 2019-01-31  Youenn Fablet  <youenn@apple.com>
1919
1920         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1921         https://bugs.webkit.org/show_bug.cgi?id=194106
1922         <rdar://problem/47676333>
1923
1924         Reviewed by Ryosuke Niwa.
1925
1926         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1927         (TestWebKitAPI::didFinishNavigation):
1928         (TestWebKitAPI::TEST):
1929         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1930
1931 2019-01-31  Chris Dumez  <cdumez@apple.com>
1932
1933         Page zoom level is lost after a process swap or a crash
1934         https://bugs.webkit.org/show_bug.cgi?id=194105
1935         <rdar://problem/47610781>
1936
1937         Reviewed by Alex Christensen.
1938
1939         Add API test coverage.
1940
1941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1942         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1943
1944 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1945
1946         Revert r238819 which is unneeded and caused a performance regression.
1947         https://bugs.webkit.org/show_bug.cgi?id=192272
1948         <rdar://problem/46664625>
1949
1950         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1951         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1952         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1953
1954 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1955
1956         Formalize WebKitAdditions mechanism of LoadOptimizer
1957         https://bugs.webkit.org/show_bug.cgi?id=193886
1958         <rdar://problem/47696809>
1959
1960         Reviewed by Brent Fulgham.
1961
1962         * MiniBrowser/MiniBrowser.entitlements:
1963         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1964
1965 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1966
1967         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1968         https://bugs.webkit.org/show_bug.cgi?id=194090
1969
1970         Reviewed by Antti Koivisto.
1971
1972         * LayoutReloaded/misc/LFC-passing-tests.txt:
1973
1974 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1975
1976         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1977         https://bugs.webkit.org/show_bug.cgi?id=194074
1978
1979         Reviewed by Antti Koivisto.
1980
1981         * LayoutReloaded/misc/LFC-passing-tests.txt:
1982
1983 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1984
1985         [LFC][BFC] Add support for block level replaced box.
1986         https://bugs.webkit.org/show_bug.cgi?id=194071
1987
1988         Reviewed by Antti Koivisto.
1989
1990         * LayoutReloaded/misc/LFC-passing-tests.txt:
1991
1992 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1993
1994         Fix WebKitTestRunner's testPath with Windows full paths
1995         https://bugs.webkit.org/show_bug.cgi?id=194012
1996
1997         Reviewed by Alex Christensen.
1998
1999         updateTestOptionsFromTestHeader failed to open test files because
2000         testPath returned wrong file paths. It returned a path "/C:/..."
2001         if a URL "file:///C:/..." was given.
2002
2003         * WebKitTestRunner/TestController.cpp:
2004         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2005
2006 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2007
2008         [WPE] Bump font related dependencies to match the GTK+ port
2009         https://bugs.webkit.org/show_bug.cgi?id=194017
2010
2011         Reviewed by Žan Doberšek.
2012
2013         * wpe/jhbuild.modules:
2014         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2015         * wpe/patches/icudata-stdlibs.patch: Added.
2016
2017 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2018
2019         Enable swipe tests on iOS
2020         https://bugs.webkit.org/show_bug.cgi?id=194076
2021
2022         Reviewed by Geoffrey Garen.
2023
2024         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2025         it causes a debug assertion failure in runUIScript.
2026
2027         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2028         (WTR::UIScriptController::beginBackSwipe):
2029         (WTR::UIScriptController::completeBackSwipe):
2030
2031 2019-01-30  Keith Rollin  <krollin@apple.com>
2032
2033         Use correct printf format specifier
2034         https://bugs.webkit.org/show_bug.cgi?id=194062
2035         <rdar://problem/47686167>
2036
2037         Reviewed by Alexey Proskuryakov.
2038
2039         LayoutTestSpellChecker.mm is trying to format a variable of type
2040         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2041         actually an unsigned long long. Fix this by formatting with %llu.
2042
2043         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2044         (-[LayoutTestTextCheckingResult description]):
2045
2046 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2047
2048         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2049         https://bugs.webkit.org/show_bug.cgi?id=193979
2050
2051         Reviewed by Wenson Hsieh.
2052
2053         Fix the test for iOS. Make the test work with iOS UA string.
2054
2055         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2056
2057 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2058
2059         Replace High Sierra LLINT CLoop bot due to hardware failure
2060         https://bugs.webkit.org/show_bug.cgi?id=194066
2061
2062         Reviewed by Aakash Jain.
2063
2064         * BuildSlaveSupport/build.webkit.org-config/config.json:
2065
2066 2019-01-30  Keith Rollin  <krollin@apple.com>
2067
2068         [NSDragItem init] is unavailable
2069         https://bugs.webkit.org/show_bug.cgi?id=194059
2070         <rdar://problem/47685715>
2071
2072         Reviewed by Wenson Hsieh.
2073
2074         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2075         DumpRenderTree and TestWebKitAPI, which both try to create an
2076         NSDragItem in a manner that invokes this method. Address this by using
2077         -initWithPasteboardWriter instead.
2078
2079         Note that the parameter passed to initWithPasteboardWriter is likely
2080         incorrect. In both cases, the object passed does not conform to
2081         NSPasteboardWriting. However, with this fix, we're no worse off than
2082         before, and can now perform builds with newer compilers and SDKs until
2083         a real fix can be crafted. That work is tracked in
2084         https://bugs.webkit.org/show_bug.cgi?id=194060
2085
2086         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2087         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2088         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2089         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2090
2091 2019-01-30  Daniel Bates  <dabates@apple.com>
2092
2093         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2094         https://bugs.webkit.org/show_bug.cgi?id=192824
2095         <rdar://problem/47100332>
2096
2097         Reviewed by Wenson Hsieh.
2098
2099         Fix a bug where the wrong usage code was used for F13 thru F24.
2100
2101         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2102         (keyCodeForDOMFunctionKey):
2103
2104 2019-01-30  Chris Dumez  <cdumez@apple.com>
2105
2106         Regression(PSON) Load hang can occur on history navigation
2107         https://bugs.webkit.org/show_bug.cgi?id=194030
2108         <rdar://problem/47656939>
2109
2110         Reviewed by Antti Koivisto.
2111
2112         Add API test coverage.
2113
2114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2115
2116 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2117
2118         [LFC] Expand tests coverage.
2119
2120         Unreviewed test gardening.
2121
2122         * LayoutReloaded/misc/LFC-passing-tests.txt:
2123
2124 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2125
2126         [Flatpak] Add openjpeg support
2127         https://bugs.webkit.org/show_bug.cgi?id=194019
2128
2129         Reviewed by Michael Catanzaro.
2130
2131         * flatpak/org.webkit.CommonModules.yaml:
2132
2133 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2134
2135         Unreviewed, rolling out r240708.
2136         https://bugs.webkit.org/show_bug.cgi?id=194022
2137
2138         It broke WPE build (Requested by KaL on #webkit).
2139
2140         Reverted changeset:
2141
2142         "[WPE] Bump font related dependencies to match the GTK+ port"
2143         https://bugs.webkit.org/show_bug.cgi?id=194017
2144         https://trac.webkit.org/changeset/240708
2145
2146 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2147
2148         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2149         https://bugs.webkit.org/show_bug.cgi?id=194001
2150
2151         Reviewed by Antti Koivisto.
2152
2153         * LayoutReloaded/misc/LFC-passing-tests.txt:
2154
2155 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2156
2157         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2158         https://bugs.webkit.org/show_bug.cgi?id=194020
2159
2160         Reviewed by Antti Koivisto.
2161
2162         * LayoutReloaded/misc/LFC-passing-tests.txt:
2163
2164 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2165
2166         AX: Support color well on iOS
2167         https://bugs.webkit.org/show_bug.cgi?id=194010
2168
2169         Reviewed by Joanmarie Diggs.
2170
2171         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2172         (WTR::AccessibilityUIElement::stringAttributeValue):
2173
2174 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2175
2176         [WPE] Bump font related dependencies to match the GTK+ port
2177         https://bugs.webkit.org/show_bug.cgi?id=194017
2178
2179         Reviewed by Žan Doberšek.
2180
2181         * wpe/jhbuild.modules:
2182         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2183         * wpe/patches/icudata-stdlibs.patch: Added.
2184
2185 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2186
2187         [Mac] Update window scale API usage
2188         https://bugs.webkit.org/show_bug.cgi?id=193991
2189         rdar://problem/47614795
2190
2191         Reviewed by Tim Horton.
2192
2193         * DumpRenderTree/mac/DumpRenderTree.mm:
2194         (changeWindowScaleIfNeeded):
2195         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2196         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2197         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2198
2199 2019-01-29  Chris Dumez  <cdumez@apple.com>
2200
2201         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2202         https://bugs.webkit.org/show_bug.cgi?id=193977
2203         <rdar://problem/47643716>
2204
2205         Reviewed by Geoff Garen.
2206
2207         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2208         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2209         to the previous provisional committing *before* we make the last load. 
2210
2211         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2212
2213 2019-01-29  Youenn Fablet  <youenn@apple.com>
2214
2215         Adopt new SPI to evaluate server certificate trust
2216         https://bugs.webkit.org/show_bug.cgi?id=193355
2217
2218         Reviewed by Alex Christensen.
2219
2220         Add infrastructure to handle HTTPS server trust evaluation testing.
2221
2222         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2223         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2224         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2225         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2226         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2227         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2228         * WebKitTestRunner/TestController.cpp:
2229         (WTR::TestController::resetPreferencesToConsistentValues):
2230         (WTR::TestController::didReceiveAuthenticationChallenge):
2231         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2232         * WebKitTestRunner/TestController.h:
2233         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2234         * WebKitTestRunner/TestInvocation.cpp:
2235         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2236         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2237         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2238
2239 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2240
2241         [ews-build] Add build step to print bot Configuration
2242         https://bugs.webkit.org/show_bug.cgi?id=193887
2243
2244         Reviewed by Lucas Forschler.
2245
2246         * BuildSlaveSupport/ews-build/steps.py:
2247         (PrintConfiguration): Build step to print configuration.
2248         * BuildSlaveSupport/ews-build/factories.py:
2249
2250 2019-01-29  Chris Dumez  <cdumez@apple.com>
2251
2252         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2253         https://bugs.webkit.org/show_bug.cgi?id=193967
2254         <rdar://problem/47635348>
2255
2256         Reviewed by Alex Christensen.
2257
2258         Add API test coverage.
2259
2260         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2261         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2262
2263 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2264
2265         [ews-app] Handle incoming results data
2266         https://bugs.webkit.org/show_bug.cgi?id=193973
2267
2268         Reviewed by Lucas Forschler.
2269
2270         * BuildSlaveSupport/ews-app/ews/views/results.py:
2271
2272 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2273
2274         [ews-app] Make the results url generic
2275         https://bugs.webkit.org/show_bug.cgi?id=193928
2276
2277         Reviewed by Lucas Forschler.
2278
2279         * BuildSlaveSupport/ews-app/ews/urls.py:
2280
2281 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2282
2283         [ews-build] Configure buildbot to send events to ews-app
2284         https://bugs.webkit.org/show_bug.cgi?id=193968
2285
2286         Reviewed by Lucas Forschler.
2287
2288         * BuildSlaveSupport/ews-build/events.py: Added.
2289         * BuildSlaveSupport/ews-build/master.cfg:
2290
2291 2019-01-29  Keith Rollin  <krollin@apple.com>
2292
2293         Add .xcfilelists to Run Script build phases
2294         https://bugs.webkit.org/show_bug.cgi?id=193792
2295         <rdar://problem/47201785>
2296
2297         Reviewed by Alex Christensen.
2298
2299         As part of supporting XCBuild, update the necessary Run Script build
2300         phases in their Xcode projects to refer to their associated
2301         .xcfilelist files.
2302
2303         Note that the addition of these files bumps the Xcode project version
2304         number to something that's Xcode 10 compatible. This change means that
2305         older versions of the Xcode IDE can't read these projects. Nor can it
2306         fully load workspaces that refer to these projects (the updated
2307         projects are shown as non-expandable placeholders). `xcodebuild` can
2308         still build these projects; it's just that the IDE can't open them.
2309
2310         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2311         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2312
2313 2019-01-29  John Wilander  <wilander@apple.com>
2314
2315         Add data abstraction and validation for Ad Click Attribution
2316         https://bugs.webkit.org/show_bug.cgi?id=193916
2317         <rdar://problem/47603481>
2318
2319         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2320
2321         Ad click attribution has two steps. First, the storage of an ad
2322         campaign ID for a click that takes the user to a destination
2323         site. Second, a conversion on the destination site that can be
2324         attributed to the ad click.
2325
2326         This patch adds a class that represents a request for ad click
2327         attribution. Validation makes sure that the bits of entropy
2328         reported through this mechanism is limited.
2329
2330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2331         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2332         (TestWebKitAPI::TEST):
2333
2334 2019-01-29  Chris Dumez  <cdumez@apple.com>
2335
2336         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2337         https://bugs.webkit.org/show_bug.cgi?id=193932
2338         <rdar://problem/47598947>
2339
2340         Reviewed by Brady Eidson.
2341
2342         Add API test coverage.
2343
2344         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2345
2346 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2347
2348         Adding new passing LFC tests.
2349
2350         Unreviewed test gardening.
2351
2352         * LayoutReloaded/misc/LFC-passing-tests.txt:
2353
2354 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2355
2356         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2357         https://bugs.webkit.org/show_bug.cgi?id=193964
2358
2359         Reviewed by Antti Koivisto.
2360
2361         * LayoutReloaded/misc/LFC-passing-tests.txt:
2362
2363 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2364
2365         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2366         https://bugs.webkit.org/show_bug.cgi?id=193954
2367
2368         Reviewed by Antti Koivisto.
2369
2370         * LayoutReloaded/misc/LFC-passing-tests.txt:
2371
2372 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2373
2374         WebDriver: add support for running subtests
2375         https://bugs.webkit.org/show_bug.cgi?id=193904
2376
2377         Reviewed by Michael Catanzaro.
2378
2379         pytest already supports it by passing test.py::subtest, so we can do the same.
2380
2381         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2382         (get_item_name): Made this global.
2383         (CollectRecorder.__init__): Receive the parameter to ignore.
2384         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2385         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2386         (collect): Add parameter to ignore.
2387         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2388         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2389         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2390         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2391         (WebDriverTestRunnerSelenium.run): Ditto.
2392         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2393         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2394         (WebDriverTestRunnerW3C.run): Ditto.
2395
2396 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2397
2398         User agent string override for navigator.userAgent should be site specific quirks
2399         https://bugs.webkit.org/show_bug.cgi?id=193950
2400
2401         Reviewed by Brent Fulgham.
2402
2403         Updated per the _WKWebsitePolicies rename.
2404
2405         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2406         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2407
2408 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2409
2410         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2411         https://bugs.webkit.org/show_bug.cgi?id=193941
2412
2413         Reviewed by Alex Christensen.
2414
2415         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2416         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2417         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2418         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2419         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2420         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2421         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2422         * TestWebKitAPI/Tests/WTF/Time.cpp:
2423         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2424         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2425         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2426         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2427
2428 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2429
2430         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2431
2432         * Scripts/webkitpy/common/config/contributors.json:
2433
2434 2019-01-28  Andy Estes  <aestes@apple.com>
2435
2436         [watchOS] Enable Parental Controls content filtering
2437         https://bugs.webkit.org/show_bug.cgi?id=193939
2438         <rdar://problem/46641912>
2439
2440         Reviewed by Ryosuke Niwa.
2441
2442         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2443
2444 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2445
2446         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2447         <https://webkit.org/b/193884>
2448
2449         Reviewed by Jiewen Tan.
2450
2451         * Scripts/webkitpy/style/checkers/cpp.py:
2452         (check_language): Add LocalAuthentication to
2453         `frameworks_with_soft_links`.
2454
2455 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2456
2457         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2458         https://bugs.webkit.org/show_bug.cgi?id=193891
2459
2460         Reviewed by Ross Kirsling.
2461
2462         There were three problems in window sizes of WebView and the host window.
2463         1. The sizes of pixel image output were incorrect.
2464         2. The host window is going to appear after window.resize was invoked.
2465         3. window.resize resized only the host window, not WebView.
2466
2467         This change solves them with a following approach.
2468         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2469         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2470            as well as DumpRenderTree in order to match the client area and the window area.
2471         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2472         d. PlatformWebView::setWindowFrame changes both window sizes.
2473         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2474
2475         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2476         (WTR::PlatformWebView::PlatformWebView): Create the host window
2477         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2478         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2479         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2480
2481 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2482
2483         [ews-app] Add method to save Step data to database
2484         https://bugs.webkit.org/show_bug.cgi?id=193890
2485
2486         Reviewed by Lucas Forschler.
2487
2488         * BuildSlaveSupport/ews-app/ews/models/step.py:
2489         (Step.save_step): Method to save step data.
2490         (Step.update_step): Method to update step data.
2491         (Step.get_existing_step): Method to fetch existing step from database.
2492         (Step.is_valid_result): Method to validate valid step result.
2493
2494 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2495
2496         [ews-app] Add method to save Build data to database
2497         https://bugs.webkit.org/show_bug.cgi?id=193735
2498
2499         Reviewed by Lucas Forschler.
2500
2501         * BuildSlaveSupport/ews-app/ews/models/build.py:
2502         (Build.save_build): Method to save build information to database.
2503         (Build.get_existing_build): Method to fetch existing build from database.
2504         (Build.is_valid_result): Method to validate build result.
2505         * BuildSlaveSupport/ews-app/ews/common/util.py:
2506         (is_valid_int_id): Method to validate valid id.
2507
2508 2019-01-28  Chris Dumez  <cdumez@apple.com>
2509
2510         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2511         https://bugs.webkit.org/show_bug.cgi?id=193915
2512         <rdar://problem/47560907>
2513
2514         Reviewed by Alex Christensen.
2515
2516         Add API test coverage.
2517
2518         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2519
2520 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2521
2522         [ews-app] Rename id variables
2523         https://bugs.webkit.org/show_bug.cgi?id=193883
2524
2525         Reviewed by Lucas Forschler.
2526
2527         * BuildSlaveSupport/ews-app/ews/models/build.py:
2528         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2529         * BuildSlaveSupport/ews-app/ews/models/step.py:
2530         * BuildSlaveSupport/ews-app/ews/urls.py:
2531         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2532         * BuildSlaveSupport/ews-app/ews/views/results.py:
2533         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2534
2535 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2536
2537         [ews-app] Allow certain fields to be empty
2538         https://bugs.webkit.org/show_bug.cgi?id=193892
2539
2540         Reviewed by Lucas Forschler.
2541
2542         * BuildSlaveSupport/ews-app/ews/models/build.py:
2543         * BuildSlaveSupport/ews-app/ews/models/step.py:
2544
2545 2019-01-28  Rob Buis  <rbuis@igalia.com>
2546
2547         Update MIME type parser
2548         https://bugs.webkit.org/show_bug.cgi?id=180526
2549
2550         Reviewed by Frédéric Wang.
2551
2552         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2553         (TestWebKitAPI::TEST):
2554
2555 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2556
2557         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2558         https://bugs.webkit.org/show_bug.cgi?id=193896
2559
2560         Reviewed by Antti Koivisto.
2561
2562         * LayoutReloaded/misc/LFC-passing-tests.txt:
2563
2564 2018-12-15  Darin Adler  <darin@apple.com>
2565
2566         Replace many uses of String::format with more type-safe alternatives
2567         https://bugs.webkit.org/show_bug.cgi?id=192742
2568
2569         Reviewed by Mark Lam.
2570
2571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2572         (WTR::cacheTestRunnerCallback): Use makeString.
2573         * WebKitTestRunner/TestController.cpp:
2574         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2575         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2576
2577 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2578
2579         Use a load optimizer for some sites
2580         https://bugs.webkit.org/show_bug.cgi?id=193881
2581         <rdar://problem/46325455>
2582
2583         Reviewed by Brent Fulgham.
2584
2585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2586         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2587
2588 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2589
2590         AX: Introduce a static accessibility tree
2591         https://bugs.webkit.org/show_bug.cgi?id=193348
2592         <rdar://problem/47203295>
2593
2594         Reviewed by Ryosuke Niwa.
2595
2596         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2597
2598 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2599
2600         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2601         https://bugs.webkit.org/show_bug.cgi?id=193867
2602
2603         Reviewed by Antti Koivisto.
2604
2605         * LayoutReloaded/misc/LFC-passing-tests.txt:
2606
2607 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2608
2609         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2610         https://bugs.webkit.org/show_bug.cgi?id=193865
2611
2612         Reviewed by Antti Koivisto.
2613
2614         * LayoutReloaded/misc/LFC-passing-tests.txt:
2615
2616 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2617
2618         Need a mechanism to override navigator.userAgent
2619         https://bugs.webkit.org/show_bug.cgi?id=193762
2620         <rdar://problem/47504939>
2621
2622         Reviewed by Brent Fulgham.
2623
2624         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2625
2626         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2627         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2628         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2629
2630 2019-01-25  Dean Jackson  <dino@apple.com>
2631
2632         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2633         https://bugs.webkit.org/show_bug.cgi?id=193831
2634         <rdar://problem/47399263>
2635
2636         Reviewed by Chris Dumez.
2637
2638         Two new tests that exercise cross-origin and same-origin System
2639         Previews.
2640
2641         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2642
2643 2019-01-25  Keith Rollin  <krollin@apple.com>
2644
2645         Update Xcode projects with "Check .xcfilelists" build phase
2646         https://bugs.webkit.org/show_bug.cgi?id=193790
2647         <rdar://problem/47201374>
2648
2649         Reviewed by Alex Christensen.
2650
2651         Support for XCBuild includes specifying inputs and outputs to various
2652         Run Script build phases. These inputs and outputs are specified as
2653         .xcfilelist files. Once created, these .xcfilelist files need to be
2654         kept up-to-date. In order to check that they are up-to-date or not,
2655         add an Xcode build step that invokes an external script that performs
2656         the checking. If the .xcfilelists are found to be out-of-date, update
2657         them, halt the build, and instruct the developer to restart the build
2658         with up-to-date files.
2659
2660         At this time, the checking and regenerating is performed only if the
2661         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2662         who want to use this facility can set this variable and test out the
2663         checking/regenerating. Once it seems like there are no egregious
2664         issues that upset a developer's workflow, we'll unconditionally enable
2665         this facility.
2666
2667         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2668         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2669         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2670         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2671
2672 2019-01-25  Keith Rollin  <krollin@apple.com>
2673
2674         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2675         https://bugs.webkit.org/show_bug.cgi?id=193781
2676         <rdar://problem/47201153>
2677
2678         Reviewed by Alex Christensen.
2679
2680         Part of generating the .xcfilelists used as part of adopting XCBuild
2681         includes running `make DerivedSources.make` from a standalone script.
2682         It’s important for this invocation to have the same environment as
2683         when the actual build invokes `make DerivedSources.make`. If the
2684         environments are different, then the two invocations will provide
2685         different results. In order to get the same environment in the
2686         standalone script, have the script launch xcodebuild targeting the
2687         "Apply Configuration to XCFileLists" build target, which will then
2688         re-invoke our standalone script. The script is now running again, this
2689         time in an environment with all workspace, project, target, xcconfig
2690         and other environment variables established.
2691
2692         The "Apply Configuration to XCFileLists" build target accomplishes
2693         this task via a small embedded shell script that consists only of:
2694
2695             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2696
2697         The process that invokes "Apply Configuration to XCFileLists" first
2698         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2699         evaluated and exports it into the shell environment. When xcodebuild
2700         is invoked, it inherits the value of this variable and can `eval` the
2701         contents of that variable. Our external standalone script can then set
2702         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2703         of command-line parameters needed to restart itself in the appropriate
2704         state.
2705
2706         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2707         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2708
2709 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2710
2711         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2712         https://bugs.webkit.org/show_bug.cgi?id=193802
2713         <rdar://problem/46010580>
2714
2715         Reviewed by Andy Estes.
2716
2717         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2718         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2719         (TEST):
2720
2721 2019-01-25  Daniel Bates  <dabates@apple.com>
2722
2723         [iOS] uiController.keyDown() does not translate Control modified key
2724         https://bugs.webkit.org/show_bug.cgi?id=192898
2725
2726         Reviewed by Wenson Hsieh.
2727
2728         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2729         key translation, as applicable. Among other cases, key translation occurs when performing
2730         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2731         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2732         human pressing down and releasing key(s) using a hardware keyboard.
2733
2734         * WebKitTestRunner/ios/HIDEventGenerator.h:
2735         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2736         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2737
2738         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2739         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2740         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2741         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2742         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2743         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2744         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2745         (-[HIDEventGenerator longPress:completionBlock:]):
2746         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2747         Update code for above renaming.
2748
2749         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2750         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2751
2752         (-[HIDEventGenerator keyDown:]): Added.
2753         (-[HIDEventGenerator keyUp:]): Added.
2754         (-[HIDEventGenerator keyPress:completionBlock:]):
2755         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2756         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2757         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2758         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2759         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2760         (WTR::parseModifier): Deleted.
2761
2762 2019-01-25  Keith Rollin  <krollin@apple.com>
2763
2764         Complete the implementation of generate-xcfilelists
2765         https://bugs.webkit.org/show_bug.cgi?id=193782
2766
2767         Reviewed by Alex Christensen.
2768
2769         A preliminary version of generate-xcfilelists was added in r238008.
2770         This patch updates that script in order to:
2771
2772         - Support checking of .xcfilelists
2773         - Perform better execution of `make DerivedSources.make` by
2774           relaunching generate-xcfilelists under xcodebuild
2775         - Support incremental generation and checking of .xcfilelists
2776         - Support supplementary .xcfilelists files from WebKitAdditions
2777         - Support being wrapped by parallel version of generate-xcfilelists in
2778           Internal that adds support for (re)generating WebKit projects in
2779           that repo.
2780         - Support builds that have been performed in WebKitBuild as well as
2781           ~/Library/Developer/code/DerivedData
2782         - Increase robustness and debugging facilities.
2783
2784         * Scripts/generate-xcfilelists:
2785
2786 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2787
2788         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2789         https://bugs.webkit.org/show_bug.cgi?id=193297
2790         <rdar://problem/47158841>
2791
2792         Unreviewed test case fix.
2793
2794         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2795         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2796
2797         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2798         (TEST):
2799
2800 2019-01-25  Keith Rollin  <krollin@apple.com>
2801
2802         Update existing .xcfilelists
2803         https://bugs.webkit.org/show_bug.cgi?id=193791
2804         <rdar://problem/47201706>
2805
2806         Reviewed by Alex Christensen.
2807
2808         Many .xcfilelist files were added in r238824 in order to support
2809         XCBuild. Update these with recent changes to the set of build files
2810         and with the current generate-xcfilelist script.
2811
2812         * DumpRenderTree/DerivedSources-input.xcfilelist:
2813         * DumpRenderTree/DerivedSources-output.xcfilelist:
2814         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2815         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2816
2817 2019-01-25  Keith Rollin  <krollin@apple.com>
2818
2819         Fix missing dependencies in extract-dependencies-from-makefile
2820         https://bugs.webkit.org/show_bug.cgi?id=193783
2821         <rdar://problem/47201571>
2822
2823         Reviewed by Alex Christensen.
2824
2825         The extract-dependencies-from-makefile script generates .xcfilelists
2826         for XCBuild by invoking a makefile in --debug mode, parsing the
2827         dependency information in the output, and extracting information
2828         regarding targets and dependents. However, the way `make` emits this
2829         dependency information is not rigorous, and so we need to determine
2830         what lines to look for and parse by trial and error. This approach
2831         didn't coriginally atch all the information we needed to collect, so
2832         update the script to look for the additional lines we now know to look
2833         for.
2834
2835         * Scripts/extract-dependencies-from-makefile:
2836         (Parser):
2837         (Parser.addTarget):
2838         (Parser.addPrereq):
2839         (Parser.doParse):
2840
2841 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2842
2843         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2844         https://bugs.webkit.org/show_bug.cgi?id=193297
2845         <rdar://problem/47158841>
2846
2847         Reviewed by Alex Christensen.
2848
2849         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2850             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2851         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2852         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2853         activating the message used to trigger the callback when it is set.
2854
2855 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2856
2857         WKWebView.goBack should reload if there is a safe browsing warning
2858         https://bugs.webkit.org/show_bug.cgi?id=193805
2859         <rdar://problem/46908216>
2860
2861         Reviewed by Geoff Garen.
2862
2863         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2864         (+[Simple3LookupContext sharedLookupContext]):
2865         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2866         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2867         (TEST):
2868
2869 2019-01-25  Chris Dumez  <cdumez@apple.com>
2870
2871         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2872         https://bugs.webkit.org/show_bug.cgi?id=193788
2873         <rdar://problem/47531231>
2874
2875         Reviewed by Alex Christensen.
2876
2877         Add API test coverage.
2878
2879         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2880         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2881
2882 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2883
2884         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2885         https://bugs.webkit.org/show_bug.cgi?id=193771
2886
2887         Unreviewed infrastructure fix.
2888
2889         * Scripts/webkitpy/port/darwin.py:
2890         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2891
2892 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2893
2894         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2895
2896 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2897
2898         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2899
2900         * Scripts/webkitpy/common/config/contributors.json:
2901
2902 2019-01-25  Chris Dumez  <cdumez@apple.com>
2903
2904         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2905         https://bugs.webkit.org/show_bug.cgi?id=193779
2906         <rdar://problem/46170903>
2907
2908         Reviewed by Antti Koivisto.
2909
2910         Add API test that quickly navigates forward to a previous process without waiting for it to
2911         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2912         the process' previous page when reconnecting the it for the forward navigation.
2913
2914         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2915
2916 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2917
2918         Need a way for JavaScript (or bundle) code to participate in undo
2919         https://bugs.webkit.org/show_bug.cgi?id=190009
2920         <rdar://problem/44807048>
2921
2922         Reviewed by Ryosuke Niwa.
2923
2924         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2925         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2926
2927         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2928         (WTR::UIScriptController::lastUndoLabel const):
2929         (WTR::UIScriptController::firstRedoLabel const):
2930         (WTR::UIScriptController::platformUndoManager const):
2931         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2932         (WTR::UIScriptController::lastUndoLabel const):
2933         (WTR::UIScriptController::firstRedoLabel const):
2934         (WTR::UIScriptController::platformUndoManager const):
2935         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2936         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2937         (WTR::UIScriptController::lastUndoLabel const):
2938         (WTR::UIScriptController::firstRedoLabel const):
2939         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2940         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2941         (WTR::UIScriptController::lastUndoLabel const):
2942         (WTR::UIScriptController::firstRedoLabel const):
2943         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2944         (WTR::UIScriptController::platformUndoManager const):
2945         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2946         (WTR::UIScriptController::platformUndoManager const):
2947
2948 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2949
2950         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2951         https://bugs.webkit.org/show_bug.cgi?id=193824
2952
2953         Reviewed by Antti Koivisto.
2954
2955         * LayoutReloaded/misc/LFC-passing-tests.txt:
2956
2957 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2958
2959         Update macOS JSC bot configurations
2960         https://bugs.webkit.org/show_bug.cgi?id=193739
2961
2962         Reviewed by Alexey Proskuryakov.
2963
2964         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2966         (BubbleQueueServer): Move JSC EWS to Mojave section.
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2968         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2969         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2970
2971 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2972
2973         [Win][WebKitTestRunner] Implement EventSenderProxy
2974         https://bugs.webkit.org/show_bug.cgi?id=193755
2975
2976         Reviewed by Don Olmstead.
2977
2978         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2979         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2980         (WTR::EventSenderProxy::dispatchMessage):
2981         (WTR::EventSenderProxy::EventSenderProxy):
2982         (WTR::EventSenderProxy::mouseDown):
2983         (WTR::EventSenderProxy::mouseUp):
2984         (WTR::EventSenderProxy::mouseMoveTo):
2985         (WTR::EventSenderProxy::mouseScrollBy):
2986         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2987
2988 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2989
2990         Unreviewed fix for API test failure after r240437.
2991
2992         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2993
2994         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2995
2996 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2997
2998         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2999         https://bugs.webkit.org/show_bug.cgi?id=193787
3000         <rdar://problem/47497634>
3001
3002         Reviewed by Alexey Proskuryakov.
3003
3004         * Scripts/webkitdirs.pm:
3005         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3006
3007 2019-01-24  Truitt Savell  <tsavell@apple.com>
3008
3009         Unreviewed, rolling out r240446.
3010
3011         Casued 5 API failures
3012
3013         Reverted changeset:
3014
3015         "Activate the WebResourceLoadStatisticsStore in the
3016         NetworkProcess and deactivate it in the UIProcess."
3017         https://bugs.webkit.org/show_bug.cgi?id=193297
3018         https://trac.webkit.org/changeset/240446
3019
3020 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3021
3022         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3023         https://bugs.webkit.org/show_bug.cgi?id=193741
3024         <rdar://problem/47135030>
3025
3026         Reviewed by Antti Koivisto and Simon Fraser.
3027
3028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3029         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3030         (TestWebKitAPI::TEST):
3031
3032 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3033
3034         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3035         https://bugs.webkit.org/show_bug.cgi?id=193297
3036         <rdar://problem/47158841>
3037
3038         Reviewed by Alex Christensen.
3039
3040         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3041         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3042         activating the message used to trigger the callback when it is set.
3043
3044 2019-01-24  John Wilander  <wilander@apple.com>
3045
3046         Add Ad Click Attribution as an internal/experimental feature
3047         https://bugs.webkit.org/show_bug.cgi?id=193685
3048         <rdar://problem/47450399>
3049
3050         Reviewed by Brent Fulgham.
3051
3052         Added test option adClickAttributionEnabled.
3053
3054         * DumpRenderTree/TestOptions.cpp:
3055         (TestOptions::TestOptions):
3056         * DumpRenderTree/TestOptions.h:
3057         * DumpRenderTree/mac/DumpRenderTree.mm:
3058         (setWebPreferencesForTestOptions):
3059
3060 2019-01-24  Antti Koivisto  <antti@apple.com>
3061
3062         [PSON] Flash on back navigation on Mac
3063         https://bugs.webkit.org/show_bug.cgi?id=193716
3064         <rdar://problem/47148458>
3065
3066         Reviewed by Chris Dumez.
3067
3068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3069
3070         Closing of the previous page is delayed so waiting for didFinishNavigation is
3071         not sufficient to guarantee we have received all the messages. Wait for them.
3072
3073 2019-01-24  Chris Dumez  <cdumez@apple.com>
3074
3075         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3076         https://bugs.webkit.org/show_bug.cgi?id=193761
3077         <rdar://problem/47456405>
3078
3079         Reviewed by Alex Christensen.
3080
3081         Add API test coverage.
3082
3083         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3084
3085 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3086
3087         webkitpy: Missing PID in crashlog name should not be fatal
3088         https://bugs.webkit.org/show_bug.cgi?id=193771
3089
3090         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3091         of raising an exception.
3092
3093         Reviewed by Lucas Forschler.
3094
3095         * Scripts/webkitpy/port/darwin.py:
3096         (DarwinPort._merge_crash_logs):
3097
3098 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3099
3100         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3101         https://bugs.webkit.org/show_bug.cgi?id=193746
3102
3103         Reviewed by Youenn Fablet.
3104
3105         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3106         so we'd best just not call it.
3107
3108         * Scripts/webkitpy/w3c/test_exporter.py:
3109         (WebPlatformTestExporter.create_branch_with_patch):
3110
3111 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3112
3113         Move FileSystem to WTF
3114         https://bugs.webkit.org/show_bug.cgi?id=193602
3115
3116         Reviewed by Yusuke Suzuki.
3117
3118         * DumpRenderTree/win/DumpRenderTree.cpp:
3119         * TestWebKitAPI/CMakeLists.txt:
3120         * TestWebKitAPI/PlatformGTK.cmake:
3121         * TestWebKitAPI/PlatformJSCOnly.cmake:
3122         * TestWebKitAPI/PlatformPlayStation.cmake:
3123         * TestWebKitAPI/PlatformWPE.cmake:
3124         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3125         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3126         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3127         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3128         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3129         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3130         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3131         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3132         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3133         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3134
3135 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3136
3137         [WPE] Remove hard dependency on subprocess32 for the API tests
3138
3139         Rubber-stamped by Carlos Garcia Campos.
3140
3141         * glib/api_test_runner.py:
3142         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3143         its presence only when running WPEQt tests.
3144
3145 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3146
3147         [GLIB] Expose JavaScriptCore options in GLib public API
3148         https://bugs.webkit.org/show_bug.cgi?id=188742
3149
3150         Reviewed by Michael Catanzaro.
3151
3152         Add a test for the new API.
3153
3154         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3155         (testsJSCOptions):
3156         (main):
3157
3158 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3159
3160         [GTK][WPE] Support JPEG 2000 images
3161         https://bugs.webkit.org/show_bug.cgi?id=186272
3162
3163         Reviewed by Žan Doberšek.
3164
3165         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3166
3167         * gtk/jhbuild.modules:
3168         * wpe/jhbuild.modules:
3169
3170 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3171
3172         check-webkit-style should warn when using soft-linking macros in a header
3173         <https://webkit.org/b/193750>
3174
3175         Reviewed by Darin Adler.
3176
3177         * Scripts/webkitpy/style/checkers/cpp.py:
3178         (check_language): Add softlink/header check by refactoring the
3179         softlink/framework check.
3180         (CppChecker): Enable softlink/header check by default.
3181         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3182         (CppStyleTest.test_softlink_framework): Rename from
3183         CppStyleTest.test_softlink() and change test framework name in
3184         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3185         files. Set file_name for macros that only appear in headers.
3186         (CppStyleTest.test_softlink_header): Add tests for using
3187         soft-link macros in headers.
3188
3189 2019-01-23  Chris Dumez  <cdumez@apple.com>
3190
3191         Deprecate API to limit the maximum number of WebProcesses
3192         https://bugs.webkit.org/show_bug.cgi?id=193725
3193         <rdar://problem/47464879>
3194
3195         Reviewed by Geoff Garen.
3196
3197         Update existing API tests to stop using deprecated API.
3198
3199         * MiniBrowser/mac/AppDelegate.m:
3200         (defaultConfiguration):
3201         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3202         (TestWebKitAPI::TEST):
3203         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3204         (TestWebKitAPI::TEST):
3205         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3206         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3207         (TEST):
3208         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3209         (TEST):
3210
3211 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3212
3213         [ews-app] Rename ews model buildermappings to buildermapping
3214         https://bugs.webkit.org/show_bug.cgi?id=193729
3215
3216         Reviewed by Lucas Forschler.
3217
3218         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3219         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3220         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3221
3222 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3223
3224         [ews-app] Rename ews model steps to step
3225         https://bugs.webkit.org/show_bug.cgi?id=193697
3226
3227         Reviewed by Lucas Forschler.
3228
3229         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3230         (Step): Renamed Steps to Step.
3231
3232 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3233
3234         Clean up IndexedDB files between tests
3235         https://bugs.webkit.org/show_bug.cgi?id=192796
3236         <rdar://problem/46824999>
3237
3238         Reviewed by Geoffrey Garen.
3239
3240         * DumpRenderTree/mac/DumpRenderTree.mm:
3241         (runTest):
3242         * WebKitTestRunner/TestController.cpp:
3243         (WTR::TestController::resetStateToConsistentValues):
3244         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3245         (WTR::RemoveAllIndexedDatabasesCallback):
3246         (WTR::TestController::ClearIndexedDatabases):
3247         * WebKitTestRunner/TestController.h:
3248         * WebKitTestRunner/TestInvocation.cpp:
3249         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3250
3251 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3252
3253         [ews-app] Rename ews model Builds to Build
3254         https://bugs.webkit.org/show_bug.cgi?id=193695
3255
3256         Reviewed by Lucas Forschler.
3257
3258         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3259         (Build): Renamed Builds to Build.
3260
3261 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3262
3263         webkitpy: Wait longer when launching WebKitTestRunner
3264         https://bugs.webkit.org/show_bug.cgi?id=193734
3265
3266         Reviewed by Aakash Jain.
3267
3268         * Scripts/webkitpy/port/simulator_process.py:
3269         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3270
3271 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3272
3273         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3274         https://bugs.webkit.org/show_bug.cgi?id=193182
3275         <rdar://problem/47452154>
3276
3277         Reviewed by Tim Horton.
3278
3279         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3280         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3281         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3282
3283         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3284         preventing later tests from recognizing gestures.
3285
3286         * WebKitTestRunner/ios/TestControllerIOS.mm:
3287         (WTR::TestController::platformResetStateToConsistentValues):
3288
3289         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3290
3291 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3292
3293         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3294         https://bugs.webkit.org/show_bug.cgi?id=193722
3295         <rdar://problem/47481475>
3296
3297         Reviewed by Lucas Forschler.
3298
3299         iPhone and iPad ports should both use the iOS config.
3300
3301         * Scripts/webkitpy/port/ios_simulator.py:
3302         (IPhoneSimulatorPort.__init__):
3303         (IPadSimulatorPort.__init__):
3304
3305 2019-01-23  Rob Buis  <rbuis@igalia.com>
3306
3307         Update MIME type parser
3308         https://bugs.webkit.org/show_bug.cgi?id=180526
3309
3310         Reviewed by Frédéric Wang.
3311
3312         Add unit tests for both parse modes of ParsedContentType.
3313
3314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3315         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3316         (TestWebKitAPI::TEST):
3317
3318 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3319
3320         [ews-app] fetch loop should not stop on network issues
3321         https://bugs.webkit.org/show_bug.cgi?id=193666
3322
3323         Reviewed by Lucas Forschler.
3324
3325         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3326         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3327
3328 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3329
3330         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3331         https://bugs.webkit.org/show_bug.cgi?id=189165
3332         <rdar://problem/47433765>
3333
3334         Reviewed by Tim Horton.
3335
3336         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3337         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3338         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3339         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3340         would make its way to the UI process by the time the layer tree commit is finished.
3341
3342         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3343         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3344         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3345         will fail because it asks for -_autofillContext too early.
3346
3347         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3348         is handled in the UI process.
3349
3350         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3351
3352         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3353         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3354         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3355         input session.
3356
3357         (-[AutofillTestView textInputHasAutofillContext]):
3358
3359         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3360
3361         * TestWebKitAPI/cocoa/TestWKWebView.h:
3362         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3363         (nextInputSessionChangeCount):
3364
3365         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3366         This includes changing the focused element from one to another.
3367
3368         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3369         (-[TestWKWebView didStartFormControlInteraction]):
3370         (-[TestWKWebView didEndFormControlInteraction]):
3371         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3372
3373         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3374         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3375         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3376         that doesn't require an input session to one that doesn't.
3377
3378 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3379
3380         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3381         <https://webkit.org/b/193676>
3382
3383         Reviewed by Alexey Proskuryakov.
3384
3385         * Scripts/webkitpy/style/checkers/cpp.py:
3386         (check_member_initialization_list):
3387         - Don't report missing whitespace around colon if the colon at
3388           the start of the line is formatted correctly.
3389         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3390         (WebKitStyleTest.test_member_initialization_list):
3391         - Add a test for a missing permutation of existing tests.
3392         - Add a test this false-positive.
3393         - Add blank lines between subtests to make them easier to read.
3394
3395 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3396
3397         [build.webkit.org] Unit-test failure after r237113
3398         https://bugs.webkit.org/show_bug.cgi?id=193669
3399
3400         Reviewed by Michael Catanzaro.
3401
3402         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3403         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3404         multiple or zero flags.
3405
3406 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3407
3408         Cache bytecode to disk
3409         https://bugs.webkit.org/show_bug.cgi?id=192782
3410         <rdar://problem/46084932>
3411
3412         Reviewed by Keith Miller.
3413
3414         Add test helper to execute bytecode-cache tests: it executes each test
3415         twice, the first with JSC_diskCachePath set to a temporary directory
3416         and second with JSC_forceDiskCache=true (in addition to the cache path)
3417         to guarantee that only the disk cache is being used and no new
3418         UnlinkedCodeBlocks are being created.
3419
3420         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3421         * Scripts/run-jsc-stress-tests:
3422
3423 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3424
3425         [css-logical] Implement flow-relative margin, padding and border shorthands
3426         https://bugs.webkit.org/show_bug.cgi?id=188697
3427
3428         Reviewed by Simon Fraser and Antti Koivisto.
3429
3430         * DumpRenderTree/TestOptions.cpp:
3431         (TestOptions::TestOptions):
3432         * DumpRenderTree/TestOptions.h:
3433         * DumpRenderTree/mac/DumpRenderTree.mm:
3434         (setWebPreferencesForTestOptions):
3435         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3436
3437         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3438         (JSONCSSPropertiesChecker.check_codegen_properties):
3439         Allow CSS property definitions to have a 'runtime-flag' parameter which
3440         disables the property when the specified runtime flag is disabled.
3441
3442 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3443
3444         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3445         https://bugs.webkit.org/show_bug.cgi?id=193643
3446
3447         Reviewed by Michael Catanzaro.
3448
3449         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3450         * wpe/jhbuild.modules: Ditto.
3451
3452 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3453
3454         [LFC][Floats] Take float top position into account when computing containing block height.
3455         https://bugs.webkit.org/show_bug.cgi?id=193655
3456
3457         Reviewed by Antti Koivisto.
3458
3459         * LayoutReloaded/misc/LFC-passing-tests.txt:
3460
3461 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3462
3463         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3464         <https://webkit.org/b/193645>
3465         <rdar://problem/47421574>
3466
3467         Reviewed by Alex Christensen.
3468
3469         - Now checks for local soft-linking of all frameworks that have
3470           their own *SoftLinking.{cpp,h,mm} files.
3471         - Changes softlink/uikit warning to softlink/framework.
3472
3473         * Scripts/webkitpy/style/checkers/cpp.py:
3474         (check_language):
3475         (CppChecker):
3476         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3477         (CppStyleTest):
3478
3479 2019-01-20  Saam Barati  <sbarati@apple.com>
3480
3481         Rollout r240210: It broke tests on iOS
3482         https://bugs.webkit.org/show_bug.cgi?id=193640
3483
3484         Unreviewed.
3485
3486         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3487         * Scripts/run-jsc-stress-tests:
3488
3489 2019-01-20  chris fleizach  <cfleizach@apple.com>
3490
3491         AX: Support returning relative frames for accessibility
3492         https://bugs.webkit.org/show_bug.cgi?id=193414
3493         <rdar://problem/47268501>
3494
3495         Reviewed by Zalan Bujtas.
3496
3497         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3498         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3499         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3500         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3501         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3502         (WTR::attributesOfElement):
3503         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3504
3505 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3506
3507         Unreviewed, add my new email address
3508
3509         * Scripts/webkitpy/common/config/contributors.json:
3510
3511 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3512
3513         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3514         https://bugs.webkit.org/show_bug.cgi?id=193617
3515
3516         Reviewed by Antti Koivisto.
3517
3518         * LayoutReloaded/misc/LFC-passing-tests.txt:
3519
3520 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3521
3522         Unreviewed, rolling out r240209.
3523
3524         Broke GTK/WPE injected bundle
3525
3526         Reverted changeset:
3527
3528         "AX: Support returning relative frames for accessibility"
3529         https://bugs.webkit.org/show_bug.cgi?id=193414
3530         https://trac.webkit.org/changeset/240209
3531
3532 2019-01-12  Dan Bernstein  <mitz@apple.com>
3533
3534         [Cocoa] Avoid importing directly from subumbrella frameworks
3535         https://bugs.webkit.org/show_bug.cgi?id=186016
3536         <rdar://problem/40591038>
3537
3538         Reviewed by Sam Weinig.
3539
3540         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3541           LaunchServices header.
3542         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3543           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3544         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3545           when using SDKs earlier than 10.13.
3546         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3547           and OTHER_CPLUSPLUSFLAGS.
3548         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3549           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3550         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3551           LaunchServices header.
3552
3553 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3554
3555         Cache bytecode to disk
3556         https://bugs.webkit.org/show_bug.cgi?id=192782
3557         <rdar://problem/46084932>
3558
3559         Reviewed by Keith Miller.
3560
3561         Add test helper to execute bytecode-cache tests: it executes each test
3562         twice, the first with JSC_diskCachePath set to a temporary directory
3563         and second with JSC_forceDiskCache=true (in addition to the cache path)
3564         to guarantee that only the disk cache is being used and no new
3565         UnlinkedCodeBlocks are being created.
3566
3567         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3568         * Scripts/run-jsc-stress-tests:
3569
3570 2019-01-20  chris fleizach  <cfleizach@apple.com>
3571
3572         AX: Support returning relative frames for accessibility
3573         https://bugs.webkit.org/show_bug.cgi?id=193414
3574         <rdar://problem/47268501>
3575
3576         Reviewed by Zalan Bujtas.
3577
3578         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3579         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3580         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3581         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3582         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3583         (WTR::attributesOfElement):
3584         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3585
3586 2019-01-20  Antoine Quint  <graouts@apple.com>
3587
3588         Add a POINTER_EVENTS feature flag
3589         https://bugs.webkit.org/show_bug.cgi?id=193577
3590         <rdar://problem/47408511>
3591
3592         Unreviewed. Also enable Pointer Events for iosmac.
3593
3594         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3595
3596 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3597
3598         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3599         https://bugs.webkit.org/show_bug.cgi?id=193613
3600
3601         Reviewed by Antti Koivisto.
3602
3603         * LayoutReloaded/misc/LFC-passing-tests.txt:
3604
3605 2019-01-19  Antoine Quint  <graouts@apple.com>
3606
3607         Add a POINTER_EVENTS feature flag
3608         https://bugs.webkit.org/show_bug.cgi?id=193577
3609
3610         Reviewed by Dean Jackson.
3611
3612         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3613
3614 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3615
3616         Disable the run-jsc-stress-test remote host key check [second round].
3617         https://bugs.webkit.org/show_bug.cgi?id=192988
3618
3619         Reviewed by Dewei Zhu.
3620
3621         * Scripts/run-jsc-stress-tests:
3622
3623 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3624
3625         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3626         https://bugs.webkit.org/show_bug.cgi?id=193597
3627
3628         Reviewed by Lucas Forschler.
3629
3630         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3631
3632 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3633
3634         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3635         https://bugs.webkit.org/show_bug.cgi?id=193595
3636
3637         Reviewed by Lucas Forschler.
3638
3639         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3640         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3641         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3642
3643 2019-01-18  Chris Dumez  <cdumez@apple.com>
3644
3645         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3646         https://bugs.webkit.org/show_bug.cgi?id=193588
3647         <rdar://problem/47131566>
3648
3649         Reviewed by Alex Christensen.
3650
3651         Add layout test coverage.
3652
3653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3654
3655 2019-01-18  Jer Noble  <jer.noble@apple.com>
3656
3657         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3658         https://bugs.webkit.org/show_bug.cgi?id=189553
3659
3660         Reviewed by Tim Horton.
3661
3662         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3663
3664         * ContentExtensionTester/Configurations/Base.xcconfig:
3665         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3666         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3667         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3668         * ImageDiff/cg/Configurations/Base.xcconfig:
3669         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3670         * MiniBrowser/Configurations/Base.xcconfig:
3671         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3672         * MobileMiniBrowser/Configurations/Base.xcconfig:
3673         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3674         * Scripts/webkitpy/style/checker.py:
3675         (_all_categories):
3676         (FileType):
3677         (CheckerDispatcher._file_type):
3678         (CheckerDispatcher._create_checker):
3679         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3680         (SDKVariantChecker):
3681         (SDKVariantChecker.__init__):
3682         (SDKVariantChecker.check):
3683         * TestWebKitAPI/Configurations/Base.xcconfig:
3684         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3685         * WebEditingTester/Configurations/Base.xcconfig:
3686         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3687         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3688         * WebKitTestRunner/Configurations/Base.xcconfig:
3689         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3690         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3691         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3692
3693 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3694
3695         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3696         <https://webkit.org/b/193568>
3697         <rdar://problem/47381130>
3698
3699         Reviewed by Alex Christensen.
3700
3701         Make sure no one re-introduces UIKit soft-linking by adding a
3702         style rule.
3703
3704         * Scripts/webkitpy/style/checkers/cpp.py:
3705         (check_language): Add softlink/uikit check.
3706         (CppChecker): Enable softlink/uikit check.
3707         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3708         (CppStyleTest): Add test for softlink/uikit.
3709
3710 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3711
3712         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3713         https://bugs.webkit.org/show_bug.cgi?id=193584
3714
3715         Change "-dev" to "-devel".
3716
3717         Reviewed by Michael Catanzaro.
3718
3719         * gtk/install-dependencies:
3720
3721 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3722
3723         webkitpy: Add iPhone and iPad ports
3724         https://bugs.webkit.org/show_bug.cgi?id=193537
3725         <rdar://problem/47353390>
3726
3727         Reviewed by Lucas Forschler.
3728
3729         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3730         ports. Note that this separation is optional, the --ios-simulator command remains.
3731
3732         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3733         (RunTest.test_device_type_test_division): Drive-by fix.
3734         (RunTest.test_device_type_specific_listing): Ditto.
3735         (RunTest.test_ipad_test_division):
3736         (RunTest):
3737         (RunTest.test_ipad_listing):
3738         * Scripts/webkitpy/port/factory.py:
3739         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3740         (PortFactory):
3741         * Scripts/webkitpy/port/ios_simulator.py:
3742         (IPhoneSimulatorPort):
3743         (IPadSimulatorPort):
3744
3745 2019-01-18  Chris Dumez  <cdumez@apple.com>
3746
3747         Regression(PSON) Scroll position is not always restored properly when navigating back
3748         https://bugs.webkit.org/show_bug.cgi?id=193578
3749         <rdar://problem/47386331>
3750
3751         Reviewed by Tim Horton.
3752
3753         Add API test coverage.
3754
3755         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3756
3757 2019-01-18  Youenn Fablet  <youenn@apple.com>
3758
3759         Add a new SPI to request for cache storage quota increase
3760         https://bugs.webkit.org/show_bug.cgi?id=193323
3761
3762         Reviewed by Alex Christensen.
3763
3764         Implement WebsiteDataStore quota delegate to handle quota requests.
3765         By default, do not update quota.
3766         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3767
3768         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3769         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3770         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3771         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3772         * WebKitTestRunner/TestController.cpp:
3773         (WTR::TestController::allowCacheStorageQuotaIncrease):
3774         * WebKitTestRunner/TestController.h:
3775         * WebKitTestRunner/TestInvocation.cpp:
3776         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3777         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3778         (-[CacheStorageQuotaManager init]):
3779         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3780         (WTR::initializeWebViewConfiguration):
3781         (WTR::TestController::cocoaResetStateToConsistentValues):
3782         (WTR::TestController::allowCacheStorageQuotaIncrease):
3783
3784 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3785
3786         [ews-build] Pass owner to the triggered builds
3787         https://bugs.webkit.org/show_bug.cgi?id=193574
3788
3789         Reviewed by Lucas Forschler.
3790
3791         * BuildSlaveSupport/ews-build/factories.py:
3792         (BuildFactory.propertiesToPassToTriggers):
3793
3794 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3795
3796         [ews-app] Send patch author as a build property
3797         https://bugs.webkit.org/show_bug.cgi?id=193560
3798
3799         Reviewed by Lucas Forschler.
3800
3801         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3802         (BugzillaPatchFetcher.fetch):
3803
3804 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3805
3806         webkitpy: Implement device type specific expected results (Follow-up fix)
3807         https://bugs.webkit.org/show_bug.cgi?id=192162
3808         <rdar://problem/46345449>
3809
3810         Unreviewed infrastructure fix.
3811
3812         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3813         (Manager.run): Don't boot a device if no tests are available to run on it.
3814
3815 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3816
3817         webkitpy: Implement device type specific expected results (Follow-up fix)
3818         https://bugs.webkit.org/show_bug.cgi?id=192162
3819         <rdar://problem/46345449>
3820
3821         Unreviewed infrastructure fix.
3822
3823         * Scripts/webkitpy/api_tests/manager.py:
3824         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3825
3826 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3827
3828         webkitpy: Implement device type specific expected results (Part 2)
3829         https://bugs.webkit.org/show_bug.cgi?id=192162
3830         <rdar://problem/46345449>
3831
3832         Rubber-stamped by Aakash Jain.
3833
3834         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3835         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3836         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3837
3838         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3839         (LayoutTestFinder.find_tests): Pass device_type through.
3840         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3841         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3842         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3843         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3844         (Manager._collect_tests): Pass device type to test finder.
3845         (Manager._needs_web_platform_test):
3846         (Manager._prepare_lists): Index _expectations by device type.
3847         (Manager._test_input_for_file):
3848         (Manager._test_is_slow): Ditto.
3849         (Manager._test_should_dump_jsconsolelog_in_stderr):
3850         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3851         (Manager._get_test_inputs):
3852         (Manager._update_worker_count):
3853         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3854         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3855         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3856         the one which runs the test.
3857         (Manager._run_test_subset):
3858         (Manager._run_tests): Index _expectations by current_device_type.
3859         (Manager._print_expectation_line_for_test): Ditto.
3860         (Manager._print_expectations_for_subset): Ditto.
3861         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3862         Unlike run, this function will behave the same regardless of what devices are available.
3863         (Manager._custom_device_for_test): Deleted.
3864         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3865         (ManagerTest.test_uses_custom_device): Deleted.
3866         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3867         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3868         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3869         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3870         all of the expectations.
3871         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3872         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3873         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3874         (TestExpectations.__init__): Allow device_type to be passed through.
3875         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3876         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3877         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3878         (summarize_results):
3879         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3880         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3881         a test ran with, one must check all expectations to find the first non-skip expectation.
3882         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3883         (RunTest.test_device_type_test_division):
3884         (RunTest):
3885         (RunTest.test_device_type_specific_listing):
3886         * Scripts/webkitpy/port/base.py:
3887         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3888         (Port.supported_device_types): The result of this function will change based on what devices are available.
3889         * Scripts/webkitpy/port/device_port.py:
3890         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3891         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3892         can be used.
3893         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3894         any, or the DEFAULT_DEVICE_TYPES of the port.
3895         * Scripts/webkitpy/port/ios.py:
3896         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3897         * Scripts/webkitpy/port/ios_simulator.py:
3898         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3899         * Scripts/webkitpy/port/watch.py:
3900         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3901         * Scripts/webkitpy/port/watch_simulator.py:
3902         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3903         * Scripts/webkitpy/xcode/device_type.py:
3904         (DeviceType):
3905         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3906
3907 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3908
3909         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3910         https://bugs.webkit.org/show_bug.cgi?id=193575
3911
3912         Reviewed by Michael Catanzaro.
3913
3914         Allow the script to run without explicit port argument because
3915         it's specific to the WPE port anyway.
3916
3917         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3918         and simplify the rest of the code accordingly.
3919
3920 2019-01-18  Charlie Turner  <cturner@igalia.com>
3921
3922         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3923         https://bugs.webkit.org/show_bug.cgi?id=192229
3924
3925         Reviewed by Xabier Rodriguez-Calvar.
3926
3927         * MiniBrowser/wpe/main.cpp:
3928         (main): Enable encrypted-media by default.
3929
3930 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3931
3932         [Flatpak] Missing KeyboardInterrupt exception handler
3933         https://bugs.webkit.org/show_bug.cgi?id=193570
3934
3935         Reviewed by Michael Catanzaro.
3936
3937         * flatpak/flatpakutils.py:
3938         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3939
3940 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3941
3942         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3943         https://bugs.webkit.org/show_bug.cgi?id=193564
3944
3945         Reviewed by Antti Koivisto.
3946
3947         * LayoutReloaded/misc/LFC-passing-tests.txt:
3948
3949 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3950
3951         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3952         https://bugs.webkit.org/show_bug.cgi?id=193562
3953
3954         Reviewed by Antti Koivisto.
3955
3956         * LayoutReloaded/misc/LFC-passing-tests.txt:
3957
3958 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3959
3960         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3961         https://bugs.webkit.org/show_bug.cgi?id=193555
3962
3963         Reviewed by Antti Koivisto.
3964
3965         * LayoutReloaded/misc/LFC-passing-tests.txt:
3966
3967 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3968
3969         [WPE] Add Qt extension
3970         https://bugs.webkit.org/show_bug.cgi?id=191464
3971
3972         Reviewed by Carlos Garcia Campos.
3973
3974         MiniBrowser and API tests for the WPE Qt API. To run the
3975         MiniBrowser a new script is introduced. Example invocation:
3976
3977         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3978
3979         Also note-worthy is the introduction of the python2-subprocess32
3980         dependency to run the GLib API tests.
3981
3982         * MiniBrowser/wpe/CMakeLists.txt:
3983         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3984         * MiniBrowser/wpe/qt/main.cpp: Added.
3985         (main):
3986         * MiniBrowser/wpe/qt/main.qml: Added.
3987         * MiniBrowser/wpe/qt/qml.qrc: Added.
3988         * Scripts/run-gtk-tests:
3989         (GtkTestRunner.is_google_test):
3990         (GtkTestRunner):
3991         (GtkTestRunner.is_qt_test):
3992         * Scripts/run-qt-wpe-minibrowser: Added.
3993         * Scripts/run-wpe-tests:
3994         (WPETestRunner):
3995         (WPETestRunner.is_google_test):
3996         (WPETestRunner.is_qt_test):
3997         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3998         (TestLoad::main):
3999         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
4000         (TestLoadHtml::main):
4001         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
4002         (TestLoadRequest::main):
4003         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
4004         (TestRunJavaScript::main):
4005         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
4006         (waitForSignal):
4007         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
4008         (LoadSpy::LoadSpy):
4009         (LoadSpy::~LoadSpy):
4010         (LoadSpy::onLoadingChanged):
4011         (LoadStartedCatcher::LoadStartedCatcher):
4012         (LoadStartedCatcher::~LoadStartedCatcher):
4013         (LoadStartedCatcher::onLoadingChanged):
4014         (waitForLoadSucceeded):
4015         (waitForLoadFailed):
4016         * TestWebKitAPI/glib/CMakeLists.txt:
4017         * flatpak/flatpakutils.py:
4018         (WebkitFlatpak.load_from_args):
4019         (WebkitFlatpak.__init__):
4020         (WebkitFlatpak.clean_args):
4021         (WebkitFlatpak.run_in_sandbox):
4022         * flatpak/org.webkit.CommonModules.yaml:
4023         * flatpak/org.webkit.WPE.yaml:
4024         * flatpak/org.webkit.WPEModules.yaml:
4025         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
4026         * flatpak/org.webkit.WebKit.yaml:
4027         * glib/api_test_runner.py:
4028         (TestRunner._run_test_qt):
4029         (TestRunner.is_qt_test):
4030         (TestRunner._run_test):
4031
4032 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4033
4034         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
4035         https://bugs.webkit.org/show_bug.cgi?id=193494
4036         <rdar://problem/46859627>
4037
4038         Reviewed by Simon Fraser and Tim Horton.
4039
4040         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
4041         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
4042
4043         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4044         (WTR::UIScriptController::contentOffsetX const):
4045         (WTR::UIScriptController::contentOffsetY const):
4046         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4047         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4048         (WTR::UIScriptController::contentOffsetX const):
4049         (WTR::UIScriptController::contentOffsetY const):
4050         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4051
4052         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
4053
4054         * WebKitTestRunner/TestController.cpp:
4055         (WTR::updateTestOptionsFromTestHeader):
4056         * WebKitTestRunner/TestOptions.h:
4057         (WTR::TestOptions::hasSameInitializationOptions const):
4058         * WebKitTestRunner/ios/TestControllerIOS.mm:
4059         (WTR::TestController::platformResetStateToConsistentValues):
4060         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4061         (WTR::UIScriptController::contentOffsetX const):
4062         (WTR::UIScriptController::contentOffsetY const):
4063
4064 2019-01-17  Truitt Savell  <tsavell@apple.com>
4065
4066         Unreviewed, rolling out r240124.
4067
4068         This commit broke an internal build.
4069
4070         Reverted changeset:
4071
4072         "SDK_VARIANT build destinations should be separate from non-
4073         SDK_VARIANT builds"
4074         https://bugs.webkit.org/show_bug.cgi?id=189553
4075         https://trac.webkit.org/changeset/240124
4076
4077 2019-01-17  Alex Christensen  <achristensen@webkit.org>
4078
4079         Fix string concatenation API test after r239920
4080         https://bugs.webkit.org/show_bug.cgi?id=193551
4081         <rdar://problem/47359304>
4082
4083         Reviewed by Youenn Fablet.
4084
4085         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
4086         (TestWebKitAPI::TEST):
4087         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
4088         in WebKit's build configuration like it apparently is on Linux.
4089
4090 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4091
4092         [ews-build] validate-patch should handle the case when bug_id is None
4093         https://bugs.webkit.org/show_bug.cgi?id=193547
4094
4095         Reviewed by Lucas Forschler.
4096
4097         * BuildSlaveSupport/ews-build/steps.py:
4098         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
4099         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
4100
4101 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4102
4103         [ews-build] Add patch author information in build
4104         https://bugs.webkit.org/show_bug.cgi?id=193465
4105
4106         Reviewed by Lucas Forschler.
4107
4108         * BuildSlaveSupport/ews-build/steps.py:
4109         (ValidatePatch._is_patch_obsolete):
4110
4111 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4112
4113         [ews-build] Pass bug_id to the triggered builds
4114         https://bugs.webkit.org/show_bug.cgi?id=193548
4115
4116         Reviewed by Lucas Forschler.
4117
4118         * BuildSlaveSupport/ews-build/factories.py:
4119         (BuildFactory.propertiesToPassToTriggers):
4120
4121 2019-01-17  Jer Noble  <jer.noble@apple.com>
4122
4123         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4124         https://bugs.webkit.org/show_bug.cgi?id=189553
4125
4126         Reviewed by Tim Horton.
4127
4128         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4129
4130         * ContentExtensionTester/Configurations/Base.xcconfig:
4131         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4132         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4133         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4134         * ImageDiff/cg/Configurations/Base.xcconfig:
4135         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4136         * MiniBrowser/Configurations/Base.xcconfig:
4137         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4138         * MobileMiniBrowser/Configurations/Base.xcconfig:
4139         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4140         * Scripts/webkitpy/style/checker.py:
4141         (_all_categories):
4142         (FileType):
4143         (CheckerDispatcher._file_type):
4144         (CheckerDispatcher._create_checker):
4145         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4146         (SDKVariantChecker):
4147         (SDKVariantChecker.__init__):
4148         (SDKVariantChecker.check):
4149         * TestWebKitAPI/Configurations/Base.xcconfig:
4150         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4151         * WebEditingTester/Configurations/Base.xcconfig:
4152         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4153         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4154         * WebKitTestRunner/Configurations/Base.xcconfig:
4155         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4156         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4157         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4158
4159 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4160
4161         [LFC][BFC] An element with transform is a containing block for positioned descendants.
4162         https://bugs.webkit.org/show_bug.cgi?id=193534
4163
4164         Reviewed by Antti Koivisto.
4165
4166         * LayoutReloaded/misc/LFC-passing-tests.txt:
4167
4168 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4169
4170         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
4171         https://bugs.webkit.org/show_bug.cgi?id=193528
4172
4173         Reviewed by Antti Koivisto.
4174
4175         * LayoutReloaded/misc/LFC-passing-tests.txt:
4176
4177 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4178
4179         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
4180         https://bugs.webkit.org/show_bug.cgi?id=193520
4181
4182         Reviewed by Antti Koivisto.
4183
4184         * LayoutReloaded/misc/LFC-passing-tests.txt:
4185
4186 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4187
4188         [ews-build] unapply-patch step should not update source
4189         https://bugs.webkit.org/show_bug.cgi?id=193234
4190
4191         Reviewed by Lucas Forschler.
4192
4193         * BuildSlaveSupport/ews-build/steps.py:
4194         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
4195         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
4196
4197 2019-01-16  Youenn Fablet  <youenn@apple.com>
4198
4199         Add a new SPI for controlling getUserMedia
4200         https://bugs.webkit.org/show_bug.cgi?id=192793
4201
4202         Reviewed by Eric Carlson.
4203
4204         * MiniBrowser/mac/WK2BrowserWindowController.m:
4205         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
4206         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4207         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
4208         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4209         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
4210         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4211         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
4212         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4213         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4214         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4215         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4216         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
4217         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4218         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4219
4220 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4221
4222         [LFC][BFC] Inflow non-replaced used width should not be negative.
4223         https://bugs.webkit.org/show_bug.cgi?id=193495
4224
4225         Reviewed by Antti Koivisto.
4226
4227         * LayoutReloaded/misc/LFC-passing-tests.txt:
4228
4229 2019-01-16  Chris Dumez  <cdumez@apple.com>
4230
4231         Regression(PSON) View becomes blank after click a cross-site download link
4232         https://bugs.webkit.org/show_bug.cgi?id=193361
4233         <rdar://problem/47099573>
4234
4235         Reviewed by Geoffrey Garen.
4236
4237         Add API test coverage.
4238
4239         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4240         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4241
4242 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4243
4244         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
4245         https://bugs.webkit.org/show_bug.cgi?id=193470
4246
4247         Reviewed by Antti Koivisto.
4248
4249         * LayoutReloaded/misc/LFC-passing-tests.txt:
4250
4251 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4252
4253         [LFC] Adjust margin box verification.
4254         https://bugs.webkit.org/show_bug.cgi?id=193482
4255
4256         Reviewed by Antti Koivisto.
4257
4258         * LayoutReloaded/misc/LFC-passing-tests.txt:
4259
4260 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
4261
4262         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
4263         https://bugs.webkit.org/show_bug.cgi?id=193451
4264
4265         Reviewed by Geoffrey Garen.
4266
4267         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
4268         (TEST):
4269         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4270         (runWebsiteDataStoreCustomPaths):
4271
4272 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4273
4274         webkitpy: Support boolean simctl isAvailable
4275         https://bugs.webkit.org/show_bug.cgi?id=193472
4276         <rdar://problem/47296150>
4277
4278         Reviewed by Ryosuke Niwa.
4279
4280         * Scripts/webkitpy/xcode/simulated_device.py:
4281         (SimulatedDeviceManager._create_runtimes):
4282         (SimulatedDeviceManager._create_device_with_runtime):
4283
4284 2019-01-15  Chris Dumez  <cdumez@apple.com>
4285
4286         Unreviewed, rolling out r239993, r239995, r239997, and
4287         r239999.
4288
4289         Caused assertions under
4290         ViewGestureController::disconnectFromProcess()
4291
4292         Reverted changesets:
4293
4294         "Regression(PSON) View becomes blank after click a cross-site
4295         download link"
4296         https://bugs.webkit.org/show_bug.cgi?id=193361
4297         https://trac.webkit.org/changeset/239993
4298
4299         "Unreviewed iOS build fix after r239993."
4300         https://trac.webkit.org/changeset/239995
4301
4302         "Fix iOS build after r239993"
4303         https://bugs.webkit.org/show_bug.cgi?id=193361
4304         https://trac.webkit.org/changeset/239997
4305
4306         "Unreviewed, revert part of r239997 as it is not needed to fix
4307         the build."
4308         https://trac.webkit.org/changeset/239999
4309
4310 2019-01-15  Tim Horton  <timothy_horton@apple.com>
4311
4312         Cannot tab out of WKWebView on macOS
4313         https://bugs.webkit.org/show_bug.cgi?id=161448
4314         <rdar://problem/28100085>
4315
4316         Reviewed by Dean Jackson.
4317
4318         Add a test that tabbing into and out of WKWebView works correctly.
4319
4320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4321         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
4322         (WebKit2_CommandBackForwardTest::SetUp):
4323         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
4324         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
4325         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
4326         (-[FocusableView canBecomeKeyView]):
4327         (TEST):
4328         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
4329         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
4330         (-[OffscreenWindow initWithSize:]):
4331         (-[OffscreenWindow isKeyWindow]):
4332         (-[OffscreenWindow isVisible]):
4333         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4334         (TestWebKitAPI::PlatformWebView::initialize):
4335         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
4336         (-[ActiveOffscreenWindow isVisible]): Deleted.
4337         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
4338
4339 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
4340
4341         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
4342         https://bugs.webkit.org/show_bug.cgi?id=193459
4343
4344         Reviewed by Mark Lam.
4345
4346         * BuildSlaveSupport/build.webkit.org-config/steps.py: