fedfd05092f260722ad4f49d14d89e42f526d1fc
[WebKit-https.git] / Tools / ChangeLog
1 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Remove replay performance tests as it's not actively maintained
4         https://bugs.webkit.org/show_bug.cgi?id=124764
5
6         Reviewed by Andreas Kling.
7
8         Removed the feature.
9
10         * Scripts/webkitpy/performance_tests/perftest.py:
11         (SingleProcessPerfTest.__init__):
12         (PerfTestFactory):
13         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
14         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
15         (PerfTestsRunner._parse_args):
16         (PerfTestsRunner._collect_tests):
17         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
18         (MainTest.test_collect_tests_with_ignored_skipped_list):
19         (MainTest.test_default_args):
20         * Scripts/webkitpy/thirdparty/__init__.py:
21         (AutoinstallImportHook.find_module):
22         (AutoinstallImportHook._install_unittest2):
23         * Scripts/webkitpy/thirdparty/__init___unittest.py:
24         (ThirdpartyTest.test_imports):
25
26 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
27
28         Enable aggressive DFG validation in testing
29         https://bugs.webkit.org/show_bug.cgi?id=124911
30
31         Rubber stamped by Ryosuke Niwa.
32         
33         This enables validation testing in non-concurrent-JIT runs.
34
35         * Scripts/run-jsc-stress-tests:
36
37 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
38
39         Moved methods which belong to Checkout into checkout.py
40         https://bugs.webkit.org/show_bug.cgi?id=124889
41
42         Reviewed by Ryosuke Niwa.
43
44         * Scripts/webkitpy/common/checkout/checkout.py:
45         (Checkout.scripts_directory):
46         (Checkout):
47         (Checkout.script_path):
48         (Checkout.commit_message_for_this_commit):
49         (Checkout.apply_patch):
50         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
51         (test_commit_message_for_this_commit):
52         (CheckoutTest.test_apply_patch):
53         * Scripts/webkitpy/common/checkout/scm/scm.py:
54         (SCM.absolute_path):
55         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
56         (SCMTest._setup_webkittools_scripts_symlink):
57         * Scripts/webkitpy/common/checkout/scm/svn.py:
58         (SVN.create_patch):
59
60 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
61
62         [EFL] Use Config mode of find_package for EFL 1.8
63         https://bugs.webkit.org/show_bug.cgi?id=124555
64
65         Reviewed by Gyuyoung Kim.
66
67         * MiniBrowser/efl/CMakeLists.txt:
68         Added optional config mode and made version requirement optional.
69
70 2013-11-25  Andres Gomez  <agomez@igalia.com>
71
72         [GTK] Search functionality in MiniBrowser provides feedback on search fail
73         https://bugs.webkit.org/show_bug.cgi?id=122681
74
75         Reviewed by Mario Sanchez Prada.
76
77         When using the search functionality in MiniBrowser, if the search
78         fails, the entry background color gets red to report the user
79         about the failing condition. When the entry is cleaned or the
80         search is again succesful the background turns back to its
81         original color.
82
83         * MiniBrowser/gtk/BrowserSearchBar.c:
84         (setFailedStyleForEntry): Added.
85         (doSearch): Sets the entry's background to its original style if
86         there is no text to search.
87         (findControllerFailedToFindTextCallback): Added.
88         (findControllerFoundTextCallback): Added.
89         (browser_search_bar_init): Creates and adds a new CSS provider to
90         the text entry so we can change its style based on the success
91         condition of the search.
92         (browserSearchBarFinalize): Frees the new CSS provider.
93         (browser_search_bar_new): Connects the two new handlers to the
94         "failed-to-find-text" and "found-text" signals emitted by the
95         WebKitFindController.
96
97 2013-11-25  Dan Bernstein  <mitz@apple.com>
98
99         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
100         https://bugs.webkit.org/show_bug.cgi?id=124850
101
102         Reviewed by Brady Eidson.
103
104         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
105
106         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
107         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
108         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
109         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
110         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
111         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
112         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
113
114 2013-11-25  Commit Queue  <commit-queue@webkit.org>
115
116         Unreviewed, rolling out r159752 and r159754.
117         http://trac.webkit.org/changeset/159752
118         http://trac.webkit.org/changeset/159754
119         https://bugs.webkit.org/show_bug.cgi?id=124847
120
121         Broke linux test bots. (Requested by mhahnenberg on #webkit).
122
123         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
124         * Scripts/run-javascriptcore-tests:
125         * Scripts/run-jsc-stress-tests:
126
127 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
128
129         Followup fix after r159752
130
131         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
132
133 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
134
135         run-jsc-stress-tests should be able to package its tests and move them places
136         https://bugs.webkit.org/show_bug.cgi?id=124549
137
138         Reviewed by Filip Pizlo.
139
140         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
141         of grep -i -q
142         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
143         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
144         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
145         All of the generated scripts now are completely relative within the results directory. This allows 
146         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
147         tarball of the generated results directory. Also refactored several portions of the script into 
148         separate functions to make it easier to run them conditionally depending on which mode we're running in.
149
150 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
151
152         EWS creates 0 byte sized log files
153         https://bugs.webkit.org/show_bug.cgi?id=107606
154
155         Reviewed by Ryosuke Niwa.
156
157         There was a modification in r138264, that tried to make less log,
158         because some of the messeges were duplicated. After this the EWS
159         created the log file (with the same name as the bugID) but doesn't
160         write anything into it, even if there were errors during the build.
161         From now only creates the log file only if there is some error.
162
163         * Scripts/webkitpy/tool/bot/queueengine.py:
164         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
165         there is nothing to log. Open the log file only if a ScriptError was raised to
166         avoid to make empty log files for bugs.
167         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
168         because of changes in r138264. Teeing is used for locally testing purposes and
169         this feature is not used anymore.
170         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
171         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
172         change.
173         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
174         (LoggingDelegate): The order of the callbacks was changed by this patch.
175         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
176         so we have to update this test.
177         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
178         this patch.
179         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
180         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
181         to be able to handle it in QueueEngine.run. Without this change, the existing
182         exception handler never run (the process_work_item method never raise ScriptError)
183         We can get the error message only from the ScriptError at this point.
184
185 2013-11-22  Dean Jackson  <dino@apple.com>
186
187         Speculative Mountain Lion build fix.
188
189         * MiniBrowser/mac/AppDelegate.m:
190         (-[BrowserAppDelegate openDocument:]):
191
192 2013-11-22  Anders Carlsson  <andersca@apple.com>
193
194         Fix Mountain Lion bug.
195
196         * MiniBrowser/mac/AppDelegate.m:
197         (-[BrowserAppDelegate openDocument:]):
198
199 2013-11-22  Anders Carlsson  <andersca@apple.com>
200
201         MiniBrowser should use the blocks-based NSOpenPanel API
202         https://bugs.webkit.org/show_bug.cgi?id=124786
203
204         Reviewed by Simon Fraser.
205
206         * MiniBrowser/mac/AppDelegate.m:
207         (-[BrowserAppDelegate frontmostBrowserWindowController]):
208         Account for windows that don't have a BrowserWindowController.
209
210         (-[BrowserAppDelegate openDocument:]):
211
212 2013-11-22  Commit Queue  <commit-queue@webkit.org>
213
214         Unreviewed, rolling out r159690.
215         http://trac.webkit.org/changeset/159690
216         https://bugs.webkit.org/show_bug.cgi?id=124782
217
218         Broke webkitpy tests (Requested by ap on #webkit).
219
220         * Scripts/webkitpy/tool/bot/queueengine.py:
221         (QueueEngine.run):
222         (QueueEngine._open_work_log):
223         (QueueEngine._ensure_work_log_closed):
224         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
225         (AbstractEarlyWarningSystem.review_patch):
226
227 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
228
229         EWS creates 0 byte sized log files
230         https://bugs.webkit.org/show_bug.cgi?id=107606
231
232         Reviewed by Ryosuke Niwa.
233
234         There was a modification in r138264, that tried to make less log, 
235         because some of the messeges were duplicated. After this the EWS 
236         created the log file (with the same name as the bugID) but doesn't 
237         write anything into it, even if there were errors during the build. 
238         From now only creates the log file only if there is some error.
239
240         * Scripts/webkitpy/tool/bot/queueengine.py:
241         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
242         there is nothing to log. Open the log file only if a ScriptError was raised to
243         avoid to make empty log files for bugs.
244         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
245         because of changes in r138264. Teeing is used for locally testing purposes and
246         this feature is not used anymore.
247         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
248         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
249         change.
250         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
251         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
252         to be able to handle it in QueueEngine.run. Without this change, the existing
253         exception handler never run (the process_work_item method never raise ScriptError)
254         We can get the error message only from the ScriptError at this point.
255
256 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
257
258         Remove ENABLE_WORKERS
259         https://bugs.webkit.org/show_bug.cgi?id=105784
260
261         Reviewed by Darin Adler.
262
263         * Scripts/webkitperl/FeatureList.pm:
264
265 2013-11-21  Darin Adler  <darin@apple.com>
266
267         Try to fix buildbot Dashboard for people who have not hidden anything.
268
269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
270         Add a null check for hidden platforms.
271
272 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
273
274         Remove chrome/chromium related things from webkitpy.
275         https://bugs.webkit.org/show_bug.cgi?id=124493
276
277         Reviewed by Darin Adler.
278
279         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
280         (PortTest.assert_mock_port_works):
281         * Scripts/webkitpy/port/base.py:
282         (Port.to.setup_environ_for_server):
283         * Scripts/webkitpy/port/mac_unittest.py:
284         (test_tests_for_other_platforms):
285         * Scripts/webkitpy/port/mock_drt.py:
286         (MockTestShell.output_for_test):
287         * Scripts/webkitpy/tool/bot/irc_command.py:
288         (Restart.execute):
289         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
290         (IRCBotTest.test_help):
291
292 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
293
294         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
295         https://bugs.webkit.org/show_bug.cgi?id=124717
296
297         Reviewed by Ryosuke Niwa.
298
299         * Scripts/webkitpy/style/filereader.py:
300         (TextFileReader.process_file):
301         * Scripts/webkitpy/style/filereader_unittest.py:
302         (TextFileReaderTest.test_process_file__does_not_exist):
303
304 2013-11-21  Mark Rowe  <mrowe@apple.com>
305
306         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
307
308         All modern versions of Xcode set it appropriately for our needs.
309
310         Reviewed by Alexey Proskuryakov.
311
312         * MiniBrowser/Configurations/Base.xcconfig:
313         * WebKitTestRunner/Configurations/Base.xcconfig:
314
315 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
316
317         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
318         https://bugs.webkit.org/show_bug.cgi?id=124676
319
320         Reviewed by Daniel Bates.
321
322         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
323         elements when there were more then one occurrence of that argument.
324         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
325         {b, a}, when it should be {b, c}.
326
327         * Scripts/webkitdirs.pm:
328         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
329         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
330         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
331
332 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
333
334         Update build-webkit after r159550.
335
336         * Scripts/webkitperl/FeatureList.pm:
337
338 2013-11-21  Lucas Forschler  <lforschler@apple.com>
339
340         Bring a new bot online, replacing the previous ones.
341         
342         Unreviewed.
343
344         * BuildSlaveSupport/build.webkit.org-config/config.json:
345
346 2013-11-21  Dean Jackson  <dino@apple.com>
347
348         Don't fetch hidden platforms on build.webkit.org/dashboard
349         https://bugs.webkit.org/show_bug.cgi?id=124750
350
351         Reviewed by Tim Horton.
352
353         If a platform is hidden, don't fetch its data. If it
354         becomes unhidden, try to fetch immediately (unless
355         you've recently fetched).
356
357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
359
360 2013-11-21  Commit Queue  <commit-queue@webkit.org>
361
362         Unreviewed, rolling out r159633.
363         http://trac.webkit.org/changeset/159633
364         https://bugs.webkit.org/show_bug.cgi?id=124726
365
366         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
367
368         * Scripts/webkitpy/style/checker.py:
369         (check_webkit_style_configuration):
370         (CheckerDispatcher.dispatch):
371         (StyleProcessorConfiguration):
372         (StyleProcessorConfiguration.__init__):
373         (StyleProcessorConfiguration.write_style_error):
374
375 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
376
377         Remove the stderr_write attribute from StyleProcessorConfiguration.
378         https://bugs.webkit.org/show_bug.cgi?id=124703
379
380         Reviewed by Brent Fulgham.
381
382         * Scripts/webkitpy/style/checker.py:
383         (check_webkit_style_configuration):
384         (CheckerDispatcher.dispatch):
385         (StyleProcessorConfiguration):
386         (StyleProcessorConfiguration.__init__):
387         (StyleProcessorConfiguration.write_style_error):
388
389 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
390
391         PerfTestRunner._generate_results_dict shouldn't depend on test objects
392         https://bugs.webkit.org/show_bug.cgi?id=124623
393
394         Removed the dependency on test objects from results JSON generation.
395         This allows single test.run to return metrics for multiple tests
396
397         Reviewed by Antti Koivisto.
398
399         * Scripts/webkitpy/performance_tests/perftest.py:
400         (PerfTestMetric.__init__): Takes the test path and test name.
401         (PerfTestMetric.path): Added.
402         (PerfTestMetric.test_file_name): Added.
403         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
404         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
405         The path is going to have the names of subtests at the end once we support them.
406
407         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
408         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
409         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
410         (TestPerfTestMetric.test_has_values): Ditto.
411         (TestPerfTestMetric.test_append): Ditto.
412
413         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
414         (_generate_results_dict): Only use metrics.
415         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
416
417 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
418
419         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
420         https://bugs.webkit.org/show_bug.cgi?id=124697
421
422         Reviewed by Ryosuke Niwa.
423
424         * Scripts/webkitdirs.pm:
425         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
426         before trying to access to the first element.
427
428 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
429
430         [GTK] Mark all deprecated symbols in GObject DOM bindings
431         https://bugs.webkit.org/show_bug.cgi?id=124406
432
433         Reviewed by Gustavo Noronha Silva.
434
435         * Scripts/webkitpy/style/checker.py: Add special case for
436         WebKitDOMDeprecated.
437         * gtk/generate-gtkdoc:
438         (get_webkit2_options): Use the prefix of the methods as namespace,
439         since this is what gtkdoc expects to sort the index.
440         (get_webkit1_options): Ditto.
441         (get_webkitdom_options): Ditto.
442         * gtk/generate-webkitdom-doc-files:
443         (WebKitDOMDocGenerator): Add a global list of deleted objects.
444         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
445         the documentation for classes that are deprecated because they
446         have been removed.
447         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
448         for deleted classes too.
449         (WebKitDOMDocGeneratorSections.__init__): Build a list of
450         deprecated symbols using the given symbols file.
451         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
452         deleted class corresponding to the given function.
453         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
454         dictionary of deprecated symbols for every class.
455         (WebKitDOMDocGeneratorSections.write_section): Add also the
456         deprecated symbols in every section.
457         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
458         sections for deleted classes too.
459
460 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
461
462         check-webkit-style should support C++11 rvalue references.
463         https://bugs.webkit.org/show_bug.cgi?id=123406
464
465         Reviewed by Brent Fulgham.
466
467         * Scripts/webkitpy/style/checkers/cpp.py:
468         (check_style):
469         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
470         (Cpp11StyleTest):
471         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
472
473 2013-11-20  Dean Jackson  <dino@apple.com>
474
475         Allow settings to be shown/hidden on build.webkit.org/dashboard
476         https://bugs.webkit.org/show_bug.cgi?id=124694
477
478         Reviewed by Tim Horton.
479
480         In preparation for more options/buttons, allow the page to
481         show or hide all the interactive things using a little gear icon
482         in the top left corner.
483
484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
486         (Settings.prototype.toggleSettingsDisplay):
487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
488         (div.cellButton.hide):
489         (div.cellButton.unhide):
490         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
491         (.settings):
492         (.settings:hover):
493         (.settings-visible .settings):
494
495 2013-11-20  Dean Jackson  <dino@apple.com>
496
497         No need to base64 SVG on build.webkit.org/dashboard
498         https://bugs.webkit.org/show_bug.cgi?id=124687
499
500         Reviewed by Tim Horton.
501
502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
503         (.status-line.good .bubble.pictogram):
504
505 2013-11-20  Dean Jackson  <dino@apple.com>
506
507         Make links look more like links on build.webkit.org/dashboard
508         https://bugs.webkit.org/show_bug.cgi?id=124686
509
510         Reviewed by Tim Horton.
511
512         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
513         (.queue-view .queueLabel:hover):
514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
515         (.status-line.linked .label:hover):
516
517 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
518
519         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
520         https://bugs.webkit.org/show_bug.cgi?id=124581
521
522         Reviewed by Daniel Bates.
523
524         Some subroutines are replicating code from checkForArgument**
525         functions instead of reusing them as is being done by all other functions.
526
527         * Scripts/webkitdirs.pm:
528         (determineXcodeSDK): Added.
529         (determinePassedConfiguration): Added.
530         (determinePassedArchitecture): Added.
531         (checkForArgumentAndRemoveFromARGV): Added.
532         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
533
534 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
535
536         Delete baseline optimizer
537         https://bugs.webkit.org/show_bug.cgi?id=122333
538
539         Reviewed by Ryosuke Niwa.
540
541         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
542         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
543         * Scripts/webkitpy/tool/commands/rebaseline.py:
544         (RebaselineTest.execute):
545         (AbstractParallelRebaselineCommand._files_to_add):
546         (AbstractParallelRebaselineCommand._rebaseline):
547         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
548         (TestRebaselineJson.test_rebaseline_all):
549         (TestRebaselineJson.test_rebaseline_debug):
550         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
551
552 2013-11-20  Anders Carlsson  <andersca@apple.com>
553
554         Enable PageLoadTest assertions again
555         https://bugs.webkit.org/show_bug.cgi?id=124681
556
557         Reviewed by Tim Horton.
558
559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
560         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
561
562 2013-11-20  Mark Rowe  <mrowe@apple.com>
563
564         Remove some obsolete logic from WebKit.app.
565
566         Reviewed by Alexey Proskuryakov.
567
568         * WebKitLauncher/WebKitNightlyEnabler.m:
569         (poseAsWebKitApp): Remove a pre-10.6 codepath.
570         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
571
572 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
573
574         Moved stray urls from svn.py and statusserver.py into common.config.urls
575         https://bugs.webkit.org/show_bug.cgi?id=124650
576
577         Reviewed by Ryosuke Niwa.
578
579         * Scripts/webkitpy/common/checkout/scm/svn.py:
580         (SVNRepository):
581         * Scripts/webkitpy/common/config/urls.py:
582         * Scripts/webkitpy/common/net/statusserver.py:
583         (StatusServer.__init__):
584         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
585         (_generate_results_dict):
586
587 2013-11-20  Commit Queue  <commit-queue@webkit.org>
588
589         Unreviewed, rolling out r159496.
590         http://trac.webkit.org/changeset/159496
591         https://bugs.webkit.org/show_bug.cgi?id=124641
592
593         It caused warning and build break with cmake lower than 2.8.8
594         (Requested by ryuan on #webkit).
595
596         * MiniBrowser/efl/CMakeLists.txt:
597
598 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
599
600         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
601         https://bugs.webkit.org/show_bug.cgi?id=124412
602
603         Reviewed by Gyuyoung Kim.
604
605         Update libseccomp to a newer 2.1.0 version.
606
607         * efl/jhbuild.modules:
608
609 2013-11-19  Mark Rowe  <mrowe@apple.com>
610
611         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
612
613         Gestalt is deprecated on recent OS X versions so we should switch off it.
614
615         Reviewed by Sam Weinig.
616
617         * WebKitLauncher/main.m:
618         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
619         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
620         two components, then join them back up.
621         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
622         the version we care about.
623
624 2013-11-19  Commit Queue  <commit-queue@webkit.org>
625
626         Unreviewed, rolling out r159538.
627         http://trac.webkit.org/changeset/159538
628         https://bugs.webkit.org/show_bug.cgi?id=124627
629
630         it broke run-jsc-stress-tests (Requested by mhahnenberg on
631         #webkit).
632
633         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
634         * Scripts/run-javascriptcore-tests:
635         * Scripts/run-jsc-stress-tests:
636
637 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
638
639         run-jsc-stress-tests should be able to package its tests and move them places
640         https://bugs.webkit.org/show_bug.cgi?id=124549
641
642         Reviewed by Geoff Garen and Filip Pizlo.
643
644         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
645         of grep -i -q 
646         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
647         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
648         other files that those tests require to run in any environment along with a fixed root directory into which these
649         files and their expected directory structure are cloned. The default Bundle class is basically 
650         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
651         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
652         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
653         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
654         to use MovableBundle instead of just Bundle. 
655
656 2013-11-19  Dan Bernstein  <mitz@apple.com>
657
658         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
659
660         Rubber-stamped by Mark Rowe.
661
662         Reverted r156840.
663
664         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
665
666 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
667
668         Yet another build fix. Just allow any character.
669         There are just too many special characters to be listed here.
670
671         * Scripts/webkitpy/performance_tests/perftest.py:
672         (PerfTest._lines_to_ignore_in_parser_result):
673         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
674         (TestPerfTest.test_parse_output_with_subtests)
675
676 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
677
678         Another build fix. Allow ':' in subtest names.
679
680         * Scripts/webkitpy/performance_tests/perftest.py:
681         (PerfTest._lines_to_ignore_in_parser_result):
682         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
683         (TestPerfTest.test_parse_output_with_subtests)
684
685 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
686
687         [EFL] Use Config mode of find_package for EFL 1.8
688         https://bugs.webkit.org/show_bug.cgi?id=124555
689
690         Reviewed by Gyuyoung Kim.
691
692         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
693
694 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
695
696         Build fix. Subtest names need to be more permissive.
697
698         * Scripts/webkitpy/performance_tests/perftest.py:
699         (PerfTest._lines_to_ignore_in_parser_result):
700         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
701         (TestPerfTest.test_parse_output_with_subtests)
702
703 2013-11-18  Mark Rowe  <mrowe@apple.com>
704
705         Use hw.activecpu for determining how many processes to spawn.
706
707         It's documented as the preferred way to determine the number of threads
708         or processes to create in a SMP aware application.
709
710         Rubber-stamped by Tim Horton.
711
712         * Scripts/copy-webkitlibraries-to-product-directory:
713         * Scripts/run-jsc-stress-tests:
714         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
715
716 2013-11-18  Tim Horton  <timothy_horton@apple.com>
717
718         build.webkit.org/dashboard builder headers should link to the builder page
719         https://bugs.webkit.org/show_bug.cgi?id=124553
720
721         Reviewed by Timothy Hatcher.
722
723         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
724         (BuildbotQueue.prototype.get overviewURL):
725         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
726
727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
728         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
729         (BuildbotBuilderQueueView.prototype.update):
730         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
731         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
732         (BuildbotTesterQueueView.prototype.update.appendBuild):
733         (BuildbotTesterQueueView.prototype.update):
734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
735         (.queue-view .queueLabel):
736         (.queue-view .queueLabel:not(:first-child)):
737         Make the header a link instead of a label, and wire it up to overviewURL.
738
739 2013-11-18  Samuel White  <samuel_white@apple.com>
740
741         AX: Add ability to fetch only visible table rows.
742         https://bugs.webkit.org/show_bug.cgi?id=124430
743
744         Reviewed by Chris Fleizach.
745
746         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
747         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
748         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
749         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
750         as the test guidelines state, our tests should be more focused and specific about what they test.
751
752         * DumpRenderTree/AccessibilityUIElement.cpp:
753         (uiElementArrayAttributeValueCallback):
754         (AccessibilityUIElement::uiElementArrayAttributeValue):
755         (AccessibilityUIElement::getJSClass):
756         * DumpRenderTree/AccessibilityUIElement.h:
757         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
758         (AccessibilityUIElement::uiElementArrayAttributeValue):
759         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
760         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
761         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
762         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
763         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
764         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
765         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
766         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
767         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
768
769 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
770
771         Simplify and reformat the output of performance tests inside test runners
772         https://bugs.webkit.org/show_bug.cgi?id=124496
773
774         Reviewed by Antti Koivisto.
775
776         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
777         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
778         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
779         the first place.
780
781         Also modernize the output to adopt "metric" concept better and make it forward compatible
782         with subtests.
783
784         With this patch, performance tests written using runner.js only produces empty lines or
785         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
786         <subtest name> -> [<value 1>, <value 2>, ...]
787         :<metric name> -> [<value 1>, <value 2>, ...]
788
789         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
790
791         * Scripts/webkitpy/performance_tests/perftest.py:
792         (PerfTest): Removed a bunch of regular expressions that are no longer used.
793         (PerfTest._run_with_driver): Just parse the values and description and treat everything
794         else as errors.
795
796         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
797         (TestPerfTest.test_parse_output): Removed the junk.
798         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
799         which was removed in favor of the tests below.
800         (TestPerfTest.test_parse_output_with_running_five_times): Added.
801         (TestPerfTest.test_parse_output_with_detailed_info): Added.
802         (TestPerfTest.test_parse_output_with_statistics): Added.
803         (TestPerfTest.test_parse_output_with_description): Removed the junk.
804         (TestPerfTest.test_parse_output_with_subtests): Ditto.
805         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
806
807         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
808         (EventTargetWrapperTestData): Ditto.
809         (SomeParserTestData): Ditto.
810         (MemoryTestData): Ditto.
811
812 2013-11-18  Tim Horton  <timothy_horton@apple.com>
813
814         Occasionally, hundreds of tests fail with small text diffs on Mavericks
815         https://bugs.webkit.org/show_bug.cgi?id=124312
816
817         Reviewed by Simon Fraser.
818
819         * Scripts/webkitpy/layout_tests/controllers/manager.py:
820         (Manager._set_up_run):
821         * Scripts/webkitpy/port/base.py:
822         (Port.to.reset_preferences):
823         * Scripts/webkitpy/port/mac.py:
824         (MacPort.reset_preferences):
825         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
826         returning some of the functionality of 158652 after 159364 removed it.
827
828 2013-11-18  Tim Horton  <timothy_horton@apple.com>
829
830         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
831         https://bugs.webkit.org/show_bug.cgi?id=122909
832
833         Reviewed by Alexey Proskuryakov.
834
835         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
836
837         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
838         (.status-line .bubble):
839         (.status-line.good .bubble.pictogram):
840
841 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
842
843         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
844         https://bugs.webkit.org/show_bug.cgi?id=124499
845
846         Reviewed by Csaba Osztrogonác.
847
848         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
849
850         * Scripts/webkitpy/performance_tests/perftest.py:
851         (PerfTest._should_ignore_line):
852         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
853         (TestPerfTest): Removed the unit test.
854
855 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
856
857         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
858         quite as easily.
859         
860         With help from Andy Trick.
861
862         * Scripts/export-llvm-build:
863
864 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
865
866         FTL should have an explicit notion of bytecode liveness
867         https://bugs.webkit.org/show_bug.cgi?id=124181
868
869         Reviewed by Mark Hahnenberg.
870
871         * Scripts/run-jsc-stress-tests:
872
873 2013-11-16  Dan Bernstein  <mitz@apple.com>
874
875         No way for policy client to determine if a the response’s MIME type can be shown
876         https://bugs.webkit.org/show_bug.cgi?id=124445
877
878         Reviewed by Sam Weinig.
879
880         * MiniBrowser/mac/WK2BrowserWindowController.m:
881         (decidePolicyForResponse): Added canShowMIMEType parameter.
882         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
883
884         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
885         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
886
887         * WebKitTestRunner/TestController.cpp:
888         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
889         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
890         * WebKitTestRunner/TestController.h:
891
892 2013-11-16  Tim Horton  <timothy_horton@apple.com>
893
894         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
895         https://bugs.webkit.org/show_bug.cgi?id=122909
896
897         Reviewed by Timothy Hatcher.
898
899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
901         (StatusLineView.prototype.set repeatCount):
902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
903         (.status-line.good .bubble.pictogram):
904         Use an SVG image instead of an obscure font for the checkboxes so they
905         render identically on all platforms.
906
907 2013-11-15  Tim Horton  <timothy_horton@apple.com>
908
909         Occasionally, hundreds of tests fail with small text diffs on Mavericks
910         https://bugs.webkit.org/show_bug.cgi?id=124312
911
912         Reviewed by Alexey Proskuryakov.
913
914         Try reverting the part of r158652 that deleted all of the persistent
915         defaults, in the thought that there might be some sort of race between
916         processes causing some settings to be left in the wrong state.
917
918         * DumpRenderTree/mac/DumpRenderTree.mm:
919         (setDefaultsToConsistentValuesForTesting):
920         * WebKitTestRunner/mac/main.mm:
921         (setDefaultsToConsistentValuesForTesting):
922
923 2013-11-15  Dan Bernstein  <mitz@apple.com>
924
925         Give the policy client the originating frame of a navigation action
926         https://bugs.webkit.org/show_bug.cgi?id=124431
927
928         Reviewed by Anders Carlsson.
929
930         * MiniBrowser/mac/WK2BrowserWindowController.m:
931         (decidePolicyForNavigationAction): Added originatingFrame parameter.
932         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
933         client.
934
935         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
936         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
937         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
938
939         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
940         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
941         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
942
943         * WebKitTestRunner/TestController.cpp:
944         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
945         client.
946         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
947         * WebKitTestRunner/TestController.h:
948
949 2013-11-15  Tim Horton  <timothy_horton@apple.com>
950
951         build.webkit.org/dashboard should provide a way to focus on a subset of bots
952         https://bugs.webkit.org/show_bug.cgi?id=122676
953
954         Reviewed by Timothy Hatcher.
955
956         Add a small 'hide' button next to every platform logo, and a 'show all'
957         button which only appears when at least one platform is hidden. Hidden
958         platforms persist using localStorage.
959
960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
962         (updateHiddenPlatforms):
963         (documentReady.unhideButton):
964         (documentReady.hideButton):
965         (documentReady):
966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
967         (Settings.prototype.setObject):
968         (Settings.prototype.getObject):
969         (Settings.prototype.addSettingListener):
970         (Settings.prototype.fireSettingListener):
971         (Settings.prototype.toggleHiddenPlatform):
972         (Settings.prototype.clearHiddenPlatforms):
973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
974         (div.cellButton):
975         (div.cellButton.hide):
976         (.hidden):
977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
978
979 2013-11-15  Jer Noble  <jer.noble@apple.com>
980
981         MediaTime addition and subtraction operators have errors when the rhs is infinite.
982         https://bugs.webkit.org/show_bug.cgi?id=124413
983
984         Reviewed by Eric Carlson.
985
986         Add a test for operator+ and operator- where an infinite value appears
987         on the right-hand side:
988         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
989         (TestWebKitAPI::TEST):
990
991         Add a LLDB summary provider for MediaTime which displays the rational
992         time as well as the value in seconds:
993         * lldb/lldb_webkit.py:
994         (__lldb_init_module):
995         (WTFMediaTime_SummaryProvider):
996         (WTFHashTableProvider.has_children):
997         (WTFMediaTimeProvider):
998         (WTFMediaTimeProvider.__init__):
999         (WTFMediaTimeProvider.timeValue):
1000         (WTFMediaTimeProvider.timeScale):
1001         (WTFMediaTimeProvider.isInvalid):
1002         (WTFMediaTimeProvider.isPositiveInfinity):
1003         (WTFMediaTimeProvider.isNegativeInfinity):
1004         (WTFMediaTimeProvider.isIndefinite):
1005
1006 2013-11-15  Tim Horton  <timothy_horton@apple.com>
1007
1008         Make it possible to select revision numbers on build.webkit.org/dashboard
1009         https://bugs.webkit.org/show_bug.cgi?id=124400
1010
1011         Reviewed by Timothy Hatcher.
1012
1013         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1014         (BuildbotQueueView.prototype.revisionLinksForIteration):
1015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1016         (.selectable):
1017         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
1018         This way, a Dashboard user can highlight revision numbers for easy copying,
1019         and doesn't even have to be precise about the selection.
1020
1021 2013-11-15  Tim Horton  <timothy_horton@apple.com>
1022
1023         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
1024         https://bugs.webkit.org/show_bug.cgi?id=124399
1025
1026         Reviewed by Gustavo Noronha Silva.
1027
1028         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
1029         with the icons adjusted to have solid backgrounds, to not be squished, and to not
1030         intersect the ring, similar to the Mac icons.
1031
1032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
1033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
1034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
1035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
1036         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1037         (documentReady.hideButton):
1038         (documentReady):
1039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1040         (table.queue-grid tr.platform.linux-gtk img.logo):
1041         (table.queue-grid tr.platform.linux-efl img.logo):
1042
1043 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
1044
1045         [GStreamer] Add support for Media Source API
1046         https://bugs.webkit.org/show_bug.cgi?id=99065
1047
1048         Reviewed by Philippe Normand.
1049
1050         * Scripts/webkitperl/FeatureList.pm:
1051
1052 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1053
1054         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
1055         https://bugs.webkit.org/show_bug.cgi?id=124360
1056
1057         Reviewed by Philippe Normand.
1058
1059         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
1060
1061 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
1062
1063         [Win] Improve support for command line builds of 64-bit JSC
1064         https://bugs.webkit.org/show_bug.cgi?id=124380
1065
1066         Reviewed by David Kilzer.
1067
1068         * Scripts/webkitdirs.pm:
1069         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
1070         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
1071         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
1072         what the "$configurationForVisualStudio" value is for.
1073
1074 2013-11-14  Oliver Hunt  <oliver@apple.com>
1075
1076         Make CLoop easier to build, and make it work
1077         https://bugs.webkit.org/show_bug.cgi?id=124359
1078
1079         Reviewed by Geoffrey Garen.
1080
1081         Add --cloop support to forcibly enable to CLoop build
1082
1083         * Scripts/build-jsc:
1084         * Scripts/build-webkit:
1085
1086 2013-11-14  Lucas Forschler  <lforschler@apple.com>
1087
1088         Add webkit slave.
1089
1090         Unreviewed.
1091
1092         * BuildSlaveSupport/build.webkit.org-config/config.json:
1093
1094 2013-11-14  Tim Horton  <timothy_horton@apple.com>
1095
1096         build.webkit.org/dashboard can’t open different results in two new tabs
1097         https://bugs.webkit.org/show_bug.cgi?id=124383
1098
1099         Reviewed by Alexey Proskuryakov.
1100
1101         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1102         (BuildbotQueueView.prototype.revisionLinksForIteration):
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1104         (StatusLineView.prototype._clicked):
1105         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
1106         real pseudo-target and instead acts as a named target and will end up causing all link clicks
1107         to open in the same secondary tab).
1108
1109 2013-11-14  Anders Carlsson  <andersca@apple.com>
1110
1111         Remove duplicate entry.
1112
1113         * Scripts/webkitpy/common/config/contributors.json:
1114
1115 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
1116
1117         [ATK] Change WKTR/DRT AX methods to use nullptr 
1118         https://bugs.webkit.org/show_bug.cgi?id=124352
1119
1120         Reviewed by Anders Carlsson.
1121
1122         Change WKTR/DRT accessibility related methods to use nullptr.
1123
1124         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1125         (AccessibilityController::AccessibilityController):
1126         (AccessibilityController::elementAtPoint):
1127         (AccessibilityController::removeNotificationListener):
1128         (AccessibilityController::childElementById):
1129         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
1130         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
1131         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1132         (AccessibilityUIElement::elementAtPoint):
1133         (AccessibilityUIElement::linkedUIElementAtIndex):
1134         (AccessibilityUIElement::getChildAtIndex):
1135         (AccessibilityUIElement::titleUIElement):
1136         (AccessibilityUIElement::parentElement):
1137         (AccessibilityUIElement::subrole):
1138         (AccessibilityUIElement::roleDescription):
1139         (AccessibilityUIElement::orientation):
1140         (AccessibilityUIElement::ariaDropEffects):
1141         (AccessibilityUIElement::uiElementForSearchPredicate):
1142         (AccessibilityUIElement::cellForColumnAndRow):
1143         (AccessibilityUIElement::disclosedRowAtIndex):
1144         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1145         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1146         (AccessibilityUIElement::selectedRowAtIndex):
1147         (AccessibilityUIElement::rowAtIndex):
1148         (AccessibilityUIElement::disclosedByRow):
1149         (AccessibilityUIElement::removeNotificationListener):
1150         (AccessibilityUIElement::classList):
1151         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1152         (WTR::AccessibilityController::logAccessibilityEvents):
1153         (WTR::AccessibilityController::resetToConsistentState):
1154         (WTR::childElementById):
1155         (WTR::AccessibilityController::accessibleElementById):
1156         (WTR::AccessibilityController::removeNotificationListener):
1157         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1158         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
1159         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
1160         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1161         (WTR::AccessibilityUIElement::elementAtPoint):
1162         (WTR::AccessibilityUIElement::childAtIndex):
1163         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1164         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1165         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1166         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1167         (WTR::AccessibilityUIElement::rowAtIndex):
1168         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1169         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1170         (WTR::AccessibilityUIElement::titleUIElement):
1171         (WTR::AccessibilityUIElement::parentElement):
1172         (WTR::AccessibilityUIElement::disclosedByRow):
1173         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1174         (WTR::AccessibilityUIElement::orientation):
1175         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1176         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1177         (WTR::AccessibilityUIElement::horizontalScrollbar):
1178         (WTR::AccessibilityUIElement::verticalScrollbar):
1179         (WTR::AccessibilityUIElement::removeNotificationListener):
1180         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1181         (WTR::AccessibilityUIElement::previousTextMarker):
1182         (WTR::AccessibilityUIElement::nextTextMarker):
1183         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1184         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1185         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1186         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1187         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1188         (WTR::AccessibilityUIElement::textMarkerForPoint):
1189         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1190         (WTR::AccessibilityUIElement::textMarkerForIndex):
1191         (WTR::AccessibilityUIElement::supportedActions):
1192         (WTR::AccessibilityUIElement::pathDescription):
1193         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1194         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1195         (WTR::AccessibilityUIElement::classList):
1196
1197 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
1198
1199         run-perf-tests should warn loudly if you're using a Debug build.
1200         https://bugs.webkit.org/show_bug.cgi?id=105236
1201
1202         Reviewed by Csaba Osztrogonác.
1203
1204         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1205         (PerfTestsRunner.run):
1206
1207 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
1208
1209         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
1210         https://bugs.webkit.org/show_bug.cgi?id=124143
1211
1212         Reviewed by Csaba Osztrogonác.
1213
1214         * Scripts/webkitpy/port/factory.py:
1215         (configuration_options):
1216
1217 2013-11-13  Anders Carlsson  <andersca@apple.com>
1218
1219         Add a Vector constructor that takes an std::initializer_list
1220         https://bugs.webkit.org/show_bug.cgi?id=124287
1221
1222         Reviewed by Antti Koivisto.
1223
1224         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1225         (TestWebKitAPI::TEST):
1226
1227 2013-11-13  Mario Sanchez Prada  <mario.prada@samsung.com>
1228
1229         Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
1230
1231         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1232         (TestRebaselineTest.test_baseline_directory): Updated.
1233
1234 2013-11-13  Krzysztof Czech  <k.czech@samsung.com>
1235
1236         [ATK] Support compilation of EFL/GTK without accessibility
1237         https://bugs.webkit.org/show_bug.cgi?id=122448
1238
1239         Reviewed by Chris Fleizach.
1240
1241         Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
1242         so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
1243
1244         * DumpRenderTree/AccessibilityController.h:
1245         * DumpRenderTree/AccessibilityUIElement.h:
1246         * DumpRenderTree/atk/AccessibilityCallbacks.h:
1247         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
1248         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
1249         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1250         (WTR::AccessibilityController::rootElement):
1251         (WTR::AccessibilityController::focusedElement):
1252         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1253         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1254         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1255         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1256         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1257         * WebKitTestRunner/PlatformEfl.cmake:
1258
1259 2013-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
1260
1261         [EFL] Added libxss-dev to install-dependencies
1262         https://bugs.webkit.org/show_bug.cgi?id=124254
1263
1264         Reviewed by Gyuyoung Kim.
1265
1266         libxss-dev is required to build EFL packages.
1267         see building part in http://www.enlightenment.org/p.php?p=contribute
1268
1269         * efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
1270
1271 2013-11-12  Tim Horton  <timothy_horton@apple.com>
1272
1273         After http://trac.webkit.org/changeset/159109, update
1274         rebaseline_unittest to use the new GTK bot names.
1275
1276         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1277         (TestRebaselineTest.test_baseline_directory):
1278
1279 2013-11-12  Denis Nomiyama  <d.nomiyama@samsung.com>
1280
1281         [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
1282         https://bugs.webkit.org/show_bug.cgi?id=124144
1283
1284         Reviewed by Gustavo Noronha Silva.
1285
1286         Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
1287         according to http://build.webkit.org/builders.
1288
1289         * Scripts/webkitpy/port/builders.py:
1290
1291 2013-11-11  Samuel White  <samuel_white@apple.com>
1292
1293         AX: support helpText() in DumpRenderTree
1294         https://bugs.webkit.org/show_bug.cgi?id=40194
1295
1296         Reviewed by Chris Fleizach.
1297
1298         Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
1299
1300         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1301         (AccessibilityUIElement::helpText):
1302
1303 2013-11-11  Anders Carlsson  <andersca@apple.com>
1304
1305         Remove block based APIs from the WebKit2 C API
1306         https://bugs.webkit.org/show_bug.cgi?id=124157
1307
1308         Reviewed by Sam Weinig.
1309
1310         Update for WK2 changes.
1311
1312         * MiniBrowser/mac/WK2BrowserWindowController.m:
1313         (dumpSource):
1314         (-[WK2BrowserWindowController dumpSourceToConsole:]):
1315
1316 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
1317
1318         The feeder queue will not feed patches older than one week.
1319         https://bugs.webkit.org/show_bug.cgi?id=107152
1320
1321         Reviewed by Csaba Osztrogonác.
1322
1323         The feeder queue will not feed patches older than one week.
1324         Unit test added to this scenario.
1325
1326         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1327         (BugzillaQueries._parse_attachment_ids_request_query):
1328           Handle date parameter.
1329         (BugzillaQueries):
1330         (BugzillaQueries._fetch_attachment_ids_request_query):
1331           Propagate date.
1332         (BugzillaQueries.fetch_attachment_ids_from_review_queue):
1333           Propagate date.
1334         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1335         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
1336           Handle date.
1337         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1338         (test_request_page_parsing):
1339           Unit test added.
1340         * Scripts/webkitpy/tool/bot/feeders.py:
1341         (EWSFeeder.feed):
1342           Query patch ids with date parameter (now - 1 week).
1343
1344 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
1345
1346         Do not shut down ImageDiff server after every diff during the tests.
1347         https://bugs.webkit.org/show_bug.cgi?id=124140
1348
1349         Reviewed by Csaba Osztrogonác.
1350
1351         There was a FIXME: There is no need to shut down the ImageDiff
1352         server after every diff. Shutdown is removed from that point.
1353
1354         * Scripts/webkitpy/port/image_diff.py:
1355         (ImageDiffer._read):
1356
1357 2013-11-08  Matthew Hanson  <matthew_hanson@apple.com>
1358
1359         Unreviewed. Added myself as a contributor.
1360
1361         * Scripts/webkitpy/common/config/contributors.json:
1362
1363 2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
1364
1365         [GTK] accessibility/aria-link-supports-press.html is failing
1366         https://bugs.webkit.org/show_bug.cgi?id=98355
1367
1368         Reviewed by Mario Sanchez Prada.
1369
1370         Checking "jump" action for link elements. Action "jump" occurs when a link 
1371         element is pressed/clicked.
1372
1373         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1374         (AccessibilityUIElement::isPressActionSupported):
1375         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1376         (WTR::AccessibilityUIElement::isPressActionSupported):
1377
1378 2013-11-08  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
1379
1380         [JHBUILD] Jhbuild Makefile build bug workaround
1381         https://bugs.webkit.org/show_bug.cgi?id=123971
1382
1383         Reviewed by Ryosuke Niwa.
1384
1385         After Jhbuild repository is cloned (for instance when you use
1386         Tools/Scripts/update-webkitefl-libs) it is built from sources.
1387         If you have GREP_OPTIONS grep env variable set (for instance
1388         GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
1389         uses shell grep. For specific GREP_OPTIONS grep output will be
1390         different than expected one by Jhbuild and there is an error
1391         with Jhbuild build. Jhbuild will not be built and then WebKit
1392         source also will not be built. This patch is a workaround to this
1393         issue. It disables GREP_OPTIONS for Jhbuild build time.
1394
1395         * jhbuild/jhbuild-wrapper:
1396         (install_jhbuild):
1397
1398 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1399
1400         [GTK] Ignore deprecated macros when generating gtk-doc
1401         https://bugs.webkit.org/show_bug.cgi?id=123988
1402
1403         Reviewed by Philippe Normand.
1404
1405         * gtk/generate-gtkdoc:
1406         (get_common_options): Ignore also WEBKIT_DEPRECATED and
1407         WEBKIT_DEPRECATED_FOR decorators.
1408
1409 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1410
1411         [GTK] Pass the library namespace to gtkdoc-mkdb
1412         https://bugs.webkit.org/show_bug.cgi?id=123900
1413
1414         Reviewed by Martin Robinson.
1415
1416         This fixes the generation of the index of symbols in the API
1417         documentation.
1418
1419         * gtk/generate-gtkdoc:
1420         (get_webkit2_options): Define namespace as WebKit.
1421         (get_webkit1_options): Ditto.
1422         (get_webkitdom_options): Define namespace as WebKitDOM.
1423         * gtk/gtkdoc.py:
1424         (GTKDoc.__init__): Add namespace option.
1425         (GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.
1426
1427 2013-11-07  Chris Fleizach  <cfleizach@apple.com>
1428
1429         Modify email order list for James Craig so his primary email is first.
1430
1431         * Scripts/webkitpy/common/config/contributors.json:
1432
1433 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
1434
1435         [Gtk] Disable LTO when building cairo
1436         https://bugs.webkit.org/show_bug.cgi?id=123954
1437
1438         Reviewed by Martin Robinson.
1439
1440         Cairo always uses LTO, when it detects compiler support.
1441         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
1442         default. This patch disables LTO when building cairo library.
1443         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
1444
1445         With gcc 4.7.3, for example, the build fails with the following message:
1446         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
1447
1448         * gtk/jhbuild.modules:
1449
1450 2013-11-07  Samuel White  <samuel_white@apple.com>
1451
1452         AX: DRT AccessibilityUIElement::isFocused methods should be finished.
1453         https://bugs.webkit.org/show_bug.cgi?id=123774
1454
1455         Reviewed by Chris Fleizach.
1456
1457         Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.
1458
1459         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1460         (AccessibilityUIElement::isFocused):
1461         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1462         (WTR::AccessibilityUIElement::isFocused):
1463
1464 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1465
1466         Removed retrieveQMakespecVar function
1467         https://bugs.webkit.org/show_bug.cgi?id=123996
1468
1469         Reviewed by Csaba Osztrogonác.
1470
1471         * Scripts/webkitdirs.pm:
1472
1473 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1474
1475         Removed QMake related filters
1476         https://bugs.webkit.org/show_bug.cgi?id=123992
1477
1478         Reviewed by Csaba Osztrogonác.
1479
1480         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1481         (TestRebaseline.test_rebaseline):
1482         (TestRebaselineExpectations.test_rebaseline_expectations):
1483
1484 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
1485
1486         [Efl] Disable LTO when building cairo
1487         https://bugs.webkit.org/show_bug.cgi?id=123947
1488
1489         Reviewed by Gyuyoung Kim.
1490
1491         Cairo always uses LTO, when it detects compiler support.
1492         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
1493         default. This patch disables LTO when building cairo library.
1494         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
1495
1496         With gcc 4.7.3, for example, the build fails with the following message:
1497         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
1498
1499         * efl/jhbuild.modules:
1500
1501 2013-11-07  Mario Sanchez Prada  <mario.prada@samsung.com>
1502
1503         AX: [ATK] Video and audio elements are not properly exposed
1504         https://bugs.webkit.org/show_bug.cgi?id=123894
1505
1506         Reviewed by Chris Fleizach.
1507
1508         Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.
1509
1510         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
1511         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.
1512
1513 2013-11-07  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1514
1515         Change git_commit_from_svn_revision() to work in a pure git checkout
1516         https://bugs.webkit.org/show_bug.cgi?id=111668
1517
1518         Reviewed by Ryosuke Niwa.
1519
1520         * Scripts/webkitpy/common/checkout/scm/git.py:
1521         (Git.git_commit_from_svn_revision):
1522
1523 2013-11-06  Jer Noble  <jer.noble@apple.com>
1524
1525         Unreviewed webkitpy unit test fix; update baselines after r158765
1526
1527         * Scripts/webkitpy/port/win_unittest.py:
1528         (WinPortTest.test_baseline_search_path):
1529
1530 2013-11-06  Jer Noble  <jer.noble@apple.com>
1531
1532         [Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
1533         https://bugs.webkit.org/show_bug.cgi?id=123905
1534
1535         Reviewed by Brent Fulgham.
1536
1537         Now that the mac-lion results have been removed, the win port should fall back to
1538         the mac-mountainlion results.
1539
1540         * Scripts/webkitpy/port/win.py:
1541         (WinPort.default_baseline_search_path):
1542
1543 2013-11-06  Anders Carlsson  <andersca@apple.com>
1544
1545         Fix a Mountain Lion test failure.
1546
1547         NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.
1548
1549         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1550         (TestWebKitAPI::TEST):
1551
1552 2013-11-06  Krzysztof Czech  <k.czech@samsung.com>
1553
1554         [ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
1555         https://bugs.webkit.org/show_bug.cgi?id=118969
1556
1557         Reviewed by Mario Sanchez Prada.
1558
1559         Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.
1560
1561         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1562         (AccessibilityUIElement::attributesOfChildren):
1563         (AccessibilityUIElement::attributesOfColumnHeaders):
1564         (AccessibilityUIElement::attributesOfRowHeaders):
1565         (AccessibilityUIElement::attributesOfVisibleCells):
1566         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1567         (WTR::AccessibilityUIElement::attributesOfChildren):
1568         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1569         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1570         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1571
1572 2013-11-05  Benjamin Poulain  <benjamin@webkit.org>
1573
1574         [WK2] Add a WebKit2 API for Geolocation's highAccuracy
1575         https://bugs.webkit.org/show_bug.cgi?id=123786
1576
1577         Reviewed by Darin Adler.
1578
1579         Add basic testing for the Geolocation API (start, stop and change accuracy).
1580
1581         * TestWebKitAPI/GNUmakefile.am:
1582         * TestWebKitAPI/PlatformEfl.cmake:
1583         * TestWebKitAPI/PlatformGTK.cmake:
1584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1585         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.
1586         (TestWebKitAPI::operator<<):
1587         (TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
1588         (TestWebKitAPI::GeolocationStateTracker::eventsChanged):
1589         (TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
1590         (TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
1591         (TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
1592         (TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
1593         (TestWebKitAPI::setupGeolocationProvider):
1594         (TestWebKitAPI::setupView):
1595         (TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
1596         (TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
1597         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
1598         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):
1599         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker):
1600         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1601         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker):
1602         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1603         (TestWebKitAPI::didFinishLoadForFrame):
1604         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Added.
1605         * TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Added.
1606         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Added.
1607         * TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Added.
1608         * WebKitTestRunner/GeolocationProviderMock.cpp:
1609         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1610
1611 2013-11-05  Anders Carlsson  <andersca@apple.com>
1612
1613         Implement more NSCoder methods
1614         https://bugs.webkit.org/show_bug.cgi?id=123815
1615
1616         Reviewed by Dan Bernstein.
1617
1618         Add a method that takes an NSArray, an NSDictionary and an NSURLRequest.
1619
1620         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1621         (TestWebKitAPI::TEST):
1622         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
1623         (-[BundleObject testMethodWithArray:dictionary:request:]):
1624         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
1625
1626 2013-11-05  Filip Pizlo  <fpizlo@apple.com>
1627
1628         Update ReducedFTL
1629         https://bugs.webkit.org/show_bug.cgi?id=123805
1630
1631         Reviewed by Sam Weinig.
1632         
1633         - Make ReducedFTL build with debug info.
1634         
1635         - Give ReducedFTL a --loop mode that runs everything in a loop. Great for finding
1636           memory leaks and attaching a profiler.
1637         
1638         - Reorder the passes so that they match the FTL.
1639         
1640         - Make it possible to change the backend opt level and enable the fast isel.
1641
1642         * ReducedFTL/ReducedFTL.c:
1643         (usage):
1644         (roundUpSize):
1645         (mmAllocateCodeSection):
1646         (main):
1647         * ReducedFTL/build.sh:
1648
1649 2013-11-05  Chris Fleizach  <cfleizach@apple.com>
1650
1651         AX: switch DRT AX methods to use nullptr
1652         https://bugs.webkit.org/show_bug.cgi?id=123773
1653
1654         Reviewed by Andreas Kling.
1655
1656         Switch AX related code in DRT and WKTR to use nullptr.
1657
1658         * DumpRenderTree/AccessibilityUIElement.cpp:
1659         (AccessibilityUIElement::startTextMarker):
1660         (AccessibilityUIElement::endTextMarker):
1661         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1662         (findAccessibleObjectById):
1663         (AccessibilityController::accessibleElementById):
1664         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1665         (AccessibilityUIElement::getChildAtIndex):
1666         (AccessibilityUIElement::linkedUIElementAtIndex):
1667         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1668         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1669         (AccessibilityUIElement::disclosedRowAtIndex):
1670         (AccessibilityUIElement::selectedChildAtIndex):
1671         (AccessibilityUIElement::selectedRowAtIndex):
1672         (AccessibilityUIElement::rowAtIndex):
1673         (AccessibilityUIElement::titleUIElement):
1674         (AccessibilityUIElement::parentElement):
1675         (AccessibilityUIElement::disclosedByRow):
1676         (AccessibilityUIElement::stringAttributeValue):
1677         (AccessibilityUIElement::uiElementAttributeValue):
1678         (AccessibilityUIElement::role):
1679         (AccessibilityUIElement::subrole):
1680         (AccessibilityUIElement::roleDescription):
1681         (AccessibilityUIElement::title):
1682         (AccessibilityUIElement::description):
1683         (AccessibilityUIElement::orientation):
1684         (AccessibilityUIElement::stringValue):
1685         (AccessibilityUIElement::language):
1686         (AccessibilityUIElement::helpText):
1687         (AccessibilityUIElement::valueDescription):
1688         (AccessibilityUIElement::speak):
1689         (AccessibilityUIElement::classList):
1690         (AccessibilityUIElement::ariaDropEffects):
1691         (AccessibilityUIElement::rangeForLine):
1692         (AccessibilityUIElement::rangeForPosition):
1693         (AccessibilityUIElement::boundsForRange):
1694         (AccessibilityUIElement::stringForRange):
1695         (AccessibilityUIElement::attributedStringForRange):
1696         (AccessibilityUIElement::uiElementForSearchPredicate):
1697         (AccessibilityUIElement::attributesOfColumnHeaders):
1698         (AccessibilityUIElement::attributesOfRowHeaders):
1699         (AccessibilityUIElement::attributesOfColumns):
1700         (AccessibilityUIElement::attributesOfRows):
1701         (AccessibilityUIElement::attributesOfVisibleCells):
1702         (AccessibilityUIElement::attributesOfHeader):
1703         (AccessibilityUIElement::rowIndexRange):
1704         (AccessibilityUIElement::columnIndexRange):
1705         (AccessibilityUIElement::cellForColumnAndRow):
1706         (AccessibilityUIElement::horizontalScrollbar):
1707         (AccessibilityUIElement::verticalScrollbar):
1708         (AccessibilityUIElement::pathDescription):
1709         (AccessibilityUIElement::selectedTextRange):
1710         (AccessibilityUIElement::url):
1711         (AccessibilityUIElement::textMarkerRangeForElement):
1712         (AccessibilityUIElement::textMarkerForIndex):
1713         (AccessibilityUIElement::previousTextMarker):
1714         (AccessibilityUIElement::nextTextMarker):
1715         (AccessibilityUIElement::stringForTextMarkerRange):
1716         (AccessibilityUIElement::textMarkerRangeForMarkers):
1717         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1718         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1719         (AccessibilityUIElement::endTextMarkerForBounds):
1720         (AccessibilityUIElement::startTextMarkerForBounds):
1721         (AccessibilityUIElement::textMarkerForPoint):
1722         (AccessibilityUIElement::accessibilityElementForTextMarker):
1723         (AccessibilityUIElement::startTextMarker):
1724         (AccessibilityUIElement::endTextMarker):
1725         (AccessibilityUIElement::supportedActions):
1726         (AccessibilityUIElement::mathPostscriptsDescription):
1727         (AccessibilityUIElement::mathPrescriptsDescription):
1728         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1729         (WTR::AccessibilityController::accessibleElementById):
1730         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1731         (WTR::AccessibilityUIElement::startTextMarker):
1732         (WTR::AccessibilityUIElement::endTextMarker):
1733         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1734         (WTR::findAccessibleObjectById):
1735         (WTR::AccessibilityController::accessibleElementById):
1736         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1737         (WTR::AccessibilityUIElement::childAtIndex):
1738         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1739         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1740         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1741         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1742         (WTR::AccessibilityUIElement::rowAtIndex):
1743         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1744         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1745         (WTR::AccessibilityUIElement::titleUIElement):
1746         (WTR::AccessibilityUIElement::parentElement):
1747         (WTR::AccessibilityUIElement::disclosedByRow):
1748         (WTR::AccessibilityUIElement::stringAttributeValue):
1749         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1750         (WTR::AccessibilityUIElement::role):
1751         (WTR::AccessibilityUIElement::subrole):
1752         (WTR::AccessibilityUIElement::roleDescription):
1753         (WTR::AccessibilityUIElement::title):
1754         (WTR::AccessibilityUIElement::description):
1755         (WTR::AccessibilityUIElement::orientation):
1756         (WTR::AccessibilityUIElement::stringValue):
1757         (WTR::AccessibilityUIElement::language):
1758         (WTR::AccessibilityUIElement::helpText):
1759         (WTR::AccessibilityUIElement::valueDescription):
1760         (WTR::AccessibilityUIElement::classList):
1761         (WTR::AccessibilityUIElement::speak):
1762         (WTR::AccessibilityUIElement::ariaDropEffects):
1763         (WTR::AccessibilityUIElement::rangeForLine):
1764         (WTR::AccessibilityUIElement::rangeForPosition):
1765         (WTR::AccessibilityUIElement::boundsForRange):
1766         (WTR::AccessibilityUIElement::stringForRange):
1767         (WTR::AccessibilityUIElement::attributedStringForRange):
1768         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1769         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1770         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1771         (WTR::AccessibilityUIElement::attributesOfColumns):
1772         (WTR::AccessibilityUIElement::attributesOfRows):
1773         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1774         (WTR::AccessibilityUIElement::attributesOfHeader):
1775         (WTR::AccessibilityUIElement::rowIndexRange):
1776         (WTR::AccessibilityUIElement::columnIndexRange):
1777         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1778         (WTR::AccessibilityUIElement::horizontalScrollbar):
1779         (WTR::AccessibilityUIElement::verticalScrollbar):
1780         (WTR::AccessibilityUIElement::selectedTextRange):
1781         (WTR::AccessibilityUIElement::url):
1782         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1783         (WTR::AccessibilityUIElement::previousTextMarker):
1784         (WTR::AccessibilityUIElement::nextTextMarker):
1785         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1786         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1787         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1788         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1789         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1790         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1791         (WTR::AccessibilityUIElement::textMarkerForPoint):
1792         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1793         (WTR::AccessibilityUIElement::textMarkerForIndex):
1794         (WTR::AccessibilityUIElement::startTextMarker):
1795         (WTR::AccessibilityUIElement::endTextMarker):
1796         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1797         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1798         (WTR::AccessibilityUIElement::pathDescription):
1799         (WTR::AccessibilityUIElement::supportedActions):
1800
1801 2013-11-05  László Langó  <laszlo.lango@frontendart.com>
1802
1803         Remove leftover Qt related things from the flakiness_dashboard
1804         https://bugs.webkit.org/show_bug.cgi?id=123800
1805
1806         Reviewed by Anders Carlsson.
1807
1808         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1809         (test):
1810
1811 2013-11-05  Robert Plociennik  <r.plociennik@samsung.com>
1812
1813         [EFL] accessibility/svg-group-element-with-title.html is failing
1814         https://bugs.webkit.org/show_bug.cgi?id=114151
1815
1816         Reviewed by Mario Sanchez Prada.
1817
1818         atk_component_ref_accessible_at_point(), utilized in
1819         AccessibilityUIElement::elementAtPoint(), is expected to 'get a reference to the
1820         accessible child, if one exists, at the coordinate point specified' and not
1821         explicitly return self in case of lack of child elements. This contradicts with
1822         expected behavior of elementAtPoint(). Therefore, elementAtPoint() is
1823         changed to return self regardless of coordinates specified, provided no child
1824         element could be retrieved, effectively mimicing the behaviour of equivalent
1825         Mac implementation in accessibilityHitTest().
1826
1827         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1828         (AccessibilityUIElement::elementAtPoint): Fixed.
1829         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1830         (WTR::AccessibilityUIElement::elementAtPoint): Fixed.
1831
1832 2013-11-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1833
1834         [CSS] Enable css-image-orientation on EFL and GTK ports.
1835         https://bugs.webkit.org/show_bug.cgi?id=123698
1836
1837         Reviewed by Beth Dakin.
1838
1839         r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
1840         when enabling css-image-orientaiton. This fixes those wrong implementation as well as enables it on EFL
1841         and GTK ports by default.
1842
1843         * Scripts/webkitperl/FeatureList.pm:
1844
1845 2013-11-04  Alexey Proskuryakov  <ap@apple.com>
1846
1847         DumpRenderTree should reset its preferences file on launch
1848         https://bugs.webkit.org/show_bug.cgi?id=29751
1849
1850         Reviewed by Dan Bernstein.
1851
1852         Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults
1853         and CFPreferencesCopyAppValue family of functions, it doesn't work with
1854         CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...).
1855
1856         So, now we'll just set defaults in the current application.
1857
1858         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1859         - Delete the defaults.
1860         - Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same.
1861         - The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect.
1862
1863         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
1864         Switched to -setValuesForKeysWithDictionary for consistency.
1865
1866 2013-11-04  Filip Pizlo  <fpizlo@apple.com>
1867
1868         Running FTL tests shouldn't reduce coverage on DFG tests
1869         https://bugs.webkit.org/show_bug.cgi?id=123780
1870
1871         Reviewed by Geoffrey Garen.
1872
1873         * Scripts/run-jsc-stress-tests:
1874
1875 2013-11-04  Anders Carlsson  <andersca@apple.com>
1876
1877         More WKRemoteObjectRegistry work
1878         https://bugs.webkit.org/show_bug.cgi?id=123754
1879
1880         Reviewed by Dan Bernstein.
1881
1882         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1883         (TestWebKitAPI::TEST):
1884         Use the correct bundle test name. Call Util::run.
1885
1886         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
1887         (-[BundleObject sayHello]):
1888         (-[BundleObject testMethodWithString:double:integer:]):
1889         Add BundleObject implementation. Register the bundle object with
1890         the remote object registry. Call _handleMessageWithName:body: on the incoming message.
1891
1892 2013-11-04  Krzysztof Czech  <k.czech@samsung.com>
1893
1894         [EFL] Change ATK version to 2.10.0
1895         https://bugs.webkit.org/show_bug.cgi?id=123727
1896
1897         Reviewed by Mario Sanchez Prada.
1898
1899         Provided new API to retrieve text at a given offset.
1900
1901         * efl/jhbuild.modules:
1902
1903 2013-11-04  Robert Plociennik  <r.plociennik@samsung.com>
1904
1905         [EFL] accessibility/textarea-line-for-index.html is failing
1906         https://bugs.webkit.org/show_bug.cgi?id=112015
1907
1908         Reviewed by Mario Sanchez Prada.
1909
1910         Provided implementation for AccessibilityUIElement::lineForIndex().
1911
1912         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1913         (AccessibilityUIElement::lineForIndex): Implemented.
1914         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1915         (WTR::AccessibilityUIElement::lineForIndex): Implemented.
1916
1917 2013-11-04  Krzysztof Czech  <k.czech@samsung.com>
1918
1919         [EFL] accessibility/button-press-action.html
1920         https://bugs.webkit.org/show_bug.cgi?id=111993
1921
1922         Reviewed by Mario Sanchez Prada.
1923
1924         Provided an implementation for AccessibilityUIElement::isPressActionSupported.
1925
1926         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1927         (AccessibilityUIElement::isPressActionSupported):
1928         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1929         (WTR::AccessibilityUIElement::isPressActionSupported):
1930
1931 2013-11-03  Patrick Gansterer  <paroga@webkit.org>
1932
1933         Add test for ListHashSet::removeLast()
1934         https://bugs.webkit.org/show_bug.cgi?id=121810
1935
1936         Reviewed by Anders Carlsson.
1937
1938         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1939         (TestWebKitAPI::TEST):
1940
1941 2013-11-02  Filip Pizlo  <fpizlo@apple.com>
1942
1943         LLVM assertion failures should funnel into WTF's crash handling
1944         https://bugs.webkit.org/show_bug.cgi?id=123682
1945
1946         Reviewed by Geoffrey Garen.
1947         
1948         Need to disable LLVM's crash overrides so that we can do our own crash overrides.
1949
1950         * Scripts/configure-llvm:
1951
1952 2013-11-01  Andy Estes  <aestes@apple.com>
1953
1954         Teach check-for-webkit-framework-include-consistency to ignore stale iOS Private headers that might exist in build directories due to r158443
1955         https://bugs.webkit.org/show_bug.cgi?id=123636
1956
1957         Reviewed by Andreas Kling.
1958
1959         * Scripts/check-for-webkit-framework-include-consistency:
1960
1961 2013-11-01  Anders Carlsson  <andersca@apple.com>
1962
1963         Begin work on encoding argument types
1964         https://bugs.webkit.org/show_bug.cgi?id=123631
1965
1966         Reviewed by Dan Bernstein.
1967
1968         Add another test method.
1969
1970         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1971         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
1972
1973 2013-11-01  Afonso R. Costa Jr.  <afonso.costa@samsung.com>
1974
1975         Expose setApplicationCacheOriginQuota via window.internals
1976         https://bugs.webkit.org/show_bug.cgi?id=87838
1977
1978         Reviewed by Joseph Pecoraro.
1979
1980         * DumpRenderTree/TestRunner.cpp: Move setApplicationCacheOriginQuota
1981         to window.internals
1982         (TestRunner::staticFunctions):
1983         * DumpRenderTree/TestRunner.h: Ditto.
1984         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setApplicationCacheOriginQuota.
1985         * DumpRenderTree/efl/TestRunnerEfl.cpp: Ditto.
1986         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Ditto.
1987         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
1988         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1989         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Ditto.
1990         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
1991         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1992
1993 2013-10-31  Mark Lam  <mark.lam@apple.com>
1994
1995         REGRESSION: Crashes in -[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:].
1996         https://bugs.webkit.org/show_bug.cgi?id=123383.
1997
1998         Reviewed by Geoffrey Garen.
1999
2000         Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
2001         added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
2002         tests to set appropriate quota settings to exercise quota expansion tests
2003         when needed.
2004
2005         * DumpRenderTree/TestRunner.cpp:
2006         (TestRunner::TestRunner):
2007         (getDatabaseDefaultQuotaCallback):
2008         (getDatabaseMaxQuotaCallback):
2009         (setDatabaseDefaultQuotaCallback):
2010         (setDatabaseMaxQuotaCallback):
2011         (TestRunner::staticValues):
2012         * DumpRenderTree/TestRunner.h:
2013         (TestRunner::databaseDefaultQuota):
2014         (TestRunner::setDatabaseDefaultQuota):
2015         (TestRunner::databaseMaxQuota):
2016         (TestRunner::setDatabaseMaxQuota):
2017         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2018         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
2019         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2020         (onExceededDatabaseQuota):
2021         * DumpRenderTree/mac/UIDelegate.mm:
2022         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2023         * DumpRenderTree/win/UIDelegate.cpp:
2024         (UIDelegate::exceededDatabaseQuota):
2025         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2026         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2027         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
2028         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2029         (WTR::TestRunner::TestRunner):
2030         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2031         (WTR::TestRunner::databaseDefaultQuota):
2032         (WTR::TestRunner::setDatabaseDefaultQuota):
2033         (WTR::TestRunner::databaseMaxQuota):
2034         (WTR::TestRunner::setDatabaseMaxQuota):
2035         * WebKitTestRunner/TestController.cpp:
2036         (WTR::TestController::createOtherPage):
2037         (WTR::TestController::createWebViewWithOptions):
2038
2039 2013-10-31  Anders Carlsson  <andersca@apple.com>
2040
2041         Add a WKRemoteObject class
2042         https://bugs.webkit.org/show_bug.cgi?id=123586
2043
2044         Reviewed by Dan Bernstein.
2045
2046         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2047         (TestWebKitAPI::TEST):
2048         Add a conformsToProtocol: test.
2049
2050 2013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
2051
2052         build.webkit.org should have a clean build button
2053         https://bugs.webkit.org/show_bug.cgi?id=123559
2054
2055         Reviewed by Darin Adler.
2056
2057         Add a new "clean" forced scheduler. When a build was created by this scheduler, CleanBuildIfScheduled
2058         step executes clean-build script that removes the WebKitBuild directory.
2059
2060         Also added make-passwords-json.py which creates a fake passwords.json from config.json for testing purposes.
2061
2062         * BuildSlaveSupport/build.webkit.org-config/make-passwords-json.py: Added.
2063         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2064         (CleanBuildIfScheduled): Added.
2065         (CleanBuildIfScheduled.start): Added. Don't do a clean build if if this build wasn't schecueld by
2066         the clean build scheduler.
2067         (DeleteStaleBuildFiles): Added.
2068         (DeleteStaleBuildFiles.start): Added. Don't delete stale build files if this build was scheduled by
2069         the clean build scheduler since everything in the WebKitBuild directory had already been removed.
2070         (Factory.__init__): Always add CleanBuildIfScheduled.  The step itself checks whether to run
2071         clean-build script or hide itself.
2072         (loadBuilderConfig): Added the new clean build scheduler. Also make ForceScheduler future proof; in newer
2073         versions of buildbot, builderNames needs to be a list of regular strings.
2074         * BuildSlaveSupport/clean-build: Added.
2075
2076 2013-10-31  Filip Pizlo  <fpizlo@apple.com>
2077
2078         Remove CachedTranscendentalFunction because caching math functions is an ugly idea
2079         https://bugs.webkit.org/show_bug.cgi?id=123574
2080
2081         Reviewed by Mark Hahnenberg.
2082
2083         Make it easier to see that a test doesn't have an -expected file.
2084
2085         * Scripts/run-jsc-stress-tests:
2086
2087 2013-10-31  Tamas Gergely  <gertom@inf.u-szeged.hu>
2088
2089         Run tests as if they are expected to pass when --force is given.
2090         https://bugs.webkit.org/show_bug.cgi?id=112890
2091
2092         Reviewed by Ryosuke Niwa.
2093
2094         The --force switch of new-run-webkit-tests is now forces all tests to
2095         be run with 'PASS' as expected result.
2096
2097         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2098         (Manager.run):
2099         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2100         (TestExpectations.__init__):
2101         (TestExpectations._add_expectations):
2102         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2103         (parse_args):
2104         (_set_up_derived_options):
2105
2106 2013-10-31  Geoffrey Garen  <ggaren@apple.com>
2107
2108         Added Mark Lam as a reviewer.
2109
2110         Unreviewed.
2111
2112         * Scripts/webkitpy/common/config/contributors.json:
2113
2114 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
2115
2116         Teach the style checker about ENUM_CLASS
2117         https://bugs.webkit.org/show_bug.cgi?id=123528
2118
2119         Reviewed by Andy Estes.
2120
2121         * Scripts/webkitpy/style/checkers/cpp.py:
2122         (_EnumState.process_clean_line): Make content of an ENUM_CLASS declaration
2123         equivalent to enum content for checking.
2124         (check_braces): Allow semicolon at the end.
2125
2126         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2127         (NoNonVirtualDestructorsTest.test_enum_casing):
2128         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon):
2129         (WebKitStyleTest.test_braces):
2130         Test it.
2131
2132 2013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
2133
2134         kill-old-processes should kill Web Socket script
2135         https://bugs.webkit.org/show_bug.cgi?id=123546
2136
2137         Reviewed by Benjamin Poulain.
2138
2139         * BuildSlaveSupport/kill-old-processes:
2140         (main):
2141
2142 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
2143
2144         Set svn:ignore for .pyc files created for test-webkitpy.
2145
2146         * Scripts/webkitpy/layout_tests/reftests: Added property svn:ignore.
2147         * Scripts/webkitpy/performance_tests: Added property svn:ignore.
2148         * Scripts/webkitpy/to_be_moved: Added property svn:ignore.
2149         * Scripts/webkitpy/w3c: Added property svn:ignore.
2150
2151 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
2152
2153         85 inspector tests asserting in DrawingAreaProxyImpl::updateAcceleratedCompositingMode()
2154         when there is a stale WebKitTestRunner preference
2155         https://bugs.webkit.org/show_bug.cgi?id=115115
2156
2157         Reviewed by Darin Adler.
2158
2159         Delete stale preferences on launch.
2160
2161         * WebKitTestRunner/TestController.h:
2162         * WebKitTestRunner/TestController.cpp:
2163         (WTR::TestController::initialize): Now that we don't have preferences stored from
2164         the previous run, we need th reinstate them before creating a WKView. Not all preferences
2165         can be applied to an existing view retroactively.
2166         (WTR::TestController::resetPreferencesToConsistentValues): Split out of resetStateToConsistentValues,
2167         because there is no injected bundle yet when calling this function from initialize().
2168
2169         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): Delete
2170         the preferences.
2171
2172         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2173         Added some FIXMEs.
2174
2175 2013-10-30  Anders Carlsson  <andersca@apple.com>
2176
2177         Try to fix the 32-bit build.
2178         
2179         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2180         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
2181
2182 2013-10-30  Anders Carlsson  <andersca@apple.com>
2183
2184         Begin fleshing out an API test for WKRemoteObjectRegistry
2185         https://bugs.webkit.org/show_bug.cgi?id=123531
2186
2187         Reviewed by Andreas Kling.
2188
2189         Add a very simple test that doesn't really test anything for now.
2190
2191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2192         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Added.
2193         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Added.
2194         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Added.
2195
2196 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
2197
2198         Remove unnecessary touch
2199
2200         Rubber stamped by Mark Hahnenberg.
2201
2202         * Scripts/run-jsc-stress-tests:
2203
2204 2013-10-30  Samuel White  <samuel_white@apple.com>
2205
2206         AX: Add samuel_white@apple.com to accessibility watchlist cc rules
2207         https://bugs.webkit.org/show_bug.cgi?id=123515
2208
2209         Reviewed by Chris Fleizach.
2210
2211         Adding myself and jcraig@apple.com (per his request) to the accessibility watchlist. Also
2212         updating contributors.json with permission from bweinstein@apple.com to make this possible.
2213
2214         * Scripts/webkitpy/common/config/contributors.json:
2215         * Scripts/webkitpy/common/config/watchlist:
2216
2217 2013-10-30  Patrick Gansterer  <paroga@webkit.org>
2218
2219         [WIN] Add executable entry points to DRT and WinLauncher
2220         https://bugs.webkit.org/show_bug.cgi?id=121837
2221
2222         Reviewed by Brent Fulgham.
2223
2224         This allows to compile and run the executables without DLLLauncher.
2225
2226         * DumpRenderTree/win/DumpRenderTree.cpp:
2227         (main):
2228         (dllLauncherEntryPoint):
2229         * WinLauncher/WinLauncher.cpp:
2230         (wWinMain):
2231         (dllLauncherEntryPoint):
2232
2233 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
2234
2235         run-jsc-stress-tests should handle ".." in paths and "slow!" in cmd's
2236         https://bugs.webkit.org/show_bug.cgi?id=123521
2237
2238         Reviewed by Mark Hahnenberg.
2239
2240         * Scripts/run-jsc-stress-tests:
2241
2242 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
2243
2244         Mavericks: 128 tests are failing due to pixel differences
2245         https://bugs.webkit.org/show_bug.cgi?id=123488
2246
2247         Reviewed by Simon Fraser.
2248
2249         Apple font preferences cannot be fully reset after they've been read, so we
2250         need to set them using CFPreferences before initializing NSApplication.
2251
2252         In theory, this should be an issue on WebKit2 as well, but somehow it doesn't
2253         appear to be. I guess we can figure out the reasons for this difference when/if
2254         any observable problems start to occur.
2255
2256         * DumpRenderTree/mac/DumpRenderTree.mm:
2257         (setDefaultsToConsistentValuesForTesting): Only set defaults here, move other work
2258         to prepareConsistentTestingEnvironment().
2259         (main): Call setDefaultsToConsistentValuesForTesting before [NSApplication sharedApplication]
2260         (which is unnecessary anyway since NSUserDefaults will implicitly call it, but seems
2261         useful to keep in case we change out approach to defaults again).
2262
2263 2013-10-29  Andy Estes  <aestes@apple.com>
2264
2265         Teach the style checker how to handle Objective-C categories and NS_ENUM
2266         https://bugs.webkit.org/show_bug.cgi?id=123482
2267
2268         Reviewed by Dan Bernstein.
2269
2270         * Scripts/webkitpy/style/checkers/cpp.py:
2271         (check_spacing_for_function_call): Allow a space before '(' in a line
2272         starting with @interface or @implementation, since this is defining an
2273         Objective-C category rather than a function.
2274         (check_braces): The opening brace of an NS_ENUM should not be on its
2275         own line.
2276         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests.
2277
2278 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
2279
2280         [EFL] accessibility/textarea-selected-text-range.html is failing
2281         https://bugs.webkit.org/show_bug.cgi?id=112016
2282
2283         Reviewed by Mario Sanchez Prada.
2284
2285         Provided implementation for AccessibilityUIElement::selectedTextRange() and
2286         AccessibilityUIElement::setSelectedTextRange().
2287
2288         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2289         (AccessibilityUIElement::selectedTextRange): Implemented.
2290         (AccessibilityUIElement::setSelectedTextRange): Implemented
2291         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2292         (WTR::AccessibilityUIElement::selectedTextRange): Implemented.
2293         (WTR::AccessibilityUIElement::setSelectedTextRange): Implemented.
2294
2295 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
2296
2297         [GTK] accessibility/svg-remote-element.html is failing
2298         https://bugs.webkit.org/show_bug.cgi?id=101185
2299
2300         Reviewed by Chris Fleizach.
2301
2302         Implemented missing methods by mimicing existing functionality in
2303         AccessibilityObject::clickPoint() using available ATK API.
2304
2305         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2306         (AccessibilityUIElement::clickPointX): Implemented.
2307         (AccessibilityUIElement::clickPointY): Implemented.
2308         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2309         (WTR::AccessibilityUIElement::clickPointX): Implemented.
2310         (WTR::AccessibilityUIElement::clickPointY): Implemented.
2311
2312 2013-10-30  Tamas Gergely  <gertom@inf.u-szeged.hu>
2313
2314         Removed Windows platform configurations from WebKitTestRunner.
2315         https://bugs.webkit.org/show_bug.cgi?id=123152
2316
2317         Reviewed by Csaba Osztrogonác.
2318
2319         Removed Windows specific parts from the source files, Windows specific
2320         subdirectory (win) and Visual Studio property files from the WebKitTestRunner,
2321         as the platform is no longer supported by this tool.
2322
2323         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Removed.
2324         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Removed.
2325         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Removed.
2326         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Removed.
2327         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Removed.
2328         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Removed.
2329         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
2330         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2331         (WTR::AccessibilityController::rootElement):
2332         (WTR::AccessibilityController::focusedElement):
2333         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2334         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2335         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2336         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2337         * WebKitTestRunner/PlatformWebView.h:
2338         * WebKitTestRunner/TestController.cpp:
2339         (WTR::TestController::initialize):
2340         * WebKitTestRunner/TestInvocation.cpp:
2341         (WTR::createWKURL):
2342         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2343         * WebKitTestRunner/config.h:
2344         * WebKitTestRunner/win/InjectedBundle.vcproj: Removed.
2345         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Removed.
2346         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Removed.
2347         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Removed.
2348         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Removed.
2349         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Removed.
2350         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Removed.
2351         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Removed.
2352         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Removed.
2353         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Removed.
2354         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Removed.
2355         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Removed.
2356         * WebKitTestRunner/win/TestControllerWin.cpp: Removed.
2357         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
2358         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed.
2359         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Removed.
2360         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Removed.
2361         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Removed.
2362         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Removed.
2363         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Removed.
2364         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Removed.
2365         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Removed.
2366         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Removed.
2367         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Removed.
2368         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Removed.
2369         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Removed.
2370         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Removed.
2371         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Removed.
2372         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Removed.
2373         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Removed.
2374         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Removed.
2375         * WebKitTestRunner/win/build-generated-files.sh: Removed.
2376         * WebKitTestRunner/win/main.cpp: Removed.
2377
2378 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
2379
2380         Result of focus-option-control-on-page.html depends on system preferences
2381         https://bugs.webkit.org/show_bug.cgi?id=123304
2382
2383         Reviewed by Simon Fraser.
2384
2385         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2386         Override a preference that WebKit reads to decide what Tab does, so that current
2387         user default doesn't affect tests.
2388
2389         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
2390         Ditto.
2391
2392 2013-10-29  Filip Pizlo  <fpizlo@apple.com>
2393
2394         It should be possible to specify extra tests to run-javascriptcore-tests
2395         https://bugs.webkit.org/show_bug.cgi?id=123495
2396
2397         Reviewed by Oliver Hunt.
2398         
2399         This adds two ways to specify additional tests: the option --extra-tests=<blah>, and
2400         the environment variable EXTRA_JSC_TESTS.
2401         
2402         Those two values (the command-line option and the environment variable) are passed
2403         as extra arguments to run-jsc-stress-tests.
2404         
2405         To make this extra super useful, run-jsc-stress-tests now allows yaml configuration
2406         files to be recursive: if a "- collection:" line is found, the string is handled
2407         just as if it was a command-line argument. This allows you to use --extra-tests=file
2408         where file contains a bunch of "- collection:" lines, and this is equivalent to each
2409         of those lines being a command-line argument.
2410
2411         * Scripts/run-javascriptcore-tests:
2412         * Scripts/run-jsc-stress-tests:
2413
2414 2013-10-29  Ryosuke Niwa  <rniwa@webkit.org>
2415
2416         Add Mavericks builders to the old flakiness dashboard.
2417
2418         * TestResultServer/static-dashboards/builders.jsonp:
2419         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2420
2421 2013-10-29  Seokju Kwon  <seokju@webkit.org>
2422
2423         Fix memory leak in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
2424         https://bugs.webkit.org/show_bug.cgi?id=123478
2425
2426         Reviewed by Anders Carlsson.
2427
2428         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2429         (NPP_Destroy): Add a missing free() for 'obj->evaluateScriptOnMouseDownOrKeyDown'.
2430
2431 2013-10-29  Lucas Forschler  <lforschler@apple.com>
2432
2433         Move the SEO bots from testers to archivers.
2434         
2435         Unreviewed.
2436         
2437         * BuildSlaveSupport/build.webkit.org-config/config.json:
2438
2439 2013-10-29  Hugo Parente Lima  <hugo.lima@openbossa.org>
2440
2441         Adding Nix files in Source/Platform to trunk
2442         https://bugs.webkit.org/show_bug.cgi?id=118331
2443
2444         Reviewed by Benjamin Poulain.
2445
2446         Add a special rule for Nix API files located at Source/Platform/nix.
2447
2448         * Scripts/webkitpy/style/checker.py:
2449
2450  2013-10-29  Nadav Rotem  <nrotem@apple.com>
2451  
2452          Add myself as a comitter.
2453          https://bugs.webkit.org/show_bug.cgi?id=123455
2454  
2455          Reviewed by Anders Carlsson.
2456  
2457          * Scripts/webkitpy/common/config/contributors.json:
2458  
2459 2013-10-29  Lucas Forschler  <lforschler@apple.com>
2460
2461         Teach the WebKit2 testers to abort early by setting the shouldAbortEarly property to True.
2462         https://bugs.webkit.org/show_bug.cgi?id=123450
2463
2464         Reviewed by Alexey Proskuryakov.
2465
2466         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2467         (RunWebKit2Tests.start):
2468
2469 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
2470
2471         [Mac] Rationalize user defaults override code
2472         https://bugs.webkit.org/show_bug.cgi?id=123436
2473
2474         Reviewed by Dan Bernstein.
2475
2476         * DumpRenderTree/mac/DumpRenderTree.mm:
2477         (resetWebPreferencesToConsistentValues): Renamed from resetDefaultsToConsistentValues,
2478         because this function only resets WebPreferences now.
2479         (setDefaultsToConsistentValuesForTesting): Moved code for setting the defaults
2480         here, because tests never change them, and they only need to be set once, not
2481         before each test. Removed long obsolete workaround for HIToolbox preferences.
2482         Don't call resetWebPreferencesToConsistentValues, because it will be called before
2483         the first test anyway.
2484         (main): Don't set AppleMagnifiedMode here, moved that to setDefaultsToConsistentValuesForTesting.
2485         (resetWebViewToConsistentStateBeforeTesting): Moved TestRunner::setSerializeHTTPLoads
2486         and setlocale calls out of resetWebPreferencesToConsistentValues().
2487         Added AppleAquaAntiAliasingChanged notification that we had in WK2, because it's
2488         also needed in WK1.
2489
2490         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2491         (WTR::InjectedBundle::platformInitialize): Use literal syntax for defaults
2492         dictionary.
2493
2494         * WebKitTestRunner/mac/main.mm:
2495         (setDefaultsToConsistentValuesForTesting): Factored out of main(), and changed to
2496         use NSArgumentDomain for everything.
2497
2498 2013-10-29  Philippe Normand  <pnormand@igalia.com>
2499
2500         [GTK] enable media-stream in build-webkit
2501         https://bugs.webkit.org/show_bug.cgi?id=123144
2502
2503         Reviewed by Martin Robinson.
2504
2505         * Scripts/webkitperl/FeatureList.pm: Enable media-stream build
2506         for the GTK+ port.
2507
2508 2013-10-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2509
2510         EFL 32 bit buildbot doesn't work on dashboard
2511         https://bugs.webkit.org/show_bug.cgi?id=123435
2512
2513         Reviewed by Csaba Osztrogonác.
2514
2515         32 bit buildbot doesn't work on dashboard because name is different from buildbot list.
2516
2517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2518         (WebKitBuildbot):
2519
2520 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2521
2522         Floating left the header broke other pages, and this CSS has no way to customize
2523         per-page.
2524
2525         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2526
2527 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2528
2529         Remove underlines on the bot names in the header.
2530         
2531         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2532         (td.LastBuild a):
2533
2534 2013-10-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2535
2536         Add EFL release bots to the buildbot dashboard
2537         https://bugs.webkit.org/show_bug.cgi?id=123430
2538
2539         Reviewed by Darin Adler.
2540
2541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added.
2542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2543         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder.
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2545         (table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line.
2546
2547 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2548
2549         More waterfall tweaking.
2550
2551         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2552         (body > .header):
2553         (td.LastBuild):
2554         (td.LastBuild a):
2555         (td.LastBuild,td.Activity a,td.Change a,td.Builder a):
2556
2557 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2558
2559         More waterfall tweaking.
2560
2561         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2562         (body.interface):
2563         (body > hr):
2564         (div.content h1):
2565         (body > .header):
2566         (td.Activity a,td.Change a,td.Builder a):
2567         (td.Builder):
2568
2569 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2570
2571         Apply changes to default.css, revert buildbot.css which seems to be unused.
2572
2573         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
2574         (body):
2575         (body, td):
2576         (a:link,a:visited,a:active):
2577         (td.Time):
2578         (td.Activity):
2579         (.exception, td.offline):
2580         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2581         (body.interface):
2582         (.auth):
2583         (td.LastBuild):
2584         (td.Time):
2585         (td.Activity):
2586         (.offline,td.offline,.retry):
2587
2588 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2589
2590         Prettify the waterfall page, and make it a little more space-efficient.
2591         
2592         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
2593         (body, td):
2594         (body.interface):
2595         (.auth):
2596         (.header):
2597         (div.content h1):
2598         (a):
2599         (a:link,a:active):
2600         (a:link,a:visited,a:active):
2601         (td.LastBuild):
2602         (td.Time):
2603         (td.Activity):
2604         (.exception, td.offline, .retry):
2605
2606 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2607
2608         Fix Lion readableName (spotted by Dan Bernstein).
2609
2610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2611
2612 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2613
2614         Add tooltips to the platform icons in Dashboard
2615         https://bugs.webkit.org/show_bug.cgi?id=123429
2616
2617         Reviewed by Alexey Proskuryakov.
2618         
2619         Add a human readable name to Buildbot.Platform entries, and use it to
2620         show a tooltip on the ring image.
2621
2622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2624         (documentReady):
2625
2626 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2627
2628         Allow explicit sort order for Dashboard platforms
2629         https://bugs.webkit.org/show_bug.cgi?id=123419
2630
2631         Reviewed by Tim Hatcher.
2632         
2633         Assign a specific sort order to Dashboard platforms, rather than
2634         just using object property order.
2635
2636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2638         (BuildbotQueue):
2639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2640         (documentReady):
2641
2642 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
2643
2644         Tidy up main http://build.webkit.org page
2645         https://bugs.webkit.org/show_bug.cgi?id=123413
2646
2647         Reviewed by Alexey Proskuryakov.
2648         
2649         Break the list of links into sections. Add some font style.
2650
2651         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2652
2653 2013-10-28  Myles C. Maxfield  <mmaxfield@apple.com>
2654
2655         Parsing support for -webkit-text-decoration-skip: ink
2656         https://bugs.webkit.org/show_bug.cgi?id=123358
2657
2658         Reviewed by Dean Jackson.
2659
2660         Adding ENABLE(CSS3_TEXT_DECORATION)
2661
2662         * Scripts/webkitperl/FeatureList.pm:
2663
2664 2013-10-28  Lucas Forschler  <lforschler@apple.com>
2665
2666         Add additional Apple Mavericks test bots.
2667         
2668         Unreviewed.
2669         
2670         * BuildSlaveSupport/build.webkit.org-config/config.json:
2671
2672 2013-10-28  Bastien Nocera <hadess@hadess.net>
2673
2674         Name all the GLib timeout sources
2675         https://bugs.webkit.org/show_bug.cgi?id=123229
2676
2677         Reviewed by Anders Carlsson.
2678
2679         Give a name to GLib timeout sources, this is helpful when
2680         profiling WebKitGTK applications.
2681
2682 2013-10-28  Bastien Nocera <hadess@hadess.net>
2683
2684         Replace 0 timeouts g_timeout_add() by g_idle_add()
2685         https://bugs.webkit.org/show_bug.cgi?id=123260
2686
2687         Reviewed by Carlos Garcia Campos.
2688
2689         A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
2690         without the nagging feeling that the wrong API was used.
2691
2692         * DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
2693         of 0-timer.
2694         (topLoadingFrameLoadFinished):
2695         * DumpRenderTree/gtk/EventSender.cpp: Ditto.
2696         (scheduleAsynchronousClickCallback):
2697         (scheduleAsynchronousKeyDownCallback):
2698
2699 2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
2700
2701         [GTK] [WebKit2] CanHandleRequest API test fails
2702         https://bugs.webkit.org/show_bug.cgi?id=88453
2703
2704         Reviewed by Martin Robinson.
2705
2706         * Scripts/run-gtk-tests:
2707         (TestRunner):
2708
2709 2013-10-25  Ryosuke Niwa  <rniwa@webkit.org>
2710
2711         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
2712
2713         * Scripts/webkitpy/port/base.py:
2714         (Port.repository_paths):
2715
2716 2013-10-25  Jer Noble  <jer.noble@apple.com>
2717
2718         [WTF] Add a multiplication operator (and a few others) to MediaTime
2719         https://bugs.webkit.org/show_bug.cgi?id=123137
2720
2721         Reviewed by Eric Carlson.
2722
2723         Add tests for new MediaTime operators.
2724
2725         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2726         (TestWebKitAPI::TEST):
2727
2728 2013-10-24  Mark Rowe  <mrowe@apple.com>
2729
2730         Remove references to OS X 10.7 from Xcode configuration settings.
2731
2732         Now that we're not building for OS X 10.7 they're no longer needed.
2733
2734         Reviewed by Anders Carlsson.
2735
2736         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2737         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2738         * MiniBrowser/Configurations/Base.xcconfig:
2739         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2740         * TestWebKitAPI/Configurations/Base.xcconfig:
2741         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2742         * WebKitLauncher/Configurations/Base.xcconfig:
2743         * WebKitTestRunner/Configurations/Base.xcconfig:
2744         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2745
2746 2013-10-24  Mark Rowe  <mrowe@apple.com>
2747
2748         <rdar://problem/15312643> Prepare for the mysterious future.
2749
2750         Reviewed by David Kilzer.
2751
2752         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2753         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2754         * MiniBrowser/Configurations/Base.xcconfig:
2755         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2756         * TestWebKitAPI/Configurations/Base.xcconfig:
2757         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2758         * WebKitLauncher/Configurations/Base.xcconfig:
2759         * WebKitTestRunner/Configurations/Base.xcconfig:
2760         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2761
2762 2013-10-24  Daniel Bates  <dabates@apple.com>
2763
2764         Crash in WebCore::NavigationScheduler::startTimer()
2765         https://bugs.webkit.org/show_bug.cgi?id=123288
2766         <rdar://problem/14055644>
2767
2768         Reviewed by Alexey Proskuryakov.
2769
2770         Add API test.
2771
2772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2773         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
2774         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
2775
2776 2013-10-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2777
2778         [GTK] Disable css-image-orientation
2779         https://bugs.webkit.org/show_bug.cgi?id=123257
2780
2781         Reviewed by Martin Robinson.
2782
2783         CSS image orientation isn't stable yet. So, test regression happen since r157909.
2784         This feature should be enabled again after it is stable.
2785
2786         * Scripts/webkitperl/FeatureList.pm:
2787
2788 2013-10-24  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2789
2790         Fix argument passing for jhbuild.
2791         https://bugs.webkit.org/show_bug.cgi?id=123253
2792
2793         Reviewed by Gustavo Noronha Silva.
2794
2795         The update-webkit-libs-jhbuild previously didn't allowed
2796         extra arguments to be passed to jhbuild.
2797
2798         * Scripts/update-webkit-libs-jhbuild:
2799         (runJhbuild):
2800         * Scripts/update-webkitefl-libs:
2801
2802 2013-10-24  Sanghyup Lee  <sh53.lee@samsung.com>
2803
2804         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
2805         https://bugs.webkit.org/show_bug.cgi?id=123251
2806
2807         Reviewed by Csaba Osztrogonác.
2808
2809         Replace %llu by PRIu64 macro to print an uint64_t value and silent a
2810         compilation warning on 64-Bit.
2811
2812         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2813         (onExceededDatabaseQuota):
2814
2815 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
2816
2817         [EFL] Build break with latest EFL 1.8 libraries.
2818         https://bugs.webkit.org/show_bug.cgi?id=123245
2819
2820         Reviewed by Gyuyoung Kim.
2821
2822         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
2823         Eo typedef and splitted header files which contain version macro.
2824
2825         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
2826         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2827         * WebKitTestRunner/PlatformWebView.h: Ditto.
2828
2829 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2830
2831         [GObject bindings] Make EventTarget interface introspectable
2832         https://bugs.webkit.org/show_bug.cgi?id=77835
2833
2834         Reviewed by Gustavo Noronha Silva.
2835
2836         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
2837         GObject DOM bindings headers.
2838
2839 2013-10-23  Lucas Forschler  <lforschler@apple.com>
2840
2841         Add two more mac bots to the Mavericks Test Queue.
2842         
2843         Unreviewed.
2844         
2845         * BuildSlaveSupport/build.webkit.org-config/config.json:
2846
2847 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
2848
2849         Have a way of dealing with slow tests in run-jsc-stress-tests
2850         https://bugs.webkit.org/show_bug.cgi?id=123221
2851
2852         Reviewed by Mark Hahnenberg.
2853         
2854         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
2855         rather than appended to it. This means that slow tests get queued up first and are less likely
2856         to block completion.
2857
2858         * Scripts/run-jsc-stress-tests:
2859
2860 2013-10-23  Alex Christensen  <achristensen@webkit.org>
2861
2862         Explicitly build Win32 or x64 configuration on Windows.
2863         https://bugs.webkit.org/show_bug.cgi?id=123206
2864
2865         Reviewed by Brent Fulgham.
2866
2867         * Scripts/webkitdirs.pm:
2868         (jscPath):
2869         (determineConfigurationForVisualStudio):
2870         (determinePassedConfiguration):
2871         Add |Win32 to the end of 32-bit Visual Studio build configurations.
2872         (safariPath):
2873         * Scripts/build-webkit:
2874         * Scripts/old-run-webkit-tests:
2875         * Scripts/run-api-tests:
2876         (testToolPath):
2877         * Scripts/run-javascriptcore-tests:
2878         (testapiPath):
2879         * Scripts/run-regexp-tests:
2880         (testapiPath):
2881         * Scripts/sunspider-compare-results:
2882         (pathToBuiltJSC):
2883         Use configuration instead of configurationForVisualStudio, which are now always different.
2884
2885 2013-10-23  Mark Lam  <mark.lam@apple.com>
2886
2887         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
2888         https://bugs.webkit.org/show_bug.cgi?id=123131.
2889
2890         Reviewed by Geoffrey Garen.
2891
2892         Updated these files to allow database quotas to grow within a limit for
2893         testing purposes.
2894
2895         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2896         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
2897         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2898         (onExceededDatabaseQuota):
2899         * DumpRenderTree/mac/UIDelegate.mm:
2900         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
2901         * DumpRenderTree/win/UIDelegate.cpp:
2902         (UIDelegate::exceededDatabaseQuota):
2903         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2904         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
2905         * WebKitTestRunner/TestController.cpp:
2906         (WTR::exceededDatabaseQuota):
2907
2908 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
2909
2910         It's valid to have a build ID of 0.
2911
2912         Reviewed by Tim Hatcher.
2913
2914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2915         (BuildbotIteration):
2916
2917 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
2918
2919         Remove Lion bots from the Dashboard.
2920
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2922         (WebKitBuildbot):
2923
2924 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
2925
2926         [GTK] Expose image links properly
2927         https://bugs.webkit.org/show_bug.cgi?id=84044
2928
2929         Reviewed by Chris Fleizach.
2930
2931         Expose the accessible URL if present, as yet another attribute
2932         for the AccessibilityUIElement wrapper. For coherence with what
2933         the Mac port does (and what you would expect as the output of
2934         the layout test), we strip the absolute URL path for relative
2935         references, if it's the case, leaving the base of the URL path
2936         out of the exposed string.
2937
2938         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2939         (attributesOfElement): Print the AXURL, if available.
2940         (AccessibilityUIElement::url): Expose the URL if present. That
2941         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
2942         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2943         (attributesOfElement): Print the AXURL, if available.
2944         (WTR::AccessibilityUIElement::url): Expose the URL if present.
2945         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
2946
2947 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
2948
2949         Remove Lion bots.
2950
2951         * BuildSlaveSupport/build.webkit.org-config/config.json:
2952
2953 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
2954
2955         Dashboard repaints constantly
2956         https://bugs.webkit.org/show_bug.cgi?id=122133
2957
2958         Reviewed by Tim Horton.
2959         
2960         Pulsing shadows are really bad for battery life.
2961
2962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2963         (.status-line.bad .bubble):
2964         (.status-line.bad .message):
2965
2966 2013-10-22  Commit Queue  <commit-queue@webkit.org>
2967
2968         Unreviewed, rolling out r157835.
2969         http://trac.webkit.org/changeset/157835
2970         https://bugs.webkit.org/show_bug.cgi?id=123192
2971
2972         broke 32-bit builds (Requested by smfr on #webkit).
2973
2974         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2975         (TestWebKitAPI::TEST):
2976
2977 2013-10-22  Jer Noble  <jer.noble@apple.com>
2978
2979         [WTF] Add a multiplication operator (and a few others) to MediaTime
2980         https://bugs.webkit.org/show_bug.cgi?id=123137
2981
2982         Reviewed by Eric Carlson.
2983
2984         Add tests for new MediaTime operators.
2985
2986         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2987         (TestWebKitAPI::TEST):
2988
2989 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
2990
2991         Educate webkitpy about Mavericks.
2992
2993         Reviewed by Ryosuke Niwa.
2994
2995         * Scripts/webkitpy/common/system/platforminfo.py:
2996         (PlatformInfo._determine_mac_version):
2997         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2998         (TestPlatformInfo.test_os_version):
2999         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3000         (TestExpectationParser):
3001         * Scripts/webkitpy/port/builders.py:
3002         * Scripts/webkitpy/port/mac.py:
3003         (MacPort):
3004         * Scripts/webkitpy/port/mac_unittest.py:
3005         (test_versions):
3006         (test_baseline_search_path):
3007         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3008         (TestRebaselineTest.test_baseline_directory):
3009         (TestRebaselineExpectations.test_rebaseline_expectations):
3010
3011 2013-10-22  Stephanie Lewis  <slewis@apple.com>
3012
3013         Update the build trigger list for Mavericks.
3014
3015         Unreviewed.
3016
3017         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3018         (_should_file_trigger_build):
3019
3020 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
3021
3022         Add Mavericks bots to the dashboard.
3023
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3025         (WebKitBuildbot):
3026
3027 2013-10-22  Samuel White  <samuel_white@apple.com>
3028
3029         AX: Add paramAttrs to fetch start and end text markers in a given rect.
3030         https://bugs.webkit.org/show_bug.cgi?id=122164
3031
3032         Reviewed by Chris Fleizach.
3033
3034         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
3035
3036         * DumpRenderTree/AccessibilityUIElement.cpp:
3037         (endTextMarkerForBoundsCallback):
3038         (startTextMarkerForBoundsCallback):
3039         (AccessibilityUIElement::endTextMarkerForBounds):
3040         (AccessibilityUIElement::startTextMarkerForBounds):
3041         (AccessibilityUIElement::getJSClass):
3042         * DumpRenderTree/AccessibilityUIElement.h:
3043         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3044         (AccessibilityUIElement::endTextMarkerForBounds):
3045         (AccessibilityUIElement::startTextMarkerForBounds):
3046         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3047         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3048         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3049         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3050         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3051         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3052         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3053         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3054         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3055         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3056         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3057
3058 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
3059
3060         There should be a way to specify additional repository paths in NRWT
3061         https://bugs.webkit.org/show_bug.cgi?id=123135
3062
3063         Reviewed by Alexey Proskuryakov.
3064
3065         Added --additional-repository-name and --additional-repository-path options to NRWT.
3066         These options allow us to submit addtional repository information, such as of Safari's
3067         to the new flakiness dashboard.
3068
3069         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3070         (parse_args):
3071         * Scripts/webkitpy/port/base.py:
3072         (Port.repository_paths):
3073
3074 2013-10-22  Commit Queue  <commit-queue@webkit.org>
3075
3076         Unreviewed, rolling out r157774.
3077         http://trac.webkit.org/changeset/157774
3078         https://bugs.webkit.org/show_bug.cgi?id=123167
3079
3080         causes python test to fail (Requested by smfr on #webkit).
3081
3082         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3083         (Manager.run):
3084         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3085         (TestExpectations.__init__):
3086         (TestExpectations._add_expectations):
3087         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3088         (parse_args):
3089         (_set_up_derived_options):
3090
3091 2013-10-22  Lucas Forschler  <lforschler@apple.com>
3092
3093         Prepare WebKit Buildbot master for Mavericks.
3094         This adds the following bot configurations:
3095             Mavericks Release/Debug builders
3096             Mavericks Release/Debug WK1 Testers
3097             Mavericks Release/Debug WK2 Testers
3098
3099         Unreviewed.
3100         
3101         * BuildSlaveSupport/build.webkit.org-config/config.json:
3102
3103 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
3104
3105         Run tests as if they are expected to pass when --force is given.
3106         https://bugs.webkit.org/show_bug.cgi?id=112890
3107
3108         Reviewed by Ryosuke Niwa.
3109
3110         The --force switch of new-run-webkit-tests is now forces all tests to
3111         be run with 'PASS' as expected result.
3112
3113         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3114         (Manager.run):
3115         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3116         (TestExpectations.__init__):
3117         (TestExpectations._add_expectations):
3118         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3119         (parse_args):
3120         (_set_up_derived_options):
3121
3122 2013-10-21  Mark Rowe  <mrowe@apple.com>
3123
3124         Add a version of WebKitSystemInterface for Mavericks.
3125
3126         Reviewed by Ryosuke Niwa.
3127
3128         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3129         * Scripts/copy-webkitlibraries-to-product-directory:
3130         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3131
3132 2013-10-21  Anders Carlsson  <andersca@apple.com>
3133
3134         Navigation policy callback not called when performing the same fragment navigation twice
3135         https://bugs.webkit.org/show_bug.cgi?id=123121
3136         <rdar://problem/15230466>
3137
3138         Reviewed by Beth Dakin.
3139
3140         Add a test.
3141
3142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3143         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
3144         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
3145         (+[WebKit1FragmentNavigationTestDelegate shared]):
3146         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3147         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3148         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
3149         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
3150         (TestWebKitAPI::TEST):
3151
3152 2013-10-21  Dan Bernstein  <mitz@apple.com>
3153
3154         Style checker should allow a space after the @property keyword
3155         https://bugs.webkit.org/show_bug.cgi?id=123117
3156
3157         Reviewed by Anders Carlsson.
3158
3159         * Scripts/webkitpy/style/checkers/cpp.py:
3160         (check_spacing_for_function_call): Allow a space between @property and the following (
3161         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3162         (CppStyleTest.test_spacing_for_fncall): Added a test case.
3163
3164 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
3165
3166         [WinCairo] Build does not start.
3167         https://bugs.webkit.org/show_bug.cgi?id=123059
3168
3169         Reviewed by Csaba Osztrogonác.
3170
3171         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
3172
3173         * Scripts/build-webkit:
3174
3175 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
3176
3177         [Jhbuild] Bump the required Jhbuild revision
3178         https://bugs.webkit.org/show_bug.cgi?id=123089
3179
3180         Reviewed by Carlos Garcia Campos.
3181
3182         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
3183         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
3184         in the Jhbuild source so a more recent revision of it should be used.
3185
3186 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
3187
3188         Mac build fix.
3189
3190         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
3191
3192 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
3193
3194         Enable webaudio/ tests on DRT/Mac
3195         https://bugs.webkit.org/show_bug.cgi?id=86914
3196
3197         Reviewed by Darin Adler.
3198
3199         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
3200         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
3201         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
3202         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
3203
3204         * DumpRenderTree/TestRunner.cpp:
3205         (setAudioResultCallback): 
3206         (TestRunner::staticFunctions):
3207         * DumpRenderTree/TestRunner.h:
3208         (TestRunner::audioResult):
3209         (TestRunner::setAudioResult):
3210         The function has a different name and argument type now, updated accordingly.
3211         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
3212
3213         * DumpRenderTree/mac/DumpRenderTree.mm:
3214         (dumpAudio): Updated for the new name of audioResult accessor.
3215         (dump): Print the result in the format webkitpy currently expects.
3216
3217         * WebKitTestRunner/TestInvocation.cpp:
3218         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
3219         chunks made no sense.
3220
3221         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3222         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
3223
3224         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
3225         so that "SourceProvider.h" can be found.
3226
3227 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
3228
3229         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
3230         https://bugs.webkit.org/show_bug.cgi?id=123070
3231
3232         Reviewed by Alexey Proskuryakov.
3233
3234         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3235         (Manager.run):
3236         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3237         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
3238         in the test expectations when this argument is set to true.
3239
3240 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
3241
3242         Mac DumpRenderTree builds without NDEBUG even in release mode
3243         https://bugs.webkit.org/show_bug.cgi?id=123066
3244
3245         Reviewed by Dan Bernstein.
3246
3247         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3248         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3249         Use the same pattern as WebCore and WebKitTestRunner.
3250
3251 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
3252
3253         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
3254         https://bugs.webkit.org/show_bug.cgi?id=123064
3255
3256         Reviewed by Ryosuke Niwa.
3257
3258         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
3259
3260         * Scripts/webkitpy/common/config/ports.py: Added.
3261         (DeprecatedPort):
3262         (DeprecatedPort.name):
3263         (DeprecatedPort.flag):
3264         (DeprecatedPort.script_path):
3265         (DeprecatedPort.script_shell_command):
3266         (DeprecatedPort.port):
3267         (DeprecatedPort.makeArgs):
3268         (DeprecatedPort.update_webkit_command):
3269         (DeprecatedPort.check_webkit_style_command):
3270         (DeprecatedPort.prepare_changelog_command):
3271         (DeprecatedPort.build_webkit_command):
3272         (DeprecatedPort.run_javascriptcore_tests_command):
3273         (DeprecatedPort.run_webkit_unit_tests_command):
3274         (DeprecatedPort.run_webkit_tests_command):
3275         (DeprecatedPort.run_python_unittests_command):
3276         (DeprecatedPort.run_perl_unittests_command):
3277         (DeprecatedPort.run_bindings_tests_command):
3278         (MacPort):
3279         (MacWK2Port):
3280         (MacWK2Port.run_webkit_tests_command):
3281         (WinPort):
3282         (WinPort.run_bindings_tests_command):
3283         (GtkPort):
3284         (GtkPort.build_webkit_command):
3285         (GtkPort.run_webkit_tests_command):
3286         (GtkWK2Port):
3287         (GtkWK2Port.build_webkit_command):
3288         (GtkWK2Port.run_webkit_tests_command):
3289         (QtPort):
3290         (QtPort.build_webkit_command):
3291         (QtPort.run_webkit_tests_command):
3292         (QtWK2Port):
3293         (QtWK2Port.build_webkit_command):
3294         (QtWK2Port.run_webkit_tests_command):
3295         (EflPort):
3296         (EflPort.build_webkit_command):
3297         (EflWK2Port):
3298         (EflWK2Port.build_webkit_command):
3299         * Scripts/webkitpy/common/config/ports_mock.py: Added.
3300         (MockPort):
3301         (MockPort.name):
3302         (MockPort.check_webkit_style_command):
3303         (MockPort.update_webkit_command):
3304         (MockPort.build_webkit_command):
3305         (MockPort.prepare_changelog_command):
3306         (MockPort.run_python_unittests_command):
3307         (MockPort.run_perl_unittests_command):
3308         (MockPort.run_javascriptcore_tests_command):
3309         (MockPort.run_webkit_unit_tests_command):
3310         (MockPort.run_webkit_tests_command):
3311         (MockPort.run_bindings_tests_command):
3312         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
3313         (DeprecatedPortTest):
3314         (DeprecatedPortTest.test_mac_port):
3315         (DeprecatedPortTest.test_gtk_port):
3316         (DeprecatedPortTest.test_gtk_wk2_port):
3317         (DeprecatedPortTest.test_efl_port):
3318         (DeprecatedPortTest.test_qt_port):
3319         (DeprecatedPortTest.test_qt_wk2_port):
3320         * Scripts/webkitpy/port/base.py:
3321         (Port._port_flag_for_scripts):
3322         (Port._wk2_port_name):
3323         * Scripts/webkitpy/port/base_unittest.py:
3324         (PortTest.test_build_path):
3325         * Scripts/webkitpy/port/efl_unittest.py:
3326         (EflPortTest.test_show_results_html_file):
3327         * Scripts/webkitpy/port/gtk_unittest.py:
3328         (GtkPortTest.test_get_crash_log):
3329         * Scripts/webkitpy/port/mac_unittest.py:
3330         (test_64bit):
3331         * Scripts/webkitpy/port/test.py:
3332         (TestPort.virtual_test_suites):
3333         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3334         (FlakyTestReporter.__init__):
3335         * Scripts/webkitpy/tool/bot/irc_command.py:
3336         (Rollout._update_working_copy):
3337         * Scripts/webkitpy/tool/commands/download_unittest.py:
3338         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3339         (AbstractEarlyWarningSystem.run_command):
3340         * Scripts/webkitpy/tool/commands/queues.py:
3341         (PatchProcessingQueue.begin_work_queue):
3342         (CommitQueue.run_command):
3343         * Scripts/webkitpy/tool/main.py:
3344         (WebKitPatch.__init__):
3345         (WebKitPatch.deprecated_port):
3346         (WebKitPatch.handle_global_options):
3347         * Scripts/webkitpy/tool/mocktool.py:
3348         (MockTool.__init__):
3349         (MockTool.deprecated_port):
3350         * Scripts/webkitpy/tool/steps/build.py:
3351         (Build.build):
3352         * Scripts/webkitpy/tool/steps/checkstyle.py:
3353         (CheckStyle.run):
3354         * Scripts/webkitpy/tool/steps/commit.py:
3355         (Commit._check_test_expectations):
3356         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3357         (PrepareChangeLog.run):
3358         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3359         (PrepareChangeLogForRevert.run):
3360         * Scripts/webkitpy/tool/steps/runtests.py:
3361         (RunTests.run):
3362         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3363         (RunTestsTest.test_webkit_run_unit_tests):
3364         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3365         (StepsTest.test_runtests_args):
3366         * Scripts/webkitpy/tool/steps/update.py:
3367         (Update._update_command):
3368         * Scripts/webkitpy/tool/steps/update_unittest.py:
3369         (UpdateTest.test_update_command_non_interactive):
3370         (UpdateTest.test_update_command_interactive):
3371
3372 2013-10-19  Andreas Kling  <akling@apple.com>
3373
3374         RefPtr::releaseNonNull() incorrectly increments the refcount.
3375         <https://webkit.org/b/123063>
3376
3377         Add an API test to verify that no extra refs are added when calling
3378         RefPtr::releaseNonNull().
3379
3380         Reviewed by Anders Carlsson.
3381
3382 2013-10-18  Rik Cabanier <cabanier@adobe.com>
3383         Add Rik Cabanier to list of committers
3384         https://bugs.webkit.org/show_bug.cgi?id=123031
3385
3386         reviewed by Dirk Schulze.
3387
3388         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
3389
3390 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
3391
3392         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
3393         https://bugs.webkit.org/show_bug.cgi?id=122970
3394
3395         Reviewed by Mario Sanchez Prada.
3396
3397         Removed an invalid signal to set an object state to layout-complete
3398         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
3399
3400         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3401         (axObjectEventListener): Replaced layout-complete with load-complete.
3402         (connectAccessibilityCallbacks): Connect callback to new listener for
3403         ATK:AtkDocument:load-complete.
3404         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
3405         for ATK:AtkDocument:load-complete.
3406         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3407         (axObjectEventListener): Replaced layout-complete with load-complete.
3408         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3409         Connect callback to new listener for ATK:AtkDocument:load-complete.
3410         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3411         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
3412
3413 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3414
3415         [GTK] Generate API documentation for GObject DOM bindings
3416         https://bugs.webkit.org/show_bug.cgi?id=121538
3417
3418         Reviewed by Gustavo Noronha Silva.
3419
3420         The .symbols file that is now generated for checking GObject DOM
3421         bindings API compatibility while building can also be used to
3422         generate the files needed to produce the gtk-doc
3423         documentation. The new script generate-webkitdom-doc-files can
3424         generate the docs.sgml and sections.txt files from the given list
3425         of .symbols files.
3426
3427         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
3428         and webkitdomgtk-sections.txt as well as rules to install the
3429         generated WebKitDOMGTK documentation.
3430         * gtk/generate-gtkdoc:
3431         (webkitdom_docs_html_path): New helper function that returns the
3432         path where the DOM API documentation has been generated.
3433         (get_webkit2_options): Include DOM API docs to the list of xref
3434         dependencies.
3435         (get_webkit1_options): Ditto.
3436         (get_webkitdom_options): Return the gtk-doc options to generate
3437         the DOM API docs.
3438         (get_webkitdom_options.derived_sources_path):
3439         (get_webkitdom_options.src_path):
3440         * gtk/generate-webkitdom-doc-files: Added.
3441         (WebKitDOMDocGenerator):
3442         (WebKitDOMDocGenerator.write_header):
3443         (WebKitDOMDocGenerator.write_section):
3444         (WebKitDOMDocGenerator.write_footer):
3445         (WebKitDOMDocGeneratorDocs):
3446         (WebKitDOMDocGeneratorDocs.write_header):
3447         (write_section):
3448         (write_footer):
3449         (WebKitDOMDocGeneratorSections):
3450         (WebKitDOMDocGeneratorSections.__init__):
3451         (WebKitDOMDocGeneratorSections._dom_class):
3452         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
3453         (WebKitDOMDocGeneratorSections._symbol_list):
3454         (WebKitDOMDocGeneratorSections.write_section):
3455
3456 2013-10-17  Alex Christensen  <achristensen@webkit.org>
3457
3458         Run JavaScriptCore tests again on Windows.
3459         https://bugs.webkit.org/show_bug.cgi?id=122787
3460
3461         Reviewed by Tim Horton.
3462
3463         * Scripts/build-jsc:
3464         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
3465         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
3466         * Scripts/webkitdirs.pm:
3467         (determineConfigurationForVisualStudio):
3468         (determineConfigurationProductDir):
3469         Build directory should end with bin64 and configuration should end with |x64 on Win64.
3470         (isAppleWinWebKit):
3471         (copyInspectorFrontendFiles):
3472         (setPathForRunningWebKitApp):
3473         Separated WinCairo directories and options from AppleWin.
3474
3475 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
3476
3477         Unreviewed. Add myself as a reviewer.
3478
3479         * Scripts/webkitpy/common/config/contributors.json:
3480
3481 2013-10-17  Andreas Kling  <akling@apple.com>
3482
3483         Make it possible to assign a PassRef to a RefPtr.
3484         <https://webkit.org/b/122943>
3485
3486         Added a small API test for RefPtr=(PassRef) so we know this code
3487         will compile (and work.)
3488
3489         Reviewed by Antti Koivisto.
3490
3491 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
3492
3493         We need test coverage for just the Baseline JIT
3494         https://bugs.webkit.org/show_bug.cgi?id=122929
3495
3496         Reviewed by Sam Weinig.
3497         
3498         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
3499         variant.
3500
3501         * Scripts/run-jsc-stress-tests:
3502
3503 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
3504
3505         Support multiple repositories in submitting results to --results-server-host
3506         https://bugs.webkit.org/show_bug.cgi?id=122935
3507
3508         Reviewed by Anders Carlsson.
3509
3510         Remoevd --got-revision and added the logic to extract revision information
3511         from multiple repositories as done in run-perf-tests.
3512
3513         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3514         (Manager.upload_results):
3515         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3516         (parse_args):
3517
3518 2013-10-16  Darin Adler  <darin@apple.com>
3519
3520         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
3521         https://bugs.webkit.org/show_bug.cgi?id=122904
3522
3523         Reviewed by Anders Carlsson.
3524
3525         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
3526
3527 2013-10-16  Darin Adler  <darin@apple.com>
3528
3529         Need tests for RefPtr self-assignment and self-move-assignment.
3530
3531         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
3532
3533 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
3534
3535         [EFL] Minibrowser can't load child window's location
3536         https://bugs.webkit.org/show_bug.cgi?id=122485
3537
3538         Reviewed by Gyuyoung Kim.
3539
3540         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
3541             followed by an explicit call to ewk_view_url_set() where appropriate.
3542         (on_key_down):
3543         (on_window_create):
3544         (window_create):
3545         (elm_main):
3546
3547 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
3548
3549         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
3550         https://bugs.webkit.org/show_bug.cgi?id=122872
3551
3552         Reviewed by Anders Carlsson.
3553
3554         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
3555         failing.
3556
3557 2013-10-15  Dean Jackson  <dino@apple.com>
3558
3559         Add ENABLE_WEB_ANIMATIONS flag
3560         https://bugs.webkit.org/show_bug.cgi?id=122871
3561
3562         Reviewed by Tim Horton.
3563
3564         Eventually might be http://dev.w3.org/fxtf/web-animations/
3565         but this is just engine-internal work at the moment.
3566
3567         * Scripts/webkitperl/FeatureList.pm:
3568
3569 2013-10-15  Darin Adler  <darin@apple.com>
3570
3571         Add some API tests for Vector, RefPtr, and Ref
3572         https://bugs.webkit.org/show_bug.cgi?id=122840
3573
3574         Reviewed by Andreas Kling.
3575
3576         * TestWebKitAPI/CMakeLists.txt: Added new files.
3577         * TestWebKitAPI/GNUmakefile.am: Ditto.
3578         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
3579         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
3580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3581
3582         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
3583         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
3584         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
3585         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
3586
3587 2013-10-14  Roger Fong  <roger_fong@apple.com>
3588
3589         Adding myself to CC list for some components.
3590
3591         * Scripts/webkitpy/common/config/watchlist:
3592
3593 2013-10-13  Darin Adler  <darin@apple.com>
3594
3595         Deprecate or remove deleteAllValues functions; there are only a few call sites left
3596         https://bugs.webkit.org/show_bug.cgi?id=122738
3597
3598         Reviewed by Anders Carlsson.
3599
3600         * DumpRenderTree/win/DRTDataObject.cpp:
3601         (DRTDataObject::~DRTDataObject):
3602         * DumpRenderTree/win/UIDelegate.cpp:
3603         (DRTUndoStack::~DRTUndoStack):
3604         (DRTUndoStack::clear):
3605         Renamed deleteAllValues to deprecatedDeleteAllValues.
3606
3607         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
3608
3609 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
3610
3611         build.webkit.org/dashboard incorrectly shows interrupted builds as green
3612         https://bugs.webkit.org/show_bug.cgi?id=122732
3613
3614         Reviewed by Tim Hatcher.
3615
3616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3617         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
3618         I don't see it occur any time in recent history, but judging from what happens for
3619         status 5 (RETRY), we can just finish this function normally.
3620         Record overall text description for iteration as BuildbotIteration.text.
3621
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3623         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
3624         but no tests failed, make it yellow, and use buildbot-provided description for it.
3625
3626 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
3627
3628         Remove Chromium specific code from flakiness dashboard
3629         https://bugs.webkit.org/show_bug.cgi?id=122714
3630
3631         Reviewed by Sam Weinig.
3632
3633         Also removed code related to GPU tests and virtual suites.
3634         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
3635
3636         * TestResultServer/model/jsonresults_unittest.py:
3637         * TestResultServer/static-dashboards/builders.js:
3638         * TestResultServer/static-dashboards/dashboard_base.js:
3639         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3640         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3641         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
3642         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3643         * TestResultServer/static-dashboards/history.js:
3644         * TestResultServer/static-dashboards/loader.js:
3645         * TestResultServer/static-dashboards/ui.js:
3646         * TestResultServer/templates/uploadform.html:
3647
3648 2013-10-11  Timothy Hatcher  <timothy@apple.com>
3649
3650         Remove preference support for picking the old Web Inspector.
3651         https://bugs.webkit.org/show_bug.cgi?id=122655
3652
3653         Reviewed by Alexey Proskuryakov.
3654
3655         * WebKitTestRunner/TestController.cpp:
3656         (WTR::TestController::resetStateToConsistentValues):
3657
3658 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
3659
3660         Fix 64-bit build on everything but Windows.
3661
3662         Rubber stamped by Brent Fulgham.
3663
3664         * Scripts/webkitdirs.pm:
3665         (argumentsForConfiguration):
3666
3667 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
3668
3669         Touch a file to see how auto-update works.
3670
3671         Rubber-stamped by Tim Hatcher.
3672
3673         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3674
3675 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
3676
3677         LeaksViewer fails to present recent results list if current build is still updating svn
3678         https://bugs.webkit.org/show_bug.cgi?id=122670
3679
3680         Fixed an obvious mistake in the previous patch.
3681
3682         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3683         (RecentBuildsLoader.prototype.start):
3684
3685 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
3686
3687         LeaksViewer fails to present recent results list if current build is still updating svn
3688         https://bugs.webkit.org/show_bug.cgi?id=122670
3689
3690         Reviewed by Adam Roben.
3691
3692         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3693         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
3694
3695 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
3696
3697         Unreviewed build fix for --64-bit target.
3698
3699         * Scripts/webkitdirs.pm:
3700         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
3701         been removed by this point.
3702         (hasArgument): Remove unused temporary.
3703
3704 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3705
3706         webkit-patch failure-reason has a quite low limit for 'too many failures'
3707         https://bugs.webkit.org/show_bug.cgi?id=122556
3708
3709         Reviewed by Darin Adler.
3710
3711         * Scripts/webkitpy/tool/commands/queries.py:
3712         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
3713         to match what the layout test runners use these days.
3714
3715 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3716
3717         webkit-patch failure-reason should allow specifying failures one is interested in
3718         https://bugs.webkit.org/show_bug.cgi?id=122554
3719
3720         Reviewed by Darin Adler.
3721
3722         * Scripts/webkitpy/tool/commands/queries.py:
3723         (FailureReason):
3724         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
3725         loop if the ones we're interested in been explained.
3726         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
3727         (FailureReason.execute): initialize failures to explain and the explained set.
3728
3729 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
3730
3731         Make sure that DataTypes.h is in the binary drop.
3732
3733         Rubber stamped by Michael Saboff.
3734
3735         * Scripts/export-llvm-build:
3736
3737 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
3738
3739         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
3740         https://bugs.webkit.org/show_bug.cgi?id=122566
3741
3742         Reviewed by Mark Rowe.
3743
3744         * Scripts/configure-llvm:
3745
3746 2013-10-10  Mark Rowe  <mrowe@apple.com>
3747
3748         <rdar://problem/13341666> WebKit should always build against an SDK.
3749
3750         Have all projects default to building against the OS X Internal SDK for the Production
3751         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
3752         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
3753
3754         Reviewed by Dan Bernstein.
3755
3756         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3757         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3758         * MiniBrowser/Configurations/Base.xcconfig:
3759         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3760         * TestWebKitAPI/Configurations/Base.xcconfig:
3761         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3762         * WebKitTestRunner/Configurations/Base.xcconfig:
3763         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3764
3765 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
3766
3767         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
3768
3769         * Scripts/run-gtk-tests:
3770         (TestRunner): skip TestInspectorServer.
3771
3772 2013-10-10  Andres Gomez  <agomez@igalia.com>
3773
3774         [GTK] Provide search functionality to MiniBrowser
3775         https://bugs.webkit.org/show_bug.cgi?id=117631
3776
3777         Reviewed by Carlos Garcia Campos.
3778
3779         Adds a search bar to MiniBrowser with the minimum functionality
3780         and a new button to the toolbar for showing the new search
3781         bar. Typical keyboard shortcuts are also added.
3782
3783         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
3784         (doSearch):
3785         (searchNext):
3786         (searchPrevious):
3787         (searchCloseButtonClickedCallback):
3788         (searchEntryMenuIconPressedCallback):
3789         (searchEntryClearIconReleasedCallback):
3790         (searchEntryChangedCallback):
3791         (searchEntryActivatedCallback):
3792         (searchPrevButtonClickedCallback):
3793         (searchNextButtonClickedCallback):
3794         (searchMenuCheckButtonToggledCallback):
3795         (browser_search_bar_init):
3796         (browserSearchBarFinalize):
3797         (browser_search_bar_class_init):
3798         (browser_search_bar_new):
3799         (browser_search_bar_add_accelerators):
3800         (browser_search_bar_open):
3801         (browser_search_bar_close):
3802         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
3803         * MiniBrowser/gtk/BrowserWindow.c:
3804         (webViewEnterFullScreen): Closes new search bar.
3805         (webViewLeaveFullScreen): Opens new search bar if previously
3806         visible.
3807         (searchCallback): Added. Shows and hides the new search bar.
3808         (browser_window_init): Added search button to the toolbar.
3809         (browserWindowConstructed): Creates the new search bar.
3810         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
3811
3812 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3813
3814         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
3815         https://bugs.webkit.org/show_bug.cgi?id=122552
3816
3817         Reviewed by Darin Adler.
3818
3819         * Scripts/webkitpy/common/checkout/commitinfo.py:
3820         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
3821         will cause UnicodeDecodeError for non-ascii characters.
3822
3823 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3824
3825         Would like a link to dashboard from build.webkit.org main page
3826         https://bugs.webkit.org/show_bug.cgi?id=122577
3827
3828         Reviewed by Tim Hatcher.
3829
3830         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
3831
3832 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
3833
3834         [Win] Check for MathML fonts and warn user if they are missing.
3835         https://bugs.webkit.org/show_bug.cgi?id=122568
3836
3837         Reviewed by Tim Horton.
3838
3839         * Scripts/webkitdirs.pm:
3840         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
3841         Windows-specific code I added previously.
3842         (fontExists): Added
3843         (checkInstalledTools): Add check for MathML fonts.
3844
3845 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3846
3847         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
3848         https://bugs.webkit.org/show_bug.cgi?id=122471
3849
3850         Reviewed by Tim Hatcher.
3851
3852         Added links to webkitpy, webkitperl and bindings-tests results.
3853
3854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3855         (Buildbot.prototype.apiTestResultsURLForIteration):
3856         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
3857         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
3858         (Buildbot.prototype.bindingsTestResultsURLForIteration):
3859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3860         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3861
3862 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3863
3864         Move some functions from WebKitBuildbot to Buildbot class.
3865
3866         Suggested by Tim Hatcher.
3867
3868         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3869         (Buildbot.prototype.javascriptTestResultsURLForIteration):
3870         (Buildbot.prototype.apiTestResultsURLForIteration):
3871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3872         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
3873
3874 2013-10-09  Timothy Hatcher  <timothy@apple.com>
3875
3876         Add API tests to the Dashbord page.
3877
3878         https://bugs.webkit.org/show_bug.cgi?id=122283
3879
3880         Reviewed by Timothy Hatcher.
3881
3882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3883         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3885         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
3886
3887 2013-10-09  Timothy Hatcher  <timothy@apple.com>
3888
3889         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
3890
3891         https://bugs.webkit.org/show_bug.cgi?id=122515
3892
3893         Reviewed by Alexey Proskuryakov.
3894
3895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3896         (BuildbotIteration.prototype.update):
3897
3898 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3899
3900         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
3901         https://bugs.webkit.org/show_bug.cgi?id=122573
3902
3903         Reviewed by Tim Hatcher.
3904
3905         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3906         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
3907
3908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3909         (Buildbot.prototype.buildPageURLForIteration): Added.
3910
3911 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
3912
3913         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
3914         https://bugs.webkit.org/show_bug.cgi?id=122569
3915
3916         Reviewed by Tim Hatcher.
3917
3918         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3919         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
3920         to be produced by the old Mozilla test harness that we don't use any more.
3921
3922 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3923
3924         Add GTK 64 bits release to the buildbot dashboard
3925         https://bugs.webkit.org/show_bug.cgi?id=122548
3926
3927         Reviewed by Darin Adler.
3928
3929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
3930         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3931         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
3932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3933         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
3934
3935 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3936
3937         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
3938         https://bugs.webkit.org/show_bug.cgi?id=120638
3939
3940         Reviewed by Gustavo Noronha Silva.
3941
3942         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
3943         can check both the old and new APIs to retrieve text at a given offset.
3944
3945 2013-10-08  Alex Christensen  <achristensen@webkit.org>
3946
3947         Improved WinLauncher.
3948         https://bugs.webkit.org/show_bug.cgi?id=122536
3949
3950         Reviewed by Brent Fulgham.
3951
3952         * WinLauncher/PrintWebUIDelegate.cpp:
3953         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
3954         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3955         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
3956         * WinLauncher/WinLauncher.cpp:
3957         (createCrashReport): Use the executable name instead of "WinLauncher".
3958         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
3959         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
3960         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
3961
3962 2013-10-08  Mark Lam  <mark.lam@apple.com>
3963
3964         Fix ruby LoadError when running run-javascriptcore-tests.
3965         https://bugs.webkit.org/show_bug.cgi?id=122519.
3966
3967         Reviewed by Mark Hahnenberg.
3968
3969         The scripts needed to explicitly require 'rubygems' for older versions of ruby
3970         (versions before 1.9).
3971
3972         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
3973         * Scripts/run-jsc-stress-tests:
3974
3975 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3976
3977         Unreviewed, add my new email to contributors.json.
3978
3979         * Scripts/webkitpy/common/config/contributors.json:
3980
3981 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
3982
3983         Unreviewed build correction.
3984
3985         * Scripts/webkitpy/port/win.py:
3986         (WinPort.write_registry_value): Use string representation of error message to avoid
3987         format conversion problem.
3988
3989 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
3990
3991         [Win] Add checks for proper build and test environment
3992         https://bugs.webkit.org/show_bug.cgi?id=122466
3993
3994         Reviewed by Darin Adler.
3995
3996         This patch makes two changes:
3997         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
3998            error messages so that people know what to fix to get things working.
3999         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
4000            the various environment settings are properly configured for our test environment.
4001
4002         * Scripts/webkitdirs.pm:
4003         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
4004         caused problems in the past.
4005         (setupAppleWinEnv):
4006         * Scripts/webkitpy/port/win.py:
4007         (WinPort):
4008         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
4009         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
4010         DWORD, etc.)
4011         (WinPort.write_registry_string): Revise to call new generic registry write function.
4012         (WinPort.setup_crash_log_saving): Revise for new API
4013         (WinPort.restore_crash_log_saving): Ditto
4014         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
4015         servers from running.
4016         (WinPort.allow_error_dialogs): Ditto.
4017         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
4018         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
4019
4020 2013-10-08  Philippe Normand  <pnormand@igalia.com>
4021
4022         [GStreamer] enable v4l2 plugin
4023         https://bugs.webkit.org/show_bug.cgi?id=122503
4024
4025         Reviewed by Martin Robinson.
4026
4027         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
4028         we updated our GStreamer version to 1.0.8.
4029
4030 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
4031
4032         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
4033         https://bugs.webkit.org/show_bug.cgi?id=122104
4034
4035         Reviewed by Chris Fleizach.
4036
4037         Updated stringAttributeValue to double check that the exposure of
4038         aria-invalid as a state is consistent with its exposure as a text
4039         attribute as well, when it applies (implementations of AtkText).
4040
4041         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4042         (AccessibilityUIElement::stringAttributeValue): Add double check.
4043         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4044         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
4045
4046 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
4047
4048         run-jsc-stress-tests progress meter should update more quickly on older Rubies
4049         https://bugs.webkit.org/show_bug.cgi?id=122459
4050
4051         Reviewed by Darin Adler.
4052
4053         * Scripts/run-jsc-stress-tests:
4054
4055 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
4056
4057         [buildbot] parse tests that are reported as crashed correctly for GTK+
4058         https://bugs.webkit.org/show_bug.cgi?id=122476
4059
4060         Reviewed by Martin Robinson.
4061
4062         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4063         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
4064         as a failure of the API tests.
4065
4066 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
4067
4068         Unreviewed. Skipping API test that is causing the next one to crash,
4069         see https://bugs.webkit.org/show_bug.cgi?id=121970.
4070
4071         * Scripts/run-gtk-tests:
4072         (TestRunner):
4073
4074 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
4075
4076         [GTK] run-gtk-tests does not distinguish between failure and crashes
4077         https://bugs.webkit.org/show_bug.cgi?id=122135
4078
4079         Reviewed by Martin Robinson.
4080
4081         The GTK+ API test runner does not distinguish between failures and crashes. This change
4082         makes it do that, so it's easier for us to spot the more important/higher priority crash
4083         case.
4084
4085         * Scripts/run-gtk-tests:
4086         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
4087         so we have more information on how the process ended.
4088         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
4089         (TestRunner.run_tests): report crashes.
4090
4091 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
4092
4093         [GTK] Missing packages for APT on install-dependencies
4094         https://bugs.webkit.org/show_bug.cgi?id=121555
4095
4096         Reviewed by Martin Robinson.
4097
4098         * gtk/install-dependencies: add packages that are needed for
4099         building WebKit itself and the jhbuild dependencies.
4100
4101 2013-10-07  Anders Carlsson  <andersca@apple.com>
4102
4103         Fix test failures.
4104
4105         * Scripts/webkitpy/port/base.py:
4106         (Port.to.start_helper):
4107         * Scripts/webkitpy/port/mock_drt.py:
4108         (MockDRTPort.start_helper):
4109
4110 2013-10-07  Anders Carlsson  <andersca@apple.com>
4111
4112         Always force discrete mode when running layout tests
4113         https://bugs.webkit.org/show_bug.cgi?id=122465
4114
4115         Reviewed by Tim Horton.
4116
4117         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
4118         
4119         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4120         Link with IOKit.
4121
4122         * DumpRenderTree/mac/LayoutTestHelper.m:
4123         (installLayoutTestColorProfile):
4124         Check installColorProfile.
4125
4126         (restoreUserColorProfile):
4127         Check installColorProfile.
4128
4129         (lockDownDiscreteGraphics):
4130         New function to force discrete graphics.
4131
4132         (main):
4133         Add '--install-color-profile' option.
4134
4135         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4136         (Manager._set_up_run):
4137         Always start the helper, but pass self._options.pixel_tests to it.
4138
4139         * Scripts/webkitpy/port/mac.py:
4140         (MacPort.start_helper):
4141         Pass --install-color-profile' to the helper if pixel_tests is true.
4142
4143 2013-10-07  Timothy Hatcher  <timothy@apple.com>
4144
4145         Properly count binding test failures as failures.
4146
4147         Fix the total for multiple failures in different steps too by avoiding undefined.
4148
4149         https://bugs.webkit.org/show_bug.cgi?id=122232
4150
4151         Reviewed by Alexey Proskuryakov.
4152
4153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
4154         (BuildbotTestResults):
4155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4156         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
4157
4158 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
4159
4160         [GTK] Fails to build with jhbuild with newer system glib
4161         https://bugs.webkit.org/show_bug.cgi?id=122132
4162
4163         Reviewed by Martin Robinson.
4164
4165         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
4166         started relying on. glib is not a dependency that should change test results, and is provided in
4167         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
4168         should not be an issue.
4169
4170         * gtk/jhbuild.modules:
4171
4172 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
4173
4174         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
4175         https://bugs.webkit.org/show_bug.cgi?id=122437
4176
4177         Reviewed by Antoine Quint.
4178
4179         * Scripts/run-jsc-stress-tests:
4180
4181 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
4182
4183         Unreviewed, fix build on old Rubies.
4184
4185         * Scripts/run-jsc-stress-tests:
4186
4187 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
4188
4189         Unified test infrastructure via the jsc shell
4190         https://bugs.webkit.org/show_bug.cgi?id=120696
4191
4192         Reviewed by Oliver Hunt.
4193         
4194         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
4195         output (silent or noisy) and different styles of test failure (just bad exit code,
4196         text diff, filtering for some magical text, etc.). This allows me to get rid of the
4197         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
4198         running in run-jsc-stress-tests.
4199         
4200         Also removes all of the code paths that defended against not having shellwords. Just
4201         install the shellwords gem if you want to run tests.
4202         
4203         Also removes the non-parallel test running code. No reason for it to exist anymore.
4204         
4205         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
4206         as part of this patch, and left three more as new bugzillas.
4207
4208         * Scripts/create-mozilla-js-test-list: Added.
4209         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
4210         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
4211         * Scripts/run-javascriptcore-tests:
4212         * Scripts/run-jsc-stress-tests:
4213
4214 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
4215
4216         run-jsc-stress-tests should be less verbose
4217         https://bugs.webkit.org/show_bug.cgi?id=122397
4218
4219         Reviewed by Sam Weinig.
4220         
4221         It now just prints something like:
4222         
4223          965/1831 ....
4224         
4225         Where the first number is the number of tests that completed, the second number is the
4226         number of tests total, and the dots are the number of tests running right now - which is
4227         useful towards the end when you're waiting for the last slow tests to finish.
4228         
4229         It will also print out the output from failing tests and it will print a line for skipped
4230         tests (to annoy you into getting them into a shape where they can be unskipped). For
4231         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
4232
4233         * Scripts/run-jsc-stress-tests:
4234
4235 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
4236
4237         Allow skipping of run-jsc-stress-tests that are configured using yaml files
4238         https://bugs.webkit.org/show_bug.cgi?id=122385
4239
4240         Reviewed by Sam Wieinig.
4241         
4242         Make tests run via YAML be able to do the parse-for-commands trick that allows
4243         us to skip tests and do other custom per-test stuff.
4244
4245         * Scripts/jsc-stress-test-helpers/layout-test-helper:
4246         * Scripts/run-jsc-stress-tests:
4247
4248 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
4249
4250         Unreviewed, fix tests on older Rubies.
4251
4252         * Scripts/run-jsc-stress-tests:
4253
4254 2013-10-05  Anders Carlsson  <andersca@apple.com>
4255
4256         Don't filter the weak symbols.
4257
4258         * Scripts/check-for-weak-vtables-and-externals:
4259
4260 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
4261
4262         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
4263         https://bugs.webkit.org/show_bug.cgi?id=122376
4264
4265         Reviewed by Mark Hahnenberg.
4266
4267         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
4268         * Scripts/run-javascriptcore-tests:
4269         (printThingsFound):
4270         * Scripts/run-jsc-stress-tests:
4271
4272 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
4273
4274         It should be even easier to run and debug a failing JSC stress test
4275         https://bugs.webkit.org/show_bug.cgi?id=122337
4276
4277         Reviewed by Oliver Hunt.
4278         
4279         If a test fails, you can now just say:
4280
4281         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
4282
4283         and get the reproduction. You don't have to set any environment variables like before.
4284         Also if you want to debug the failing test you can now just say:
4285
4286         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
4287
4288         Broadly, any arguments passed to the reproduction script are prepended to the command to
4289         run the test. This is sort of quirky and won't work for some tests (for example the
4290         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
4291         them and that's good enough for now.
4292
4293         * Scripts/run-jsc-stress-tests:
4294
4295 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
4296
4297         [Windows] Correct run-path when using 64-bit binaries.
4298
4299         Reviewed by David Kilzer.
4300
4301         * Scripts/webkitdirs.pm:
4302         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
4303         directory. Otherwise use the existing 'bin32' directory.
4304
4305 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
4306
4307         Teach webkitdirs.pm to honor the --64-bit flag
4308         https://bugs.webkit.org/show_bug.cgi?id=122357
4309
4310         Reviewed by David Kilzer.
4311
4312         * Scripts/webkitdirs.pm:
4313         (argumentsForConfiguration): Modify to check if --64-bit is supplied