[CMake] Enable building WebKit2-only build for the EFL port
[WebKit-https.git] / Tools / ChangeLog
1 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
2
3         [CMake] Enable building WebKit2-only build for the EFL port
4         https://bugs.webkit.org/show_bug.cgi?id=103820
5
6         Reviewed by Gyuyoung Kim.
7
8         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
9         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
10         cmake directly. Initialize $cmakeArgs to avoid potential
11         warnings when running the script.
12
13         * Scripts/build-webkit:
14
15 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
16
17         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
18         https://bugs.webkit.org/show_bug.cgi?id=103407
19
20         Reviewed by Kentaro Hara.
21
22         Changing the mock to use the new results delivery API.
23
24         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
25
26 2012-12-03  Alexis Menard  <alexis@webkit.org>
27
28         [Qt] Enable CSS3 background-position offsets by default.
29         https://bugs.webkit.org/show_bug.cgi?id=103877
30
31         Reviewed by Tor Arne Vestbø.
32
33         Enable by default CSS3 background-position offsets.
34
35         * qmake/mkspecs/features/features.pri:
36
37 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
38
39         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
40         https://bugs.webkit.org/show_bug.cgi?id=103863
41
42         Reviewed by Gyuyoung Kim.
43
44         Use float instead of int for zoomLevels variables for a clearer expression
45
46         * MiniBrowser/efl/main.c:
47         (on_key_down):
48
49 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
50
51         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
52         https://bugs.webkit.org/show_bug.cgi?id=99285
53
54         Reviewed by Gyuyoung Kim.
55
56          Add support for a zoom level setting to MiniBrowser.
57          Shortcuts for setting operations are same as common browsers:
58          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
59
60         * MiniBrowser/efl/main.c:
61         (on_key_down):
62
63 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
64
65         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
66         https://bugs.webkit.org/show_bug.cgi?id=103835
67
68         Reviewed by Kentaro Hara.
69
70         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
71
72         * MiniBrowser/efl/main.c:
73         (elm_main):
74
75 2012-12-02  Mike West  <mkwst@chromium.org>
76
77         Garden-o-matic shouldn't die when blank JSON results are received.
78         https://bugs.webkit.org/show_bug.cgi?id=103838
79
80         Reviewed by Adam Barth.
81
82         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
83             If the JSONP string doesn't contain '(' or ')', return an empty object.
84         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
85             Check that this behavior stays in place.
86
87 2012-12-02  Eric Seidel  <eric@webkit.org>
88
89         run-perf-tests --profile should use iprofiler instead of instruments on Mac
90         https://bugs.webkit.org/show_bug.cgi?id=103765
91
92         Unreviewed.  Updating the unittests after my previous change.
93
94         * Scripts/webkitpy/common/system/profiler_unittest.py:
95         (ProfilerFactoryTest.test_basic):
96
97 2012-12-02  Julie Parent  <jparent@chromium.org>
98
99         Remove dead code in flakiness dashboard for obsolete buildDir option
100         https://bugs.webkit.org/show_bug.cgi?id=103792
101
102         Reviewed by Dirk Pranke.
103
104         * TestResultServer/static-dashboards/dashboard_base.js:
105         (initBuilders):
106
107 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
108
109         nrwt: clean up logic for retrying failed tests a bit
110         https://bugs.webkit.org/show_bug.cgi?id=103829
111
112         Reviewed by Ojan Vafai.
113
114         The code for determining when to retry test failures and
115         show the results.html file was awkward and could stand some
116         cleaning up. This patch should have no functional changes.
117
118         The routine called _get_failures() returned a dict of test names
119         to failure types, but we only ever used the names, so I've converted
120         it to return a list (and renamed it); also, the show_results_html()
121         file was calling that routine to figure out if anything failed, when
122         the information was already in the result_summary (as either
123         unexpected_results or total_failures), so we were doing unnecessary work.
124
125         * Scripts/webkitpy/layout_tests/controllers/manager.py:
126         (Manager.__init__):
127         (Manager.run):
128         (Manager._run_tests):
129         (Manager._failed_test_names):
130         (Manager._copy_results_html_file):
131
132 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
133
134         nrwt: remove unused methods in manager.py
135         https://bugs.webkit.org/show_bug.cgi?id=103828
136
137         Reviewed by Eric Seidel.
138
139         These two methods weren't being called by anything and were no
140         longer needed.
141
142         * Scripts/webkitpy/layout_tests/controllers/manager.py:
143         (Manager._get_failures):
144         (Manager._upload_json_files):
145
146 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
147
148         Correct the spelling of the cmakeargs argument
149         https://bugs.webkit.org/show_bug.cgi?id=103814
150
151         Reviewed by Darin Adler.
152
153         The script expects cmakeargs (plural), so lets get the
154         documentation of the script report the same.
155
156         * Scripts/build-webkit:
157
158 2012-12-02  Mike West  <mkwst@chromium.org>
159
160         [gtk] Enable the CSP_NEXT runtime flag.
161         https://bugs.webkit.org/show_bug.cgi?id=103810
162
163         Reviewed by Adam Barth.
164
165         * DumpRenderTree/gtk/DumpRenderTree.cpp:
166         (resetDefaultsToConsistentValues):
167             Turn on the CSP_NEXT runtime flag when running tests under GTK.
168
169 2012-12-02  Eric Seidel  <eric@webkit.org>
170
171         run-perf-tests --profile should use iprofiler instead of instruments on Mac
172         https://bugs.webkit.org/show_bug.cgi?id=103765
173
174         Reviewed by Ryosuke Niwa.
175
176         Stephanie pointed out that iprofiler is the newer command-line interface
177         to replace /usr/bin/instruments in Instruments 4 (which according to the
178         interblags is supported on everything since 10.6.6), so I've moved --profile
179         to use iprofiler on Mac.
180
181         I also made the IProfiler class wait for iprofiler to complete so that
182         iprofiler won't continue running after run-perf-tests is complete (and
183         spam over the top of your shell output).
184
185         There are a couple of "got-chas" to this approach:
186         1.  iprofiler will ask for your password the first time you run it, which may
187             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
188         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
189             directory and basename arguments, making IProfiler a somewhat awkward
190             baseclass of SingleFileOutputProfiler
191
192         I suspect we'll iterate from here.  It does seem slightly faster than
193         /usr/bin/instruments was.
194
195         * Scripts/webkitpy/common/system/profiler.py:
196         (ProfilerFactory.create_profiler):
197         (IProfiler):
198         (IProfiler.__init__):
199         (IProfiler.attach_to_pid):
200
201 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
202
203         Need a method to close all idle localstorage databases immediately.
204         https://bugs.webkit.org/show_bug.cgi?id=103469
205
206         Reviewed by David Kilzer.
207
208         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
209         DumpRenderTree layout tests.
210
211         * DumpRenderTree/TestRunner.cpp:
212         (closeIdleLocalStorageDatabasesCallback):
213         (TestRunner::staticFunctions):
214         * DumpRenderTree/TestRunner.h:
215         (TestRunner):
216         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
217         (TestRunner::closeIdleLocalStorageDatabases):
218         * DumpRenderTree/efl/TestRunnerEfl.cpp:
219         (TestRunner::closeIdleLocalStorageDatabases):
220         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
221         (TestRunner::closeIdleLocalStorageDatabases):
222         * DumpRenderTree/mac/TestRunnerMac.mm:
223         (TestRunner::closeIdleLocalStorageDatabases):
224         * DumpRenderTree/win/TestRunnerWin.cpp:
225         (TestRunner::closeIdleLocalStorageDatabases):
226         * DumpRenderTree/wx/TestRunnerWx.cpp:
227         (TestRunner::closeIdleLocalStorageDatabases):
228
229 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
230
231         [EFL][WK2] MiniBrowser should have a legacy mode
232         https://bugs.webkit.org/show_bug.cgi?id=103679
233
234         Reviewed by Kenneth Rohde Christiansen.
235
236         Add an option to start MiniBrowser in legacy mode.
237
238         * MiniBrowser/efl/main.c:
239         (window_create):
240         (elm_main):
241
242 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
243
244         Unreviewed, rolling out r136236.
245         http://trac.webkit.org/changeset/136236
246         https://bugs.webkit.org/show_bug.cgi?id=103833
247
248         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
249         during GC. (Requested by mkwst on #webkit).
250
251         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
252
253 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
254
255         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
256         https://bugs.webkit.org/show_bug.cgi?id=103806
257
258         Reviewed by Dirk Pranke.
259
260         There are occasional mishaps on builders where XvfbDriver doesn't properly
261         clean up the Xvfb instance it was managing so the related guard lock files
262         are still existing when the webkitpy unit tests are run. This can cause failures
263         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
264         with a specific number but is unable to due to the stale locks.
265
266         The solution to this is to use MockFileLock when inside unit test. This is achievable
267         by creating a file lock through the SystemHost instance connected to the Port object,
268         the latter available to the Driver.
269
270         * Scripts/webkitpy/common/system/file_lock_mock.py:
271         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
272         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
273         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
274         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
275         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
276         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
277
278 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
279
280         [GTK] A11y tests in WK2 report badly-formatted AX roles
281         https://bugs.webkit.org/show_bug.cgi?id=102947
282
283         Reviewed by Xan Lopez.
284
285         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
286         These are expected in both tests and their baselines.
287
288         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
289         (WTR::roleToString):
290         (WTR):
291         (WTR::AccessibilityUIElement::role):
292
293 2012-11-30  Mike West  <mkwst@chromium.org>
294
295         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
296         https://bugs.webkit.org/show_bug.cgi?id=103652
297
298         Reviewed by Adam Barth.
299
300         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
301
302         * DumpRenderTree/chromium/TestShell.cpp:
303         (TestShell::TestShell):
304
305 2012-11-30  Roger Fong  <roger_fong@apple.com>
306
307         Unreviewed. Removed temporary debugging change from DRT (r136300).
308
309         * DumpRenderTree/win/DumpRenderTree.cpp:
310         (dump):
311
312 2012-11-30  Roger Fong  <roger_fong@apple.com>
313
314         Unreviewed. Temporary change to DRT for debugging purposes.
315
316         * DumpRenderTree/win/DumpRenderTree.cpp:
317         (dump):
318
319 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
320
321         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
322         https://bugs.webkit.org/show_bug.cgi?id=103407
323
324         Reviewed by Adam Barth.
325
326         Changing the mock to use the new results delivery API.
327
328         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
329
330 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
331
332         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
333         https://bugs.webkit.org/show_bug.cgi?id=99314
334
335         Reviewed by Tor Arne Vestbø.
336
337         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
338         shared libraries.
339
340         It's a big refactoring that mostly involves moving WebCore dependent
341         code into QtWebKit and accessing it through exported QWebFrameAdapter
342         and QWebPageAdapter classes.
343
344         * DumpRenderTree/qt/DumpRenderTree.pro:
345         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
346         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
347         * MiniBrowser/qt/MiniBrowser.pro:
348         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
349         * Scripts/webkitpy/style/checker_unittest.py:
350         (GlobalVariablesTest.test_path_rules_specifier):
351         * WebKitTestRunner/InjectedBundle/Target.pri:
352         * qmake/mkspecs/features/default_post.prf:
353         * qmake/mkspecs/features/webkit_modules.prf:
354         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
355
356 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
357
358         [Qt] Unreviewed trivial fix.
359
360         Add empty.cpp back, it was removed accidentally by r129092.
361
362         * qmake/config.tests/gccdepends/empty.cpp: Added.
363
364 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
365
366         [Qt] Add support for prepare_docs and generate_docs
367
368         Follow-up to changes in Qt in how documentation is built.
369
370         Reviewed by Simon Hausmann.
371
372         * qmake/mkspecs/features/default_post.prf:
373
374 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
375
376         Finally remove webkitpy.common.system.deprecated_logging
377         https://bugs.webkit.org/show_bug.cgi?id=103624
378
379         Reviewed by Adam Barth.
380
381         Remove the deprecated logging module and its unit tests now that such logging is not
382         used anymore in webkitpy.
383
384         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
385         The tee class is renamed to Tee to conform with the usual guidelines.
386
387         Only unit test for the Tee class is currently provided as the OutputTee is not currently
388         using the webkitpy Filesystem abstraction that would make its functionality testable.
389
390         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
391         (Executive.run_and_throw_if_fail):
392         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
393         (Tee):
394         (Tee.__init__):
395         (Tee.write):
396         (OutputTee):
397         (OutputTee.__init__):
398         (OutputTee.add_log):
399         (OutputTee.remove_log):
400         (OutputTee._open_log_file):
401         (OutputTee._tee_outputs_to_files):
402         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
403         (SimpleTeeTest):
404         (SimpleTeeTest.test_simple_tee):
405         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
406         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
407
408 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
409
410         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
411         https://bugs.webkit.org/show_bug.cgi?id=103634
412
413         Reviewed by Gyuyoung Kim.
414
415         Add support for PlatformWebView::simulateRightClick() and enable
416         WebKit2 API test HitTestResultNodeHandle.
417
418         * TestWebKitAPI/PlatformEfl.cmake:
419         * TestWebKitAPI/efl/PlatformWebView.cpp:
420         (TestWebKitAPI::PlatformWebView::simulateRightClick):
421         (TestWebKitAPI):
422
423 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
424
425         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
426         https://bugs.webkit.org/show_bug.cgi?id=101192
427
428         Reviewed by Hajime Morita.
429
430         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
431
432         Tests: No new tests because there is no functional change.
433
434         * DumpRenderTree/chromium/WebPreferences.cpp:
435         (WebPreferences::applyTo):
436
437 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
438
439         [HTMLTemplateElement] Add feature flag
440         https://bugs.webkit.org/show_bug.cgi?id=103694
441
442         Reviewed by Adam Barth.
443
444         This flag will guard the implementation of the HTMLTemplateElement.
445         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
446
447         * Scripts/webkitperl/FeatureList.pm:
448
449 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
450
451         Ignore errors when removing directories on win32 during autoinstall
452         https://bugs.webkit.org/show_bug.cgi?id=103699
453
454         Unreviewed, build fix.
455
456         I think this will work on win32; if not, I'll have to actually
457         reproduce this :). The problem is that the logilab files
458         appear to contain a write-protected file, and deleting those
459         is problematic on windows.
460
461         * Scripts/webkitpy/common/system/autoinstall.py:
462         (AutoInstaller._install):
463         (AutoInstaller.install):
464
465 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
466
467         webkitpy: autoinstaller is failing on windows
468         https://bugs.webkit.org/show_bug.cgi?id=103699
469
470         Unreviewed, build fix.
471
472         We're attempting to create directories with forward slashes in them;
473         this is a no-no on windows.
474
475         * Scripts/webkitpy/common/system/autoinstall.py:
476         (AutoInstaller._create_scratch_directory_inner):
477
478 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
479
480         Fix python unit tests after r136158 (android port tests failing)
481         https://bugs.webkit.org/show_bug.cgi?id=103581
482
483         Unreviewed, build fix.
484
485         The unit tests apparently weren't ran for this patch; we failed
486         to update the mock executive calls out to adb to determine various
487         aspects of the environment, and were failing to create drivers.
488
489         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
490         (MockRunCommand.mock_run_command_fn):
491
492 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
493
494         Unreviewed, rolling out r136175 and r136177.
495         http://trac.webkit.org/changeset/136175
496         http://trac.webkit.org/changeset/136177
497         https://bugs.webkit.org/show_bug.cgi?id=103683
498
499         Changes did not correct Windows build. (Requested by bfulgham
500         on #webkit).
501
502         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
503
504 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
505
506         [Windows, WinCairo] Unreviewed build correction. Correct debug
507         build case on build machine.
508
509         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
510
511 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
512
513         [Windows, WinCairo] Unreviewed build correction. Hide the
514         unexported 'notSolidColor' symbol when testing against
515         the BitmapImage class to avoid having to deal with a
516         debug-only symbol in the Windows export definition file.
517
518         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
519
520 2012-11-29  Peter Beverloo  <peter@chromium.org>
521
522         run-perf-tests --chromium-android should not require adb in my path
523         https://bugs.webkit.org/show_bug.cgi?id=103581
524
525         Reviewed by Eric Seidel.
526
527         Remove the need to have "adb" available in the path for Layout and Performance
528         tests. We'll determine the versions of the "adb" version in path (if any) and
529         the one provided in the Chromium Android checkout. Unless the "adb" available
530         in the path is newer, the provided version will be used.
531
532         Some other minor nits addressed:
533         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
534           section, as they're not overriding anything and are used by the driver.
535         - Make _restart_adb_as_root slightly more robust by waiting for the device
536           to come back online regardless of the output.
537
538         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
539         (ChromiumAndroidPort.__init__):
540         (ChromiumAndroidPort.check_build):
541         (ChromiumAndroidPort.path_to_adb):
542         (ChromiumAndroidPort):
543         (ChromiumAndroidPort.path_to_forwarder):
544         (ChromiumAndroidPort.path_to_md5sum):
545         (ChromiumAndroidPort._path_to_helper):
546         (ChromiumAndroidPort._determine_adb_version):
547         (ChromiumAndroidPort._get_devices):
548         (ChromiumAndroidDriver.__init__):
549         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
550         (ChromiumAndroidDriver._push_executable):
551         (ChromiumAndroidDriver._restart_adb_as_root):
552
553 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
554
555         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
556         https://bugs.webkit.org/show_bug.cgi?id=103277
557
558         Reviewed by Carlos Garcia Campos.
559
560         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
561         during gtkdoc generation.
562
563         * gtk/generate-gtkdoc:
564         (get_webkit2_options):
565
566 2012-11-29  Eric Seidel  <eric@webkit.org>
567
568         run-perf-tests --chromium-android fails due to Skia INFO logging
569         https://bugs.webkit.org/show_bug.cgi?id=103585
570
571         Reviewed by Adam Barth.
572
573         Ignore all INFO logging from Chromium code.
574         Also added some basic testing of the ignored-stderr lines code.
575
576         * Scripts/webkitpy/performance_tests/perftest.py:
577         (PerfTest):
578         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
579         (MainTest.test_ignored_stderr_lines):
580
581 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
582
583         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
584         https://bugs.webkit.org/show_bug.cgi?id=103252
585
586         Reviewed by Kenneth Rohde Christiansen.
587
588         Add support for PlatformWebView::simulateMouseMove() and enable
589         WebKit2 API test MouseMoveAfterCrash.
590
591         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
592         test.
593         * TestWebKitAPI/efl/PlatformWebView.cpp:
594         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
595         to prevent loading an error page since the test case is reloading actual
596         page after web process has terminated and recovered.
597         (TestWebKitAPI):
598         (TestWebKitAPI::PlatformWebView::PlatformWebView):
599         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
600
601 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
602
603         [Qt] Fix installation of QtWebProcess binary
604         https://bugs.webkit.org/show_bug.cgi?id=101735
605
606         Reviewed by Simon Hausmann.
607
608         Add config test to detect the availability of support
609         for "program executables" in Qt (libexec).
610
611         This test can be removed after the Qt5 release.
612
613         * Tools.pro:
614         * qmake/mkspecs/features/features.prf:
615         * qmake/config.tests/libexecdir/libexecdir.cpp:
616         * qmake/config.tests/libexecdir/libexecdir.pro:
617
618 2012-11-29  Eric Seidel  <eric@webkit.org>
619
620         run-perf-tests does not work when the layout test directory does not exist
621         https://bugs.webkit.org/show_bug.cgi?id=103572
622
623         Reviewed by Ryosuke Niwa.
624
625         Make sure that Profiler() calls maybe_make_directory for the output_dir
626         before ever using it.  It's a little awkward to create the directory
627         from the constructor, but its simplest that way as the various subclasses
628         all use the directory at different times.
629
630         Since this required having a filesystem in Profiler (and I didn't want
631         to grab inside Workspace to get one), I just made Profiler expect a
632         SystemHost instead of a separate filesystem, executive and workspace.
633
634         * Scripts/webkitpy/common/system/profiler.py:
635         (ProfilerFactory.create_profiler):
636         (Profiler.__init__):
637         (SingleFileOutputProfiler.__init__):
638         (GooglePProf.__init__):
639         (GooglePProf.profile_after_exit):
640         (Instruments.__init__):
641         (Instruments.attach_to_pid):
642         * Scripts/webkitpy/common/system/profiler_unittest.py:
643         (ProfilerFactoryTest.test_basic):
644
645 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
646
647         Adding secondary email id
648         https://bugs.webkit.org/show_bug.cgi?id=103594
649
650         Unreviewed. Adding secondary email.
651
652         * Scripts/webkitpy/common/config/committers.py:
653
654 2012-11-28  Kent Tamura  <tkent@chromium.org>
655
656         garden-o-matic: Use indeterminate <progress> in the status area
657         https://bugs.webkit.org/show_bug.cgi?id=103494
658
659         Reviewed by Adam Barth.
660
661         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
662         Wrap the "Processing..." message with an indeterminate progress bar.
663         We keep the message as a fallback content.
664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
665         Follow the above change.
666
667 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
668
669         Adding Nima Ghanavatian to committers.py
670         https://bugs.webkit.org/show_bug.cgi?id=103533
671
672         Reviewed by Rob Buis.
673
674         Adding myself to committers.py as a Committer.
675
676         * Scripts/webkitpy/common/config/committers.py:
677
678 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
679
680         [WinCairo] Crash when requesting favicon.
681         https://bugs.webkit.org/show_bug.cgi?id=102689
682
683         Reviewed by Brent Fulgham.
684
685         * TestWebKitAPI/Tests/WebCore/win: Added.
686         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
687         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
688         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
689         (TestWebKitAPI::TEST): Added new test.
690         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
691        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
692
693 2012-11-28  Eric Seidel  <eric@webkit.org>
694
695         run-perf-tests should have a --profile option for easy profiling
696         https://bugs.webkit.org/show_bug.cgi?id=99517
697
698         Reviewed by Adam Barth.
699
700         This is a very basic implementation which works on Mac and Linux
701         and makes it trivial for anyone to profile a PerformanceTest.
702
703         Currently it's not "hard" to profile a PerformanceTest
704         but lowering the barriers to entry here allows all of us to focus
705         less on the tools and more on the code.
706
707         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
708         which is actually "hard", and this option will make much easier.
709
710         * Scripts/webkitpy/common/system/profiler.py: Added.
711         (ProfilerFactory):
712         (ProfilerFactory.create_profiler):
713         (Profiler):
714         (Profiler.__init__):
715         (Profiler.adjusted_environment):
716         (Profiler.attach_to_pid):
717         (Profiler.did_stop):
718         (SingleFileOutputProfiler):
719         (SingleFileOutputProfiler.__init__):
720         (GooglePProf):
721         (GooglePProf.__init__):
722         (GooglePProf.adjusted_environment):
723         (GooglePProf.did_stop):
724         (Instruments):
725         (Instruments.__init__):
726         (Instruments.attach_to_pid):
727         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
728         (ProfilerFactoryTest):
729         (ProfilerFactoryTest.test_basic):
730         * Scripts/webkitpy/layout_tests/port/driver.py:
731         (Driver.__init__):
732         (Driver._start):
733         (Driver.stop):
734         (Driver.cmd_line):
735         * Scripts/webkitpy/performance_tests/perftest.py:
736         (PerfTest.parse_output):
737         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
738         (MainTest.test_parse_output):
739         (MainTest.test_parse_output_with_failing_line):
740         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
741         (PerfTestsRunner._parse_args):
742         (PerfTestsRunner.run):
743
744 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
745
746         Remove deprecated logging usage from QueueEngine
747         https://bugs.webkit.org/show_bug.cgi?id=103532
748
749         Reviewed by Dirk Pranke.
750
751         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
752         logging through the Logger object. The unit test is modified to reflect
753         these changes.
754
755         After these changes the deprecated logging (i.e. logging to stderr) is not
756         used anymore through webkitpy and can be removed.
757
758         * Scripts/webkitpy/tool/bot/queueengine.py:
759         (QueueEngine.exit_after_handled_error):
760         (QueueEngine.run):
761         (QueueEngine._stopping):
762         (QueueEngine._sleep):
763         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
764         (QueueEngineTest._run_engine):
765
766 2012-11-28  Nate Chapin  <japhet@chromium.org>
767
768         Move empty loading to DocumentLoader, simplify FrameLoader::init()
769         https://bugs.webkit.org/show_bug.cgi?id=101512
770
771         Reviewed by Adam Barth.
772
773         * DumpRenderTree/chromium/WebViewHost.cpp:
774         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
775             interprets them as a non-empty load. This change is required for
776              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
777         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
778              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
779         (TestWebKitAPI::didFinishLoadForFrame):
780         (TestWebKitAPI::TEST):
781
782 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
783
784         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
785         https://bugs.webkit.org/show_bug.cgi?id=103092
786
787         Reviewed by Tony Chang.
788
789         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
790         from touch events.
791
792         * DumpRenderTree/chromium/TestWebPlugin.cpp:
793         (parseTouchEventRequestType):
794         (TestWebPlugin::TestWebPlugin):
795         (TestWebPlugin::initialize):
796         * DumpRenderTree/chromium/TestWebPlugin.h:
797         (TestWebPlugin):
798
799 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
800
801         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
802         https://bugs.webkit.org/show_bug.cgi?id=103123
803
804         Reviewed by Laszlo Gombos.
805
806         Add support for PlatformWebView::simulateSpacebarKeyPress().
807         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
808         which is going to be unskipped in bug #103252.
809
810         * TestWebKitAPI/efl/PlatformUtilities.cpp:
811         (TestWebKitAPI::Util::sleep):
812         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
813         sleep().
814         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
815         (TestWebKitAPI):
816
817 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
818
819         Minor cleanup in TestInvocation
820         https://bugs.webkit.org/show_bug.cgi?id=103512
821
822         Reviewed by Kenneth Rohde Christiansen.
823
824         Remove a function declaration that is not defined and not used.
825         Fix spelling error in m_webProcessIsUnresponsive.
826
827         * WebKitTestRunner/TestInvocation.cpp:
828         (WTR::TestInvocation::TestInvocation):
829         (WTR::TestInvocation::invoke):
830         * WebKitTestRunner/TestInvocation.h:
831         (TestInvocation):
832         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
833         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
834         * WebKitTestRunner/qt/TestInvocationQt.cpp:
835         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
836
837 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
838
839         Unreviewed. Use my personal email as bugzilla email.
840
841         * Scripts/webkitpy/common/config/committers.py:
842
843 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
844
845         Unreviewed. Adding myself to committers.py.
846
847         * Scripts/webkitpy/common/config/committers.py:
848
849 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
850
851         Unreviewed. Adding myself to committers.py.
852
853         * Scripts/webkitpy/common/config/committers.py:
854
855 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
856
857         Add basic implementation for MediaStreamAudioDestinationNode
858         https://bugs.webkit.org/show_bug.cgi?id=101815
859
860         Reviewed by Chris Rogers.
861
862         Adds a bit of code that exercises the WebKit API.
863
864         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
865         (MockWebMediaStreamSourceConsumer):
866         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
867         (MockWebMediaStreamCenter::didCreateMediaStream):
868
869 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
870
871         Unreviewed. Adding myself to committers list.
872
873         * Scripts/webkitpy/common/config/committers.py:
874
875 2012-11-27  Li Yin  <li.yin@intel.com>
876
877         Unreviewed. Adding myself to committers list.
878
879         * Scripts/webkitpy/common/config/committers.py:
880
881 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
882
883         Unreviewed. Adding myself to committers.py.
884
885         * Scripts/webkitpy/common/config/committers.py:
886
887 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
888
889         Unreviewd. Adding myself to committers list.
890
891         * Scripts/webkitpy/common/config/committers.py:
892
893 2012-11-27  Tony Chang  <tony@chromium.org>
894
895         Bring back partytime!
896         https://bugs.webkit.org/show_bug.cgi?id=103466
897
898         Reviewed by Adam Barth.
899
900         "code 404, message Unknown function images/partytime_gif" since we didn't
901         allow .gif or .png files to be served.
902
903         * Scripts/webkitpy/tool/servers/gardeningserver.py:
904         (GardeningHTTPRequestHandler):
905
906 2012-11-27  Adam Barth  <abarth@webkit.org>
907
908         run-perf-tests fails on Android because of stderr output
909         https://bugs.webkit.org/show_bug.cgi?id=103462
910
911         Reviewed by Ryosuke Niwa.
912
913         The chromium-android port produces some stderr output that causes
914         run-perf-tests to get sad and not record the results of the performance
915         test. This patch teaches run-perf-test to ignore this output much in
916         the same way that it currently ignores some stdout messages.
917
918         * Scripts/webkitpy/performance_tests/perftest.py:
919         (PerfTest.run):
920         (PerfTest._should_ignore_line):
921         (PerfTest):
922         (PerfTest._should_ignore_line_in_stderr):
923         (PerfTest._filter_stderr):
924         (PerfTest._should_ignore_line_in_parser_test_result):
925
926 2012-11-27  Tony Chang  <tony@chromium.org>
927
928         Fix garden-o-matic for non-chromium ports
929         https://bugs.webkit.org/show_bug.cgi?id=103458
930
931         Reviewed by Adam Barth.
932
933         I was getting a 403 error when trying to select any non-chromium port.
934
935         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
936         (ReflectionHandler._handle_request): Use the path without query params.
937
938 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
939
940         [EFL][WK2] 3D pixel tests are failing
941         https://bugs.webkit.org/show_bug.cgi?id=102833
942
943         Reviewed by Kenneth Rohde Christiansen.
944
945         Generate a snapshot of the view in the UI process instead of the web process.
946         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
947
948         * WebKitTestRunner/TestInvocation.h:
949         (TestInvocation):
950         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
951         (WTR::writeFunction):
952         (WTR::paintRepaintRectOverlay):
953         (WTR):
954         (WTR::TestInvocation::forceRepaintDoneCallback):
955         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
956         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
957         (WTR::PlatformWebView::windowSnapshotImage):
958
959 2012-11-27  Adam Barth  <abarth@webkit.org>
960
961         Make it possible to run performance tests on Chromium Android
962         https://bugs.webkit.org/show_bug.cgi?id=103268
963
964         Reviewed by Ryosuke Niwa.
965
966         Based on a patch by Peter Beverloo.
967
968         This patch (almost) makes it possible to run WebKit performance tests
969         on the Chromium port for Android. There are a few things I had to do
970         in order to make this happen:
971
972         1) The worker number when creating a driver for a port is zero-based
973            for layout tests and elsewhere. Android uses this to determine
974            which device it has to run on, so make it zero based for performance
975            tests as well.
976
977         2) Tests aren't available on the Android device, so we start an HTTP
978            server that serves the tests to the device or emulator.
979
980         The one shortcoming of this patch is that chromium-android produces
981         some stderr output that confuses run-perf-tests. I'll address that
982         issue in a subsequent CL. This patch also depends on
983         https://codereview.chromium.org/11416182 in order to work.
984
985         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
986         (ChromiumAndroidPort.start_http_server):
987         (ChromiumAndroidDriver._command_from_driver_input):
988         * Scripts/webkitpy/performance_tests/perftest.py:
989         (ReplayPerfTest.prepare):
990         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
991         (PerfTestsRunner.__init__):
992         (PerfTestsRunner._parse_args):
993         (PerfTestsRunner._start_servers):
994         (PerfTestsRunner):
995         (PerfTestsRunner._stop_servers):
996         (PerfTestsRunner.run):
997         (PerfTestsRunner._run_tests_set):
998
999 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
1000
1001         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
1002         https://bugs.webkit.org/show_bug.cgi?id=103408
1003
1004         Reviewed by Dirk Pranke.
1005
1006         Remove the use of the deprecated log and error methods by replacing them with
1007         logging through Python's logging.Logger objects.
1008
1009         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
1010         updates any affected unit test.
1011
1012         * Scripts/webkitpy/common/checkout/changelog.py:
1013         (ChangeLogEntry._parse_entry):
1014         * Scripts/webkitpy/common/checkout/checkout.py:
1015         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1016         (CheckoutTest.test_apply_patch):
1017         * Scripts/webkitpy/common/checkout/deps_mock.py:
1018         (MockDEPS.write_variable):
1019         * Scripts/webkitpy/common/checkout/scm/detection.py:
1020         (SCMDetector.default_scm):
1021         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1022         (SCMDetectorTest.test_detect_scm_system):
1023         * Scripts/webkitpy/common/checkout/scm/git.py:
1024         (Git._check_git_architecture):
1025         (Git._commit_on_branch):
1026         * Scripts/webkitpy/common/checkout/scm/scm.py:
1027         (SCM.ensure_clean_working_directory):
1028         (SCM.ensure_no_local_commits):
1029         (SCM.will.commit_locally_with_message):
1030         * Scripts/webkitpy/common/checkout/scm/svn.py:
1031         (SVN.apply_reverse_diff):
1032         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1033         (Attachment._validate_flag_value):
1034         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1035         (Bugzilla._fetch_bug_page):
1036         (Bugzilla.bug_id_for_attachment_id):
1037         (Bugzilla.authenticate):
1038         (Bugzilla._commit_queue_flag):
1039         (Bugzilla.add_attachment_to_bug):
1040         (Bugzilla.add_patch_to_bug):
1041         (Bugzilla.create_bug):
1042         (Bugzilla.clear_attachment_flags):
1043         (Bugzilla.set_flag_on_attachment):
1044         (Bugzilla.obsolete_attachment):
1045         (Bugzilla.add_cc_to_bug):
1046         (Bugzilla.post_comment_to_bug):
1047         (Bugzilla.close_bug_as_fixed):
1048         (Bugzilla.reassign_bug):
1049         (reopen_bug):
1050         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1051         (MockBugzilla.create_bug):
1052         (MockBugzilla.reassign_bug):
1053         (MockBugzilla.set_flag_on_attachment):
1054         (MockBugzilla.post_comment_to_bug):
1055         (MockBugzilla.add_attachment_to_bug):
1056         (MockBugzilla.add_patch_to_bug):
1057         (MockBugzilla.reopen_bug):
1058         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1059         (test_add_cc_to_bug):
1060         (_assert_reopen):
1061         (test_reopen_bug):
1062         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1063         (MockBuilder.force_build):
1064         * Scripts/webkitpy/common/net/credentials.py:
1065         (Credentials._run_security_tool):
1066         * Scripts/webkitpy/common/net/credentials_unittest.py:
1067         (_assert_security_call):
1068         * Scripts/webkitpy/common/net/irc/irc_mock.py:
1069         (MockIRC.post):
1070         (MockIRC.disconnect):
1071         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1072         (IRCProxy.__init__):
1073         (IRCProxy.disconnect):
1074         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
1075         (IRCProxyTest.test_trivial):
1076         * Scripts/webkitpy/common/net/layouttestresults.py:
1077         (ORWTResultsHTMLParser._failures_from_fail_row):
1078         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1079         (test_failures_from_fail_row):
1080         * Scripts/webkitpy/common/net/networktransaction.py:
1081         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1082         (JSONTestResult._tokenize):
1083         (JSONTestResult._failure_types_from_actual_result):
1084         * Scripts/webkitpy/common/net/statusserver.py:
1085         (StatusServer.update_status):
1086         (StatusServer.update_svn_revision):
1087         * Scripts/webkitpy/common/net/statusserver_mock.py:
1088         (MockStatusServer.release_work_item):
1089         (MockStatusServer.update_work_items):
1090         (MockStatusServer.submit_to_ews):
1091         (MockStatusServer.update_status):
1092         * Scripts/webkitpy/common/net/unittestresults.py:
1093         (UnitTestResults.results_from_string):
1094         * Scripts/webkitpy/common/system/executive_mock.py:
1095         (MockExecutive.running_pids):
1096         (MockExecutive.run_and_throw_if_fail):
1097         (MockExecutive.run_command):
1098         (MockExecutive.popen):
1099         * Scripts/webkitpy/common/system/user_mock.py:
1100         (MockUser.confirm):
1101         (MockUser.open_url):
1102         * Scripts/webkitpy/common/system/workspace_unittest.py:
1103         (WorkspaceTest.test_create_zip):
1104         (WorkspaceTest.test_create_zip_exception):
1105         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
1106         (MockWatchList.determine_cc_and_messages):
1107         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1108         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
1109         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1110         (EflPortTest.test_show_results_html_file):
1111         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1112         (GtkPortTest.test_show_results_html_file):
1113         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1114         (test_show_results_html_file):
1115         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1116         (test_build_driver):
1117         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1118         (QtPortTest.test_show_results_html_file):
1119         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1120         (WinPortTest.test_show_results_html_file):
1121         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
1122         (XvfbDriverTest.assertDriverStartSuccessful):
1123         (XvfbDriverTest.test_start_no_pixel_tests):
1124         (XvfbDriverTest.test_start_pixel_tests):
1125         (XvfbDriverTest.test_start_arbitrary_worker_number):
1126         (XvfbDriverTest.test_start_next_worker):
1127         (XvfbDriverTest.test_stop):
1128         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1129         (TestLayoutTestApacheHttpd.test_start_cmd):
1130         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1131         (test_run_test_pause_before_testing):
1132         (test_run_memory_test):
1133         (_test_run_with_json_output):
1134         (test_run_respects_no_results):
1135         (test_run_generates_and_show_results_page):
1136         (test_run_respects_no_show_results):
1137         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1138         (FeedersTest.test_commit_queue_feeder):
1139         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1140         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
1141         (test_report_flaky_tests_creating_bug):
1142         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1143         (IRCCommandTest.test_rollout_updates_working_copy):
1144         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1145         (IRCBotTest.test_exception_during_command):
1146         (IRCBotTest.test_hi):
1147         (IRCBotTest.test_help):
1148         (IRCBotTest.test_restart):
1149         (IRCBotTest.test_rollout):
1150         (IRCBotTest.test_revert):
1151         (IRCBotTest.test_roll_chromium_deps):
1152         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
1153         (IRCBotTest.test_multi_rollout):
1154         (IRCBotTest.test_rollout_with_r_in_svn_revision):
1155         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
1156         (IRCBotTest.test_rollout_bananas):
1157         (IRCBotTest.test_rollout_invalidate_revision):
1158         (IRCBotTest.test_rollout_invalidate_reason):
1159         (test_multi_rollout_invalidate_reason):
1160         (test_rollout_no_reason):
1161         (test_multi_rollout_no_reason):
1162         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1163         (SheriffTest.test_post_blame_comment_on_bug):
1164         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
1165         (ApplyWatchListLocalTest.test_args_parsing):
1166         (test_args_parsing_with_bug):
1167         * Scripts/webkitpy/tool/commands/download_unittest.py:
1168         (test_land_cowboy):
1169         (test_check_style):
1170         (test_create_rollout):
1171         (test_create_rollout_resolved):
1172         (test_rollout):
1173         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1174         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1175         (EarlyWarningSytemTest._default_expected_logs):
1176         (EarlyWarningSytemTest._test_builder_ews):
1177         (EarlyWarningSytemTest._test_testing_ews):
1178         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
1179         (OpenBugsTest.test_args_parsing):
1180         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1181         (QueryCommandsTest.test_bugs_to_commit):
1182         (QueryCommandsTest.test_patches_in_commit_queue):
1183         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1184         (FeederQueueTest.test_feeder_queue):
1185         (AbstractPatchQueueTest.test_next_patch):
1186         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
1187         (CommitQueueTest.test_commit_queue):
1188         (test_commit_queue_failure):
1189         (test_commit_queue_failure_with_failing_tests):
1190         (test_rollout):
1191         (test_rollout_lands):
1192         (test_auto_retry):
1193         (test_manual_reject_during_processing):
1194         (test_report_flaky_tests):
1195         (StyleQueueTest.test_style_queue_with_style_exception):
1196         (test_style_queue_with_watch_list_exception):
1197         * Scripts/webkitpy/tool/commands/queuestest.py:
1198         (QueuesTest._default_begin_work_queue_logs):
1199         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1200         (RollCommandsTest.test_update_chromium_deps):
1201         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1202         (UploadCommandsTest.test_assign_to_committer):
1203         (test_post):
1204         (test_attach_to_bug):
1205         (test_attach_to_bug_no_description_or_comment):
1206         (test_land_safely):
1207         (test_prepare):
1208         (test_upload):
1209         (test_mark_bug_fixed):
1210         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
1211         (ApplyWatchListTest.test_apply_watch_list_local):
1212         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1213         (CommitTest._test_check_test_expectations):
1214         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1215         (RunTestsTest.test_webkit_run_unit_tests):
1216         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1217         (StepsTest._assert_step_output_with_bug):
1218         (StepsTest._assert_post_diff_output_for_bug):
1219         (StepsTest.test_post_diff):
1220         (StepsTest.test_post_diff_for_commit):
1221         (StepsTest.test_ensure_bug_is_open_and_assigned):
1222         (StepsTest.test_runtests_args):
1223         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1224         (SuggestReviewersTest.test_basic):
1225         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1226         (ValidateChangeLogsTest._assert_start_line_produces_output):
1227
1228 2012-11-27  Pratik Solanki  <psolanki@apple.com>
1229
1230         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
1231         https://bugs.webkit.org/show_bug.cgi?id=101780
1232
1233         Reviewed by Brent Fulgham.
1234
1235         Clean up header includes so we don't include objc/objc-runtime.h.
1236
1237         * DumpRenderTree/mac/DumpRenderTree.mm:
1238         * DumpRenderTree/mac/ObjCPlugin.m:
1239         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
1240         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1241
1242 2012-11-27  Marja Hölttä  <marja@chromium.org>
1243
1244         Add callbacks to the FrameLoaderClient when a resource is requested
1245         https://bugs.webkit.org/show_bug.cgi?id=92761
1246
1247         Reviewed by Adam Barth.
1248
1249         In Chromium, when an extension script cancels a network
1250         request (which happens out of process), we'd like to
1251         notify content scripts running on the current page about
1252         which elements failed to load because the requests were
1253         cancelled (as opposed to e.g. the network request just
1254         didn't work). Since the resource request itself does not
1255         carry any information what DOM element is was made for,
1256         currently a content script has to search the DOM tree and
1257         guess which requests will be cancelled by its counter
1258         part. By adding these callbacks, the embedder can make
1259         this connection explictly.
1260
1261         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1262         (DRTTestRunner::DRTTestRunner):
1263         (DRTTestRunner::dumpResourceRequestCallbacks):
1264         (DRTTestRunner::reset):
1265         * DumpRenderTree/chromium/DRTTestRunner.h:
1266         (DRTTestRunner):
1267         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
1268         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
1269         * DumpRenderTree/chromium/TestShell.h:
1270         (TestShell::shouldDumpResourceRequestCallbacks):
1271         * DumpRenderTree/chromium/WebViewHost.cpp:
1272         (WebViewHost::willRequestResource):
1273         * DumpRenderTree/chromium/WebViewHost.h:
1274         (WebViewHost):
1275
1276 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
1277
1278         [GStreamer] Verify if GStreamer was previously initialized
1279         https://bugs.webkit.org/show_bug.cgi?id=103151
1280
1281         Reviewed by Philippe Normand.
1282
1283         This patch adds the gst_init() in GtkLauncher, so we can add the
1284         GStreamer options in the command line through
1285         gst_init_get_option_group().
1286
1287         This approach is not valid for MiniBrowser because it uses WebKit2,
1288         where the GStreamer backend lives in the web process, which is
1289         different from the UI process.
1290
1291         * GNUmakefile.am:
1292         * GtkLauncher/main.c:
1293         (main):
1294
1295 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
1296
1297         [Qt] Fix the build with new Qt5 hash
1298         https://bugs.webkit.org/show_bug.cgi?id=103406
1299
1300         Reviewed by Csaba Osztrogonác.
1301
1302         Remove references to deprecated QApplication::GuiServer which
1303         has been removed, and use QStyleFactory::create instead of
1304         instantiating a QWindowsStyle directly since it is about to
1305         become an internal class.
1306
1307         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
1308         (main):
1309         * QtTestBrowser/qttestbrowser.cpp:
1310         (LauncherApplication::LauncherApplication):
1311         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1312         (WTR::InjectedBundle::platformInitialize):
1313
1314 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
1315
1316         [style] Add a style-check for enum-member names
1317         https://bugs.webkit.org/show_bug.cgi?id=103157
1318
1319         Reviewed by Daniel Bates.
1320
1321         * Scripts/webkitpy/style/checkers/cpp.py:
1322         (_EnumState):
1323         (_EnumState.__init__):
1324         (_EnumState.process_clean_line):
1325         (check_enum_casing):
1326         (check_style):
1327         (process_line):
1328         (_process_lines):
1329         (CppChecker):
1330         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1331         (NoNonVirtualDestructorsTest.test_enum_casing):
1332         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
1333
1334 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
1335
1336         [EFL][jhbuild] Disable unnecessary options of elementary module
1337         https://bugs.webkit.org/show_bug.cgi?id=103360
1338
1339         Reviewed by Gyuyoung Kim.
1340
1341         When jhbuild configures elementary, unnecessary options may be enabled by
1342         user installed modules and it causes build break.
1343
1344         * efl/jhbuild.modules:
1345         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
1346
1347 2012-11-26  Varun Jain  <varunjain@chromium.org>
1348
1349         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
1350         https://bugs.webkit.org/show_bug.cgi?id=101545
1351
1352         Reviewed by Antonio Gomes.
1353
1354         For LongPress, we simulate drag by sending a mouse down and mouse drag
1355         events. If a drag is not started (because maybe there is no draggable
1356         element), then we show context menu instead (which is the current
1357         behavior for LongPress). For LongTap, we use the existing functions that
1358         LongPress uses to summon the context menu. LongPress initiated drag and
1359         drop can be enabled/disabled by the platform using the Setting
1360         touchDragDropEnabled which is disabled by default.
1361
1362         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1363         (WebTestRunner):
1364         (WebTestRunner::EventSender::EventSender):
1365         (WebTestRunner::EventSender::gestureLongTap):
1366         (WebTestRunner::EventSender::gestureEvent):
1367         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1368         (EventSender):
1369         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1370         (WebTestRunner::TestRunner::TestRunner):
1371         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
1372         (WebTestRunner):
1373         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1374         (TestRunner):
1375
1376 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
1377
1378         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
1379         https://bugs.webkit.org/show_bug.cgi?id=103224
1380
1381         Reviewed by Laszlo Gombos.
1382
1383         Add --local-storage command line argument to MiniBrowser to
1384         explicitely disable HTML5 local storage functionality. This
1385         is useful for testing purposes.
1386
1387         * MiniBrowser/efl/main.c:
1388         (window_create):
1389         (elm_main):
1390
1391 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
1392
1393         Remove use of deprecated logging from most of webkitpy.tool
1394         https://bugs.webkit.org/show_bug.cgi?id=103180
1395
1396         Reviewed by Dirk Pranke.
1397
1398         Remove calls to log and error methods of the deprecated_logging module, replacing them
1399         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
1400         except the QueueEngine.
1401
1402         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
1403
1404         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1405         (MockCommitQueue.run_command):
1406         (MockCommitQueue.command_passed):
1407         (MockCommitQueue.command_failed):
1408         (MockCommitQueue.report_flaky_tests):
1409         (MockCommitQueue.archive_last_test_results):
1410         (CommitQueueTaskTest._run_through_task):
1411         (CommitQueueTaskTest.test_success_case):
1412         (test_fast_success_case):
1413         (test_clean_failure):
1414         (test_update_failure):
1415         (test_apply_failure):
1416         (test_validate_changelog_failure):
1417         (test_build_failure):
1418         (test_red_build_failure):
1419         (test_flaky_test_failure):
1420         (test_failed_archive):
1421         (test_double_flaky_test_failure):
1422         (test_test_failure):
1423         (test_red_test_failure):
1424         (test_very_red_tree_retry):
1425         (test_red_tree_patch_rejection):
1426         (test_land_failure):
1427         * Scripts/webkitpy/tool/bot/feeders.py:
1428         (CommitQueueFeeder._update_work_items):
1429         (EWSFeeder.feed):
1430         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1431         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1432         (LayoutTestResultsReader.archive):
1433         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1434         (test_archive_last_layout_test_results):
1435         * Scripts/webkitpy/tool/bot/sheriff.py:
1436         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1437         (AbstractSequencedCommand.execute):
1438         * Scripts/webkitpy/tool/commands/commandtest.py:
1439         (CommandsTest.assert_execute_outputs):
1440         * Scripts/webkitpy/tool/commands/download.py:
1441         (AbstractPatchProcessingCommand._process_patch.execute):
1442         (ProcessBugsMixin._fetch_list_of_patches_to_process):
1443         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1444         (AbstractRolloutPrepCommand._commit_info):
1445         * Scripts/webkitpy/tool/commands/download_unittest.py:
1446         (AbstractRolloutPrepCommandTest.test_commit_info):
1447         (DownloadCommandsTest.test_build):
1448         (DownloadCommandsTest.test_build_and_test):
1449         (test_apply_attachment):
1450         (test_apply_from_bug):
1451         (test_apply_watch_list):
1452         (test_land):
1453         (test_land_red_builders):
1454         (test_check_style):
1455         (test_build_attachment):
1456         (test_land_attachment):
1457         (test_land_from_bug):
1458         (test_land_from_url):
1459         (test_prepare_rollout):
1460         (test_create_rollout):
1461         (test_create_rollout_resolved):
1462         (test_rollout):
1463         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1464         (AbstractEarlyWarningSystem.handle_script_error.does):
1465         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1466         (EarlyWarningSytemTest._default_expected_stderr):
1467         (EarlyWarningSytemTest._default_expected_logs):
1468         (EarlyWarningSytemTest._test_testing_ews):
1469         * Scripts/webkitpy/tool/commands/openbugs.py:
1470         (OpenBugs.execute):
1471         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
1472         (OpenBugsTest.test_args_parsing):
1473         * Scripts/webkitpy/tool/commands/perfalizer.py:
1474         (Perfalizer.handle_unexpected_error):
1475         * Scripts/webkitpy/tool/commands/queries.py:
1476         (PatchesInCommitQueue.execute):
1477         (PatchesToCommitQueue._needs_commit_queue):
1478         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1479         (QueryCommandsTest.test_bugs_to_commit):
1480         (QueryCommandsTest.test_patches_in_commit_queue):
1481         (QueryCommandsTest.test_patches_to_commit_queue):
1482         * Scripts/webkitpy/tool/commands/queues.py:
1483         (AbstractQueue._cc_watchers):
1484         (AbstractQueue.begin_work_queue):
1485         (FeederQueue.handle_unexpected_error):
1486         (CommitQueue.handle_script_error):
1487         (AbstractReviewQueue.handle_unexpected_error):
1488         (AbstractReviewQueue.handle_script_error):
1489         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1490         (test_auto_retry):
1491         * Scripts/webkitpy/tool/commands/queuestest.py:
1492         (QueuesTest.assert_outputs):
1493         (QueuesTest._default_begin_work_queue_stderr):
1494         (QueuesTest):
1495         (QueuesTest._default_begin_work_queue_logs):
1496         (QueuesTest.assert_queue_outputs):
1497         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1498         (RollCommandsTest.test_update_chromium_deps):
1499         (test_update_chromium_deps_older_revision):
1500         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1501         (SheriffBot.handle_unexpected_error):
1502         * Scripts/webkitpy/tool/commands/stepsequence.py:
1503         (StepSequence.run_and_handle_errors):
1504         * Scripts/webkitpy/tool/commands/upload.py:
1505         (AssignToCommitter._assign_bug_to_last_patch_attacher):
1506         (AbstractPatchUploadingCommand._prepare_state):
1507         (PostCommits.execute):
1508         (MarkBugFixed._determine_bug_id_and_svn_revision):
1509         (MarkBugFixed.execute):
1510         (CreateBug.create_bug_from_commit):
1511         (CreateBug.execute):
1512         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1513         (test_obsolete_attachments):
1514         (test_land_safely):
1515         (test_mark_bug_fixed):
1516         * Scripts/webkitpy/tool/multicommandtool.py:
1517         (Command.check_arguments_and_execute):
1518         (MultiCommandTool.main):
1519         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1520         (CommandTest.test_required_arguments):
1521         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
1522         (AddSvnMimetypeForPng.run):
1523         * Scripts/webkitpy/tool/steps/applypatch.py:
1524         (ApplyPatch.run):
1525         * Scripts/webkitpy/tool/steps/build.py:
1526         (Build.run):
1527         * Scripts/webkitpy/tool/steps/checkstyle.py:
1528         * Scripts/webkitpy/tool/steps/closebug.py:
1529         (CloseBug.run):
1530         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
1531         (CloseBugForLandDiff.run):
1532         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1533         (CloseBugForLandDiffTest.test_empty_state):
1534         * Scripts/webkitpy/tool/steps/commit.py:
1535         (Commit.run):
1536         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1537         (CommitTest._test_check_test_expectations):
1538         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
1539         (EnsureLocalCommitIfNeeded.run):
1540         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1541         (ObsoletePatches.run):
1542         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1543         (PrepareChangeLog.run):
1544         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1545         (ReopenBugAfterRollout.run):
1546         * Scripts/webkitpy/tool/steps/runtests.py:
1547         (RunTests.run):
1548         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1549         (RunTestsTest.test_webkit_run_unit_tests):
1550         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1551         (StepsTest.test_update_step):
1552         (StepsTest.test_runtests_args):
1553         * Scripts/webkitpy/tool/steps/update.py:
1554         (Update.run):
1555         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1556         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
1557         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
1558         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1559         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
1560         (UpdateChangeLogsWithReviewer.run):
1561         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
1562         (UpdateChromiumDEPS._validate_revisions):
1563         (UpdateChromiumDEPS.run):
1564         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1565         (ValidateChangeLogs._check_changelog_diff):
1566         (ValidateChangeLogs.run):
1567         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1568         (ValidateChangeLogsTest._assert_start_line_produces_output):
1569         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1570         (ValidateReviewer.run):
1571
1572 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
1573
1574         Coverage testing in webkitpy should omit some paths
1575         https://bugs.webkit.org/show_bug.cgi?id=103267
1576
1577         Reviewed by Dirk Pranke.
1578
1579         Omit testing coverage of any file under /usr directory and any file
1580         that is of third party origin and was autoinstalled.
1581
1582         * Scripts/webkitpy/test/main.py:
1583         (Tester._run_tests):
1584
1585 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
1586
1587         Text Autosizing: Add Text Autosizing APIs for WK2
1588         https://bugs.webkit.org/show_bug.cgi?id=100633
1589
1590         Reviewed by Sam Weinig.
1591
1592         Add test cases for Text Autosizing in WKPreferences.
1593
1594         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1595         (TestWebKitAPI::TEST):
1596
1597 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
1598
1599         [Qt] REGRESSION(r135575): It made all tests assert
1600         https://bugs.webkit.org/show_bug.cgi?id=103169
1601
1602         Reviewed by Simon Hausmann.
1603
1604         This fixes another regression introduced in r135515:
1605         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
1606         since it can be called from WebKit2 to initialize QStyle for testing.
1607         This would then lead to things such as PlatformStrategies being
1608         initialized twice.
1609
1610         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
1611         (WebCore::DumpRenderTree::DumpRenderTree):
1612
1613 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
1614
1615         Add the --order option to NRWT
1616         https://bugs.webkit.org/show_bug.cgi?id=102229
1617
1618         Reviewed by Dirk Pranke.
1619
1620         The --order option controls in what order the gathered tests will be run.
1621         There are 3 options:
1622         - natural, the tests are sorted in natural order,
1623         - random, the tests are sorted in random order,
1624         - none, the tests are kept in the order in which they were specified through
1625         arguments or the test list.
1626
1627         The natural option is the default one and maintains the current behavior.
1628
1629         The none option is primarily intended to be used with the --test-list option,
1630         with the test list file expected to list specific test names.
1631         When a directory is specified as one of the paths from under which tests should
1632         be gathered and the none option is used, that path will expand to all the tests
1633         under it, with these tests sorted in the natural order.
1634
1635         Using --order=random duplicated the behavior of the --randomize-order option, so
1636         the latter is removed.
1637
1638         This patch also incorporates the change with which makes it is possible to specify
1639         a test via arguments or the test list multiple tests and then have the test run
1640         that many times.
1641
1642         * Scripts/webkitpy/common/find_files.py:
1643         (find): Accept an optional sorting key that is used to sort files found in the directories
1644         that the given paths specify.
1645         (_normalized_find): Both paths that are then searched for the tests and the tests that
1646         were found are now kept in lists. This makes it possible to run a test multiple times
1647         by specifying it multiple times through arguments or the test list file.
1648         (_normalized_find.sort_by_directory_key):
1649         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1650         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
1651         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
1652         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1653         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
1654         (Sharder.__init__): Ditto.
1655         (Sharder._resize_shards):
1656         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1657         (SharderTests.get_shards): Modify the Shader initializing as required.
1658         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
1659         are now moved to the base Port unit tests.
1660         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1661         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
1662         the new --order option.
1663         * Scripts/webkitpy/layout_tests/port/base.py:
1664         (Port.tests): This method should now return a list of all the tests found in the specified
1665         paths.
1666         (Port._real_tests): A list is required, so no conversion to a set is made.
1667         (Port):
1668         (Port.test_key): Place this method here for now, but it should really move into a separate
1669         module.
1670         (Port._natural_sort_key): Ditto.
1671         (Port._natural_sort_key.tryint):
1672         (Port._virtual_tests): A list is required, so the function now operates on that rather than
1673         on a set.
1674         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1675         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
1676         list rather than an empty set.
1677         (PortTest.test_dont_require_http_server):
1678         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
1679         (NaturalCompareTest.assert_cmp):
1680         (NaturalCompareTest.test_natural_compare):
1681         (KeyCompareTest): The test name key unit tests are placed here for now.
1682         (KeyCompareTest.assert_cmp):
1683         (KeyCompareTest.test_test_key):
1684         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1685         (parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
1686         by using --order=random.
1687         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
1688         various aspects of this change.
1689         (MainTest.test_natural_order):
1690         (MainTest):
1691         (MainTest.test_natural_order_test_specified_multiple_times):
1692         (MainTest.test_random_order):
1693         (MainTest.test_random_order_test_specified_multiple_times):
1694         (MainTest.test_no_order):
1695         (MainTest.test_no_order_test_specified_multiple_times):
1696         (MainTest.test_no_order_with_directory_entries_in_natural_order):
1697         * Scripts/webkitpy/tool/commands/queries.py:
1698         (PrintExpectations.execute): Operate on a set of tests when printing out expectations.
1699
1700 2012-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1701
1702         Unreviewed, rolling out r135600.
1703         http://trac.webkit.org/changeset/135600
1704         https://bugs.webkit.org/show_bug.cgi?id=103173
1705
1706         It made EFL API test is failed (Requested by gyuyoung_mbp on
1707         #webkit).
1708
1709         * TestWebKitAPI/PlatformEfl.cmake:
1710         * TestWebKitAPI/efl/PlatformUtilities.cpp:
1711         (TestWebKitAPI::Util::sleep):
1712         * TestWebKitAPI/efl/PlatformWebView.cpp:
1713
1714 2012-11-23  Alexis Menard  <alexis@webkit.org>
1715
1716         [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
1717         https://bugs.webkit.org/show_bug.cgi?id=102104
1718
1719         Reviewed by Julien Chaffraix.
1720
1721         Protect the new feature behind a feature flag.
1722
1723         * Scripts/webkitperl/FeatureList.pm:
1724         * qmake/mkspecs/features/features.pri:
1725
1726 2012-11-23  Mario Sanchez Prada  <mario@webkit.org>
1727
1728         Unreviewed. Update my e-mail address.
1729
1730         * Scripts/webkitpy/common/config/committers.py:
1731
1732 2012-11-23  Mateusz Leszko  <m.leszko@samsung.com>
1733
1734         [EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
1735         https://bugs.webkit.org/show_bug.cgi?id=100757
1736
1737         Reviewed by Laszlo Gombos.
1738
1739         Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
1740         Updating CMake files due to changes from Bug 99011.
1741
1742         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1743         (WTR::AccessibilityController::AccessibilityController):
1744         (WTR):
1745         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1746         (AccessibilityController):
1747         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1748         (WTR):
1749         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1750         (AccessibilityUIElement):
1751         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
1752         * WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
1753
1754 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
1755
1756         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
1757         https://bugs.webkit.org/show_bug.cgi?id=102510
1758
1759         Reviewed by Pavel Feldman.
1760
1761         Added missing includes.
1762
1763         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1764
1765 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1766
1767         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
1768         https://bugs.webkit.org/show_bug.cgi?id=103123
1769
1770         Reviewed by Kenneth Rohde Christiansen.
1771
1772         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
1773         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
1774
1775         * TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
1776         test.
1777         * TestWebKitAPI/efl/PlatformUtilities.cpp:
1778         (TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
1779         test case is passing 0.5 seconds to sleep.
1780         * TestWebKitAPI/efl/PlatformWebView.cpp:
1781         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
1782         (TestWebKitAPI):
1783
1784 2012-11-23  Wojciech Bielawski  <w.bielawski@samsung.com>
1785
1786         [WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
1787         https://bugs.webkit.org/show_bug.cgi?id=86881
1788
1789         Reviewed by Kenneth Rohde Christiansen.
1790
1791         eventSender object extended with contextClick() method in WebKitTestRunner.
1792         contextClick() method returns an array of menu items objects with field 'title' containing title of single
1793         context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
1794         delivered in this patch.
1795
1796         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1797         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1798         (WTR::EventSendingController::contextClick):
1799         (WTR):
1800         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1801         (EventSendingController):
1802
1803 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
1804
1805         [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
1806         https://bugs.webkit.org/show_bug.cgi?id=102942
1807
1808         Reviewed by Tor Arne Vestbø.
1809
1810         Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
1811         macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
1812         to follow the same rules as other Qt 5 modules, with the exception that instead of
1813         QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
1814         in other cross-platform header files to determine the correct meaning of export
1815         macros.
1816
1817         * qmake/mkspecs/features/default_post.prf:
1818         * qmake/mkspecs/features/win32/default_post.prf:
1819
1820 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
1821
1822         [Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
1823         https://bugs.webkit.org/show_bug.cgi?id=103111
1824
1825         Reviewed by Kenneth Rohde Christiansen.
1826
1827         This function was added as a slot during Qt 4.x times because adding
1828         virtual functions breaks binary compatibility. This constraint is gone
1829         with the initial release of WebKit with Qt 5, and therefore we can
1830         make it virtual now.
1831
1832         The change is fully source compatible as existing "re-implementations"
1833         as slots will now be called through it being a virtual function. They
1834         become unused slots.
1835
1836         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1837         (WebCore::WebPage::shouldInterruptJavaScript):
1838         (WebPage):
1839         * QtTestBrowser/webpage.h:
1840         (WebPage):
1841
1842 2012-11-22  Peter Beverloo  <peter@chromium.org>
1843
1844         [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
1845         https://bugs.webkit.org/show_bug.cgi?id=103065
1846
1847         Reviewed by Dirk Pranke.
1848
1849         This addresses two further reliability issues in the Android test running
1850         scripts. Firstly, the run_tests.py script needs to have the --exit_code
1851         argument passed in order to return non-zero codes, which we need for the
1852         build master to distinguish failures from successful runs.
1853
1854         Secondly, it modifies the layout test runner to briefly wait (through
1855         the wait-for-device command) after requesting a device to switch to root
1856         mode. Without this waiting period, commands might get lost and thereby
1857         unexpectedly fail.
1858
1859         * Scripts/run-api-tests:
1860         * Scripts/run-chromium-webkit-unit-tests:
1861         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1862         (ChromiumAndroidDriver._setup_test):
1863         (ChromiumAndroidDriver._restart_adb_as_root):
1864
1865 2012-11-22  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>
1866
1867         [Qt] Separate QWidget dependant code into separate WebKitWidgets static library
1868         https://bugs.webkit.org/show_bug.cgi?id=102800
1869
1870         Reviewed by Tor Arne Vestbø.
1871
1872         This patch separates code that needs to use QWidget related APIs in
1873         WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
1874         example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
1875         while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
1876         static library. WebKit1 is compiled without QT += widgets and therefore
1877         any widget related dependency has been moved "up" and out of WebKit1 into
1878         the WebKitWidgets library.
1879
1880         Between the code in WebKit.a and WebKitWidgets.a new adapters and
1881         interfaces have been introduced, such as QWebPageAdapter and
1882         QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
1883         call out into the API layer, implemented by QWebPage (QWebPagePrivate).
1884         The other way around if QWebPage wants to access WebCore or
1885         WebCoreSupport related functionality, it will go through
1886         QWebPageAdapater (as base class). The separation in the direction up
1887         into the API layer is complete with this patch, no code in WebKit1
1888         depends on QtWidgets. The separation the other way around, code in the
1889         API layer not using any WebCore types, is not complete yet.
1890
1891         Some classes such as QWebSettings, QWebElement or
1892         DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
1893         they do not depend on widget related Qt APIs and they make much more
1894         use of WebCore internal APIs and therefore are easier to keep in
1895         WebKit1.
1896
1897         In the future we plan to place a real shared library boundary between
1898         WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
1899         part of the QtWebKit shared library and by turning the WebKitWidgets
1900         static library into a shared one.
1901
1902         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1903         (WebCore::WebPage::resetSettings):
1904         (WebCore::WebPage::createWindow):
1905         (WebCore::DumpRenderTree::DumpRenderTree):
1906         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1907         (WebCore::DumpRenderTree::initJSObjects):
1908         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
1909         (WebCore::DumpRenderTree::dumpFramesAsText):
1910         (WebCore::DumpRenderTree::dump):
1911         (WebCore::DumpRenderTree::createWindow):
1912         (WebCore::DumpRenderTree::pageAdapter):
1913         (WebCore):
1914         (WebCore::DumpRenderTree::mainFrameAdapter):
1915         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1916         (DumpRenderTree):
1917         * DumpRenderTree/qt/EventSenderQt.cpp:
1918         (EventSender::contextClick):
1919         (EventSender::scalePageBy):
1920         * DumpRenderTree/qt/TestRunnerQt.cpp:
1921         (TestRunner::reset):
1922         (TestRunner::display):
1923         (TestRunner::closeWebInspector):
1924         (TestRunner::showWebInspector):
1925         (TestRunner::evaluateInWebInspector):
1926         (TestRunner::setFrameFlatteningEnabled):
1927         (TestRunner::goBack):
1928         (TestRunner::setDefersLoading):
1929         (TestRunner::pauseAnimationAtTimeOnElementWithId):
1930         (TestRunner::pauseTransitionAtTimeOnElementWithId):
1931         (TestRunner::numberOfActiveAnimations):
1932         (TestRunner::setCaretBrowsingEnabled):
1933         (TestRunner::setAuthorAndUserStylesEnabled):
1934         (TestRunner::callShouldCloseOnWebView):
1935         (TestRunner::setSmartInsertDeleteEnabled):
1936         (TestRunner::setSelectTrailingWhitespaceEnabled):
1937         (TestRunner::execCommand):
1938         (TestRunner::isCommandEnabled):
1939         (TestRunner::findString):
1940         (TestRunner::elementDoesAutoCompleteForElementWithId):
1941         (TestRunner::setMockDeviceOrientation):
1942         (TestRunner::setGeolocationPermission):
1943         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1944         (TestRunner::setMockGeolocationPositionUnavailableError):
1945         (TestRunner::setMockGeolocationPosition):
1946         (TestRunner::evaluateScriptInIsolatedWorld):
1947         (TestRunner::addUserStyleSheet):
1948         (TestRunner::setMinimumTimerInterval):
1949         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1950         (TextInputController::selectedRange):
1951         (TextInputController::firstRectForCharacterRange):
1952         (TextInputController::unmarkText):
1953         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1954         (LoadAlternateHTMLStringItem::invoke):
1955         * qmake/mkspecs/features/default_post.prf:
1956         * qmake/mkspecs/features/production_build.prf:
1957         * qmake/mkspecs/features/webkit_modules.prf:
1958         * qmake/mkspecs/modules/webkitwidgets.prf: Added.
1959
1960 2012-11-22  Christophe Dumez  <christophe.dumez@intel.com>
1961
1962         WebKitTestRunner needs layoutTestController.setCacheModel
1963         https://bugs.webkit.org/show_bug.cgi?id=42684
1964
1965         Reviewed by Kenneth Rohde Christiansen.
1966
1967         Add support for testRunner.setCacheModel to WebKitTestRunner.
1968
1969         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1970         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1971         (WTR::InjectedBundle::beginTesting):
1972         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1973         (WTR::TestRunner::setCacheModel):
1974         (WTR):
1975         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1976         (TestRunner):
1977
1978 2012-11-22  Balazs Kelemen  <kbalazs@webkit.org>
1979
1980         [Qt][WTR] TestController::platformRunUntil should not do busy waiting
1981         https://bugs.webkit.org/show_bug.cgi?id=101327
1982
1983         Reviewed by Simon Hausmann.
1984
1985         Avoid busy waiting for events in platformRunUntil while making
1986         sure we don't change the behavior of modal event loops.
1987
1988         * WebKitTestRunner/TestController.cpp:
1989         (WTR::TestController::~TestController):
1990         * WebKitTestRunner/TestController.h:
1991         (TestController):
1992         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1993         (WTR::TestController::platformDestroy):
1994         (WTR):
1995         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1996         (WTR::TestController::platformDestroy):
1997         (WTR):
1998         * WebKitTestRunner/mac/TestControllerMac.mm:
1999         (WTR::TestController::platformDestroy):
2000         (WTR):
2001         * WebKitTestRunner/qt/TestControllerQt.cpp:
2002         (TestController::RunLoop): Helper class to handle
2003         the event loop logic
2004         (WTR):
2005         (WTR::TestController::RunLoop::RunLoop):
2006         (WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
2007         the run loop. This is the appropriate API to push the WaitForMoreEvents
2008         flag to QCoreApplication::processEvents and also being able to exit the
2009         loop if we have timed out.
2010         (WTR::TestController::RunLoop::notifyDone):
2011         (WTR::TestController::RunLoop::timerFired):
2012         (WTR::TestController::RunLoop::runModal):
2013         (WTR::TestController::notifyDone):
2014         (WTR::TestController::platformInitialize):
2015         (WTR::TestController::platformDestroy):
2016         (WTR::TestController::platformRunUntil):
2017         (WTR::TestController::runModal):
2018         * WebKitTestRunner/win/TestControllerWin.cpp:
2019         (WTR::TestController::platformDestroy):
2020         (WTR):
2021
2022 2012-11-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2023
2024         [EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
2025         https://bugs.webkit.org/show_bug.cgi?id=102926
2026
2027         Reviewed by Kenneth Rohde Christiansen.
2028
2029         Add missing bits needed by WKPreferences and AboutBlankLoad API
2030         tests in the test harness and enable these tests on EFL port.
2031
2032         * TestWebKitAPI/PlatformEfl.cmake:
2033         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2034         (TestWebKitAPI::TEST):
2035         * TestWebKitAPI/efl/PlatformUtilities.cpp:
2036         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2037         (Util):
2038
2039 2012-11-21  Zan Dobersek  <zandobersek@gmail.com>
2040
2041         [GTK][WTR] Implement AccessibilityUIElement::stringValue
2042         https://bugs.webkit.org/show_bug.cgi?id=102951
2043
2044         Reviewed by Martin Robinson.
2045
2046         Implement AccessibilityUIElement::stringValue in the ATK backend
2047         in the same manner it is implemented in DumpRenderTree.
2048
2049         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2050         (WTR::replaceCharactersForResults):
2051         (WTR):
2052         (WTR::AccessibilityUIElement::stringValue):
2053
2054 2012-11-21  Vineet Chaudhary  <rgf748@motorola.com>
2055
2056         Unreviewed. Adding myself to committers.py.
2057
2058         * Scripts/webkitpy/common/config/committers.py:
2059
2060 2012-11-21  Tien-Ren Chen  <trchen@chromium.org>
2061
2062         [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
2063         https://bugs.webkit.org/show_bug.cgi?id=100061
2064
2065         Reviewed by Adam Barth.
2066
2067         On Android we're using a different pixel scaling implementation
2068         (WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
2069         platforms. In this mode, we don't make use of device-independent pixels. Device
2070         scale factor is provided to WebKit and get merged into page scale factor. Other
2071         than that device scale factor should have no effects on rendering.
2072
2073         * DumpRenderTree/chromium/WebPreferences.cpp:
2074         (WebPreferences::applyTo):
2075
2076 2012-11-21  Fady Samuel  <fsamuel@chromium.org>
2077
2078         Clear MousePressed state on context menu to avoid initiating a drag
2079         https://bugs.webkit.org/show_bug.cgi?id=101786
2080
2081         Reviewed by Ojan Vafai.
2082
2083         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2084         (WebTestRunner):
2085         (WebTestRunner::EventSender::EventSender):
2086         (WebTestRunner::EventSender::contextClick):
2087         Only send a MouseUp on Windows. Keep the current mouse pressed state when
2088         calling up a context menu.
2089
2090 2012-11-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2091
2092         [EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
2093         https://bugs.webkit.org/show_bug.cgi?id=102895
2094
2095         Reviewed by Gyuyoung Kim.
2096
2097         Change the link order so it wont override the new operator on gtest.
2098         Looks like it was crashing because an allocator mismatch (using libc's
2099         new and later fastMalloc delete. Thanks to Kangil Han for hinting on
2100         the fastMalloc issue.
2101
2102         * TestWebKitAPI/CMakeLists.txt:
2103
2104 2012-11-21  Kentaro Hara  <haraken@chromium.org>
2105
2106         Unreviewed, rolling out r135340.
2107         http://trac.webkit.org/changeset/135340
2108         https://bugs.webkit.org/show_bug.cgi?id=102492
2109
2110         It broke Safari's internal build
2111
2112         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2113         (new):
2114         (GenerateModule):
2115         (GenerateInterface):
2116         (finish):
2117
2118 2012-11-21  Yael Aharon  <yael.aharon@intel.com>, Gyuyoung Kim <gyuyoung.kim@samsung.com>
2119
2120         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
2121         https://bugs.webkit.org/show_bug.cgi?id=101526
2122
2123         Reviewed by Kenneth Rohde Christiansen.
2124
2125         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
2126
2127         * Scripts/webkitperl/FeatureList.pm:
2128         * TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
2129
2130 2012-11-21  Jongseok Yang  <js45.yang@samsung.com>
2131
2132         [EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
2133         https://bugs.webkit.org/show_bug.cgi?id=102867
2134
2135         Reviewed by Gyuyoung Kim.
2136
2137         Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.
2138
2139         ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
2140         because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
2141         And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.
2142
2143         * MiniBrowser/efl/main.c:
2144         (on_key_down):
2145
2146 2012-11-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2147
2148         Unreviewed, rolling out r133859.
2149         http://trac.webkit.org/changeset/133859
2150         https://bugs.webkit.org/show_bug.cgi?id=102875
2151
2152         This patch makes API test broken (Requested by gyuyoung on
2153         #webkit).
2154
2155         * Scripts/webkitperl/FeatureList.pm:
2156
2157 2012-11-20  Jinwoo Song  <jinwoo7.song@samsung.com>
2158
2159         [EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
2160         https://bugs.webkit.org/show_bug.cgi?id=99114
2161
2162         Reviewed by Gyuyoung Kim.
2163
2164         Implemented window_create and window_close smartcallback functions.
2165
2166         * MiniBrowser/efl/main.c:
2167         (on_window_create):
2168         (on_window_close):
2169         (window_create):
2170
2171 2012-11-20  Ojan Vafai  <ojan@chromium.org>
2172
2173         Simplify builder filters now that we have lists of which builders run which tests
2174         https://bugs.webkit.org/show_bug.cgi?id=102849
2175
2176         Reviewed by Dirk Pranke.
2177
2178         We only need filters when we load the same master for multiple groups in the
2179         same test type, i.e. when we need to only include some of the builders that run
2180         a given test suite on a given master.
2181
2182         Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
2183         Now just make it a method on BuilderGroup.
2184
2185         * TestResultServer/static-dashboards/builders.js:
2186         (BuilderGroup.prototype.append):
2187         (BuilderGroup.prototype.setup):
2188         (BuilderGroup.prototype._defaultBuilder):
2189         (BuilderGroup.prototype.master):
2190         (requestBuilderList):
2191         (isChromiumWebkitTipOfTreeTestRunner):
2192         (isChromiumWebkitDepsTestRunner):
2193         (loadBuildersList):
2194         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2195         (test):
2196
2197 2012-11-20  Ojan Vafai  <ojan@chromium.org>
2198
2199         Remove perfav master for webkit_unit_tests and test_shell_tests.
2200         There are no bots on this master that run these tests.
2201         * TestResultServer/static-dashboards/builders.js:
2202
2203 2012-11-20  Ojan Vafai  <ojan@chromium.org>
2204
2205         Remove special case for layout tests when builders fail to load
2206         https://bugs.webkit.org/show_bug.cgi?id=102842
2207
2208         Reviewed by Tony Chang.
2209
2210         Now that we load only builders that actually run the given test
2211         type, we can reliably show errors to the users because it
2212         represents a broken bot.
2213         * TestResultServer/static-dashboards/loader.js:
2214
2215 2012-11-15  Ojan Vafai  <ojan@chromium.org>
2216
2217         Generate a list of builders/test suites from the buildbot json
2218         https://bugs.webkit.org/show_bug.cgi?id=102443
2219
2220         Reviewed by Dirk Pranke.
2221
2222         Instead of the cludgy things we do now to track which bots run which tests,
2223         we generate all that data from the buildbots' json files.
2224         This is the minimal amount to keep everything working. Once this lands,
2225         we can also do a bunch of followup cleanup.
2226
2227         For now we commit the generated data. In theory, in the future, we could
2228         have the test results server generate the data on the fly.
2229
2230         For the sake of easily understanding what changes when we run the generate script,
2231         also checkin a pretty printed version of the output. The pretty printed version
2232         is too large to serve as part of the flakiness dashboard though.
2233
2234         This also has the benefit of making the dashboard load much faster since
2235         we no longer ever need to block on requests to buildbot.
2236
2237         * TestResultServer/generate_builders_json.py: Added.
2238         (master_json_url):
2239         (builder_json_url):
2240         (cached_build_json_url):
2241         (fetch_json):
2242         (insert_builder_and_test_data):
2243         (main):
2244         * TestResultServer/generate_builders_json_unittest.py: Added.
2245         (GenerateBuildersJsonTest):
2246         (GenerateBuildersJsonTest.test_master_json_url):
2247         (GenerateBuildersJsonTest.test_builder_json_url):
2248         (GenerateBuildersJsonTest.test_cached_build_json_url):
2249         (GenerateBuildersJsonTest.test_generate_json_data):
2250         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2251         * TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
2252         * TestResultServer/static-dashboards/builders.js:
2253         (LOAD_BUILDBOT_DATA):
2254         (BuilderGroup):
2255         (BuilderGroup.prototype.append):
2256         (BuilderGroup.prototype.master):
2257         (requestBuilderList):
2258         * TestResultServer/static-dashboards/builders.jsonp: Added.
2259         * TestResultServer/static-dashboards/builders_unittests.js: Added.
2260         * TestResultServer/static-dashboards/dashboard_base.js:
2261         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2262         (showPopupForBuild):
2263         (htmlForTestResults):
2264         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2265         (loadExpectationsLayoutTests):
2266         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2267         (resetGlobals):
2268         (test):
2269         * TestResultServer/static-dashboards/loader.js:
2270         * TestResultServer/static-dashboards/loader_unittests.js:
2271         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2272         * TestResultServer/static-dashboards/run-unittests.html:
2273         * TestResultServer/static-dashboards/timeline_explorer.html:
2274
2275 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2276
2277         [WTR][Qt] Enable fixedLayout when needed by the test
2278         https://bugs.webkit.org/show_bug.cgi?id=102811
2279
2280         Reviewed by Kenneth Rohde Christiansen.
2281
2282         Create a flickable view for CSS Device Adaptation tests. This is
2283         crucial for testing them since they will change the size of the
2284         viewport.
2285
2286         * WebKitTestRunner/PlatformWebView.h:
2287         (PlatformWebView):
2288         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2289         (WTR::PlatformWebView::PlatformWebView):
2290         (WTR::PlatformWebView::viewSupportsOptions):
2291         (WTR):
2292         * WebKitTestRunner/qt/main.cpp:
2293         (main):
2294
2295 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2296
2297         [WTR] WebKitTestRunner should be able to run tests using fixed layout
2298         https://bugs.webkit.org/show_bug.cgi?id=102517
2299
2300         Reviewed by Kenneth Rohde Christiansen.
2301
2302         WTR will now request the creation of a view that has a page using
2303         fixed layout for CSS Device Adaptation tests, but this feature might
2304         be used in the future by any other test that requires a mobile-like type
2305         of viewport (i.e. Viewport META tests should be ported).
2306
2307         The viewport type of the other tests remains unchanged and is restored
2308         when the runner leaves the device-adapt/ folder.
2309
2310         * WebKitTestRunner/PlatformWebView.h:
2311         (PlatformWebView):
2312         * WebKitTestRunner/TestInvocation.cpp:
2313         (WTR):
2314         (WTR::shouldUseFixedLayout):
2315         (WTR::updateLayoutType):
2316         (WTR::TestInvocation::invoke):
2317         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2318         (WTR::PlatformWebView::PlatformWebView):
2319         (WTR::PlatformWebView::viewSupportsOptions):
2320         (WTR):
2321
2322 2012-11-20  Csaba Osztrogonác  <ossy@webkit.org>
2323
2324         [Qt] REGRESSION(r128174): Fast build path doesn't work now
2325         https://bugs.webkit.org/show_bug.cgi?id=100360
2326
2327         Reviewed by Tor Arne Vestbø.
2328
2329         Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.
2330
2331         * Scripts/webkitdirs.pm:
2332         (buildQMakeProjects):
2333
2334 2012-11-20  Mateusz Leszko  <m.leszko@samsung.com>
2335
2336         [EFL][GTK]Sharing accessibility support in WebKitTestRunner.
2337         https://bugs.webkit.org/show_bug.cgi?id=99011
2338
2339         Reviewed by Martin Robinson.
2340
2341         Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.
2342
2343         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
2344         (WTR::AccessibilityController::logAccessibilityEvents):
2345         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.
2346
2347 2012-11-20  Zan Dobersek  <zandobersek@gmail.com>
2348
2349         webkitpy unit tests should run serially when checking code coverage
2350         https://bugs.webkit.org/show_bug.cgi?id=102693
2351
2352         Reviewed by Dirk Pranke.
2353
2354         When checking code coverage, the unit tests should not be run in parallel
2355         as this causes the tracing functions (set via sys.settrace in the coverage
2356         module) being overriden, resulting in incorrect coverage reports.
2357
2358         * Scripts/webkitpy/test/main.py:
2359         (Tester._run_tests):
2360
2361 2012-11-19  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
2362
2363         [EFL] Add fallback for WebkitTestRunner if opengl is not available.
2364         https://bugs.webkit.org/show_bug.cgi?id=102704
2365
2366         Reviewed by Laszlo Gombos.
2367
2368         Add fallback to non-opengl evas engine in WebkitTestRunner if opengl is not available.
2369
2370         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2371         (WTR::initEcoreEvas):
2372
2373 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
2374
2375         [garden-o-matic] Switch frontend to use the gardeningserver.
2376         https://bugs.webkit.org/show_bug.cgi?id=102712
2377
2378         Reviewed by Dirk Pranke.
2379
2380         Instead of serving garden-o-matic frontend as file, we now serve it from the gardening server. This enables
2381         using garden-o-matic in a Chrome OS device, with a separate machine as a headless server.
2382
2383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Changed CSP policy to use 'self'.
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Removed now-unnecessary references to kLocalServerURL.
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Tweaked the test expectation.
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Removed kLocalServerURL.
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Spuriously updated the name of the webkit-patch command.
2388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Removed kLocalServerURL.
2389         * Scripts/webkitpy/tool/servers/gardeningserver.py: Changed to use the new launch URL.
2390
2391 2012-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2392
2393         Unreviewed, rolling out r135172.
2394         http://trac.webkit.org/changeset/135172
2395         https://bugs.webkit.org/show_bug.cgi?id=102710
2396
2397         Broke some WebKit2 api tests :( (Requested by japhet on
2398         #webkit).
2399
2400         * DumpRenderTree/chromium/WebViewHost.cpp:
2401         (WebViewHost::updateForCommittedLoad):
2402
2403 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
2404
2405         [garden-o-matic] Enable serving garden-o-matic with gardeningserver.
2406         https://bugs.webkit.org/show_bug.cgi?id=102703
2407
2408         Reviewed by Ojan Vafai.
2409
2410         To enable gardening from a Chrome OS device, we need the ability to serve garden-o-matic
2411         from the same origin as the gardening server. This change gently massages the current
2412         logic to adapt an extension-sniffing-based approach of identifying static files,
2413         rather than requiring an explicit list.
2414
2415         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2416         (ReflectionHandler): Replaced STATIC_FILE_NAMES with STATIC_FILE_EXTENSIONS.
2417         (ReflectionHandler._handle_request): Changed the logic to smell for extensions, rather than specific files.
2418         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py: Added.
2419
2420 2012-11-19  Ojan Vafai  <ojan@chromium.org>
2421
2422         Add DOM and HTML watchlists and add myself to a bunch of lists
2423         https://bugs.webkit.org/show_bug.cgi?id=102707
2424
2425         Reviewed by Eric Seidel.
2426
2427         * Scripts/webkitpy/common/config/watchlist:
2428
2429 2012-11-19  Jochen Eisinger  <jochen@chromium.org>
2430
2431         [chromium] move methods that only use the WebKit API from DRTTestRunner to TestRunner
2432         https://bugs.webkit.org/show_bug.cgi?id=102676
2433
2434         Reviewed by Tony Chang.
2435
2436         In addition, I've replaced parsePageNumber with the more commonly used
2437         cppVariantToInt32, moved abortModal to the list of stubbed out methods,
2438         and removed setAutomaticLinkDetectionEnabled which wasn't used
2439         anywhere.
2440
2441         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2442         (DRTTestRunner::DRTTestRunner):
2443         (DRTTestRunner::reset):
2444         (DRTTestRunner::overridePreference):
2445         * DumpRenderTree/chromium/DRTTestRunner.h:
2446         (DRTTestRunner):
2447         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2448         (WebTestRunner::TestRunner::TestRunner):
2449         (WebTestRunner::TestRunner::reset):
2450         (WebTestRunner):
2451         (WebTestRunner::TestRunner::setTabKeyCyclesThroughElements):
2452         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
2453         (WebTestRunner::TestRunner::execCommand):
2454         (WebTestRunner::TestRunner::isCommandEnabled):
2455         (WebTestRunner::TestRunner::pauseAnimationAtTimeOnElementWithId):
2456         (WebTestRunner::TestRunner::pauseTransitionAtTimeOnElementWithId):
2457         (WebTestRunner::TestRunner::elementDoesAutoCompleteForElementWithId):
2458         (WebTestRunner::TestRunner::numberOfActiveAnimations):
2459         (WebTestRunner::TestRunner::callShouldCloseOnWebView):
2460         (WebTestRunner::TestRunner::setDomainRelaxationForbiddenForURLScheme):
2461         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
2462         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorld):
2463         (WebTestRunner::TestRunner::setIsolatedWorldSecurityOrigin):
2464         (WebTestRunner::TestRunner::setIsolatedWorldContentSecurityPolicy):
2465         (WebTestRunner::TestRunner::addOriginAccessWhitelistEntry):
2466         (WebTestRunner::TestRunner::removeOriginAccessWhitelistEntry):
2467         (WebTestRunner::TestRunner::hasCustomPageSizeStyle):
2468         (WebTestRunner::TestRunner::forceRedSelectionColors):
2469         (WebTestRunner::TestRunner::addUserScript):
2470         (WebTestRunner::TestRunner::addUserStyleSheet):
2471         (WebTestRunner::TestRunner::startSpeechInput):
2472         (WebTestRunner::TestRunner::loseCompositorContext):
2473         (WebTestRunner::TestRunner::markerTextForListItem):
2474         (WebTestRunner::TestRunner::findString):
2475         (WebTestRunner::TestRunner::setMinimumTimerInterval):
2476         (WebTestRunner::TestRunner::setAutofilled):
2477         (WebTestRunner::TestRunner::setValueForUser):
2478         (WebTestRunner::TestRunner::enableFixedLayoutMode):
2479         (WebTestRunner::TestRunner::setFixedLayoutSize):
2480         (WebTestRunner::TestRunner::selectionAsMarkup):
2481         (WebTestRunner::TestRunner::setTextSubpixelPositioning):
2482         (WebTestRunner::TestRunner::resetPageVisibility):
2483         (WebTestRunner::TestRunner::setPageVisibility):
2484         (WebTestRunner::TestRunner::setTextDirection):
2485         (WebTestRunner::TestRunner::textSurroundingNode):
2486         (WebTestRunner::TestRunner::workerThreadCount):
2487         (WebTestRunner::TestRunner::cppVariantToBool):
2488         (WebTestRunner::TestRunner::cppVariantToInt32):
2489         (WebTestRunner::TestRunner::cppVariantToWebString):
2490         (WebTestRunner::TestRunner::cppVariantToWebStringArray):
2491         (WebTestRunner::TestRunner::printErrorMessage): formerly logErrorToConsole
2492         (WebTestRunner::TestRunner::fallbackMethod):
2493         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2494         (WebKit):
2495         (WebTestRunner::TestRunner::setWebView):
2496         (TestRunner):
2497         * DumpRenderTree/chromium/TestShell.cpp:
2498         (TestShell::createMainWindow):
2499         (TestShell::~TestShell):
2500
2501 2012-11-19  Yusuke Sato  <yusukes@chromium.org>
2502
2503         [Chromium] Flash cannot receive scroll events when threaded compositing is in use
2504         https://bugs.webkit.org/show_bug.cgi?id=101423
2505
2506         Reviewed by James Robinson.
2507
2508         Call setWantsWheelEvents(true) in initialize() so that gesture-events and transformed-events tests in
2509         LayoutTests/platform/chromium/plugins/ will not fail even if a buildbot introduces threaded compositing
2510         in the future.
2511
2512         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2513         (TestWebPlugin::initialize):
2514
2515 2012-11-19  Nate Chapin  <japhet@chromium.org>
2516
2517         Move empty loading to DocumentLoader, simplify FrameLoader::init()
2518         https://bugs.webkit.org/show_bug.cgi?id=101512
2519
2520         Reviewed by Adam Barth.
2521
2522         Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
2523         interprets them as a non-empty load. This ensures
2524         http/tests/navigation/new-window-redirect-history.html continues to pass
2525         in chromium.
2526
2527         * DumpRenderTree/chromium/WebViewHost.cpp:
2528         (WebViewHost::updateForCommittedLoad):
2529
2530 2012-11-19  Vincent Scheib  <scheib@chromium.org>
2531
2532         [Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock.
2533         https://bugs.webkit.org/show_bug.cgi?id=96946
2534
2535         Reviewed by Adam Barth.
2536
2537         The runtime flag functionality has already been removed.
2538         Now that Chromium no longer has a compile dependency on this
2539         API, it can be removed as well.
2540
2541         * DumpRenderTree/chromium/TestShell.cpp:
2542         (TestShell::TestShell):
2543
2544 2012-11-19  Kihong Kwon  <kihong.kwon@samsung.com>
2545
2546         Add PROXIMITY_EVENTS feature
2547         https://bugs.webkit.org/show_bug.cgi?id=102658
2548
2549         Reviewed by Kentaro Hara.
2550
2551         Add PROXIMITY_EVENTS feature to FeatureList and qmake.
2552
2553         * Scripts/webkitperl/FeatureList.pm:
2554         * qmake/mkspecs/features/features.pri:
2555
2556 2012-11-19  Christophe Dumez  <christophe.dumez@intel.com>
2557
2558         [WK2][WTR] Memory leak in TestController::initialize()
2559         https://bugs.webkit.org/show_bug.cgi?id=102616
2560
2561         Reviewed by Kenneth Rohde Christiansen.
2562
2563         Remove call to WKStringCreateWithUTF8CString() to construct
2564         the icon database path which was leaking memory since the
2565         returned WKStringRef was not adopted. The code now uses
2566         WTF::String instead of std::string and converts it to a
2567         WKStringRef using toWK().
2568
2569         * WebKitTestRunner/StringFunctions.h:
2570         (WTR::toWK): Overload toWK() to take a WTF::String in
2571         argument.
2572         (WTR):
2573         * WebKitTestRunner/TestController.cpp:
2574         (WTR::TestController::initialize):
2575
2576 2012-11-19  Kentaro Hara  <haraken@chromium.org>
2577
2578         Remove IDLStructure.pm
2579         https://bugs.webkit.org/show_bug.cgi?id=102642
2580
2581         Reviewed by Adam Barth.
2582
2583         Previously IDLStructure.pm was full of regular expressions to
2584         parse IDL files. Now a new IDL parser is implemented, IDLStructure.pm
2585         just contains several data structures for the IDL parser. We can
2586         move them to IDLParser.pm and thus remove IDLStructure.pm.
2587
2588         No tests. No change in generated code.
2589
2590         * WebKitTestRunner/DerivedSources.make:
2591         * WebKitTestRunner/GNUmakefile.am:
2592         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2593
2594 2012-11-18  KyungTae Kim  <ktf.kim@samsung.com>
2595
2596         [EFL] Not to include "ewk_view_private.h" in Tools
2597         https://bugs.webkit.org/show_bug.cgi?id=102644
2598
2599         Reviewed by Gyuyoung Kim.
2600
2601         Include ewk_view.h instead of ewk_view_private.h in Tools
2602
2603         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2604
2605 2012-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2606
2607         Unreviewed, rolling out r135104.
2608         http://trac.webkit.org/changeset/135104
2609         https://bugs.webkit.org/show_bug.cgi?id=102638
2610
2611         Should not use commit queue to add people to committer list.
2612         (Requested by ap_ on #webkit).
2613
2614         * Scripts/webkitpy/common/config/committers.py:
2615
2616 2012-11-18  Vivek Galatage  <vivek.vg@samsung.com>
2617
2618         Add myself to committers.py
2619         https://bugs.webkit.org/show_bug.cgi?id=102636
2620
2621         Reviewed by Laszlo Gombos.
2622
2623         Add myself to committers.py
2624
2625         * Scripts/webkitpy/common/config/committers.py:
2626
2627 2012-11-18  Genevieve Mak  <gmak@rim.com>
2628
2629         [BlackBerry] Enable Touch Sliders
2630         https://bugs.webkit.org/show_bug.cgi?id=102516
2631
2632         Reviewed by Rob Buis.
2633
2634         Enabled for BlackBerry only
2635         PR #242781
2636         PR #176014
2637
2638         * Scripts/webkitperl/FeatureList.pm:
2639
2640 2012-11-17  Dimitri Glazkov  <dglazkov@chromium.org>
2641
2642         Remove unused code I wrote a long time ago from gardeningserver.py
2643         https://bugs.webkit.org/show_bug.cgi?id=102605
2644
2645         Reviewed by Adam Barth.
2646
2647         * Scripts/webkitpy/tool/servers/gardeningserver.py: Removed.
2648         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Removed.
2649
2650 2012-11-16  Tony Chang  <tony@chromium.org>
2651
2652         Remove ENABLE_CSS_HIERARCHIES since it's no longer in use
2653         https://bugs.webkit.org/show_bug.cgi?id=102554
2654
2655         Reviewed by Andreas Kling.
2656
2657         As mentioned in https://bugs.webkit.org/show_bug.cgi?id=79939#c41 ,
2658         we're going to revist this feature once additional vendor support is
2659         achieved.
2660
2661         * Scripts/webkitperl/FeatureList.pm:
2662
2663 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
2664
2665         [chromium] move stubs from DRTTestRunner to TestRunner
2666         https://bugs.webkit.org/show_bug.cgi?id=102489
2667
2668         Reviewed by Adam Barth.
2669
2670         This is part of moving all methods from DRTTestRunner to TestRunner.
2671         Instead of keeping one stub per method, I'm using a shared stub to
2672         clean up the code.
2673
2674         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2675         (DRTTestRunner::DRTTestRunner):
2676         * DumpRenderTree/chromium/DRTTestRunner.h:
2677         (DRTTestRunner):
2678         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2679         (WebTestRunner::TestRunner::TestRunner):
2680         (WebTestRunner):
2681         (WebTestRunner::TestRunner::fallbackMethod):
2682         (WebTestRunner::TestRunner::notImplemented):
2683         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2684         (WebTestRunner):
2685         (TestRunner):
2686         (WebTestRunner::TestRunner::setDelegate):
2687         * DumpRenderTree/chromium/TestShell.cpp:
2688         (TestShell::createMainWindow):
2689         (TestShell::~TestShell):
2690
2691 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
2692
2693         [chromium] fake drag drop operations in the WebTestProxyBase instead of the WebViewHost
2694         https://bugs.webkit.org/show_bug.cgi?id=102495
2695
2696         Reviewed by Adam Barth.
2697
2698         When a drag operation is initiated in a layout test, we need to
2699         simulate a corresponding drop event, otherwise the WebViewImpl will sit
2700         there waiting for it. Instead of having the embedder taking care of
2701         this, move this into the TestRunner library.
2702
2703         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2704         (WebKit):
2705         (WebTestProxyBase):
2706         (WebTestRunner::WebTestProxy::startDragging):
2707         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2708         (WebTestRunner::WebTestProxyBase::startDragging):
2709         (WebTestRunner):
2710         * DumpRenderTree/chromium/WebViewHost.cpp:
2711         * DumpRenderTree/chromium/WebViewHost.h:
2712         (WebViewHost):
2713
2714 2012-11-16  Tien-Ren Chen  <trchen@chromium.org>
2715
2716         Rename applyDefaultDeviceScaleFactorInCompositor to setApplyDeviceScaleFactorInCompositor
2717         https://bugs.webkit.org/show_bug.cgi?id=102462
2718
2719         Reviewed by James Robinson.
2720
2721         As we no longer have this "default" device scale factor.
2722
2723         * DumpRenderTree/chromium/WebPreferences.cpp:
2724         (WebPreferences::applyTo):
2725
2726 2012-11-15  Takashi Sakamoto  <tasak@google.com>
2727
2728         [Win] key event's location does not work on Windows platform.
2729         https://bugs.webkit.org/show_bug.cgi?id=89742
2730
2731         Reviewed by Brent Fulgham.
2732
2733         Modified keyDownCallback to use lparam to specify left-hand keys or
2734         right-hand keys.
2735
2736         * DumpRenderTree/win/EventSender.cpp:
2737         (makeKeyDataForScanCode):
2738         Given a virtual keycode, generate scancode and extended key bit of
2739         lparam.
2740         (keyDownCallback):
2741         Use lparam for left-hand and right-hand keys, because Windows doesn't
2742         directly provide a virtual keycode which distinguishes between
2743         left-hand and right-hand. For example, when control key is pressed,
2744         wparam has VK_CONTROL, neither VK_RCONTROL nor VK_LCONTROL.
2745
2746 2012-11-16  Tommy Widenflycht  <tommyw@google.com>
2747
2748         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
2749         https://bugs.webkit.org/show_bug.cgi?id=102386
2750
2751         Reviewed by Adam Barth.
2752
2753         Adding mock data channel functionality.
2754
2755         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2756         (MockWebRTCPeerConnectionHandler::openDataChannel):
2757
2758 2012-11-16  Jochen Eisinger  <jochen@chromium.org>
2759
2760         [chromium] delete unused testRunner methods
2761         https://bugs.webkit.org/show_bug.cgi?id=102479
2762
2763         Reviewed by Adam Barth.
2764
2765         These methods aren't used by any layout test. Remove them to avoid bit rot
2766
2767         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2768         (DRTTestRunner::DRTTestRunner):
2769         (DRTTestRunner::reset):
2770         * DumpRenderTree/chromium/DRTTestRunner.h:
2771         (DRTTestRunner):
2772         * DumpRenderTree/chromium/WebViewHost.cpp:
2773         (WebViewHost::shouldBeginEditing):
2774         (WebViewHost::shouldEndEditing):
2775         (WebViewHost::shouldInsertNode):
2776         (WebViewHost::shouldInsertText):
2777         (WebViewHost::shouldChangeSelectedRange):
2778         (WebViewHost::shouldDeleteRange):
2779         (WebViewHost::shouldApplyStyle):
2780         (WebViewHost::startDragging):
2781         (WebViewHost::enterFullScreenNow):
2782         (WebViewHost::exitFullScreenNow):
2783
2784 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
2785
2786         Private Browsing is a per-page setting that sets a global value
2787         https://bugs.webkit.org/show_bug.cgi?id=67870
2788
2789         Reviewed by Sam Weinig.
2790
2791         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2792         Call _switchNetworkLoaderToNewTestingSession before making other settings, so that
2793         they would actually apply to the testing session.
2794
2795         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2796         (WTR::InjectedBundle::initialize):
2797         (WTR::InjectedBundle::beginTesting):
2798         Only call WKBundleSwitchNetworkLoaderToNewTestingSession once per process, matching
2799         WebKit1. I'm not fully sure what is going wrong, but apparently creating mutiple
2800         sessions with the same identifier doesn't quite work.
2801
2802 2012-11-16  Yael Aharon  <yael.aharon@intel.com>
2803
2804         Unreviewed. Help bugzilla find me.
2805
2806         * Scripts/webkitpy/common/config/committers.py:
2807
2808 2012-11-16  Peter Beverloo  <peter@chromium.org>
2809
2810         Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner
2811         https://bugs.webkit.org/show_bug.cgi?id=102245
2812
2813         Reviewed by Tony Chang.
2814
2815         When running TestWebKitAPI and webkit_unit_test for Chromium Android, defer
2816         the actual running part to the test runner which lives on the Chromium side.
2817         Re-implementing or even generalizing the device-interaction part in WebKit
2818         is error prone and not worth the effort.
2819
2820         * Scripts/run-api-tests:
2821         * Scripts/run-chromium-webkit-unit-tests:
2822
2823 2012-11-15  Yury Semikhatsky  <yurys@chromium.org>
2824
2825         Memory instrumentation: add code for reporting stack traces of unknown instrumented objects
2826         https://bugs.webkit.org/show_bug.cgi?id=102384
2827
2828         Reviewed by Pavel Feldman.
2829
2830         Updated return type in accord with the changes in MemoryInstrumentationClient.
2831
2832         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2833
2834 2012-11-15  Gustavo Noronha Silva  <gns@gnome.org>
2835
2836         [GTK] Split WebCore/platform into a separate library
2837         https://bugs.webkit.org/show_bug.cgi?id=94435
2838
2839         Reviewed by Martin Robinson.
2840
2841         More people have been reporting problems when linking WebCore because
2842         the command line limit is being exceeded. Splitting WebCore a bit more
2843         is in order.
2844
2845         * GNUmakefile.am: link libWebCorePlatform into DRT
2846
2847 2012-11-15  Dana Jansens  <danakj@chromium.org>
2848
2849         [chromium] Stop using the WebCompositorSupport methods for changing settings
2850         https://bugs.webkit.org/show_bug.cgi?id=101968
2851
2852         Reviewed by James Robinson.
2853
2854         * DumpRenderTree/chromium/TestShell.cpp:
2855         * DumpRenderTree/chromium/TestShell.h:
2856         (TestShell::setPerTilePaintingEnabled):
2857         (TestShell::setAcceleratedAnimationEnabled):
2858
2859 2012-11-15  Tony Chang  <tony@chromium.org>
2860
2861         Generate Settings from a .in file
2862         https://bugs.webkit.org/show_bug.cgi?id=100393
2863
2864         Reviewed by Adam Barth.
2865
2866         Add the generated WebCore files to the include dir.
2867
2868         * TestWebKitAPI/CMakeLists.txt:
2869         * WebKitTestRunner/CMakeLists.txt:
2870
2871 2012-11-15  Roger Fong  <roger_fong@apple.com>
2872
2873         Make old-run-webkit-tests handle setting the results directory properly.
2874         https://bugs.webkit.org/show_bug.cgi?id=102273
2875         <rdar://problem/11571607>
2876
2877         Reviewed by Timothy Horton.
2878
2879         A call to chdirWebkit in old-run-webkit-tests set the current working directory to the OpenSource folder.
2880         Thus setting --results-directory to OpenSource/layout-test-results would create OpenSource/layout-test-results inside the main OpenSource folder.
2881         This caused many other problems including failure to upload test results and failed future test runs.
2882         The solution is to save the current working directory before calling chdirWebKit and then reconstructing the full path to the results directory 
2883         using the saved directory when setting $testResultsDirectory.
2884
2885         * Scripts/old-run-webkit-tests:
2886
2887 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2888
2889         Unreviewed, rolling out r134800 and r134805.
2890         http://trac.webkit.org/changeset/134800
2891         http://trac.webkit.org/changeset/134805
2892         https://bugs.webkit.org/show_bug.cgi?id=102417
2893
2894         This patch broke chromium port (Requested by jianli on
2895         #webkit).
2896
2897         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2898         (MockWebRTCPeerConnectionHandler::openDataChannel):
2899
2900 2012-11-15  Tommy Widenflycht  <tommyw@google.com>
2901
2902         [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
2903         https://bugs.webkit.org/show_bug.cgi?id=102386
2904
2905         Reviewed by Adam Barth.
2906
2907         Adding mock data channel functionality.
2908
2909         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2910         (MockWebRTCPeerConnectionHandler::openDataChannel):
2911
2912 2012-11-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2913
2914         Unreviewed, rolling out r134649 and r134665.
2915         http://trac.webkit.org/changeset/134649
2916         http://trac.webkit.org/changeset/134665
2917         https://bugs.webkit.org/show_bug.cgi?id=102413
2918
2919         Broke a ton of downstream chromium tests (Requested by japhet
2920         on #webkit).
2921
2922         * DumpRenderTree/chromium/WebViewHost.cpp:
2923         (WebViewHost::updateForCommittedLoad):
2924
2925 2012-11-15  Andreas Kling  <akling@apple.com>
2926
2927         Update my e-mail address.
2928
2929         Rubber-stamped by Anders Koivisto.
2930
2931         * Scripts/webkitpy/common/config/committers.py:
2932
2933 2012-11-15  Dominik Röttsches  <dominik.rottsches@intel.com>
2934
2935         [EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
2936         https://bugs.webkit.org/show_bug.cgi?id=101323
2937
2938         Reviewed by Martin Robinson.
2939
2940         Bumping Harfbuzz to newer version so that we can remove the
2941         ifdef round the fix for bug 101009 for EFL, too.
2942         We're using the zip snapshot since jhbuild can fallback to the previously
2943         downloaded blob in case of network failures which leads to better
2944         buildbot robustness. This zip snapshot currently needs to be locally
2945         patched to fix ICU detection on systems that don't have icu pkg-config files.
2946         The patch is suggested for merging into HarfBuzz. We can remove it locally
2947         once it's accepted into HarfBuzz upstream.
2948
2949         * efl/patches/harfbuzz-icu-detection-fix.patch: Applied after retrieving source to fix harfbuzz detection on systems that don't have pkg-config files for it.
2950         * efl/jhbuild.modules: Bumping harfbuzz version.
2951
2952 2012-11-15  Alexey Proskuryakov  <ap@apple.com>
2953
2954         [Mac] Implement WTR --no-timeout-at-all option
2955         https://bugs.webkit.org/show_bug.cgi?id=102251
2956
2957         Reviewed by Eric Carlson.
2958
2959         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil):
2960         Just do it, and convert to Objective C on the way for simplicity.
2961
2962 2012-11-14  Ryuan Choi  <ryuan.choi@gmail.com>
2963
2964         [EFL] Port tiled backing store
2965         https://bugs.webkit.org/show_bug.cgi?id=71352
2966
2967         Reviewed by Gyuyoung Kim.
2968
2969         * EWebLauncher/main.c: Added option to test the WebCore's tiled backing store.
2970         (_User_Arguments):
2971         (windowCreate):
2972         (parseUserArguments):
2973
2974 2012-11-14  Andy Estes  <aestes@apple.com>
2975
2976         Fix the build.
2977
2978         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2979
2980 2012-11-14  Dirk Pranke  <dpranke@chromium.org>
2981
2982         webkitpy: consolidate webkit-base-finding code
2983         https://bugs.webkit.org/show_bug.cgi?id=102007
2984
2985         Reviewed by Eric Seidel.
2986
2987         This patch creates a new "WebKitFinder" class that other
2988         modules can use to find the top of the WebKit tree and
2989         commonly used subdirectories. This logic was in the
2990         webkitpy.layout_test.port classes but wasn't specific to those
2991         classes and now can be used by other modules without needing a port
2992         (e.g., by the check-webkit-style python linter).
2993
2994         This code is somewhat redundant with the code for find_checkout_root()
2995         in the scm modules, but it does not rely on the presence of a version
2996         control system to work. This is a requirement for some uses of the
2997         tree (e.g., Chromium tester checkouts).
2998
2999         This patch removes most of the logic from the layout_tests.port.config
3000         module and makes that as private as possible. Now we just need to move
3001         the default_configuration and flag_from_configuration logic into
3002         DeprecatedPort (or someplace else appropriate) and we can finish
3003         getting rid of the Config class (but that is a separate patch).
3004
3005         * Scripts/webkitpy/common/webkit_finder.py: Added.
3006         (WebKitFinder):
3007         (WebKitFinder.__init__):
3008         (WebKitFinder.webkit_base):
3009         (WebKitFinder.path_from_webkit_base):
3010         (WebKitFinder.path_to_script):
3011         (WebKitFinder.layout_tests_dir):
3012         (WebKitFinder.perf_tests_dir):
3013         * Scripts/webkitpy/layout_tests/port/base.py:
3014         (Port.__init__):
3015         (Port):
3016         (Port.webkit_base):
3017         (Port.path_from_webkit_base):
3018         (Port.path_to_script):
3019         (Port.layout_tests_dir):
3020         (Port.perf_tests_dir):
3021         (Port.set_option_default):
3022         (Port._run_script):
3023         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3024         (PortTest.test_diff_text):
3025         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3026         (ChromiumLinuxPort._determine_driver_path_statically):
3027         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3028         * Scripts/webkitpy/layout_tests/port/config.py:
3029         (Config.__init__):
3030         (Config.build_directory):
3031         (Config.default_configuration):
3032         (Config._read_configuration):
3033         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
3034         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3035         (ConfigTest.test_default_configuration__standalone):
3036         (ConfigTest.test_default_configuration__scripterror):
3037         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3038         (DriverTest.make_port):
3039         (DriverTest.test_no_timeout):
3040         * Scripts/webkitpy/layout_tests/port/gtk.py:
3041         (GtkPort.setup_environ_for_server):
3042         * Scripts/webkitpy/layout_tests/port/mac.py:
3043         (MacPort.show_results_html_file):
3044         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3045         (TestWebKitPort.__init__):
3046         (PortTestCase.make_port):
3047         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3048         (WinPortTest.test_expectations_files):
3049         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3050         (XvfbDriverTest.make_driver):
3051         (XvfbDriverTest.test_stop):
3052         * Scripts/webkitpy/style/checkers/python.py:
3053         (Pylinter.__init__):
3054
3055 2012-11-14  Dana Jansens  <danakj@chromium.org>
3056
3057         [chromium] WebPreferences reset() should set perTilePainting and acceleratedAnimation settings to false.
3058         https://bugs.webkit.org/show_bug.cgi?id=102296
3059
3060         Reviewed by James Robinson.
3061
3062         These settings are always set by TestShell anyhow, but we should be
3063         setting them to false here along with everything else.
3064
3065         * DumpRenderTree/chromium/WebPreferences.cpp:
3066         (WebPreferences::reset):
3067
3068 2012-11-08  Andy Estes  <aestes@apple.com>
3069
3070         [WebKit2] Need API in UIProcess to enable loading of custom protocols
3071         https://bugs.webkit.org/show_bug.cgi?id=101674
3072
3073         Reviewed by Brady Eidson.
3074
3075         Add an API test that implements a custom protocol and attempts to load
3076         a resource requiring that protocol in a WKView. The test passes only if
3077         didFinishLoadForFrame: fires.
3078
3079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3080         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Added.
3081         (+[TestProtocol canInitWithRequest:]):
3082         (+[TestProtocol canonicalRequestForRequest:]):
3083         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
3084         (-[TestProtocol startLoading]):
3085         (-[TestProtocol stopLoading]):
3086         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3087         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
3088         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
3089         (-[TestBrowsingContextLoadDelegate initWithBlockToRunOnLoad:]):
3090         (-[TestBrowsingContextLoadDelegate browsingContextControllerDidFinishLoad:]):
3091
3092 2012-11-14  Ojan Vafai  <ojan@chromium.org>
3093
3094         Fix some defuct flakiness dashboard unittests.
3095         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3096
3097 2012-11-14  Glenn Adams  <glenn@skynav.com>
3098
3099         webkitpy: print-expectations - add --paths option to print only paths of test expectation files
3100         https://bugs.webkit.org/show_bug.cgi?id=102269
3101
3102         Reviewed by Dirk Pranke.
3103
3104         Add --paths option to print-expectations command in order to obtain list of applicable
3105         test expectation file paths.
3106
3107         * Scripts/webkitpy/tool/commands/queries.py:
3108         (PrintExpectations.__init__):
3109         (PrintExpectations.execute):
3110         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3111         (PrintExpectationsTest.run_test):
3112         (PrintExpectationsTest.test_paths):
3113
3114 2012-11-14  James Robinson  <jamesr@chromium.org>
3115
3116         webgl-background-color.html started failing
3117         https://bugs.webkit.org/show_bug.cgi?id=102247
3118
3119         Reviewed by Adrienne Walker.
3120
3121         The compositor thread should outlive the WebView.
3122
3123         * DumpRenderTree/chromium/TestShell.h:
3124         (TestShell):
3125
3126 2012-11-14  Nate Chapin  <japhet@chromium.org>
3127
3128         Move empty loading to DocumentLoader, simplify FrameLoader::init()
3129         https://bugs.webkit.org/show_bug.cgi?id=101512
3130
3131         Reviewed by Adam Barth.
3132
3133         Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
3134         interprets them as a non-empty load. This ensures
3135         http/tests/navigation/new-window-redirect-history.html continues to pass
3136         in chromium.
3137
3138         * DumpRenderTree/chromium/WebViewHost.cpp:
3139         (WebViewHost::updateForCommittedLoad):
3140
3141 2012-11-14  Zan Dobersek  <zandobersek@gmail.com>
3142
3143         Remove uses of deprecated unittest.TestCase aliases
3144         https://bugs.webkit.org/show_bug.cgi?id=102253
3145
3146         Reviewed by Dirk Pranke.
3147
3148         Replace the deprecated unittest.TestCase methods with the corresponding methods
3149         everywhere inside the Tools directory. The following replacements are done:
3150         - assertEquals -> assertEqual
3151         - assert_ -> assertTrue
3152         - failUnlessRaises -> assertRaises
3153
3154         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3155         (SVNMirrorTest.test_CheckOutSource):
3156         * QueueStatusServer/model/queuepropertymixin_unittest.py:
3157         (QueuePropertyMixinTest.test_queue_property):
3158         * QueueStatusServer/model/queues_unittest.py:
3159         (QueueTest._assert_short_name):
3160         (QueueTest._assert_display_name):
3161         (QueueTest._assert_name_with_underscores):
3162         * QueueStatusServer/model/workitems_unittest.py:
3163         (WorkItemsTest.test_display_position_for_attachment):
3164         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3165         (test_parse_log_entries_from_changelog):
3166         (test_parse_log_entries_from_annotated_file):
3167         (_assert_parse_reviewer_text_and_list):
3168         (_assert_parse_reviewer_text_list):
3169         (_assert_fuzzy_reviewer_match):
3170         (_assert_parse_authors):
3171         (test_latest_entry_parse):
3172         (test_latest_entry_parse_single_entry):
3173         (test_set_reviewer):
3174         (test_set_short_description_and_bug_url):
3175         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3176         (DiffParserTest.test_diff_parser):
3177         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3178         (GitSVNTest.test_revisions_changing_files_with_local_commit):
3179         (GitSVNTest.test_upstream_branch):
3180         (GitSVNTest.test_create_patch_with_rm_and_changed_files):
3181         (GitTestWithMock.test_push_local_commits_to_server_with_username_and_password):
3182         * Scripts/webkitpy/common/config/ports_unittest.py:
3183         (DeprecatedPortTest.test_mac_port):
3184         (DeprecatedPortTest.test_gtk_port):
3185         (DeprecatedPortTest.test_efl_port):
3186         (DeprecatedPortTest.test_qt_port):
3187         (DeprecatedPortTest.test_chromium_port):
3188         (DeprecatedPortTest.test_chromium_android_port):
3189         (DeprecatedPortTest.test_chromium_xvfb_port):
3190         * Scripts/webkitpy/common/config/urls_unittest.py:
3191         (URLsTest.test_parse_bug_id):
3192         (URLsTest.test_parse_attachment_id):
3193         * Scripts/webkitpy/common/find_files_unittest.py:
3194         (TestWinNormalize.assert_filesystem_normalizes):
3195         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3196         (test_url_creation):
3197         (test_parse_bug_id):
3198         (_assert_dictionaries_equal):
3199         (test_parse_bugs_from_xml):
3200         (test_attachment_detail_bug_parsing):
3201         (_assert_result_count):
3202         (test_request_page_parsing):
3203         (test_quip_page_parsing):
3204         (EditUsersParserTest._assert_login_userid_pairs):
3205         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3206         (test_status_parsing):
3207         (test_latest_cached_build):
3208         (test_results_zip_url):
3209         * Scripts/webkitpy/common/net/credentials_unittest.py:
3210         (test_credentials_from_environment):
3211         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3212         (FailureMapTest.test_failing_revisions):
3213         (FailureMapTest.test_new_failures):
3214         (FailureMapTest.test_new_failures_with_old_revisions):
3215         (FailureMapTest.test_new_failures_with_more_old_revisions):
3216         (FailureMapTest.test_tests_failing_for):
3217         (FailureMapTest.test_failing_tests):
3218         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3219         (LayoutTestResultsTest.test_set_failure_limit_count):
3220         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
3221         (UnitTestResultsTest.test_nostring):
3222         (UnitTestResultsTest.test_emptystring):
3223         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
3224         (ReadChecksumFromPngTest.test_read_checksum):
3225         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
3226         (LoggingTest.assert_log_equals):
3227         * Scripts/webkitpy/common/system/executive_unittest.py:
3228         (ScriptErrorTest.test_string_from_args):
3229         (ScriptErrorTest.test_message_with_output):
3230         (ExecutiveTest.test_run_command_with_bad_command):
3231         (ExecutiveTest.test_run_command_with_unicode):
3232         (ExecutiveTest.serial_test_run_in_parallel):
3233         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3234         (MockFileSystemTest.quick_check):
3235         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3236         (GenericFileSystemTests.test_glob__trailing_asterisk):
3237         (GenericFileSystemTests.test_glob__leading_asterisk):
3238         (GenericFileSystemTests.test_glob__middle_asterisk):
3239         (GenericFileSystemTests.test_glob__period_is_escaped):
3240         (RealFileSystemTest.test_chdir):
3241         (RealFileSystemTest.test_remove_file_with_retry):
3242         (RealFileSystemTest.test_sep):
3243         * Scripts/webkitpy/common/system/logtesting.py:
3244         (TestLogStream.assertMessages):
3245         * Scripts/webkitpy/common/system/logutils_unittest.py:
3246         (GetLoggerTest.test_get_logger_in_webkitpy):
3247         (GetLoggerTest.test_get_logger_not_in_webkitpy):
3248         * Scripts/webkitpy/common/system/outputcapture.py:
3249         (OutputCaptureTestCaseBase.assertStdout):
3250         (OutputCaptureTestCaseBase.assertStderr):
3251         * Scripts/webkitpy/common/system/path_unittest.py:
3252         (AbspathTest.test_abspath_to_uri_cygwin):
3253         (AbspathTest.test_abspath_to_uri_unixy):
3254         (AbspathTest.test_abspath_to_uri_win):
3255         (AbspathTest.test_abspath_to_uri_escaping_unixy):
3256         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
3257         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3258         (TestPlatformInfo.test_real_code):
3259         (TestPlatformInfo.test_os_name_and_wrappers):
3260         (TestPlatformInfo.test_os_version):
3261         (TestPlatformInfo.test_total_bytes_memory):
3262         * Scripts/webkitpy/common/system/user_unittest.py:
3263         (UserTest.test_confirm.mock_raw_input):
3264         (UserTest.test_confirm):
3265         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
3266         (ZipFileSetTest.test_open):
3267         (ZipFileSetTest.test_read):
3268         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
3269         (WatchListTest.test_filename_definition_no_matches):
3270         (WatchListTest.test_filename_definition):
3271         (WatchListTest.test_cc_rules_simple):
3272         (WatchListTest.test_cc_rules_complex):
3273         (WatchListTest.test_cc_and_message_rules_complex):
3274         (WatchListTest.test_cc_and_message_rules_no_matches):
3275         (WatchListTest.test_added_match):
3276         (WatchListTest.test_deleted_match):
3277         (WatchListTest.test_more_and_less_match):
3278         (WatchListTest.test_complex_match):
3279         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3280         (LockCheckingRunner.handle_finished_list):
3281         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
3282         (LayoutTestRunnerTests.test_update_summary_with_result):
3283         (LayoutTestRunnerTests.test_servers_started):
3284         (SharderTests.assert_shards):
3285         (SharderTests.test_shard_in_two_has_no_locked_shards):
3286         (SharderTests.test_shard_in_two_has_no_unlocked_shards):
3287         (NaturalCompareTest.assert_cmp):
3288         (KeyCompareTest.assert_cmp):
3289         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3290         (TestConfigurationTest.test_items):
3291         (TestConfigurationTest.test_keys):
3292         (TestConfigurationTest.test_str):
3293         (TestConfigurationTest.test_repr):
3294         (TestConfigurationTest.test_hash):
3295         (TestConfigurationTest.test_eq):
3296         (TestConfigurationTest.test_values):
3297         (SpecifierSorterTest.test_init):
3298         (SpecifierSorterTest.test_add_specifier):
3299         (SpecifierSorterTest.test_add_macros):
3300         (SpecifierSorterTest.test_category_priority):
3301         (SpecifierSorterTest.test_specifier_priority):
3302         (SpecifierSorterTest.test_sort_specifiers):
3303         (TestConfigurationConverterTest.test_symmetric_difference):
3304         (TestConfigurationConverterTest.test_to_config_set):
3305         (TestConfigurationConverterTest.test_macro_expansion):
3306         (TestConfigurationConverterTest.test_to_specifier_lists):
3307         (TestConfigurationConverterTest.test_macro_collapsing):
3308         (TestConfigurationConverterTest.test_converter_macro_collapsing):
3309         (TestConfigurationConverterTest.test_specifier_converter_access):
3310         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3311         (assert_exp):
3312         (MiscTests.test_result_was_expected):
3313         (MiscTests.test_remove_pixel_failures):
3314         (MiscTests.test_suffixes_for_expectations):
3315         (MiscTests.test_get_expectations_string):
3316         (SkippedTests.check):
3317         (ExpectationSyntaxTests.assert_tokenize_exp):
3318         (SemanticTests.test_bad_bugid):
3319         (SemanticTests.test_missing_bugid):
3320         (TestExpectationSerializationTests.test_reconstitute_only_these):
3321         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
3322         (TestFailuresTest.test_crashes):
3323         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3324         (PortTest.test_nonexistant_expectations):
3325         (PortTest.test_additional_expectations):
3326         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
3327         (BuildersTest.test_path_from_name):
3328         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3329         (ChromiumAndroidPortTest.test_attributes):
3330         (ChromiumAndroidPortTest.test_default_timeout_ms):
3331         (ChromiumAndroidPortTest.test_get_devices_one_device):
3332         (ChromiumAndroidPortTest.test_get_devices_two_devices):
3333         (ChromiumAndroidPortTest.test_get_device_serial_one_device):
3334         (ChromiumAndroidPortTest.test_get_device_serial_two_devices):
3335         (ChromiumAndroidPortTest.test_must_require_http_server):
3336         (ChromiumAndroidDriverTest.test_get_last_stacktrace):
3337         (ChromiumAndroidDriverTest.test_get_crash_log):
3338         (ChromiumAndroidDriverTest.test_cmd_line):
3339         (ChromiumAndroidDriverTest.test_read_prompt):
3340         (ChromiumAndroidDriverTest.test_command_from_driver_input):
3341         (ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
3342         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
3343         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3344         (ChromiumLinuxPortTest.assert_architecture):
3345         (ChromiumLinuxPortTest.test_determine_architecture_fails):
3346         (ChromiumLinuxPortTest.test_path_to_image_diff):
3347         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3348         (ChromiumMacPortTest.assert_name):
3349         (ChromiumMacPortTest.test_baseline_path):
3350         (ChromiumMacPortTest.test_path_to_image_diff):
3351         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3352         (ChromiumPortTestCase.test_default_max_locked_shards):
3353         (ChromiumPortTestCase.test_default_timeout_ms):
3354         (ChromiumPortTestCase.test_default_pixel_tests):
3355         (ChromiumPortTestCase.test_all_test_configurations):
3356         (ChromiumPortTestCase.test_default_configuration):
3357         (ChromiumPortTestCase.test_diff_image):
3358         (ChromiumPortTestCase.test_diff_image_crashed):
3359         (ChromiumPortTestCase.test_expectations_files):
3360         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3361         (ChromiumWinTest.test_setup_environ_for_server_cygpath):
3362         (ChromiumWinTest.assert_name):
3363         (ChromiumWinTest.test_baseline_path):
3364         (ChromiumWinTest.test_path_to_image_diff):
3365         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3366         (DriverTest.test_read_block):
3367         (DriverTest.test_read_binary_block):
3368         (DriverTest.test_read_base64_block):
3369         (DriverTest.test_no_timeout):
3370         (DriverTest.test_check_for_driver_crash.assert_crash):
3371         (DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
3372         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3373         (FactoryTest.test_get_from_builder_name):
3374         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3375         (GtkPortTest.test_default_timeout_ms):
3376         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
3377         (HttpLockTest.test_current_lock_pid):
3378         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
3379         (TestImageDiffer.test_diff_image_failed):
3380         (TestImageDiffer.test_diff_image_passed):
3381         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3382         (LeakDetectorTest.test_leaks_args):
3383         (test_parse_leaks_output):
3384         (test_leaks_files_in_directory):
3385         (test_count_total_leaks):
3386         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3387         (MacTest.test_default_timeout_ms):
3388         (assert_name):
3389         (test_setup_environ_for_server):
3390         (_assert_search_path):
3391         (test_32bit):
3392         (test_64bit):
3393         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3394         (MockTestShellTest.test_pixeltest__fails):
3395         (MockTestShellTest.test_test_shell_parse_options):
3396         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3397         (PortTestCase.test_default_max_locked_shards):
3398         (PortTestCase.test_default_timeout_ms):
3399         (PortTestCase.test_default_pixel_tests):
3400         (PortTestCase.test_diff_image):
3401         (PortTestCase.test_diff_image_crashed):
3402         (PortTestCase.test_get_crash_log):
3403         (PortTestCase.assert_build_path):
3404         (PortTestCase.test_expectations_ordering):
3405         (_assert_config_file_for_platform):
3406         (test_path_to_apache_config_file):
3407         (test_additional_platform_directory):
3408         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3409         (QtPortTest._assert_search_path):
3410         (QtPortTest._assert_expectations_files):
3411         (QtPortTest.test_setup_environ_for_server):
3412         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3413         (TestServerProcess.test_basic):
3414         (TestServerProcess.test_broken_pipe):
3415         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3416         (WinPortTest._assert_search_path):
3417         (WinPortTest._assert_version):
3418         (WinPortTest.test_runtime_feature_list):
3419         (WinPortTest.test_expectations_files):
3420         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3421         (LintTest.test_all_configurations):
3422         (MainTest.test_all):
3423         (MainTest.test_repeat_each):
3424         (MainTest.test_skipped_flag):
3425         (MainTest.test_iterations):
3426         (MainTest.test_run_chunk):
3427         (MainTest.test_run_part):
3428         (MainTest.test_run_singly):
3429         (MainTest.test_run_singly_actually_runs_tests):
3430         (MainTest.test_single_file):
3431         (MainTest.test_single_file_with_prefix):
3432         (MainTest.test_single_skipped_file):
3433         (MainTest.test_stderr_is_saved):
3434         (MainTest.test_test_list):
3435         (MainTest.test_test_list_with_prefix):
3436         (MainTest.test_missing_and_unexpected_results):
3437         (MainTest.test_pixel_test_directories):
3438         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
3439         (MainTest.test_crash_log):
3440         (MainTest.test_web_process_crash_log):
3441         (MainTest.test_exit_after_n_failures_upload):
3442         (MainTest.test_exit_after_n_failures):
3443         (MainTest.test_exit_after_n_crashes):
3444         (MainTest.test_retrying_and_flaky_tests):
3445         (MainTest.test_run_order__inline):
3446         (MainTest.test_reftest_run):
3447         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
3448         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
3449         (MainTest.test_reftest_expected_html_should_be_ignored):
3450         (MainTest.test_reftest_driver_should_run_expected_html):
3451         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
3452         (MainTest.test_output_diffs):
3453         (MainTest.test_unsupported_platform):
3454         (EndToEndTest.test_end_to_end):
3455         (RebaselineTest.test_reset_results):
3456         (RebaselineTest.test_missing_results):
3457         (RebaselineTest.test_new_baseline):
3458         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3459         (BaseTest.integration_test_server__normal):
3460         (BaseTest.integration_test_server__fails):
3461         (BaseTest.integration_test_port_and_root):
3462         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3463         (TestHttpServer.test_start_cmd):
3464         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3465         (RegularTest.test_logging_not_included):
3466         (RegularTest._basic):
3467         (RegularTest.test_basic):
3468         (RegularTest.test_log_after_update):
3469         (RegularTest.test_log_args):
3470         (TtyTest.test_basic):
3471         (TtyTest.test_log_after_update):
3472         (VerboseTest.test_basic):
3473         (VerboseTest.test_log_after_update):
3474         (VerboseTest.test_log_args):
3475         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3476         (Testprinter.assertWritten):
3477         (test_test_status_line):
3478         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3479         (MainTest.assertWritten):
3480         * Scripts/webkitpy/style/checker_unittest.py:
3481         (GlobalVariablesTest.test_webkit_base_filter_rules):
3482         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
3483         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3484         (CheckerDispatcherDispatchTest.assert_checker):
3485         (CheckerDispatcherDispatchTest.test_changelog_paths):
3486         (CheckerDispatcherDispatchTest.test_cpp_paths):
3487         (CheckerDispatcherDispatchTest.test_json_paths):
3488         (CheckerDispatcherDispatchTest.test_python_paths):
3489         (CheckerDispatcherDispatchTest.test_text_paths):
3490         (CheckerDispatcherDispatchTest.test_xml_paths):
3491         (StyleProcessorConfigurationTest.test_init):
3492         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
3493         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
3494         (StyleProcessor_EndToEndTest.test_init):
3495         (StyleProcessor_EndToEndTest.test_process):
3496         (StyleProcessor_CodeCoverageTest.test_process__checker_dispatched):
3497         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3498         (ChangeLogCheckerTest.assert_error.handle_style_error):
3499         (ChangeLogCheckerTest.test_init):
3500         * Scripts/webkitpy/style/checkers/common_unittest.py:
3501         (CarriageReturnCheckerTest.assert_carriage_return):
3502         (TabCheckerTest.assert_tab):
3503         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3504         (CppFunctionsTest.test_convert_to_lower_with_underscores):
3505         (CppFunctionsTest.test_create_acronym):
3506         (CppFunctionsTest.test_parameter):
3507         (CppFunctionsTest.test_single_line_view):
3508         (CppFunctionsTest.test_create_skeleton_parameters):
3509         (CppFunctionsTest.test_find_parameter_name_index):
3510         (CppFunctionsTest.test_parameter_list):
3511         (CppFunctionsTest.test_check_parameter_against_text):
3512         (CppStyleTestBase.perform_lint):
3513         (CppStyleTestBase.assert_lint):
3514         (CppStyleTestBase.assert_lint_one_of_many_errors_re):
3515         (CppStyleTestBase.assert_multi_line_lint):
3516         (CppStyleTestBase.assert_language_rules_check):
3517         (CppStyleTestBase.assert_include_what_you_use):
3518         (CppStyleTestBase.assert_blank_lines_check):
3519         (CppStyleTestBase.assert_positions_equal):
3520         (FunctionDetectionTest.perform_function_detection):
3521         (CppStyleTest.test_get_line_width):
3522         (CppStyleTest.test_find_next_multi_line_comment_start):
3523         (CppStyleTest.test_find_next_multi_line_comment_end):
3524         (CppStyleTest.test_remove_multi_line_comments_from_range):
3525         (CppStyleTest.test_position):
3526         (CppStyleTest.test_rfind_in_lines):
3527         (CppStyleTest.test_close_expression):
3528         (CppStyleTest.test_include_what_you_use_no_implementation_files):
3529         (CppStyleTest.test_include_what_you_use):
3530         (CppStyleTest.test_files_belong_to_same_module):
3531         (CppStyleTest.test_cleanse_line):
3532         (CppStyleTest.test_multiline_strings):
3533         (CppStyleTest.test_newline_at_eof.do_test):
3534         (CppStyleTest.test_invalid_utf8.do_test):
3535         (CppStyleTest.test_is_blank_line):
3536         (CppStyleTest.test_allow_blank_line_before_closing_namespace):
3537         (CppStyleTest.test_allow_blank_line_before_if_else_chain):
3538         (CppStyleTest.test_else_on_same_line_as_closing_braces):
3539         (CppStyleTest.test_build_header_guard):
3540         (CppStyleTest.test_legal_copyright):
3541         (CleansedLinesTest.test_init):
3542         (CleansedLinesTest.test_init_empty):
3543         (CleansedLinesTest.test_collapse_strings):
3544         (CheckForFunctionLengthsTest.assert_function_lengths_check):
3545         (PassPtrTest.assert_pass_ptr_check):
3546         (LeakyPatternTest.assert_leaky_pattern_check):
3547         (WebKitStyleTest.test_parameter_names):
3548         (WebKitStyleTest.test_webkit_export_check):
3549         (CppCheckerTest.test_init):
3550         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
3551         (JSONCheckerTest.assert_error.handle_style_error):
3552         (JSONCheckerTest.test_init):
3553         * Scripts/webkitpy/style/checkers/png_unittest.py:
3554         (PNGCheckerTest.test_init):
3555         (PNGCheckerTest.test_check):
3556         * Scripts/webkitpy/style/checkers/python_unittest.py:
3557         (PythonCheckerTest.test_init):
3558         (PythonCheckerTest.test_check):
3559         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3560         (TestExpectationsTestCase._expect_port_for_expectations_path):
3561         (TestExpectationsTestCase.assert_lines_lint):
3562         * Scripts/webkitpy/style/checkers/text_unittest.py:
3563         (TextStyleTestCase.assertNoError):
3564         (TextStyleTestCase.assertError.error_for_test):
3565         (TextStyleTestCase.assertError):
3566         (TextCheckerTest.test_init):
3567         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
3568         (WatchListTest.test_basic_error_message.handle_style_error):
3569         (WatchListTest):
3570         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
3571         (XcodeProjectFileCheckerTest.assert_error):
3572         * Scripts/webkitpy/style/checkers/xml_unittest.py:
3573         (XMLCheckerTest.assert_error.handle_style_error):
3574         (XMLCheckerTest.test_init):
3575         * Scripts/webkitpy/style/error_handlers_unittest.py:
3576         (DefaultStyleErrorHandlerTest._check_initialized):
3577         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
3578         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
3579         (DefaultStyleErrorHandlerTest.test_line_numbers):
3580         * Scripts/webkitpy/style/filereader_unittest.py:
3581         (TextFileReaderTest._assert_file_reader):
3582         (TextFileReaderTest.test_process_file__does_not_exist):
3583         (TextFileReaderTest.test_count_delete_only_file):
3584         * Scripts/webkitpy/style/filter_unittest.py:
3585         (CategoryFilterTest.test_init):
3586         (CategoryFilterTest.test_init_default_arguments):
3587         (CategoryFilterTest.test_str):
3588         (FilterConfigurationTest.test_init):
3589         (FilterConfigurationTest.test_default_arguments):
3590         * Scripts/webkitpy/style/main_unittest.py:
3591         (ChangeDirectoryTest._assert_result):
3592         * Scripts/webkitpy/style/optparser_unittest.py:
3593         (ArgumentPrinterTest.test_to_flag_string):
3594         (ArgumentParserTest.test_parse_default_arguments):
3595         (ArgumentParserTest.test_parse_explicit_arguments):
3596         (ArgumentParserTest.test_parse_files):
3597         (CommandOptionValuesTest.test_init):
3598         * Scripts/webkitpy/style/patchreader_unittest.py:
3599         (PatchReaderTest._assert_checked):
3600         * Scripts/webkitpy/test/finder_unittest.py:
3601         (FinderTest.test_additional_system_paths):
3602         (FinderTest.test_to_module):
3603         (FinderTest.check_names):
3604         * Scripts/webkitpy/test/main_unittest.py:
3605         (TesterTest.test_individual_names_are_not_run_twice):
3606         (TesterTest.test_integration_tests_are_not_found_by_default):
3607         (TesterTest.test_integration_tests_are_found):
3608         (TesterTest.integration_test_coverage_works):
3609         * Scripts/webkitpy/test/runner_unittest.py:
3610         (RunnerTest.test_run):