fe6b41825b15e7e8a07926226018cf4c695cca0a
[WebKit-https.git] / Tools / ChangeLog
1 2018-02-03  Charlie Turner  <cturner@igalia.com>
2
3         Add libmount to WPE dependencies
4         https://bugs.webkit.org/show_bug.cgi?id=182345
5
6         Reviewed by Michael Catanzaro.
7
8         * wpe/install-dependencies:
9
10 2018-02-02  Youenn Fablet  <youenn@apple.com>
11
12         W3C test exporter should allow exporting newly added files
13         https://bugs.webkit.org/show_bug.cgi?id=182369
14
15         Reviewed by Ryosuke Niwa.
16
17         * Scripts/webkitpy/common/checkout/scm/git.py:
18         (Git.apply_mail_patch):
19
20 2018-02-02  David Quesada  <david_quesada@apple.com>
21
22         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
23         https://bugs.webkit.org/show_bug.cgi?id=182363
24         rdar://problem/37093498
25
26         Reviewed by Ryosuke Niwa.
27
28         Updated ApplicationManifestParserTests to account for the new default scope behavior.
29
30         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
31         (assertManifestHasDefaultValues):
32         (TEST_F):
33
34 2018-02-02  Youenn Fablet  <youenn@apple.com>
35
36         Clearing all service worker registrations should wait for importing service worker registration to finish
37         https://bugs.webkit.org/show_bug.cgi?id=182407
38
39         Reviewed by Chris Dumez.
40
41         Make sure we finish clearing service worker registrations before running tests.
42
43         * WebKitTestRunner/TestController.cpp:
44         (WTR::TestController::resetStateToConsistentValues):
45         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
46         (WTR::clearServiceWorkerRegistrationsCallback):
47         (WTR::TestController::clearServiceWorkerRegistrations):
48         * WebKitTestRunner/TestController.h:
49
50 2018-02-02  Youenn Fablet  <youenn@apple.com>
51
52         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
53         https://bugs.webkit.org/show_bug.cgi?id=182403
54
55         Reviewed by Alex Christensen.
56
57         * WebKitTestRunner/TestController.cpp:
58         (WTR::TestController::generateContextConfiguration const):
59         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
60         (WTR::initializeWebViewConfiguration):
61
62 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
63
64         [GTK] WebDriver: tests step always times out in the bot
65         https://bugs.webkit.org/show_bug.cgi?id=182437
66
67         Reviewed by Carlos Alberto Lopez Perez.
68
69         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
70         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
71
72         * Scripts/run-webdriver-tests: Call teardown() after run().
73         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
74         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
75         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
76         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
77         the display driver once and pass it to the test runners.
78         (WebDriverTestRunner.teardown): Stop the display server.
79         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
80         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
81         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
82         (WebDriverTestRunnerSelenium.run): Ditto.
83         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
84         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
85         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
86         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
87         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
88
89 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
90
91         Unreviewed, rolling out r227999.
92
93         It didn't fix the problem
94
95         Reverted changeset:
96
97         "Unreviewed. Try to avoid webdriver tests step timing out in
98         the bots."
99         https://trac.webkit.org/changeset/227999
100
101 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
102
103         Start timeout for the run-buildbot-test script is too aggressive
104         https://bugs.webkit.org/show_bug.cgi?id=182429
105
106         Reviewed by Carlos Garcia Campos.
107
108         15 seconds is not enough waiting for the update database process
109         to complete on a system backed with rotational HDDs. Raise it to 60.
110
111         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
112         (wait_for_master_ready):
113
114 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
115
116         re-add ARM JSCOnly bots on buildbot waterfall
117         https://bugs.webkit.org/show_bug.cgi?id=182428
118
119         Reviewed by Csaba Osztrogonác.
120
121         * BuildSlaveSupport/build.webkit.org-config/config.json:
122         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
123
124 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
125
126         Remove ARM JSCOnly bots from buildbot waterfall
127         https://bugs.webkit.org/show_bug.cgi?id=182398
128
129         Reviewed by Alexey Proskuryakov.
130
131         * BuildSlaveSupport/build.webkit.org-config/config.json:
132         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
133
134 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
135
136         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
137
138         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
139         workaround for a bug in python2.7 when using multiprocess module.
140
141         * Scripts/run-webdriver-tests:
142
143 2018-02-01  Youenn Fablet  <youenn@apple.com>
144
145         Delay service worker process creation until actually needed by SWServer
146         https://bugs.webkit.org/show_bug.cgi?id=182301
147
148         Reviewed by Chris Dumez.
149
150         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
151         (function):
152
153 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
154
155         Bubbles intermittently disappear from bot watchers dashboard
156         https://bugs.webkit.org/show_bug.cgi?id=182085
157
158         Reviewed by Alexey Proskuryakov.
159
160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
161         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
162         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
163         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
164
165 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
166
167         [GTK] Problem with Washington Post images
168         https://bugs.webkit.org/show_bug.cgi?id=181421
169
170         Reviewed by Carlos Alberto Lopez Perez.
171
172         Add test case for the new user agent quirk.
173
174         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
175         (TestWebKitAPI::TEST):
176
177 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
178
179         [GTK] MiniBrowser settings are just a list of names
180         https://bugs.webkit.org/show_bug.cgi?id=182005
181
182         Reviewed by Sergio Villar Senin.
183
184         The default size we are using is too small to show the values column, and the window is not resizable because
185         GObjectClass::constructed() is not called in the parent class.
186
187         * MiniBrowser/gtk/BrowserSettingsDialog.c:
188         (browser_settings_dialog_init): Use 600x400 as default size.
189         (browserSettingsDialogConstructed): Chain up to parent constructed.
190
191 2018-01-31  Andres Gomez  <agomez@igalia.com>
192
193         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
194
195         * Scripts/webkitpy/common/config/watchlist:
196
197 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
198
199         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
200         https://bugs.webkit.org/show_bug.cgi?id=181204
201         <rdar://problem/36256274>
202
203         Reviewed by Ryosuke Niwa.
204
205         Implement 'testRunner.forceImmediateCompletion()' for WK1.
206
207         * DumpRenderTree/TestRunner.cpp:
208         (forceImmediateCompletionCallback):
209         (TestRunner::staticFunctions):
210
211 2018-01-31  Alex Christensen  <achristensen@webkit.org>
212
213         Unreviewed, rolling out r227942.
214
215         r227875 should not have been rolled out.
216
217         Reverted changeset:
218
219         "Unreviewed, rolling out r227875."
220         https://bugs.webkit.org/show_bug.cgi?id=182357
221         https://trac.webkit.org/changeset/227942
222
223 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
224
225         Unreviewed, rolling out r227875.
226         https://bugs.webkit.org/show_bug.cgi?id=182357
227
228         Missing cross-platform TestController implementation
229
230         Reverted changeset:
231
232         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
233         https://bugs.webkit.org/show_bug.cgi?id=181958
234         https://trac.webkit.org/changeset/227875
235
236         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
237         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
238         (WTR::InjectedBundle::didReceiveMessageToPage):
239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
240         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
241         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
242         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
243         * WebKitTestRunner/InjectedBundle/TestRunner.h:
244         * WebKitTestRunner/TestInvocation.cpp:
245         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
246         * WebKitTestRunner/TestInvocation.h:
247         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
248         (WTR::TestController::statisticsUpdateCookiePartitioning):
249         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
250
251 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
252
253         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
254         https://bugs.webkit.org/show_bug.cgi?id=182222
255
256         Reviewed by Alex Christensen.
257
258         Use the new API to notify when resource load statistics deletion is complete.
259
260         * WebKitTestRunner/TestController.cpp:
261         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
262         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
263         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
264
265 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
266
267         Add the support for running StyleBench to run-benchmark
268         https://bugs.webkit.org/show_bug.cgi?id=182323
269
270         Reviewed by Antti Koivisto.
271
272         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
273
274         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
275         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
276
277 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
278
279         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
280         https://bugs.webkit.org/show_bug.cgi?id=182339
281         <rdar://problem/36041396>
282
283         Reviewed by Andy Estes.
284
285         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
286         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
287         check against the length of the data written.
288
289         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
290         (testIconImageData):
291         (runTestWithTemporaryFolder):
292         (TestWebKitAPI::TEST):
293
294 2018-01-31  Dan Bernstein  <mitz@apple.com>
295
296         [macOS] MiniBrowser isn’t app-sandboxed
297         https://bugs.webkit.org/show_bug.cgi?id=182147
298
299         Reviewed by Sam Weinig.
300
301         Enable App Sandbox and add a temporary exception allowing read access to all files.
302
303         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
304         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
305         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
306           and read access from /.
307         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
308
309 2018-01-31  Philippe Normand  <pnormand@igalia.com>
310
311         [JHBuild] Add gstreamer-vaapi in moduleset
312         https://bugs.webkit.org/show_bug.cgi?id=182283
313
314         Reviewed by Carlos Alberto Lopez Perez.
315
316         GStreamer-VAAPI is required for hardware-accelerated video
317         playback support on Intel and AMD (using radeosi driver)
318         platforms.
319
320         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
321         * gtk/install-dependencies: Install libva.
322         * wpe/install-dependencies: Ditto.
323         * Scripts/webkitpy/port/gtk.py:
324         (GtkPort.setup_environ_for_server): Disable va-api support when
325         testing because it's incompatible with Mesa's softGL driver.
326
327 2018-01-31  Charlie Turner  <cturner@igalia.com>
328
329         [WPE] Update jhbuild dependencies
330         https://bugs.webkit.org/show_bug.cgi?id=182286
331
332         This upgrades the following packages,
333         glib 2.44.1 -> 2.54.3
334         glib-networking 2.42.0 -> 2.54.1
335         libsoup 2.48.0 -> 2.60.3
336
337         The initial reason for performing these upgrades was that when
338         visiting https://youtube.com, WPE was getting TLS certificate
339         errors. After upgrading glib-networking, these were fixed, but the
340         upgrade introduced dependencies on newer versions of the other
341         packages upgraded in this commit.
342
343         The upgrade to glib caused a linking error in gstreamer, the
344         following errors were being logged during linking,
345
346         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
347         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
348         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
349
350         This was fixed by adding the glib package built in the jhbuild to
351         harfbuzz.
352
353         Finally, the upgrade of glib caused the glib-warning-fix.patch to
354         no longer apply, so this patch was removed.
355
356         Reviewed by Michael Catanzaro.
357
358         * wpe/jhbuild.modules: Added dependecies.
359         * wpe/patches/glib-warning-fix.patch: Removed.
360
361 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
362
363         Unreviewed, rolling out r227782.
364
365         It didn't fix the problem
366
367         Reverted changeset:
368
369         "Unreviewed. Try to avoid webdriver tests step timing out in
370         the bots."
371         https://trac.webkit.org/changeset/227782
372
373 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
374
375         WebDriver: add domains to server config in w3c tests
376         https://bugs.webkit.org/show_bug.cgi?id=182294
377
378         Reviewed by Carlos Alberto Lopez Perez.
379
380         Several cookie tests expect server_config to have a domains key.
381
382         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
383                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
384
385         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
386         (WebDriverW3CExecutor.__init__):
387
388 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
389
390         Unreviewed. Update W3C WebDriver imported tests.
391
392         Show full pytest failure logs.
393
394         pytest truncates long lists when printing a failed assertion.
395         This is not great for debugging and arguably it should be the
396         default to show the full diff when comparing lists.
397
398         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
399         (run):
400
401 2018-01-30  John Wilander  <wilander@apple.com>
402
403         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
404         https://bugs.webkit.org/show_bug.cgi?id=181958
405         https://bugs.webkit.org/show_bug.cgi?id=182072
406         <rdar://problem/36801804>
407         <rdar://problem/36845795>
408
409         Reviewed by Brent Fulgham.
410
411         Because of the asynchronous nature of XPC and cookies,
412         we need callbacks in these TestRunner functions so that
413         the layout tests can wait for state changes to finish
414         before checking test conditions.
415
416         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
417         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
418         (WTR::InjectedBundle::didReceiveMessageToPage):
419         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
420         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
421         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
422         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
423         * WebKitTestRunner/InjectedBundle/TestRunner.h:
424         * WebKitTestRunner/TestInvocation.cpp:
425         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
426         * WebKitTestRunner/TestInvocation.h:
427         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
428         (WTR::TestController::statisticsUpdateCookiePartitioning):
429         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
430
431 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
432
433         [webkitpy] Config file for apache is copied twice.
434         https://bugs.webkit.org/show_bug.cgi?id=182131
435
436         Reviewed by Daniel Bates.
437
438         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
439         (LayoutTestApacheHttpd.__init__):
440         (LayoutTestApacheHttpd._copy_apache_config_file):
441         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
442
443 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
444
445         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
446         https://bugs.webkit.org/show_bug.cgi?id=182312
447
448         Reviewed by Michael Catanzaro.
449
450         * DumpRenderTree/config.h:
451         * TestWebKitAPI/config.h:
452         * WebKitTestRunner/config.h:
453
454 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
455
456         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
457         https://bugs.webkit.org/show_bug.cgi?id=182307
458         <rdar://problem/36041485>
459
460         Reviewed by Ryosuke Niwa.
461
462         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
463         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
464         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
465         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
466
467         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
468         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
469         (TestWebKitAPI::TEST):
470
471 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
472
473         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
474         https://bugs.webkit.org/show_bug.cgi?id=182284
475
476         Reviewed by Michael Catanzaro.
477
478         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
479         * wpe/manifest.txt.in: Ditto.
480
481 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
482
483         Unreviewed, try to fix JSCOnly build
484         https://bugs.webkit.org/show_bug.cgi?id=177202
485
486         * CMakeLists.txt:
487
488 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
489
490         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
491
492         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
493         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
494         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
495         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
496
497         * Scripts/run-webdriver-tests:
498         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
499         (WebDriverTestRunner.dump_results_to_json_file):
500
501 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
502
503         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
504         https://bugs.webkit.org/show_bug.cgi?id=177202
505
506         Reviewed by Alex Christensen.
507
508         * CMakeLists.txt:
509
510 2018-01-29  Alex Christensen  <achristensen@webkit.org>
511
512         Clean up API after bugs 178240 and 176474
513         https://bugs.webkit.org/show_bug.cgi?id=182259
514
515         Reviewed by Dan Bernstein.
516
517         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
518         (TEST):
519         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
520
521 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
522
523         [WebAuthN] Add a compile-time feature flag
524         https://bugs.webkit.org/show_bug.cgi?id=182211
525         <rdar://problem/36936365>
526
527         Reviewed by Brent Fulgham.
528
529         * Scripts/webkitperl/FeatureList.pm:
530         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
531
532 2018-01-29  Brady Eidson  <beidson@apple.com>
533
534         Make the API test added in r227737 be Mac-only.
535
536         Unreviewed gardening.
537
538         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
539
540 2018-01-29  Matt Lewis  <jlewis3@apple.com>
541
542         Unreviewed, rolling out r227731.
543
544         This caused and assertion failure in API tests.
545
546         Reverted changeset:
547
548         "Layout Test fast/events/beforeunload-dom-manipulation-
549         crash.html is crashing"
550         https://bugs.webkit.org/show_bug.cgi?id=181204
551         https://trac.webkit.org/changeset/227731
552
553 2018-01-29  Youenn Fablet  <youenn@apple.com>
554
555         WPT test exporter should add WebKit export in its PR description
556         https://bugs.webkit.org/show_bug.cgi?id=182246
557
558         Reviewed by Chris Dumez.
559
560         Updating PR description body to contain the words 'WebKit export'.
561         That way, WPT PR bot will mark the PR as reviewed downstream.
562
563         * Scripts/webkitpy/w3c/test_exporter.py:
564         (TestExporter.__init__):
565         (TestExporter.make_pull_request):
566         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
567         (TestExporterTest.test_export):
568
569 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
570
571         Add the support for running Speedometer 2.0 to run-benchmark
572         https://bugs.webkit.org/show_bug.cgi?id=182231
573
574         Reviewed by Antti Koivisto.
575
576         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
577         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
578         requires aggregating the geometric mean out of total time spent in each suite.
579
580         Also added --show-iteration-values to show individual measured values in each iteration.
581
582         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
583         (BenchmarkResults.format): Added show_iteration_values as an option.
584         (BenchmarkResults._format_tests): Ditto.
585         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
586         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
587         is easily parsable as a JSON array.
588         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
589         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
590         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
591         had exactly one aggregator.
592         (BenchmarkResults._lint_results):
593         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
594         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
595         parent_aggregator_list.
596         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
597         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
598         (BenchmarkResults._lint_configuration):
599         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
600         (test_format_values_with_no_unit_scaling): Added.
601         (test_format_values_with_iteration_values): Added.
602         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
603         (test_aggregate_results_from_another_aggregator): Added.
604         (test_lint_results): Added a test case.
605         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
606         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
607         (BenchmarkRunner._run_benchmark): Ditto.
608         (BenchmarkRunner.show_results): Ditto.
609         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
610         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
611         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
612         (parse_args): Added --show-iteration-values as a boolean argument.
613         (run_benchmark_plan): Ditto.
614         (start): Ditto.
615         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
616         (WebServerBenchmarkRunner.__init__): Ditto.
617
618 2018-01-29  Brady Eidson  <beidson@apple.com>
619
620         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
621         https://bugs.webkit.org/show_bug.cgi?id=182229
622
623         Reviewed by Chris Dumez.
624
625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
626         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
627
628 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
629
630         WebDriver: properly recover w3c tests after a webdriver server crash
631         https://bugs.webkit.org/show_bug.cgi?id=182242
632
633         Reviewed by Carlos Alberto Lopez Perez.
634
635         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
636         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
637         relaunching the server after every test failure, because other failures, even when not crashing the server,
638         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
639         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
640
641         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
642         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
643         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
644         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
645         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
646         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
647         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
648         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
649
650 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
651
652         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
653         https://bugs.webkit.org/show_bug.cgi?id=181204
654         <rdar://problem/36256274>
655
656         Reviewed by Ryosuke Niwa.
657
658         Implement 'testRunner.forceImmediateCompletion()' for WK1.
659
660         * DumpRenderTree/TestRunner.cpp:
661         (forceImmediateCompletionCallback):
662         (TestRunner::staticFunctions):
663
664 2018-01-29  Frederic Wang  <fwang@igalia.com>
665
666         Unreviewed, add myself to some watch lists.
667
668         * Scripts/webkitpy/common/config/watchlist:
669
670 2018-01-27  Dan Bernstein  <mitz@apple.com>
671
672         HaveInternalSDK includes should be "#include?"
673         https://bugs.webkit.org/show_bug.cgi?id=179670
674
675         * DumpRenderTree/mac/Configurations/Base.xcconfig:
676
677 2018-01-26  Chris Dumez  <cdumez@apple.com>
678
679         Make sure service worker code does not launch a StorageProcess unnecessarily
680         https://bugs.webkit.org/show_bug.cgi?id=182192
681         <rdar://problem/36927427>
682
683         Reviewed by Geoffrey Garen.
684
685         Add API test coverage.
686
687         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
688
689 2018-01-26  Chris Dumez  <cdumez@apple.com>
690
691         Offlined content does not work for apps on home screen
692         https://bugs.webkit.org/show_bug.cgi?id=182070
693         <rdar://problem/36843906>
694
695         Reviewed by Youenn Fablet.
696
697         Add API test coverage to make sure an already registered service worker is able to intercept
698         the very first load.
699
700         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
701         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
702
703 2018-01-26  Chris Nardi  <cnardi@chromium.org>
704
705         Addressing post-review comments after r226614
706         https://bugs.webkit.org/show_bug.cgi?id=182151
707
708         Reviewed by Myles C. Maxfield.
709
710         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
711         (TestWebKitAPI::TEST):
712
713 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
714
715         Unreviewed, rolling out r224920.
716
717         Some Win EWS bots are not coming back up after starting reboot.
718
719         * EWSTools/start-queue-win.sh:
720
721 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
722
723         WebDriver: simplify the tests json report
724         https://bugs.webkit.org/show_bug.cgi?id=182171
725
726         Reviewed by Carlos Alberto Lopez Perez.
727
728         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
729         form the subtest name. We should do the same for simplicity and compatibility with WPT.
730
731         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
732         (WebDriverTestRunner.dump_results_to_json_file):
733
734 2018-01-25  Alex Christensen  <achristensen@webkit.org>
735
736         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
737         https://bugs.webkit.org/show_bug.cgi?id=182152
738
739         Reviewed by Joseph Pecoraro.
740
741         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
742         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
743         (TEST):
744
745 2018-01-25  Youenn Fablet  <youenn@apple.com>
746
747         WebPluginInfoProvider should handle null host queries
748         https://bugs.webkit.org/show_bug.cgi?id=182112
749
750         Reviewed by Chris Dumez.
751
752         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
753         (TEST):
754
755 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
756
757         [webkitpy] Stop modifying path information only when running on Cygwin
758         https://bugs.webkit.org/show_bug.cgi?id=182136
759
760         On LayoutTestApacheHttpd, some path configuration is modified when platform
761         is Windows. This modification is only required for AppleWin running on Cygwin.
762         WinCairo uses native Windows environment, so the condition should be changed.
763
764         Reviewed by Per Arne Vollan.
765
766         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
767         (LayoutTestApacheHttpd.__init__):
768         (LayoutTestApacheHttpd._get_apache_config_file_path):
769
770 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
771
772         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
773         https://bugs.webkit.org/show_bug.cgi?id=182038
774         <rdar://problem/36812083>
775
776         Reviewed by Jer Noble.
777
778         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
779         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
780
781 2018-01-24  Daniel Bates  <dabates@apple.com>
782
783         webkit-patch upload emits irrelevant simulator warnings
784         https://bugs.webkit.org/show_bug.cgi?id=181702
785         <rdar://problem/36556359>
786
787         Reviewed by Aakash Jain.
788
789         Remove warning when a person explicitly passes --child-processes with a value greater than
790         the default number of simulator instances webkitpy would have used had --child-processes
791         been omitted. Moreover, the placement of the warning logic to support printing such a message
792         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
793
794         By default, webkitpy will parallelize running tests using the maximum number of simulator
795         instances that can be supported based on available system resources at the time run-webkit-tests
796         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
797         by specifying --child-processes knows what they are doing. The effects of picking a large
798         value be obvious, the system may become sluggish.
799
800         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
801         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
802
803         * Scripts/webkitpy/port/ios_simulator.py:
804         (IOSSimulatorPort.__init__):
805
806 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
807
808         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
809         https://bugs.webkit.org/show_bug.cgi?id=182102
810
811         Reviewed by Carlos Garcia Campos.
812
813         * MiniBrowser/gtk/main.c:
814         (main): Removed the call to set_enable_webvr().
815
816 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
817
818         WebDriver: add support for slow tests
819         https://bugs.webkit.org/show_bug.cgi?id=182095
820
821         Reviewed by Carlos Alberto Lopez Perez.
822
823         Add timeout mark to slow tests.
824
825         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
826         (TestExpectationsMarker.__init__): Save the timeout.
827         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
828         (run): Pass timeout to TestExpectationsMarker constructor.
829
830 2018-01-24  Alex Christensen  <achristensen@webkit.org>
831
832         Gracefully recover from NetworkProcess crashes in private browsing
833         https://bugs.webkit.org/show_bug.cgi?id=182073
834         <rdar://problem/36572023>
835
836         Reviewed by Geoff Garen.
837
838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
839         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
840         (-[CrashDelegate webView:didFinishNavigation:]):
841         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
842         (-[CrashDelegate webView:didFailNavigation:withError:]):
843         (TEST):
844
845 2018-01-24  Ali Juma  <ajuma@chromium.org>
846
847         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
848         https://bugs.webkit.org/show_bug.cgi?id=182052
849
850         Reviewed by Simon Fraser.
851
852         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
853         immediately.
854
855         Test: fast/visual-viewport/viewport-dimensions.html
856
857         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
858         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
859
860 2018-01-24  Alex Christensen  <achristensen@webkit.org>
861
862         Remove pre-Sierra-OS-specific code in Tools
863         https://bugs.webkit.org/show_bug.cgi?id=182034
864
865         Reviewed by Tim Horton.
866
867         * DumpRenderTree/mac/DumpRenderTree.mm:
868         (setDefaultsToConsistentValuesForTesting):
869         * MiniBrowser/mac/BrowserWindowController.m:
870         (-[BrowserWindowController windowDidLoad]):
871         (-[BrowserWindowController share:]):
872         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
873         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
874         (-[EventStreamPlayer playbackTimerFired:]):
875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
876         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
877         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
878         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
879         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
880         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
881         (WTR::InjectedBundle::platformInitialize):
882         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
883         (WTR::initializeWebViewConfiguration):
884
885 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
886
887         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
888         https://bugs.webkit.org/show_bug.cgi?id=181400
889         <rdar://problem/36358768>
890
891         Reviewed by Joseph Pecoraro.
892
893         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
894
895         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
896         Always disable poisoning when running with --leaks, as this should work locally,
897         not just on bots.
898
899 2018-01-24  Daniel Bates  <dabates@apple.com>
900
901         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
902         https://bugs.webkit.org/show_bug.cgi?id=181993
903         <rdar://problem/36421080>
904
905         Reviewed by David Hyatt.
906
907         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
908         as we no longer support this strategy.
909
910         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
911
912 2018-01-24  David Kilzer  <ddkilzer@apple.com>
913
914         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
915         <https://webkit.org/b/182015>
916         <rdar://problem/36449728>
917
918         Reviewed by Tim Horton.
919
920         * Scripts/webkitpy/style/checkers/cpp.py:
921         (regex_for_lambdas_and_blocks): Update regex to include
922         optional return type for block argument in Objective-C.
923         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
924         (WebKitStyleTest.test_braces): Add test.
925
926 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
927
928         WPE-focused test gardening.
929         https://bugs.webkit.org/show_bug.cgi?id=182051
930
931         Unreviewed test gardening.
932
933         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
934
935 2018-01-23  Mark Lam  <mark.lam@apple.com>
936
937         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
938         https://bugs.webkit.org/show_bug.cgi?id=182017
939         <rdar://problem/36795513>
940
941         Reviewed by Filip Pizlo and JF Bastien.
942
943         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
944         (TestWebKitAPI::TEST):
945         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
946         (TestWebKitAPI::TEST):
947         (TestWebKitAPI::passWithRef):
948         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
949         (TestWebKitAPI::TEST):
950         (TestWebKitAPI::f1):
951         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
952         (TestWebKitAPI::TEST):
953         (TestWebKitAPI::poisonedPtrFoo):
954         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
955         (TestWebKitAPI::TEST):
956         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
957         (TestWebKitAPI::TEST):
958
959 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
960
961         [WebVR] Add OpenVR to the tree and to the build
962         https://bugs.webkit.org/show_bug.cgi?id=177298
963
964         Reviewed by Žan Doberšek.
965
966         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
967         with reduced style checks.
968
969 2018-01-24  Chris Nardi  <cnardi@chromium.org>
970
971         Add Chris Nardi to contributors list
972         https://bugs.webkit.org/show_bug.cgi?id=182029
973
974         Reviewed by Antti Koivisto.
975
976         * Scripts/webkitpy/common/config/contributors.json:
977
978 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
979
980         Mac Sierra perf bots have been failing due to CG errors
981         https://bugs.webkit.org/show_bug.cgi?id=181955
982
983         Reviewed by Antti Koivisto.
984
985         Ignore the CoreGraphics error messages on macOS Sierra.
986
987         Also added tests for ignoring lines in stdout and stderr.
988
989         * Scripts/webkitpy/performance_tests/perftest.py:
990         (PerfTest.run_failed): Refactored for clarity.
991         (PerfTest):
992         (PerfTest.filter_ignored_lines): Added.
993         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
994         are now used to ignore lines in other kinds of tests than parser tests.
995         (PerfTest._errors_to_ignore_in_sierra): Added.
996         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
997         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
998         (test_parse_output_with_ignored_stdout): Added.
999         (test_parse_output_with_ignored_stderr): Added.
1000         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
1001
1002 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
1003
1004         Resign NowPlaying status when no media element is eligible
1005         https://bugs.webkit.org/show_bug.cgi?id=181914
1006         <rdar://problem/35294116>
1007
1008         Reviewed by Jer Noble.
1009
1010         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1011         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1012         (TestWebKitAPI::TEST):
1013         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1014
1015 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1016
1017         [WinCairo] Use 64-bit toolset
1018         https://bugs.webkit.org/show_bug.cgi?id=181979
1019
1020         Reviewed by Alex Christensen.
1021
1022         Use 64-bit toolset for 64-bit build in order to improve build time. 
1023
1024         * Scripts/webkitdirs.pm:
1025         (generateBuildSystemFromCMakeProject):
1026
1027 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
1028
1029         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
1030         https://bugs.webkit.org/show_bug.cgi?id=181741
1031         rdar://problem/36593581
1032
1033         Reviewed by Tim Horton.
1034         
1035         If zoomToScale:animated: is called with the current zoom level, call the callback
1036         rather than doing nothing.
1037
1038         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1039         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1040
1041 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1042
1043         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
1044         https://bugs.webkit.org/show_bug.cgi?id=180820
1045
1046         Reviewed by David Kilzer.
1047
1048         * Scripts/webkitpy/common/checkout/scm/git.py:
1049         (Git.in_working_directory):
1050         (Git.clone):
1051         (Git.read_git_config):
1052         (Git.apply_reverse_diff):
1053         * Scripts/webkitpy/common/checkout/scm/scm.py:
1054         (SCM.run):
1055         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1056         * Scripts/webkitpy/common/checkout/scm/svn.py:
1057         (SVNRepository.has_authorization_for_realm):
1058         * Scripts/webkitpy/common/net/credentials_unittest.py:
1059         * Scripts/webkitpy/common/system/abstractexecutive.py:
1060         (AbstractExecutive.run_command):
1061         * Scripts/webkitpy/common/system/executive.py:
1062         (Executive.kill_process.is):
1063         (Executive.running_pids):
1064         (Executive.kill_all):
1065         (Executive.run_command):
1066         * Scripts/webkitpy/common/system/executive_mock.py:
1067         (MockExecutive.run_command):
1068         (MockExecutive2.run_command):
1069         * Scripts/webkitpy/common/system/executive_unittest.py:
1070         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
1071         * Scripts/webkitpy/common/system/platforminfo.py:
1072         (PlatformInfo.xcode_sdk_version):
1073         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1074         (Lighttpd._check_and_kill):
1075         * Scripts/webkitpy/port/base.py:
1076         (Port._symbols_string):
1077         * Scripts/webkitpy/port/gtk.py:
1078         (GtkPort.setup_environ_for_server):
1079         * Scripts/webkitpy/port/win.py:
1080         (WinPort._runtime_feature_list):
1081         (WinPort.read_registry_value):
1082         * Scripts/webkitpy/port/win_unittest.py:
1083         (WinPortTest.test_runtime_feature_list):
1084         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1085         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
1086
1087 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1088
1089         Unreviewed, rolling out r227279 and r227373.
1090         https://bugs.webkit.org/show_bug.cgi?id=181988
1091
1092         The LayoutTest crash fix introduced an API test failure.
1093         (Requested by ryanhaddad on #webkit).
1094
1095         Reverted changesets:
1096
1097         "Resign NowPlaying status when no media element is eligible"
1098         https://bugs.webkit.org/show_bug.cgi?id=181914
1099         https://trac.webkit.org/changeset/227279
1100
1101         "Resign NowPlaying status when no media element is eligible"
1102         https://bugs.webkit.org/show_bug.cgi?id=181914
1103         https://trac.webkit.org/changeset/227373
1104
1105 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1106
1107         Unreviewed. Add test case for slow in test_expectations.py.
1108
1109         I forgot to also check slow tests in test_expectations.py unit tests.
1110
1111         * Scripts/webkitpy/common/test_expectations_unittest.py:
1112         (assert_slow):
1113         (test_build_type):
1114         (test_slow):
1115
1116 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1117
1118         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
1119
1120         * TestWebKitAPI/glib/TestExpectations.json:
1121
1122 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1123
1124         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
1125         https://bugs.webkit.org/show_bug.cgi?id=181616
1126         <rdar://problem/36484908>
1127
1128         Reviewed by Wenson Hsieh.
1129
1130         Added tests to make sure we sanitize plain HTML, not just web archives,
1131         when and only when custom pasteboard data is enabled.
1132
1133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1134         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
1135         (writeHTMLToPasteboard): Added.
1136         (createWebViewWithCustomPasteboardDataSetting): Added.
1137
1138 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
1139
1140         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1141         https://bugs.webkit.org/show_bug.cgi?id=181400
1142         rdar://problem/36358768
1143
1144         Reviewed by JF Bastien.
1145
1146         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
1147
1148 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1149
1150         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
1151         https://bugs.webkit.org/show_bug.cgi?id=181929
1152
1153         Reviewed by Michael Catanzaro.
1154
1155         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
1156         the website data completion callback is not called immediately, and a new file is created when the operation
1157         finishes. We need to check that the file was removing after calling clear.
1158
1159         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1160         (fileChangedCallback):
1161         (testWebsiteDataResourceLoadStatistics):
1162
1163 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1164
1165         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
1166
1167         * TestWebKitAPI/glib/TestExpectations.json:
1168
1169 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1170
1171         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
1172
1173         Partially revert r226782, the fix was wrong for the GLib version we currently use.
1174
1175         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1176         (testWebKitConsoleMessageNetworkError):
1177
1178 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1179
1180         Unreviewed. Remove unused verbose mode from GLib API tests runner.
1181
1182         * glib/api_test_runner.py:
1183         (add_options):
1184
1185 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1186
1187         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1188         https://bugs.webkit.org/show_bug.cgi?id=181918
1189
1190         Reviewed by Tim Horton.
1191
1192         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1193
1194         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1195
1196 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
1197
1198         Resign NowPlaying status when no media element is eligible
1199         https://bugs.webkit.org/show_bug.cgi?id=181914
1200         <rdar://problem/35294116>
1201
1202         Reviewed by Jer Noble.
1203
1204         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1205         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1206         (TestWebKitAPI::TEST):
1207         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1208
1209 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
1210
1211         Fix broken unit-tests after r227192
1212         https://bugs.webkit.org/show_bug.cgi?id=181909
1213
1214         Reviewed by Carlos Garcia Campos.
1215
1216         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1217
1218 2018-01-20  Chris Dumez  <cdumez@apple.com>
1219
1220         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
1221         https://bugs.webkit.org/show_bug.cgi?id=174984
1222         <rdar://problem/33665676>
1223
1224         Reviewed by Alexey Proskuryakov.
1225
1226         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
1227
1228         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
1229         (TEST):
1230
1231 2018-01-20  Brian Burg  <bburg@apple.com>
1232
1233         WebDriver: fix some nits that prevent running W3C tests on Mac
1234         https://bugs.webkit.org/show_bug.cgi?id=181864
1235
1236         Reviewed by Carlos Garcia Campos.
1237
1238         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1239         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
1240         as we assume that the property exists later.
1241
1242         (WebDriverW3CWebServer.stop): If the temporary file doesn't
1243         exist for some reason, the remove call will raise and exception.
1244         Gracefully handle the case where the file isn't created due to
1245         a problem/exception that happened elsewhere.
1246
1247 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
1248
1249         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
1250         https://bugs.webkit.org/show_bug.cgi?id=181881
1251
1252         Reviewed by Alexey Proskuryakov.
1253
1254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1255         (BubbleQueueServer):
1256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1258         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
1259
1260 2018-01-19  Youenn Fablet  <youenn@apple.com>
1261
1262         Do not go to the storage process when registering a service worker client if there is no service worker registered
1263         https://bugs.webkit.org/show_bug.cgi?id=181740
1264         <rdar://problem/36650400>
1265
1266         Reviewed by Chris Dumez.
1267
1268         Add support for internals inside API tests.
1269
1270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1271         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
1272         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
1273         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
1274         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
1275         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
1276         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1277         (setConfigurationInjectedBundlePath):
1278         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
1279
1280 2018-01-19  John Wilander  <wilander@apple.com>
1281
1282         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
1283         https://bugs.webkit.org/show_bug.cgi?id=181822
1284         https://bugs.webkit.org/show_bug.cgi?id=175263
1285         https://bugs.webkit.org/show_bug.cgi?id=178536
1286         https://bugs.webkit.org/show_bug.cgi?id=181223
1287         https://bugs.webkit.org/show_bug.cgi?id=181482
1288         <rdar://problem/33491222>
1289         <rdar://problem/33805293>
1290         <rdar://problem/36332683>
1291         <rdar://problem/36549026>
1292
1293         Reviewed by Alex Christensen.
1294
1295         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1296         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1297         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1298         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1299         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1300         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1301         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1302         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1303
1304 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
1305
1306         run-webkit-tests fails when there is a curly brace in Xcode build output
1307         https://bugs.webkit.org/show_bug.cgi?id=181254
1308         <rdar://problem/36453374>
1309
1310         Reviewed by Daniel Bates.
1311
1312         * Scripts/webkitpy/port/base.py:
1313         (Port._run_script): Encode script output before logging it.
1314
1315 2018-01-19  Chris Dumez  <cdumez@apple.com>
1316
1317         Service worker registrations restored from disk may not be reused when the JS calls register() again
1318         https://bugs.webkit.org/show_bug.cgi?id=181810
1319         <rdar://problem/36591711>
1320
1321         Reviewed by Youenn Fablet.
1322
1323         Add API test coverage.
1324
1325         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1326         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
1327         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
1328
1329 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
1330
1331         Remove El Capitan queues from flakiness dashboard
1332         https://bugs.webkit.org/show_bug.cgi?id=181860
1333
1334         Reviewed by Aakash Jain.
1335
1336         * TestResultServer/static-dashboards/builders.jsonp:
1337
1338 2018-01-19  Keith Miller  <keith_miller@apple.com>
1339
1340         HaveInternalSDK includes should be "#include?"
1341         https://bugs.webkit.org/show_bug.cgi?id=179670
1342
1343         Reviewed by Dan Bernstein.
1344
1345         * MiniBrowser/Configurations/Base.xcconfig:
1346         * MobileMiniBrowser/Configurations/Base.xcconfig:
1347         * TestWebKitAPI/Configurations/Base.xcconfig:
1348         * WebKitTestRunner/Configurations/Base.xcconfig:
1349
1350 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1351
1352         WebDriver: driver environment not passed to pytest when running w3c tests
1353         https://bugs.webkit.org/show_bug.cgi?id=181852
1354
1355         Reviewed by Carlos Alberto Lopez Perez.
1356
1357         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
1358
1359         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1360         (WebDriverW3CExecutor.run):
1361
1362 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1363
1364         [GTK] WebDriver: wayland display no used in wayland bot
1365         https://bugs.webkit.org/show_bug.cgi?id=181851
1366
1367         Reviewed by Carlos Alberto Lopez Perez.
1368
1369         We need to handle the additionalArguments property in the WebDriverTests step.
1370
1371         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1372         (RunWebDriverTests.start):
1373
1374 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1375
1376         [GTK] TERM environment variable is not passed to the test driver.
1377         https://bugs.webkit.org/show_bug.cgi?id=181847
1378
1379         Rubber-stamped by by Carlos Garcia Campos.
1380
1381         * Scripts/webkitpy/port/base.py:
1382         (Port.to.setup_environ_for_server):
1383
1384 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1385
1386         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
1387         https://bugs.webkit.org/show_bug.cgi?id=181844
1388
1389         Reviewed by Carlos Alberto Lopez Perez.
1390
1391         We always try to create the directory where to store the json file, but when the filename is given directly,
1392         like in the bots, the current dir is used.
1393
1394         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1395         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
1396         empty string.
1397
1398 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1399
1400         [GTK] WebDriver tests are running outside the jhbuild env
1401         https://bugs.webkit.org/show_bug.cgi?id=181842
1402
1403         Reviewed by Žan Doberšek.
1404
1405         We need to enter jhbuild env in run-webdriver-tests.
1406
1407         * Scripts/run-webdriver-tests:
1408
1409 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1410
1411         [GTK] Run WebDriver tests in the bots
1412         https://bugs.webkit.org/show_bug.cgi?id=181787
1413
1414         Reviewed by Michael Catanzaro.
1415
1416         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
1417         factory for the GTK port for now.
1418
1419         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1420         (TestFactory.__init__):
1421         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1422         (RunWebDriverTests):
1423         (RunWebDriverTests.start):
1424         (RunWebDriverTests.commandComplete):
1425         (RunWebDriverTests.evaluateCommand):
1426         (RunWebDriverTests.getText):
1427         (RunWebDriverTests.getText2):
1428
1429 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1430
1431         [WinCairo] Pass correct url for http test to test driver.
1432         https://bugs.webkit.org/show_bug.cgi?id=181814
1433
1434         Reviewed by Alex Christensen.
1435
1436         * Scripts/webkitpy/port/driver.py:
1437         (Driver):
1438         (Driver.http_test_path_to_uri):
1439         (Driver.is_secure_path):
1440         (Driver.http_base_url):
1441         (Driver.uri_to_test):
1442
1443 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1444
1445         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
1446
1447         * BuildSlaveSupport/build.webkit.org-config/config.json:
1448
1449 2018-01-18  Dan Bernstein  <mitz@apple.com>
1450
1451         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1452         https://bugs.webkit.org/show_bug.cgi?id=181803
1453
1454         Reviewed by Tim Horton.
1455
1456         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
1457         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
1458         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
1459         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
1460         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
1461         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1462         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1463         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
1464         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
1465           helpers.
1466         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
1467           settings useful for defining settings that depend on the target macOS version.
1468         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
1469         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
1470
1471 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
1472
1473         Remove Opensource El Capitan queues from buildbot
1474         https://bugs.webkit.org/show_bug.cgi?id=181712
1475
1476         Reviewed by Aakash Jain.
1477
1478         * BuildSlaveSupport/build.webkit.org-config/config.json:
1479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1480         (WebKitBuildbot):
1481         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1482
1483 2018-01-18  Chris Dumez  <cdumez@apple.com>
1484
1485         Service Workers restored from persistent storage have 'redundant' state
1486         https://bugs.webkit.org/show_bug.cgi?id=181749
1487         <rdar://problem/36556486>
1488
1489         Reviewed by Youenn Fablet.
1490
1491         Add API test coverage.
1492
1493         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1494         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
1495
1496 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1497
1498         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
1499         https://bugs.webkit.org/show_bug.cgi?id=176796
1500
1501         Reviewed by Chris Fleizach.
1502
1503         Add sanity check that we have a URL before calling g_strstr_len().
1504
1505         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1506         (WTR::AccessibilityUIElement::url):
1507
1508 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1509
1510         Add triggers for Sierra test262 and perf queues
1511         https://bugs.webkit.org/show_bug.cgi?id=181799
1512
1513         Reviewed by Aakash Jain.
1514
1515         * BuildSlaveSupport/build.webkit.org-config/config.json:
1516
1517 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1518
1519         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
1520         https://bugs.webkit.org/show_bug.cgi?id=181783
1521         <rdar://problem/35785445>
1522
1523         Reviewed by Ryosuke Niwa.
1524
1525         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
1526         copying an image contains a relevant title.
1527
1528         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1529         (TestWebKitAPI::TEST):
1530         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1531         * TestWebKitAPI/ios/UIKitSPI.h:
1532
1533 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1534
1535         WebDriver: ignore the driver in selenium test names when getting expectations
1536         https://bugs.webkit.org/show_bug.cgi?id=181738
1537
1538         Reviewed by Carlos Alberto Lopez Perez.
1539
1540         In selenium tests, the driver is added as a parameter to every test which results in tests names like
1541         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
1542         driver name in the test expectations file, so we need to remove it when querying the expectations.
1543
1544         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1545         (TestExpectationsMarker.__init__): Save the param to ignore.
1546         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
1547         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
1548         (run): Pass param to ignore to TestExpectationsMarker().
1549         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1550         (WebDriverSeleniumExecutor.__init__): Save the driver name.
1551         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
1552
1553 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1554
1555         [GTK][WPE] Show unit tests unexpectedly passing in the bots
1556         https://bugs.webkit.org/show_bug.cgi?id=181726
1557
1558         Reviewed by Michael Catanzaro.
1559
1560         Now that we have the info, let's show it also in the bots.
1561
1562         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1563         (RunGLibAPITests.commandComplete):
1564
1565 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
1566
1567         Fix broken unittest after r227048
1568         https://bugs.webkit.org/show_bug.cgi?id=181760
1569
1570         Reviewed by Aakash Jain.
1571
1572
1573 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1574
1575         WEBKIT_FRAMEWORK should not modify file-global include directories
1576         https://bugs.webkit.org/show_bug.cgi?id=181656
1577
1578         Reviewed by Konstantin Tokarev.
1579
1580         * TestWebKitAPI/PlatformWPE.cmake:
1581         * TestWebKitAPI/glib/CMakeLists.txt:
1582
1583 2018-01-17  Alicia Boya García  <aboya@igalia.com>
1584
1585         Unreviewed, mark Alicia as committer in contributors.json
1586
1587         * Scripts/webkitpy/common/config/contributors.json:
1588
1589 2018-01-17  Youenn Fablet  <youenn@apple.com>
1590
1591         Put fetch Request.keepalive behind a runtime flag
1592         https://bugs.webkit.org/show_bug.cgi?id=181592
1593
1594         Reviewed by Chris Dumez.
1595
1596         * DumpRenderTree/mac/DumpRenderTree.mm:
1597         (enableExperimentalFeatures):
1598         * DumpRenderTree/win/DumpRenderTree.cpp:
1599         (enableExperimentalFeatures):
1600         * WebKitTestRunner/TestController.cpp:
1601         (WTR::TestController::resetPreferencesToConsistentValues):
1602
1603 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1604
1605         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1606         https://bugs.webkit.org/show_bug.cgi?id=181637
1607         <rdar://problem/36508471>
1608
1609         Reviewed by Tim Horton.
1610
1611         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
1612         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
1613
1614         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1615         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1616         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
1617
1618         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
1619         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
1620
1621         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1622         (webViewForTestingAttachments):
1623         (-[TestWKWebView tagsInBody]):
1624         (-[TestWKWebView expectElementTagsInOrder:]):
1625         (-[TestWKWebView expectElementTag:toComeBefore:]):
1626
1627         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
1628         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
1629
1630         (TestWebKitAPI::TEST):
1631         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1632         (WTR::InjectedBundlePage::InjectedBundlePage):
1633
1634 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1635
1636         WebDriver: add support for test expectations
1637         https://bugs.webkit.org/show_bug.cgi?id=180420
1638
1639         Reviewed by Carlos Alberto Lopez Perez.
1640
1641         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
1642
1643         * Scripts/run-webdriver-tests: Get the retval from process_results().
1644         * Scripts/webkitpy/thirdparty/__init__.py:
1645         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
1646         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1647         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
1648         (TestExpectationsMarker.__init__): Initialize expectations.
1649         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
1650         (run): Create and use TestExpectationsMarker plugin.
1651         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1652         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
1653         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1654         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
1655         (WebDriverTestRunner.run): Do not count results here.
1656         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
1657         amount of failures. Printing the test summary while processing results will be made optional in a follow up
1658         patch.
1659         (WebDriverTestRunner.process_results.report): Return the amount of failures.
1660         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1661         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
1662         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
1663         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
1664         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1665         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
1666         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
1667         (WebDriverTestRunnerW3C._scan_directory): Ditto.
1668         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
1669         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1670         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
1671
1672 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1673
1674         Unreviewed WPE gardening. Mark some known unit test failures.
1675
1676         * TestWebKitAPI/glib/TestExpectations.json:
1677
1678 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1679
1680         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
1681         https://bugs.webkit.org/show_bug.cgi?id=181724
1682
1683         Reviewed by Philippe Normand.
1684
1685         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
1686         reason to use different names. This way we can refer to the same test names for both and we can share the
1687         expectations in the TestExpectations.json file.
1688
1689         * TestWebKitAPI/glib/TestExpectations.json:
1690         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
1691
1692 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1693
1694         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
1695
1696         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
1697         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
1698
1699         * glib/api_test_runner.py:
1700         (TestRunner._run_test_glib):
1701         (TestRunner._run_google_test):
1702
1703 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1704
1705         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
1706         https://bugs.webkit.org/show_bug.cgi?id=179914
1707
1708         Reviewed by Žan Doberšek.
1709
1710         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
1711         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
1712         all symbols listed in the script are present in the library.
1713
1714         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
1715         (bss_symbols):
1716         * Scripts/check-for-invalid-symbols-in-version-script: Added.
1717         (script_symbols):
1718         * Scripts/make-dist:
1719         (Distcheck.build):
1720         (Distcheck):
1721         (Distcheck.check_symbols):
1722         (Distcheck.check):
1723
1724 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1725
1726         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
1727         https://bugs.webkit.org/show_bug.cgi?id=181722
1728
1729         Reviewed by Žan Doberšek.
1730
1731         I forgot to pass the parameters to run() when restarting.
1732
1733         * glib/glib_test_runner.py:
1734         (GLibTestRunner.run):
1735
1736 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1737
1738         [CMake] Remove WebCoreDerivedSources library target
1739         https://bugs.webkit.org/show_bug.cgi?id=181664
1740
1741         Reviewed by Carlos Garcia Campos.
1742
1743         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
1744         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1745
1746 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
1747
1748         Move Debug Test262, Release Test262 and Performance queues to Sierra
1749         https://bugs.webkit.org/show_bug.cgi?id=181692
1750
1751         Unreviewed
1752
1753 2018-01-16  Zach Li  <zachli@apple.com>
1754
1755         Add pop-up policy support in website policies.
1756         https://bugs.webkit.org/show_bug.cgi?id=181544.
1757         rdar://problem/30521400.
1758
1759         Reviewed by Alex Christensen.
1760
1761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1762         Added pop-up-check.html.
1763
1764         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
1765
1766         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1767         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1768         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1769         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1770         (TEST):
1771
1772 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1773
1774         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
1775         https://bugs.webkit.org/show_bug.cgi?id=181638
1776         <rdar://problem/36508702>
1777
1778         Reviewed by Dan Bernstein.
1779
1780         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
1781         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
1782
1783         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1784         (-[AttachmentUpdateObserver init]):
1785         (-[AttachmentUpdateObserver sourceForIdentifier:]):
1786         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
1787         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
1788         (TestWebKitAPI::TEST):
1789         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
1790
1791 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1792
1793         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
1794
1795         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
1796
1797         * glib/api_test_runner.py:
1798         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
1799         * glib/glib_test_runner.py:
1800         (GLibTestRunner.run): Use given env.
1801
1802 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1803
1804         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
1805         https://bugs.webkit.org/show_bug.cgi?id=181676
1806
1807         Reviewed by Carlos Alberto Lopez Perez.
1808
1809         The option was removed in r226967.
1810
1811         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1812         (RunGtkAPITests):
1813         (RunWPEAPITests):
1814
1815 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1816
1817         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
1818
1819         The bots are still passing that option and the step is failing because it was removed in r226967.
1820
1821         * glib/api_test_runner.py:
1822         (add_options):
1823
1824 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1825
1826         [GTK][WPE] Improve the way glib tests are run
1827         https://bugs.webkit.org/show_bug.cgi?id=181674
1828
1829         Reviewed by Žan Doberšek.
1830
1831         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
1832         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
1833         tests failing due to an expected assert in the test and unexpected crashes.
1834         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
1835         not showing the subtest name in stdout in case of timeouts.
1836         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
1837         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
1838         of every test case.
1839
1840         * glib/api_test_runner.py:
1841         (TestRunner._run_test_glib): Use GLibTestRunner.
1842         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
1843         (add_options):
1844         * glib/glib_test_runner.py: Added.
1845         (TestTimeout):
1846         (Message):
1847         (Message.__init__):
1848         (Message.create):
1849         (Message.create.read_unsigned):
1850         (Message.create.read_double):
1851         (Message.create.read_string):
1852         (GLibTestRunner):
1853         (GLibTestRunner.__init__):
1854         (GLibTestRunner._process_data):
1855         (GLibTestRunner._process_message):
1856         (GLibTestRunner._read_from_pipe):
1857         (GLibTestRunner._read_from_stderr):
1858         (GLibTestRunner._start_timeout):
1859         (GLibTestRunner._start_timeout._alarm_handler):
1860         (GLibTestRunner._stop_timeout):
1861         (GLibTestRunner._subtest_start):
1862         (GLibTestRunner._subtest_message):
1863         (GLibTestRunner._subtest_stderr):
1864         (GLibTestRunner._subtest_end):
1865         (GLibTestRunner.run):
1866
1867 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1868
1869         Unreviewed, add Thibault to contributors.json
1870
1871         It's a bit weird to add someone here before their first contribution, but this affects
1872         Bugzilla autocomplete, and that is serious business.
1873
1874         * Scripts/webkitpy/common/config/contributors.json:
1875
1876 2018-01-15  JF Bastien  <jfbastien@apple.com>
1877
1878         Remove makePoisonedUnique
1879         https://bugs.webkit.org/show_bug.cgi?id=181630
1880         <rdar://problem/36498623>
1881
1882         Reviewed by Mark Lam.
1883
1884         Update tests.
1885
1886         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1887         (TestWebKitAPI::TEST):
1888         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1889         (TestWebKitAPI::TEST):
1890
1891 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
1892
1893         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
1894         https://bugs.webkit.org/show_bug.cgi?id=181476
1895
1896         Reviewed by Michael Catanzaro.
1897
1898         Update to xorg-server 1.19.6 which depends on libxfont2, and change
1899         the lists of packages to install libxfont2-devel (or equivalent).
1900
1901         * gtk/install-dependencies:
1902         * gtk/jhbuild.modules:
1903
1904 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1905
1906         [GTK][WPE] Add support for unit test expectations
1907         https://bugs.webkit.org/show_bug.cgi?id=181589
1908
1909         Reviewed by Michael Catanzaro.
1910
1911         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
1912         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
1913         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
1914         script itself is not a good idea either.
1915
1916         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
1917         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
1918         convenient methods to query them.
1919
1920         * Scripts/run-gtk-tests:
1921         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
1922         * Scripts/run-wpe-tests:
1923         (WPETestRunner): Ditto.
1924         * Scripts/webkitpy/common/test_expectations.py: Added.
1925         (TestExpectations):
1926         (TestExpectations.__init__):
1927         (TestExpectations._port_name_for_expected):
1928         (TestExpectations._expected_value):
1929         (TestExpectations.skipped_tests):
1930         (TestExpectations.skipped_subtests):
1931         (TestExpectations._expectation_value):
1932         (TestExpectations.is_slow):
1933         (TestExpectations.get_expectation):
1934         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
1935         (MockTestExpectations):
1936         (MockTestExpectations.__init__):
1937         (MockTestExpectations.is_skip):
1938         (ExpectationsTest):
1939         (assert_exp):
1940         (assert_not_exp):
1941         (assert_bad_exp):
1942         (assert_skip):
1943         (test_basic):
1944         (test_skip):
1945         (test_flaky):
1946         (test_build_type):
1947         * TestWebKitAPI/glib/TestExpectations.json: Added.
1948         * glib/api_test_runner.py:
1949         (TestRunner): Remove SkippedTest implementation.
1950         (TestRunner.__init__): Create a TestExpectations.
1951         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
1952         (TestRunner._should_run_test_program): Ditto.
1953         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
1954         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
1955         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
1956         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
1957         (TestRunner.run_tests.report): Helper to write report to stdout.
1958
1959 2018-01-13  Mark Lam  <mark.lam@apple.com>
1960
1961         Replace all use of ConstExprPoisoned with Poisoned.
1962         https://bugs.webkit.org/show_bug.cgi?id=181542
1963         <rdar://problem/36442138>
1964
1965         Reviewed by JF Bastien.
1966
1967         1. Converted tests to using new uintptr_t& poison type.
1968         2. Added tests for Poisoned comparison operators.
1969
1970         * TestWebKitAPI/CMakeLists.txt:
1971         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1972         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
1973         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1974         (TestWebKitAPI::TEST):
1975         (TestWebKitAPI::initializeTestPoison): Deleted.
1976         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1977         (TestWebKitAPI::TEST):
1978         (TestWebKitAPI::passWithRef):
1979         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1980         (TestWebKitAPI::TEST):
1981         (TestWebKitAPI::f1):
1982         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1983         (TestWebKitAPI::TEST):
1984         (TestWebKitAPI::poisonedPtrFoo):
1985         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1986         (TestWebKitAPI::TEST):
1987         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1988         (TestWebKitAPI::TEST):
1989
1990 2018-01-13  David Kilzer  <ddkilzer@apple.com>
1991
1992         check-webkit-style: false positive for [whitespace/braces] with os_log format string
1993         <https://webkit.org/b/181606>
1994
1995         Reviewed by Darin Adler.
1996
1997         * Scripts/webkitpy/style/checkers/cpp.py:
1998         (check_spacing): Modify regular expression to ignore
1999         os_log format strings like '%{public}'.
2000         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2001         (CppStyleTest.test_spacing_before_braces): Add os_log
2002         format string test.
2003
2004 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2005
2006         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
2007         https://bugs.webkit.org/show_bug.cgi?id=181626
2008
2009         Reviewed by Joseph Pecoraro.
2010
2011         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
2012         Additionally, write a new API test covering the change in r226915.
2013
2014         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2015         (webViewForTestingAttachments):
2016         (TestWebKitAPI::TEST):
2017
2018 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2019
2020         History state should be updated during client redirects with asynchronous policy decisions
2021         https://bugs.webkit.org/show_bug.cgi?id=181358
2022         <rdar://problem/35547689>
2023
2024         Reviewed by Andy Estes.
2025
2026         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2027         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
2028         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2029         (TEST):
2030
2031 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
2032
2033         webkitpy: Refactor simulator code (Part 4)
2034         https://bugs.webkit.org/show_bug.cgi?id=180555
2035         <rdar://problem/36131381>
2036
2037         Reviewed by Aakash Jain.
2038
2039         Move new_simulated_device.py to simulated_device.py.
2040
2041         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
2042         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
2043         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
2044         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
2045         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
2046
2047 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2048
2049         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
2050         https://bugs.webkit.org/show_bug.cgi?id=181595
2051
2052         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
2053         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
2054         I change the < and > to $ to make this test pass and continue to test what it used to.
2055
2056         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
2057         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2058         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2059
2060 2018-01-11  Keith Miller  <keith_miller@apple.com>
2061
2062         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
2063         https://bugs.webkit.org/show_bug.cgi?id=181573
2064
2065         Reviewed by Simon Fraser.
2066
2067         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2068
2069 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
2070
2071         [WebAuthN] Import a CBOR coder from Chromium
2072         https://bugs.webkit.org/show_bug.cgi?id=181522
2073         <rdar://problem/36055729>
2074
2075         Reviewed by Brent Fulgham.
2076
2077         This patch also imports all unit tests into our API tests to ensure all
2078         workarounds and modification against the original codebase doesn't change
2079         any original functionalities.
2080
2081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2082         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
2083         (TestWebKitAPI::TEST):
2084         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
2085         (TestWebKitAPI::TEST):
2086         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
2087         (TestWebKitAPI::eq):
2088         Workarounds applied.
2089         (TestWebKitAPI::TEST):
2090
2091 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2092
2093         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
2094         https://bugs.webkit.org/show_bug.cgi?id=181538
2095         <rdar://problem/36440580>
2096
2097         Reviewed by Aakash Jain.
2098
2099         When disambiguating a device type, it is possible that the provided device type is sufficiently
2100         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
2101         will result in a failure to disambiguate the type.
2102
2103         * Scripts/webkitpy/xcode/new_simulated_device.py:
2104         (SimulatedDeviceManager._disambiguate_device_type):
2105
2106 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
2107
2108         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
2109         https://bugs.webkit.org/show_bug.cgi?id=181136
2110         <rdar://problem/36116604>
2111
2112         Reviewed by Chris Dumez.
2113
2114         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
2115         browsing sessions.
2116
2117         * Scripts/run-gtk-tests:
2118         (GtkTestRunner): Unskip test now that it passes.
2119         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2120         (TEST): Add new WebsiteDataStoreEphemeral test.
2121
2122 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2123
2124         Unreviewed, rolling out r226816.
2125
2126         This change broke LayoutTests on the bots.
2127
2128         Reverted changeset:
2129
2130         "run-webkit-tests fails when there is a curly brace in Xcode
2131         build output"
2132         https://bugs.webkit.org/show_bug.cgi?id=181254
2133         https://trac.webkit.org/changeset/226816
2134
2135 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2136
2137         webkitpy: Fix flakey webserver tests
2138         https://bugs.webkit.org/show_bug.cgi?id=181555
2139         <rdar://problem/36448273>
2140
2141         Reviewed by Aakash Jain.
2142
2143         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2144         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
2145         determine if a specific server is running.
2146
2147 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2148
2149         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
2150         https://bugs.webkit.org/show_bug.cgi?id=181561
2151         <rdar://problem/36452652>
2152
2153         Reviewed by Aakash Jain.
2154
2155         BeautifulSoup.find may return None, this case should be gracefully handled.
2156
2157         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2158         (BugzillaQueries._parse_result_count):
2159         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
2160
2161 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
2162
2163         run-webkit-tests fails when there is a curly brace in Xcode build output
2164         https://bugs.webkit.org/show_bug.cgi?id=181254
2165
2166         Reviewed by Daniel Bates.
2167
2168         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2169         (MeteredStream.write):
2170
2171 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2172
2173         webkitpy: Reimplement simulator code (Part 3)
2174         https://bugs.webkit.org/show_bug.cgi?id=180555
2175         <rdar://problem/36131381>
2176
2177         Reviewed by Aakash Jain.
2178
2179         Remove old simulator code.
2180
2181         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
2182         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
2183         * Scripts/webkitpy/xcode/simulator.py: Removed.
2184         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
2185
2186 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2187
2188         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
2189         https://bugs.webkit.org/show_bug.cgi?id=181337
2190         <rdar://problem/36324813>
2191
2192         Reviewed by Tim Horton.
2193
2194         Add 3 new API tests for attachment element dragging.
2195
2196         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2197         (-[TestWKWebView expectElementTag:toComeBefore:]):
2198         (-[NSItemProvider expectType:withData:]):
2199         (TestWebKitAPI::TEST):
2200
2201 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2202
2203         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
2204         https://bugs.webkit.org/show_bug.cgi?id=179621
2205         <rdar://problem/35589585>
2206
2207         Unreviewed infrastructure fix.
2208
2209         * Scripts/webkitpy/port/mac.py:
2210         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
2211         list if we are the VERSION_MAX, which usually corresponds with future.
2212
2213 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
2214
2215         CodeBlocks should be in IsoSubspaces
2216         https://bugs.webkit.org/show_bug.cgi?id=180884
2217
2218         Reviewed by Saam Barati.
2219         
2220         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
2221         shouldn't take a long time due to benchmarks we don't optimize for.
2222         
2223         * Scripts/run-jsc-benchmarks:
2224
2225 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
2226
2227         Test gardening for GTK.
2228         https://bugs.webkit.org/show_bug.cgi?id=181477
2229
2230         Unreviewed test gardening.
2231
2232         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
2233         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
2234
2235 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2236
2237         Add the new JSCOnly bot to the scheduler.
2238         https://bugs.webkit.org/show_bug.cgi?id=181487
2239
2240         Unreviewed follow-up patch after r226729
2241
2242         On r226729 I missed to add the new JSCOnly bot the default scheduler.
2243         This is needed to make the bot automatically pick each commit for testing.
2244
2245         * BuildSlaveSupport/build.webkit.org-config/config.json:
2246
2247 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2248
2249         [Attachment Support] Support dragging attachment elements out as files on iOS
2250         https://bugs.webkit.org/show_bug.cgi?id=181199
2251         <rdar://problem/36299316>
2252
2253         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
2254
2255         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
2256         attachment API tests.
2257
2258         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2259         (-[NSItemProvider expectType:withData:]):
2260         (TestWebKitAPI::TEST):
2261
2262         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
2263         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
2264         -expectType:withData: helper to inspect the item providers created from the drag source.
2265
2266         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2267         (TestWebKitAPI::TEST):
2268         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2269         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2270         (-[MockDragSession localContext]):
2271         (-[MockDragSession setLocalContext:]):
2272         (-[DataInteractionSimulator _resetSimulatedState]):
2273         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
2274         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2275         (-[DataInteractionSimulator _advanceProgress]):
2276         (-[DataInteractionSimulator endDataTransfer]):
2277
2278         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
2279         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
2280         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
2281         MockDragSession to hold on to a localContext.
2282
2283 2018-01-11  Ali Juma  <ajuma@chromium.org>
2284
2285         Unreviewed. Add Ali Juma as contributor
2286
2287         * Scripts/webkitpy/common/config/contributors.json:
2288
2289 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2290
2291         Unreviewed. Update Selenium WebDriver imported tests.
2292
2293         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
2294         environment variables.
2295
2296         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2297         (collect): Reorder the arguments to make pytest happy.
2298         (run): Ditto.
2299         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2300         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
2301
2302 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
2303
2304         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
2305         https://bugs.webkit.org/show_bug.cgi?id=181492
2306         <rdar://problem/36359679>
2307
2308         Reviewed by Alexey Proskuryakov. 
2309
2310 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
2311
2312         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
2313         https://bugs.webkit.org/show_bug.cgi?id=181475
2314
2315         Reviewed by Michael Catanzaro.
2316
2317         * gtk/install-dependencies: Update package list for Arch Linux, extend
2318         message shown at end of installation with additional tips.
2319
2320 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2321
2322         REGRESSION(r222507): Composition highlight doesn't render when using IME
2323         https://bugs.webkit.org/show_bug.cgi?id=181485
2324         <rdar://problem/35896516>
2325
2326         Reviewed by Ryosuke Niwa.
2327
2328         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
2329         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
2330         allow rendering composition backgrounds (see InlineTextBox::paint).
2331
2332         * DumpRenderTree/ios/TextInputControllerIOS.m:
2333         (+[TextInputController isSelectorExcludedFromWebScript:]):
2334         (+[TextInputController webScriptNameForSelector:]):
2335         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2336         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2337         * DumpRenderTree/mac/TextInputControllerMac.m:
2338         (+[TextInputController isSelectorExcludedFromWebScript:]):
2339         (+[TextInputController webScriptNameForSelector:]):
2340         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2341         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2342         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2343         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2344         (WTR::TextInputController::setMarkedText):
2345         * WebKitTestRunner/InjectedBundle/TextInputController.h:
2346
2347 2018-01-10  JF Bastien  <jfbastien@apple.com>
2348
2349         Poison small JSObject derivatives which only contain pointers
2350         https://bugs.webkit.org/show_bug.cgi?id=181483
2351         <rdar://problem/36407127>
2352
2353         Reviewed by Mark Lam.
2354
2355         Test the new move-assign and move-copy from unique_ptr, as well as
2356         nullptr_t ctors.
2357
2358         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2359         (TestWebKitAPI::TEST):
2360         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2361         (TestWebKitAPI::TEST):
2362         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2363         (TestWebKitAPI::TEST):
2364
2365 2018-01-10  Chris Dumez  <cdumez@apple.com>
2366
2367         Multiple http/wpt/beacon/contentextensions/ test are flaky.
2368         https://bugs.webkit.org/show_bug.cgi?id=179256
2369         <rdar://problem/35401978>
2370
2371         Reviewed by Alex Christensen.
2372
2373         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
2374         instance gets its own folder to avoid conflicts and flakiness.
2375
2376         * WebKitTestRunner/mac/TestControllerMac.mm:
2377         (WTR::TestController::platformConfigureViewForTest):
2378
2379 2018-01-10  Tim Horton  <timothy_horton@apple.com>
2380
2381         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
2382         https://bugs.webkit.org/show_bug.cgi?id=181269
2383         <rdar://problem/35110344>
2384
2385         Reviewed by Simon Fraser.
2386
2387         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2388         (WTR::UIScriptController::beginBackSwipe):
2389         (WTR::UIScriptController::completeBackSwipe):
2390         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2391         (WTR::UIScriptController::beginBackSwipe):
2392         (WTR::UIScriptController::completeBackSwipe):
2393         (WTR::UIScriptController::overridePreference):
2394         (WTR::UIScriptController::replaceTextAtRange):
2395         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2396         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2397         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2398         (WTR::UIScriptController::beginBackSwipe):
2399         (WTR::UIScriptController::completeBackSwipe):
2400         Implement beginBackSwipe and completeBackSwipe on iOS (they already
2401         exist on Mac) in terms of the new WKWebView testing SPI.
2402
2403 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2404
2405         REGRESSION (r226715): ignore WARNING output in linter tests
2406         https://bugs.webkit.org/show_bug.cgi?id=181486
2407         <rdar://problem/36408847>
2408
2409         Reviewed by Aakash Jain.
2410
2411         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
2412
2413         * Scripts/webkitpy/common/system/outputcapture.py:
2414         (OutputCapture.__init__): Pass logging level to be captured.
2415         * Scripts/webkitpy/style/main_unittest.py:
2416         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
2417         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
2418         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
2419         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
2420         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
2421         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
2422         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
2423         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
2424
2425 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2426
2427         Add a JSCOnly MIPS buildbot
2428         https://bugs.webkit.org/show_bug.cgi?id=181487
2429
2430         Reviewed by Michael Catanzaro.
2431
2432         Add the new bot configs definitions for the master and update the unit tests.
2433
2434         * BuildSlaveSupport/build.webkit.org-config/config.json:
2435         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2436
2437 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2438
2439         REGRESSION (r226715): don't re-check number of simulators in child processes
2440         https://bugs.webkit.org/show_bug.cgi?id=181484
2441         <rdar://problem/36407151>
2442
2443         Reviewed by Aakash Jain.
2444
2445         * Scripts/webkitpy/port/ios_simulator.py:
2446         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
2447         are already initialized.
2448
2449 2018-01-10  Commit Queue  <commit-queue@webkit.org>
2450
2451         Unreviewed, rolling out r226667 and r226673.
2452         https://bugs.webkit.org/show_bug.cgi?id=181488
2453
2454         This caused a flaky crash. (Requested by mlewis13 on #webkit).
2455
2456         Reverted changesets:
2457
2458         "CodeBlocks should be in IsoSubspaces"
2459         https://bugs.webkit.org/show_bug.cgi?id=180884
2460         https://trac.webkit.org/changeset/226667
2461
2462         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
2463         https://bugs.webkit.org/show_bug.cgi?id=180884
2464         https://trac.webkit.org/changeset/226673
2465
2466 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2467
2468         Follow-up fix to r226715
2469         https://bugs.webkit.org/show_bug.cgi?id=180555
2470         <rdar://problem/36131381>
2471
2472         Unreviewed infrastructure fix.
2473
2474         * Scripts/webkitpy/xcode/new_simulated_device.py:
2475         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
2476         of delete.
2477
2478 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2479
2480         webkitpy: Refactor simulator code (Part 2)
2481         https://bugs.webkit.org/show_bug.cgi?id=180555
2482         <rdar://problem/36131381>
2483
2484         Reviewed by Aakash Jain.
2485
2486         The patch leverages the SimulatedDeviceManager when running layout tests.
2487         This patch is primarily code removal, since much of the IOSSimulatorPort
2488         was dedicated to managing simulators. The removed code is either now owned by the
2489         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
2490         boot multiple simulators which was made obsolete in Xcode 9.
2491
2492         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2493         (Manager._custom_device_for_test.in): Device names now have spaces in them,
2494         strip those spaces.
2495         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2496         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
2497         * Scripts/webkitpy/port/ios.py:
2498         (IOSPort.__init__): The _current_device idiom is no longer required since the
2499         SimulatedDeviceManager keeps track of any previously booted devices.
2500         (IOSPort.target_host): Even when only a single device is used, it will be accessed
2501         through the array of managed devices.
2502         (IOSPort.using_multiple_devices): Deleted.
2503         * Scripts/webkitpy/port/ios_device.py:
2504         (IOSDevicePort.using_multiple_devices): Deleted.
2505         * Scripts/webkitpy/port/ios_simulator.py:
2506         (IOSSimulatorPort): Remove constants required to manage simulators, change device
2507         class strings so they can be parsed by the DeviceType class.
2508         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
2509         the number of simulators currently booted, the number of child processes specified
2510         and the maximum number of simulators supported by this system.
2511         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
2512         devices owned by the SimulatedDeviceManager.
2513         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
2514         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
2515         the maximum number of supported simulators on this system.
2516         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
2517         request for each child process and send this list to the SimulatedDeviceManager to
2518         initialize the devices.
2519         (IOSSimulatorPort.clean_up_test_run):
2520         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
2521         specified version of iOS.
2522         (IOSSimulatorPort.reset_preferences):
2523         (IOSSimulatorPort.simulator_runtime): Deleted.
2524         (IOSSimulatorPort.simulator_device_type): Deleted.
2525         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
2526         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
2527         (IOSSimulatorPort._create_simulators): Deleted.
2528         (IOSSimulatorPort._quit_ios_simulator): Deleted.
2529         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
2530         (IOSSimulatorPort.using_multiple_devices): Deleted.
2531         (IOSSimulatorPort._create_device): Deleted.
2532         (IOSSimulatorPort.get_simulator_path): Deleted.
2533         (IOSSimulatorPort._createSimulatorApps): Deleted.
2534         (IOSSimulatorPort._createSimulatorApp): Deleted.
2535         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2536         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
2537         maximum number of simulators run on this system.
2538         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
2539         * Scripts/webkitpy/xcode/new_simulated_device.py:
2540         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
2541
2542 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2543
2544         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
2545         https://bugs.webkit.org/show_bug.cgi?id=181474
2546
2547         Reviewed by Carlos Alberto Lopez Perez.
2548
2549         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
2550         name as the name.
2551
2552         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2553         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
2554         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
2555
2556 2018-01-09  Andy Estes  <aestes@apple.com>
2557
2558         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
2559         https://bugs.webkit.org/show_bug.cgi?id=181459
2560
2561         Reviewed by Dan Bernstein.
2562
2563         * ImageDiff/cg/Configurations/Base.xcconfig:
2564
2565 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
2566
2567         font-display:fallback can cause a visual flash (which is supposed to be impossible)
2568         https://bugs.webkit.org/show_bug.cgi?id=181374
2569
2570         Reviewed by Simon Fraser.
2571
2572         The test requires Palatino.
2573
2574         * DumpRenderTree/mac/DumpRenderTree.mm:
2575         (allowedFontFamilySet):
2576         * WebKitTestRunner/mac/TestControllerMac.mm:
2577         (WTR::allowedFontFamilySet):
2578
2579 2018-01-09  Saam Barati  <sbarati@apple.com>
2580
2581         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
2582         https://bugs.webkit.org/show_bug.cgi?id=181449
2583
2584         Reviewed by JF Bastien.
2585
2586         This allows me to Cmd+f in my terminal to search for things without
2587         having the results become misaligned.
2588
2589         * Scripts/display-profiler-output:
2590
2591 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2592
2593         [webkitpy] PlatformInfo should have default argument for casual use
2594         https://bugs.webkit.org/show_bug.cgi?id=180827
2595
2596         Reviewed by David Kilzer.
2597
2598         PlatformInfo should be the only way to check platform specific thing instead
2599         of sys.platform or other various checks. If there is something you want to check,
2600         it should be placed in PlatformInfo.
2601
2602         Currently to instantiate PlatformInfo, it requires arguments, which is usually
2603         sys, platform and Executive(). They are straight forward and should be handled
2604         by default arguments. Then we can instantiate PlatformInfo more casual.
2605
2606         * Scripts/webkitpy/common/system/platforminfo.py:
2607         (PlatformInfo): Use relative module path import
2608         (PlatformInfo.__init__):
2609         (PlatformInfo.executive): Lazy instantiation of Executive()
2610         (PlatformInfo.total_bytes_memory): Accessing via above property
2611         (PlatformInfo.xcode_sdk_version): Ditto
2612         (PlatformInfo.xcode_simctl_list): Ditto
2613         (PlatformInfo.xcode_version): Ditto
2614         (PlatformInfo._win_version_str): Ditto
2615         * Scripts/webkitpy/common/system/systemhost.py:
2616         (SystemHost.__init__):
2617         * Scripts/webkitpy/common/system/user.py:
2618         (User.__init__):
2619
2620 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2621
2622         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
2623         https://bugs.webkit.org/show_bug.cgi?id=176443
2624
2625         Reviewed by Darin Adler.
2626
2627         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
2628         (TEST):
2629
2630 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
2631
2632         check-webkit-style: Verify syntax for WK_API_AVAILABLE
2633         https://bugs.webkit.org/show_bug.cgi?id=181394
2634
2635         Reviewed by Darin Adler.
2636
2637         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
2638         as the second parameter instead of ios(WK_IOS_TBA). This generally
2639         builds for iOS on EWS but not when using the public SDK. See r224057,
2640         r223207 and r226211 for example. This patch adds a basic style check
2641         for that macro to prevent this kind of mistake.
2642
2643         * Scripts/webkitpy/style/checkers/cpp.py:
2644         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
2645         (check_style): Run new style check.
2646         (CppChecker): Add build type for the new style check.
2647         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2648         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
2649
2650 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2651
2652         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
2653         https://bugs.webkit.org/show_bug.cgi?id=181420
2654         <rdar://problem/36365827>
2655
2656         Reviewed by Alex Christensen.
2657
2658         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
2659         of corresponding _WKAttachments.
2660
2661         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2662         (TestWebKitAPI::TEST):
2663
2664 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2665
2666         Add WKNavigationDelegate SPI exposing WebProcess crash reason
2667         https://bugs.webkit.org/show_bug.cgi?id=181410
2668         <rdar://problem/36167199>
2669
2670         Reviewed by Wenson Hsieh.
2671
2672         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2673         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
2674         (TEST):
2675
2676 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2677
2678         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
2679         https://bugs.webkit.org/show_bug.cgi?id=181408
2680         <rdar://problem/35884960>
2681
2682         Reviewed by Tim Horton.
2683
2684         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
2685         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2686
2687 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2688
2689         [Attachment Support] Expose file name and content type of WKAttachment
2690         https://bugs.webkit.org/show_bug.cgi?id=181390
2691         <rdar://problem/36336837>
2692
2693         Reviewed by Tim Horton.
2694
2695         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
2696
2697         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2698         (-[_WKAttachment synchronouslyRequestInfo:]):
2699         (-[_WKAttachment synchronouslyRequestData:]):
2700
2701         Reimplement this in terms of -synchronouslyRequestInfo:.
2702
2703         (-[_WKAttachment expectRequestedDataToBe:]):
2704         (TestWebKitAPI::TEST):
2705
2706 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2707
2708         Copying, pasting, and then deleting an attachment element breaks attachment data requests
2709         https://bugs.webkit.org/show_bug.cgi?id=181365
2710         <rdar://problem/36340647>
2711
2712         Reviewed by Tim Horton.
2713
2714         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
2715         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
2716         detail.
2717
2718         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2719         (TestWebKitAPI::TEST):
2720
2721 2018-01-08  Youenn Fablet  <youenn@apple.com>
2722
2723         navigator.onLine does not work inside service workers
2724         https://bugs.webkit.org/show_bug.cgi?id=181079
2725         <rdar://problem/36178606>
2726
2727         Reviewed by Darin Adler.
2728
2729         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2730         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
2731
2732 2018-01-07  Saam Barati  <sbarati@apple.com>
2733
2734         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
2735         https://bugs.webkit.org/show_bug.cgi?id=181372
2736
2737         Reviewed by Filip Pizlo.
2738
2739         Adding these sorting modes makes it easier to analyze functions
2740         that recompile a lot and exit a lot.
2741
2742         * Scripts/display-profiler-output:
2743
2744 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
2745
2746         Unreviewed, remove my Cisco email from contributors.json
2747
2748         * Scripts/webkitpy/common/config/contributors.json:
2749
2750 2018-01-05  JF Bastien  <jfbastien@apple.com>
2751
2752         WebAssembly: poison JS object's secrets
2753         https://bugs.webkit.org/show_bug.cgi?id=181339
2754         <rdar://problem/36325001>
2755
2756         Reviewed by Mark Lam.
2757
2758         Update tests for swap(Poisoned<k, T>, T*)
2759
2760         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
2761         (TestWebKitAPI::TEST):
2762         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2763         (TestWebKitAPI::TEST):
2764         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2765         (TestWebKitAPI::TEST):
2766
2767 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2768
2769         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
2770         https://bugs.webkit.org/show_bug.cgi?id=181359
2771
2772         Reviewed by Tim Horton.
2773
2774         Ensure that these tests still pass using older SDKs.
2775
2776         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2777         (TestWebKitAPI::TEST):
2778
2779 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2780
2781         Rebase API test after r226469
2782         https://bugs.webkit.org/show_bug.cgi?id=181308
2783
2784         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
2785         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2786         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
2787
2788 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2789
2790         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
2791         https://bugs.webkit.org/show_bug.cgi?id=181217
2792
2793         Reviewed by Tim Horton.
2794
2795         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2796         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2797         (TEST):
2798
2799 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2800
2801         Add WKBundleFrameCreateFrameHandle
2802         https://bugs.webkit.org/show_bug.cgi?id=181232
2803         <rdar://problem/35926696>
2804
2805         Reviewed by Tim Horton.
2806
2807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2808         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
2809         (mouseDidMoveOverElement):
2810         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
2811         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2812         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
2813         (TEST):
2814
2815 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
2816
2817         iOS: Build fix after r226432.
2818         
2819         Unreviewed. Stop duplicating speakAs symbols for iOS.
2820
2821         * DumpRenderTree/AccessibilityUIElement.cpp:
2822         (AccessibilityUIElement::speakAs):
2823
2824 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
2825
2826         Unreviewed, added myself as WebKit reviewer
2827
2828         * Scripts/webkitpy/common/config/contributors.json:
2829
2830 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
2831
2832         WPE: Build fix after r226432.
2833
2834         Unreviewed. Rename ::speak() to ::speakAs().
2835         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2836         (WTR::AccessibilityUIElement::speakAs):
2837         (WTR::AccessibilityUIElement::speak): Deleted.
2838
2839 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
2840
2841         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
2842         https://bugs.webkit.org/show_bug.cgi?id=180361
2843
2844         Reviewed by Zalan Bujtas.
2845
2846         * DumpRenderTree/AccessibilityUIElement.cpp:
2847         (speakAsCallback):
2848         (AccessibilityUIElement::speakAs):
2849         (AccessibilityUIElement::getJSClass):
2850         (speakCallback): Deleted.
2851         (AccessibilityUIElement::speak): Deleted.
2852         * DumpRenderTree/AccessibilityUIElement.h:
2853         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2854         (AccessibilityUIElement::speakAs):
2855         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2856         (AccessibilityUIElement::speakAs):
2857         (AccessibilityUIElement::speak): Deleted.
2858         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2859         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2860         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2861         (WTR::AccessibilityUIElement::speakAs):
2862         (WTR::AccessibilityUIElement::speak): Deleted.
2863         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2864         (WTR::AccessibilityUIElement::speakAs):
2865         (WTR::AccessibilityUIElement::speak): Deleted.
2866
2867 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
2868
2869         REGRESSION (r226395): test-webkitperl test expectations incorrect
2870         https://bugs.webkit.org/show_bug.cgi?id=181307
2871         <rdar://problem/36306558>
2872
2873         Rubber-stamped by Aakash Jain.
2874
2875         r226395 added two lines towards the beginning of
2876         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
2877         numbers in the test expectations need to update.
2878
2879         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2880
2881 2018-01-04  Tim Horton  <timothy_horton@apple.com>
2882
2883         WKWebView loses minimum layout size overrides that happen while the process is terminated
2884         https://bugs.webkit.org/show_bug.cgi?id=181306
2885         <rdar://problem/34398288>
2886
2887         Reviewed by Dan Bernstein.
2888
2889         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2890         (TEST):
2891         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
2892         while the process is terminated results in the page getting the correct
2893         minimum layout size.
2894
2895 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
2896
2897         [MediaStream] Add Mock screen capture source
2898         https://bugs.webkit.org/show_bug.cgi?id=181291
2899         <rdar://problem/36298164>
2900
2901         Reviewed by Dean Jackson.
2902
2903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
2904         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2905         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2906
2907 2018-01-04  Lucas Forschler  <lforschler@apple.com>
2908
2909         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
2910
2911         Reviewed by Ling Ho.
2912
2913         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2914
2915 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2916
2917         [Attachment Support] Create attachment elements when dropping files on iOS
2918         https://bugs.webkit.org/show_bug.cgi?id=181192
2919         <rdar://problem/36280945>
2920
2921         Reviewed by Tim Horton.
2922
2923         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
2924         switch is enabled. See below for more details.
2925
2926         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2927         (-[NSItemProvider registerData:type:]):
2928         (platformCopyPNG):
2929         (TestWebKitAPI::TEST):
2930         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2931
2932         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
2933         source item provider when dragging rich text *without* attachments, so this should have been a check for just
2934         kUTTypeRTF instead.
2935
2936         (TestWebKitAPI::TEST):
2937
2938         Tests a few cases of inserting attachment elements via drop:
2939         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
2940             Instead of inserting the contents as inline web content, this should generate attachment elements.
2941         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
2942             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
2943             back to inserting the content as an attachment.
2944         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
2945             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
2946             or at the end).
2947
2948         * TestWebKitAPI/cocoa/TestWKWebView.h:
2949         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2950         (-[TestWKWebView objectByEvaluatingJavaScript:]):
2951
2952         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
2953         -stringByEvaluatingJavaScript to just turn around and call this.
2954
2955         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2956
2957 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
2958
2959         Replace hard-coded paths in shebangs with #!/usr/bin/env
2960         https://bugs.webkit.org/show_bug.cgi?id=181040
2961
2962         Reviewed by Alex Christensen.
2963
2964         * BuildSlaveSupport/build-launcher-app:
2965         * BuildSlaveSupport/build-launcher-dmg:
2966         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2967         * BuildSlaveSupport/built-product-archive:
2968         * BuildSlaveSupport/clean-build:
2969         * BuildSlaveSupport/delete-stale-build-files:
2970         * BuildSlaveSupport/download-built-product:
2971         * BuildSlaveSupport/gtk/buildbot/log/run:
2972         * BuildSlaveSupport/gtk/buildbot/run:
2973         * BuildSlaveSupport/gtk/pulseaudio/run:
2974         * BuildSlaveSupport/kill-old-processes:
2975         * BuildSlaveSupport/test-result-archive:
2976         * BuildSlaveSupport/win/kill-old-processes:
2977         * Scripts/SpacingHeuristics.pm:
2978         * Scripts/add-include:
2979         * Scripts/build-api-tests:
2980         * Scripts/build-dumprendertree:
2981         * Scripts/build-imagediff:
2982         * Scripts/build-jsc:
2983         * Scripts/build-webkit:
2984         * Scripts/build-webkittestrunner:
2985         * Scripts/check-Xcode-source-file-types:
2986         * Scripts/check-dom-results:
2987         * Scripts/check-for-exit-time-destructors:
2988         * Scripts/check-for-global-initializers:
2989         * Scripts/check-for-inappropriate-objc-class-names:
2990         * Scripts/check-for-weak-vtables-and-externals:
2991         * Scripts/clean-header-guards:
2992         * Scripts/compare-timing-files:
2993         * Scripts/configure-xcode-for-ios-development:
2994         * Scripts/copy-webkitlibraries-to-product-directory:
2995         * Scripts/create-exports:
2996         * Scripts/debug-minibrowser:
2997         * Scripts/debug-safari:
2998         * Scripts/debug-test-runner:
2999         * Scripts/do-file-rename:
3000         * Scripts/do-webcore-rename:
3001         * Scripts/dump-webkit-tests-run:
3002         * Scripts/ensure-valid-python:
3003         * Scripts/execAppWithEnv:
3004         * Scripts/extract-localizable-js-strings:
3005         * Scripts/filter-build-webkit:
3006         * Scripts/find-extra-includes:
3007         * Scripts/fix-blink-patch:
3008         * Scripts/generate-coverage-data:
3009         * Scripts/git-add-reviewer:
3010         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3011         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
3012         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
3013         * Scripts/make-new-script-test:
3014         * Scripts/make-script-test-wrappers:
3015         * Scripts/package-root:
3016         * Scripts/parse-malloc-history:
3017         * Scripts/report-include-statistics:
3018         * Scripts/resolve-ChangeLogs:
3019         * Scripts/run-api-tests:
3020         * Scripts/run-bindings-tests:
3021         * Scripts/run-content-extension-tester:
3022         * Scripts/run-iexploder-tests:
3023         * Scripts/run-javascriptcore-tests:
3024         * Scripts/run-jsc:
3025         * Scripts/run-leaks:
3026         * Scripts/run-mangleme-tests:
3027         * Scripts/run-minibrowser:
3028         * Scripts/run-pageloadtest:
3029         * Scripts/run-regexp-tests:
3030         * Scripts/run-safari:
3031         * Scripts/run-sunspider:
3032         * Scripts/run-test-runner:
3033         * Scripts/run-webkit-app:
3034         * Scripts/run-webkit-httpd:
3035         * Scripts/run-webkit-websocketserver:
3036         * Scripts/set-webkit-configuration:
3037         * Scripts/show-pretty-diff:
3038         * Scripts/sort-Xcode-project-file:
3039         * Scripts/split-file-by-class:
3040         * Scripts/sunspider-compare-results:
3041         * Scripts/svn-apply:
3042         * Scripts/svn-unapply:
3043         * Scripts/test-webkit-scripts:
3044         * Scripts/test-webkitperl:
3045         * Scripts/update-iexploder-cssproperties:
3046         * Scripts/update-javascriptcore-test-results:
3047         * Scripts/update-webkit:
3048         * Scripts/update-webkit-auxiliary-libs:
3049         * Scripts/update-webkit-dependency:
3050         * Scripts/update-webkit-libs-jhbuild:
3051         * Scripts/update-webkit-localizable-strings:
3052         * Scripts/update-webkit-support-libs:
3053         * Scripts/update-webkitgtk-libs:
3054         * Scripts/update-webkitwpe-libs:
3055         * Scripts/webkit-build-directory:
3056         * Scripts/webkitperl/LoadAsModule.pm:
3057         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
3058         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3059         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
3060         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
3061         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
3062         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
3063         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3064         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3065         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3066         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3067         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
3068         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
3069         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
3070         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3071         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3072         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3073         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3074         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
3075         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
3076         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
3077         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
3078         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
3079         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
3080         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
3081         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
3082         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3083         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
3084         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
3085         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
3086         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3087         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
3088         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
3089         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
3090         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
3091         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
3092         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3093         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3094         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
3095         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
3096         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
3097         * ccache/ccache-clang:
3098         * ccache/ccache-clang++:
3099         * ccache/ccache-wrapper:
3100         * gtk/install-dependencies:
3101         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
3102         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
3103         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
3104         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
3105         * iExploder/iexploder-1.3.2/tools/showtest.rb:
3106         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
3107         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
3108         * iExploder/iexploder-1.7.2/src/webserver.rb:
3109         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
3110         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
3111         * wpe/install-dependencies:
3112
3113 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
3114
3115         filter-build-webkit filters out useful compiler error lines
3116         https://bugs.webkit.org/show_bug.cgi?id=179864
3117
3118         Reviewed by Tim Horton.
3119
3120         Don't filter out lines that contain information about build errors by always showing lines
3121         after a line that contains "note:" or "error:".
3122
3123         * Scripts/filter-build-webkit:
3124         (shouldShowSubsequentLine):
3125         (shouldIgnoreLine):
3126
3127 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3128
3129         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
3130         https://bugs.webkit.org/show_bug.cgi?id=173915
3131
3132         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
3133         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
3134         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
3135         empty string in this case.
3136
3137         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3138         (emitFormSubmissionEvent):
3139
3140 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3141
3142         [GTK] Add web process API to detect when form is submitted via JavaScript
3143         https://bugs.webkit.org/show_bug.cgi?id=173915
3144
3145         Reviewed by Carlos Garcia Campos.
3146
3147         Test it.
3148
3149         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3150         (FormSubmissionTest::FormSubmissionTest):
3151         (FormSubmissionTest::~FormSubmissionTest):
3152         (FormSubmissionTest::testFormSubmissionResult):
3153         (FormSubmissionTest::willSendDOMEventCallback):
3154         (FormSubmissionTest::willCompleteCallback):
3155         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
3156         (testWebExtensionFormSubmissionSteps):
3157         (beforeAll):
3158         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3159         (DelayedSignal::DelayedSignal):
3160         (emitFormSubmissionEvent):
3161         (handleFormSubmissionCallback):
3162         (willSubmitFormCallback):
3163         (pageCreatedCallback):
3164
3165 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3166
3167         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
3168         https://bugs.webkit.org/show_bug.cgi?id=181251
3169
3170         * Scripts/run-gtk-tests:
3171         (GtkTestRunner):
3172
3173 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3174
3175         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
3176         https://bugs.webkit.org/show_bug.cgi?id=181136
3177
3178         * Scripts/run-gtk-tests:
3179         (GtkTestRunner):
3180
3181 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
3182
3183         [macOS, iOS] Adopt new secure coding APIs in WebKit
3184         https://bugs.webkit.org/show_bug.cgi?id=181085
3185         <rdar://problem/34837397>
3186
3187         Reviewed by Tim Horton.
3188
3189         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
3190         capable of supporting NSSecureCoding, so pass through the current coding routines.
3191
3192         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
3193         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
3194         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
3195         routines if necessary.
3196         (TEST): Updated for NSSecureCoding.
3197         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
3198         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
3199
3200 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
3201
3202         Remove std::chrono completely
3203         https://bugs.webkit.org/show_bug.cgi?id=181186
3204
3205         Reviewed by Alex Christensen.
3206
3207         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3208         (WTR::TestController::platformRunUntil):
3209
3210 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3211
3212         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
3213         https://bugs.webkit.org/show_bug.cgi?id=181231
3214
3215         Reviewed by Alex Christensen.
3216
3217         Implement TestController APIs needed by ResourceLoadStatistics tests.
3218
3219         * WebKitTestRunner/TestController.cpp:
3220         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
3221         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
3222
3223 2018-01-02  Tim Horton  <timothy_horton@apple.com>
3224
3225         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
3226         https://bugs.webkit.org/show_bug.cgi?id=181219
3227
3228         Reviewed by Wenson Hsieh.
3229
3230         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3231
3232 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3233
3234         Add a WebAuthentication runtime feature flag
3235         https://bugs.webkit.org/show_bug.cgi?id=181220
3236         <rdar://problem/36055305>
3237
3238         Reviewed by Brent Fulgham.
3239
3240         Renames the CredentialManagement runtime feature flag into WebAuthentication.
3241
3242         * DumpRenderTree/TestOptions.h:
3243         * DumpRenderTree/TestOptions.mm:
3244         (TestOptions::TestOptions):
3245         * DumpRenderTree/mac/DumpRenderTree.mm:
3246         (enableExperimentalFeatures):
3247         (setWebPreferencesForTestOptions):
3248         * WebKitTestRunner/TestController.cpp:
3249         (WTR::TestController::resetPreferencesToConsistentValues):
3250         (WTR::updateTestOptionsFromTestHeader):
3251         * WebKitTestRunner/TestOptions.h:
3252         (WTR::TestOptions::hasSameInitializationOptions const):
3253
3254 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3255
3256         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
3257         https://bugs.webkit.org/show_bug.cgi?id=181143
3258         <rdar://problem/36200381>
3259
3260         Reviewed by Tim Horton.
3261
3262         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
3263         attachment elements are enabled.
3264
3265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3266         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3267         (TestWebKitAPI::TEST):
3268
3269 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3270
3271         Update Credential Management API for WebAuthentication
3272         https://bugs.webkit.org/show_bug.cgi?id=181082
3273         <rdar://problem/36055239>
3274
3275         Reviewed by Brent Fulgham.
3276
3277         Enable Credential Management API for testing.
3278
3279         * DumpRenderTree/TestOptions.h:
3280         * WebKitTestRunner/TestOptions.h:
3281
3282 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3283
3284         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
3285         https://bugs.webkit.org/show_bug.cgi?id=168194
3286
3287         Reviewed by Carlos Garcia Campos.
3288
3289         Fix an assertion and unskip the test. The order that form controls are associated is not
3290         guaranteed.
3291
3292         * Scripts/run-gtk-tests:
3293         (GtkTestRunner):
3294         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3295         (didAssociateFormControlsCallback):
3296
3297 2018-01-02  Alex Christensen  <achristensen@webkit.org>
3298
3299         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
3300         https://bugs.webkit.org/show_bug.cgi?id=180897
3301         <rdar://problem/35535328>
3302
3303         Reviewed by Brent Fulgham.
3304
3305         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
3306
3307         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3308         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3309         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
3310         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3311         (websiteDataStoreTestWebView):
3312         (TEST):
3313
3314 == Rolled over to ChangeLog-2018-01-01 ==