build-webkit: make ninja work with chromium linux
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
2
3         build-webkit: make ninja work with chromium linux
4         https://bugs.webkit.org/show_bug.cgi?id=84213
5
6         Reviewed by Eric Seidel.
7
8         Fix typos so that build-webkit will use ninja to
9         build chromium if a build.ninja file exists and is up-to-date.
10
11         * Scripts/webkitdirs.pm:
12         (determineIsChromiumNinja):
13
14 2012-04-17  Ojan Vafai  <ojan@chromium.org>
15
16         Add caching to the flakiness dashboard json files
17         https://bugs.webkit.org/show_bug.cgi?id=84198
18
19         Reviewed by Dirk Pranke.
20
21         * TestResultServer/handlers/testfilehandler.py:
22         (GetFile._get_file_list):
23         (GetFile._get_file_content):
24         (GetFile._get_file_content_from_key):
25         (GetFile._get_test_list_json):
26         (GetFile._serve_json):
27         Add a Last-Modified header and handle If-Modified-Since headers.
28         (GetFile.get):
29
30 2012-04-17  Anders Carlsson  <andersca@apple.com>
31
32         Need a client callback for when the user tries to interact with an already unresponsive page
33         https://bugs.webkit.org/show_bug.cgi?id=84201
34         <rdar://problem/11140862>
35
36         Reviewed by Andreas Kling.
37
38         Add new client functions.
39
40         * MiniBrowser/mac/BrowserWindowController.m:
41         (-[BrowserWindowController awakeFromNib]):
42         * WebKitTestRunner/TestController.cpp:
43         (WTR::TestController::initialize):
44
45 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
46
47         nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
48         https://bugs.webkit.org/show_bug.cgi?id=84190
49
50         Reviewed by Ojan Vafai.
51
52         LayoutTestHelper would exit when the user typed ctrl-c, but we
53         would attempt to write to it to shut it down, generating an
54         IOError.
55
56         * Scripts/webkitpy/layout_tests/port/chromium.py:
57         (ChromiumPort.stop_helper):
58
59 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
60
61         rename --experimental-fully-parallel
62         https://bugs.webkit.org/show_bug.cgi?id=84188
63
64         Reviewed by Ojan Vafai.
65
66         I thought this was done long ago; rename
67         --experimental-fully-parallel to just --fully-parallel and
68         remove the --no- switch that AFAIK no one uses.
69
70         * Scripts/webkitpy/layout_tests/controllers/manager.py:
71         (Manager._run_tests):
72         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
73         (parse_args):
74
75 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
76
77         EFL's LayoutTestController does not implement callShouldCloseOnWebView
78         https://bugs.webkit.org/show_bug.cgi?id=82301
79
80         Reviewed by Martin Robinson.
81
82         Implement callShouldCloseOnWebView in EFL's LayoutTestController by
83         calling shouldClose() on the FrameLoader, allowing the related test
84         to be removed from the skip list.
85
86         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
87         (LayoutTestController::callShouldCloseOnWebView):
88
89 2012-04-17  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
90
91         [EFL] Add setting API to enable/disable XSSAuditor
92         https://bugs.webkit.org/show_bug.cgi?id=83281
93
94         Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
95         in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal 
96         'xss,detected' in DRT to enable a test, which is expecting a line containing
97         'didDetectXSS' in the output when reflected XSS is encountered in the page.
98
99         Reviewed by Antonio Gomes.
100
101         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
102         (DumpRenderTreeChrome::createView):
103         (DumpRenderTreeChrome::onFrameCreated):
104         (DumpRenderTreeChrome::onDidDetectXSS):
105         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
106         (DumpRenderTreeChrome):
107         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
108         (LayoutTestController::setXSSAuditorEnabled):
109
110 2012-04-17  Nandor Huszka  <hnandor@inf.u-szeged.hu>
111
112         [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
113         https://bugs.webkit.org/show_bug.cgi?id=77533
114
115         Reviewed by Simon Hausmann.
116
117         Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
118         the corresponding parameter to the buildQMakeProjects function.
119
120         * Scripts/build-jsc:
121
122 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
123
124         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
125         https://bugs.webkit.org/show_bug.cgi?id=83030
126
127         Reviewed by Antonio Gomes.
128
129         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
130         in EFL's DumpRenderTree. Make use of the new frame argument passed to
131         the "load,started" and "load,finished" signals.
132
133         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
134         (DumpRenderTreeChrome::createView):
135         (DumpRenderTreeChrome::onLoadStarted):
136         (DumpRenderTreeChrome::processWork):
137         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
138         (DumpRenderTreeChrome::onWebViewOnloadEvent):
139         (DumpRenderTreeChrome::onInsecureContentRun):
140         (DumpRenderTreeChrome::onInsecureContentDisplayed):
141         (DumpRenderTreeChrome::onFrameCreated):
142         (DumpRenderTreeChrome::onFrameProvisionalLoad):
143         (DumpRenderTreeChrome::onFrameLoadCommitted):
144         (DumpRenderTreeChrome::onFrameLoadFinished):
145         (DumpRenderTreeChrome::onFrameLoadError):
146         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
147         (DumpRenderTreeChrome):
148
149 2012-04-17  Sheriff Bot  <webkit.review.bot@gmail.com>
150
151         Unreviewed, rolling out r114376.
152         http://trac.webkit.org/changeset/114376
153         https://bugs.webkit.org/show_bug.cgi?id=84155
154
155         Wrong patch version committed, asked by the patch author.
156         (Requested by rakuco on #webkit).
157
158         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
159         (DumpRenderTreeChrome::createView):
160         (DumpRenderTreeChrome::processWork):
161         (DumpRenderTreeChrome::onLoadFinished):
162         (DumpRenderTreeChrome::onWillSendRequest):
163         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
164         (DumpRenderTreeChrome):
165
166 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
167
168         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
169         https://bugs.webkit.org/show_bug.cgi?id=83030
170
171         Reviewed by Antonio Gomes.
172
173         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
174         in EFL's DumpRenderTree.
175
176         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
177         (DumpRenderTreeChrome::createView):
178         (DumpRenderTreeChrome::processWork):
179         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
180         (DumpRenderTreeChrome::onWebViewOnloadEvent):
181         (DumpRenderTreeChrome::onInsecureContentRun):
182         (DumpRenderTreeChrome::onInsecureContentDisplayed):
183         (DumpRenderTreeChrome::onFrameCreated):
184         (DumpRenderTreeChrome::onFrameProvisionalLoad):
185         (DumpRenderTreeChrome::onFrameLoadCommitted):
186         (DumpRenderTreeChrome::onFrameLoadFinished):
187         (DumpRenderTreeChrome::onFrameLoadError):
188         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
189         (DumpRenderTreeChrome):
190
191 2012-04-17  Michael Brüning  <michael.bruning@nokia.com>
192
193         [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
194         https://bugs.webkit.org/show_bug.cgi?id=83035
195
196         Reviewed by Simon Hausmann.
197
198         The force_static_libs_as_shared feature for the Qt port will remove
199         hide_symbols from Qt's CONFIG in order to make them visible to other
200         libraries again.
201
202         Due to an evaluation order problem in qmake, the flags for the C++ compiler
203         that are set by adding hide_symbols to the CONFIG variables get applied
204         to qmake's C++ compiler flags directly and hence trying to remove these
205         later will not work and cause build failures when using the force_static_libs_as_shared
206         feature of the Qt port.
207
208         This is fixed by removing the flags that hide the exports from the compiler flags directly.
209
210         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
211
212 2012-04-16  Ryosuke Niwa  <rniwa@webkit.org>
213
214         Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
215         https://bugs.webkit.org/show_bug.cgi?id=84068
216
217         Reviewed by Eric Seidel.
218
219         Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
220         automatically creates the build directory if needed.
221
222         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
223         (DownloadAndPerfTestFactory.__init__):
224         (DownloadAndPerfTestWebKit2Factory.__init__):
225
226 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
227
228         [GTK] Use configure instead of autogen.sh for gtk+
229         https://bugs.webkit.org/show_bug.cgi?id=84112
230
231         Rubber-stamped by Martin Robinson.
232
233         * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
234         we don't want to depend on that for now, so run configure instead - we
235         can, since we are using a tarball
236
237 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
238
239         Unreviewed, rolling out r114322.
240         http://trac.webkit.org/changeset/114322
241         https://bugs.webkit.org/show_bug.cgi?id=84096
242
243         Didn't make the debug bot happy, so back out
244
245         * gtk/jhbuild.modules:
246
247 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
248
249         [GTK] Try to fix debug bot by adding gobject-introspection to the build
250         https://bugs.webkit.org/show_bug.cgi?id=84096
251
252         Unreviewed speculative build fix.
253
254         * gtk/jhbuild.modules: Added gobject-introspection, since modules need
255         an up-to-date introspection m4 for running autogen.
256
257 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
258
259         [GTK] Add pango to jhbuild
260         https://bugs.webkit.org/show_bug.cgi?id=84086
261
262         Unreviewed build fix.
263
264         * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
265         jhbuild environment. It's required for latest stable GTK+ and some
266         systems may lack it.
267
268 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
269
270         [GTK] fonts jhbuild module needs an empty clean target
271         https://bugs.webkit.org/show_bug.cgi?id=84085
272
273         Rubber-stamped by Martin Robinson.
274
275         * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
276         includes a phony clean target that should make warnings and errors go
277         away.
278
279 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
280
281         [GTK] Bump dependency on GTK+ 3.x to match reality
282         https://bugs.webkit.org/show_bug.cgi?id=84060
283
284         Rubber-stamped by Martin Robinson.
285
286         * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
287         to their GNOME 3.4 versions.
288         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
289         is applied upstream.
290
291 2012-04-16  Vincent Scheib  <scheib@chromium.org>
292
293         Adding Contributors Brian Salomon and Tom Hudson to committers.py.
294
295         Unreviewed.
296
297         * Scripts/webkitpy/common/config/committers.py:
298
299 2012-04-16  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
300
301         [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
302         https://bugs.webkit.org/show_bug.cgi?id=84031
303
304         Reviewed by Rob Buis.
305
306         Implemented interface function didReceiveAuthenticationChallenge in class
307         DumpRenderTree.
308
309         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
310         (drtCredentialDescription):
311         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
312         (WebKit):
313         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
314         (WebCore):
315         (DumpRenderTree):
316
317 2012-04-16  Philippe Normand  <pnormand@igalia.com>
318
319         build-webkit --gtk --no-webkit2 builds WK2
320         https://bugs.webkit.org/show_bug.cgi?id=83977
321
322         Reviewed by Martin Robinson.
323
324         * Scripts/build-webkit: Fixup ./configure option to disable
325         WebKit2 build.
326
327 2012-04-16  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
328
329         [EFL] [DRT] Feeding key events with invalid keyName
330         https://bugs.webkit.org/show_bug.cgi?id=83797
331
332         Keep the keyName valid within scope of KeyEventInfo to avoid
333         feeding key events with invalid keyName.
334
335         Reviewed by Philippe Normand.
336
337         * DumpRenderTree/efl/EventSender.cpp:
338         (KeyEventInfo::KeyEventInfo):
339         (KeyEventInfo):
340         (keyPadNameFromJSValue):
341         (keyNameFromJSValue):
342         (createKeyEventInfo):
343         (sendKeyDown):
344
345 2012-04-16  Andras Piroska  <pandras@inf.u-szeged.hu>
346
347         [Qt] Replace QtXmlPatterns usage with libxslt dependency
348         <https://bugs.webkit.org/show_bug.cgi?id=76820>
349
350         Reviewed by Simon Hausmann.
351
352         The features.prf file was modified, in order to use libxml and libxslt by default.
353         This modification only work at Qt5.
354
355         * qmake/config.tests/libxml2/libxml2.cpp: Added.
356         (main):
357         * qmake/config.tests/libxml2/libxml2.pro: Added.
358         * qmake/config.tests/libxslt/libxslt.cpp: Added.
359         (main):
360         * qmake/config.tests/libxslt/libxslt.pro: Added.
361         * qmake/mkspecs/features/features.prf:
362         * qmake/sync.profile:
363
364 2012-04-16  Seokju Kwon  <seokju.kwon@samsung.com>
365
366         [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
367         https://bugs.webkit.org/show_bug.cgi?id=83862
368
369         Reviewed by Kenneth Rohde Christiansen.
370
371         EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
372         It doesn't work properly because of wrong parameter order in function call.
373
374         * EWebLauncher/main.c:
375
376 2012-04-16  Philippe Normand  <pnormand@igalia.com>
377
378         Unreviewed, GTK gardening.
379
380         * Scripts/run-gtk-tests:
381         (TestRunner): Skip /webkit/atk/textChangedNotifications.
382
383 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
384
385         Chromium perf bots should not build
386         https://bugs.webkit.org/show_bug.cgi?id=83641
387
388         Reviewed by Eric Seidel.
389
390         Don't build on perf bots to improve the cycle time.
391
392         * BuildSlaveSupport/build.webkit.org-config/config.json:
393
394 2012-04-14  Zalan Bujtas  <zbujtas@gmail.com>
395
396         [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
397         https://bugs.webkit.org/show_bug.cgi?id=81945
398
399         Reviewed by Dan Bernstein.
400
401         WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
402         the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
403         PageCache to be functional.
404
405         * WebKitTestRunner/TestController.cpp:
406         (WTR::TestController::resetStateToConsistentValues):
407
408 2012-04-11  James Robinson  <jamesr@chromium.org>
409
410         [chromium] Remove unused compositeToTexture / compositeOffscreen setting
411         https://bugs.webkit.org/show_bug.cgi?id=83733
412
413         Reviewed by Adrienne Walker.
414
415         Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
416
417         * DumpRenderTree/chromium/DumpRenderTree.cpp:
418         (main):
419         * DumpRenderTree/chromium/TestShell.cpp:
420         (TestShell::TestShell):
421         (TestShell::resetWebSettings):
422         * DumpRenderTree/chromium/TestShell.h:
423         (TestShell):
424         * DumpRenderTree/chromium/WebPreferences.cpp:
425         (WebPreferences::reset):
426         (WebPreferences::applyTo):
427         * DumpRenderTree/chromium/WebPreferences.h:
428         (WebPreferences):
429
430 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
431
432         webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
433         and also rebaseline the test results since we ignore the first run now.
434
435         * Scripts/webkitpy/performance_tests/perftest.py:
436         (PageLoadingPerfTest.run):
437         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
438         (TestPageLoadingPerfTest.test_run):
439
440 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
441
442         Enable SVG page loading performance tests
443         https://bugs.webkit.org/show_bug.cgi?id=83861
444
445         Reviewed by Adam Barth.
446
447         Add support for page loading tests. These are tests without any test running harnesses, and we use
448         DriverOutput's test_timeout to measure the loading time.
449
450         Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
451
452         * Scripts/webkitpy/performance_tests/perftest.py:
453         (PerfTest.run):
454         (PerfTest):
455         (PerfTest.run_failed):
456         (PerfTest.parse_output):
457         (PerfTest.output_statistics):
458         (ChromiumStylePerfTest.parse_output):
459         (PageLoadingPerfTest): Added.
460         (PageLoadingPerfTest.__init__):
461         (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
462         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
463         (MockPrinter):
464         (MockPrinter.__init__):
465         (MockPrinter.write):
466         (MainTest):
467         (MainTest.test_parse_output):
468         (MainTest.test_parse_output_with_failing_line):
469         (TestPageLoadingPerfTest):
470         (TestPageLoadingPerfTest.assertWritten):
471         (TestPageLoadingPerfTest.MockDriver):
472         (TestPageLoadingPerfTest.MockDriver.__init__):
473         (TestPageLoadingPerfTest.MockDriver.run_test):
474         (TestPageLoadingPerfTest.test_run):
475         (TestPageLoadingPerfTest.test_run_with_bad_output):
476         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
477         (PerfTestsRunner):
478         (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
479         (PerfTestsRunner._collect_tests):
480         (PerfTestsRunner._run_tests_set):
481         (PerfTestsRunner._run_single_test):
482         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
483         (test_collect_tests_with_page_load_svg):
484         (test_collect_tests_with_page_load_svg.add_file):
485
486 2012-04-10  Brady Eidson  <beidson@apple.com>
487
488         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
489         Need WebKit2 API to notify whether history loads are in the page cache
490
491         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
492         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
493
494         Reviewed by Darin Adler.
495
496         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
497         (TestWebKitAPI::didFinishLoadForFrame):
498         (TestWebKitAPI::willGoToBackForwardListItem):
499         (TestWebKitAPI::setPageLoaderClient):
500         (TestWebKitAPI::TEST):
501         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
502         (ShouldGoToBackForwardListItemTest):
503         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
504         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
505         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
507
508         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
509         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
510
511 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
512
513         Group EFL bots into a category on the buildbot master
514         https://bugs.webkit.org/show_bug.cgi?id=82712
515
516         Reviewed by Adam Roben.
517
518         Creating a new category definition on the buildbot frontend.
519
520         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
521         (loadBuilderConfig): Determine category for EFL bots
522         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
523
524 2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
525
526         Unreviewed, rolling out r113714.
527         http://trac.webkit.org/changeset/113714
528         https://bugs.webkit.org/show_bug.cgi?id=83887
529
530         It is behaving strange on the bots and needs more
531         investigation. (Requested by jeez_ on #webkit).
532
533         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
534         (WTR::PlatformWebView::PlatformWebView):
535
536 2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
537
538         webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
539         https://bugs.webkit.org/show_bug.cgi?id=83690
540
541         Reviewed by Tor Arne Vestbø.
542
543         Typing part of an email and pressing <TAB> will bash-complete it using the list in
544         Tools/Scripts/webkitpy/common/config/committers.py
545
546         * Scripts/webkit-tools-completion.sh:
547
548 2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
549
550         [EFL] Add API for color chooser
551         https://bugs.webkit.org/show_bug.cgi?id=83692
552
553         Enables INPUT_TYPE_COLOR by default on the EFL port.
554
555         Reviewed by Kenneth Rohde Christiansen.
556
557         * Scripts/build-webkit:
558
559 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
560
561         Extract PerfTest class from PerfTestRunner
562         https://bugs.webkit.org/show_bug.cgi?id=83847
563
564         Reviewed by Hajime Morita.
565
566         Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
567         that was previously represented by a tuple.
568
569         Also moved the logic to determine whether a given test is chromium style or not from run() to
570         _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
571         tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
572         add new types of tests more easily.
573
574         * Scripts/webkitpy/performance_tests/perftest.py: Added.
575         (PerfTest):
576         (PerfTest.__init__):
577         (PerfTest.test_name):
578         (PerfTest.dirname):
579         (PerfTest.path_or_url):
580         (PerfTest._should_ignore_line_in_parser_test_result):
581         (PerfTest.parse_output):
582         (ChromiumStylePerfTest):
583         (ChromiumStylePerfTest.__init__):
584         (ChromiumStylePerfTest.parse_output):
585         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
586         (PerfTestsRunner._collect_tests):
587         (PerfTestsRunner.run):
588         (PerfTestsRunner._run_tests_set):
589         (PerfTestsRunner._run_single_test):
590         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
591         (run_test):
592         (_tests_for_runner):
593         (test_run_test_set_with_json_output):
594         (test_run_test_set_with_json_source):
595         (test_run_test_set_with_multiple_repositories):
596         (_collect_tests_and_sort_test_name):
597         (test_collect_tests):
598         (test_collect_tests_with_skipped_list):
599
600 2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>
601
602         [Qt] Fix WebKit1 build with V8
603         https://bugs.webkit.org/show_bug.cgi?id=83322
604
605         Reviewed by Adam Barth.
606
607         * DumpRenderTree/qt/DumpRenderTree.pro:
608         * qmake/mkspecs/features/default_post.prf:
609         * qmake/mkspecs/features/default_pre.prf:
610         * qmake/mkspecs/features/features.prf:
611
612 2012-04-12  Dirk Pranke  <dpranke@chromium.org>
613
614         test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
615         https://bugs.webkit.org/show_bug.cgi?id=83583
616
617         Reviewed by Philippe Normand
618
619         Updated the unit test to ignore the hours and minutes of the
620         localtime for time(0), since we can't easily guarantee which
621         timezone we're in or what timezone rules were in effect on
622         1/1/1970; this should be mostly fine since we can trust that
623         time.localtime() will work, although there is the possibility
624         that we'll screw up the time formatting of which field is the
625         hours and which is the minutes.
626
627         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
628         (VerboseTest):
629         (VerboseTest.test_basic):
630         (VerboseTest.test_log_after_update):
631
632 2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>
633
634         Add an EFL Debug Buildbot to the master configuration
635         https://bugs.webkit.org/show_bug.cgi?id=82711
636
637         Forgot to add EFL Linux Debug to scheduler.
638
639         Reviewed by Philippe Normand.
640
641         * BuildSlaveSupport/build.webkit.org-config/config.json:
642
643 2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
644
645         Add an EFL Debug Buildbot to the master configuration
646         https://bugs.webkit.org/show_bug.cgi?id=82711
647
648         Reviewed by Philippe Normand.
649
650         Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
651
652         * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
653
654 2012-04-12  George Staikos  <staikos@webkit.org>
655
656         Enable the fullscreen API for BlackBerry.
657         https://bugs.webkit.org/show_bug.cgi?id=83757
658
659         Reviewed by Antonio Gomes.
660
661         * Scripts/build-webkit:
662
663 2012-04-12  Simon Pena  <spena@igalia.com>
664
665         [GTK] Test runner crashes without recent versions of pulseaudio-utils
666         https://bugs.webkit.org/show_bug.cgi?id=83774
667
668         Reviewed by Philippe Normand.
669
670         Besides checking that pactl is available, check also that its output
671         is the expected one, and handle gracefully when it isn't, when
672         trying to unload pulseaudio modules.
673
674         * Scripts/webkitpy/layout_tests/port/gtk.py:
675         (GtkPort._unload_pulseaudio_module):
676         (GtkPort._restore_pulseaudio_module):
677
678 2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>
679
680         [Qt] Use QRawFont when building with Qt 5
681         https://bugs.webkit.org/show_bug.cgi?id=78001
682
683         Flip the QRawFont switch for Qt 5.
684
685         Reviewed by Simon Hausmann.
686
687         * qmake/mkspecs/features/features.prf:
688
689 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
690
691         Web Inspector: Disabling Inspector causes build failure on Windows
692         https://bugs.webkit.org/show_bug.cgi?id=83557
693
694         Reviewed by Pavel Feldman.
695
696         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
697         This change brings all such API calls under the guard.
698
699         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
700         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
701         (WTR):
702         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
703         (LayoutTestController):
704         * WebKitTestRunner/TestInvocation.cpp:
705         (WTR::TestInvocation::invoke):
706
707 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
708
709         Fix regression introduced in r113927.
710
711         Unreviewed, build fix.
712
713         I failed to rename skipped_tests() to skipped_layout_tests()
714         everywhere it needed to be renamed. The unit tests didn't catch
715         this because the TestPort was one of the places that didn't get
716         renamed :(.
717
718         * Scripts/webkitpy/layout_tests/controllers/manager.py:
719         (Manager.parse_expectations):
720         * Scripts/webkitpy/layout_tests/port/test.py:
721         (TestPort.skipped_layout_tests):
722         * Scripts/webkitpy/tool/commands/queries.py:
723         (PrintExpectations._model):
724
725 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
726
727         new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
728         https://bugs.webkit.org/show_bug.cgi?id=47528
729
730         Reviewed by Adam Barth.
731
732         The skipped-ports command has been replaced by 'webkit-patch
733         print-expectations', which offers the equivalent functionality
734         via 'webkit-patch print-expectations --platform \* -t skip'
735         (and other features, of course).
736         
737         This also allows me to fix a nasty layering violation where the
738         chromium port had to know about the TestExpectations objects in
739         order to implement the command properly.
740
741         Lastly, this allows me to rename skipped_tests() to
742         skipped_layout_tests() to more consistent with
743         skipped_perf_tests().
744         
745         This patch removes skips_layout_test() from the Port interface,
746         because that can't be implemented without the port knowing about
747         Expectations objects (and skipped-ports was the only thing using it).
748
749         * Scripts/webkitpy/layout_tests/port/base.py:
750         (Port.skipped_layout_tests):
751         (Port.skipped_perf_tests):
752         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
753         (PortTest.test_default_configuration_notfound):
754         * Scripts/webkitpy/layout_tests/port/chromium.py:
755         (ChromiumPort.test_expectations_overrides):
756         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
757         (ChromiumPortTest.test_path_to_image_diff):
758         * Scripts/webkitpy/layout_tests/port/webkit.py:
759         (WebKitPort.skipped_layout_tests):
760         * Scripts/webkitpy/tool/commands/queries.py:
761         (execute):
762         * Scripts/webkitpy/tool/commands/queries_unittest.py:
763         (QueryCommandsTest.test_tree_status):
764
765 2012-04-11  Mark Rowe  <mrowe@apple.com>
766
767         Remove a fprintf from LayoutTestController.
768
769         This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
770         It was added for no apparent reason by Ryosuke in r113651.
771
772         * DumpRenderTree/LayoutTestController.cpp:
773         (LayoutTestController::redirectionDestinationForURL):
774
775 2012-04-11  Nico Weber  <thakis@chromium.org>
776
777         [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
778         https://bugs.webkit.org/show_bug.cgi?id=83709
779
780         Reviewed by Anders Carlsson.
781
782         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
783         (handleEventCarbon):
784
785 2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>
786
787         Adding myself to committers.py
788         https://bugs.webkit.org/show_bug.cgi?id=83711
789
790         Unreviewed update to committers.py.
791
792         * Scripts/webkitpy/common/config/committers.py:
793
794 2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
795
796         [EFL] LayoutTestController needs implementation of pageProperty
797         https://bugs.webkit.org/show_bug.cgi?id=82449
798
799         Add missing implementation pageProperty to EFL's LayoutTestController
800         in order to unskip printing/page-rule-selection.html
801
802         Reviewed by Antonio Gomes.
803
804         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
805         (LayoutTestController::pageProperty):
806
807 2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
808
809         Unreviewed, rolling out r113836.
810         http://trac.webkit.org/changeset/113836
811         https://bugs.webkit.org/show_bug.cgi?id=83705
812
813         Broke all the WebKit2 inspector tests (Requested by andersca
814         on #webkit).
815
816         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
817         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
818         (WTR::LayoutTestController::showWebInspector):
819         (WTR::LayoutTestController::closeWebInspector):
820         (WTR::LayoutTestController::evaluateInWebInspector):
821         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
822         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
823         (LayoutTestController):
824         * WebKitTestRunner/TestInvocation.cpp:
825         (WTR::TestInvocation::invoke):
826
827 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
828
829         Web Inspector: Disabling Inspector causes build failure on Windows
830         https://bugs.webkit.org/show_bug.cgi?id=83557
831
832         Reviewed by Pavel Feldman.
833
834         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
835         This change brings all such API calls under the guard.
836
837         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
838         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
839         (WTR):
840         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
841         (LayoutTestController):
842         * WebKitTestRunner/TestInvocation.cpp:
843         (WTR::TestInvocation::invoke):
844
845 2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
846
847         [Qt][WK2] Manage graphics buffers in the web process
848         https://bugs.webkit.org/show_bug.cgi?id=78675
849  
850         Make graphics surface available only for Qt 5, attempting to fix
851         the Qt-mac build.
852
853         Unreviewed build fix.
854
855         * qmake/mkspecs/features/features.prf:
856
857 2012-04-11  Philippe Normand  <pnormand@igalia.com>
858
859         Unreviewed, GTK NRWT follow-up fix after r113849.
860
861         * Scripts/webkitpy/layout_tests/port/gtk.py:
862         (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
863
864 2012-04-11  Simon Pena  <spena@igalia.com>
865
866         [GTK] media/event-attributes.html fails
867         https://bugs.webkit.org/show_bug.cgi?id=71662
868
869         Reviewed by Philippe Normand.
870
871         PulseAudio's module "module-stream-restore" allows saving the volume
872         of a stream, restoring it the next time it runs.
873         This affects the tests, since DumpRenderTree's volume settings are
874         saved between test runs, and tests relying on specific volume values
875         would miss some volumeChange events (or get additional ones).
876
877         This patch hooks on the existing GtkPort setup_test_run method and
878         creates a new clean_up_test_run method, so PulseAudio's module is
879         unloaded (if found) before running the tests, and restored (if it
880         was there previously) after they finished, ensuring the tests run in
881         the right environment.
882
883         * Scripts/webkitpy/layout_tests/controllers/manager.py:
884         (Manager._clean_up_run): Invoke the port implementation of
885         clean_up_test_run.
886         * Scripts/webkitpy/layout_tests/port/base.py:
887         (Port.clean_up_test_run): Add an empty implementation of
888         clean_up_test_run.
889         * Scripts/webkitpy/layout_tests/port/gtk.py:
890         (GtkPort._unload_pulseaudio_module): Unloads the offending
891         pulseaudio module, if found.
892         (GtkPort):
893         (GtkPort._restore_pulseaudio_module): Restores the offending
894         pulseaudio module, if it was there previously.
895         (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
896         (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
897
898 2012-04-11  Andras Becsi  <andras.becsi@nokia.com>
899
900         Fix the build with gcc 4.7.0
901         https://bugs.webkit.org/show_bug.cgi?id=83584
902
903         Reviewed by Alexey Proskuryakov.
904
905         * qmake/mkspecs/features/unix/default_post.prf:
906         The -fuse-ld=gold option is not supported with upstream gcc.
907
908 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
909
910         Refactor PerfTestRunner to include file extensions in test names
911         https://bugs.webkit.org/show_bug.cgi?id=83677
912
913         Reviewed by Hajime Morita.
914
915         Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
916
917         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
918         (PerfTestsRunner._collect_tests):
919         (PerfTestsRunner._run_tests_set):
920         (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
921         We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
922         (PerfTestsRunner._run_single_test):
923         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
924         (run_test):
925         (_tests_for_runner):
926         (test_run_test_set):
927         (test_run_test_set_kills_drt_per_run):
928         (test_run_test_pause_before_testing):
929         (test_run_test_set_for_parser_tests):
930         (test_collect_tests):
931         (test_collect_tests_with_skipped_list):
932
933 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
934
935         Web Inspector: Disabling Inspector causes build failure on Windows
936         https://bugs.webkit.org/show_bug.cgi?id=83557
937
938         Reviewed by Pavel Feldman.
939
940         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
941         This change brings all such API calls under the guard.
942
943         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
944         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
945         (WTR):
946         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
947         (LayoutTestController):
948         * WebKitTestRunner/TestInvocation.cpp:
949         (WTR::TestInvocation::invoke):
950
951 2012-04-10  Kent Tamura  <tkent@chromium.org>
952
953         Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
954
955         * Scripts/webkitpy/common/config/watchlist:
956         * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
957
958 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
959
960         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
961         https://bugs.webkit.org/show_bug.cgi?id=82799
962
963         Reviewed by Ojan Vafai.
964
965         The tests we were skipping in _mark_interrupted_tests_as_skipped
966         had incorrectly-constructed TestResults, and so they were not
967         being treated as failures. The JSON generator doesn't record
968         tests that are passed or skiped in incremental_results, so you
969         couldn't tell these tests were being skipped at all.
970
971         This change changes _mark_interrupted_tests_as_skipped() to
972         treat the skipped tests as failures; this is arguably still
973         incorrect but is minimally invasive for now. We probably need to
974         revisit how we are uploading information about tests that are
975         skipped and passed altogether in a separate change.
976
977         This change also cleans up a couple of other nits that were
978         unnecessary or broken in this same code path.
979
980         * Scripts/webkitpy/layout_tests/controllers/manager.py:
981         (Manager._mark_interrupted_tests_as_skipped):
982         (Manager._upload_json_files): Deletes the check for
983         chromium-mac-leopard (as it is no longer necessary).
984         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
985         (JSONLayoutResultsGenerator.__init__): Here we were
986         recalculating the failure type unnecessarily.
987         * Scripts/webkitpy/layout_tests/models/test_failures.py:
988         (determine_result_type):
989         (FailureEarlyExit): Adds a new failure type so we can tell what
990         happened.
991         (FailureEarlyExit.message):
992         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
993         (MainTest.test_exit_after_n_failures_upload): Add more checks to
994         ensure that we are recording the SKIP correctly; this is less
995         than ideal, because we can't actually test the contents of
996         incremental_results.json. We should fix that at some point.
997
998 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
999
1000         make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
1001         https://bugs.webkit.org/show_bug.cgi?id=83401
1002
1003         Reviewed by Adam Barth.
1004
1005         Last patch in the series - no longer look in mac-leopard,
1006         mac-snowleopard, or mac-lion.
1007
1008         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1009         (ChromiumMacPort):
1010         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1011
1012 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1013
1014         webkit-patch: add a print-expectations command
1015         https://bugs.webkit.org/show_bug.cgi?id=83347
1016
1017         Reviewed by Adam Barth.
1018
1019         This command will print the expected results for a given set of
1020         tests on a given set of ports matching a given set of keywords.
1021
1022         Example output (printing all the tests not expected to pass, and their
1023         expected results, on a Mac):
1024
1025         $ webkit-patch print-expectations -x pass fast/html
1026         // For mac-snowleopard
1027         fast/html/details-open4.html = TEXT
1028         fast/html/details-open2.html = TEXT
1029         fast/html/details-no-summary4.html = TEXT
1030         fast/html/details-open-javascript.html = TEXT
1031         $
1032
1033         You can also print full test-expectatons.txt lines using --full and a
1034         CSV-style report (which can be useful for post-processing) using --csv.
1035
1036         It will replace the 'skipped-files' command (which will be
1037         removed in a subsequent patch) and is a more general (and
1038         cleaner and properly layered) solution.
1039
1040         Also add an update() command to MockOptions() to make overriding keywords easier.
1041
1042         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1043         (TestExpectationSerializer.to_string):
1044         (TestExpectationSerializer):
1045         (TestExpectationSerializer.to_csv):
1046         (TestExpectationSerializer._format_result):
1047         (TestExpectationLine.create_passing_expectation):
1048         (TestExpectationsModel.get_test_set_for_keyword):
1049         (TestExpectationsModel.has_keyword):
1050         (TestExpectations.model):
1051         * Scripts/webkitpy/tool/commands/queries.py:
1052         (execute):
1053         (PrintExpectations):
1054         (PrintExpectations.__init__):
1055         (PrintExpectations.execute):
1056         (PrintExpectations._filter_tests):
1057         (PrintExpectations._format_lines):
1058         (PrintExpectations._model):
1059         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1060         (TestPrintExpectations): Added.
1061         * Scripts/webkitpy/tool/mocktool.py:
1062         (MockOptions):
1063         (MockOptions.__init__):
1064         (MockOptions.update): Added.
1065
1066 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1067
1068         webkitpy: refactor handling of --platform and related options
1069         https://bugs.webkit.org/show_bug.cgi?id=83525
1070
1071         Reviewed by Adam Barth.
1072
1073         This change moves to centralize handling of --platform, --debug,
1074         --gtk, and other similar flags into a central place next to the
1075         code that actually uses those flags in PortFactory to get the
1076         right Port object.
1077
1078         * Scripts/webkitpy/layout_tests/port/__init__.py:
1079         * Scripts/webkitpy/layout_tests/port/factory.py:
1080         (port_options):
1081         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1082         (parse_args):
1083         * Scripts/webkitpy/tool/commands/queries.py:
1084         (PrintBaselines.__init__):
1085
1086 2012-04-10  Ojan Vafai  <ojan@chromium.org>
1087
1088         Add a chromeless view to the individual tests view
1089         https://bugs.webkit.org/show_bug.cgi?id=83541
1090
1091         Reviewed by Daniel Bates.
1092
1093         This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
1094
1095         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1096         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1097         (testHtmlForIndividualTestOnAllBuilders):
1098         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
1099         (testHtmlForIndividualTestOnAllBuildersWithChrome):
1100         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
1101         (testHtmlForIndividualTests):
1102         (htmlEscape):
1103         (runTests):
1104
1105 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1106
1107         remove 'win' from chromium-win, chromium-linux fallback paths
1108         https://bugs.webkit.org/show_bug.cgi?id=83613
1109
1110         Reviewed by Ojan Vafai.
1111
1112         The chromium ports no longer need to look at the apple 'win'
1113         directory for baseline results.
1114
1115         Also remove the old '-gpu-' entries from the flakiness dashboard
1116         map since I'm touching lines nearby.
1117
1118         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1119         (ChromiumLinuxPort):
1120         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1121         (ChromiumWinPort):
1122         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1123
1124 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
1125
1126         [Qt][WK2] Manage graphics buffers in the web process
1127         https://bugs.webkit.org/show_bug.cgi?id=78675
1128
1129         Enable graphics surfaces on Mac for Qt.
1130
1131         Reviewed by Kenneth Rohde Christiansen.
1132
1133         * qmake/mkspecs/features/features.prf:
1134
1135 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
1136
1137         [CMake] Enable USE_FOLDERS property
1138         https://bugs.webkit.org/show_bug.cgi?id=83571
1139
1140         Reviewed by Daniel Bates.
1141
1142         Setting the FOLDER property on targets gives more structure
1143         to the generated Visual Studio solutions.
1144         This does not affect other CMake generators.
1145
1146         * DumpRenderTree/efl/CMakeLists.txt:
1147         * EWebLauncher/CMakeLists.txt:
1148         * WinCELauncher/CMakeLists.txt:
1149
1150 2012-04-10  David Dorwin  <ddorwin@chromium.org>
1151
1152         Add Encrypted Media Extensions methods to HTMLMediaElement
1153         https://bugs.webkit.org/show_bug.cgi?id=82971
1154
1155         Reviewed by Adam Barth.
1156
1157         The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
1158         Implementation is based on v0.1 of the draft proposal at
1159         http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
1160
1161         * DumpRenderTree/chromium/TestShell.cpp:
1162         (TestShell::TestShell):
1163
1164 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
1165
1166         [EFL][DRT] Catch the "title,changed" signal
1167         https://bugs.webkit.org/show_bug.cgi?id=82174
1168
1169         Reviewed by Gustavo Noronha Silva.
1170
1171         EFL's DumpRenderTree now catches the "title,changed" signal, and
1172         prints out the needed information.
1173
1174         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1175         (DumpRenderTreeChrome::onTitleChanged):
1176
1177 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
1178
1179         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
1180         https://bugs.webkit.org/show_bug.cgi?id=82443
1181
1182         Reviewed by Philippe Normand.
1183
1184         EFL's DRT needs to support LayoutTestController's
1185         willSendRequestReturnsNull() and return NULL when expected. This
1186         allows for several tests to be removed from the skip list.
1187
1188         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1189         (DumpRenderTreeChrome::onWillSendRequest):
1190
1191 2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1192
1193         [EFL] LayoutTestController needs implementation of addUserStyleSheet
1194         https://bugs.webkit.org/show_bug.cgi?id=82446
1195
1196         Adding missing implementation addUserStyleSheet to EFL's LayoutTestController 
1197         so that we can unskip related tests from the skip list. 
1198
1199         Reviewed by Antonio Gomes.
1200
1201         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1202         (LayoutTestController::addUserStyleSheet): Implemented.
1203
1204 2012-04-10  Philip Rogers  <pdr@google.com>
1205
1206         Adding myself to committers.py!
1207
1208         Unreviewed update to committers.py.
1209
1210         * Scripts/webkitpy/common/config/committers.py:
1211
1212 2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>
1213
1214         [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
1215         https://bugs.webkit.org/show_bug.cgi?id=82483
1216
1217         Reviewed by Kenneth Rohde Christiansen.
1218
1219         Set window title to default if there is no page title.
1220
1221         * MiniBrowser/qt/BrowserWindow.cpp:
1222         (BrowserWindow::BrowserWindow):
1223         (BrowserWindow::onTitleChanged):
1224         * MiniBrowser/qt/BrowserWindow.h:
1225         (BrowserWindow):
1226
1227 2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1228
1229         [Qt][WK2] Implement PageClient::isViewWindowActive()
1230         https://bugs.webkit.org/show_bug.cgi?id=81143
1231
1232         Reviewed by Kenneth Rohde Christiansen.
1233
1234         Fix the WrapperWindow from our PlatformWebView
1235         so it correctly creates the platform related
1236         stuff for QWindow, which is not created unless
1237         QWindow::setVisible() or QWindow::show() are called.
1238
1239         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1240         (WTR::PlatformWebView::PlatformWebView):
1241
1242 2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
1243
1244         [Qt][WK2] TestNetscapePlugin is broken
1245         https://bugs.webkit.org/show_bug.cgi?id=83024
1246
1247         Reviewed by Csaba Osztrogonác.
1248
1249         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1250         Fix X11 availability check. embedded is always true with QPA.
1251         * Tools.pro:
1252         Build the test plugin if plugins are enabled for WebKit2.
1253         * qmake/mkspecs/features/features.prf:
1254         * qmake/mkspecs/features/functions.prf:
1255         Added a convenience function to determine availability
1256         of X11 libraries.
1257
1258 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
1259
1260         [WIN] Fix build without precompiled header.
1261
1262         * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
1263
1264 2012-04-10  Arko Saha  <arko@motorola.com>
1265
1266         Unreviewed: adding myself to committers.py.
1267
1268         * Scripts/webkitpy/common/config/committers.py:
1269
1270 2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1271
1272         Unreviewed: adding myself to committers.py.
1273
1274         * Scripts/webkitpy/common/config/committers.py:
1275
1276 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1277
1278         Unreviewed, rolling out r113656.
1279         http://trac.webkit.org/changeset/113656
1280         https://bugs.webkit.org/show_bug.cgi?id=83542
1281
1282         test is broken on chromium-win (Requested by simonjam on
1283         #webkit).
1284
1285         * DumpRenderTree/chromium/WebViewHost.cpp:
1286         (WebViewHost::dispatchIntent):
1287
1288 2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>
1289
1290         Update pywebsocket to 0.7.4.
1291         https://bugs.webkit.org/show_bug.cgi?id=83461
1292
1293         Reviewed by Kent Tamura.
1294
1295         This version supports TLS by using ssl in addition to pyOpenSSL.
1296         Other functional difrerences from 0.7.2 are:
1297          - strict Sec-WebSocket-Key validation conforming RFC 4648
1298          - compression ratio logging in debug
1299
1300         * Scripts/webkitpy/thirdparty/__init__.py:
1301         (AutoinstallImportHook._install_pywebsocket):
1302
1303 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
1304
1305         add a webkit-patch print-baselines command
1306         https://bugs.webkit.org/show_bug.cgi?id=83348
1307
1308         Reviewed by Adam Barth.
1309
1310         This adds a simple 'print-baselines' command to webkit-patch
1311         that can be used in one of two forms: to print where the
1312         baselines for a given test (or set of tests) on a single port
1313         will be found, or to generate a report for multiple ports.
1314
1315         Example of the former:
1316
1317         $ webkit-patch print-baselines fast/html/keygen.html
1318         // For mac-snowleopard
1319         platform/mac/fast/html/keygen-expected.txt
1320         platform/mac/fast/html/keygen-expected.png
1321         $
1322
1323         The latter is most useful for finding out which fallback dirs are
1324         used by which ports for which tests, for example,
1325         'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
1326         No example output is given because the reports are pretty wordy :).
1327
1328         * Scripts/webkitpy/layout_tests/port/base.py:
1329         (Port.baseline_extensions): Added.
1330         (Port.expected_baseline_dict): Added.
1331         * Scripts/webkitpy/tool/commands/queries.py:
1332         (PrintBaselines):
1333         (PrintBaselines.__init__):
1334         (PrintBaselines.execute):
1335         (PrintBaselines._print_baselines):
1336         (PrintBaselines._platform_for_path):
1337
1338 2012-04-09  Florin Malita  <fmalita@chromium.org>
1339
1340         Unreviewed: adding myself to committers.py.
1341
1342         * Scripts/webkitpy/common/config/committers.py:
1343
1344 2012-04-09  Ming Xie  <mxie@rim.com>
1345
1346         [BlackBerry] Allow simulator to use GLES2 acceleration
1347         https://bugs.webkit.org/show_bug.cgi?id=81672
1348
1349         Reviewed by Rob Buis.
1350
1351         * Scripts/webkitdirs.pm:
1352         (blackberryCMakeArguments):
1353
1354 2012-04-09  Dana Jansens  <danakj@chromium.org>
1355
1356         Mark myself as a committer
1357         https://bugs.webkit.org/show_bug.cgi?id=83510
1358
1359         Reviewed by Adrienne Walker.
1360
1361         * Scripts/webkitpy/common/config/committers.py:
1362
1363 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
1364
1365         nrwt is failing to upload test results on the chromium-mac-leopard bots
1366         https://bugs.webkit.org/show_bug.cgi?id=83230
1367
1368         Unreviewed, build fix.
1369
1370         It looks like the change in r113399 to use the per-request
1371         timeout variable didn't actually work, so I am removing the
1372         timeout code altogether and counting on the idea that upload
1373         just isn't likely to take that long and the timeouts and
1374         retransmits are largely unused and largely unnecessary. We'll
1375         see if this breaks anywhere else.
1376
1377         * Scripts/webkitpy/common/net/file_uploader.py:
1378         (FileUploader.__init__):
1379         (FileUploader._upload_data.callback):
1380         (FileUploader):
1381
1382 2012-04-09  Rob Buis  <rbuis@rim.com>
1383
1384         [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
1385         https://bugs.webkit.org/show_bug.cgi?id=83469
1386
1387         Reviewed by Dirk Schulze.
1388
1389         Remove WTF:: prefixes and fix a warning with the length variable.
1390
1391         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1392         (jsStringRefToWebCoreString):
1393         (LayoutTestController::execCommand):
1394         (LayoutTestController::isCommandEnabled):
1395         (LayoutTestController::setUserStyleSheetLocation):
1396         (LayoutTestController::counterValueForElementById):
1397         (LayoutTestController::overridePreference):
1398         (LayoutTestController::setMockGeolocationError):
1399         (LayoutTestController::findString):
1400
1401 2012-04-09  Patrick Gansterer  <paroga@webkit.org>
1402
1403         Build fix for WinCE after r113570.
1404
1405         * Scripts/build-webkit: Do not use FastMalloc for WinCE.
1406
1407 2012-04-09  Eric Carlson  <eric.carlson@apple.com>
1408
1409         Subscribe eric.carlson@apple.com to Media-related changes
1410         https://bugs.webkit.org/show_bug.cgi?id=83421
1411
1412         Reviewed by Dan Bernstein.
1413
1414         * Scripts/webkitpy/common/config/watchlist:
1415
1416 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
1417
1418         check-webkit-style should ignore NULL usage in gtk_style_context_get_style
1419         https://bugs.webkit.org/show_bug.cgi?id=83412
1420
1421         Reviewed by David Levin.
1422
1423         Accept NULL as an argument for gtk_style_context_get_style, because it's
1424         used as a sentinel in a variable argument list. 
1425
1426         * Scripts/webkitpy/style/checkers/cpp.py:
1427         (check_for_null): Add an exception.
1428         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1429         (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
1430
1431 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
1432
1433         webkitpy: use the filesystem object properly in fileuploader
1434         https://bugs.webkit.org/show_bug.cgi?id=83326
1435
1436         Reviewed by Adam Barth.
1437
1438         We should be using the filesystem object rather than the codecs
1439         object.
1440
1441         * Scripts/webkitpy/common/net/file_uploader.py:
1442         (FileUploader.upload_as_multipart_form_data):
1443
1444 2012-04-09  Eric Seidel  <eric@webkit.org>
1445
1446         Enable webkit_unit_tests for commit queue and EWS while tracking failures
1447         https://bugs.webkit.org/show_bug.cgi?id=83329
1448
1449         Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
1450
1451         line 62, in _create_unit_test_results
1452          return UnitTestResults.results_from_string(results_xml)
1453          NameError: global name 'UnitTestResults' is not defined
1454
1455         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1456         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1457         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1458
1459 2012-04-08  Adam Barth  <abarth@webkit.org>
1460
1461         The port object is missing unit_tests_results_path
1462         https://bugs.webkit.org/show_bug.cgi?id=83448
1463
1464         Unreviewed.
1465
1466         This is causing the cr-linux-ews to throw an exception.
1467
1468         * Scripts/webkitpy/common/config/ports.py:
1469         (DeprecatedPort.unit_tests_results_path):
1470
1471 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
1472
1473         [CMake] Cleanup WTF include directories
1474         https://bugs.webkit.org/show_bug.cgi?id=82716
1475
1476         Reviewed by Eric Seidel.
1477
1478         * DumpRenderTree/efl/CMakeLists.txt:
1479         * WinCELauncher/CMakeLists.txt:
1480
1481 2012-04-07  Rob Buis  <rbuis@rim.com>
1482
1483         [BlackBerry] Add Battery Status API support
1484         https://bugs.webkit.org/show_bug.cgi?id=82615
1485
1486         Reviewed by George Staikos.
1487
1488         Enable BATTERY_STATUS.
1489
1490         * Scripts/build-webkit:
1491
1492 2012-04-06  Ami Fischman  <fischman@chromium.org>
1493
1494         Subscribe feature-media-reviews@c.o to Media-related changes.
1495         https://bugs.webkit.org/show_bug.cgi?id=83397
1496
1497         Reviewed by David Levin.
1498
1499         * Scripts/webkitpy/common/config/committers.py:
1500         * Scripts/webkitpy/common/config/watchlist:
1501
1502 2012-04-06  Adrienne Walker  <enne@google.com>
1503
1504         [chromium] Add virtual test suite for threaded compositing
1505         https://bugs.webkit.org/show_bug.cgi?id=82263
1506
1507         Reviewed by James Robinson.
1508
1509         Add compositing/visibility as a virtual test suites to test threaded
1510         compositing with. This is a reasonable smoke test of 9 tests, none of
1511         which have any expectations in the non-threaded case.
1512
1513         To fix many of the remaining tests in this virtual test suite, there
1514         will need to be some serious refactoring to merge the conflict between
1515         the way CCScheduler wants to draw frames and the way DRT also wants to
1516         control things. So, in the short term, enable a few simple tests that
1517         are known to be passing.
1518
1519         * Scripts/webkitpy/layout_tests/port/chromium.py:
1520         (ChromiumPort.virtual_test_suites):
1521
1522 2012-04-06  Enrica Casucci  <enrica@apple.com>
1523
1524         Provide Obj-C private API to simplify markup.
1525         https://bugs.webkit.org/show_bug.cgi?id=83334
1526         <rdar://problem/11033861>
1527
1528         Reviewed by Sam Weinig.
1529
1530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1531         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
1532         (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
1533         * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
1534
1535 2012-04-06  Dirk Pranke  <dpranke@chromium.org>
1536
1537         new-run-webkit-tests: fix bugs in 'mock' drt implementation
1538         https://bugs.webkit.org/show_bug.cgi?id=83341
1539
1540         Reviewed by Eric Seidel.
1541
1542         The current implementation crashed in some circumstances for
1543         reference tests and files that were missing expected results.
1544         This patch fixes those cases and adds more unit tests; it is a
1545         precursor to adding unit tests each port that actually uses this
1546         code, in order to get better coverage of the port/*
1547         implementations.
1548
1549         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1550         (parse_options):
1551         (MockDRT.input_from_line):
1552         (MockDRT.output_for_test):
1553         (MockDRT.run_one_test):
1554         (MockChromiumDRT.input_from_line):
1555         (MockChromiumDRT.output_for_test):
1556         (MockChromiumDRT.run_one_test):
1557         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1558         (MockDRTTest.make_input_output):
1559         (MockDRTTest.expected_output):
1560         (MockDRTTest):
1561         (MockDRTTest.assertTest):
1562         (MockDRTTest.test_missing_image):
1563         (MockDRTTest.test_missing_text):
1564         (MockDRTTest.test_reftest_match):
1565         (MockDRTTest.test_reftest_mismatch):
1566         (MockChromiumDRTTest.expected_output):
1567
1568 2012-04-06  James Robinson  <jamesr@chromium.org>
1569
1570         Enable webkit_unit_tests for commit queue and EWS while tracking failures
1571         https://bugs.webkit.org/show_bug.cgi?id=83329
1572
1573         Reviewed by Adam Barth.
1574
1575         This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
1576         the commit queue and EWS can reject patches that cause regressions.
1577
1578         * Scripts/webkitpy/common/config/ports.py:
1579         (ChromiumPort.run_webkit_unit_tests_command):
1580         * Scripts/webkitpy/common/config/ports_mock.py:
1581         (MockPort.unit_tests_results_path):
1582         * Scripts/webkitpy/common/net/layouttestresults.py:
1583         (LayoutTestResults.__init__):
1584         (LayoutTestResults.failing_tests):
1585         (LayoutTestResults):
1586         (LayoutTestResults.add_unit_test_failures):
1587         * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
1588         (UnitTestResults):
1589         (UnitTestResults.results_from_string):
1590         * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
1591         (UnitTestResultsTest):
1592         (UnitTestResultsTest.test_nostring):
1593         (UnitTestResultsTest.test_emptystring):
1594         (UnitTestResultsTest.test_nofailures):
1595         (test_onefailure):
1596         (test_multiple_failures_per_test):
1597         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1598         (MockCommitQueue.test_results):
1599         (MockCommitQueue.archive_last_test_results):
1600         (FailingTestCommitQueue.test_results):
1601         (test_flaky_test_failure):
1602         (test_failed_archive):
1603         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1604         (LayoutTestResultsReader._create_unit_test_results):
1605         (LayoutTestResultsReader.results):
1606         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1607         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1608         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1609         (PatchAnalysisTaskDelegate.test_results):
1610         (PatchAnalysisTaskDelegate.archive_last_test_results):
1611         (PatchAnalysisTask._test):
1612         (PatchAnalysisTask._build_and_test_without_patch):
1613         (PatchAnalysisTask._test_patch):
1614         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1615         (AbstractEarlyWarningSystem.test_results):
1616         (AbstractEarlyWarningSystem.archive_last_test_results):
1617         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1618         (EarlyWarningSytemTest._test_testing_ews):
1619         * Scripts/webkitpy/tool/commands/queues.py:
1620         (CommitQueue.test_results):
1621         (CommitQueue.archive_last_test_results):
1622         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1623         (CommitQueueTest.test_commit_queue):
1624         (test_rollout):
1625         (test_manual_reject_during_processing):
1626         * Scripts/webkitpy/tool/steps/runtests.py:
1627         (RunTests.run):
1628         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1629         (RunTestsTest.test_webkit_run_unit_tests):
1630
1631 2012-04-06  Aaron Colwell  <acolwell@chromium.org>
1632
1633         Enable MediaSource feature for DumpRenderTree so
1634         MediaSource LayoutTests will pass for Chromium.
1635         https://bugs.webkit.org/show_bug.cgi?id=83053
1636
1637         Reviewed by Dimitri Glazkov.
1638
1639         * DumpRenderTree/chromium/TestShell.cpp:
1640         (TestShell::TestShell):
1641
1642 2012-04-06  George Staikos  <staikos@webkit.org>
1643
1644         Turn on vibration support for BlackBerry.
1645
1646         Reviewed by Rob Buis.
1647
1648         * Scripts/build-webkit:
1649
1650 2012-04-06  Dan Bernstein  <mitz@apple.com>
1651
1652         <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
1653
1654         Reviewed by Sam Weinig.
1655
1656         * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
1657
1658 2012-04-05  Dirk Pranke  <dpranke@chromium.org>
1659
1660         nrwt is failing to upload test results on the chromium-mac-leopard bots
1661         https://bugs.webkit.org/show_bug.cgi?id=83230
1662
1663         Reviewed by Ojan Vafai.
1664
1665         This should fix things properly; FileUploader() was setting the
1666         socket default timeout value, and apparently that doesn't work
1667         properly with urllib. Also, the class had a bad try/finally
1668         block that was causing the exceptions to be swallowed :(.
1669
1670         * Scripts/webkitpy/common/net/file_uploader.py:
1671         (FileUploader.__init__):
1672         (FileUploader._upload_data.callback):
1673         (FileUploader):
1674         (FileUploader._upload_data):
1675         * Scripts/webkitpy/common/net/networktransaction.py:
1676         (NetworkTimeout.__str__):
1677         (NetworkTransaction.run):
1678         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1679         (JSONResultsGeneratorBase.upload_json_files):
1680
1681 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
1682
1683         [Qt] Correct <wtf/*.h> include paths.
1684         https://bugs.webkit.org/show_bug.cgi?id=83270
1685
1686         Reviewed by Eric Seidel.
1687
1688         Modify the #include declerations so that the
1689         wtf types are included using the full path.
1690
1691         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1692
1693 2012-04-05  Philippe Normand  <pnormand@igalia.com>
1694
1695         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1696         https://bugs.webkit.org/show_bug.cgi?id=83176
1697
1698         Reviewed by Tony Chang.
1699
1700         Refactored the test to use os.path.join() to specify the
1701         core_pattern value of the empty crash log mock.
1702
1703         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1704         (GtkPortTest):
1705         (GtkPortTest.assertLinesEqual):
1706         (GtkPortTest.test_get_crash_log):
1707         (_mock_gdb_output):
1708
1709 2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1710
1711         [Qt] Fix includes after QtDeclarative -> QtQML renaming
1712         https://bugs.webkit.org/show_bug.cgi?id=82195
1713
1714         Relanding r112651, because Qt5 is updated everywhere.
1715
1716         * MiniBrowser/qt/BrowserWindow.cpp:
1717         (BrowserWindow::updateVisualMockTouchPoints):
1718         * MiniBrowser/qt/main.cpp:
1719         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1720         (WTR::WrapperWindow::handleStatusChanged):
1721         * qmake/mkspecs/features/unix/default_post.prf:
1722
1723 2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>
1724
1725         [Qt] WK1/WK2 layout test results are diverging
1726         https://bugs.webkit.org/show_bug.cgi?id=82720
1727
1728         The resolving of default font families was altered in Qt5.
1729         This directly affects the font picked by DRT for layout
1730         tests. Since we want to keep the Qt4 and Qt5 results in line,
1731         we can trick DRT in picking the same font as before for now.
1732
1733         Reviewed by Csaba Osztrogonác.
1734
1735         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1736         (WebKit::initializeTestFonts):
1737
1738 2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>
1739
1740         Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
1741         https://bugs.webkit.org/show_bug.cgi?id=82592
1742
1743         Reviewed by David Levin.
1744
1745         Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
1746
1747         * DumpRenderTree/chromium/EventSender.cpp:
1748         (EventSender::beginDragWithFiles):
1749
1750 2012-04-04  Tim Horton  <timothy_horton@apple.com>
1751
1752         [mac] WKTR should always keep its windows offscreen
1753         https://bugs.webkit.org/show_bug.cgi?id=83244
1754         <rdar://problem/11188764>
1755
1756         Reviewed by Simon Fraser.
1757
1758         We don't want to allow windows onto the main display; intercept attempts to
1759         change WebKitTestRunnerWindow's frame origin and prevent it from happening.
1760
1761         Also keep around and respond with a new "fake" origin, in case someone is
1762         expecting it to change (I couldn't find any tests that expected this, however).
1763
1764         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1765         (-[WebKitTestRunnerWindow setFrameOrigin:]):
1766         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
1767         (-[WebKitTestRunnerWindow setFrame:display:]):
1768         (-[WebKitTestRunnerWindow frame]):
1769
1770 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1771
1772         Fix typo introduced in r113271.
1773
1774         Unreviewed, build fix.
1775
1776         * Scripts/webkitpy/common/net/file_uploader.py:
1777         (FileUploader._upload_data.callback):
1778         (FileUploader):
1779
1780 2012-04-04  Scott Graham  <scottmg@google.com>
1781
1782         [Chromium, DRT] Bounds check indices on gamepadController
1783         https://bugs.webkit.org/show_bug.cgi?id=83192
1784
1785         Invalid test data would cause bad array accesses. Add simple checks to
1786         ignore such invalid data.
1787
1788         Reviewed by Kent Tamura.
1789
1790         * DumpRenderTree/chromium/GamepadController.cpp:
1791         (GamepadController::connect):
1792         (GamepadController::disconnect):
1793         (GamepadController::setId):
1794         (GamepadController::setButtonCount):
1795         (GamepadController::setButtonData):
1796         (GamepadController::setAxisCount):
1797         (GamepadController::setAxisData):
1798
1799 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1800
1801         nrwt is failing to upload test results on the chromium-mac-leopard bots
1802         https://bugs.webkit.org/show_bug.cgi?id=83230
1803
1804         Reviewed by Ojan Vafai.
1805
1806         More debugging info and a possible fix - stop messing with the
1807         default network timeout, and don't swallow URLErrors.
1808
1809         * Scripts/webkitpy/common/net/file_uploader.py:
1810         (FileUploader._upload_data):
1811         * Scripts/webkitpy/common/net/networktransaction.py:
1812         (NetworkTransaction.run):
1813         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1814         (JSONResultsGeneratorBase.upload_json_files):
1815
1816 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1817
1818         nrwt is failing to upload test results on the chromium-mac-leopard bots
1819         https://bugs.webkit.org/show_bug.cgi?id=83230
1820
1821         Reviewed by Ojan Vafai.
1822
1823         * Scripts/webkitpy/common/net/file_uploader.py:
1824         (FileUploader.__init__):
1825         (FileUploader._upload_data.callback):
1826         (FileUploader):
1827         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1828         (Manager._upload_json_files):
1829         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1830         (JSONResultsGeneratorBase.upload_json_files):
1831
1832 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1833
1834         WKTR needs to implement layoutTestController.setPageVisibility()
1835         https://bugs.webkit.org/show_bug.cgi?id=69554
1836
1837         Reviewed by Simon Fraser.
1838
1839         This patch implements the layoutTestController.setPageVisibility
1840         so WKTR supports the Page Visibility API implementation by using InjectedBundle
1841         to set the visibility state directly to Page.
1842
1843         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1844         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1845         (WTR::LayoutTestController::setPageVisibility):
1846         (WTR):
1847         (WTR::LayoutTestController::resetPageVisibility):
1848         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1849         (LayoutTestController):
1850
1851 2012-04-04  Adam Barth  <abarth@webkit.org>
1852
1853         [Chromium] TestWebKitAPI links in WebCore twice
1854         https://bugs.webkit.org/show_bug.cgi?id=83177
1855
1856         Reviewed by Dimitri Glazkov.
1857
1858         This is causing link errors in the Windows component build. This patch
1859         moves the dependencies a bit lower down in the dependency diagram in
1860         the hopes of removing the duplicate symbols.
1861
1862         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1863
1864 2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>
1865
1866         [EFL][DRT] Catch the "resource,request,willsend" signal
1867         https://bugs.webkit.org/show_bug.cgi?id=82192
1868
1869         Reviewed by Gustavo Noronha Silva.
1870
1871         EFL's DumpRenderTree now catches the "resource,request,willsend"
1872         signal in order to implement the "Blocked access to external URL"
1873         behavior and avoid potential network-related timeouts in the tests.
1874
1875         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1876         (DumpRenderTreeChrome::createView):
1877         (DumpRenderTreeChrome::onWillSendRequest):
1878         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1879         (DumpRenderTreeChrome):
1880
1881 2012-04-04  Patrick Gansterer  <paroga@webkit.org>
1882
1883         [EFL][DRT] Correct <wtf/*.h> include paths.
1884         https://bugs.webkit.org/show_bug.cgi?id=83168
1885
1886         Reviewed by Eric Seidel.
1887
1888         Modify the #include declarations so that the 
1889         wtf types are included using the full path.
1890
1891         * DumpRenderTree/efl/DumpRenderTree.cpp:
1892
1893 2012-04-04  Philippe Normand  <pnormand@igalia.com>
1894
1895         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1896         https://bugs.webkit.org/show_bug.cgi?id=83176
1897
1898         Reviewed by Tony Chang.
1899
1900         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1901         (test_get_crash_log): Skip the test on non-linux platforms.
1902
1903 2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1904
1905         [EFL] DRT support for computedStyleIncludingVisitedInfo
1906         https://bugs.webkit.org/show_bug.cgi?id=82190
1907
1908         Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
1909         LayoutTestController so that we can unskip related tests from the skip list.
1910
1911         Reviewed by Antonio Gomes.
1912
1913         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1914         (LayoutTestController::computedStyleIncludingVisitedInfo):
1915
1916 2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>
1917
1918         Unreviewed; update my email address once again in the committers
1919         and watch list.
1920
1921         * Scripts/webkitpy/common/config/committers.py: Prefer my
1922         webkit.org email over my FreeBSD.org one.
1923         * Scripts/webkitpy/common/config/watchlist: Ditto.
1924
1925 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1926
1927         [Qt][WK2] QtWebKit2 should support Page Visibility API
1928         https://bugs.webkit.org/show_bug.cgi?id=81164
1929
1930         Reviewed by Kenneth Rohde Christiansen.
1931
1932         Enabling Page Visiblity API for Qt WebKit2.
1933
1934         * qmake/mkspecs/features/features.prf:
1935
1936 2012-04-04  Andras Becsi  <andras.becsi@nokia.com>
1937
1938         [Qt][WK2] Make the WebView a subclass of Flickable
1939         https://bugs.webkit.org/show_bug.cgi?id=83033
1940
1941         Reviewed by Kenneth Rohde Christiansen.
1942
1943         Remove workaround in MiniBrowser and the ScrollIndicator
1944         now that the WebView is a Flickable.
1945
1946         * MiniBrowser/qt/MiniBrowser.pro:
1947         * MiniBrowser/qt/qml/BrowserWindow.qml:
1948         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1949         * WebKitTestRunner/Target.pri:
1950
1951 2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>
1952
1953         REGRESSION(r113144): It made run-webkit-tests always fail
1954         https://bugs.webkit.org/show_bug.cgi?id=83142
1955
1956         Unreviewed trivial fix after r113144.
1957
1958         * Scripts/run-webkit-tests:
1959
1960 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1961
1962         I really hope this is the last build fix. Apparently exec doesn't quite arguments with
1963         double quotations on Windows. Use system instead.
1964
1965         Hopefully, this won't break anything.
1966
1967         * Scripts/run-webkit-tests:
1968
1969 2012-04-03  Keishi Hattori  <keishi@webkit.org>
1970
1971         Disable ENABLE_DATALIST for now
1972         https://bugs.webkit.org/show_bug.cgi?id=82871
1973
1974         Reviewed by Kent Tamura.
1975
1976         * Scripts/build-webkit: Disabled ENABLE_DATALIST.
1977
1978 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1979
1980         Sigh... this isn't going well. I can't even reproduce this issue locally.
1981         Another speculative fix.
1982
1983         * Scripts/run-webkit-tests:
1984
1985 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1986
1987         I don't know why I'm so sloppy today. Another build fix.
1988
1989         * Scripts/run-webkit-tests:
1990
1991 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1992
1993         Hopefully the last build fix for Chromium Windows.
1994
1995         Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
1996
1997         * Scripts/run-webkit-tests:
1998
1999 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
2000
2001         [Chromium] Lots of timeouts causing Mac10.6 to exit early.
2002         https://bugs.webkit.org/show_bug.cgi?id=83076
2003
2004         Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
2005
2006         Add logic to the apple mac and chromium mac code to not use
2007         too many workers; it looks like the xserves (and possibly mac
2008         pros) count hyperthreaded cores when they really shouldn't and
2009         we end up using too many workers at a time; this leads to tests
2010         thrashing and timing out.
2011
2012         This change is a temporary fix to make the bots happy while I
2013         look into more profiling and other fixes.
2014
2015         * Scripts/webkitpy/layout_tests/port/mac.py:
2016         (ChromiumMacPort.default_child_processes):
2017
2018         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2019         (ChromiumMacPort.default_child_processes):
2020
2021 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2022
2023         WebKitTestRunner's EventSender is leaky
2024         https://bugs.webkit.org/show_bug.cgi?id=83099
2025
2026         Reviewed by Beth Dakin.
2027         
2028         Fix leaks of WKNumbers by using the adoptWK idiom, and make
2029         all the code consistent.
2030
2031         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2032         (WTR::EventSendingController::mouseDown):
2033         (WTR::EventSendingController::mouseUp):
2034         (WTR::EventSendingController::mouseMoveTo):
2035         (WTR::EventSendingController::leapForward):
2036         (WTR::EventSendingController::keyDown):
2037         (WTR::EventSendingController::mouseScrollBy):
2038         (WTR::EventSendingController::addTouchPoint):
2039         (WTR::EventSendingController::updateTouchPoint):
2040         (WTR::EventSendingController::setTouchModifier):
2041         (WTR::EventSendingController::releaseTouchPoint):
2042         (WTR::EventSendingController::cancelTouchPoint):
2043
2044 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2045
2046         Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
2047
2048         * Scripts/run-webkit-tests:
2049         (useNewRunWebKitTests):
2050
2051 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2052
2053         kill-old-processes should kill apache2 and httpd
2054         https://bugs.webkit.org/show_bug.cgi?id=83065
2055
2056         Reviewed by Tony Chang.
2057
2058         Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
2059
2060         * BuildSlaveSupport/kill-old-processes:
2061
2062 2012-04-03  Tony Chang  <tony@chromium.org>
2063
2064         run the same test steps on test only bots as on build-and-test bots
2065         https://bugs.webkit.org/show_bug.cgi?id=83090
2066
2067         Reviewed by Ryosuke Niwa.
2068
2069         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2070         (TestFactory.__init__):
2071
2072 2012-04-03  Ami Fischman  <fischman@chromium.org>
2073
2074         Add a Media watchlist.
2075         https://bugs.webkit.org/show_bug.cgi?id=83071
2076
2077         Reviewed by David Levin.
2078
2079         * Scripts/webkitpy/common/config/watchlist:
2080
2081 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2082
2083         Fix large leak in WebKitTestRunner
2084         https://bugs.webkit.org/show_bug.cgi?id=83084
2085
2086         Reviewed by Beth Dakin.
2087         
2088         Fix a leak of the bimap backing store created when doing pixel and
2089         ref tests. This leak was causing serious thrash on the test bots.
2090         
2091         We don't need to allocate memory for CGBitmapContextCreate(); if we
2092         pass NULL, it will allocate and manage its own backing store.
2093
2094         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2095         (WTR::createCGContextFromImage):
2096
2097 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2098
2099         Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
2100
2101         * BuildSlaveSupport/built-product-archive:
2102         (unzipArchive):
2103
2104 2012-04-03  Ojan Vafai  <ojan@chromium.org>
2105
2106         Give more human friendly error message when builders fail to load or have stale data.
2107         https://bugs.webkit.org/show_bug.cgi?id=83058
2108
2109         Reviewed by Eric Seidel.
2110
2111         * TestResultServer/static-dashboards/dashboard_base.js:
2112         (addError):
2113         (addBuilderLoadErrors):
2114         (handleLocationChange):
2115         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2116
2117 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2118
2119         Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
2120
2121         * BuildSlaveSupport/built-product-archive:
2122         (extractBuiltProduct):
2123
2124 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2125
2126         Yet another build fix after r113067. Don't trigger Chromium testers right away
2127         since they're now triggered by builders.
2128
2129         * BuildSlaveSupport/build.webkit.org-config/config.json:
2130
2131 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2132
2133         Another build fix after r113067 for Mac port.
2134         It turned out that archiving the entire build directory doesn't work.
2135
2136         * BuildSlaveSupport/built-product-archive:
2137         (createZipManually):
2138         (createZip):
2139         (archiveBuiltProduct):
2140
2141 2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
2142
2143         [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
2144         https://bugs.webkit.org/show_bug.cgi?id=82643
2145
2146         Update LayoutTestController to accomodate the new find API.
2147         It now provides caseSensitive functionality to DRT.
2148
2149         Internal Review by Andy Chen.
2150
2151         Reviewed by Rob Buis.
2152
2153         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2154         (LayoutTestController::findString):
2155
2156 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2157
2158         Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
2159         because download-built-product creates the build directory as needed.
2160
2161         This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
2162
2163         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2164         (TestFactory.__init__):
2165
2166 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2167
2168         Build fix after r113067. Don't delete the build directory.
2169
2170         * BuildSlaveSupport/built-product-archive:
2171         (extractBuiltProduct):
2172
2173 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2174
2175         Load all builder lists from the buildbot json
2176         https://bugs.webkit.org/show_bug.cgi?id=82998
2177
2178         Reviewed by Adam Barth.
2179
2180         Also, remove an unnecessary list of test types. Now we don't hard-code
2181         builder names anywhere and we only have a single hard-coded list of
2182         test types.
2183
2184         * TestResultServer/static-dashboards/builders.js:
2185         (BuilderMaster.prototype.logPath):
2186         (BuilderMaster.prototype.builderJsonPath):
2187         (requestBuilderList.xhr.onload):
2188         (requestBuilderList.xhr.onerror):
2189         (isChromiumDepsFyiGpuTestRunner):
2190         (isChromiumTipOfTreeGpuTestRunner):
2191         (isChromiumDepsGTestRunner):
2192         (isChromiumDepsCrosGTestRunner):
2193         (isChromiumTipOfTreeGTestRunner):
2194         (onBuilderListLoad):
2195         (loadBuildersList):
2196         * TestResultServer/static-dashboards/dashboard_base.js:
2197         (parseCrossDashboardParameters):
2198         (currentBuilderGroupCategory):
2199         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2200         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2201         (testHtmlForTestsWithExpectationsButNoFailures):
2202         (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
2203         (testGenerateChromiumDepsGTestBuildersFromBuilderList):
2204         (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
2205         (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
2206         * TestResultServer/static-dashboards/timeline_explorer.html:
2207
2208 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
2209
2210         Chromium testers should extract builds instead of building on their own
2211         https://bugs.webkit.org/show_bug.cgi?id=82996
2212
2213         Reviewed by Tony Chang.
2214
2215         Make Chromium builders triggger Chromium testers and make testers download and extract builds
2216         from the buildbot master instead of building binaries on their own.
2217
2218         Add download-built-product to wrap curl used in the download-built-product step since Windows
2219         does not provide "curl" natively.
2220
2221         * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
2222         Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
2223         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2224         (DownloadBuiltProduct): Call download-built-product instead of curl.
2225         * BuildSlaveSupport/built-product-archive:
2226         (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
2227         needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
2228         (archiveBuiltProduct): Zip the configuration build directory on Mac port.
2229         (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
2230         (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
2231         * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
2232
2233 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
2234
2235         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
2236         https://bugs.webkit.org/show_bug.cgi?id=82473
2237
2238         Reviewed by Philippe Normand.
2239
2240         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
2241         was ever run.
2242
2243         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
2244         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
2245
2246 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2247
2248         [EFL] DRT support for setInteractiveFormValidationEnabled
2249         https://bugs.webkit.org/show_bug.cgi?id=82050
2250
2251         Enable interactive form validation and unskip tests from the
2252         skip list.
2253
2254         Reviewed by Antonio Gomes.
2255
2256         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2257         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2258
2259 2012-04-03  Philippe Normand  <pnormand@igalia.com>
2260
2261         Unreviewed, another test-webkitpy fix-up after r113037.
2262
2263         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
2264         crash dump depending on current environment.
2265
2266 2012-04-03  Philippe Normand  <pnormand@igalia.com>
2267
2268         Unreviewed, test-webkitpy build fix after r113037.
2269
2270         * Scripts/webkitpy/layout_tests/port/gtk.py:
2271         (GtkPort._get_crash_log):
2272
2273 2012-04-03  Philippe Normand  <pnormand@igalia.com>
2274
2275         [GTK] crash log reports support
2276         https://bugs.webkit.org/show_bug.cgi?id=81659
2277
2278         Reviewed by Martin Robinson.
2279
2280         Removed the daemontools crashmon/xvfb scripts and implemented the crash
2281         log reporting in the NRWT Gtk port. To get proper crash logs one
2282         needs to set the core pattern like this:
2283         echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
2284         Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
2285         environment variable.
2286
2287         * BuildSlaveSupport/gtk/README:
2288         * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
2289         * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
2290         * BuildSlaveSupport/gtk/crashmon/run: Removed.
2291         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2292         * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
2293         * BuildSlaveSupport/gtk/xvfb/run: Removed.
2294         * Scripts/new-run-webkit-tests:
2295         * Scripts/webkitpy/layout_tests/port/gtk.py:
2296         (GtkDriver.stop):
2297         (GtkPort.show_results_html_file):
2298         (GtkPort):
2299         (GtkPort._get_gdb_output):
2300         (GtkPort._get_crash_log):
2301         (GtkPort._get_crash_log.match_filename):
2302         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2303         (GtkPortTest):
2304         (test_show_results_html_file):
2305         (assertLinesEqual):
2306         (_mock_gdb_output):
2307         (test_get_crash_log):
2308
2309 2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2310
2311         Enable and connect the WebInspectorServer with WebKit2 pages.
2312         https://bugs.webkit.org/show_bug.cgi?id=73094
2313
2314         Reviewed by Simon Hausmann.
2315
2316         Enable developer extras on pages in MiniBrowser for Qt.
2317
2318         * MiniBrowser/qt/qml/BrowserWindow.qml:
2319
2320 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
2321
2322         [EFL] LayoutTestController needs implementation of setDefersLoading
2323         https://bugs.webkit.org/show_bug.cgi?id=82890
2324
2325         Reviewed by Philippe Normand.
2326
2327         Implement setDefersLoading() in EFL's LayoutTestController so that the
2328         corresponding test case can be removed from the skip list.
2329
2330         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2331         (LayoutTestController::setDefersLoading):
2332
2333 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
2334
2335         [EFL] LayoutTestController needs implementation of goBack
2336         https://bugs.webkit.org/show_bug.cgi?id=81914
2337
2338         Reviewed by Philippe Normand.
2339
2340         Implement goBack() in EFL's LayoutTestController by calling
2341         ewk_frame_back().
2342
2343         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2344         (LayoutTestController::goBack):
2345
2346 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
2347
2348         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
2349         https://bugs.webkit.org/show_bug.cgi?id=82589
2350
2351         Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
2352         in order to unskip printing/page-format-data.html
2353
2354         Reviewed by Philippe Normand.
2355
2356         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2357         (LayoutTestController::pageSizeAndMarginsInPixels):
2358
2359 2012-04-03  Simon Pena  <spena@igalia.com>
2360
2361         [GTK] DRT missing didRunInsecureContent notification
2362         https://bugs.webkit.org/show_bug.cgi?id=59367
2363
2364         Reviewed by Philippe Normand.
2365
2366         Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
2367         the main WebFrame or any other WebFrame created later. Added
2368         "didRunInsecureContent" notification in the callback in order to
2369         get the LayoutTests passing.
2370
2371         * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
2372         to WebFrame's "insecure-content-run" signal and add
2373         didRunInsecureContent notification in the callback to get the
2374         LayoutTests passing.
2375         (didRunInsecureContent):
2376         (createWebView):
2377
2378 2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2379
2380         rebaseline-server: Make it possible to not launch a browser with the server.
2381         https://bugs.webkit.org/show_bug.cgi?id=82999
2382
2383         Reviewed by Adam Barth.
2384
2385         Add the `--no-show-results' option, which lets one decide not to
2386         launch a web browser when running the rebaseline server.  This is
2387         especially useful if the default browser is not the wanted one, or
2388         if the rebaseline server page is already open.
2389
2390         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
2391         (AbstractLocalServerCommand.__init__):
2392         (AbstractLocalServerCommand.execute):
2393
2394 2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2395
2396         EFL's LayoutTestController disableImageLoading implementation.
2397         https://bugs.webkit.org/show_bug.cgi?id=82848
2398
2399         Reviewed by Hajime Morita.
2400
2401         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2402         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2403         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2404         (LayoutTestController::disableImageLoading):
2405
2406 2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>
2407
2408         [EFL] LayoutTestController needs implementation of isPageBoxVisible
2409         https://bugs.webkit.org/show_bug.cgi?id=82591
2410
2411         Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
2412         in order to unskip printing/page-format-data.html
2413
2414         Reviewed by Hajime Morita.
2415
2416         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2417         (LayoutTestController::isPageBoxVisible):
2418
2419 2012-04-02  Simon Fraser  <simon.fraser@apple.com>
2420
2421         run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
2422         https://bugs.webkit.org/show_bug.cgi?id=82962
2423
2424         Reviewed by Dirk Pranke.
2425
2426         Ensure that _build_path() returns an absolute path.
2427
2428         Eric Seidel also had to deploy MockConfig in a bunch of places
2429         in order to correct previous testing errors where we were
2430         pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
2431         was a real path.  The real Config object calls run_command("webkit-build-directory")
2432         to read the WebKit build directory from the webkitdirs.pm perl code.
2433         MockConfig abstracts this away and always returns "/mock-build" during
2434         testing.  This change is much larger than one would think necessary
2435         because of needing to deploy this MockConfig class.
2436
2437         * Scripts/webkitpy/layout_tests/port/webkit.py:
2438         (WebKitPort._build_path):
2439
2440 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2441
2442         Fix snafu in r112971. We were never calling parseParameter for builder.
2443
2444         * TestResultServer/static-dashboards/dashboard_base.js:
2445
2446 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2447
2448         Generate the lists of all layout test builders from the buildbot json
2449         https://bugs.webkit.org/show_bug.cgi?id=82924
2450
2451         Reviewed by Mihai Parparita.
2452
2453         In order to make this work, cleaned up a lot of existing technical debt.
2454         -Got rid of expectations builder. This concept is outdated and just dead code.
2455         -Split hash parameter parsing into two functions. One for dashboard_base
2456         (crossDashboardParameters) and one for the specific dashboard html file
2457         (dashboardSpecificParameters). In the old world, parseParameters needed to
2458         be called twice and depended on it's own output the first time through.
2459         Now we only need to parse crossDashboardParameters first and crossDashboardParameters
2460         doesn't depend on the output of crossDashboardParameters.
2461         -Lots of variable/method renames due to the above.
2462         -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
2463         for that dashboard.
2464
2465         * TestResultServer/static-dashboards/aggregate_results.html:
2466         * TestResultServer/static-dashboards/builders.js:
2467         (BuilderGroup):
2468         (BuilderGroup.prototype.setup):
2469         (jsonRequest.xhr.onload):
2470         (jsonRequest.xhr.onerror):
2471         (isWebkitTestRunner):
2472         (isChromiumWebkitTipOfTreeTestRunner):
2473         (isChromiumWebkitDepsTestRunner):
2474         (generateBuildersFromBuilderList):
2475         (onLayoutTestBuilderListLoad):
2476         (onErrorLoadingBuilderList):
2477         (loadBuildersList):
2478         * TestResultServer/static-dashboards/dashboard_base.js:
2479         (handleValidHashParameterWrapper):
2480         (queryHashAsMap):
2481         (parseParameter):
2482         (parseCrossDashboardParameters):
2483         (parseDashboardSpecificParameters):
2484         (parseParameters):
2485         (diffStates):
2486         (defaultValue):
2487         (isLayoutTestResults):
2488         (isGPUTestResults):
2489         (currentBuilderGroupCategory):
2490         (currentBuilderGroup):
2491         (initBuilders):
2492         Now that we've split parameter parseing, these methods no longer need
2493         to take an optional state. They can always just use the global cross-dashboard state.
2494
2495         (pathToBuilderResultsFile):
2496         (appendJSONScriptElementFor):
2497         (appendJSONScriptElements):
2498         (handleResourceLoadError):
2499         (haveJsonFilesLoaded):
2500         (combinedDashboardState):
2501         (setQueryParameter):
2502         (permaLinkURLHash):
2503         (toggleQueryParameter):
2504         (queryParameterValue):
2505         (selectHTML):
2506         (htmlForTestTypeSwitcher):
2507         (g_handleBuildersListLoaded):
2508         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2509         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2510         (testPlatformAndBuildType):
2511         (testSubstringList):
2512         (testHtmlForTestTypeSwitcherGroup):
2513         (testLookupVirtualTestSuite):
2514         (testBaseTest):
2515         (generateBuildersFromBuilderListHelper):
2516         (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
2517         (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
2518         (assertObjectsDeepEqual):
2519         (testQueryHashAsMap):
2520         (testDiffStates):
2521         * TestResultServer/static-dashboards/timeline_explorer.html:
2522         * TestResultServer/static-dashboards/treemap.html:
2523
2524 2012-04-02  Tony Chang  <tony@chromium.org>
2525
2526         check-webkit-style errors when removing .png files
2527         https://bugs.webkit.org/show_bug.cgi?id=82933
2528
2529         Reviewed by David Levin.
2530
2531         * Scripts/webkitpy/style/patchreader.py:
2532         (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
2533         * Scripts/webkitpy/style/patchreader_unittest.py:
2534         (test_check_patch_with_png_deletion):
2535
2536 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2537
2538         Unreviewed, rolling out r112948.
2539         http://trac.webkit.org/changeset/112948
2540         https://bugs.webkit.org/show_bug.cgi?id=82961
2541
2542         Someone else already checked in a similar change (Requested by
2543         sundiamonde on #webkit).
2544
2545         * Scripts/webkitpy/layout_tests/port/webkit.py:
2546         (WebKitDriver._start):
2547
2548 2012-04-02  Adam Barth  <abarth@webkit.org>
2549
2550         garden-o-matic isn't able to rebaseline audio failures
2551         https://bugs.webkit.org/show_bug.cgi?id=82957
2552
2553         Reviewed by Chris Rogers.
2554
2555         This patch just adds "wav" to the list of test suffixes and updates the
2556         unit tests to show that we're rebaselining audio tests results now too.
2557
2558         * Scripts/webkitpy/tool/commands/rebaseline.py:
2559         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2560         (test_rebaseline_updates_expectations_file):
2561
2562 2012-04-02  Adam Barth  <abarth@webkit.org>
2563
2564         garden-o-matic should let you listen to audio failures
2565         https://bugs.webkit.org/show_bug.cgi?id=82953
2566
2567         Reviewed by Chris Rogers.
2568
2569         Now that we've actually got an audio failure on the bots, we can clean
2570         up the last stray bugs.  This patch doesn't have any tests because I'm
2571         lame.
2572
2573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2576         (.):
2577
2578 2012-04-02  Stephanie Lewis  <slewis@apple.com>
2579
2580         run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
2581         https://bugs.webkit.org/show_bug.cgi?id=82552
2582
2583         Reviewed by Dirk Pranke.
2584
2585         Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
2586
2587         * Scripts/webkitpy/layout_tests/port/webkit.py:
2588         (WebKitDriver._start):
2589
2590 2012-04-02  Dirk Pranke  <dpranke@chromium.org>
2591
2592         NRWT is not printing out the builder it's uploading JSON files for
2593         https://bugs.webkit.org/show_bug.cgi?id=82834
2594
2595         Reviewed by Ojan Vafai.
2596
2597         Handle log messages of the form log.info("%s", arg) properly ...
2598         I didn't even know you could do that :).
2599
2600         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2601         (_LogHandler.emit):
2602         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2603         (RegularTest.test_log_args):
2604         (VerboseTest.test_log_args):
2605
2606 2012-04-02  Tim Horton  <timothy_horton@apple.com>
2607
2608         [mac] LayoutTestHelper crashes if there is no main display
2609         https://bugs.webkit.org/show_bug.cgi?id=82944
2610         <rdar://problem/11162954>
2611
2612         Reviewed by Simon Fraser.
2613
2614         If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
2615         a null dictionary, so we shouldn't go ahead and try to read from it.
2616
2617         * DumpRenderTree/mac/LayoutTestHelper.m:
2618         (installLayoutTestColorProfile):
2619
2620 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2621
2622         [Qt][WK2] Set up plugin process on Unix
2623         https://bugs.webkit.org/show_bug.cgi?id=72121
2624
2625         Reviewed by Simon Hausmann.
2626
2627         * qmake/mkspecs/features/features.prf: Reenable plugins
2628         and turn on plugin process.
2629
2630 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2631
2632         Unreviewed, rolling out r112868, r112879, and r112881.
2633         http://trac.webkit.org/changeset/112868
2634         http://trac.webkit.org/changeset/112879
2635         http://trac.webkit.org/changeset/112881
2636         https://bugs.webkit.org/show_bug.cgi?id=82901
2637
2638         "Build fail on bots." (Requested by kbalazs on #webkit).
2639
2640         * MiniBrowser/gtk/GNUmakefile.am:
2641         * qmake/mkspecs/features/features.prf:
2642
2643 2012-04-02  Philippe Normand  <pnormand@igalia.com>
2644
2645         [GTK] Enable shadow-dom in build-webkit.
2646
2647         Rubber-stamped by Gustavo Noronha Silva.
2648
2649         * Scripts/build-webkit: Enable shadow-dom build, this is need to
2650         have a working build currently.
2651
2652 2012-04-02  Andreas Kling  <kling@webkit.org>
2653
2654         Adding Zalan Bujtas to committers list.
2655
2656         * Scripts/webkitpy/common/config/committers.py:
2657
2658 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2659
2660         [Qt][WK2] Set up plugin process on Unix
2661         https://bugs.webkit.org/show_bug.cgi?id=72121
2662
2663         Reviewed by Simon Hausmann.
2664
2665         * qmake/mkspecs/features/features.prf: Reenable plugins
2666         and turn on plugin process.
2667
2668 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2669
2670         Unreviewed, rolling out r112651.
2671         http://trac.webkit.org/changeset/112651
2672         https://bugs.webkit.org/show_bug.cgi?id=82887
2673
2674         It doesn't work with older Qt5 (Requested by Ossy on #webkit).
2675
2676         * MiniBrowser/qt/BrowserWindow.cpp:
2677         (BrowserWindow::updateVisualMockTouchPoints):
2678         * MiniBrowser/qt/main.cpp:
2679         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2680         (WTR::WrapperWindow::handleStatusChanged):
2681         * qmake/mkspecs/features/unix/default_post.prf:
2682
2683 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2684
2685         [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
2686         https://bugs.webkit.org/show_bug.cgi?id=82877
2687
2688         Reviewed by Philippe Normand.
2689
2690         * Scripts/run-gtk-tests:
2691         (TestRunner.run_tests): Use replace instead of lstrip to remove
2692         the programs_path from the full path of unit tests.
2693
2694 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2695
2696         Unreviewed. Skip flaky unit tests.
2697
2698         * Scripts/run-gtk-tests:
2699         (TestRunner):
2700
2701 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
2702
2703         webkitpy rebaseline.
2704
2705         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2706         (test_run_test_set_with_json_output):
2707         (test_run_test_set_with_json_source):
2708
2709 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
2710
2711         perf-o-matic should store test results' units
2712         https://bugs.webkit.org/show_bug.cgi?id=82852
2713
2714         Reviewed by Kentaro Hara.
2715
2716         Include units in the results JSON.
2717
2718         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2719         (PerfTestsRunner._process_chromium_style_test_result):
2720         (PerfTestsRunner._process_parser_test_result):
2721
2722 2012-04-01  Tony Tseung  <tseung@apple.com>
2723
2724         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
2725         composite fonts from existing physical fonts.
2726         <rdar://problem/10717370>
2727         https://bugs.webkit.org/show_bug.cgi?id=82810
2728             
2729         A new test font of this kind as been added to the test tools for running the webkit-tests
2730
2731         Reviewed by Dan Bernstein.
2732
2733         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2734         Added new dependency SampleFont.sfont
2735         
2736         * DumpRenderTree/fonts/SampleFont.sfont: Added.
2737         
2738         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2739         * DumpRenderTree/mac/DumpRenderTree.mm:
2740         (allowedFontFamilySet):
2741         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2742         
2743         (activateTestingFonts):
2744         Added the registration of the Composite Font Referene sample font
2745         
2746         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2747         (WTR::allowedFontFamilySet):
2748         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2749
2750         (WTR::activateFonts):
2751         Added the registration of the Composite Font Referene sample font
2752
2753         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2754         Added new dependency SampleFont.sfont
2755
2756         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
2757
2758 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2759
2760         Support the Network Information API
2761         https://bugs.webkit.org/show_bug.cgi?id=73528
2762
2763         Reviewed by Adam Barth.
2764
2765         Add network information API feature to build script.
2766
2767         * Scripts/build-webkit:
2768
2769 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2770
2771         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
2772         https://bugs.webkit.org/show_bug.cgi?id=82839
2773
2774         Reviewed by Adam Barth.
2775
2776         Also, update various hard-coded lists for WIN7 and Lion ports.
2777         This is necessary since the new list of builders grabbed off the
2778         buildbot includes Lion.
2779
2780         * TestResultServer/static-dashboards/builders.js:
2781         (generateWebkitBuildersFromBuilderList):
2782         (xhr.onreadystatechange):
2783         Don't use dashboard_base's request method to avoid layering violation.
2784
2785         * TestResultServer/static-dashboards/dashboard_base.js:
2786         (parseParameters):
2787         (initBuilders):
2788         (haveJsonFilesLoaded):
2789         (g_handleBuildersListLoaded):
2790         Block loading the JSON files for each builder until we actually have a list of builders.
2791
2792         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2793         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2794         (testPlatformAndBuildType):
2795         (testGenerateWebkitBuildersFromBuilderList):
2796         * TestResultServer/static-dashboards/timeline_explorer.html:
2797         * TestResultServer/static-dashboards/treemap.html:
2798         Delay generating the page until the builder list has loaded.
2799
2800 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2801
2802         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
2803         https://bugs.webkit.org/show_bug.cgi?id=82799
2804
2805         Reviewed by Eric Seidel.
2806
2807         If we don't run a test, mark it as skipped.
2808
2809         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2810         (Manager._mark_interrupted_tests_as_skipped):
2811         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
2812         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2813         (ManagerTest.test_interrupt_if_at_failure_limits):
2814
2815 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2816
2817         One more build fix after r112781 for Chromium Windows.
2818         Don't copy zip .idb files.
2819
2820         * BuildSlaveSupport/built-product-archive:
2821         (copyBuildFiles):
2822
2823 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2824
2825         Yet another build fix after r112781 for Chromium Windows.
2826         Run webkit-build-directory by perl explicitly.
2827
2828         * BuildSlaveSupport/built-product-archive:
2829         (determineWebKitBuildDirectory):
2830
2831 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2832
2833         Fix the syntax error in master.cfg after r112734.
2834
2835         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2836         (unitTestsSupported):
2837
2838 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2839
2840         Another build fix after r112781.
2841
2842         * BuildSlaveSupport/built-product-archive:
2843         (createZip):
2844
2845 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2846
2847         Build fix after r112781.
2848
2849         * BuildSlaveSupport/built-product-archive:
2850         (createZipManually):
2851         (createZip):
2852
2853 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
2854
2855         Chromium bots should upload archived built files
2856         https://bugs.webkit.org/show_bug.cgi?id=82666
2857
2858         Reviewed by Tony Chang.
2859
2860         * BuildSlaveSupport/build.webkit.org-config/config.json:
2861         * BuildSlaveSupport/built-product-archive:
2862         (main):
2863         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
2864         call out to webkit-build-directory.
2865         (removeDirectoryIfExists): Extracted.
2866         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
2867         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
2868         (createZipManually.addToArchive):
2869         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
2870         (archiveBuiltProduct): Add support for Chromium port.
2871         * Scripts/webkit-build-directory: Add support for --platform options.
2872
2873 2012-03-30  Dan Bernstein  <mitz@apple.com>
2874
2875         Reverted r112767, because it caused many vertical text tests to fail.
2876
2877         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2878         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2879         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2880         * DumpRenderTree/mac/DumpRenderTree.mm:
2881         (allowedFontFamilySet):
2882         (activateTestingFonts):
2883         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2884         (WTR::allowedFontFamilySet):
2885         (WTR::activateFonts):
2886         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2887         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2888
2889 2012-03-30  Malcolm MacLeod  <malcolm.macleod@tshwanedje.com>
2890
2891         [wx] Move wxWebKit API into WebKit namespace.
2892         https://bugs.webkit.org/show_bug.cgi?id=82740
2893
2894         Reviewed by Kevin Ollivier.
2895
2896         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2897         (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
2898         (LayoutWebViewEventHandler::bindEvents):
2899         (LayoutWebViewEventHandler::OnLoadEvent):
2900         (LayoutWebViewEventHandler::OnAlertEvent):
2901         (LayoutWebViewEventHandler::OnConfirmEvent):
2902         (LayoutWebViewEventHandler::OnPromptEvent):
2903         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2904         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2905         (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
2906         (LayoutWebViewEventHandler):
2907         (dumpFramesAsText):
2908         (dump):
2909         (MyApp::OnInit):
2910         * wx/browser/browser.cpp:
2911         (MyApp::OnInit):
2912
2913 2012-03-30  Eli Fidler  <efidler@rim.com>
2914
2915         Enable OpenType Sanitizer for BlackBerry port.
2916         https://bugs.webkit.org/show_bug.cgi?id=82782
2917
2918         Reviewed by Eric Seidel.
2919
2920         * Scripts/webkitdirs.pm:
2921         (blackberryCMakeArguments): add OTS to include path
2922
2923 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2924
2925         run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
2926         as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
2927         is found.
2928
2929         <rdar://problem/11158581>
2930         
2931         Reviewed by Mark Rowe.
2932
2933         * Scripts/webkitpy/layout_tests/port/webkit.py:
2934         (WebKitDriver._start):
2935
2936 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2937
2938         Disable run-api-tests on release mac builds
2939         https://bugs.webkit.org/show_bug.cgi?id=82788
2940
2941         Reviewed by Ryosuke Niwa.
2942         
2943         TestWebKitAPI crashes every time in release builds currently
2944         (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
2945         run-api-tests on mac release builders.
2946
2947         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2948         (unitTestsSupported):
2949
2950 2012-03-30  Chang Shu  <cshu@webkit.org>
2951
2952         Unreviewed. Update my email.
2953
2954         * Scripts/webkitpy/common/config/committers.py:
2955
2956 2012-03-30  Chris Fleizach  <cfleizach@apple.com>
2957
2958         AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
2959         https://bugs.webkit.org/show_bug.cgi?id=82745
2960
2961         Reviewed by Simon Fraser.
2962
2963         * DumpRenderTree/AccessibilityUIElement.cpp:
2964         (rangeForPositionCallback):
2965         (AccessibilityUIElement::rangeForPosition):
2966         (AccessibilityUIElement::getJSClass):
2967         * DumpRenderTree/AccessibilityUIElement.h:
2968         (AccessibilityUIElement):
2969         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2970         (AccessibilityUIElement::rangeForPosition):
2971         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2972         (WTR::AccessibilityUIElement::rangeForPosition):
2973         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2974         (AccessibilityUIElement):
2975         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2976         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2977         (WTR::AccessibilityUIElement::rangeForPosition):
2978         (WTR):
2979
2980 2012-03-30  David Barr  <davidbarr@chromium.org>
2981
2982         Split up top-level .gitignore and .gitattributes
2983         https://bugs.webkit.org/show_bug.cgi?id=82687
2984
2985         Reviewed by Tor Arne Vestbø.
2986
2987         * .gitattributes: Added.
2988         * .gitignore: Added.
2989         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
2990         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
2991
2992 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
2993
2994         Actually remove the ChromiumOS GTK builder, like r112673 said it would.
2995
2996         * TestResultServer/static-dashboards/builders.js:
2997
2998 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
2999
3000         Update ChromiumOS bot names in builders.js to reflect changes made by
3001         http://crrev.com/129835
3002         
3003         Also removes the ChromiumOS GTK builder, which was removed by
3004         http://crrev.com/129835
3005
3006         * TestResultServer/static-dashboards/builders.js:
3007
3008 2012-03-30  Vineet Chaudhary  <rgf748@motorola.com>
3009
3010         [GTK] Disable introspection build in the at-spi2-core module.
3011         https://bugs.webkit.org/show_bug.cgi?id=82729
3012
3013         Reviewed by Philippe Normand.
3014
3015         This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
3016
3017         * gtk/jhbuild.modules: Disable introspection.
3018
3019 2012-03-30  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3020
3021         Add a "preview" state to Page Visibility API implementation
3022         https://bugs.webkit.org/show_bug.cgi?id=81355
3023
3024         Reviewed by Adam Barth.
3025
3026         Updating the Page Visibility API implementation to the current spec version.
3027
3028         * DumpRenderTree/chromium/LayoutTestController.cpp:
3029         (LayoutTestController::setPageVisibility):
3030
3031 2012-03-30  Keishi Hattori  <keishi@webkit.org>
3032
3033         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
3034         https://bugs.webkit.org/show_bug.cgi?id=80972
3035
3036         Reviewed by Kent Tamura.
3037
3038         * Scripts/build-webkit:
3039         * qmake/mkspecs/features/features.prf:
3040
3041 2012-03-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
3042
3043         [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
3044         https://bugs.webkit.org/show_bug.cgi?id=82195
3045
3046         Reviewed by Simon Hausmann.
3047
3048         * MiniBrowser/qt/BrowserWindow.cpp:
3049         (BrowserWindow::updateVisualMockTouchPoints):
3050         * MiniBrowser/qt/main.cpp:
3051         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3052         (WTR::WrapperWindow::handleStatusChanged):
3053         * qmake/mkspecs/features/unix/default_post.prf:
3054
3055 2012-03-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3056
3057         [EFL] Implement LayoutTestController::setMinimumTimerInterval
3058         https://bugs.webkit.org/show_bug.cgi?id=81220
3059
3060         Add missing implementation setMinimumTimerInterval to EFL's
3061         LayoutTestController so that we can unskip related tests from the skip list.
3062
3063         Reviewed by Philippe Normand.
3064
3065         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3066         (LayoutTestController::setMinimumTimerInterval):
3067
3068 2012-03-29  Dan Bernstein  <mitz@apple.com>
3069
3070         Removed “Intel” from the Lion builders’ names.
3071
3072         Rubber-stamped by Mark Rowe.
3073
3074         * BuildSlaveSupport/build.webkit.org-config/config.json:
3075         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3076         (LeaksViewer._displayURLPrompt):
3077
3078 2012-03-29  Mihai Parparita  <mihaip@chromium.org>
3079
3080         [Chromium] Add sharded ChromiumOS debug bots to builders.js
3081         https://bugs.webkit.org/show_bug.cgi?id=82639
3082
3083         Reviewed by Eric Seidel.
3084
3085         The bots were sharded by http://crrev.com/129613, update builders.js
3086         to reflect this.
3087
3088         * TestResultServer/static-dashboards/builders.js:
3089
3090 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
3091
3092         remove support for junit-style xml output from test-webkitpy
3093         https://bugs.webkit.org/show_bug.cgi?id=82279
3094
3095         Reviewed by Eric Seidel.
3096
3097         This was added when we were looking into integrating w/ Jenkins
3098         rather than buildbot, but I believe that project got shelved, so
3099         this is unused. We can always add it back in later as necessary.
3100
3101         * Scripts/webkitpy/test/main.py:
3102         (Tester._parse_args):
3103         (Tester._run_tests):
3104         * Scritps/webkitpy/thirdparty/__init__.py:
3105
3106 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
3107
3108         new-run-webkit-tests: crashes when it fails to decode a stack trace
3109         https://bugs.webkit.org/show_bug.cgi?id=82673
3110
3111         Unreviewed, build fix.
3112
3113         We are assuming the stdout/stderr output from the driver is utf-8
3114         encoded when we get stack traces; this may not be a valid
3115         assumption generally, but if we do get strings that aren't valid
3116         utf-8, we would crash. Now we will ignore any decoding errors.
3117
3118         * Scripts/webkitpy/layout_tests/port/base.py:
3119         (Port._get_crash_log):
3120         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3121         (PortTestCase.test_get_crash_log):
3122
3123 2012-03-29  Simon Fraser  <simon.fraser@apple.com>
3124
3125         Scripts fail to detect when a tool crashes
3126         https://bugs.webkit.org/show_bug.cgi?id=82659
3127
3128         Reviewed by Mark Rowe.
3129         
3130         Have exitStatus() detect when the process fail to exit cleanly
3131         (possibly because of a crash), and return a non-zero exit code
3132         in that case.
3133
3134         * Scripts/VCSUtils.pm:
3135         (exitStatus):
3136
3137 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3138
3139         [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
3140         https://bugs.webkit.org/show_bug.cgi?id=82581
3141
3142         Reviewed by Martin Robinson.
3143
3144         Running Javascriptcore tests through jhbuild
3145         for consistency with run-webkit-tests and in order to
3146         avoid confusing libraries when facing regressions.
3147
3148         * Scripts/run-javascriptcore-tests:
3149
3150 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
3151
3152         test-webkitpy: add --timing
3153         https://bugs.webkit.org/show_bug.cgi?id=82550
3154
3155         Reviewed by Eric Seidel.
3156
3157         This patch adds a --timing option that will display the time
3158         each test takes. It also removes the --silent option, since
3159         probably no one ever used it, and cleans up the logging
3160         option parsing code to be easier to follow.
3161
3162         * Scripts/webkitpy/test/main.py:
3163         (Tester._parse_args):
3164         (Tester._configure):
3165         * Scripts/webkitpy/test/runner.py:
3166         (TestRunner.write_result):
3167         * Scripts/webkitpy/test/runner_unittest.py:
3168         (RunnerTest.test_regular):
3169         (RunnerTest.test_verbose):
3170         (RunnerTest):
3171         (RunnerTest.test_timing):
3172
3173 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3174
3175         HashMap<>::add should return a more descriptive object
3176         https://bugs.webkit.org/show_bug.cgi?id=71063
3177
3178         Reviewed by Ryosuke Niwa.
3179
3180         Update code to use AddResult instead of a pair.
3181
3182         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3183         (LayoutTestController::evaluateScriptInIsolatedWorld):
3184         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3185         (LayoutTestController::evaluateScriptInIsolatedWorld):
3186         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3187         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
3188
3189 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
3190
3191         Web Inspector: chromium: DRT --no-timeout option doesn't work.
3192         https://bugs.webkit.org/show_bug.cgi?id=82608
3193
3194         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
3195         This was broken by r112354 and the sequence became opposite.
3196
3197         Reviewed by Yury Semikhatsky.
3198
3199         * DumpRenderTree/chromium/TestShell.cpp:
3200         (TestShell::TestShell):
3201         (TestShell::initialize):
3202
3203 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
3204
3205         Remove custom bindings form Internals.idl of attribute type Array.
3206         https://bugs.webkit.org/show_bug.cgi?id=82319
3207
3208         Reviewed by Kentaro Hara.
3209
3210         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
3211
3212         * GNUmakefile.am:
3213
3214 2012-03-28  Mark Rowe  <mrowe@apple.com>
3215
3216         Fix --no-saved-state.
3217
3218         Ignore the flag before Lion, rather than making it specific to Lion.
3219
3220         Rubber-stamped by Dan Bernstein.
3221
3222         * Scripts/webkitdirs.pm:
3223         (argumentsForRunAndDebugMacWebKitApp):
3224
3225 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
3226
3227         Add dtharp to contributors list
3228         https://bugs.webkit.org/show_bug.cgi?id=82545
3229
3230         Reviewed by Adam Barth.
3231
3232         Adding dtharp as Contributor.
3233
3234         * Scripts/webkitpy/common/config/committers.py:
3235
3236 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
3237
3238         build-webkit : the word "pass" is spelled incorrectly as "passs"
3239         https://bugs.webkit.org/show_bug.cgi?id=82532
3240
3241         Reviewed by Julien Chaffraix.
3242
3243         Corrected spelling of the word "pass" in build-webkit.
3244
3245         * Scripts/build-webkit:
3246
3247 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
3248
3249         new-run-webkit-tests doesn't log correctly after retrying failures
3250         https://bugs.webkit.org/show_bug.cgi?id=82541
3251
3252         Unreviewed, build fix.
3253
3254         r112189 introduced a regression where we would accidentally
3255         delete the log handler after we retried any failing tests - that
3256         meant that any log messages around uploading the results got
3257         dropped.
3258
3259         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3260         (Manager._run_tests):
3261
3262 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
3263
3264         [wx] Unreviewed. Build fix, move WTF back into JSCore target
3265         until issues with JSCore not linking in all WTF symbols are resolved.
3266
3267         * waf/build/settings.py:
3268
3269 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
3270
3271         download-built-product build step should detect 404 errors
3272         https://bugs.webkit.org/show_bug.cgi?id=82491
3273
3274         Reviewed by Ryosuke Niwa.
3275         
3276         Pass --fail to curl so that it reports 404 errors.
3277
3278         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3279         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
3280         * BuildSlaveSupport/built-product-archive:
3281         (extractBuiltProduct): Remove trailing whitespace.
3282
3283 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
3284
3285         flakiness dashboard should only keep the last 500 runs
3286         https://bugs.webkit.org/show_bug.cgi?id=82530
3287
3288         Reviewed by Ojan Vafai.
3289
3290         If a bot has an overly large amount of failing tests, then
3291         storing 750 runs' worth takes a lot of memory and CPU time to
3292         process and we end up getting killed by AppEngine; this cases
3293         data corruption and confusion down the road when we have to
3294         retry the upload of the data and the tests show up as multiple
3295         runs.
3296
3297         * TestResultServer/model/jsonresults.py:
3298         (JsonResults.update_file):
3299
3300 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3301
3302         extract-built-product build step should fail if unzipping fails
3303         https://bugs.webkit.org/show_bug.cgi?id=82493
3304
3305         Reviewed by Simon Fraser.
3306
3307         Forward non-zero exit code from subprocesses so that the master can detect any failures
3308         and bail out early.
3309
3310         * BuildSlaveSupport/built-product-archive:
3311         (main):
3312
3313 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
3314
3315         test-webkitpy should support files, directories, and packages as command line args
3316         https://bugs.webkit.org/show_bug.cgi?id=76765
3317
3318         Reviewed by Adam Barth.
3319
3320         This patch adds support for specifying files, directories, and
3321         packages to test-webkitpy along with the already existing
3322         support for modules, test classes, and individual test names.
3323
3324         Also, fix a bug in filesystem_mock where we wouldn't normalize a
3325         path containing a reference to the current directory properly,
3326         for example, '/foo/./bar.py'.
3327
3328         * Scripts/webkitpy/common/system/filesystem_mock.py:
3329         (MockFileSystem.normpath):
3330         * Scripts/webkitpy/test/main.py:
3331         (Tester._configure_logging):
3332         (Tester._run_tests):
3333         * Scripts/webkitpy/test/test_finder.py:
3334         (TestDirectoryTree.find_modules):
3335         (TestDirectoryTree.subpath):
3336         (TestFinder.is_dotted_name):
3337         (TestFinder.find_names):
3338         (TestFinder):
3339         (TestFinder._find_names_for_arg):
3340         (TestFinder._find_in_trees):
3341         (TestFinder._default_names):
3342         * Scripts/webkitpy/test/test_finder_unittest.py:
3343         (TestFinderTest.setUp):
3344         (TestFinderTest.tearDown):
3345         (TestFinderTest.check_names):
3346         (TestFinderTest.test_default_names):
3347         (TestFinderTest):
3348         (TestFinderTest.test_paths):
3349
3350 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
3351
3352         Fix inspector tests when running in internal builds.
3353
3354         <rdar://problem/11050694>
3355
3356         Reviewed by Tim Hatcher.
3357
3358         * DumpRenderTree/mac/DumpRenderTree.mm:
3359         (resetDefaultsToConsistentValues):
3360         * WebKitTestRunner/TestController.cpp:
3361         (WTR::TestController::resetStateToConsistentValues):
3362
3363 2012-03-28  David Kilzer  <ddkilzer@apple.com>
3364
3365         Use xcrun to find nm and ranlib on OS X builds
3366         <http://webkit.org/b/82466>
3367
3368         Reviewed by Dan Bernstein.
3369
3370         * Scripts/build-webkit: Use xcrun to find ranlib.
3371         * Scripts/webkitdirs.pm:
3372         (determineNmPath): Added.  Use xcrun to find nm on OS X.
3373         (nmPath): Added.
3374         * Scripts/webkitperl/features.pm:
3375         (libraryContainsSymbol): Use nmPath().
3376
3377 2012-03-28  Ojan Vafai  <ojan@chromium.org>
3378
3379         Add history navigation to garden-o-matic
3380         https://bugs.webkit.org/show_bug.cgi?id=82495
3381
3382         Reviewed by Dimitri Glazkov.
3383
3384         Also, maintain scroll offsets when returning to a tab. This makes addressing
3385         expected failures considerably easier when dealing with below-the-fold tests.
3386
3387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3388         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
3389         switching.
3390         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
3391         from a file URL and Chrome puts each different file URL in it's own origin.
3392
3393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3394         Remove the href so that clicking on the accordion item does not modify window.location.hash.
3395
3396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3398
3399 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3400
3401         [GTK] generate-gtk-doc doesn't cope with custom build directory
3402         https://bugs.webkit.org/show_bug.cgi?id=82448
3403
3404         Reviewed by Martin Robinson.
3405
3406         Pass the product directory in generate-gtkdoc arguments from
3407         build-webkit.
3408
3409         * Scripts/webkitdirs.pm:
3410         (buildAutotoolsProject):
3411         * gtk/common.py:
3412         (get_build_path):
3413
3414 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3415
3416         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
3417         https://bugs.webkit.org/show_bug.cgi?id=82341
3418
3419         Reviewed by Martin Robinson.
3420
3421         Add --skipped=skip|ignore|only command line option.
3422
3423         * Scripts/run-gtk-tests:
3424         (TestRunner._test_cases_to_skip): Return the list of test cases
3425         to skip for the given test depending on the skipped action.
3426         (TestRunner._should_run_test): Decide whether to run the test or
3427         not depending on the skipped action.
3428         (TestRunner.run_tests): Only show the list of skipped tests when
3429         skipped action is 'skip'.
3430
3431 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3432
3433         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
3434         https://bugs.webkit.org/show_bug.cgi?id=82333
3435
3436         Reviewed by Martin Robinson.
3437
3438         * Scripts/run-gtk-tests:
3439         (TestRunner.SkippedTest): Add SkippedTest class to store more
3440         information about skipped tests.
3441         (TestRunner._setup_testing_environment): Use SkippedTest to add
3442         TestWebKitAccessibility to the skipped list.
3443         (TestRunner._find_skipped_test): Return the SkippedTest object for
3444         a given test path.
3445         (TestRunner._test_cases_to_skip): Returns the list of test cases
3446         that should be skipped for a given test path.
3447         (TestRunner._should_run_test): Helper funtion to decide whether
3448         the given test path should be run or not. Tests in the skipped
3449         list that don't have a list of failing test cases are not run at
3450         all. Tests in the skipped list that contain a list of test cases
3451         are run with gtester -s to skip the individual test cases.
3452         (TestRunner._run_test): Helper funtion to run a given test.
3453         (TestRunner.run_tests): Build the list of tests to run based on
3454         _should_run_test() and use helper function _run_test() to run
3455         every test.
3456
3457 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3458
3459         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
3460         https://bugs.webkit.org/show_bug.cgi?id=52810
3461
3462         Reviewed by Simon Hausmann.
3463
3464         Use SSE2 floating point math on 32 bit instead of the default
3465         387 to make layout test result same on 32 and on 64 bit builds.
3466
3467         * qmake/mkspecs/features/unix/default_post.prf:
3468
3469 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
3470
3471         [Soup] DNS prefetching spams resolver, shoots self in the foot
3472         https://bugs.webkit.org/show_bug.cgi?id=41630
3473
3474         Reviewed by Martin Robinson.
3475
3476         Bump libsoup and glib dependencies.
3477
3478         * efl/jhbuild.modules:
3479         * gtk/jhbuild.modules:
3480
3481 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
3482
3483         [GTK] Disable introspection for jhbuild modules
3484         https://bugs.webkit.org/show_bug.cgi?id=82395
3485
3486         Reviewed by Philippe Normand.
3487
3488         * efl/jhbuild.modules: add --disable-introspection to all modules
3489         that support it
3490         * gtk/jhbuild.modules: ditto.
3491
3492 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3493
3494         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
3495
3496         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3497         (BuildAndTestFactory.__init__):
3498
3499 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3500
3501         [Qt] Unreviewed typo fix after r112383.
3502
3503         * Scripts/run-qtwebkit-tests:
3504         (Main.check_crash_occurences):
3505
3506 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
3507
3508         [Qt] run-qtwebkit-tests should report crashes
3509         https://bugs.webkit.org/show_bug.cgi?id=76905
3510
3511         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
3512         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
3513
3514         Reviewed by Csaba Osztrogonác.
3515
3516         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3517         (RunQtAPITests.commandComplete):
3518         (RunQtAPITests.evaluateCommand):
3519         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3520         (RunQtAPITestsTest):
3521         (test_failure):
3522         (test_crash):
3523         * Scripts/run-qtwebkit-tests:
3524         (Main.announce_results_html):
3525         (Main):
3526         (Main.check_crash_occurences):
3527         (Main.convert_to_stdout):
3528         (Main.convert_to_html):
3529
3530 2012-03-28  Kwonjin Jeong  <gram@company100.net>
3531
3532         Add support for Intel compiler on Linux QT port.
3533         https://bugs.webkit.org/show_bug.cgi?id=81077
3534
3535         Reviewed by Tor Arne Vestbø.
3536
3537         * qmake/mkspecs/features/default_post.prf:
3538         Don't hide symbols when building with Intel compiler.
3539         The symbols are needed when building QtWebKit tests.
3540
3541         * qmake/mkspecs/features/unix/icc.prf:
3542         Added to ignore icc-specific warnings.
3543         This feature is used with command-line arguments for build-webkit script.
3544
3545 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3546
3547         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
3548
3549         * Scripts/update-webkitgtk-libs: This script is written in
3550         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
3551
3552 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3553
3554         kill-old-processes doesn't do anything on linux
3555         https://bugs.webkit.org/show_bug.cgi?id=82388
3556
3557         Reviewed by Tony Chang.
3558
3559         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
3560         This should help stabilizing Chromium linux bots.
3561
3562         * BuildSlaveSupport/kill-old-processes:
3563
3564 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3565
3566         [GTK] jhbuild wrongly tricked into clean-up
3567         https://bugs.webkit.org/show_bug.cgi?id=82216
3568
3569         Reviewed by Gustavo Noronha Silva.
3570
3571         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
3572         build tree. Also when checking if the jhbuild configuration
3573         changed use absolute md5sum paths.
3574
3575         * Scripts/webkitdirs.pm:
3576         (runAutogenForAutotoolsProjectIfNecessary):
3577         (jhbuildConfigurationChanged):
3578         (buildAutotoolsProject):
3579
3580 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3581
3582         kill-old-processes doesn't do anything on linux
3583         https://bugs.webkit.org/show_bug.cgi?id=82388
3584
3585         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
3586
3587         The platform in Factory comes from config.json, accordingly platform is fullplatform,
3588         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
3589
3590         Reviewed by Ryosuke Niwa.
3591
3592         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3593         (Factory.__init__):
3594
3595 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
3596
3597         Make Chromium port for Android use hardware gpu path default.
3598         https://bugs.webkit.org/show_bug.cgi?id=82033
3599
3600         Reviewed by Dirk Pranke.
3601
3602         Skip canvas tests, which are run in virtual gpu test suites.
3603
3604         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3605         (ChromiumAndroidPort.__init__):
3606         (ChromiumAndroidPort.skipped_tests):
3607
3608 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3609
3610         kill-old-processes doesn't do anything on linux
3611         https://bugs.webkit.org/show_bug.cgi?id=82388
3612
3613         Disable kill-old-processes on the Qt bots not to kill each others.
3614
3615         Reviewed by Ryosuke Niwa.
3616
3617         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3618         (Factory.__init__):
3619
3620 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
3621
3622         Handle DRT crash caused by Android OOM.
3623         https://bugs.webkit.org/show_bug.cgi?id=82310
3624
3625         Reviewed by Tony Chang.
3626
3627         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
3628         is stopped silently and regarded as crashed. Re-run the test for
3629         such crash.
3630
3631         Add some debug log to NRWT.
3632
3633         * Scripts/webkitpy/layout_tests/port/chromium.py:
3634         (ChromiumDriver.run_test):
3635         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3636         (ChromiumAndroidPort.__init__):
3637         (ChromiumAndroidPort.get_last_stacktrace):
3638         (ChromiumAndroidDriver.__init__):
3639         (ChromiumAndroidDriver._start):
3640         (ChromiumAndroidDriver.run_test):
3641         (ChromiumAndroidDriver._get_drt_return_value):
3642
3643 2012-03-27  Ojan Vafai  <ojan@chromium.org>
3644
3645         Fix expected results for some unittest failures.
3646
3647         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3648
3649 2012-03-27  Adrienne Walker  <enne@google.com>
3650
3651         [chromium] Fix --enabled-threaded-compositing flag in DRT
3652         https://bugs.webkit.org/show_bug.cgi?id=82405
3653
3654         Reviewed by James Robinson.
3655
3656         --enable-threaded-compositing wasn't working because there was no way
3657         to set the value before it was used in the TestShell constructor.
3658
3659         To avoid adding yet another boolean parameter to TestShell's
3660         constructor, add an explicit initialize function that can operate on
3661         any boolean settings that are set post-constructor.
3662
3663         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3664         (main):
3665         * DumpRenderTree/chromium/TestShell.cpp:
3666         (TestShell::TestShell):
3667         (TestShell::initialize):
3668         * DumpRenderTree/chromium/TestShell.h:
3669         (TestShell):
3670         (TestShell::setTestShellMode):
3671
3672 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
3673
3674         new-run-webkit-tests: suppress debug output from run-safari on results file
3675         https://bugs.webkit.org/show_bug.cgi?id=82400
3676
3677         Reviewed by Ryosuke Niwa.
3678
3679         Send the run-safari output to /dev/null rather than the console.
3680
3681         * Scripts/webkitpy/layout_tests/port/mac.py:
3682         (MacPort.show_results_html_file):
3683
3684 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
3685
3686         Improve error reporting in run-javascriptcore-tests
3687         https://bugs.webkit.org/show_bug.cgi?id=82379
3688
3689         Reviewed by Jessie Berlin.
3690         
3691         When the script dies, have it print out the reason for dying.
3692
3693         * Scripts/run-javascriptcore-tests:
3694
3695 2012-03-27  Eric Seidel  <eric@webkit.org>
3696
3697         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
3698         https://bugs.webkit.org/show_bug.cgi?id=82373
3699
3700         Reviewed by Ryosuke Niwa.
3701
3702         Dave's committer-status in in-progress, so until then
3703         list him as a Contributor so at least I can more easily CC him on bugs.
3704
3705         * Scripts/webkitpy/common/config/committers.py:
3706
3707 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3708
3709         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
3710         https://bugs.webkit.org/show_bug.cgi?id=82252
3711
3712         Reviewed by Gustavo Noronha Silva.
3713
3714         Appending the directory containing common.py may be problematic if
3715         another path in sys.path also contains either a common.py or a
3716         common/ module, so prepend to select our&n