fde753d4e750e08809f680c054929b77e33a2c00
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2
3         garden-o-matic should not report flaking in expected failures as failures.
4         https://bugs.webkit.org/show_bug.cgi?id=70279
5
6         Reviewed by Adam Barth.
7
8         On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
9         For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
10         same for garden-o-matic.
11
12         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
13             rewrote the logic for determining expected or unexpected failures as a central analysis tool.
14         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
15
16 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
17
18         [Gtk] Support for client-based geolocation
19         https://bugs.webkit.org/show_bug.cgi?id=64970
20
21         Reviewed by Martin Robinson.
22
23         Add support for testing client-based geolocation tests in DumpRenderTree.
24
25         * DumpRenderTree/gtk/DumpRenderTree.cpp:
26         (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
27         (createWebView): Create web view after declaring DumpRenderTree mode.
28         That way a mock client for geolocation is used instead of a GeoClue
29         client if a web view is created when testing.
30         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
31         geolocation layout tests.
32         (LayoutTestController::setMockGeolocationPosition):
33         (LayoutTestController::setMockGeolocationError):
34         (LayoutTestController::setGeolocationPermission):
35         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
36         * Scripts/build-webkit: Note that the Gtk port is using client-based
37         geolocation, even though changing this flag has no effect on compilation.
38
39 2011-10-07  Andrey Kosyakov  <caseq@chromium.org>
40
41         [Chromium] suppress console output from DevTools window
42         https://bugs.webkit.org/show_bug.cgi?id=69632
43
44         Reviewed by Pavel Feldman.
45
46         * DumpRenderTree/chromium/TestShell.cpp:
47         (TestShell::showDevTools):
48         * DumpRenderTree/chromium/WebViewHost.cpp:
49         (WebViewHost::didAddMessageToConsole):
50         (WebViewHost::reset):
51         (WebViewHost::setLogConsoleOutput):
52         * DumpRenderTree/chromium/WebViewHost.h:
53
54 2011-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
55
56         Unreviewed, rolling out r97735.
57         http://trac.webkit.org/changeset/97735
58         https://bugs.webkit.org/show_bug.cgi?id=70317
59
60         some people apparently use build-jsc with the qt port without
61         building webkit first (Requested by torarne on #webkit).
62
63         * Scripts/build-webkit:
64         * Scripts/webkitdirs.pm:
65         (buildQMakeProject):
66         (buildQMakeQtProject):
67
68 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
69
70         [Qt] Remove dead code in build-webkit
71
72         build-webkit will iterate over a list of subdirectories to build,
73         but this feature is only used by the Apple ports. For QtWebKit we
74         always pass an empty directory to buildQMakeProject, which makes
75         the logic for dealing with sub-projects in buildQMakeProject just
76         added noise.
77
78         If we do want this feature at some point, we should redo it in
79         the context of the upcoming build system changes for Qt.
80
81         Reviewed by Simon Hausmann.
82
83         * Scripts/build-webkit:
84         * Scripts/webkitdirs.pm:
85         (buildQt):
86
87 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
88
89         Remove traces of Symbian support from the build scripts
90
91         Reviewed by Simon Hausmann.
92
93         * Scripts/build-webkit:
94         * Scripts/webkitdirs.pm:
95         (determineBaseProductDir):
96         (argumentsForConfiguration):
97         (usesPerConfigurationBuildDirectory):
98         (buildQMakeProject):
99
100 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
101
102         Build fix after r97672.
103
104         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
105
106 2011-10-17  Kent Tamura  <tkent@chromium.org>
107
108         A follow-up of r97716.
109         https://bugs.webkit.org/show_bug.cgi?id=68803
110
111         * DumpRenderTree/chromium/LayoutTestController.cpp:
112         (LayoutTestController::reset): Initialize m_dumpCreateView.
113
114 2011-10-17  Jochen Eisinger  <jochen@chromium.org>
115
116         [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
117         https://bugs.webkit.org/show_bug.cgi?id=68803
118
119         Reviewed by Nate Chapin.
120
121         * DumpRenderTree/chromium/LayoutTestController.cpp:
122         (LayoutTestController::LayoutTestController):
123         (LayoutTestController::dumpCreateView):
124         * DumpRenderTree/chromium/LayoutTestController.h:
125         (LayoutTestController::shouldDumpCreateView):
126         * DumpRenderTree/chromium/WebViewHost.cpp:
127         (WebViewHost::createView):
128
129 2011-10-17  Nate Chapin  <japhet@chromium.org>
130
131         Add myself to watchlists, and add a watch
132         for Source/WebCore/loader/.
133         https://bugs.webkit.org/show_bug.cgi?id=70263
134
135         Reviewed by David Levin.
136
137         * Scripts/webkitpy/common/config/watchlist:
138
139 2011-10-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
140
141         [EFL] DRT: Make non-recognized keys work in events as well.
142         https://bugs.webkit.org/show_bug.cgi?id=69860
143
144         Reviewed by Antonio Gomes.
145
146         fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
147         here: it has a select box with a few non-latin options, and one of them
148         is selected via the keyboard.
149
150         In this specific case, we need to make EventHandler::keyEvent send a
151         keyPressEvent to SelectElement, so that
152         SelectElement::defaultEventHandler calls typeAheadFind(). This happens
153         only when PlatformKeyEvent::text() is not empty, which was not the case
154         so far.
155
156         * DumpRenderTree/efl/EventSender.cpp:
157         (keyDownCallback):
158
159 2011-10-17  Alok Priyadarshi  <alokp@chromium.org>
160
161         Add layout tests for WebPlugin compositor path
162         https://bugs.webkit.org/show_bug.cgi?id=69027
163
164         Reviewed by James Robinson.
165
166         * DumpRenderTree/DumpRenderTree.gypi:
167         * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
168         (premultiplyAlpha):
169         (TestWebPlugin::TestWebPlugin):
170         (TestWebPlugin::~TestWebPlugin):
171         (TestWebPlugin::mimeType):
172         (TestWebPlugin::initialize):
173         (TestWebPlugin::destroy):
174         (TestWebPlugin::updateGeometry):
175         (TestWebPlugin::parsePrimitive):
176         (TestWebPlugin::parseColor):
177         (TestWebPlugin::parseOpacity):
178         (TestWebPlugin::initScene):
179         (TestWebPlugin::drawScene):
180         (TestWebPlugin::destroyScene):
181         (TestWebPlugin::initProgram):
182         (TestWebPlugin::initPrimitive):
183         (TestWebPlugin::drawPrimitive):
184         (TestWebPlugin::loadShader):
185         (TestWebPlugin::loadProgram):
186         * DumpRenderTree/chromium/TestWebPlugin.h: Added.
187         (TestWebPlugin::scriptableObject):
188         (TestWebPlugin::paint):
189         (TestWebPlugin::updateFocus):
190         (TestWebPlugin::updateVisibility):
191         (TestWebPlugin::acceptsInputEvents):
192         (TestWebPlugin::handleInputEvent):
193         (TestWebPlugin::didReceiveResponse):
194         (TestWebPlugin::didReceiveData):
195         (TestWebPlugin::didFinishLoading):
196         (TestWebPlugin::didFailLoading):
197         (TestWebPlugin::didFinishLoadingFrameRequest):
198         (TestWebPlugin::didFailLoadingFrameRequest):
199         (TestWebPlugin::Scene::Scene):
200         * DumpRenderTree/chromium/WebViewHost.cpp:
201         (WebViewHost::createPlugin):
202
203 2011-10-17  Ryosuke Niwa  <rniwa@webkit.org>
204
205         [nrwt] Add new category for MISSING
206         https://bugs.webkit.org/show_bug.cgi?id=69990
207
208         Reviewed by Dirk Pranke.
209
210         Treat missing results as a new category in summerize_results.
211
212         Because Chromium port wants to turn bots red when there are tests with missing results,
213         extracted the logic to compute the exit code as exit_code_from_summarized_results in
214         base and chromium ports.
215
216         * Scripts/webkitpy/layout_tests/controllers/manager.py:
217         * Scripts/webkitpy/layout_tests/port/base.py:
218         * Scripts/webkitpy/layout_tests/port/chromium.py:
219         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
220
221 2011-10-17  Dimitri Glazkov  <dglazkov@chromium.org>
222
223         garden-o-matic operations fail because of CSP.
224         https://bugs.webkit.org/show_bug.cgi?id=70249
225
226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
227
228 2011-10-17  Ada Chan  <adachan@apple.com>
229
230         Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
231         https://bugs.webkit.org/show_bug.cgi?id=70168
232
233         Reviewed by Alexey Proskuryakov.
234
235         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
236         (TestWebKitAPI::didFinishLoadForFrame):
237         (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
238
239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
240         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
241         Add the new file.
242
243 2011-10-17  Darin Adler  <darin@apple.com>
244
245         Add some more *.pyc ignores in directories with Python scripts.
246
247         * QueueStatusServer: Added property svn:ignore.
248         * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
249         * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
250         * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
251
252 2011-10-17  Alexis Menard  <alexis.menard@openbossa.org>
253
254         [Qt][WK2][meta] Fix failing API tests
255         https://bugs.webkit.org/show_bug.cgi?id=70236
256
257         Reviewed by Csaba Osztrogonác.
258
259         In order to run WebKit2 API tests we need the WebProcess to be in
260         the path so let's add the bin directory when running the API tests of Qt.
261
262         * Scripts/run-qtwebkit-tests:
263
264 2011-10-17  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
265
266         [Qt][WK2] Build dependency problems
267         https://bugs.webkit.org/show_bug.cgi?id=68456
268
269         Reviewed by Csaba Osztrogonác.
270
271         * Scripts/webkitdirs.pm:
272         (buildQMakeProject):
273
274 2011-10-17  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
275
276         [build] Introduce Qt/SH4 buildbot
277         https://bugs.webkit.org/show_bug.cgi?id=70227
278
279         Reviewed by Adam Roben.
280
281         Add buildslave for Linux/Qt/SH4.
282
283         * BuildSlaveSupport/build.webkit.org-config/config.json:
284
285 2011-10-16  Adam Barth  <abarth@webkit.org>
286
287         Always enable ENABLE(DOM_STORAGE)
288         https://bugs.webkit.org/show_bug.cgi?id=70189
289
290         Reviewed by Eric Seidel.
291
292         * Scripts/build-webkit:
293         * waf/build/settings.py:
294
295 2011-10-15  Adam Barth  <abarth@webkit.org>
296
297         Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
298         https://bugs.webkit.org/show_bug.cgi?id=70194
299
300         Reviewed by Daniel Bates.
301
302         * Scripts/build-webkit:
303
304 2011-10-15  Ojan Vafai  <ojan@chromium.org>
305
306         run-webkit-tests should accept --child-processes
307         https://bugs.webkit.org/show_bug.cgi?id=69713
308
309         Reviewed by Adam Barth.
310
311         Only set --child-processes=1 if --child-processes it not
312         passed on the commandline.
313
314         * Scripts/run-webkit-tests:
315
316 2011-10-15  Daniel Bates  <dbates@webkit.org>
317
318         Extract common gdb code into its own function; Remove script gdb-safari
319         https://bugs.webkit.org/show_bug.cgi?id=68499
320
321         Reviewed by David Kilzer.
322
323         Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
324         runSafari}() and in the script gdb-safari to launch gdb to debug an application.
325         We should extract the common parts into a function that can be shared by all callers
326         so as to remove duplicate code.
327
328         As a side effect of removing duplicate code we can remove the script gdb-safari since
329         its code has been incorporated into webkitdirs::debugSafari() which is called by the
330         script debug-safari.
331
332         * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
333         * Scripts/gdb-safari: Removed.
334         * Scripts/webkitdirs.pm:
335         (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
336         debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
337         script gdb-safari to here.
338         (debugSafari): Added.
339         (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
340         Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
341         runSafari() always returns 1 on Windows and the script run-safari exits using this
342         value as its exit status. Hence, the script run-safari always exits with a nonzero
343         exit status (i.e. abnormal termination) on Windows. Instead, we should return the
344         exit status of the WebKit launcher application.
345         (debugMiniBrowser): Modified to call debugMacWebKitApp().
346         (debugWebKitTestRunner): Ditto.
347
348 2011-10-15  Robert Hogan  <robert@webkit.org>
349
350         [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
351         https://bugs.webkit.org/show_bug.cgi?id=70056
352
353         Reviewed by Adam Barth.
354
355         The preferred file-order for patches is LayoutTests at the end and
356         ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use 
357         it when creating patches for review and landing.
358
359         * Scripts/webkitpy/common/checkout/scm/git.py:
360         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
361         * Scripts/webkitpy/common/config/orderfile: Added.
362
363 2011-10-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
364
365         [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
366         https://bugs.webkit.org/show_bug.cgi?id=69920
367
368         Reviewed by Kenneth Rohde Christiansen.
369
370         * DumpRenderTree/qt/DumpRenderTree.pro:
371         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
372         (WebCore::DumpRenderTree::open):
373         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
374         * QtTestBrowser/QtTestBrowser.pro:
375         * QtTestBrowser/launcherwindow.cpp:
376         (LauncherWindow::screenshot):
377         (LauncherWindow::showFPS):
378         (LauncherWindow::updateFPS):
379         * QtTestBrowser/launcherwindow.h:
380         (WindowOptions::WindowOptions):
381         * QtTestBrowser/mainwindow.cpp:
382         (MainWindow::buildUI):
383         * Scripts/webkitpy/style/checker.py: Remove rules for the
384         WebKit/qt/symbian/platformplugin directory.
385         * Scripts/webkitpy/style/checker_unittest.py:
386         * Tools.pro:
387         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
388         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
389         (WTR::LayoutTestController::platformInitialize):
390         * WebKitTestRunner/qt/TestControllerQt.cpp:
391         (WTR::isExistingLibrary):
392         * WebKitTestRunner/qt/WebKitTestRunner.pro:
393
394 2011-10-15  Adam Barth  <abarth@webkit.org>
395
396         Fix typo in webkitpy help
397         https://bugs.webkit.org/show_bug.cgi?id=70169
398
399         Reviewed by Eric Seidel.
400
401         * Scripts/webkitpy/tool/commands/upload.py:
402
403 2011-10-15  Tony Chang  <tony@chromium.org>
404
405         fix another typo in treemap.html
406         https://bugs.webkit.org/show_bug.cgi?id=70149
407
408         Reviewed by Ojan Vafai.
409
410         Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
411
412         * TestResultServer/static-dashboards/treemap.html:
413
414 2011-10-14  Adam Barth  <abarth@webkit.org>
415
416         Hide status bubbles from queues which are very far behind
417         https://bugs.webkit.org/show_bug.cgi?id=70133
418
419         Reviewed by Eric Seidel.
420
421         The mac-ews is so far behind that we shouldn't show its status bubble.
422         The status bubble just makes contributors sad.
423
424         * QueueStatusServer/handlers/statusbubble.py:
425
426 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
427
428         Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
429         https://bugs.webkit.org/show_bug.cgi?id=70143
430
431         Reviewed by Adam Barth.
432
433         * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
434         * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
435
436 2011-10-14  David Levin  <levin@chromium.org>
437
438         watchlist: Add a validation check for the email names in the list.
439         https://bugs.webkit.org/show_bug.cgi?id=70154
440
441         Reviewed by Adam Barth.
442
443         If an email is listed which doesn't have a bugzilla log in, then any emails
444         added to the bug along with that email will fail to happen, so try to prevent this
445         from happening by validating that emails added to the watchlist are known to be
446         contributors.
447
448         * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
449         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
450         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
451
452 2011-10-14  David Levin  <levin@chromium.org>
453
454         watchlist: If the style check fails, then the watchlist will not be run.
455         https://bugs.webkit.org/show_bug.cgi?id=69484
456
457         Reviewed by Adam Barth.
458
459         * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
460         if the style part fails and don't allow watch list failures turn the
461         bot run red.
462         * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
463         * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
464
465 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
466
467         Plumb style-checker filter up to command options and make land-cowboy use it.
468         https://bugs.webkit.org/show_bug.cgi?id=70119
469
470         Reviewed by Adam Barth.
471
472         * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
473         * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
474         * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
475         * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
476         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
477         * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
478         * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
479
480 2011-10-14  Sam Weinig  <sam@webkit.org>
481
482         Remove the Leopard slaves.
483
484         Reviewed by Adam Roben.
485
486         * BuildSlaveSupport/build.webkit.org-config/config.json:
487
488 2011-10-14  Peter Beverloo  <peter@chromium.org>
489
490         [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
491         https://bugs.webkit.org/show_bug.cgi?id=70028
492
493         Reviewed by Adam Barth.
494
495         * Scripts/update-webkit-chromium:
496         * Scripts/webkitdirs.pm:
497         (buildChromiumMakefile):
498         (buildChromium):
499
500 2011-10-14  Leandro Pereira  <leandro@profusion.mobi>
501
502         Unreviewed; add missing #includes.
503
504         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
505         * DumpRenderTree/efl/EventSender.cpp:
506
507 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
508
509         [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
510         https://bugs.webkit.org/show_bug.cgi?id=69770
511
512         Reviewed by Antonio Gomes.
513
514         We were just appending the given URL to the absolute URI of the main
515         frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
516         instead of "file:///foo/bar/theother/url.html".
517
518         This should make fast/dom/navigation-type-navigate.html behave
519         better (it still fails, but later).
520
521         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
522         (LayoutTestController::queueLoad):
523
524 2011-10-13  Arko Saha  <arko@motorola.com>
525
526         Microdata: Basic implementation of document.getItems() method.
527         https://bugs.webkit.org/show_bug.cgi?id=68610
528
529         Reviewed by Ryosuke Niwa.
530
531         Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
532         Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
533
534         * Scripts/build-webkit:
535
536 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
537
538         new-run-webkit-tests does not support qt-4.8 results
539         https://bugs.webkit.org/show_bug.cgi?id=64071
540
541         Roll-back second part of r97252. :)
542
543         * Scripts/webkitpy/layout_tests/port/qt.py:
544
545 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
546
547         [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
548         https://bugs.webkit.org/show_bug.cgi?id=70106
549
550         Reviewed by Antonio Gomes.
551
552         OwnFastMallocPtr was being used as a smart pointer that automatically called
553         free() on the strings returned by the EFL or by ewk.
554
555         However, when WTF is built in release mode, it uses its own memory management
556         code instead of using the system malloc(), free() and friends. This means bad
557         things will happen when one uses WTF's free() on memory allocated with system
558         malloc() by the EFL or ewk.
559
560         The easiest way to solve this is to call free() ourselves.
561
562         * DumpRenderTree/efl/DumpRenderTree.cpp:
563         (dumpFramesAsText):
564         (getFinalTestURL):
565
566 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
567
568         [EFL] Add DumpRenderTreeSupportEfl
569         https://bugs.webkit.org/show_bug.cgi?id=68458
570
571         Reviewed by Kenneth Rohde Christiansen.
572
573         Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
574
575         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
576         (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
577         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
578         (DumpRenderTreeChrome::onWindowObjectCleared):
579         (DumpRenderTreeChrome::onDocumentLoadFinished):
580         * DumpRenderTree/efl/GCControllerEfl.cpp:
581         (GCController::collect):
582         (GCController::collectOnAlternateThread):
583         (GCController::getJSObjectCount):
584         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
585         (LayoutTestController::counterValueForElementById):
586         (LayoutTestController::pageNumberForElementById):
587         (LayoutTestController::numberOfPages):
588         (LayoutTestController::workerThreadCount):
589         (LayoutTestController::findString):
590         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
591         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
592         (LayoutTestController::sampleSVGAnimationForElementAtTime):
593         (LayoutTestController::numberOfActiveAnimations):
594         (LayoutTestController::suspendAnimations):
595         (LayoutTestController::resumeAnimations):
596         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
597         (createBitmapContextFromWebView):
598
599 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
600
601         [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
602
603         Unreviewed.
604
605         * Scripts/run-webkit-tests:
606         (useNewRunWebKitTests):
607
608 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
609
610         new-run-webkit-tests does not support qt-4.8 results
611         https://bugs.webkit.org/show_bug.cgi?id=64071
612
613         Roll-back r97252 with unit test fix.
614
615         Reviewed by Csaba Osztrogonác.
616
617         * Scripts/webkitpy/layout_tests/port/qt.py:
618         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
619
620 2011-10-13  Ojan Vafai  <ojan@chromium.org>
621
622         Make filter-build-webkit exit 1 if the build fails.
623         https://bugs.webkit.org/show_bug.cgi?id=70080
624
625         Reviewed by Eric Seidel.
626
627         This only works if you redirect stderr to stdout, but it at least makes it possible.
628         This is useful if you want to run a followup command (e.g. run-webkit-tests) but
629         only if the build succeeds.
630
631         * Scripts/filter-build-webkit:
632
633 2011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
634
635         land-cowboy should at least check style.
636         https://bugs.webkit.org/show_bug.cgi?id=70073
637
638         Reviewed by Adam Barth.
639
640         * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
641
642 2011-10-13  Tony Chang  <tony@chromium.org>
643
644         fix regex in layout test times dashboard
645         https://bugs.webkit.org/show_bug.cgi?id=70059
646
647         This fixes the treemapfocus query param.
648
649         Reviewed by Ojan Vafai.
650
651         * TestResultServer/static-dashboards/treemap.html:
652
653 2011-10-13  Beth Dakin  <bdakin@apple.com>
654
655         https://bugs.webkit.org/show_bug.cgi?id=70050
656         DRT and WRT should have HiDPI testing capabilities
657
658         Reviewed by Darin Adler.
659
660         New layoutTestController function setBackingScaleFactor takes a double for a scale 
661         factor and a callback function to call once the backing scale factor has 
662         successfully been set for the view.
663         * DumpRenderTree/LayoutTestController.cpp:
664         (setBackingScaleFactorCallback):
665         (LayoutTestController::staticFunctions):
666
667         On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other 
668         platforms do nothing.
669         * DumpRenderTree/LayoutTestController.h:
670         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
671         (LayoutTestController::setBackingScaleFactor):
672         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
673         (LayoutTestController::setBackingScaleFactor):
674         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
675         (LayoutTestController::setBackingScaleFactor):
676
677         Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a 
678         value of 0, which resets to the system default.
679         * DumpRenderTree/mac/DumpRenderTree.mm:
680         (resetWebViewToConsistentStateBeforeTesting):
681
682         When generating the pixel dump, create a Bitmap of the appropriate size based on 
683         the backing scale factor. If it is a HiDPI view, paint into the context using 
684         displayRectIgnoringOpacity.
685         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
686         (createBitmapContextFromWebView):
687
688         And now the same stuff for WK2. Again, new layoutTestController function 
689         setBackingScaleFactor takes a double for a scale factor and a callback function. 
690         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
691         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
692         (WTR::LayoutTestController::setBackingScaleFactor):
693         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
694         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
695
696         The InjectedBundle sends a message to the UI process to set the backing scale 
697         factor. It also processes a message the UI process will send back once it 
698         completes this task, and at that time, the InjectedBundle calls the callback.
699         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
700         (WTR::InjectedBundle::didReceiveMessage):
701         (WTR::InjectedBundle::postSetBackingScaleFactor):
702         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
703
704         Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor 
705         with a value of 0, which resets to the system default.
706         * WebKitTestRunner/TestController.cpp:
707         (WTR::TestController::resetStateToConsistentValues):
708
709         Upon receiving the SetBackingScaleFactor message, call 
710         WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message 
711         back to InjectedBundle to say it has been done.
712         * WebKitTestRunner/TestInvocation.cpp:
713         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
714         
715         Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a 
716         window's scale factor so we have to avoid that.
717         * WebKitTestRunner/cg/TestInvocationCG.cpp:
718         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
719
720 2011-10-13  John Knottenbelt  <jknotten@chromium.org>
721
722         [Chromium] Allow building without speech input enabled.
723         https://bugs.webkit.org/show_bug.cgi?id=69867
724
725         Reviewed by Darin Fisher.
726
727         * DumpRenderTree/chromium/LayoutTestController.cpp:
728         (LayoutTestController::addMockSpeechInputResult):
729
730 2011-10-13  Kent Tamura  <tkent@chromium.org>
731
732         [Chromium] A DRT fix for r97348.
733
734         * DumpRenderTree/chromium/LayoutTestController.cpp:
735         (LayoutTestController::overridePreference):
736         Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
737         print an error message.
738
739 2011-10-12  Lucas Forschler  <lforschler@apple.com>
740
741         Update kill-old-processes logic.
742         https://bugs.webkit.org/show_bug.cgi?id=63651
743
744         Reviewed by Ryosuke Niwa.
745
746         Remove unused mac platform specific folder.
747         Update master.config to use new kill-old-processes.
748
749         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
750         * BuildSlaveSupport/kill-old-processes:
751         * BuildSlaveSupport/mac: Removed.
752
753 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
754
755         [NRWT] New tests without expected files are reported as flakey tests
756         https://bugs.webkit.org/show_bug.cgi?id=67268
757
758         Reviewed by Dirk Pranke.
759
760         The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
761         and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
762         for missing results in retry_summary.
763
764         Fixed the bug by treating missing results separately.
765
766         * Scripts/webkitpy/layout_tests/controllers/manager.py:
767         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
768
769 2011-10-12  Adam Barth  <abarth@webkit.org>
770
771         Remove ENABLE(XHTMLMP) and associated code
772         https://bugs.webkit.org/show_bug.cgi?id=69729
773
774         Reviewed by David Levin.
775
776         * Scripts/build-webkit:
777         * Scripts/old-run-webkit-tests:
778         * Scripts/webkitperl/features.pm:
779         * Scripts/webkitpy/layout_tests/port/webkit.py:
780         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
781
782 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
783
784         Kill old run-webkit-tests processes in kill-process on Mac
785         https://bugs.webkit.org/show_bug.cgi?id=69976
786
787         Reviewed by Dirk Pranke.
788
789         Add a system call to remove all python processes running run-webkit-tests.
790
791         * BuildSlaveSupport/kill-old-processes:
792         * BuildSlaveSupport/mac: Removed.
793
794 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
795
796         Many WK2 snapshots are blank
797         https://bugs.webkit.org/show_bug.cgi?id=69953
798
799         Reviewed by Beth Dakin.
800         
801         Two fixes:
802         1. negating a size_t in CGContextTranslateCTM() fails, because
803         size_t is unsigned. Fix by casing to CGFloat before negation.
804         
805         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
806         Autodisplay is necessary to kick off Core Animation rendering.
807
808         * WebKitTestRunner/cg/TestInvocationCG.cpp:
809         (WTR::createCGContextFromImage):
810         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
811         (WTR::PlatformWebView::PlatformWebView):
812
813 2011-10-12  Adam Barth  <abarth@webkit.org>
814
815         commit-queue doesn't have a friendly error message when the reviewer line is messed up
816         https://bugs.webkit.org/show_bug.cgi?id=69979
817
818         Reviewed by Eric Seidel.
819
820         Rather than combining the ChangeLog validation with a more complicated
821         command, this patch has the commit-queue run it as a separate command,
822         which will give us more control over the error message.
823
824         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
825         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
826         * Scripts/webkitpy/tool/commands/download.py:
827         * Scripts/webkitpy/tool/commands/queues_unittest.py:
828         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
829         * Scripts/webkitpy/tool/steps/validatereviewer.py:
830
831 2011-10-12  Eric Seidel  <eric@webkit.org>
832
833         Layout tests asserting in LayoutTestController::pathToLocalResource()
834         https://bugs.webkit.org/show_bug.cgi?id=69898
835
836         Reviewed by Simon Fraser.
837
838         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
839
840         * Scripts/old-run-webkit-tests:
841         (openDumpTool):
842
843 2011-10-12  Adam Barth  <abarth@webkit.org>
844
845         The commit-queue doesn't tell me which tests my patch broke
846         https://bugs.webkit.org/show_bug.cgi?id=69975
847
848         Reviewed by Eric Seidel.
849
850         We now print the list of newly failing tests, like we do for the EWS.
851
852         * Scripts/webkitpy/tool/commands/queues.py:
853         * Scripts/webkitpy/tool/commands/queues_unittest.py:
854
855 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
856
857         Added myself as a committer.
858
859         * Scripts/webkitpy/common/config/committers.py:
860
861 2011-10-12  Adam Barth  <abarth@webkit.org>
862
863         _run_tests is a confusing variable name in webkitpy
864         https://bugs.webkit.org/show_bug.cgi?id=69971
865
866         Reviewed by Eric Seidel.
867
868         Eric and I thought this was a function.
869
870         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
871
872 2011-10-12  Tony Chang  <tony@chromium.org>
873
874         Fix test-webkitpy after r97307 and r97293.
875
876         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
877           is None during tests so add back the check.
878         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
879           output directory is now build/Debug.
880
881 2011-10-12  Tony Chang  <tony@chromium.org>
882
883         [chromium] remove old build dirs on chromium-win
884         https://bugs.webkit.org/show_bug.cgi?id=69961
885
886         Reviewed by Adam Barth.
887
888         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
889           always in build and never in chrome or webkit.
890
891 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
892
893         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
894         https://bugs.webkit.org/show_bug.cgi?id=69954
895
896         Also renamed the action and associated event name to address an FIXME.
897
898         Reviewed by Adam Barth.
899
900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
903
904 2011-10-12  Tony Chang  <tony@chromium.org>
905
906         stop spamming 'stopping test driver timed out, killing it' when running rwt
907         https://bugs.webkit.org/show_bug.cgi?id=69938
908
909         Reviewed by Adam Barth.
910
911         In http://trac.webkit.org/changeset/95875 , we made the timeout for
912         stopping the driver based on time_out_ms, but we based it on the wrong
913         default times.
914
915         * Scripts/webkitpy/layout_tests/port/chromium.py:
916
917 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
918
919         3D transforms are flattened in WebKit2 snapshots
920         https://bugs.webkit.org/show_bug.cgi?id=68276
921
922         Reviewed by Adam Roben.
923         
924         Fix WKImage leak noticed by Adam.
925
926         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
927         (WTR::PlatformWebView::windowSnapshotImage):
928
929 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
930
931         garden-o-matic should color-code test failure types.
932         https://bugs.webkit.org/show_bug.cgi?id=69945
933
934         Reviewed by Adam Barth.
935
936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
937         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
939         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
940
941 2011-10-12  Adam Barth  <abarth@webkit.org>
942
943         webkitpy tests are failing on Mac bots
944         https://bugs.webkit.org/show_bug.cgi?id=69929
945
946         Reviewed by Simon Fraser.
947
948         Admit that Lion exists.
949
950         * Scripts/webkitpy/layout_tests/port/chromium.py:
951         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
952
953 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
954
955         Improve output of run-api-tests to make time-outs more obvious
956         https://bugs.webkit.org/show_bug.cgi?id=69788
957
958         Reviewed by Adam Roben.
959         
960         List the tests that failed and timed out at the bottom of the output,
961         if run with --verbose.
962
963         * Scripts/run-api-tests:
964         (runAllTests):
965         (runTest):
966
967 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
968
969         Unreviewed, rolling out r97252.
970         http://trac.webkit.org/changeset/97252
971         https://bugs.webkit.org/show_bug.cgi?id=69944
972
973         Broke test-webkpy (Requested by abarth on #webkit).
974
975         * Scripts/webkitpy/layout_tests/port/qt.py:
976         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
977
978 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
979
980         new-run-webkit-tests does not support qt-4.8 results
981         https://bugs.webkit.org/show_bug.cgi?id=64071
982
983         Reviewed by Csaba Osztrogonác.
984
985         * Scripts/webkitpy/layout_tests/port/qt.py:
986         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
987
988 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
989
990         [GTK] [WebKit2] Make adding another unit test easier
991         https://bugs.webkit.org/show_bug.cgi?id=69409
992
993         Reviewed by Gustavo Noronha Silva.
994
995         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
996         new WebKit2 tests.
997
998 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
999
1000         [WebSocket] update pywebsocket to 0.6b6.
1001         https://bugs.webkit.org/show_bug.cgi?id=69824
1002
1003         Reviewed by Kent Tamura.
1004
1005         WebKit supports WebSocket with version 8 based protocol for now.
1006         We should update its protocol to version 13 based one like hybi-17.
1007         pywebsocket 0.6b6 supports both of version 8 and 13.
1008
1009         * Scripts/webkitpy/thirdparty/__init__.py:
1010
1011 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
1012
1013         WebKitTestRunner needs to link with WebKit for NSURL category methods
1014         https://bugs.webkit.org/show_bug.cgi?id=69892
1015
1016         Reviewed by Sam Weinig.
1017         
1018         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
1019         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
1020         WebKit.framework to fix this.
1021
1022         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1023
1024 2011-10-11  Adam Barth  <abarth@webkit.org>
1025
1026         sheriffbot takes too long to acknowledge rollout commands
1027         https://bugs.webkit.org/show_bug.cgi?id=69871
1028
1029         Reviewed by Eric Seidel.
1030
1031         We used to update the working copy before acknowledging the command
1032         because we wanted to ping all the relevant IRC nicks.  That's caused a
1033         bunch of frustration because folks don't know whether the bot has heard
1034         their commands.
1035
1036         This patch makes the bot reply immediately before updating the working
1037         copy.  All the relevenat folks are still pinged when the bot finishes
1038         preparing the rollout.
1039
1040         * Scripts/webkitpy/tool/bot/irc_command.py:
1041         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1042
1043 2011-10-11  Adam Barth  <abarth@webkit.org>
1044
1045         test-webkitpy fails on Lion
1046         https://bugs.webkit.org/show_bug.cgi?id=69873
1047
1048         Reviewed by Eric Seidel.
1049
1050         This patch fixes one of the two failures.  I'll need to track down the
1051         other failure another time.
1052
1053         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1054
1055 2011-10-11  Adam Barth  <abarth@webkit.org>
1056
1057         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
1058         https://bugs.webkit.org/show_bug.cgi?id=65230
1059
1060         Reviewed by Dimitri Glazkov.
1061
1062         This patch causes us to treat crashed or hung run-webkit-tests runs
1063         similarly to how we treat compile failures.  In some sense, they're
1064         similar because they prevent us from getting test coverage.
1065
1066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1068
1069 2011-10-11  Adam Barth  <abarth@webkit.org>
1070
1071         Failing builder display in garden-o-matic should have the same visual style as the failure grid
1072         https://bugs.webkit.org/show_bug.cgi?id=69876
1073
1074         Reviewed by Dimitri Glazkov.
1075
1076         This patch generalizes the view we use for failing builders in the
1077         FailureGrid so that we can use it for the list of builders that aren't
1078         compiling.
1079
1080         One downside of this patch is that it makes it harder to tell when
1081         debug builders are failing (as opposed to release builders) because
1082         that information isn't presented in this view.  A future patch will
1083         improve this aspect.
1084
1085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1091
1092 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
1093
1094         Some API tests are timing out in Release
1095         https://bugs.webkit.org/show_bug.cgi?id=69787
1096
1097         Reviewed by Mark Rowe.
1098         
1099         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
1100         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
1101
1102         * TestWebKitAPI/Configurations/Base.xcconfig:
1103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1104         * TestWebKitAPI/config.h:
1105
1106 2011-10-11  Adam Barth  <abarth@webkit.org>
1107
1108         garden-o-matic links to flakiness dashboard should open in a new tab
1109         https://bugs.webkit.org/show_bug.cgi?id=69864
1110
1111         Reviewed by Dimitri Glazkov.
1112
1113         This bug was obvious in the first five minutes of using this new
1114         feature.  :)
1115
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1118
1119 2011-10-11  Adam Barth  <abarth@webkit.org>
1120
1121         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
1122         that * doesn't really mean "all".  I've emailed the W3C working group
1123         about changing the spec.
1124
1125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1126
1127 2011-10-11  Adam Barth  <abarth@webkit.org>
1128
1129         garden-o-matic should link to the flakiness dashboard
1130         https://bugs.webkit.org/show_bug.cgi?id=69862
1131
1132         Reviewed by Dimitri Glazkov.
1133
1134         The flakiness dashboard has lots of great information about the failure
1135         history of each test.  This patch adds a link from garden-o-matic to
1136         the flakiness dashboard so the gardener can look at this information.
1137
1138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1139         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1140         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1141
1142 2011-10-11  David Levin  <levin@chromium.org>
1143
1144         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
1145         https://bugs.webkit.org/show_bug.cgi?id=69789
1146
1147         Reviewed by Eric Seidel.
1148
1149         Made the signature of _assertRaisesRegexp match that of Python 2.7.
1150
1151         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
1152         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
1153         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
1154         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
1155
1156 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
1157
1158         [EFL] DRT: Do not abort() when an unknown key is pressed.
1159         https://bugs.webkit.org/show_bug.cgi?id=69856
1160
1161         Reviewed by Antonio Gomes.
1162
1163         A lot of tests crash due to the previous behaviour. Just using the
1164         received name of the pressed key works most of the time, and when it
1165         does not the failing tests should tell us.
1166
1167         * DumpRenderTree/efl/EventSender.cpp:
1168         (keyPadNameFromJSValue):
1169         (keyNameFromJSValue):
1170         (keyDownCallback):
1171
1172 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1173
1174         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
1175         https://bugs.webkit.org/show_bug.cgi?id=68016
1176
1177         Reviewed by Chang Shu.
1178
1179         * Scripts/webkitpy/layout_tests/port/qt.py:
1180
1181 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
1182
1183         [EFL] DRT: Return the right window count in LayoutTestController.
1184         https://bugs.webkit.org/show_bug.cgi?id=69764
1185
1186         Reviewed by Antonio Gomes.
1187
1188         Follow-up to r96943: now that we have DumpRenderTreeChrome and
1189         DumpRenderTreeView in the tree, we can correctly count the number of
1190         open windows in DRT.
1191
1192         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1193         (LayoutTestController::windowCount):
1194
1195 2011-10-11  Jer Noble  <jer.noble@apple.com>
1196
1197         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
1198         https://bugs.webkit.org/show_bug.cgi?id=69800
1199
1200         Reviewed by Csaba Osztrogonác.
1201
1202         Enable WEB_AUDIO at runtime.
1203
1204         * DumpRenderTree/mac/DumpRenderTree.mm:
1205         (resetDefaultsToConsistentValues):
1206
1207 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
1208
1209         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
1210         https://bugs.webkit.org/show_bug.cgi?id=69769
1211
1212         Reviewed by Antonio Gomes.
1213
1214         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1215         (LayoutTestController::setIconDatabaseEnabled):
1216
1217 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1218
1219         [Qt] Remove all references to QTDIR_build and standalone_package
1220
1221         Qt is now modularized, which means we no longer import WebKit into
1222         the Qt source tree. Instead we use git submodules, and building
1223         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
1224
1225         To decrease the number of buildsystem configurations we also remove
1226         the standalone_package code-path used when we were providing tarballs
1227         with the derived sources pre-generated.
1228
1229         Reviewed by Simon Hausmann.
1230
1231         * MiniBrowser/qt/MiniBrowser.pro:
1232         * QtTestBrowser/QtTestBrowser.pro:
1233         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1234
1235 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
1236
1237         Update Chromium accessibility support in DRT.
1238         https://bugs.webkit.org/show_bug.cgi?id=69676
1239
1240         Reviewed by Chris Fleizach.
1241
1242         Adds several missing properties and methods to enable more
1243         tests to pass, and in particular adds support for notification
1244         callbacks.
1245
1246         * DumpRenderTree/chromium/AccessibilityController.cpp:
1247         (AccessibilityController::AccessibilityController):
1248         (AccessibilityController::reset):
1249         (AccessibilityController::getFocusedElement):
1250         (AccessibilityController::shouldLogAccessibilityEvents):
1251         (AccessibilityController::notificationReceived):
1252         (AccessibilityController::logAccessibilityEventsCallback):
1253         * DumpRenderTree/chromium/AccessibilityController.h:
1254         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1255         (getHelpText):
1256         (getStringValue):
1257         (getOrientation):
1258         (AccessibilityUIElement::AccessibilityUIElement):
1259         (AccessibilityUIElement::getChildAtIndex):
1260         (AccessibilityUIElement::isEqual):
1261         (AccessibilityUIElement::notificationReceived):
1262         (AccessibilityUIElement::roleGetterCallback):
1263         (AccessibilityUIElement::titleGetterCallback):
1264         (AccessibilityUIElement::descriptionGetterCallback):
1265         (AccessibilityUIElement::helpTextGetterCallback):
1266         (AccessibilityUIElement::stringValueGetterCallback):
1267         (AccessibilityUIElement::xGetterCallback):
1268         (AccessibilityUIElement::yGetterCallback):
1269         (AccessibilityUIElement::widthGetterCallback):
1270         (AccessibilityUIElement::heightGetterCallback):
1271         (AccessibilityUIElement::intValueGetterCallback):
1272         (AccessibilityUIElement::minValueGetterCallback):
1273         (AccessibilityUIElement::maxValueGetterCallback):
1274         (AccessibilityUIElement::childrenCountGetterCallback):
1275         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
1276         (AccessibilityUIElement::selectedTextRangeGetterCallback):
1277         (AccessibilityUIElement::isEnabledGetterCallback):
1278         (AccessibilityUIElement::isRequiredGetterCallback):
1279         (AccessibilityUIElement::isFocusedGetterCallback):
1280         (AccessibilityUIElement::isFocusableGetterCallback):
1281         (AccessibilityUIElement::isSelectedGetterCallback):
1282         (AccessibilityUIElement::isSelectableGetterCallback):
1283         (AccessibilityUIElement::isMultiSelectableGetterCallback):
1284         (AccessibilityUIElement::isExpandedGetterCallback):
1285         (AccessibilityUIElement::isCheckedGetterCallback):
1286         (AccessibilityUIElement::isVisibleGetterCallback):
1287         (AccessibilityUIElement::isOffScreenGetterCallback):
1288         (AccessibilityUIElement::isCollapsedGetterCallback):
1289         (AccessibilityUIElement::hasPopupGetterCallback):
1290         (AccessibilityUIElement::isValidGetterCallback):
1291         (AccessibilityUIElement::orientationGetterCallback):
1292         (AccessibilityUIElement::showMenuCallback):
1293         (AccessibilityUIElement::pressCallback):
1294         (AccessibilityUIElement::isEqualCallback):
1295         (AccessibilityUIElement::addNotificationListenerCallback):
1296         (AccessibilityUIElement::removeNotificationListenerCallback):
1297         (AccessibilityUIElement::takeFocusCallback):
1298         (AccessibilityUIElement::fallbackCallback):
1299         (RootAccessibilityUIElement::getChildAtIndex):
1300         (AccessibilityUIElementList::getOrCreate):
1301         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1302         * DumpRenderTree/chromium/CppVariant.cpp:
1303         (CppVariant::invokeDefault):
1304         * DumpRenderTree/chromium/CppVariant.h:
1305         * DumpRenderTree/chromium/LayoutTestController.cpp:
1306         (LayoutTestController::LayoutTestController):
1307         (LayoutTestController::reset):
1308         * DumpRenderTree/chromium/LayoutTestController.h:
1309         * DumpRenderTree/chromium/WebViewHost.cpp:
1310         (WebViewHost::postAccessibilityNotification):
1311
1312 2011-10-10  Adam Klein  <adamk@chromium.org>
1313
1314         Support Distributed-CompileC as an action name in filter-build-webkit
1315         https://bugs.webkit.org/show_bug.cgi?id=69783
1316
1317         Reviewed by Ojan Vafai.
1318
1319         * Scripts/filter-build-webkit:
1320
1321 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
1322
1323         3D transforms are flattened in WebKit2 snapshots
1324         https://bugs.webkit.org/show_bug.cgi?id=68276
1325
1326         Reviewed by Anders Carlsson.
1327         
1328         Use a snapshot of the window, rather than an image from the web process
1329         for pixel testing in WebKitTestRunner. This correctly captures compositing
1330         layers, so works for 3D transform tests.
1331
1332         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
1333         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1334         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
1335         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
1336         use that instead of the image we get from the web process.
1337         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1338         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
1339         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1340         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
1341         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1342         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
1343         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1344         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
1345
1346 2011-10-10  David Levin  <levin@chromium.org>
1347
1348         Quick fix for watchlist unit test failures when using Python 2.7+
1349         Reviewed by Adam Barth.
1350
1351         Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
1352         better fix.
1353
1354         * Scripts/webkitpy/common/webkitunittest.py: Always use our
1355         version of assertRaisesRegexp.
1356
1357 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1358
1359         Unreviewed, rolling out r97082.
1360         http://trac.webkit.org/changeset/97082
1361         https://bugs.webkit.org/show_bug.cgi?id=69784
1362
1363         broke Windows build (Requested by smfr on #webkit).
1364
1365         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1366         * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
1367         (WTR::createCGContextFromImage):
1368         (WTR::computeMD5HashStringForContext):
1369         (WTR::dumpBitmap):
1370         (WTR::paintRepaintRectOverlay):
1371         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1372         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1373         (WTR::PlatformWebView::PlatformWebView):
1374
1375 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
1376
1377         3D transforms are flattened in WebKit2 snapshots
1378         https://bugs.webkit.org/show_bug.cgi?id=68276
1379
1380         Reviewed by Anders Carlsson.
1381         
1382         The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
1383         flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
1384         the window when doing pixel tests.
1385         
1386         Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
1387
1388         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
1389         * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
1390         (WTR::createBitmapCGContext): Utility function to create a bitmap context.
1391         (WTR::computeMD5HashStringForContext):
1392         (WTR::dumpBitmap):
1393         (WTR::paintRepaintRectOverlay):
1394         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
1395         grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
1396         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1397         (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
1398         We need the window to autodisplay for Core Animation to render layers and start animations.
1399
1400 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
1401
1402         WebKitTestRunner needs layoutTestController.setWindowIsKey
1403         https://bugs.webkit.org/show_bug.cgi?id=42688
1404
1405         Reviewed by Anders Carlsson.
1406
1407         Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
1408         This sets a flag that the platform layer uses to indicate that
1409         the window is the key window, which fixes focus ring drawing
1410         in pixel results.
1411         
1412         Also focus the web view when we get a 'didCommitLoad' for the main
1413         frame, as DumpRenderTree does.
1414
1415         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1416         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1417         (WTR::InjectedBundle::postSetWindowIsKey):
1418         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1419         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1420         (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
1421         (WTR::LayoutTestController::addChromeInputField):
1422         (WTR::LayoutTestController::removeChromeInputField):
1423         (WTR::LayoutTestController::focusWebView):
1424         (WTR::LayoutTestController::setWindowIsKey):
1425         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
1426         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
1427         (WTR::LayoutTestController::callFocusWebViewCallback):
1428         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1429         * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
1430         so that we can override -isKeyWindow. Use a boolean member variable
1431         to track window key status.
1432         (WTR::PlatformWebView::setWindowIsKey):
1433         (WTR::PlatformWebView::windowIsKey):
1434         * WebKitTestRunner/TestController.cpp:
1435         (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
1436         (WTR::closeOtherPage): Use the same cast as other functions.
1437         (WTR::focus): Implement to call setWindowIsKey(true)
1438         (WTR::unfocus): Implement to call setWindowIsKey(false)
1439         (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
1440         (WTR::TestController::initialize):
1441         (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
1442         * WebKitTestRunner/TestController.h:
1443         * WebKitTestRunner/TestInvocation.cpp:
1444         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1445         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1446         (WTR::PlatformWebView::PlatformWebView):
1447         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1448         (-[WebKitTestRunnerWindow isKeyWindow]):
1449         (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
1450         (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
1451         (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
1452         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1453         (WTR::PlatformWebView::PlatformWebView):
1454         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1455         (WTR::PlatformWebView::PlatformWebView):
1456
1457 2011-10-10  Raphael Kubo da Costa  <kubo@profusion.mobi>
1458
1459         check-webkit-style: Add readability exception for Ewk_* data types.
1460         https://bugs.webkit.org/show_bug.cgi?id=69763
1461
1462         Reviewed by David Levin.
1463
1464         Many EFL-related files (such as EditorClientEfl.h or
1465         DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
1466         struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
1467         check-webkit-style.
1468
1469         Add an exception for them, just like there are exceptions for
1470         Evas_*, Ecore_* and others.
1471
1472         * Scripts/webkitpy/style/checkers/cpp.py:
1473         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1474
1475 2011-10-10  Dominic Mazzoni  <dmazzoni@google.com>
1476
1477         [Chromium] Get rid of WebAccessibilityCache.
1478         https://bugs.webkit.org/show_bug.cgi?id=68224
1479
1480         Reviewed by Dimitri Glazkov.
1481
1482         * DumpRenderTree/chromium/AccessibilityController.cpp:
1483         (AccessibilityController::bindToJavascript):
1484
1485 2011-10-09  Adam Barth  <abarth@webkit.org>
1486
1487         Remove "near miss" XSS vulnerabilities in garden-o-matic
1488         https://bugs.webkit.org/show_bug.cgi?id=69708
1489
1490         Reviewed by David Levin.
1491
1492         Collin Jackson did a security audit of garden-o-matic.  He hasn't found
1493         any actual vulnerabilities yet, but he did identify a couple "near
1494         misses" where a slight change in garden-o-matic could lead to a
1495         vulnerability.  This patch removes those potential issues.
1496
1497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
1498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1499
1500 2011-10-07  Adam Barth  <abarth@webkit.org>
1501
1502         Add a Content-Security-Policy to garden-o-matic
1503         https://bugs.webkit.org/show_bug.cgi?id=69668
1504
1505         Reviewed by David Levin.
1506
1507         This will help mitigate cross-site script and will also help us dogfood CSP.
1508
1509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1510
1511 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
1512
1513         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
1514         https://bugs.webkit.org/show_bug.cgi?id=66380
1515
1516         Reviewed by Antonio Gomes.
1517
1518         This encapsulates EWebKit into an object that manages multiple windows
1519         and provides a cleaner interface to EFL's DumpRenderTree.
1520
1521         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
1522         (DumpRenderTreeChrome::create):
1523         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1524         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
1525         (DumpRenderTreeChrome::createNewWindow):
1526         (DumpRenderTreeChrome::createView):
1527         (DumpRenderTreeChrome::removeWindow):
1528         (DumpRenderTreeChrome::initialize):
1529         (DumpRenderTreeChrome::extraViews):
1530         (DumpRenderTreeChrome::mainFrame):
1531         (DumpRenderTreeChrome::mainView):
1532         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1533         (DumpRenderTreeChrome::onWindowObjectCleared):
1534         (DumpRenderTreeChrome::onLoadStarted):
1535         (DumpRenderTreeChrome::processWork):
1536         (DumpRenderTreeChrome::onLoadFinished):
1537         (DumpRenderTreeChrome::onStatusbarTextSet):
1538         (DumpRenderTreeChrome::onTitleChanged):
1539         (DumpRenderTreeChrome::onDocumentLoadFinished):
1540         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
1541         * DumpRenderTree/efl/EventSender.cpp:
1542         (sendClick): Use browser->mainFrame() instead of mainFrame.
1543         (mouseDownCallback): Ditto.
1544         (mouseUpCallback): Ditto.
1545         (mouseMoveToCallback): Ditto.
1546         (mouseScrollByCallback): Ditto.
1547         (keyDownCallback): Ditto.
1548         (scalePageByCallback): Ditto.
1549         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1550         (LayoutTestController::counterValueForElementById): Use
1551         browser->mainFrame() instead of mainFrame.
1552         (LayoutTestController::pageNumberForElementById): Ditto.
1553         (LayoutTestController::numberOfPages): Ditto.
1554         (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
1555         (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
1556         (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
1557         (LayoutTestController::numberOfActiveAnimations): Ditto.
1558         (LayoutTestController::suspendAnimations): Ditto.
1559         (LayoutTestController::resumeAnimations): Ditto.
1560         (LayoutTestController::setWebViewEditable): Ditto.
1561         (LayoutTestController::webHistoryItemCount): Use browser->mainView()
1562         instead of browser.
1563         (LayoutTestController::queueLoad): Ditto.
1564         (LayoutTestController::setAcceptsEditing): Ditto.
1565         (LayoutTestController::setUserStyleSheetEnabled): Ditto.
1566         (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
1567         (LayoutTestController::setFrameFlatteningEnabled): Ditto.
1568         (LayoutTestController::setSpatialNavigationEnabled): Ditto.
1569         (LayoutTestController::setPluginsEnabled): Ditto.
1570         (LayoutTestController::findString): Ditto.
1571         (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
1572         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1573         (createBitmapContextFromWebView): Use browser->mainFrame() instead of
1574         mainFrame.
1575         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1576         (LoadItem::invoke): Ditto.
1577         (LoadHTMLStringItem::invoke): Ditto.
1578         (ScriptItem::invoke): Ditto.
1579         (ReloadItem::invoke): Use browser->mainView() instead of browser.
1580
1581 2011-10-07  Simon Hausmann  <simon.hausmann@nokia.com>
1582
1583         [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
1584         https://bugs.webkit.org/show_bug.cgi?id=69617
1585
1586         Reviewed by Andreas Kling.
1587
1588         Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
1589         the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
1590         events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
1591         events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
1592         logic.
1593
1594         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1595         (MiniBrowserApplication::MiniBrowserApplication):
1596         (MiniBrowserApplication::notify):
1597         * MiniBrowser/qt/MiniBrowserApplication.h:
1598
1599 2011-10-06  Adam Barth  <abarth@webkit.org>
1600
1601         Port PixelZoomer to work in garden-o-matic
1602         https://bugs.webkit.org/show_bug.cgi?id=69577
1603
1604         Reviewed by David Levin.
1605
1606         This implementation of PixelZoomer is basically a fork of the
1607         implementation used by results.html.  These two apps have different
1608         requirements on where this code lives.  results.html wants to be
1609         self-contained whereas garden-o-matic wants to live in the public_html
1610         folder of the buildbot.  We could do something fancy here to share the
1611         code, but that's not likely to be of much benefit.
1612
1613         I had to change a few things about pixelzoomer to accounter for the
1614         differences in DOM between results.html and garden-o-matic, but
1615         surprisingly little.  I also moved all the code into an anonymous
1616         function, which is the style we're suing for module separation in
1617         garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
1618         want to drag along too many extra functions from results.html.
1619
1620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
1625         (.pixel-zoom-container):
1626         (.pixel-zoom-container > *):
1627         (.pixel-zoom-container .scaled-image-container):
1628         (.scaled-image-container > img):
1629
1630 2011-10-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1631
1632         [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
1633         https://bugs.webkit.org/show_bug.cgi?id=69505
1634
1635         Reviewed by Andreas Kling.
1636
1637         * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
1638         (on_viewport_changed):
1639
1640 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
1641
1642         [WinCairo] Unreviewed test correction.
1643
1644         * Scripts/webkitdirs.pm:
1645         (argumentsForConfiguration): Add 'wincairo' option to the set of
1646         configuration flags used by run-javascript-core tests, so that it
1647         does not attempt to run Apple's release version.
1648
1649 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
1650
1651         [WinCairo] Unreviewed test correction.
1652
1653         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
1654          of known build slave types so that test-result-archive won't fail
1655          when running tests.
1656
1657 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
1658
1659         The GTK+ WebKit2 headers produce a lot of style warnings
1660         https://bugs.webkit.org/show_bug.cgi?id=69481
1661
1662         Reviewed by David Levin.
1663
1664         Prevent emitting so many style warnings for GTK+ API. We skip header
1665         files in the WebKit2 GTK+ API directory and also avoid warnings about
1666         identifier names that begin with "webkit_" in files that contain the
1667         string "gtk".
1668
1669         * Scripts/webkitpy/style/checker.py: Do not check header files in
1670         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
1671         adding the ability to specify a regular expression in the skip list. Remove
1672         a few files from the skipped list that no longer exist.
1673         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
1674         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
1675         about identifiers that begin with "webkit_".
1676         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
1677
1678 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
1679
1680         [WinCairo] Correct config.json for WinCairo Test builds.
1681         https://bugs.webkit.org/show_bug.cgi?id=69272
1682
1683         Reviewed by Ryosuke Niwa.
1684
1685         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
1686          old 'WinCairo Debug (Build)' label and replace with correct
1687          'WinCairo Release' label.
1688
1689 2011-10-06  David Levin  <levin@chromium.org>
1690
1691         Add a style checker watchlist definition and add myself to it.
1692         https://bugs.webkit.org/show_bug.cgi?id=69564
1693
1694         Reviewed by Daniel Bates.
1695
1696         * Scripts/webkitpy/common/config/watchlist:
1697
1698 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
1699
1700         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
1701         https://bugs.webkit.org/show_bug.cgi?id=69450
1702
1703         Reviewed by Ryosuke Niwa.
1704
1705         This should avoid stderr messages when running
1706         webarchive/test-link-rel-icon.html.
1707
1708         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1709         (LayoutTestController::setIconDatabaseEnabled):
1710
1711 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
1712
1713         [WK2] [GTK] Add Skipped file for Webkit2 test runner
1714         https://bugs.webkit.org/show_bug.cgi?id=69517
1715
1716         Use the shared WK2 skipped file also in GTK port.
1717
1718         Reviewed by Martin Robinson.
1719
1720         * Scripts/old-run-webkit-tests:
1721         (readSkippedFiles):
1722
1723 2011-10-06  Elliot Poger  <epoger@google.com>
1724
1725         allow new-run-webkit-tests to run on Lion
1726         https://bugs.webkit.org/show_bug.cgi?id=69429
1727
1728         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
1729         directory to fallback lists (even though that directory doesn't exist yet)
1730
1731         Reviewed by Adam Barth.
1732
1733         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1734         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1735
1736 2011-10-03  Hans Wennborg  <hans@chromium.org>
1737
1738         IndexedDB: Remove SQLite-LevelDB migration code
1739         https://bugs.webkit.org/show_bug.cgi?id=69264
1740
1741         Reviewed by Tony Chang.
1742
1743         Remove setOverrideIndexedDBBackingStore. It was used in the layout
1744         test for migration.
1745
1746         * DumpRenderTree/chromium/LayoutTestController.cpp:
1747         (LayoutTestController::LayoutTestController):
1748         * DumpRenderTree/chromium/LayoutTestController.h:
1749
1750 2011-10-05  James Robinson  <jamesr@chromium.org>
1751
1752         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
1753         https://bugs.webkit.org/show_bug.cgi?id=69498
1754
1755         Reviewed by Adam Barth.
1756
1757         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1758         (main):
1759         * DumpRenderTree/chromium/TestShell.cpp:
1760         (TestShell::TestShell):
1761         (TestShell::resetWebSettings):
1762         * DumpRenderTree/chromium/TestShell.h:
1763         (TestShell::setThreadedCompositingEnabled):
1764         * DumpRenderTree/chromium/WebPreferences.cpp:
1765         (WebPreferences::reset):
1766         (WebPreferences::applyTo):
1767         * DumpRenderTree/chromium/WebPreferences.h:
1768         * Scripts/webkitpy/layout_tests/port/chromium.py:
1769         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1770
1771 2011-10-05  Erik Arvidsson  <arv@chromium.org>
1772
1773         [QT] Fix DRT after r96779
1774
1775         unreviewed.
1776
1777         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1778         (WebCore::dumpHistoryItem):
1779
1780 2011-10-05  Erik Arvidsson  <arv@chromium.org>
1781
1782         window.location.href and others needlessly decodes URI-encoded characters
1783         https://bugs.webkit.org/show_bug.cgi?id=30225
1784
1785         Reviewed by Darin Adler.
1786
1787         * DumpRenderTree/chromium/TestShell.cpp:
1788         (normalizeLayoutTestURLInternal): Remove extra encode.
1789
1790 2011-10-05  Darin Adler  <darin@apple.com>
1791
1792         Fix build.
1793
1794         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1795         (TestWebKitAPI::TEST): Remove underscore prefix from call to
1796         WKContextRegisterURLSchemeAsEmptyDocument.
1797
1798 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
1799
1800         [WinCairo] Switch to building Release target, and activate tests.
1801         https://bugs.webkit.org/show_bug.cgi?id=69272
1802
1803         Reviewed by Adam Barth.
1804
1805         * BuildSlaveSupport/build.webkit.org-config/config.json:
1806         Change from debug to release target. Switch from "Build" to
1807         "BuildAndTest"
1808
1809 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
1810
1811         In WebKitTestRunner, text has font smoothing in pixel snapshots
1812         https://bugs.webkit.org/show_bug.cgi?id=69396
1813
1814         Reviewed by Darin Adler.
1815         
1816         Call the new WKContext method that disables font smoothing in
1817         WebKitTestRunner, so that pixel snapshots don't have font smoothing
1818         enabled. Remove leading underscore from a WKContext function call.
1819
1820         * WebKitTestRunner/TestController.cpp:
1821         (WTR::TestController::resetStateToConsistentValues):
1822
1823 2011-10-05  David Levin  <levin@chromium.org>
1824
1825         Improve the watchlist for threading entries.
1826         https://bugs.webkit.org/show_bug.cgi?id=69463
1827
1828         Reviewed by Adam Barth.
1829
1830         * Scripts/webkitpy/common/config/watchlist:
1831
1832 2011-10-05  Adam Roben  <aroben@apple.com>
1833
1834         Add tests for using RetainPtrs inside HashMap and HashSet
1835
1836         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
1837         in HashMap/HashSet fails to compile
1838
1839         Reviewed by John Sullivan.
1840
1841         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
1842         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
1843         and value type of HashMap.
1844
1845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1846         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1847         Added new file.
1848
1849 2011-10-05  Adam Barth  <abarth@webkit.org>
1850
1851         Mark as Expected in garden-o-matic is confusing
1852         https://bugs.webkit.org/show_bug.cgi?id=69452
1853
1854         Reviewed by David Levin.
1855
1856         krit didn't understand the difference between this button and the
1857         Rebaseline button because both of them seem to indicate that the new
1858         behavior is expected.  This patch renames "Mark as Expected" to "Expect
1859         Failure" to make it clear that we're just expecting the test to fail
1860         rather than accepting the new results as passing.  We might need to
1861         iterate on these names a bit more if folks continue to find them
1862         confusing.
1863
1864         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1865
1866 2011-10-05  Adam Barth  <abarth@webkit.org>
1867
1868         Add watchlist entries for abarth
1869         https://bugs.webkit.org/show_bug.cgi?id=69461
1870
1871         Reviewed by David Levin.
1872
1873         I might have gone a bit overboard.  We'll see if this is too much spam
1874         for me.
1875
1876         * Scripts/webkitpy/common/config/watchlist:
1877
1878 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
1879
1880         [WinCairo] Teach old-run-webkit-tests about wincairo.
1881         https://bugs.webkit.org/show_bug.cgi?id=69280
1882
1883         Reviewed by Adam Roben.
1884
1885         * Scripts/old-run-webkit-tests: Handle wincairo case.
1886         (buildPlatformResultHierarchy):
1887         (readSkippedFiles): Ditto
1888         * Scripts/webkitdirs.pm: Deal with wincairo build case.
1889         (determineConfiguration):
1890
1891 2011-10-05  Chang Shu  <cshu@webkit.org>
1892
1893         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
1894         https://bugs.webkit.org/show_bug.cgi?id=68924
1895
1896         Added TextInputController files and JS interfaces for the above functions.
1897
1898         Reviewed by Darin Adler.
1899
1900         * WebKitTestRunner/DerivedSources.make:
1901         * WebKitTestRunner/DerivedSources.pro:
1902         * WebKitTestRunner/GNUmakefile.am:
1903         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
1904         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1905         (WTR::InjectedBundle::beginTesting):
1906         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1907         (WTR::InjectedBundle::textInputController):
1908         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1909         (WTR::InjectedBundlePage::didClearWindowForFrame):
1910         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
1911         (WTR::TextInputController::create):
1912         (WTR::TextInputController::TextInputController):
1913         (WTR::TextInputController::~TextInputController):
1914         (WTR::TextInputController::wrapperClass):
1915         (WTR::TextInputController::makeWindowObject):
1916         (WTR::TextInputController::setMarkedText):
1917         (WTR::TextInputController::hasMarkedText):
1918         (WTR::TextInputController::unmarkText):
1919         (WTR::TextInputController::insertText):
1920         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
1921         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1922         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1923         * WebKitTestRunner/win/InjectedBundle.vcproj:
1924
1925 2011-10-04  Oliver Hunt  <oliver@apple.com>
1926
1927         Add rudimentary filtering to write barriers
1928         https://bugs.webkit.org/show_bug.cgi?id=69392
1929
1930         Reviewed by Filip Pizlo.
1931
1932         When we're recording gc phase times Heap.o picks up
1933         some exit time destructors, so we'll just ignore Heap.o
1934         in this check.
1935
1936         * Scripts/check-for-exit-time-destructors:
1937
1938 2011-10-05  Chang Shu  <cshu@webkit.org>
1939
1940         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
1941         https://bugs.webkit.org/show_bug.cgi?id=69365
1942
1943         Reviewed by Darin Adler.
1944
1945         Added js API in WTR LayoutTestController.
1946
1947         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1948         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1949         (WTR::LayoutTestController::dumpConfigurationForViewport):
1950         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1951
1952 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
1953
1954         [EFL] ImageDiff: Do not clear the image before it is processed and compared
1955         https://bugs.webkit.org/show_bug.cgi?id=69378
1956
1957         Reviewed by Antonio Gomes.
1958
1959         Commit 61836 to Evas added a few cleanup calls to some
1960         evas_object_image functions which effectively made ImageDiff consider
1961         all images to be equal.
1962
1963         It turns out that now evas_object_image_colorspace_set clears any
1964         data set, so the call to evas_object_image_data_set was not having any
1965         effect.
1966
1967         * DumpRenderTree/efl/ImageDiff.cpp:
1968         (readImageFromStdin): Call evas_object_image_data_set after
1969         evas_object_image_colorspace_set.
1970
1971 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
1972
1973         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
1974         https://bugs.webkit.org/show_bug.cgi?id=68449
1975
1976         Reviewed by Antonio Gomes.
1977
1978         evas_render() must be called to close up temporary files and unmap unused
1979         resources. evas_object_image_data_set() must be called after an
1980         evas_object_image_data_get() to balance an internal reference count.
1981
1982         * DumpRenderTree/efl/ImageDiff.cpp:
1983         (differenceImageFromDifferenceBuffer):
1984         (calculateDifference):
1985         (printImage):
1986         (printImageDifferences):
1987
1988 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
1989
1990         [Qt][WK2] Unreviewed build fix.
1991
1992         Don't use WebCore directly in WTR.
1993
1994         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1995         (WTR::PlatformWebView::addChromeInputField):
1996         (WTR::PlatformWebView::removeChromeInputField):
1997         (WTR::PlatformWebView::makeWebViewFirstResponder):
1998
1999 2011-10-05  David Levin  <levin@chromium.org>
2000
2001         watchlist: Add more rules for chromium public api and sort the file.
2002         https://bugs.webkit.org/show_bug.cgi?id=69323
2003
2004         Reviewed by Adam Barth.
2005
2006         * Scripts/webkitpy/common/config/watchlist:
2007
2008 2011-10-05  David Levin  <levin@chromium.org>
2009
2010         watchlist: Don't add the same message to a bug more than once.
2011         https://bugs.webkit.org/show_bug.cgi?id=69303
2012
2013         Reviewed by Adam Barth.
2014
2015         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
2016         if a message is in the comments already.
2017         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
2018         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2019         Pick a bug supplied by the mock. Change the test due to different output
2020         from the mock watch list tool.
2021         * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
2022         another email so it will be filtered out, fix bugs to have the cc and comment fields,
2023         and fix fetch_bug to handle bug_id's which are text (because that took me way too long
2024         to debug).
2025         * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
2026         and/or cc's that are already in the bug.
2027         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
2028         and remove a comment that is filtered out.
2029
2030 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
2031
2032         [Qt][WK2] Unreviewed build fix after r96643.
2033
2034         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2035         (WTR::PlatformWebView::addChromeInputField):
2036         (WTR::PlatformWebView::removeChromeInputField):
2037         (WTR::PlatformWebView::makeWebViewFirstResponder):
2038
2039 2011-10-04  Kent Tamura  <tkent@chromium.org>
2040
2041         Introduce feature flags for incomplete input types
2042         https://bugs.webkit.org/show_bug.cgi?id=68971
2043
2044         Reviewed by Hajime Morita.
2045
2046         * Scripts/build-webkit:
2047         Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
2048         They are disabled by default.
2049
2050 2011-10-04  Adam Barth  <abarth@webkit.org>
2051
2052         garden-o-matic doesn't launch it's UI on Lion
2053         https://bugs.webkit.org/show_bug.cgi?id=69349
2054
2055         Reviewed by Darin Adler.
2056
2057         It turns out that Lion is a bit more picky about file URLs.  This patch
2058         switches us from using a path to using an actual file URL, silencing
2059         the warning and making the tool actually launch on Lion.
2060
2061         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2062
2063 2011-10-04  Daniel Bates  <dbates@rim.com>
2064
2065         Fix Perl undefined variable warning when using run-safari after
2066         <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
2067
2068         Rubber-stamped by Alexey Proskuryakov.
2069
2070         * Scripts/webkitdirs.pm:
2071         (runMacWebKitApp): Check that the optional function argument $useOpenCommand
2072         is defined before using it in a comparison operation.
2073
2074 2011-10-04  Scott Graham  <scottmg@chromium.org>
2075
2076         Add GAMEPAD feature flag
2077         https://bugs.webkit.org/show_bug.cgi?id=66859
2078
2079         Reviewed by Darin Fisher.
2080
2081         * Scripts/build-webkit:
2082
2083 2011-10-04  Jon Lee  <jonlee@apple.com>
2084
2085         REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
2086         https://bugs.webkit.org/show_bug.cgi?id=68412
2087         <rdar://problem/9988252>
2088
2089         Reviewed by Darin Adler.
2090
2091         In order to create a test for the bug, I had to update DRT and WKTR to create some
2092         widget that allows first responder status to move away from the main web view.
2093
2094         Three methods were added to layoutTestController: addChromeInputField,
2095         removeChromeInputField, and focusWebView. addChromeInputField adds a text field
2096         that is a sibling to the web view, and sets up the key event loop between the two.
2097         removeChromeInputField removes that field. focusWebView moves first responder
2098         status to the web view.
2099
2100         The test makes the call via layoutTestController and passes a callback that it
2101         assumes will be executed once the task is completed. In DRT the callback is called
2102         synchronously. In WKTR this is handled with message passing between the two
2103         processes.
2104
2105         * DumpRenderTree/LayoutTestController.cpp:
2106         (addChromeInputFieldCallback):
2107         (removeChromeInputFieldCallback):
2108         (focusWebViewCallback):
2109         (LayoutTestController::staticFunctions):
2110         * DumpRenderTree/LayoutTestController.h:
2111         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2112         (LayoutTestController::addChromeInputField):
2113         (LayoutTestController::removeChromeInputField):
2114         (LayoutTestController::focusWebView):
2115         * DumpRenderTree/mac/DumpRenderTree.mm:
2116         (resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
2117         make sure to remove the chrome input field.
2118         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2119         (LayoutTestController::addChromeInputField):
2120         (LayoutTestController::removeChromeInputField):
2121         (LayoutTestController::focusWebView):
2122         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2123         (LayoutTestController::addChromeInputField):
2124         (LayoutTestController::removeChromeInputField):
2125         (LayoutTestController::focusWebView):
2126         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2127         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2128         (WTR::InjectedBundle::didReceiveMessage):
2129         (WTR::InjectedBundle::postAddChromeInputField):
2130         (WTR::InjectedBundle::postRemoveChromeInputField):
2131         (WTR::InjectedBundle::postFocusWebView):
2132         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2133         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2134         (WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
2135         through JS.
2136         (WTR::cacheLayoutTestControllerCallback):
2137         (WTR::callLayoutTestControllerCallback):
2138         (WTR::LayoutTestController::addChromeInputField):
2139         (WTR::LayoutTestController::removeChromeInputField):
2140         (WTR::LayoutTestController::focusWebView):
2141         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
2142         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
2143         (WTR::LayoutTestController::callFocusWebViewCallback):
2144         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2145         * WebKitTestRunner/PlatformWebView.h:
2146         * WebKitTestRunner/TestController.cpp:
2147         (WTR::TestController::resetStateToConsistentValues):
2148         * WebKitTestRunner/TestInvocation.cpp:
2149         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2150         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2151         (WTR::PlatformWebView::addChromeInputField):
2152         (WTR::PlatformWebView::removeChromeInputField):
2153         (WTR::PlatformWebView::makeWebViewFirstResponder):
2154         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2155         (WTR::PlatformWebView::addChromeInputField):
2156         (WTR::PlatformWebView::removeChromeInputField):
2157         (WTR::PlatformWebView::makeWebViewFirstResponder):
2158         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2159         (WTR::PlatformWebView::addChromeInputField):
2160         (WTR::PlatformWebView::removeChromeInputField):
2161         (WTR::PlatformWebView::makeWebViewFirstResponder):
2162
2163         * DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
2164         with the patch-- just cleaning up style.
2165         (LayoutTestController::addDisallowedURL):
2166         (originsArrayToJS):
2167         (LayoutTestController::queueLoad):
2168         (LayoutTestController::setMockDeviceOrientation):
2169         (LayoutTestController::setIconDatabaseEnabled):
2170         (LayoutTestController::setEditingBehavior):
2171
2172 2011-10-04  Simon Fraser  <simon.fraser@apple.com>
2173
2174         Move font-fixup code in WebKitTestRunner to a better place
2175         https://bugs.webkit.org/show_bug.cgi?id=69356
2176
2177         Reviewed by Sam Weinig.
2178         
2179         Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
2180         already contains font-related code.
2181
2182         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2183         (WTR::InjectedBundle::initialize):
2184         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2185         (WTR::allowedFontFamilySet):
2186         (WTR::drt_NSFontManager_availableFontFamilies):
2187         (WTR::drt_NSFontManager_availableFonts):
2188         (WTR::swizzleNSFontManagerMethods):
2189         (WTR::activateFonts):
2190         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2191         (WTR::InjectedBundle::platformInitialize):
2192
2193 2011-10-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
2194
2195         [EFL] DRT: Add DumpRenderTree.cpp
2196         https://bugs.webkit.org/show_bug.cgi?id=62034
2197
2198         Reviewed by Antonio Gomes.
2199
2200         This is the main implementation file for EFL's DumpRenderTree.
2201
2202         * DumpRenderTree/efl/DumpRenderTree.cpp: Added.
2203         (dumpFramesAsText):
2204         (dumpFrameScrollPosition):
2205         (shouldLogFrameLoadDelegates):
2206         (shouldDumpAsText):
2207         (sendPixelResultsEOF):
2208         (invalidateAnyPreviousWaitToDumpWatchdog):
2209         (onEcoreEvasResize):
2210         (onCloseWindow):
2211         (useLongRunningServerMode):
2212         (parseCommandLineOptions):
2213         (getFinalTestURL):
2214         (getExpectedPixelHash):
2215         (createLayoutTestController):
2216         (runTest):
2217         (runTestingServerLoop):
2218         (adjustOutputTypeByMimeType):
2219         (dumpFrameContentsAsText):
2220         (shouldDumpFrameScrollPosition):
2221         (shouldDumpPixelsAndCompareWithExpected):
2222         (shouldDumpBackForwardList):
2223         (initEfl):
2224         (shutdownEfl):
2225         (displayWebView):
2226         (dump):
2227         (initEcoreEvas):
2228         (main):
2229
2230 2011-10-03  Adam Barth  <abarth@webkit.org>
2231
2232         garden-o-matic should remove builders from the failure grid once they start to pass
2233         https://bugs.webkit.org/show_bug.cgi?id=69309
2234
2235         Unreviewed.  dglazkov is on vacation.  I need to interest someone else
2236         in reviewing these patches.
2237
2238         This patch follows the update/purge model from UpdateTracker.  This
2239         patch is less awesome than it could be because it causes the UI to
2240         flash slightly.  In a future patch, we'll want to use these
2241         update/purge notifications to update the UI without flashing.  However,
2242         that's not such a big deal because this UI is hidden in the default
2243         view.
2244
2245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2249
2250 2011-10-03  David Levin  <levin@chromium.org>
2251
2252         webkitpy: Expose cc_emails and comments from bug.py
2253         https://bugs.webkit.org/show_bug.cgi?id=69308
2254
2255         Reviewed by Adam Barth.
2256
2257         * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
2258         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
2259         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
2260         to comments being exposed.
2261
2262 2011-10-03  James Robinson  <jamesr@chromium.org>
2263
2264         Add myself to the watchlist for platform/graphics/chromium
2265         https://bugs.webkit.org/show_bug.cgi?id=69297
2266
2267         Reviewed by David Levin.
2268
2269         * Scripts/webkitpy/common/config/watchlist:
2270
2271 2011-10-03  Anders Carlsson  <andersca@apple.com>
2272
2273         Remove custom scrollbar painting hooks
2274         https://bugs.webkit.org/show_bug.cgi?id=69163
2275
2276         Reviewed by Alexey Proskuryakov.
2277
2278         * DumpRenderTree/chromium/WebPreferences.cpp:
2279         (WebPreferences::applyTo):
2280         No need to enable custom scrollbar painting.
2281
2282 2011-10-03  David Levin  <levin@chromium.org>
2283
2284         watchlist: Make watchlist run on a bot.
2285         https://bugs.webkit.org/show_bug.cgi?id=68974
2286
2287         Reviewed by Adam Barth.
2288
2289         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
2290         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2291         Change to log what is run so that we can see the style command
2292         and the watchlist command being run.
2293
2294 2011-10-03  David Levin  <levin@chromium.org>
2295
2296         watchlist: Allow specified a bug to attach the watchlist info to.
2297         https://bugs.webkit.org/show_bug.cgi?id=69288
2298
2299         Reviewed by Eric Seidel.
2300
2301         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
2302         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2303         Add tests and fix an existing test because the unit tests do not go through the
2304         normal command line processing (so the -g argument remained when we determined bug ids).
2305         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
2306         get the assert raises regex method.
2307         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
2308
2309 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
2310
2311         [EFL] DRT: Add JSStringUtils.{cpp,h}
2312         https://bugs.webkit.org/show_bug.cgi?id=66397
2313
2314         Reviewed by Ryosuke Niwa.
2315         
2316         Adds helper functions to compare the equality of C-style strings and
2317         JSStringRef objects.
2318
2319         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
2320         (equals):
2321         * DumpRenderTree/efl/JSStringUtils.h: Added.
2322
2323 2011-10-03  Adam Barth  <abarth@webkit.org>
2324
2325         garden-o-matic should work in Safari 5.1
2326         https://bugs.webkit.org/show_bug.cgi?id=69290
2327
2328         Reviewed by Sam Weinig.
2329
2330         My old implementation of bind was too clever by half.  This one seems
2331         to work better, at least according to this test.
2332
2333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2335
2336 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2337
2338         Unreviewed: change my e-mail in commiters.py
2339
2340         (I'm leaving the company and my @openbossa.org will be no more)
2341
2342         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2343
2344 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
2345
2346         Correct post-build step for WinCairo test runs.
2347         https://bugs.webkit.org/show_bug.cgi?id=69191 
2348
2349         Reviewed by Brian Weinstein.
2350
2351         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
2352         shell case to handle the CFLite build.
2353
2354 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
2355
2356         Added myself to reviewers, because I'm now a reviewer.
2357
2358         * Scripts/webkitpy/common/config/committers.py:
2359
2360 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
2361
2362         Bencher script makes it difficult to do automated performance testing
2363         https://bugs.webkit.org/show_bug.cgi?id=69207
2364
2365         Reviewed by Sam Weinig.
2366         
2367         This adds two new features:
2368         
2369         The ability to disable automatic VM detection, which is flaky if any
2370         profiling features are enabled in jsc.
2371         
2372         The ability to compute, and report, a scaled result for all benchmark
2373         suites. It is the geometric mean of three numbers: SunSpider's
2374         arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
2375         It is also possible to turn off all other output from bencher and just
2376         get this number with the --brief option.
2377
2378         * Scripts/bencher:
2379
2380 2011-10-01  Sam Weinig  <sam@webkit.org>
2381
2382         WTR is not successfully changing the NSUserDefaults
2383         https://bugs.webkit.org/show_bug.cgi?id=69204
2384
2385         Reviewed by Dan Bernstein.
2386
2387         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2388         (WTR::InjectedBundle::platformInitialize):
2389         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
2390         get our overrides picked up.
2391
2392 2011-09-30  Daniel Bates  <dbates@rim.com>
2393
2394         Cleanup: Extract code to launch a Mac WebKit application into a common function
2395         https://bugs.webkit.org/show_bug.cgi?id=68662
2396
2397         Reviewed by Adam Roben.
2398
2399         Extracts common code to launch a WebKit application on Mac OS X into a function
2400         so that we can remove duplicate code.
2401
2402         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
2403         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
2404         (runMacWebKitApp): Added.
2405         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
2406         (runMiniBrowser): Ditto.
2407         (runWebKitTestRunner): Ditto.
2408         (runTestWebKitAPI): Ditto.
2409
2410 2011-09-29  David Levin  <levin@chromium.org>
2411
2412         watchlist: Add webkit-patch command to run watchlist.
2413         https://bugs.webkit.org/show_bug.cgi?id=68973
2414
2415         Reviewed by Eric Seidel.
2416
2417         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
2418         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
2419         the cc and messages as sorted lists. To allow for deterministic ordering.
2420         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
2421         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
2422         that it will be exposed as a command by webkit-patch.
2423         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
2424         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
2425         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
2426         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
2427         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
2428         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
2429         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
2430         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
2431
2432 2011-09-30  David Levin  <levin@chromium.org>
2433
2434         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
2435         https://bugs.webkit.org/show_bug.cgi?id=69031
2436
2437         Reviewed by Adam Barth.
2438
2439         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
2440         a comment to explain something important about the email addresses, and
2441         a comment to let emacs know to treat the file as a python file.
2442         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
2443         Detects increases or decreases in a pattern.
2444         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
2445         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2446         Added unit tests for watchlist which has "more" or "less".
2447         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
2448         Added support for "more" or "less".
2449
2450 2011-09-30  Sam Weinig  <sam@webkit.org>
2451
2452         Add support for eventSender.mouseScrollBy in WTR
2453         https://bugs.webkit.org/show_bug.cgi?id=69189
2454
2455         Add implementation of eventSender.mouseScrollBy for the mac.
2456
2457         Reviewed by Simon Fraser.
2458
2459         * WebKitTestRunner/EventSenderProxy.h:
2460         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2461         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2462         (WTR::EventSendingController::keyDown):
2463         (WTR::EventSendingController::mouseScrollBy):
2464         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2465         * WebKitTestRunner/TestController.cpp:
2466         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2467         * WebKitTestRunner/mac/EventSenderProxy.mm:
2468         (WTR::EventSenderProxy::mouseScrollBy):
2469
2470 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
2471
2472         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
2473         https://bugs.webkit.org/show_bug.cgi?id=35273
2474
2475         Reviewed by Dan Bernstein.
2476         
2477         There are two types of font issue that can cause layout test failure.
2478         First, the user may have non-standard fonts installed that affect the layout
2479         of some tests. For example, some tests use the MS Gothic font if installed.
2480         
2481         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
2482         which override the system fonts (e.g. a copy of Arial from MS Office). For
2483         some tests, this can affect font metrics or fallback behavior.
2484         
2485         This change addresses the first problem only. It limits the set of fonts
2486         available through NSFontManager, by swizzling some methods to return
2487         a list of fonts or font families which only include fonts from a hardcoded
2488         whitelist.
2489         
2490         * DumpRenderTree/mac/DumpRenderTree.mm:
2491         (allowedFontFamilySet):
2492         (drt_NSFontManager_availableFontFamilies):
2493         (drt_NSFontManager_availableFonts):
2494         (swizzleNSFontManagerMethods):
2495         (activateTestingFonts):
2496         (adjustFonts):
2497         (createWebViewAndOffscreenWindow):
2498         (prepareConsistentTestingEnvironment):
2499         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2500         (WTR::allowedFontFamilySet):
2501         (WTR::drt_NSFontManager_availableFontFamilies):
2502         (WTR::drt_NSFontManager_availableFonts):
2503         (WTR::swizzleNSFontManagerMethods):
2504         (WTR::InjectedBundle::platformInitialize):
2505
2506 2011-09-30  David Levin  <levin@chromium.org>
2507
2508         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
2509         https://bugs.webkit.org/show_bug.cgi?id=69039
2510
2511         Reviewed by Adam Barth.
2512
2513         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2514         Actually skip only one specific test that is failing on Windows.
2515
2516 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2517
2518         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
2519
2520         For DRT we didn't install the message handler early enough to
2521         catch output while constructing the QApplication. For WTR we
2522         didn't even install a message handler.
2523
2524         Since the UI process will forward any output from the web process
2525         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
2526         in WTR before the web process is started. This is picked up by the
2527         web process which installs its own message handler.
2528
2529         The environment variable can be overriden on the command line if you
2530         want to see output from the web process, or you can pass --verbose to
2531         WTR to see output from both processes.
2532
2533         https://bugs.webkit.org/show_bug.cgi?id=69132
2534
2535         Reviewed by Andreas Kling.
2536
2537         * DumpRenderTree/qt/main.cpp:
2538         * WebKitTestRunner/qt/main.cpp:
2539
2540 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2541
2542         [Qt] Make sure WTR sizes the window and item correctly
2543
2544         Revision 96345 changed the logic for how the view and
2545         window was created, but missed a vital part, setting
2546         the size.
2547
2548         We now use a QSGView for the window, that has a simple
2549         item as its root object that is always resized to fit
2550         within the window. The webview is then parented to the
2551         root object and set to anchors.fill: parent. That way
2552         any window geometry changes will propagate to the web
2553         view.
2554
2555         https://bugs.webkit.org/show_bug.cgi?id=69134
2556
2557         Reviewed by Andreas Kling.
2558
2559         * WebKitTestRunner/PlatformWebView.h:
2560         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2561
2562 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
2563
2564         [EFL] Only save the current viewport in PixelDumpSupportEfl.
2565         https://bugs.webkit.org/show_bug.cgi?id=68450
2566
2567         Reviewed by Antonio Gomes.
2568
2569         The previous implementation saved the whole page contents in the final
2570         PNG, however the baselines and expectations in the tree only want the
2571         current viewport (with a scrollbar, if needed), so we now only save the
2572         currently visible contents.
2573
2574         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2575         (createBitmapContextFromWebView): Use
2576         ewk_frame_visible_content_geometry_get instead of
2577         ewk_frame_contents_size_get.
2578
2579 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
2580
2581         [EFL] Support and keep track of extra windows (views).
2582         https://bugs.webkit.org/show_bug.cgi?id=68454
2583
2584         Reviewed by Antonio Gomes.
2585
2586         So far, window.open and related JavaScript code would not work, as
2587         DRTView did not implementation
2588         Ewk_View_Smart_Class::window_{open,close}. The default implementation
2589         in ewk just returns the current window/view, which broke any
2590         layouttest which relied on window.open.
2591
2592         We now properly create and remove these new views. Unfortunately, the
2593         current way ewk works (and due to the fact that we cannot pass class
2594         methods as function pointers to the EFL functions), DRTView needs to
2595         know that DRTChrome exists and call `browser' directly in some points.
2596
2597         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2598         (onWindowCreate):
2599         (onWindowCloseDelayed):
2600         (onWindowClose):
2601         (drtViewTiledAdd):
2602
2603 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
2604
2605         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
2606         https://bugs.webkit.org/show_bug.cgi?id=42698
2607
2608         Reviewed by Andreas Kling.
2609
2610         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
2611         and call clearApplicationCache when layoutTest start up.
2612
2613         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2614         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2615         (WTR::InjectedBundle::beginTesting):
2616         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2617         (WTR::LayoutTestController::clearAllApplicationCaches):
2618         (WTR::LayoutTestController::setAppCacheMaximumSize):
2619         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2620
2621 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
2622
2623         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
2624         https://bugs.webkit.org/show_bug.cgi?id=69145
2625
2626         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
2627         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
2628         and is perfectly suitable for SceneGraph as well. GraphicsScene events
2629         will not be available in QtGui anymore in future. Therefore we also have to change
2630         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
2631
2632         Reviewed by Chang Shu.
2633
2634         * WebKitTestRunner/EventSenderProxy.h:
2635         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2636         (WTR::EventSenderProxy::createMouseEvent):
2637         (WTR::EventSenderProxy::mouseDown):
2638         (WTR::EventSenderProxy::mouseUp):
2639         (WTR::EventSenderProxy::mouseMoveTo):
2640
2641 2011-09-30  James Robinson  <jamesr@chromium.org>
2642
2643         [chromium] Add WebKit API for sending input events to the compositor thread
2644         https://bugs.webkit.org/show_bug.cgi?id=69117
2645
2646         Reviewed by Darin Fisher.
2647
2648         Adds support for creating and setting a compositor thread in DRT.
2649
2650         * DumpRenderTree/chromium/WebViewHost.cpp:
2651         (WebViewHost::WebViewHost):
2652         * DumpRenderTree/chromium/WebViewHost.h:
2653
2654 2011-09-29  David Levin  <levin@chromium.org>
2655
2656         watchlist: Add cross-checks for WatchList once it is filled.
2657         https://bugs.webkit.org/show_bug.cgi?id=68975
2658
2659         Reviewed by Eric Seidel.
2660
2661         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
2662         instead of having trivial getter and setters.
2663         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
2664         pass the validation checks.
2665         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
2666         and fix a few style nits.
2667         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
2668         validation checks.
2669         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
2670
2671 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
2672
2673         run-api-tests fails on chromium-win bot
2674         https://bugs.webkit.org/show_bug.cgi?id=69121
2675
2676         On Windows running a perl script needs the interpreter.
2677
2678         Reviewed by Adam Barth.
2679
2680         * Scripts/run-api-tests:
2681         (buildTestTool):
2682
2683 2011-09-29  Adam Barth  <abarth@webkit.org>
2684
2685         Attempt to make this tool work on Windows.
2686
2687         * Scripts/run-api-tests:
2688         (buildTestTool):
2689
2690 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2691
2692         [Qt] Try to fix the minial build
2693
2694         * QtTestBrowser/launcherwindow.cpp:
2695         * QtTestBrowser/webpage.cpp:
2696
2697 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2698
2699         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
2700
2701         QWidget and friends now live in the QtWidgets library. We update
2702         includes in implementation files and private headers to us the
2703         non-module-prefixed path, and leave the lookup for the include
2704         path. For public headers we have to ifdef the includes as the
2705         user might now have the modules we need in his QT config.
2706
2707         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
2708         have to update our code and use windowHandle() for setting the
2709         parent relationships.
2710
2711         https://bugs.webkit.org/show_bug.cgi?id=68687
2712
2713         Reviewed by Andreas Kling.
2714
2715         * DumpRenderTree/qt/DumpRenderTree.pro:
2716         * DumpRenderTree/qt/ImageDiff.pro:
2717         * MiniBrowser/qt/BrowserView.cpp:
2718         * MiniBrowser/qt/BrowserView.h:
2719         * MiniBrowser/qt/BrowserWindow.cpp:
2720         * MiniBrowser/qt/BrowserWindow.h:
2721         * MiniBrowser/qt/MiniBrowser.pro:
2722         * MiniBrowser/qt/MiniBrowserApplication.h:
2723         * MiniBrowser/qt/main.cpp:
2724         * QtTestBrowser/QtTestBrowser.pro:
2725         * QtTestBrowser/launcherwindow.cpp:
2726         * QtTestBrowser/launcherwindow.h:
2727         * QtTestBrowser/locationedit.h:
2728         * QtTestBrowser/main.cpp:
2729         * QtTestBrowser/mainwindow.cpp:
2730         * QtTestBrowser/mainwindow.h:
2731         * QtTestBrowser/webinspector.h:
2732         * QtTestBrowser/webpage.cpp:
2733         * QtTestBrowser/webview.cpp:
2734         * WebKitTestRunner/PlatformWebView.h:
2735         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2736
2737 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
2738
2739         Initial implementation of WebInspector for WebKit2 GTK port.
2740         https://bugs.webkit.org/show_bug.cgi?id=68235
2741
2742         Reviewed by Martin Robinson.
2743
2744         * MiniBrowser/gtk/BrowserWindow.c:
2745         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
2746
2747 2011-09-29  Adam Barth  <abarth@webkit.org>
2748
2749         Unbreak the "update expectatations" button by using the existing
2750         machinery to create the failureInfo objects.
2751
2752         Unbreak the "close" button on the progress dialog by using |this|
2753         instead of the old name of the object.
2754
2755         Teach the controllers unit test not to talk to the actual network.
2756
2757         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2758         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
2759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2760
2761 2011-09-29  Hans Wennborg  <hans@chromium.org>
2762
2763         IndexedDB: Use LevelDB also for in-memory databases
2764         https://bugs.webkit.org/show_bug.cgi?id=68903
2765
2766         Reviewed by Steve Block.
2767
2768         Remove the temporary dir that was necessary before LevelDB supported
2769         in-memory databases.
2770
2771         * DumpRenderTree/chromium/TestShell.cpp:
2772         (TestShell::TestShell):
2773         * DumpRenderTree/chromium/TestShell.h:
2774
2775 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
2776
2777         Run TestWebKitAPI on Chromium buildbots
2778         https://bugs.webkit.org/show_bug.cgi?id=68678
2779
2780         Reviewed by Tony Chang.
2781
2782         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2783
2784 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
2785
2786         garden-o-matic results should anticipate 0 unexpected failures.
2787         https://bugs.webkit.org/show_bug.cgi?id=69036
2788
2789         Also fixes controllers: UnexpectedFailures test.
2790
2791         Reviewed by Adam Barth.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
2794
2795 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
2796
2797         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
2798
2799         https://bugs.webkit.org/show_bug.cgi?id=67253
2800
2801         Reviewed by Eric Seidel.
2802
2803         Nearly all of the work in this was done by Simon Fraser; I'm
2804         just repackaging it and cleaning it up a bit. This change
2805         modifies port.diff_image() to return a tuple of (pass/fail,
2806         %age), adds the value to the FailureImageHashMismatch, and
2807         writes the value into the full_results.json files to be
2808         displayed in the results page.
2809
2810         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2811         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2812         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2813         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2814         * Scripts/webkitpy/layout_tests/port/base.py:
2815         * Scripts/webkitpy/layout_tests/port/chromium.py:
2816         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2817         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2818         * Scripts/webkitpy/layout_tests/port/test.py:
2819         * Scripts/webkitpy/layout_tests/port/webkit.py:
2820         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2821
2822 2011-09-25  Kentaro Hara  <haraken@chromium.org>
2823
2824         Unreviewed. Adding myself to committers.py.
2825
2826         * Scripts/webkitpy/common/config/committers.py:
2827
2828 2011-09-28  Adam Barth  <abarth@webkit.org>
2829
2830         garden-o-matic shouldn't depend on test-results.appspot.com
2831         https://bugs.webkit.org/show_bug.cgi?id=69019
2832
2833         Reviewed by Dimitri Glazkov.
2834
2835         This patch moves garden-o-matic from getting full_results.json from
2836         test-results.appspot.com to getting that information directly from the
2837         buildbot.  This patch improve the load time and accuracy of
2838         garden-o-matic because test-results.appspot.com is slow and is dropping
2839         a significant number of writes (see
2840         https://bugs.webkit.org/show_bug.cgi?id=68748).
2841
2842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
2843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2845
2846 2011-09-28  David Levin  <levin@chromium.org>
2847
2848         watchlist: Add a way to load the watchlist from config.
2849         https://bugs.webkit.org/show_bug.cgi?id=68991
2850
2851         Reviewed by Eric Seidel.
2852
2853         * Scripts/webkitpy/common/config/watchlist: Added.
2854         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
2855         Support for loading the watch list.
2856         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
2857         Tests for the loading.
2858         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
2859         Adjusted to use the common base class.
2860         * Scripts/webkitpy/common/webkitunittest.py: Added.
2861         Made a common base class for functionality used in more than one.
2862
2863 2011-09-28  David Levin  <levin@chromium.org>
2864
2865         Attempt fix for Leopard python unit test run.
2866
2867         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
2868
2869 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
2870
2871         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
2872         https://bugs.webkit.org/show_bug.cgi?id=68938
2873
2874         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
2875
2876         Reviewed by David Hyatt.
2877
2878         * DumpRenderTree/chromium/WebViewHost.cpp:
2879         (WebViewHost::didUpdateLayout): Added width/height queries.
2880         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
2881
2882 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
2883
2884         Get rebaseline server running again
2885         https://bugs.webkit.org/show_bug.cgi?id=69020
2886
2887         Reviewed by Adam Barth.
2888
2889         Make rebaseline server run again after r90337 (missing format_date_time
2890         import, results_json wasn't outputting anything).
2891
2892         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2893         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2894
2895 2011-09-28  David Grogan  <dgrogan@chromium.org>
2896
2897         Move dgrogan from contributor to committer
2898         https://bugs.webkit.org/show_bug.cgi?id=69021
2899
2900         * Scripts/webkitpy/common/config/committers.py:
2901
2902 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
2903
2904         Add Mac Skia GPU bots to builders.py
2905         https://bugs.webkit.org/show_bug.cgi?id=69016
2906
2907         Reviewed by Eric Seidel.
2908
2909         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
2910         GPU tests.
2911
2912         * Scripts/webkitpy/layout_tests/port/builders.py:
2913         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2914
2915 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2916
2917         Second try at fixing the GTK+ build.
2918
2919         * GNUmakefile.am:
2920
2921 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
2922
2923         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
2924         https://bugs.webkit.org/show_bug.cgi?id=68680
2925
2926         Reviewed by Tony Chang.
2927
2928         * Scripts/run-chromium-webkit-unit-tests:
2929         * Scripts/webkitdirs.pm:
2930         (determineBaseProductDir):
2931
2932 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2933
2934         [Gtk] Implement textInputController.doCommand
2935         https://bugs.webkit.org/show_bug.cgi?id=66496
2936
2937         Reviewed by Martin Robinson.
2938
2939         * DumpRenderTree/gtk/TextInputController.cpp:
2940         (doCommandCallback): Callback function for textInputController.doCommand
2941
2942 2011-09-28  David Levin  <levin@chromium.org>
2943
2944         watchlist: Suggest corrections for typos and improve error message consistency.
2945         https://bugs.webkit.org/show_bug.cgi?id=68976
2946
2947         Reviewed by Adam Barth.
2948
2949         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
2950         for typos and improve consistency of the error messages.
2951         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
2952         and improve the regex that were already present.
2953
2954 2011-09-28  David Levin  <levin@chromium.org>
2955
2956         watchlist: Add support for matching added or deleted lines.
2957         https://bugs.webkit.org/show_bug.cgi?id=68972
2958
2959         Reviewed by Adam Barth.
2960
2961         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
2962         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
2963         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
2964         to the pattern match to only have the diff lines instead of the DiffFile.
2965         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2966         Add tests for the new patterns and combinations of the patterns.
2967         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
2968         Sort imports. Add changeline support.
2969
2970 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2971
2972         [GTK] Add WebKitError to GTK+ WebKit2 API
2973         https://bugs.webkit.org/show_bug.cgi?id=68508
2974
2975         Reviewed by Martin Robinson.
2976
2977         * GNUmakefile.am: Add path to webkitgtk derived sources to the
2978         include path.
2979
2980 2011-09-28  Philippe Normand  <pnormand@igalia.com>
2981
2982         [GTK] missing WebKit2 support in run-gtk-tests
2983         https://bugs.webkit.org/show_bug.cgi?id=68992
2984
2985         Rubber-stamped by Andreas Kling.
2986
2987         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
2988         webkit2 directory.
2989
2990 2011-09-27  Philippe Normand  <pnormand@igalia.com>
2991
2992         [GTK] build-webkit --no-webkit2 still builds WebKit2
2993         https://bugs.webkit.org/show_bug.cgi?id=68892
2994
2995         Reviewed by Martin Robinson.
2996
2997         Take the --no-webkit2 option in account when building WebKitGTK+.
2998
2999         * Scripts/build-webkit:
3000         * Scripts/webkitdirs.pm:
3001         (buildAutotoolsProject):
3002         (buildGtkProject):
3003
3004 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3005
3006         Make Chromium Win Release (Tests) a core builder
3007         https://bugs.webkit.org/show_bug.cgi?id=68906
3008
3009         Reviewed by Adam Barth.
3010
3011         Add Chromium Win Release (Tests) to the list of core builders.
3012
3013         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3014         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3015
3016 2011-09-27  Adam Barth  <abarth@webkit.org>
3017
3018         garden-o-matic should load faster and inform the user what is happening
3019         https://bugs.webkit.org/show_bug.cgi?id=68954
3020
3021         Reviewed by Dimitri Glazkov.
3022
3023         This test disables the expected failures tab.  The web inspector showed
3024         that loading the data for this tab was slowing down the loading time
3025         for the whole app.  We need to find a way to load that data lazily.
3026
3027         This patch also improves the update message to better describe the
3028         progress the app is making analyzing data from the buildbot.
3029
3030         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3033
3034 2011-09-27  Adam Barth  <abarth@webkit.org>
3035
3036         garden-o-matic should show the first result when examining results
3037         https://bugs.webkit.org/show_bug.cgi?id=68960
3038
3039         Reviewed by Dimitri Glazkov.
3040
3041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3042
3043 2011-09-27  David Levin  <levin@chromium.org>
3044
3045         watchlist: Add support for cc and message rules.
3046         https://bugs.webkit.org/show_bug.cgi?id=68950
3047
3048         Reviewed by Adam Barth.
3049
3050         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
3051         the cc's and messages for a patch.
3052         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
3053         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
3054         for the rules.
3055         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
3056         A generic encapsulation of either a message list or a cc list.
3057         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
3058
3059 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
3060
3061         webkit-patch doesn't like UTF-8 characters in reviewers names
3062         https://bugs.webkit.org/show_bug.cgi?id=63452
3063
3064         Reviewed by Eric Seidel.
3065
3066         * Scripts/webkit-patch:
3067
3068 2011-09-27  Adam Barth  <abarth@webkit.org>
3069
3070         garden-o-matic examine buttons shows both expected and unexpected failures
3071         https://bugs.webkit.org/show_bug.cgi?id=68918
3072
3073         Reviewed by Dimitri Glazkov.
3074
3075         This was a copy/paste error when I refactored this classes to share
3076         more code.
3077
3078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3079
3080 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
3081
3082         Add Kaustubh Atrawalkar to the list of contributors.
3083
3084         * Scripts/webkitpy/common/config/committers.py:
3085
3086 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
3087
3088         [Chromium] Fixed layout mode tests break subsequent tests
3089         https://bugs.webkit.org/show_bug.cgi?id=68923
3090         
3091         Reviewed by Adam Barth.        
3092
3093         Reset fixed layout mode between tests, so that tests that run after
3094         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
3095         regular 800x600 non-fixed layout.
3096
3097         * DumpRenderTree/chromium/TestShell.cpp:
3098         (TestShell::resetTestController):
3099
3100 2011-09-27  David Levin  <levin@chromium.org>
3101
3102         watchlist: Add the filename pattern for definitions.
3103         https://bugs.webkit.org/show_bug.cgi?id=68917
3104
3105         Reviewed by Adam Barth.
3106
3107         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
3108         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
3109         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
3110         for definitions.
3111         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
3112         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
3113
3114 2011-09-27  Adam Barth  <abarth@webkit.org>
3115
3116         garden-o-matic results view should sort test and builder names
3117         https://bugs.webkit.org/show_bug.cgi?id=68488
3118
3119         Reviewed by Andy Estes.
3120
3121         Previously, the test and builder names were displayed in an arbitrary
3122         order that changed from time to time.  That confused one user study
3123         participant.  This patch sorts the lists so that they occur in a
3124         predictable order.
3125
3126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3127
3128 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3129
3130         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
3131         http://trac.webkit.org/changeset/96108
3132         http://trac.webkit.org/changeset/96111
3133         http://trac.webkit.org/changeset/96113
3134         http://trac.webkit.org/changeset/96116
3135         https://bugs.webkit.org/show_bug.cgi?id=68913
3136
3137         Wait for working Qt5 (Requested by ossy on #webkit).
3138
3139         * DumpRenderTree/qt/DumpRenderTree.pro:
3140         * DumpRenderTree/qt/ImageDiff.pro:
3141         * MiniBrowser/qt/BrowserView.cpp:
3142         (BrowserView::BrowserView):
3143         * MiniBrowser/qt/BrowserView.h:
3144         * MiniBrowser/qt/BrowserWindow.cpp:
3145         (BrowserWindow::BrowserWindow):
3146         (BrowserWindow::urlChanged):
3147         (BrowserWindow::~BrowserWindow):
3148         * MiniBrowser/qt/BrowserWindow.h:
3149         * MiniBrowser/qt/MiniBrowser.pro:
3150         * MiniBrowser/qt/MiniBrowserApplication.h:
3151         * MiniBrowser/qt/main.cpp:
3152         * QtTestBrowser/QtTestBrowser.pro:
3153         * QtTestBrowser/launcherwindow.cpp:
3154         * QtTestBrowser/launcherwindow.h:
3155         * QtTestBrowser/locationedit.h:
3156         * QtTestBrowser/main.cpp:
3157         * QtTestBrowser/mainwindow.cpp:
3158         * QtTestBrowser/mainwindow.h:
3159         * QtTestBrowser/webinspector.h:
3160         * QtTestBrowser/webpage.cpp:
3161         * QtTestBrowser/webview.cpp:
3162         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3163         * WebKitTestRunner/PlatformWebView.h:
3164         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3165         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3166         (WTR::WebView::wkView):
3167         (WTR::WebView::pageRef):
3168         (WTR::WebView::~WebView):
3169         (WTR::WebView::WebView):
3170         (WTR::PlatformWebView::PlatformWebView):
3171         (WTR::PlatformWebView::sendEvent):
3172         (WTR::PlatformWebView::postEvent):
3173         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3174
3175 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3176
3177         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
3178         https://bugs.webkit.org/show_bug.cgi?id=65178
3179
3180         Reviewed by Martin Robinson.
3181
3182         * GNUmakefile.am:
3183         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
3184
3185 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
3186
3187         [Qt][WK2] Buildfix after r96108.
3188
3189         Rubber-stamped by Andreas Kling.
3190
3191         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3192         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3193         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3194
3195 2011-09-27  David Levin  <levin@chromium.org>
3196
3197         watchlist: Change watchlistparser.py to be class based.
3198         https://bugs.webkit.org/show_bug.cgi?id=68869
3199
3200         Reviewed by Eric Seidel.
3201
3202         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
3203         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
3204
3205 2011-09-27  David Levin  <levin@chromium.org>
3206
3207         watchlist: Break out the diff boilerplate to allow for re-use.
3208         https://bugs.webkit.org/show_bug.cgi?id=68871
3209
3210         Reviewed by Eric Seidel.
3211
3212         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3213         Break out the diff into a new file.
3214         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
3215
3216 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
3217
3218         Web Inspector: UI performance: introduce heap size tracking stats.
3219         https://bugs.webkit.org/show_bug.cgi?id=68901
3220
3221         It is interesting how much the heap memory is used by Inspector in order of running the test.
3222
3223         Reviewed by Yury Semikhatsky.
3224
3225         * DumpRenderTree/chromium/TestShell.cpp:
3226         (TestShell::showDevTools):
3227         (TestShell::closeDevTools):
3228
3229 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3230
3231         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
3232
3233         QWidget and friends now live in the QtWidgets library. We update
3234         includes in implementation files and private headers to us the
3235         non-module-prefixed path, and leave the lookup for the include
3236         path. For public headers we have to ifdef the includes as the
3237         user might now have the modules we need in his QT config.
3238
3239         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
3240         have to update our code and use windowHandle() for setting the
3241         parent relationships.
3242
3243         https://bugs.webkit.org/show_bug.cgi?id=68687
3244
3245         Reviewed by Andreas Kling.
3246
3247         * DumpRenderTree/qt/DumpRenderTree.pro:
3248         * DumpRenderTree/qt/ImageDiff.pro:
3249         * MiniBrowser/qt/BrowserView.cpp:
3250         * MiniBrowser/qt/BrowserView.h:
3251         * MiniBrowser/qt/BrowserWindow.cpp:
3252         * MiniBrowser/qt/BrowserWindow.h:
3253         * MiniBrowser/qt/MiniBrowser.pro:
3254         * MiniBrowser/qt/MiniBrowserApplication.h:
3255         * MiniBrowser/qt/main.cpp:
3256         * QtTestBrowser/QtTestBrowser.pro:
3257         * QtTestBrowser/launcherwindow.cpp:
3258         * QtTestBrowser/launcherwindow.h:
3259         * QtTestBrowser/locationedit.h:
3260         * QtTestBrowser/main.cpp:
3261         * QtTestBrowser/mainwindow.cpp:
3262         * QtTestBrowser/mainwindow.h:
3263         * QtTestBrowser/webinspector.h:
3264         * QtTestBrowser/webpage.cpp:
3265         * QtTestBrowser/webview.cpp:
3266         * WebKitTestRunner/PlatformWebView.h:
3267         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3268
3269 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3270
3271         [Qt][WK2] Add support for hover API in Qt WebKit2
3272         https://bugs.webkit.org/show_bug.cgi?id=68369
3273
3274         Reviewed by Andreas Kling.
3275
3276         Change the statusbar to show the link URL when hovering links in
3277         MiniBrowser using QDesktopWebView.
3278
3279         * MiniBrowser/qt/BrowserWindow.cpp:
3280         (BrowserWindow::BrowserWindow):
3281         (BrowserWindow::onLinkHovered):
3282         * MiniBrowser/qt/BrowserWindow.h:
3283
3284 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
3285
3286         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
3287         https://bugs.webkit.org/show_bug.cgi?id=68864
3288
3289         Reviewed by Adam Barth.
3290
3291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
3292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
3293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
3294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
3295
3296 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
3297
3298         [Qt][WK2] One more unreviewed buildfix after r96005.
3299
3300         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
3301
3302 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
3303
3304         [Qt][WK2] Unreviewed buildfix after r96005.
3305
3306         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3307         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3308
3309 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
3310
3311         garden-o-matic should be pretty in Open Sans.
3312         https://bugs.webkit.org/show_bug.cgi?id=68845
3313
3314         Reviewed by Adam Barth.
3315
3316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
3317
3318 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
3319
3320         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
3321         https://bugs.webkit.org/show_bug.cgi?id=68841
3322
3323         Reviewed by Adam Barth.
3324
3325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
3326         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
3327         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
3328
3329 2011-09-26  David Levin  <levin@chromium.org>
3330
3331         watchlist: Add parsing for definition section.
3332         https://bugs.webkit.org/show_bug.cgi?id=68850
3333
3334         Reviewed by Adam Barth.
3335
3336         * Scripts/webkitpy/common/watchlist/watchlist.py:
3337         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
3338         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
3339
3340 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
3341
3342         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
3343
3344         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3345         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3346         * WebKitTestRunner/win/TestInvocationWin.cpp:
3347         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3348
3349 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
3350
3351         Repaint tests don't work in WebKit2
3352         https://bugs.webkit.org/show_bug.cgi?id=68453
3353
3354         Reviewed by Sam Weinig.
3355         
3356         Convert DumpRenderTree to use use the repaint rects
3357         exposed via WebKit API when generating the repaint test
3358         overlay.
3359         
3360         Fix WebKitTestRunner to work with repaint tests, again
3361         using the repaint rects exposed from WK2.
3362         
3363         In both cases, layoutTestController.display() now just
3364         forces a display of the web view, and turns on repaint
3365         rect tracking on the main FrameView.
3366         
3367         Later, when pixel results are requested, the alpha overlay
3368         that shows the repaint rects is generated using the list
3369         of rects supplied by WebCore.
3370
3371         * DumpRenderTree/mac/DumpRenderTree.mm:
3372         (resetDefaultsToConsistentValues):
3373         (resetWebViewToConsistentStateBeforeTesting):
3374         (displayWebView):
3375         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3376         (paintRepaintRectOverlay):
3377         (createBitmapContextFromWebView):
3378         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3379         (WTR::InjectedBundle::beginTesting):
3380         (WTR::InjectedBundle::done):
3381         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3382         (WTR::InjectedBundle::setRepaintRects):
3383         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3384         (WTR::InjectedBundlePage::reset):
3385         (WTR::InjectedBundlePage::dump):
3386         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3387         (WTR::LayoutTestController::display):
3388         * WebKitTestRunner/TestInvocation.cpp:
3389         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3390         * WebKitTestRunner/TestInvocation.h:
3391         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3392         (WTR::paintRepaintRectOverlay):
3393         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3394
3395 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
3396
3397         Get hover'ed element URL from HitTest.
3398
3399         mouseDidMoveOverElement now gets the hover'ed element link using
3400         WKHitTestResult API's.
3401         https://bugs.webkit.org/show_bug.cgi?id=68426 
3402
3403         Reviewed by Anders Carlsson.
3404
3405         * MiniBrowser/gtk/BrowserWindow.c:
3406         (mouseDidMoveOverElement):
3407
3408 2011-09-26  David Levin  <levin@chromium.org>
3409
3410         Add skeleton parsing for a WatchList.
3411         https://bugs.webkit.org/show_bug.cgi?id=68823
3412
3413         Reviewed by Adam Barth.
3414
3415         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
3416         Parses the top level watch list sections -- none are defined yet -- and
3417         throws an exception if an invalid one is listed.
3418         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
3419         Verify the exception for an invalid section in a watch list.
3420         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
3421
3422 2011-09-26  Adam Roben  <aroben@apple.com>
3423
3424         Clean up code imported from WebKitAPITest
3425
3426         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
3427         TestWebKitAPI conventions
3428
3429         Reviewed by David Levin.
3430
3431         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
3432         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
3433         namespace name.
3434
3435         (TestWebKitAPI::WebViewDestruction::SetUp):
3436         (TestWebKitAPI::WebViewDestruction::webViewCount):
3437         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3438         (TestWebKitAPI::WebViewDestruction::runMessagePump):
3439         (TestWebKitAPI::WebViewDestruction::TearDown):
3440         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
3441         Moved functionality from free functions into these new test fixtures.
3442
3443         * TestWebKitAPI/win/HostWindow.cpp:
3444         * TestWebKitAPI/win/HostWindow.h:
3445         Prefixed Win32 API calls with ::. Updated namespace name.
3446
3447 2011-09-23  Adam Roben  <aroben@apple.com>
3448
3449         Merge WebKitAPITest into TestWebKitAPI
3450
3451         This also means that our formerly-WebKitAPITest tests will be run on the bots!
3452
3453         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
3454         them more idiomatic in a separate pass.
3455
3456         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
3457         functionality (and names!)
3458
3459         Reviewed by Anders Carlsson.
3460
3461         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
3462         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
3463         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
3464
3465         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
3466
3467         * TestWebKitAPI/win/main.cpp:
3468         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
3469
3470         * WebKitAPITest: Removed this directory and its contents.
3471
3472 2011-09-23  Adam Roben  <aroben@apple.com>
3473
3474         Remove two failing WebKitAPITest tests
3475
3476         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
3477
3478         Reviewed by Anders Carlsson.
3479
3480         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
3481         MainFrameAfterClose tests.
3482
3483 2011-09-25  Adam Barth  <abarth@webkit.org>
3484
3485         Finish removing PLATFORM(BREWMP) by removing associated code
3486         https://bugs.webkit.org/show_bug.cgi?id=68779
3487
3488         Reviewed by Sam Weinig.
3489
3490         * Scripts/webkitpy/common/config/build.py:
3491         * waf/build/settings.py:
3492
3493 2011-09-21  Ai Makabi  <makabi@google.com>
3494
3495         Provides a simple LRU cache class in Python.
3496
3497         https://bugs.webkit.org/show_bug.cgi?id=67823
3498
3499         Reviewed by Tony Chang.
3500
3501         * Scripts/webkitpy/common/lru_cache.py:
3502         * Scripts/webkitpy/common/lru_cache_unittest.py:
3503
3504 2011-09-25  Adam Barth  <abarth@webkit.org>
3505
3506         Remove PLATFORM(HAIKU) and associated code
3507         https://bugs.webkit.org/show_bug.cgi?id=68774
3508
3509         Reviewed by Sam Weinig.
3510
3511         * Scripts/webkitpy/common/config/build.py:
3512         * waf/build/settings.py:
3513
3514 2011-09-24  Adam Barth  <abarth@webkit.org>
3515
3516         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
3517         https://bugs.webkit.org/show_bug.cgi?id=68767
3518
3519         Reviewed by Eric Seidel.
3520
3521         * Scripts/build-webkit:
3522
3523 2011-09-24  Adam Barth  <abarth@webkit.org>
3524
3525         Remove ENABLE(WCSS) and associated code
3526         https://bugs.webkit.org/show_bug.cgi?id=68759
3527
3528         Reviewed by Darin Adler.
3529
3530         * Scripts/build-webkit:
3531         * Scripts/old-run-webkit-tests:
3532         * Scripts/webkitperl/features.pm:
3533         (hasFeature):
3534         * Scripts/webkitpy/layout_tests/port/webkit.py:
3535         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3536
3537 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
3538
3539         Fixed GTK compilation after r95878, the operator== was defined
3540         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
3541
3542         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3543
3544 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
3545
3546         [DRT] Include the right config file for EFL's DRT.
3547         https://bugs.webkit.org/show_bug.cgi?id=67042
3548
3549         Reviewed by Martin Robinson.
3550
3551         Ports which use CMake as their buildsystem (such as the EFL one) also
3552         have config.h files, but they are named differently, so include the
3553         right one depending on the buildsystem being used.
3554
3555         * DumpRenderTree/config.h:
3556
3557 2011-09-23  Adam Klein  <adamk@chromium.org>
3558
3559         Add ENABLE_MUTATION_OBSERVERS feature flag
3560         https://bugs.webkit.org/show_bug.cgi?id=68732
3561
3562         Reviewed by Ojan Vafai.
3563
3564         This flag will guard an implementation of the "Mutation Observers" proposed in
3565         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
3566
3567         * Scripts/build-webkit:
3568
3569 2011-09-23  Chang Shu  <cshu@webkit.org>
3570
3571         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
3572         https://bugs.webkit.org/show_bug.cgi?id=68556
3573
3574         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
3575
3576         Reviewed by Darin Adler.
3577
3578         * WebKitTestRunner/EventSenderProxy.h:
3579         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3580         * WebKitTestRunner/PlatformWebView.h:
3581         * WebKitTestRunner/mac/EventSenderProxy.mm:
3582         (WTR::EventSenderProxy::EventSenderProxy):
3583         (WTR::EventSenderProxy::leapForward):
3584         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3585         (WTR::EventSenderProxy::EventSenderProxy):
3586         (WTR::getMouseButton):
3587         (WTR::getModifiers):
3588         (WTR::EventSenderProxy::updateClickCountForButton):
3589         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
3590         (WTR::EventSenderProxy::mouseDown):
3591         (WTR::EventSenderProxy::mouseUp):
3592         (WTR::EventSenderProxy::mouseMoveTo):
3593         (WTR::EventSenderProxy::leapForward):
3594         (WTR::EventSenderProxy::sendOrQueueEvent):
3595         (WTR::EventSenderProxy::replaySavedEvents):
3596         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3597         (WTR::PlatformWebView::postEvent):
3598         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3599
3600 2011-09-23  Lei Zhang  <thestig@chromium.org>
3601
3602         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
3603         https://bugs.webkit.org/show_bug.cgi?id=68026
3604
3605         Reviewed by Dirk Pranke.
3606
3607         * Scripts/webkitpy/layout_tests/port/chromium.py:
3608
3609 2011-09-23  Elliot Poger  <epoger@google.com>
3610
3611         update layout_tests to account for new default of use_skia=1
3612         https://bugs.webkit.org/show_bug.cgi?id=68698
3613
3614         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
3615         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
3616         (Chromium-on-Mac now uses the Skia graphics library instead of
3617         Core Graphics).
3618
3619         Also updates layout_test code to work with that change.
3620
3621         Reviewed by Mihai Parparita.
3622
3623         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3624         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3625
3626 2011-09-23  Mark Rowe  <mrowe@apple.com>
3627
3628         Fix the build.
3629         
3630         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
3631         the WTF namespace.
3632
3633 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
3634
3635         enable NRWT for run-webkit-tests on Lion
3636         https://bugs.webkit.org/show_bug.cgi?id=68673
3637
3638         Reviewed by Eric Seidel.
3639
3640         * Scripts/run-webkit-tests:
3641         (useNewRunWebKitTests):
3642
3643 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3644
3645         Add unit test for existing StringBuilder
3646         https://bugs.webkit.org/show_bug.cgi?id=67080
3647
3648         Reviewed by Darin Adler.
3649
3650         * TestWebKitAPI/TestWebKitAPI.gypi:
3651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3652         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
3653         (operator<<):
3654         (TestWebKitAPI::expectBuilderContent):
3655         (TestWebKitAPI::expectEmpty):
3656         (TestWebKitAPI::TEST):
3657
3658 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
3659
3660         [EFL] Use ewk_view to navigate in history instead of ewk_history.
3661         https://bugs.webkit.org/show_bug.cgi?id=68455
3662
3663         Reviewed by Antonio Gomes.
3664
3665         BackForwardItem::invoke() was using ewk_history functions to navigate
3666         in history; however, this will only call WebCore::BackForwardListImpl
3667         and not move between pages at all. We now call ewk_view_navigate and
3668         its siblings to make sure the navigation actually happens.
3669
3670         This should make tests like fast/dom/navigation-type-back-forward.html
3671         stop timing out.
3672
3673         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3674         (BackForwardItem::invoke):
3675
3676 2011-09-22  Dean Jackson  <dino@apple.com>
3677
3678         Add ENABLE_CSS_FILTERS
3679         https://bugs.webkit.org/show_bug.cgi?id=68652
3680
3681         Reviewed by Simon Fraser.
3682
3683         * Scripts/build-webkit:
3684
3685 2011-09-22  Anders Carlsson  <andersca@apple.com>
3686
3687         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
3688         https://bugs.webkit.org/show_bug.cgi?id=68660
3689
3690         Reviewed by Adam Barth.
3691
3692         * WebKitTestRunner/mac/EventSenderProxy.mm:
3693         (WTR::EventSenderProxy::mouseUp):
3694
3695 2011-09-22  Adam Roben  <aroben@apple.com>
3696
3697         Remove FindSafari
3698
3699         It isn't used or built anymore.
3700
3701         Fixes <http://webkit.org/b/68628>
3702
3703         Reviewed by Darin Adler.
3704
3705         * FindSafari: Removed this directory and its contents.
3706
3707 2011-09-22  Adam Roben  <aroben@apple.com>
3708
3709         Remove FindSafari from all our .sln files
3710
3711         It isn't used anymore, so there's no point in building it.
3712
3713         Part of <http://webkit.org/b/68628> Remove FindSafari
3714
3715         Reviewed by Steve Falkenburg.
3716
3717         * DumpRenderTree/DumpRenderTree.sln:
3718         * WebKitTestRunner/WebKitTestRunner.sln:
3719
3720 2011-09-22  Adam Roben  <aroben@apple.com>
3721
3722         Remove all uses of FindSafari
3723
3724         It isn't really needed anymore.
3725
3726         Fixes <http://webkit.org/b/68626>.
3727
3728         Reviewed by Darin Adler.
3729
3730         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
3731
3732         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
3733         WebKit, but now we use WebKit.exe for that.
3734
3735         * Scripts/webkitdirs.pm:
3736         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
3737         do the same thing.
3738
3739         (readRegistryString):
3740         (writeRegistryString):
3741         Moved here from old-run-webkit-tests.
3742
3743 2011-09-22  Adam Roben  <aroben@apple.com>
3744
3745         Use the "direct object" form of system() to run WebKit.exe
3746
3747         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
3748         path to WebKit.exe.
3749
3750         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
3751         %WEBKITOUTPUTDIR%
3752
3753         Reviewed by Steve Falkenburg.
3754
3755         * Scripts/webkitdirs.pm:
3756         (runSafari):
3757
3758 2011-09-22  Adam Roben  <aroben@apple.com>
3759
3760         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
3761
3762         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
3763         spaces in the path to the WebKit source tree
3764
3765         Reviewed by John Sullivan.
3766
3767         * Scripts/webkitdirs.pm:
3768         (setupCygwinEnv):
3769
3770 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3771
3772         [Qt] Use same DPI for application font as rest of app in DRT and WTR
3773
3774         QApplication will initialize the default application font based
3775         on the application DPI at construction time, but we then override
3776         the application DPI using QX11Info (hard-coding it to 96 for
3777         consistency). This hard-coding is not reflected in the application
3778         font, so we explicitly have update the font ourselves.
3779
3780         The 6 test results that are updated were originally produced with
3781         a DPI of 75, as this is the default fallback DPI when a QFont is
3782         constructed before QApplication. This was wrong, and the results
3783         are updated to match a DPI of 96.
3784
3785         Reviewed by Csaba Osztrogonác.
3786
3787         * DumpRenderTree/qt/main.cpp:
3788         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3789
3790 2011-09-21  Anna Cavender  <annacc@chromium.org>
3791
3792         Update committers.py with a new contributor contact        
3793         https://bugs.webkit.org/show_bug.cgi?id=68565
3794
3795         Reviewed by Eric Carlson.
3796
3797         * Scripts/webkitpy/common/config/committers.py:
3798
3799 2011-09-21  Chang Shu  <cshu@webkit.org>
3800
3801         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
3802         https://bugs.webkit.org/show_bug.cgi?id=68108
3803
3804         This patch implements the event sender mouse events through WebKit2 UIProcess which is
3805         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
3806         platform as the first step so the existing code is still kept for other platforms.
3807
3808         Reviewed by Darin Adler.
3809
3810         * WebKitTestRunner/EventSenderProxy.h:
3811         (WTR::EventSenderProxy::EventSenderProxy):
3812         (WTR::EventSenderProxy::leapForward):
3813         (WTR::EventSenderProxy::currentEventTime):
3814         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3815         (WTR::EventSendingController::EventSendingController):
3816         (WTR::EventSendingController::mouseDown):
3817         (WTR::EventSendingController::mouseUp):
3818         (WTR::EventSendingController::mouseMoveTo):
3819         (WTR::EventSendingController::leapForward):
3820         (WTR::EventSendingController::keyDown):
3821         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3822         * WebKitTestRunner/TestController.cpp:
3823         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3824         * WebKitTestRunner/mac/EventSenderProxy.mm:
3825         (WTR::eventTypeForMouseButtonAndAction):
3826         (WTR::operator==):
3827         (WTR::EventSenderProxy::updateClickCountForButton):
3828         (WTR::EventSenderProxy::mouseDown):
3829         (WTR::EventSenderProxy::mouseUp):
3830         (WTR::EventSenderProxy::mouseMoveTo):
3831         (WTR::EventSenderProxy::keyDown):
3832         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3833         (WTR::EventSenderProxy::keyDown):
3834         (WTR::EventSenderProxy::mouseDown):
3835         (WTR::EventSenderProxy::mouseUp):
3836         (WTR::EventSenderProxy::mouseMoveTo):
3837
3838 2011-09-21  Dan Bernstein  <mitz@apple.com>
3839
3840         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
3841         https://bugs.webkit.org/show_bug.cgi?id=68451
3842
3843         Reviewed by Darin Adler.
3844
3845         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
3846         Objective-C classes with names not having one of a list of prefixes
3847         passed on the command line.
3848
3849 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
3850
3851         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
3852         https://bugs.webkit.org/show_bug.cgi?id=68206
3853
3854         Reviewed by Tony Chang.
3855
3856         * Scripts/webkitdirs.pm:
3857         (determineBaseProductDir): add support for chromium-mac
3858         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3859         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3860
3861 2011-09-21  Adam Barth  <abarth@webkit.org>
3862
3863         garden-o-matic command should explain that it is starting a local server
3864         https://bugs.webkit.org/show_bug.cgi?id=68486
3865
3866         Reviewed by Dimitri Glazkov.
3867
3868         In the user study, both participants didn't understand why the
3869         garden-o-matic command appeared to hang.  This patch adds an
3870         explaination of what's going on.  It also adds a confirmation prompt
3871         before launching the browser to give the user a chance to read the
3872         text.  If that's too much of a speed bump, we can iterate.
3873
3874         * Scripts/webkitpy/tool/commands/gardenomatic.py:
3875
3876 2011-09-21  Chang Shu  <cshu@webkit.org>
3877
3878         [Qt] Implement KeyDown function for WebKit2 EventSender.
3879         https://bugs.webkit.org/show_bug.cgi?id=56485
3880
3881         Implement the KeyDown function on Qt platform.
3882
3883         Reviewed by Andreas Kling.
3884
3885         * WebKitTestRunner/PlatformWebView.h:
3886         * WebKitTestRunner/TestController.cpp:
3887         (WTR::TestController::TestController):
3888         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3889         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
3890         (WTR::getModifiers):
3891         (WTR::EventSenderProxy::keyDown):
3892         (buildModifierFlags):
3893         (EventSenderProxy::keyDown):
3894         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3895         (WTR::PlatformWebView::sendEvent):
3896         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3897
3898 2011-09-20  Adam Barth  <abarth@webkit.org>
3899
3900         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
3901         https://bugs.webkit.org/show_bug.cgi?id=68496
3902
3903         Reviewed by Dimitri Glazkov.
3904
3905         This patch adds a bunch of sorting to make sure things happen in a
3906         predictable order in both JavaScriptCore and V8.  We've talked before
3907         about whether these two JavaScript engines should enumerate
3908         dictionaries in the same order, but the consensus has been that they
3909         shouldn't.  Personally, I disagree with that consensus, but such is life.
3910
3911         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3913         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3914         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3915
3916 2011-09-20  Adam Barth  <abarth@webkit.org>
3917
3918         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
3919         https://bugs.webkit.org/show_bug.cgi?id=68495
3920
3921         Reviewed by Dimitri Glazkov.
3922
3923         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
3924
3925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3926
3927 2011-09-20  Eric Seidel  <eric@webkit.org>
3928
3929         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
3930         https://bugs.webkit.org/show_bug.cgi?id=65781
3931
3932         Reviewed by Ryosuke Niwa.
3933
3934         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
3935         to resolve the passed in url relative to the absolute url for the test.
3936         For http tests, since the test url is an http url, we can't resolve relative
3937         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
3938         for resolving.
3939
3940         I believe this is a better approach than the on used in the Qt and Chromium DRT's
3941         (which resolves the path relative to the built location of the DRT executable)
3942         and we should move this new code into a shared location in a follow-up patch.
3943
3944         It turns out that there was a second use for pathToLocalResource, used by one
3945         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
3946         To support this test I made the new pathToLocalResource smart enough to map
3947         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
3948
3949         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3950         (LayoutTestController::pathToLocalResource):
3951         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
3952
3953 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
3954
3955         Need to specify a django version, instead of using default
3956         https://bugs.webkit.org/show_bug.cgi?id=68398
3957
3958         Reviewed by Eric Seidel.
3959
3960         * QueueStatusServer/__init__.py:
3961         * QueueStatusServer/main.py:
3962
3963 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
3964
3965         Update committers.py with a few more contributor contacts
3966         https://bugs.webkit.org/show_bug.cgi?id=68487
3967
3968         Reviewed by Eric Seidel.
3969
3970         * Scripts/webkitpy/common/config/committers.py:
3971
3972 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
3973
3974         Fix webkitpy unit tests after 95547 and 95549
3975         https://bugs.webkit.org/show_bug.cgi?id=68483
3976
3977         Reviewed by Adam Barth.
3978         
3979         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
3980
3981         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
3982         parse_entries_from_file(), use StringIO and entry.reviewer_text().
3983         While testing parse_latest_entry_from_file(), expect the correct
3984         touched_files() list.
3985
3986 2011-09-20  Adam Barth  <abarth@webkit.org>
3987
3988         garden-o-matic makes it hard to compare images when scroll bars appear
3989         https://bugs.webkit.org/show_bug.cgi?id=68482
3990
3991         Reviewed by Eric Seidel.
3992
3993         Because we autoscale image width, the images rescale if we overflow
3994         vertically and get a scrollbar.  That makes it hard to compare two sets
3995         of images.  This patch reserves space for the scrollbar so we won't
3996         have the layout change.
3997
3998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
3999
4000 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
4001
4002         Unreviewed, rolling out r95565.
4003         http://trac.webkit.org/changeset/95565
4004         https://bugs.webkit.org/show_bug.cgi?id=68470
4005
4006         Broke builds (Requested by andersca on #webkit).
4007
4008         * MiniBrowser/gtk/BrowserWindow.c:
4009         (mouseDidMoveOverElement):
4010
4011 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
4012
4013         Get hover'ed element URL from HitTest.
4014         
4015         mouseDidMoveOverElement now gets the hover'ed element link using
4016         WKHitTestResult API's.
4017         https://bugs.webkit.org/show_bug.cgi?id=68426
4018
4019         Reviewed by Anders Carlsson.
4020
4021         * MiniBrowser/gtk/BrowserWindow.c:
4022         (mouseDidMoveOverElement):
4023
4024 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
4025
4026         Changelog class should have a method to return all entries
4027         https://bugs.webkit.org/show_bug.cgi?id=68399
4028         
4029         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
4030         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
4031
4032         Reviewed by Ryosuke Niwa.
4033
4034         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
4035         and adapt it to become a generator.
4036         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
4037
4038 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
4039
4040         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
4041         https://bugs.webkit.org/show_bug.cgi?id=51159
4042
4043         Permit any URL with a local scheme to set a user style sheet. Allow qrc
4044         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
4045         
4046         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
4047
4048         Reviewed by Kenneth Rohde Christiansen.
4049
4050         * DumpRenderTree/qt/DumpRenderTree.pro:
4051         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
4052         * DumpRenderTree/qt/resources/user.css: Added.
4053         (body):
4054         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4055         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
4056         * WebKitTestRunner/qt/resources/user.css: Added.
4057         (body):
4058
4059 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
4060
4061         ChangeLogEntry class should contain a list of touched files
4062         https://bugs.webkit.org/show_bug.cgi?id=68115
4063
4064         Reviewed by Eric Seidel.
4065         
4066         Add method to return the list of files touched in a ChangeLog entry.
4067
4068         * Scripts/webkitpy/common/checkout/changelog.py: Add
4069         touched_files_regexp and touched_files() method.
4070         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
4071         unit tests for touched_files() method.
4072
4073 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
4074
4075         Unreviewed, rolling out r95526 and r95541.
4076         http://trac.webkit.org/changeset/95526
4077         http://trac.webkit.org/changeset/95541
4078         https://bugs.webkit.org/show_bug.cgi?id=68443
4079
4080         It broke 6 tests (Requested by ossy_ on #webkit).
4081
4082         * DumpRenderTree/qt/main.cpp:
4083         (main):
4084         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4085         (WTR::activateFonts):
4086
4087 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
4088
4089         Fix patch and bug numbering in the mocktool simulation code
4090         https://bugs.webkit.org/show_bug.cgi?id=68374
4091
4092         Reviewed by Adam Barth.
4093
4094         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4095         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
4096         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4097         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4098         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4099         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4100         * Scripts/webkitpy/tool/commands/download_unittest.py:
4101         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4102         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4103         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4104         * Scripts/webkitpy/tool/commands/queuestest.py:
4105         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4106         * Scripts/webkitpy/tool/mocktool.py:
4107         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4108         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
4109
4110 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4111
4112         [Qt] Don't override default QApplication font for DRT and WTR
4113
4114         Revision 95526 moved the relevant code below the QApplication
4115         constructor, to fix a potential crash, and that made the code
4116         take effect, breaking 6 tests.
4117
4118         We should rely on the QWebSettings to set default fonts, and
4119         this QApplication::setFont() is a relic from when we didn't
4120         have that option, so we remove the code.
4121
4122         Reviewed by Csaba Osztrogonác.
4123
4124         * DumpRenderTree/qt/main.cpp:
4125         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4126
4127 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4128
4129         WebKitTestRunner: Provide usage if run without arguments
4130
4131         If WTR is run without either one or more filenames, or
4132         a '-' to indicate server mode, we don't need to start
4133         up the test machinery. Doing so might actually crash,
4134         as we'll exit the application immedeatly after anyways.
4135
4136         Reviewed by Simon Hausmann.
4137
4138         * WebKitTestRunner/TestController.cpp:
4139         (WTR::TestController::initialize):
4140
4141 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4142
4143         [Qt] Don't use QFont before initializing QApplication
4144
4145         Could potentially result in crash.
4146
4147         Reviewed by Simon Hausmann.
4148
4149         * DumpRenderTree/qt/main.cpp:
4150         (main):
4151
4152 2011-09-19  Adam Barth  <abarth@webkit.org>
4153
4154         Always enable ENABLE(EVENTSOURCE)
4155         https://bugs.webkit.org/show_bug.cgi?id=68414
4156
4157         Reviewed by Eric Seidel.
4158
4159         * Scripts/build-webkit:
4160
4161 2011-09-19  David Levin  <levin@chromium.org>
4162
4163         Sheriffbot rollout should be more intuitive.
4164         https://bugs.webkit.org/show_bug.cgi?id=68415
4165
4166         Reviewed by Adam Barth.
4167
4168         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
4169         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
4170           and a few others cases.
4171         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
4172
4173 2011-09-19  David Levin  <levin@chromium.org>
4174
4175         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
4176         https://bugs.webkit.org/show_bug.cgi?id=68391
4177
4178         Reviewed by Darin Adler.
4179
4180         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
4181         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
4182
4183 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
4184
4185         Style checker should not check public Qt WK2 API for parameter_name.
4186         https://bugs.webkit.org/show_bug.cgi?id=68359
4187
4188         Reviewed by Andreas Kling.
4189
4190         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
4191         Add an exception in the style checker to disable the check. Also added the test for it.
4192
4193         * Scripts/webkitpy/style/checker.py:
4194         * Scripts/webkitpy/style/checker_unittest.py:
4195
4196 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
4197
4198         GTK DRT leaks memory while comparing history items
4199         https://bugs.webkit.org/show_bug.cgi?id=68086
4200
4201         Reviewed by Martin Robinson.
4202         
4203         webkit_web_history_item_get_target() returns a g_strdup()'d string,
4204         so memory must be freed before compareHistoryItems() returns.
4205
4206         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4207         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
4208
4209 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
4210
4211         Buildbot marks a nrwt bot red when tests are missing results
4212         https://bugs.webkit.org/show_bug.cgi?id=64812
4213
4214         Reviewed by Ryosuke Niwa.
4215
4216         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4217         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4218
4219 2011-09-19  Jessie Berlin  <jberlin@apple.com>
4220
4221         Sites that use history pushState or replaceState are recorded in history in Private Browsing
4222         mode.
4223         https://bugs.webkit.org/show_bug.cgi?id=68208
4224
4225         Reviewed by Brady Eidson.
4226
4227         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
4228         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
4229
4230         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
4231         (TestWebKitAPI::didNavigateWithNavigationData):
4232         This is a context history client callback, so it should not be called when in Private
4233         Browsing. Add a call to FAIL().
4234         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4235         This is a page load client callback that happens after the didNavigateWithNavigationData
4236         callback. End the test.
4237         (TestWebKitAPI::TEST):
4238         Enable Private Browsing and load a page that uses history.pushState.
4239
4240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4241         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
4242         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
4243         Ditto.
4244         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4245         Ditto.
4246         * TestWebKitAPI/win/copy-resources.cmd:
4247         Ditto.
4248
4249 2011-09-16  Elliot Poger  <epoger@google.com>
4250
4251         add non-CG Webkit-Mac builds to flakiness dashboard
4252         https://bugs.webkit.org/show_bug.cgi?id=68265
4253
4254         Reviewed by Adam Barth.
4255
4256         As Chromium-on-Mac approaches the switchover from Core Graphics to
4257         Skia, we need to add the Skia version to the flakiness dashboard.
4258
4259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4260         * TestResultServer/static-dashboards/builders.js:
4261         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
4262
4263 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
4264
4265         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
4266         https://bugs.webkit.org/show_bug.cgi?id=68071
4267
4268         Reviewed by Adam Barth.
4269
4270         * DumpRenderTree/chromium/WebPermissions.cpp:
4271         (WebPermissions::allowImage):
4272         * DumpRenderTree/chromium/WebPermissions.h:
4273
4274 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
4275
4276         update-webkit-chromium should retry the gclient call if it fails once
4277         https://bugs.webkit.org/show_bug.cgi?id=68252
4278
4279         Reviewed by Adam Barth.
4280
4281         * Scripts/update-webkit-chromium:
4282
4283 2011-09-16  Rob Buis  <rbuis@rim.com>
4284
4285         Add Eli's rim address and change the nick.
4286
4287         * Scripts/webkitpy/common/config/committers.py:
4288
4289 2011-09-16  Anders Carlsson  <andersca@apple.com>
4290
4291         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
4292         https://bugs.webkit.org/show_bug.cgi?id=68269
4293
4294         Reviewed by Geoffrey Garen.
4295
4296         Update client function signatures.
4297
4298         * MiniBrowser/gtk/BrowserWindow.c:
4299         (browserWindowUIClientInit):
4300         * MiniBrowser/mac/BrowserWindowController.m:
4301         (mouseDidMoveOverElement):
4302         (-[BrowserWindowController awakeFromNib]):
4303         * MiniBrowser/win/BrowserView.cpp:
4304         (BrowserView::create):
4305         * WebKitTestRunner/TestController.cpp:
4306         (WTR::TestController::createOtherPage):
4307         (WTR::TestController::initialize):
4308
4309 2011-09-16  Anders Carlsson  <andersca@apple.com>
4310
4311         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
4312         https://bugs.webkit.org/show_bug.cgi?id=68266
4313
4314         Reviewed by John Sullivan.
4315
4316         * MiniBrowser/mac/BrowserWindowController.m:
4317         (mouseDidMoveOverElement):
4318
4319 2011-09-16  Vincent Scheib  <scheib@chromium.org>
4320
4321         Add Vincent Scheib to the committers list.
4322
4323         * Scripts/webkitpy/common/config/committers.py:
4324
4325 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
4326
4327         Unreviewed, rolling out r95285.
4328         http://trac.webkit.org/changeset/95285
4329         https://bugs.webkit.org/show_bug.cgi?id=68247
4330
4331         It broke a webkitpy test (