[GTK] Gardening 21st April.
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] MiniBrowser should use NetworkProcess by default
4         https://bugs.webkit.org/show_bug.cgi?id=143948
5
6         Reviewed by Sergio Villar Senin.
7
8         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
9         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
10
11         * MiniBrowser/gtk/main.c:
12         (main):
13
14 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
15
16         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
17
18         Unreviewed build fix.
19
20         * Scripts/prepare-ChangeLog:
21         (get_function_line_ranges_for_cpp):
22         Use grep instead of any to determine if a string is an element of an array.
23
24 2015-04-21  Anders Carlsson  <andersca@apple.com>
25
26         Fix block signatures
27         https://bugs.webkit.org/show_bug.cgi?id=144002
28
29         Reviewed by Andreas Kling.
30
31         * MiniBrowser/mac/WK2BrowserWindowController.m:
32         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
33
34 2015-04-21  Philippe Normand  <pnormand@igalia.com>
35
36         [GTK] jhbuild should not use a branch for openwebrtc
37         https://bugs.webkit.org/show_bug.cgi?id=143981
38
39         Reviewed by Carlos Garcia Campos.
40
41         * gtk/jhbuild.modules:
42
43 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
44
45         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
46
47         Unreviewed build fix.
48
49         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
50         However, it has been exposed by List::MoreUtils since its inception. This patch uses
51         the any function exposed by List::MoreUtils for greater compatibility.
52
53         * Scripts/prepare-ChangeLog:
54         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
55         the any function in all of versions of Perl used by our infrastructure.
56
57 2015-04-20  Alex Christensen  <achristensen@webkit.org>
58
59         Remove unnecessary logs when resetting tests.
60
61         * WebKitTestRunner/mac/TestControllerMac.mm:
62         (WTR::TestController::platformResetPreferencesToConsistentValues):
63         In r183020 I added some logs when compiling or removing content extensions fails.
64         We often try to remove a content extension that does not exist, and that is not a problem.
65
66 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
67
68         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
69         https://bugs.webkit.org/show_bug.cgi?id=143897
70
71         Reviewed by David Kilzer.
72
73         This is a speculative fix that addresses two issues:
74
75         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
76         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
77
78         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
79         Before: (723, 729)
80         After: (721, 720)
81
82         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
83         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
84
85         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
86         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
87
88         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
89
90         2. Creating git diffs from HEAD and not origin/master by default.
91
92         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
93         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
94
95         * Scripts/prepare-ChangeLog:
96         (originalFile):
97         Use HEAD instead of origin/master in default Git case.
98
99         (generateFunctionLists):
100         Ensure that the end line is not less than the start line.
101
102         (extractLineRangeAfterChange):
103         Set the end line to the start line if the end line is less than the start line.
104
105         (extractLineRangeBeforeChange):
106         Ditto.
107
108 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
109
110         Suppress warning in prepare-ChangeLog.
111         https://bugs.webkit.org/show_bug.cgi?id=143882
112
113         Reviewed by David Kilzer.
114
115         Prune noisy prepare-ChangeLog output by using the List::Util::any function
116         instead of the deprecated smartmatch operator.
117
118         * Scripts/prepare-ChangeLog:
119         Import the List::Util::any function.
120
121         (get_function_line_ranges_for_cpp):
122         Use the any function instead of smartmatch.
123
124 2015-04-20  Anders Carlsson  <andersca@apple.com>
125
126         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
127         https://bugs.webkit.org/show_bug.cgi?id=143966
128
129         Reviewed by Dan Bernstein.
130
131         * MiniBrowser/mac/WK2BrowserWindowController.m:
132         (dataTypes):
133         (-[WK2BrowserWindowController fetchWebsiteData:]):
134         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
135         (-[WK2BrowserWindowController clearWebsiteData:]):
136
137 2015-04-20  Alex Christensen  <achristensen@webkit.org>
138
139         Fix content extension test flakiness.
140         https://bugs.webkit.org/show_bug.cgi?id=143950
141
142         Reviewed by Brady Eidson.
143
144         * WebKitTestRunner/mac/TestControllerMac.mm:
145         (WTR::TestController::platformResetPreferencesToConsistentValues):
146         Remove the TestContentExtensions if it exists.
147         (WTR::TestController::platformConfigureViewForTest):
148         Log errors in case there are any.
149
150 2015-04-20  Alex Christensen  <achristensen@webkit.org>
151
152         Properly report errors from _WKUserContentExtensionStore.
153         https://bugs.webkit.org/show_bug.cgi?id=143808
154
155         Reviewed by Darin Adler.
156
157         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
158         (TEST_F):
159
160 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
161
162         Add a rule for NetworkCache to watchlist file
163         https://bugs.webkit.org/show_bug.cgi?id=143945
164
165         Reviewed by Sergio Villar Senin.
166
167         And add myself to the list of watchers.
168
169         * Scripts/webkitpy/common/config/watchlist:
170
171 2015-04-19  Darin Adler  <darin@apple.com>
172
173         Update RefPtr documentation and deprecation
174         https://bugs.webkit.org/show_bug.cgi?id=143936
175
176         Reviewed by Andreas Kling.
177
178         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
179
180 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
181
182         Introduce bytecode intrinsics
183         https://bugs.webkit.org/show_bug.cgi?id=143926
184
185         Reviewed by Filip Pizlo.
186
187         Change cpplint to accept emit_intrinsic_XXX.
188
189         * Scripts/webkitpy/style/checkers/cpp.py:
190         (check_identifier_name_in_declaration):
191
192 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
193
194         Fix lldb_webkit.py to show StringImpls correctly
195         https://bugs.webkit.org/show_bug.cgi?id=143920
196
197         Reviewed by Andreas Kling.
198         
199         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
200
201         * lldb/lldb_webkit.py:
202         (WTFStringImplProvider.is_8bit):
203
204 2015-04-17  Daniel Bates  <dabates@apple.com>
205
206         Not able to build WebKit against iOS Simulator 8.3 SDK
207         https://bugs.webkit.org/show_bug.cgi?id=143883
208
209         Reviewed by David Kilzer.
210
211         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
212         so that Xcode uses them.
213
214         * Scripts/copy-webkitlibraries-to-product-directory:
215
216 2015-04-17  Beth Dakin  <bdakin@apple.com>
217
218         Force mouse events should go through normal mouse event handling code paths
219         https://bugs.webkit.org/show_bug.cgi?id=143749
220         -and corresponding-
221         rdar://problem/20472895
222
223         Reviewed by Dean Jackson.
224
225         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
226         Since there is not a way to create an NSEventTypePressure from scratch, we 
227         subclass NSEvent and override all of the critical methods.
228
229         * WebKitTestRunner/EventSenderProxy.h:
230         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
231         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
232         (WTR::EventSendingController::mouseForceDown):
233         (WTR::EventSendingController::mouseForceUp):
234         (WTR::EventSendingController::mouseForceChanged):
235         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
236         * WebKitTestRunner/TestController.cpp:
237         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
238         * WebKitTestRunner/mac/EventSenderProxy.mm:
239         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
240         (-[EventSenderPressureEvent timestamp]):
241         (-[EventSenderPressureEvent type]):
242         (-[EventSenderPressureEvent locationInWindow]):
243         (-[EventSenderPressureEvent location]):
244         (-[EventSenderPressureEvent stage]):
245         (-[EventSenderPressureEvent pressure]):
246         (-[EventSenderPressureEvent phase]):
247         (-[EventSenderPressureEvent eventNumber]):
248         (WTR::EventSenderProxy::mouseForceDown):
249         (WTR::EventSenderProxy::mouseForceUp):
250         (WTR::EventSenderProxy::mouseForceChanged):
251
252 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
253
254         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
255         https://bugs.webkit.org/show_bug.cgi?id=143885
256
257         Reviewed by Tim Horton.
258
259         Fixed a case where we have two builds with the same revision(s). An in order build
260         is one for which the revision is strictly higher.
261
262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
263         (BuildbotQueue.prototype._checkForInOrderResult):
264         (BuildbotQueue.prototype.compareIterationsByRevisions):
265
266 2015-04-17  Commit Queue  <commit-queue@webkit.org>
267
268         Unreviewed, rolling out r182912 and r182920.
269         https://bugs.webkit.org/show_bug.cgi?id=143881
270
271         Build breakage in some configurations (Requested by ap on
272         #webkit).
273
274         Reverted changesets:
275
276         "Force mouse events should go through normal mouse event
277         handling code paths"
278         https://bugs.webkit.org/show_bug.cgi?id=143749
279         http://trac.webkit.org/changeset/182912
280
281         http://trac.webkit.org/changeset/182920
282
283 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
284
285         [GTK] One more unreviewed fix after r182882.
286
287         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
288
289 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
290
291         [GTK] Unreviewed speculative clean build fix after r182882.
292
293         TestWebKitAPI's forwarding header generator depended on WeKit2's
294         which generated SOUP related forwarding headers too.
295
296         This dependency isn't necessary and was removed by r182882 to make
297         forwarding header generators parallelizable. But in this case
298         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
299         should generate SOUP related forwarding headers too similar to EFL.
300
301         * TestWebKitAPI/PlatformGTK.cmake:
302         * WebKitTestRunner/PlatformGTK.cmake:
303
304 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
305
306         [SOUP] Redirect to non HTTP destination is broken
307         https://bugs.webkit.org/show_bug.cgi?id=143866
308
309         Reviewed by Sergio Villar Senin.
310
311         Add a unit test to check that redirect to a data URI works.
312
313         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
314         (testRedirectToDataURI):
315         (serverCallback):
316         (beforeAll):
317
318 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
319
320         Changes method of quitting iOS Simulator to be more correct.
321         https://bugs.webkit.org/show_bug.cgi?id=143847
322         <rdar://problem/20530344>
323
324         Reviewed by Darin Adler.
325
326         Fixes by addressing the app by ID rather than by name.
327
328         * Scripts/webkitdirs.pm:
329         (quitIOSSimulator):
330         * Scripts/webkitpy/port/ios.py:
331         (IOSSimulatorPort.check_sys_deps):
332
333 2015-04-16  Anders Carlsson  <andersca@apple.com>
334
335         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
336         https://bugs.webkit.org/show_bug.cgi?id=143844
337
338         Reviewed by Dan Bernstein.
339
340         * MiniBrowser/mac/AppDelegate.m:
341         (-[BrowserAppDelegate newPrivateWindow:]):
342         * MiniBrowser/mac/WK2BrowserWindowController.m:
343         (-[WK2BrowserWindowController initWithConfiguration:]):
344         (-[WK2BrowserWindowController fetchWebsiteData:]):
345         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
346         (-[WK2BrowserWindowController clearWebsiteData:]):
347
348 2015-04-16  Alex Christensen  <achristensen@webkit.org>
349
350         32-bit build fix.
351
352         * WebKitTestRunner/mac/TestControllerMac.mm:
353         (WTR::TestController::platformResetPreferencesToConsistentValues):
354         (WTR::TestController::platformConfigureViewForTest):
355         Added WK_API_ENABLED.
356
357 2015-04-16  Alex Christensen  <achristensen@webkit.org>
358
359         Removed unused WKUserContentFilterRef.
360         https://bugs.webkit.org/show_bug.cgi?id=143852
361
362         Reviewed by Sam Weinig.
363
364         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
365         * WebKitTestRunner/mac/TestControllerMac.mm:
366         (WTR::TestController::platformResetPreferencesToConsistentValues):
367         (WTR::TestController::platformConfigureViewForTest):
368
369 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
370
371         Unreviewed. Adding myself as a commiter in contributers.json.
372
373         * Scripts/webkitpy/common/config/contributors.json:
374
375 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
376
377         It is very hard to attach a debugger to WebProcess to debug tests
378         https://bugs.webkit.org/show_bug.cgi?id=143837
379
380         Reviewed by Chris Dumez.
381
382         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
383         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
384
385         Now it disables all timeouts in tools, as is best for debugging tests.
386
387         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
388         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
389
390         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
391         now has the same functionality.
392
393 2015-04-16  Beth Dakin  <bdakin@apple.com>
394
395         Force mouse events should go through normal mouse event handling code paths
396         https://bugs.webkit.org/show_bug.cgi?id=143749
397         -and corresponding-
398         rdar://problem/20472895
399
400         Reviewed by Dean Jackson.
401
402         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
403         Since there is not a way to create an NSEventTypePressure from scratch, we 
404         subclass NSEvent and override all of the critical methods.
405
406         * WebKitTestRunner/EventSenderProxy.h:
407         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
408         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
409         (WTR::EventSendingController::mouseForceDown):
410         (WTR::EventSendingController::mouseForceUp):
411         (WTR::EventSendingController::mouseForceChanged):
412         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
413         * WebKitTestRunner/TestController.cpp:
414         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
415         * WebKitTestRunner/mac/EventSenderProxy.mm:
416         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
417         (-[EventSenderPressureEvent timestamp]):
418         (-[EventSenderPressureEvent type]):
419         (-[EventSenderPressureEvent locationInWindow]):
420         (-[EventSenderPressureEvent location]):
421         (-[EventSenderPressureEvent stage]):
422         (-[EventSenderPressureEvent pressure]):
423         (-[EventSenderPressureEvent phase]):
424         (-[EventSenderPressureEvent eventNumber]):
425         (WTR::EventSenderProxy::mouseForceDown):
426         (WTR::EventSenderProxy::mouseForceUp):
427         (WTR::EventSenderProxy::mouseForceChanged):
428
429 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
430
431         [EFL] Bump LLVM to version 3.6.0 on X86_64
432         https://bugs.webkit.org/show_bug.cgi?id=143604
433
434         Reviewed by Gyuyoung Kim.
435
436         * efl/jhbuild.modules:
437         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
438         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
439         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
440         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
441
442 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
443
444         [EFL] Remove an unnecessary workaround from jhbuildrc
445         https://bugs.webkit.org/show_bug.cgi?id=143823
446
447         Reviewed by Gyuyoung Kim.
448
449         * efl/jhbuildrc:
450
451 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
452
453         [GTK] Run forwarding headers generator unconditionally
454         https://bugs.webkit.org/show_bug.cgi?id=143819
455
456         Reviewed by Carlos Garcia Campos.
457
458         * TestWebKitAPI/PlatformGTK.cmake:
459         * WebKitTestRunner/PlatformGTK.cmake:
460
461 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
462
463         [EFL] Add gnutls to jhbuild.module
464         https://bugs.webkit.org/show_bug.cgi?id=143777
465
466         Reviewed by Csaba Osztrogonác.
467
468         EFL port has required at least 3.0.0 version of gnutls since r176712.
469         However some old linux distributions don't support 3.0.0 version. Besides
470         other projects sometimes need to use lower version of gnutls.
471
472         This patch supports to download gnutls through jhbuild, and use it.
473
474         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
475         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
476
477 2015-04-15  Mark Lam  <mark.lam@apple.com>
478
479         Remove obsolete VMInspector debugging tool.
480         https://bugs.webkit.org/show_bug.cgi?id=143798
481
482         Reviewed by Michael Saboff.
483
484         * TestWebKitAPI/CMakeLists.txt:
485         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
486         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
488         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
489
490 2015-04-15  Jer Noble  <jer.noble@apple.com>
491
492         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
493
494         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
495
496 2015-04-15  Jer Noble  <jer.noble@apple.com>
497
498         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
499
500         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
501         (TestWebKitAPI::TEST_F):
502
503 2015-04-15  Chris Dumez  <cdumez@apple.com>
504
505         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
506         https://bugs.webkit.org/show_bug.cgi?id=143779
507
508         Reviewed by Brent Fulgham.
509
510         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
511         similarly to what is done on Mac / WK1. Without this, PageCache could
512         stay enabled after page cache tests and cause weird behaviors.
513
514         * DumpRenderTree/win/DumpRenderTree.cpp:
515         (resetWebPreferencesToConsistentValues):
516
517 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
518
519         Re-enable custom dilation for antialiased fonts
520         https://bugs.webkit.org/show_bug.cgi?id=143738
521
522         Reviewed by Tim Horton.
523         
524         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
525         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
526         a private WebKit pref. This pref defaults to YES, enabling the feature by default
527         in WK1 as we do for WK2.
528
529         * DumpRenderTree/mac/DumpRenderTree.mm:
530         (resetWebPreferencesToConsistentValues):
531         * WebKitTestRunner/TestController.cpp:
532         (WTR::TestController::resetPreferencesToConsistentValues):
533
534 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
535
536         Correct layering violation in DumpRenderTree Build
537         https://bugs.webkit.org/show_bug.cgi?id=143732
538
539         Reviewed by Simon Fraser.
540
541         Correct a layering violation in DumpRenderTree by calling functions on the
542         WebCoreTestSupport library, rather than attempting to work with WebCore
543         types directly.
544
545         * DumpRenderTree/mac/EventSendingController.mm:
546         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
547         than WebCore itself.,
548         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
549
550 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
551
552         Add a conservative DFA minimizer for the content extension matcher
553         https://bugs.webkit.org/show_bug.cgi?id=143501
554
555         Reviewed by Alex Christensen.
556
557         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
558         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
559
560 2015-04-14  Daniel Bates  <dabates@apple.com>
561
562         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
563         https://bugs.webkit.org/show_bug.cgi?id=143693
564         <rdar://problem/20530316>
565
566         Reviewed by Tim Horton.
567
568         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
569         to use the fixed layout code on iOS at this time.
570
571         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
572
573 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
574
575         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
576         https://bugs.webkit.org/show_bug.cgi?id=143705
577
578         Unreviewed change to watchlist file.
579
580         * Scripts/webkitpy/common/config/watchlist:
581
582 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
583
584         [EFL] favicon wasn't updated for google.com sometimes.
585         https://bugs.webkit.org/show_bug.cgi?id=141940
586
587         Reviewed by Gyuyoung Kim.
588
589         As elm_entry_utf8_to_markup can include additional characters, parameter for the
590         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
591
592         * MiniBrowser/efl/main.c:
593         (on_url_changed):
594
595 2015-04-13  Tim Horton  <timothy_horton@apple.com>
596
597         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
598         https://bugs.webkit.org/show_bug.cgi?id=143560
599         <rdar://problem/16302047>
600
601         Reviewed by Darin Adler.
602
603         * MiniBrowser/mac/BrowserWindowController.h:
604         * MiniBrowser/mac/MainMenu.xib:
605         * MiniBrowser/mac/WK1BrowserWindowController.m:
606         (-[WK1BrowserWindowController setScale:]):
607         * MiniBrowser/mac/WK2BrowserWindowController.m:
608         (viewScaleForMenuItemTag):
609         (-[WK2BrowserWindowController setScale:]):
610         (-[WK2BrowserWindowController validateMenuItem:]):
611         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
612         When in use, we resize the window so that the view fits correctly, and
613         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
614         layout size will not change when scaling down (but will update appropriately
615         when the view is resized).
616
617 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
618
619         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
620         https://bugs.webkit.org/show_bug.cgi?id=138630
621
622         Reviewed by Tim Horton.
623
624         Make sure that we always load at least one in order productive iteration.
625
626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
627         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
628         is done loading at least one iteration that wasn't an out of order build.
629         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
630         when that's needed to check for out of order builds.
631         (BuildbotQueue.prototype.update): Ditto.
632         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
633         result, and if it does not, load more iterations.
634         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
635         an in order iteration loaded too.
636         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
637         corrected to always sort loaded iterations before unloaded ones.
638
639 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
640
641         Expand test infrastructure to support scrolling tests
642         https://bugs.webkit.org/show_bug.cgi?id=143286
643         <rdar://problem/20375516>
644
645         Reviewed by Simon Fraser.
646
647         Extend the WK1 and WK2 test programs to support two new EventSender commands:
648         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
649         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
650         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
651         relevant rubberband, scroll, and scroll-snap animations are finished.
652
653         * DumpRenderTree/mac/EventSendingController.mm:
654         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
655         and 'monitorWheelEvents'.
656         (+[EventSendingController webScriptNameForSelector:]): Ditto.
657         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
658         debugging test failures.
659         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
660         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
661         function, then passes it to WebCore to be called once the test deferrals have been cleared.
662         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
663         'callAfterScrollingCompletes' method.
664         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
665         and 'monitorWheelEvents'.
666         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
667         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
668         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
669         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
670         'callAfterScrollingComplates' method.
671         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
672
673 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
674
675         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
676         https://bugs.webkit.org/show_bug.cgi?id=143656
677
678         Reviewed by Darin Adler.
679
680         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
681         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
682
683 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
684
685         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
686         https://bugs.webkit.org/show_bug.cgi?id=142387
687
688         Reviewed by Carlos Garcia Campos.
689
690         Running mixed content is blocked by default since r181134. Updated
691         the test case to reflect the new default settings.
692
693         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
694         (testInsecureContent):
695
696 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
697
698         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
699         https://bugs.webkit.org/show_bug.cgi?id=143667
700
701         Reviewed by Csaba Osztrogonác.
702
703         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
704         since r169017. Added $hardwareConcurrencySupport for it.
705
706         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
707
708         * Scripts/webkitperl/FeatureList.pm:
709
710 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
711
712         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
713         https://bugs.webkit.org/show_bug.cgi?id=143664
714
715         Reviewed by Gyuyoung Kim.
716
717         * Scripts/webkitperl/FeatureList.pm:
718
719 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
720
721         [EFL] Enable Media Source
722         https://bugs.webkit.org/show_bug.cgi?id=143635
723
724         Reviewed by Csaba Osztrogonác.
725
726         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
727
728 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
729
730         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
731         https://bugs.webkit.org/show_bug.cgi?id=143646
732
733         Reviewed by David Kilzer.
734
735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
736         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
737
738 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
739
740         Use en_US spell checker for tests on Mac instead of Multilingual
741         https://bugs.webkit.org/show_bug.cgi?id=143641
742
743         Reviewed by Dan Bernstein.
744
745         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
746         While at it, override NSUserDictionaryReplacementItems, so that user replacements
747         cannot affect tests.
748
749         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
750         Made this more like WebKit1 version.
751
752 2015-04-10  Tim Horton  <timothy_horton@apple.com>
753
754         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
755         https://bugs.webkit.org/show_bug.cgi?id=143576
756
757         Reviewed by Simon Fraser.
758
759         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
760         (TEST):
761         Adopt.
762
763 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
764
765         Update my email address and expertise.
766         https://bugs.webkit.org/show_bug.cgi?id=143586
767
768         Unreviewed, just update my info.
769
770         * Scripts/webkitpy/common/config/contributors.json:
771
772 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
773
774         Flakiness Dashboard not loading insecure content if loaded with https URL
775         https://bugs.webkit.org/show_bug.cgi?id=143570
776
777         Reviewed by Alexey Proskuryakov.
778
779         * TestResultServer/app.yaml:
780         * TestResultServer/static-dashboards/loader.js:
781         Switch to https scheme.
782
783 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
784
785         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
786         https://bugs.webkit.org/show_bug.cgi?id=142907
787
788         Reviewed by Carlos Garcia Campos.
789
790         * TestWebKitAPI/PlatformEfl.cmake:
791         * TestWebKitAPI/PlatformGTK.cmake:
792         * WebKitTestRunner/PlatformEfl.cmake:
793         * WebKitTestRunner/PlatformGTK.cmake:
794
795 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
796
797         [Mac] Unreviewed test fix after r182584
798         https://bugs.webkit.org/show_bug.cgi?id=143452
799
800         Put both of these tests back to their original state now that the underlying
801         problem is fixed.
802
803         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
804         (TestWebKitAPI::TEST):
805         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
806         (TestWebKitAPI::TEST):
807
808 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
809
810         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
811         https://bugs.webkit.org/show_bug.cgi?id=143553
812
813         Reviewed by Ryosuke Niwa.
814         
815         Remove the spurious printVMs left over from an earlier change.
816
817         * Scripts/run-jsc-benchmarks:
818
819 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
820
821         [Mac] Unreviewed test fix after r182581
822
823         The behavior of control-left-click is controlled by a system preference.
824         Our test bots have this turned off.
825
826         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
827         (TestWebKitAPI::TEST):
828         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
829         (TestWebKitAPI::TEST):
830
831 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
832
833         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
834         https://bugs.webkit.org/show_bug.cgi?id=143452
835         <rdar://problem/20437483>
836
837         Reviewed by Tim Horton.
838
839         Add a new API test to confirm that Cocoa mouse button press events are properly
840         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
841
842         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
843         some registered event handlers that the expected button press and context menu
844         events are received.
845
846         The WK1 unit test creates an NSEvent with the desired button press state, and then
847         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
848         We check the resulting PlatformMouseEvent for proper state.
849
850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
851         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
852         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
853         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
854         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
855         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
856         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
857         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
858         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
859         mouse down events.
860         * TestWebKitAPI/mac/PlatformWebViewMac.h:
861
862 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
863
864         [GTK] Add pango to jhbuild-optional.modules
865         https://bugs.webkit.org/show_bug.cgi?id=143537
866
867         Reviewed by Martin Robinson.
868
869         * gtk/jhbuild-optional.modules: Add pango.
870
871 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
872
873         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
874         https://bugs.webkit.org/show_bug.cgi?id=143530
875
876         Reviewed by Žan Doberšek.
877
878         Assume that the default value for display (:0) is reserved and start checking on :1
879         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
880         and for X server named Xorg.bin (previous bug 1376599)
881
882         * Scripts/webkitpy/port/xvfbdriver.py:
883         (XvfbDriver._next_free_display)
884         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
885         (XvfbDriverTest.test_start_no_pixel_tests):
886         (XvfbDriverTest.test_start_pixel_tests):
887         (XvfbDriverTest.test_start_arbitrary_worker_number):
888         (XvfbDriverTest.test_next_free_display):
889         (XvfbDriverTest.test_start_next_worker):
890 2015-04-08  Alex Christensen  <achristensen@webkit.org>
891
892         Block popups from content extensions.
893         https://bugs.webkit.org/show_bug.cgi?id=143497
894
895         Reviewed by Brady Eidson.
896
897         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
898         (TestWebKitAPI::TEST_F):
899         Added popup test.
900
901 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
902
903         Add CMake build system for WinCairo port.
904         https://bugs.webkit.org/show_bug.cgi?id=115944
905
906         Reviewed by Chris Dumez.
907
908         * CMakeLists.txt:
909         * WinLauncher/CMakeLists.txt: Added.
910
911 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
912
913         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
914         https://bugs.webkit.org/show_bug.cgi?id=143521
915
916         Reviewed by Martin Robinson.
917
918         Add a way to detect unexpected web process crashes to WebViewTest,
919         and a test case to testDOMCache to trigger the crash.
920
921         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
922         (WebKitDOMNodeTest::testDOMCache):
923         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
924         (testWebKitWebViewProcessCrashed):
925         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
926         (WebViewTest::WebViewTest):
927         (WebViewTest::webProcessCrashed):
928         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
929
930 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
931
932         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
933         rdar://problem/20461342
934
935         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
936
937 2015-04-07  Commit Queue  <commit-queue@webkit.org>
938
939         Unreviewed, rolling out r182511.
940         https://bugs.webkit.org/show_bug.cgi?id=143507
941
942         caused debug test failures (Requested by alexchristensen on
943         #webkit).
944
945         Reverted changeset:
946
947         "Block popups from content extensions."
948         https://bugs.webkit.org/show_bug.cgi?id=143497
949         http://trac.webkit.org/changeset/182511
950
951 2015-04-07  Alex Christensen  <achristensen@webkit.org>
952
953         Block popups from content extensions.
954         https://bugs.webkit.org/show_bug.cgi?id=143497
955
956         Reviewed by Brady Eidson.
957
958         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
959         (TestWebKitAPI::TEST_F):
960         Added popup test.
961
962 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
963
964         Get the features.json files ready for open contributions
965         https://bugs.webkit.org/show_bug.cgi?id=143436
966
967         Reviewed by Darin Adler.
968
969         * Scripts/webkitpy/style/checkers/jsonchecker.py:
970         (JSONFeaturesChecker.check):
971         Extend the syntax checking a bit, but leave everything non-mandatory
972         very loose until we figure what fields are important.
973
974 2015-04-07  Tim Horton  <timothy_horton@apple.com>
975
976         Expose and test fixedLayoutSize via modern WebKit SPI
977         https://bugs.webkit.org/show_bug.cgi?id=143500
978
979         Reviewed by Simon Fraser.
980
981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
982         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
983         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
984         (TEST):
985         Add a test that verifies that fixedLayoutSize works at all, that
986         it persists through a navigation, and that turning it back off reverts to
987         laying out at the size of the view.
988
989 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
990
991         Unreviewed. Add myself as a committer.
992
993         * Scripts/webkitpy/common/config/contributors.json:
994
995 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
996
997         [Win] Bots complain about missing /etc/catalog
998         https://bugs.webkit.org/show_bug.cgi?id=143484
999
1000         Reviewed by Chris Dumez.
1001
1002         The libxml2 build on Mac, iOS, and Windows does not provide the set
1003         of default catalog files. We do not actually need these for our
1004         purposes, but we get warnings and some bot flakiness because they
1005         are not present.
1006
1007         We can avoid both problems the same way the Mac and iOS ports do,
1008         by setting the XML_CATALOG_FILES environment variable to 'empty string',
1009         which avoid the warnings and bot problems.
1010
1011         * Scripts/webkitpy/port/win.py:
1012         (WinPort.setup_environ_for_server): Added.
1013
1014 2015-04-06  Sam Weinig  <sam@webkit.org>
1015
1016         Use content extensions in MiniBrowser.
1017         https://bugs.webkit.org/show_bug.cgi?id=143446
1018
1019         Reviewed by Alex Christensen.
1020
1021         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1022         * MiniBrowser/mac/AppDelegate.h:
1023         * MiniBrowser/mac/AppDelegate.m:
1024         (-[BrowserAppDelegate init]):
1025         (-[BrowserAppDelegate showExtensionsManager:]):
1026         (-[BrowserAppDelegate userContentContoller]):
1027         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1028         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1029         (-[ExtensionManagerWindowController init]):
1030         (-[ExtensionManagerWindowController windowDidLoad]):
1031         (-[ExtensionManagerWindowController add:]):
1032         (-[ExtensionManagerWindowController remove:]):
1033         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1034         * MiniBrowser/mac/MainMenu.xib:
1035
1036 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1037
1038         web-platform-tests server should retrieve the modules file relatively to its docroot path
1039         https://bugs.webkit.org/show_bug.cgi?id=142742
1040
1041         Reviewed by Darin Adler.
1042
1043         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1044         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
1045
1046 2015-04-06  Commit Queue  <commit-queue@webkit.org>
1047
1048         Unreviewed, rolling out r182445.
1049         https://bugs.webkit.org/show_bug.cgi?id=143459
1050
1051         broke 32 bit build (Requested by alexchristensen on #webkit).
1052
1053         Reverted changeset:
1054
1055         "Use content extensions in MiniBrowser."
1056         https://bugs.webkit.org/show_bug.cgi?id=143446
1057         http://trac.webkit.org/changeset/182445
1058
1059 2015-04-06  Sam Weinig  <sam@webkit.org>
1060
1061         Use content extensions in MiniBrowser.
1062         https://bugs.webkit.org/show_bug.cgi?id=143446
1063
1064         Reviewed by Alex Christensen.
1065
1066         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1067         * MiniBrowser/mac/AppDelegate.h:
1068         * MiniBrowser/mac/AppDelegate.m:
1069         (-[BrowserAppDelegate init]):
1070         (-[BrowserAppDelegate showExtensionsManager:]):
1071         (-[BrowserAppDelegate userContentContoller]):
1072         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1073         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1074         (-[ExtensionManagerWindowController init]):
1075         (-[ExtensionManagerWindowController windowDidLoad]):
1076         (-[ExtensionManagerWindowController add:]):
1077         (-[ExtensionManagerWindowController remove:]):
1078         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1079         * MiniBrowser/mac/MainMenu.xib:
1080
1081 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1082
1083         [GTK] install-dependencies should prefer dnf to yum
1084         https://bugs.webkit.org/show_bug.cgi?id=143441
1085
1086         Reviewed by Martin Robinson.
1087
1088         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
1089
1090         * gtk/install-dependencies:
1091
1092 2015-04-06  Andy Estes  <aestes@apple.com>
1093
1094         [iOS] 'make clean' fails in Tools/WebKitTestRunner
1095         https://bugs.webkit.org/show_bug.cgi?id=143455
1096
1097         Reviewed by Dan Bernstein.
1098
1099         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
1100         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
1101
1102         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
1103
1104 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
1105
1106         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
1107         https://bugs.webkit.org/show_bug.cgi?id=143450
1108
1109         Reviewed by Anders Carlsson.
1110
1111         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
1112         Make sure that the view is actually closed, regardless of anything else that happens beneath.
1113         Also, removed unnecessary get() calls.
1114
1115 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
1116
1117         Reduce the dependency on Flash in regression tests
1118         https://bugs.webkit.org/show_bug.cgi?id=143391
1119
1120         Reviewed by Anders Carlsson.
1121
1122         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
1123         Only allow QuickTime and the test plug-in.
1124
1125 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1126
1127         W3C test importer should generate the modules installed dynamically to run wpt tests
1128         https://bugs.webkit.org/show_bug.cgi?id=142738
1129
1130         Reviewed by Ryosuke Niwa.
1131
1132         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
1133         The implementation is done within TestDownloader and it is activated for the WPT repository.
1134         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
1135
1136         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1137         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
1138         * Scripts/webkitpy/w3c/test_downloader.py:
1139         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
1140         (TestDownloader):
1141         (TestDownloader._git_submodules_description): Computes submodule description.
1142         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
1143         * Scripts/webkitpy/w3c/test_importer.py:
1144         (TestImporter.do_import): Added the possibility to post process the tests.
1145         (TestImporter):
1146         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
1147         (TestImporter.should_convert_test_harness_links): Updated according new options format.
1148         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1149         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
1150         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
1151         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
1152         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
1153         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
1154
1155 2015-04-05  Antti Koivisto  <antti@apple.com>
1156
1157         Bloom filter should support longer hashes
1158         https://bugs.webkit.org/show_bug.cgi?id=143419
1159
1160         Reviewed by Dan Bernstein.
1161
1162         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
1163         (TestWebKitAPI::generateRandomDigests):
1164         (TestWebKitAPI::TEST):
1165
1166 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1167
1168         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
1169         https://bugs.webkit.org/show_bug.cgi?id=143372
1170
1171         Reviewed by Darin Adler.
1172
1173         * Scripts/run-jsc-stress-tests:
1174
1175 2015-04-03  Antti Koivisto  <antti@apple.com>
1176
1177         Add non-counting bloom filter class
1178         https://bugs.webkit.org/show_bug.cgi?id=143366
1179
1180         Reviewed by Sam Weinig.
1181
1182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1183         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
1184         (TestWebKitAPI::generateRandomHashes):
1185         (TestWebKitAPI::TEST):
1186
1187 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1188
1189         FTL JIT tests should fail if LLVM library isn't available
1190         https://bugs.webkit.org/show_bug.cgi?id=143374
1191
1192         Reviewed by Mark Lam.
1193
1194         * Scripts/run-jsc-stress-tests:
1195
1196 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1197
1198         [EFL] Speedup jhbuild with disable running autogen.sh
1199         https://bugs.webkit.org/show_bug.cgi?id=143369
1200
1201         Reviewed by Gyuyoung Kim.
1202
1203         * efl/jhbuild.modules:
1204
1205 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
1206
1207         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
1208         https://bugs.webkit.org/show_bug.cgi?id=143282
1209
1210         Reviewed by Daniel Bates.
1211
1212         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
1213
1214 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
1215
1216         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
1217         https://bugs.webkit.org/show_bug.cgi?id=143240
1218         rdar://problem/19990425
1219
1220         Reviewed by Tim Horton.
1221
1222         * DumpRenderTree/mac/LayoutTestHelper.m:
1223         (colorProfileURLForDisplay):
1224         (saveDisplayColorProfiles):
1225         Gracefully handle it when the current profile cannot be retrieved, fixing at
1226         least one case when LayoutTestHelper couldn't start.
1227
1228         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1229         (Manager._set_up_run):
1230         (Manager._force_pixel_tests_if_needed):
1231         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
1232         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
1233         Return and check an error from start_helper().
1234
1235 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
1236
1237         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
1238         https://bugs.webkit.org/show_bug.cgi?id=143321
1239
1240         Reviewed by Alexey Proskuryakov.
1241
1242         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
1243
1244 2015-04-01  Enrica Casucci  <enrica@apple.com>
1245
1246         Injected bundle messages should be at the page level.
1247         https://bugs.webkit.org/show_bug.cgi?id=143283
1248
1249         Reviewed by Alexey Proskuryakov.
1250
1251         Updating WebKitTestRunner to use the new page level messaging.
1252         The author of this patch is Tim Horton, I just finished it.
1253
1254         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1255         (WTR::EventSendingController::mouseDown):
1256         (WTR::EventSendingController::mouseUp):
1257         (WTR::EventSendingController::mouseMoveTo):
1258         (WTR::EventSendingController::leapForward):
1259         (WTR::EventSendingController::scheduleAsynchronousClick):
1260         (WTR::EventSendingController::keyDown):
1261         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1262         (WTR::EventSendingController::mouseScrollBy):
1263         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1264         (WTR::EventSendingController::continuousMouseScrollBy):
1265         (WTR::EventSendingController::addTouchPoint):
1266         (WTR::EventSendingController::updateTouchPoint):
1267         (WTR::EventSendingController::setTouchModifier):
1268         (WTR::EventSendingController::setTouchPointRadius):
1269         (WTR::EventSendingController::touchStart):
1270         (WTR::EventSendingController::touchMove):
1271         (WTR::EventSendingController::touchEnd):
1272         (WTR::EventSendingController::touchCancel):
1273         (WTR::EventSendingController::clearTouchPoints):
1274         (WTR::EventSendingController::releaseTouchPoint):
1275         (WTR::EventSendingController::cancelTouchPoint):
1276         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1277         (WTR::InjectedBundle::didReceiveMessage):
1278         (WTR::InjectedBundle::didReceiveMessageToPage):
1279         (WTR::InjectedBundle::done):
1280         (WTR::InjectedBundle::outputText):
1281         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1282         (WTR::InjectedBundle::postAddChromeInputField):
1283         (WTR::InjectedBundle::postRemoveChromeInputField):
1284         (WTR::InjectedBundle::postFocusWebView):
1285         (WTR::InjectedBundle::postSetBackingScaleFactor):
1286         (WTR::InjectedBundle::postSetWindowIsKey):
1287         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1288         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1289         (WTR::InjectedBundle::setGeolocationPermission):
1290         (WTR::InjectedBundle::setMockGeolocationPosition):
1291         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1292         (WTR::InjectedBundle::setUserMediaPermission):
1293         (WTR::InjectedBundle::setCustomPolicyDelegate):
1294         (WTR::InjectedBundle::setHidden):
1295         (WTR::InjectedBundle::setCacheModel):
1296         (WTR::InjectedBundle::shouldProcessWorkQueue):
1297         (WTR::InjectedBundle::processWorkQueue):
1298         (WTR::InjectedBundle::queueBackNavigation):
1299         (WTR::InjectedBundle::queueForwardNavigation):
1300         (WTR::InjectedBundle::queueLoad):
1301         (WTR::InjectedBundle::queueLoadHTMLString):
1302         (WTR::InjectedBundle::queueReload):
1303         (WTR::InjectedBundle::queueLoadingScript):
1304         (WTR::InjectedBundle::queueNonLoadingScript):
1305         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1306         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1307         (WTR::TestRunner::setAuthenticationUsername):
1308         (WTR::TestRunner::setAuthenticationPassword):
1309         (WTR::TestRunner::secureEventInputIsEnabled):
1310         (WTR::TestRunner::setBlockAllPlugins):
1311         * WebKitTestRunner/TestController.cpp:
1312         (WTR::TestController::createWebViewWithOptions):
1313         (WTR::TestController::resetStateToConsistentValues):
1314         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
1315         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
1316         * WebKitTestRunner/TestController.h:
1317         * WebKitTestRunner/TestInvocation.cpp:
1318         (WTR::TestInvocation::invoke):
1319         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1320
1321 2015-04-01  Commit Queue  <commit-queue@webkit.org>
1322
1323         Unreviewed, rolling out r182174 and r182177.
1324         https://bugs.webkit.org/show_bug.cgi?id=143314
1325
1326         Try to correct EWS failures (Requested by bfulgham on
1327         #webkit).
1328
1329         Reverted changesets:
1330
1331         "Python SCM should be able to retrieve untracked files"
1332         https://bugs.webkit.org/show_bug.cgi?id=143135
1333         http://trac.webkit.org/changeset/182174
1334
1335         "[buildbot] clean-build script should remove untracked files
1336         and revert local changes too"
1337         https://bugs.webkit.org/show_bug.cgi?id=142400
1338         http://trac.webkit.org/changeset/182177
1339
1340 2015-04-01  Alex Christensen  <achristensen@webkit.org>
1341
1342         [Content Extensions] Properly handle regexes that match everything.
1343         https://bugs.webkit.org/show_bug.cgi?id=143281
1344
1345         Reviewed by Benjamin Poulain.
1346
1347         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1348         (TestWebKitAPI::testRequest):
1349         (TestWebKitAPI::makeBackend):
1350         (TestWebKitAPI::TEST_F):
1351         Removed duplicate code and added test.
1352
1353 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
1354
1355         Content Extensions: split the state machines to minimize prefix states
1356         https://bugs.webkit.org/show_bug.cgi?id=143253
1357
1358         Reviewed by Alex Christensen.
1359
1360         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1361         (TestWebKitAPI::TEST_F):
1362         (TestWebKitAPI::testPatternStatus):
1363
1364 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
1365
1366         Clean up Identifier factories to clarify the meaning of StringImpl*
1367         https://bugs.webkit.org/show_bug.cgi?id=143146
1368
1369         Reviewed by Filip Pizlo.
1370
1371         Simple API tests for StringImpl are added.
1372
1373         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1374         (TestWebKitAPI::TEST):
1375
1376 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
1377
1378         [EFL] Add AArch64 builder and tester bot to build.webkit.org
1379         https://bugs.webkit.org/show_bug.cgi?id=143092
1380
1381         Reviewed by Gyuyoung Kim.
1382
1383         * BuildSlaveSupport/build.webkit.org-config/config.json:
1384         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1385         (Factory.__init__):
1386         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1387
1388 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1389
1390         [buildbot] clean-build script should remove untracked files and revert local changes too
1391         https://bugs.webkit.org/show_bug.cgi?id=142400
1392
1393         Reviewed by Ryosuke Niwa.
1394
1395         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1396         A helper routine SCM.discard_untracked_files is added for that purpose.
1397
1398         * BuildSlaveSupport/clean-build:
1399         (main): Making call to Scripts/clean-webkit
1400         * Scripts/clean-webkit: Added.
1401         (main): Revert changes and delete untracked files.
1402         * Scripts/webkitpy/common/checkout/scm/scm.py:
1403         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1404         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1405         (SCMTest._shared_test_discard_untracked_files):
1406         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1407
1408 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1409
1410         Python SCM should be able to retrieve untracked files
1411         https://bugs.webkit.org/show_bug.cgi?id=143135
1412
1413         Reviewed by Ryosuke Niwa.
1414
1415         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1416         Ignored files may be included or not in this list according boolean passed to the function.
1417
1418         * Scripts/webkitpy/common/checkout/scm/git.py:
1419         (Git.untracked_files):
1420         * Scripts/webkitpy/common/checkout/scm/scm.py:
1421         (SCM.untracked_files):
1422         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1423         (SCMTest._shared_test_untracked_files):
1424         (test_untracked_files):
1425         (GitSVNTest.test_untracked_files):
1426         * Scripts/webkitpy/common/checkout/scm/svn.py:
1427         (SVN.untracked_files):
1428
1429 2015-03-30  Alex Christensen  <achristensen@webkit.org>
1430
1431         [Content Extensions] Correctly handle regular expressions matching everything
1432         https://bugs.webkit.org/show_bug.cgi?id=143235
1433
1434         Reviewed by Benjamin Poulain.
1435
1436         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1437         (TestWebKitAPI::checkCompilerError):
1438         (TestWebKitAPI::TEST_F):
1439         Test ContentExtensionErrors.
1440
1441 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
1442
1443         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
1444         https://bugs.webkit.org/show_bug.cgi?id=143241
1445         rdar://problem/20351297
1446
1447         Reviewed by Mark Lam.
1448
1449         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1450
1451 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1452
1453         [CMake][EFL] Remove redundant library link and include path
1454         https://bugs.webkit.org/show_bug.cgi?id=143221
1455
1456         Reviewed by Csaba Osztrogonác.
1457
1458         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
1459
1460 2015-03-30  Sam Weinig  <sam@webkit.org>
1461
1462         [Content Extensions] Flesh out the UserContentExtensionStore
1463         https://bugs.webkit.org/show_bug.cgi?id=143123
1464
1465         Reviewed by Benjamin Poulain.
1466
1467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1468         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
1469         Add tests for _WKUserContentExtensionStore.
1470
1471 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1472
1473         Update install-dependencies Fedora packages after r181624
1474         https://bugs.webkit.org/show_bug.cgi?id=143215
1475
1476         Add json-glib, libv4l, openssl and pulseaudio development packages to
1477         the Fedora list providing we need them to build WebKit dependencies
1478         for this distribution.
1479
1480         Reviewed by Philippe Normand.
1481
1482         * gtk/install-dependencies:
1483
1484 2015-03-30  Commit Queue  <commit-queue@webkit.org>
1485
1486         Unreviewed, rolling out r182119.
1487         https://bugs.webkit.org/show_bug.cgi?id=143196
1488
1489         problem with syntax (Requested by youenn on #webkit).
1490
1491         Reverted changeset:
1492
1493         "[buildbot] clean-build script should remove untracked files
1494         and revert local changes too"
1495         https://bugs.webkit.org/show_bug.cgi?id=142400
1496         http://trac.webkit.org/changeset/182119
1497
1498 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
1499
1500         Start the features.json files
1501         https://bugs.webkit.org/show_bug.cgi?id=143207
1502
1503         Reviewed by Darin Adler.
1504
1505         I kept the style checking light. We'll have to figure
1506         what is the best format for each field.
1507
1508         * Scripts/webkitpy/style/checker.py:
1509         (CheckerDispatcher._create_checker):
1510         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1511         (JSONContributorsChecker.check):
1512         (JSONFeaturesChecker):
1513         (JSONFeaturesChecker.check):
1514
1515 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1516
1517         [buildbot] clean-build script should remove untracked files and revert local changes too
1518         https://bugs.webkit.org/show_bug.cgi?id=142400
1519
1520         Reviewed by Ryosuke Niwa.
1521
1522         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
1523
1524         * BuildSlaveSupport/clean-build:
1525         (main): Adding call to Tools/Scripts/clean-webkit.
1526         * Scripts/clean-webkit: Added.
1527         (main): Removes untracked and changed files.
1528         * Scripts/webkitpy/common/checkout/scm/git.py:
1529         (Git.untracked_files): Retrieves GIT untracked files.
1530         * Scripts/webkitpy/common/checkout/scm/scm.py:
1531         (SCM.untracked_files): Retrieves SVN untracked files.
1532         (SCM):
1533         (SCM.discard_untracked_files): Deletes untracked files/folders.
1534         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1535         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
1536         (test_untracked_files):
1537         (GitSVNTest.test_untracked_files):
1538         * Scripts/webkitpy/common/checkout/scm/svn.py:
1539         (SVN.untracked_files):
1540
1541 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1542
1543         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
1544         https://bugs.webkit.org/show_bug.cgi?id=143138
1545
1546         Reviewed by Csaba Osztrogonác.
1547
1548         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
1549         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
1550
1551         * ImageDiff/CMakeLists.txt:
1552         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
1553         * WebKitTestRunner/CMakeLists.txt: ditto.
1554
1555 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
1556
1557         Support building WTF on Windows without Cygwin
1558         https://bugs.webkit.org/show_bug.cgi?id=143084
1559
1560         Reviewed by Brent Fulgham.
1561
1562         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
1563         This patch also migrates to using File::Spec->catfile() for directory separators.
1564
1565         * Scripts/update-webkit-dependency:
1566         (wanted):
1567         * Scripts/update-webkit-support-libs:
1568         (wanted):
1569         (downloadExpectedVersionNumber):
1570         (zipFileVersion):
1571         (toUnixPath): Deleted.
1572         * Scripts/webkitdirs.pm:
1573         (determineSourceDir):
1574         (windowsSourceSourceDir):
1575         (windowsLibrariesDir):
1576         (windowsOutputDir):
1577         (checkInstalledTools):
1578         (buildVisualStudioProject):
1579
1580 2015-03-27  Alex Christensen  <achristensen@webkit.org>
1581
1582         Fix WinCairo bot.
1583         https://bugs.webkit.org/show_bug.cgi?id=143086
1584
1585         Reviewed by Brent Fulgham.
1586
1587         * Scripts/webkitdirs.pm:
1588         (buildVisualStudioProject):
1589         (runSvnUpdateAndResolveChangeLogs):
1590         Use ActivePerl-friendly perl.
1591
1592 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1593
1594         URTBF after r182059 to fix the EFL build.
1595
1596         * TestWebKitAPI/CMakeLists.txt:
1597
1598 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
1599
1600         Layout test results URL loads in WK1 but not WK2 minibrowser
1601         https://bugs.webkit.org/show_bug.cgi?id=143117
1602
1603         Reviewed by Tim Horton.
1604
1605         * MiniBrowser/mac/WK2BrowserWindowController.m:
1606         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
1607         everything.
1608         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
1609
1610 2015-03-26  Jer Noble  <jer.noble@apple.com>
1611
1612         Add --allowed-host support to run-webkit-tests
1613         https://bugs.webkit.org/show_bug.cgi?id=142938
1614
1615         Reviewed by Brent Fulgham.
1616
1617         Accept --allowed-host arguments from run-webkit-tests and pass them through to
1618         DumpRenderTree and WebKitTestRunner.
1619
1620         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
1621         are placed in the wrong location. The argument is compared with each tests's path, and if a
1622         relative path or a path with '..' was used, results are placed alongside the test. Take the
1623         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
1624
1625         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1626         (parse_args):
1627         * Scripts/webkitpy/port/base.py:
1628         (Port.__init__):
1629         (Port.allowed_hosts):
1630         * Scripts/webkitpy/port/driver.py:
1631         (Driver.cmd_line):
1632
1633 2015-03-26  Jer Noble  <jer.noble@apple.com>
1634
1635         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
1636         https://bugs.webkit.org/show_bug.cgi?id=142931
1637
1638         Reviewed by Brent Fulgham.
1639
1640         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
1641         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
1642         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
1643         runtime.
1644
1645         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
1646         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
1647
1648         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
1649         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
1650         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
1651         the top loading frame from the page, as we do elsewhere in this class.
1652
1653         * DumpRenderTree/TestRunner.h:
1654         (TestRunner::allowedHosts):
1655         (TestRunner::setAllowedHosts):
1656         * DumpRenderTree/mac/DumpRenderTree.mm:
1657         (initializeGlobalsFromCommandLineOptions):
1658         (runTest):
1659         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1660         (isAllowedHost):
1661         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1662         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1663         (WTR::InjectedBundle::didReceiveMessage):
1664         (WTR::InjectedBundle::isAllowedHost):
1665         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1666         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1667         (WTR::isAllowedHost):
1668         (WTR::InjectedBundlePage::willSendRequestForFrame):
1669         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1670         * WebKitTestRunner/Options.cpp:
1671         (WTR::handleOptionAllowedHost):
1672         (WTR::OptionsHandler::OptionsHandler):
1673         * WebKitTestRunner/Options.h:
1674         * WebKitTestRunner/TestController.cpp:
1675         (WTR::TestController::initialize):
1676         (WTR::TestController::resetStateToConsistentValues):
1677         * WebKitTestRunner/TestController.h:
1678
1679 2015-03-26  Brady Eidson  <beidson@apple.com>
1680
1681         Apply ContentExtension actions after redirects.
1682         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
1683
1684         Reviewed by Alex Christensen.
1685
1686         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1687         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
1688           which is specifically interesting to a new test.
1689
1690 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1691
1692         [EFL] Disable building libseccomp on AArch64
1693         https://bugs.webkit.org/show_bug.cgi?id=143094
1694
1695         Reviewed by Gyuyoung Kim.
1696
1697         * efl/jhbuildrc:
1698
1699 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1700
1701         [jhbuild] git should use only 1 thread for cloning jhbuild
1702         https://bugs.webkit.org/show_bug.cgi?id=143095
1703
1704         Reviewed by Gyuyoung Kim.
1705
1706         * jhbuild/jhbuild-wrapper:
1707         (clone_jhbuild):
1708
1709 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
1710
1711         Update prepare-ChangeLog to work with ES6 Class syntax
1712         https://bugs.webkit.org/show_bug.cgi?id=143069
1713
1714         Reviewed by Timothy Hatcher.
1715
1716         * Scripts/prepare-ChangeLog:
1717         (get_function_line_ranges_for_javascript):
1718         Better handle ES6 Class syntax.
1719
1720         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1721         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1722         (BaseClass):
1723         (DerivedClass):
1724         (DerivedClass.staticMethod):
1725         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
1726         (DerivedClass.prototype.method):
1727         (DerivedClass.prototype.get getter):
1728         (namespace.MyClass):
1729         (namespace.MyClass.staticMethod):
1730         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
1731         (namespace.MyClass.prototype.method):
1732         (namespace.MyClass.prototype.get getter):
1733         Proof!
1734
1735 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
1736
1737         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
1738         https://bugs.webkit.org/show_bug.cgi?id=142993
1739
1740         Reviewed by Mark Lam.
1741         
1742         Bunch of support for testing executable allocation failure.
1743
1744         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
1745         (fail):
1746         * Scripts/run-javascriptcore-tests:
1747         (runJSCStressTests):
1748         * Scripts/run-jsc-stress-tests:
1749
1750 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1751
1752         Fix Windows build from r181977.
1753
1754         Unreviewed.
1755
1756         * Scripts/update-webkit-dependency:
1757
1758 2015-03-25  Sam Weinig  <sam@webkit.org>
1759
1760         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
1761
1762         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1763         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1764
1765 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1766
1767         Migrate update-webkit for Windows to not require Cygwin
1768         https://bugs.webkit.org/show_bug.cgi?id=143040
1769
1770         Reviewed by Brent Fulgham.
1771
1772         * Scripts/update-webkit-dependency:
1773         (wanted):
1774         (toUnixPath): Deleted.
1775         * Scripts/webkitdirs.pm:
1776         (fontExists):
1777         (checkInstalledTools):
1778         (setupAppleWinEnv):
1779
1780 2015-03-25  Sam Weinig  <sam@webkit.org>
1781
1782         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1783         https://bugs.webkit.org/show_bug.cgi?id=143059
1784
1785         Reviewed by Alex Christensen.
1786
1787         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1788         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1789         Update for new interface of compileRuleList().
1790
1791 2015-03-25  Alex Christensen  <achristensen@webkit.org>
1792
1793         [Content Extensions] Add multi-DFA compiling and interpreting.
1794         https://bugs.webkit.org/show_bug.cgi?id=143010
1795
1796         Reviewed by Benjamin Poulain.
1797
1798         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1799         (TestWebKitAPI::testRequest):
1800         (TestWebKitAPI::TEST_F):
1801         Add some tests for ignore-previous-rules and large rulesets.
1802
1803 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
1804
1805         Mavericks WK1 still runs JSC tests
1806         https://bugs.webkit.org/show_bug.cgi?id=143035
1807
1808         Reviewed by Csaba Osztrogonác.
1809
1810         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1811         with other bots.
1812
1813         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1814         accordingly.
1815
1816 2015-03-25  Commit Queue  <commit-queue@webkit.org>
1817
1818         Unreviewed, rolling out r181932.
1819         https://bugs.webkit.org/show_bug.cgi?id=143041
1820
1821         The test fails most of the time on bots (Requested by ap on
1822         #webkit).
1823
1824         Reverted changeset:
1825
1826         "[Content Extensions] Add multi-DFA compiling and
1827         interpreting."
1828         https://bugs.webkit.org/show_bug.cgi?id=143010
1829         http://trac.webkit.org/changeset/181932
1830
1831 2015-03-24  Alex Christensen  <achristensen@webkit.org>
1832
1833         [Content Extensions] Add multi-DFA compiling and interpreting.
1834         https://bugs.webkit.org/show_bug.cgi?id=143010
1835
1836         Reviewed by Benjamin Poulain.
1837
1838         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1839         (TestWebKitAPI::testRequest):
1840         (TestWebKitAPI::TEST_F):
1841         Add some tests for ignore-previous-rules and large rulesets.
1842
1843 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
1844
1845         Make URL filter patterns matching consistent and add a simple canonicalization step
1846         https://bugs.webkit.org/show_bug.cgi?id=142998
1847
1848         Reviewed by Alex Christensen.
1849
1850         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1851
1852 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
1853
1854         [EFL] Add OpenWebRTC in jhbuild
1855         https://bugs.webkit.org/show_bug.cgi?id=142778
1856
1857         Reviewed by Gyuyoung Kim.
1858
1859         Original patch by Philippe Normand <pnormand@igalia.com>
1860
1861         * efl/install-dependencies: Dependencies for OpenWebRTC.
1862         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1863         the openwebrtc gst plugins.
1864
1865 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
1866
1867         Regression(r181257): WTF_WorkQueue.Simple is flaky
1868         https://bugs.webkit.org/show_bug.cgi?id=142560
1869
1870         Remove the check that the refCount has returned to one after the
1871         individual tasks have completed. It's too nondeterministic when
1872         the reference count will be reduced.
1873
1874         Reviewed by Alexey Proskuryakov
1875
1876         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1877         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1878
1879 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1880
1881         [CMake][EFL] Put failure API test excutables into failure directory
1882         https://bugs.webkit.org/show_bug.cgi?id=142965
1883
1884         Reviewed by Csaba Osztrogonác.
1885
1886         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1887
1888         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1889         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1890
1891 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
1892
1893         CSS Selectors: fix attribute case-insensitive matching of Contain and List
1894         https://bugs.webkit.org/show_bug.cgi?id=142932
1895
1896         Reviewed by Darin Adler.
1897
1898         Add tests for the new features and fix some existing tests using the 
1899         stringFromUTF8() utility recently added by Dhi.
1900
1901         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1902         (TestWebKitAPI::stringFromUTF8):
1903         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1904
1905 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1906
1907         [GTK] install-dependencies should install orc
1908         https://bugs.webkit.org/show_bug.cgi?id=142955
1909
1910         Reviewed by Martin Robinson.
1911
1912         Install orc, needed by openwebrtc
1913
1914         * gtk/install-dependencies:
1915
1916 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
1917
1918         Detect when url filter pattern with groups match the empty string
1919         https://bugs.webkit.org/show_bug.cgi?id=142930
1920
1921         Reviewed by Sam Weinig.
1922
1923         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1924
1925 2015-03-22  Anders Carlsson  <andersca@apple.com>
1926
1927         _WKWebsiteDataStore should clear WebSQL databases
1928         https://bugs.webkit.org/show_bug.cgi?id=142947
1929
1930         Reviewed by Sam Weinig.
1931
1932         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1933
1934         * MiniBrowser/mac/WK2BrowserWindowController.m:
1935         (-[WK2BrowserWindowController fetchWebsiteData:]):
1936         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1937         (-[WK2BrowserWindowController clearWebsiteData:]):
1938
1939 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
1940
1941         GCTimer should know keep track of nested GC phases
1942         https://bugs.webkit.org/show_bug.cgi?id=142675
1943
1944         Reviewed by Darin Adler.
1945
1946         Adds a tool to aid in parsing the GC phase timing output into a
1947         tree-like structure based on the parent-child relationships
1948         of nested GC phases.
1949
1950         * Scripts/parse-gc-phase-timings: Added.
1951         (Timing):
1952         (Timing.__init__):
1953         (Timing.__unicode__):
1954         (Timing.__str__):
1955         (Timing.__repr__):
1956         (parse_input):
1957         (print_timing_node):
1958         (print_timing_tree):
1959         (link_parents):
1960         (main):
1961
1962 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
1963
1964         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1965
1966         * Scripts/webkitpy/common/config/ews.json:
1967
1968 2015-03-20  Philippe Normand  <pnormand@igalia.com>
1969
1970         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1971         https://bugs.webkit.org/show_bug.cgi?id=142867
1972
1973         Rubber-stamped by Csaba Osztrogon.
1974
1975         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1976         a fixed revision for the openwebrtc-gst-plugins.
1977
1978 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1979
1980         Unreviewed build fix. Don't try to report stats for all benchmarks.
1981         Just report the geometric mean of preferred means.
1982
1983         * Scripts/run-jsc-benchmarks:
1984
1985 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1986
1987         run-jsc-benchmarks should only report preferred mean
1988         https://bugs.webkit.org/show_bug.cgi?id=142874
1989
1990         Reviewed by Geoffrey Garen.
1991
1992         Just collect statistics for the preferred mean.
1993
1994         * Scripts/run-jsc-benchmarks:
1995
1996 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1997
1998         [Content Extensions] Test regular expression parse failures.
1999         https://bugs.webkit.org/show_bug.cgi?id=142872
2000
2001         Reviewed by Benjamin Poulain.
2002
2003         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2004         (TestWebKitAPI::testPatternStatus):
2005         (TestWebKitAPI::TEST_F):
2006         Added tests for each parsing status.
2007
2008 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2009
2010         Fix API tests after r181754.
2011
2012         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2013         (TestWebKitAPI::testRequest):
2014
2015 2015-03-19  Brady Eidson  <beidson@apple.com>
2016
2017         Part of content extensions should apply css selectors
2018         https://bugs.webkit.org/show_bug.cgi?id=142604
2019
2020         Reviewed by Alex Christensen.
2021
2022         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2023         (WebCore::ContentExtensions::operator<<):
2024
2025 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
2026
2027         [Win] Activate tests on EWS
2028         https://bugs.webkit.org/show_bug.cgi?id=142850
2029
2030         Reviewed by Alexey Proskuryakov.
2031
2032         * Scripts/webkitpy/common/config/ews.json: Add me as
2033         the EWS bot watcher, and activate tests.
2034
2035 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
2036
2037         [GTK] Fix inspector userinterface related incremental build issue
2038         https://bugs.webkit.org/show_bug.cgi?id=142849
2039
2040         Reviewed by Carlos Garcia Campos.
2041
2042         * Scripts/webkitdirs.pm:
2043         (shouldRemoveCMakeCache):
2044
2045 2015-03-18  Alex Christensen  <achristensen@webkit.org>
2046
2047         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
2048         https://bugs.webkit.org/show_bug.cgi?id=142799
2049
2050         Reviewed by Brady Eidson.
2051
2052         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2053         (TestWebKitAPI::testPattern):
2054         (TestWebKitAPI::TEST_F):
2055         Start testing regex failures.
2056
2057 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
2058
2059         Fix StringView typos after r181525 and r181558
2060         https://bugs.webkit.org/show_bug.cgi?id=142772
2061
2062         Reviewed by Darin Adler.
2063
2064         Add some tests in [1] to cover the StringView::startsWith, 
2065         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
2066         StringView::endsWithIgnoringASCIICase implementations.
2067
2068         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2069         (TestWebKitAPI::TEST):
2070
2071 2015-03-18  Dana Burkart  <dburkart@apple.com>
2072
2073         Remove extraneous import to fix the build.
2074
2075         Unreviewed.
2076
2077         * Scripts/webkitpy/port/driver.py:
2078
2079 2015-03-18  Dana Burkart  <dburkart@apple.com>
2080
2081         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
2082         https://bugs.webkit.org/show_bug.cgi?id=142547
2083
2084         Reviewed by Alexey Proskuryakov.
2085
2086         * Scripts/webkitpy/port/driver.py:
2087         (Driver._setup_environ_for_driver):
2088
2089 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
2090
2091         Tweak how AppleSystemFontOSSubversion default is added
2092         https://bugs.webkit.org/show_bug.cgi?id=142835
2093
2094         Reviewed by Dan Bernstein.
2095
2096         * DumpRenderTree/mac/DumpRenderTree.mm:
2097         (setDefaultsToConsistentValuesForTesting):
2098
2099 2015-03-18  Dan Bernstein  <mitz@apple.com>
2100
2101         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
2102         https://bugs.webkit.org/show_bug.cgi?id=142815
2103
2104         Reviewed by Darin Adler.
2105
2106         * Scripts/prepare-ChangeLog:
2107         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
2108         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
2109         keep consuming the quoted text until the matching quotation mark is reached. Emit the
2110         warning only if a line ends without a backslash before the matching quotation mark was found.
2111
2112 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2113
2114         Remove unused "preprocessor" parameter to sub-CodeGenerators
2115         https://bugs.webkit.org/show_bug.cgi?id=142793
2116
2117         Reviewed by Darin Adler.
2118
2119         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2120         (new):
2121
2122 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
2123
2124         [EFL] Bump gstreamer version to 1.4.4
2125         https://bugs.webkit.org/show_bug.cgi?id=142782
2126
2127         Reviewed by Philippe Normand.
2128
2129         * efl/jhbuild.modules:
2130         * efl/patches/gst-libav.patch:
2131         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
2132         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2133
2134 2015-03-17  Tim Horton  <timothy_horton@apple.com>
2135
2136         Fix the iOS build.
2137
2138         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2139         (WTR::InjectedBundle::platformInitialize):
2140
2141 2015-03-17  Dean Jackson  <dino@apple.com>
2142
2143         check-webkit-style should allow "bool a : 1"
2144         https://bugs.webkit.org/show_bug.cgi?id=142794
2145
2146         Reviewed by Brent Fulgham.
2147
2148         We should allow member bitfields of the form:
2149
2150         bool m_var : 1;
2151
2152         It seems that Visual Studio 8 was the last compiler that
2153         wasn't happy about not using unsigned here. We already have
2154         about 500 cases (in WebCore) where people were ignoring this rule.
2155
2156         * Scripts/webkitpy/style/checkers/cpp.py:
2157         (check_language): Allow "bool".
2158         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
2159         (CppStyleTest.test_enum_bitfields):
2160         (CppStyleTest.test_plain_integral_bitfields):
2161
2162 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
2163
2164         Compile character ranges targeting the same state as range check in the bytecode
2165         https://bugs.webkit.org/show_bug.cgi?id=142759
2166
2167         Reviewed by Alex Christensen.
2168
2169         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2170         (TestWebKitAPI::TEST_F):
2171
2172 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2173
2174         W3C test parser and converter should use test importer host
2175         https://bugs.webkit.org/show_bug.cgi?id=142729
2176
2177         Reviewed by Bem Jones-Bey.
2178
2179         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
2180         This enables adding more TestImporter unit testing.
2181         This patch also ensures that the git object instantiated by TestDownloader is using the
2182         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
2183
2184         * Scripts/webkitpy/common/system/filesystem_mock.py:
2185         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
2186         * Scripts/webkitpy/w3c/test_downloader.py:
2187         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
2188         (TestDownloader.checkout_test_repository): Making use of the new git function.
2189         * Scripts/webkitpy/w3c/test_importer.py:
2190         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
2191         (TestImporter.import_tests): Adding host as parameter to the converter.
2192         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2193         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
2194         (TestImporterTest):
2195         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
2196         * Scripts/webkitpy/w3c/test_parser.py:
2197         (TestParser.__init__): Adding host as parameter constructor.
2198
2199 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2200
2201         [GTK] WebKitDOM objects leaking
2202         https://bugs.webkit.org/show_bug.cgi?id=118788
2203
2204         Reviewed by Darin Adler and Sergio Villar Senin.
2205
2206         Update DOMObjectCache unit test to check that DOM objects are also
2207         released when new contents are loaded in the web view, and the old
2208         document is detached from the frame.
2209
2210         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2211         (testWebKitDOMObjectCache):
2212         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2213         (runTest):
2214
2215 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2216
2217         W3C test importer default import folder should be LayoutTests/imported/w3c
2218         https://bugs.webkit.org/show_bug.cgi?id=142728
2219
2220         Reviewed by Bem Jones-Bey.
2221
2222         * Scripts/webkitpy/w3c/test_importer.py:
2223         (parse_args): Updating the default destination option value to 'imported/w3c'.
2224
2225 2015-03-17  Philippe Normand  <pnormand@igalia.com>
2226
2227         [GTK] basic OpenWebRTC build support
2228         https://bugs.webkit.org/show_bug.cgi?id=142393
2229
2230         Reviewed by Carlos Garcia Campos.
2231
2232         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
2233         is not the upstream OpenWebRTC repository. This temporary fork
2234         contains a few patches needed by WebKit for audio/video rendering.
2235
2236 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2237
2238         [CMake][EFL] Build test tools only for developer mode
2239         https://bugs.webkit.org/show_bug.cgi?id=142761
2240
2241         Reviewed by Csaba Osztrogonác.
2242
2243         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
2244
2245         * CMakeLists.txt:
2246
2247 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
2248
2249         Remove never used "useLayerOnTop" bindings generator argument
2250         https://bugs.webkit.org/show_bug.cgi?id=142773
2251
2252         Reviewed by Darin Adler.
2253
2254         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2255         (new):
2256
2257 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
2258
2259         Enable ES6 classes by default
2260         https://bugs.webkit.org/show_bug.cgi?id=142774
2261
2262         Reviewed by Gavin Barraclough.
2263
2264         * Scripts/webkitperl/FeatureList.pm:
2265
2266 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2267
2268         Fix webkitpy tests after r181585.
2269
2270         Looks like "me" cannot be anyone's email, it's a special case.
2271
2272         * Scripts/webkitpy/common/config/contributors.json:
2273
2274 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2275
2276         Add tolerance to WebAudio tests
2277         https://bugs.webkit.org/show_bug.cgi?id=142676
2278
2279         Reviewed by Tim Horton.
2280
2281         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
2282
2283         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2284         (TestResultWriter.create_audio_diff_and_write_result):
2285         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2286         (FailureAudio.write_failure):
2287         * Scripts/webkitpy/port/base.py:
2288         (Port.do_audio_results_differ):
2289         Diff audio failures.
2290
2291         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
2292         tests to use real parseable WAV data, and got rid of base64, which there didn't
2293         seem to have been any reason for.
2294
2295 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2296
2297         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
2298         https://bugs.webkit.org/show_bug.cgi?id=142720
2299
2300         Reviewed by Myles C. Maxfield.
2301
2302         Activate system copies of Microsoft fonts for the current process, thus overriding
2303         any other ones that could be preferred by the system otherwise.
2304
2305         * DumpRenderTree/mac/DumpRenderTree.mm:
2306         (activateSystemCoreWebFonts):
2307         (adjustFonts):
2308         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2309         (WTR::activateSystemCoreWebFonts):
2310         (WTR::activateFonts):
2311
2312 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2313
2314         Created Streams API watchlist
2315         https://bugs.webkit.org/show_bug.cgi?id=142684
2316
2317         Reviewed by Benjamin Poulain.
2318
2319         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
2320         watchlist and added Benjamin, Youenn and me to it.
2321
2322 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
2323
2324         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
2325         https://bugs.webkit.org/show_bug.cgi?id=142715
2326
2327         Reviewed by Brent Fulgham.
2328
2329         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2330         (TestWebKitAPI::TEST):
2331
2332 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
2333
2334         Change the exact attribute matching to be ASCII case-insensitive
2335         https://bugs.webkit.org/show_bug.cgi?id=142609
2336
2337         Reviewed by Darin Adler.
2338
2339         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2340         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2341
2342 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2343
2344         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
2345         https://bugs.webkit.org/show_bug.cgi?id=134764
2346
2347         Reviewed by Ryosuke Niwa.
2348
2349         TestDownloader is introduced to download W3C tests from the official
2350         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
2351         and https://github.com/w3c/csswg-test.git).
2352         TestDownloader clones the repositories and checkouts revisions of the tests
2353         defined in LayoutTests/imported/w3c/resources/TestRepositories.
2354
2355         Similarly to https://codereview.chromium.org/148173016,
2356         TestDownloader copies part of the files based on the rules
2357         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
2358
2359         TestDownloader is used by TestImporter when no source directory is provided.
2360
2361         * Scripts/webkitpy/w3c/test_downloader.py: Added.
2362         (TestDownloader):
2363         (TestDownloader.default_options):
2364         (TestDownloader.load_test_repositories):
2365         (TestDownloader.__init__):
2366         (TestDownloader.checkout_test_repository):
2367         (TestDownloader._init_paths_from_expectations):
2368         (TestDownloader._add_test_suite_paths):
2369         (TestDownloader._empty_directory):
2370         (TestDownloader.copy_tests):
2371         (TestDownloader.download_tests):
2372         * Scripts/webkitpy/w3c/test_importer.py:
2373         (main):
2374         (parse_args):
2375         (TestImporter.__init__):
2376         (TestImporter.do_import):
2377         (TestImporter.test_downloader):
2378         (TestImporter.find_importable_tests.should_keep_subdir):
2379         (TestImporter.should_convert_test_harness_links):
2380         (TestImporter.import_tests):
2381         (TestImporter.write_import_log):
2382
2383 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2384
2385         [Mavericks] Test snapshots are 1600x1200 on Retina devices
2386         https://bugs.webkit.org/show_bug.cgi?id=142630
2387
2388         Reviewed by Tim Horton.
2389
2390         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2391         Removed an ifdef that disabled the fix on Mavericks.
2392
2393 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2394
2395         Remove isWK2 cruft from webkitdirs.pm after r170426
2396         https://bugs.webkit.org/show_bug.cgi?id=142618
2397
2398         Reviewed by Daniel Bates.
2399
2400         * Scripts/webkitdirs.pm:
2401         (isWK2): Deleted.
2402
2403 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2404
2405         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
2406         https://bugs.webkit.org/show_bug.cgi?id=138687
2407
2408         Reviewed by Carlos Garcia Campos.
2409
2410         Always change cookie policy from UI process, as changing it from WebProcess doesn't
2411         affect other processes.
2412
2413         The implementation is imperfect, because the change happens asynchronously, but I
2414         don't expect it to be a problem in practice.
2415
2416         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2417         (WTR::InjectedBundle::beginTesting):
2418         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2419         (WTR::TestRunner::setAlwaysAcceptCookies):
2420         * WebKitTestRunner/TestInvocation.cpp:
2421         (WTR::TestInvocation::invoke):
2422         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2423
2424 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2425
2426         [EFL] Enable building EFL 1.13 with NEON support
2427         https://bugs.webkit.org/show_bug.cgi?id=142619
2428
2429         Reviewed by Gyuyoung Kim.
2430
2431         * efl/jhbuild.modules:
2432
2433 2015-03-11  Alex Christensen  <achristensen@webkit.org>
2434
2435         [Content Extensions] Add resource type and load type triggers.
2436         https://bugs.webkit.org/show_bug.cgi?id=142422
2437
2438         Reviewed by Benjamin Poulain.
2439
2440         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2441         (TestWebKitAPI::testRequest):
2442         (TestWebKitAPI::mainDocumentRequest):
2443         (TestWebKitAPI::TEST_F):
2444         (TestWebKitAPI::testURL): Deleted.
2445
2446 2015-03-10  Sam Weinig  <sam@webkit.org>
2447
2448         Allow adding a button in input elements for auto fill related functionality
2449         <rdar://problem/19782066>
2450         https://bugs.webkit.org/show_bug.cgi?id=142564
2451
2452         Reviewed by Anders Carlsson.
2453
2454         * WebKitTestRunner/TestController.cpp:
2455         (WTR::TestController::createOtherPage):
2456         (WTR::TestController::createWebViewWithOptions):
2457         Update for new callback.
2458
2459 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
2460
2461         Add basic support for BOL and EOL assertions to the URL Filter parser
2462         https://bugs.webkit.org/show_bug.cgi?id=142568
2463
2464         Reviewed by Alex Christensen.
2465
2466         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2467         (TestWebKitAPI::TEST_F):
2468
2469 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2470
2471         [GTK] Add support for handling TLS errors to MiniBrowser
2472         https://bugs.webkit.org/show_bug.cgi?id=142576
2473
2474         Reviewed by Sergio Villar Senin.
2475
2476         It's useful for testing TLS errors handling itself, but also to
2477         allow ignoring TLS errors when testing.
2478
2479         * MiniBrowser/gtk/BrowserWindow.c:
2480         (webViewLoadFailedWithTLSerrors):
2481         (browserWindowConstructed):
2482
2483 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
2484
2485         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
2486         https://bugs.webkit.org/show_bug.cgi?id=142569
2487
2488         Reviewed by David Hyatt.
2489
2490         Test Optional::valueOrCompute().
2491
2492         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2493         (TestWebKitAPI::TEST):
2494
2495 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2496
2497         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
2498         https://bugs.webkit.org/show_bug.cgi?id=126688
2499
2500         Reviewed by Gustavo Noronha Silva.
2501
2502         * CMakeLists.txt: Build testing tools only for developer builds,
2503         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
2504         * MiniBrowser/gtk/CMakeLists.txt: Only add
2505         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
2506         and add a rule to install the MiniBrowser.
2507         * MiniBrowser/gtk/main.c:
2508         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
2509         builds.
2510
2511 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
2512
2513         Add some DateMath tests to TestWebKitAPI
2514         https://bugs.webkit.org/show_bug.cgi?id=142565
2515
2516         Reviewed by Alexey Proskuryakov.
2517
2518         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
2519         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
2520         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
2521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
2522         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
2523
2524 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
2525
2526         Regression(r181257): WTF_WorkQueue.Simple is flaky
2527         https://bugs.webkit.org/show_bug.cgi?id=142560
2528
2529         Unreviewed attempt to improve test stability.
2530
2531         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
2532         the WorkQueue a little later to redue flakiness.
2533
2534 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2535
2536         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
2537         https://bugs.webkit.org/show_bug.cgi?id=142555
2538
2539         Reviewed by Simon Fraser.
2540
2541         * DumpRenderTree/mac/DumpRenderTree.mm:
2542         (setDefaultsToConsistentValuesForTesting):
2543         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2544         (WTR::InjectedBundle::platformInitialize):
2545
2546 2015-03-10  Alex Christensen  <achristensen@webkit.org>
2547
2548         Use unsigned for HashSet size.
2549         https://bugs.webkit.org/show_bug.cgi?id=142518
2550
2551         Reviewed by Benjamin Poulain.
2552
2553         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2554         (TestWebKitAPI::TEST):
2555         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2556         (TestWebKitAPI::testInitialCapacity):
2557         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2558         (TestWebKitAPI::TEST):
2559
2560 2015-03-10  Daniel Bates  <dabates@apple.com>
2561
2562         [iOS] Add WebKitSystemInterface for iOS 8.2
2563         https://bugs.webkit.org/show_bug.cgi?id=142505
2564
2565         Rubber-stamped by Anders Carlsson.
2566
2567         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
2568         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
2569         copy-webkitlibraries-to-product-directory in r181286.
2570
2571         * Scripts/copy-webkitlibraries-to-product-directory:
2572
2573 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
2574
2575         Extend URL filter's Term definition to support groups/subpatterns
2576         https://bugs.webkit.org/show_bug.cgi?id=142519
2577
2578         Reviewed by Alex Christensen.
2579
2580         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2581         (TestWebKitAPI::testURL):
2582
2583 2015-03-06  Jer Noble  <jer.noble@apple.com>
2584
2585         Add an option to run-webkit-tests to override the LayoutTests/ directory
2586         https://bugs.webkit.org/show_bug.cgi?id=142418
2587
2588         Reviewed by David Kilzer.
2589
2590         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
2591         directory. The base port will parse the options during initialization and store the override
2592         location if present. layout_tests_dir() will return this overridden location if set.
2593
2594         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2595         (parse_args):
2596         * Scripts/webkitpy/port/base.py:
2597         (Port.__init__):
2598         (Port.layout_tests_dir):
2599
2600 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
2601
2602         [CMake] Enable WorkQueue tests for CMake ports
2603         https://bugs.webkit.org/show_bug.cgi?id=142473
2604
2605         Reviewed by Darin Adler.
2606
2607         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
2608         the list of source files.
2609         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
2610         to the list of include directories for EFL.
2611
2612 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2613
2614         Attempt to fix timeouts on iOS Simulator layout tests
2615
2616         * Scripts/webkitpy/port/ios.py:
2617         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
2618         Simulator end after the first 50 tests time out.  Some analysis
2619         this past weekend shows that the 'Booted' status in the output
2620         of `xcrun simctl list` is not sufficient (and watching the test
2621         run shows that SpringBoard hasn't fully started to the point
2622         where it's displaying icons on the home screen).  The workaround
2623         until we have a better fix is to add an arbitrary timeout to let
2624         SpringBoard finish launching.  In practice, 15 seconds is
2625         probably enough, but 30 seconds should nearly always work.
2626
2627 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
2628
2629         Unreviewed. Add myself as a committer.
2630
2631         * Scripts/webkitpy/common/config/contributors.json:
2632
2633 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2634
2635         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
2636
2637         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2638         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
2639         an expectation that will fail if we hit the race condition.
2640         This test is inherently racy and will deadlock if the first job
2641         for queue2 takes the mutex lock before the second job for
2642         queue1.
2643
2644 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2645
2646         [Win] WTF::WorkQueue does not balance ref/deref properly
2647         https://bugs.webkit.org/show_bug.cgi?id=142471
2648
2649         Reviewed by Antti Koivisto.
2650
2651         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2652         (TestWebKitAPI::TEST): Check that the refcount is correct.
2653
2654 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2655
2656         Do not show passing test result on output of EFL layout test
2657         https://bugs.webkit.org/show_bug.cgi?id=142380
2658
2659         Reviewed by Darin Adler.
2660
2661         To show passing tests has caused inconvenience when we detect problem tests
2662         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
2663         in order not to show passing tests in the output of EFL layout test.
2664
2665         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2666         (RunWebKitTests.start):
2667
2668 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2669
2670         Unreviewed build fix.
2671
2672         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2673         (TestWebKitAPI::TEST): Remove two unused variables.
2674
2675 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2676
2677         Add some WorkQueue tests to TestWebKitAPI
2678         https://bugs.webkit.org/show_bug.cgi?id=142447
2679
2680         Reviewed by Sam Weinig.
2681
2682         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2683         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2685         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
2686         (TestWebKitAPI::simpleTest):
2687         (TestWebKitAPI::longTest):
2688         (TestWebKitAPI::thirdTest):
2689         (TestWebKitAPI::finishedTests):
2690         (TestWebKitAPI::TEST):
2691         (TestWebKitAPI::longTest2):
2692
2693 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2694
2695         Remove willDestroyFrame in WKBundlePageLoaderClient
2696         https://bugs.webkit.org/show_bug.cgi?id=142389
2697
2698         Reviewed by Anders Carlsson.
2699
2700         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2701         (WTR::InjectedBundlePage::InjectedBundlePage):
2702
2703 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
2704
2705         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
2706         https://bugs.webkit.org/show_bug.cgi?id=142433
2707
2708         Reviewed by Darin Adler.
2709
2710         Include more TestWebKitAPI tests when building for Windows. Also
2711         fix a build error in MetaAllocator.cpp caused by one of the
2712         Microsoft headers #defining 'small'.
2713
2714         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2715         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2716         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2717
2718 2015-03-06  Sam Weinig  <sam@webkit.org>
2719
2720         [Content Extensions] Move compiling of content extensions to the UIProcess
2721         https://bugs.webkit.org/show_bug.cgi?id=142402
2722
2723         Reviewed by Benjamin Poulain.
2724
2725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2726         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
2727         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2728         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
2729         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2730         (TestWebKitAPI::TEST_F):
2731         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
2732         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
2733         is now abstract).
2734
2735 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
2736
2737         [Win] Correct Windows build.
2738
2739         Rubberstamped by Michael Saboff
2740
2741         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
2742         in the GOTO labels.
2743
2744 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2745
2746         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
2747         https://bugs.webkit.org/show_bug.cgi?id=142385
2748
2749         Reviewed by Sergio Villar Senin.
2750
2751         Use stack allocated GMainLoopSources to make sure they are
2752         cancelled automatically if the test finishes before they have
2753         been processed.
2754
2755         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2756         (testWebViewSyncRequestOnMaxConns):
2757
2758 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2759
2760         Remove Mountain Lion libraries since ML isn't supported
2761         https://bugs.webkit.org/show_bug.cgi?id=142332
2762
2763         Reviewed by Darin Adler.
2764
2765         * Scripts/copy-webkitlibraries-to-product-directory:
2766
2767 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
2768
2769         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
2770         https://bugs.webkit.org/show_bug.cgi?id=142083
2771
2772         Reviewed by Simon Fraser.
2773
2774         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2775
2776         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2777         (WebPlatformTestServer._copy_webkit_test_files):
2778
2779 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2780
2781         setup-git-clone fails due to the failure to download python-irclib-0.4.8
2782         https://bugs.webkit.org/show_bug.cgi?id=141946
2783
2784         Reviewed by Ryosuke Niwa.
2785
2786         Check in ircbot.py and irclib.py to avoid network problems in the future.
2787
2788         * Scripts/webkitpy/common/net/irc/ircbot.py:
2789         * Scripts/webkitpy/thirdparty/__init__.py:
2790         (AutoinstallImportHook.find_module):
2791         (AutoinstallImportHook._install_irc): Deleted.
2792         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2793         (ThirdpartyTest.test_imports):
2794         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2795         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2796         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2797
2798 2015-03-06  David Kilzer  <ddkilzer@apple.com>
2799
2800         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2801
2802         See also fix to config.json in r181097.
2803
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2805         (WebKitBuildbot): Add missing "WK2" to the names of the perf
2806         bots.
2807
2808 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2809
2810         run-jsc-stress-tests should determine the architecture from ELF binaries
2811         https://bugs.webkit.org/show_bug.cgi?id=142335
2812
2813         Reviewed by Darin Adler.
2814
2815         * Scripts/run-jsc-stress-tests:
2816
2817 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2818
2819         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2820         <http://webkit.org/b/142226>
2821
2822         Reviewed by Darin Adler.
2823
2824         * Scripts/webkitpy/port/ios.py:
2825         (IOSSimulatorPort.default_baseline_search_path): Switch the
2826         TestExpectations order of ios-simulator-wk2 from this:
2827           ios-simulator-wk2, wk2, ios-simulator
2828         To this:
2829           ios-simulator-wk2, ios-simualtor, wk2
2830
2831 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2832
2833         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2834         https://bugs.webkit.org/show_bug.cgi?id=142370
2835
2836         Reviewed by Dean Jackson.
2837
2838         * Scripts/webkitdirs.pm:
2839         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2840         logs, one for warnings, the other for errors.
2841         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2842         into the standard BuildOutput.htm document.
2843
2844 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2845
2846         Dashboard has trouble parsing iOS test output
2847         <http://webkit.org/b/142364>
2848
2849         Reviewed by Alex Christensen.
2850
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2852         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2853         Add fallback path to build a regex using 'matchString' so that
2854         it matches anywhere in the line.  In practice, 'matchString' is
2855         a prefix for the label following the number.
2856
2857 2015-03-05  Alex Christensen  <achristensen@webkit.org>
2858
2859         Fix linker warnings in TestWebKitAPI.
2860         https://bugs.webkit.org/show_bug.cgi?id=141912
2861
2862         Reviewed by David Kilzer.
2863
2864         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2865         Do not export TearDownTestCase or SetUpTestCase symbols.
2866
2867 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2868
2869         [Win] Unreviewed EWS fix.
2870
2871         * Scripts/webkitdirs.pm:
2872         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2873         the EWS output more usable.
2874
2875 2015-03-05  Chris Dumez  <cdumez@apple.com>
2876
2877         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2878         https://bugs.webkit.org/show_bug.cgi?id=142350
2879
2880         Reviewed by Michael Saboff and Benjamin Poulain.
2881
2882         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2883         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2884
2885         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2886         (TestWebKitAPI::TEST):
2887
2888 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2889
2890         [Win] Ensure build target directory exists when launching MSBuild
2891         https://bugs.webkit.org/show_bug.cgi?id=142360
2892
2893         Reviewed by Dean Jackson.
2894
2895         Create the build output directory (if it doesn't exist) before
2896         launching MSBuild so that it can immediately begin writing logs.
2897
2898         * Scripts/webkitdirs.pm:
2899         (buildVisualStudioProject):
2900
2901 2015-03-05  Chris Dumez  <cdumez@apple.com>
2902
2903         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2904         https://bugs.webkit.org/show_bug.cgi?id=142325
2905
2906         Reviewed by Csaba Osztrogonác.
2907
2908         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2909         As a result, "--webkit-test-runner / -2" parameters are replaced by
2910         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2911         than WebKitTestRunner.
2912
2913         * BuildSlaveSupport/build.webkit.org-config/config.json:
2914         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2915         (RunWebKit1Tests):
2916         (RunWebKit1Tests.start):
2917         (RunWebKit1LeakTests):
2918         (RunWebKit1LeakTests.start):
2919         (RunAndUploadPerfTestsWebKit1):
2920         (RunAndUploadPerfTestsWebKit1.start):
2921         (TestFactory):
2922         (TestWebKit1LeaksFactory):
2923         (TestWebKit1LeaksFactory.__init__):
2924         (TestWebKit1Factory):
2925         (TestWebKit1AllButJSCFactory):
2926         (TestAllButJSCFactory):
2927         (BuildAndPerfTestWebKit1Factory):
2928         (BuildAndPerfTestWebKit1Factory.__init__):
2929         (BuildAndPerfTestFactory):
2930         (BuildAndPerfTestFactory.__init__):
2931         (DownloadAndPerfTestWebKit1Factory):
2932         (DownloadAndPerfTestWebKit1Factory.__init__):
2933         (DownloadAndPerfTestFactory):
2934         (DownloadAndPerfTestFactory.__init__):
2935         (RunWebKitLeakTests): Deleted.
2936         (RunWebKitLeakTests.start): Deleted.
2937         (RunWebKit2Tests): Deleted.
2938         (RunWebKit2Tests.start): Deleted.
2939         (RunAndUploadPerfTestsWebKit2): Deleted.
2940         (RunAndUploadPerfTestsWebKit2.start): Deleted.
2941         (TestLeaksFactory): Deleted.
2942         (TestLeaksFactory.__init__): Deleted.
2943         (TestWebKit2Factory): Deleted.
2944         (TestWebKit2AndJSCFactory): Deleted.
2945         (BuildAndPerfTestWebKit2Factory): Deleted.
2946         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2947         (DownloadAndPerfTestWebKit2Factory): Deleted.
2948         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2949         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2950         (parse_args):
2951         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2952         (PerfTestsRunner._parse_args):
2953         * Scripts/webkitpy/port/port_testcase.py:
2954         (PortTestCase.test_build_driver):
2955
2956 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2957
2958         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2959         https://bugs.webkit.org/show_bug.cgi?id=140845
2960
2961         Reviewed by David Kilzer.
2962
2963         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2964         and generate suitable build commands to drive a full build from our
2965         existing solution files.
2966
2967         * Scripts/webkitdirs.pm:
2968         (msBuildInstallDir): Added.
2969         (determineConfigurationForVisualStudio): Revise to use MSBuild command
2970         line arguments to drive the build.
2971         (setupCygwinEnv): Warn user if MSBuild cannot be located.
2972         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2973         to specify build architecture.
2974         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2975         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2976         bother looking for CoreUI or SafariTheme build logs.
2977
2978 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2979
2980         [buildbot] mastercfg_unittest.py should be runnable easily
2981         https://bugs.webkit.org/show_bug.cgi?id=142219
2982
2983         Reviewed by Chris Dumez.
2984
2985         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2986         the last Twisted version works together with this buildbot version.
2987
2988         * Scripts/webkitpy/common/system/autoinstall.py:
2989         (AutoInstaller): Added prepend_to_search_path argument to be able
2990         to prefer autoinstalled package to system package.
2991         (AutoInstaller.__init__):
2992         (AutoInstaller._set_up_target_dir):
2993         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2994         (AutoInstaller._prepare_package):
2995         (AutoInstaller._extract_targz): Renamed to _extract_tar.
2996         * Scripts/webkitpy/thirdparty/__init__.py:
2997         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2998
2999 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
3000
3001         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
3002         https://bugs.webkit.org/show_bug.cgi?id=131162
3003
3004         Reviewed by Gyuyoung Kim.
3005
3006         * MiniBrowser/efl/main.c:
3007         (on_download_request):
3008         (on_download_finished):
3009         (on_download_failed):
3010         (window_create):
3011         Adapt download callbacks to new callback mechanism
3012
3013 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3014
3015         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
3016
3017         In r180927 we updated the libsoup version used by the jhbuild. In
3018         this new version the sniffer uses image/x-icon instead of
3019         image/vnd.microsoft.icon for blank.ico resource.
3020
3021         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3022         (testWebResourceMimeType):
3023
3024 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3025
3026         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
3027         https://bugs.webkit.org/show_bug.cgi?id=142244
3028
3029         Reviewed by Sergio Villar Senin.
3030
3031         Check that the SSL server doesn't process any request in case of
3032         TLS errors when the policy is set to FAIL.
3033
3034         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3035         (testTLSErrorsPolicy):
3036         (testTLSErrorsRedirect):
3037         (testTLSErrorsHTTPAuth):
3038         (testLoadFailedWithTLSErrors):
3039         (testSubresourceLoadFailedWithTLSErrors):
3040         (httpsServerCallback):
3041
3042 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
3043
3044         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
3045         https://bugs.webkit.org/show_bug.cgi?id=141154
3046
3047         Reviewed by Jer Noble.
3048
3049         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
3050
3051         For the sake of completeness WebKitTestRunner should specify temporary
3052         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
3053
3054         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
3055         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3056         to get data storage paths. Only Mac port has an actual implementation of it.
3057         However, WebKitTestRunner overrides them in favour of unique temporary dir
3058         which is taken from libraryPathForTesting().
3059
3060         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3061         is not implemented for EFL and GTK ports it returns an empty string.
3062         All default data folders besides MediaKeys are overridden in TestRunner
3063         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
3064         env variable.
3065
3066         GTK port does not enable encrypted keys by default so
3067         WebMediaKeyStorageManager::initialize() code path is never triggered.
3068
3069         * WebKitTestRunner/TestController.cpp:
3070         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
3071         WebKit ports.
3072
3073 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
3074
3075         [buildbot] Add regression test to check which builder runs which tests
3076         https://bugs.webkit.org/show_bug.cgi?id=142166
3077
3078         Reviewed by Alexey Proskuryakov.
3079
3080         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3081         (BuildStepsConstructorTest.createTest):
3082         (BuildStepsTest):
3083         (BuildStepsTest.generateTests):
3084         (BuildStepsTest.createTest):
3085         (BuildStepsTest.createTest.doTest):
3086         (BuildStepsTest.test_unnecessary_expected_results):
3087
3088 2015-03-04  Commit Queue  <commit-queue@webkit.org>
3089
3090         Unreviewed, rolling out r181054.
3091         https://bugs.webkit.org/show_bug.cgi?id=142320
3092
3093         Broke the api tests (Requested by sundiamonde on #webkit).
3094
3095         Reverted changeset:
3096
3097         "Fix linker warnings in TestWebKitAPI."
3098         https://bugs.webkit.org/show_bug.cgi?id=141912
3099         http://trac.webkit.org/changeset/181054
3100
3101 2015-03-04  Alex Christensen  <achristensen@webkit.org>
3102
3103         Fix linker warnings in TestWebKitAPI.
3104         https://bugs.webkit.org/show_bug.cgi?id=141912
3105
3106         Reviewed by David Kilzer.
3107
3108         * TestWebKitAPI/Configurations/Base.xcconfig:
3109         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
3110
3111 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
3112
3113         [Mac] Set SystemUIFontSelect in DRT and WKTR
3114         https://bugs.webkit.org/show_bug.cgi?id=142303
3115
3116         Reviewed by Myles C. Maxfield.
3117
3118         * DumpRenderTree/mac/DumpRenderTree.mm:
3119         (setDefaultsToConsistentValuesForTesting):
3120         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3121         (WTR::InjectedBundle::platformInitialize):
3122
3123 2015-03-04  Chris Dumez  <cdumez@apple.com>
3124
3125         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3126         https://bugs.webkit.org/show_bug.cgi?id=142314
3127         <rdar://problem/20046835>
3128
3129         Reviewed by Ryosuke Niwa.
3130
3131         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3132         to get WK2 code coverage.
3133
3134         * BuildSlaveSupport/build.webkit.org-config/config.json:
3135
3136 2015-03-04  Alex Christensen  <achristensen@webkit.org>
3137
3138         Move content extensions test to properly named directory.
3139         https://bugs.webkit.org/show_bug.cgi?id=142299
3140
3141         Reviewed by Tim Horton.
3142
3143         * WebKitTestRunner/mac/TestControllerMac.mm:
3144         (WTR::TestController::platformConfigureViewForTest):
3145
3146 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3147
3148         W3C test importer should use filesystem instead of os.walk
3149         https://bugs.webkit.org/show_bug.cgi?id=142085
3150
3151         Reviewed by Bem Jones-Bey.
3152
3153         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
3154         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
3155         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
3156
3157         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
3158         Added a unit test to check that test importer is now black-box testable using a Mock system.
3159
3160         * Scripts/webkitpy/common/system/filesystem.py:
3161         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
3162         (FileSystem.dirs_under.filter_all):
3163         * Scripts/webkitpy/common/system/filesystem_mock.py:
3164         (MockFileSystem.dirs_under):
3165         (MockFileSystem.dirs_under.filter_all):
3166         (MockFileSystem.getsize):
3167         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3168         (MockFileSystemTest.test_dirs_under):
3169         (MockFileSystemTest.test_dirs_under.filter_dir):
3170         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3171         (RealFileSystemTest.test_sep):
3172         (RealFileSystemTest):
3173         (RealFileSystemTest.test_dirs_under):
3174         (RealFileSystemTest.test_dirs_under.filter_this_dir):
3175         * Scripts/webkitpy/w3c/test_importer.py:
3176         (TestImporter.do_import):
3177         (TestImporter.find_importable_tests.should_keep_subdir):
3178         (TestImporter.find_importable_tests):
3179         (TestImporter.should_keep_subdir): Deleted.
3180         (TestImporter.should_skip_file): Deleted.
3181         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3182         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
3183
3184 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
3185
3186         [WebEditingTester] Add support for the find and replace bar
3187         https://bugs.webkit.org/show_bug.cgi?id=142247
3188
3189         Reviewed by Enrica Casucci.
3190
3191         While it's not hooked up yet in WKWebView, adding support for the
3192         find bar to WebEditingTester will help us implement that functionality.
3193
3194         * WebEditingTester/AppDelegate.h:
3195         * WebEditingTester/AppDelegate.m:
3196         (-[WebEditingAppDelegate performTextFinderAction:]):
3197         * WebEditingTester/MainMenu.xib:
3198         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
3199
3200         * WebEditingTester/WK2WebDocumentController.m:
3201         (-[WK2WebDocumentController awakeFromNib]):
3202         (-[WK2WebDocumentController performTextFinderAction:]):
3203         (-[WK2WebDocumentController findBarView]):
3204         (-[WK2WebDocumentController setFindBarView:]):
3205         (-[WK2WebDocumentController isFindBarVisible]):
3206         (-[WK2WebDocumentController setFindBarVisible:]):
3207         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
3208         (-[WK2WebDocumentController layout]):
3209         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
3210         pointing at the WKWebView (currently nothing will work, but the bar will
3211         show up). Install and uninstall the bar as needed.
3212
3213         * WebEditingTester/WebDocument.xib:
3214         Don't use a full-size content view. There's no need, and it makes find
3215         bar layout harder.
3216
3217         * WebEditingTester/WebDocumentController.h:
3218         * WebEditingTester/WebDocumentController.m:
3219         (-[WebDocumentController performTextFinderAction:]):
3220
3221 2015-03-03  Sam Weinig  <sam@webkit.org>
3222
3223         [Content Extensions] Split parsing and compiling of content extensions into their own files
3224         https://bugs.webkit.org/show_bug.cgi?id=142259
3225
3226         Reviewed by Anders Carlsson.
3227
3228         Add basic unit test for the content filter compiler.
3229
3230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3231         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
3232         (WebCore::ContentExtensions::operator<<):
3233         (TestWebKitAPI::ContentFilterTest::SetUp):
3234         (TestWebKitAPI::TEST_F):
3235
3236 2015-03-04  Matthew Mirman  <mmirman@apple.com>
3237
3238         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
3239         https://bugs.webkit.org/show_bug.cgi?id=142230
3240
3241         Reviewed by Csaba Osztrogonác.
3242
3243         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3244         (TestFactory):
3245         (TestFactory.getProduct): Added
3246         (TestFactory.__init__): moved downloader to getProduct
3247         (BuildAndTestFactory):        
3248         (BuildAndTestFactory.getProduct): Added
3249         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
3250         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
3251
3252 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
3253
3254         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
3255         https://bugs.webkit.org/show_bug.cgi?id=142225
3256
3257         Reviewed by Carlos Garcia Campos.
3258
3259         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3260         (testWebViewWebContextLifetime):
3261         (beforeAll):
3262
3263 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3264
3265         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
3266         <http://webkit.org/b/142243>
3267
3268         Reviewed by Alexey Proskuryakov.
3269
3270         * WebKitTestRunner/TestController.cpp:
3271         (WTR::TestController::webProcessName):
3272         (WTR::TestController::networkProcessName):
3273         - Return the same process name on iOS and Mac because they both
3274           use the same process name for local engineering builds.
3275
3276 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3277
3278         check-webkit-style: Add exception for FrameworkSoftLink.h header order
3279         <http://webkit.org/b/141872>
3280
3281         Reviewed by Alex Christensen.
3282
3283         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
3284         semi-colons in various places and fix whitespace.
3285         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
3286         constants.
3287         (_IncludeState.__init__): Add self._visited_soft_link_section
3288         boolean state variable.
3289         (_IncludeState.visited_soft_link_section): Getter for
3290         self._visited_soft_link_section.
3291         (_IncludeState.check_next_include_order): Update state machine
3292         for soft-link headers.  Add check that soft-link headers always
3293         appear last.
3294         (_classify_include): Add check for soft-link header type.
3295         (check_include_line): Return early if there is a soft-link
3296         header error.
3297
3298         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3299         (OrderOfIncludesTest.test_public_primary_header): Add tests for
3300         including soft-link headers.
3301         (OrderOfIncludesTest.test_classify_include): Add test for
3302         _SOFT_LINK_HEADER type.
3303
3304 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
3305
3306         build.webkit.org/dashboard: Don't repeatedly handle each test type
3307         https://bugs.webkit.org/show_bug.cgi?id=142211
3308
3309         Reviewed by Tim Horton and Matt Hanson.
3310
3311         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3312         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
3313         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
3314         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
3315         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
3316         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
3317         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
3318         Removed functions that build a link to test step results. The buildbot provides
3319         these links in JSON.
3320
3321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3322         (BuildbotIteration): Put failing tests into an array, instead of named variables.
3323         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
3324         We can easily add them to the map as needed.
3325         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
3326         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
3327         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
3328         and then build a BuildbotTestResults object, which was strange.
3329         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
3330
3331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3332         Corrected an unrelated assertion that was buggy, and kept firing.
3333
3334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3335         (BuildbotTestResults):
3336         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
3337         (BuildbotTestResults.prototype._parseResults):
3338         (BuildbotTestResults.prototype.addFullLayoutTestResults):
3339         Moved the code for parsing JSON results for a single step here.
3340
3341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3342         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
3343         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
3344         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
3345         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
3346         (BuildbotTesterQueueView.prototype.update): Deleted.
3347         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
3348         Updated for the new data structures. One behavior change is that we now display individual
3349         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
3350         test failures, 3 platform api test failures".
3351
3352 2015-03-03  Matthew Mirman  <mmirman@apple.com>
3353
3354         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
3355         https://bugs.webkit.org/show_bug.cgi?id=142094
3356
3357         Reviewed by Csaba Osztrogonác.
3358
3359         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
3360         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3361         (TestFactory):
3362         (TestFactory.__init__): Made running of JSC tests conditional.
3363         (TestAllButJSCFactory):
3364         (TestJSCFactory): Added.
3365         (TestJSCFactory.__init__):
3366         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
3367
3368 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3369
3370         `build-webkit --help` is wrong about how to build for the iOS simulator
3371         <http://webkit.org/b/142223>
3372
3373         Reviewed by Csaba Osztrogonác.
3374
3375         * Scripts/build-webkit: Fix help.
3376
3377 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3378
3379         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
3380
3381         * gtk/jhbuild.modules:
3382
3383 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3384
3385         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
3386         https://bugs.webkit.org/show_bug.cgi?id=141508
3387
3388         Reviewed by Sergio Villar Senin.
3389
3390         Add a unit test to check that synchronous XHRs load even if the
3391         maximum connection limits are reached.
3392
3393         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3394         (testWebViewSyncRequestOnMaxConns):
3395         (serverCallback):
3396         (beforeAll):
3397         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
3398
3399 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
3400
3401         Update the name of ASan build step.
3402
3403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3404
3405 2015-03-02  Jer Noble  <jer.noble@apple.com>
3406
3407         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
3408         https://bugs.webkit.org/show_bug.cgi?id=142121
3409
3410         Reviewed by Simon Fraser.
3411
3412         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
3413         that the initial and final screen rects for the web content are as expected.
3414
3415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3416         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
3417         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
3418         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3419         (runJavaScriptAlert):
3420         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3421         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3422         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
3423         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
3424         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
3425         (TestWebKitAPI::TEST_F):
3426
3427 2015-03-01  David Kilzer  <ddkilzer@apple.com>
3428
3429         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
3430
3431         Follow-up fix for:
3432
3433         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
3434         <http://webkit.org/b/142145>
3435
3436         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3437         (-[LTRelayController _environmentVariables]): Fix think-o.
3438
3439 2015-03-01  David Kilzer  <ddkilzer@apple.com>
3440
3441         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
3442         <http://webkit.org/b/142145>
3443
3444         Reviewed by Simon Fraser.
3445
3446         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3447         (-[LTRelayController _environmentVariables]): Add.
3448         (-[LTRelayController launchApp]): Use -_environmentVariables.
3449
3450 2015-02-28  David Kilzer  <ddkilzer@apple.com>
3451
3452         [iOS] Stop running webkit-build-directory on every layout test
3453
3454         This was originally fixed by David Farler for Bug 135409 in
3455         r172602.
3456
3457         * Scripts/webkitpy/port/ios.py:
3458         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
3459         run webkit-build-directory every time it's called.
3460
3461 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3462
3463         W3C importer should use filesystem instead of shutil/host
3464         https://bugs.webkit.org/show_bug.cgi?id=142012
3465
3466         Reviewed by Bem Jones-Bey.
3467
3468         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
3469
3470         * Scripts/webkitpy/w3c/test_importer.py:
3471         (main):
3472         (TestImporter.do_import):
3473         (TestImporter.find_importable_tests):
3474         (TestImporter.import_tests):
3475         (TestImporter.remove_deleted_files):
3476         (TestImporter.write_import_log):
3477
3478 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3479
3480         W3C test importer should use filesystem to read and write files
3481         https://bugs.webkit.org/show_bug.cgi?id=142084
3482
3483         Reviewed by Bem Jones-Bey.
3484
3485         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
3486
3487         * Scripts/webkitpy/w3c/test_importer.py:
3488         (TestImporter.import_tests):
3489         (TestImporter.remove_deleted_files):
3490         (TestImporter.write_import_log):
3491
3492 2015-02-27  Sam Weinig  <sam@webkit.org>
3493
3494         Add WebKit2 SPI to create a DOM File object
3495         https://bugs.webkit.org/show_bug.cgi?id=142109
3496
3497         Reviewed by Tim Horton.
3498
3499         Add a test for WKBundleFileHandleRef.
3500
3501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3502         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
3503         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3504         (TestWebKitAPI::didFinishLoadForFrame):
3505         (TestWebKitAPI::TEST):
3506         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
3507         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
3508         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
3509
3510 2015-02-27  Michael Saboff  <msaboff@apple.com>
3511
3512         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
3513         https://bugs.webkit.org/show_bug.cgi?id=142112
3514
3515         Reviewed by Filip Pizlo.
3516
3517         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
3518         <someDir> as the library path.
3519
3520         * Scripts/run-jsc-benchmarks:
3521
3522 2015-02-27  Alex Christensen  <achristensen@webkit.org>
3523
3524         [WinCairo] Unreviewed build fix.
3525
3526         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3527         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
3528
3529 2015-02-27  Anders Carlsson  <andersca@apple.com>
3530
3531         Add infrastructure for handling website data in the network process
3532         https://bugs.webkit.org/show_bug.cgi?id=142092
3533
3534         Reviewed by Andreas Kling.
3535
3536         Add a menu item that will fetch all website data, delete the returned data records, and
3537         fetch all website data again so we can confirm that it's all empty.
3538
3539         * MiniBrowser/mac/WK2BrowserWindowController.m:
3540         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3541
3542 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3543
3544         [Win] Remove remaining SafariTheme cruft
3545         https://bugs.webkit.org/show_bug.cgi?id=142075
3546
3547         Reviewed by Anders Carlsson.
3548
3549         Remove reference to SafariTheme-switching preference.
3550
3551         * DumpRenderTree/win/DumpRenderTree.cpp:
3552         (resetWebPreferencesToConsistentValues):
3553         (prepareConsistentTestingEnvironment):
3554
3555 2015-02-26  Doug Russell  <d_russell@apple.com>
3556
3557         AX: Expose caret browsing preference to accessibility API
3558         https://bugs.webkit.org/show_bug.cgi?id=141862
3559
3560         Reviewed by Chris Fleizach.
3561
3562         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
3563         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
3564
3565         * DumpRenderTree/AccessibilityUIElement.cpp:
3566         (setBoolAttributeValueCallback):
3567         (selectedTextMarkerRangeCallback):
3568         (resetSelectedTextMarkerRangeCallback):
3569         (AccessibilityUIElement::setBoolAttributeValue):
3570         (AccessibilityUIElement::selectedTextMarkerRange):
3571         (AccessibilityUIElement::resetSelectedTextMarkerRange):
3572         (AccessibilityUIElement::getJSClass):
3573         * DumpRenderTree/AccessibilityUIElement.h:
3574         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3575         (AccessibilityUIElement::setBoolAttributeValue):
3576         (AccessibilityUIElement::selectedTextMarkerRange):
3577         (AccessibilityUIElement::resetSelectedTextMarkerRange):
3578         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3579         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
3580         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
3581         (WTR::AccessibilityUIElement::setBoolAttributeValue):
3582         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3583         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3584         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3585         (WTR::AccessibilityUIElement::setBoolAttributeValue):
3586         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
3587         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
3588
3589 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3590
3591         [Win] Remove WebKitExportGenerator project (and related)
3592         https://bugs.webkit.org/show_bug.cgi?id=142035
3593
3594         Reviewed by Dean Jackson.
3595
3596         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
3597         build log from WebKitExportGenerator.
3598
3599 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
3600
3601         [EFL] Bump EFL version to 1.13.0
3602         https://bugs.webkit.org/show_bug.cgi?id=141708
3603
3604         Reviewed by Gyuyoung Kim.
3605
3606         * efl/jhbuild.modules:
3607
3608 2015-02-26  Sam Weinig  <sam@webkit.org>
3609
3610         Check in missing WebEditingTester.xcconfig file.
3611
3612         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
3613
3614 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
3615
3616         [webkitpy] Remove skipped file related crufts
3617         https://bugs.webkit.org/show_bug.cgi?id=142046
3618
3619         Reviewed by Ryosuke Niwa.
3620
3621         * Scripts/webkitpy/port/base.py:
3622         (Port.skipped_layout_tests):
3623         (Port._tests_from_skipped_file_contents): Deleted.
3624         (Port): Deleted.
3625         (Port._expectations_from_skipped_files): Deleted.
3626         * Scripts/webkitpy/port/mac_unittest.py:
3627         (MacTest.test_default_timeout_ms):
3628         (MacTest): Deleted.
3629         (test_tests_from_skipped_file_contents): Deleted.
3630
3631 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3632
3633         [Win] Unreviewed WinCairo build fix after r180653.
3634
3635         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
3636
3637         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3638         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3639         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3640         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
3641         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
3642
3643 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
3644
3645         [Win] Use WEBCORE_EXPORT instead of Definition file
3646         https://bugs.webkit.org/show_bug.cgi?id=141734
3647
3648         Reviewed by Alex Christensen.
3649
3650         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3651         Use a precompiled header so we can define our export macros properly.
3652         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
3653         Visual studio automatic update stuff.
3654         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3655         Set up Precompiled Header use for project..
3656         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
3657         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
3658         declarations for building DumpRenderTree as a client of
3659         WebCore/WebKit.
3660
3661 2015-02-25  Mark Lam  <mark.lam@apple.com>
3662
3663         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
3664         <https://webkit.org/b/141672>
3665
3666         Reviewed by Alexey Proskuryakov.
3667
3668         ASan does not like the fact that we memcpy the stack for GC scans.  So,
3669         we're working around this by using our own memcpy (asanUnsafeMemcpy)
3670         implementation that we can tell ASan to ignore.
3671
3672         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
3673         which isn't effective for working around this issue. 
3674
3675         * asan/webkit-asan-ignore.txt:
3676
3677 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
3678
3679         CodeBlock crashes when dumping op_push_name_scope
3680         https://bugs.webkit.org/show_bug.cgi?id=141953
3681
3682         Reviewed by Filip Pizlo.
3683
3684         * Scripts/run-jsc-stress-tests:
3685
3686 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3687