-[WKWebView evaluateJavaScript] provides a misleading error when the return cannot...
[WebKit-https.git] / Tools / ChangeLog
1 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
2
3         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
4         https://bugs.webkit.org/show_bug.cgi?id=145900
5
6         Reviewed by Sam Weinig.
7
8         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
9         (TEST): Added tests.
10
11 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
12
13         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
14         https://bugs.webkit.org/show_bug.cgi?id=145969
15
16         Reviewed by Sergio Villar Senin.
17
18         Add a test case to the custom URI schemes unit test.
19
20         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
21         (testWebContextURIScheme):
22
23 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
24
25         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
26         https://bugs.webkit.org/show_bug.cgi?id=145922
27
28         Reviewed by Carlos Garcia Campos.
29
30         * gtk/jhbuild.modules:
31         * gtk/patches/glib-warning-fix.patch: Added.
32
33 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
34
35         Update springLoadingHighlight type
36         https://bugs.webkit.org/show_bug.cgi?id=145939
37         rdar://problem/20880213
38
39         Reviewed by Darin Adler.
40
41         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
42         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
43         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
44         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
45
46 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
47
48         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
49         https://bugs.webkit.org/show_bug.cgi?id=145945
50
51         Reviewed by Stephanie Lewis.
52
53         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
54         (OSXBrowserDriver.prepareEnv):
55         (OSXBrowserDriver.moveCursor): Deleted.
56         (OSXBrowserDriver): Deleted.
57         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
58         (OSXSafariDriver.prepareEnv):
59
60 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
61
62         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
63         https://bugs.webkit.org/show_bug.cgi?id=145938
64
65         Reviewed by Alexey Proskuryakov.
66
67         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
68         LWP::UserAgent to get access to more robust HTTPS support.
69
70 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
71
72         [GTK] Fix return type warning in WebViewTest.cpp
73         https://bugs.webkit.org/show_bug.cgi?id=145914
74
75         Reviewed by Darin Adler.
76
77         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
78         (WebViewTest::isEditable):
79
80 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
81
82         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
83         https://bugs.webkit.org/show_bug.cgi?id=145799
84
85         Reviewed by Carlos Garcia Campos.
86
87         Update header inclusions for headers that have been moved
88         to Source/WTF/wtf/glib/.
89
90         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
91         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
92
93         * TestWebKitAPI/PlatformGTK.cmake:
94         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
95         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
96         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
97         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
98         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
99         (TestWebKitAPI::GMainLoopSourceTest::finish):
100         (TestWebKitAPI::GMainLoopSourceTest::source):
101         (TestWebKitAPI::basicRescheduling):
102         (TestWebKitAPI::TEST):
103         (TestWebKitAPI::reentrantRescheduling):
104         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
105         (TestWebKitAPI::basicDestroyCallbacks):
106         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
107         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
108         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
109         (log):
110         (takeLogStr):
111         (TestWebKitAPI::TEST):
112         (TestWebKitAPI::returnOutChar):
113         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
114         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
115         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
116         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
117         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
118         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
119         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
120         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
121         (TestWebKitAPI::basicRescheduling): Deleted.
122         (TestWebKitAPI::TEST): Deleted.
123         (TestWebKitAPI::reentrantRescheduling): Deleted.
124         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
125         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
126         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
127         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
128         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
129         (log): Deleted.
130         (takeLogStr): Deleted.
131         (TestWebKitAPI::TEST): Deleted.
132         (TestWebKitAPI::returnOutChar): Deleted.
133         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
134         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
135         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
136         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
137         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
138         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
139         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
140         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
141         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
142         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
143         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
144         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
145         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
146         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
147         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
148         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
149         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
150         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
151         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
152         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
153         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
154         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
155         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
156         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
157         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
158         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
159         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
160         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
161         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
162         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
163         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
164         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
165         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
166         * WebKitTestRunner/InjectedBundle/TestRunner.h:
167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
168         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
169         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
170         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
171         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
172         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
173         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
174         * WebKitTestRunner/PlatformGTK.cmake:
175         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
176         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
177
178 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
179
180         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
181         https://bugs.webkit.org/show_bug.cgi?id=145913
182
183         Reviewed by Gyuyoung Kim.
184
185         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
186         (TestWebKitAPI::setupGeolocationProvider):
187         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
188         (TestWebKitAPI::setPageLoaderClient):
189         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
190         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
191         * WebKitTestRunner/GeolocationProviderMock.cpp:
192         (WTR::GeolocationProviderMock::GeolocationProviderMock):
193         * WebKitTestRunner/WebNotificationProvider.cpp:
194         (WTR::WebNotificationProvider::provider):
195
196 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
197
198         Fix the libusrsctp build with clang
199         https://bugs.webkit.org/show_bug.cgi?id=145128
200
201         Reviewed by Gyuyoung Kim.
202
203         * efl/jhbuild.modules:
204         * gtk/jhbuild.modules:
205
206 2015-06-11  Mark Lam  <mark.lam@apple.com>
207
208         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
209         https://bugs.webkit.org/show_bug.cgi?id=145872
210
211         Reviewed by Michael Saboff.
212
213         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
214         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
215         - Exercises the JSC ObjC API to call a function which throws an exception.  That
216           exception will be returned as a JSValue instead of an Exception object.  We
217           will use this JSValue to test WebCore::reportException() to confirm that it is
218           able to handle an exception value which is not an Exception object.
219
220 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
221
222         Move cursor to corner and fix safari window size before running benchmark
223         https://bugs.webkit.org/show_bug.cgi?id=145858
224
225         Reviewed by Ryosuke Niwa
226
227         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
228         (OSXBrowserDriver.prepareEnv):
229         (OSXBrowserDriver):
230         (OSXBrowserDriver.moveCursor):
231         (OSXBrowserDriver.getScreenSize):
232         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
233         (OSXChromeDriver.launchUrl):
234         (OSXChromeCanaryDriver.launchUrl):
235         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
236         (OSXFirefoxDriver.launchUrl):
237         (OSXFirefoxNightlyDriver.launchUrl):
238         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
239         (OSXSafariDriver.prepareEnv):
240         (OSXSafariDriver):
241         (OSXSafariDriver.maximizeWindow):
242
243 2015-06-11  Daniel Bates  <dabates@apple.com>
244
245         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
246         https://bugs.webkit.org/show_bug.cgi?id=145319
247
248         Reviewed by David Kilzer.
249
250         Add SPI wrapper header for CoreSimulator and update the source files to reference
251         it instead of directly referencing the CoreSimulator header.
252
253         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
254         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
255         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
256         * LayoutTestRelay/LayoutTestRelay/main.m:
257
258 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
259
260         [EFL] dimmed area for popup does not cover the fullscreen mode.
261         https://bugs.webkit.org/show_bug.cgi?id=145133
262
263         Reviewed by Gyuyoung Kim.
264
265         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
266         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
267
268         * MiniBrowser/efl/main.c:
269         (on_fullscreen_accept):
270         (on_fullscreen_deny):
271         (on_fullscreen_enter):
272
273 2015-06-10  Commit Queue  <commit-queue@webkit.org>
274
275         Unreviewed, rolling out r185442.
276         https://bugs.webkit.org/show_bug.cgi?id=145871
277
278         seems to have broken WTF.StringOperators test (Requested by
279         alexchristensen on #webkit).
280
281         Reverted changeset:
282
283         "[Content Extensions] Limit number of rules."
284         https://bugs.webkit.org/show_bug.cgi?id=145663
285         http://trac.webkit.org/changeset/185442
286
287 2015-06-10  Alex Christensen  <achristensen@webkit.org>
288
289         [Content Extensions] Make max NFA size and max rule count user defaults.
290         https://bugs.webkit.org/show_bug.cgi?id=145663
291         rdar://problem/21242407
292
293         Reviewed by Benjamin Poulain.
294
295         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
296         (TestWebKitAPI::TEST_F):
297
298 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
299
300         [EFL] Execute Javascript method in mini browser address bar.
301         https://bugs.webkit.org/show_bug.cgi?id=145725
302
303         Reviewed by Gyuyoung Kim.
304
305         Support 'javascript:' scheme in WebKit EFL Mini Browser.
306
307         * MiniBrowser/efl/main.c:
308         (url_from_user_input):
309         (url_load_from_user_input):
310         (on_url_bar_activated):
311         (elm_main):
312
313 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
314
315         Implement dumpProgressFinishedCallback() for Win layoutTestController.
316         https://bugs.webkit.org/show_bug.cgi?id=66773
317
318         Reviewed by Darin Adler.
319
320         * DumpRenderTree/win/FrameLoadDelegate.cpp:
321         * DumpRenderTree/win/FrameLoadDelegate.h:
322
323 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
324
325         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
326         https://bugs.webkit.org/show_bug.cgi?id=145764
327
328         Reviewed by Darin Adler.
329
330         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
331         JetStream and SunSpider.
332
333         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
334         (GenericBenchmarkBuilder):
335         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
336         the whole JSON as the input.
337         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
338         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
339         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
340         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
341         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
342         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
343         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
344
345 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
346
347         Remove ewstool scripts used by chromium port
348         https://bugs.webkit.org/show_bug.cgi?id=145789
349
350         Reviewed by Csaba Osztrogonác.
351
352         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
353         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
354         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
355         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
356         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
357
358 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
359
360         Unreviewed, updated my list of email addresses.
361
362         * Scripts/webkitpy/common/config/contributors.json:
363
364 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
365
366         [cmake] Fix the style issues in cmake project files
367         https://bugs.webkit.org/show_bug.cgi?id=145755
368
369         Reviewed by Darin Adler.
370
371         * TestWebKitAPI/CMakeLists.txt:
372         * TestWebKitAPI/PlatformEfl.cmake:
373
374 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
375
376         Fix a typo in r185345.
377
378         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
379         (OSXSafariDriver.closeBrowsers):
380
381 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
382
383         Yet another unreviewed build fix :(
384
385         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
386         (OSXSafariDriver):
387         (OSXSafariDriver.launchUrl):
388         (OSXSafariDriver.closeBrowsers):
389
390 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
391
392         Unreviewed build fix. Initialize result in the case things blow up below.
393
394         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
395         (BenchmarkRunner.execute):
396
397 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
398
399         Partially revert and fix after r185243.
400
401         * Scripts/benchmark_runner/benchmark_runner.py:
402         * Scripts/run-benchmark:
403
404 2015-06-08  Daniel Bates  <dabates@apple.com>
405
406         Many LayoutTests/http tests time out in DumpRenderTree
407         https://bugs.webkit.org/show_bug.cgi?id=145770
408         <rdar://problem/19593910>
409
410         Reviewed by Alexey Proskuryakov.
411
412         * DumpRenderTree/ios/Info.plist: Add ATS key.
413         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
414         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
415         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
416         that make use of testRunner.pathToLocalResource().
417
418 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
419
420         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
421         https://bugs.webkit.org/show_bug.cgi?id=145759
422
423         Reviewed by Carlos Garcia Campos.
424
425         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
426         (testWebViewSave):
427
428 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
429
430         [GTK] Add editor mode to MiniBrowser
431         https://bugs.webkit.org/show_bug.cgi?id=145595
432
433         Reviewed by Sergio Villar Senin.
434
435         It loads an empty editable web view with an edit toolbar. It makes
436         easier to test the editor, editing commands and input methods.
437
438         * MiniBrowser/gtk/BrowserWindow.c:
439         (editingCommandCallback):
440         (browserWindowSetupEditorToolbar):
441         (browserWindowConstructed):
442         * MiniBrowser/gtk/main.c:
443         (createBrowserWindow):
444
445 2015-06-05  Zalan Bujtas  <zalan@apple.com>
446
447         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
448
449         Reviewed by Dan Bernstein.
450
451         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
452         (TestWebKitAPI::TEST):
453
454 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
455
456         [EFL] API test has been broken since r184357
457         https://bugs.webkit.org/show_bug.cgi?id=145635
458
459         Reviewed by Darin Adler.
460
461         r184357 suppress cmake build warning using TARGET_FILE property. However
462         many EFL API test cases have been broken after applying it.
463
464         * TestWebKitAPI/CMakeLists.txt:
465
466 2015-06-05  Anders Carlsson  <andersca@apple.com>
467
468         Make the network cache directory part of WKContextConfigurationRef
469         https://bugs.webkit.org/show_bug.cgi?id=145711
470
471         Reviewed by Antti Koivisto.
472
473         * WebKitTestRunner/TestController.cpp:
474         (WTR::TestController::initialize):
475
476 2015-06-05  Anders Carlsson  <andersca@apple.com>
477
478         Make the application cache directory part of WKContextConfigurationRef
479         https://bugs.webkit.org/show_bug.cgi?id=145704
480
481         Reviewed by Geoffrey Garen.
482
483         * WebKitTestRunner/TestController.cpp:
484         (WTR::TestController::initialize):
485
486 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
487
488         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
489         https://bugs.webkit.org/show_bug.cgi?id=145680
490
491         Reviewed by Brent Fulgham.
492
493         * Scripts/webkitpy/style/checkers/cpp.py:
494         (check_for_null):
495         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
496         (WebKitStyleTest.test_null_false_zero):
497
498 2015-06-05  Stephanie Lewis  <slewis@apple.com>
499
500         Make the web server more robust to timing issues..
501
502         Reviewed by Ryosuke Niwa.
503
504         Cleaned up exception handling.
505         Test server is actually serving pages before returning.
506         Clean up some style issues.
507
508         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
509         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
510         (SimpleHTTPServerDriver.__init__):
511         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
512         (SimpleHTTPServerDriver.baseUrl): 
513         (SimpleHTTPServerDriver.fetchResult):
514         (SimpleHTTPServerDriver.killServer):
515         (SimpleHTTPServerDriver.getReturnCode):
516
517 2015-06-05  Stephanie Lewis  <slewis@apple.com>
518
519
520         Add errors to run-benchmark exception handling.
521
522         Reviewed by Ryosuke Niwa.
523
524         * Scripts/run-benchmark:
525         (main):
526         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
527         (GenericBenchmarkBuilder.prepare):
528         (GenericBenchmarkBuilder._runCreateScript):
529         (GenericBenchmarkBuilder._applyPatch):
530         (GenericBenchmarkBuilder.clean):
531         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
532         (BenchmarkRunner.__init__):
533         (BenchmarkRunner.execute):
534         (BenchmarkRunner):
535         (BenchmarkRunner.cleanup):
536         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
537         (GenericFactory.iterateGetItem):
538         (GenericFactory.create):
539         * Scripts/webkitpy/benchmark_runner/utils.py:
540         (loadModule):
541         (loadJSONFromFile):
542         (forceRemove):
543
544 2015-06-05  Stephanie Lewis  <slewis@apple.com>
545
546         Streamline run-benchmark browser
547
548         Reviewed by Ryosuke Niwa.
549
550         Add Caffeinate so computer won't sleep while running.
551         Remove calls to collect output since we were just dumping to stdout anyway.
552         Add xpc dyld_path.
553         Default to system safari.
554
555         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
556         (OSXBrowserDriver.launchProcess):
557         (OSXBrowserDriver.terminateProcesses):
558         (OSXBrowserDriver):
559         (OSXBrowserDriver.launchCaffeinateForProcess):
560         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
561         (OSXSafariDriver.launchUrl):
562         (OSXSafariDriver.closeBrowsers):
563
564 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
565
566         Combine tiny DFAs into slightly larger ones
567         https://bugs.webkit.org/show_bug.cgi?id=145572
568
569         Reviewed by Alex Christensen.
570
571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
572         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
573         (TestWebKitAPI::DFACombinerTest::SetUp):
574         (TestWebKitAPI::combine):
575         (TestWebKitAPI::TEST_F):
576         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
577         (TestWebKitAPI::countLiveNodes):
578         (TestWebKitAPI::createNFAs):
579         (TestWebKitAPI::buildDFAFromPatterns):
580         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
581         (TestWebKitAPI::countLiveNodes): Deleted.
582         (TestWebKitAPI::createNFAs): Deleted.
583         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
584
585 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
586
587         WebKitTestRunner leaks strings in generateWhitelist()
588         https://bugs.webkit.org/show_bug.cgi?id=145665
589
590         Reviewed by Myles C. Maxfield.
591
592         * WebKitTestRunner/mac/TestControllerMac.mm:
593         (WTR::generateWhitelist):
594
595 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
596
597         Fix options in build-jsc for CMake builds
598         https://bugs.webkit.org/show_bug.cgi?id=145636
599
600         Reviewed by Gyuyoung Kim.
601
602         CMake only accepts -DXXX=YYY style options.
603         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
604
605         * Scripts/build-jsc:
606
607 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
608
609         Added a patch so that the colors displayed on the page could be toggled
610         in case people need accessibility colors displayed in their browser.
611         https://bugs.webkit.org/show_bug.cgi?id=145570
612         <rdar://problem/20994468>
613
614         Added in CSS colors and toggle buttons for checkmarks in the page, so that
615         the page could be rendered in a specific way for accessibility needs if needed.
616
617         Reviewed by Alexey Proskuryakov.
618
619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
620         (updateHiddenPlatforms):
621         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
622         (toggleAccessibilityColors): Toggle colors on and off
623         (documentReady): Needed to make changes to the initialization
624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
625         (a:hover):
626         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
627         (div.cellButton.hide, div.accessibilityButton.hide):
628         (div.cellButton.unhide, div.accessibilityButton.unhide):
629         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
630         (.popover-tracking:hover):
631         (.accessibilityButton):
632         (div.cellButton): Deleted.
633         (div.cellButton.hide): Deleted.
634         (div.cellButton.unhide): Deleted.
635         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
637         (.status-line.neutral .bubble):
638         (.status-line.unauthorized .bubble):
639         (.status-line.danger .bubble.pictogram):
640         (.status-line.bad .bubble.pictogram):
641         (.status-line.no-bubble .message):
642         (.status-line.bad .bubble):
643         (.status-line.good .bubble):
644         (.status-line.good .message):
645         (.status-line.bad .message):
646         (body.accessibility-colors .status-line.good .bubble):
647         (body.accessibility-colors .status-line.bad .bubble):
648         (body.accessibility-colors .status-line.good .message):
649         (body.accessibility-colors .status-line.bad .message):
650         (.status-line.danger .message):
651         (.status-line.unauthorized .message):
652
653 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
654
655         Unreviewed build fix for Dromaeo.
656
657         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
658         (BenchmarkResults._aggregate_results_for_test):
659
660 2015-06-03  Anders Carlsson  <andersca@apple.com>
661
662         Fix build.
663
664         * DumpRenderTree/mac/TestRunnerMac.mm:
665
666 2015-06-03  Daniel Bates  <dabates@apple.com>
667
668         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
669         https://bugs.webkit.org/show_bug.cgi?id=145616
670
671         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
672         of the test. Further investigation is needed.
673
674         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
675         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
676
677 2015-06-03  Brady Eidson  <beidson@apple.com>
678
679         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
680         https://bugs.webkit.org/show_bug.cgi?id=145580
681
682         Reviewed by Mark Lam.
683
684         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
685         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
686
687 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
688
689         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
690
691         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
692         (TestWebKitAPI::TEST): Update the syntax.
693
694 2015-06-02  Mark Lam  <mark.lam@apple.com>
695
696         build-jsc's --cloop option is broken.
697         https://bugs.webkit.org/show_bug.cgi?id=145516
698
699         Reviewed by Darin Adler.
700
701         * Scripts/build-jsc:
702         - Make sure to disable the JIT when --cloop is specified.
703           Did analogous fix for --ftljit.
704
705 2015-06-02  Daniel Bates  <dabates@apple.com>
706
707         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
708
709         Rubber-stamped by Alexey Proskuryakov.
710
711         * MiniBrowser/mac/Info.plist:
712         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
713
714 2015-06-01  Commit Queue  <commit-queue@webkit.org>
715
716         Unreviewed, rolling out r185066.
717         https://bugs.webkit.org/show_bug.cgi?id=145543
718
719         it breaks the FTL JIT builds with a local checkout of llvm
720         (Requested by pizlo on #webkit).
721
722         Reverted changeset:
723
724         "build-jsc's --cloop option is broken."
725         https://bugs.webkit.org/show_bug.cgi?id=145516
726         http://trac.webkit.org/changeset/185066
727
728 2015-06-01  Daniel Bates  <dabates@apple.com>
729
730         Notify client that we began editing when text field is focused
731         https://bugs.webkit.org/show_bug.cgi?id=145439
732         <rdar://problem/21142108>
733
734         Reviewed by Anders Carlsson.
735
736         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
737         a text field is focused and defocused.
738
739         * TestWebKitAPI/CMakeLists.txt:
740         * TestWebKitAPI/PlatformEfl.cmake:
741         * TestWebKitAPI/PlatformGTK.cmake:
742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
743         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
744         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
745         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
746         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
747         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
748         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
749         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
750         (TestWebKitAPI::TEST_F):
751         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
752         (TestWebKitAPI::textFieldDidBeginEditing):
753         (TestWebKitAPI::textFieldDidEndEditing):
754         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
755         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
756         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
757
758 2015-06-01  Alex Christensen  <achristensen@webkit.org>
759
760         [Content Extensions] resource-type and load-type should be independent.
761         https://bugs.webkit.org/show_bug.cgi?id=145528
762         rdar://problem/21190765
763
764         Reviewed by Benjamin Poulain.
765
766         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
767         (TestWebKitAPI::TEST_F):
768
769 2015-06-01  Daniel Bates  <dabates@apple.com>
770
771         Add ATS keys to WebKitTestRunnerApp
772         https://bugs.webkit.org/show_bug.cgi?id=145519
773
774         Reviewed by Alexey Proskuryakov.
775
776         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
777
778         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
779
780 2015-06-01  Brady Eidson  <beidson@apple.com>
781
782         Add WKTR support for "should open external URLs".
783         https://bugs.webkit.org/show_bug.cgi?id=145505
784
785         Reviewed by Darin Adler.
786
787         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
788           "should open external URLs" bit set.
789         
790         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
791           the policy delegate, including whether or not the bit was set.
792         
793         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
794         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
795         (WTR::TestRunner::queueLoad):
796         * WebKitTestRunner/InjectedBundle/TestRunner.h:
797         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
798         (WTR::TestRunner::shouldDumpPolicyCallbacks):
799         
800         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
801         (WTR::InjectedBundle::queueLoad):
802         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
803
804         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
805         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
806
807         * WebKitTestRunner/TestInvocation.cpp:
808         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
809
810         * WebKitTestRunner/WorkQueueManager.cpp:
811         (WTR::WorkQueueManager::queueLoad):
812         * WebKitTestRunner/WorkQueueManager.h:
813
814 2015-06-01  Mark Lam  <mark.lam@apple.com>
815
816         build-jsc's --cloop option is broken.
817         https://bugs.webkit.org/show_bug.cgi?id=145516
818
819         Reviewed by Darin Adler.
820
821         * Scripts/build-jsc:
822         - Make sure to disable the JIT when --cloop is specified.
823           Did analogous fix for --ftljit.
824
825 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
826
827         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
828         https://bugs.webkit.org/show_bug.cgi?id=144959
829
830         Reviewed by Darin Adler.
831
832         * Scripts/webkitpy/style/checkers/cmake.py:
833         (CMakeChecker.check): Use enumerate instead of xrange.
834         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
835         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
836         (CMakeCheckerTest.test_check): Update the expected results.
837
838 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
839
840         Fix the webkitpy scm unittests after r174051
841         https://bugs.webkit.org/show_bug.cgi?id=145511
842
843         Reviewed by Darin Adler.
844
845         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
846         (GitTestWithMock.make_scm):
847
848 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
849
850         EWS provides misleading information for not applyable patches
851         https://bugs.webkit.org/show_bug.cgi?id=145307
852
853         Reviewed by Alexey Proskuryakov.
854
855         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
856
857 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
858
859         Further tweak results of WebKit1.StringTruncator after r184965.
860
861         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
862
863 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
864
865         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
866         https://bugs.webkit.org/show_bug.cgi?id=145264
867
868         Reviewed by Carlos Garcia Campos.
869
870         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
871
872 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
873
874         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
875
876         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
877         (BenchmarkResults._lint_subtest_results):
878         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
879         (test_aggregate_nested_results):
880         (test_lint_results):
881         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
882
883 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
884
885         run-benchmark should print out the results
886         https://bugs.webkit.org/show_bug.cgi?id=145398
887
888         Reviewed by Antti Koivisto.
889
890         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
891         of the output to catch early errors.
892
893         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
894         (BenchmarkResults): Added.
895         (BenchmarkResults.__init__): Added.
896         (BenchmarkResults.format): Added.
897         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
898         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
899         Uses the sample standard deviation to compute the significant figures for the value.
900         (BenchmarkResults._unit_from_metric): Added.
901         (BenchmarkResults._aggregate_results): Added.
902         (BenchmarkResults._aggregate_results_for_test): Added.
903         (BenchmarkResults._flatten_list): Added.
904         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
905         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
906         (BenchmarkResults._aggregate_values): Added.
907         (BenchmarkResults._lint_results): Added.
908         (BenchmarkResults._lint_subtest_results): Added.
909         (BenchmarkResults._lint_aggregator_list): Added.
910         (BenchmarkResults._lint_configuration): Added.
911         (BenchmarkResults._lint_values): Added.
912         (BenchmarkResults._is_numeric): Added.
913         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
914         (BenchmarkResultsTest):
915         (BenchmarkResultsTest.test_init):
916         (BenchmarkResultsTest.test_format):
917         (test_format_values_with_large_error):
918         (test_format_values_with_small_error):
919         (test_format_values_with_time):
920         (test_format_values_with_no_error):
921         (test_format_values_with_small_difference):
922         (test_aggregate_results):
923         (test_aggregate_results_with_gropus):
924         (test_aggregate_nested_results):
925         (test_lint_results):
926         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
927         (BenchmarkRunner.execute): Added a call to show_results
928         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
929         (BenchmarkRunner.show_results): Added.
930
931 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
932
933         run_benchmark should have an option to specify the number of runs
934         https://bugs.webkit.org/show_bug.cgi?id=145091
935
936         Reviewed by Antti Koivisto.
937
938         Added --count option.
939
940         * Scripts/run-benchmark:
941         (main):
942         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
943         (BenchmarkRunner.__init__):
944
945 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
946
947         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
948
949         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
950
951 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
952
953         Update results of WebKit1.StringTruncator after r184965.
954
955         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
956
957 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
958
959         Unreviewed, updated my list of email addresses.
960
961         * Scripts/webkitpy/common/config/contributors.json:
962
963 2015-05-27  Dean Jackson  <dino@apple.com>
964
965         img.currentSrc problem in strict mode with old picturefill
966         https://bugs.webkit.org/show_bug.cgi?id=144095
967         <rdar://problem/21087013>
968
969         Reviewed by Simon Fraser.
970
971         Add a PICTURE_SIZES flag.
972
973         * Scripts/webkitperl/FeatureList.pm:
974
975 2015-05-26  Dana Burkart  <dburkart@apple.com>
976
977         Fixes compatibility issues with recent dashboard cleanup.
978         https://bugs.webkit.org/show_bug.cgi?id=144814
979
980         Reviewed by Alexey Proskuryakov.
981
982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
983         (BuildbotStaticAnalyzerQueueView):
984         (BuildbotStaticAnalyzerQueueView.prototype.update):
985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
986         (documentReady):
987
988 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
989
990         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
991         https://bugs.webkit.org/show_bug.cgi?id=143091
992         rdar://problem/19330328
993
994         Reviewed by Darin Adler and Timothy Hatcher.
995
996         We have many of these, which are hard to fit on the dashboard. Added a view that
997         collapses to a single green bubble when everything is good, and expands when there
998         are failures (or manually).
999
1000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
1001
1002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1003         (Buildbot.prototype.set isAuthenticated):
1004         (Buildbot.prototype._normalizeQueueInfo):
1005         (Buildbot.prototype._normalizeQueuesInfo):
1006         (Buildbot.prototype.updateQueues):
1007         Moved queue info normalization here from BuildbitQueue. The latter is a model class
1008         that shouldn't have to know about presentation, and this lets us leep the knowledge
1009         about combined queues out if it. Later, we can refactor existing code, and move out
1010         all knowledge about headings and such.
1011
1012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1013         Added the new view. It's not quite universal, and doesn't have as helpful popovers
1014         as other views, but we can extend it when/if we use it for more than JSC.
1015
1016         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1017         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
1018
1019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1020         (documentReady): Added support for combined queues. These are currently always ending up
1021         in Other column, but it's easy to customize in the future if we need to.
1022
1023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1024         (WebKitBuildbot): Added JSC queus.
1025
1026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1027         (.combined-queue-popover):
1028         (.combined-queue-popover .revision):
1029         Added styles for the combined view.
1030
1031 2015-05-26  Dan Bernstein  <mitz@apple.com>
1032
1033         Changed a file to use Unix line endings.
1034
1035         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1036
1037 2015-05-26  Dan Bernstein  <mitz@apple.com>
1038
1039         <rdar://problem/21104551> Update build settings
1040
1041         Reviewed by Anders Carlsson.
1042
1043         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1044         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1045         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1046         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1047         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1048         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1049         * asan/asan.xcconfig:
1050
1051 2015-05-26  Anders Carlsson  <andersca@apple.com>
1052
1053         Fix build.
1054
1055         * WebKitTestRunner/mac/EventSenderProxy.mm:
1056         (WTR::EventSenderProxy::mouseForceDown):
1057         (WTR::EventSenderProxy::mouseForceUp):
1058         (WTR::EventSenderProxy::mouseForceChanged):
1059
1060 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
1061
1062         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
1063         https://bugs.webkit.org/show_bug.cgi?id=145342
1064
1065         Reviewed by Darin Adler.
1066
1067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1068         (BuildbotIteration.prototype._parseData):
1069
1070 2015-05-26  Milan Crha  <mcrha@redhat.com>
1071
1072         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
1073         https://bugs.webkit.org/show_bug.cgi?id=138134
1074
1075         Reviewed by Žan Doberšek.
1076
1077         * gtk/generate-inspector-gresource-manifest.py:
1078         (get_filenames): Command line with expanded resources exceeds 32KB, which
1079         is a limit on Windows. It's better to expand wildcards inside the python script.
1080
1081 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1082
1083         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
1084         https://bugs.webkit.org/show_bug.cgi?id=140882
1085
1086         Reviewed by Gustavo Noronha Silva.
1087
1088         Make sure unit tests write IndexedDB databases to the temporary
1089         directory, and add a test case to check that the directory is
1090         correctly created at the expected path.
1091
1092         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1093         (testWebContextConfiguration):
1094         (serverCallback):
1095         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1096         (Test::Test):
1097
1098 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1099
1100         [GTK] Enable IndexedDB
1101         https://bugs.webkit.org/show_bug.cgi?id=98932
1102
1103         Reviewed by Žan Doberšek.
1104
1105         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1106
1107 2015-05-24  Sam Weinig  <sam@webkit.org>
1108
1109         Crash when using a removed ScriptMessageHandler
1110         <rdar://problem/20888499>
1111         https://bugs.webkit.org/show_bug.cgi?id=145359
1112
1113         Reviewed by Dan Bernstein.
1114
1115         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1116         Add tests for removing script message handlers.
1117
1118 2015-05-23  Dan Bernstein  <mitz@apple.com>
1119
1120         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
1121         https://bugs.webkit.org/show_bug.cgi?id=145345
1122
1123         Reviewed by Sam Weinig.
1124
1125         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1126         * LayoutTestRelay/Configurations/Base.xcconfig:
1127         * TestWebKitAPI/Configurations/Base.xcconfig:
1128         * WebKitTestRunner/Configurations/Base.xcconfig:
1129
1130 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1131
1132         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
1133         https://bugs.webkit.org/show_bug.cgi?id=144848
1134
1135         Reviewed by Darin Adler.
1136
1137         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
1138
1139         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1140
1141 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
1142
1143         Fix one more merge error in static analyzer support.
1144
1145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1146         (BuildbotStaticAnalyzerQueueView):
1147
1148 2015-05-22  Dana Burkart  <dburkart@apple.com>
1149
1150         Fix internal dashboard breakage from recent commit.
1151         https://bugs.webkit.org/show_bug.cgi?id=144814
1152
1153         Unreviewed build fix.
1154
1155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1156         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
1157         (BuildbotStaticAnalyzerQueueView.prototype.update):
1158
1159 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
1160
1161         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
1162         https://bugs.webkit.org/show_bug.cgi?id=130463
1163         rdar://problem/20461342
1164
1165         Reviewed by Tim Horton.
1166
1167         This was more of a timing related flakiness than an actual OS version specific bug,
1168         we weren't getting window visibility notifications.
1169         
1170         I will look into adding this function call to DumpRenderTree separately, layout tests
1171         might actually rely on the broken behavior.
1172
1173         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1174         (TestWebKitAPI::TEST_F):
1175         * TestWebKitAPI/mac/mainMac.mm:
1176         (main):
1177
1178 2015-05-22  Dana Burkart  <dburkart@apple.com>
1179
1180         Add missing file from r184804 (mis-applied diff).
1181         https://bugs.webkit.org/show_bug.cgi?id=144814
1182
1183         Reviewed by Alexey Proskuryakov.
1184
1185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
1186         (BuildbotStaticAnalyzerQueueView):
1187         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
1188         (BuildbotStaticAnalyzerQueueView.prototype.update):
1189
1190 2015-05-22  Dana Burkart  <dburkart@apple.com>
1191
1192         Add support to the botwatchers dashboard for a static analyzer bot.
1193         https://bugs.webkit.org/show_bug.cgi?id=144814
1194
1195         Reviewed by Alexey Proskuryakov.
1196
1197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1198         scan-build should be considered a productive step.
1199
1200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1201         (BuildbotQueue):
1202         Adds support for the staticAnalyzer property
1203
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1205         (BuildbotTestResults.prototype._parseResults):
1206         Get bug count from the scan-build step output
1207
1208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1209         (documentReady):
1210         Rename the performance column 'Other', and merge the current 'Other' column with it.
1211
1212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1213         (WebKitBuildbot):
1214         Now that performance bots are part of the 'Other' column, give them better headings.
1215
1216 2015-05-22  Tim Horton  <timothy_horton@apple.com>
1217
1218         Turn on autosaving of toolbar configuration in MiniBrowser
1219
1220         Rubber-stamped by Dan Bernstein.
1221
1222         * MiniBrowser/mac/BrowserWindow.xib:
1223
1224 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
1225
1226         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
1227         https://bugs.webkit.org/show_bug.cgi?id=145297
1228
1229         Reviewed by Tim Horton.
1230
1231         This is a refactoring to simplify code, and to make it more logical.
1232
1233         It is up to the view to decide how to present the queues, and whether to split
1234         them into debug and release, or in some different way.
1235
1236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1237         (BuildbotBuilderQueueView.filterQueues):
1238         (BuildbotBuilderQueueView):
1239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1240         (BuildbotLeaksQueueView):
1241         (BuildbotLeaksQueueView.prototype.update):
1242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
1243         (BuildbotPerformanceQueueView):
1244         (BuildbotPerformanceQueueView.prototype.update):
1245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1246         (BuildbotQueueView):
1247         (BuildbotQueueView.prototype._updateQueues):
1248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1249         (BuildbotTesterQueueView):
1250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1251         (documentReady):
1252
1253 2015-05-22  Tim Horton  <timothy_horton@apple.com>
1254
1255         Remove action menu support
1256         https://bugs.webkit.org/show_bug.cgi?id=145305
1257         <rdar://problem/21070771>
1258
1259         Reviewed by Anders Carlsson.
1260
1261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1262         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
1263         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
1264         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
1265         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
1266         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
1267         Remove the tests.
1268
1269 2015-05-22  Dan Bernstein  <mitz@apple.com>
1270
1271         Removed the Use Shrink To Fit button from the toolbar’s default set.
1272
1273         Rubber-stamped by Tim Horton.
1274
1275         * MiniBrowser/mac/BrowserWindow.xib:
1276
1277 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
1278
1279         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
1280         https://bugs.webkit.org/show_bug.cgi?id=128420
1281
1282         Reviewed by Chris Fleizach.
1283
1284         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1285         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
1286
1287 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
1288
1289         [EFL] Bump libsoup version to 2.50.0
1290         https://bugs.webkit.org/show_bug.cgi?id=145127
1291
1292         Reviewed by Gyuyoung Kim.
1293
1294         * efl/jhbuild.modules:
1295         * efl/patches/soup-clang-warning-fix1.patch: Removed.
1296         * efl/patches/soup-clang-warning-fix2.patch: Removed.
1297
1298 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
1299
1300         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
1301         https://bugs.webkit.org/show_bug.cgi?id=145117
1302
1303         Reviewed by Csaba Osztrogonác.
1304
1305         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
1306         Tools/TestWebKitAPI/Tests/WTF/glib/.
1307
1308         * TestWebKitAPI/PlatformGTK.cmake:
1309         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
1310         (TestWebKitAPI::TEST):
1311
1312 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
1313
1314         [EFL] fix efreet error
1315         https://bugs.webkit.org/show_bug.cgi?id=143670
1316
1317         Reviewed by Gyuyoung Kim.
1318
1319         Fix efreet error by using external variable efreet_cache_update.
1320         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
1321         efreet error for efreet_cache does not occur.
1322
1323         * MiniBrowser/efl/main.c:
1324         (elm_main):
1325
1326 2015-05-20  Michael Saboff  <msaboff@apple.com>
1327
1328         Add option to run_jsc_stress_tests to disable JIT testing
1329         https://bugs.webkit.org/show_bug.cgi?id=145233
1330
1331         Reviewed by Mark Lam.
1332
1333         Added --no-jit option.
1334
1335         * Scripts/run-jsc-stress-tests:
1336
1337 2015-05-20  Alex Christensen  <achristensen@webkit.org>
1338
1339         Use correct String for StringView in WTF API tests
1340         https://bugs.webkit.org/show_bug.cgi?id=145226
1341         rdar://problem/20361786
1342
1343         Reviewed by Benjamin Poulain.
1344
1345         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1346         (TestWebKitAPI::TEST):
1347         Use patternHolder for pattern.
1348
1349 2015-05-20  Alex Christensen  <achristensen@webkit.org>
1350
1351         [Content Extensions] Relax restrictions on triggers that match everything.
1352         https://bugs.webkit.org/show_bug.cgi?id=145069
1353
1354         Reviewed by Benjamin Poulain.
1355
1356         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1357         (TestWebKitAPI::TEST_F):
1358         Update and add tests for new possibilities with .*
1359
1360 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
1361
1362         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
1363         https://bugs.webkit.org/show_bug.cgi?id=144992
1364
1365         Reviewed by Gyuyoung Kim.
1366
1367         * MiniBrowser/efl/main.c:
1368         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
1369         (on_key_down):
1370         (on_fullscreen_enter):
1371         (on_fullscreen_exit):
1372         (window_create):
1373
1374 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1375
1376         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
1377         https://bugs.webkit.org/show_bug.cgi?id=145109
1378
1379         Reviewed by Darin Adler.
1380
1381         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1382         (TestWebKitAPI::TEST):
1383
1384 2015-05-19  Anders Carlsson  <andersca@apple.com>
1385
1386         Add alternate menu items for performing operations on the default data store
1387         https://bugs.webkit.org/show_bug.cgi?id=145184
1388
1389         Reviewed by Sam Weinig.
1390
1391         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
1392         associated with a data store.
1393
1394         * MiniBrowser/mac/AppDelegate.m:
1395         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
1396         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
1397         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
1398         * MiniBrowser/mac/MainMenu.xib:
1399
1400 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1401
1402         Fix tautological-compare warning in AtomicString.cpp
1403         https://bugs.webkit.org/show_bug.cgi?id=145120
1404
1405         Reviewed by Alexey Proskuryakov.
1406
1407         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1408         (TestWebKitAPI::TEST): Removed always true assert.
1409
1410 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
1411
1412         [EFL] Fix unsequenced warning in MiniBrowser's main.c
1413         https://bugs.webkit.org/show_bug.cgi?id=145123
1414
1415         Reviewed by Gyuyoung Kim.
1416
1417         * MiniBrowser/efl/main.c:
1418         (on_key_down):
1419
1420 2015-05-18  Daniel Bates  <dabates@apple.com>
1421
1422         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
1423         when staged non-empty file for commit
1424         https://bugs.webkit.org/show_bug.cgi?id=145082
1425
1426         Reviewed by Darin Adler.
1427
1428         Fixes two issues when running prepare-ChangeLog:
1429             1. The function above a deleted function is reported as changed.
1430             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
1431             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
1432             included in this patch).
1433
1434         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
1435         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
1436         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
1437         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
1438         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
1439         VCSUtil::parseChunkRange() has existing test coverage.
1440
1441         * Scripts/prepare-ChangeLog:
1442         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
1443         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
1444         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
1445         examine files that only have deletions. Currently this works as a side effect of the behavior of
1446         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
1447         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
1448         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
1449         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
1450         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1451         We return (-1, -1) when the change represents a deletion.
1452         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
1453         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1454         We return (-1, -1) when the change represents an addition.
1455         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
1456         unit tests.
1457
1458 2015-05-18  Anders Carlsson  <andersca@apple.com>
1459
1460         Add ATS keys to MiniBrowser
1461         https://bugs.webkit.org/show_bug.cgi?id=145141
1462
1463         Reviewed by Sam Weinig.
1464
1465         * MiniBrowser/mac/Info.plist:
1466
1467 2015-05-17  David Kilzer  <ddkilzer@apple.com>
1468
1469         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
1470         <http://webkit.org/b/145100>
1471
1472         Reviewed by Darin Adler.
1473
1474         * Scripts/bisect-builds:
1475         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
1476         - Switch to using PROMPT_RESPONSE_* constants when testing the
1477           value of $didReproduceBug.
1478         - Add do { } while loops to implement 'retry' mode.
1479         (promptForTest):
1480         - Switch to returning PROMPT_RESPONSE_* constants.
1481         - Add support for 'retry' response.
1482
1483 2015-05-16  Tanay C  <tanay.c@samsung.com>
1484
1485         [EFL][WK2] Minibrowser : Add search icon to search bar
1486         https://bugs.webkit.org/show_bug.cgi?id=139773
1487
1488         Reviewed by Gyuyoung Kim.
1489
1490         * MiniBrowser/efl/main.c: 
1491         (search_icon_show): Added.
1492         (search_box_show): Modified.
1493
1494 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1495
1496         run_benchmark should have an option to specify the number of runs
1497         https://bugs.webkit.org/show_bug.cgi?id=145091
1498
1499         Reviewed by Stephanie Lewis.
1500
1501         Added --count option.
1502
1503         * Scripts/run-benchmark:
1504         (main):
1505         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1506         (BenchmarkRunner.__init__):
1507
1508 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
1509
1510         Temporarily disable failing API test.
1511
1512         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1513         (TestWebKitAPI::TEST):
1514
1515 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
1516
1517         User interruption while running of run-webkit-tests should also generate results.html
1518         https://bugs.webkit.org/show_bug.cgi?id=122154
1519
1520         Reviewed by Csaba Osztrogonác.
1521
1522         Generation of results.html on execution of run-webkit-tests happens only
1523         on completion of entire layout tests run. It should be created even when
1524         the execution has been interrupted - either by user (by pressing Ctrl+C)
1525         or because of other interruptions (like exit-after-n-failures option).
1526
1527         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1528         (LayoutTestRunner.run_tests):
1529         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1530         (Manager.run):
1531         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1532         (TestRunResults.__init__):
1533         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1534         (main):
1535         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1536         (RunTest.test_keyboard_interrupt):
1537         (MainTest.test_exception_handling):
1538
1539 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
1540
1541         [buildbot] Fix the URL of the performance bots
1542         https://bugs.webkit.org/show_bug.cgi?id=145043
1543
1544         Reviewed by Ryosuke Niwa.
1545
1546         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1547
1548 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
1549
1550         Add a layout mode that scales down the view to try to fit the document
1551         https://bugs.webkit.org/show_bug.cgi?id=145022
1552         <rdar://problem/19790341>
1553
1554         Reviewed by Dean Jackson.
1555
1556         * MiniBrowser/mac/BrowserWindow.xib:
1557         * MiniBrowser/mac/BrowserWindowController.h:
1558         * MiniBrowser/mac/WK2BrowserWindowController.m:
1559         (-[WK2BrowserWindowController toggleShrinkToFit:]):
1560         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
1561         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
1562
1563 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
1564
1565         [CMake] Don't read the LOCATION property of targets
1566         https://bugs.webkit.org/show_bug.cgi?id=145018
1567
1568         Reviewed by Martin Robinson.
1569
1570         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
1571         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
1572         be the same at configure-time as it is at generate-time.
1573
1574         * TestWebKitAPI/CMakeLists.txt:
1575
1576 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
1577
1578         Add String literal overloads to equalIgnoringASCIICase()
1579         https://bugs.webkit.org/show_bug.cgi?id=145008
1580
1581         Reviewed by Benjamin Poulain.
1582
1583         Test changes to WTF.
1584
1585         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1586         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
1587         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1588         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1589         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
1590         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1591
1592 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1593
1594         SharedBuffer::createWithContentsOfFile should use map file routines
1595         https://bugs.webkit.org/show_bug.cgi?id=144192
1596
1597         Reviewed by Darin Adler.
1598
1599         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
1600
1601         * TestWebKitAPI/PlatformGTK.cmake:
1602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1603         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
1604         (TestWebKitAPI::FileSystemTest::tempFilePath):
1605         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
1606         (TestWebKitAPI::TEST_F):
1607         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
1608         (TestWebKitAPI::SharedBufferTest::tempFilePath):
1609         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
1610         (TestWebKitAPI::TEST_F):
1611
1612 2015-05-13  Alex Christensen  <achristensen@webkit.org>
1613
1614         [Content Extensions] Test interactions between multiple extensions and multiple domains.
1615         https://bugs.webkit.org/show_bug.cgi?id=144967
1616
1617         Reviewed by Benjamin Poulain.
1618
1619         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1620         Xcode wanted to fix an alphabetization issue.
1621         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1622         (TestWebKitAPI::TEST_F):
1623         Test interactions that worked but were not explicitly tested before.
1624
1625 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1626
1627         Unreviewed build fix.
1628
1629         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
1630
1631         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
1632
1633 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1634
1635         Fix the previous commit, which made both bubbles green.
1636
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1638         (.status-line.good .bubble):
1639         (.status-line.bad .bubble):
1640         (.status-line.good .message):
1641
1642 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
1643
1644         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
1645         https://bugs.webkit.org/show_bug.cgi?id=144929
1646
1647         Reviewed by Eric Carlson.
1648
1649         Tweaked colors as I see fit.
1650
1651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1652         (.status-line.good .bubble):
1653         (.status-line.bad .bubble):
1654
1655 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
1656
1657         [Mac] Share cookie storage between UI process and secondary processes
1658         https://bugs.webkit.org/show_bug.cgi?id=144820
1659         rdar://problem/20572830
1660
1661         Reviewed by Darin Adler.
1662
1663         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1664         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
1665         for testing.
1666
1667 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
1668
1669         Fix internal build configuration issues
1670         https://bugs.webkit.org/show_bug.cgi?id=144762
1671
1672         Reviewed by David Kilzer.
1673
1674         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
1675
1676         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1677         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1678         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1679         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1680         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1681         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1682         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1683         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1684
1685 2015-05-12  David Kilzer  <ddkilzer@apple.com>
1686
1687         Switch to launching iOS Simulator using bundle ID
1688         <rdar://problem/20916096>
1689
1690         This is required to fix the layout tests on internal bots.
1691
1692         * Scripts/webkitdirs.pm:
1693         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
1694         Simulator.  Add FIXME.
1695         (quitIOSSimulator): Add FIXME.
1696         * Scripts/webkitpy/port/ios.py:
1697         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
1698         launch iOS Simulator.  Add FIXME.
1699         (IOSSimulatorPort.check_sys_deps): Add FIXME.
1700
1701 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
1702
1703         Fix run-javascriptcore-tests step on the WinCairo bot
1704         https://bugs.webkit.org/show_bug.cgi?id=144866
1705
1706         Reviewed by Csaba Osztrogonác.
1707
1708         Catch exception when failing to create soft link, so we can fall back to copy.
1709
1710         * Scripts/run-jsc-stress-tests:
1711
1712 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
1713
1714         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
1715         https://bugs.webkit.org/show_bug.cgi?id=116971
1716
1717         Reviewed by Chris Fleizach.
1718
1719         Implement rowAtIndex for ATK.
1720
1721         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1722         (WTR::AccessibilityUIElement::rowAtIndex):
1723
1724 2015-05-11  Dan Bernstein  <mitz@apple.com>
1725
1726         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
1727
1728         Reviewed by Alexey Proskuryakov.
1729
1730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1731         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
1732         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
1733         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
1734
1735 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
1736
1737         Fix internal build configuration issues
1738         https://bugs.webkit.org/show_bug.cgi?id=144762
1739
1740         Reviewed by Darin Adler.
1741
1742         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
1743
1744         * TestWebKitAPI/Configurations/Base.xcconfig:
1745         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1746         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1747         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1748         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1749         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1750         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1751
1752 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
1753
1754         [Win] Move Windows build target to Windows 7 (or newer)
1755         https://bugs.webkit.org/show_bug.cgi?id=144890
1756         <rdar://problem/20707307>
1757
1758         Reviewed by Anders Carlsson.
1759
1760         Update linked SDK and minimal Windows level to be compatible with
1761         Windows 7 or newer.
1762
1763         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1764         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1765         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1766         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1767         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1768         * DumpRenderTree/config.h:
1769         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1770         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1771         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1772         * WinLauncher/stdafx.h:
1773
1774 2015-05-11  Commit Queue  <commit-queue@webkit.org>
1775
1776         Unreviewed, rolling out r184119.
1777         https://bugs.webkit.org/show_bug.cgi?id=144888
1778
1779         broke JSC tests on Apple Windows bots (Requested by kling on
1780         #webkit).
1781
1782         Reverted changeset:
1783
1784         "Fix run-javascriptcore-tests step on the WinCairo bot"
1785         https://bugs.webkit.org/show_bug.cgi?id=144866
1786         http://trac.webkit.org/changeset/184119
1787
1788 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1789
1790         run-benchmark should support Dromaeo
1791         https://bugs.webkit.org/show_bug.cgi?id=144849
1792
1793         Reviewed by Chris Dumez.
1794
1795         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
1796         they can take as much as 15 minutes to run each.
1797
1798         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
1799         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
1800         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
1801         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
1802
1803 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1804
1805         Build fix. jetstream has a local copy, not remote archive.
1806
1807         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1808
1809 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1810
1811         run-benchmark should support SunSpider, Kraken and Octane
1812         https://bugs.webkit.org/show_bug.cgi?id=144840
1813
1814         Reviewed by Darin Adler.
1815
1816         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
1817         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
1818         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
1819         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
1820
1821         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
1822         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
1823
1824         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
1825         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
1826
1827         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
1828         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
1829         now has the ability to run an arbitrary "create script".
1830
1831         * Scripts/run-benchmark:
1832         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
1833         This also overrides the remote archive URL specified in the plan.
1834
1835         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
1836
1837         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
1838         JetStreamBenchmarkBuilder.
1839
1840         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
1841         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
1842         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
1843         _runCreateScript and _applyPatch to clean after themselves.
1844         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
1845         JetStream, SunSpider, Kraken all use this feature.
1846         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
1847         the leaf directory name since the latter is not available when a remote ZIP file is used.
1848         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
1849         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
1850         the benchmark name in the patches.
1851
1852         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
1853
1854         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1855         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
1856         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
1857         the browser opens by planName as the plan file no longer contains that.
1858
1859         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
1860         the top directory of JetStream instead of its parent.
1861         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
1862         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
1863         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
1864         the top directory of JetStream instead of its parent.
1865         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
1866         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
1867         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
1868         done in JetStream.patch.
1869         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
1870         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
1871         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
1872         path from the top directory of JetStream as done in JetStream.patch.
1873         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
1874
1875 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
1876
1877         Fix run-javascriptcore-tests step on the WinCairo bot
1878         https://bugs.webkit.org/show_bug.cgi?id=144866
1879
1880         Reviewed by Darin Adler.
1881
1882         * Scripts/run-jsc-stress-tests:
1883
1884 2015-05-11  Alex Christensen  <achristensen@webkit.org>
1885
1886         [Content Extensions] Support domain-specific rules and exceptions.
1887         https://bugs.webkit.org/show_bug.cgi?id=144833
1888
1889         Reviewed by Darin Adler.
1890
1891         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1892         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1893         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1894         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1895         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
1896         (TestWebKitAPI::mainDocumentRequest):
1897         (TestWebKitAPI::subResourceRequest):
1898         (TestWebKitAPI::TEST_F):
1899         (TestWebKitAPI::checkCompilerError):
1900         Added tests for parsing and functionality of if-domain and unless-domain.
1901
1902 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
1903
1904         run-benchmark should support Chrome Canary and Firefox Nightly
1905         https://bugs.webkit.org/show_bug.cgi?id=144850
1906
1907         Reviewed by Darin Adler.
1908
1909         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
1910
1911         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
1912
1913         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
1914         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
1915         (OSXBrowserDriver):
1916         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
1917         (OSXBrowserDriver.closeBrowsers): Ditto.
1918         (OSXBrowserDriver.launchProcess): Ditto.
1919         (OSXBrowserDriver.terminateProcesses): Ditto.
1920         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1921         (OSXChromeDriver): Removed the unused self.chromePreferences.
1922         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
1923         (OSXChromeDriver.closeBrowsers): Ditto.
1924         (OSXChromeDriver.launchUrl):
1925         (OSXChromeCanaryDriver): Added.
1926         (OSXChromeCanaryDriver.launchUrl):
1927         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
1928         (OSXFirefoxDriver): Added.
1929         (OSXFirefoxDriver.launchUrl):
1930         (OSXFirefoxNightlyDriver): Added.
1931         (OSXFirefoxNightlyDriver.launchUrl):
1932         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1933         (OSXSafariDriver):
1934         (OSXSafariDriver.closeBrowsers):
1935
1936 2015-05-11  Tim Horton  <timothy_horton@apple.com>
1937
1938         Page overlay action context override should indicate the source of the request
1939         https://bugs.webkit.org/show_bug.cgi?id=144832
1940         <rdar://problem/20562594>
1941
1942         Reviewed by Darin Adler.
1943
1944         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1945         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1946
1947 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
1948
1949         [GTK] fast/events/page-visibility-transition-test.html is timing out
1950         https://bugs.webkit.org/show_bug.cgi?id=114789
1951
1952         Reviewed by Darin Adler.
1953
1954         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1955         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
1956         requests visibility changes.
1957
1958 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1959
1960         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
1961         https://bugs.webkit.org/show_bug.cgi?id=144798
1962
1963         Reviewed by Darin Adler.
1964
1965         * efl/install-dependencies:
1966
1967 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
1968
1969         Make arguments of run-benchmark more user friendly
1970         https://bugs.webkit.org/show_bug.cgi?id=144835
1971
1972         Reviewed by Darin Adler.
1973
1974         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
1975         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
1976         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
1977         default values from --platform and --browser as they are required arguments.
1978
1979         * Scripts/run-benchmark:
1980         (main): Made --build-directory optional, and removed default values from --platform and --browser.
1981         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
1982         are not dynamically obtained via BrowserDriverFactory.
1983         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1984         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
1985         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
1986         run any benchmark in that case.
1987         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
1988         the specified file isn't a valid relative or an absolute path.
1989         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1990         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
1991         and browsers.
1992         (BrowserDriverFactory.available_browsers): Ditto.
1993         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1994         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
1995         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
1996         browserBuildPath was None.
1997         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1998         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
1999         so that we can use locally built WebKit to launch Safari.
2000
2001 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
2002
2003         Remove the PICTURE_SIZES build flag
2004         https://bugs.webkit.org/show_bug.cgi?id=144679
2005
2006         Reviewed by Benjamin Poulain.
2007
2008         Removed the PICTURE_SIZES build time flag.
2009
2010         * Scripts/webkitperl/FeatureList.pm:
2011
2012 2015-05-09  David Kilzer  <ddkilzer@apple.com>
2013
2014         Layout tests broke due to unexpected simctl output
2015
2016         * Scripts/webkitpy/xcode/simulator.py:
2017         (Simulator._parse_devices): Handle new Device Pairs header.
2018         * Scripts/webkitpy/xcode/simulator_unittest.py:
2019         (test_device_pairs): Add unit test for Device Pairs header.
2020
2021 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2022
2023         Remove convenience constructors for TextRun
2024         https://bugs.webkit.org/show_bug.cgi?id=144752
2025
2026         Reviewed by Anders Carlsson.
2027
2028         Test the StringView which takes a StringImpl*.
2029
2030         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2031         (StringView8Bit): Testing is8Bit() on StringView
2032
2033 2015-05-07  Sam Weinig  <sam@webkit.org>
2034
2035         [Content Extensions] Add simple tester that takes an extension and compiles it
2036         https://bugs.webkit.org/show_bug.cgi?id=144781
2037
2038         Reviewed by Dan Bates.
2039
2040         * ContentExtensionTester: Added.
2041         * ContentExtensionTester/Configurations: Added.
2042         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
2043         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
2044         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
2045         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
2046         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
2047         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
2048         * ContentExtensionTester/main.m: Added.
2049         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
2050
2051 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
2052
2053         Build fix.
2054
2055         Reviewed by Dan Bernstein.
2056
2057         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2058         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2059         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
2060         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2061         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2062         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2063         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
2064         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2065
2066 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
2067
2068         [GTK] Some tests fail because they do not assume the popup menu captures click events
2069         https://bugs.webkit.org/show_bug.cgi?id=40601
2070
2071         Reviewed by Carlos Garcia Campos.
2072
2073         Popdown all attached menus when moving between tests and between each new
2074         event sent to the WebView. This prevents context and popup menus from eating
2075         events.
2076
2077         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
2078         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
2079         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2080         (WTR::dispatchEvent): Popdown all menus between dispatching events.
2081         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
2082         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
2083         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2084         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
2085         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2086         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
2087         longer in the platform-independent file.
2088         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
2089
2090 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
2091
2092         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
2093         https://bugs.webkit.org/show_bug.cgi?id=144746
2094
2095         Reviewed by Carlos Garcia Campos.
2096
2097         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
2098
2099         * MiniBrowser/gtk/main.c:
2100         (main):
2101
2102 2015-05-08  Commit Queue  <commit-queue@webkit.org>
2103
2104         Unreviewed, rolling out r183996.
2105         https://bugs.webkit.org/show_bug.cgi?id=144806
2106
2107         ASan detected use-after free (Requested by ap on #webkit).
2108
2109         Reverted changeset:
2110
2111         "Remove convenience constructors for TextRun"
2112         https://bugs.webkit.org/show_bug.cgi?id=144752
2113         http://trac.webkit.org/changeset/183996
2114
2115 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2116
2117         Remove convenience constructors for TextRun
2118         https://bugs.webkit.org/show_bug.cgi?id=144752
2119
2120         Reviewed by Anders Carlsson.
2121
2122         Test the StringView which takes a StringImpl*.
2123
2124         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2125         (StringView8Bit): Testing is8Bit() on StringView
2126
2127 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2128
2129         [GTK] WTR doesn't correctly handle the Escape key
2130         https://bugs.webkit.org/show_bug.cgi?id=144788
2131
2132         Reviewed by Martin Robinson.
2133
2134         Correctly handle 0x001B character code in GTK+ event sender to be
2135         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
2136         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
2137         to dismiss popup menus.
2138
2139         Fixes editing/selection/5354455-1.html.
2140
2141         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2142         (WTR::getGDKKeySymForKeyRef):
2143
2144 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2145
2146         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
2147         https://bugs.webkit.org/show_bug.cgi?id=144748
2148
2149         Reviewed by Sergio Villar Senin.
2150
2151         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2152         (testWebKitSettings): Check the new setting is correctly
2153         initialized and updated.
2154         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2155         (testWebContextSecurityFileXHR): Check XHR to local files is
2156         allowed from file URLs after changing the setting.
2157         (beforeAll): Add new test.
2158
2159 2015-05-08  Commit Queue  <commit-queue@webkit.org>
2160
2161         Unreviewed, rolling out r183945.
2162         https://bugs.webkit.org/show_bug.cgi?id=144789
2163
2164         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
2165
2166         Reverted changeset:
2167
2168         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
2169         https://bugs.webkit.org/show_bug.cgi?id=144746
2170         http://trac.webkit.org/changeset/183945
2171
2172 2015-05-07  Anders Carlsson  <andersca@apple.com>
2173
2174         Build fixes.
2175
2176         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
2177         (TestWebKitAPI::TEST):
2178         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
2179         (TestWebKitAPI::TEST):
2180         Add casts.
2181
2182 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
2183
2184         GC has trouble with pathologically large array allocations
2185         https://bugs.webkit.org/show_bug.cgi?id=144609
2186
2187         Reviewed by Geoffrey Garen.
2188         
2189         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
2190         and it's a frequently requested feature.
2191         
2192         Also add the ability to run a test pretending that your system has a particular RAM size.
2193         This is useful for GC tests, and the new GC test that I added uses this.
2194
2195         * Scripts/run-javascriptcore-tests:
2196         (runJSCStressTests):
2197         * Scripts/run-jsc-stress-tests:
2198
2199 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
2200
2201         [EFL] Bump EFL version to 1.14.0
2202         https://bugs.webkit.org/show_bug.cgi?id=144743
2203
2204         Reviewed by Darin Adler.
2205
2206         Bump EFL and elementary version to 1.14.0 and removed
2207         md5sum, because it isn't used at all if hash is present.
2208
2209         * efl/jhbuild.modules:
2210
2211 2015-05-07  Saam Barati  <saambarati1@gmail.com>
2212
2213         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
2214         https://bugs.webkit.org/show_bug.cgi?id=144753
2215
2216         Reviewed by Mark Lam.
2217
2218         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2219
2220 2015-05-07  Beth Dakin  <bdakin@apple.com>
2221
2222         New force-related DOM events should fire in WK1 views
2223         https://bugs.webkit.org/show_bug.cgi?id=144663
2224         -and corresponding-
2225         rdar://problem/20281886
2226
2227         Reviewed by Sam Weinig.
2228
2229         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
2230         now. Just send nil. 
2231         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2232         (TestWebKitAPI::buildAndPerformTest):
2233
2234 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2235
2236         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
2237         https://bugs.webkit.org/show_bug.cgi?id=144746
2238
2239         Reviewed by Martin Robinson.
2240
2241         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
2242
2243         * MiniBrowser/gtk/main.c:
2244         (main):
2245
2246 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
2247
2248         Revert "Introducing the Platform Abstraction Layer (PAL)"
2249         https://bugs.webkit.org/show_bug.cgi?id=144751
2250
2251         Unreviewed.
2252
2253         PAL should be a new target inside WebCore, rather than a top-level folder.
2254
2255         * Scripts/build-webkit: Add it to build-webkit.
2256
2257 2015-05-07  Ada Chan  <adachan@apple.com>
2258
2259         Add a test for WKPageCopySessionState() with filtering.
2260         https://bugs.webkit.org/show_bug.cgi?id=144666
2261
2262         Reviewed by Darin Adler.
2263
2264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2265         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
2266         (TestWebKitAPI::didFinishLoadForFrame):
2267         (TestWebKitAPI::setPageLoaderClient):
2268         (TestWebKitAPI::filterFirstItemCallback):
2269         (TestWebKitAPI::filterAllItemsCallback):
2270         (TestWebKitAPI::createSessionStates):
2271         (TestWebKitAPI::TEST):
2272
2273 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
2274
2275         iOS build fix attempt
2276
2277         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
2278
2279         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2280
2281 2015-05-06  Matt Baker  <mattbaker@apple.com>
2282
2283         Unreviewed, updated my list of email addresses.
2284
2285         * Scripts/webkitpy/common/config/contributors.json:
2286
2287 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
2288
2289         Do not link tools to WebKit2.framework
2290         https://bugs.webkit.org/show_bug.cgi?id=144699
2291
2292         Unreviewed build fix.
2293
2294         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2295         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2296         These linked to WebKit2 in two ways, eliminating the other one.
2297
2298 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
2299
2300         Introducing the Platform Abstraction Layer (PAL)
2301         https://bugs.webkit.org/show_bug.cgi?id=143358
2302
2303         Reviewed by Simon Fraser.
2304
2305         * Scripts/build-webkit: Add it to build-webkit.
2306
2307 2015-05-06  Alex Christensen  <achristensen@webkit.org>
2308
2309         Fix api tests after r183877.
2310
2311         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2312         (TestWebKitAPI::TEST_F):
2313         Generate all DFAs before compiling them.
2314
2315 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
2316
2317         Do not link tools to WebKit2.framework
2318         https://bugs.webkit.org/show_bug.cgi?id=144699
2319
2320         Reviewed by Tim Horton.
2321
2322         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2324         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2325
2326 2015-05-06  Alex Christensen  <achristensen@webkit.org>
2327
2328         [Content Extensions] Test splitting NFAs by max NFA size.
2329         https://bugs.webkit.org/show_bug.cgi?id=144659
2330
2331         Reviewed by Darin Adler.
2332
2333         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2334         (TestWebKitAPI::createNFAs):
2335         (TestWebKitAPI::TEST_F):
2336         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2337         (TestWebKitAPI::createNFAs):
2338
2339 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
2340
2341         Remove the remaining vestiges of SVG feature define
2342         https://bugs.webkit.org/show_bug.cgi?id=144655
2343
2344         Reviewed by Alexey Proskuryakov.
2345
2346         * Scripts/webkitperl/FeatureList.pm:
2347
2348 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
2349
2350         Add a layout mode for computing fixed layout size from a minimum size
2351         https://bugs.webkit.org/show_bug.cgi?id=144610
2352         <rdar://problem/19790341>
2353
2354         Reviewed by Simon Fraser.
2355
2356         * MiniBrowser/mac/BrowserWindow.xib:
2357         * MiniBrowser/mac/BrowserWindowController.h:
2358         * MiniBrowser/mac/WK1BrowserWindowController.m:
2359         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
2360         * MiniBrowser/mac/WK2BrowserWindowController.m:
2361         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
2362         Add a optional toolbar item to toggle a minimum view size of 1024x0.
2363
2364 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2365
2366         [Content Extensions] Release input NSString when finished copying it.
2367         https://bugs.webkit.org/show_bug.cgi?id=144642
2368
2369         Reviewed by Brian Weinstein.
2370
2371         * WebKitTestRunner/mac/TestControllerMac.mm:
2372         (WTR::TestController::platformConfigureViewForTest):
2373         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
2374
2375 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
2376
2377         Unreviewed test fix after r183798.
2378
2379         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2380         (convertToDRTLabel): Mimic behavior of Mac accessibility output
2381         so we can share results.
2382
2383 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2384
2385         [Content Extensions] Use less memory to store the json input.
2386         https://bugs.webkit.org/show_bug.cgi?id=144604
2387
2388         Reviewed by Benjamin Poulain.
2389
2390         * MiniBrowser/mac/ExtensionManagerWindowController.m:
2391         (-[ExtensionManagerWindowController add:]):
2392         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2393         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2394         * WebKitTestRunner/mac/TestControllerMac.mm:
2395         (WTR::TestController::platformConfigureViewForTest):
2396
2397 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2398
2399         Unreviewed. Make myself a WebKit reviewer.
2400
2401         * Scripts/webkitpy/common/config/contributors.json:
2402
2403 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
2404
2405         [GTK] r183783 breaks build
2406         https://bugs.webkit.org/show_bug.cgi?id=144632
2407
2408         Reviewed by Martin Robinson.
2409
2410         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
2411
2412         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2413         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2414
2415 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2416
2417         [Content Extensions] Combine NFAs properly and free memory as we compile.
2418         https://bugs.webkit.org/show_bug.cgi?id=144485
2419
2420         Reviewed by Benjamin Poulain.
2421
2422         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2423         (TestWebKitAPI::TEST_F):
2424         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
2425         Added tests for deep NFAs.
2426
2427 2015-05-04  Alex Christensen  <achristensen@webkit.org>
2428
2429         [Content Extensions] Use less memory when writing byte code to file
2430         https://bugs.webkit.org/show_bug.cgi?id=144602
2431
2432         Reviewed by Darin Adler.
2433
2434         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2435
2436 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2437
2438         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
2439         https://bugs.webkit.org/show_bug.cgi?id=144541
2440
2441         Reviewed by Žan Doberšek.
2442
2443         Add a test case to WorkQueue unit test, to check that sources of
2444         asynchronous IO operations running in the WorkQueue thread are
2445         dispatched by the WorkQueue main loop.
2446
2447         * TestWebKitAPI/PlatformGTK.cmake:
2448         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
2449         (TestWebKitAPI::TEST):
2450
2451 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
2452
2453         Correct '--show-webview' option for Tiled Drawing tests
2454         https://bugs.webkit.org/show_bug.cgi?id=144621
2455
2456         Reviewed by Simon Fraser.
2457
2458         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
2459         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
2460
2461         * WebKitTestRunner/mac/TestControllerMac.mm:
2462         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
2463         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
2464
2465 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
2466
2467         Large array shouldn't be slow
2468         https://bugs.webkit.org/show_bug.cgi?id=144617
2469
2470         Reviewed by Geoffrey Garen.
2471         
2472         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
2473         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
2474         long-running. So, hash-map sort of belongs here.
2475
2476         * Scripts/run-jsc-benchmarks:
2477
2478 2015-05-04  Doug Russell  <d_russell@apple.com>
2479
2480         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
2481         https://bugs.webkit.org/show_bug.cgi?id=144489
2482
2483         Reviewed by Chris Fleizach.
2484
2485         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
2486         on the returned control.
2487         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
2488         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
2489         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
2490         Add support for setSelectedVisibleTextRange() in accessibility tests.
2491
2492         * DumpRenderTree/AccessibilityUIElement.cpp:
2493         (setSelectedVisibleTextRangeCallback):
2494         (AccessibilityUIElement::setSelectedVisibleTextRange):
2495         (AccessibilityUIElement::getJSClass):
2496         (AccessibilityUIElement::textMarkerForIndex): Deleted.
2497         * DumpRenderTree/AccessibilityUIElement.h:
2498         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2499         (AccessibilityUIElement::setSelectedVisibleTextRange):
2500         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2501         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2502         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
2503         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2504         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2505         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2506         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2507         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2508         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2509         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2510         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2511
2512 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
2513
2514         [Win] Implement the "--show-webview" option for Windows
2515         https://bugs.webkit.org/show_bug.cgi?id=144589
2516
2517         Reviewed by Alex Christensen.
2518
2519         Add another runtime flag (--show-webview) that causes DumpRenderTree
2520         to draw its view on-screen, rather than the standard offscreen mode.
2521
2522         * DumpRenderTree/win/DumpRenderTree.cpp:
2523         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
2524         (initializeGlobalsFromCommandLineOptions): Recognize the new
2525         command-line argument, and set the global 'showWebView' state if
2526         appropriate.
2527
2528 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
2529
2530         Remove dead code from TestInvocationCairo.cpp
2531         https://bugs.webkit.org/show_bug.cgi?id=144564
2532
2533         Reviewed by Gyuyoung Kim.
2534
2535         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
2536
2537         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2538         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2539
2540 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
2541
2542         [GTK] Add libnotify in gtk install-dependencies
2543         https://bugs.webkit.org/show_bug.cgi?id=144379
2544
2545         Reviewed by Csaba Osztrogonác.
2546
2547         * gtk/install-dependencies:
2548
2549 2015-05-01  Dan Bernstein  <mitz@apple.com>
2550
2551         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
2552         https://bugs.webkit.org/show_bug.cgi?id=144501
2553
2554         Reviewed by Darin Adler.
2555
2556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2557         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
2558         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
2559         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
2560
2561 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
2562
2563         check-webkit-style fails due to system pylint
2564         https://bugs.webkit.org/show_bug.cgi?id=144360
2565
2566         Reviewed by Darin Adler.
2567
2568         Make sure that the directory containing third party autoinstalled modules
2569         is at the beginning of the search path, to avoid conflicts with other
2570         versions of the same modules installed in the system (e.g. pylint).
2571
2572         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
2573         modules directory to sys.path, instead of appending it.
2574
2575 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
2576
2577         Unreviewed, updated my list of email addresses.
2578
2579         * Scripts/webkitpy/common/config/contributors.json: Updated.
2580
2581 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
2582
2583         USE(...) macro should expect unprefixed variables
2584         https://bugs.webkit.org/show_bug.cgi?id=144454
2585
2586         Reviewed by Daniel Bates.
2587
2588         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
2589         * DumpRenderTree/config.h: Ditto.
2590         * TestWebKitAPI/config.h: Ditto.
2591
2592 2015-05-01  Basile Clement  <basile_clement@apple.com>
2593
2594         Unreviewed. Add myself as a commiter in contributors.json.
2595
2596         * Scripts/webkitpy/common/config/contributors.json:
2597
2598 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
2599
2600         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
2601         https://bugs.webkit.org/show_bug.cgi?id=144487
2602
2603         Reviewed by Ryosuke Niwa.
2604
2605         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2606         (BenchmarkRunner.merge): Fix bug.
2607         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
2608
2609 2015-05-01  Brady Eidson  <beidson@apple.com>
2610
2611         Add API to disable meta refreshes.
2612         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
2613
2614         Reviewed by Alexey Proskuryakov.
2615
2616         * DumpRenderTree/mac/DumpRenderTree.mm:
2617         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
2618
2619 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
2620
2621         Provide a runtime flag to run-webkit-tests that shows the test view
2622         https://bugs.webkit.org/show_bug.cgi?id=144079.
2623
2624         Unreviewed correction to r183651.
2625
2626         * WebKitTestRunner/TestController.cpp:
2627         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
2628         flag is included in the options dictionary passed to the PlatformWebView.
2629
2630 2015-05-01  Antti Koivisto  <antti@apple.com>
2631
2632         Remove network process load serialization code
2633         https://bugs.webkit.org/show_bug.cgi?id=144448
2634
2635         Reviewed by Alexey Proskuryakov.
2636
2637         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2638         (WTR::InjectedBundle::beginTesting):
2639         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2640         (WTR::TestRunner::setSerializeHTTPLoads):
2641         (WTR::TestRunner::dispatchPendingLoadRequests):
2642
2643 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2644
2645         [GTK] Add libhyphen-dev to the build dependencies
2646         https://bugs.webkit.org/show_bug.cgi?id=144452
2647
2648         Reviewed by Martin Robinson.
2649
2650         * gtk/install-dependencies: Added hyphen as Fedora and Arch
2651         dependencies.
2652
2653 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
2654
2655         Provide a runtime flag to run-webkit-tests that shows the test view
2656         https://bugs.webkit.org/show_bug.cgi?id=144079.
2657
2658         Reviewed by Dean Jackson.
2659
2660         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
2661         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
2662         option:
2663         
2664         --additional-drt-flag="--show-webview"
2665
2666         * DumpRenderTree/mac/DumpRenderTree.mm:
2667         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
2668         '--show-webview' flag.
2669         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
2670         * WebKitTestRunner/Options.cpp:
2671         (WTR::Options::Options):
2672         (WTR::handleOptionShowWebView):
2673         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
2674         * WebKitTestRunner/Options.h:
2675         * WebKitTestRunner/TestController.cpp:
2676         (WTR::TestController::TestController):
2677         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
2678         * WebKitTestRunner/TestController.h:
2679         (WTR::TestController::shouldShowWebView):
2680         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2681         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
2682         options dictionary. If it is true, display the web view while running the test.
2683
2684 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
2685
2686         r183355 didn't trigger Mac tests
2687         https://bugs.webkit.org/show_bug.cgi?id=144464
2688
2689         Reviewed by Simon Fraser.
2690
2691         Update badly neglected filters and unit tests.
2692
2693         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2694         (_should_file_trigger_build):
2695         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2696         (ShouldBuildTest):
2697         (ShouldBuildTest.test_should_build):
2698
2699 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2700
2701         [GTK] Add libhyphen-dev to the build dependencies
2702         https://bugs.webkit.org/show_bug.cgi?id=144452
2703
2704         Reviewed by Martin Robinson.
2705
2706         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
2707         build dependencies.
2708
2709 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
2710
2711         [GTK] Testing dictionaries are not installed automatically
2712         https://bugs.webkit.org/show_bug.cgi?id=144460
2713
2714         Reviewed by Carlos Garcia Campos.
2715
2716         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
2717
2718 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
2719
2720         Fix return code issue, check return code of safari process and dump results to log
2721         https://bugs.webkit.org/show_bug.cgi?id=144436
2722
2723         Reviewed by Ryosuke Niwa.
2724
2725         * Scripts/run-benchmark:
2726         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2727         (BenchmarkRunner.dump): Correct typo.
2728         (BenchmarkRunner.wrap): Add results to console.
2729         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
2730         (OSXSafariDriver.prepareEnv):
2731         (OSXSafariDriver.launchUrl):
2732         (OSXSafariDriver.closeBrowsers):
2733
2734 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2735
2736         Should no longer need to worry about very old versions of Xcode
2737         https://bugs.webkit.org/show_bug.cgi?id=144437
2738
2739         Reviewed by Dan Bernstein.
2740
2741         * Scripts/check-for-exit-time-destructors:
2742         * Scripts/check-for-global-initializers:
2743         * Scripts/check-for-weak-vtables-and-externals:
2744
2745 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
2746
2747         REGRESSION(183583): [Mac] make without SDKROOT has issues
2748         https://bugs.webkit.org/show_bug.cgi?id=144431
2749
2750         Reviewed by Dan Bernstein.
2751
2752         * Makefile:
2753         * WebKitTestRunner/Makefile:
2754         Assume an empty SDKROOT means an macosx variant, so only
2755         enable settings if the SDKROOT is not empty and does not
2756         contain "macosx".
2757
2758 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
2759
2760         Expand test infrastructure to support scrolling tests
2761         https://bugs.webkit.org/show_bug.cgi?id=143684
2762         <rdar://problem/20375516>
2763
2764         Reviewed by Simon Fraser.
2765
2766         * DumpRenderTree/mac/DumpRenderTree.mm:
2767         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
2768         reset before the next test run.
2769         * WebKitTestRunner/TestController.cpp:
2770         (WTR::TestController::resetStateToConsistentValues): Ditto."
2771
2772 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2773
2774         Run javascriptcore tests on Windows without cygwin
2775         https://bugs.webkit.org/show_bug.cgi?id=144419
2776
2777         Reviewed by Brent Fulgham.
2778
2779         * Scripts/run-javascriptcore-tests:
2780         (runJSCStressTests):
2781         Just call ruby, not /usr/bin/env ruby.
2782
2783 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
2784
2785         [GTK] Add --enable-shared option to LLVM to build mesa
2786         https://bugs.webkit.org/show_bug.cgi?id=144393
2787
2788         Reviewed by Martin Robinson.
2789
2790         The updated mesa requires the shared LLVM libraries.
2791         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
2792         to LLVM configure script. It will provide shared libraries in addition to static libraries.
2793
2794         * gtk/jhbuild-optional.modules:
2795
2796 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
2797
2798         [GTK] Add support for automatic hyphenation
2799         https://bugs.webkit.org/show_bug.cgi?id=44478
2800
2801         Reviewed by Carlos Garcia Campos.
2802
2803         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
2804         all systems will use the same dictionaries for testing purposes.
2805
2806 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
2807
2808         Failure when building WebKit for appletvsimulator.
2809         https://bugs.webkit.org/show_bug.cgi?id=144356
2810
2811         Reviewed by Alexey Proskuryakov.
2812
2813         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
2814         make TVOS and WatchOS behave correctly.
2815
2816         * Makefile:
2817         * WebKitTestRunner/Makefile:
2818
2819 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2820
2821         Use-after-free when invalidating WKPageForceRepaint callback
2822         https://bugs.webkit.org/show_bug.cgi?id=144401
2823         rdar://problem/20741111
2824
2825         Reviewed by Tim Horton.
2826
2827         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
2828
2829         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
2830         Don't do anything on error, because the context may be a stale pointer now.
2831
2832 2015-04-29  David Kilzer  <ddkilzer@apple.com>
2833
2834         check-webkit-style: Don't complain about returning value from Objective-C method call in header
2835         <http://webkit.org/b/144395>
2836
2837         Reviewed by Andy Estes.
2838
2839         * Scripts/webkitpy/style/checkers/cpp.py:
2840         (check_spacing): Update regex so 'return' is ignored if it
2841         precedes the whitespace and bracket.  Change category name to
2842         'whitespace/brackets'.  Add period to error message.
2843         (CppChecker): Add 'whitespace/brackets' as a category.
2844         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2845         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
2846         'CppChecker.categories' since that's where the list lives now.
2847         (CppStyleTest.test_spacing_before_brackets): Add tests for
2848         'whitespace/brackets' issues and non-issues.
2849
2850 2015-04-29  Alex Christensen  <achristensen@webkit.org>
2851
2852         Fix WinCairo bot.
2853
2854         * Scripts/webkitdirs.pm:
2855         (determinePassedConfiguration):
2856         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
2857
2858 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
2859
2860         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
2861         https://bugs.webkit.org/show_bug.cgi?id=132159
2862
2863         Reviewed by Darin Adler.
2864
2865         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
2866         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
2867
2868         * DumpRenderTree/mac/DumpRenderTree.mm:
2869         (fontWhitelist):
2870         (adjustFonts):
2871         (createWebViewAndOffscreenWindow):
2872         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2873         (WTR::activateFonts):
2874         * WebKitTestRunner/mac/TestControllerMac.mm:
2875         (WTR::allowedFontFamilySet):
2876         (WTR::systemHiddenFontFamilySet):
2877         (WTR::generateWhitelist):
2878         (WTR::TestController::platformInitializeContext):
2879
2880 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
2881
2882         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2883         https://bugs.webkit.org/show_bug.cgi?id=144155
2884
2885         Reviewed by Andreas Kling.
2886
2887         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2888         Make sure that test window is "visible" before each test. While there is no concrete
2889         evidence that this is the problem indeed, the behavior is consistent with what would
2890         happen for an invisible window. Also, WKTR obviously needs to do this to protect
2891         against potential buggy tests that hide the window and don't show it.
2892
2893 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2894
2895         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
2896
2897         Latest changes in the inspector UI made this test fail. We were
2898         relying that the sidebar was always visible and the first 'li'
2899         element of the inspector was the one containing the title. This is
2900         no longer true, so better use document title that is not likely
2901         to change.
2902
2903         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2904         (openRemoteDebuggingSession):
2905
2906 2015-04-29  Andres Gomez  <agomez@igalia.com>
2907
2908         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
2909
2910         * Scripts/webkitpy/common/config/contributors.json:
2911
2912 2015-04-29  Andres Gomez  <agomez@igalia.com>
2913
2914         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
2915
2916         * Scripts/webkitpy/common/config/watchlist:
2917
2918 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
2919
2920         [EFL] Allow to run the tests on the native X display
2921         https://bugs.webkit.org/show_bug.cgi?id=144247
2922
2923         Reviewed by Gyuyoung Kim.
2924
2925         Added the USE_NATIVE_XDISPLAY option for the WTR.
2926         We can select the Xorg driver if environment variable is set up before running the tests.
2927
2928         * Scripts/webkitpy/port/efl.py:
2929         (EflPort._driver_class):
2930
2931 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
2932
2933         [GTK] Add libnotify-dev in gtk install-dependencies
2934         https://bugs.webkit.org/show_bug.cgi?id=144379
2935
2936         Reviewed by Žan Doberšek.
2937
2938         * gtk/install-dependencies:
2939
2940 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
2941
2942         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
2943         https://bugs.webkit.org/show_bug.cgi?id=143001
2944
2945         Reviewed by Gyuyoung Kim.
2946
2947         * WebKitTestRunner/TestController.cpp:
2948         (WTR::shouldUseFixedLayout):
2949
2950 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
2951
2952         Increase stablility of run-benchmark script
2953         https://bugs.webkit.org/show_bug.cgi?id=144361
2954
2955         Reviewed by Ryosuke Niwa.
2956
2957         * Scripts/run-benchmark:
2958         (main):
2959         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
2960         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2961         (GenericBenchmarkBuilder.clean):
2962         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
2963         (BenchmarkRunner.__init__):
2964         (BenchmarkRunner.execute):
2965         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2966         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
2967         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
2968         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
2969         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
2970         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
2971         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
2972         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2973         (HTTPServerDriver.fetchResult):
2974         (HTTPServerDriver):
2975         (HTTPServerDriver.killServer): Add kill server interface.
2976         (HTTPServerDriver.getReturnCode): Add get return code interface.
2977         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
2978         (SimpleHTTPServerDriver.serve):
2979         (SimpleHTTPServerDriver.fetchResult):
2980         (SimpleHTTPServerDriver):
2981         (SimpleHTTPServerDriver.killServer):
2982         (SimpleHTTPServerDriver.getReturnCode):
2983         * Scripts/webkitpy/benchmark_runner/utils.py:
2984         (forceRemove): Provide python version of 'rm -rf'.
2985
2986 2015-04-28  Sam Weinig  <sam@webkit.org>
2987
2988         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
2989         https://bugs.webkit.org/show_bug.cgi?id=144363
2990
2991         Reviewed by Alex Christensen.
2992
2993         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2994         (TestWebKitAPI::createNFAs):
2995         (TestWebKitAPI::TEST_F):
2996         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2997         (TestWebKitAPI::countLiveNodes):
2998         (TestWebKitAPI::createNFAs):
2999         (TestWebKitAPI::buildDFAFromPatterns):
3000         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
3001
3002 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3003
3004         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
3005         https://bugs.webkit.org/show_bug.cgi?id=144304
3006
3007         Reviewed by Geoffrey Garen.
3008
3009         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
3010         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
3011         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
3012
3013 2015-04-28  Commit Queue  <commit-queue@webkit.org>
3014
3015         Unreviewed, rolling out r183514.
3016         https://bugs.webkit.org/show_bug.cgi?id=144359
3017
3018         It broke cloop test bots (Requested by mcatanzaro on #webkit).
3019
3020         Reverted changeset:
3021
3022         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
3023         https://bugs.webkit.org/show_bug.cgi?id=144304
3024         http://trac.webkit.org/changeset/183514
3025
3026 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3027
3028         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
3029         https://bugs.webkit.org/show_bug.cgi?id=144304
3030
3031         Reviewed by Geoffrey Garen.
3032
3033         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
3034         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
3035         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
3036         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
3037
3038 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3039
3040         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
3041         https://bugs.webkit.org/show_bug.cgi?id=144319
3042
3043         Reviewed by Csaba Osztrogonác.
3044
3045         * TestWebKitAPI/CMakeLists.txt:
3046         * TestWebKitAPI/PlatformEfl.cmake:
3047
3048 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
3049
3050         Fix common typo "targetting" => "targeting"
3051         https://bugs.webkit.org/show_bug.cgi?id=144349
3052
3053         Reviewed by Daniel Bates.
3054
3055         * Scripts/webkitdirs.pm:
3056         (execMacWebKitAppForDebugging):
3057
3058 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3059
3060         [GTK][jhbuild] Mesa build failure with llvm 3.6
3061         https://bugs.webkit.org/show_bug.cgi?id=144250
3062
3063         Reviewed by Žan Doberšek.
3064
3065         Bump the version of Mesa to 10.5.4
3066
3067         * gtk/jhbuild.modules:
3068
3069 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
3070
3071         Disable App Nap in WebKitTestRunner UI process
3072         https://bugs.webkit.org/show_bug.cgi?id=144308
3073
3074         Reviewed by Daniel Bates.
3075
3076         * WebKitTestRunner/mac/main.mm:
3077         (disableAppNapInUIProcess):
3078         (main):
3079
3080 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3081
3082         [GTK] Update JHBuild Mesa download directory
3083         https://bugs.webkit.org/show_bug.cgi?id=144318
3084
3085         Update the download directory of Mesa module since the previous one
3086         doesn't exist any more.
3087
3088         Reviewed by Žan Doberšek.
3089
3090         * gtk/jhbuild.modules:
3091
3092 2015-04-28  Commit Queue  <commit-queue@webkit.org>
3093
3094         Unreviewed, rolling out r183477.
3095         https://bugs.webkit.org/show_bug.cgi?id=144334
3096
3097         Roll back the Mesa dependency bump in fear of uncaught
3098         regressions while the testing bots are no-op. (Requested by
3099         zdobersek on #webkit).
3100
3101         Reverted changeset:
3102
3103         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
3104         https://bugs.webkit.org/show_bug.cgi?id=144250
3105         http://trac.webkit.org/changeset/183477
3106
3107 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3108
3109         [GTK][jhbuild] Mesa build failure with llvm 3.6
3110         https://bugs.webkit.org/show_bug.cgi?id=144250
3111
3112         Reviewed by Žan Doberšek.
3113
3114         Bump the version of Mesa to 10.5.4
3115
3116         * gtk/jhbuild.modules:
3117
3118 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
3119
3120         Add '__init__.py' and fix known bug in benchmark runner.
3121         https://bugs.webkit.org/show_bug.cgi?id=144296
3122
3123         Reviewed by Ryosuke Niwa
3124
3125         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
3126         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
3127         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3128         (BenchmarkRunner.__init__):
3129         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
3130         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
3131         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
3132
3133 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3134
3135         More build fix.
3136
3137         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3138         (-[AccessibilityNotificationHandler _notificationReceived:]):
3139         Use -objectForKey:, not array subscript.
3140
3141 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3142
3143         Catch unexpected exits in DumpRenderTree
3144         https://bugs.webkit.org/show_bug.cgi?id=144288
3145
3146         Reviewed by Tim Horton.
3147
3148         * DumpRenderTree/mac/DumpRenderTree.mm:
3149         (atexitFunction):
3150         (DumpRenderTreeMain):
3151
3152 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3153
3154         Build fix
3155
3156         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3157         (-[AccessibilityNotificationHandler _notificationReceived:]):
3158         Use -objectForKey:, not array subscript.
3159
3160 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3161
3162         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
3163         https://bugs.webkit.org/show_bug.cgi?id=144155
3164
3165         Reviewed by Tim Horton.
3166
3167         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
3168         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
3169         and we clearly don't want App Nap while testing.
3170
3171 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
3172
3173         [CMake] Autogenerate cmakeconfig.h.cmake
3174         https://bugs.webkit.org/show_bug.cgi?id=143997
3175
3176         Reviewed by Csaba Osztrogonác.
3177
3178         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
3179         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
3180
3181 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
3182
3183         REGRESSION(r182879): Images and video can no longer be downloaded
3184         https://bugs.webkit.org/show_bug.cgi?id=144267
3185         <rdar://problem/20702844>
3186
3187         Reviewed by Simon Fraser.
3188
3189         Revise tests to check for proper download menu state.
3190         1. Downloading a loal image should be disabled.
3191         2. Downloading a local media file should be disabled.
3192         3. Downloading non-downloadable media should be disabled.
3193
3194         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3195         (TestWebKitAPI::TEST):
3196
3197 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
3198
3199         Merge run-launcher into run-minibrowser
3200         https://bugs.webkit.org/show_bug.cgi?id=141928
3201
3202         Reviewed by Darin Adler.
3203
3204         * Scripts/run-iexploder-tests:
3205         (runSafariWithIExploder):
3206         * Scripts/run-launcher: Removed.
3207         * Scripts/run-minibrowser:
3208         * Scripts/webkitdirs.pm:
3209         (launcherPath):
3210         * Scripts/webkitpy/port/efl.py:
3211         (EflPort.show_results_html_file):
3212         * Scripts/webkitpy/port/efl_unittest.py:
3213         (EflPortTest.test_show_results_html_file):
3214         * Scripts/webkitpy/port/gtk.py:
3215         (GtkPort.print_leaks_summary):
3216         (GtkPort.show_results_html_file):
3217         (GtkPort): Deleted.
3218         * Scripts/webkitpy/port/gtk_unittest.py:
3219         (GtkPortTest.test_show_results_html_file):
3220
3221 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
3222
3223         [buildbot] Fix the output of perf-test buildstep on timeout
3224         https://bugs.webkit.org/show_bug.cgi?id=144097
3225
3226         Reviewed by Ryosuke Niwa.
3227
3228         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3229         (RunAndUploadPerfTests.getText2):
3230         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3231         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
3232         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
3233
3234 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
3235
3236         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
3237         https://bugs.webkit.org/show_bug.cgi?id=143874
3238
3239         Reviewed by Gyuyoung Kim.
3240
3241         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
3242
3243 2015-04-24  Philippe Normand  <pnormand@igalia.com>
3244
3245         [JHBuild] Move to upstream OpenWebRTC
3246         https://bugs.webkit.org/show_bug.cgi?id=144145
3247
3248         Reviewed by Carlos Garcia Campos.
3249
3250         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
3251         and add a new simple patch to gst-plugins-base, required for
3252         OpenWebRTC build.
3253         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
3254         * gtk/jhbuild.modules: Ditto.
3255         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
3256
3257 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3258
3259         [ES6] Implement ES6 template literals
3260         https://bugs.webkit.org/show_bug.cgi?id=142691
3261
3262         Reviewed by Darin Adler.
3263
3264         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
3265
3266         * Scripts/webkitperl/FeatureList.pm:
3267
3268 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3269
3270         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
3271         https://bugs.webkit.org/show_bug.cgi?id=144217
3272
3273         Reviewed by Darin Adler.
3274
3275         * WebKitTestRunner/PlatformEfl.cmake:
3276
3277 2015-04-26  Doug Russell  <d_russell@apple.com>
3278
3279         AX: richer text change notifications (142719)
3280         https://bugs.webkit.org/show_bug.cgi?id=142719
3281
3282         Reviewed by Darin Adler.
3283
3284         Richer accessibility value change notifications. Introduce AXTextEditType,
3285         postTextStateChangeNotification and postTextReplacementNotification to give assistive
3286         tech apps more reliable context for responding to changes in web content. Also implement
3287         a mechanism to post value changes in password form fields in coalesced ticks to thwart
3288         analyzing the cadence of changes.
3289
3290         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
3291         and an overload of postTextReplacementNotification to give assistive tech apps more
3292         reliable context for responding to changes in web content selection. Also block posting
3293         selection changes on password fields.
3294
3295         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
3296         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3297         (-[AccessibilityNotificationHandler stopObserving]):
3298         (-[AccessibilityNotificationHandler _notificationReceived:]):
3299         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3300         (AccessibilityUIElement::removeNotificationListener):
3301         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3302         (-[AccessibilityNotificationHandler _notificationReceived:]):
3303         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3304         (WTR::AccessibilityUIElement::removeNotificationListener):
3305
3306 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
3307
3308         Add myself to contributors.json
3309         https://bugs.webkit.org/show_bug.cgi?id=144204
3310
3311         Reviewed by Darin Adler.
3312
3313         * Scripts/webkitpy/common/config/contributors.json:
3314
3315 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
3316
3317         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
3318         https://bugs.webkit.org/show_bug.cgi?id=144182
3319
3320         Reviewed by Simon Fraser.
3321
3322         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
3323
3324 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
3325
3326         https://bugs.webkit.org/show_bug.cgi?id=144038
3327
3328         Reviewed by Ryosuke Niwa
3329
3330         Add a script to run Speedometer and JetStream on a browser.
3331
3332         * Scripts/run-benchmark: Wrapper script to run benchmark.
3333         (main):
3334         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
3335         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
3336         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
3337         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
3338         (BenchmarkBuilderFactory):
3339         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
3340         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
3341         (GenericBenchmarkBuilder):
3342         (GenericBenchmarkBuilder.prepare):
3343         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
3344         (GenericBenchmarkBuilder._applyPatch):
3345         (GenericBenchmarkBuilder.clean):
3346         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
3347         (JetStreamBenchmarkBuilder):
3348         (JetStreamBenchmarkBuilder.prepare):
3349         (JetStreamBenchmarkBuilder._runCreateScript):
3350         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
3351         (BenchmarkRunner):
3352         (BenchmarkRunner.__init__):
3353         (BenchmarkRunner.execute):
3354         (BenchmarkRunner.dump):
3355         (BenchmarkRunner.wrap):
3356         (BenchmarkRunner.merge):
3357         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
3358         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
3359         (BrowserDriver):
3360         (BrowserDriver.prepareEnv):
3361         (BrowserDriver.launchUrl):
3362         (BrowserDriver.closeBrowser):
3363         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
3364         (BrowserDriverFactory):
3365         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
3366         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
3367         (OSXChromeDriver):
3368         (OSXChromeDriver.prepareEnv):
3369         (OSXChromeDriver.launchUrl):
3370         (OSXChromeDriver.closeBrowsers):
3371         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
3372         (OSXSafariDriver):
3373         (OSXSafariDriver.prepareEnv):
3374         (OSXSafariDriver.launchUrl):
3375         (OSXSafariDriver.closeBrowsers):
3376         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
3377         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
3378         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
3379         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
3380         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
3381         (GenericFactory):
3382         (GenericFactory.iterateGetItem):
3383         (GenericFactory.create):
3384         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
3385         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
3386         (ServerControl):
3387         (ServerControl.render_GET):
3388         (ServerControl.render_POST):
3389         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
3390         (HTTPServerDriver):
3391         (HTTPServerDriver.serve):
3392         (HTTPServerDriver.fetchResult):
3393         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
3394         (HTTPServerDriverFactory):
3395         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
3396         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
3397         (SimpleHTTPServerDriver):
3398         (SimpleHTTPServerDriver.depends):
3399         (SimpleHTTPServerDriver.__init__):
3400         (SimpleHTTPServerDriver.serve):
3401         (SimpleHTTPServerDriver.baseUrl):
3402         (SimpleHTTPServerDriver.fetchResult):
3403         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
3404         (ModuleNotFoundError):
3405         (loadModule):
3406         (getPathFromProjectRoot):
3407         (loadJSONFromFile):
3408         (TimeoutError):
3409         (timeout):
3410         (timeout.__init__):
3411         (timeout.handle_timeout):
3412         (timeout.__enter__):
3413         (timeout.__exit__):
3414
3415 2015-04-24  Commit Queue  <commit-queue@webkit.org>
3416
3417         Unreviewed, rolling out r183303.
3418         https://bugs.webkit.org/show_bug.cgi?id=144181
3419
3420         Change was incorrect, broke builds (Requested by smfr on
3421         #webkit).
3422
3423         Reverted changeset:
3424
3425         "Fix the build."
3426         http://trac.webkit.org/changeset/183303
3427
3428 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
3429
3430         Fix the build.
3431
3432         * MiniBrowser/mac/WK2BrowserWindowController.m:
3433         (-[WK2BrowserWindowController initWithConfiguration:]):
3434
3435 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3436
3437         Disable ActionMenusPDFTest due to timeout on test bot
3438
3439         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3440         (TestWebKitAPI::TEST):
3441
3442 2015-04-24  Commit Queue  <commit-queue@webkit.org>
3443
3444         Unreviewed, rolling out r183266.
3445         https://bugs.webkit.org/show_bug.cgi?id=144164
3446
3447         Broke 32-bit build and a test. (Requested by ap on #webkit).
3448
3449         Reverted changeset:
3450
3451         "AX: richer text change notifications (142719)"
3452         https://bugs.webkit.org/show_bug.cgi?id=142719
3453         http://trac.webkit.org/changeset/183266
3454
3455 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3456
3457         REGRESSION: WebKit2.ActionMenusTest API test fails
3458         https://bugs.webkit.org/show_bug.cgi?id=144149
3459         <rdar://problem/20677770>
3460
3461         Reviewed by Tim Horton.
3462
3463         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
3464         as the 'ActionMenusPDFTest'.
3465         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3466         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
3467         to match the hit test on the 'action-menu-target.pdf' test file.
3468
3469 2015-04-24  Daniel Bates  <dabates@apple.com>
3470
3471         Cleanup: Use @memoized for property IOSSimulator.testing_device
3472         https://bugs.webkit.org/show_bug.cgi?id=141715
3473
3474         Reviewed by Darin Adler.
3475
3476         Simplify the caching of the result of IOSSimulator.testing_device
3477         and make the code more readable by making use of the @memoized declarator
3478         instead of explicitly managing a private instance variable,
3479         IOSSimulator._testing_device, for the cached result.
3480
3481         * Scripts/webkitpy/port/ios.py:
3482         (IOSPort.determine_full_port_name):
3483         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
3484         (IOSSimulatorPort):
3485         (IOSSimulatorPort.testing_device): No need to cache the created device object in
3486         IOSSimulatorPort._testing_device since we are marking this function @memoized.
3487         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
3488         of caching in local variable since we only make use of this value exactly once in this function.
3489         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
3490         been used since being added in r178622. So, we can remove this constructor since
3491         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
3492
3493 2015-04-24  Anders Carlsson  <andersca@apple.com>
3494
3495         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
3496         https://bugs.webkit.org/show_bug.cgi?id=144158
3497
3498         Reviewed by Beth Dakin.
3499
3500         * MiniBrowser/mac/WK2BrowserWindowController.m:
3501         (-[WK2BrowserWindowController initWithConfiguration:]):
3502
3503 2015-04-24  Doug Russell  <d_russell@apple.com>
3504
3505         AX: richer text change notifications (142719)
3506         https://bugs.webkit.org/show_bug.cgi?id=142719
3507
3508         Reviewed by Darin Adler.
3509
3510         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
3511
3512         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
3513
3514         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
3515         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3516         (-[AccessibilityNotificationHandler stopObserving]):
3517         (-[AccessibilityNotificationHandler _notificationReceived:]):
3518         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3519         (AccessibilityUIElement::removeNotificationListener):
3520         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3521         (-[AccessibilityNotificationHandler _notificationReceived:]):
3522         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3523         (WTR::AccessibilityUIElement::removeNotificationListener):
3524
3525 2015-04-24  Darin Adler  <darin@apple.com>
3526
3527         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
3528         https://bugs.webkit.org/show_bug.cgi?id=128007
3529
3530         Reviewed by Anders Carlsson.
3531
3532         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
3533         * DumpRenderTree/win/UIDelegate.h: Ditto.
3534
3535         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
3536         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
3537
3538         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
3539
3540         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
3541         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
3542         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
3543         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
3544         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3545         (WebKitDOMDOMWindowTest::create): Ditto.
3546         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3547         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
3548         of smart pointers to DelayedSIgnal objects.
3549         (uriChangedCallback): Ditto.
3550
3551 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3552
3553         [Mac] Unreviewed test fix.
3554         https://bugs.webkit.org/show_bug.cgi?id=144149
3555
3556         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3557         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
3558         test.
3559
3560 2015-04-23  Darin Adler  <darin@apple.com>
3561
3562         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
3563         https://bugs.webkit.org/show_bug.cgi?id=144090
3564
3565         Reviewed by Anders Carlsson.
3566
3567         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
3568
3569 2015-04-23  Michael Saboff  <msaboff@apple.com>
3570
3571         lldb macro btjs sometimes can't get a frame description
3572         https://bugs.webkit.org/show_bug.cgi?id=144130
3573
3574         Reviewed by Filip Pizlo.
3575
3576         We look to execute ExecState::describeFrame().  It appears that in some contexts the
3577         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
3578         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
3579
3580         * lldb/lldb_webkit.py:
3581         (btjs):
3582
3583 2015-04-23  Alex Christensen  <achristensen@webkit.org>
3584
3585         Use less memory when compiling content extensions.
3586         https://bugs.webkit.org/show_bug.cgi?id=144051
3587
3588         Reviewed by Darin Adler and Benjamin Poulain.
3589
3590         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3591         (TestWebKitAPI::TEST_F):
3592         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3593         (TestWebKitAPI::countLiveNodes):
3594
3595 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3596
3597         [CMake] Clean up JSC JIT options
3598         https://bugs.webkit.org/show_bug.cgi?id=143998
3599
3600         Reviewed by Filip Pizlo.
3601
3602         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
3603         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
3604
3605 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
3606
3607         [Mac] Extend action menus to support PDF
3608         https://bugs.webkit.org/show_bug.cgi?id=143895
3609         <rdar://problem/19003333>
3610
3611         Reviewed by Tim Horton.
3612
3613         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
3614         of PDF content works.
3615
3616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
3617         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
3618         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
3619         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3620         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
3621         Update to support PDF tests.
3622         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
3623         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
3624
3625 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3626
3627         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
3628
3629         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3630         (beforeAll):
3631         (testWebViewAudioOnlyUserMediaPermissionRequests):
3632
3633 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3634
3635         Add myself to watchlist
3636         https://bugs.webkit.org/show_bug.cgi?id=144041
3637
3638         Reviewed by Alex Christensen.
3639
3640         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
3641
3642         * Scripts/webkitpy/common/config/watchlist:
3643
3644 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3645
3646         [GTK] MiniBrowser should use NetworkProcess by default
3647         https://bugs.webkit.org/show_bug.cgi?id=143948
3648
3649         Reviewed by Sergio Villar Senin.
3650
3651         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
3652         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
3653
3654         * MiniBrowser/gtk/main.c:
3655         (main):
3656
3657 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
3658
3659         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
3660
3661         Unreviewed build fix.
3662
3663         * Scripts/prepare-ChangeLog:
3664         (get_function_line_ranges_for_cpp):
3665         Use grep instead of any to determine if a string is an element of an array.
3666
3667 2015-04-21  Anders Carlsson  <andersca@apple.com>
3668
3669         Fix block signat