[JSCOnly] Add a MIPS32el JSCOnly EWS
[WebKit-https.git] / Tools / ChangeLog
1 2018-06-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         [JSCOnly] Add a MIPS32el JSCOnly EWS
4         https://bugs.webkit.org/show_bug.cgi?id=186523
5
6         Reviewed by Michael Catanzaro.
7
8         Add a new jsc-mips-ews queue that will execute build-jsc for the jsc-only (Linux) port.
9         The worker(s) on this queue should be pre-configured to cross-build JSC for MIPS32el.
10
11         * QueueStatusServer/config/queues.py:
12         * QueueStatusServer/model/queues.py:
13         (Queue.display_name):
14         * Scripts/webkitpy/common/config/ews.json:
15         * Scripts/webkitpy/common/config/ports.py:
16         (DeprecatedPort.port):
17         (WpePort.run_webkit_tests_command):
18         (JscOnlyPort):
19         (JscOnlyPort.build_jsc_command):
20         * Scripts/webkitpy/common/config/ports_unittest.py:
21         (DeprecatedPortTest.test_wincairo_port):
22         (DeprecatedPortTest):
23         (DeprecatedPortTest.test_jsconly_port):
24         * Scripts/webkitpy/port/factory.py:
25         (PortFactory):
26         * Scripts/webkitpy/port/jsc_only.py: Added. Add a basic port definition. Required by the EWS tooling.
27         (JscOnlyPort):
28         (JscOnlyPort.__init__):
29         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
30         (test_ews_name):
31
32 2018-06-12  Zan Dobersek  <zdobersek@igalia.com>
33
34         Add run-web-platform-tests script
35         https://bugs.webkit.org/show_bug.cgi?id=183356
36
37         Reviewed by Carlos Alberto Lopez Perez.
38
39         Add the run-web-platform-tests script that allows running WebKit builds
40         against the external web-platform-tests project.
41
42         The script sets up all the port-specific information, including the
43         display driver. If no web-platform-tests repository location is
44         specified, the TestDownloader utility is used to clone the repository,
45         and path to that clone is leveraged instead.
46
47         Port-specific TestManifest.ini and TestExpectations.json file paths are
48         then constructed, bailing if any of the files is missing. The JSON file
49         is then used to construct the metadata file tree, creating an .ini file
50         for each test that is disabled, has a certain expectation, or has
51         subtests that themselves have certain expectations. This metadata tree
52         is built under the build directory, and is purged and reconstructed for
53         each separate run.
54
55         Lastly, the WPT python module is imported from the web-platform-tests
56         source location, and wpt.main() is invoked along with all the necessary
57         arguments that set up a web-platform-tests suite run using the WebKit
58         product.
59
60         * Scripts/run-web-platform-tests: Added.
61         * Scripts/webkitpy/common/config/ports_mock.py:
62         (MockPort.run_bindings_tests_command):
63         (MockPort):
64         (MockPort.wpt_metadata_directory):
65         (MockPort.wpt_manifest_file):
66         * Scripts/webkitpy/port/base.py:
67         (Port.wpt_metadata_directory):
68         (Port):
69         (Port.wpt_manifest_file):
70         * Scripts/webkitpy/w3c/common.py:
71         (is_file_exportable):
72         (WPTPaths):
73         (WPTPaths.checkout_directory):
74         (WPTPaths.wpt_checkout_path):
75         * Scripts/webkitpy/w3c/test_downloader.py:
76         (TestDownloader.clone_tests):
77         (TestDownloader):
78         (TestDownloader.download_tests):
79         * Scripts/webkitpy/w3c/test_exporter.py:
80         (WebPlatformTestExporter.__init__):
81         * Scripts/webkitpy/w3c/wpt_runner.py: Added.
82         (main):
83         (parse_args):
84         (create_webdriver):
85         (spawn_wpt):
86         (WPTRunner):
87         (WPTRunner.__init__):
88         (WPTRunner._prepare_wpt_checkout):
89         (WPTRunner._generate_metadata_directory):
90         (WPTRunner.run):
91         * Scripts/webkitpy/w3c/wpt_runner_unittest.py: Added.
92         (WPTRunnerTest):
93         (WPTRunnerTest.MockTestDownloader):
94         (WPTRunnerTest.MockTestDownloader.default_options):
95         (WPTRunnerTest.MockTestDownloader.__init__):
96         (WPTRunnerTest.MockTestDownloader.clone_tests):
97         (WPTRunnerTest.MockWebDriver):
98         (WPTRunnerTest.MockWebDriver.create):
99         (WPTRunnerTest.MockWebDriver.binary_path):
100         (WPTRunnerTest.MockWebDriver.browser_path):
101         (WPTRunnerTest.MockWebDriver.browser_args):
102         (WPTRunnerTest.MockSpawnWPT):
103         (WPTRunnerTest.MockSpawnWPT.__init__):
104         (WPTRunnerTest.MockSpawnWPT.__call__):
105         (WPTRunnerTest.TestInstance):
106         (WPTRunnerTest.TestInstance.__init__):
107         (WPTRunnerTest.TestInstance.prepare_mock_files_for_run):
108         (WPTRunnerTest.test_prepare_wpt_checkout):
109         (WPTRunnerTest.test_prepare_wpt_checkout_specified_path):
110         (WPTRunnerTest.test_generate_metadata_directory):
111         (WPTRunnerTest.test_run):
112         (WPTRunnerTest.test_run_with_specified_options):
113         (WPTRunnerTest.test_run_with_args):
114
115 2018-06-11  Mark Lam  <mark.lam@apple.com>
116
117         Add support for webkit-test-runner jscOptions in DumpRenderTree and WebKitTestRunner.
118         https://bugs.webkit.org/show_bug.cgi?id=186451
119         <rdar://problem/40875792>
120
121         Reviewed by Tim Horton.
122
123         This jscOptions option can be used by a layout test to specify some JSC runtime
124         options needed by the test e.g. by adding something like this to the top of the
125         html file after the DOCTYPE tag:
126             <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true ] -->
127
128         If more than one option is needed, the options can be specified as a comma
129         separated string e.g.
130             <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true,--useZombieMode=true ] -->
131
132         This only works with JSC options that can be changed at runtime.  Not all JSC
133         options can be changed this way as some options are only checked and set once at
134         VM / process initialization time: changing this type of options may have no
135         effect.  It's the test writer's responsibility to determine which options are
136         appropriate for with this webkit-test-runner jscOptions option.
137
138         This implementation is a workaround until we can change the run-webkit-tests
139         scripts to parse the option and apply it to a new launch of DRT or WKTR:
140         https://bugs.webkit.org/show_bug.cgi?id=186452
141
142         * DumpRenderTree/TestOptions.cpp:
143         (TestOptions::TestOptions):
144         (TestOptions::webViewIsCompatibleWithOptions const):
145         * DumpRenderTree/TestOptions.h:
146         * DumpRenderTree/mac/DumpRenderTree.mm:
147         (setJSCOptions):
148         (resetWebViewToConsistentStateBeforeTesting):
149         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
150         (WTR::InjectedBundle::didReceiveMessageToPage):
151         * WebKitTestRunner/TestController.cpp:
152         (WTR::TestController::resetStateToConsistentValues):
153         (WTR::updateTestOptionsFromTestHeader):
154         * WebKitTestRunner/TestOptions.h:
155         (WTR::TestOptions::hasSameInitializationOptions const):
156
157 2018-06-11  Brady Eidson  <beidson@apple.com>
158
159         Add a command line default to force WebKitTestRunner to turn on process swap on navigation.
160         https://bugs.webkit.org/show_bug.cgi?id=186534
161
162         Reviewed by Chris Dumez.
163
164         Right now Process Swap On Navigation is enabled on a per-test basis.
165         The future is to enable it by default.
166
167         Adding a 'defaults write' helps us get to that future.
168
169         * WebKitTestRunner/TestController.cpp:
170         (WTR::TestController::testOptionsForTest const):
171         (WTR::TestController::platformAddTestOptions const):
172         * WebKitTestRunner/TestController.h:
173         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
174         (WTR::TestController::platformAddTestOptions const):
175
176 2018-06-11  Chris Dumez  <cdumez@apple.com>
177
178         Allow enabling PSON in layout tests without window.open support
179         https://bugs.webkit.org/show_bug.cgi?id=186537
180
181         Reviewed by Geoffrey Garen.
182
183         Allow enabling PSON in layout tests without window.open support since window.open support
184         is far from being ready and we plan to enable PSON in layout tests soon.
185
186         * WebKitTestRunner/TestController.cpp:
187         (WTR::TestController::createWebViewWithOptions):
188         (WTR::updateTestOptionsFromTestHeader):
189         * WebKitTestRunner/TestOptions.h:
190         (WTR::TestOptions::hasSameInitializationOptions const):
191
192 2018-06-11  Brady Eidson  <beidson@apple.com>
193
194         Followup to [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
195         https://bugs.webkit.org/show_bug.cgi?id=186436
196
197         Patch by Darin Adler
198         Reviewed by Brady Eidson.
199
200         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm:
201         (TestWebKitAPI::TEST):
202
203 2018-06-11  Mark Lam  <mark.lam@apple.com>
204
205         Gardening: skip BigInt tests on iOS until the feature is stable.
206         <rdar://problem/40331121>
207
208         Not reviewed.
209
210         * Scripts/run-jsc-stress-tests:
211
212 2018-06-11  Fujii Hironori  <Hironori.Fujii@sony.com>
213
214         [Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API
215         https://bugs.webkit.org/show_bug.cgi?id=186478
216
217         Reviewed by Alex Christensen.
218
219         Added "New WebKit Window" and "New WebKitLegacy Window" menu
220         items. Disabled the menu item "New WebKit Window" if
221         !ENABLE(WEBKIT).
222
223         * MiniBrowser/win/CMakeLists.txt: Added WebKitBrowserWindow.cpp
224         source file and ENABLE_WEBKIT macro if ENABLE_WEBKIT.
225         * MiniBrowser/win/MainWindow.cpp:
226         (MainWindow::MainWindow):
227         (MainWindow::create):
228         (MainWindow::init):
229         (MainWindow::WndProc):
230         * MiniBrowser/win/MainWindow.h:
231         * MiniBrowser/win/MiniBrowserLib.rc:
232         * MiniBrowser/win/MiniBrowserLibResource.h:
233         * MiniBrowser/win/PrintWebUIDelegate.cpp:
234         (PrintWebUIDelegate::createWebViewWithRequest):
235         * MiniBrowser/win/WebKitBrowserWindow.cpp: Added.
236         (createString):
237         (toUtf8):
238         (createWKString):
239         (createWKURL):
240         (WebKitBrowserWindow::create):
241         (WebKitBrowserWindow::WebKitBrowserWindow):
242         (WebKitBrowserWindow::init):
243         (WebKitBrowserWindow::hwnd):
244         (WebKitBrowserWindow::loadURL):
245         (WebKitBrowserWindow::loadHTMLString):
246         (WebKitBrowserWindow::navigateForwardOrBackward):
247         (WebKitBrowserWindow::navigateToHistory):
248         (WebKitBrowserWindow::setPreference):
249         (WebKitBrowserWindow::print):
250         (WebKitBrowserWindow::launchInspector):
251         (WebKitBrowserWindow::setUserAgent):
252         (WebKitBrowserWindow::userAgent):
253         (WebKitBrowserWindow::showLayerTree):
254         (WebKitBrowserWindow::updateStatistics):
255         (WebKitBrowserWindow::resetZoom):
256         (WebKitBrowserWindow::zoomIn):
257         (WebKitBrowserWindow::zoomOut):
258         (toWebKitBrowserWindow):
259         (WebKitBrowserWindow::didReceiveTitleForFrame):
260         (WebKitBrowserWindow::didCommitLoadForFrame):
261         * MiniBrowser/win/WebKitBrowserWindow.h:
262         * MiniBrowser/win/WinMain.cpp:
263         (wWinMain):
264
265 2018-06-11  Keith Miller  <keith_miller@apple.com>
266
267         Add missing whitespace to run-jsc command
268         https://bugs.webkit.org/show_bug.cgi?id=186528
269
270         Reviewed by Mark Lam.
271
272         * Scripts/run-jsc:
273
274 2018-06-11  Philippe Normand  <pnormand@igalia.com>
275
276         [webkitpy] PHP7.2 support on Debian platforms
277         https://bugs.webkit.org/show_bug.cgi?id=186521
278
279         Reviewed by Michael Catanzaro.
280
281         * Scripts/webkitpy/port/base.py:
282         (Port._debian_php_version): Refactor and add PHP 7.2 version support.
283
284 2018-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
285
286         Unreviewed. Fix WPE API and layout tests after r232670.
287
288         Now that dyz is not installed, there's not -default.so symlink for the WPE backend, so we need to use
289         WPE_BACKEND_LIBRARY environment variable to ensure tests are run with fdo backend.
290
291         * Scripts/run-wpe-tests:
292         (WPETestRunner.__init__):
293         (WPETestRunner):
294         (WPETestRunner.setup_testing_environment):
295         * Scripts/webkitpy/port/wpe.py:
296         (WPEPort.setup_environ_for_server):
297         * glib/api_test_runner.py:
298         (TestRunner.setup_testing_environment):
299         (TestRunner.run_tests):
300         (TestRunner._setup_testing_environment): Deleted.
301
302 2018-06-10  Carlos Garcia Campos  <cgarcia@igalia.com>
303
304         [GTK][WPE] Add API run run javascript from a WebKitWebView in an isolated world
305         https://bugs.webkit.org/show_bug.cgi?id=186192
306
307         Reviewed by Michael Catanzaro.
308
309         Add tests cases for the new API.
310
311         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
312         (testWebViewRunJavaScript):
313         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
314         (methodCallCallback):
315         (webkit_web_extension_initialize_with_user_data):
316         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
317         (runJavaScriptInWorldReadyCallback):
318         (WebViewTest::runJavaScriptFromGResourceAndWaitUntilFinished):
319         (WebViewTest::runJavaScriptInWorldAndWaitUntilFinished):
320         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
321
322 2018-06-10  Carlos Garcia Campos  <cgarcia@igalia.com>
323
324         [WPE] Add a MiniBrowser and use it to run WebDriver tests
325         https://bugs.webkit.org/show_bug.cgi?id=186345
326
327         Reviewed by Žan Doberšek.
328
329         Most of the code is based on dyz and gtk MiniBrowser. This patch adds a new internal library WPEToolingBackends,
330         including the headless view backend and a new window backend to be used by the MiniBrowser. MiniBrowser can also
331         run in headless mode, by using the headless backend instead of the window one, which will allow us to run the
332         WebDriver tests in the bots.
333
334         * CMakeLists.txt:
335         * MiniBrowser/wpe/CMakeLists.txt: Added.
336         * MiniBrowser/wpe/main.cpp: Added.
337         (automationStartedCallback):
338         (createViewBackend):
339         (main):
340         * Scripts/run-minibrowser: Remove WPE specific code.
341         * Scripts/run-webdriver-tests: Add headless display-server option.
342         * Scripts/webkitdirs.pm:
343         (launcherName): Remove WPE specific code.
344         * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:
345         (WebDriverWPE.browser_name): Return MiniBrowser.
346         (WebDriverWPE.browser_path): Return the path to the MiniBrowser in build dir.
347         (WebDriverWPE.browser_args): Add --headless when running in headless mode.
348         (WebDriverWPE.capabilities): Use the full browser path.
349         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
350         (WebDriverTestRunnerSelenium.collect_tests): Fix early return value.
351         * TestWebKitAPI/PlatformWPE.cmake: Use WPEToolingBackends instead of HeadlessViewBackend.
352         * TestWebKitAPI/PlatformWebView.h: Ditto.
353         * TestWebKitAPI/glib/PlatformWPE.cmake: Ditto
354         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
355         (Test::createWebViewBackend): Ditto.
356         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
357         (TestWebKitAPI::PlatformWebView::initialize): Ditto.
358         * WebKitTestRunner/PlatformWPE.cmake: Ditto.
359         * WebKitTestRunner/PlatformWebView.h: Ditto.
360         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
361         (WTR::PlatformWebView::PlatformWebView): Ditto.
362         * wpe/HeadlessViewBackend/CMakeLists.txt: Removed.
363         * wpe/backends/CMakeLists.txt: Added.
364         * wpe/backends/HeadlessViewBackend.cpp: Renamed from Tools/wpe/HeadlessViewBackend/HeadlessViewBackend.cpp.
365         (WPEToolingBackends::getEGLDisplay):
366         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
367         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
368         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
369         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
370         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
371         * wpe/backends/HeadlessViewBackend.h: Renamed from Tools/wpe/HeadlessViewBackend/HeadlessViewBackend.h.
372         * wpe/backends/ViewBackend.cpp: Added.
373         (WPEToolingBackends::ViewBackend::ViewBackend):
374         (WPEToolingBackends::ViewBackend::~ViewBackend):
375         (WPEToolingBackends::ViewBackend::initialize):
376         (WPEToolingBackends::ViewBackend::setInputClient):
377         (WPEToolingBackends::ViewBackend::backend const):
378         (WPEToolingBackends::ViewBackend::dispatchInputPointerEvent):
379         (WPEToolingBackends::ViewBackend::dispatchInputAxisEvent):
380         (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent):
381         * wpe/backends/ViewBackend.h: Added.
382         * wpe/backends/WindowViewBackend.cpp: Added.
383         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
384         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
385         (WPEToolingBackends::WindowViewBackend::displayBuffer):
386         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
387         * wpe/backends/WindowViewBackend.h: Added.
388         * wpe/jhbuild.modules: Remove dyz and add wayland-protocols.
389
390 2018-06-10  Fujii Hironori  <Hironori.Fujii@sony.com>
391
392         [Win][MiniBrowser] MiniBrowser class should be renamed to WebKitLegacyBrowserWindow
393         https://bugs.webkit.org/show_bug.cgi?id=186427
394
395         Reviewed by Ryosuke Niwa.
396
397         * MiniBrowser/win/AccessibilityDelegate.cpp:
398         * MiniBrowser/win/AccessibilityDelegate.h:
399         (AccessibilityDelegate::AccessibilityDelegate):
400         * MiniBrowser/win/CMakeLists.txt: Removed MiniBrowser.cpp. Added WebKitLegacyBrowserWindow.cpp.
401         * MiniBrowser/win/Common.h:
402         * MiniBrowser/win/MainWindow.cpp:
403         (MainWindow::init):
404         * MiniBrowser/win/MainWindow.h:
405         * MiniBrowser/win/MiniBrowserWebHost.cpp:
406         * MiniBrowser/win/MiniBrowserWebHost.h:
407         (MiniBrowserWebHost::MiniBrowserWebHost):
408         * MiniBrowser/win/PageLoadTestClient.cpp:
409         (PageLoadTestClient::PageLoadTestClient):
410         * MiniBrowser/win/PageLoadTestClient.h:
411         * MiniBrowser/win/PrintWebUIDelegate.cpp:
412         (PrintWebUIDelegate::createWebViewWithRequest):
413         * MiniBrowser/win/PrintWebUIDelegate.h:
414         (PrintWebUIDelegate::PrintWebUIDelegate):
415         * MiniBrowser/win/ResourceLoadDelegate.cpp:
416         * MiniBrowser/win/ResourceLoadDelegate.h:
417         (ResourceLoadDelegate::ResourceLoadDelegate):
418         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp: Renamed from Tools/MiniBrowser/win/MiniBrowser.cpp.
419         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Renamed from Tools/MiniBrowser/win/MiniBrowser.h.
420         * MiniBrowser/win/WebDownloadDelegate.cpp:
421         (WebDownloadDelegate::WebDownloadDelegate):
422         * MiniBrowser/win/WebDownloadDelegate.h:
423
424 2018-06-10  Chris Dumez  <cdumez@apple.com>
425
426         Reload the Web view in case of crash if the client does not implement webViewWebContentProcessDidTerminate delegate
427         https://bugs.webkit.org/show_bug.cgi?id=186468
428
429         Reviewed by Geoffrey Garen.
430
431         Add API test coverage.
432
433         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
434         (-[BasicNavigationDelegateWithoutCrashHandler webView:didStartProvisionalNavigation:]):
435         (-[BasicNavigationDelegateWithoutCrashHandler webView:didFinishNavigation:]):
436         (TEST):
437
438 2018-06-10  Michael Catanzaro  <mcatanzaro@igalia.com>
439
440         [WPE][GTK] paypal.com requires user agent quirk
441         https://bugs.webkit.org/show_bug.cgi?id=186466
442
443         Reviewed by Carlos Garcia Campos.
444
445         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
446         (TestWebKitAPI::TEST):
447
448 2018-06-09  Dan Bernstein  <mitz@apple.com>
449
450         [Xcode] Clean up and modernize some build setting definitions
451         https://bugs.webkit.org/show_bug.cgi?id=186463
452
453         Reviewed by Sam Weinig.
454
455         * DumpRenderTree/mac/Configurations/Base.xcconfig: Removed definition for macOS 10.11.
456           Simplified the definition of WK_PRIVATE_FRAMEWORK_STUBS_DIR now that
457           WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
458         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Removed definition for macOS
459           10.11.
460         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
461         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
462         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
463         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
464         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Simplified the definitions of
465           ENABLE_APPLE_PAY and ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest
466           supported version.
467         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for
468           macOS 10.11.
469         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also simplified the definition of
470           WK_PRIVATE_FRAMEWORK_STUBS_DIR now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all
471           supported Xcode versions
472         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Removed definition for macOS 10.11.
473
474 2018-06-09  Dan Bernstein  <mitz@apple.com>
475
476         Added missing file references to the Configuration group.
477
478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
479
480 2018-06-08  Darin Adler  <darin@apple.com>
481
482         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
483         https://bugs.webkit.org/show_bug.cgi?id=186436
484
485         Reviewed by Anders Carlsson.
486
487         * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm:
488         (TestWebKitAPI::WebKit2CustomProtocolsTest_ProcessPoolDestroyedDuringLoading):
489         Use @autoreleasepool.
490         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
491         (TestWebKitAPI::buildAndPerformTest): Ditto.
492         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm:
493         (TestWebKitAPI::WebKitLegacy_StopLoadingFromDidFinishLoading): Ditto.
494
495 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
496
497         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
498         https://bugs.webkit.org/show_bug.cgi?id=186442
499         <rdar://problem/40879364>
500
501         Reviewed by Tim Horton.
502
503         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
504
505 2018-06-08  Alicia Boya García  <aboya@igalia.com>
506
507         [GTK] Update to libva-2.1.0 in jhbuild
508         https://bugs.webkit.org/show_bug.cgi?id=186434
509
510         Reviewed by Philippe Normand.
511
512         * gstreamer/jhbuild.modules:
513
514 2018-06-07  Yusuke Suzuki  <utatane.tea@gmail.com>
515
516         [WTF] Add WorkerPool
517         https://bugs.webkit.org/show_bug.cgi?id=174569
518
519         Reviewed by Carlos Garcia Campos.
520
521         * TestWebKitAPI/CMakeLists.txt:
522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
523         * TestWebKitAPI/Tests/WTF/WorkerPool.cpp: Added.
524         (TestWebKitAPI::TEST):
525
526 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
527
528         [Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and WK2 BrowserWindow
529         https://bugs.webkit.org/show_bug.cgi?id=186421
530
531         Reviewed by Ryosuke Niwa.
532
533         This is the core patch to make MiniBrowser to support WK1 and WK2
534         windows (Bug 184770).
535
536         I will rename MiniBrowser class to WK1BrowserWindow in a follow-up
537         patch (Bug 184770 Comment 12).
538
539         * MiniBrowser/win/BrowserWindow.h: Added.
540         * MiniBrowser/win/MainWindow.cpp:
541         (MainWindow::WndProc):
542         * MiniBrowser/win/MainWindow.h:
543         (MainWindow::browserWindow const):
544         * MiniBrowser/win/MiniBrowser.cpp:
545         (MiniBrowser::create):
546         (MiniBrowser::navigateForwardOrBackward): Removed the unsed first argument hWnd.
547         (MiniBrowser::navigateToHistory): Ditto.
548         * MiniBrowser/win/MiniBrowser.h: Inherit BrowserWindow interface.
549         Make all other methods private and make delegates classes friends.
550         * MiniBrowser/win/PrintWebUIDelegate.cpp:
551         (PrintWebUIDelegate::createWebViewWithRequest):
552
553 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
554
555         [Win][MiniBrowser] MiniBrowser::updateDeviceScaleFactor should be a MainWindow's method
556         https://bugs.webkit.org/show_bug.cgi?id=186387
557
558         Reviewed by Ryosuke Niwa.
559
560         MiniBrowser::updateDeviceScaleFactor does nothing for MiniBrowser.
561         It should be a MainWindow's method.
562
563         * MiniBrowser/win/MainWindow.cpp:
564         (MainWindow::init): Call MainWindow::updateDeviceScaleFactor.
565         (MainWindow::resizeSubViews): Do not set a font every time window size is changed.
566         (MainWindow::WndProc): Call MainWindow::updateDeviceScaleFactor on WM_DPICHANGED.
567         (MainWindow::updateDeviceScaleFactor): Converted from
568         MiniBrowser::updateDeviceScaleFactor and
569         MiniBrowser::generateFontForScaleFactor. Set a URL bar's font if DPI is changed.
570         * MiniBrowser/win/MainWindow.h:
571         * MiniBrowser/win/MiniBrowser.cpp:
572         (MiniBrowser::init):
573         (MiniBrowser::generateFontForScaleFactor): Deleted.
574         (MiniBrowser::updateDeviceScaleFactor): Deleted.
575         * MiniBrowser/win/MiniBrowser.h:
576         (MiniBrowser::deviceScaleFactor): Deleted.
577         (MiniBrowser::urlBarFont): Deleted.
578
579 2018-06-07  Jonathan Bedard  <jbedard@apple.com>
580
581         [webkitpy] Treat svn versions as Version objects
582         https://bugs.webkit.org/show_bug.cgi?id=186403
583         <rdar://problem/40904860>
584
585         Reviewed by Dan Bernstein.
586
587         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
588         * Scripts/webkitpy/common/checkout/scm/svn.py:
589         (SVN.svn_version): Return Version object instead of string.
590         (SVN._status_regexp): Convert version string to Version object.
591         (SVN.add_list): Ditto.
592
593 2018-06-07  Tadeu Zagallo  <tzagallo@apple.com>
594
595         Don't try to allocate JIT memory if we don't have the JIT entitlement
596         https://bugs.webkit.org/show_bug.cgi?id=182605
597         <rdar://problem/38271229>
598
599         Reviewed by Mark Lam.
600
601         Add the Security framework to the TestWTF target, since it's required by the new function to check the entitlements.
602
603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
604
605 2018-06-07  Mark Lam  <mark.lam@apple.com>
606
607         Enhance run-jsc-stress-tests to allow a test to specify test specific options required for it to run.
608         https://bugs.webkit.org/show_bug.cgi?id=186409
609         <rdar://problem/40909007>
610
611         Reviewed by Saam Barati.
612
613         This is needed because some tests are written with specific features in mind, and
614         we may not necessarily want to enable that option for all tests.
615
616         We can now specify something like this at the top of a test file:
617             //@ requireOptions("--useIntlPluralRules=true")
618
619         ... and ensure that that test will be run with the --useIntlPluralRules=true
620         option for all test configurations that run the test.
621
622         * Scripts/run-jsc-stress-tests:
623
624 2018-06-07  Tim Horton  <timothy_horton@apple.com>
625
626         REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing
627         https://bugs.webkit.org/show_bug.cgi?id=186395
628         <rdar://problem/40902427>
629
630         Reviewed by Wenson Hsieh.
631
632         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
633         (TEST):
634         endAnimatedResize no longer synchronizes, so we have to wait for the next presentation update.
635
636 2018-06-07  Thibault Saunier  <tsaunier@igalia.com>
637
638         [GTK][WPE] Start implementing MediaStream API
639         https://bugs.webkit.org/show_bug.cgi?id=185787
640
641         Reviewed by Philippe Normand.
642
643         * Scripts/webkitpy/style/checker.py: Apply special formatting rules for new GObject subclasses.
644         * gstreamer/jhbuild.modules: Added a patch for the gst-plugins-base.
645         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch:
646         Added this fix to gst-plugings-base to fix the decodebin3. Merged as 89d0e9cc92a86aa0227ee87406737b6d31670aea
647
648 2018-06-07  Brendan McLoughlin  <brendan@bocoup.com>
649
650         Update web-platform-tests github location in webkitpy.w3c.test_importer
651         https://bugs.webkit.org/show_bug.cgi?id=186392
652
653         Reviewed by Youenn Fablet.
654
655         * Scripts/webkitpy/w3c/test_importer.py:
656         (TestImporter.write_import_log):
657
658 2018-06-07  Jonathan Bedard  <jbedard@apple.com>
659
660         webkitperl: Generalize .internal SDK suffix
661         https://bugs.webkit.org/show_bug.cgi?id=186352
662         <rdar://problem/40853947>
663
664         Reviewed by Alexey Proskuryakov.
665
666         * Scripts/build-webkit:
667         * Scripts/package-root:
668         (usage):
669         * Scripts/webkitdirs.pm:
670         (parseAvailableXcodeSDKS): Parse 'xcodebuild -showsdks' output.
671         (availableXcodeSDKS): Generate a list of all available Xcode SDKs on this machine.
672         (determineXcodeSDK): Always prefer .internal SDKs if available.
673         * Scripts/webkitperl/webkitdirs_unittest/availableXcodeSDKS.pl:
674         
675 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
676
677         [Win][MiniBrowser] Support multiple windows properly
678         https://bugs.webkit.org/show_bug.cgi?id=186263
679
680         Reviewed by Ryosuke Niwa.
681
682         The current implementation of
683         PrintWebUIDelegate::createWebViewWithRequest is wrong. It is using
684         CreateProcess to open a new window, and doesn't return the new
685         instance of IWebView. As the result, for example, window.close
686         doesn't work as expected.
687
688         In this change, a new MainWindow is created and return the
689         IWebView in PrintWebUIDelegate::createWebViewWithRequest.
690
691         In addition to it, this change unifies the lifetime of MiniBrowser
692         and its delegates AccessibilityDelegate, PrintWebUIDelegate,
693         ResourceLoadDelegate and WebDownloadDelegate in order to keep
694         MiniBrowser alive as long as the delegates live. Because the
695         window of webview keeps references of such delegates and accesses
696         those after MiniBrowser destruction.
697
698         * MiniBrowser/win/MainWindow.h: Added s_numInstances class member
699         to count the number of instance to close the application. Do not
700         use unique_ptr for m_browserWindow because it has ref count now.
701         * MiniBrowser/win/MainWindow.cpp:
702         (MainWindow::MainWindow): Increment s_numInstances.
703         (MainWindow::~MainWindow): Decrement s_numInstances.
704         (MainWindow::create):
705         (MainWindow::init):
706         (MainWindow::WndProc): Rename thiz to thisWindow. Keep this
707         instance alive during this function by using RefPtr<MainWindow>.
708         Deref the MainWindow instance on WM_DESTROY. Quit the application
709         when the last MainWindow is closed.
710         (MainWindow::cachesDialogProc): Rename thiz to thisWindow.
711         (MainWindow::customUserAgentDialogProc): Ditto.
712         * MiniBrowser/win/MiniBrowser.h: Added declarations AddRef and Release.
713         * MiniBrowser/win/MiniBrowser.cpp:
714         (MiniBrowser::create):
715         (MiniBrowser::AddRef):
716         (MiniBrowser::Release):
717         (MiniBrowser::init): Passes this to the constructors of delegates.
718         * MiniBrowser/win/AccessibilityDelegate.cpp:
719         (AccessibilityDelegate::AddRef): Delegate to MiniBrowser.
720         (AccessibilityDelegate::Release): Ditto.
721         * MiniBrowser/win/AccessibilityDelegate.h: Removed m_refCount.
722         (AccessibilityDelegate::AccessibilityDelegate):
723         * MiniBrowser/win/MiniBrowserWebHost.cpp:
724         (MiniBrowserWebHost::AddRef): Delegate to MiniBrowser.
725         (MiniBrowserWebHost::Release): Ditto.
726         * MiniBrowser/win/MiniBrowserWebHost.h: Removed m_refCount.
727         * MiniBrowser/win/PrintWebUIDelegate.cpp:
728         (PrintWebUIDelegate::createWebViewWithRequest): Create a new
729         MainWindow and return the IWebView.
730         (PrintWebUIDelegate::AddRef): Delegate to MiniBrowser.
731         (PrintWebUIDelegate::Release): Ditto.
732         * MiniBrowser/win/PrintWebUIDelegate.h: Removed m_refCount.
733         (PrintWebUIDelegate::PrintWebUIDelegate):
734         * MiniBrowser/win/ResourceLoadDelegate.cpp:
735         (ResourceLoadDelegate::AddRef): Delegate to MiniBrowser.
736         (ResourceLoadDelegate::Release): Ditto.
737         * MiniBrowser/win/ResourceLoadDelegate.h: Removed m_refCount.
738         * MiniBrowser/win/WebDownloadDelegate.cpp:
739         (WebDownloadDelegate::WebDownloadDelegate):
740         (WebDownloadDelegate::AddRef): Delegate to MiniBrowser.
741         (WebDownloadDelegate::Release): Ditto.
742         * MiniBrowser/win/WebDownloadDelegate.h: Removed m_refCount.
743
744 2018-06-06  Fujii Hironori  <Hironori.Fujii@sony.com>
745
746         [Win][MiniBrowser] Remove gMainWindow global variable
747         https://bugs.webkit.org/show_bug.cgi?id=186378
748
749         Reviewed by Ryosuke Niwa.
750
751         I'm going to support multiple MainWindow in Bug 186263. It should
752         not be assumed that MainWindow has only one instance. gMainWindow
753         is used only in DisplayAuthDialog.
754
755         * MiniBrowser/win/Common.cpp:
756         (authDialogProc): Use DWLP_USER to store the dialog data.
757         (displayAuthDialog): Moved and renamed from
758         MainWindow::displayAuthDialog. Use DialogBoxParam instead of
759         DialogBox to pass a data pointer. Do not return S_OK if
760         DialogBoxParam returns -1. Take a HWND argument as the parent
761         window.
762         (DisplayAuthDialog): Deleted.
763         * MiniBrowser/win/Common.h:
764         * MiniBrowser/win/MainWindow.cpp:
765         (authDialogProc): Moved to Common.cpp.
766         (MainWindow::displayAuthDialog): Ditto.
767         * MiniBrowser/win/MainWindow.h:
768         * MiniBrowser/win/ResourceLoadDelegate.cpp:
769         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
770         * MiniBrowser/win/WinMain.cpp:
771         (wWinMain): Added a local variable mainWindow instead of using
772         gMainWindow.
773
774 2018-06-06  Dan Bernstein  <mitz@apple.com>
775
776         [Xcode] Opt out of the New Build System
777         https://bugs.webkit.org/show_bug.cgi?id=186380
778
779         Reviewed by Alexey Proskuryakov.
780
781         * Scripts/webkitdirs.pm:
782         (XcodeOptions): Have -UseNewBuildSystem=NO passed to xcodebuild.
783
784 2018-06-06  Antoine Quint  <graouts@apple.com>
785
786         Rename color-filter to -apple-color-filter and do not expose it to Web content
787         https://bugs.webkit.org/show_bug.cgi?id=186306
788         <rdar://problem/39874167>
789
790         Reviewed by Simon Fraser.
791
792         Adding an option to turn support for the -apple-color-filter property on via an HTML comment.
793
794         * DumpRenderTree/TestOptions.cpp:
795         (TestOptions::TestOptions):
796         * DumpRenderTree/TestOptions.h:
797         * DumpRenderTree/mac/DumpRenderTree.mm:
798         (setWebPreferencesForTestOptions):
799         * WebKitTestRunner/TestController.cpp:
800         (WTR::TestController::resetPreferencesToConsistentValues):
801         (WTR::updateTestOptionsFromTestHeader):
802         * WebKitTestRunner/TestOptions.h:
803         (WTR::TestOptions::hasSameInitializationOptions const):
804         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
805         (WTR::TestController::platformCreateWebView):
806
807 2018-06-06  Brent Fulgham  <bfulgham@apple.com>
808
809         Adjust compile and runtime flags to match shippable state of features (Part 2)
810         https://bugs.webkit.org/show_bug.cgi?id=186319
811         <rdar://problem/40352045>
812
813         Unreviewed test fix.
814
815         TestWebKitAPI was timing out because 'color' input types are no longer support. I also discovered that the
816         ASSERT_STREQ macro returns on error, which causes tests to time out whenever a 'done = true' call (needed to
817         end the test) is done after ASSERT_STREQ, which might fail and return early, preventing the flag from being
818         set.
819
820         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm:
821         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]): Make testing of
822         the 'color' input type conditional on the feature being part of the build.
823         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
824         (-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]): Set the 'done=true' state before performing
825         string equality assertions, since they do an early return and bypass the end state of the test.
826         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]): Ditto.
827         (-[AutoFillAvailableDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
828         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
829
830 2018-06-05  Chris Dumez  <cdumez@apple.com>
831
832         Regression(r232082): Websites get loaded inside of Messages App chat transcript
833         https://bugs.webkit.org/show_bug.cgi?id=186331
834         <rdar://problem/40735446>
835
836         Reviewed by Darin Adler.
837
838         Add API test coverage.
839
840         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm:
841         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
842         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:didStartProvisionalLoadForFrame:]):
843         (TestWebKitAPI::TEST):
844         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Deleted.
845         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): Deleted.
846         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]): Deleted.
847
848 2018-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
849
850         DataInteractionTests ContentEditableToTextarea and ContentEditableToContentEditable are failing on recent iOS 12
851         https://bugs.webkit.org/show_bug.cgi?id=186325
852         <rdar://problem/40527850>
853
854         Reviewed by Tim Horton.
855
856         Tweak these API tests so that they're robust against changes to how NSAttributedStrings are serialized in item
857         providers ("public.rtf" vs. "com.apple.flat-rtfd"). Across all versions of iOS, just verify that either rich
858         text type is present in the list of dragged type identifiers, and that the rich text type is placed at a higher
859         fidelity than plain text.
860
861         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
862         (checkRichTextTypePrecedesPlainTextType):
863         (TestWebKitAPI::TEST):
864         (checkTypeIdentifierPrecedesOtherTypeIdentifier): Deleted.
865
866 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
867
868         Adjust compile and runtime flags to match shippable state of features
869         https://bugs.webkit.org/show_bug.cgi?id=186319
870         <rdar://problem/40352045>
871
872         Reviewed by Maciej Stachowiak, Jon Lee, and others.
873
874         This patch revises the compile time and runtime state for various features to match their
875         suitability for end-user releases.
876
877         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
878         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
879         Cocoa builds.
880         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
881         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
882
883 2018-06-05  Saam Barati  <sbarati@apple.com>
884
885         run-testmem should have a dry run option and an option to parse the stdout of executing the dry run
886         https://bugs.webkit.org/show_bug.cgi?id=186293
887
888         Reviewed by Mark Lam.
889
890         This makes it easier to execute run-testmem on a device that doesn't have ruby
891         on it. run-testmem now has a --dry option that will output commands to execute
892         in bash. To run on a device that doesn't have ruby, just put its output into
893         a bash script, and copy the PerformanceTests/testmem directory onto that device,
894         and execute the bash script. Running that bash script will give you raw output.
895         Make a file with that output and pass it into run-testmem using the --parse option.
896         run-testmem will parse the raw output and compute the benchmark score.
897
898         * Scripts/run-testmem:
899
900 2018-06-05  Youenn Fablet  <youenn@apple.com>
901
902         ServiceWorker registration should store any script fetched through importScripts
903         https://bugs.webkit.org/show_bug.cgi?id=182444
904         <rdar://problem/37164835>
905
906         Reviewed by Chris Dumez.
907
908         Add support to crash the storage process from Internals.
909
910         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
911         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
912         (WTR::TestRunner::terminateStorageProcess):
913         * WebKitTestRunner/InjectedBundle/TestRunner.h:
914         * WebKitTestRunner/TestController.cpp:
915         (WTR::TestController::terminateStorageProcess):
916         * WebKitTestRunner/TestController.h:
917         * WebKitTestRunner/TestInvocation.cpp:
918         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
919
920 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
921
922         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
923         https://bugs.webkit.org/show_bug.cgi?id=186286
924         <rdar://problem/40782992>
925
926         Reviewed by Dan Bernstein.
927
928         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
929         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
930         change this flag when preparing for a production release.
931
932         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to
933         determine whether experimental features should be enabled, and use it to properly define
934         the feature flag.
935
936 2018-06-05  Robin Morisset  <rmorisset@apple.com>
937
938         Add a grammar (in antlr4 format) to the WSL spec.
939         https://bugs.webkit.org/show_bug.cgi?id=186310
940
941         Rubberstamped by Filip Pizlo
942
943         It is just the raw rules, without much comments and no typesetting.
944         Compiles to any of Java/JS/C++/etc.. with antlr4 (requires a JDK)
945
946         It does not exactly match the parser of the current js implementation of WSL, it:
947         - Accepts negative literals
948         - Reserves keywords fallthrough/auto
949         - Refuses '_' as a valid identifier
950         - Accepts several capitalizations for Null/True/False
951         - Accepts variable declarations at the top-level
952         - Correctly parses ternary expressions
953         - Forbids empty extension list for protocols
954         - Does not allow a space between '[' and ']' in type suffixes
955         - Correctly parses nested generics
956         - Accepts a 'fallthrough;' statement (for switches)
957         - Refuses chained relational operator (e.g. x < y < z)
958         - Generally a completely different structure for parsing effectful expressions, although it probably accepts about the same language
959         - Currently only accepts literals and identifiers as constexpr (while the js parser accepts way too much, including '(x += 42)')
960         There are probably more differences that I missed. The js parser will probably have to be mostly rewritten to follow the spec more closely (and fix all the bugs).
961         I will try to see if it can be automatically derived from the antlr4 grammar.
962
963         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Added.
964
965 2018-06-04  Frederic Wang  <fwang@igalia.com>
966
967         import-w3c-tests should rely on <meta name="flags"> to detect CSS manual tests
968         https://bugs.webkit.org/show_bug.cgi?id=186261
969
970         Reviewed by Youenn Fablet.
971
972         * Scripts/webkitpy/w3c/test_parser.py:
973         (TestParser.is_wpt_manualtest): Add code to detect whether a file is a manual test
974         from its <meta name="flags"> tags. This is based on SourceFile::content_is_css_manual from
975         the WPT repository.
976         * Scripts/webkitpy/w3c/test_parser_unittest.py: Add a test to verify whether files with
977         <meta name="flags"> are manual or non-manual according to CSS WG rules.
978
979 2018-06-04  Dan Bernstein  <mitz@apple.com>
980
981         Fixed building ImageDiff with the default build system in the Xcode 10 developer beta.
982
983         * ImageDiff/cg/Configurations/Base.xcconfig: Use #include? to include
984           HaveInternalSDK.xcconfig, since it may not be preent.
985
986 2018-06-04  Dan Bernstein  <mitz@apple.com>
987
988         Fixed building TestWebKitAPI with a shared build directory with XCBuild, which is the
989         default build system in the Xcode 10 developer beta.
990
991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Changed the reference to the
992           built libWTF.a to be relative to the built products directory.
993
994 2018-06-04  Chris Dumez  <cdumez@apple.com>
995
996         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
997         https://bugs.webkit.org/show_bug.cgi?id=186287
998         <rdar://problem/40783352>
999
1000         Reviewed by Youenn Fablet.
1001
1002         * DumpRenderTree/mac/DumpRenderTree.mm:
1003         (enableExperimentalFeatures):
1004         * DumpRenderTree/win/DumpRenderTree.cpp:
1005         (enableExperimentalFeatures):
1006
1007 2018-06-04  Daniel Bates  <dabates@apple.com>
1008
1009         Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue()
1010         https://bugs.webkit.org/show_bug.cgi?id=186290
1011
1012         Reviewed by Aakash Jain.
1013
1014         Although the usefulness of the code in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() is
1015         questionable we should fix a typo when calling this mocked function with argument since.
1016
1017         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1018         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
1019
1020 2018-06-04  Dan Bernstein  <mitz@apple.com>
1021
1022         Fixed building with the macOS Mojave seed SDK.
1023
1024         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
1025
1026 2018-06-04  Alexey Proskuryakov  <ap@apple.com>
1027
1028         Add Mojave support to WebKit tools
1029         https://bugs.webkit.org/show_bug.cgi?id=186282
1030
1031         Reviewed by Daniel Bates.
1032
1033         Nightly build support will be added separately.
1034
1035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png: Added.
1036         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png: Added.
1037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1038         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1039         Added dashboard support.
1040
1041         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1042         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1043         Trigger the right build queues on check-in.
1044
1045         * Scripts/webkitpy/common/version_name_map.py:
1046         * Scripts/webkitpy/common/version_name_map_unittest.py:
1047         The main version mapping class updated.
1048
1049         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1050         * Scripts/webkitpy/port/mac_unittest.py:
1051         Updated for more platforms in unit tests.
1052
1053         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1054         Added the new platform to flakiness dashboard.
1055
1056 2018-06-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1057
1058         [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag
1059         https://bugs.webkit.org/show_bug.cgi?id=186279
1060
1061         Reviewed by Tim Horton.
1062
1063         Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS).
1064
1065         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
1066
1067 2018-06-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1068
1069         [Win][MiniBrowser] Remove gMiniBrowser global variable
1070         https://bugs.webkit.org/show_bug.cgi?id=186134
1071
1072         Reviewed by Brent Fulgham.
1073
1074         It should not be assumed there is only one main window and one browser
1075         window to support multiple windows properly. gMainWindow and
1076         gMiniBrowser global variables should be removed. This change
1077         removes gMiniBrowser.
1078
1079         * MiniBrowser/win/Common.cpp: Removed gMiniBrowser global variable.
1080         * MiniBrowser/win/Common.h: Ditto.
1081         * MiniBrowser/win/MainWindow.cpp:
1082         (MainWindow::init):
1083         (MainWindow::WndProc):
1084         (EditProc): Post WM_COMMAND if the enter key is pressed in URL bar.
1085         (MainWindow::cachesDialogProc): Renamed from Caches.
1086         (MainWindow::customUserAgentDialogProc): Renamed from CustomUserAgent.
1087         (MainWindow::onURLBarEnter): Extracted from EditProc.
1088         (BackButtonProc): Deleted.
1089         (ForwardButtonProc): Deleted.
1090         (Caches): Renamed to MainWindow::cachesDialogProc.
1091         (CustomUserAgent): Renamed to MainWindow::customUserAgentDialogProc.
1092         * MiniBrowser/win/MainWindow.h: Convert hCacheWnd global variable to a member variable of MainWindow.
1093         * MiniBrowser/win/MiniBrowserLibResource.h:
1094         * MiniBrowser/win/WinMain.cpp:
1095         (wWinMain):
1096
1097 2018-06-02  Darin Adler  <darin@apple.com>
1098
1099         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
1100         https://bugs.webkit.org/show_bug.cgi?id=186227
1101
1102         Reviewed by Dan Bernstein.
1103
1104         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1105         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
1106         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1107
1108         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Add a missing include.
1109
1110         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1111         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1112         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1113         (AccessibilityTextMarker::isEqual): Ditto.
1114         (AccessibilityTextMarkerRange::isEqual): Ditto.
1115
1116         * DumpRenderTree/mac/DumpRenderTree.mm:
1117         (-[DumpRenderTree _waitForWebThread]): Use @autoreleasepool instead of NSAutoreleasePool.
1118         (DumpRenderTreeMain): Ditto.
1119         (WebThreadLockAfterDelegateCallbacksHaveCompleted): Ditto.
1120         (runTest): Ditto.
1121
1122         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1123         (copyFile): Use a std::pair to return both a URL and an error rather than using an
1124         out argument for the NSError.
1125         (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
1126         Updated for the above change.
1127
1128         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1129         (-[DumpRenderTreeWindow _addToOpenWindows]): Add __bridge to a bridging typecast.
1130         (-[DumpRenderTreeWindow close]): Ditto.
1131         * DumpRenderTree/mac/LayoutTestHelper.m:
1132         (setDisplayColorProfile): Ditto.
1133
1134         * DumpRenderTree/mac/PolicyDelegate.mm: Add a missing include.
1135
1136         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1137         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1138         Add __bridge to a bridging typecast.
1139         * DumpRenderTree/mac/TestRunnerMac.mm:
1140         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Ditto.
1141         (TestRunner::apiTestNewWindowDataLoadBaseURL): Use @autoreleasepool instead of NSAutoreleasePool.
1142
1143         * DumpRenderTree/mac/TextInputControllerMac.m: Fix a comment.
1144
1145         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1146         (WTR::UIScriptController::replaceTextAtRange): Add __bridge to a bridging typecast.
1147         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Ditto.
1148         (WTR::UIScriptController::overridePreference): Ditto.
1149         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1150         (LoadItem::invoke const): Ditto.
1151         (LoadHTMLStringItem::invoke const): Ditto.
1152         (ScriptItem::invoke const): Ditto.
1153
1154         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1155         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
1156         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1157
1158         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1159         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
1160         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1161
1162         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1163         (WTR::AccessibilityController::accessibleElementById): Add __bridge to a bridging typecast.
1164         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1165         (-[NSString createJSStringRef]): Ditto.
1166         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm:
1167         (WTR::AccessibilityTextMarker::isEqual): Ditto.
1168         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm:
1169         (WTR::AccessibilityTextMarkerRange::isEqual): Ditto.
1170         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1171         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
1172         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Ditto.
1173         (WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto.
1174         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
1175         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
1176         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto.
1177         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
1178         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
1179         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
1180         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
1181         (WTR::createJSStringRef): Ditto.
1182         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
1183         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
1184         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
1185         (WTR::AccessibilityUIElement::indexForTextMarker): Ditto.
1186         (WTR::AccessibilityUIElement::isTextMarkerValid): Ditto.
1187         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
1188         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
1189         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
1190         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
1191         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
1192         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
1193         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
1194         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
1195         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
1196         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
1197         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1198         (WTR::initializeWebViewConfiguration): Ditto.
1199         (WTR::TestController::platformContext): Ditto.
1200         (WTR::TestController::platformPreferences): Ditto.
1201         (WTR::TestController::platformAdjustContext): Ditto.
1202         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1203         (WTR::PlatformWebView::PlatformWebView): Ditto.
1204         * WebKitTestRunner/mac/TestControllerMac.mm:
1205         (WTR::TestController::initializeInjectedBundlePath): Ditto.
1206         (WTR::TestController::initializeTestPluginDirectory): Ditto.
1207         (WTR::TestController::platformConfigureViewForTest): Ditto.
1208
1209         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1210         (WTR::nsString): Use CFBridgingRelease instead of autorelease.
1211         (WTR::UIScriptController::platformPlayBackEventStream): Add __bridge to a bridging
1212         typecast.
1213
1214         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Add a missing include.
1215
1216         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
1217         (-[LocalPasteboard setPropertyList:forType:]): Add _bridge to a bridging typecast.
1218         (-[LocalPasteboard setString:forType:]): Ditto.
1219
1220         * WebKitTestRunner/mac/main.mm:
1221         (main): Use @autoreleasepool instead of NSAutoreleasePool.
1222
1223 2018-06-02  Keith Miller  <keith_miller@apple.com>
1224
1225         run-jsc should pass the option to use dollar vm by default
1226         https://bugs.webkit.org/show_bug.cgi?id=186170
1227
1228         Reviewed by Yusuke Suzuki.
1229
1230         * Scripts/run-jsc:
1231
1232 2018-06-02  Commit Queue  <commit-queue@webkit.org>
1233
1234         Unreviewed, rolling out r232421.
1235         https://bugs.webkit.org/show_bug.cgi?id=186240
1236
1237         Breaks webkitpy tests (Requested by aakashjain on #webkit).
1238
1239         Reverted changeset:
1240
1241         "Add some tests for lldb_webkit.py"
1242         https://bugs.webkit.org/show_bug.cgi?id=183744
1243         https://trac.webkit.org/changeset/232421
1244
1245 2018-06-01  Daniel Bates  <dabates@apple.com>
1246
1247         Add some tests for lldb_webkit.py
1248         https://bugs.webkit.org/show_bug.cgi?id=183744
1249
1250         Reviewed by Alexey Proskuryakov.
1251
1252         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
1253         and WTF::String objects.
1254
1255         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
1256         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
1257         on Mac.
1258
1259         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
1260         * Scripts/build-lldbwebkittester: Added.
1261         (buildProjectOrDie):
1262         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
1263         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
1264         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
1265         the file and take advantage of Python's default error semantics to throw an exception
1266         if the import fails instead of handling it ourself. This has the side effect that we
1267         now always import the LLDB Python module even if this script is invoked with --help.
1268         If this turns out to be a significant annoyance then we can look to dynamically import
1269         the module as we did before this change.
1270         (webkit_build_dir):
1271         (main):
1272         (developer_dir): Deleted.
1273         (import_lldb): Deleted.
1274         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
1275         that fact that test-webkitpy does not support class and module fixtures. This is because
1276         test-webkitpy currently implements parallelism by breaking down existing test classes
1277         into individual test methods itself and having each worker run exactly one test method (via
1278         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
1279         setUpModule()/setUpClass() are called for each test method as opposed to once per test
1280         class/test module.
1281         (remove_dir): Ditto.
1282         * Scripts/webkitpy/common/system/systemhost.py:
1283         (SystemHost):
1284         (SystemHost.path_to_lldb_python_directory): Added.
1285         * Scripts/webkitpy/test/main.py:
1286         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
1287         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
1288         lldbWebKitTester on Mac.
1289         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
1290         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
1291         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
1292         If we will run these tests then build lldbWebKitTester if it has not already been built as the
1293         unit tests depend on this program.
1294         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
1295         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
1296         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
1297         * lldb/lldbWebKitTester/Makefile: Added.
1298         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
1299         * lldb/lldbWebKitTester/main.cpp: Added.
1300         (breakForTestingSummaryProviders):
1301         (utf16String):
1302         (testSummaryProviders):
1303         (main):
1304         * lldb/lldb_webkit_unittest.py: Added.
1305         (destroy_cached_debug_session):
1306         (LLDBDebugSession):
1307         (LLDBDebugSession.setup):
1308         (LLDBDebugSession.tearDown):
1309         (TestSummaryProviders):
1310         (TestSummaryProviders.setUpClass):
1311         (TestSummaryProviders._sbFrame):
1312         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
1313         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
1314         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
1315         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
1316         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
1317         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
1318         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
1319         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
1320
1321 2018-06-01  Frederic Wang  <fwang@igalia.com>
1322
1323         export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
1324         https://bugs.webkit.org/show_bug.cgi?id=186133
1325
1326         Reviewed by Youenn Fablet.
1327
1328         * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the diff.
1329         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test.
1330
1331 2018-05-31  Frederic Wang  <fwang@igalia.com>
1332
1333         export-w3c-test-changes should use the new location & name of the WPT repo
1334         https://bugs.webkit.org/show_bug.cgi?id=186135
1335
1336         Reviewed by Youenn Fablet.
1337
1338         Web platform tests have been moved to GitHub's web-platform-tests/wpt. This patch updates the
1339         corresponding variables to use the new organization and repository name. It also refactors a
1340         bit the code to reduce the amount of hardcoded strings.
1341
1342         * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name wpt. Also removes the
1343         final slash to WPT_GH_URL, so it can be used for repo URL too.
1344         * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define WPT_PR_URL from
1345         WPT_GH_URL.
1346         (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_NAME.
1347         (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME.
1348         (WebPlatformTestExporter._git): Use  WPT_GH_URL.
1349         (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
1350         (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
1351         (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL.
1352         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1353         (TestExporterTest.test_export): Update organization and repository names for the remote
1354         branch and pull request.
1355         (TestExporterTest.test_export_with_specific_branch): Update repository name.
1356
1357 2018-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1358
1359         Update expected results for BuildStepsConstructorTest
1360         https://bugs.webkit.org/show_bug.cgi?id=186119
1361
1362         Reviewed by Alex Christensen.
1363
1364         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missing entries for 'WinCairo 64-bit' bots.
1365
1366 2018-05-31  Sihui Liu  <sihui_liu@apple.com>
1367
1368         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
1369         https://bugs.webkit.org/show_bug.cgi?id=185831
1370         <rdar://problem/40468716>
1371
1372         Reviewed by David Kilzer.
1373
1374         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1375         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1376         (TEST):
1377
1378 2018-05-31  Chris Dumez  <cdumez@apple.com>
1379
1380         [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset is a flaky failure
1381         https://bugs.webkit.org/show_bug.cgi?id=184893
1382         <rdar://problem/39747271>
1383
1384         Reviewed by Wenson Hsieh.
1385
1386         Update test to wait until the view is the expected height instead of
1387         calling waitForNextPresentationUpdate once and expect the view to
1388         have the right height. This fixes the flakiness.
1389
1390         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1391         (TestWebKitAPI::waitUntilInnerHeightIs):
1392         (TestWebKitAPI::TEST):
1393
1394 2018-05-31  Leo Balter  <leonardo.balter@gmail.com>
1395
1396         test262-runner should run in verbose mode in automation
1397         https://bugs.webkit.org/show_bug.cgi?id=186115
1398
1399         Reviewed by Yusuke Suzuki.
1400
1401         This patch toggles the verbose mode in the build bot and reports every test file
1402         in order to avoid the '1200 seconds without output' issue.
1403         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1404         (RunTest262Tests):
1405         * Scripts/test262/Runner.pm:
1406         (processResult):
1407
1408 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1409
1410         [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
1411         https://bugs.webkit.org/show_bug.cgi?id=186079
1412
1413         Reviewed by Alex Christensen.
1414
1415         This is a sub task of Bug 184770.
1416
1417         This change is partial. I'm going to remove global variables
1418         gMainWindow and gMiniBrowser and convert more functions to
1419         MainWindow's methods in follow-up patches.
1420
1421         * MiniBrowser/win/CMakeLists.txt: Added Common.cpp
1422         * MiniBrowser/win/Common.cpp:
1423         (menuItemIsChecked): Moved to MainWindow.cpp.
1424         (turnOffOtherUserAgents): Ditto.
1425         (EditProc): Ditto.
1426         (BackButtonProc): Ditto.
1427         (ForwardButtonProc): Ditto.
1428         (About): Ditto.
1429         (Caches): Ditto.
1430         (CustomUserAgent): Ditto.
1431         (AuthDialogProc): Ditto.
1432         (DisplayAuthDialog): Converted to MainWindow's method.
1433         (ToggleMenuItem): Ditto.
1434         (loadURL): Ditto.
1435         * MiniBrowser/win/Common.h:
1436         * MiniBrowser/win/MainWindow.cpp:
1437         (MainWindow::init): Call SetFocus at the end of the construction.
1438         (MainWindow::WndProc):
1439         (menuItemIsChecked): Moved from Common.cpp.
1440         (turnOffOtherUserAgents): Ditto.
1441         (EditProc): Ditto.
1442         (BackButtonProc): Ditto.
1443         (ForwardButtonProc): Ditto.
1444         (About): Ditto.
1445         (Caches): Ditto.
1446         (CustomUserAgent): Ditto.
1447         (authDialogProc): Ditto.
1448         (MainWindow::displayAuthDialog): Converted from a function of Common.cpp.
1449         (MainWindow::toggleMenuItem): Ditto.
1450         (MainWindow::loadURL): Ditto.
1451         * MiniBrowser/win/MainWindow.h: Added method declarations.
1452         * MiniBrowser/win/MiniBrowser.h: Added pragma once.
1453         * MiniBrowser/win/WinMain.cpp:
1454         (wWinMain): Include Common.h instead of Common.cpp.
1455
1456 2018-05-30  Brady Eidson  <beidson@apple.com>
1457
1458         REGRESSION (r224684): User-agent seen by page does not change when modified by the develop menu options after reloading.
1459         <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=186111
1460
1461         Reviewed by Andy Estes.
1462
1463         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1464         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1465         (WTR::TestRunner::setCustomUserAgent):
1466         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1467         * WebKitTestRunner/TestController.cpp:
1468         (WTR::TestController::resetStateToConsistentValues):
1469         * WebKitTestRunner/TestInvocation.cpp:
1470         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1471
1472 2018-05-30  Youenn Fablet  <youenn@apple.com>
1473
1474         Rename CrossOriginResourcePolicy same to same-origin
1475         https://bugs.webkit.org/show_bug.cgi?id=186080
1476
1477         Reviewed by Chris Dumez.
1478
1479         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
1480         (TestWebKitAPI::TEST):
1481
1482 2018-05-30  Ms2ger  <Ms2ger@igalia.com>
1483
1484         [GTK] Unreviewed test gardening
1485         https://bugs.webkit.org/show_bug.cgi?id=186098
1486
1487         Unreviewed gardening.
1488
1489         * TestWebKitAPI/glib/TestExpectations.json: update expectations.
1490
1491 2018-05-29  Youenn Fablet  <youenn@apple.com>
1492
1493         Add a consistency check between URL and CFURL
1494         https://bugs.webkit.org/show_bug.cgi?id=182444
1495         <rdar://problem/37164835>
1496
1497         Reviewed by Geoff Garen.
1498
1499         DRT code expected a non null URL which is no longer the case now.
1500         Updated DRT to remove that assumption.
1501
1502         * DumpRenderTree/TestRunner.cpp:
1503         (TestRunner::redirectionDestinationForURL):
1504         * DumpRenderTree/TestRunner.h:
1505         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1506         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1507
1508 2018-05-29  Brendan McLoughlin  <brendan@bocoup.com>
1509
1510         Export changes to web-platform-test as part of the webkit-patch upload workflow
1511         https://bugs.webkit.org/show_bug.cgi?id=184914
1512
1513         Reviewed by Youenn Fablet.
1514
1515         * Scripts/webkitpy/tool/commands/upload.py:
1516         (Upload):
1517         (CreateBug.execute):
1518         (WPTChangeExport):
1519         * Scripts/webkitpy/tool/steps/__init__.py:
1520         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
1521         (WPTChangeExport):
1522         (WPTChangeExport.options):
1523         (WPTChangeExport.run):
1524         * Scripts/webkitpy/w3c/common.py:
1525         * Scripts/webkitpy/w3c/test_exporter.py:
1526         (WebPlatformTestExporter):
1527         (WebPlatformTestExporter.__init__):
1528         (WebPlatformTestExporter.username):
1529         (WebPlatformTestExporter.token):
1530         (WebPlatformTestExporter._github):
1531         (WebPlatformTestExporter._wpt_fork_branch_github_url):
1532         (WebPlatformTestExporter._wpt_fork_remote):
1533         (WebPlatformTestExporter._wpt_fork_push_url):
1534         (WebPlatformTestExporter._git):
1535         (WebPlatformTestExporter._branch_name):
1536         (WebPlatformTestExporter._public_branch_name):
1537         (WebPlatformTestExporter._wpt_patch):
1538         (WebPlatformTestExporter.has_wpt_changes):
1539         (WebPlatformTestExporter._find_filename):
1540         (WebPlatformTestExporter._is_ignored_file):
1541         (WebPlatformTestExporter._strip_ignored_files_from_diff):
1542         (WebPlatformTestExporter.write_git_patch_file):
1543         (WebPlatformTestExporter._prompt_for_token):
1544         (WebPlatformTestExporter._prompt_for_username):
1545         (WebPlatformTestExporter._ensure_username_and_token):
1546         (WebPlatformTestExporter._validate_and_save_token):
1547         (WebPlatformTestExporter.create_branch_with_patch):
1548         (WebPlatformTestExporter.push_to_wpt_fork):
1549         (WebPlatformTestExporter.make_pull_request):
1550         (WebPlatformTestExporter.delete_local_branch):
1551         (WebPlatformTestExporter.create_upload_remote_if_needed):
1552         (WebPlatformTestExporter.do_export):
1553         (parse_args):
1554         (TestExporter): Deleted.
1555         (TestExporter.__init__): Deleted.
1556         (TestExporter._ensure_wpt_repository): Deleted.
1557         (TestExporter._fetch_wpt_repository): Deleted.
1558         (TestExporter._ensure_new_branch_name): Deleted.
1559         (TestExporter.download_and_commit_patch): Deleted.
1560         (TestExporter.clean): Deleted.
1561         (TestExporter.create_branch_with_patch): Deleted.
1562         (TestExporter.push_to_wpt_fork): Deleted.
1563         (TestExporter.make_pull_request): Deleted.
1564         (TestExporter.create_wpt_pull_request): Deleted.
1565         (TestExporter.delete_local_branch): Deleted.
1566         (TestExporter.create_git_patch): Deleted.
1567         (TestExporter.create_upload_remote): Deleted.
1568         (TestExporter.do_export): Deleted.
1569         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1570         (TestExporterTest.MockGit):
1571         (TestExporterTest.MockGit.create_patch):
1572         (TestExporterTest.test_export):
1573         (TestExporterTest.test_export_with_specific_branch):
1574         (TestExporterTest):
1575         (TestExporterTest.test_export_interactive_mode):
1576         (TestExporterTest.test_export_invalid_token):
1577         (TestExporterTest.test_export_wrong_token):
1578         (TestExporterTest.test_has_wpt_changes):
1579         (TestExporterTest.test_has_no_wpt_changes_for_no_diff):
1580         (TestExporterTest.test_ignore_changes_to_expected_file):
1581
1582 2018-05-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1583
1584         [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser.cpp
1585         https://bugs.webkit.org/show_bug.cgi?id=186029
1586
1587         Reviewed by Alex Christensen.
1588
1589         This is a sub task of Bug 184770.
1590
1591         * MiniBrowser/win/Common.cpp:
1592         (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPreference.
1593         (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics.
1594         (AbortProc): Moved to MiniBrowser.cpp.
1595         (getPrinterDC): Ditto.
1596         (initDocStruct): Ditto.
1597         (PrintView): Ditto.
1598         (ToggleMenuFlag): Ditto.
1599         (setWindowText): Ditto.
1600         (updateStatistics): Ditto.
1601         * MiniBrowser/win/MainWindow.cpp:
1602         (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView.
1603         * MiniBrowser/win/MiniBrowser.cpp:
1604         (AbortProc): Moved from Common.cpp.
1605         (getPrinterDC): Moved from Common.cpp.
1606         (initDocStruct): Moved from Common.cpp.
1607         (setWindowText): Moved from Common.cpp.
1608         (MiniBrowser::print): Renamed from PrintView of Common.cpp.
1609         (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common.cpp.
1610         (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cpp.
1611         * MiniBrowser/win/MiniBrowser.h: Add method declarations.
1612         * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePtr typedef.
1613
1614 2018-05-29  Saam Barati  <sbarati@apple.com>
1615
1616         JSC should put bmalloc's scavenger into mini mode
1617         https://bugs.webkit.org/show_bug.cgi?id=185988
1618
1619         Reviewed by Michael Saboff.
1620
1621         This patch makes it so that we turn off the JIT when running run-testmem
1622         that way we make JSC use its mini mode.
1623
1624         * Scripts/run-testmem:
1625
1626 2018-05-29  Sihui Liu  <sihui_liu@apple.com>
1627
1628         Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
1629         https://bugs.webkit.org/show_bug.cgi?id=185835
1630         <rdar://problem/39142257>
1631
1632         Reviewed by Chris Dumez.
1633
1634         Add API test coverage.
1635
1636         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1637         (TEST):
1638
1639 2018-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1640
1641         [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
1642         https://bugs.webkit.org/show_bug.cgi?id=186042
1643         <rdar://problem/40604182>
1644
1645         Reviewed by Tim Horton.
1646
1647         Adds a new API test to check that the "significant area painting" rendering milestone is dispatched when a
1648         significant portion of the page has been painted before document load is finished.
1649
1650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1651         * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html: Added.
1652         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added.
1653         (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]):
1654         (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]):
1655         (-[RenderingProgressHandler initWithHandler:]):
1656         (-[RenderingProgressHandler _webView:renderingProgressDidChange:]):
1657         (TEST):
1658
1659 2018-05-29  Thibault Saunier  <tsaunier@igalia.com>
1660
1661         [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-system" patch
1662         https://bugs.webkit.org/show_bug.cgi?id=186040
1663
1664         The patch we merge contained a type and was merged in upstream GStreamer fixing that
1665         (s/avalaible/available/).
1666
1667         Reviewed by Xabier Rodriguez-Calvar.
1668
1669         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch:
1670
1671 2018-05-28  Sihui Liu  <sihui_liu@apple.com>
1672
1673         Add an API test to check process privilege when using Cookie API
1674         https://bugs.webkit.org/show_bug.cgi?id=185406
1675
1676         Reviewed by Geoffrey Garen.
1677
1678         Add API test coverage.
1679
1680         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1681         (TEST):
1682
1683 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
1684
1685         [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
1686         https://bugs.webkit.org/show_bug.cgi?id=185948
1687
1688         Reviewed by Xabier Rodriguez-Calvar.
1689
1690         When the patch introducing gst_protection_filter_systems_by_available_decryptors was merged, we changed sensibly its behaviour
1691         concerning the way empty results is represented (now returning NULL instead of an array of 1(NULL) element) and this change was not
1692         properly taken into account in the qtdemux patch that uses it and got upstreamed. Those 3 new patches fixe that and change the
1693         NEED_CONTEXT field names to clarify the meaning of "stream-encryption-systems".
1694
1695         * gstreamer/jhbuild.modules:
1696         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f36c4660c583a60e93
1697         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558a3e
1698         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Added.
1699
1700 2018-05-27  Dan Bernstein  <mitz@apple.com>
1701
1702         Reverted the changes made for https://webkit.org/b/186016
1703
1704         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
1705
1706 2018-05-27  Dan Bernstein  <mitz@apple.com>
1707
1708         [Cocoa] Avoid importing directly from subumbrella frameworks
1709         https://bugs.webkit.org/show_bug.cgi?id=186016
1710
1711         Reviewed by Sam Weinig.
1712
1713         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1714           LaunchServices header.
1715         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1716           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1717         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1718           when using SDKs earlier than 10.13.
1719         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1720           and OTHER_CPLUSPLUSFLAGS.
1721         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an
1722           HIToolbox header.
1723         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1724           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1725         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1726           LaunchServices header.
1727
1728 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1729
1730         [Win][MiniBrowser] Add MainWindow class
1731         https://bugs.webkit.org/show_bug.cgi?id=185814
1732
1733         Reviewed by Per Arne Vollan.
1734
1735         This is a sub task of Bug 184770. Added a new class MainWindow to
1736         represent the main window which will be shared among WK1 and WK2.
1737
1738         This change is partial so that it's easy to review this patch.
1739         I'll move more functions into MainWindow.cpp, and remove more
1740         global variables in forthcoming patches.
1741
1742         * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
1743         * MiniBrowser/win/Common.cpp: Removed MainWindow related global
1744         variables hMainWnd, hURLBarWnd, hBackButtonWnd and
1745         hForwardButtonWnd. Added a new global variable gMainWindow.
1746         (WndProc): Moved to MainWindow.cpp.
1747         (resizeSubViews): Ditto.
1748         (ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
1749         (ToggleMenuItem): Ditto.
1750         (CustomUserAgent): Follow the global variables removal.
1751         (DisplayAuthDialog): Ditto.
1752         (loadURL): Ditto.
1753         (WndProc): Renamed to MainWindow::WndProc.
1754         * MiniBrowser/win/MainWindow.cpp: Added.
1755         (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
1756         (MainWindow::init): Extracted MainWindow initialization code from wWinMain.
1757         (MainWindow::resizeSubViews): Moved from Common.cpp.
1758         (MainWindow::WndProc): Ditto.
1759         * MiniBrowser/win/MainWindow.h: Added.
1760         (MainWindow::hwnd):
1761         (MainWindow::browserWindow):
1762         * MiniBrowser/win/MiniBrowser.cpp:
1763         (MiniBrowser::init):
1764         (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
1765         (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.
1766         * MiniBrowser/win/MiniBrowser.h:
1767         * MiniBrowser/win/WinMain.cpp:
1768         (wWinMain): Extracted MainWindow initialization code into MainWindow::init.
1769         (MyRegisterClass): Moved to MainWindow.cpp.
1770
1771 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1772
1773         [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
1774         https://bugs.webkit.org/show_bug.cgi?id=185969
1775
1776         Reviewed by Alex Christensen.
1777
1778         MiniBrowser::init takes URL argument, but it's used only for
1779         loading default HTML if URL is not given.
1780
1781         - Add a new method MiniBrowser::loadHTMLString
1782         - Remove loadHTMLString process from MiniBrowser::prepareViews
1783
1784         * MiniBrowser/win/MiniBrowser.cpp:
1785         (MiniBrowser::init): Removed `requestedURL` argument.
1786         (MiniBrowser::prepareViews): Ditto.
1787         (MiniBrowser::loadHTMLString): New.
1788         (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.
1789         * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
1790         * MiniBrowser/win/WinMain.cpp:
1791         (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.
1792
1793 2018-05-27  David Kilzer  <ddkilzer@apple.com>
1794
1795         svn-apply fails when a patch has an empty file
1796         <https://webkit.org/b/29684>
1797
1798         Reviewed by Daniel Bates.
1799
1800         Prior to this change, applying the following patches resulted in:
1801         - svn: add empty file     (failure)
1802         - svn: delete empty file  (failure)
1803         - svn: rename empty file  (failure)
1804         - git: add empty file     (false-positive success)
1805         - git: delete empty file  (success)
1806         - git: rename empty file  (failure)
1807
1808         * Scripts/VCSUtils.pm:
1809         (parseSvnDiffHeader): Handle the case when there is no patch
1810         following the header.  If the file exists and is empty, that
1811         means it's a deletion.  If the file does not exist, that means
1812         it's an addition. Everything else is a fatal error.
1813         * Scripts/svn-apply:
1814         (patch):
1815         - Only apply a patch for deletion if it has one or more text
1816           chunks.
1817         - Add a case to handle adding an empty file (an addition with no
1818           text chunks), and verify the file doesn't exist yet.
1819         - Any unhandled patch is a fatal error.
1820         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1821         Add tests for adding an empty file and deleting an empty file.
1822         * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.
1823         Used by parseSvnDiffHeader.pl unit test for "add an empty file"
1824         test case.
1825
1826 2018-05-25  Aakash Jain  <aakash_jain@apple.com>
1827
1828         Display detailed error logs when a script fails in EWS
1829         https://bugs.webkit.org/show_bug.cgi?id=175696
1830         <rdar://problem/34841885>
1831
1832         Reviewed by Darin Adler.
1833
1834         * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 characters instead of default 500 characters.
1835         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto.
1836         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1837         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto.
1838         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1839         * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto.
1840
1841 2018-05-25  Daniel Bates  <dabates@apple.com>
1842
1843         test-webkitpy messages logged using __main__ logger are not displayed
1844         https://bugs.webkit.org/show_bug.cgi?id=185823
1845
1846         Rubber-stamped by Aakash Jain.
1847
1848         Configure the logger for __main__ so that messages that are logged before it parses its
1849         command line arguments are printed to standard error.
1850
1851         Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
1852         not configure a stream to use for printing until after it parses its command line arguments
1853         via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
1854         to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
1855         earlier because the latter both configures a stream and filters logged messages based on
1856         the specified verbosity. Logged messaged from code in __main__ should not be subject to
1857         such filtering. So, we explicitly configure the __main__ logger.
1858
1859         * Scripts/webkitpy/test/main.py:
1860         (main):
1861
1862 2018-05-25  Saam Barati  <sbarati@apple.com>
1863
1864         Make JSC have a mini mode that kicks in when the JIT is disabled
1865         https://bugs.webkit.org/show_bug.cgi?id=185931
1866
1867         Reviewed by Mark Lam.
1868
1869         This renames a variable for clarity.
1870
1871         * Scripts/run-testmem:
1872
1873 2018-05-25  Alex Christensen  <achristensen@webkit.org>
1874
1875         URL::host should return a StringView to reduce allocations
1876         https://bugs.webkit.org/show_bug.cgi?id=185986
1877
1878         Reviewed by Geoff Garen.
1879
1880         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1881         (TestWebKitAPI::TEST_F):
1882         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1883         (TestWebKitAPI::eq):
1884         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
1885         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1886
1887 2018-05-25  Ms2ger  <Ms2ger@igalia.com>
1888
1889         Minor improvements to wpt exporter.
1890         https://bugs.webkit.org/show_bug.cgi?id=185978
1891
1892         Reviewed by Youenn Fablet.
1893
1894         * Scripts/webkitpy/w3c/test_exporter.py:
1895         (TestExporter.push_to_wpt_fork): Update call to create_upload_remote().
1896         (TestExporter.make_pull_request): Improve the description of the created PR.
1897         (TestExporter.create_upload_remote): Always update the remote to override any obsolete state.
1898
1899 2018-05-25  Saam Barati  <sbarati@apple.com>
1900
1901         Have a memory test where we can validate JSCs mini memory mode
1902         https://bugs.webkit.org/show_bug.cgi?id=185932
1903
1904         Reviewed by Mark Lam.
1905
1906         This patch adds the run-testmem script. This runs the new testmem
1907         CLI against the contents in the testmem benchmark. The contents of testmem
1908         contain tests from ARES-6, Sunspider, Octane, and JetStream.
1909         
1910         One iteration of the benchmark comprises of running each testmem test for
1911         a certain number of iterations. We collect the peak memory usage, the memory
1912         usage after running all the iterations, and the time it takes to run all the
1913         iterations. We then run the entire benchmark 3 times over. For each test, we
1914         compute the arithmetic mean over each iteration for time, peak memory, and
1915         end memory. The benchmark then computes a time score and memory score.
1916         
1917         peak memory score = geomean({peak memory of each individual test})
1918         end memory score = geomean({end memory of each individual test})
1919         memory score = geomean({peak memory score, end memory score})
1920         time score = geomean({time score of each individual test})
1921         
1922         We want the memory score to weigh improvements to peak memory usage and
1923         memory usage at the end equally.
1924         
1925         We plan to tune this benchmark in JSC's mini mode by improving the memory
1926         score while ensuring the time score is not more than 10-15% regressed.
1927
1928         * Scripts/run-testmem: Added.
1929
1930 2018-05-25  Sihui Liu  <sihui_liu@apple.com>
1931
1932         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
1933         https://bugs.webkit.org/show_bug.cgi?id=185041
1934         <rdar://problem/34684214>
1935
1936         Reviewed by Geoffrey Garen.
1937
1938         Add API test coverage.
1939
1940         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1941         (TEST):
1942
1943 2018-05-24  Chris Dumez  <cdumez@apple.com>
1944
1945         Reduce copying of FontCascadeDescription objects by moving them around
1946         https://bugs.webkit.org/show_bug.cgi?id=185963
1947
1948         Reviewed by Simon Fraser.
1949
1950         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1951
1952         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1953         (TestWebKitAPI::TEST_F):
1954
1955 2018-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1956
1957         WebDriver: implement maximize, minimize and fullscreen window commands
1958         https://bugs.webkit.org/show_bug.cgi?id=180398
1959
1960         Reviewed by Brian Burg.
1961
1962         * Scripts/webkitpy/port/xvfbdriver.py:
1963         (XvfbDriver._setup_environ_for_test): Set UNDER_XVFB environment variable when running under Xvfb.
1964
1965 2018-05-24  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1966
1967         [GStreamer] Save some time disabling some compile options in the dependencies
1968         https://bugs.webkit.org/show_bug.cgi?id=185909
1969
1970         Reviewed by Philippe Normand.
1971
1972         * gstreamer/jhbuild.modules: Added  --disable-tests to gstreamer
1973         and --disable-examples --disable-gtk-doc to gstreamer-vaapi.
1974
1975 2018-05-23  Roy Reapor  <rreapor@apple.com>
1976
1977         Use Helvetica on build.webkit.org webpages
1978         https://bugs.webkit.org/show_bug.cgi?id=185894
1979
1980         Reviewed by Aakash Jain.
1981
1982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
1985
1986 2018-05-23  Aakash Jain  <aakash_jain@apple.com>
1987
1988         Add Buildbot configuration for Opensource EWS
1989         https://bugs.webkit.org/show_bug.cgi?id=185484
1990
1991         Rubber-stamped by Alexey Proskuryakov.
1992
1993         * BuildSlaveSupport/ews-build/config.json: Added, config file.
1994         * BuildSlaveSupport/ews-build/factories.py: Added, basic template for factories.
1995         * BuildSlaveSupport/ews-build/loadConfig.py: Added.
1996         (loadBuilderConfig): Loads the configuration.
1997         (checkValidWorker): Checks if the worker is valid.
1998         (checkValidBuilder): Checks if the builder is valid.
1999         (checkWorkersAndBuildersForConsistency): Check if workers and builders are consistent.
2000         (checkWorkersAndBuildersForConsistency._find_worker_with_name):
2001         (getBlackListedTags): Returns a list of keywords which should not be listed as tags.
2002         (getValidTags): Returns a list of valid tags.
2003         (getTagsForBuilder): Return a list of tags for given builder.
2004         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: unit-tests for loadConfig.py.
2005         * BuildSlaveSupport/ews-build/master.cfg: Configuration for buildbot.
2006
2007 2018-05-23  Michael Catanzaro  <mcatanzaro@igalia.com>
2008
2009         [GTK] Silence GCC 8 warnings
2010         https://bugs.webkit.org/show_bug.cgi?id=185556
2011
2012         Reviewed by Žan Doberšek.
2013
2014         GCC is complaining about this strncpy. It's guaranteed to be safe, because the length of
2015         source and destination are always identical. But switching to snprintf avoids the warning.
2016
2017         * DumpRenderTree/TestNetscapePlugIn/Tests/FormValue.cpp:
2018         (FormValue::NPP_GetValue):
2019
2020 2018-05-23  Ryan Haddad  <ryanhaddad@apple.com>
2021
2022         Unreviewed, rolling out r232112.
2023
2024         The tests added with this change  are failing on the bots.
2025
2026         Reverted changeset:
2027
2028         "test262/Runner.pm: add unit tests"
2029         https://bugs.webkit.org/show_bug.cgi?id=185783
2030         https://trac.webkit.org/changeset/232112
2031
2032 2018-05-23  Valerie R Young  <valerie@bocoup.com>
2033
2034         test262/Runner.pm: add unit tests
2035         https://bugs.webkit.org/show_bug.cgi?id=185783
2036
2037         Reviewed by Aakash Jain.
2038
2039         Add unit tests to be run by test-webkitperl
2040
2041         * Scripts/test262/Runner.pm:
2042         (main):
2043          - If harness files cannot be found in a custom, supplies test262 path,
2044            then sure the webkit test262 harness files.
2045          - Lazily create the test262-results directory.
2046          - If an expectation file is supplied via command line, save to the
2047            supplied location instead of the detault webkit location.
2048         (compileTest):
2049         (processResult):
2050         (getHarness):
2051         * Scripts/webkitperl/test262_unittest/README: Added.
2052         * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
2053         * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
2054         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
2055         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
2056         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
2057         (f):
2058         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
2059         * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
2060         * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
2061         (f):
2062         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.
2063
2064 2018-05-22  Roy Reapor  <rreapor@apple.com>
2065
2066         Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
2067         https://bugs.webkit.org/show_bug.cgi?id=185788
2068
2069         Reviewed by Aakash Jain.
2070
2071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2073         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
2074         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2075         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
2076         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2077         * TestResultServer/static-dashboards/run-unittests.html:
2078
2079 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
2080
2081         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
2082         https://bugs.webkit.org/show_bug.cgi?id=185831
2083
2084         Reviewed by Chris Dumez.
2085
2086         Updated the test to prevent crash after assertion fails.
2087
2088         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2089         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2090
2091 2018-05-22  Chris Dumez  <cdumez@apple.com>
2092
2093         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2094         https://bugs.webkit.org/show_bug.cgi?id=185832
2095         <rdar://problem/40307871>
2096
2097         Reviewed by Geoffrey Garen.
2098
2099         Add API test coverage.
2100
2101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2102         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
2103         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
2104         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2105         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
2106         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
2107         (TestWebKitAPI::TEST):
2108         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2109         (-[WKWebView _isBackground]):
2110
2111 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
2112
2113         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
2114         https://bugs.webkit.org/show_bug.cgi?id=185715
2115
2116         Reviewed by Geoffrey Garen.
2117
2118         Add API test coverage.
2119
2120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2121         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
2122         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2123         (TEST):
2124
2125 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
2126
2127         Unreviewed, added myself as a WebKit committer.
2128
2129         * Scripts/webkitpy/common/config/contributors.json:
2130
2131 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2132
2133         Unreviewed, rolling out r232052.
2134
2135         Breaks internal builds.
2136
2137         Reverted changeset:
2138
2139         "Use more C++17"
2140         https://bugs.webkit.org/show_bug.cgi?id=185176
2141         https://trac.webkit.org/changeset/232052
2142
2143 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
2144
2145         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
2146         https://bugs.webkit.org/show_bug.cgi?id=185689
2147
2148         Reviewed by Philippe Normand.
2149
2150         And update the patches, removing the ones that have been merged upstream.
2151
2152         * gstreamer/jhbuild.modules:
2153         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
2154         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
2155         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
2156         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
2157         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
2158         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
2159         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
2160         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
2161
2162 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2163
2164         Use more C++17
2165         https://bugs.webkit.org/show_bug.cgi?id=185176
2166
2167         Reviewed by JF Bastien.
2168
2169         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2170         * ImageDiff/cg/Configurations/Base.xcconfig:
2171         * MiniBrowser/Configurations/Base.xcconfig:
2172         * MobileMiniBrowser/Configurations/Base.xcconfig:
2173         * TestWebKitAPI/Configurations/Base.xcconfig:
2174         * WebKitTestRunner/Configurations/Base.xcconfig:
2175
2176 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2177
2178         [WinCairo] Enable WebKit build by default
2179         https://bugs.webkit.org/show_bug.cgi?id=185141
2180
2181         Reviewed by Per Arne Vollan.
2182
2183         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
2184         WebKitForwardingHeaders because config.h includes a header of WK2.
2185
2186         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
2187         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
2188
2189 2018-05-21  Jer Noble  <jer.noble@apple.com>
2190
2191         Complete fix for enabling modern EME by default
2192         https://bugs.webkit.org/show_bug.cgi?id=185770
2193         <rdar://problem/40368220>
2194
2195         Reviewed by Eric Carlson.
2196
2197         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2198
2199 2018-05-18  Christopher Reid  <chris.reid@sony.com>
2200
2201         Unreviewed, add myself as a WebKit committer.
2202
2203         * Scripts/webkitpy/common/config/contributors.json:
2204
2205 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2206
2207         Unreviewed, rolling out r222967.
2208
2209         It's not ready yet
2210
2211         Reverted changeset:
2212
2213         "[GTK][WPE] Add API to configure and enable resource load
2214         statistics"
2215         https://bugs.webkit.org/show_bug.cgi?id=177943
2216         https://trac.webkit.org/changeset/222967
2217
2218 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2219
2220         [GTK] MiniBrowser crashes when loading twice quickly
2221         https://bugs.webkit.org/show_bug.cgi?id=185763
2222
2223         Reviewed by Michael Catanzaro.
2224
2225         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
2226         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
2227         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
2228         leaked, it will crash when scheduled if the window has already been destroyed.
2229
2230         * MiniBrowser/gtk/BrowserWindow.c:
2231         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
2232
2233 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
2234
2235         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
2236         https://bugs.webkit.org/show_bug.cgi?id=185624
2237         <rdar://problem/39111626>
2238
2239         Reviewed by Chris Dumez.
2240
2241         Modified expectation to make test more robust as cookies can be returned in different orders.
2242
2243         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2244         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2245         (TEST):
2246
2247 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2248
2249         Unreviewed, rolling out r231982.
2250         https://bugs.webkit.org/show_bug.cgi?id=185793
2251
2252         Caused layout test failures (Requested by realdawei on
2253         #webkit).
2254
2255         Reverted changeset:
2256
2257         "Complete fix for enabling modern EME by default"
2258         https://bugs.webkit.org/show_bug.cgi?id=185770
2259         https://trac.webkit.org/changeset/231982
2260
2261 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
2262
2263         Handle failure to extend sandbox gracefully
2264         https://bugs.webkit.org/show_bug.cgi?id=185779
2265         <rdar://problem/40316349>
2266
2267         Unreviewed, fix test results.
2268
2269         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2270         (TEST_F):
2271
2272 2018-05-18  Jer Noble  <jer.noble@apple.com>
2273
2274         Complete fix for enabling modern EME by default
2275         https://bugs.webkit.org/show_bug.cgi?id=185770
2276         <rdar://problem/40368220>
2277
2278         Reviewed by Eric Carlson.
2279
2280         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2281
2282 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
2283
2284         Handle failure to extend sandbox gracefully
2285         https://bugs.webkit.org/show_bug.cgi?id=185779
2286         <rdar://problem/40316349>
2287
2288         Reviewed by Brent Fulgham.
2289
2290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2291         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
2292         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
2293         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2294         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2295         (MediaCaptureSimulateFailedSandbox::SetUp):
2296         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
2297         (TEST_F):
2298         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
2299
2300 2018-05-18  Daniel Bates  <dabates@apple.com>
2301
2302         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
2303         https://bugs.webkit.org/show_bug.cgi?id=185774
2304
2305         Reviewed by Andy Estes.
2306
2307         For now, the script debug-safari is not supported for WebKit for iOS. To
2308         fix this we differentiate between the Apple Mac port and Apple embedded
2309         ports.
2310
2311         * Scripts/webkitdirs.pm:
2312         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
2313         (isAppleMacWebKit): Added.
2314         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
2315         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
2316         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
2317         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
2318         (runSafari): Ditto.
2319         (runMiniBrowser): Ditto.
2320         (debugMiniBrowser): Ditto.
2321         (runWebKitTestRunner): Ditto.
2322         (debugWebKitTestRunner): Ditto.
2323
2324 2018-05-18  Antoine Quint  <graouts@apple.com>
2325
2326         [Web Animations] Turn Web Animations with CSS integration on for test runners
2327         https://bugs.webkit.org/show_bug.cgi?id=184819
2328         <rdar://problem/39597337>
2329
2330         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
2331
2332         * DumpRenderTree/TestOptions.cpp:
2333         (TestOptions::TestOptions):
2334         * DumpRenderTree/TestOptions.h:
2335         * DumpRenderTree/mac/DumpRenderTree.mm:
2336         (runTest):
2337         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
2338         * WebKitTestRunner/TestController.cpp:
2339         (WTR::TestController::resetPreferencesToConsistentValues):
2340         (WTR::updateTestOptionsFromTestHeader):
2341         * WebKitTestRunner/TestOptions.cpp:
2342         (WTR::TestOptions::TestOptions):
2343         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2344         * WebKitTestRunner/TestOptions.h:
2345
2346 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2347
2348         [Win][MiniBrowser] Create MainWindow even in transparent mode
2349         https://bugs.webkit.org/show_bug.cgi?id=185597
2350
2351         Reviewed by Per Arne Vollan.
2352
2353         The current implementations doesn't create the MainWindow in
2354         transparent mode. The screenshot is in Bug 58300.
2355
2356         There were three problems:
2357         - Can't control the WebView. ie. going backward and forward.
2358         - Can't quit the program.
2359         - It makes implementation complicated.
2360
2361         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
2362         even in the transparent mode.
2363         * MiniBrowser/win/WinMain.cpp:
2364         (wWinMain): Create the main window even in the transparent mode.
2365
2366 2018-05-18  Antoine Quint  <graouts@apple.com>
2367
2368         [Web Animations] Turn Web Animations with CSS integration on for test runners
2369         https://bugs.webkit.org/show_bug.cgi?id=184819
2370         <rdar://problem/39597337>
2371
2372         Reviewed by Jon Lee.
2373
2374         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
2375         integration flag on.
2376
2377         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
2378         comment directly at the top of the file since test runners now set the flag on by default
2379         and a dedicated directory exists for tests that need to run with this flag off.
2380
2381         * DumpRenderTree/TestOptions.cpp:
2382         (TestOptions::TestOptions):
2383         * DumpRenderTree/TestOptions.h:
2384         * DumpRenderTree/mac/DumpRenderTree.mm:
2385         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
2386         (runTest):
2387         * WebKitTestRunner/TestController.cpp:
2388         (WTR::TestController::resetPreferencesToConsistentValues):
2389         (WTR::updateTestOptionsFromTestHeader):
2390         * WebKitTestRunner/TestOptions.cpp:
2391         (WTR::isLegacyAnimationEngineTestPath):
2392         (WTR::TestOptions::TestOptions):
2393         * WebKitTestRunner/TestOptions.h:
2394
2395 2018-05-17  Nan Wang  <n_wang@apple.com>
2396
2397         AX: [macOS] Expose the primary screen height through AX API
2398         https://bugs.webkit.org/show_bug.cgi?id=185742
2399
2400         Reviewed by Chris Fleizach.
2401
2402         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2403         (attributesOfElement):
2404         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2405         (WTR::attributesOfElement):
2406
2407 2018-05-17  Commit Queue  <commit-queue@webkit.org>
2408
2409         Unreviewed, rolling out r231912.
2410         https://bugs.webkit.org/show_bug.cgi?id=185750
2411
2412         It is prompting the user when there is no WPT changes
2413         (Requested by bmac on #webkit).
2414
2415         Reverted changeset:
2416
2417         "Export changes to web-platform-test as part of the webkit-
2418         patch upload workflow"
2419         https://bugs.webkit.org/show_bug.cgi?id=184914
2420         https://trac.webkit.org/changeset/231912
2421
2422 2018-05-17  Valerie R Young  <valerie@bocoup.com>
2423
2424         test262/Runner.pm: expand $INC to find webkitdirs.pm
2425         https://bugs.webkit.org/show_bug.cgi?id=185739
2426
2427         Reviewed by Michael Saboff.
2428
2429         * Scripts/test262/Runner.pm:
2430         (getBuildPath):
2431
2432 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2433
2434         [WPE] Implement and enable FULLSCREEN_API
2435         https://bugs.webkit.org/show_bug.cgi?id=185676
2436
2437         Reviewed by Žan Doberšek.
2438
2439         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2440         (testWebViewFullScreen):
2441
2442 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
2443
2444         Export changes to web-platform-test as part of the webkit-patch upload workflow
2445         https://bugs.webkit.org/show_bug.cgi?id=184914
2446
2447         Reviewed by Youenn Fablet.
2448
2449         * Scripts/webkitpy/tool/commands/upload.py:
2450         (Upload):
2451         (CreateBug.execute):
2452         (WPTChangeExport):
2453         * Scripts/webkitpy/tool/steps/__init__.py:
2454         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
2455         (WPTChangeExport):
2456         (WPTChangeExport.options):
2457         (WPTChangeExport.run):
2458         * Scripts/webkitpy/w3c/common.py:
2459         * Scripts/webkitpy/w3c/test_exporter.py:
2460         (WebPlatformTestExporter):
2461         (WebPlatformTestExporter.__init__):
2462         (WebPlatformTestExporter.username):
2463         (WebPlatformTestExporter.token):
2464         (WebPlatformTestExporter._github):
2465         (WebPlatformTestExporter._wpt_fork_branch_github_url):
2466         (WebPlatformTestExporter._wpt_fork_remote):
2467         (WebPlatformTestExporter._wpt_fork_push_url):
2468         (WebPlatformTestExporter._git):
2469         (WebPlatformTestExporter._branch_name):
2470         (WebPlatformTestExporter._public_branch_name):
2471         (WebPlatformTestExporter.has_wpt_changes):
2472         (WebPlatformTestExporter._create_patch):
2473         (WebPlatformTestExporter.create_git_patch):
2474         (WebPlatformTestExporter._prompt_for_token):
2475         (WebPlatformTestExporter._prompt_for_username):
2476         (WebPlatformTestExporter._ensure_username_and_token):
2477         (WebPlatformTestExporter._validate_and_save_token):
2478         (WebPlatformTestExporter.push_to_wpt_fork):
2479         (WebPlatformTestExporter.make_pull_request):
2480         (WebPlatformTestExporter.delete_local_branch):
2481         (parse_args):
2482         (TestExporter): Deleted.
2483         (TestExporter.__init__): Deleted.
2484         (TestExporter._ensure_wpt_repository): Deleted.
2485         (TestExporter._fetch_wpt_repository): Deleted.
2486         (TestExporter._ensure_new_branch_name): Deleted.
2487         (TestExporter.download_and_commit_patch): Deleted.
2488         (TestExporter.clean): Deleted.
2489         (TestExporter.create_branch_with_patch): Deleted.
2490         (TestExporter.push_to_wpt_fork): Deleted.
2491         (TestExporter.make_pull_request): Deleted.
2492         (TestExporter.create_wpt_pull_request): Deleted.
2493         (TestExporter.delete_local_branch): Deleted.
2494         (TestExporter.create_git_patch): Deleted.
2495         (TestExporter.create_upload_remote_if_needed): Deleted.
2496         (TestExporter.do_export): Deleted.
2497         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
2498         (TestExporterTest.test_export):
2499         (TestExporterTest.test_export_with_specific_branch):
2500         (TestExporterTest):
2501         (TestExporterTest.test_export_interactive_mode):
2502         (TestExporterTest.test_export_invalid_token):
2503         (TestExporterTest.test_export_wrong_token):
2504
2505 2018-05-17  Valerie R Young  <valerie@bocoup.com>
2506
2507         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
2508         https://bugs.webkit.org/show_bug.cgi?id=185650
2509
2510         Reviewed by Michael Saboff.
2511
2512         First, use jsc from CLI arg, then try to use webkit-build-directory,
2513         if that doesn't work, look for jsc in the $PATH
2514
2515         * Scripts/test262/Runner.pm:
2516         (processCLI):
2517         (getBuildPath):
2518         (runTest):
2519
2520 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
2521
2522         Test262-Runner: Adds a --timeout option
2523         https://bugs.webkit.org/show_bug.cgi?id=185696
2524
2525         Reviewed by Michael Saboff.
2526
2527         The timeout option is used to set a timeout execution in ms for each test run in JSC.
2528         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
2529         * Scripts/test262/Runner.pm:
2530         (processCLI):
2531         (runTest):
2532
2533 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
2534
2535         Test262-Runner: Set timer for each test run
2536         https://bugs.webkit.org/show_bug.cgi?id=185692
2537
2538         Reviewed by Michael Saboff.
2539
2540         Sets a high resolution timer for each execution call of JSC, reporting
2541         the time in the results report to allow identifying slow tests.
2542         * Scripts/test262/Runner.pm:
2543         (main):
2544         (processFile):
2545         (runTest):
2546         (processResult):
2547
2548 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2549
2550         Add support for Intl NumberFormat formatToParts
2551         https://bugs.webkit.org/show_bug.cgi?id=185375
2552
2553         Reviewed by Yusuke Suzuki.
2554
2555         Add flag for NumberFormat formatToParts.
2556
2557         * Scripts/webkitperl/FeatureList.pm:
2558         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2559
2560 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2561
2562         [Win] Use C++17 in MSVC
2563         https://bugs.webkit.org/show_bug.cgi?id=185232
2564
2565         Reviewed by Alex Christensen.
2566
2567         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
2568         conflicts with ::byte defined in Windows' header.
2569
2570         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
2571         (WindowedPluginTest::WindowedPluginTest):
2572         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2573         (logEventProc):
2574         (stringEvent):
2575         (AccessibilityController::winNotificationReceived):
2576         * DumpRenderTree/win/TextInputController.cpp:
2577         (markedRangeCallback):
2578         (firstRectForCharacterRangeCallback):
2579         (selectedRangeCallback):
2580         * DumpRenderTree/win/TextInputController.h:
2581         * DumpRenderTree/win/TextInputControllerWin.cpp:
2582         (TextInputController::markedRange):
2583         (TextInputController::firstRectForCharacterRange):
2584         (TextInputController::selectedRange):
2585
2586 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
2587
2588         Session cookies aren't reliably set when using default WKWebSiteDataStore
2589         https://bugs.webkit.org/show_bug.cgi?id=185624
2590         <rdar://problem/39111626>
2591
2592         Reviewed by Geoffrey Garen.
2593
2594         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
2595
2596         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2597         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2598         (TEST):
2599
2600 2018-05-16  Valerie R Young  <valerie@bocoup.com>
2601
2602         test262/Runner.pm: save to supplied expectation file if supplied
2603         https://bugs.webkit.org/show_bug.cgi?id=185660
2604
2605         Reviewed by Michael Saboff.
2606
2607         * Scripts/test262/Runner.pm:
2608         (processCLI):
2609         (main):
2610
2611 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
2612
2613         Unreviewed, rolling out r231763.
2614
2615         The test added with this change is failing an assertion.
2616
2617         Reverted changeset:
2618
2619         "NSEvent event trackers don't work from WebKitTestRunner"
2620         https://bugs.webkit.org/show_bug.cgi?id=185383
2621         https://trac.webkit.org/changeset/231763
2622
2623 2018-05-15  David Kilzer  <ddkilzer@apple.com>
2624
2625         TestWebKitAPI: Fix warnings found by new clang compiler
2626         <https://webkit.org/b/185631>
2627
2628         Reviewed by Michael Catanzaro.
2629
2630         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
2631         (TestWebKitAPI::TEST):
2632         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2633         (TestWebKitAPI::TEST):
2634         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2635         (TestWebKitAPI::TEST):
2636         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2637         (TestWebKitAPI::TEST):
2638         - Add #pragma statements to ignore the new
2639           -Wself-assign-overloaded warning and to ignore
2640           this as an unknown warning on older clang versions.  We want
2641           to keep these self assigments as this code is designed to test
2642           that use case.
2643
2644         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2645         (TestWebKitAPI::didFindStringMatches):
2646         - Replace the "rect = rect;" statement that was used to avoid an
2647           unused variable warning with two expectations.
2648
2649         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2650         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
2651         - Switch from -integerValue to -unsignedIntegerValue when
2652           comparing against _WKRectEdgeAll since it's an enum declared
2653           as an NSUInteger.
2654
2655 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2656
2657         Unreviewed, rolling out r230749
2658
2659         This did not work as desired.
2660
2661         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2662         (TestWebKitAPI::TEST):
2663
2664 2018-05-15  Antoine Quint  <graouts@apple.com>
2665
2666         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2667         https://bugs.webkit.org/show_bug.cgi?id=185647
2668
2669         Reviewed by Dean Jackson.
2670
2671         Rename the Web Animations CSS integration flag.
2672
2673         * DumpRenderTree/TestOptions.cpp:
2674         (TestOptions::TestOptions):
2675         * DumpRenderTree/TestOptions.h:
2676         * DumpRenderTree/mac/DumpRenderTree.mm:
2677         (setWebPreferencesForTestOptions):
2678         * WebKitTestRunner/TestController.cpp:
2679         (WTR::TestController::resetPreferencesToConsistentValues):
2680         (WTR::updateTestOptionsFromTestHeader):
2681         * WebKitTestRunner/TestOptions.h:
2682         (WTR::TestOptions::hasSameInitializationOptions const):
2683
2684 2018-05-14  Brady Eidson  <beidson@apple.com>
2685
2686         Add an API test to guard against regressions while re-entering setDefersLoading:.
2687         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
2688
2689         Reviewed by Chris Dumez.
2690
2691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2692         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
2693         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
2694         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
2695         (-[DefersScheme initWithBytes:]):
2696         (-[DefersScheme webView:startURLSchemeTask:]):
2697         (-[DefersScheme webView:stopURLSchemeTask:]):
2698         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
2699         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2700         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
2701         (-[DoubleDefersLoadingPlugIn dealloc]):
2702
2703 2018-05-14  Daniel Bates  <dabates@apple.com>
2704
2705         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
2706         https://bugs.webkit.org/show_bug.cgi?id=185599
2707         <rdar://problem/22493890>
2708
2709         Reviewed by Simon Fraser.
2710
2711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2712         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
2713         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
2714         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
2715         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2716         (TestWebKitAPI::TEST):
2717         * TestWebKitAPI/ios/set-timeout-function.html: Added.
2718
2719 2018-05-14  Valerie R Young  <valerie@bocoup.com>
2720
2721         test262/Runner.pm: small bugs in CLI and error codes
2722         https://bugs.webkit.org/show_bug.cgi?id=185629
2723
2724         Reviewed by Michael Saboff.
2725
2726         Fix two commandline args with use '-f', correct
2727         error code of failures.
2728
2729         * Scripts/test262/Runner.pm:
2730         (processCLI):
2731         (main):
2732
2733 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
2734
2735         Disable API tests that time out after pointer poisioning was disabled.
2736         https://bugs.webkit.org/show_bug.cgi?id=185586
2737
2738         Unreviewed test gardening.
2739
2740         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2741         (TestWebKitAPI::TEST):
2742         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2743         (TestWebKitAPI::TEST):
2744         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2745         (TestWebKitAPI::TEST):
2746         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2747         (TestWebKitAPI::TEST):
2748
2749 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
2750
2751         Test262-Runner: Fix RegExp for capturing tests metadata"
2752         https://bugs.webkit.org/show_bug.cgi?id=185622
2753
2754         Reviewed by Michael Saboff.
2755
2756         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
2757         both LF and CRLF forms.
2758
2759         The fix also allows the runner to capture the proper results from two specific files using CR and
2760         CRLF line terminators. They are updated in the expectations file.
2761         * Scripts/test262/Runner.pm:
2762         (parseData):
2763
2764 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
2765
2766         NSEvent event trackers don't work from WebKitTestRunner
2767         https://bugs.webkit.org/show_bug.cgi?id=185383
2768         rdar://problem/40025045
2769
2770         Reviewed by Simon Fraser.
2771
2772         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
2773         NSEvent swipe tracking is used for webkit swipe navigation.
2774
2775         * WebKitTestRunner/mac/EventSenderProxy.mm:
2776         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2777
2778 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
2779
2780         Test262 Runner should search for the Debug JSC by default
2781         https://bugs.webkit.org/show_bug.cgi?id=185562
2782
2783         Reviewed by Michael Saboff.
2784
2785         The Test262 Runner is now searching for the Debug build of JSC by
2786         default, not the Release build.
2787
2788         This fix allows a similar call from the previous runner, making
2789         it compatible with the current build bot configuration parameters.
2790
2791         This patch also adds some minor improvements the verbose mode output.
2792
2793         * Scripts/test262/Runner.pm:
2794         (processCLI):
2795         (main):
2796         (getBuildPath):
2797         (processResult):
2798
2799 2018-05-11  Charles Vazac  <cvazac@gmail.com>
2800
2801         Runtime feature flag for Server-Timing
2802         https://bugs.webkit.org/show_bug.cgi?id=184758
2803
2804         Reviewed by Youenn Fablet.
2805
2806         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
2807         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
2808
2809 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2810
2811         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
2812         https://bugs.webkit.org/show_bug.cgi?id=185418
2813
2814         Reviewed by Alex Christensen.
2815
2816         All WK1 related code should be moved into MiniBrowser for the preparation
2817         of Bug 184770.
2818
2819         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
2820
2821         * MiniBrowser/win/Common.cpp:
2822         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
2823         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
2824         * MiniBrowser/win/Common.h: Added.
2825         * MiniBrowser/win/MiniBrowser.cpp:
2826         (MiniBrowser::init): Moved the initilization code from wWinMain.
2827         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
2828         * MiniBrowser/win/MiniBrowser.h:
2829         (MiniBrowser::setCacheFolder): Changed to a private method.
2830         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
2831         * MiniBrowser/win/WinMain.cpp:
2832         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
2833
2834 2018-05-11  Brady Eidson  <beidson@apple.com>
2835
2836         Make sure history navigations reuse the existing process when necessary.
2837         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
2838
2839         Reviewed by Ryosuke Niwa.
2840
2841         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2842
2843 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2844
2845         [JSC][GLIB] Add introspectable alternatives to functions using vargars
2846         https://bugs.webkit.org/show_bug.cgi?id=185508
2847
2848         Reviewed by Michael Catanzaro.
2849
2850         Add test cases for the new API.
2851
2852         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2853         (testJSCFunction):
2854         (testJSCObject):
2855
2856 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
2857
2858         [Build Bot] Restore configuration options to the Test262 Runner
2859
2860         During the switch from the previous Test262 runner to the new one,
2861         a call for an extra configurations options got removed.
2862
2863         This call is important to inform the script to find the debug or
2864         release build of JSC. It's being restored in this patch.
2865
2866         https://bugs.webkit.org/show_bug.cgi?id=185513
2867
2868         Reviewed by Yusuke Suzuki.
2869
2870         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2871         (RunTest262Tests):
2872
2873 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
2874
2875         REGRESSION (r230998): Cannot stream API test output
2876         https://bugs.webkit.org/show_bug.cgi?id=185090
2877
2878         Reviewed by Ryosuke Niwa.
2879
2880         Change run-api-tests so that the stdout and stderr of a test will be printed
2881         before it's result. If -v is passed, the output of single test runs will be
2882         streamed. 
2883
2884         * Scripts/webkitpy/api_tests/run_api_tests.py:
2885         (run): Use print_timestamps flag.
2886         (parse_args): Add timestamps option to print timestamps in the log.
2887         * Scripts/webkitpy/api_tests/runner.py:
2888         (Runner): Add running status.
2889         (Runner.__init__): Add number of workers and a flag to detect if a newline
2890         is needed at the beginning of a log line.
2891         (Runner.run): Turn off most logging coming from server process since it is
2892         not constructive for API tests.
2893         (Runner.handle): Add new log message to stream stdout and stderr instead of
2894         caching values until the test run finished.
2895         (_Worker._run_single_test): Log stdout and stderr in real time.
2896         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
2897         the test.
2898         (_Worker.post): Provide a post with explicitly enumerated argument names.
2899         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2900         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
2901         (MeteredStream.write): Allow for verbose logging without timestamps.
2902         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2903         (RegularTest): Add print_timestamps flag.
2904         (RegularTest.setUp):
2905         (RegularTest.test_logging_not_included):
2906         (VerboseTest.test_log_args):
2907         (VerboseWithOutTimestamp):
2908         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
2909
2910 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
2911
2912         build-webkit can erroneously warn about Xcode being too old
2913         https://bugs.webkit.org/show_bug.cgi?id=185533
2914
2915         Reviewed by Dan Bernstein.
2916
2917         Don't assume the version number is always a single digit.
2918
2919         * Scripts/webkitdirs.pm:
2920         (determineXcodeVersion):
2921
2922 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
2923
2924         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
2925         https://bugs.webkit.org/show_bug.cgi?id=185528
2926
2927         Reviewed by Lucas Forschler.
2928
2929         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2930         (TestFactory.__init__):
2931         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2932         (InstallWinCairoDependencies):
2933
2934 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2935
2936         Fix some -Wstring-op-truncation warnings
2937         https://bugs.webkit.org/show_bug.cgi?id=185496
2938
2939         Reviewed by Alex Christensen.
2940
2941         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
2942         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
2943         set the last bucket to NUL.
2944
2945         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2946         (TestWebKitAPI::testAtomicStringNumber):
2947         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2948         (TestWebKitAPI::testStringNumberFixedPrecision):
2949         (TestWebKitAPI::testStringNumberFixedWidth):
2950         (TestWebKitAPI::testStringNumber):
2951
2952 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2953
2954         [Win][MiniBrowser] Add a separate WndProc for the layered window
2955         https://bugs.webkit.org/show_bug.cgi?id=185460
2956
2957         Reviewed by Brent Fulgham.
2958
2959         All WK1 related code should be moved into MiniBrowser for the
2960         preparation of Bug 184770.
2961
2962         The layered window was using WndProc of the main window. The
2963         layered window is specific only for WK1. the main window will be
2964         shared among WK1 and WK2.
2965
2966         This change add a new WndProc for the layer window.
2967
2968         * MiniBrowser/win/Common.cpp:
2969         (WndProc): Removed code for the layered windows.
2970         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
2971         * MiniBrowser/win/MiniBrowser.cpp:
2972         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
2973         (viewWndProc): New WndProc for the layered windows.
2974         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
2975         * MiniBrowser/win/MiniBrowser.h:
2976         (MiniBrowser::hwnd):
2977         * MiniBrowser/win/WinMain.cpp:
2978         (wWinMain): Added m_viewWnd.
2979
2980 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
2981
2982         Support --verbose in run-javascriptcore-tests
2983         https://bugs.webkit.org/show_bug.cgi?id=185492
2984
2985         Reviewed by Daniel Bates.
2986
2987         * Scripts/run-javascriptcore-tests:
2988         (runJSCStressTests):
2989
2990 2018-05-10  Valerie R Young  <valerie@bocoup.com>
2991
2992         test262/Runner.pm: --failing-files uses results file not expectations
2993         https://bugs.webkit.org/show_bug.cgi?id=185395
2994
2995         Reviewed by Michael Saboff.
2996
2997         --failing-files arg now uses results file to find failing tests
2998         to rerun. It will look in the test262-results directory from whereever
2999         the script is run, or a results.yaml file can be supplied via command
3000         line argument.
3001         --expectations arg added for suppling expectation file.
3002
3003         * Scripts/test262/Runner.pm:
3004         (processCLI):
3005         (main):
3006         (loadImportFile):
3007         (findAllFailing):
3008
3009 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3010
3011         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
3012         https://bugs.webkit.org/show_bug.cgi?id=185506
3013
3014         Reviewed by Philippe Normand.
3015
3016         Useful for testing and debugging.
3017
3018         * MiniBrowser/gtk/main.c:
3019         (main):
3020
3021 2018-05-09  Chris Dumez  <cdumez@apple.com>
3022
3023         Unreviewed Windows build fix after r231622.
3024
3025         * DumpRenderTree/win/DumpRenderTree.cpp:
3026         (enableExperimentalFeatures):
3027
3028 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
3029
3030         Update WebKit.WebsiteDataStoreCustomPaths after r231536
3031         https://bugs.webkit.org/show_bug.cgi?id=185486
3032         <rdar://problem/37214391>
3033
3034         Reviewed by Chris Dumez.
3035
3036         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
3037
3038         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3039         (TEST):
3040
3041 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
3042
3043         Test262-Runner: Improve the verbose output
3044         https://bugs.webkit.org/show_bug.cgi?id=185491
3045
3046         Reviewed by Michael Saboff.
3047
3048         * Scripts/test262/Import.pm:
3049         (transferFiles):
3050         * Scripts/test262/Runner.pm:
3051         (processResult):
3052
3053 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
3054
3055         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
3056         https://bugs.webkit.org/show_bug.cgi?id=185488
3057
3058         Reviewed by Michael Saboff.
3059
3060         * Scripts/test262/Runner.pm:
3061         (processCLI):
3062         (getBuildPath):
3063         (runTest):
3064
3065 2018-05-09  Richard Houle  <rhoule@apple.com>
3066
3067         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
3068         https://bugs.webkit.org/show_bug.cgi?id=185260
3069         <rdar://problem/39290394>
3070
3071         Reviewed by Tim Horton.
3072
3073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3074         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
3075         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
3076         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
3077         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3078         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3079
3080 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
3081
3082         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
3083         https://bugs.webkit.org/show_bug.cgi?id=185481
3084
3085         Reviewed by Philippe Normand.
3086
3087         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
3088
3089         * Scripts/webkitpy/port/gtk.py:
3090         (GtkPort.setup_environ_for_server):
3091
3092 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
3093
3094         Set build.webkit.org to use the new Test262-runner
3095         https://bugs.webkit.org/show_bug.cgi?id=184933
3096
3097         Reviewed by Aakash Jain.
3098
3099         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3100         (RunTest262Tests):
3101         (RunTest262Tests.countFailures):
3102         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3103
3104 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3105
3106         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
3107         https://bugs.webkit.org/show_bug.cgi?id=185461
3108
3109         Reviewed by Michael Catanzaro.
3110
3111         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
3112
3113         * gtk/jhbuild.modules:
3114
3115 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3116
3117         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
3118
3119         * wpe/manifest.txt.in: Distribute the NEWS.
3120
3121 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3122
3123         [WPE] Build cleanly with GCC 8 and ICU 60
3124         https://bugs.webkit.org/show_bug.cgi?id=185462
3125
3126         Reviewed by Carlos Alberto Lopez Perez.
3127
3128         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
3129         sure why this was never noticed until now or why the bots are OK.
3130         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
3131         * gtk/patches/glib-cast-function-type.patch: Added.
3132         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
3133         * wpe/patches/glib-cast-function-type.patch: Added.
3134
3135 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3136
3137         [JSC][GTK][JSCONLY] Use capstone disassembler
3138         https://bugs.webkit.org/show_bug.cgi?id=185283
3139
3140         Reviewed by Michael Catanzaro.
3141
3142         * gtk/manifest.txt.in:
3143         * wpe/manifest.txt.in:
3144
3145 2018-05-09  Antti Koivisto  <antti@apple.com>
3146
3147         Add OptionSet::operator& and operator bool
3148         https://bugs.webkit.org/show_bug.cgi?id=185306
3149
3150         Reviewed by Anders Carlsson.
3151
3152         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
3153         (TestWebKitAPI::TEST):
3154
3155 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3156
3157         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
3158         https://bugs.webkit.org/show_bug.cgi?id=185340
3159
3160         Reviewed by Tim Horton.
3161
3162         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
3163         non-empty text in a contenteditable.
3164
3165         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3166         (TestWebKitAPI::TEST):
3167
3168 2018-05-08  Valerie R Young  <valerie@bocoup.com>
3169
3170         test262/Runner.pm: create results dir for results of test262 run
3171         https://bugs.webkit.org/show_bug.cgi?id=185392
3172
3173         Reviewed by Michael Saboff.
3174
3175         New directory test262-results created from where ever script is
3176         called.
3177
3178         * Scripts/test262/Runner.pm:
3179         (processCLI):
3180
3181 2018-05-08  Valerie R Young  <valerie@bocoup.com>
3182
3183         test262/Runner.pm: lower number of processes per core
3184         https://bugs.webkit.org/show_bug.cgi?id=185426
3185
3186         Reviewed by Michael Saboff.
3187
3188         * Scripts/test262/Runner.pm:
3189         (getProcesses):
3190
3191 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
3192
3193         Test262-Runner: Add base Perl UnicodeData
3194         https://bugs.webkit.org/show_bug.cgi?id=185444
3195
3196         Reviewed by Michael Saboff.
3197
3198         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
3199         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
3200
3201 2018-05-08  Daniel Bates  <dabates@apple.com>
3202
3203         Add tests to ensure that the Strong Password appearance is removed on form reset
3204         https://bugs.webkit.org/show_bug.cgi?id=185440
3205
3206         Reviewed by Ryosuke Niwa.
3207
3208         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
3209         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
3210         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3211         (TEST):
3212
3213 2018-05-08  Daniel Bates  <dabates@apple.com>
3214
3215         Resign Strong Password appearance when text field value changes
3216         https://bugs.webkit.org/show_bug.cgi?id=185433
3217         <rdar://problem/39958508>
3218
3219         Reviewed by Ryosuke Niwa.
3220
3221         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
3222         when the field has the Strong Password button and its value changes.
3223
3224         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3225         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3226         (TEST):
3227
3228 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
3229
3230         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
3231         https://bugs.webkit.org/show_bug.cgi?id=185365
3232
3233         Reviewed by Saam Barati.
3234         
3235         Make it possible to measure compile times.
3236         
3237         Rolling back in after fixing cloop builds.
3238
3239         * Scripts/run-jsc-benchmarks:
3240
3241 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3242
3243         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
3244         https://bugs.webkit.org/show_bug.cgi?id=185414
3245
3246         Reviewed by Tim Horton.
3247
3248         Adjust a test expectation to check that the resulting DOM contains an attachment element,
3249         anchor element, and another attachment element in that order. This ensures that the test
3250         still passes, even after the anchor element is followed by a line break.
3251
3252         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3253         (TestWebKitAPI::TEST):
3254
3255 2018-05-08  Commit Queue  <commit-queue@webkit.org>
3256
3257         Unreviewed, rolling out r231491.
3258         https://bugs.webkit.org/show_bug.cgi?id=185434
3259
3260         Setting the Created key on a cookie does not work yet, due a
3261         bug in CFNetwork (Requested by ggaren on #webkit).
3262
3263         Reverted changeset:
3264
3265         "[WKHTTPCookieStore getAllCookies] returns inconsistent
3266         creation time"
3267         https://bugs.webkit.org/show_bug.cgi?id=185041
3268         https://trac.webkit.org/changeset/231491
3269
3270 2018-05-08  Valerie R Young  <valerie@bocoup.com>
3271
3272         test262/Runner.pm: move input files to JSTests/test262
3273         https://bugs.webkit.org/show_bug.cgi?id=185389
3274
3275         Reviewed by Michael Saboff.
3276
3277         * Scripts/test262/Runner.pm:
3278         (processCLI):
3279
3280 2018-05-08  Chris Dumez  <cdumez@apple.com>
3281
3282         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
3283
3284         * Scripts/webkitpy/performance_tests/perftest.py:
3285         (PerfTest):
3286
3287 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
3288
3289         Unreviewed, rolling out r231468.
3290
3291         Broke the CLoop build
3292
3293         Reverted changeset:
3294
3295         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
3296         any abstract values"
3297         https://bugs.webkit.org/show_bug.cgi?id=185365
3298         https://trac.webkit.org/changeset/231468
3299
3300 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
3301
3302         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
3303         https://bugs.webkit.org/show_bug.cgi?id=185041
3304         <rdar://problem/34684214>
3305
3306         Reviewed by Geoffrey Garen.
3307
3308         Add API test Coverage.
3309
3310         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3311         (TEST):
3312
3313 2018-05-08  Chris Dumez  <cdumez@apple.com>
3314
3315         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
3316
3317         * Scripts/webkitpy/performance_tests/perftest.py:
3318         (PerfTest):
3319
3320 2018-05-08  Chris Dumez  <cdumez@apple.com>
3321
3322         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
3323
3324         * Scripts/webkitpy/performance_tests/perftest.py:
3325         (PerfTest):
3326
3327 2018-05-07  Chris Dumez  <cdumez@apple.com>
3328
3329         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
3330
3331         * Scripts/webkitpy/performance_tests/perftest.py:
3332         (PerfTest):
3333
3334 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
3335
3336         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
3337         https://bugs.webkit.org/show_bug.cgi?id=185365
3338
3339         Reviewed by Saam Barati.
3340         
3341         Make it possible to measure compile times.
3342
3343         * Scripts/run-jsc-benchmarks:
3344
3345 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
3346
3347         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
3348         https://bugs.webkit.org/show_bug.cgi?id=185390
3349
3350         Reviewed by Michael Saboff.
3351
3352         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
3353
3354 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
3355
3356         Check for com.apple.datamigrator before declaring simulators booted
3357         https://bugs.webkit.org/show_bug.cgi?id=185315
3358         <rdar://problem/39986261>
3359
3360         Reviewed by David Kilzer.
3361
3362         * Scripts/webkitdirs.pm:
3363         (waitUntilProcessNotRunning): Wait until a process is not found.
3364         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
3365         a simulator booted.
3366         * Scripts/webkitpy/common/system/executive_mock.py:
3367         (MockExecutive2.__init__): Define _running_pids.
3368         * Scripts/webkitpy/xcode/simulated_device.py:
3369         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
3370         declaring that devices have been booted, increase the timeout since data migration will frequently
3371         take longer than 60 seconds, especially with multiple simulators booting.
3372         (SimulatedDeviceManager.swap): Ditto.
3373         (SimulatedDeviceManager):
3374         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
3375         processes running.
3376
3377 2018-05-07  Daniel Bates  <dabates@apple.com>
3378
3379         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
3380         https://bugs.webkit.org/show_bug.cgi?id=185054
3381         <rdar://problem/39773209>
3382
3383         Reviewed by Ryosuke Niwa.
3384
3385         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
3386
3387         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
3388         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
3389         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
3390         tests for the port.
3391
3392         * Scripts/webkitpy/port/mac.py:
3393         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
3394         have Apple Additions.
3395         * Scripts/webkitpy/port/mac_unittest.py:
3396         (MacTest.test_factory_with_future_version): Added.
3397         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
3398         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
3399         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
3400         is absent.
3401
3402 2018-05-07  Brian Burg  <bburg@apple.com>
3403
3404         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
3405         https://bugs.webkit.org/show_bug.cgi?id=184861
3406         <rdar://problem/39153768>
3407
3408         Reviewed by Timothy Hatcher.
3409
3410         Add a new test that checks whether a new process is used for navigation when
3411         an Inspector is shown. Also check that the behavior reverts to normal after
3412         the Inspector has been closed.
3413
3414         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3415
3416 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3417
3418         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
3419         https://bugs.webkit.org/show_bug.cgi?id=185289
3420         <rdar://problem/35756912>
3421
3422         Reviewed by Tim Horton and Darin Adler.
3423
3424         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
3425         sessions.
3426
3427         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3428         (TestWebKitAPI::TEST):
3429
3430 2018-05-04  Timothy Hatcher  <timothy@apple.com>
3431
3432         Deprecate legacy WebView and friends
3433         https://bugs.webkit.org/show_bug.cgi?id=185279
3434         rdar://problem/33268700
3435
3436         Reviewed by Tim Horton.
3437
3438         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
3439         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
3440
3441 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
3442
3443         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
3444         https://bugs.webkit.org/show_bug.cgi?id=185314
3445
3446         Reviewed by Michael Saboff.
3447
3448         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
3449
3450 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
3451
3452         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
3453         https://bugs.webkit.org/show_bug.cgi?id=184196
3454         <rdar://problem/39054481>
3455
3456         Reviewed by Tim Horton.
3457
3458         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
3459         earlier than 11.3. Also re-enables these tests.
3460
3461         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3462         (TestWebKitAPI::TEST):
3463         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
3464         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
3465
3466 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
3467
3468         Text shaping in the simple path is flipped in the y direction
3469         https://bugs.webkit.org/show_bug.cgi?id=185062
3470         <rdar://problem/39778678>
3471
3472         Reviewed by Simon Fraser.
3473
3474         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
3475
3476         * Scripts/webkitpy/common/config/contributors.json:
3477
3478 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
3479
3480         Test262-Runner: place the processCLI inside the main call
3481         https://bugs.webkit.org/show_bug.cgi?id=185304
3482
3483         Reviewed by Michael Saboff.
3484
3485         * Scripts/test262/Runner.pm:
3486         (main):
3487
3488 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3489
3490         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
3491         https://bugs.webkit.org/show_bug.cgi?id=174730
3492
3493         Reviewed by Michael Catanzaro.
3494
3495         Update unit tests to check that User-Agent header is included in HTTP download requests.
3496
3497         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3498         (testDownloadRemoteFile):
3499         (testWebViewDownloadURI):
3500         (testPolicyResponseDownload):
3501         (testPolicyResponseDownloadCancel):
3502         (testDownloadMIMEType):
3503         (testContextMenuDownloadActions):
3504
3505 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
3506
3507         [WinCairo] Test archive must use Python zipfile, just like build product.
3508         https://bugs.webkit.org/show_bug.cgi?id=185265
3509
3510         Reviewed by Per Arne Vollan.
3511
3512         * BuildSlaveSupport/test-result-archive:
3513         (archive_test_results):
3514         Copy over Win32-oriented archiving logic from built-product-archive.
3515
3516 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
3517
3518         cleanup modules usage for the Test262-Runner
3519         https://bugs.webkit.org/show_bug.cgi?id=185263
3520
3521         Reviewed by Michael Saboff.
3522
3523         * Scripts/test262-runner:
3524         * Scripts/test262/Runner.pm:
3525         (processCLI):
3526
3527 2018-05-03  Valerie R Young  <valerie@bocoup.com>
3528
3529         test262/Runner.pm: minor fixes
3530         https://bugs.webkit.org/show_bug.cgi?id=185250
3531
3532         Reviewed by Michael Saboff.
3533
3534         Add comments, change output and fix bug: unintended interpolation
3535         of filename when running jsc.
3536
3537         * Scripts/test262/Runner.pm:
3538         (processCLI):
3539         (main):
3540         (runTest):
3541
3542 2018-05-03  Chris Dumez  <cdumez@apple.com>
3543
3544         Load hangs if the WebProcess fails to launch
3545         https://bugs.webkit.org/show_bug.cgi?id=185225
3546         <rdar://problem/38249058>
3547
3548         Reviewed by Geoff Garen.
3549
3550         Add API test coverage.
3551
3552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3553         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
3554         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
3555         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
3556         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3557         (TEST):
3558
3559 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
3560
3561         [WinCairo] Add JSC test bots
3562         https://bugs.webkit.org/show_bug.cgi?id=185234
3563
3564         Reviewed by Per Arne Vollan.
3565
3566         * BuildSlaveSupport/build.webkit.org-config/config.json:
3567         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3568         (RunJavaScriptCoreTests.start):
3569
3570 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3571
3572         WebKit should send fake macOS user agent to docs.google.com
3573         https://bugs.webkit.org/show_bug.cgi?id=185165
3574
3575         Reviewed by Carlos Garcia Campos.
3576
3577         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3578         (TestWebKitAPI::TEST):
3579
3580 2018-05-03  Valerie R Young  <valerie@bocoup.com>
3581
3582         test262/Runner.pm: performance improvements
3583         https://bugs.webkit.org/show_bug.cgi?id=185202
3584
3585         Reviewed by Michael Saboff.
3586
3587         Batch the tests by the number of processes, and give each process
3588         a file to save results to to avoid threading. Do not parallelize
3589         when running small sets of tests.
3590
3591         * Scripts/test262/Runner.pm:
3592         (processCLI):
3593         (main):
3594         (processFile):
3595         (processResult):
3596
3597 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
3598
3599         Unreviewed, rolling out r231253.
3600
3601         The API test added with this change is crashing on the bots.
3602
3603         Reverted changeset:
3604
3605         "Web Inspector: opt out of process swap on navigation if a Web
3606         Inspector frontend is connected"
3607         https://bugs.webkit.org/show_bug.cgi?id=184861
3608         https://trac.webkit.org/changeset/231253
3609
3610 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3611