[GTK] Add initial WebKitWebsiteDataManager API for process configuration options
[WebKit-https.git] / Tools / ChangeLog
1 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
4         https://bugs.webkit.org/show_bug.cgi?id=146149
5
6         Reviewed by Sergio Villar Senin.
7
8         Update unit tests to use WebKitWebsiteDataManager.
9
10         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
11         (testWebContextConfiguration):
12         (serverCallback):
13         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
14         (Test::Test): Use WebKitWebsiteDataManager and set all possible
15         values to ensure unit tests don't write outside the temporary directory.
16         (Test::~Test): Explicitly reset the web context to ensure its
17         objects are released before the leaks check.
18         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
19         (WebViewTest::wait): Fix the GSource used, since we are receiving
20         a double in seconds, but using g_timeout_add_seconds() that
21         expects an unsigned in seconds. Use GMainLoopSource to correctly
22         handle the value and simplify the code.
23
24 2015-06-24  Jason Marcell  <jmarcell@apple.com>
25
26         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
27         https://bugs.webkit.org/show_bug.cgi?id=146126
28         <rdar://problem/18226291>
29
30         Reviewed by Alexey Proskuryakov.
31
32         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
33         (documentReady): Using combined queues to display iOS projects
34
35 2015-06-24  Doug Russell  <d_russell@apple.com>
36
37         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
38         when posting a selection notification when on the border between two accessibilityObjects
39         https://bugs.webkit.org/show_bug.cgi?id=146177
40
41         Reviewed by Darin Adler.
42
43         Add support for mapping WebCore Accessibility types into JSValueRef types
44         so they can be used in tests.
45
46         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
47         (webAccessibilityObjectWrapperClass):
48         (-[AccessibilityNotificationHandler startObserving]):
49         (makeValueRefForValue):
50         (makeArrayRefForArray):
51         (makeObjectRefForDictionary):
52         (-[AccessibilityNotificationHandler _notificationReceived:]):
53         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
54         (webAccessibilityObjectWrapperClass):
55         (-[AccessibilityNotificationHandler startObserving]):
56         (makeValueRefForValue):
57         (makeArrayRefForArray):
58         (makeObjectRefForDictionary):
59         (-[AccessibilityNotificationHandler _notificationReceived:]):
60
61 2015-06-24  Zalan Bujtas  <zalan@apple.com>
62
63         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
64         https://bugs.webkit.org/show_bug.cgi?id=146273
65         rdar://problem/18509840
66
67         Reviewed by Simon Fraser.
68
69         Due to the floating point approximate representation, we can't always produce
70         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
71         and by changing the rounding in roundToDevicePixel() from float to double.
72
73         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
74         (TestWebKitAPI::TEST):
75
76 2015-06-24  Brady Eidson  <beidson@apple.com>
77
78         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
79         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
80
81         Reviewed by Alex Christensen.
82
83         - Update WKTR to the new client structure.
84         - Update existing TestWebKitAPI tests to either use the new client structure or
85           assign the old function signature to the updated variable name.
86         - Include a new test.
87
88         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
89
90         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
91         (TestWebKitAPI::runJavaScriptAlert):
92
93         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
94         (TestWebKitAPI::TEST):
95
96         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
97         (TestWebKitAPI::analyzeDialogArguments):
98         (TestWebKitAPI::runJavaScriptAlert):
99         (TestWebKitAPI::runJavaScriptConfirm):
100         (TestWebKitAPI::runJavaScriptPrompt):
101         (TestWebKitAPI::createNewPage):
102         (TestWebKitAPI::TEST):
103
104         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
105         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
106
107         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
108         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
109
110         * WebKitTestRunner/TestController.cpp:
111         (WTR::TestController::createOtherPage):
112         (WTR::TestController::createWebViewWithOptions):
113
114 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
115
116         Refactoring benchmark runner script to follow pep8 code style.
117         https://bugs.webkit.org/show_bug.cgi?id=146264
118
119         Reviewed by Ryosuke Niwa.
120
121         Refactor benchmark runner script to follow pep8 code style.
122
123         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
124         (GenericBenchmarkBuilder.prepare):
125         (GenericBenchmarkBuilder._run_create_script):
126         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
127         (GenericBenchmarkBuilder._fetch_remote_archive):
128         (GenericBenchmarkBuilder):
129         (GenericBenchmarkBuilder._checkout_with_subversion):
130         (GenericBenchmarkBuilder._apply_patch):
131         (GenericBenchmarkBuilder.clean):
132         (GenericBenchmarkBuilder._runCreateScript): Deleted.
133         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
134         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
135         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
136         (GenericBenchmarkBuilder._applyPatch): Deleted.
137         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
138         (BenchmarkRunner.__init__):
139         (BenchmarkRunner._find_plan_file):
140         (BenchmarkRunner.execute):
141         (BenchmarkRunner._cleanup):
142         (BenchmarkRunner._dump):
143         (BenchmarkRunner._wrap):
144         (BenchmarkRunner._merge):
145         (BenchmarkRunner._show_results):
146         (BenchmarkRunner._findPlanFile): Deleted.
147         (BenchmarkRunner.cleanup): Deleted.
148         (BenchmarkRunner.dump): Deleted.
149         (BenchmarkRunner.wrap): Deleted.
150         (BenchmarkRunner.merge): Deleted.
151         (BenchmarkRunner.show_results): Deleted.
152         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
153         (BrowserDriver.prepare_env):
154         (BrowserDriver.launch_url):
155         (BrowserDriver.close_browsers):
156         (BrowserDriver.prepareEnv): Deleted.
157         (BrowserDriver.launchUrl): Deleted.
158         (BrowserDriver.closeBrowser): Deleted.
159         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
160         (OSXBrowserDriver):
161         (OSXBrowserDriver.prepare_env):
162         (OSXBrowserDriver.close_browsers):
163         (OSXBrowserDriver._launch_process):
164         (OSXBrowserDriver._terminiate_processes):
165         (OSXBrowserDriver._launch_process_with_caffinate):
166         (OSXBrowserDriver._screen_size):
167         (OSXBrowserDriver.prepareEnv): Deleted.
168         (OSXBrowserDriver.closeBrowsers): Deleted.
169         (OSXBrowserDriver.launchProcess): Deleted.
170         (OSXBrowserDriver.terminateProcesses): Deleted.
171         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
172         (OSXBrowserDriver.screenSize): Deleted.
173         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
174         (OSXChromeDriver):
175         (OSXChromeDriver.launch_url):
176         (OSXChromeCanaryDriver):
177         (OSXChromeCanaryDriver.launch_url):
178         (OSXChromeDriver.launchUrl): Deleted.
179         (OSXChromeCanaryDriver.launchUrl): Deleted.
180         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
181         (OSXFirefoxDriver):
182         (OSXFirefoxDriver.launch_url):
183         (OSXFirefoxNightlyDriver):
184         (OSXFirefoxNightlyDriver.launch_url):
185         (OSXFirefoxDriver.launchUrl): Deleted.
186         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
187         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
188         (OSXSafariDriver):
189         (OSXSafariDriver.prepare_env):
190         (OSXSafariDriver.launch_url):
191         (OSXSafariDriver.close_browsers):
192         (OSXSafariDriver._maximize_window):
193         (OSXSafariDriver.prepareEnv): Deleted.
194         (OSXSafariDriver.launchUrl): Deleted.
195         (OSXSafariDriver.closeBrowsers): Deleted.
196         (OSXSafariDriver.maximizeWindow): Deleted.
197         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
198         (HTTPServerDriver.fetch_result):
199         (HTTPServerDriver.kill_server):
200         (HTTPServerDriver.get_return_code):
201         (HTTPServerDriver.set_device_id):
202         (HTTPServerDriver.fetchResult): Deleted.
203         (HTTPServerDriver.killServer): Deleted.
204         (HTTPServerDriver.getReturnCode): Deleted.
205         (HTTPServerDriver.setDeviceID): Deleted.
206         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
207         (SimpleHTTPServerDriver.serve):
208         (SimpleHTTPServerDriver.base_url):
209         (SimpleHTTPServerDriver.fetch_result):
210         (SimpleHTTPServerDriver.kill_server):
211         (SimpleHTTPServerDriver.get_return_code):
212         (SimpleHTTPServerDriver): Deleted.
213         (SimpleHTTPServerDriver.baseUrl): Deleted.
214         (SimpleHTTPServerDriver.fetchResult): Deleted.
215         (SimpleHTTPServerDriver.killServer): Deleted.
216         (SimpleHTTPServerDriver.getReturnCode): Deleted.
217         * Scripts/webkitpy/benchmark_runner/utils.py:
218         (get_path_from_project_root):
219         (force_remove):
220         (getPathFromProjectRoot): Deleted.
221         (forceRemove): Deleted.
222
223 2015-06-23  Anders Carlsson  <andersca@apple.com>
224
225         Add operator! and copy/move constructors to WeakObjCPtr
226         https://bugs.webkit.org/show_bug.cgi?id=146255
227
228         Reviewed by Andreas Kling.
229
230         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
231         (TEST):
232
233 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
234
235         Expose some more rendering progress events, and have MiniBrowser log for each of them
236         https://bugs.webkit.org/show_bug.cgi?id=146227
237
238         Reviewed by Darin Adler.
239
240         Register for layout milestones/rendering progress events in the WK1 and WK2
241         browser window controllers, and, if logging is turned on, log when they are
242         reached.
243
244         * MiniBrowser/mac/WK1BrowserWindowController.m:
245         (-[WK1BrowserWindowController awakeFromNib]):
246         (-[WK1BrowserWindowController webView:didLayout:]):
247         * MiniBrowser/mac/WK2BrowserWindowController.m:
248         (-[WK2BrowserWindowController awakeFromNib]):
249         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
250
251 2015-06-23  Brady Eidson  <beidson@apple.com>
252
253         WKFrameInfo should have an accessor for the Frame's current security origin.
254         https://bugs.webkit.org/show_bug.cgi?id=146162
255
256         Reviewed by Dan Bernstein.
257
258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
259         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
260         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
261         (sawDialog):
262         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
263         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
264         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
265         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
266         (TEST):
267
268 2015-06-23  Tanay C  <tanay.c@samsung.com>
269
270         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
271         https://bugs.webkit.org/show_bug.cgi?id=146007
272
273         Reviewed by Darin Adler.
274
275         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
276         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
277         (pluginLogWithWindowObject):
278         (pluginLogWithArguments):
279         (pluginLog):
280         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
281         (PluginTest::executeScript):
282         (PluginTest::log):
283
284 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
285
286         [EFL] Add libhyphen-dev as dependency after r185862
287         https://bugs.webkit.org/show_bug.cgi?id=146230
288
289         Reviewed by Gyuyoung Kim.
290
291         * efl/install-dependencies:
292
293 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
294
295         [EFL] Hyphenation is not supported
296         https://bugs.webkit.org/show_bug.cgi?id=89830
297
298         Reviewed by Gyuyoung Kim.
299
300         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
301
302 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
303
304         Get rid of factory json files in benchmark_runner
305         https://bugs.webkit.org/show_bug.cgi?id=146175
306
307         Reviewed by Ryosuke Niwa.
308
309         Get rid of factory json files in benchmark_runner and refactoring the code.
310
311         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
312         (benchmark_builder_loader):
313         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
314         (BenchmarkBuilderFactory):
315         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
316         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
317         (GenericBenchmarkBuilder):
318         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
319         (BenchmarkRunner.__init__):
320         (BenchmarkRunner.execute):
321         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
322         (browser_driver_loader):
323         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
324         (BrowserDriver):
325         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
326         (BrowserDriverFactory):
327         (BrowserDriverFactory.available_platforms):
328         (BrowserDriverFactory.available_browsers):
329         (BrowserDriverFactory.add_browser_driver):
330         (BrowserDriverFactory.create):
331         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
332         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
333         (OSXBrowserDriver):
334         (OSXBrowserDriver.prepareEnv):
335         (OSXBrowserDriver.terminateProcesses):
336         (OSXBrowserDriver.screenSize):
337         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
338         (OSXChromeDriver):
339         (OSXChromeCanaryDriver):
340         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
341         (OSXFirefoxDriver):
342         (OSXFirefoxNightlyDriver):
343         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
344         (OSXSafariDriver):
345         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
346         (GenericFactory.create):
347         (GenericFactory.add):
348         (GenericFactory.iterateGetItem): Deleted.
349         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
350         (http_server_driver_loader):
351         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
352         (HTTPServerDriver):
353         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
354         (HTTPServerDriverFactory):
355         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
356         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
357         (SimpleHTTPServerDriver):
358         * Scripts/webkitpy/benchmark_runner/utils.py:
359         (is_subclass):
360         (load_subclasses):
361         (ModuleNotFoundError): Deleted.
362         (loadModule): Deleted.
363         (loadJSONFromFile): Deleted.
364
365 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
366
367         Make it possible to enable incremental rendering suppression in MiniBrowser
368         https://bugs.webkit.org/show_bug.cgi?id=146223
369         
370         Reviewed by Tim Horton.
371
372         Add a menu item to enable incremental rendering suppression to MiniBrowser.
373         
374         For WK1, this just toggles a pref, and takes effect immediately.
375         
376         For WK2, this is a WKConfiguration property, so only affects new web views.
377         
378         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
379         logging on launch.
380
381         * MiniBrowser/mac/AppDelegate.m:
382         (defaultConfiguration):
383         * MiniBrowser/mac/BrowserWindow.xib:
384         * MiniBrowser/mac/SettingsController.h:
385         * MiniBrowser/mac/SettingsController.m:
386         (-[SettingsController _populateMenu]):
387         (-[SettingsController validateMenuItem:]):
388         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
389         (-[SettingsController incrementalRenderingSuppressed]):
390         * MiniBrowser/mac/WK1BrowserWindowController.m:
391         (-[WK1BrowserWindowController didChangeSettings]):
392
393 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
394
395         Run CDjs as part of JSC stress testing
396         https://bugs.webkit.org/show_bug.cgi?id=146174
397
398         Reviewed by Geoffrey Garen.
399
400         * Scripts/run-javascriptcore-tests:
401         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
402         * Scripts/run-jsc-stress-tests:
403         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
404         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
405         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
406
407 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
408
409         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
410         https://bugs.webkit.org/show_bug.cgi?id=146121
411         rdar://problem/21395180
412
413         Reviewed by Darin Adler.
414
415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
416         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
417         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
418         (TestWebKitAPI::overrideAppleLanguages):
419         (TestWebKitAPI::languageForSystemLanguage):
420         (TestWebKitAPI::TEST):
421
422 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
423
424         [CMake] Ignore warnings from system headers when compiling Tools
425         https://bugs.webkit.org/show_bug.cgi?id=146185
426
427         Reviewed by Martin Robinson.
428
429         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
430         from system headers that we don't control.
431
432         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
433         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
434         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
435         * ImageDiff/PlatformGTK.cmake:
436         * MiniBrowser/efl/CMakeLists.txt:
437         * MiniBrowser/gtk/CMakeLists.txt:
438         * TestWebKitAPI/PlatformEfl.cmake:
439         * TestWebKitAPI/PlatformGTK.cmake:
440         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
441         * WebKitTestRunner/CMakeLists.txt:
442         * WebKitTestRunner/PlatformEfl.cmake:
443         * WebKitTestRunner/PlatformGTK.cmake:
444
445 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
446
447         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
448         https://bugs.webkit.org/show_bug.cgi?id=146186
449
450         Reviewed by Martin Robinson.
451
452         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
453         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
454
455         * MiniBrowser/gtk/CMakeLists.txt:
456
457 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
458
459         Build fix after r146125.
460
461         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
462         (OSXSafariDriver):
463         (OSXSafariDriver.prepareEnv):
464
465 2015-06-19  Brady Eidson  <beidson@apple.com>
466
467         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
468         https://bugs.webkit.org/show_bug.cgi?id=146152
469
470         Reviewed by Dan Bernstein.
471
472         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
473         * WebKitTestRunner/WebNotificationProvider.cpp:
474
475 2015-06-19  Mark Lam  <mark.lam@apple.com>
476
477         CheckedArithmetic's operator bool() and operator==() is broken.
478         https://bugs.webkit.org/show_bug.cgi?id=146129
479
480         Reviewed by Geoffrey Garen and Oliver Hunt.
481
482         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
483         and overflow scenarios in usage of the Checked arithmetic class.
484
485         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
486         (TestWebKitAPI::OverflowCrashLogger::overflowed):
487         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
488         (TestWebKitAPI::OverflowCrashLogger::crash):
489         (TestWebKitAPI::OverflowCrashLogger::reset):
490         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
491         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
492         (TestWebKitAPI::OverflowCrashLogger::didCrash):
493         - crash logger for verifying that a crash occurs when expected. 
494
495         (TestWebKitAPI::resetOverflow):
496         - convenience function for resetting a test value to an initial overflowed state
497           before a crash.  We will use this value in the overflow testing.
498
499         (TestWebKitAPI::CheckedArithmeticTester::run):
500         - Added new tests for all the comparison operators.
501
502 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
503
504         Fix the Windows build after r185721
505         https://bugs.webkit.org/show_bug.cgi?id=146146
506
507         Reviewed by Csaba Osztrogonác.
508
509         Speculative buildfix.
510
511         * DumpRenderTree/win/UIDelegate.h:
512         (UIDelegate::unused4): Added.
513         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
514
515 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
516
517         Unreviewed. Add myself as a committer.
518
519         * Scripts/webkitpy/common/config/contributors.json:
520
521 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
522
523         Remove unnecessary svn:executable flags
524         https://bugs.webkit.org/show_bug.cgi?id=146107
525
526         Reviewed by Alexey Proskuryakov.
527
528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
529         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
530         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
533         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
534         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
535         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
536         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
537         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
538         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
539         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
540         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
541         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
542
543 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
544
545         Disable tests on the WinCairo buildbot
546         https://bugs.webkit.org/show_bug.cgi?id=146106
547
548         Reviewed by Alexey Proskuryakov.
549
550         * BuildSlaveSupport/build.webkit.org-config/config.json:
551         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
552
553 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
554
555         [EFL] Fix the minibrowser after r185725
556         https://bugs.webkit.org/show_bug.cgi?id=146135
557
558         Reviewed by Gyuyoung Kim.
559
560         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
561         for the elm_config_accel_preference_set() to set the config of acceleration preference.
562
563         * MiniBrowser/efl/main.c:
564         (elm_main): Deleted the HAVE_ECORE_X guard.
565
566 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
567
568         Extend capability of run-benchmark script to support mobile device
569         https://bugs.webkit.org/show_bug.cgi?id=146125
570
571         Reviewed by Ryosuke Niwa.
572
573         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
574         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
575
576         * Scripts/run-benchmark:
577         (main): Deleted.
578         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
579         (BenchmarkRunner.__init__):
580         (BenchmarkRunner.execute):
581         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
582         (BrowserDriver.prepareEnv):
583         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
584         (OSXBrowserDriver.prepareEnv):
585         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
586         (OSXSafariDriver.prepareEnv):
587         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
588         (HTTPServerDriver.getReturnCode):
589         (HTTPServerDriver):
590         (HTTPServerDriver.setDeviceID):
591         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
592         (parse_args):
593         (start):
594         (main):
595         * Scripts/webkitpy/benchmark_runner/utils.py:
596         (getPathFromProjectRoot):
597
598 2015-06-18  Jon Lee  <jonlee@apple.com>
599
600         Unreviewed. Add Matt Daiter as a contributor.
601
602         * Scripts/webkitpy/common/config/contributors.json:
603
604 2015-06-18  Mark Lam  <mark.lam@apple.com>
605
606         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
607         https://bugs.webkit.org/show_bug.cgi?id=146103
608
609         Not reviewed.
610
611         Follow up to fix some typos not caught before original patch was landed.
612
613         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
614         (TestWebKitAPI::CheckedArithmeticTester::run):
615         (TestWebKitAPI::AllowMixedSignednessTest::run):
616         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
617
618 2015-06-18  Daniel Bates  <dabates@apple.com>
619
620         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
621         https://bugs.webkit.org/show_bug.cgi?id=146082
622
623         Reviewed by Darin Adler.
624
625         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
626         working directory after being invoked in a different Git checkout. In particular,
627         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
628         a pure Git checkout g will fail to update g.
629
630         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
631         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
632         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
633         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
634         different than the current working directory). Instead runGitUpdate() should check
635         whether the current working directory is a Git SVN checkout on each invocation.
636
637         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
638         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
639         SVN directory from isGitSVN().
640         (isGitSVN): Implemented in terms of isGitSVNDirectory().
641         * Scripts/webkitdirs.pm:
642         (runGitUpdate): Modified to use isGitSVNDirectory().
643
644 2015-06-18  Mark Lam  <mark.lam@apple.com>
645
646         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
647         https://bugs.webkit.org/show_bug.cgi?id=146103
648
649         Reviewed by Anders Carlsson.
650
651         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
652         part of a large macro.  This makes them harder to:
653
654         1. write: no editor help with indentations, have to add trailing '\'s,
655            inconvenient to add line breaks and comments.
656
657         2. read: no chroma coding / syntax highlighting.
658
659         3. debug: compile time errors are reported as being on the single line where
660            the macro is used.
661
662         Refactoring the tests to use C++ templates solves all these issues.
663
664         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
665         (TestWebKitAPI::CheckedArithmeticTester::run):
666         (TestWebKitAPI::AllowMixedSignednessTest::run):
667         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
668         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
669         (TestWebKitAPI::CoerceLiteralNop::coerce):
670
671 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
672
673         [EFL][WK2] Use Web Browser cache model in MiniBrowser
674         https://bugs.webkit.org/show_bug.cgi?id=112273
675
676         Reviewed by Laszlo Gombos.
677
678         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
679         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
680         This way we have a decent cache capacity and the page cache actually works.
681
682         * MiniBrowser/efl/main.c:
683         (elm_main):
684
685 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
686
687         Remove redundant Chromium bug keyword
688         https://bugs.webkit.org/show_bug.cgi?id=146097
689
690         Reviewed by Csaba Osztrogonác.
691
692         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
693         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
694         (TestExpectationLine._format_line): Deleted.
695
696 2015-06-17  Daniel Bates  <dabates@apple.com>
697
698         Client may receive began editing callback for already focused text field
699         https://bugs.webkit.org/show_bug.cgi?id=146074
700         <rdar://problem/21293562>
701
702         Reviewed by Darin Adler.
703
704         Add a unit test to ensure that a client receives exactly one began editing
705         callback when a text field is newly focused. In particular, dispatching
706         a DOM focus event at an already focused text field does not dispatch a
707         began editing callback to the client.
708
709         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
710         (TestWebKitAPI::TEST_F):
711
712 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
713
714         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
715         https://bugs.webkit.org/show_bug.cgi?id=26481
716
717         Reviewed by Darin Adler.
718
719         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
720
721         * DumpRenderTree/win/TestRunnerWin.cpp:
722         (TestRunner::dispatchPendingLoadRequests):
723         (TestRunner::overridePreference):
724
725 2015-06-17  Alex Christensen  <achristensen@webkit.org>
726
727         [Content Extensions] Fail to parse invalid arrays
728         https://bugs.webkit.org/show_bug.cgi?id=146079
729         rdar://problem/21422649
730
731         Reviewed by Benjamin Poulain.
732
733         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
734         (TestWebKitAPI::TEST_F):
735         Correct and add parsing tests with invalid arrays.
736
737 2015-06-17  Matt Rajca  <mrajca@apple.com>
738
739         Unreviewed. Added myself as a committer.
740
741         * Scripts/webkitpy/common/config/contributors.json:
742
743 2015-06-17  Daniel Bates  <dabates@apple.com>
744
745         Export VCSUtils::gitTreeDirectory()
746         <rdar://problem/21248901>
747
748         Rubber-stamped by Alexey Proskuryakov.
749
750         * Scripts/VCSUtils.pm:
751
752 2015-06-17  Tim Horton  <timothy_horton@apple.com>
753
754         Safari tabs still have shrunken content after coming out of fullscreen
755         https://bugs.webkit.org/show_bug.cgi?id=146037
756         <rdar://problem/21105960>
757
758         Reviewed by Simon Fraser and Darin Adler.
759
760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
761         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
762         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
763         (TEST):
764         Add a test that ensures that disabling scale-to-fit mode correctly updates
765         the page's layout.
766
767 2015-06-17  Dan Bernstein  <mitz@apple.com>
768
769         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
770         https://bugs.webkit.org/show_bug.cgi?id=145957
771
772         Reviewed by Darin Adler.
773
774         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
775         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
776
777 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
778
779         AX:  iOS accessibility tests are not running because we need WKTR support
780         https://bugs.webkit.org/show_bug.cgi?id=145991
781
782         Reviewed by Daniel Bates.
783
784         Add support for WKTR iOS accessibility.
785         Utilize the notification handling mechanisms that Mac already uses.
786         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
787
788         * DumpRenderTree/AccessibilityUIElement.cpp:
789         (stringForSelectionCallback):
790         (getIdentifierCallback):
791         (getTraitsCallback):
792         (getElementTextPositionCallback):
793         (getElementTextLengthCallback):
794         (AccessibilityUIElement::getJSClass):
795         (getIPhoneLabelCallback): Deleted.
796         (getIPhoneHintCallback): Deleted.
797         (getIPhoneValueCallback): Deleted.
798         (getIPhoneIdentifierCallback): Deleted.
799         (getIPhoneTraitsCallback): Deleted.
800         (getIPhoneIsElementCallback): Deleted.
801         (getIPhoneElementTextPositionCallback): Deleted.
802         (getIPhoneElementTextLengthCallback): Deleted.
803         * DumpRenderTree/AccessibilityUIElement.h:
804         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
805         (AccessibilityUIElement::identifier):
806         (AccessibilityUIElement::traits):
807         (AccessibilityUIElement::elementTextPosition):
808         (AccessibilityUIElement::elementTextLength):
809         (AccessibilityUIElement::description):
810         (AccessibilityUIElement::orientation):
811         (AccessibilityUIElement::stringValue):
812         (AccessibilityUIElement::language):
813         (AccessibilityUIElement::helpText):
814         (AccessibilityUIElement::intValue):
815         (AccessibilityUIElement::isSelected):
816         (AccessibilityUIElement::isExpanded):
817         (AccessibilityUIElement::documentURI):
818         (AccessibilityUIElement::addNotificationListener):
819         (AccessibilityUIElement::removeNotificationListener):
820         (AccessibilityUIElement::isFocusable):
821         (AccessibilityUIElement::isIgnored):
822         (AccessibilityUIElement::hasPopup):
823         (AccessibilityUIElement::iphoneLabel): Deleted.
824         (AccessibilityUIElement::iphoneHint): Deleted.
825         (AccessibilityUIElement::iphoneValue): Deleted.
826         (AccessibilityUIElement::iphoneIdentifier): Deleted.
827         (AccessibilityUIElement::iphoneTraits): Deleted.
828         (AccessibilityUIElement::iphoneIsElement): Deleted.
829         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
830         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
831         (_accessibilityNotificationCallback): Deleted.
832         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
833         (WTR::AccessibilityUIElement::isValid):
834         (WTR::AccessibilityUIElement::identifier):
835         (WTR::AccessibilityUIElement::traits):
836         (WTR::AccessibilityUIElement::elementTextPosition):
837         (WTR::AccessibilityUIElement::elementTextLength):
838         (WTR::AccessibilityUIElement::stringForSelection):
839         (WTR::AccessibilityUIElement::elementsForRange):
840         (WTR::AccessibilityUIElement::increaseTextSelection):
841         (WTR::AccessibilityUIElement::decreaseTextSelection):
842         (WTR::AccessibilityUIElement::linkedElement):
843         (WTR::AccessibilityUIElement::headerElementAtIndex):
844         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
845         (WTR::AccessibilityUIElement::characterAtOffset):
846         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
847         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
848         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
849         (WTR::findAccessibleObjectById):
850         (WTR::AccessibilityController::accessibleElementById):
851         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
852         (+[NSString stringWithJSStringRef:]):
853         (-[NSString createJSStringRef]):
854         (WTR::convertNSArrayToVector):
855         (WTR::concatenateAttributeAndValue):
856         (WTR::AccessibilityUIElement::AccessibilityUIElement):
857         (WTR::AccessibilityUIElement::isEqual):
858         (WTR::AccessibilityUIElement::headerElementAtIndex):
859         (WTR::AccessibilityUIElement::linkedElement):
860         (WTR::AccessibilityUIElement::getLinkedUIElements):
861         (WTR::AccessibilityUIElement::elementAtPoint):
862         (WTR::convertElementsToObjectArray):
863         (WTR::AccessibilityUIElement::elementsForRange):
864         (WTR::AccessibilityUIElement::indexOfChild):
865         (WTR::AccessibilityUIElement::stringAttributeValue):
866         (WTR::AccessibilityUIElement::description):
867         (WTR::AccessibilityUIElement::orientation):
868         (WTR::AccessibilityUIElement::stringValue):
869         (WTR::AccessibilityUIElement::language):
870         (WTR::AccessibilityUIElement::helpText):
871         (WTR::AccessibilityUIElement::x):
872         (WTR::AccessibilityUIElement::clickPointX):
873         (WTR::AccessibilityUIElement::clickPointY):
874         (WTR::AccessibilityUIElement::intValue):
875         (WTR::AccessibilityUIElement::minValue):
876         (WTR::AccessibilityUIElement::maxValue):
877         (WTR::AccessibilityUIElement::valueDescription):
878         (WTR::AccessibilityUIElement::isSelected):
879         (WTR::AccessibilityUIElement::isSelectedOptionActive):
880         (WTR::AccessibilityUIElement::stringForRange):
881         (WTR::AccessibilityUIElement::attributedStringForRange):
882         (WTR::AccessibilityUIElement::attributesOfHeader):
883         (WTR::AccessibilityUIElement::traits):
884         (WTR::AccessibilityUIElement::identifier):
885         (WTR::AccessibilityUIElement::rowCount):
886         (WTR::AccessibilityUIElement::rowIndexRange):
887         (WTR::AccessibilityUIElement::columnIndexRange):
888         (WTR::AccessibilityUIElement::cellForColumnAndRow):
889         (WTR::AccessibilityUIElement::horizontalScrollbar):
890         (WTR::AccessibilityUIElement::documentURI):
891         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
892         (WTR::AccessibilityUIElement::increaseTextSelection):
893         (WTR::AccessibilityUIElement::decreaseTextSelection):
894         (WTR::AccessibilityUIElement::stringForSelection):
895         (WTR::AccessibilityUIElement::elementTextPosition):
896         (WTR::AccessibilityUIElement::elementTextLength):
897         (WTR::AccessibilityUIElement::url):
898         (WTR::AccessibilityUIElement::addNotificationListener):
899         (WTR::AccessibilityUIElement::removeNotificationListener):
900         (WTR::AccessibilityUIElement::isFocusable):
901         (WTR::AccessibilityUIElement::isIgnored):
902         (WTR::AccessibilityUIElement::hasPopup):
903         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
904         (WTR::_CGPathEnumerationIteration):
905         (WTR::AccessibilityUIElement::pathDescription):
906         (WTR::AccessibilityUIElement::supportedActions):
907
908 2015-06-16  Mark Lam  <mark.lam@apple.com>
909
910         Use NakedPtr<Exception>& to return exception results.
911         https://bugs.webkit.org/show_bug.cgi?id=145870
912
913         Reviewed by Anders Carlsson and Filip Pizlo.
914
915         * TestWebKitAPI/CMakeLists.txt:
916         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
917         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
919         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
920         (TestWebKitAPI::TEST):
921         (TestWebKitAPI::nakedPtrFoo):
922
923 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
924
925         Unreviewed. Adding myself as a committer.
926
927         * Scripts/webkitpy/common/config/contributors.json:
928
929 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
930
931         Add test expectations for El Capitan
932         https://bugs.webkit.org/show_bug.cgi?id=146005
933
934         Rubber-stamped by Dan Bernstein.
935
936         Add appropriate tools code.
937
938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
942         Added dashboard support.
943
944         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
945         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
946         Trigger the right build queues on check-in.
947
948         * Scripts/webkitpy/common/system/platforminfo.py:
949         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
950         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
951         * Scripts/webkitpy/port/mac.py:
952         * Scripts/webkitpy/port/mac_unittest.py:
953         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
954         * TestResultServer/static-dashboards/flakiness_dashboard.js:
955         Added cases for El Capitan, and updated tests for new baseline search paths.
956
957 2015-06-15  Alex Christensen  <achristensen@webkit.org>
958
959         [Content Extensions] Make max NFA size and max rule count user defaults.
960         https://bugs.webkit.org/show_bug.cgi?id=145663
961
962         Reviewed by Benjamin Poulain.
963
964         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
965         (TestWebKitAPI::TEST_F):
966
967 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
968
969         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
970         https://bugs.webkit.org/show_bug.cgi?id=145900
971
972         Reviewed by Sam Weinig.
973
974         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
975         (TEST): Added tests.
976
977 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
978
979         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
980         https://bugs.webkit.org/show_bug.cgi?id=145969
981
982         Reviewed by Sergio Villar Senin.
983
984         Add a test case to the custom URI schemes unit test.
985
986         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
987         (testWebContextURIScheme):
988
989 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
990
991         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
992         https://bugs.webkit.org/show_bug.cgi?id=145922
993
994         Reviewed by Carlos Garcia Campos.
995
996         * gtk/jhbuild.modules:
997         * gtk/patches/glib-warning-fix.patch: Added.
998
999 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1000
1001         Update springLoadingHighlight type
1002         https://bugs.webkit.org/show_bug.cgi?id=145939
1003         rdar://problem/20880213
1004
1005         Reviewed by Darin Adler.
1006
1007         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1008         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1009         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1010         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1011
1012 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
1013
1014         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
1015         https://bugs.webkit.org/show_bug.cgi?id=145945
1016
1017         Reviewed by Stephanie Lewis.
1018
1019         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1020         (OSXBrowserDriver.prepareEnv):
1021         (OSXBrowserDriver.moveCursor): Deleted.
1022         (OSXBrowserDriver): Deleted.
1023         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1024         (OSXSafariDriver.prepareEnv):
1025
1026 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
1027
1028         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
1029         https://bugs.webkit.org/show_bug.cgi?id=145938
1030
1031         Reviewed by Alexey Proskuryakov.
1032
1033         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
1034         LWP::UserAgent to get access to more robust HTTPS support.
1035
1036 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1037
1038         [GTK] Fix return type warning in WebViewTest.cpp
1039         https://bugs.webkit.org/show_bug.cgi?id=145914
1040
1041         Reviewed by Darin Adler.
1042
1043         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1044         (WebViewTest::isEditable):
1045
1046 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
1047
1048         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
1049         https://bugs.webkit.org/show_bug.cgi?id=145799
1050
1051         Reviewed by Carlos Garcia Campos.
1052
1053         Update header inclusions for headers that have been moved
1054         to Source/WTF/wtf/glib/.
1055
1056         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
1057         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
1058
1059         * TestWebKitAPI/PlatformGTK.cmake:
1060         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
1061         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1062         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1063         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1064         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1065         (TestWebKitAPI::GMainLoopSourceTest::finish):
1066         (TestWebKitAPI::GMainLoopSourceTest::source):
1067         (TestWebKitAPI::basicRescheduling):
1068         (TestWebKitAPI::TEST):
1069         (TestWebKitAPI::reentrantRescheduling):
1070         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1071         (TestWebKitAPI::basicDestroyCallbacks):
1072         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1073         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1074         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
1075         (log):
1076         (takeLogStr):
1077         (TestWebKitAPI::TEST):
1078         (TestWebKitAPI::returnOutChar):
1079         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1080         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1081         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
1082         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
1083         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
1084         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
1085         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
1086         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
1087         (TestWebKitAPI::basicRescheduling): Deleted.
1088         (TestWebKitAPI::TEST): Deleted.
1089         (TestWebKitAPI::reentrantRescheduling): Deleted.
1090         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
1091         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
1092         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
1093         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
1094         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
1095         (log): Deleted.
1096         (takeLogStr): Deleted.
1097         (TestWebKitAPI::TEST): Deleted.
1098         (TestWebKitAPI::returnOutChar): Deleted.
1099         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1100         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1101         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1102         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1103         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1104         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1105         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1106         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1107         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1108         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1109         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1110         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1111         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1112         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1113         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1114         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
1115         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1116         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1117         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1118         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1119         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1120         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1121         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1122         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1123         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1124         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1125         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1126         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1127         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1128         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
1129         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1130         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
1131         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1132         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1133         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1134         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1135         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1136         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1137         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1138         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1139         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1140         * WebKitTestRunner/PlatformGTK.cmake:
1141         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1142         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1143
1144 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1145
1146         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
1147         https://bugs.webkit.org/show_bug.cgi?id=145913
1148
1149         Reviewed by Gyuyoung Kim.
1150
1151         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1152         (TestWebKitAPI::setupGeolocationProvider):
1153         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1154         (TestWebKitAPI::setPageLoaderClient):
1155         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1156         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1157         * WebKitTestRunner/GeolocationProviderMock.cpp:
1158         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1159         * WebKitTestRunner/WebNotificationProvider.cpp:
1160         (WTR::WebNotificationProvider::provider):
1161
1162 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1163
1164         Fix the libusrsctp build with clang
1165         https://bugs.webkit.org/show_bug.cgi?id=145128
1166
1167         Reviewed by Gyuyoung Kim.
1168
1169         * efl/jhbuild.modules:
1170         * gtk/jhbuild.modules:
1171
1172 2015-06-11  Mark Lam  <mark.lam@apple.com>
1173
1174         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
1175         https://bugs.webkit.org/show_bug.cgi?id=145872
1176
1177         Reviewed by Michael Saboff.
1178
1179         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1180         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1181         - Exercises the JSC ObjC API to call a function which throws an exception.  That
1182           exception will be returned as a JSValue instead of an Exception object.  We
1183           will use this JSValue to test WebCore::reportException() to confirm that it is
1184           able to handle an exception value which is not an Exception object.
1185
1186 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
1187
1188         Move cursor to corner and fix safari window size before running benchmark
1189         https://bugs.webkit.org/show_bug.cgi?id=145858
1190
1191         Reviewed by Ryosuke Niwa
1192
1193         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1194         (OSXBrowserDriver.prepareEnv):
1195         (OSXBrowserDriver):
1196         (OSXBrowserDriver.moveCursor):
1197         (OSXBrowserDriver.getScreenSize):
1198         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1199         (OSXChromeDriver.launchUrl):
1200         (OSXChromeCanaryDriver.launchUrl):
1201         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1202         (OSXFirefoxDriver.launchUrl):
1203         (OSXFirefoxNightlyDriver.launchUrl):
1204         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1205         (OSXSafariDriver.prepareEnv):
1206         (OSXSafariDriver):
1207         (OSXSafariDriver.maximizeWindow):
1208
1209 2015-06-11  Daniel Bates  <dabates@apple.com>
1210
1211         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
1212         https://bugs.webkit.org/show_bug.cgi?id=145319
1213
1214         Reviewed by David Kilzer.
1215
1216         Add SPI wrapper header for CoreSimulator and update the source files to reference
1217         it instead of directly referencing the CoreSimulator header.
1218
1219         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
1220         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
1221         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1222         * LayoutTestRelay/LayoutTestRelay/main.m:
1223
1224 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1225
1226         [EFL] dimmed area for popup does not cover the fullscreen mode.
1227         https://bugs.webkit.org/show_bug.cgi?id=145133
1228
1229         Reviewed by Gyuyoung Kim.
1230
1231         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
1232         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
1233
1234         * MiniBrowser/efl/main.c:
1235         (on_fullscreen_accept):
1236         (on_fullscreen_deny):
1237         (on_fullscreen_enter):
1238
1239 2015-06-10  Commit Queue  <commit-queue@webkit.org>
1240
1241         Unreviewed, rolling out r185442.
1242         https://bugs.webkit.org/show_bug.cgi?id=145871
1243
1244         seems to have broken WTF.StringOperators test (Requested by
1245         alexchristensen on #webkit).
1246
1247         Reverted changeset:
1248
1249         "[Content Extensions] Limit number of rules."
1250         https://bugs.webkit.org/show_bug.cgi?id=145663
1251         http://trac.webkit.org/changeset/185442
1252
1253 2015-06-10  Alex Christensen  <achristensen@webkit.org>
1254
1255         [Content Extensions] Make max NFA size and max rule count user defaults.
1256         https://bugs.webkit.org/show_bug.cgi?id=145663
1257         rdar://problem/21242407
1258
1259         Reviewed by Benjamin Poulain.
1260
1261         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1262         (TestWebKitAPI::TEST_F):
1263
1264 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1265
1266         [EFL] Execute Javascript method in mini browser address bar.
1267         https://bugs.webkit.org/show_bug.cgi?id=145725
1268
1269         Reviewed by Gyuyoung Kim.
1270
1271         Support 'javascript:' scheme in WebKit EFL Mini Browser.
1272
1273         * MiniBrowser/efl/main.c:
1274         (url_from_user_input):
1275         (url_load_from_user_input):
1276         (on_url_bar_activated):
1277         (elm_main):
1278
1279 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1280
1281         Implement dumpProgressFinishedCallback() for Win layoutTestController.
1282         https://bugs.webkit.org/show_bug.cgi?id=66773
1283
1284         Reviewed by Darin Adler.
1285
1286         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1287         * DumpRenderTree/win/FrameLoadDelegate.h:
1288
1289 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
1290
1291         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
1292         https://bugs.webkit.org/show_bug.cgi?id=145764
1293
1294         Reviewed by Darin Adler.
1295
1296         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
1297         JetStream and SunSpider.
1298
1299         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1300         (GenericBenchmarkBuilder):
1301         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
1302         the whole JSON as the input.
1303         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
1304         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
1305         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1306         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
1307         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
1308         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1309         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1310
1311 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1312
1313         Remove ewstool scripts used by chromium port
1314         https://bugs.webkit.org/show_bug.cgi?id=145789
1315
1316         Reviewed by Csaba Osztrogonác.
1317
1318         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
1319         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
1320         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
1321         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
1322         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
1323
1324 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1325
1326         Unreviewed, updated my list of email addresses.
1327
1328         * Scripts/webkitpy/common/config/contributors.json:
1329
1330 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1331
1332         [cmake] Fix the style issues in cmake project files
1333         https://bugs.webkit.org/show_bug.cgi?id=145755
1334
1335         Reviewed by Darin Adler.
1336
1337         * TestWebKitAPI/CMakeLists.txt:
1338         * TestWebKitAPI/PlatformEfl.cmake:
1339
1340 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1341
1342         Fix a typo in r185345.
1343
1344         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1345         (OSXSafariDriver.closeBrowsers):
1346
1347 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1348
1349         Yet another unreviewed build fix :(
1350
1351         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1352         (OSXSafariDriver):
1353         (OSXSafariDriver.launchUrl):
1354         (OSXSafariDriver.closeBrowsers):
1355
1356 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1357
1358         Unreviewed build fix. Initialize result in the case things blow up below.
1359
1360         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1361         (BenchmarkRunner.execute):
1362
1363 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1364
1365         Partially revert and fix after r185243.
1366
1367         * Scripts/benchmark_runner/benchmark_runner.py:
1368         * Scripts/run-benchmark:
1369
1370 2015-06-08  Daniel Bates  <dabates@apple.com>
1371
1372         Many LayoutTests/http tests time out in DumpRenderTree
1373         https://bugs.webkit.org/show_bug.cgi?id=145770
1374         <rdar://problem/19593910>
1375
1376         Reviewed by Alexey Proskuryakov.
1377
1378         * DumpRenderTree/ios/Info.plist: Add ATS key.
1379         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1380         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
1381         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
1382         that make use of testRunner.pathToLocalResource().
1383
1384 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
1385
1386         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
1387         https://bugs.webkit.org/show_bug.cgi?id=145759
1388
1389         Reviewed by Carlos Garcia Campos.
1390
1391         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1392         (testWebViewSave):
1393
1394 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1395
1396         [GTK] Add editor mode to MiniBrowser
1397         https://bugs.webkit.org/show_bug.cgi?id=145595
1398
1399         Reviewed by Sergio Villar Senin.
1400
1401         It loads an empty editable web view with an edit toolbar. It makes
1402         easier to test the editor, editing commands and input methods.
1403
1404         * MiniBrowser/gtk/BrowserWindow.c:
1405         (editingCommandCallback):
1406         (browserWindowSetupEditorToolbar):
1407         (browserWindowConstructed):
1408         * MiniBrowser/gtk/main.c:
1409         (createBrowserWindow):
1410
1411 2015-06-05  Zalan Bujtas  <zalan@apple.com>
1412
1413         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
1414
1415         Reviewed by Dan Bernstein.
1416
1417         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1418         (TestWebKitAPI::TEST):
1419
1420 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1421
1422         [EFL] API test has been broken since r184357
1423         https://bugs.webkit.org/show_bug.cgi?id=145635
1424
1425         Reviewed by Darin Adler.
1426
1427         r184357 suppress cmake build warning using TARGET_FILE property. However
1428         many EFL API test cases have been broken after applying it.
1429
1430         * TestWebKitAPI/CMakeLists.txt:
1431
1432 2015-06-05  Anders Carlsson  <andersca@apple.com>
1433
1434         Make the network cache directory part of WKContextConfigurationRef
1435         https://bugs.webkit.org/show_bug.cgi?id=145711
1436
1437         Reviewed by Antti Koivisto.
1438
1439         * WebKitTestRunner/TestController.cpp:
1440         (WTR::TestController::initialize):
1441
1442 2015-06-05  Anders Carlsson  <andersca@apple.com>
1443
1444         Make the application cache directory part of WKContextConfigurationRef
1445         https://bugs.webkit.org/show_bug.cgi?id=145704
1446
1447         Reviewed by Geoffrey Garen.
1448
1449         * WebKitTestRunner/TestController.cpp:
1450         (WTR::TestController::initialize):
1451
1452 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1453
1454         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
1455         https://bugs.webkit.org/show_bug.cgi?id=145680
1456
1457         Reviewed by Brent Fulgham.
1458
1459         * Scripts/webkitpy/style/checkers/cpp.py:
1460         (check_for_null):
1461         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1462         (WebKitStyleTest.test_null_false_zero):
1463
1464 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1465
1466         Make the web server more robust to timing issues..
1467
1468         Reviewed by Ryosuke Niwa.
1469
1470         Cleaned up exception handling.
1471         Test server is actually serving pages before returning.
1472         Clean up some style issues.
1473
1474         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1475         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1476         (SimpleHTTPServerDriver.__init__):
1477         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
1478         (SimpleHTTPServerDriver.baseUrl): 
1479         (SimpleHTTPServerDriver.fetchResult):
1480         (SimpleHTTPServerDriver.killServer):
1481         (SimpleHTTPServerDriver.getReturnCode):
1482
1483 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1484
1485
1486         Add errors to run-benchmark exception handling.
1487
1488         Reviewed by Ryosuke Niwa.
1489
1490         * Scripts/run-benchmark:
1491         (main):
1492         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1493         (GenericBenchmarkBuilder.prepare):
1494         (GenericBenchmarkBuilder._runCreateScript):
1495         (GenericBenchmarkBuilder._applyPatch):
1496         (GenericBenchmarkBuilder.clean):
1497         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1498         (BenchmarkRunner.__init__):
1499         (BenchmarkRunner.execute):
1500         (BenchmarkRunner):
1501         (BenchmarkRunner.cleanup):
1502         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1503         (GenericFactory.iterateGetItem):
1504         (GenericFactory.create):
1505         * Scripts/webkitpy/benchmark_runner/utils.py:
1506         (loadModule):
1507         (loadJSONFromFile):
1508         (forceRemove):
1509
1510 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1511
1512         Streamline run-benchmark browser
1513
1514         Reviewed by Ryosuke Niwa.
1515
1516         Add Caffeinate so computer won't sleep while running.
1517         Remove calls to collect output since we were just dumping to stdout anyway.
1518         Add xpc dyld_path.
1519         Default to system safari.
1520
1521         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1522         (OSXBrowserDriver.launchProcess):
1523         (OSXBrowserDriver.terminateProcesses):
1524         (OSXBrowserDriver):
1525         (OSXBrowserDriver.launchCaffeinateForProcess):
1526         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1527         (OSXSafariDriver.launchUrl):
1528         (OSXSafariDriver.closeBrowsers):
1529
1530 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
1531
1532         Combine tiny DFAs into slightly larger ones
1533         https://bugs.webkit.org/show_bug.cgi?id=145572
1534
1535         Reviewed by Alex Christensen.
1536
1537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1538         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
1539         (TestWebKitAPI::DFACombinerTest::SetUp):
1540         (TestWebKitAPI::combine):
1541         (TestWebKitAPI::TEST_F):
1542         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
1543         (TestWebKitAPI::countLiveNodes):
1544         (TestWebKitAPI::createNFAs):
1545         (TestWebKitAPI::buildDFAFromPatterns):
1546         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1547         (TestWebKitAPI::countLiveNodes): Deleted.
1548         (TestWebKitAPI::createNFAs): Deleted.
1549         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
1550
1551 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
1552
1553         WebKitTestRunner leaks strings in generateWhitelist()
1554         https://bugs.webkit.org/show_bug.cgi?id=145665
1555
1556         Reviewed by Myles C. Maxfield.
1557
1558         * WebKitTestRunner/mac/TestControllerMac.mm:
1559         (WTR::generateWhitelist):
1560
1561 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1562
1563         Fix options in build-jsc for CMake builds
1564         https://bugs.webkit.org/show_bug.cgi?id=145636
1565
1566         Reviewed by Gyuyoung Kim.
1567
1568         CMake only accepts -DXXX=YYY style options.
1569         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
1570
1571         * Scripts/build-jsc:
1572
1573 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
1574
1575         Added a patch so that the colors displayed on the page could be toggled
1576         in case people need accessibility colors displayed in their browser.
1577         https://bugs.webkit.org/show_bug.cgi?id=145570
1578         <rdar://problem/20994468>
1579
1580         Added in CSS colors and toggle buttons for checkmarks in the page, so that
1581         the page could be rendered in a specific way for accessibility needs if needed.
1582
1583         Reviewed by Alexey Proskuryakov.
1584
1585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1586         (updateHiddenPlatforms):
1587         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
1588         (toggleAccessibilityColors): Toggle colors on and off
1589         (documentReady): Needed to make changes to the initialization
1590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1591         (a:hover):
1592         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
1593         (div.cellButton.hide, div.accessibilityButton.hide):
1594         (div.cellButton.unhide, div.accessibilityButton.unhide):
1595         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
1596         (.popover-tracking:hover):
1597         (.accessibilityButton):
1598         (div.cellButton): Deleted.
1599         (div.cellButton.hide): Deleted.
1600         (div.cellButton.unhide): Deleted.
1601         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
1602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1603         (.status-line.neutral .bubble):
1604         (.status-line.unauthorized .bubble):
1605         (.status-line.danger .bubble.pictogram):
1606         (.status-line.bad .bubble.pictogram):
1607         (.status-line.no-bubble .message):
1608         (.status-line.bad .bubble):
1609         (.status-line.good .bubble):
1610         (.status-line.good .message):
1611         (.status-line.bad .message):
1612         (body.accessibility-colors .status-line.good .bubble):
1613         (body.accessibility-colors .status-line.bad .bubble):
1614         (body.accessibility-colors .status-line.good .message):
1615         (body.accessibility-colors .status-line.bad .message):
1616         (.status-line.danger .message):
1617         (.status-line.unauthorized .message):
1618
1619 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
1620
1621         Unreviewed build fix for Dromaeo.
1622
1623         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1624         (BenchmarkResults._aggregate_results_for_test):
1625
1626 2015-06-03  Anders Carlsson  <andersca@apple.com>
1627
1628         Fix build.
1629
1630         * DumpRenderTree/mac/TestRunnerMac.mm:
1631
1632 2015-06-03  Daniel Bates  <dabates@apple.com>
1633
1634         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
1635         https://bugs.webkit.org/show_bug.cgi?id=145616
1636
1637         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
1638         of the test. Further investigation is needed.
1639
1640         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1641         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
1642
1643 2015-06-03  Brady Eidson  <beidson@apple.com>
1644
1645         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
1646         https://bugs.webkit.org/show_bug.cgi?id=145580
1647
1648         Reviewed by Mark Lam.
1649
1650         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1651         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
1652
1653 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
1654
1655         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
1656
1657         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1658         (TestWebKitAPI::TEST): Update the syntax.
1659
1660 2015-06-02  Mark Lam  <mark.lam@apple.com>
1661
1662         build-jsc's --cloop option is broken.
1663         https://bugs.webkit.org/show_bug.cgi?id=145516
1664
1665         Reviewed by Darin Adler.
1666
1667         * Scripts/build-jsc:
1668         - Make sure to disable the JIT when --cloop is specified.
1669           Did analogous fix for --ftljit.
1670
1671 2015-06-02  Daniel Bates  <dabates@apple.com>
1672
1673         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
1674
1675         Rubber-stamped by Alexey Proskuryakov.
1676
1677         * MiniBrowser/mac/Info.plist:
1678         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1679
1680 2015-06-01  Commit Queue  <commit-queue@webkit.org>
1681
1682         Unreviewed, rolling out r185066.
1683         https://bugs.webkit.org/show_bug.cgi?id=145543
1684
1685         it breaks the FTL JIT builds with a local checkout of llvm
1686         (Requested by pizlo on #webkit).
1687
1688         Reverted changeset:
1689
1690         "build-jsc's --cloop option is broken."
1691         https://bugs.webkit.org/show_bug.cgi?id=145516
1692         http://trac.webkit.org/changeset/185066
1693
1694 2015-06-01  Daniel Bates  <dabates@apple.com>
1695
1696         Notify client that we began editing when text field is focused
1697         https://bugs.webkit.org/show_bug.cgi?id=145439
1698         <rdar://problem/21142108>
1699
1700         Reviewed by Anders Carlsson.
1701
1702         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
1703         a text field is focused and defocused.
1704
1705         * TestWebKitAPI/CMakeLists.txt:
1706         * TestWebKitAPI/PlatformEfl.cmake:
1707         * TestWebKitAPI/PlatformGTK.cmake:
1708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1709         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
1710         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
1711         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
1712         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
1713         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
1714         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
1715         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
1716         (TestWebKitAPI::TEST_F):
1717         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
1718         (TestWebKitAPI::textFieldDidBeginEditing):
1719         (TestWebKitAPI::textFieldDidEndEditing):
1720         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
1721         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
1722         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
1723
1724 2015-06-01  Alex Christensen  <achristensen@webkit.org>
1725
1726         [Content Extensions] resource-type and load-type should be independent.
1727         https://bugs.webkit.org/show_bug.cgi?id=145528
1728         rdar://problem/21190765
1729
1730         Reviewed by Benjamin Poulain.
1731
1732         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1733         (TestWebKitAPI::TEST_F):
1734
1735 2015-06-01  Daniel Bates  <dabates@apple.com>
1736
1737         Add ATS keys to WebKitTestRunnerApp
1738         https://bugs.webkit.org/show_bug.cgi?id=145519
1739
1740         Reviewed by Alexey Proskuryakov.
1741
1742         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
1743
1744         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1745
1746 2015-06-01  Brady Eidson  <beidson@apple.com>
1747
1748         Add WKTR support for "should open external URLs".
1749         https://bugs.webkit.org/show_bug.cgi?id=145505
1750
1751         Reviewed by Darin Adler.
1752
1753         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
1754           "should open external URLs" bit set.
1755         
1756         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
1757           the policy delegate, including whether or not the bit was set.
1758         
1759         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1760         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1761         (WTR::TestRunner::queueLoad):
1762         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1763         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
1764         (WTR::TestRunner::shouldDumpPolicyCallbacks):
1765         
1766         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1767         (WTR::InjectedBundle::queueLoad):
1768         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1769
1770         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1771         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1772
1773         * WebKitTestRunner/TestInvocation.cpp:
1774         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1775
1776         * WebKitTestRunner/WorkQueueManager.cpp:
1777         (WTR::WorkQueueManager::queueLoad):
1778         * WebKitTestRunner/WorkQueueManager.h:
1779
1780 2015-06-01  Mark Lam  <mark.lam@apple.com>
1781
1782         build-jsc's --cloop option is broken.
1783         https://bugs.webkit.org/show_bug.cgi?id=145516
1784
1785         Reviewed by Darin Adler.
1786
1787         * Scripts/build-jsc:
1788         - Make sure to disable the JIT when --cloop is specified.
1789           Did analogous fix for --ftljit.
1790
1791 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1792
1793         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
1794         https://bugs.webkit.org/show_bug.cgi?id=144959
1795
1796         Reviewed by Darin Adler.
1797
1798         * Scripts/webkitpy/style/checkers/cmake.py:
1799         (CMakeChecker.check): Use enumerate instead of xrange.
1800         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
1801         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1802         (CMakeCheckerTest.test_check): Update the expected results.
1803
1804 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1805
1806         Fix the webkitpy scm unittests after r174051
1807         https://bugs.webkit.org/show_bug.cgi?id=145511
1808
1809         Reviewed by Darin Adler.
1810
1811         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1812         (GitTestWithMock.make_scm):
1813
1814 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1815
1816         EWS provides misleading information for not applyable patches
1817         https://bugs.webkit.org/show_bug.cgi?id=145307
1818
1819         Reviewed by Alexey Proskuryakov.
1820
1821         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
1822
1823 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
1824
1825         Further tweak results of WebKit1.StringTruncator after r184965.
1826
1827         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1828
1829 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1830
1831         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
1832         https://bugs.webkit.org/show_bug.cgi?id=145264
1833
1834         Reviewed by Carlos Garcia Campos.
1835
1836         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
1837
1838 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1839
1840         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
1841
1842         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1843         (BenchmarkResults._lint_subtest_results):
1844         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1845         (test_aggregate_nested_results):
1846         (test_lint_results):
1847         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
1848
1849 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
1850
1851         run-benchmark should print out the results
1852         https://bugs.webkit.org/show_bug.cgi?id=145398
1853
1854         Reviewed by Antti Koivisto.
1855
1856         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
1857         of the output to catch early errors.
1858
1859         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
1860         (BenchmarkResults): Added.
1861         (BenchmarkResults.__init__): Added.
1862         (BenchmarkResults.format): Added.
1863         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
1864         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
1865         Uses the sample standard deviation to compute the significant figures for the value.
1866         (BenchmarkResults._unit_from_metric): Added.
1867         (BenchmarkResults._aggregate_results): Added.
1868         (BenchmarkResults._aggregate_results_for_test): Added.
1869         (BenchmarkResults._flatten_list): Added.
1870         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
1871         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
1872         (BenchmarkResults._aggregate_values): Added.
1873         (BenchmarkResults._lint_results): Added.
1874         (BenchmarkResults._lint_subtest_results): Added.
1875         (BenchmarkResults._lint_aggregator_list): Added.
1876         (BenchmarkResults._lint_configuration): Added.
1877         (BenchmarkResults._lint_values): Added.
1878         (BenchmarkResults._is_numeric): Added.
1879         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
1880         (BenchmarkResultsTest):
1881         (BenchmarkResultsTest.test_init):
1882         (BenchmarkResultsTest.test_format):
1883         (test_format_values_with_large_error):
1884         (test_format_values_with_small_error):
1885         (test_format_values_with_time):
1886         (test_format_values_with_no_error):
1887         (test_format_values_with_small_difference):
1888         (test_aggregate_results):
1889         (test_aggregate_results_with_gropus):
1890         (test_aggregate_nested_results):
1891         (test_lint_results):
1892         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1893         (BenchmarkRunner.execute): Added a call to show_results
1894         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
1895         (BenchmarkRunner.show_results): Added.
1896
1897 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1898
1899         run_benchmark should have an option to specify the number of runs
1900         https://bugs.webkit.org/show_bug.cgi?id=145091
1901
1902         Reviewed by Antti Koivisto.
1903
1904         Added --count option.
1905
1906         * Scripts/run-benchmark:
1907         (main):
1908         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1909         (BenchmarkRunner.__init__):
1910
1911 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1912
1913         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
1914
1915         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1916
1917 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1918
1919         Update results of WebKit1.StringTruncator after r184965.
1920
1921         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1922
1923 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1924
1925         Unreviewed, updated my list of email addresses.
1926
1927         * Scripts/webkitpy/common/config/contributors.json:
1928
1929 2015-05-27  Dean Jackson  <dino@apple.com>
1930
1931         img.currentSrc problem in strict mode with old picturefill
1932         https://bugs.webkit.org/show_bug.cgi?id=144095
1933         <rdar://problem/21087013>
1934
1935         Reviewed by Simon Fraser.
1936
1937         Add a PICTURE_SIZES flag.
1938
1939         * Scripts/webkitperl/FeatureList.pm:
1940
1941 2015-05-26  Dana Burkart  <dburkart@apple.com>
1942
1943         Fixes compatibility issues with recent dashboard cleanup.
1944         https://bugs.webkit.org/show_bug.cgi?id=144814
1945
1946         Reviewed by Alexey Proskuryakov.
1947
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1949         (BuildbotStaticAnalyzerQueueView):
1950         (BuildbotStaticAnalyzerQueueView.prototype.update):
1951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1952         (documentReady):
1953
1954 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
1955
1956         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
1957         https://bugs.webkit.org/show_bug.cgi?id=143091
1958         rdar://problem/19330328
1959
1960         Reviewed by Darin Adler and Timothy Hatcher.
1961
1962         We have many of these, which are hard to fit on the dashboard. Added a view that
1963         collapses to a single green bubble when everything is good, and expands when there
1964         are failures (or manually).
1965
1966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
1967
1968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1969         (Buildbot.prototype.set isAuthenticated):
1970         (Buildbot.prototype._normalizeQueueInfo):
1971         (Buildbot.prototype._normalizeQueuesInfo):
1972         (Buildbot.prototype.updateQueues):
1973         Moved queue info normalization here from BuildbitQueue. The latter is a model class
1974         that shouldn't have to know about presentation, and this lets us leep the knowledge
1975         about combined queues out if it. Later, we can refactor existing code, and move out
1976         all knowledge about headings and such.
1977
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1979         Added the new view. It's not quite universal, and doesn't have as helpful popovers
1980         as other views, but we can extend it when/if we use it for more than JSC.
1981
1982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1983         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
1984
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1986         (documentReady): Added support for combined queues. These are currently always ending up
1987         in Other column, but it's easy to customize in the future if we need to.
1988
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1990         (WebKitBuildbot): Added JSC queus.
1991
1992         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1993         (.combined-queue-popover):
1994         (.combined-queue-popover .revision):
1995         Added styles for the combined view.
1996
1997 2015-05-26  Dan Bernstein  <mitz@apple.com>
1998
1999         Changed a file to use Unix line endings.
2000
2001         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2002
2003 2015-05-26  Dan Bernstein  <mitz@apple.com>
2004
2005         <rdar://problem/21104551> Update build settings
2006
2007         Reviewed by Anders Carlsson.
2008
2009         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2010         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2011         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2012         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2013         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2014         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2015         * asan/asan.xcconfig:
2016
2017 2015-05-26  Anders Carlsson  <andersca@apple.com>
2018
2019         Fix build.
2020
2021         * WebKitTestRunner/mac/EventSenderProxy.mm:
2022         (WTR::EventSenderProxy::mouseForceDown):
2023         (WTR::EventSenderProxy::mouseForceUp):
2024         (WTR::EventSenderProxy::mouseForceChanged):
2025
2026 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2027
2028         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
2029         https://bugs.webkit.org/show_bug.cgi?id=145342
2030
2031         Reviewed by Darin Adler.
2032
2033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2034         (BuildbotIteration.prototype._parseData):
2035
2036 2015-05-26  Milan Crha  <mcrha@redhat.com>
2037
2038         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
2039         https://bugs.webkit.org/show_bug.cgi?id=138134
2040
2041         Reviewed by Žan Doberšek.
2042
2043         * gtk/generate-inspector-gresource-manifest.py:
2044         (get_filenames): Command line with expanded resources exceeds 32KB, which
2045         is a limit on Windows. It's better to expand wildcards inside the python script.
2046
2047 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2048
2049         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
2050         https://bugs.webkit.org/show_bug.cgi?id=140882
2051
2052         Reviewed by Gustavo Noronha Silva.
2053
2054         Make sure unit tests write IndexedDB databases to the temporary
2055         directory, and add a test case to check that the directory is
2056         correctly created at the expected path.
2057
2058         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2059         (testWebContextConfiguration):
2060         (serverCallback):
2061         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2062         (Test::Test):
2063
2064 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2065
2066         [GTK] Enable IndexedDB
2067         https://bugs.webkit.org/show_bug.cgi?id=98932
2068
2069         Reviewed by Žan Doberšek.
2070
2071         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2072
2073 2015-05-24  Sam Weinig  <sam@webkit.org>
2074
2075         Crash when using a removed ScriptMessageHandler
2076         <rdar://problem/20888499>
2077         https://bugs.webkit.org/show_bug.cgi?id=145359
2078
2079         Reviewed by Dan Bernstein.
2080
2081         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2082         Add tests for removing script message handlers.
2083
2084 2015-05-23  Dan Bernstein  <mitz@apple.com>
2085
2086         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
2087         https://bugs.webkit.org/show_bug.cgi?id=145345
2088
2089         Reviewed by Sam Weinig.
2090
2091         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2092         * LayoutTestRelay/Configurations/Base.xcconfig:
2093         * TestWebKitAPI/Configurations/Base.xcconfig:
2094         * WebKitTestRunner/Configurations/Base.xcconfig:
2095
2096 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2097
2098         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
2099         https://bugs.webkit.org/show_bug.cgi?id=144848
2100
2101         Reviewed by Darin Adler.
2102
2103         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
2104
2105         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2106
2107 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2108
2109         Fix one more merge error in static analyzer support.
2110
2111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2112         (BuildbotStaticAnalyzerQueueView):
2113
2114 2015-05-22  Dana Burkart  <dburkart@apple.com>
2115
2116         Fix internal dashboard breakage from recent commit.
2117         https://bugs.webkit.org/show_bug.cgi?id=144814
2118
2119         Unreviewed build fix.
2120
2121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2122         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2123         (BuildbotStaticAnalyzerQueueView.prototype.update):
2124
2125 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2126
2127         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2128         https://bugs.webkit.org/show_bug.cgi?id=130463
2129         rdar://problem/20461342
2130
2131         Reviewed by Tim Horton.
2132
2133         This was more of a timing related flakiness than an actual OS version specific bug,
2134         we weren't getting window visibility notifications.
2135         
2136         I will look into adding this function call to DumpRenderTree separately, layout tests
2137         might actually rely on the broken behavior.
2138
2139         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2140         (TestWebKitAPI::TEST_F):
2141         * TestWebKitAPI/mac/mainMac.mm:
2142         (main):
2143
2144 2015-05-22  Dana Burkart  <dburkart@apple.com>
2145
2146         Add missing file from r184804 (mis-applied diff).
2147         https://bugs.webkit.org/show_bug.cgi?id=144814
2148
2149         Reviewed by Alexey Proskuryakov.
2150
2151         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
2152         (BuildbotStaticAnalyzerQueueView):
2153         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2154         (BuildbotStaticAnalyzerQueueView.prototype.update):
2155
2156 2015-05-22  Dana Burkart  <dburkart@apple.com>
2157
2158         Add support to the botwatchers dashboard for a static analyzer bot.
2159         https://bugs.webkit.org/show_bug.cgi?id=144814
2160
2161         Reviewed by Alexey Proskuryakov.
2162
2163         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2164         scan-build should be considered a productive step.
2165
2166         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2167         (BuildbotQueue):
2168         Adds support for the staticAnalyzer property
2169
2170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2171         (BuildbotTestResults.prototype._parseResults):
2172         Get bug count from the scan-build step output
2173
2174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2175         (documentReady):
2176         Rename the performance column 'Other', and merge the current 'Other' column with it.
2177
2178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2179         (WebKitBuildbot):
2180         Now that performance bots are part of the 'Other' column, give them better headings.
2181
2182 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2183
2184         Turn on autosaving of toolbar configuration in MiniBrowser
2185
2186         Rubber-stamped by Dan Bernstein.
2187
2188         * MiniBrowser/mac/BrowserWindow.xib:
2189
2190 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2191
2192         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
2193         https://bugs.webkit.org/show_bug.cgi?id=145297
2194
2195         Reviewed by Tim Horton.
2196
2197         This is a refactoring to simplify code, and to make it more logical.
2198
2199         It is up to the view to decide how to present the queues, and whether to split
2200         them into debug and release, or in some different way.
2201
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2203         (BuildbotBuilderQueueView.filterQueues):
2204         (BuildbotBuilderQueueView):
2205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2206         (BuildbotLeaksQueueView):
2207         (BuildbotLeaksQueueView.prototype.update):
2208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2209         (BuildbotPerformanceQueueView):
2210         (BuildbotPerformanceQueueView.prototype.update):
2211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2212         (BuildbotQueueView):
2213         (BuildbotQueueView.prototype._updateQueues):
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2215         (BuildbotTesterQueueView):
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2217         (documentReady):
2218
2219 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2220
2221         Remove action menu support
2222         https://bugs.webkit.org/show_bug.cgi?id=145305
2223         <rdar://problem/21070771>
2224
2225         Reviewed by Anders Carlsson.
2226
2227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2228         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
2229         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
2230         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
2231         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
2232         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
2233         Remove the tests.
2234
2235 2015-05-22  Dan Bernstein  <mitz@apple.com>
2236
2237         Removed the Use Shrink To Fit button from the toolbar’s default set.
2238
2239         Rubber-stamped by Tim Horton.
2240
2241         * MiniBrowser/mac/BrowserWindow.xib:
2242
2243 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
2244
2245         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
2246         https://bugs.webkit.org/show_bug.cgi?id=128420
2247
2248         Reviewed by Chris Fleizach.
2249
2250         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2251         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
2252
2253 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
2254
2255         [EFL] Bump libsoup version to 2.50.0
2256         https://bugs.webkit.org/show_bug.cgi?id=145127
2257
2258         Reviewed by Gyuyoung Kim.
2259
2260         * efl/jhbuild.modules:
2261         * efl/patches/soup-clang-warning-fix1.patch: Removed.
2262         * efl/patches/soup-clang-warning-fix2.patch: Removed.
2263
2264 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
2265
2266         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
2267         https://bugs.webkit.org/show_bug.cgi?id=145117
2268
2269         Reviewed by Csaba Osztrogonác.
2270
2271         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
2272         Tools/TestWebKitAPI/Tests/WTF/glib/.
2273
2274         * TestWebKitAPI/PlatformGTK.cmake:
2275         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
2276         (TestWebKitAPI::TEST):
2277
2278 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2279
2280         [EFL] fix efreet error
2281         https://bugs.webkit.org/show_bug.cgi?id=143670
2282
2283         Reviewed by Gyuyoung Kim.
2284
2285         Fix efreet error by using external variable efreet_cache_update.
2286         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
2287         efreet error for efreet_cache does not occur.
2288
2289         * MiniBrowser/efl/main.c:
2290         (elm_main):
2291
2292 2015-05-20  Michael Saboff  <msaboff@apple.com>
2293
2294         Add option to run_jsc_stress_tests to disable JIT testing
2295         https://bugs.webkit.org/show_bug.cgi?id=145233
2296
2297         Reviewed by Mark Lam.
2298
2299         Added --no-jit option.
2300
2301         * Scripts/run-jsc-stress-tests:
2302
2303 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2304
2305         Use correct String for StringView in WTF API tests
2306         https://bugs.webkit.org/show_bug.cgi?id=145226
2307         rdar://problem/20361786
2308
2309         Reviewed by Benjamin Poulain.
2310
2311         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2312         (TestWebKitAPI::TEST):
2313         Use patternHolder for pattern.
2314
2315 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2316
2317         [Content Extensions] Relax restrictions on triggers that match everything.
2318         https://bugs.webkit.org/show_bug.cgi?id=145069
2319
2320         Reviewed by Benjamin Poulain.
2321
2322         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2323         (TestWebKitAPI::TEST_F):
2324         Update and add tests for new possibilities with .*
2325
2326 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
2327
2328         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
2329         https://bugs.webkit.org/show_bug.cgi?id=144992
2330
2331         Reviewed by Gyuyoung Kim.
2332
2333         * MiniBrowser/efl/main.c:
2334         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
2335         (on_key_down):
2336         (on_fullscreen_enter):
2337         (on_fullscreen_exit):
2338         (window_create):
2339
2340 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2341
2342         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
2343         https://bugs.webkit.org/show_bug.cgi?id=145109
2344
2345         Reviewed by Darin Adler.
2346
2347         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2348         (TestWebKitAPI::TEST):
2349
2350 2015-05-19  Anders Carlsson  <andersca@apple.com>
2351
2352         Add alternate menu items for performing operations on the default data store
2353         https://bugs.webkit.org/show_bug.cgi?id=145184
2354
2355         Reviewed by Sam Weinig.
2356
2357         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
2358         associated with a data store.
2359
2360         * MiniBrowser/mac/AppDelegate.m:
2361         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
2362         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
2363         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
2364         * MiniBrowser/mac/MainMenu.xib:
2365
2366 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2367
2368         Fix tautological-compare warning in AtomicString.cpp
2369         https://bugs.webkit.org/show_bug.cgi?id=145120
2370
2371         Reviewed by Alexey Proskuryakov.
2372
2373         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2374         (TestWebKitAPI::TEST): Removed always true assert.
2375
2376 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
2377
2378         [EFL] Fix unsequenced warning in MiniBrowser's main.c
2379         https://bugs.webkit.org/show_bug.cgi?id=145123
2380
2381         Reviewed by Gyuyoung Kim.
2382
2383         * MiniBrowser/efl/main.c:
2384         (on_key_down):
2385
2386 2015-05-18  Daniel Bates  <dabates@apple.com>
2387
2388         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
2389         when staged non-empty file for commit
2390         https://bugs.webkit.org/show_bug.cgi?id=145082
2391
2392         Reviewed by Darin Adler.
2393
2394         Fixes two issues when running prepare-ChangeLog:
2395             1. The function above a deleted function is reported as changed.
2396             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
2397             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
2398             included in this patch).
2399
2400         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
2401         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
2402         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
2403         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
2404         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
2405         VCSUtil::parseChunkRange() has existing test coverage.
2406
2407         * Scripts/prepare-ChangeLog:
2408         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
2409         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
2410         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
2411         examine files that only have deletions. Currently this works as a side effect of the behavior of
2412         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
2413         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
2414         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
2415         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
2416         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2417         We return (-1, -1) when the change represents a deletion.
2418         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
2419         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2420         We return (-1, -1) when the change represents an addition.
2421         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
2422         unit tests.
2423
2424 2015-05-18  Anders Carlsson  <andersca@apple.com>
2425
2426         Add ATS keys to MiniBrowser
2427         https://bugs.webkit.org/show_bug.cgi?id=145141
2428
2429         Reviewed by Sam Weinig.
2430
2431         * MiniBrowser/mac/Info.plist:
2432
2433 2015-05-17  David Kilzer  <ddkilzer@apple.com>
2434
2435         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
2436         <http://webkit.org/b/145100>
2437
2438         Reviewed by Darin Adler.
2439
2440         * Scripts/bisect-builds:
2441         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
2442         - Switch to using PROMPT_RESPONSE_* constants when testing the
2443           value of $didReproduceBug.
2444         - Add do { } while loops to implement 'retry' mode.
2445         (promptForTest):
2446         - Switch to returning PROMPT_RESPONSE_* constants.
2447         - Add support for 'retry' response.
2448
2449 2015-05-16  Tanay C  <tanay.c@samsung.com>
2450
2451         [EFL][WK2] Minibrowser : Add search icon to search bar
2452         https://bugs.webkit.org/show_bug.cgi?id=139773
2453
2454         Reviewed by Gyuyoung Kim.
2455
2456         * MiniBrowser/efl/main.c: 
2457         (search_icon_show): Added.
2458         (search_box_show): Modified.
2459
2460 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2461
2462         run_benchmark should have an option to specify the number of runs
2463         https://bugs.webkit.org/show_bug.cgi?id=145091
2464
2465         Reviewed by Stephanie Lewis.
2466
2467         Added --count option.
2468
2469         * Scripts/run-benchmark:
2470         (main):
2471         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2472         (BenchmarkRunner.__init__):
2473
2474 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
2475
2476         Temporarily disable failing API test.
2477
2478         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2479         (TestWebKitAPI::TEST):
2480
2481 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
2482
2483         User interruption while running of run-webkit-tests should also generate results.html
2484         https://bugs.webkit.org/show_bug.cgi?id=122154
2485
2486         Reviewed by Csaba Osztrogonác.
2487
2488         Generation of results.html on execution of run-webkit-tests happens only
2489         on completion of entire layout tests run. It should be created even when
2490         the execution has been interrupted - either by user (by pressing Ctrl+C)
2491         or because of other interruptions (like exit-after-n-failures option).
2492
2493         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2494         (LayoutTestRunner.run_tests):
2495         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2496         (Manager.run):
2497         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2498         (TestRunResults.__init__):
2499         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2500         (main):
2501         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2502         (RunTest.test_keyboard_interrupt):
2503         (MainTest.test_exception_handling):
2504
2505 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
2506
2507         [buildbot] Fix the URL of the performance bots
2508         https://bugs.webkit.org/show_bug.cgi?id=145043
2509
2510         Reviewed by Ryosuke Niwa.
2511
2512         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2513
2514 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
2515
2516         Add a layout mode that scales down the view to try to fit the document
2517         https://bugs.webkit.org/show_bug.cgi?id=145022
2518         <rdar://problem/19790341>
2519
2520         Reviewed by Dean Jackson.
2521
2522         * MiniBrowser/mac/BrowserWindow.xib:
2523         * MiniBrowser/mac/BrowserWindowController.h:
2524         * MiniBrowser/mac/WK2BrowserWindowController.m:
2525         (-[WK2BrowserWindowController toggleShrinkToFit:]):
2526         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
2527         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
2528
2529 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2530
2531         [CMake] Don't read the LOCATION property of targets
2532         https://bugs.webkit.org/show_bug.cgi?id=145018
2533
2534         Reviewed by Martin Robinson.
2535
2536         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
2537         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
2538         be the same at configure-time as it is at generate-time.
2539
2540         * TestWebKitAPI/CMakeLists.txt:
2541
2542 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
2543
2544         Add String literal overloads to equalIgnoringASCIICase()
2545         https://bugs.webkit.org/show_bug.cgi?id=145008
2546
2547         Reviewed by Benjamin Poulain.
2548
2549         Test changes to WTF.
2550
2551         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2552         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
2553         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2554         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2555         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
2556         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2557
2558 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2559
2560         SharedBuffer::createWithContentsOfFile should use map file routines
2561         https://bugs.webkit.org/show_bug.cgi?id=144192
2562
2563         Reviewed by Darin Adler.
2564
2565         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
2566
2567         * TestWebKitAPI/PlatformGTK.cmake:
2568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2569         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
2570         (TestWebKitAPI::FileSystemTest::tempFilePath):
2571         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
2572         (TestWebKitAPI::TEST_F):
2573         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
2574         (TestWebKitAPI::SharedBufferTest::tempFilePath):
2575         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
2576         (TestWebKitAPI::TEST_F):
2577
2578 2015-05-13  Alex Christensen  <achristensen@webkit.org>
2579
2580         [Content Extensions] Test interactions between multiple extensions and multiple domains.
2581         https://bugs.webkit.org/show_bug.cgi?id=144967
2582
2583         Reviewed by Benjamin Poulain.
2584
2585         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2586         Xcode wanted to fix an alphabetization issue.
2587         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2588         (TestWebKitAPI::TEST_F):
2589         Test interactions that worked but were not explicitly tested before.
2590
2591 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2592
2593         Unreviewed build fix.
2594
2595         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
2596
2597         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
2598
2599 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2600
2601         Fix the previous commit, which made both bubbles green.
2602
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2604         (.status-line.good .bubble):
2605         (.status-line.bad .bubble):
2606         (.status-line.good .message):
2607
2608 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2609
2610         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
2611         https://bugs.webkit.org/show_bug.cgi?id=144929
2612
2613         Reviewed by Eric Carlson.
2614
2615         Tweaked colors as I see fit.
2616
2617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2618         (.status-line.good .bubble):
2619         (.status-line.bad .bubble):
2620
2621 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
2622
2623         [Mac] Share cookie storage between UI process and secondary processes
2624         https://bugs.webkit.org/show_bug.cgi?id=144820
2625         rdar://problem/20572830
2626
2627         Reviewed by Darin Adler.
2628
2629         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2630         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
2631         for testing.
2632
2633 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
2634
2635         Fix internal build configuration issues
2636         https://bugs.webkit.org/show_bug.cgi?id=144762
2637
2638         Reviewed by David Kilzer.
2639
2640         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
2641
2642         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2643         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2644         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2645         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2646         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
2647         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2648         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2649         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2650
2651 2015-05-12  David Kilzer  <ddkilzer@apple.com>
2652
2653         Switch to launching iOS Simulator using bundle ID
2654         <rdar://problem/20916096>
2655
2656         This is required to fix the layout tests on internal bots.
2657
2658         * Scripts/webkitdirs.pm:
2659         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
2660         Simulator.  Add FIXME.
2661         (quitIOSSimulator): Add FIXME.
2662         * Scripts/webkitpy/port/ios.py:
2663         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
2664         launch iOS Simulator.  Add FIXME.
2665         (IOSSimulatorPort.check_sys_deps): Add FIXME.
2666
2667 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
2668
2669         Fix run-javascriptcore-tests step on the WinCairo bot
2670         https://bugs.webkit.org/show_bug.cgi?id=144866
2671
2672         Reviewed by Csaba Osztrogonác.
2673
2674         Catch exception when failing to create soft link, so we can fall back to copy.
2675
2676         * Scripts/run-jsc-stress-tests:
2677
2678 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
2679
2680         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
2681         https://bugs.webkit.org/show_bug.cgi?id=116971
2682
2683         Reviewed by Chris Fleizach.
2684
2685         Implement rowAtIndex for ATK.
2686
2687         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2688         (WTR::AccessibilityUIElement::rowAtIndex):
2689
2690 2015-05-11  Dan Bernstein  <mitz@apple.com>
2691
2692         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
2693
2694         Reviewed by Alexey Proskuryakov.
2695
2696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2697         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
2698         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
2699         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
2700
2701 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
2702
2703         Fix internal build configuration issues
2704         https://bugs.webkit.org/show_bug.cgi?id=144762
2705
2706         Reviewed by Darin Adler.
2707
2708         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
2709
2710         * TestWebKitAPI/Configurations/Base.xcconfig:
2711         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2712         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2713         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2714         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2715         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2716         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2717
2718 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
2719
2720         [Win] Move Windows build target to Windows 7 (or newer)
2721         https://bugs.webkit.org/show_bug.cgi?id=144890
2722         <rdar://problem/20707307>
2723
2724         Reviewed by Anders Carlsson.
2725
2726         Update linked SDK and minimal Windows level to be compatible with
2727         Windows 7 or newer.
2728
2729         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2730         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2731         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2732         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2733         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2734         * DumpRenderTree/config.h:
2735         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2736         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2737         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2738         * WinLauncher/stdafx.h:
2739
2740 2015-05-11  Commit Queue  <commit-queue@webkit.org>
2741
2742         Unreviewed, rolling out r184119.
2743         https://bugs.webkit.org/show_bug.cgi?id=144888
2744
2745         broke JSC tests on Apple Windows bots (Requested by kling on
2746         #webkit).
2747
2748         Reverted changeset:
2749
2750         "Fix run-javascriptcore-tests step on the WinCairo bot"
2751         https://bugs.webkit.org/show_bug.cgi?id=144866
2752         http://trac.webkit.org/changeset/184119
2753
2754 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2755
2756         run-benchmark should support Dromaeo
2757         https://bugs.webkit.org/show_bug.cgi?id=144849
2758
2759         Reviewed by Chris Dumez.
2760
2761         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
2762         they can take as much as 15 minutes to run each.
2763
2764         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
2765         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
2766         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
2767         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
2768
2769 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2770
2771         Build fix. jetstream has a local copy, not remote archive.
2772
2773         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2774
2775 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2776
2777         run-benchmark should support SunSpider, Kraken and Octane
2778         https://bugs.webkit.org/show_bug.cgi?id=144840
2779
2780         Reviewed by Darin Adler.
2781
2782         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
2783         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
2784         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
2785         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
2786
2787         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
2788         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
2789
2790         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
2791         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
2792
2793         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
2794         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
2795         now has the ability to run an arbitrary "create script".
2796
2797         * Scripts/run-benchmark:
2798         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
2799         This also overrides the remote archive URL specified in the plan.
2800
2801         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
2802
2803         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
2804         JetStreamBenchmarkBuilder.
2805
2806         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
2807         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
2808         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
2809         _runCreateScript and _applyPatch to clean after themselves.
2810         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
2811         JetStream, SunSpider, Kraken all use this feature.
2812         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
2813         the leaf directory name since the latter is not available when a remote ZIP file is used.
2814         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
2815         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
2816         the benchmark name in the patches.
2817
2818         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
2819
2820         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2821         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
2822         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
2823         the browser opens by planName as the plan file no longer contains that.
2824
2825         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
2826         the top directory of JetStream instead of its parent.
2827         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
2828         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
2829         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
2830         the top directory of JetStream instead of its parent.
2831         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
2832         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
2833         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
2834         done in JetStream.patch.
2835         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
2836         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
2837         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
2838         path from the top directory of JetStream as done in JetStream.patch.
2839         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
2840
2841 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
2842
2843         Fix run-javascriptcore-tests step on the WinCairo bot
2844         https://bugs.webkit.org/show_bug.cgi?id=144866
2845
2846         Reviewed by Darin Adler.
2847
2848         * Scripts/run-jsc-stress-tests:
2849
2850 2015-05-11  Alex Christensen  <achristensen@webkit.org>
2851
2852         [Content Extensions] Support domain-specific rules and exceptions.
2853         https://bugs.webkit.org/show_bug.cgi?id=144833
2854
2855         Reviewed by Darin Adler.
2856
2857         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2858         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2859         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2860         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2861         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
2862         (TestWebKitAPI::mainDocumentRequest):
2863         (TestWebKitAPI::subResourceRequest):
2864         (TestWebKitAPI::TEST_F):
2865         (TestWebKitAPI::checkCompilerError):
2866         Added tests for parsing and functionality of if-domain and unless-domain.
2867
2868 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2869
2870         run-benchmark should support Chrome Canary and Firefox Nightly
2871         https://bugs.webkit.org/show_bug.cgi?id=144850
2872
2873         Reviewed by Darin Adler.
2874
2875         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
2876
2877         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
2878
2879         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
2880         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
2881         (OSXBrowserDriver):
2882         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
2883         (OSXBrowserDriver.closeBrowsers): Ditto.
2884         (OSXBrowserDriver.launchProcess): Ditto.
2885         (OSXBrowserDriver.terminateProcesses): Ditto.
2886         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2887         (OSXChromeDriver): Removed the unused self.chromePreferences.
2888         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
2889         (OSXChromeDriver.closeBrowsers): Ditto.
2890         (OSXChromeDriver.launchUrl):
2891         (OSXChromeCanaryDriver): Added.
2892         (OSXChromeCanaryDriver.launchUrl):
2893         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
2894         (OSXFirefoxDriver): Added.
2895         (OSXFirefoxDriver.launchUrl):
2896         (OSXFirefoxNightlyDriver): Added.
2897         (OSXFirefoxNightlyDriver.launchUrl):
2898         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2899         (OSXSafariDriver):
2900         (OSXSafariDriver.closeBrowsers):
2901
2902 2015-05-11  Tim Horton  <timothy_horton@apple.com>
2903
2904         Page overlay action context override should indicate the source of the request
2905         https://bugs.webkit.org/show_bug.cgi?id=144832
2906         <rdar://problem/20562594>
2907
2908         Reviewed by Darin Adler.
2909
2910         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2911         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2912
2913 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
2914
2915         [GTK] fast/events/page-visibility-transition-test.html is timing out
2916         https://bugs.webkit.org/show_bug.cgi?id=114789
2917
2918         Reviewed by Darin Adler.
2919
2920         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2921         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
2922         requests visibility changes.
2923
2924 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2925
2926         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
2927         https://bugs.webkit.org/show_bug.cgi?id=144798
2928
2929         Reviewed by Darin Adler.
2930
2931         * efl/install-dependencies:
2932
2933 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
2934
2935         Make arguments of run-benchmark more user friendly
2936         https://bugs.webkit.org/show_bug.cgi?id=144835
2937
2938         Reviewed by Darin Adler.
2939
2940         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
2941         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
2942         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
2943         default values from --platform and --browser as they are required arguments.
2944
2945         * Scripts/run-benchmark:
2946         (main): Made --build-directory optional, and removed default values from --platform and --browser.
2947         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
2948         are not dynamically obtained via BrowserDriverFactory.
2949         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2950         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
2951         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
2952         run any benchmark in that case.
2953         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
2954         the specified file isn't a valid relative or an absolute path.
2955         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2956         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
2957         and browsers.
2958         (BrowserDriverFactory.available_browsers): Ditto.
2959         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2960         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
2961         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
2962         browserBuildPath was None.
2963         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2964         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
2965         so that we can use locally built WebKit to launch Safari.
2966
2967 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
2968
2969         Remove the PICTURE_SIZES build flag
2970         https://bugs.webkit.org/show_bug.cgi?id=144679
2971
2972         Reviewed by Benjamin Poulain.
2973
2974         Removed the PICTURE_SIZES build time flag.
2975
2976         * Scripts/webkitperl/FeatureList.pm:
2977
2978 2015-05-09  David Kilzer  <ddkilzer@apple.com>
2979
2980         Layout tests broke due to unexpected simctl output
2981
2982         * Scripts/webkitpy/xcode/simulator.py:
2983         (Simulator._parse_devices): Handle new Device Pairs header.
2984         * Scripts/webkitpy/xcode/simulator_unittest.py:
2985         (test_device_pairs): Add unit test for Device Pairs header.
2986
2987 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2988
2989         Remove convenience constructors for TextRun
2990         https://bugs.webkit.org/show_bug.cgi?id=144752
2991
2992         Reviewed by Anders Carlsson.
2993
2994         Test the StringView which takes a StringImpl*.
2995
2996         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2997         (StringView8Bit): Testing is8Bit() on StringView
2998
2999 2015-05-07  Sam Weinig  <sam@webkit.org>
3000
3001         [Content Extensions] Add simple tester that takes an extension and compiles it
3002         https://bugs.webkit.org/show_bug.cgi?id=144781
3003
3004         Reviewed by Dan Bates.
3005
3006         * ContentExtensionTester: Added.
3007         * ContentExtensionTester/Configurations: Added.
3008         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
3009         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
3010         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
3011         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
3012         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
3013         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
3014         * ContentExtensionTester/main.m: Added.
3015         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
3016
3017 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
3018
3019         Build fix.
3020
3021         Reviewed by Dan Bernstein.
3022
3023         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3024         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3025         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
3026         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3027         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3028         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3029         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
3030         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3031
3032 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
3033
3034         [GTK] Some tests fail because they do not assume the popup menu captures click events
3035         https://bugs.webkit.org/show_bug.cgi?id=40601
3036
3037         Reviewed by Carlos Garcia Campos.
3038
3039         Popdown all attached menus when moving between tests and between each new
3040         event sent to the WebView. This prevents context and popup menus from eating
3041         events.
3042
3043         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
3044         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
3045         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3046         (WTR::dispatchEvent): Popdown all menus between dispatching events.
3047         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
3048         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
3049         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3050         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
3051         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3052         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
3053         longer in the platform-independent file.
3054         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
3055
3056 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
3057
3058         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3059         https://bugs.webkit.org/show_bug.cgi?id=144746
3060
3061         Reviewed by Carlos Garcia Campos.
3062
3063         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3064
3065         * MiniBrowser/gtk/main.c:
3066         (main):
3067
3068 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3069
3070         Unreviewed, rolling out r183996.
3071         https://bugs.webkit.org/show_bug.cgi?id=144806
3072
3073         ASan detected use-after free (Requested by ap on #webkit).
3074
3075         Reverted changeset:
3076
3077         "Remove convenience constructors for TextRun"
3078         https://bugs.webkit.org/show_bug.cgi?id=144752
3079         http://trac.webkit.org/changeset/183996
3080
3081 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3082
3083         Remove convenience constructors for TextRun
3084         https://bugs.webkit.org/show_bug.cgi?id=144752
3085
3086         Reviewed by Anders Carlsson.
3087
3088         Test the StringView which takes a StringImpl*.
3089
3090         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3091         (StringView8Bit): Testing is8Bit() on StringView
3092
3093 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3094
3095         [GTK] WTR doesn't correctly handle the Escape key
3096         https://bugs.webkit.org/show_bug.cgi?id=144788
3097
3098         Reviewed by Martin Robinson.
3099
3100         Correctly handle 0x001B character code in GTK+ event sender to be
3101         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
3102         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
3103         to dismiss popup menus.
3104
3105         Fixes editing/selection/5354455-1.html.
3106
3107         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3108         (WTR::getGDKKeySymForKeyRef):
3109
3110 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3111
3112         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
3113         https://bugs.webkit.org/show_bug.cgi?id=144748
3114
3115         Reviewed by Sergio Villar Senin.
3116
3117         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3118         (testWebKitSettings): Check the new setting is correctly
3119         initialized and updated.
3120         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3121         (testWebContextSecurityFileXHR): Check XHR to local files is
3122         allowed from file URLs after changing the setting.
3123         (beforeAll): Add new test.
3124
3125 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3126
3127         Unreviewed, rolling out r183945.
3128         https://bugs.webkit.org/show_bug.cgi?id=144789
3129
3130         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
3131
3132         Reverted changeset:
3133
3134         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
3135         https://bugs.webkit.org/show_bug.cgi?id=144746
3136         http://trac.webkit.org/changeset/183945
3137
3138 2015-05-07  Anders Carlsson  <andersca@apple.com>
3139
3140         Build fixes.
3141
3142         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3143         (TestWebKitAPI::TEST):
3144         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3145         (TestWebKitAPI::TEST):
3146         Add casts.
3147
3148 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
3149
3150         GC has trouble with pathologically large array allocations
3151         https://bugs.webkit.org/show_bug.cgi?id=144609
3152
3153         Reviewed by Geoffrey Garen.
3154         
3155         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
3156         and it's a frequently requested feature.
3157         
3158         Also add the ability to run a test pretending that your system has a particular RAM size.
3159         This is useful for GC tests, and the new GC test that I added uses this.
3160
3161         * Scripts/run-javascriptcore-tests:
3162         (runJSCStressTests):
3163         * Scripts/run-jsc-stress-tests:
3164
3165 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
3166
3167         [EFL] Bump EFL version to 1.14.0
3168         https://bugs.webkit.org/show_bug.cgi?id=144743
3169
3170         Reviewed by Darin Adler.
3171
3172         Bump EFL and elementary version to 1.14.0 and removed
3173         md5sum, because it isn't used at all if hash is present.
3174
3175         * efl/jhbuild.modules:
3176
3177 2015-05-07  Saam Barati  <saambarati1@gmail.com>
3178
3179         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
3180         https://bugs.webkit.org/show_bug.cgi?id=144753
3181
3182         Reviewed by Mark Lam.
3183
3184         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3185
3186 2015-05-07  Beth Dakin  <bdakin@apple.com>
3187
3188         New force-related DOM events should fire in WK1 views
3189         https://bugs.webkit.org/show_bug.cgi?id=144663
3190         -and corresponding-
3191         rdar://problem/20281886
3192
3193         Reviewed by Sam Weinig.
3194
3195         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
3196         now. Just send nil. 
3197         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3198         (TestWebKitAPI::buildAndPerformTest):
3199
3200 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3201
3202         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3203         https://bugs.webkit.org/show_bug.cgi?id=144746
3204
3205         Reviewed by Martin Robinson.
3206
3207         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3208
3209         * MiniBrowser/gtk/main.c:
3210         (main):
3211
3212 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3213
3214         Revert "Introducing the Platform Abstraction Layer (PAL)"
3215         https://bugs.webkit.org/show_bug.cgi?id=144751
3216
3217         Unreviewed.
3218
3219         PAL should be a new target inside WebCore, rather than a top-level folder.
3220
3221         * Scripts/build-webkit: Add it to build-webkit.
3222
3223 2015-05-07  Ada Chan  <adachan@apple.com>
3224
3225         Add a test for WKPageCopySessionState() with filtering.
3226         https://bugs.webkit.org/show_bug.cgi?id=144666
3227
3228         Reviewed by Darin Adler.
3229
3230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3231         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
3232         (TestWebKitAPI::didFinishLoadForFrame):
3233         (TestWebKitAPI::setPageLoaderClient):
3234         (TestWebKitAPI::filterFirstItemCallback):
3235         (TestWebKitAPI::filterAllItemsCallback):
3236         (TestWebKitAPI::createSessionStates):
3237         (TestWebKitAPI::TEST):
3238
3239 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3240
3241         iOS build fix attempt
3242
3243         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
3244
3245         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3246
3247 2015-05-06  Matt Baker  <mattbaker@apple.com>
3248
3249         Unreviewed, updated my list of email addresses.
3250
3251         * Scripts/webkitpy/common/config/contributors.json:
3252
3253 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3254
3255         Do not link tools to WebKit2.framework
3256         https://bugs.webkit.org/show_bug.cgi?id=144699
3257
3258         Unreviewed build fix.
3259
3260         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3261         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3262         These linked to WebKit2 in two ways, eliminating the other one.
3263
3264 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3265
3266         Introducing the Platform Abstraction Layer (PAL)
3267         https://bugs.webkit.org/show_bug.cgi?id=143358
3268
3269         Reviewed by Simon Fraser.
3270
3271         * Scripts/build-webkit: Add it to build-webkit.
3272
3273 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3274
3275         Fix api tests after r183877.
3276
3277         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3278         (TestWebKitAPI::TEST_F):
3279         Generate all DFAs before compiling them.
3280
3281 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3282
3283         Do not link tools to WebKit2.framework
3284         https://bugs.webkit.org/show_bug.cgi?id=144699
3285
3286         Reviewed by Tim Horton.
3287
3288         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3290         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3291
3292 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3293
3294         [Content Extensions] Test splitting NFAs by max NFA size.
3295         https://bugs.webkit.org/show_bug.cgi?id=144659
3296
3297         Reviewed by Darin Adler.
3298
3299         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3300         (TestWebKitAPI::createNFAs):
3301         (TestWebKitAPI::TEST_F):
3302         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3303         (TestWebKitAPI::createNFAs):
3304
3305 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
3306
3307         Remove the remaining vestiges of SVG feature define
3308         https://bugs.webkit.org/show_bug.cgi?id=144655
3309
3310         Reviewed by Alexey Proskuryakov.
3311
3312         * Scripts/webkitperl/FeatureList.pm:
3313
3314 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
3315
3316         Add a layout mode for computing fixed layout size from a minimum size
3317         https://bugs.webkit.org/show_bug.cgi?id=144610
3318         <rdar://problem/19790341>
3319
3320         Reviewed by Simon Fraser.
3321
3322         * MiniBrowser/mac/BrowserWindow.xib:
3323         * MiniBrowser/mac/BrowserWindowController.h:
3324         * MiniBrowser/mac/WK1BrowserWindowController.m:
3325         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
3326         * MiniBrowser/mac/WK2BrowserWindowController.m:
3327         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
3328         Add a optional toolbar item to toggle a minimum view size of 1024x0.
3329
3330 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3331
3332         [Content Extensions] Release input NSString when finished copying it.
3333         https://bugs.webkit.org/show_bug.cgi?id=144642
3334
3335         Reviewed by Brian Weinstein.
3336
3337         * WebKitTestRunner/mac/TestControllerMac.mm:
3338         (WTR::TestController::platformConfigureViewForTest):
3339         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
3340
3341 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
3342
3343         Unreviewed test fix after r183798.
3344
3345         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3346         (convertToDRTLabel): Mimic behavior of Mac accessibility output
3347         so we can share results.
3348
3349 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3350
3351         [Content Extensions] Use less memory to store the json input.
3352         https://bugs.webkit.org/show_bug.cgi?id=144604
3353
3354         Reviewed by Benjamin Poulain.
3355
3356         * MiniBrowser/mac/ExtensionManagerWindowController.m:
3357         (-[ExtensionManagerWindowController add:]):
3358         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3359         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3360         * WebKitTestRunner/mac/TestControllerMac.mm:
3361         (WTR::TestController::platformConfigureViewForTest):
3362
3363 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3364
3365         Unreviewed. Make myself a WebKit reviewer.
3366
3367         * Scripts/webkitpy/common/config/contributors.json:
3368
3369 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
3370
3371         [GTK] r183783 breaks build
3372         https://bugs.webkit.org/show_bug.cgi?id=144632
3373
3374         Reviewed by Martin Robinson.
3375
3376         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
3377
3378         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3379         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3380
3381 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3382
3383         [Content Extensions] Combine NFAs properly and free memory as we compile.
3384         https://bugs.webkit.org/show_bug.cgi?id=144485
3385
3386         Reviewed by Benjamin Poulain.
3387
3388         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3389         (TestWebKitAPI::TEST_F):
3390         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
3391         Added tests for deep NFAs.
3392
3393 2015-05-04  Alex Christensen  <achristensen@webkit.org>
3394
3395         [Content Extensions] Use less memory when writing byte code to file
3396         https://bugs.webkit.org/show_bug.cgi?id=144602
3397
3398         Reviewed by Darin Adler.
3399
3400         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3401
3402 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3403
3404         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
3405         https://bugs.webkit.org/show_bug.cgi?id=144541
3406
3407         Reviewed by Žan Doberšek.
3408
3409         Add a test case to WorkQueue unit test, to check that sources of
3410         asynchronous IO operations running in the WorkQueue thread are
3411         dispatched by the WorkQueue main loop.
3412
3413         * TestWebKitAPI/PlatformGTK.cmake:
3414         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
3415         (TestWebKitAPI::TEST):
3416
3417 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3418
3419         Correct '--show-webview' option for Tiled Drawing tests
3420         https://bugs.webkit.org/show_bug.cgi?id=144621
3421
3422         Reviewed by Simon Fraser.
3423
3424         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
3425         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
3426
3427         * WebKitTestRunner/mac/TestControllerMac.mm:
3428         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
3429         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
3430
3431 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
3432
3433         Large array shouldn't be slow
3434         https://bugs.webkit.org/show_bug.cgi?id=144617
3435
3436         Reviewed by Geoffrey Garen.
3437         
3438         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
3439         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
3440         long-running. So, hash-map sort of belongs here.
3441
3442         * Scripts/run-jsc-benchmarks:
3443
3444 2015-05-04  Doug Russell  <d_russell@apple.com>
3445
3446         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
3447         https://bugs.webkit.org/show_bug.cgi?id=144489
3448
3449         Reviewed by Chris Fleizach.
3450
3451         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
3452         on the returned control.
3453         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
3454         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
3455         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
3456         Add support for setSelectedVisibleTextRange() in accessibility tests.
3457
3458         * DumpRenderTree/AccessibilityUIElement.cpp:
3459         (setSelectedVisibleTextRangeCallback):
3460         (AccessibilityUIElement::setSelectedVisibleTextRange):
3461         (AccessibilityUIElement::getJSClass):
3462         (AccessibilityUIElement::textMarkerForIndex): Deleted.
3463         * DumpRenderTree/AccessibilityUIElement.h:
3464         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3465         (AccessibilityUIElement::setSelectedVisibleTextRange):
3466         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3467         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3468         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
3469         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3470         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3471         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3472         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3473         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3474         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3475         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3476         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3477
3478 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3479
3480         [Win] Implement the "--show-webview" option for Windows
3481         https://bugs.webkit.org/show_bug.cgi?id=144589
3482
3483         Reviewed by Alex Christensen.
3484
3485         Add another runtime flag (--show-webview) that causes DumpRenderTree
3486         to draw its view on-screen, rather than the standard offscreen mode.
3487
3488         * DumpRenderTree/win/DumpRenderTree.cpp:
3489         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
3490         (initializeGlobalsFromCommandLineOptions): Recognize the new
3491         command-line argument, and set the global 'showWebView' state if
3492         appropriate.
3493
3494 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
3495
3496         Remove dead code from TestInvocationCairo.cpp
3497         https://bugs.webkit.org/show_bug.cgi?id=144564
3498
3499         Reviewed by Gyuyoung Kim.
3500
3501         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
3502
3503         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3504         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3505
3506 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
3507
3508         [GTK] Add libnotify in gtk install-dependencies
3509         https://bugs.webkit.org/show_bug.cgi?id=144379
3510
3511         Reviewed by Csaba Osztrogonác.
3512
3513         * gtk/install-dependencies:
3514
3515 2015-05-01  Dan Bernstein  <mitz@apple.com>
3516
3517         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
3518         https://bugs.webkit.org/show_bug.cgi?id=144501
3519
3520         Reviewed by Darin Adler.
3521
3522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3523         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
3524         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
3525         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
3526
3527 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3528
3529         check-webkit-style fails due to system pylint
3530         https://bugs.webkit.org/show_bug.cgi?id=144360
3531
3532         Reviewed by Darin Adler.
3533
3534         Make sure that the directory containing third party autoinstalled modules
3535         is at the beginning of the search path, to avoid conflicts with other
3536         versions of the same modules installed in the system (e.g. pylint).
3537
3538         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
3539         modules directory to sys.path, instead of appending it.
3540
3541 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3542
3543         Unreviewed, updated my list of email addresses.
3544
3545         * Scripts/webkitpy/common/config/contributors.json: Updated.
3546
3547 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
3548
3549         USE(...) macro should expect unprefixed variables
3550         https://bugs.webkit.org/show_bug.cgi?id=144454
3551
3552         Reviewed by Daniel Bates.
3553
3554         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
3555         * DumpRenderTree/config.h: Ditto.
3556         * TestWebKitAPI/config.h: Ditto.
3557
3558 2015-05-01  Basile Clement  <basile_clement@apple.com>
3559
3560         Unreviewed. Add myself as a commiter in contributors.json.
3561
3562         * Scripts/webkitpy/common/config/contributors.json:
3563
3564 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
3565
3566         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
3567         https://bugs.webkit.org/show_bug.cgi?id=144487
3568
3569         Reviewed by Ryosuke Niwa.
3570
3571         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3572         (BenchmarkRunner.merge): Fix bug.
3573         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
3574
3575 2015-05-01  Brady Eidson  <beidson@apple.com>
3576
3577         Add API to disable meta refreshes.
3578         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
3579
3580         Reviewed by Alexey Proskuryakov.
3581
3582         * DumpRenderTree/mac/DumpRenderTree.mm:
3583         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
3584
3585 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
3586
3587         Provide a runtime flag to run-webkit-tests that shows the test view
3588         https://bugs.webkit.org/show_bug.cgi?id=144079.
3589
3590         Unreviewed correction to r183651.
3591
3592         * WebKitTestRunner/TestController.cpp:
3593         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
3594         flag is included in the options dictionary passed to the PlatformWebView.
3595
3596 2015-05-01  Antti Koivisto  <antti@apple.com>
3597
3598         Remove network process load serialization code
3599         https://bugs.webkit.org/show_bug.cgi?id=144448
3600
3601         Reviewed by Alexey Proskuryakov.
3602
3603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3604         (WTR::InjectedBundle::beginTesting):
3605         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3606         (WTR::TestRunner::setSerializeHTTPLoads):
3607         (WTR::TestRunner::dispatchPendingLoadRequests):
3608
3609 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3610
3611         [GTK] Add libhyphen-dev to the build dependencies
3612         https://bugs.webkit.org/show_bug.cgi?id=144452
3613
3614         Reviewed by Martin Robinson.
3615
3616         * gtk/install-dependencies: Added hyphen as Fedora and Arch
3617         dependencies.
3618
3619 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
3620
3621         Provide a runtime flag to run-webkit-tests that shows the test view
3622         https://bugs.webkit.org/show_bug.cgi?id=144079.
3623
3624         Reviewed by Dean Jackson.
3625
3626         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
3627         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
3628         option:
3629         
3630         --additional-drt-flag="--show-webview"
3631
3632         * DumpRenderTree/mac/DumpRenderTree.mm:
3633         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
3634         '--show-webview' flag.
3635         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
3636         * WebKitTestRunner/Options.cpp:
3637         (WTR::Options::Options):
3638         (WTR::handleOptionShowWebView):
3639         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
3640         * WebKitTestRunner/Options.h:
3641         * WebKitTestRunner/TestController.cpp:
3642         (WTR::TestController::TestController):
3643         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
3644         * WebKitTestRunner/TestController.h:
3645         (WTR::TestController::shouldShowWebView):
3646         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3647         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
3648         options dictionary. If it is true, display the web view while running the test.