Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree...
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2
3         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
4         https://bugs.webkit.org/show_bug.cgi?id=208434
5
6         Reviewed by Chris Fleizach.
7
8         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
9         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
10         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
11         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
12         (WTR::AccessibilityController::accessibleElementById): Same as above.
13
14 2020-03-02  John Wilander  <wilander@apple.com>
15
16         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
17         https://bugs.webkit.org/show_bug.cgi?id=208399
18         <rdar://problem/24731650>
19
20         Reviewed by Brent Fulgham.
21
22         The majority of the changes in WTR::TestController is (partially) fixing a bug
23         where the TestRunner would statically use the default website datastore instead
24         of the website data store configure for the page. This worked for persistent
25         storage testing but not for ephemeral sessions which is what this patch is all
26         about. The previous TestController::websiteDataStore() is now called
27         TestController::defaultWebsiteDataStore() and the new
28         TestController::websiteDataStore() returns the configured website data store.
29         Most of the use of the default website data store should probably change but
30         that's not really for this patch to deal with. I did however move all of
31         resource load statistics' use to the new TestController::websiteDataStore().
32
33         A new TestRunner function was added: isStatisticsEphemeral()
34         It allows test cases to query the ephemeral status of resource load statistics.
35
36         One problem that is mitigated in this patch but not fully fixed is that for
37         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
38         TestController::generatePageConfiguration() via C API 
39         WKPageConfigurationSetWebsiteDataStore(), and then again in 
40         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
41         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
42         I tried removing the latter since one session for all platforms should be
43         Enough but got broken behavior as a result. So now both are still there
44         and both enable resource load statistics.
45
46         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
47         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
48         (WTR::TestRunner::isStatisticsEphemeral):
49         * WebKitTestRunner/InjectedBundle/TestRunner.h:
50         * WebKitTestRunner/TestController.cpp:
51         (WTR::TestController::defaultWebsiteDataStore):
52         (WTR::TestController::websiteDataStore):
53         (WTR::TestController::generatePageConfiguration):
54         (WTR::TestController::resetPreferencesToConsistentValues):
55         (WTR::TestController::resetStateToConsistentValues):
56         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
57         (WTR::TestController::decidePolicyForNavigationAction):
58         (WTR::TestController::platformAdjustContext):
59         (WTR::TestController::clearServiceWorkerRegistrations):
60         (WTR::TestController::clearDOMCache):
61         (WTR::TestController::clearDOMCaches):
62         (WTR::TestController::clearIndexedDatabases):
63         (WTR::TestController::clearLocalStorage):
64         (WTR::TestController::hasDOMCache):
65         (WTR::TestController::domCacheSize):
66         (WTR::TestController::setStatisticsEnabled):
67         (WTR::TestController::isStatisticsEphemeral):
68         (WTR::TestController::setStatisticsDebugMode):
69         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
70         (WTR::TestController::setStatisticsLastSeen):
71         (WTR::TestController::setStatisticsMergeStatistic):
72         (WTR::TestController::setStatisticsPrevalentResource):
73         (WTR::TestController::setStatisticsVeryPrevalentResource):
74         (WTR::TestController::dumpResourceLoadStatistics):
75         (WTR::TestController::isStatisticsPrevalentResource):
76         (WTR::TestController::isStatisticsVeryPrevalentResource):
77         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
78         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
79         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
80         (WTR::TestController::setStatisticsHasHadUserInteraction):
81         (WTR::TestController::isStatisticsHasHadUserInteraction):
82         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
83         (WTR::TestController::setStatisticsGrandfathered):
84         (WTR::TestController::isStatisticsGrandfathered):
85         (WTR::TestController::setUseITPDatabase):
86         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
87         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
88         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
89         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
90         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
91         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
92         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
93         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
94         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
95         (WTR::TestController::statisticsUpdateCookieBlocking):
96         (WTR::TestController::statisticsSubmitTelemetry):
97         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
98         (WTR::TestController::setStatisticsIsRunningTest):
99         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
100         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
101         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
102         (WTR::TestController::setStatisticsGrandfatheringTime):
103         (WTR::TestController::setStatisticsMaxStatisticsEntries):
104         (WTR::TestController::setStatisticsPruneEntriesDownTo):
105         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
106         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
107         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
108         (WTR::TestController::statisticsDeleteCookiesForHost):
109         (WTR::TestController::isStatisticsHasLocalStorage):
110         (WTR::TestController::setStatisticsCacheMaxAgeCap):
111         (WTR::TestController::hasStatisticsIsolatedSession):
112         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
113         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
114         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
115         (WTR::TestController::statisticsResetToConsistentState):
116         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
117         * WebKitTestRunner/TestController.h:
118         * WebKitTestRunner/TestInvocation.cpp:
119         (WTR::TestInvocation::invoke):
120         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
121         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
122         (WTR::initializeWebViewConfiguration):
123         (WTR::TestController::platformCreateWebView):
124
125 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
126
127         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
128         https://bugs.webkit.org/show_bug.cgi?id=208415
129
130         Reviewed by Brent Fulgham.
131
132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
133         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
134         (TEST):
135
136 2020-03-02  Daniel Bates  <dabates@apple.com>
137
138         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
139         https://bugs.webkit.org/show_bug.cgi?id=208352
140         <rdar://problem/59867815>
141
142         Reviewed by Wenson Hsieh.
143
144         Update test results to reflect the new behavior. To do this I also need to fix up the test code
145         to actually scroll the web content. This also means we now execute the same code on both Mac and
146         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
147         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
148         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
149
150         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
151         (TEST):
152
153 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
154
155         Unreviewed, rolling out r257687.
156
157         This commit caused debug tests to crash for macOS & iOS
158
159         Reverted changeset:
160
161         "[Cocoa] Mapping from MIME type to UTI type should be done in
162         the UI process"
163         https://bugs.webkit.org/show_bug.cgi?id=208415
164         https://trac.webkit.org/changeset/257687
165
166 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
167
168         Unreviewed, rolling out r257618.
169
170         This allegedly causes Safari to crash when closing a window
171         (see rdar://problem/59922725).
172
173         Reverted changeset:
174
175         "UIProcess crash after using _prepareForMoveToWindow, then
176         deallocating the WKWebView before moving to the window"
177         https://bugs.webkit.org/show_bug.cgi?id=208365
178         https://trac.webkit.org/changeset/257618
179
180 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
181
182         Remove std::lock_guard
183         https://bugs.webkit.org/show_bug.cgi?id=206451
184
185         Reviewed by Anders Carlsson.
186
187         Add std::lock_guard lint rule to prevent from using it.
188
189         * Scripts/webkitpy/style/checkers/cpp.py:
190         (check_lock_guard):
191         (check_style):
192         (CppChecker):
193         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
194         (WebKitStyleTest.test_lock_guard):
195         * TestWebKitAPI/Tests/WTF/Condition.cpp:
196         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
197         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
198         (assertHasObjects):
199         (assertHasOnlyObjects):
200         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
201         (WTR::AXThread::dispatch):
202         (WTR::AXThread::dispatchFunctionsFromAXThread):
203         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
204         (WTR::AXThread::initializeRunLoop):
205
206 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
207
208         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
209         https://bugs.webkit.org/show_bug.cgi?id=208415
210
211         Reviewed by Brent Fulgham.
212
213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
214         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
215         (TEST):
216
217 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
218
219         Unreviewed, rolling out r257565.
220
221         It broke WinCairo MiniBrowser
222
223         Reverted changeset:
224
225         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
226         https://bugs.webkit.org/show_bug.cgi?id=206894
227         https://trac.webkit.org/changeset/257565
228
229 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
230
231         EWS fails to retry build in case of kill-old-processes exception
232         https://bugs.webkit.org/show_bug.cgi?id=208003
233
234         Reviewed by Jonathan Bedard.
235
236         * BuildSlaveSupport/ews-build/steps.py:
237         (KillOldProcesses.evaluateCommand):
238         (KillOldProcesses.getResultSummary):
239
240 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
241
242         [ews] commit-queue should update the ChangeLog with Reviewer name
243         https://bugs.webkit.org/show_bug.cgi?id=206535
244
245         Reviewed by Jonathan Bedard.
246
247         * BuildSlaveSupport/ews-build/steps.py:
248         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
249
250 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
251
252         run-javascriptcore-tests: Make upload format valid
253         https://bugs.webkit.org/show_bug.cgi?id=208341
254
255         Rubber-stamped by Aakash Jain.
256
257         * Scripts/run-javascriptcore-tests:
258         (uploadResults): Remove. FIXME.
259         * Scripts/webkitdirs.pm:
260         (splitVersionString): Handle case where the subminor version number has a - in it.
261         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
262
263 2020-02-28  youenn fablet  <youenn@apple.com>
264
265         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
266         https://bugs.webkit.org/show_bug.cgi?id=208130
267
268         Reviewed by Eric Carlson.
269
270         * WebKitTestRunner/TestOptions.h:
271         Use GPU process to capture by default.
272         We will remove this option once done verifying that every test works smoothly.
273
274 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
275
276         [ews] commit queue should skip building and testing for rollout patches
277         https://bugs.webkit.org/show_bug.cgi?id=208329
278
279         Reviewed by Jonathan Bedard.
280
281         * BuildSlaveSupport/ews-build/steps.py:
282         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
283         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
284         (RunWebKit1Tests.doStepIf): Ditto.
285         * BuildSlaveSupport/ews-build/steps_unittest.py:
286         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
287         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
288
289 2020-02-28  Daniel Bates  <dabates@apple.com>
290
291         Update my watch list preferences and contributor's entry.
292
293         * Scripts/webkitpy/common/config/contributors.json:
294         * Scripts/webkitpy/common/config/watchlist:
295
296 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
297
298         Fix WebCore export macros for declspec
299         https://bugs.webkit.org/show_bug.cgi?id=208363
300
301         Reviewed by Konstantin Tokarev.
302
303         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
304         files. Removed precompiled headers that were empty.
305
306         * DumpRenderTree/DumpRenderTreePrefix.h:
307         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
308         * MiniBrowser/win/stdafx.h:
309         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
310         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
311         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
312         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
313         * WebKitTestRunner/PlatformFTW.cmake:
314         * WebKitTestRunner/PlatformWin.cmake:
315         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
316
317 2020-02-27  Tim Horton  <timothy_horton@apple.com>
318
319         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
320         https://bugs.webkit.org/show_bug.cgi?id=208365
321
322         Reviewed by Alex Christensen.
323
324         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
325         (TEST):
326         Add a test! It was a 100% repro crash before this change.
327
328 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
329
330         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
331         https://bugs.webkit.org/show_bug.cgi?id=208260
332         <rdar://problem/59820107>
333
334         Reviewed by Tim Horton.
335
336         Followed instructions for adding an Info.plist for Single-File Tools
337         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
338
339         The default WebsiteDataStore file path will change with this test to
340         reflect the new bundleID so we must change expectations for any api
341         tests which rely on knowing the path.
342
343         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
345         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
346         (TEST):
347         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
348         (TEST):
349         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
350         (TEST):
351         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
352         (TEST):
353         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
354         (TEST):
355         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
356         (TEST):
357         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
358         (TEST):
359         (defaultWebsiteCacheDirectory):
360         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
361         (TEST):
362         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
363         (TEST):
364         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
365         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
366         (TEST):
367         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
368         (TEST):
369         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
370         (runWebsiteDataStoreCustomPaths):
371         (TEST):
372         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
373         (TestWebKitAPI::resetTestState):
374         Now that we set a bundleID, we have to reset the cache model between
375         tests, otherwise it gets stored between tests.
376
377         (TestWebKitAPI::TEST):
378         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
379         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
380
381 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
382
383         TextManipulationController should not generate a new item for content in manipulated paragraphs
384         https://bugs.webkit.org/show_bug.cgi?id=208286
385
386         Reviewed by Wenson Hsieh.
387
388         Added a regression test.
389
390         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
391         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
392
393 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
394
395         run-javascriptcore-tests: Make upload format valid
396         https://bugs.webkit.org/show_bug.cgi?id=208341
397
398         Reviewed by Aakash Jain.
399
400         * Scripts/run-javascriptcore-tests:
401         (uploadResults): Print json blob for upload after failure for debugging.
402
403 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
404
405         [CMake] Add WebKit::PAL target
406         https://bugs.webkit.org/show_bug.cgi?id=198493
407
408         Reviewed by Michael Catanzaro.
409
410         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
411
412         * DumpRenderTree/PlatformWin.cmake:
413
414 2020-02-27  Alex Christensen  <achristensen@webkit.org>
415
416         Add SPI to query WKFrameInfos in a WKWebView
417         https://bugs.webkit.org/show_bug.cgi?id=208212
418
419         Reviewed by Brady Eidson.
420
421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
422         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
423         * WebKitTestRunner/TestController.cpp:
424         (WTR::TestController::saltForOrigin):
425
426 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
427
428         Unreviewed, rolling out r257530.
429
430         This commit seems to have broke the build internally for
431         watchOS
432
433         Reverted changeset:
434
435         "Add SPI to query WKFrameInfos in a WKWebView"
436         https://bugs.webkit.org/show_bug.cgi?id=208212
437         https://trac.webkit.org/changeset/257530
438
439 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
440
441         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
442         https://bugs.webkit.org/show_bug.cgi?id=206894
443
444         Reviewed by Adrian Perez de Castro.
445
446         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
447         MiniBrowsers.
448
449         * MiniBrowser/gtk/CMakeLists.txt:
450         * MiniBrowser/win/CMakeLists.txt:
451         * MiniBrowser/wpe/CMakeLists.txt:
452
453 2020-02-26  Alex Christensen  <achristensen@webkit.org>
454
455         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
456         https://bugs.webkit.org/show_bug.cgi?id=206456
457
458         Reviewed by Brady Eidson.
459
460         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
461         (TEST):
462
463 2020-02-26  Alex Christensen  <achristensen@webkit.org>
464
465         _WKUserContentWorld should be a wrapper around WKContentWorld
466         https://bugs.webkit.org/show_bug.cgi?id=208274
467
468         Reviewed by Brady Eidson.
469
470         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
471         (TEST):
472         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
473         (TEST):
474
475 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
476
477         Unreviewed, rolling out r257522.
478
479         Caused 16 API test failures on the bots
480
481         Reverted changeset:
482
483         "TestWebKitAPI and WebKitTestRunner should have bundle
484         identifiers"
485         https://bugs.webkit.org/show_bug.cgi?id=208260
486         https://trac.webkit.org/changeset/257522
487
488 2020-02-26  Alex Christensen  <achristensen@webkit.org>
489
490         Add SPI to query WKFrameInfos in a WKWebView
491         https://bugs.webkit.org/show_bug.cgi?id=208212
492
493         Reviewed by Brady Eidson.
494
495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
496         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
497         * WebKitTestRunner/TestController.cpp:
498         (WTR::TestController::saltForOrigin):
499
500 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
501
502         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
503         https://bugs.webkit.org/show_bug.cgi?id=208260
504         <rdar://problem/59820107>
505
506         Reviewed by Tim Horton.
507
508         Followed instructions for adding an Info.plist for Single-File Tools
509         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
510
511         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
512         * TestWebKitAPI/Info.plist: Added.
513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
514         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
515         * WebKitTestRunner/Info.plist: Added.
516         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
517
518 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
519
520         Tests should each use a unique ResourceLoadStatistics file path for its database store
521         https://bugs.webkit.org/show_bug.cgi?id=208206
522         <rdar://problem/59690272>
523
524         Reviewed by Brady Eidson.
525
526         Initialize a default website data store before checking for the ITP
527         store to ensure the directory exists after the file has been deleted.
528
529         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
530         (TEST):
531
532 2020-02-26  Christopher Reid  <chris.reid@sony.com>
533
534         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
535         https://bugs.webkit.org/show_bug.cgi?id=197684
536         <rdar://problem/59467397>
537
538         Reviewed by Yusuke Suzuki.
539
540         Add test for FileSystem::createFile
541
542         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
543
544 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
545
546         [ews] commit-queue should verify patch committer and reviewer
547         https://bugs.webkit.org/show_bug.cgi?id=206532
548
549         Reviewed by Jonathan Bedard.
550
551         * BuildSlaveSupport/ews-build/steps.py:
552         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
553         (ValidateCommiterAndReviewer._addToLog):
554         (ValidateCommiterAndReviewer.getResultSummary):
555         (ValidateCommiterAndReviewer.fail_build):
556         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
557         (ValidateCommiterAndReviewer.is_reviewer):
558         (ValidateCommiterAndReviewer.is_committer):
559         (ValidateCommiterAndReviewer.full_name_from_email):
560         (ValidateCommiterAndReviewer.start):
561
562 2020-02-26  Daniel Bates  <dabates@apple.com>
563
564         [iOS] Send focus update immediately on becoming or resigning first responder
565         https://bugs.webkit.org/show_bug.cgi?id=208082
566         <rdar://problem/59688413>
567
568         Rubber-stamped by Jer Noble.
569
570         Add a test to ensure that selecting a position at a point after the web view
571         becomes first responder is allowed. Such an operation is only allowed if the
572         web view is focused.
573
574         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
575         (-[TestWKWebView selectPositionAtPoint:]):
576         (TEST):
577         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
578
579 2020-02-26  Chris Dumez  <cdumez@apple.com>
580
581         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
582
583         The test was added for macOS and times out on iOS.
584
585         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
586         (TEST):
587
588 2020-02-26  Youenn Fablet  <youenn@apple.com>
589
590         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
591         https://bugs.webkit.org/show_bug.cgi?id=208238
592
593         Reviewed by Eric Carlson.
594
595         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
596         (TEST):
597         Remove use of deleted parameter.
598
599 2020-02-25  Devin Rousso  <drousso@apple.com>
600
601         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
602         https://bugs.webkit.org/show_bug.cgi?id=206911
603         <rdar://problem/58026635>
604
605         Reviewed by Brian Burg.
606
607         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
608         (TestWebKitAPI::TEST):
609         Add test for `WTF::HashSet::reserveInitialCapacity`.
610
611         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
612         (TestWebKitAPI::TEST):
613         Actually check the value of `WTF::HashMap::capacity`.
614
615         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
616         (-[InspectorDelegate _webView:didAttachInspector:])
617         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
618         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
619         (TestWebKitAPI::TEST):
620         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
621         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
622         (TestWebKitAPI::TEST): Deleted.
623
624 2020-02-25  Matt Lewis  <jlewis3@apple.com>
625
626         Add checkout_root to stubrepository.py
627         https://bugs.webkit.org/show_bug.cgi?id=208213
628
629         Reviewed by Jonathan Bedard.
630
631         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
632         (StubRepository.__init__):
633
634         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
635         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
636
637 2020-02-25  Daniel Bates  <dabates@apple.com>
638
639         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
640         https://bugs.webkit.org/show_bug.cgi?id=208214
641
642         Reviewed by Wenson Hsieh.
643
644         Wait until the copy operation completes before loading the second web view and testing paste
645         to ensure that something was actually copied to the clipboard.
646
647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
648         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
649         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
650         so that we wait until the command completes.
651
652 2020-02-25  Chris Dumez  <cdumez@apple.com>
653
654         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
655         https://bugs.webkit.org/show_bug.cgi?id=208199
656         <rdar://problem/59746887>
657
658         Reviewed by Alex Christensen.
659
660         Add API test coverage.
661
662         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
663         (TEST):
664
665 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
666
667         spinRunLoop should take a non-zero integer as parameter
668         https://bugs.webkit.org/show_bug.cgi?id=208148
669         <rdar://problem/59766682>
670
671         Unreviewed iOS build fix.
672
673         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
674         (TestWebKitAPI::Util::spinRunLoop):
675
676 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
677
678         spinRunLoop should take a non-zero integer as parameter
679         https://bugs.webkit.org/show_bug.cgi?id=208148
680
681         Reviewed by Darin Adler.
682
683         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
684         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
685         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
686         (TestWebKitAPI::Util::spinRunLoop):
687
688 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
689
690         [WTF] Add tests for CompactRefPtrTuple
691         https://bugs.webkit.org/show_bug.cgi?id=208172
692
693         Reviewed by Darin Adler.
694
695         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
696         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
697
698         * TestWebKitAPI/CMakeLists.txt:
699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
700         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
701         (TestWebKitAPI::TEST):
702
703 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
704
705         [ews] commit-queue should check that patch have appropriate review flag
706         https://bugs.webkit.org/show_bug.cgi?id=208138
707
708         Reviewed by Jonathan Bedard.
709
710         * BuildSlaveSupport/ews-build/steps.py:
711         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
712         (BugzillaMixin._is_patch_cq_plus):
713         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
714         (ValidatePatch.start):
715
716 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
717
718         [WebAuthn] Implement SPI for the platform authenticator
719         https://bugs.webkit.org/show_bug.cgi?id=208087
720         <rdar://problem/59369305>
721
722         Reviewed by Brent Fulgham.
723
724         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
725
726         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
727         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
729         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
730         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
731         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
732         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
733         (TestWebKitAPI::TEST):
734         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
735         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
736         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
737         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
738
739 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
740
741         Unreviewed, updating LLDB test for CompactPointerTuple.
742         https://bugs.webkit.org/show_bug.cgi?id=207827
743
744         * lldb/lldb_webkit.py:
745         (WTFCompactPointerTupleProvider):
746         (WTFCompactPointerTupleProvider.update):
747
748 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
749
750         Provide alternate way to name Web Content process
751         https://bugs.webkit.org/show_bug.cgi?id=205224
752         rdar://57038084
753
754         Reviewed by Alex Christensen.
755
756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
757         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
758         (TestWebKitAPI::TEST):
759
760 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
761
762         results.webkit.org: Link to result archives
763         https://bugs.webkit.org/show_bug.cgi?id=207646
764         <rdar://problem/59395807>
765
766         Rubber-stamped by Aakash Jain.
767
768         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
769         (_ArchiveRouter): Retrieve json from archive-router endpoint.
770         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
771         return the most specific value.
772         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
773         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
774         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
775         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
776         (parametersForInstance): Extract from lambda function.
777         (testRunLink): Use parametersForInstance instead of a lambda function.
778         (archiveLink): Return an archive link for data. 
779         (contentForData): Add archive link to view.
780         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
781         (TimelineFromEndpoint): Accept both suite and test.
782         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
783         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
784         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
785         * resultsdbpy/resultsdbpy/view/view_routes.py:
786         (ViewRoutes.__init__): Add archive_route dictionary.
787
788 2020-02-24  Alex Christensen  <achristensen@webkit.org>
789
790         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
791         https://bugs.webkit.org/show_bug.cgi?id=208035
792         <rdar://problem/58011337>
793
794         Reviewed by Tim Hatcher.
795
796         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
797
798 2020-02-22  Darin Adler  <darin@apple.com>
799
800         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
801         https://bugs.webkit.org/show_bug.cgi?id=208099
802
803         Reviewed by Antti Koivisto.
804
805         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
806         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
807         so we can use the -[NSString createJSStringRef] method.
808         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
809         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
810
811 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
812
813         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
814         https://bugs.webkit.org/show_bug.cgi?id=208096
815         <rdar://problem/59632008>
816
817         Reviewed by Alexey Proskuryakov.
818
819         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
820         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
821         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
822
823         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
824         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
825         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
826         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
827         in the credit card expiry field.
828
829         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
830
831         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
832         * TestRunnerShared/UIScriptContext/UIScriptController.h:
833         (WTR::UIScriptController::setDefaultCalendarType):
834         * WebKitTestRunner/TestController.h:
835
836         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
837         identifier and calendar locale identifier.
838
839         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
840         (WTR::swizzledCalendar):
841         (WTR::TestController::overriddenCalendarIdentifier const):
842         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
843
844         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
845
846         (WTR::TestController::setDefaultCalendarType):
847
848         Plumb the new calendar's locale identifier through this method.
849
850         (WTR::TestController::cocoaResetStateToConsistentValues):
851         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
852         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
853         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
854         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
855
856 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
857
858         App-bound domains should have separate Network Sessions
859         https://bugs.webkit.org/show_bug.cgi?id=208026
860         <rdar://problem/59434006>
861
862         Reviewed by Brent Fulgham.
863
864         This patch is mostly test infrastructure involving 3 functions.
865         One sets in-app browser privacy as enabled in the network process
866         manually for the test. One ensures that setting the WebView category
867         works properly, and the last one checks for an app-bound session for
868         an app-bound navigation.
869
870         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
871         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
872         (WTR::InjectedBundle::didReceiveMessageToPage):
873         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
874         (WTR::TestRunner::getWebViewCategory):
875         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
876         (WTR::TestRunner::hasAppBoundSession):
877         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
878         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
879         * WebKitTestRunner/InjectedBundle/TestRunner.h:
880         * WebKitTestRunner/TestController.cpp:
881         (WTR::TestController::ensureViewSupportsOptionsForTest):
882         Clearing the bundleID should happen right before setting a new one, 
883         otherwise it clears the ID after it is set and returns a null ID.
884
885         (WTR::TestController::resetStateToConsistentValues):
886         (WTR::TestController::getWebViewCategory):
887         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
888         (WTR::inAppBrowserPrivacyBooleanResultCallback):
889         (WTR::inAppBrowserPrivacyVoidResultCallback):
890         (WTR::TestController::hasAppBoundSession):
891         (WTR::TestController::setInAppBrowserPrivacyEnabled):
892         * WebKitTestRunner/TestController.h:
893         * WebKitTestRunner/TestInvocation.cpp:
894         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
895         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
896         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
897         (WTR::TestInvocation::didReceivePrevalentDomains):
898         (WTR::TestInvocation::didReceiveWebViewCategory):
899         * WebKitTestRunner/TestInvocation.h:
900         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
901         (WTR::TestController::getWebViewCategory):
902
903 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
904
905         Build DumpRenderTree and WebKitTestRunner for macCatalyst
906         https://bugs.webkit.org/show_bug.cgi?id=208068
907         <rdar://problem/59676596>
908
909         Reviewed by Tim Horton.
910
911         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
912         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
913         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
914         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
915         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
916         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
917         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
918         * DumpRenderTree/mac/EventSendingController.h: Ditto.
919         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
920         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
921         * Makefile: Add DumpRenderTree and WebKitTestRunner.
922         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
923         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
924         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
925
926 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
927
928         [ews] Add build step to Validate ChangeLog for commit-queue
929         https://bugs.webkit.org/show_bug.cgi?id=208064
930
931         Reviewed by Jonathan Bedard.
932
933         * BuildSlaveSupport/ews-build/steps.py:
934         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
935         (ValidateChangeLogAndReviewer.start):
936         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
937         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
938
939 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
940
941         [ews] Add build step to set cq- flag on bugzilla patch
942         https://bugs.webkit.org/show_bug.cgi?id=208021
943
944         Reviewed by Jonathan Bedard.
945
946         * BuildSlaveSupport/ews-build/steps.py:
947         (BugzillaMixin.set_cq_minus_flag_on_patch):
948         (SetCommitQueueMinusFlagOnPatch):
949         (SetCommitQueueMinusFlagOnPatch.start):
950         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
951
952 2020-02-20  Matt Lewis  <jlewis3@apple.com>
953
954         Stub repositories fail to upload some results due to missing head svn revision
955         https://bugs.webkit.org/show_bug.cgi?id=207684
956
957         Reviewed by Jonathan Bedard.
958
959         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
960         (MockHost.__init__):
961         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
962         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
963         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
964         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
965         * Scripts/webkitpy/port/base.py:
966         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
967         from using mock SCMs and more
968         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
969
970 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
971
972         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
973         https://bugs.webkit.org/show_bug.cgi?id=208051
974
975         Reviewed by Carlos Alberto Lopez Perez.
976
977         Verbose flag prints out each test name executed. Without this flag
978         stdout prints out one or two periods.
979
980         * BuildSlaveSupport/build.webkit.org-config/steps.py:
981         (RunJavaScriptCoreTests.start):
982
983 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
984
985         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
986         https://bugs.webkit.org/show_bug.cgi?id=207984
987
988         Reviewed by Daniel Bates.
989
990         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
991         (TestWebKitAPI::TEST):
992
993 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
994
995         [GTK] Improve user agent quirk for Google Docs and Google Drive
996         https://bugs.webkit.org/show_bug.cgi?id=206506
997
998         Reviewed by Carlos Garcia Campos.
999
1000         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1001         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
1002         (TestWebKitAPI::TEST):
1003
1004 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1005
1006         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
1007         https://bugs.webkit.org/show_bug.cgi?id=207380
1008
1009         Reviewed by Jonathan Bedard.
1010
1011         Added a new rule 'build/export_macro'.
1012
1013         Removed a obsolete rule 'readability/webkit_export' which was used
1014         only by Chromium port (r148185).
1015
1016         * Scripts/webkitpy/style/checkers/cpp.py:
1017         (_FunctionState.export_macro):
1018         (check_function_definition):
1019         (_unix_path): Added.
1020         (is_generated_file): Use _unix_path.
1021         (check_has_config_header): Ditto.
1022         (CppChecker):
1023         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1024         (WebKitStyleTest.test_export_macro_check):
1025         (WebKitStyleTest.test_webkit_export_check): Deleted.
1026
1027 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1028
1029         [Win][MiniBrowser] Add prettier toolbar button icons
1030         https://bugs.webkit.org/show_bug.cgi?id=207999
1031
1032         Reviewed by Ross Kirsling.
1033
1034         Use a custom toolbar button icons instead of system stock icons.
1035
1036         Fixed a bug toolbar button dropdown arrows always looked being
1037         hovered. TBSTYLE_FLAT should be given.
1038
1039         Removed the window border line of Progress Indicator.
1040
1041         * MiniBrowser/win/MainWindow.cpp:
1042         (MainWindow::createToolbar):
1043         * MiniBrowser/win/MiniBrowserLib.rc:
1044         * MiniBrowser/win/MiniBrowserLibResource.h:
1045         * MiniBrowser/win/toolbar.bmp: Added.
1046
1047 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
1048
1049         Update run-webkit-tests help description for skip-failing-tests
1050         https://bugs.webkit.org/show_bug.cgi?id=208031
1051
1052         Reviewed by Alexey Proskuryakov.
1053
1054         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1055
1056 2020-02-20  Chris Dumez  <cdumez@apple.com>
1057
1058         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
1059         https://bugs.webkit.org/show_bug.cgi?id=208015
1060         <rdar://problem/59591630>
1061
1062         Reviewed by Geoffrey Garen.
1063
1064         Add API test coverage.
1065
1066         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
1067         (TEST):
1068
1069 2020-02-20  Tim Horton  <timothy_horton@apple.com>
1070
1071         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
1072         https://bugs.webkit.org/show_bug.cgi?id=207998
1073         <rdar://problem/40942425>
1074
1075         Reviewed by Sam Weinig.
1076
1077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1078         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
1079         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1080         (TestWebKitAPI::TEST):
1081         Add some tests for top content insets.
1082
1083 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
1084
1085         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
1086         https://bugs.webkit.org/show_bug.cgi?id=207910
1087
1088         Unreviewed infrastructure fix.
1089
1090         * Scripts/run-javascriptcore-tests:
1091         (configurationForUpload): Use the major version instead of the sub-minor version
1092         for version name.
1093
1094 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
1095
1096         [CMake] Add WPE::libwpe target
1097         https://bugs.webkit.org/show_bug.cgi?id=207970
1098
1099         Reviewed by Adrian Perez de Castro.
1100
1101         Use the WPE::libwpe target.
1102
1103         * MiniBrowser/wpe/CMakeLists.txt:
1104         * TestWebKitAPI/PlatformWPE.cmake:
1105         * TestWebKitAPI/glib/PlatformWPE.cmake:
1106         * wpe/backends/CMakeLists.txt:
1107
1108 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1109
1110         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
1111         https://bugs.webkit.org/show_bug.cgi?id=207749
1112
1113         Reviewed by Ross Kirsling.
1114
1115         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
1116
1117         * MiniBrowser/win/MainWindow.cpp:
1118         (MainWindow::createToolbar):
1119         (MainWindow::WndProc):
1120         (MainWindow::setDefaultURLToCurrentURL):
1121         (MainWindow::goHome): Added.
1122         (MainWindow::onURLBarEnter):
1123         * MiniBrowser/win/MainWindow.h:
1124         * MiniBrowser/win/MiniBrowserLib.rc:
1125         * MiniBrowser/win/MiniBrowserLibResource.h:
1126         * MiniBrowser/win/MiniBrowserReplace.h:
1127         * MiniBrowser/win/WinMain.cpp:
1128         (wWinMain):
1129
1130 2020-02-19  Peng Liu  <peng.liu6@apple.com>
1131
1132         Fix check-webkit-style errors related to AVFoundationSPI.h
1133         https://bugs.webkit.org/show_bug.cgi?id=207834
1134
1135         Reviewed by Daniel Bates.
1136
1137         Revert the change in r256770 regarding the headers ordering.
1138         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
1139
1140         * Scripts/webkitpy/style/checkers/cpp.py:
1141         (check_include_line):
1142
1143 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
1144
1145         results.webkit.org: Correctly report JSC tests for windows
1146         https://bugs.webkit.org/show_bug.cgi?id=207910
1147
1148         Rubber-stamped by Aakash Jain.
1149
1150         * Scripts/run-javascriptcore-tests:
1151         (configurationForUpload): Give Windows a version name.
1152         * Scripts/webkitdirs.pm:
1153         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
1154         Version dictionary.
1155
1156 2020-02-19  Chris Dumez  <cdumez@apple.com>
1157
1158         Unreviewed, fix assertions in storage access API layout tests after r256882.
1159
1160         Drop dead testRunner code to toggle storage access API feature.
1161
1162         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1163         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1164         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
1165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1166         * WebKitTestRunner/TestInvocation.cpp:
1167         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1168
1169 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
1170
1171         [WPE] Support 2D axis, smooth-motion events
1172         https://bugs.webkit.org/show_bug.cgi?id=207881
1173
1174         Reviewed by Carlos Garcia Campos.
1175
1176         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
1177
1178 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
1179
1180         Unreviewed, rolling out r256851.
1181
1182         Broke internal bots
1183
1184         Reverted changeset:
1185
1186         "Stub repositories fail to upload some results due to missing
1187         head svn revision"
1188         https://bugs.webkit.org/show_bug.cgi?id=207684
1189         https://trac.webkit.org/changeset/256851
1190
1191 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1192
1193         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
1194         https://bugs.webkit.org/show_bug.cgi?id=207883
1195
1196         Reviewed by Ross Kirsling.
1197
1198         Unlike other mouse buttons, 4th and 5th mouse buttons are
1199         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
1200         WM_XBUTTONUP events to the window under the mouse cursor.
1201         Unhandled WM_XBUTTONUP events are automatically converted to
1202         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
1203         parent window.
1204         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
1205
1206         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
1207         handled.
1208
1209         * MiniBrowser/win/BrowserWindow.h:
1210         * MiniBrowser/win/MainWindow.cpp:
1211         (MainWindow::WndProc):
1212         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1213         (WebKitBrowserWindow::navigateForwardOrBackward):
1214         * MiniBrowser/win/WebKitBrowserWindow.h:
1215         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1216         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
1217         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1218
1219 2020-02-18  Alex Christensen  <achristensen@webkit.org>
1220
1221         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
1222         https://bugs.webkit.org/show_bug.cgi?id=207912
1223         <rdar://problem/59556922>
1224
1225         Reviewed by Brian Weinstein.
1226
1227         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1228         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1229         (TEST):
1230         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1231         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
1232
1233 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1234
1235         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
1236         https://bugs.webkit.org/show_bug.cgi?id=207899
1237         <rdar://problem/55658207>
1238
1239         Reviewed by Tim Horton and Simon Fraser.
1240
1241         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
1242
1243         * WebKitTestRunner/TestController.cpp:
1244         (WTR::updateTestOptionsFromTestHeader):
1245         * WebKitTestRunner/TestOptions.h:
1246         (WTR::TestOptions::hasSameInitializationOptions const):
1247         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1248         (WTR::TestController::platformCreateWebView):
1249
1250 2020-02-18  Matt Lewis  <jlewis3@apple.com>
1251
1252         Stub repositories fail to upload some results due to missing head svn revision
1253         https://bugs.webkit.org/show_bug.cgi?id=207684
1254
1255         Reviewed by Jonathan Bedard.
1256
1257         * Scripts/webkitpy/api_tests/run_api_tests.py:
1258         (main): Added initializing the scm to the host object.
1259         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1260         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1261         it in line with modern code.
1262         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1263         (main): Added inializing the scm to the host object.
1264         * Scripts/webkitpy/port/base.py:
1265         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
1266         from using mock SCMs and more
1267         * Scripts/webkitpy/test/main.py:
1268         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
1269         and converted the webkit_root variable to the SCM checkout root.
1270         (Tester._run_tests):
1271
1272 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
1273
1274         Move [UIDevice currentDevice] calls to UI process
1275         https://bugs.webkit.org/show_bug.cgi?id=204320
1276
1277         Reviewed by Darin Adler.
1278
1279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1280         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
1281         (TEST):
1282
1283 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
1284
1285         Move from "layer flush" terminology to "rendering update"
1286         https://bugs.webkit.org/show_bug.cgi?id=207870
1287
1288         Reviewed by Tim Horton.
1289
1290         Rename various functions and member variables to move away from the legacy "layer flush"
1291         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
1292         that we have layers is an implementation detail.
1293         
1294         Change LayerFlushThrottlingState to be an OptionSet<>.
1295
1296         * Tracing/SystemTracePoints.plist:
1297
1298 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
1299
1300         [Webkit.css] Adding popover style element
1301         This help to prevent us reinventing the wheel ever again
1302         https://bugs.webkit.org/show_bug.cgi?id=207787
1303
1304         Reviewed by Dean Jackson.
1305
1306         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
1307         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
1308         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1309         (.popover):
1310         (.popover>.content):
1311         (.popover.display):
1312         (.popover .arrow):
1313         (.popover .arrow.point-top):
1314         (.popover .arrow.point-bottom):
1315         (.popover .arrow.point-left):
1316         (.popover .arrow.point-right):
1317         (@media (prefers-color-scheme: dark) .popover>.content):
1318         (@media (prefers-color-scheme: dark) .popover.display):
1319         (@media (prefers-color-scheme: dark) .popover .arrow):
1320         (.popover>.content>.section): Deleted.
1321         (.popover:focus>.content, .popover:hover>.content): Deleted.
1322         (.popover.right>.content): Deleted.
1323         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
1324         (.popover.left>.content): Deleted.
1325         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
1326         (.popover.bottom>.content): Deleted.
1327         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
1328
1329 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
1330
1331         Update WebKit Tools to issue mach extensions as needed
1332         https://bugs.webkit.org/show_bug.cgi?id=207850
1333         <rdar://problem/59521019>
1334
1335         Reviewed by Per Arne Vollan.
1336
1337         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
1338         to its child processes (WebContent, GPU, Network, etc.) as needed.
1339
1340         * MiniBrowser/MiniBrowser.entitlements:
1341         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
1342         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1344         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
1345
1346 2020-02-17  Peng Liu  <peng.liu6@apple.com>
1347
1348         Fix check-webkit-style errors related to AVFoundationSPI.h
1349         https://bugs.webkit.org/show_bug.cgi?id=207834
1350
1351         Reviewed by Eric Carlson.
1352
1353         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
1354         Soft-link headers can be included as either "file.h" or <file.h>.
1355
1356         * Scripts/webkitpy/style/checkers/cpp.py:
1357         (_classify_include):
1358         (check_include_line):
1359
1360 2020-02-17  Keith Rollin  <krollin@apple.com>
1361
1362         Unreviewed build fix after r256715.
1363
1364         Fix tvOS and watchOS builds.
1365
1366         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1367
1368 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
1369
1370         Use CF prefs direct mode in the WebContent process
1371         https://bugs.webkit.org/show_bug.cgi?id=203420
1372
1373         Reviewed by Brent Fulgham.
1374
1375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1376         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
1377         (TEST):
1378
1379 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1380
1381         EWS should be able to file Bugzilla bugs
1382         https://bugs.webkit.org/show_bug.cgi?id=207845
1383
1384         Reviewed by Alexey Proskuryakov.
1385
1386         * BuildSlaveSupport/ews-build/steps.py:
1387         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
1388
1389 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1390
1391         EWS should be able to comment on Bugzilla
1392         https://bugs.webkit.org/show_bug.cgi?id=201927
1393
1394         Reviewed by Jonathan Bedard.
1395
1396         * BuildSlaveSupport/ews-build/steps.py:
1397         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
1398         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
1399         (BugzillaMixin.close_bug): Ditto.
1400         (CommentOnBug): Build step to comment on bugzilla bug.
1401
1402 2020-02-17  Antti Koivisto  <antti@apple.com>
1403
1404         [macOS] Add trace points for layer flush runloop observer
1405         https://bugs.webkit.org/show_bug.cgi?id=207837
1406
1407         Reviewed by Sam Weinig.
1408
1409         * Tracing/SystemTracePoints.plist:
1410
1411 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
1412
1413         [CMake] Use builtin targets
1414         https://bugs.webkit.org/show_bug.cgi?id=205166
1415
1416         Reviewed by Darin Adler.
1417
1418         * TestWebKitAPI/PlatformWin.cmake:
1419
1420 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1421
1422         [ews] add SetBuildSummary step for Windows EWS
1423         https://bugs.webkit.org/show_bug.cgi?id=207556
1424
1425         Reviewed by Jonathan Bedard.
1426
1427         * BuildSlaveSupport/ews-build/factories.py:
1428         (WindowsFactory.__init__):
1429         (GTKBuildAndTestFactory.__init__):
1430         * BuildSlaveSupport/ews-build/factories_unittest.py:
1431         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
1432
1433 2020-02-17  Alberto Garcia  <berto@igalia.com>
1434
1435         [WPE] Change the QML plugin install path
1436         https://bugs.webkit.org/show_bug.cgi?id=207761
1437
1438         Reviewed by Philippe Normand.
1439
1440         * Scripts/run-qt-wpe-minibrowser:
1441         * glib/api_test_runner.py:
1442         (TestRunner._run_test_qt):
1443
1444 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1445
1446         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
1447         https://bugs.webkit.org/show_bug.cgi?id=207746
1448
1449         Reviewed by Don Olmstead.
1450
1451         * MiniBrowser/win/stdafx.h:
1452
1453 2020-02-16  Brady Eidson  <beidson@apple.com>
1454
1455         Expose "allowsContentJavaScript" on WKWebpagePreferences
1456         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
1457
1458         Reviewed by Darin Adler.
1459
1460         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1461         (TEST):
1462         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1463         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1464         (TEST):
1465         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
1466         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1467         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1468         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1469         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
1470         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
1471         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1472         * TestWebKitAPI/cocoa/TestWKWebView.h:
1473         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1474         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
1475
1476 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
1477
1478         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
1479         https://bugs.webkit.org/show_bug.cgi?id=207747
1480
1481         Reviewed by Keith Miller.
1482
1483         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
1484         (TestWebKitAPI::TEST):
1485
1486 2020-02-14  Alex Christensen  <achristensen@webkit.org>
1487
1488         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
1489         https://bugs.webkit.org/show_bug.cgi?id=207360
1490         <rdar://problem/57825317>
1491
1492         Reviewed by Ryosuke Niwa.
1493
1494         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1495         (TestWebKitAPI::TEST):
1496
1497 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
1498
1499         [CMake] Add Fontconfig::Fontconfig target
1500         https://bugs.webkit.org/show_bug.cgi?id=207730
1501
1502         Reviewed by Adrian Perez de Castro.
1503
1504         Use the Fontconfig::Fontconfig target.
1505
1506         * WebKitTestRunner/PlatformGTK.cmake:
1507
1508 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
1509
1510          Expose prevalent domains on a per-page basis
1511          https://bugs.webkit.org/show_bug.cgi?id=207523
1512          <rdar://problem/59270758>
1513
1514         Reviewed by Chris Dumez.
1515
1516         Added WebKitTestRunner functions so this functionality can be tested.
1517         clearPrevalentDomains should be called between tests to reset the
1518         state.
1519
1520         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1521         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1522         (WTR::InjectedBundle::didReceiveMessageToPage):
1523         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1524         (WTR::TestRunner::getPrevalentDomains):
1525         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
1526         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1527         * WebKitTestRunner/TestController.cpp:
1528         (WTR::TestController::resetStateToConsistentValues):
1529         (WTR::TestController::getPrevalentDomains):
1530         (WTR::TestController::clearPrevalentDomains):
1531         * WebKitTestRunner/TestController.h:
1532         * WebKitTestRunner/TestInvocation.cpp:
1533         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1534         (WTR::TestInvocation::didReceivePrevalentDomains):
1535         * WebKitTestRunner/TestInvocation.h:
1536         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1537         (WTR::TestController::getPrevalentDomains):
1538         (WTR::TestController::clearPrevalentDomains):
1539
1540 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1541
1542         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
1543         https://bugs.webkit.org/show_bug.cgi?id=207682
1544
1545         Reviewed by Ross Kirsling.
1546
1547         The toolbar placed button common controls as the toolbar buttons.
1548         However, because these buttons are focusable, shortcut keys don't
1549         work after clicking them.
1550
1551         Added Home button, Add to Bookmarks button, dropdown buttons of
1552         back and forward buttons, but they aren't implemented yet. Just
1553         placeholders at the moment.
1554
1555         * MiniBrowser/win/MainWindow.cpp:
1556         (MainWindow::createToolbar): Added.
1557         (MainWindow::resizeToolbar): Added.
1558         (MainWindow::rescaleToolbar): Added.
1559         (MainWindow::init):
1560         (MainWindow::resizeSubViews):
1561         (MainWindow::updateDeviceScaleFactor):
1562         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
1563
1564 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1565
1566         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
1567         https://bugs.webkit.org/show_bug.cgi?id=207676
1568
1569         Reviewed by Wenson Hsieh and Timothy Hatcher.
1570
1571         Added regression tests for pasting content with -apple-system-label and outdenting content.
1572
1573         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1574         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
1575         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
1576
1577 2020-02-13  Alex Christensen  <achristensen@webkit.org>
1578
1579         _WKResourceLoadInfo should conform to NSSecureCoding
1580         https://bugs.webkit.org/show_bug.cgi?id=207667
1581
1582         Reviewed by Brady Eidson.
1583
1584         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1585         (TEST):
1586
1587 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
1588
1589         [PlayStation] Add Buildbots for Debug/Release builds
1590         https://bugs.webkit.org/show_bug.cgi?id=199454
1591
1592         Reviewed by Aakash Jain.
1593
1594         * BuildSlaveSupport/build.webkit.org-config/config.json:
1595         Add PlayStation slaves, builders
1596         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1597         Use higher timeout for playstation as with win bot
1598         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
1599         Set PlayStation category for playstation platform
1600         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1601         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
1602         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1603         Add PlayStation expectations
1604
1605 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
1606
1607         [iOS] Check if PIP is supported in the UI process
1608         https://bugs.webkit.org/show_bug.cgi?id=207406
1609
1610         Reviewed by Brent Fulgham.
1611
1612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1613         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
1614         (TEST):
1615
1616 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
1617
1618         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
1619         https://bugs.webkit.org/show_bug.cgi?id=207397
1620         <rdar://problem/59268128>
1621
1622         Reviewed by Jer Noble.
1623
1624         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1625         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
1626
1627 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
1628
1629         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
1630         https://bugs.webkit.org/show_bug.cgi?id=207696
1631
1632         Reviewed by Tim Horton.
1633
1634         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1635
1636 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1637
1638         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
1639         https://bugs.webkit.org/show_bug.cgi?id=207680
1640         <rdar://problem/59340940>
1641
1642         Reviewed by Tim Horton.
1643
1644         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
1645         the current selection works.
1646
1647         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1648         (-[TestWKWebView updateSelectionWithExtentPoint:]):
1649         * TestWebKitAPI/ios/UIKitSPI.h:
1650
1651 2020-02-13  Said Abou-Hallawa  <said@apple.com>
1652
1653         Unreviewed, rolling out r255158, 255405 and r255486
1654
1655         Caused test flakiness and PLT regression.
1656
1657         * DumpRenderTree/mac/DumpRenderTree.mm:
1658         (resetWebPreferencesToConsistentValues):
1659         * DumpRenderTree/win/DumpRenderTree.cpp:
1660         (enableExperimentalFeatures):
1661         * WebKitTestRunner/TestController.cpp:
1662         (WTR::TestController::resetPreferencesToConsistentValues):
1663
1664 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
1665
1666         run-javascriptcore-tests: Allow insecure requests on upload
1667         https://bugs.webkit.org/show_bug.cgi?id=207662
1668
1669         Rubber-stamped by Aakash Jain.
1670
1671         * Scripts/run-javascriptcore-tests:
1672         (uploadResults): Allow insecure curl request when posting results.
1673
1674 2020-02-12  Truitt Savell  <tsavell@apple.com>
1675
1676         Unreviewed, rolling out r256463.
1677
1678         Caused major flakiness on Mac wk2
1679
1680         Reverted changeset:
1681
1682         "REGRESSION (r255158): http/tests/frame-throttling/raf-
1683         throttle-in-cross-origin-subframe.html is a flaky failure"
1684         https://bugs.webkit.org/show_bug.cgi?id=206839
1685         https://trac.webkit.org/changeset/256463
1686
1687 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
1688
1689         results.webkit.org: Remove debug JS logging
1690         https://bugs.webkit.org/show_bug.cgi?id=207663
1691
1692         Reviewed by Aakash Jain.
1693
1694         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
1695         (elapsed):
1696         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
1697         (_ToolTip.prototype.toString):
1698         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
1699         (prototype.addWithDelay):
1700         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
1701
1702 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
1703
1704         Remove CSS_DEVICE_ADAPTATION
1705         https://bugs.webkit.org/show_bug.cgi?id=203479
1706
1707         Reviewed by Tim Horton.
1708         
1709         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
1710         so remove the code.
1711
1712         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1713
1714 2020-02-12  Said Abou-Hallawa  <said@apple.com>
1715
1716         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
1717         https://bugs.webkit.org/show_bug.cgi?id=206839
1718
1719         Reviewed by Simon Fraser.
1720
1721         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
1722
1723         * DumpRenderTree/mac/DumpRenderTree.mm:
1724         (resetWebPreferencesToConsistentValues):
1725         * DumpRenderTree/win/DumpRenderTree.cpp:
1726         (enableExperimentalFeatures):
1727         * WebKitTestRunner/TestController.cpp:
1728         (WTR::TestController::resetPreferencesToConsistentValues):
1729
1730 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
1731
1732         results.webkit.org: Cache archive content
1733         https://bugs.webkit.org/show_bug.cgi?id=207589
1734
1735         Reviewed by Aakash Jain.
1736
1737         * resultsdbpy/resultsdbpy/flask_support/util.py:
1738         (cache_for): Add decorator function which sets the cache values on the returned response.
1739         * resultsdbpy/resultsdbpy/view/archive_view.py:
1740         (ArchiveView): Cache archive content client-side for 12 hours.
1741         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
1742         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
1743
1744 2020-02-12  Youenn Fablet  <youenn@apple.com>
1745
1746         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
1747         https://bugs.webkit.org/show_bug.cgi?id=207537
1748
1749         Reviewed by Chris Dumez.
1750
1751         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1752
1753 2020-02-11  Rob Buis  <rbuis@igalia.com>
1754
1755         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
1756         <https://webkit.org/b/207424>
1757         <rdar://problem/59250384>
1758
1759         Reviewed by Rob Buis.
1760
1761         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1762         (TestWebKitAPI::TEST): Add more tests.
1763
1764 2020-02-11  Commit Queue  <commit-queue@webkit.org>
1765
1766         Unreviewed, rolling out r256314.
1767         https://bugs.webkit.org/show_bug.cgi?id=207594
1768
1769         It is breaking an API test (Requested by youenn on #webkit).
1770
1771         Reverted changeset:
1772
1773         "WebSWServerConnection::registerServiceWorkerClient is not
1774         sending IPC message to UIProcess when it should"
1775         https://bugs.webkit.org/show_bug.cgi?id=207537
1776         https://trac.webkit.org/changeset/256314
1777
1778 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
1779
1780         results.webkit.org: Configuration documentation should include architecture
1781         https://bugs.webkit.org/show_bug.cgi?id=207584
1782
1783         Reviewed by Aakash Jain.
1784
1785         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
1786
1787 2020-02-11  Youenn Fablet  <youenn@apple.com>
1788
1789         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
1790         https://bugs.webkit.org/show_bug.cgi?id=207325
1791         <rdar://problem/59224810>
1792
1793         Reviewed by Eric Carlson.
1794
1795         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
1796         (TestWebKitAPI::TEST):
1797         Add a test validating that RTCRtpSender.getCapabilities does not return null.
1798         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1799
1800 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1801
1802         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
1803         https://bugs.webkit.org/show_bug.cgi?id=207557
1804
1805         Reviewed by Jonathan Bedard.
1806
1807         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
1808         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
1809         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
1810         around this by focusing an empty select element instead (for which we won't attempt to create and select any
1811         table view cells).
1812
1813         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1814
1815 2020-02-11  Alex Christensen  <achristensen@webkit.org>
1816
1817         Add WKHTTPCookieStore._getCookiesForURL SPI
1818         https://bugs.webkit.org/show_bug.cgi?id=207527
1819
1820         Reviewed by Brady Eidson.
1821
1822         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1823         (TEST):
1824
1825 2020-02-11  Youenn Fablet  <youenn@apple.com>
1826
1827         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
1828         https://bugs.webkit.org/show_bug.cgi?id=207537
1829
1830         Reviewed by Chris Dumez.
1831
1832         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1833
1834 2020-02-11  Lauro Moura  <lmoura@igalia.com>
1835
1836         [WPE][WebDriver] MiniBrowser should react to close session commands
1837         https://bugs.webkit.org/show_bug.cgi?id=207529
1838
1839         Reviewed by Carlos Garcia Campos.
1840
1841         WebDriver delete session command asks to close the WebView associated to the
1842         current automation session. We must react to it to avoid lots of
1843         timeouts and errors.
1844
1845         * MiniBrowser/wpe/main.cpp:
1846         (main): Listen to "close" signal on the main WebView.
1847
1848 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1849
1850         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
1851         https://bugs.webkit.org/show_bug.cgi?id=207525
1852         <rdar://problem/59110543>
1853
1854         Reviewed by Tim Horton.
1855
1856         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
1857         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
1858         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
1859         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
1860         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
1861         causing us to crash upon trying to create the dictionary.
1862
1863         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
1864         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
1865         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
1866         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
1867         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
1868         beginning of each API test.
1869
1870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1871         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1872         (overrideBundleIdentifier):
1873
1874         Move this to the top of the file, so it can be shared.
1875
1876         (+[WKWebView initialize]):
1877
1878         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
1879         internal class method that calls into the internal helper function, with no other side effects.
1880
1881         * TestWebKitAPI/ios/UIKitSPI.h:
1882
1883 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
1884
1885         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
1886         https://bugs.webkit.org/show_bug.cgi?id=207501
1887         <rdar://problem/59323414>
1888
1889         Reviewed by Alex Christensen.
1890
1891         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
1892         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
1893         The same behavior.
1894
1895 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
1896
1897         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
1898         https://bugs.webkit.org/show_bug.cgi?id=207352
1899         <rdar://problem/59115798>
1900
1901         Reviewed by Alex Christensen.
1902
1903         Add a test to exercise the new SPI.
1904
1905         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
1906         a webpage that contains text in subframes.
1907
1908
1909 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
1910
1911         [iOS] Crash when granting access to asset services
1912         https://bugs.webkit.org/show_bug.cgi?id=207520
1913
1914         Reviewed by Brent Fulgham.
1915
1916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1917         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
1918         (TEST):
1919
1920 2020-02-10  Chris Dumez  <cdumez@apple.com>
1921
1922         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
1923         https://bugs.webkit.org/show_bug.cgi?id=207481
1924
1925         Reviewed by Alexey Proskuryakov.
1926
1927         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
1928         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
1929         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
1930
1931         * DumpRenderTree/mac/DumpRenderTree.mm:
1932         (resetWebViewToConsistentStateBeforeTesting):
1933         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
1934         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
1935         over internal settings.
1936
1937 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
1938
1939         [watchOS] Notification listener is never unregistered
1940         https://bugs.webkit.org/show_bug.cgi?id=207459
1941
1942         Reviewed by Maciej Stachowiak.
1943
1944         Add a test which tests that posting a backlight level change notification will not cause a crash.
1945
1946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1947         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
1948         (TEST):
1949
1950 2020-02-10  James Howard  <jameshoward@mac.com>
1951
1952         Standard gamepad mapping for GameControllerGamepads
1953         https://bugs.webkit.org/show_bug.cgi?id=206033
1954
1955         Reviewed by Dean Jackson.
1956
1957         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1958         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1959         (WTR::TestRunner::setMockGamepadDetails):
1960         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1961         * WebKitTestRunner/TestInvocation.cpp:
1962         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1963
1964 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
1965
1966         [ews] Display flaky layout test names in build summary
1967         https://bugs.webkit.org/show_bug.cgi?id=207504
1968
1969         Reviewed by Jonathan Bedard.
1970
1971         * BuildSlaveSupport/ews-build/steps.py:
1972         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
1973         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
1974         (AnalyzeLayoutTestsResults.start):
1975
1976 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
1977
1978         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
1979         https://bugs.webkit.org/show_bug.cgi?id=207492
1980
1981         Reviewed by Jonathan Bedard.
1982
1983         * BuildSlaveSupport/ews-build/steps.py:
1984         (RunWebKitTests.evaluateCommand):
1985         (ReRunWebKitTests.evaluateCommand):
1986         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
1987         * BuildSlaveSupport/ews-build/factories.py:
1988         (TestFactory.__init__):
1989
1990 2020-02-10  Truitt Savell  <tsavell@apple.com>
1991
1992         Unreviewed, rolling out r256091.
1993
1994         Broke internal builds
1995
1996         Reverted changeset:
1997
1998         "Move trivial definitions from FeatureDefines.xcconfig to
1999         PlatformEnableCocoa.h"
2000         https://bugs.webkit.org/show_bug.cgi?id=207155
2001         https://trac.webkit.org/changeset/256091
2002
2003 2020-02-10  Truitt Savell  <tsavell@apple.com>
2004
2005         Unreviewed, rolling out r256103.
2006
2007         This patch is blocking the rollout of r256091
2008
2009         Reverted changeset:
2010
2011         "Move JavaScriptCore related feature defines from
2012         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
2013         https://bugs.webkit.org/show_bug.cgi?id=207436
2014         https://trac.webkit.org/changeset/256103
2015
2016 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2017
2018         results.webkit.org: Abstract archive storage solutions
2019         https://bugs.webkit.org/show_bug.cgi?id=207277
2020
2021         Rubber-stamped by Aakash Jain.
2022
2023         * resultsdbpy/resultsdbpy/model/archive_context.py:
2024         (ArchiveContext):
2025         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
2026         (ArchiveContext.__init__): Add archiver member.
2027         (ArchiveContext.__enter__): archiver is a context manager.
2028         (ArchiveContext.__exit__): Ditto.
2029         (ArchiveContext.register): The archiver member owns saving an archive.
2030         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
2031         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
2032         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
2033         (Archiver): Base class for all Archiving systems.
2034         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
2035         (Archiver.archive_size): Given a file-like archive, calculate it's size.
2036         (Archiver.save):
2037         (Archiver.retrieve):
2038         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
2039         (CassandraArchiver):
2040         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
2041         (CassandraArchiver.__init__):
2042         (CassandraArchiver.__enter__):
2043         (CassandraArchiver.__exit__):
2044         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
2045         from ArchiveContext.
2046         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
2047         from ArchiveContext.
2048
2049 2020-02-09  Lauro Moura  <lmoura@igalia.com>
2050
2051         [GTK][WPE] Expose allowTopNavigationToDataURL
2052         https://bugs.webkit.org/show_bug.cgi?id=207384
2053
2054         Reviewed by Adrian Perez de Castro.
2055
2056         Updates with new "allow-top-navigation-to-data-urls" property.
2057
2058         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2059         (testWebViewAllowModalDialogs): This test requires this property to be
2060         set.
2061         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2062         (testWebKitSettings): Added tests for getter/setter.
2063
2064 2020-02-08  Sam Weinig  <weinig@apple.com>
2065
2066         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2067         https://bugs.webkit.org/show_bug.cgi?id=207436
2068
2069         Reviewed by Tim Horton.
2070
2071         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2072         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
2073
2074 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
2075
2076         [WTF] Try using 75% load factor for HashTable
2077         https://bugs.webkit.org/show_bug.cgi?id=207183
2078
2079         Reviewed by Mark Lam.
2080
2081         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2082         (TestWebKitAPI::testInitialCapacity):
2083
2084 2020-02-08  Sam Weinig  <weinig@apple.com>
2085
2086         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2087         https://bugs.webkit.org/show_bug.cgi?id=207155
2088
2089         Reviewed by Tim Horton.
2090
2091         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2092         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2093         also has a default value in PlatformEnable.h
2094
2095         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2096
2097 2020-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2098
2099         Several iOS API tests that call -makeKeyWindow assert after r255907
2100         https://bugs.webkit.org/show_bug.cgi?id=207411
2101
2102         Reviewed by Tim Horton.
2103
2104         r255907 asserted in -makeKeyWindow that the shared UIApplication exists. While this was guaranteed for all call
2105         sites of -makeKeyWindow from API tests, -makeKeyWindow may also be invoked from within UIKit code; in this case,
2106         nothing guarantees that the application has been initialized, and we end up hitting this assertion. To fix this,
2107         replace the assertion with logic to bootstrap the shared UIApplication (if it didn't already exist).
2108
2109         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2110         (TestWebKitAPI::TEST):
2111         (TestWebKitAPI::overrideBundleIdentifier): Deleted.
2112         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2113         (overrideBundleIdentifier):
2114         (setOverriddenApplicationKeyWindow):
2115
2116 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2117
2118         TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
2119         https://bugs.webkit.org/show_bug.cgi?id=207405
2120
2121         Reviewed by Wenson Hsieh.
2122
2123         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2124
2125 2020-02-07  Alex Christensen  <achristensen@apple.com>
2126
2127         Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
2128         https://bugs.webkit.org/show_bug.cgi?id=207409
2129         rdar://problem/59275641
2130
2131         Reviewed by Chris Dumez.
2132
2133         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2134         (TestWebKitAPI::TEST):
2135
2136 2020-02-07  Ryan Haddad  <ryanhaddad@apple.com>
2137
2138         Unreviewed, rolling out r256051.
2139
2140         Broke internal builds.
2141
2142         Reverted changeset:
2143
2144         "Move trivial definitions from FeatureDefines.xcconfig to
2145         PlatformEnableCocoa.h"
2146         https://bugs.webkit.org/show_bug.cgi?id=207155
2147         https://trac.webkit.org/changeset/256051
2148
2149 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2150
2151         iPad testers failing to launch processes
2152         https://bugs.webkit.org/show_bug.cgi?id=207401
2153         <rdar://problem/58184777>
2154
2155         Unreviewed infrastructure fix.
2156
2157         This is a speculative fix because I've had problems reproducing this error.
2158         The only time I managed to reproduce the problem was immediately after killing the 
2159         SimulatorTrampoline and CoreSimulator.xpc processes.
2160
2161         * BuildSlaveSupport/kill-old-processes:
2162         (main): Only kill Simulator.app, not all associated simulator processes.
2163
2164 2020-02-07  Jiewen Tan  <jiewen_tan@apple.com>
2165
2166         [WebAuthn] Report CTAP Client Pin Error to clients
2167         https://bugs.webkit.org/show_bug.cgi?id=205837
2168         <rdar://problem/58356872>
2169
2170         Reviewed by Brent Fulgham.
2171
2172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2173         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2174         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2177         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-invalid-error-retry.html: Added.
2178         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2179         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2180         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-invalid-error-retry.html: Added.
2181         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-blocked-error.html: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2182         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-invalid-error-retry.html: Added.
2183         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-invalid-error-retry.html: Added.
2184
2185 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2186
2187         run-safari Doesn't work with the latest Xcode version and iOS
2188         https://bugs.webkit.org/show_bug.cgi?id=207394
2189
2190         Reviewed by Ryosuke Niwa.
2191
2192         * Scripts/webkitdirs.pm:
2193         (iosSimulatorRuntime): Determine the runtime from valid runtimes.
2194         (findOrCreateSimulatorForIOSDevice): iPhone 5 is unsupported, remove code.
2195
2196 2020-02-07  Daniel Bates  <dabates@apple.com>
2197
2198         Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
2199         https://bugs.webkit.org/show_bug.cgi?id=207366
2200
2201         Reviewed by Brent Fulgham.
2202
2203         Enable default WebKitLinkedOnOrAfterEverything in DumpRenderTree just as we do in WebKitTestRunner.
2204         This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
2205         as the actual test instead of under a platform-specific directory even when the tests' behavior
2206         depends on the link-time version of WebKit.
2207
2208         Note that testing of pre-linked behavior can still be accomplished by test writers by exposing settings
2209         and toggling them in a test.
2210
2211         * DumpRenderTree/mac/DumpRenderTree.mm:
2212         (setDefaultsToConsistentValuesForTesting):
2213
2214 2020-02-03  Sam Weinig  <weinig@apple.com>
2215
2216         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2217         https://bugs.webkit.org/show_bug.cgi?id=207155
2218
2219         Reviewed by Tim Horton.
2220
2221         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2222         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2223         also has a default value in PlatformEnable.h
2224
2225         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2226
2227 2020-02-07  Kate Cheney  <katherine_cheney@apple.com>
2228
2229         Update WebView category name to be more accurate
2230         https://bugs.webkit.org/show_bug.cgi?id=207334
2231         <rdar://problem/59224855>
2232
2233         Reviewed by Brent Fulgham.
2234
2235         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
2236         (TEST):
2237
2238 2020-02-07  Aakash Jain  <aakash_jain@apple.com>
2239
2240         [ews] add commit-queue build step to close the bug
2241         https://bugs.webkit.org/show_bug.cgi?id=207387
2242
2243         Reviewed by Jonathan Bedard.
2244
2245         * BuildSlaveSupport/ews-build/steps.py:
2246         (BugzillaMixin.close_bug): Method to close the bugzilla bug.
2247         (CloseBug): Build step to close bugzilla bug.
2248
2249 2020-02-05  Aakash Jain  <aakash_jain@apple.com>
2250
2251         [ews] add commit-queue build step to clear flags on patch
2252         https://bugs.webkit.org/show_bug.cgi?id=206536
2253
2254         Reviewed by Jonathan Bedard.
2255
2256         * BuildSlaveSupport/ews-build/steps.py:
2257         (BugzillaMixin): Class for common bugzilla related methods.
2258         (BugzillaMixin.get_bugzilla_api_key): Method to read bugzilla api key from file.
2259         (BugzillaMixin.remove_flags_on_patch): Method to remove flags on patch.
2260         (ValidatePatch):
2261         (RemoveFlagsOnPatch): Class to remove flags on patch.
2262         (RemoveFlagsOnPatch.start):
2263         (ValidatePatch._addToLog): Moved.
2264         (ValidatePatch.fetch_data_from_url): Moved.
2265         (ValidatePatch.get_patch_json): Moved.
2266         (ValidatePatch.get_bug_json): Moved.
2267         (ValidatePatch.get_bug_id_from_patch): Moved.
2268         (ValidatePatch._is_patch_obsolete): Moved.
2269         (ValidatePatch._is_patch_review_denied): Moved.
2270         (ValidatePatch._is_patch_cq_plus): Moved.
2271         (ValidatePatch._is_bug_closed): Moved.
2272
2273 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2274
2275         EWS should run resultsdbpy tests
2276         https://bugs.webkit.org/show_bug.cgi?id=201928
2277
2278         Reviewed by Aakash Jain.
2279
2280         * BuildSlaveSupport/ews-build/factories.py:
2281         (ServicesFactory.__init__): Add RunResultsdbpyTests.
2282         * BuildSlaveSupport/ews-build/factories_unittest.py:
2283         (TestTestsFactory.test_services_factory): Add RunResultsdbpyTests.
2284         * BuildSlaveSupport/ews-build/steps.py:
2285         (CheckPatchRelevance): resultsdbpy changes should trigger service tests.
2286         (RunResultsdbpyTests): Add step which runs resultsdbpy tests.
2287         * BuildSlaveSupport/ews-build/steps_unittest.py:
2288         (TestRunResultsdbpyTests):
2289         (TestRunResultsdbpyTests.setUp):
2290         (TestRunResultsdbpyTests.tearDown):
2291         (TestRunResultsdbpyTests.test_success):
2292         (TestRunResultsdbpyTests.test_failure):
2293
2294 2020-02-07  Jacob Uphoff  <jacob_uphoff@apple.com>
2295
2296         Adding myself to contributors.json
2297         
2298         Unreviewed
2299
2300         * Scripts/webkitpy/common/config/contributors.json:
2301
2302 2020-02-07  Jason Lawrence  <lawrence.j@apple.com>
2303
2304         Adding myself to contributors.json
2305         
2306         Unreviewed
2307
2308         * Scripts/webkitpy/common/config/contributors.json:
2309
2310 2020-02-07  Patrick Griffis  <pgriffis@igalia.com>
2311
2312         [GTK][WPE] Add same-site cookie support
2313         https://bugs.webkit.org/show_bug.cgi?id=204137
2314
2315         Reviewed by Carlos Garcia Campos.
2316
2317         Update libsoup to 2.69.90 in JHBuild.
2318
2319         * gtk/jhbuild.modules:
2320         * wpe/jhbuild.modules:
2321
2322 2020-02-07  Yusuke Suzuki  <ysuzuki@apple.com>
2323
2324         Unreviewed, revert 75% load-factor because of JetStream2/string-unpack-code-SP regression
2325         https://bugs.webkit.org/show_bug.cgi?id=207183
2326
2327         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2328         (TestWebKitAPI::testInitialCapacity):
2329
2330 2020-02-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2331
2332         WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
2333         https://bugs.webkit.org/show_bug.cgi?id=207350
2334         <rdar://problem/59239914>
2335
2336         Reviewed by Tim Horton.
2337
2338         Add a test to exercise the corner case in the SPI.
2339
2340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2341         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
2342
2343 2020-02-06  Jiewen Tan  <jiewen_tan@apple.com>
2344
2345         Adopt new SOAuthorizationOption constants
2346         https://bugs.webkit.org/show_bug.cgi?id=207186
2347         <rdar://problem/48909336>
2348
2349         Reviewed by Brent Fulgham.
2350
2351         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2352         (checkAuthorizationOptions):
2353
2354 2020-02-06  Brady Eidson  <beidson@apple.com>
2355
2356         Cleanup and promote WKContentWorld and its clients in WKWebView.
2357         https://bugs.webkit.org/show_bug.cgi?id=207351
2358
2359         Reviewed by Alex Christensen.
2360
2361         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2362         (TestWebKitAPI::TEST):
2363         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2364         (TEST):
2365         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2366         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
2367
2368 2020-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2369
2370         [Win][MiniBrowser] Accelerator keys don't work unless the main window is focused
2371         https://bugs.webkit.org/show_bug.cgi?id=207250
2372
2373         Reviewed by Alex Christensen.
2374
2375         MiniBrowser has shortcut keys, Ctrl-W to close window, Ctrl-R to
2376         reload. However, they don't work unless the main window is
2377         focused.
2378
2379         Ctrl-W should be processed differently. Ctrl-W should be handled
2380         without dispatching to WebKit, others should be handled only when
2381         WebKit didn't consume. So, this change split the accelerator table
2382         into two, one is for Ctrl-W, another is for other shortcut keys.
2383
2384         For Ctrl-W, key events are processed before dispatching to
2385         WebView. It is converted to IDM_CLOSE_WINDOW of WM_COMMAND, and
2386         dispatched to WebView. WebKit2 WebView bubbles up unhandled
2387         WM_COMMAND to the parent window. Then, IDM_CLOSE_WINDOW is handled
2388         in the main window's WndProc. However, it doesn't work for WebKit1
2389         because this change doesn't add the bubbling up code to WebKit1
2390         WebView.
2391
2392         For other shortcut keys, for example Ctrl-R, key events are
2393         dispatched to WebView without accelerator key translations. Then,
2394         WebKitBrowserWindow::didNotHandleKeyEvent is called back if they
2395         aren't consumed. didNotHandleKeyEvent posts the messasge to the
2396         main window. The message loop processed key events dispatched to
2397         the main window with another accelerator table. However, it
2398         doesn't work for WebKit1, because WebKit1 doesn't have a API
2399         equivalent to didNotHandleKeyEvent.
2400
2401         After switching the active window by pressing Alt-Tab and
2402         reactivating the main window, the main window got the focus. This
2403         was the reason shortcut keys worked only after reactivating the
2404         main window. But, this is not the desired behavior after this
2405         change because other shortcut keys don't work if the main window
2406         is focused. So. set the focus to the brower window when
2407         WM_ACTIVATE of the main window.
2408
2409         Shortcut keys Ctrl++ (zoom in) and Ctrl+- (zoom out) were
2410         effective only for keyboard numpad. Add VK_OEM_MINUS and
2411         VK_OEM_PLUS for them.
2412
2413         Add a shortcut key Ctrl-0 to reset page zoom scale to actual.
2414
2415         * MiniBrowser/win/MainWindow.cpp:
2416         (MainWindow::isInstance):
2417         (MainWindow::WndProc):
2418         * MiniBrowser/win/MainWindow.h:
2419         * MiniBrowser/win/MiniBrowserLib.rc: Add a new accelerator table
2420         IDR_ACCELERATORS_PRE for Ctrl-W.
2421         * MiniBrowser/win/MiniBrowserLibResource.h:
2422         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2423         (WebKitBrowserWindow::didNotHandleKeyEvent):
2424         * MiniBrowser/win/WinMain.cpp:
2425         (wWinMain):
2426
2427 2020-02-06  Jonathan Bedard  <jbedard@apple.com>
2428
2429         results.webkitorg: Dead CI links
2430         https://bugs.webkit.org/show_bug.cgi?id=207340
2431
2432         Reviewed by Alexey Proskuryakov.
2433
2434         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
2435         (Configuration.prototype.toParams): Version name and version number often duplicate the
2436         same information, exception version number is often more specific than is useful.
2437
2438 2020-02-06  Brent Fulgham  <bfulgham@apple.com>
2439
2440         Prevent navigating top level frames to Data URLs
2441         https://bugs.webkit.org/show_bug.cgi?id=206962
2442         <rdar://problem/56770676>
2443
2444         Reviewed by Youenn Fablet.
2445
2446         Revise test running code to allow data URL navigations by default, since they are so frequently
2447         used in testing. However, provide a flag to turn this off in tests so we can confirm proper
2448         function.
2449
2450         * DumpRenderTree/TestOptions.cpp:
2451         (TestOptions::TestOptions):
2452         * DumpRenderTree/TestOptions.h:
2453         * DumpRenderTree/mac/DumpRenderTree.mm:
2454         (setWebPreferencesForTestOptions):
2455         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2456         (DownloadAttributeDoesNotStartDownloads): Revise configuration to allow script navigation of the main frame to a Data URL.
2457         (StartDownloadWithDownloadAttribute): Ditto.
2458         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2459         (WebViewWillPerformClientRedirect): Ditto.
2460         (WebViewDidCancelClientRedirect): Ditto.
2461         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2462         (NavigateToDataURLThenBack): Ditto.
2463         (ContentExtensionBlocksMainLoadThenReloadWithoutExtensions): Ditto.
2464         * WebKitTestRunner/TestController.cpp:
2465         (WTR::TestController::resetPreferencesToConsistentValues):
2466         (WTR::updateTestOptionsFromTestHeader):
2467         * WebKitTestRunner/TestOptions.h:
2468         (WTR::TestOptions::hasSameInitializationOptions const):
2469         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2470         (WTR::initializeWebViewConfiguration):
2471         (WTR::TestController::platformCreateWebView):
2472
2473 2020-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2474
2475         [iOS] Provide a way to suppress software keyboards on WKWebView's WKContentView
2476         https://bugs.webkit.org/show_bug.cgi?id=207272
2477         <rdar://problem/59190828>
2478
2479         Reviewed by Tim Horton.
2480
2481         Add an API test to verify (through UIKeyboardImpl) that the software keyboard should be suppressed when setting
2482         -_setSuppressSoftwareKeyboard: on the web view. This involves making `-makeKeyWindow` "work" in the API testing
2483         environment on iOS, by swizzling out both `-[NSBundle bundleIdentifier]` and `-[UIApplication keyWindow]`.
2484
2485         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2486         (TestWebKitAPI::overrideBundleIdentifier):
2487         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2488         (setOverriddenApplicationKeyWindow):
2489         (applicationKeyWindowOverride):
2490         (-[TestWKWebViewHostWindow makeKeyWindow]):
2491         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2492         * TestWebKitAPI/ios/UIKitSPI.h:
2493
2494         Also move the `UIResponder (UIKitSPI)` category from the internal section to the SPI section; this is redundant
2495         when using the internal SDK to build, since these methods are already declared in UIResponder_Private.h.
2496
2497 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
2498
2499         [PlayStation] Build a shared JavaScriptCore
2500         https://bugs.webkit.org/show_bug.cgi?id=198446
2501
2502         Reviewed by Fujii Hironori.
2503
2504         Add TARGET_OBJECTS for bmalloc and WTF so TestWTF links.
2505
2506         * TestWebKitAPI/PlatformPlayStation.cmake:
2507
2508 2020-02-05  Stephan Szabo  <stephan.szabo@sony.com>
2509
2510         [WinCairo] Set up fonts for layout tests for test bot image
2511         https://bugs.webkit.org/show_bug.cgi?id=207223
2512
2513         Reviewed by Fujii Hironori.
2514
2515         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp:
2516           Implement activateFonts to load fonts for test
2517
2518 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
2519
2520         [PlayStation] Miscellaneous build fixes February 2020 edition
2521         https://bugs.webkit.org/show_bug.cgi?id=207312
2522
2523         Unreviewed build fix.
2524
2525         * TestWebKitAPI/PlatformWebView.h: Remove #elif guard and just use #else
2526
2527 2020-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
2528
2529         [WTF] Try using 75% load factor for HashTable
2530         https://bugs.webkit.org/show_bug.cgi?id=207183
2531
2532         Reviewed by Mark Lam.
2533
2534         Fix load-factor assumption in existing tests.
2535
2536         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2537         (TestWebKitAPI::testInitialCapacity):
2538
2539 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
2540
2541         resulsdbpy: Fix unit tests
2542         https://bugs.webkit.org/show_bug.cgi?id=207304
2543
2544         Reviewed by Aakash Jain.
2545
2546         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
2547         (ConfigurationContextTest.test_partition_by_configuration): Add branch to testing table.
2548         (ConfigurationContextTest.test_partition_by_partial_configuration): Ditto.
2549         * resultsdbpy/resultsdbpy/model/failure_context_unittest.py:
2550         (FailureContextTest.test_failures): Sort test failures by uuid for a predictable order in testing.
2551         (FailureContextTest.test_unexpected_failures): Ditto.
2552         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
2553         (MockModelFactory.iterate_all_commits): Do not batch requests since this function has no way
2554         of knowing how expensive the callback may be.
2555
2556 2020-02-05  Chris Dumez  <cdumez@apple.com>
2557
2558         Unreviewed, another build fix after r255846
2559
2560         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2561
2562 2020-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2563
2564         Unreviewed infrastructure fix.
2565
2566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2567         (WebKitBuildbot): Delete entries for queues that have been removed from buildbot.
2568
2569 2020-02-05  Chris Dumez  <cdumez@apple.com>
2570
2571         Unreviewed build fix after r255846.
2572
2573         * TestWebKitAPI/cocoa/HTTPServer.h:
2574
2575 2020-02-05  Jiewen Tan  <jiewen_tan@apple.com>
2576
2577         Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
2578         https://bugs.webkit.org/show_bug.cgi?id=207173
2579         <rdar://problem/55669065>
2580
2581         Reviewed by Brent Fulgham.
2582
2583         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2584         (TestWebKitAPI::TEST):
2585         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2586         (-[TestWKWebView _setUpTestWindow:]):
2587         Make the TestWKWebViewHostWindow miniaturizable to enable the test.
2588
2589 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
2590
2591         results.webkit.org: Apply ttl to archive shards
2592         https://bugs.webkit.org/show_bug.cgi?id=207295
2593
2594         Rubber-stamped by Aakash Jain.
2595
2596         * resultsdbpy/resultsdbpy/model/archive_context.py:
2597         (ArchiveContext.ArchiveMetaDataByCommit): Use new table.
2598         (ArchiveContext.ArchiveChunks): Use new table.
2599         (ArchiveContext.register): Add ttl to archive shards.
2600
2601 2020-02-05  Alex Christensen  <achristensen@webkit.org>
2602
2603         Make WKWebView._negotiatedLegacyTLS accurate when loading main resouorce from network or cache
2604         https://bugs.webkit.org/show_bug.cgi?id=207207
2605
2606         Reviewed by Chris Dumez.
2607
2608         HTTPServer now supports HTTPS. Tell your friends!
2609
2610         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2611         (testCertificate):
2612         (testIdentity):
2613         (credentialWithIdentity):
2614         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2615         (TestWebKitAPI::webViewWithNavigationDelegate):
2616         (TestWebKitAPI::TEST):
2617         * TestWebKitAPI/cocoa/HTTPServer.h:
2618         * TestWebKitAPI/cocoa/HTTPServer.mm:
2619         (TestWebKitAPI::HTTPServer::HTTPServer):
2620         (TestWebKitAPI::HTTPServer::request const):
2621
2622 2020-02-05  Brady Eidson  <beidson@apple.com>
2623
2624         _WKDownload should expose the originating FrameInfo.
2625         <rdar://problem/58022576> and https://bugs.webkit.org/show_bug.cgi?id=207185
2626
2627         Reviewed by Geoff Garen.
2628
2629         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2630         (-[DownloadTestSchemeDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2631         (-[DownloadSecurityOriginDelegate _downloadDidStart:]):
2632         (loaded):
2633         * TestWebKitAPI/cocoa/HTTPServer.mm:
2634
2635 2020-02-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2636
2637         [GTK] Fix dependencies build
2638         https://bugs.webkit.org/show_bug.cgi?id=207273
2639
2640         Reviewed by Carlos Garcia Campos.
2641
2642         * gtk/jhbuild.modules: Bumped wpebackend-fdo version to 1.4.1 and
2643         added mesa as one of its deps. Added the xserver patch as well.
2644         * gtk/patches/xserver-gl-version.patch: Added.
2645
2646 2020-02-05  Chris Dumez  <cdumez@apple.com>
2647
2648         REGRESSION(r255595): page not closed after beforeunload handler returns true
2649         https://bugs.webkit.org/show_bug.cgi?id=207189
2650         <rdar://problem/59149593>
2651
2652         Reviewed by Youenn Fablet.
2653
2654         Add API test coverage for fix landed in r255677.
2655
2656         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2657         (-[SlowBeforeUnloadPromptUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2658         (TEST):
2659
2660 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
2661
2662         results.webkit.org should disable auto-capitalize over the search field
2663         https://bugs.webkit.org/show_bug.cgi?id=207240
2664         <rdar://problem/59053042>
2665
2666         Rubber-stamped by Aakash Jain.
2667
2668         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2669
2670 2020-02-01  Darin Adler  <darin@apple.com>
2671
2672         Replace RGBA32 typedef with a class to improve type safety
2673         https://bugs.webkit.org/show_bug.cgi?id=206862
2674
2675         Reviewed by Sam Weinig.
2676
2677         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
2678         (TestWebKitAPI::TEST): Use the Color constructor instead of Color::createUnchecked.
2679
2680 2020-02-04  Darin Adler  <darin@apple.com>
2681
2682         Remove NSKeyedArchiverSPI.h now that WebKit only uses API
2683         https://bugs.webkit.org/show_bug.cgi?id=207203
2684
2685         Reviewed by Anders Carlsson.
2686
2687         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Removed
2688         include of NSKeyedArchiverSPI.h and call methods of NSKeyedArchiver directly.
2689         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm: Ditto.
2690         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Ditto.
2691         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Ditto.
2692
2693 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
2694
2695         results.webkit.org: Support Internal in run-javascriptcore-tests
2696         https://bugs.webkit.org/show_bug.cgi?id=204095
2697
2698         Rubber-stamped by Aakash Jain.
2699
2700         * Scripts/VCSUtils.pm:
2701         (gitBisectStartBranchForDirectory): Renamed from gitBisectStartBranch.
2702         (gitBranchForDirectory): Compute branch for directory.
2703         (gitBranch): Compute branch for the current git directory.
2704         (commitForDirectory): Add git support.
2705         (gitBisectStartBranch): Renamed to gitBisectStartBranchForDirectory.
2706         * Scripts/run-javascriptcore-tests:
2707         (uploadResults): Check for Internal repository.
2708
2709 2020-02-04  Alex Christensen  <achristensen@webkit.org>
2710
2711         REGRESSION: (r255611) [ Mac ] 3 lldb tests failing related to HashMap
2712         https://bugs.webkit.org/show_bug.cgi?id=207204
2713
2714         Reviewed by Simon Fraser.
2715
2716         Remove support for HashSet and HashMap until we are able to do the equivalent of reinterpret_cast<unsigned*>(pointer)[-1]
2717         in LLDB's python API.
2718
2719         * lldb/lldb_webkit_unittest.py:
2720         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
2721         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
2722         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
2723
2724 2020-02-04  Lauro Moura  <lmoura@igalia.com>
2725
2726         [EWS] Stop GTK/WPE build if jhbuild fails.
2727         https://bugs.webkit.org/show_bug.cgi?id=207220
2728
2729         Reviewed by Adrian Perez de Castro.
2730
2731         * BuildSlaveSupport/ews-build/steps.py:
2732         (InstallGtkDependencies): Halt on failure
2733         (InstallWpeDependencies): Ditto
2734
2735 2020-02-04  Alex Christensen  <achristensen@webkit.org>
2736
2737         Fix Mac CMake build
2738         https://bugs.webkit.org/show_bug.cgi?id=207231
2739
2740         * DumpRenderTree/PlatformMac.cmake:
2741         * MiniBrowser/mac/CMakeLists.txt:
2742         * MiniBrowser/mac/WK2BrowserWindowController.m:
2743         (-[WK2BrowserWindowController awakeFromNib]):
2744         * WebKitTestRunner/PlatformMac.cmake:
2745
2746 2020-02-04  Don Olmstead  <don.olmstead@sony.com>
2747
2748         [PlayStation] Enable TestWebKit
2749         https://bugs.webkit.org/show_bug.cgi?id=207211
2750
2751         Reviewed by Ross Kirsling.
2752
2753         Stub out PlayStation implementation of TestWebKit so it builds.
2754
2755         * TestWebKitAPI/PlatformPlayStation.cmake:
2756         * TestWebKitAPI/PlatformWebView.h: Simplify platform define
2757         * TestWebKitAPI/playstation/PlatformUtilitiesPlayStation.cpp: Added.
2758         (TestWebKitAPI::Util::createInjectedBundlePath):
2759         (TestWebKitAPI::Util::createURLForResource):
2760         (TestWebKitAPI::Util::URLForNonExistentResource):
2761         (TestWebKitAPI::Util::isKeyDown):
2762         * TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp: Added.
2763         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2764         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2765         (TestWebKitAPI::PlatformWebView::initialize):
2766         (TestWebKitAPI::PlatformWebView::page const):
2767         (TestWebKitAPI::PlatformWebView::resizeTo):
2768         (TestWebKitAPI::PlatformWebView::focus):
2769         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2770         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2771         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2772         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2773
2774 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
2775
2776         results.webkit.org: Support branches in run-javascriptcore-tests
2777         https://bugs.webkit.org/show_bug.cgi?id=204094
2778
2779         Rubber-stamped by Aakash Jain.
2780
2781         * Scripts/run-javascriptcore-tests:
2782         (uploadResults): Use webkitdirs function to generate commit information.
2783         * Scripts/VCSUtils.pm:
2784         (commitForDirectory): Generate commit information for SVN repository, including
2785         branch name.
2786
2787 2020-02-04  Matt Lewis  <jlewis3@apple.com>
2788
2789         Replace bot677 due to hardware failure
2790         https://bugs.webkit.org/show_bug.cgi?id=207224
2791
2792         Reviewed by Aakash Jain.
2793
2794         * BuildSlaveSupport/build.webkit.org-config/config.json:
2795
2796 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
2797
2798         TestWebKitAPI: Handle case where test result does not contain path
2799         https://bugs.webkit.org/show_bug.cgi?id=207216
2800
2801         Reviewed by Tim Horton.
2802
2803         * TestWebKitAPI/TestsController.cpp:
2804         (TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
2805         will not contain a file name. We should handle this case.
2806
2807 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
2808
2809         results.webkit.org: Better order upload callbacks
2810         https://bugs.webkit.org/show_bug.cgi?id=207219
2811
2812         Reviewed by Aakash Jain.
2813
2814         Order upload callbacks more deliberately so that the quickest callbacks
2815         that are least likely to link to information from unfinished callbacks are
2816         executed first.
2817
2818         * resultsdbpy/resultsdbpy/model/model.py:
2819         (Model.__init__): Generate buildbot links first, then generate a failure
2820         list, then generate the collective suite results and finally, individual
2821         test results.
2822
2823 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
2824
2825         [EWS] Do not remove TestWebKitAPI prefix from api test failures
2826         https://bugs.webkit.org/show_bug.cgi?id=207210
2827
2828         Reviewed by Jonathan Bedard.
2829
2830         * BuildSlaveSupport/ews-build/steps.py:
2831         (AnalyzeAPITestsResults.analyzeResults):
2832
2833 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
2834
2835         [EWS] Do not remove webkitpy prefix from test failures
2836         https://bugs.webkit.org/show_bug.cgi?id=207206
2837
2838         Reviewed by Jonathan Bedard.
2839
2840         * BuildSlaveSupport/ews-build/steps.py:
2841         (WebKitPyTest.getResultSummary): Do not remove 'webkitpy' from test name. Also handled the
2842         case when json output doesn't have failures/errors key.
2843         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2844
2845 2020-02-04  Ross Kirsling  <ross.kirsling@sony.com>
2846
2847         [CMake] Add Cairo::Cairo target
2848         https://bugs.webkit.org/show_bug.cgi?id=207159
2849
2850         Reviewed by Konstantin Tokarev.
2851
2852         * DumpRenderTree/PlatformWin.cmake:
2853         * ImageDiff/Cairo.cmake:
2854         * TestWebKitAPI/PlatformWPE.cmake:
2855         * TestWebKitAPI/PlatformWin.cmake:
2856         * TestWebKitAPI/glib/CMakeLists.txt:
2857         * WebKitTestRunner/PlatformGTK.cmake:
2858         * WebKitTestRunner/PlatformWPE.cmake:
2859         * WebKitTestRunner/PlatformWin.cmake:
2860         * wpe/backends/CMakeLists.txt:
2861
2862 2020-02-03  Jiewen Tan  <jiewen_tan@apple.com>
2863
2864         Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
2865         https://bugs.webkit.org/show_bug.cgi?id=207079
2866         <rdar://problem/48290464>
2867
2868         Reviewed by Brent Fulgham.
2869
2870         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2871         (-[TestSOAuthorizationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
2872         (overrideGetAuthorizationHintsWithURL):
2873         (TestWebKitAPI::TEST):
2874
2875 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
2876
2877         results.webkit.org: Support jsc stress tests
2878         https://bugs.webkit.org/show_bug.cgi?id=204096
2879
2880         Rubber-stamped by Aakash Jain.
2881
2882         * Scripts/run-javascriptcore-tests:
2883         (runJSCStressTests): Add pass and failures to reported results.
2884
2885 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
2886
2887         Make Bugzilla._find_select_element_for_flag more robust
2888         https://bugs.webkit.org/show_bug.cgi?id=207148
2889
2890         Reviewed by Jonathan Bedard.
2891
2892         This patch resolves two FIXMEs:
2893         1. _find_select_element_for_flag() is now used in _fill_attachment_form() method.
2894         2. _find_select_element_for_flag() now does not rely on order of <select> elements.
2895
2896         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2897         (Bugzilla._fill_attachment_form):
2898         (Bugzilla._find_select_element_for_flag):
2899
2900 2020-02-03  Alex Christensen  <achristensen@webkit.org>
2901
2902         Reduce size of HashMap and HashSet
2903         https://bugs.webkit.org/show_bug.cgi?id=207138
2904
2905         Reviewed by Yusuke Suzuki.
2906
2907         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2908         (TestWebKitAPI::TEST):
2909         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2910         (TestWebKitAPI::TEST):
2911
2912 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
2913
2914         obsolete_attachment should not fail when flags do not exist
2915         https://bugs.webkit.org/show_bug.cgi?id=171121
2916
2917         Reviewed by Jonathan Bedard.
2918
2919         Before this change, an error occured if a contributor without EditBugs privileges tried
2920         to obsolete not their own attachment. With this patch, uploading routine continues with
2921         friendly console warning like we have in reassign_bug() method.
2922
2923         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2924         (Bugzilla):
2925         (Bugzilla.obsolete_attachment):
2926         (Bugzilla.reassign_bug): Use NO_EDIT_BUGS_MESSAGE constant.
2927
2928 2020-02-03  Chris Dumez  <cdumez@apple.com>
2929
2930         Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
2931         https://bugs.webkit.org/show_bug.cgi?id=207121
2932         <rdar://problem/58880177>
2933
2934         Reviewed by Alex Christensen.
2935
2936         Add API test coverage.
2937
2938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2939         * TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
2940         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2941         (-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2942         (-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
2943         (TEST):
2944
2945 2020-02-03  Lauro Moura  <lmoura@igalia.com>
2946
2947         [WebKitTestRunner] setOpenPanelFiles support in non-local tests
2948         https://bugs.webkit.org/show_bug.cgi?id=206517
2949
2950         Reviewed by Carlos Alberto Lopez Perez.
2951
2952         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2953         (WTR::TestRunner::setOpenPanelFiles): Use file:// if the passed path
2954         starts with a leading slash instead of using the test URL, which could
2955         cause input forms with invalid file data.
2956
2957 2020-02-03  Aakash Jain  <aakash_jain@apple.com>
2958
2959         [ews] Set custom build summary for webkitpy tests
2960         https://bugs.webkit.org/show_bug.cgi?id=207027
2961
2962         Reviewed by Jonathan Bedard.
2963
2964         * BuildSlaveSupport/ews-build/factories.py:
2965         * BuildSlaveSupport/ews-build/steps.py:
2966         (WebKitPyTest.setBuildSummary):
2967         (WebKitPyTest.getResultSummary):
2968         * BuildSlaveSupport/ews-build/factories_unittest.py:
2969
2970 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
2971
2972         run-javascriptcore-tests: Don't split binary results
2973         https://bugs.webkit.org/show_bug.cgi?id=207118
2974
2975         Rubber-stamped by Aakash Jain.
2976
2977         * Scripts/run-javascriptcore-tests:
2978         (runTest): Only report aggregated binary results.
2979
2980 2020-02-03  Chris Dumez  <cdumez@apple.com>
2981
2982         Unreviewed, disable ResponsivenessTimer test in Debug / ASAN
2983
2984         The ResponsivenessTimer is disabled for those configurations as of r255518.
2985
2986         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
2987
2988 2020-02-03  Zan Dobersek  <zdobersek@igalia.com>
2989
2990         Use std::hypot() where possible
2991         https://bugs.webkit.org/show_bug.cgi?id=198483
2992
2993         Reviewed by Carlos Garcia Campos.
2994
2995         Use std::hypot() where possible, allowing for a possibly more precise
2996         calculation of square roots of sums of two or three square values.
2997
2998         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2999         (-[DragAndDropSimulator initialProgressForMouseDrag]):
3000
3001 2020-02-03  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3002
3003         [JHBuild] remove libvpx
3004         https://bugs.webkit.org/show_bug.cgi?id=207103
3005
3006         Reviewed by Xabier Rodriguez-Calvar.
3007
3008         libvpx were added in jhbuild in times of OpenWebRTC. Nowadays, LibWebRTC is used and libvpx is
3009         installed through Tools/gtk/install-dependencies, thus it should be removed from jhbuild.modules
3010
3011         * gstreamer/jhbuild.modules: remove libvpx.
3012
3013 2020-02-02  Sam Weinig  <weinig@apple.com>
3014
3015         Update style checker with new locations OS version checks are allowed
3016         https://bugs.webkit.org/show_bug.cgi?id=207106
3017
3018         Reviewed by Alexey Proskuryakov.
3019
3020         * Scripts/webkitpy/style/checkers/cpp.py:
3021         (check_os_version_checks):
3022         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3023         (WebKitStyleTest.test_os_version_checks):
3024         Update path check to allow anything with the pattern "Source/WTF/wtf/Platform[a-zA-Z]+\.h"
3025
3026 2020-02-01  Simon Fraser  <simon.fraser@apple.com>
3027
3028         Closing a MiniBrowser WK2 window does not release the WKWebView
3029         https://bugs.webkit.org/show_bug.cgi?id=203185
3030
3031         Reviewed by Wenson Hsieh.
3032         
3033         Use a weak WKWebView reference in the _textFinder.hideInterfaceCallback() block
3034         to avoid a retain cycle that keeps the window controller and WKWebView alive.
3035
3036         * MiniBrowser/mac/WK2BrowserWindowController.m:
3037         (-[WK2BrowserWindowController awakeFromNib]):
3038
3039 2020-01-31  David Quesada  <david_quesada@apple.com>
3040
3041         REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges
3042         https://bugs.webkit.org/show_bug.cgi?id=206984
3043         rdar://problem/58999654
3044
3045         Reviewed by Brady Eidson.
3046
3047         Add an API test for a resumed download that receives an authentication challenge. The download
3048         delegate should be asked to handle the challenge, and the download should be able to finish.
3049
3050         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3051         (-[DownloadCancelingDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3052         (-[DownloadCancelingDelegate _download:didReceiveData:]):
3053         (-[DownloadCancelingDelegate _downloadDidCancel:]):
3054         (-[AuthenticationChallengeHandlingDelegate _download:didReceiveAuthenticationChallenge:completionHandler:]):
3055         (-[AuthenticationChallengeHandlingDelegate _downloadDidFinish:]):
3056         (TEST):
3057
3058 2020-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3059
3060         Add support for specifying background colors when setting marked text
3061         https://bugs.webkit.org/show_bug.cgi?id=207065
3062         <rdar://problem/57876140>
3063
3064         Reviewed by Tim Horton.
3065
3066         Add support in WebKitTestRunner for specifying a list of highlight ranges when setting marked text. This comes
3067         in the form of an additional argument to TextInputController::setMarkedText, which contains an array of objects,
3068         each describing one range (in the composition) to highlight.
3069
3070         * DumpRenderTree/ios/TextInputControllerIOS.m:
3071         (+[TextInputController isSelectorExcludedFromWebScript:]):
3072         (+[TextInputController webScriptNameForSelector:]):
3073         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3074         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3075         * DumpRenderTree/mac/TextInputControllerMac.m:
3076         (+[TextInputController isSelectorExcludedFromWebScript:]):
3077         (+[TextInputController webScriptNameForSelector:]):
3078         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3079         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3080         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3081         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3082         (WTR::arrayLength):
3083         (WTR::createCompositionHighlightData):
3084
3085         Add logic to convert a given JSObject containing the composition highlight information into a WKArrayRef, which
3086         is then passed into WebKit via WKBundlePageSetComposition.
3087
3088         (WTR::TextInputController::setMarkedText):
3089         * WebKitTestRunner/InjectedBundle/TextInputController.h:
3090
3091 2020-01-31  Alex Christensen  <achristensen@webkit.org>
3092
3093         Add KVO SPI WKWebView._negotiatedLegacyTLS
3094         https://bugs.webkit.org/show_bug.cgi?id=207067
3095
3096         Reviewed by Andy Estes.
3097
3098         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3099         (-[TLSObserver observeValueForKeyPath:ofObject:change:context:]):
3100         (-[TLSObserver waitUntilNegotiatedLegacyTLSChanged]):
3101         (TestWebKitAPI::TEST):
3102         * TestWebKitAPI/config.h:
3103
3104 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3105
3106         [ews] Display flaky test names in build summary when ReRunWebKitTests passes
3107         https://bugs.webkit.org/show_bug.cgi?id=207050
3108
3109         Reviewed by Jonathan Bedard.
3110
3111         * BuildSlaveSupport/ews-build/steps.py:
3112         (ReRunWebKitTests.evaluateCommand):
3113
3114 2020-01-31  David Kilzer  <ddkilzer@apple.com>
3115
3116         REGRESSION: [ iPadOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html always fails
3117         <https://webkit.org/b/206759>
3118         <rdar://problem/58872607>
3119
3120         Reviewed by Brent Fulgham.
3121
3122         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3123         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3124         - Add declaration.
3125         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3126         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3127         - Implement by waiting for
3128           -[UIViewController isPerformingModalTransition] to return NO
3129           while spinning the runloop.
3130         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
3131         - Call waitForModalTransitionToFinish() to fix the test.
3132
3133 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3134
3135         [ews] add build step to set custom build summary
3136         https://bugs.webkit.org/show_bug.cgi?id=207026
3137
3138         Reviewed by Jonathan Bedard.
3139
3140         * BuildSlaveSupport/ews-build/steps.py:
3141         (SetBuildSummary.doStepIf): Run this step only if build_summary property is set.
3142         (SetBuildSummary.hideStepIf): Hide this step if it is not executed.
3143         (SetBuildSummary.start):
3144
3145 2020-01-31  Jonathan Bedard  <jbedard@apple.com>
3146
3147         results.webkit.org: Handle modified firewall rules
3148         https://bugs.webkit.org/show_bug.cgi?id=207047
3149
3150         Reviewed by Aakash Jain.
3151
3152         * Scripts/webkitpy/results/upload.py:
3153         (Upload.upload_archive): Return true for 403 and 413 errors, but print a message
3154         indicating the upload failed.
3155         * Scripts/webkitpy/results/upload_unittest.py:
3156         (UploadTest.test_archive_upload):
3157
3158 2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
3159
3160         Unreviewed, another speculative test fix after r255041
3161
3162         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3163         (WTR::TestController::addTestKeyToKeychain):
3164         Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
3165         potential error due to screen locks.
3166
3167 2020-01-30  Alex Christensen  <achristensen@webkit.org>
3168
3169         Add WKNavigationDelegate SPI to disable TLS 1.0 and 1.1
3170         https://bugs.webkit.org/show_bug.cgi?id=206979
3171
3172         Reviewed by Brady Eidson.
3173
3174         * MiniBrowser/mac/SettingsController.m:
3175         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3176         (-[TLSNavigationDelegate waitForDidFinishNavigation]):
3177         (-[TLSNavigationDelegate waitForDidFailProvisionalNavigation]):
3178         (-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]):
3179         (-[TLSNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3180         (-[TLSNavigationDelegate webView:didFinishNavigation:]):
3181         (-[TLSNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3182         (-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]):
3183         (TestWebKitAPI::TEST):
3184
3185 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
3186
3187         PAL: Remove old iOS version macros
3188         https://bugs.webkit.org/show_bug.cgi?id=206905
3189
3190         Reviewed by Darin Adler.
3191
3192         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: Remove USE(NSPROGRESS_PUBLISHING_SPI)
3193         with HAVE(NSPROGRESS_PUBLISHING_SPI)
3194
3195 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
3196
3197         TestWebKitAPI: Re-baseline AccessibilityTests for Catalyst
3198         https://bugs.webkit.org/show_bug.cgi?id=206997
3199
3200         Reviewed by Wenson Hsieh.
3201
3202         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3203         (TestWebKitAPI::TEST):
3204
3205 2020-01-29  Jonathan Bedard  <jbedard@apple.com>
3206
3207         run-safari / run-webkit-tests --ios-simulator not working with XCode 13.3.1 (11C504)
3208         https://bugs.webkit.org/show_bug.cgi?id=206932
3209
3210         Reviewed by Alexey Proskuryakov.
3211
3212         * Scripts/webkitpy/xcode/simulated_device.py:
3213         (SimulatedDeviceManager.get_runtime_for_device_type): Request for a device running
3214         some version will return a runtime of the same major version with a minor version
3215         that is equal to or greater than the specified minor version.
3216         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3217         (test_matching_up_success):
3218         (test_matching_up_failure):
3219
3220 2020-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3221
3222         [JSC] Give up IC when unknown structure transition happens
3223         https://bugs.webkit.org/show_bug.cgi?id=206846
3224
3225         Reviewed by Mark Lam.
3226
3227         Add `crash!` annotation, which allows us to write a crashing JS test.
3228
3229         * Scripts/run-jsc-stress-tests:
3230         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3231         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
3232         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3233
3234 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3235
3236         [GTK] Add api-gtk to EWS bubbles.
3237         https://bugs.webkit.org/show_bug.cgi?id=206930
3238
3239         Reviewed by Aakash Jain.
3240
3241         A new queue has been added to the EWS to run GTK API tests in r255238.
3242         The queue is now running fine with no pre-existent failures.
3243         Let's add it to the EWS bubbles.
3244
3245         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3246         (StatusBubble):
3247
3248 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3249
3250         [GTK] Fix TestWebKitAPI/TestJSC:/jsc/options API test after r255314
3251         https://bugs.webkit.org/show_bug.cgi?id=206927
3252
3253         Reviewed by Carlos Garcia Campos.
3254
3255         Update the default value tested from 4MB to 5MB.
3256
3257         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3258         (testsJSCOptions):
3259
3260 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3261
3262         [GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
3263         https://bugs.webkit.org/show_bug.cgi?id=206925
3264
3265         Reviewed by Carlos Garcia Campos.
3266
3267         Add cups-daemon to the list of packages to be installed, which is necessary to sucessfully
3268         run the printing related GTK API tests. Add also the liberation fonts, which are needed to
3269         run the complex text controller API tests.
3270
3271         * gtk/install-dependencies:
3272         * wpe/install-dependencies: Don't add cups packages, because WPE currently doesn't run print-related API test.
3273
3274 2020-01-28  Tim Horton  <timothy_horton@apple.com>
3275
3276         macCatalyst: Right clicking on a link follows it immediately
3277         https://bugs.webkit.org/show_bug.cgi?id=206919
3278         <rdar://problem/58936679>
3279
3280         Reviewed by Wenson Hsieh.
3281
3282         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:
3283         (TEST):
3284         Add a test ensuring that mouseup is still called with the secondary button,
3285         even if the event's buttonmask is 0.
3286
3287 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3288
3289         TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION)
3290         https://bugs.webkit.org/show_bug.cgi?id=206913
3291         <rdar://problem/58973357>
3292
3293         Reviewed by Chris Dumez.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3296
3297 2020-01-28  Tim Horton  <timothy_horton@apple.com>
3298
3299         macCatalyst: Triple clicking to select a sentence results in an empty selection
3300         https://bugs.webkit.org/show_bug.cgi?id=206863
3301         <rdar://problem/58776993>
3302
3303         Reviewed by Wenson Hsieh.
3304
3305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3306         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm: Added.
3307         (-[WKTestingEvent locationInView:]):
3308         (-[WKTestingEvent _setButtonMask:]):
3309         (-[WKTestingEvent _buttonMask]):
3310         (-[WKTestingTouch locationInView:]):
3311         (-[WKTestingTouch setTapCount:]):
3312         (-[WKTestingTouch tapCount]):
3313         (mouseGesture):
3314         (TEST):
3315         Add a test ensuring that simply plumbing mouse events to WebCore
3316         does not result in a selection change in macCatalyst (because UIKit
3317         will handle the selection change itself, instead).
3318
3319 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3320
3321         TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK)
3322         https://bugs.webkit.org/show_bug.cgi?id=206907
3323         <rdar://problem/58969924>
3324
3325         Rubber-stamped by Alexey Proskuryakov.
3326
3327         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm: Conditionalize on USE(QUICK_LOOK).
3328
3329 2020-01-28  Sihui Liu  <sihui_liu@apple.com>
3330
3331         IndexedDB: speed up index records deletion
3332         https://bugs.webkit.org/show_bug.cgi?id=206196
3333
3334         Reviewed by Brady Eidson.
3335
3336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3337         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgrade.sqlite3: Added.
3338         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.html: Added.
3339         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm: Added.
3340         (-[IDBObjectStoreInfoUpgradeToV2MessageHandler userContentController:didReceiveScriptMessage:]):
3341         (TEST):
3342
3343 2020-01-28  James Darpinian  <jdarpinian@chromium.org>
3344
3345         Quote file argument to git check-attr
3346         https://bugs.webkit.org/show_bug.cgi?id=206322
3347
3348         Reviewed by Jonathan Bedard.
3349
3350         * Scripts/prepare-ChangeLog:
3351         (attributeCommand):
3352         * Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl: Added.
3353         (writeFileWithContent):
3354
3355 2020-01-28  Brent Fulgham  <bfulgham@apple.com>
3356
3357         Reset the application bundle identifier between test runs
3358         https://bugs.webkit.org/show_bug.cgi?id=206858
3359         <rdar://problem/58844002>
3360
3361         Reviewed by Per Arne Vollan.
3362
3363         Clear the application bundle identifier set during testing when resetting the test system
3364         to a known state in preparation for the next run.
3365
3366         * WebKitTestRunner/TestController.cpp:
3367         (WTR::TestController::resetStateToConsistentValues): Clear any override for the application
3368         bundle identifier before the next test invocation.
3369         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3370         (WTR::TestController::setApplicationBundleIdentifier): Correct an over-release caused by assigning
3371         an autorelease return value to an NSRetainPtr.
3372         (WTR::TestController::clearApplicationBundleIdentifierTestingOverride): Added.
3373
3374 2020-01-28  Aakash Jain  <aakash_jain@apple.com>
3375
3376         EWS django app should send cq+ patches to commit-queue
3377         https://bugs.webkit.org/show_bug.cgi?id=206534
3378
3379         Reviewed by Jonathan Bedard.
3380
3381         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3382         (Buildbot.send_patch_to_buildbot): Added support to send to commit queue.
3383         * BuildSlaveSupport/ews-app/ews/config.py: Added COMMIT_QUEUE_PORT.
3384         * BuildSlaveSupport/ews-app/ews/fetcher.py: Added support for sending patches to commit queue.
3385         * BuildSlaveSupport/ews-app/ews/migrations/0003_patch_sent_to_commit_queue.py: Added.
3386         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3387         (Patch): Added sent_to_commit_queue field in patch table.
3388         (Patch.is_patch_sent_to_commit_queue): Method to check if patch is sent to commit queue.
3389         (Patch.set_sent_to_commit_queue): Set sent_to_commit_queue field.
3390
3391 2020-01-28  Stephan Szabo  <stephan.szabo@sony.com>
3392
3393         Python 3: Update windows scripts and uses of is constant
3394         https://bugs.webkit.org/show_bug.cgi?id=206856
3395
3396         Reviewed by Jonathan Bedard.
3397
3398         * Scripts/download-github-release.py: Update for python 3
3399         * Scripts/webkitpy/common/system/profiler.py: Change is constant usage
3400         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Change is constant usage
3401         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Change is constant usage
3402         * Scripts/webkitpy/port/westondriver.py: Change is constant usage
3403         * Scripts/webkitpy/port/win.py: Update for python 3
3404         * Scripts/webkitpy/port/xvfbdriver.py: Change is constant usage
3405         * Scripts/webkitpy/xcode/device_type.py: Change is constant usage
3406
3407 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3408
3409         run-webkit-tests: clobber-old-results should remove the entire results folder
3410         https://bugs.webkit.org/show_bug.cgi?id=205875
3411         <rdar://problem/58236117>
3412
3413         Reviewed by Alexey Proskuryakov.
3414
3415         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3416         (Manager.run): Boot http servers after the build check and after clobbering
3417         old results.
3418         (Manager._clobber_old_results): Remove entire results folder.
3419         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3420         (RunTest.test_retrying_and_flaky_tests): clobber-old-results now removes the
3421         entire results directory.
3422
3423 2020-01-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3424
3425         [GTK] Add EWS testers to run GTK unit tests.
3426         https://bugs.webkit.org/show_bug.cgi?id=202361
3427
3428         Reviewed by Aakash Jain.
3429
3430         This switches two of the GTK BuildOnly EWS bots to be BuildAndRunAPITests bots.
3431         It doesn't make it a test-only bot because of concerns related with having to
3432         upload and download much data constantly over the network. It reuses the same
3433         logic for running Mac API tests, but simply using a different command at startup.
3434
3435         * BuildSlaveSupport/ews-build/config.json:
3436         * BuildSlaveSupport/ews-build/factories.py:
3437         (GTKBuildFactory):
3438         (GTKBuildAndTestFactory):
3439         (GTKBuildAndTestFactory.__init__):
3440         (GTKAPIBuildAndTestFactory):
3441         * BuildSlaveSupport/ews-build/loadConfig.py:
3442         * BuildSlaveSupport/ews-build/steps.py:
3443         (RunAPITests.start):
3444         (ReRunAPITests.evaluateCommand):
3445         * BuildSlaveSupport/ews-build/steps_unittest.py:
3446
3447 2020-01-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3448
3449         WPT test importer only rewrites the first URL on <style> tags.
3450         https://bugs.webkit.org/show_bug.cgi?id=206842
3451
3452         Reviewed by Jonathan Bedard.
3453
3454         There was an issue, when a <style> tag had several URL() paths
3455         to local references, only the first one was converted.
3456         This was caused because the test parser was only seeing the
3457         first one (re.search() only finds the first regex), instead use
3458         re.findall() to find all the ocurrences.
3459         Then in the test converter for relative paths, when there are
3460         several paths to be converted, convert from the last conversion
3461         instead of the original text.
3462
3463         * Scripts/webkitpy/w3c/test_converter.py:
3464         (_W3CTestConverter.convert_reference_relpaths):
3465         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3466         (test_convert_style_multiple_url):
3467         * Scripts/webkitpy/w3c/test_parser.py:
3468         (TestParser.support_files):
3469         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3470
3471 2020-01-28  Antoine Quint  <graouts@apple.com>
3472
3473         [Web Animations] Make Animation.timeline read-write only if a runtime flag is enabled
3474         https://bugs.webkit.org/show_bug.cgi?id=206173
3475         <rdar://problem/58527432>
3476
3477         Reviewed by Dean Jackson.
3478
3479         Manually enable the new WebAnimationsMutableTimelines runtime flag in DumpRenderTree.
3480
3481         * DumpRenderTree/mac/DumpRenderTree.mm:
3482         (enableExperimentalFeatures):
3483         * DumpRenderTree/win/DumpRenderTree.cpp:
3484         (enableExperimentalFeatures):
3485
3486 2020-01-27  Aakash Jain  <aakash_jain@apple.com>
3487
3488         [ews] Add method to fetch cq+ patches from Bugzilla
3489         https://bugs.webkit.org/show_bug.cgi?id=206774
3490
3491         Reviewed by Jonathan Bedard.
3492
3493         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
3494         (Bugzilla._get_commit_queue_patches_from_bug): Method to get cq+ patches for a given bug.
3495         (Bugzilla._is_patch_cq_plus): Method to check if patch has cq+ flag set.
3496         (Bugzilla.get_list_of_patches_for_commit_queue): Method to fetch list of cq+ patches from Bugzilla.
3497         (BugzillaBeautifulSoup.fetch_bug_ids_for_commit_queue):
3498
3499 2020-01-27  Noam Rosenthal  <noam@webkit.org>
3500
3501         Unreviewed. Adding myself back as a reviewer.
3502
3503         * Scripts/webkitpy/common/config/contributors.json:
3504
3505 2020-01-27  Keith Rollin  <krollin@apple.com>
3506
3507         Fix internal builds
3508         https://bugs.webkit.org/show_bug.cgi?id=206790
3509         <rdar://problem/58888951>
3510
3511         Reviewed by Maciej Stachowiak.
3512
3513         TestRunner.cpp in DumpRenderTree includes ExecutableAllocator.h. In
3514         some circumstances, this file can include <os/thread_self_restrict.h>,
3515         which in turn includes <machine/cpu_capabilities.h>. This latter file
3516         does not exist at a standard location, and the build fails due to not
3517         being able to find the file. Fix this by adding a path to it to the
3518         build command line.
3519
3520         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3521
3522 2020-01-27  Robin Morisset  <rmorisset@apple.com>
3523
3524         Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage
3525         https://bugs.webkit.org/show_bug.cgi?id=206833
3526
3527         Reviewed by Jonathan Bedard.
3528
3529         Just a trivial fix to the arguments validation code of the script.
3530
3531         * Scripts/set-webkit-configuration:
3532
3533 2020-01-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
3534
3535         Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
3536         https://bugs.webkit.org/show_bug.cgi?id=204713
3537
3538         Reviewed by Simon Fraser.
3539
3540         RenderingUpdateThrottling is enabled by default. Turn it off for DRT and
3541         WTR. In some cases, the page may not get visually active while it's
3542         waiting for rAF. Throttling tests will have to explicitly turn it on.
3543
3544         * DumpRenderTree/mac/DumpRenderTree.mm:
3545         (resetWebPreferencesToConsistentValues):
3546         * DumpRenderTree/win/DumpRenderTree.cpp:
3547         (resetWebPreferencesToConsistentValues):
3548         * WebKitTestRunner/TestController.cpp:
3549         (WTR::TestController::resetPreferencesToConsistentValues):
3550
3551 2020-01-26  Aakash Jain  <aakash_jain@apple.com>
3552
3553         [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
3554         https://bugs.webkit.org/show_bug.cgi?id=206807
3555
3556         Reviewed by Jonathan Bedard.
3557
3558         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3559
3560 2020-01-27  Kate Cheney  <katherine_cheney@apple.com>
3561
3562         Delete the ITP storage file that is not being used (plist or database file) when switching to a new storage type
3563         https://bugs.webkit.org/show_bug.cgi?id=206601
3564         <rdar://problem/58696521>
3565
3566         Reviewed by Alex Christensen.
3567
3568         This patch caused some API tests to fail which relied on the ITP files
3569         always existing. Now the tests ensure the respective file exists when 
3570         switching between in-memory and database storage before running the tests.
3571
3572         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3573         (ensureITPFileIsCreated):
3574         (TEST):
3575
3576 2020-01-27  Ryan Haddad  <ryanhaddad@apple.com>
3577
3578         Unreviewed, rolling out r255131.
3579
3580         Caused assertion failures on iOS debug bots.
3581
3582         Reverted changeset:
3583
3584         "Throttling requestAnimationFrame should be controlled by
3585         RenderingUpdateScheduler"
3586         https://bugs.webkit.org/show_bug.cgi?id=204713
3587         https://trac.webkit.org/changeset/255131
3588
3589 2020-01-27  Jonathan Bedard  <jbedard@apple.com>
3590
3591         webkitpy: Replace StringIO.StringIO in statusserver.py
3592         https://bugs.webkit.org/show_bug.cgi?id=206825
3593
3594         Reviewed by Aakash Jain.
3595
3596         * Scripts/webkitpy/common/net/statusserver.py:
3597         (StatusServer._upload_attachment_to_server): The Python 3 compatible StringIO
3598         object cannot be referenced as StringIO.StringIO
3599
3600 2020-01-26  Said Abou-Hallawa  <said@apple.com>
3601
3602         Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
3603         https://bugs.webkit.org/show_bug.cgi?id=204713
3604
3605         Reviewed by Simon Fraser.
3606
3607         RenderingUpdateThrottling is enabled by default. Turn it off for DRT and
3608         WTR. In some cases, the page may not get visually active while it's
3609         waiting for rAF. Throttling tests will have to explicitly turn it on.
3610
3611         * DumpRenderTree/mac/DumpRenderTree.mm:
3612         (resetWebPreferencesToConsistentValues):
3613         * DumpRenderTree/win/DumpRenderTree.cpp:
3614         (resetWebPreferencesToConsistentValues):
3615         * WebKitTestRunner/TestController.cpp:
3616         (WTR::TestController::resetPreferencesToConsistentValues):
3617
3618 2020-01-25  Mark Lam  <mark.lam@apple.com>
3619
3620         Add some tests for dynamically allocated StaticStringImpls.
3621         https://bugs.webkit.org/show_bug.cgi?id=206802
3622
3623         Reviewed by Darin Adler.
3624
3625         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3626         (TestWebKitAPI::doStaticStringImplTests):
3627         (TestWebKitAPI::TEST):
3628
3629 2020-01-25  Aakash Jain  <aakash_jain@apple.com>
3630
3631         webkit-patch upload should not submit automatically to old EWS
3632         https://bugs.webkit.org/show_bug.cgi?id=206801
3633
3634         Reviewed by Alexey Proskuryakov.
3635
3636         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3637         * Scripts/webkitpy/tool/steps/submittoews.py:
3638
3639 2020-01-25  Per Arne Vollan  <pvollan@apple.com>
3640
3641         [Cocoa] Media mime types map should be created in the UI process
3642         https://bugs.webkit.org/show_bug.cgi?id=206478
3643
3644         Reviewed by Darin Adler.
3645
3646         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3647         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Added.
3648         (TEST):
3649
3650 2020-01-25  Antti Koivisto  <antti@apple.com>
3651
3652         [LFC][Integration] Re-enable line layout integration
3653         https://bugs.webkit.org/show_bug.cgi?id=206795
3654         <rdar://problem/58853907>
3655
3656         Reviewed by Zalan Bujtas.
3657
3658         * DumpRenderTree/TestOptions.h:
3659
3660 2020-01-25  Youenn Fablet  <youenn@apple.com>
3661
3662         HTMLMediaElement should not remove the media session at DOM suspension time