[GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-18  Alberto Garcia  <berto@igalia.com>
2
3         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
4         https://bugs.webkit.org/show_bug.cgi?id=130388
5
6         Reviewed by Sergio Villar Senin.
7
8         * Scripts/webkitdirs.pm:
9         (shouldRemoveCMakeCache): make sure that the build directory
10         exists before attempting to create a file in it.
11
12 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
13
14         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
15         https://bugs.webkit.org/show_bug.cgi?id=130336
16
17         Reviewed by Gyuyoung Kim.
18
19         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
20         requires a space between literal and string macro [-Wliteral-suffix]'
21         warning treated as error.
22
23         This patch applies a solution from r162448 to the EFL port.
24
25         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
26         * efl/jhbuild.modules: Added appropriate patch section.
27
28 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
29
30         webkitpy test rebaseline.
31
32         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
33         (MainTest.test_default_args):
34
35 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
36
37         --profile should imply --test-runner-count=1 in run-perf-tests
38         https://bugs.webkit.org/show_bug.cgi?id=130375
39
40         Reviewed by Benjamin Poulain.
41
42         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
43
44         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
45         (PerfTestsRunner._parse_args): Use -1 as the default value.
46         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
47         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
48         should be 1.
49
50 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
51
52         Address some style nits.
53
54         * MiniBrowser/mac/WK2BrowserWindowController.m:
55
56 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
57
58         Add transparent window support back into MiniBrowser
59         https://bugs.webkit.org/show_bug.cgi?id=130363
60
61         Reviewed by Anders Carlsson.
62         
63         Re-enable transparent window support for WK2.
64
65         * MiniBrowser/mac/WK2BrowserWindowController.m:
66         (-[WK2BrowserWindowController validateMenuItem:]):
67         (-[WK2BrowserWindowController toggleTransparentWindow:]):
68
69 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
70
71         Fix the 32-bit build; make the open panel make a WK1 window.
72
73         * MiniBrowser/mac/AppDelegate.m:
74         (-[BrowserAppDelegate openDocument:]):
75
76 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
77
78         Convert MiniBrowser to use WKWebView API
79         https://bugs.webkit.org/show_bug.cgi?id=130061
80
81         Reviewed by Anders Carlsson.
82         
83         Convert the MiniBrowser WK2 window to use WebKit2 API as much
84         as possible.
85         
86         Some functionality was removed temporarily:
87             - text zoom, page zoom
88             - reload
89             - pagination mode
90             - transparent window
91             - dumping source
92             - window.open support
93             - beforeUnload panel
94             - find in page
95
96         * MiniBrowser/mac/AppDelegate.h:
97         * MiniBrowser/mac/AppDelegate.m:
98         (-[BrowserAppDelegate init]):
99         (-[BrowserAppDelegate newWindow:]):
100         (-[BrowserAppDelegate applicationWillTerminate:]):
101         (-[BrowserAppDelegate openDocument:]):
102         * MiniBrowser/mac/WK2BrowserWindowController.h:
103         * MiniBrowser/mac/WK2BrowserWindowController.m:
104         (-[WK2BrowserWindowController awakeFromNib]):
105         (-[WK2BrowserWindowController dealloc]):
106         (-[WK2BrowserWindowController fetch:]):
107         (-[WK2BrowserWindowController validateMenuItem:]):
108         (-[WK2BrowserWindowController reload:]):
109         (-[WK2BrowserWindowController goBack:]):
110         (-[WK2BrowserWindowController goForward:]):
111         (-[WK2BrowserWindowController toggleZoomMode:]):
112         (-[WK2BrowserWindowController resetZoom:]):
113         (-[WK2BrowserWindowController canResetZoom]):
114         (-[WK2BrowserWindowController dumpSourceToConsole:]):
115         (-[WK2BrowserWindowController togglePaginationMode:]):
116         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
117         (-[WK2BrowserWindowController windowShouldClose:]):
118         (-[WK2BrowserWindowController applicationTerminating]):
119         (-[WK2BrowserWindowController currentZoomFactor]):
120         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
121         (-[WK2BrowserWindowController toggleTransparentWindow:]):
122         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
123         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
124         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
125         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
126         (-[WK2BrowserWindowController find:]):
127         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
128         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
129         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
130         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
131         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
132         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
133         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
134         * WebKitTestRunner/PlatformWebView.h:
135         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
136         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
137
138 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
139
140         Use RunLoop objects through references instead of pointers
141         https://bugs.webkit.org/show_bug.cgi?id=130313
142
143         Reviewed by Andreas Kling.
144
145         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
146         return RunLoop reference instead of a pointer.
147
148         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
149         (loadedCallback):
150         (clickedCallback):
151
152 2014-03-17  Tim Horton  <timothy_horton@apple.com>
153
154         sort-export-file --help doesn't work (missing 'use')
155         https://bugs.webkit.org/show_bug.cgi?id=130338
156
157         Reviewed by Anders Carlsson.
158
159         * Scripts/sort-export-file:
160         Add a missing 'use', and fix a typo in an error message.
161
162 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
163
164         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
165         https://bugs.webkit.org/show_bug.cgi?id=130155
166
167         Reviewed by Philippe Normand.
168
169         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
170
171 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
172
173         [GTK] MiniBrowser fails to load injected bundle lib
174         https://bugs.webkit.org/show_bug.cgi?id=130332
175
176         Reviewed by Anders Carlsson.
177
178         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
179
180         * MiniBrowser/gtk/main.c:
181         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
182         process is spawn.
183
184 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
185
186         [EFL] Enable TOUCH_SLIDER macro
187         https://bugs.webkit.org/show_bug.cgi?id=130185
188
189         Reviewed by Gyuyoung Kim.
190
191         * Scripts/webkitperl/FeatureList.pm:
192
193 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
194
195         [GTK][CMake] Build with -fno-rtti
196         https://bugs.webkit.org/show_bug.cgi?id=130261
197
198         Reviewed by Martin Robinson.
199
200         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
201         defined to 0 to prevent typeid use in included GTest headers.
202
203 2014-03-16  Brian Burg  <bburg@apple.com>
204
205         Web Inspector: vended backend commands file should be generated as part of the build
206         https://bugs.webkit.org/show_bug.cgi?id=130110
207
208         Reviewed by Timothy Hatcher.
209
210         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
211
212 2014-03-16  Diego Pino García  <dpino@igalia.com>
213
214         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
215         https://bugs.webkit.org/show_bug.cgi?id=128999
216
217         Reviewed by Philippe Normand.
218
219         * MiniBrowser/gtk/BrowserWindow.c:
220         (reloadPage):
221         (reloadPageIgnoringCache):
222         (browser_window_init):
223
224 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
225
226         [GTK] Improve ninja detection in webkitdirs.pm
227         https://bugs.webkit.org/show_bug.cgi?id=129902
228
229         Reviewed by Daniel Bates.
230
231         * Scripts/webkitdirs.pm:
232         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
233         us to look for ninja-build as well.
234
235 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
236
237         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
238         https://bugs.webkit.org/show_bug.cgi?id=130276
239         <rdar://problem/16266927>
240         
241         Reviewed by Simon Fraser.
242
243         * BuildSlaveSupport/build-launcher-app:
244         * BuildSlaveSupport/build-launcher-dmg:
245         * DumpRenderTree/DumpRenderTree.h:
246         * DumpRenderTree/DumpRenderTreePrefix.h:
247         * DumpRenderTree/GCController.cpp:
248         * DumpRenderTree/GCController.h:
249         * DumpRenderTree/JavaScriptThreading.cpp:
250         * DumpRenderTree/JavaScriptThreading.h:
251         * DumpRenderTree/PixelDumpSupport.cpp:
252         * DumpRenderTree/PixelDumpSupport.h:
253         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
254         * DumpRenderTree/TestRunner.cpp:
255         * DumpRenderTree/TestRunner.h:
256         * DumpRenderTree/WorkQueue.cpp:
257         * DumpRenderTree/WorkQueue.h:
258         * DumpRenderTree/WorkQueueItem.h:
259         * DumpRenderTree/atk/AccessibilityCallbacks.h:
260         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
261         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
262         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
263         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
264         * DumpRenderTree/cg/PixelDumpSupportCG.h:
265         * DumpRenderTree/efl/EditingCallbacks.cpp:
266         * DumpRenderTree/efl/EditingCallbacks.h:
267         * DumpRenderTree/efl/EventSender.cpp:
268         * DumpRenderTree/efl/EventSender.h:
269         * DumpRenderTree/efl/GCControllerEfl.cpp:
270         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
271         * DumpRenderTree/efl/TestRunnerEfl.cpp:
272         * DumpRenderTree/gtk/DumpRenderTree.cpp:
273         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
274         * DumpRenderTree/gtk/EditingCallbacks.cpp:
275         * DumpRenderTree/gtk/EditingCallbacks.h:
276         * DumpRenderTree/gtk/EventSender.cpp:
277         * DumpRenderTree/gtk/EventSender.h:
278         * DumpRenderTree/gtk/GCControllerGtk.cpp:
279         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
280         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
281         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
282         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
283         * DumpRenderTree/gtk/TextInputController.cpp:
284         * DumpRenderTree/gtk/TextInputController.h:
285         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
286         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
287         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
288         * DumpRenderTree/mac/AppleScriptController.h:
289         * DumpRenderTree/mac/AppleScriptController.m:
290         * DumpRenderTree/mac/CheckedMalloc.cpp:
291         * DumpRenderTree/mac/CheckedMalloc.h:
292         * DumpRenderTree/mac/DumpRenderTree.mm:
293         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
294         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
295         * DumpRenderTree/mac/DumpRenderTreeMac.h:
296         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
297         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
298         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
299         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
300         * DumpRenderTree/mac/EditingDelegate.h:
301         * DumpRenderTree/mac/EditingDelegate.mm:
302         * DumpRenderTree/mac/EventSendingController.h:
303         * DumpRenderTree/mac/EventSendingController.mm:
304         * DumpRenderTree/mac/FrameLoadDelegate.h:
305         * DumpRenderTree/mac/FrameLoadDelegate.mm:
306         * DumpRenderTree/mac/GCControllerMac.mm:
307         * DumpRenderTree/mac/MockWebNotificationProvider.h:
308         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
309         * DumpRenderTree/mac/NavigationController.h:
310         * DumpRenderTree/mac/NavigationController.m:
311         * DumpRenderTree/mac/ObjCController.h:
312         * DumpRenderTree/mac/ObjCController.m:
313         * DumpRenderTree/mac/ObjCPlugin.h:
314         * DumpRenderTree/mac/ObjCPlugin.m:
315         * DumpRenderTree/mac/ObjCPluginFunction.h:
316         * DumpRenderTree/mac/ObjCPluginFunction.m:
317         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
318         * DumpRenderTree/mac/PolicyDelegate.h:
319         * DumpRenderTree/mac/PolicyDelegate.mm:
320         * DumpRenderTree/mac/ResourceLoadDelegate.h:
321         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
322         * DumpRenderTree/mac/TestRunnerMac.mm:
323         * DumpRenderTree/mac/TextInputController.h:
324         * DumpRenderTree/mac/TextInputController.m:
325         * DumpRenderTree/mac/UIDelegate.h:
326         * DumpRenderTree/mac/UIDelegate.mm:
327         * DumpRenderTree/mac/WorkQueueItemMac.mm:
328         * DumpRenderTree/win/DRTDataObject.cpp:
329         * DumpRenderTree/win/DRTDataObject.h:
330         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
331         * DumpRenderTree/win/DRTDropSource.cpp:
332         * DumpRenderTree/win/DRTDropSource.h:
333         * DumpRenderTree/win/DraggingInfo.h:
334         * DumpRenderTree/win/DumpRenderTree.cpp:
335         * DumpRenderTree/win/DumpRenderTreeWin.h:
336         * DumpRenderTree/win/EditingDelegate.cpp:
337         * DumpRenderTree/win/EditingDelegate.h:
338         * DumpRenderTree/win/EventSender.cpp:
339         * DumpRenderTree/win/EventSender.h:
340         * DumpRenderTree/win/FrameLoadDelegate.cpp:
341         * DumpRenderTree/win/FrameLoadDelegate.h:
342         * DumpRenderTree/win/GCControllerWin.cpp:
343         * DumpRenderTree/win/HistoryDelegate.cpp:
344         * DumpRenderTree/win/HistoryDelegate.h:
345         * DumpRenderTree/win/MD5.cpp:
346         * DumpRenderTree/win/MD5.h:
347         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
348         * DumpRenderTree/win/PolicyDelegate.cpp:
349         * DumpRenderTree/win/PolicyDelegate.h:
350         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
351         * DumpRenderTree/win/ResourceLoadDelegate.h:
352         * DumpRenderTree/win/TestRunnerWin.cpp:
353         * DumpRenderTree/win/TextInputController.cpp:
354         * DumpRenderTree/win/TextInputController.h:
355         * DumpRenderTree/win/TextInputControllerWin.cpp:
356         * DumpRenderTree/win/UIDelegate.cpp:
357         * DumpRenderTree/win/UIDelegate.h:
358         * DumpRenderTree/win/WorkQueueItemWin.cpp:
359         * EWebLauncher/main.c:
360         * GtkLauncher/main.c:
361         * ImageDiff/efl/ImageDiff.cpp:
362         * ImageDiff/gtk/ImageDiff.cpp:
363         * MiniBrowser/gtk/main.c:
364         * Scripts/SpacingHeuristics.pm:
365         * Scripts/VCSUtils.pm:
366         * Scripts/bisect-builds:
367         * Scripts/build-dumprendertree:
368         * Scripts/build-jsc:
369         * Scripts/build-webkit:
370         * Scripts/check-dom-results:
371         * Scripts/check-for-exit-time-destructors:
372         * Scripts/check-for-global-initializers:
373         * Scripts/commit-log-editor:
374         * Scripts/compare-timing-files:
375         * Scripts/debug-minibrowser:
376         * Scripts/debug-safari:
377         * Scripts/do-file-rename:
378         * Scripts/find-extra-includes:
379         * Scripts/generate-coverage-data:
380         * Scripts/make-script-test-wrappers:
381         * Scripts/malloc-tree:
382         * Scripts/old-run-webkit-tests:
383         * Scripts/parse-malloc-history:
384         * Scripts/report-include-statistics:
385         * Scripts/resolve-ChangeLogs:
386         * Scripts/run-bindings-tests:
387         * Scripts/run-iexploder-tests:
388         * Scripts/run-javascriptcore-tests:
389         * Scripts/run-jsc:
390         * Scripts/run-launcher:
391         * Scripts/run-leaks:
392         * Scripts/run-mangleme-tests:
393         * Scripts/run-minibrowser:
394         * Scripts/run-pageloadtest:
395         * Scripts/run-regexp-tests:
396         * Scripts/run-safari:
397         * Scripts/run-sunspider:
398         * Scripts/run-webkit-app:
399         * Scripts/sampstat:
400         * Scripts/set-webkit-configuration:
401         * Scripts/sort-Xcode-project-file:
402         * Scripts/sort-export-file:
403         * Scripts/split-file-by-class:
404         * Scripts/sunspider-compare-results:
405         * Scripts/svn-apply:
406         * Scripts/svn-create-patch:
407         * Scripts/svn-unapply:
408         * Scripts/test-webkit-scripts:
409         * Scripts/update-javascriptcore-test-results:
410         * Scripts/update-webkit:
411         * Scripts/update-webkit-auxiliary-libs:
412         * Scripts/update-webkit-dependency:
413         * Scripts/update-webkit-localizable-strings:
414         * Scripts/update-webkit-support-libs:
415         * Scripts/update-webkit-wincairo-libs:
416         * Scripts/webkit-build-directory:
417         * Scripts/webkitdirs.pm:
418         (installedSafariPath):
419         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
420         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
421         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
422         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
423         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
424         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
425         * Scripts/webkitperl/features.pm:
426         * Scripts/webkitperl/httpd.pm:
427         * Scripts/webkitpy/bindings/main.py:
428         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
429         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
430         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
431         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
432         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
433         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
434         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
435         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
436         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
437         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
438         * WebKitTestRunner/PixelDumpSupport.cpp:
439         * WebKitTestRunner/PixelDumpSupport.h:
440         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
441         * WinLauncher/WinLauncher.cpp:
442         * WinLauncher/WinLauncher.h:
443         * WinLauncher/stdafx.cpp:
444         * WinLauncher/stdafx.h:
445
446 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
447
448         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
449         https://bugs.webkit.org/show_bug.cgi?id=130265
450
451         Reviewed by Michael Saboff.
452
453         * Scripts/build-webkit:
454         * Scripts/copy-webkitlibraries-to-product-directory:
455
456 2014-03-14  Landry Breuil  <landry@openbsd.org>
457
458         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
459         Also allow to set MAKE in the environment.
460         https://bugs.webkit.org/show_bug.cgi?id=129991
461
462         Reviewed by Andreas Kling.
463
464         * Scripts/webkitdirs.pm:
465         (determineArchitecture):
466         (determineNumberOfCPUs):
467         (isBSD):
468         (buildAutotoolsProject):
469         * Scripts/webkitpy/common/system/platforminfo.py:
470         (PlatformInfo.__init__):
471         (PlatformInfo.is_openbsd):
472         (PlatformInfo):
473         (PlatformInfo.is_netbsd):
474         (PlatformInfo._determine_os_name):
475
476 2014-03-14  Dean Jackson  <dino@apple.com>
477
478         Remove libWebKitSystemInterfaceLion.a
479         https://bugs.webkit.org/show_bug.cgi?id=130254
480
481         Reviewed by Geoffrey Garen and Andreas Kling.
482
483         No need to copy the Lion libraries into the build.
484
485         * Scripts/copy-webkitlibraries-to-product-directory:
486
487 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
488
489         [EFL][MiniBrowser] Revise help messages of command line parameters
490         https://bugs.webkit.org/show_bug.cgi?id=130222
491
492         Reviewed by Csaba Osztrogonác.
493
494         Correct the default value description and make help messages to be consistent.
495
496         * MiniBrowser/efl/main.c:
497
498 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
499
500         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
501         https://bugs.webkit.org/show_bug.cgi?id=129612
502
503         Reviewed by Darin Adler.
504
505         For new code use static NeverDestroyed<T> instead.
506
507         * DumpRenderTree/JavaScriptThreading.cpp:
508         (javaScriptThreadsMutex):
509         (javaScriptThreads):
510         * DumpRenderTree/efl/EventSender.cpp:
511         (touchPointList):
512         (delayedEventQueue):
513         * DumpRenderTree/win/FrameLoadDelegate.cpp:
514         (delegatesWithDelayedWork):
515         * Scripts/check-for-exit-time-destructors:
516         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
517         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
518         (testsMap):
519
520 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
521
522         [EFL][WK2] Fix compilation warning in Minibrowser
523         https://bugs.webkit.org/show_bug.cgi?id=130132
524
525         Reviewed by Csaba Osztrogonác.
526
527         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
528
529         * MiniBrowser/efl/main.c:
530         (on_download_request):
531
532 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
533
534         FTL should support IsBlah
535         https://bugs.webkit.org/show_bug.cgi?id=130202
536
537         Reviewed by Geoffrey Garen.
538         
539         Running existing JSRegress tests with noInline gives us coverage for these
540         changes. Chances are, this will also give coverage for other interesting things
541         as well.
542
543         * Scripts/run-jsc-stress-tests:
544
545 2014-03-12  Brian Burg  <bburg@apple.com>
546
547         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
548         https://bugs.webkit.org/show_bug.cgi?id=129744
549
550         Reviewed by Timothy Hatcher.
551
552         * DumpRenderTree/TestRunner.cpp:
553         (evaluateInWebInspectorCallback):
554         * DumpRenderTree/TestRunner.h:
555         * DumpRenderTree/efl/TestRunnerEfl.cpp:
556         (TestRunner::evaluateInWebInspector):
557         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
558         (TestRunner::evaluateInWebInspector):
559         * DumpRenderTree/mac/TestRunnerMac.mm:
560         (TestRunner::evaluateInWebInspector):
561         * DumpRenderTree/win/TestRunnerWin.cpp:
562         (TestRunner::evaluateInWebInspector):
563         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
565         (WTR::TestRunner::evaluateInWebInspector):
566         * WebKitTestRunner/InjectedBundle/TestRunner.h:
567
568 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
569
570         [GTK] build-webkit shouldn't show error message when ninja isn't installed
571         https://bugs.webkit.org/show_bug.cgi?id=130129
572
573         Reviewed by Csaba Osztrogonác.
574
575         * Scripts/webkitdirs.pm:
576         (canUseNinja): Redirecting stderr to /dev/null
577
578 2014-03-13  Andres Gomez  <agomez@igalia.com>
579
580         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
581         https://bugs.webkit.org/show_bug.cgi?id=130092
582
583         Reviewed by Csaba Osztrogonác.
584
585         Added "python-dev" as dependency for deb based distros. It is
586         already present for rpm based distros. This dependency will allow
587         libxml2 to generate its python bindings, needed by gtk-doc.
588
589         * gtk/install-dependencies:
590
591 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
592
593         Unreviewed. Fix GTK+ cmake build after r165488.
594
595         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
596
597 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
598
599         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
600         https://bugs.webkit.org/show_bug.cgi?id=130014
601
602         Reviewed by Martin Robinson.
603
604         Include cmake or autotools config header.
605
606         * MiniBrowser/gtk/BrowserDownloadsBar.c:
607         * MiniBrowser/gtk/BrowserSearchBar.c:
608         * MiniBrowser/gtk/BrowserWindow.c:
609         * MiniBrowser/gtk/main.c:
610
611 2014-03-12  Commit Queue  <commit-queue@webkit.org>
612
613         Unreviewed, rolling out r165471.
614         https://bugs.webkit.org/show_bug.cgi?id=130139
615
616         Didn't really fix the issue and broke another bot (Requested
617         by mrobinson on #webkit).
618
619         Reverted changeset:
620
621         "[CMake] Newer versions of CMake cannot find older versions of
622         Freetype"
623         https://bugs.webkit.org/show_bug.cgi?id=130107
624         http://trac.webkit.org/changeset/165471
625
626 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
627
628         It should be possible to build WebKit with FTL on iOS
629         https://bugs.webkit.org/show_bug.cgi?id=130116
630
631         Reviewed by Dan Bernstein.
632
633         * Scripts/build-webkit:
634         * Scripts/copy-webkitlibraries-to-product-directory:
635
636 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
637
638         [Win] Remove use of QTSDK
639         https://bugs.webkit.org/show_bug.cgi?id=130049
640
641         Reviewed by Darin Adler.
642
643         * DumpRenderTree/win/DumpRenderTree.cpp:
644         (initialize): Remove QuickTime code.
645         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
646         building QTMovieWin.
647
648 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
649
650         [GTK][CMAKE] Too verbose build output
651         https://bugs.webkit.org/show_bug.cgi?id=130076
652
653         Reviewed by Carlos Garcia Campos.
654
655         Instead of building with cmake --build which isn't smart about pretty printing and
656         colors, we build with a script which calls the proper build command.
657
658         * Scripts/webkitdirs.pm:
659         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
660         the CMake configuration pass.
661
662 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
663
664         [CMake] Newer versions of CMake cannot find older versions of Freetype
665         https://bugs.webkit.org/show_bug.cgi?id=130107
666
667         Reviewed by Gustavo Noronha Silva.
668
669         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
670         to CMake during jhbuild initialization.
671
672 2014-03-12  Zalan Bujtas  <zalan@apple.com>
673
674         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
675         https://bugs.webkit.org/show_bug.cgi?id=129961
676
677         Reviewed by Simon Fraser.
678
679         Now scaled content can go through the window capturing mechanism too for compositing content.
680         AppleMagnifiedMode is redundant.
681
682         * DumpRenderTree/mac/DumpRenderTree.mm:
683         (setDefaultsToConsistentValuesForTesting):
684         (runTest):
685         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
686         (createBitmapContextFromWebView):
687         * WebKitTestRunner/PlatformWebView.h:
688         * WebKitTestRunner/cg/TestInvocationCG.cpp:
689         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
690         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
691         (WTR::PlatformWebView::didInitializeClients):
692         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
693         (WTR::PlatformWebView::forceWindowFramesChanged):
694         * WebKitTestRunner/mac/main.mm:
695         (setDefaultsToConsistentValuesForTesting):
696
697 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
698
699         Unreviewed. Add myself as a committer.
700
701         * Scripts/webkitpy/common/config/contributors.json:
702
703 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
704
705         Unreviewed build fix on the EFL port when used lower version of ATK
706
707         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
708         (WTR::AccessibilityUIElement::y): Fixed typo.
709
710 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
711
712         Some images are blank in the rebaseline server UI
713         https://bugs.webkit.org/show_bug.cgi?id=130104
714
715         Reviewed by Tim Horton.
716
717         Let the server check for images in the 'retries' directory
718         if it can't find an image otherwise.
719
720         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
721         (RebaselineHTTPRequestHandler.test_result):
722
723 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
724
725         [GTK][CMake] --update-gtk has no effect
726         https://bugs.webkit.org/show_bug.cgi?id=130088
727
728         Reviewed by Philippe Normand.
729
730         * Scripts/webkitdirs.pm:
731         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
732         as an argument.
733
734 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
735
736         Add "System Font" to the list of whitelisted DRT fonts
737         https://bugs.webkit.org/show_bug.cgi?id=130046
738
739         Reviewed by Darin Adler.
740
741         * DumpRenderTree/mac/DumpRenderTree.mm:
742         (allowedFontFamilySet):
743         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
744
745 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
746
747         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
748         https://bugs.webkit.org/show_bug.cgi?id=130064
749
750         Reviewed by Philippe Normand.
751
752         * efl/jhbuildrc: Remove duplicated code.
753         * gtk/jhbuildrc: Remove duplicated code.
754         * jhbuild/jhbuildrc_common.py:
755         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
756         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
757         and is apparently necessary for GTK+.
758
759 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
760
761         check-webkit-style failed to complain about missing braces
762         https://bugs.webkit.org/show_bug.cgi?id=34189
763
764         Reviewed by Ryosuke Niwa.
765
766         * Scripts/webkitpy/style/checkers/cpp.py:
767         (check_braces):
768         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
769         (WebKitStyleTest.test_braces):
770
771 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
772
773         Remove Qt cruft from style checker.
774         https://bugs.webkit.org/show_bug.cgi?id=130085
775
776         Reviewed by Csaba Osztrogonác.
777
778         There is no 'foreach' keyword in c++. That was a Qt feature
779         added in: http://trac.webkit.org/changeset/46113
780         Qt was removed from WebKit, so we should remove the checks
781         of this keyword from check-webkit-style scripts.
782
783         * Scripts/webkitpy/style/checkers/cpp.py:
784         (check_spacing_for_function_call):
785         (check_spacing):
786         (check_braces):
787         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
788         (CppStyleTest.test_mismatching_spaces_in_parens):
789         (CppStyleTest.test_spacing_for_fncall):
790         (WebKitStyleTest.test_braces):
791
792 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
793
794         [GTK] update-webkitgtk-libs needs itstool
795         https://bugs.webkit.org/show_bug.cgi?id=130082
796
797         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
798         itstool is a dependency of building gtk-doc from version 1.19, so it should
799         be added to Tools/gtk/install-dependencies script, too.
800
801         Reviewed by Philippe Normand.
802
803         * gtk/install-dependencies:
804
805 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
806
807         webkitbot rollout ChangeLogs should be nicer
808         https://bugs.webkit.org/show_bug.cgi?id=122654
809
810         Reviewed by Csaba Osztrogonác.
811
812         Added bug urls and descriptions of rolled out patches to the rollout changelog
813         if they are present in the original changelog. Additionally removed the list of
814         changed files and functions.
815
816         * Scripts/webkitpy/common/checkout/changelog.py:
817         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
818         * Scripts/webkitpy/common/checkout/checkout.py:
819         (Checkout._changelog_data_for_revision): Store bug description.
820         * Scripts/webkitpy/common/checkout/checkout_mock.py:
821         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
822         (CheckoutTest.test_commit_info_for_revision):
823         * Scripts/webkitpy/common/checkout/commitinfo.py:
824         (CommitInfo.bug_description): Added.
825         (CommitInfo.to_json):
826         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
827         (CommitInfoTest.test_commit_info_creation):
828         * Scripts/webkitpy/tool/commands/download.py:
829         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
830         out patches for creating rollout changelog.
831         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
832         caused the regression is stored in state["bug_blocked"] now.
833         * Scripts/webkitpy/tool/commands/download_unittest.py:
834         (test_prepare_rollout):
835         (test_create_rollout_multiple_revision):
836         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
837         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
838         rolled out patches to the changelog.
839         (PrepareChangeLogForRevert.run):
840         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
841         (UpdateChangeLogsForRevertTest):
842         (test_message_for_revert):
843         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
844         (ReopenBugAfterRollout.run):
845
846 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
847
848         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
849         https://bugs.webkit.org/show_bug.cgi?id=130021
850
851         Reviewed by Mario Sanchez Prada.
852
853         Replace deprecated functions to use new API from ATK 2.11.90.
854
855         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
856         (AccessibilityUIElement::x):
857         (AccessibilityUIElement::y):
858         (AccessibilityUIElement::width):
859         (AccessibilityUIElement::height):
860         (AccessibilityUIElement::clickPointX):
861         (AccessibilityUIElement::clickPointY):
862         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
863         (WTR::AccessibilityUIElement::x):
864         (WTR::AccessibilityUIElement::y):
865         (WTR::AccessibilityUIElement::width):
866         (WTR::AccessibilityUIElement::height):
867         (WTR::AccessibilityUIElement::clickPointX):
868         (WTR::AccessibilityUIElement::clickPointY):
869
870 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
871
872         [ATK] Expose aria-posinset and aria-setsize through object attributes
873         https://bugs.webkit.org/show_bug.cgi?id=130011
874
875         Reviewed by Chris Fleizach.
876
877         Added missing implementation of numberAttributeValue both to WKTR and DRT.
878
879         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
880         (AccessibilityUIElement::numberAttributeValue):
881         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
882         (WTR::AccessibilityUIElement::numberAttributeValue):
883
884 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
885
886         [Win] Unreviewed build fix.
887
888         Some bad Windows code was committed at some point that prevents the Apple Windows port
889         from finding its runtime dependencies reliably.
890
891         * win/DLLLauncher/DLLLauncherMain.cpp:
892         (appleApplicationSupportDirectory): Restored this function.
893         (modifyPath): Update to use appleApplicationSupportDirectory function.
894
895 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
896
897         Let the user define the full address of the performance-site-server for uploading results
898         https://bugs.webkit.org/show_bug.cgi?id=129819
899
900         Reviewed by Ryosuke Niwa.
901
902         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
903         can be confusing. It's more straightforward, if you need to define explicitly the server's full
904         address along with the protocol, when you're using this parameter. I added HTTPS as the default
905         protocol for now, in order to avoid breaking the perf bots.
906
907         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
908         (_upload_json):
909         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
910         (MainTest.test_upload_json):
911
912 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
913
914         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
915         https://bugs.webkit.org/show_bug.cgi?id=130023
916
917         Reviewed by Dean Jackson.
918
919         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
920         /SAFESEH flag to DLL launcher process.
921
922 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
923
924         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
925         https://bugs.webkit.org/show_bug.cgi?id=129980
926
927         Reviewed by Carlos Garcia Campos.
928
929         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
930
931 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
932
933         [GTK] Remove the WebView source-mode WebKit1 test
934         https://bugs.webkit.org/show_bug.cgi?id=129976
935
936         Reviewed by Carlos Garcia Campos.
937
938         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
939
940 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
941
942         Unreviewed build fix for GTKbuild after the switch to CMake
943
944         * gtk/common.py:
945         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
946         test-only bot doesn't have any build files.
947
948 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
949
950         [GTK] built-product-archive does not handle GTK+ CMake build
951         https://bugs.webkit.org/show_bug.cgi?id=129941
952
953         * BuildSlaveSupport/built-product-archive:
954         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
955         the CMake build.
956
957 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
958
959         [GTK] Include CMake into install-dependencies script
960         https://bugs.webkit.org/show_bug.cgi?id=129909
961
962         Reviewed by Martin Robinson.
963
964         As since r165267 buid-webkit uses CMake by default, the dependency
965         with 'cmake' package should be introduced.
966
967         * gtk/install-dependencies: Ditto.
968
969 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
970
971         REGRESSION(165267): Broke a webkitpy unit tests
972         https://bugs.webkit.org/show_bug.cgi?id=129904
973
974         Reviewed by Jon Honeycutt.
975
976         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
977         (GtkPort._is_cmake_build):
978
979 2014-03-07  Andres Gomez  <agomez@igalia.com>
980
981         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
982         https://bugs.webkit.org/show_bug.cgi?id=129893
983
984         Reviewed by Martin Robinson.
985
986         Added "git-svn" as dependency for deb based distros and,
987         additionally, "subversion" for rpm based distros.
988
989         * gtk/install-dependencies:
990
991 2014-03-07  Roger Fong  <roger_fong@apple.com>
992
993         Remove dummy setSystemWebGLLoadPolicy client method.
994         https://bugs.webkit.org/show_bug.cgi?id=129873.
995
996         Reviewed by Dean Jackson.
997
998         * WebKitTestRunner/TestController.cpp:
999         (WTR::TestController::createWebViewWithOptions):
1000
1001 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1002
1003         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1004         https://bugs.webkit.org/show_bug.cgi?id=129886
1005
1006         Reviewed by Mark Lam.
1007
1008         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1009         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1010         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1011         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1012         make it through when in non-verbose mode.
1013
1014 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1015
1016         [GTK] buid-webkit should use CMake by default
1017         https://bugs.webkit.org/show_bug.cgi?id=129855
1018
1019         Reviewed by Carlos Garcia Campos.
1020
1021         Make the CMake build the default GTK+ build when using build-webkit. This will
1022         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1023         so that we have --gtk and --gtkautotools.
1024
1025         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1026         * Scripts/webkitpy/port/gtk.py: Ditto.
1027
1028 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1029
1030         [CMake] [GTK] Build with ninja when it is available
1031         https://bugs.webkit.org/show_bug.cgi?id=129805
1032
1033         Reviewed by Philippe Normand.
1034
1035         * Scripts/webkitdirs.pm:
1036         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1037         if it's available on the system.
1038         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1039         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1040
1041 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1042
1043         If the FTL is build-time enabled then it should be run-time enabled.
1044
1045         Rubber stamped by Geoffrey Garen.
1046
1047         * Scripts/run-jsc-stress-tests:
1048
1049 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1050
1051         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1052         https://bugs.webkit.org/show_bug.cgi?id=129837
1053
1054         Reviewed by Michael Saboff.
1055
1056         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1057         The fix is to use find instead of ls like we do in shell-runner.sh.
1058
1059         * Scripts/run-jsc-stress-tests:
1060
1061 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1062
1063         filter-build-webkit should not strip .o
1064         https://bugs.webkit.org/show_bug.cgi?id=129614
1065
1066         Reviewed by Dean Jackson.
1067
1068         This makes it much easier to jump from the failing output at
1069         the end back up to the compile errors earlier in the output.
1070
1071         * Scripts/filter-build-webkit:
1072
1073 2014-03-06  Anders Carlsson  <andersca@apple.com>
1074
1075         Build WebKit2 before building WebKit
1076         https://bugs.webkit.org/show_bug.cgi?id=129831
1077         <rdar://problem/15920020>
1078
1079         Reviewed by Dan Bernstein.
1080
1081         * Scripts/build-webkit:
1082         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1083
1084 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1085
1086         make-3.82 fails to build on ARM/Linux
1087         https://bugs.webkit.org/show_bug.cgi?id=107926
1088
1089         Reviewed by Martin Robinson.
1090
1091         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1092         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1093         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1094         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1095
1096         * gtk/patches/make-3.82-arg-list-length.patch:
1097
1098 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1099
1100         [GTK] Close the page when the view is disposed instead of when finalized
1101         https://bugs.webkit.org/show_bug.cgi?id=129783
1102
1103         Reviewed by Sergio Villar Senin.
1104
1105         Add test case but disabled for now because it's affetected by bug #129684.
1106
1107         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1108         (testProcessPerWebView):
1109
1110 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1111
1112         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1113         https://bugs.webkit.org/show_bug.cgi?id=129738
1114
1115         Reviewed by Sergio Villar Senin.
1116
1117         The problem is that we are calling g_object_unref() for the
1118         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1119         view only increases the reference counter when the settings is not
1120         the same it currently has. We should release our reference once.
1121
1122         * MiniBrowser/gtk/main.c:
1123         (createBrowserWindow):
1124         (main):
1125
1126 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1127
1128         [GTK][CMake] Tarball is created with wrong tarball paths
1129         https://bugs.webkit.org/show_bug.cgi?id=129496
1130
1131         Reviewed by Daniel Bates.
1132
1133         * gtk/make-dist.py:
1134         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1135         landing the original patch with some suggestions from the reviewer. With the
1136         checks corrected, the tarball path is constructed properly.
1137
1138 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1139
1140         Unreviewed. Update my email in contributors.json
1141
1142         * Scripts/webkitpy/common/config/contributors.json:
1143
1144 2014-03-05  Dean Jackson  <dino@apple.com>
1145
1146         [WebGL] Use WKSI to see what the system policy for WebGL is
1147         https://bugs.webkit.org/show_bug.cgi?id=129722
1148         <rdar://problem/15790542>
1149
1150         Reviewed by Tim Horton.
1151
1152         Dummy entry for setSystemWebGLLoadPolicy.
1153
1154         * WebKitTestRunner/TestController.cpp:
1155         (WTR::TestController::createWebViewWithOptions):
1156
1157 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1158
1159         [GTK][CMake] Generate documentation for the DOM bindings
1160         https://bugs.webkit.org/show_bug.cgi?id=126211
1161
1162         Reviewed by Carlos Garcia Campos.
1163
1164         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1165         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1166         * gtk/generate-webkitdom-doc-files: Removed.
1167         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1168         that it can be called by generate-gtkdoc.
1169
1170 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1171
1172         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1173         https://bugs.webkit.org/show_bug.cgi?id=129380
1174
1175         Reviewed by Philippe Normand.
1176
1177         * Scripts/webkitdirs.pm:
1178         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1179         skipping CMake execution.
1180
1181 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1182
1183         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1184         https://bugs.webkit.org/show_bug.cgi?id=129651
1185
1186         Reviewed by Philippe Normand.
1187
1188         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1189
1190 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1191
1192         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1193         https://bugs.webkit.org/show_bug.cgi?id=129637
1194
1195         Reviewed by Carlos Garcia Campos.
1196
1197         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1198         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1199         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1200         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1201         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1202         (TestFactory.__init__): Add the test for GTK+.
1203         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1204
1205 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1206
1207         [ATK] Expose missing functionalities of AtkTableCell to AT
1208         https://bugs.webkit.org/show_bug.cgi?id=129492
1209
1210         Reviewed by Mario Sanchez Prada.
1211
1212         Reducing some code by using new API of AtkTableCell.
1213
1214         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1215         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1216
1217 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1218
1219         Preparing to run layout tests on Wincairo.
1220         https://bugs.webkit.org/show_bug.cgi?id=129709
1221
1222         Reviewed by Brent Fulgham.
1223
1224         * Scripts/webkitdirs.pm:
1225         (setPathForRunningWebKitApp):
1226         Add GStreamer directory for WinCairo running layout tests.
1227         * win/DLLLauncher/DLLLauncherMain.cpp:
1228         (modifyPath):
1229         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1230
1231 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1232
1233         [GTK] Simplify the GObject DOM bindings API break check into one step
1234         https://bugs.webkit.org/show_bug.cgi?id=129571
1235
1236         Reviewed by Carlos Garcia Campos.
1237
1238         * GNUmakefile.am: Add the API break check to 'make check.'
1239         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1240         * gtk/check-gdom-symbols: Removed.
1241         * gtk/webkitdom.py: Added.
1242         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1243         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1244
1245 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1246
1247         Add Jeremy Jones to the contributors list as a contributor.
1248
1249         * Scripts/webkitpy/common/config/contributors.json:
1250
1251 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1252
1253         Unreviewed. Update contact email.
1254         https://bugs.webkit.org/show_bug.cgi?id=129610
1255
1256         * Scripts/webkitpy/common/config/contributors.json:
1257
1258 2014-03-02  Brian Burg  <bburg@apple.com>
1259
1260         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1261         https://bugs.webkit.org/show_bug.cgi?id=129460
1262
1263         Reviewed by Dan Bernstein.
1264
1265         Don't unconditionally open the inspector before running an inspector test.
1266         Instead, the test should request that the inspector open when it's ready.
1267
1268         This change was lost during a rebase, but is the same change made to
1269         DumpRenderTree.
1270
1271         * WebKitTestRunner/TestInvocation.cpp:
1272         (WTR::TestInvocation::invoke): 
1273
1274 2014-03-02  Darin Adler  <darin@apple.com>
1275
1276         Split TextIteratorBehavior into a separate header
1277         https://bugs.webkit.org/show_bug.cgi?id=129578
1278
1279         Reviewed by Sam Weinig.
1280
1281         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1282         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1283         task easy, but the remove is still a bit of a pain.
1284
1285 2014-03-02  Darin Adler  <darin@apple.com>
1286
1287         Sort Mac platform export files so they merge better
1288         https://bugs.webkit.org/show_bug.cgi?id=129581
1289
1290         Reviewed by Sam Weinig.
1291
1292         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1293         Mac export files in a "canonical" order for this project.
1294
1295 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1296
1297         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1298         https://bugs.webkit.org/show_bug.cgi?id=129438
1299
1300         Reviewed by Simon Fraser.
1301
1302         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1303         offscreen window. It makes testing subpixel rendering and positioning possible.
1304
1305         Both the offscreen window's and WebKit's scaling are set accordingly.
1306
1307         * DumpRenderTree/mac/DumpRenderTree.mm:
1308         (createWebViewAndOffscreenWindow): cleanup
1309         (destroyWebViewAndOffscreenWindow): cleanup
1310         (dumpRenderTree):
1311         (changeWindowScaleIfNeeded):
1312         (runTest):
1313         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1314         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1315         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1316         * WebKitTestRunner/PlatformWebView.h:
1317         * WebKitTestRunner/TestInvocation.cpp:
1318         (WTR::changeWindowScaleIfNeeded):
1319         (WTR::TestInvocation::invoke):
1320         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1321         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1322         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1323         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1324         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1325         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1326         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1327         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1328
1329 2014-02-28  Anders Carlsson  <andersca@apple.com>
1330
1331         Remove logging.
1332
1333         Reviewed by Dan Bernstein.
1334
1335         * MiniBrowser/mac/WK2BrowserWindowController.m:
1336         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1337
1338 2014-02-28  Daniel Bates  <dabates@apple.com>
1339
1340         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1341         https://bugs.webkit.org/show_bug.cgi?id=129163
1342
1343         Reviewed by David Kilzer.
1344
1345         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1346         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1347         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1348         bundle.
1349
1350         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1351         which is specified either explicitly when building with MAKE(1) or implicitly by
1352         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1353         the OS X SDK and toolchain since the built products are only applicable to OS X.
1354
1355         * DumpRenderTree/ios/PerlSupport/Makefile:
1356
1357 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1358
1359         Unreviewed, rolling out r164859.
1360         http://trac.webkit.org/changeset/164859
1361         https://bugs.webkit.org/show_bug.cgi?id=129483
1362
1363         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
1364         #webkit).
1365
1366         * DumpRenderTree/mac/DumpRenderTree.mm:
1367         (createWebViewAndOffscreenWindow):
1368         (dumpRenderTree):
1369         (runTest):
1370         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1371         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1372         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1373         * WebKitTestRunner/PlatformWebView.h:
1374         * WebKitTestRunner/TestInvocation.cpp:
1375         (WTR::TestInvocation::invoke):
1376         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1377         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1378         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1379         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1380         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1381
1382 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1383
1384         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1385         https://bugs.webkit.org/show_bug.cgi?id=129438
1386
1387         Reviewed by Simon Fraser.
1388
1389         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1390         offscreen window. It makes testing subpixel rendering and positioning possible.
1391
1392         Both the offscreen window's and WebKit's scaling are set accordingly.
1393
1394         * DumpRenderTree/mac/DumpRenderTree.mm:
1395         (createWebViewAndOffscreenWindow): unrelated cleanup.
1396         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
1397         (dumpRenderTree):
1398         (changeOffscreenWindowScaleIfNeeded):
1399         (runTest):
1400         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1401         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1402         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
1403         * WebKitTestRunner/PlatformWebView.h:
1404         * WebKitTestRunner/TestInvocation.cpp:
1405         (WTR::changeOffscreenWindowScaleIfNeeded):
1406         (WTR::TestInvocation::invoke):
1407         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1408         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
1409
1410 2014-02-27  Brian Burg  <bburg@apple.com>
1411
1412         Web Inspector: model tests should use a special Test.html inspector page
1413         https://bugs.webkit.org/show_bug.cgi?id=129190
1414
1415         Reviewed by Timothy Hatcher.
1416
1417         Remove code that immediately opens the Web Inspector based on the file path of the test.
1418         Instead, the test page should request that the inspector open inside its `test()` method.
1419
1420         This change is necessary because otherwise, the inspector would be opened too early for
1421         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
1422         will get loaded instead of the minimal test page.
1423
1424         * DumpRenderTree/efl/DumpRenderTree.cpp:
1425         (createTestRunner):
1426         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1427         (runTest):
1428         * DumpRenderTree/mac/DumpRenderTree.mm:
1429         (runTest):
1430         * DumpRenderTree/win/DumpRenderTree.cpp:
1431         (runTest):
1432
1433 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1434
1435         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
1436         https://bugs.webkit.org/show_bug.cgi?id=127076
1437
1438         Reviewed by Anders Carlsson.
1439
1440         Avoid match for :: as start of a member initialization list. Modify expression to match
1441         after a colon either non-colon character or end of line.
1442
1443         * Scripts/webkitpy/style/checkers/cpp.py:
1444         (check_member_initialization_list):
1445         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1446         (WebKitStyleTest.test_member_initialization_list):
1447
1448 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
1449
1450         Unreviewed. Update my email addresses in contributors.json.
1451
1452         * Scripts/webkitpy/common/config/contributors.json:
1453
1454 2014-02-27  Alberto Garcia  <berto@igalia.com>
1455
1456         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
1457         https://bugs.webkit.org/show_bug.cgi?id=128927
1458
1459         Reviewed by Philippe Normand.
1460
1461         Encode manually the data for sys.{stdout,stderr}.write.
1462
1463         * gtk/gtkdoc.py:
1464         (GTKDoc._run_command):
1465
1466 2014-02-27  Andres Gomez  <agomez@igalia.com>
1467
1468         Unreviewed. Add myself to watchlists
1469
1470         * Scripts/webkitpy/common/config/watchlist: Add myself to
1471         watchlists.
1472
1473 2014-02-27  Andres Gomez  <agomez@igalia.com>
1474
1475         Unreviewed, rolling out r164790.
1476         http://trac.webkit.org/changeset/164790
1477
1478         Revert r164790 because of erroneous commit log
1479
1480         * Scripts/webkitpy/common/config/watchlist:
1481
1482 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
1483
1484         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
1485         https://bugs.webkit.org/show_bug.cgi?id=129250
1486
1487         Reviewed by Mario Sanchez Prada.
1488
1489         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
1490         Implementing methods so that we could test column/row headers represented as an array of cells.
1491
1492         * DumpRenderTree/AccessibilityUIElement.cpp:
1493         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1494         (AccessibilityUIElement::columnHeaders):
1495         (AccessibilityUIElement::rowHeaders):
1496         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
1497         (AccessibilityUIElement::columnHeaders):
1498         (AccessibilityUIElement::rowHeaders):
1499         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1500         (WTR::AccessibilityUIElement::rowHeaders):
1501         (WTR::AccessibilityUIElement::columnHeaders):
1502         * efl/jhbuild.modules:
1503         * gtk/jhbuild.modules:
1504
1505 2014-02-27  Andres Gomez  <agomez@igalia.com>
1506
1507         Unreviewed. Add myself to watchlists
1508
1509         * Scripts/webkitpy/common/config/watchlist: Add myself to
1510         watchlists.
1511
1512 2014-02-27  Andres Gomez  <agomez@igalia.com>
1513
1514         Unreviewed. Add myself as a committer.
1515
1516         * Scripts/webkitpy/common/config/contributors.json:
1517
1518 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1519
1520         Unreviewed. Add Víctor Jáquez and myself to watchlists
1521
1522         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
1523         myself to watchlists.
1524
1525 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
1526
1527         Unreviewed. Add myself as a committer.
1528
1529         * Scripts/webkitpy/common/config/contributors.json:
1530
1531 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1532
1533         Unreviewed. Moved myself to the list of committers.
1534
1535         * Scripts/webkitpy/common/config/contributors.json:
1536
1537 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1538
1539         [GTK] Reduplicate common.top_level_path in scripts
1540         https://bugs.webkit.org/show_bug.cgi?id=129291
1541
1542         Reviewed by Philippe Normand.
1543
1544         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
1545         path manipulation and weird dependencies on the jhbuild infrastructure.
1546
1547         * Scripts/run-gtk-tests: Use common again.
1548         (TestRunner._setup_testing_environment): Ditto.
1549         * gtk/check-gdom-symbols: Ditto.
1550         * gtk/common.py:
1551         (top_level_path): Re-add top_level_path..
1552         (get_build_path): Use the builtin top_level_path again.
1553         * gtk/find-make-dist-errors: Use common again.
1554         (get_missing_headers): Ditto.
1555         * gtk/generate-inspector-gresource-manifest.py: Ditto.
1556
1557 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1558
1559         runscript: line 42: /bin/ls: Argument list too long
1560         https://bugs.webkit.org/show_bug.cgi?id=129376
1561
1562         Reviewed by Michael Saboff.
1563
1564         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
1565         We should use find instead, which generates the list of files rather than expanding them all on 
1566         the command line and spitting them back out.
1567
1568         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
1569
1570 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1571
1572         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
1573         https://bugs.webkit.org/show_bug.cgi?id=129377
1574
1575         Reviewed by Csaba Osztrogonác.
1576
1577         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
1578
1579 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
1580
1581         [GTK] Re-enable gtk-doc in EWS
1582         https://bugs.webkit.org/show_bug.cgi?id=128369
1583
1584         Reviewed by Carlos Garcia Campos.
1585
1586         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1587
1588         * Scripts/webkitpy/common/config/ports.py:
1589         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1590         (GtkWK2Port.build_webkit_command): Ditto.
1591         * Scripts/webkitpy/common/config/ports_unittest.py:
1592         (DeprecatedPortTest.test_gtk_port): Ditto.
1593         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1594
1595 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1596
1597         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
1598         https://bugs.webkit.org/show_bug.cgi?id=129319
1599
1600         Reviewed by Carlos Garcia Campos.
1601
1602         * gtk/generate-gtkdoc:
1603         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
1604
1605 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
1606
1607         Unreviewed. Add myself as a committer.
1608
1609         * Scripts/webkitpy/common/config/contributors.json:
1610
1611 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
1612
1613         [CSS Grid Layout] Add ENABLE flag
1614         https://bugs.webkit.org/show_bug.cgi?id=129153
1615
1616         Reviewed by Simon Fraser.
1617
1618         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
1619         all ports for developer builds.
1620
1621         * Scripts/webkitperl/FeatureList.pm:
1622
1623 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1624
1625         Added myself as a committer.
1626
1627         Unreviewed.
1628
1629         * Scripts/webkitpy/common/config/contributors.json:
1630
1631 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1632
1633         Unreviewed. Moved myself to the list of committers.
1634
1635         * Scripts/webkitpy/common/config/contributors.json:
1636
1637 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1638
1639         Move myself to the committers list.
1640
1641         Unreviewed.
1642
1643         * Scripts/webkitpy/common/config/contributors.json:
1644
1645 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
1646
1647         Unreviewed. Add myself as a committer.
1648
1649         * Scripts/webkitpy/common/config/contributors.json:
1650
1651 2014-02-25  Commit Queue  <commit-queue@webkit.org>
1652
1653         Unreviewed, rolling out r164639.
1654         http://trac.webkit.org/changeset/164639
1655         https://bugs.webkit.org/show_bug.cgi?id=129302
1656
1657         gtk-doc still have problems in EWS (Requested by rego on
1658         #webkit).
1659
1660         * Scripts/webkitpy/common/config/ports.py:
1661         (GtkPort.build_webkit_command):
1662         (GtkWK2Port.build_webkit_command):
1663         * Scripts/webkitpy/common/config/ports_unittest.py:
1664         (DeprecatedPortTest.test_gtk_port):
1665         (DeprecatedPortTest.test_gtk_wk2_port):
1666
1667 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
1668
1669         [GTK] Re-enable gtk-doc in EWS
1670         https://bugs.webkit.org/show_bug.cgi?id=128369
1671
1672         Reviewed by Carlos Garcia Campos.
1673
1674         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1675
1676         * Scripts/webkitpy/common/config/ports.py:
1677         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1678         (GtkWK2Port.build_webkit_command): Ditto.
1679         * Scripts/webkitpy/common/config/ports_unittest.py:
1680         (DeprecatedPortTest.test_gtk_port): Ditto.
1681         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1682
1683 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1684
1685         [GTK] Mark view source mode methods as deprecated
1686         https://bugs.webkit.org/show_bug.cgi?id=128920
1687
1688         Reviewed by Martin Robinson.
1689
1690         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1691         (beforeAll): Remove view mode test.
1692
1693 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1694
1695         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
1696         https://bugs.webkit.org/show_bug.cgi?id=128417
1697
1698         Reviewed by Carlos Garcia Campos.
1699
1700         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
1701         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
1702         a makefile. This allows accepting a header list from the build system, which can be used
1703         to dynamically build a list of ignored files. We can ignore any source file that doesn't
1704         have a corresponding header file on the header list. 
1705         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
1706         source directories to gtkdoc-scan.
1707
1708 2014-02-24  Anders Carlsson  <andersca@apple.com>
1709
1710         Add a DefaultVisitedLinkProvider and route visited link actions through it
1711         https://bugs.webkit.org/show_bug.cgi?id=129285
1712
1713         Reviewed by Dan Bernstein.
1714
1715         * MiniBrowser/mac/AppDelegate.m:
1716         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1717         Set a shared history so we'll get visited link tracking.
1718
1719         * MiniBrowser/mac/WK1BrowserWindowController.m:
1720         (-[WK1BrowserWindowController awakeFromNib]):
1721         Set a group name.
1722
1723 2014-02-24  Dan Bernstein  <mitz@apple.com>
1724
1725         iOS build fix after r164577.
1726
1727         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1728         (AccessibilityUIElement::selectedChildrenCount):
1729         (AccessibilityUIElement::selectedChildAtIndex):
1730
1731 2014-02-24  David Kilzer  <ddkilzer@apple.com>
1732
1733         [ASan] Remove methods from ignore list that no longer cause crashes
1734         <http://webkit.org/b/129257>
1735
1736         Reviewed by Anders Carlsson.
1737
1738         * asan/webkit-asan-ignore.txt: Remove old methods.
1739
1740 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1741
1742         Extract common parts from jhbuildrc files.
1743         https://bugs.webkit.org/show_bug.cgi?id=125986
1744
1745         Reviewed by Csaba Osztrogonác.
1746
1747         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
1748
1749         * Scripts/run-gtk-tests:
1750         (TestRunner._setup_testing_environment):
1751         * efl/common.py: Removed.
1752         * efl/jhbuildrc:
1753         * gtk/check-gdom-symbols:
1754         * gtk/common.py:
1755         (binary_build_path):
1756         (get_build_path):
1757         * gtk/find-make-dist-errors:
1758         (get_missing_headers):
1759         * gtk/generate-gtkdoc:
1760         (get_webkit2_options):
1761         (get_webkit1_options.src_path):
1762         (get_webkit1_options):
1763         (get_webkitdom_options.src_path):
1764         (get_webkitdom_options):
1765         * gtk/generate-inspector-gresource-manifest.py:
1766         * gtk/jhbuildrc:
1767         * jhbuild/jhbuildrc_common.py: Added.
1768         (script_path):
1769         (top_level_path):
1770         (init):
1771
1772 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
1773
1774         Unreviewed. Fix code indentation and spacing.
1775
1776         * Scripts/webkitpy/style/checkers/js.py:
1777         (SingleQuoteChecker.check):
1778
1779 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
1780
1781         [ATK] Wrong selected element at a given index in a list box.
1782         https://bugs.webkit.org/show_bug.cgi?id=129039
1783
1784         Reviewed by Chris Fleizach.
1785
1786         Added missing implementation and proposed some new function for testing selection
1787         in a list boxes.
1788
1789         * DumpRenderTree/AccessibilityUIElement.cpp:
1790         (setSelectedChildAtIndexCallback):
1791         (removeSelectionAtIndexCallback):
1792         (AccessibilityUIElement::getJSClass):
1793         * DumpRenderTree/AccessibilityUIElement.h:
1794         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1795         (AccessibilityUIElement::selectedChildrenCount):
1796         (AccessibilityUIElement::selectedChildAtIndex):
1797         (AccessibilityUIElement::setSelectedChildAtIndex):
1798         (AccessibilityUIElement::removeSelectionAtIndex):
1799         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1800         (AccessibilityUIElement::selectedChildrenCount):
1801         (AccessibilityUIElement::selectedChildAtIndex):
1802         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1803         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1804         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1805         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1806         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1807         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1808         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1809         (WTR::AccessibilityUIElement::selectedChildrenCount):
1810         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1811         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1812
1813 2014-02-23  Diego Pino García  <dpino@igalia.com>
1814
1815         [GTK] Fix build after Web Inspector code reorganization (r164543)
1816         https://bugs.webkit.org/show_bug.cgi?id=129231
1817
1818         Reviewed by Dean Jackson.
1819
1820         * gtk/generate-inspector-gresource-manifest.py:
1821         Modify paths to Web Inspector code.
1822
1823 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1824
1825         [GTK] generate-gtkdoc should use argparse
1826         https://bugs.webkit.org/show_bug.cgi?id=128418
1827
1828         Reviewed by Carlos Garcia Campos.
1829
1830         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
1831         to all functions, and guard the main routine with a __name__ == __main__ check.
1832
1833 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1834
1835         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
1836         https://bugs.webkit.org/show_bug.cgi?id=129191
1837
1838         Reviewed by Anders Carlsson.
1839
1840         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
1841         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
1842         name of the directory is "lib" and not "libs". Instead we should use the CMake
1843         variable specifically assigned to this task.
1844
1845 2014-02-23  David Kilzer  <ddkilzer@apple.com>
1846
1847         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
1848         <http://webkit.org/b/129209>
1849
1850         Reviewed by Geoffrey Garen.
1851
1852         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
1853         ignore list to make ASan builds usable again.  Follow-up
1854         investigation is tracked by <rdar://problem/16055903>.
1855
1856 2014-02-20  David Farler  <dfarler@apple.com>
1857
1858         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
1859         https://bugs.webkit.org/show_bug.cgi?id=128622
1860
1861         Reviewed by Simon Fraser.
1862
1863         With this change, we now have layout tests running in both DumpRenderTree
1864         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
1865         simulator.
1866
1867         * Scripts/old-run-webkit-tests:
1868         In general, make any specific reference to DumpRenderTree
1869         able to refer to WebKitTestRunner wherever possible:
1870         - Rename functions to remove DRT-specific naming.
1871         - Name FIFOs after the tool that is being used.
1872         -- Clean up FIFO creation code
1873         Other necessary changes:
1874         - Allow use of an ios-sim-wk2 platform.
1875         - Clean up platform hierarchy creation where the simulator platform behavior differed.
1876         * WebKitTestRunner/TestController.cpp:
1877         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
1878         (WTR::TestController::TestController):
1879         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1880         Copy the injected bundle into the app bundle.
1881
1882 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
1883
1884         run-webkit-httpd fails to find httpd configuation file.
1885
1886         Reviewed by Ryosuke Niwa.
1887
1888         * Scripts/webkitperl/httpd.pm:
1889         (getHTTPDConfigPathForTestDirectory):
1890
1891 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
1892
1893         Fix TimeRanges layering violations
1894         https://bugs.webkit.org/show_bug.cgi?id=128717
1895
1896         Reviewed by Jer Noble.
1897
1898         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
1899         (TestWebKitAPI::TEST):
1900
1901 2014-02-21  Diego Pino García  <dpino@igalia.com>
1902
1903         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
1904         https://bugs.webkit.org/show_bug.cgi?id=128422
1905
1906         Reviewed by Joseph Pecoraro.
1907
1908         * Scripts/webkitpy/style/checkers/js.py:
1909         (JSChecker.__init__):
1910         (JSChecker.check):
1911         (SingleQuoteChecker):
1912         (SingleQuoteChecker.__init__):
1913         (SingleQuoteChecker.check):
1914         * Scripts/webkitpy/style/checkers/js_unittest.py:
1915         (JSTestCase.assertError.error_for_test):
1916         (JSTestCase.assertError):
1917         (JSTestCase.test_no_error):
1918         (JSTestCase.test_error):
1919
1920 == Rolled over to ChangeLog-2014-02-20 ==