Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTes...
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-30  David Levin  <levin@chromium.org>
2
3         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
4         https://bugs.webkit.org/show_bug.cgi?id=69039
5
6         Reviewed by Adam Barth.
7
8         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
9         Actually skip only one specific test that is failing on Windows.
10
11 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
12
13         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
14
15         For DRT we didn't install the message handler early enough to
16         catch output while constructing the QApplication. For WTR we
17         didn't even install a message handler.
18
19         Since the UI process will forward any output from the web process
20         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
21         in WTR before the web process is started. This is picked up by the
22         web process which installs its own message handler.
23
24         The environment variable can be overriden on the command line if you
25         want to see output from the web process, or you can pass --verbose to
26         WTR to see output from both processes.
27
28         https://bugs.webkit.org/show_bug.cgi?id=69132
29
30         Reviewed by Andreas Kling.
31
32         * DumpRenderTree/qt/main.cpp:
33         * WebKitTestRunner/qt/main.cpp:
34
35 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
36
37         [Qt] Make sure WTR sizes the window and item correctly
38
39         Revision 96345 changed the logic for how the view and
40         window was created, but missed a vital part, setting
41         the size.
42
43         We now use a QSGView for the window, that has a simple
44         item as its root object that is always resized to fit
45         within the window. The webview is then parented to the
46         root object and set to anchors.fill: parent. That way
47         any window geometry changes will propagate to the web
48         view.
49
50         https://bugs.webkit.org/show_bug.cgi?id=69134
51
52         Reviewed by Andreas Kling.
53
54         * WebKitTestRunner/PlatformWebView.h:
55         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
56
57 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
58
59         [EFL] Only save the current viewport in PixelDumpSupportEfl.
60         https://bugs.webkit.org/show_bug.cgi?id=68450
61
62         Reviewed by Antonio Gomes.
63
64         The previous implementation saved the whole page contents in the final
65         PNG, however the baselines and expectations in the tree only want the
66         current viewport (with a scrollbar, if needed), so we now only save the
67         currently visible contents.
68
69         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
70         (createBitmapContextFromWebView): Use
71         ewk_frame_visible_content_geometry_get instead of
72         ewk_frame_contents_size_get.
73
74 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
75
76         [EFL] Support and keep track of extra windows (views).
77         https://bugs.webkit.org/show_bug.cgi?id=68454
78
79         Reviewed by Antonio Gomes.
80
81         So far, window.open and related JavaScript code would not work, as
82         DRTView did not implementation
83         Ewk_View_Smart_Class::window_{open,close}. The default implementation
84         in ewk just returns the current window/view, which broke any
85         layouttest which relied on window.open.
86
87         We now properly create and remove these new views. Unfortunately, the
88         current way ewk works (and due to the fact that we cannot pass class
89         methods as function pointers to the EFL functions), DRTView needs to
90         know that DRTChrome exists and call `browser' directly in some points.
91
92         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
93         (onWindowCreate):
94         (onWindowCloseDelayed):
95         (onWindowClose):
96         (drtViewTiledAdd):
97
98 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
99
100         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
101         https://bugs.webkit.org/show_bug.cgi?id=42698
102
103         Reviewed by Andreas Kling.
104
105         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
106         and call clearApplicationCache when layoutTest start up.
107
108         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
109         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
110         (WTR::InjectedBundle::beginTesting):
111         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
112         (WTR::LayoutTestController::clearAllApplicationCaches):
113         (WTR::LayoutTestController::setAppCacheMaximumSize):
114         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
115
116 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
117
118         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
119         https://bugs.webkit.org/show_bug.cgi?id=69145
120
121         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
122         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
123         and is perfectly suitable for SceneGraph as well. GraphicsScene events
124         will not be available in QtGui anymore in future. Therefore we also have to change
125         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
126
127         Reviewed by Chang Shu.
128
129         * WebKitTestRunner/EventSenderProxy.h:
130         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
131         (WTR::EventSenderProxy::createMouseEvent):
132         (WTR::EventSenderProxy::mouseDown):
133         (WTR::EventSenderProxy::mouseUp):
134         (WTR::EventSenderProxy::mouseMoveTo):
135
136 2011-09-30  James Robinson  <jamesr@chromium.org>
137
138         [chromium] Add WebKit API for sending input events to the compositor thread
139         https://bugs.webkit.org/show_bug.cgi?id=69117
140
141         Reviewed by Darin Fisher.
142
143         Adds support for creating and setting a compositor thread in DRT.
144
145         * DumpRenderTree/chromium/WebViewHost.cpp:
146         (WebViewHost::WebViewHost):
147         * DumpRenderTree/chromium/WebViewHost.h:
148
149 2011-09-29  David Levin  <levin@chromium.org>
150
151         watchlist: Add cross-checks for WatchList once it is filled.
152         https://bugs.webkit.org/show_bug.cgi?id=68975
153
154         Reviewed by Eric Seidel.
155
156         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
157         instead of having trivial getter and setters.
158         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
159         pass the validation checks.
160         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
161         and fix a few style nits.
162         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
163         validation checks.
164         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
165
166 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
167
168         run-api-tests fails on chromium-win bot
169         https://bugs.webkit.org/show_bug.cgi?id=69121
170
171         On Windows running a perl script needs the interpreter.
172
173         Reviewed by Adam Barth.
174
175         * Scripts/run-api-tests:
176         (buildTestTool):
177
178 2011-09-29  Adam Barth  <abarth@webkit.org>
179
180         Attempt to make this tool work on Windows.
181
182         * Scripts/run-api-tests:
183         (buildTestTool):
184
185 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
186
187         [Qt] Try to fix the minial build
188
189         * QtTestBrowser/launcherwindow.cpp:
190         * QtTestBrowser/webpage.cpp:
191
192 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
193
194         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
195
196         QWidget and friends now live in the QtWidgets library. We update
197         includes in implementation files and private headers to us the
198         non-module-prefixed path, and leave the lookup for the include
199         path. For public headers we have to ifdef the includes as the
200         user might now have the modules we need in his QT config.
201
202         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
203         have to update our code and use windowHandle() for setting the
204         parent relationships.
205
206         https://bugs.webkit.org/show_bug.cgi?id=68687
207
208         Reviewed by Andreas Kling.
209
210         * DumpRenderTree/qt/DumpRenderTree.pro:
211         * DumpRenderTree/qt/ImageDiff.pro:
212         * MiniBrowser/qt/BrowserView.cpp:
213         * MiniBrowser/qt/BrowserView.h:
214         * MiniBrowser/qt/BrowserWindow.cpp:
215         * MiniBrowser/qt/BrowserWindow.h:
216         * MiniBrowser/qt/MiniBrowser.pro:
217         * MiniBrowser/qt/MiniBrowserApplication.h:
218         * MiniBrowser/qt/main.cpp:
219         * QtTestBrowser/QtTestBrowser.pro:
220         * QtTestBrowser/launcherwindow.cpp:
221         * QtTestBrowser/launcherwindow.h:
222         * QtTestBrowser/locationedit.h:
223         * QtTestBrowser/main.cpp:
224         * QtTestBrowser/mainwindow.cpp:
225         * QtTestBrowser/mainwindow.h:
226         * QtTestBrowser/webinspector.h:
227         * QtTestBrowser/webpage.cpp:
228         * QtTestBrowser/webview.cpp:
229         * WebKitTestRunner/PlatformWebView.h:
230         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
231
232 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
233
234         Initial implementation of WebInspector for WebKit2 GTK port.
235         https://bugs.webkit.org/show_bug.cgi?id=68235
236
237         Reviewed by Martin Robinson.
238
239         * MiniBrowser/gtk/BrowserWindow.c:
240         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
241
242 2011-09-29  Adam Barth  <abarth@webkit.org>
243
244         Unbreak the "update expectatations" button by using the existing
245         machinery to create the failureInfo objects.
246
247         Unbreak the "close" button on the progress dialog by using |this|
248         instead of the old name of the object.
249
250         Teach the controllers unit test not to talk to the actual network.
251
252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
253         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
255
256 2011-09-29  Hans Wennborg  <hans@chromium.org>
257
258         IndexedDB: Use LevelDB also for in-memory databases
259         https://bugs.webkit.org/show_bug.cgi?id=68903
260
261         Reviewed by Steve Block.
262
263         Remove the temporary dir that was necessary before LevelDB supported
264         in-memory databases.
265
266         * DumpRenderTree/chromium/TestShell.cpp:
267         (TestShell::TestShell):
268         * DumpRenderTree/chromium/TestShell.h:
269
270 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
271
272         Run TestWebKitAPI on Chromium buildbots
273         https://bugs.webkit.org/show_bug.cgi?id=68678
274
275         Reviewed by Tony Chang.
276
277         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
278
279 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
280
281         garden-o-matic results should anticipate 0 unexpected failures.
282         https://bugs.webkit.org/show_bug.cgi?id=69036
283
284         Also fixes controllers: UnexpectedFailures test.
285
286         Reviewed by Adam Barth.
287
288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
289
290 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
291
292         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
293
294         https://bugs.webkit.org/show_bug.cgi?id=67253
295
296         Reviewed by Eric Seidel.
297
298         Nearly all of the work in this was done by Simon Fraser; I'm
299         just repackaging it and cleaning it up a bit. This change
300         modifies port.diff_image() to return a tuple of (pass/fail,
301         %age), adds the value to the FailureImageHashMismatch, and
302         writes the value into the full_results.json files to be
303         displayed in the results page.
304
305         * Scripts/webkitpy/layout_tests/controllers/manager.py:
306         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
307         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
308         * Scripts/webkitpy/layout_tests/models/test_failures.py:
309         * Scripts/webkitpy/layout_tests/port/base.py:
310         * Scripts/webkitpy/layout_tests/port/chromium.py:
311         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
312         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
313         * Scripts/webkitpy/layout_tests/port/test.py:
314         * Scripts/webkitpy/layout_tests/port/webkit.py:
315         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
316
317 2011-09-25  Kentaro Hara  <haraken@chromium.org>
318
319         Unreviewed. Adding myself to committers.py.
320
321         * Scripts/webkitpy/common/config/committers.py:
322
323 2011-09-28  Adam Barth  <abarth@webkit.org>
324
325         garden-o-matic shouldn't depend on test-results.appspot.com
326         https://bugs.webkit.org/show_bug.cgi?id=69019
327
328         Reviewed by Dimitri Glazkov.
329
330         This patch moves garden-o-matic from getting full_results.json from
331         test-results.appspot.com to getting that information directly from the
332         buildbot.  This patch improve the load time and accuracy of
333         garden-o-matic because test-results.appspot.com is slow and is dropping
334         a significant number of writes (see
335         https://bugs.webkit.org/show_bug.cgi?id=68748).
336
337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
340
341 2011-09-28  David Levin  <levin@chromium.org>
342
343         watchlist: Add a way to load the watchlist from config.
344         https://bugs.webkit.org/show_bug.cgi?id=68991
345
346         Reviewed by Eric Seidel.
347
348         * Scripts/webkitpy/common/config/watchlist: Added.
349         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
350         Support for loading the watch list.
351         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
352         Tests for the loading.
353         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
354         Adjusted to use the common base class.
355         * Scripts/webkitpy/common/webkitunittest.py: Added.
356         Made a common base class for functionality used in more than one.
357
358 2011-09-28  David Levin  <levin@chromium.org>
359
360         Attempt fix for Leopard python unit test run.
361
362         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
363
364 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
365
366         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
367         https://bugs.webkit.org/show_bug.cgi?id=68938
368
369         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
370
371         Reviewed by David Hyatt.
372
373         * DumpRenderTree/chromium/WebViewHost.cpp:
374         (WebViewHost::didUpdateLayout): Added width/height queries.
375         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
376
377 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
378
379         Get rebaseline server running again
380         https://bugs.webkit.org/show_bug.cgi?id=69020
381
382         Reviewed by Adam Barth.
383
384         Make rebaseline server run again after r90337 (missing format_date_time
385         import, results_json wasn't outputting anything).
386
387         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
388         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
389
390 2011-09-28  David Grogan  <dgrogan@chromium.org>
391
392         Move dgrogan from contributor to committer
393         https://bugs.webkit.org/show_bug.cgi?id=69021
394
395         * Scripts/webkitpy/common/config/committers.py:
396
397 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
398
399         Add Mac Skia GPU bots to builders.py
400         https://bugs.webkit.org/show_bug.cgi?id=69016
401
402         Reviewed by Eric Seidel.
403
404         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
405         GPU tests.
406
407         * Scripts/webkitpy/layout_tests/port/builders.py:
408         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
409
410 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
411
412         Second try at fixing the GTK+ build.
413
414         * GNUmakefile.am:
415
416 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
417
418         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
419         https://bugs.webkit.org/show_bug.cgi?id=68680
420
421         Reviewed by Tony Chang.
422
423         * Scripts/run-chromium-webkit-unit-tests:
424         * Scripts/webkitdirs.pm:
425         (determineBaseProductDir):
426
427 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
428
429         [Gtk] Implement textInputController.doCommand
430         https://bugs.webkit.org/show_bug.cgi?id=66496
431
432         Reviewed by Martin Robinson.
433
434         * DumpRenderTree/gtk/TextInputController.cpp:
435         (doCommandCallback): Callback function for textInputController.doCommand
436
437 2011-09-28  David Levin  <levin@chromium.org>
438
439         watchlist: Suggest corrections for typos and improve error message consistency.
440         https://bugs.webkit.org/show_bug.cgi?id=68976
441
442         Reviewed by Adam Barth.
443
444         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
445         for typos and improve consistency of the error messages.
446         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
447         and improve the regex that were already present.
448
449 2011-09-28  David Levin  <levin@chromium.org>
450
451         watchlist: Add support for matching added or deleted lines.
452         https://bugs.webkit.org/show_bug.cgi?id=68972
453
454         Reviewed by Adam Barth.
455
456         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
457         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
458         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
459         to the pattern match to only have the diff lines instead of the DiffFile.
460         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
461         Add tests for the new patterns and combinations of the patterns.
462         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
463         Sort imports. Add changeline support.
464
465 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
466
467         [GTK] Add WebKitError to GTK+ WebKit2 API
468         https://bugs.webkit.org/show_bug.cgi?id=68508
469
470         Reviewed by Martin Robinson.
471
472         * GNUmakefile.am: Add path to webkitgtk derived sources to the
473         include path.
474
475 2011-09-28  Philippe Normand  <pnormand@igalia.com>
476
477         [GTK] missing WebKit2 support in run-gtk-tests
478         https://bugs.webkit.org/show_bug.cgi?id=68992
479
480         Rubber-stamped by Andreas Kling.
481
482         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
483         webkit2 directory.
484
485 2011-09-27  Philippe Normand  <pnormand@igalia.com>
486
487         [GTK] build-webkit --no-webkit2 still builds WebKit2
488         https://bugs.webkit.org/show_bug.cgi?id=68892
489
490         Reviewed by Martin Robinson.
491
492         Take the --no-webkit2 option in account when building WebKitGTK+.
493
494         * Scripts/build-webkit:
495         * Scripts/webkitdirs.pm:
496         (buildAutotoolsProject):
497         (buildGtkProject):
498
499 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
500
501         Make Chromium Win Release (Tests) a core builder
502         https://bugs.webkit.org/show_bug.cgi?id=68906
503
504         Reviewed by Adam Barth.
505
506         Add Chromium Win Release (Tests) to the list of core builders.
507
508         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
509         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
510
511 2011-09-27  Adam Barth  <abarth@webkit.org>
512
513         garden-o-matic should load faster and inform the user what is happening
514         https://bugs.webkit.org/show_bug.cgi?id=68954
515
516         Reviewed by Dimitri Glazkov.
517
518         This test disables the expected failures tab.  The web inspector showed
519         that loading the data for this tab was slowing down the loading time
520         for the whole app.  We need to find a way to load that data lazily.
521
522         This patch also improves the update message to better describe the
523         progress the app is making analyzing data from the buildbot.
524
525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
527         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
528
529 2011-09-27  Adam Barth  <abarth@webkit.org>
530
531         garden-o-matic should show the first result when examining results
532         https://bugs.webkit.org/show_bug.cgi?id=68960
533
534         Reviewed by Dimitri Glazkov.
535
536         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
537
538 2011-09-27  David Levin  <levin@chromium.org>
539
540         watchlist: Add support for cc and message rules.
541         https://bugs.webkit.org/show_bug.cgi?id=68950
542
543         Reviewed by Adam Barth.
544
545         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
546         the cc's and messages for a patch.
547         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
548         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
549         for the rules.
550         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
551         A generic encapsulation of either a message list or a cc list.
552         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
553
554 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
555
556         webkit-patch doesn't like UTF-8 characters in reviewers names
557         https://bugs.webkit.org/show_bug.cgi?id=63452
558
559         Reviewed by Eric Seidel.
560
561         * Scripts/webkit-patch:
562
563 2011-09-27  Adam Barth  <abarth@webkit.org>
564
565         garden-o-matic examine buttons shows both expected and unexpected failures
566         https://bugs.webkit.org/show_bug.cgi?id=68918
567
568         Reviewed by Dimitri Glazkov.
569
570         This was a copy/paste error when I refactored this classes to share
571         more code.
572
573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
574
575 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
576
577         Add Kaustubh Atrawalkar to the list of contributors.
578
579         * Scripts/webkitpy/common/config/committers.py:
580
581 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
582
583         [Chromium] Fixed layout mode tests break subsequent tests
584         https://bugs.webkit.org/show_bug.cgi?id=68923
585         
586         Reviewed by Adam Barth.        
587
588         Reset fixed layout mode between tests, so that tests that run after
589         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
590         regular 800x600 non-fixed layout.
591
592         * DumpRenderTree/chromium/TestShell.cpp:
593         (TestShell::resetTestController):
594
595 2011-09-27  David Levin  <levin@chromium.org>
596
597         watchlist: Add the filename pattern for definitions.
598         https://bugs.webkit.org/show_bug.cgi?id=68917
599
600         Reviewed by Adam Barth.
601
602         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
603         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
604         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
605         for definitions.
606         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
607         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
608
609 2011-09-27  Adam Barth  <abarth@webkit.org>
610
611         garden-o-matic results view should sort test and builder names
612         https://bugs.webkit.org/show_bug.cgi?id=68488
613
614         Reviewed by Andy Estes.
615
616         Previously, the test and builder names were displayed in an arbitrary
617         order that changed from time to time.  That confused one user study
618         participant.  This patch sorts the lists so that they occur in a
619         predictable order.
620
621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
622
623 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
624
625         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
626         http://trac.webkit.org/changeset/96108
627         http://trac.webkit.org/changeset/96111
628         http://trac.webkit.org/changeset/96113
629         http://trac.webkit.org/changeset/96116
630         https://bugs.webkit.org/show_bug.cgi?id=68913
631
632         Wait for working Qt5 (Requested by ossy on #webkit).
633
634         * DumpRenderTree/qt/DumpRenderTree.pro:
635         * DumpRenderTree/qt/ImageDiff.pro:
636         * MiniBrowser/qt/BrowserView.cpp:
637         (BrowserView::BrowserView):
638         * MiniBrowser/qt/BrowserView.h:
639         * MiniBrowser/qt/BrowserWindow.cpp:
640         (BrowserWindow::BrowserWindow):
641         (BrowserWindow::urlChanged):
642         (BrowserWindow::~BrowserWindow):
643         * MiniBrowser/qt/BrowserWindow.h:
644         * MiniBrowser/qt/MiniBrowser.pro:
645         * MiniBrowser/qt/MiniBrowserApplication.h:
646         * MiniBrowser/qt/main.cpp:
647         * QtTestBrowser/QtTestBrowser.pro:
648         * QtTestBrowser/launcherwindow.cpp:
649         * QtTestBrowser/launcherwindow.h:
650         * QtTestBrowser/locationedit.h:
651         * QtTestBrowser/main.cpp:
652         * QtTestBrowser/mainwindow.cpp:
653         * QtTestBrowser/mainwindow.h:
654         * QtTestBrowser/webinspector.h:
655         * QtTestBrowser/webpage.cpp:
656         * QtTestBrowser/webview.cpp:
657         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
658         * WebKitTestRunner/PlatformWebView.h:
659         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
660         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
661         (WTR::WebView::wkView):
662         (WTR::WebView::pageRef):
663         (WTR::WebView::~WebView):
664         (WTR::WebView::WebView):
665         (WTR::PlatformWebView::PlatformWebView):
666         (WTR::PlatformWebView::sendEvent):
667         (WTR::PlatformWebView::postEvent):
668         * WebKitTestRunner/qt/WebKitTestRunner.pro:
669
670 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
671
672         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
673         https://bugs.webkit.org/show_bug.cgi?id=65178
674
675         Reviewed by Martin Robinson.
676
677         * GNUmakefile.am:
678         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
679
680 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
681
682         [Qt][WK2] Buildfix after r96108.
683
684         Rubber-stamped by Andreas Kling.
685
686         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
687         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
688         * WebKitTestRunner/qt/WebKitTestRunner.pro:
689
690 2011-09-27  David Levin  <levin@chromium.org>
691
692         watchlist: Change watchlistparser.py to be class based.
693         https://bugs.webkit.org/show_bug.cgi?id=68869
694
695         Reviewed by Eric Seidel.
696
697         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
698         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
699
700 2011-09-27  David Levin  <levin@chromium.org>
701
702         watchlist: Break out the diff boilerplate to allow for re-use.
703         https://bugs.webkit.org/show_bug.cgi?id=68871
704
705         Reviewed by Eric Seidel.
706
707         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
708         Break out the diff into a new file.
709         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
710
711 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
712
713         Web Inspector: UI performance: introduce heap size tracking stats.
714         https://bugs.webkit.org/show_bug.cgi?id=68901
715
716         It is interesting how much the heap memory is used by Inspector in order of running the test.
717
718         Reviewed by Yury Semikhatsky.
719
720         * DumpRenderTree/chromium/TestShell.cpp:
721         (TestShell::showDevTools):
722         (TestShell::closeDevTools):
723
724 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
725
726         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
727
728         QWidget and friends now live in the QtWidgets library. We update
729         includes in implementation files and private headers to us the
730         non-module-prefixed path, and leave the lookup for the include
731         path. For public headers we have to ifdef the includes as the
732         user might now have the modules we need in his QT config.
733
734         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
735         have to update our code and use windowHandle() for setting the
736         parent relationships.
737
738         https://bugs.webkit.org/show_bug.cgi?id=68687
739
740         Reviewed by Andreas Kling.
741
742         * DumpRenderTree/qt/DumpRenderTree.pro:
743         * DumpRenderTree/qt/ImageDiff.pro:
744         * MiniBrowser/qt/BrowserView.cpp:
745         * MiniBrowser/qt/BrowserView.h:
746         * MiniBrowser/qt/BrowserWindow.cpp:
747         * MiniBrowser/qt/BrowserWindow.h:
748         * MiniBrowser/qt/MiniBrowser.pro:
749         * MiniBrowser/qt/MiniBrowserApplication.h:
750         * MiniBrowser/qt/main.cpp:
751         * QtTestBrowser/QtTestBrowser.pro:
752         * QtTestBrowser/launcherwindow.cpp:
753         * QtTestBrowser/launcherwindow.h:
754         * QtTestBrowser/locationedit.h:
755         * QtTestBrowser/main.cpp:
756         * QtTestBrowser/mainwindow.cpp:
757         * QtTestBrowser/mainwindow.h:
758         * QtTestBrowser/webinspector.h:
759         * QtTestBrowser/webpage.cpp:
760         * QtTestBrowser/webview.cpp:
761         * WebKitTestRunner/PlatformWebView.h:
762         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
763
764 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
765
766         [Qt][WK2] Add support for hover API in Qt WebKit2
767         https://bugs.webkit.org/show_bug.cgi?id=68369
768
769         Reviewed by Andreas Kling.
770
771         Change the statusbar to show the link URL when hovering links in
772         MiniBrowser using QDesktopWebView.
773
774         * MiniBrowser/qt/BrowserWindow.cpp:
775         (BrowserWindow::BrowserWindow):
776         (BrowserWindow::onLinkHovered):
777         * MiniBrowser/qt/BrowserWindow.h:
778
779 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
780
781         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
782         https://bugs.webkit.org/show_bug.cgi?id=68864
783
784         Reviewed by Adam Barth.
785
786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
789         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
790
791 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
792
793         [Qt][WK2] One more unreviewed buildfix after r96005.
794
795         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
796
797 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
798
799         [Qt][WK2] Unreviewed buildfix after r96005.
800
801         * WebKitTestRunner/qt/TestInvocationQt.cpp:
802         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
803
804 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
805
806         garden-o-matic should be pretty in Open Sans.
807         https://bugs.webkit.org/show_bug.cgi?id=68845
808
809         Reviewed by Adam Barth.
810
811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
812
813 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
814
815         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
816         https://bugs.webkit.org/show_bug.cgi?id=68841
817
818         Reviewed by Adam Barth.
819
820         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
821         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
822         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
823
824 2011-09-26  David Levin  <levin@chromium.org>
825
826         watchlist: Add parsing for definition section.
827         https://bugs.webkit.org/show_bug.cgi?id=68850
828
829         Reviewed by Adam Barth.
830
831         * Scripts/webkitpy/common/watchlist/watchlist.py:
832         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
833         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
834
835 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
836
837         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
838
839         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
840         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
841         * WebKitTestRunner/win/TestInvocationWin.cpp:
842         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
843
844 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
845
846         Repaint tests don't work in WebKit2
847         https://bugs.webkit.org/show_bug.cgi?id=68453
848
849         Reviewed by Sam Weinig.
850         
851         Convert DumpRenderTree to use use the repaint rects
852         exposed via WebKit API when generating the repaint test
853         overlay.
854         
855         Fix WebKitTestRunner to work with repaint tests, again
856         using the repaint rects exposed from WK2.
857         
858         In both cases, layoutTestController.display() now just
859         forces a display of the web view, and turns on repaint
860         rect tracking on the main FrameView.
861         
862         Later, when pixel results are requested, the alpha overlay
863         that shows the repaint rects is generated using the list
864         of rects supplied by WebCore.
865
866         * DumpRenderTree/mac/DumpRenderTree.mm:
867         (resetDefaultsToConsistentValues):
868         (resetWebViewToConsistentStateBeforeTesting):
869         (displayWebView):
870         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
871         (paintRepaintRectOverlay):
872         (createBitmapContextFromWebView):
873         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
874         (WTR::InjectedBundle::beginTesting):
875         (WTR::InjectedBundle::done):
876         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
877         (WTR::InjectedBundle::setRepaintRects):
878         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
879         (WTR::InjectedBundlePage::reset):
880         (WTR::InjectedBundlePage::dump):
881         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
882         (WTR::LayoutTestController::display):
883         * WebKitTestRunner/TestInvocation.cpp:
884         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
885         * WebKitTestRunner/TestInvocation.h:
886         * WebKitTestRunner/cg/TestInvocationCG.cpp:
887         (WTR::paintRepaintRectOverlay):
888         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
889
890 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
891
892         Get hover'ed element URL from HitTest.
893
894         mouseDidMoveOverElement now gets the hover'ed element link using
895         WKHitTestResult API's.
896         https://bugs.webkit.org/show_bug.cgi?id=68426 
897
898         Reviewed by Anders Carlsson.
899
900         * MiniBrowser/gtk/BrowserWindow.c:
901         (mouseDidMoveOverElement):
902
903 2011-09-26  David Levin  <levin@chromium.org>
904
905         Add skeleton parsing for a WatchList.
906         https://bugs.webkit.org/show_bug.cgi?id=68823
907
908         Reviewed by Adam Barth.
909
910         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
911         Parses the top level watch list sections -- none are defined yet -- and
912         throws an exception if an invalid one is listed.
913         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
914         Verify the exception for an invalid section in a watch list.
915         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
916
917 2011-09-26  Adam Roben  <aroben@apple.com>
918
919         Clean up code imported from WebKitAPITest
920
921         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
922         TestWebKitAPI conventions
923
924         Reviewed by David Levin.
925
926         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
927         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
928         namespace name.
929
930         (TestWebKitAPI::WebViewDestruction::SetUp):
931         (TestWebKitAPI::WebViewDestruction::webViewCount):
932         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
933         (TestWebKitAPI::WebViewDestruction::runMessagePump):
934         (TestWebKitAPI::WebViewDestruction::TearDown):
935         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
936         Moved functionality from free functions into these new test fixtures.
937
938         * TestWebKitAPI/win/HostWindow.cpp:
939         * TestWebKitAPI/win/HostWindow.h:
940         Prefixed Win32 API calls with ::. Updated namespace name.
941
942 2011-09-23  Adam Roben  <aroben@apple.com>
943
944         Merge WebKitAPITest into TestWebKitAPI
945
946         This also means that our formerly-WebKitAPITest tests will be run on the bots!
947
948         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
949         them more idiomatic in a separate pass.
950
951         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
952         functionality (and names!)
953
954         Reviewed by Anders Carlsson.
955
956         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
957         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
958         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
959
960         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
961
962         * TestWebKitAPI/win/main.cpp:
963         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
964
965         * WebKitAPITest: Removed this directory and its contents.
966
967 2011-09-23  Adam Roben  <aroben@apple.com>
968
969         Remove two failing WebKitAPITest tests
970
971         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
972
973         Reviewed by Anders Carlsson.
974
975         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
976         MainFrameAfterClose tests.
977
978 2011-09-25  Adam Barth  <abarth@webkit.org>
979
980         Finish removing PLATFORM(BREWMP) by removing associated code
981         https://bugs.webkit.org/show_bug.cgi?id=68779
982
983         Reviewed by Sam Weinig.
984
985         * Scripts/webkitpy/common/config/build.py:
986         * waf/build/settings.py:
987
988 2011-09-21  Ai Makabi  <makabi@google.com>
989
990         Provides a simple LRU cache class in Python.
991
992         https://bugs.webkit.org/show_bug.cgi?id=67823
993
994         Reviewed by Tony Chang.
995
996         * Scripts/webkitpy/common/lru_cache.py:
997         * Scripts/webkitpy/common/lru_cache_unittest.py:
998
999 2011-09-25  Adam Barth  <abarth@webkit.org>
1000
1001         Remove PLATFORM(HAIKU) and associated code
1002         https://bugs.webkit.org/show_bug.cgi?id=68774
1003
1004         Reviewed by Sam Weinig.
1005
1006         * Scripts/webkitpy/common/config/build.py:
1007         * waf/build/settings.py:
1008
1009 2011-09-24  Adam Barth  <abarth@webkit.org>
1010
1011         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1012         https://bugs.webkit.org/show_bug.cgi?id=68767
1013
1014         Reviewed by Eric Seidel.
1015
1016         * Scripts/build-webkit:
1017
1018 2011-09-24  Adam Barth  <abarth@webkit.org>
1019
1020         Remove ENABLE(WCSS) and associated code
1021         https://bugs.webkit.org/show_bug.cgi?id=68759
1022
1023         Reviewed by Darin Adler.
1024
1025         * Scripts/build-webkit:
1026         * Scripts/old-run-webkit-tests:
1027         * Scripts/webkitperl/features.pm:
1028         (hasFeature):
1029         * Scripts/webkitpy/layout_tests/port/webkit.py:
1030         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1031
1032 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
1033
1034         Fixed GTK compilation after r95878, the operator== was defined
1035         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
1036
1037         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1038
1039 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1040
1041         [DRT] Include the right config file for EFL's DRT.
1042         https://bugs.webkit.org/show_bug.cgi?id=67042
1043
1044         Reviewed by Martin Robinson.
1045
1046         Ports which use CMake as their buildsystem (such as the EFL one) also
1047         have config.h files, but they are named differently, so include the
1048         right one depending on the buildsystem being used.
1049
1050         * DumpRenderTree/config.h:
1051
1052 2011-09-23  Adam Klein  <adamk@chromium.org>
1053
1054         Add ENABLE_MUTATION_OBSERVERS feature flag
1055         https://bugs.webkit.org/show_bug.cgi?id=68732
1056
1057         Reviewed by Ojan Vafai.
1058
1059         This flag will guard an implementation of the "Mutation Observers" proposed in
1060         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
1061
1062         * Scripts/build-webkit:
1063
1064 2011-09-23  Chang Shu  <cshu@webkit.org>
1065
1066         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1067         https://bugs.webkit.org/show_bug.cgi?id=68556
1068
1069         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
1070
1071         Reviewed by Darin Adler.
1072
1073         * WebKitTestRunner/EventSenderProxy.h:
1074         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1075         * WebKitTestRunner/PlatformWebView.h:
1076         * WebKitTestRunner/mac/EventSenderProxy.mm:
1077         (WTR::EventSenderProxy::EventSenderProxy):
1078         (WTR::EventSenderProxy::leapForward):
1079         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1080         (WTR::EventSenderProxy::EventSenderProxy):
1081         (WTR::getMouseButton):
1082         (WTR::getModifiers):
1083         (WTR::EventSenderProxy::updateClickCountForButton):
1084         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
1085         (WTR::EventSenderProxy::mouseDown):
1086         (WTR::EventSenderProxy::mouseUp):
1087         (WTR::EventSenderProxy::mouseMoveTo):
1088         (WTR::EventSenderProxy::leapForward):
1089         (WTR::EventSenderProxy::sendOrQueueEvent):
1090         (WTR::EventSenderProxy::replaySavedEvents):
1091         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1092         (WTR::PlatformWebView::postEvent):
1093         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1094
1095 2011-09-23  Lei Zhang  <thestig@chromium.org>
1096
1097         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
1098         https://bugs.webkit.org/show_bug.cgi?id=68026
1099
1100         Reviewed by Dirk Pranke.
1101
1102         * Scripts/webkitpy/layout_tests/port/chromium.py:
1103
1104 2011-09-23  Elliot Poger  <epoger@google.com>
1105
1106         update layout_tests to account for new default of use_skia=1
1107         https://bugs.webkit.org/show_bug.cgi?id=68698
1108
1109         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
1110         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
1111         (Chromium-on-Mac now uses the Skia graphics library instead of
1112         Core Graphics).
1113
1114         Also updates layout_test code to work with that change.
1115
1116         Reviewed by Mihai Parparita.
1117
1118         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1119         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1120
1121 2011-09-23  Mark Rowe  <mrowe@apple.com>
1122
1123         Fix the build.
1124         
1125         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
1126         the WTF namespace.
1127
1128 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
1129
1130         enable NRWT for run-webkit-tests on Lion
1131         https://bugs.webkit.org/show_bug.cgi?id=68673
1132
1133         Reviewed by Eric Seidel.
1134
1135         * Scripts/run-webkit-tests:
1136         (useNewRunWebKitTests):
1137
1138 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1139
1140         Add unit test for existing StringBuilder
1141         https://bugs.webkit.org/show_bug.cgi?id=67080
1142
1143         Reviewed by Darin Adler.
1144
1145         * TestWebKitAPI/TestWebKitAPI.gypi:
1146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1147         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
1148         (operator<<):
1149         (TestWebKitAPI::expectBuilderContent):
1150         (TestWebKitAPI::expectEmpty):
1151         (TestWebKitAPI::TEST):
1152
1153 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
1154
1155         [EFL] Use ewk_view to navigate in history instead of ewk_history.
1156         https://bugs.webkit.org/show_bug.cgi?id=68455
1157
1158         Reviewed by Antonio Gomes.
1159
1160         BackForwardItem::invoke() was using ewk_history functions to navigate
1161         in history; however, this will only call WebCore::BackForwardListImpl
1162         and not move between pages at all. We now call ewk_view_navigate and
1163         its siblings to make sure the navigation actually happens.
1164
1165         This should make tests like fast/dom/navigation-type-back-forward.html
1166         stop timing out.
1167
1168         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1169         (BackForwardItem::invoke):
1170
1171 2011-09-22  Dean Jackson  <dino@apple.com>
1172
1173         Add ENABLE_CSS_FILTERS
1174         https://bugs.webkit.org/show_bug.cgi?id=68652
1175
1176         Reviewed by Simon Fraser.
1177
1178         * Scripts/build-webkit:
1179
1180 2011-09-22  Anders Carlsson  <andersca@apple.com>
1181
1182         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
1183         https://bugs.webkit.org/show_bug.cgi?id=68660
1184
1185         Reviewed by Adam Barth.
1186
1187         * WebKitTestRunner/mac/EventSenderProxy.mm:
1188         (WTR::EventSenderProxy::mouseUp):
1189
1190 2011-09-22  Adam Roben  <aroben@apple.com>
1191
1192         Remove FindSafari
1193
1194         It isn't used or built anymore.
1195
1196         Fixes <http://webkit.org/b/68628>
1197
1198         Reviewed by Darin Adler.
1199
1200         * FindSafari: Removed this directory and its contents.
1201
1202 2011-09-22  Adam Roben  <aroben@apple.com>
1203
1204         Remove FindSafari from all our .sln files
1205
1206         It isn't used anymore, so there's no point in building it.
1207
1208         Part of <http://webkit.org/b/68628> Remove FindSafari
1209
1210         Reviewed by Steve Falkenburg.
1211
1212         * DumpRenderTree/DumpRenderTree.sln:
1213         * WebKitTestRunner/WebKitTestRunner.sln:
1214
1215 2011-09-22  Adam Roben  <aroben@apple.com>
1216
1217         Remove all uses of FindSafari
1218
1219         It isn't really needed anymore.
1220
1221         Fixes <http://webkit.org/b/68626>.
1222
1223         Reviewed by Darin Adler.
1224
1225         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
1226
1227         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
1228         WebKit, but now we use WebKit.exe for that.
1229
1230         * Scripts/webkitdirs.pm:
1231         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
1232         do the same thing.
1233
1234         (readRegistryString):
1235         (writeRegistryString):
1236         Moved here from old-run-webkit-tests.
1237
1238 2011-09-22  Adam Roben  <aroben@apple.com>
1239
1240         Use the "direct object" form of system() to run WebKit.exe
1241
1242         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
1243         path to WebKit.exe.
1244
1245         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
1246         %WEBKITOUTPUTDIR%
1247
1248         Reviewed by Steve Falkenburg.
1249
1250         * Scripts/webkitdirs.pm:
1251         (runSafari):
1252
1253 2011-09-22  Adam Roben  <aroben@apple.com>
1254
1255         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
1256
1257         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
1258         spaces in the path to the WebKit source tree
1259
1260         Reviewed by John Sullivan.
1261
1262         * Scripts/webkitdirs.pm:
1263         (setupCygwinEnv):
1264
1265 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1266
1267         [Qt] Use same DPI for application font as rest of app in DRT and WTR
1268
1269         QApplication will initialize the default application font based
1270         on the application DPI at construction time, but we then override
1271         the application DPI using QX11Info (hard-coding it to 96 for
1272         consistency). This hard-coding is not reflected in the application
1273         font, so we explicitly have update the font ourselves.
1274
1275         The 6 test results that are updated were originally produced with
1276         a DPI of 75, as this is the default fallback DPI when a QFont is
1277         constructed before QApplication. This was wrong, and the results
1278         are updated to match a DPI of 96.
1279
1280         Reviewed by Csaba Osztrogonác.
1281
1282         * DumpRenderTree/qt/main.cpp:
1283         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1284
1285 2011-09-21  Anna Cavender  <annacc@chromium.org>
1286
1287         Update committers.py with a new contributor contact        
1288         https://bugs.webkit.org/show_bug.cgi?id=68565
1289
1290         Reviewed by Eric Carlson.
1291
1292         * Scripts/webkitpy/common/config/committers.py:
1293
1294 2011-09-21  Chang Shu  <cshu@webkit.org>
1295
1296         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1297         https://bugs.webkit.org/show_bug.cgi?id=68108
1298
1299         This patch implements the event sender mouse events through WebKit2 UIProcess which is
1300         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
1301         platform as the first step so the existing code is still kept for other platforms.
1302
1303         Reviewed by Darin Adler.
1304
1305         * WebKitTestRunner/EventSenderProxy.h:
1306         (WTR::EventSenderProxy::EventSenderProxy):
1307         (WTR::EventSenderProxy::leapForward):
1308         (WTR::EventSenderProxy::currentEventTime):
1309         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1310         (WTR::EventSendingController::EventSendingController):
1311         (WTR::EventSendingController::mouseDown):
1312         (WTR::EventSendingController::mouseUp):
1313         (WTR::EventSendingController::mouseMoveTo):
1314         (WTR::EventSendingController::leapForward):
1315         (WTR::EventSendingController::keyDown):
1316         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1317         * WebKitTestRunner/TestController.cpp:
1318         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1319         * WebKitTestRunner/mac/EventSenderProxy.mm:
1320         (WTR::eventTypeForMouseButtonAndAction):
1321         (WTR::operator==):
1322         (WTR::EventSenderProxy::updateClickCountForButton):
1323         (WTR::EventSenderProxy::mouseDown):
1324         (WTR::EventSenderProxy::mouseUp):
1325         (WTR::EventSenderProxy::mouseMoveTo):
1326         (WTR::EventSenderProxy::keyDown):
1327         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1328         (WTR::EventSenderProxy::keyDown):
1329         (WTR::EventSenderProxy::mouseDown):
1330         (WTR::EventSenderProxy::mouseUp):
1331         (WTR::EventSenderProxy::mouseMoveTo):
1332
1333 2011-09-21  Dan Bernstein  <mitz@apple.com>
1334
1335         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
1336         https://bugs.webkit.org/show_bug.cgi?id=68451
1337
1338         Reviewed by Darin Adler.
1339
1340         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
1341         Objective-C classes with names not having one of a list of prefixes
1342         passed on the command line.
1343
1344 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
1345
1346         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
1347         https://bugs.webkit.org/show_bug.cgi?id=68206
1348
1349         Reviewed by Tony Chang.
1350
1351         * Scripts/webkitdirs.pm:
1352         (determineBaseProductDir): add support for chromium-mac
1353         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1354         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1355
1356 2011-09-21  Adam Barth  <abarth@webkit.org>
1357
1358         garden-o-matic command should explain that it is starting a local server
1359         https://bugs.webkit.org/show_bug.cgi?id=68486
1360
1361         Reviewed by Dimitri Glazkov.
1362
1363         In the user study, both participants didn't understand why the
1364         garden-o-matic command appeared to hang.  This patch adds an
1365         explaination of what's going on.  It also adds a confirmation prompt
1366         before launching the browser to give the user a chance to read the
1367         text.  If that's too much of a speed bump, we can iterate.
1368
1369         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1370
1371 2011-09-21  Chang Shu  <cshu@webkit.org>
1372
1373         [Qt] Implement KeyDown function for WebKit2 EventSender.
1374         https://bugs.webkit.org/show_bug.cgi?id=56485
1375
1376         Implement the KeyDown function on Qt platform.
1377
1378         Reviewed by Andreas Kling.
1379
1380         * WebKitTestRunner/PlatformWebView.h:
1381         * WebKitTestRunner/TestController.cpp:
1382         (WTR::TestController::TestController):
1383         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1384         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
1385         (WTR::getModifiers):
1386         (WTR::EventSenderProxy::keyDown):
1387         (buildModifierFlags):
1388         (EventSenderProxy::keyDown):
1389         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1390         (WTR::PlatformWebView::sendEvent):
1391         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1392
1393 2011-09-20  Adam Barth  <abarth@webkit.org>
1394
1395         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
1396         https://bugs.webkit.org/show_bug.cgi?id=68496
1397
1398         Reviewed by Dimitri Glazkov.
1399
1400         This patch adds a bunch of sorting to make sure things happen in a
1401         predictable order in both JavaScriptCore and V8.  We've talked before
1402         about whether these two JavaScript engines should enumerate
1403         dictionaries in the same order, but the consensus has been that they
1404         shouldn't.  Personally, I disagree with that consensus, but such is life.
1405
1406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1410
1411 2011-09-20  Adam Barth  <abarth@webkit.org>
1412
1413         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
1414         https://bugs.webkit.org/show_bug.cgi?id=68495
1415
1416         Reviewed by Dimitri Glazkov.
1417
1418         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
1419
1420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1421
1422 2011-09-20  Eric Seidel  <eric@webkit.org>
1423
1424         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1425         https://bugs.webkit.org/show_bug.cgi?id=65781
1426
1427         Reviewed by Ryosuke Niwa.
1428
1429         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
1430         to resolve the passed in url relative to the absolute url for the test.
1431         For http tests, since the test url is an http url, we can't resolve relative
1432         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
1433         for resolving.
1434
1435         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1436         (which resolves the path relative to the built location of the DRT executable)
1437         and we should move this new code into a shared location in a follow-up patch.
1438
1439         It turns out that there was a second use for pathToLocalResource, used by one
1440         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
1441         To support this test I made the new pathToLocalResource smart enough to map
1442         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
1443
1444         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1445         (LayoutTestController::pathToLocalResource):
1446         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
1447
1448 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1449
1450         Need to specify a django version, instead of using default
1451         https://bugs.webkit.org/show_bug.cgi?id=68398
1452
1453         Reviewed by Eric Seidel.
1454
1455         * QueueStatusServer/__init__.py:
1456         * QueueStatusServer/main.py:
1457
1458 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1459
1460         Update committers.py with a few more contributor contacts
1461         https://bugs.webkit.org/show_bug.cgi?id=68487
1462
1463         Reviewed by Eric Seidel.
1464
1465         * Scripts/webkitpy/common/config/committers.py:
1466
1467 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1468
1469         Fix webkitpy unit tests after 95547 and 95549
1470         https://bugs.webkit.org/show_bug.cgi?id=68483
1471
1472         Reviewed by Adam Barth.
1473         
1474         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
1475
1476         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
1477         parse_entries_from_file(), use StringIO and entry.reviewer_text().
1478         While testing parse_latest_entry_from_file(), expect the correct
1479         touched_files() list.
1480
1481 2011-09-20  Adam Barth  <abarth@webkit.org>
1482
1483         garden-o-matic makes it hard to compare images when scroll bars appear
1484         https://bugs.webkit.org/show_bug.cgi?id=68482
1485
1486         Reviewed by Eric Seidel.
1487
1488         Because we autoscale image width, the images rescale if we overflow
1489         vertically and get a scrollbar.  That makes it hard to compare two sets
1490         of images.  This patch reserves space for the scrollbar so we won't
1491         have the layout change.
1492
1493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1494
1495 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1496
1497         Unreviewed, rolling out r95565.
1498         http://trac.webkit.org/changeset/95565
1499         https://bugs.webkit.org/show_bug.cgi?id=68470
1500
1501         Broke builds (Requested by andersca on #webkit).
1502
1503         * MiniBrowser/gtk/BrowserWindow.c:
1504         (mouseDidMoveOverElement):
1505
1506 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
1507
1508         Get hover'ed element URL from HitTest.
1509         
1510         mouseDidMoveOverElement now gets the hover'ed element link using
1511         WKHitTestResult API's.
1512         https://bugs.webkit.org/show_bug.cgi?id=68426
1513
1514         Reviewed by Anders Carlsson.
1515
1516         * MiniBrowser/gtk/BrowserWindow.c:
1517         (mouseDidMoveOverElement):
1518
1519 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1520
1521         Changelog class should have a method to return all entries
1522         https://bugs.webkit.org/show_bug.cgi?id=68399
1523         
1524         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
1525         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
1526
1527         Reviewed by Ryosuke Niwa.
1528
1529         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
1530         and adapt it to become a generator.
1531         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
1532
1533 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
1534
1535         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
1536         https://bugs.webkit.org/show_bug.cgi?id=51159
1537
1538         Permit any URL with a local scheme to set a user style sheet. Allow qrc
1539         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
1540         
1541         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
1542
1543         Reviewed by Kenneth Rohde Christiansen.
1544
1545         * DumpRenderTree/qt/DumpRenderTree.pro:
1546         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
1547         * DumpRenderTree/qt/resources/user.css: Added.
1548         (body):
1549         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1550         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
1551         * WebKitTestRunner/qt/resources/user.css: Added.
1552         (body):
1553
1554 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
1555
1556         ChangeLogEntry class should contain a list of touched files
1557         https://bugs.webkit.org/show_bug.cgi?id=68115
1558
1559         Reviewed by Eric Seidel.
1560         
1561         Add method to return the list of files touched in a ChangeLog entry.
1562
1563         * Scripts/webkitpy/common/checkout/changelog.py: Add
1564         touched_files_regexp and touched_files() method.
1565         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
1566         unit tests for touched_files() method.
1567
1568 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1569
1570         Unreviewed, rolling out r95526 and r95541.
1571         http://trac.webkit.org/changeset/95526
1572         http://trac.webkit.org/changeset/95541
1573         https://bugs.webkit.org/show_bug.cgi?id=68443
1574
1575         It broke 6 tests (Requested by ossy_ on #webkit).
1576
1577         * DumpRenderTree/qt/main.cpp:
1578         (main):
1579         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1580         (WTR::activateFonts):
1581
1582 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
1583
1584         Fix patch and bug numbering in the mocktool simulation code
1585         https://bugs.webkit.org/show_bug.cgi?id=68374
1586
1587         Reviewed by Adam Barth.
1588
1589         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1590         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1591         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1592         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1593         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1594         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1595         * Scripts/webkitpy/tool/commands/download_unittest.py:
1596         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1597         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1598         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1599         * Scripts/webkitpy/tool/commands/queuestest.py:
1600         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1601         * Scripts/webkitpy/tool/mocktool.py:
1602         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1603         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1604
1605 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1606
1607         [Qt] Don't override default QApplication font for DRT and WTR
1608
1609         Revision 95526 moved the relevant code below the QApplication
1610         constructor, to fix a potential crash, and that made the code
1611         take effect, breaking 6 tests.
1612
1613         We should rely on the QWebSettings to set default fonts, and
1614         this QApplication::setFont() is a relic from when we didn't
1615         have that option, so we remove the code.
1616
1617         Reviewed by Csaba Osztrogonác.
1618
1619         * DumpRenderTree/qt/main.cpp:
1620         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1621
1622 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1623
1624         WebKitTestRunner: Provide usage if run without arguments
1625
1626         If WTR is run without either one or more filenames, or
1627         a '-' to indicate server mode, we don't need to start
1628         up the test machinery. Doing so might actually crash,
1629         as we'll exit the application immedeatly after anyways.
1630
1631         Reviewed by Simon Hausmann.
1632
1633         * WebKitTestRunner/TestController.cpp:
1634         (WTR::TestController::initialize):
1635
1636 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1637
1638         [Qt] Don't use QFont before initializing QApplication
1639
1640         Could potentially result in crash.
1641
1642         Reviewed by Simon Hausmann.
1643
1644         * DumpRenderTree/qt/main.cpp:
1645         (main):
1646
1647 2011-09-19  Adam Barth  <abarth@webkit.org>
1648
1649         Always enable ENABLE(EVENTSOURCE)
1650         https://bugs.webkit.org/show_bug.cgi?id=68414
1651
1652         Reviewed by Eric Seidel.
1653
1654         * Scripts/build-webkit:
1655
1656 2011-09-19  David Levin  <levin@chromium.org>
1657
1658         Sheriffbot rollout should be more intuitive.
1659         https://bugs.webkit.org/show_bug.cgi?id=68415
1660
1661         Reviewed by Adam Barth.
1662
1663         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
1664         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
1665           and a few others cases.
1666         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
1667
1668 2011-09-19  David Levin  <levin@chromium.org>
1669
1670         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
1671         https://bugs.webkit.org/show_bug.cgi?id=68391
1672
1673         Reviewed by Darin Adler.
1674
1675         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
1676         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
1677
1678 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
1679
1680         Style checker should not check public Qt WK2 API for parameter_name.
1681         https://bugs.webkit.org/show_bug.cgi?id=68359
1682
1683         Reviewed by Andreas Kling.
1684
1685         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
1686         Add an exception in the style checker to disable the check. Also added the test for it.
1687
1688         * Scripts/webkitpy/style/checker.py:
1689         * Scripts/webkitpy/style/checker_unittest.py:
1690
1691 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
1692
1693         GTK DRT leaks memory while comparing history items
1694         https://bugs.webkit.org/show_bug.cgi?id=68086
1695
1696         Reviewed by Martin Robinson.
1697         
1698         webkit_web_history_item_get_target() returns a g_strdup()'d string,
1699         so memory must be freed before compareHistoryItems() returns.
1700
1701         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1702         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
1703
1704 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1705
1706         Buildbot marks a nrwt bot red when tests are missing results
1707         https://bugs.webkit.org/show_bug.cgi?id=64812
1708
1709         Reviewed by Ryosuke Niwa.
1710
1711         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1712         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1713
1714 2011-09-19  Jessie Berlin  <jberlin@apple.com>
1715
1716         Sites that use history pushState or replaceState are recorded in history in Private Browsing
1717         mode.
1718         https://bugs.webkit.org/show_bug.cgi?id=68208
1719
1720         Reviewed by Brady Eidson.
1721
1722         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
1723         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
1724
1725         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
1726         (TestWebKitAPI::didNavigateWithNavigationData):
1727         This is a context history client callback, so it should not be called when in Private
1728         Browsing. Add a call to FAIL().
1729         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1730         This is a page load client callback that happens after the didNavigateWithNavigationData
1731         callback. End the test.
1732         (TestWebKitAPI::TEST):
1733         Enable Private Browsing and load a page that uses history.pushState.
1734
1735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1736         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
1737         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
1738         Ditto.
1739         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1740         Ditto.
1741         * TestWebKitAPI/win/copy-resources.cmd:
1742         Ditto.
1743
1744 2011-09-16  Elliot Poger  <epoger@google.com>
1745
1746         add non-CG Webkit-Mac builds to flakiness dashboard
1747         https://bugs.webkit.org/show_bug.cgi?id=68265
1748
1749         Reviewed by Adam Barth.
1750
1751         As Chromium-on-Mac approaches the switchover from Core Graphics to
1752         Skia, we need to add the Skia version to the flakiness dashboard.
1753
1754         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1755         * TestResultServer/static-dashboards/builders.js:
1756         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1757
1758 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
1759
1760         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
1761         https://bugs.webkit.org/show_bug.cgi?id=68071
1762
1763         Reviewed by Adam Barth.
1764
1765         * DumpRenderTree/chromium/WebPermissions.cpp:
1766         (WebPermissions::allowImage):
1767         * DumpRenderTree/chromium/WebPermissions.h:
1768
1769 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
1770
1771         update-webkit-chromium should retry the gclient call if it fails once
1772         https://bugs.webkit.org/show_bug.cgi?id=68252
1773
1774         Reviewed by Adam Barth.
1775
1776         * Scripts/update-webkit-chromium:
1777
1778 2011-09-16  Rob Buis  <rbuis@rim.com>
1779
1780         Add Eli's rim address and change the nick.
1781
1782         * Scripts/webkitpy/common/config/committers.py:
1783
1784 2011-09-16  Anders Carlsson  <andersca@apple.com>
1785
1786         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
1787         https://bugs.webkit.org/show_bug.cgi?id=68269
1788
1789         Reviewed by Geoffrey Garen.
1790
1791         Update client function signatures.
1792
1793         * MiniBrowser/gtk/BrowserWindow.c:
1794         (browserWindowUIClientInit):
1795         * MiniBrowser/mac/BrowserWindowController.m:
1796         (mouseDidMoveOverElement):
1797         (-[BrowserWindowController awakeFromNib]):
1798         * MiniBrowser/win/BrowserView.cpp:
1799         (BrowserView::create):
1800         * WebKitTestRunner/TestController.cpp:
1801         (WTR::TestController::createOtherPage):
1802         (WTR::TestController::initialize):
1803
1804 2011-09-16  Anders Carlsson  <andersca@apple.com>
1805
1806         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
1807         https://bugs.webkit.org/show_bug.cgi?id=68266
1808
1809         Reviewed by John Sullivan.
1810
1811         * MiniBrowser/mac/BrowserWindowController.m:
1812         (mouseDidMoveOverElement):
1813
1814 2011-09-16  Vincent Scheib  <scheib@chromium.org>
1815
1816         Add Vincent Scheib to the committers list.
1817
1818         * Scripts/webkitpy/common/config/committers.py:
1819
1820 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1821
1822         Unreviewed, rolling out r95285.
1823         http://trac.webkit.org/changeset/95285
1824         https://bugs.webkit.org/show_bug.cgi?id=68247
1825
1826         It broke a webkitpy test (Requested by ossy on #webkit).
1827
1828         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1829
1830 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1831
1832         Buildbot marks a nrwt bot red when tests are missing results
1833         https://bugs.webkit.org/show_bug.cgi?id=64812
1834
1835         Reviewed by Dirk Pranke.
1836
1837         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1838
1839 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
1840
1841         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
1842         https://bugs.webkit.org/show_bug.cgi?id=68178
1843
1844         Reviewed by Xan Lopez.
1845
1846         Add a work-around to enable WebKit2 when using build-webkit.
1847
1848         * Scripts/webkitdirs.pm:
1849         (buildAutotoolsProject): 
1850
1851 2011-09-15  James Robinson  <jamesr@chromium.org>
1852
1853         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
1854
1855         * Scripts/webkitpy/common/config/committers.py:
1856
1857 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1858
1859         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
1860         https://bugs.webkit.org/show_bug.cgi?id=68003
1861
1862         Reviewed by Adam Barth.
1863
1864         * Scripts/webkitpy/tool/mocktool.py:
1865         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1866         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1867
1868 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1869
1870         Python version check is confusing in test-webkitpy
1871         https://bugs.webkit.org/show_bug.cgi?id=68004
1872
1873         Reviewed by Adam Barth.
1874
1875         * Scripts/test-webkitpy:
1876
1877 2011-09-15  Eric Seidel  <eric@webkit.org>
1878
1879         Reviewed by Adam Barth.
1880
1881         webkit-patch should be able to find users and add them to bugzilla groups
1882         https://bugs.webkit.org/show_bug.cgi?id=63351
1883
1884         These are both very basic commands.  But it's now possible to find
1885         all users matching a regexp, as well as add all users matching a regexp
1886         to a set of groups.
1887
1888         bugzilla.py already knew how to find users (for validate-committer-lists)
1889         but now it has the ability to modify the user records.
1890
1891         I split some of the logic out into a new EditUsersParser class
1892         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
1893
1894         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1895         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1896         * Scripts/webkitpy/tool/commands/__init__.py:
1897         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
1898         * Scripts/webkitpy/tool/commands/findusers.py: Added.
1899
1900 2011-09-15  Eric Seidel  <eric@webkit.org>
1901
1902         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
1903         https://bugs.webkit.org/show_bug.cgi?id=68182
1904
1905         Reviewed by Adam Barth.
1906
1907         * Scripts/build-webkit:
1908         * waf/build/settings.py:
1909
1910 2011-09-15  Eric Seidel  <eric@webkit.org>
1911
1912         Unreviewed.  Make contributor email look-up case-insensitive.
1913
1914         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
1915         was missing from committers.py due to case sensitivity.
1916
1917         This also includes a test expectations update to committers_unittest.py
1918         after my previous change.
1919
1920         * Scripts/webkitpy/common/config/committers.py:
1921         * Scripts/webkitpy/common/config/committers_unittest.py:
1922         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1923
1924 2011-09-15  Eric Seidel  <eric@webkit.org>
1925
1926         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
1927
1928         Add a bunch of email aliases to committers.py for regular contributors
1929         who are committing using other email addresses than they have listed in the file.
1930
1931         * Scripts/webkitpy/common/config/committers.py:
1932
1933 2011-09-15  Eric Seidel  <eric@webkit.org>
1934
1935         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
1936         https://bugs.webkit.org/show_bug.cgi?id=68022
1937
1938         Reviewed by Ryosuke Niwa.
1939
1940         * Scripts/build-webkit:
1941         * waf/build/settings.py:
1942
1943 2011-09-15  Anders Carlsson  <andersca@apple.com>
1944
1945         Fix Mac build by including config.h where needed.
1946
1947         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1948         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1949         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1950         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1951         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1952         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1953         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1954         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1955         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1956         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1957         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1958         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1959         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1960         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
1961         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1962         * TestWebKitAPI/mac/main.mm:
1963
1964 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1965
1966         Let TestWebKitAPI work for chromium
1967         https://bugs.webkit.org/show_bug.cgi?id=67756
1968
1969         Reviewed by Sam Weinig.
1970
1971         * Scripts/build-api-tests:
1972         * Scripts/run-api-tests:
1973         (isSupportedPlatform):
1974         (runTest):
1975         (populateTests):
1976         * Scripts/webkitdirs.pm:
1977         (determineBaseProductDir):
1978         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1979         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1980         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1981         * TestWebKitAPI/InjectedBundleController.cpp:
1982         * TestWebKitAPI/InjectedBundleMain.cpp:
1983         * TestWebKitAPI/JavaScriptTest.cpp:
1984         * TestWebKitAPI/PlatformUtilities.cpp:
1985         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
1986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1987         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
1988         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1989         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1990         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1991         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
1992         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1993         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1994         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1995         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1996         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1997         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1998         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1999         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2000         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2001         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2002         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2003         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2004         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2005         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2006         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2007         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2008         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2009         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2010         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2011         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2012         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2013         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2014         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2015         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2016         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2017         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2018         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2019         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2020         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2021         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2022         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2023         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2024         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2025         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2026         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2027         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2028         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2029         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2030         * TestWebKitAPI/TestsController.cpp:
2031         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
2032         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
2033         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2034         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2035         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2036         * TestWebKitAPI/win/main.cpp:
2037
2038 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
2039
2040         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
2041         https://bugs.webkit.org/show_bug.cgi?id=68145
2042
2043         This will allow for other classes in DumpRenderTree to reuse this functionality
2044
2045         Reviewed by David Levin.
2046
2047         * DumpRenderTree/chromium/TestShell.cpp:
2048         (normalizeLayoutTestURLInternal):
2049         (dumpHistoryItem):
2050         (TestShell::normalizeLayoutTestURL):
2051         * DumpRenderTree/chromium/TestShell.h:
2052
2053 2011-09-14  Ada Chan  <adachan@apple.com>
2054
2055         Add test for WKBundleFrameCopyWebArchive().
2056         https://bugs.webkit.org/show_bug.cgi?id=67857
2057
2058         Reviewed by Anders Carlsson.
2059
2060         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
2061         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
2062         the returned data is a valid webarchive.
2063         (TestWebKitAPI::setInjectedBundleClient):
2064         (TestWebKitAPI::didFinishLoadForFrame):
2065         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
2066         injected bundle for the webarchive and check the returned webarchive.
2067         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
2068         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
2069         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
2070         the web archive.
2071
2072         Add files to project.
2073         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
2074         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2076
2077 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2078
2079         committers.py should support multiple IRC nicknames
2080         https://bugs.webkit.org/show_bug.cgi?id=68110
2081
2082         Reviewed by Eric Seidel.
2083
2084         Add multiple IRC nickname support to committers.py
2085
2086         * Scripts/webkitpy/common/config/committers.py:
2087         * Scripts/webkitpy/common/config/committers_unittest.py:
2088         * Scripts/webkitpy/tool/bot/irc_command.py:
2089         * Scripts/webkitpy/tool/bot/sheriff.py:
2090
2091 2011-09-14  Jon Lee  <jonlee@apple.com>
2092
2093         Implement globalFlag for WebKitTestRunner
2094         https://bugs.webkit.org/show_bug.cgi?id=68033
2095         <rdar://problem/10119204>
2096
2097         Reviewed by Sam Weinig.
2098
2099         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
2100         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2101         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
2102         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
2103         (WTR::LayoutTestController::globalFlag): simple getter
2104         (WTR::LayoutTestController::setGlobalFlag): simple setter
2105
2106 2011-09-13  Eric Seidel  <eric@webkit.org>
2107
2108         Remove ENABLE_SVG_USE as <use> is required by HTML5
2109         https://bugs.webkit.org/show_bug.cgi?id=68019
2110
2111         Reviewed by Ryosuke Niwa.
2112
2113         * Scripts/build-webkit:
2114         * waf/build/settings.py:
2115
2116 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2117
2118         Remove Jan Erik Hanssen (added in my r95078) from the list for now
2119         since I can't confirm acceptable his committership.
2120
2121         * Scripts/webkitpy/common/config/committers.py:
2122
2123 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
2124
2125         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
2126         https://bugs.webkit.org/show_bug.cgi?id=68066
2127
2128         Reviewed by Adam Barth.
2129
2130         * DumpRenderTree/chromium/WebViewHost.cpp:
2131         * DumpRenderTree/chromium/WebViewHost.h:
2132
2133 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2134
2135         committers.py is missing some contributors
2136         https://bugs.webkit.org/show_bug.cgi?id=68059
2137
2138         Reviewed by Adam Barth.
2139
2140         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
2141
2142         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
2143
2144         * Scripts/webkitpy/common/config/committers.py:
2145
2146 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2147
2148         Fix webkit python test after r95061.
2149
2150         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2151
2152 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
2153
2154         Add myself as a contributor. No review needed.
2155
2156         * Scripts/webkitpy/common/config/committers.py:
2157
2158 2011-09-13  Adam Barth  <abarth@webkit.org>
2159
2160         garden-o-matic has unfriendly error messages when the local server is not available
2161         https://bugs.webkit.org/show_bug.cgi?id=68042
2162
2163         Reviewed by Dimitri Glazkov.
2164
2165         This patch moves us from using alert to showing the error inline in the
2166         progress dialog.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2173
2174 2011-09-13  Adam Barth  <abarth@webkit.org>
2175
2176         FailureGrid in garden-o-matic should link to the builder's waterfall page
2177         https://bugs.webkit.org/show_bug.cgi?id=68036
2178
2179         Reviewed by Dimitri Glazkov.
2180
2181         One of the users in the user study thought the configurations names in
2182         the failure grid would link to the underlying bots.  That makes sense,
2183         so this patch adds the behavior.
2184
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2189
2190 2011-09-13  Adam Barth  <abarth@webkit.org>
2191
2192         garden-o-matic should be able to mark failures as expected
2193         https://bugs.webkit.org/show_bug.cgi?id=68027
2194
2195         Reviewed by Dimitri Glazkov.
2196
2197         All the back-end infrastructure exists for this operation.  This patch
2198         just adds some UI to the front-end and wires that UI up to the back
2199         end.  This exact UI will likely need some more polish, but this should
2200         be a reasonable first cut.
2201
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2207
2208 2011-09-13  Adam Barth  <abarth@webkit.org>
2209
2210         garden-o-matic should tell you about the progress of your rebaseline
2211         https://bugs.webkit.org/show_bug.cgi?id=67967
2212
2213         Reviewed by Dimitri Glazkov.
2214
2215         This patch adds ui.MessageBox, which is a light wrapper around jQuery
2216         UI's dialog widget.  We then use ui.MessageBox to show status messages
2217         about in-progress rebaselines.  As each baseline is downloaded, the
2218         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
2219
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2223         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2226
2227 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
2228
2229         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
2230         https://bugs.webkit.org/show_bug.cgi?id=68024
2231
2232         Reviewed by Gustavo Noronha Silva.
2233         
2234         Using g_list_count() and g_list_nth_data() together on a loop is
2235         inneficient since they're both O(n). Iterate over lists in a saner
2236         way.
2237
2238         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2239         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
2240         iterate on it using g_list_next(). Free the list after done with it.
2241         (dumpBackForwardListForWebView): Instead of appending (which is
2242         expensive in GLists) history items and then iterating from the tail
2243         of the itemsToPrint list, prepend items and walk forwards as usual.
2244         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
2245         remove the (unneeded) viewList variable.
2246
2247 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2248
2249         Add Eric's IRC nick.
2250
2251         * Scripts/webkitpy/common/config/committers.py:
2252
2253 2011-09-13  Anders Carlsson  <andersca@apple.com>
2254
2255         Disable C++ exceptions when building with clang
2256         https://bugs.webkit.org/show_bug.cgi?id=68031
2257         <rdar://problem/9556880>
2258
2259         Reviewed by Mark Rowe.
2260
2261         * MiniBrowser/Configurations/Base.xcconfig:
2262         * TestWebKitAPI/Configurations/Base.xcconfig:
2263         * WebKitTestRunner/Configurations/Base.xcconfig:
2264
2265 2011-09-13  Ojan Vafai  <ojan@chromium.org>
2266
2267         [chromium] fix flakiness dashboard for chromium interactive tests
2268         https://bugs.webkit.org/show_bug.cgi?id=68029
2269
2270         Reviewed by Tony Chang.
2271
2272         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2273         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2274
2275 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2276
2277         Add Alice and Aryeh to the list of contributors.
2278
2279         * Scripts/webkitpy/common/config/committers.py:
2280
2281 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2282
2283         sheriffbot whois should also tell us email addresses
2284         https://bugs.webkit.org/show_bug.cgi?id=67975
2285
2286         Reviewed by Eric Seidel and David Levin.
2287
2288         Taught sheriffbot how to tell us contributor's email addresses.
2289
2290         * Scripts/webkitpy/tool/bot/irc_command.py:
2291         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2292
2293 2011-09-13  Eric Seidel  <eric@webkit.org>
2294
2295         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
2296         https://bugs.webkit.org/show_bug.cgi?id=68018
2297
2298         Reviewed by Ryosuke Niwa.
2299
2300         * Scripts/build-webkit:
2301         * waf/build/settings.py:
2302
2303 2011-09-13  Chang Shu  <cshu@webkit.org>
2304
2305         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
2306         https://bugs.webkit.org/show_bug.cgi?id=57515
2307
2308         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
2309         TestController synchronously. The latter then sends simulated event to WebKit2 module,
2310         which is synchronous, too.
2311
2312         Reviewed by Darin Adler.
2313
2314         * WebKitTestRunner/EventSenderProxy.h: Added.
2315         (WTR::EventSenderProxy::EventSenderProxy):
2316         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2317         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2318         (WTR::EventSendingController::keyDown):
2319         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2320         * WebKitTestRunner/PlatformWebView.h:
2321         (WTR::PlatformWebView::platformWindow):
2322         * WebKitTestRunner/TestController.cpp:
2323         (WTR::TestController::TestController):
2324         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2325         * WebKitTestRunner/TestController.h:
2326         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2327         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
2328         (WTR::buildModifierFlags):
2329         (WTR::EventSenderProxy::keyDown):
2330
2331 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
2332
2333         [EFL] DRT: Add DumpRenderTreeEfl.h
2334         https://bugs.webkit.org/show_bug.cgi?id=63993
2335
2336         Reviewed by Eric Seidel.
2337         
2338         This header contains some global variables used by EFL's
2339         DumpRenderTree implementation.
2340
2341         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
2342         appropriate.
2343         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
2344
2345 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
2346
2347         [EFL] Send the right key names for PageUp and PageDown.
2348         https://bugs.webkit.org/show_bug.cgi?id=67044
2349
2350         Reviewed by Kenneth Rohde Christiansen.
2351
2352         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
2353         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
2354         However, EventSender was sending "Page_Up" and "Page_Down", so tests
2355         such as editing/input/page-up-down-scrolls.html were timing out due to
2356         the right key down events not being sent.
2357
2358         * DumpRenderTree/efl/EventSender.cpp:
2359         (keyPadNameFromJSValue):
2360         (keyNameFromJSValue):
2361
2362 2011-09-12  Eric Seidel  <eric@webkit.org>
2363
2364         sheriffbot whois is case sensitive
2365         https://bugs.webkit.org/show_bug.cgi?id=67972
2366
2367         Reviewed by Adam Barth.
2368
2369         I also fixed a typo in the "More than 5 contributors" message
2370         from my previous commit.
2371
2372         * Scripts/webkitpy/common/config/committers.py:
2373         * Scripts/webkitpy/common/config/committers_unittest.py:
2374         * Scripts/webkitpy/tool/bot/irc_command.py:
2375         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2376
2377 2011-09-12  Eric Seidel  <eric@webkit.org>
2378
2379         sheriffbot whois should be smarter
2380         https://bugs.webkit.org/show_bug.cgi?id=67971
2381
2382         Reviewed by Adam Barth.
2383
2384         This makes sheriffbot whois basically grep the committers list
2385         making it much easier to find a contributor by name.
2386
2387         Unfortunately the current unittests depend on the real committers.py
2388         file, so as we add more eric's to the project, this unittest result will
2389         change.  I think that's OK for now.  We'll fix it when it breaks.
2390
2391         * Scripts/webkitpy/common/config/committers.py:
2392         * Scripts/webkitpy/tool/bot/irc_command.py:
2393         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2394
2395 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2396
2397         Unreviewed, rolling out r94976.
2398         http://trac.webkit.org/changeset/94976
2399         https://bugs.webkit.org/show_bug.cgi?id=67953
2400
2401         Broke a bunch of security/load& tests (Requested by rniwa on
2402         #webkit).
2403
2404         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2405         (LayoutTestController::pathToLocalResource):
2406
2407 2011-09-12  Eric Seidel  <eric@webkit.org>
2408
2409         Rubber-stamped by Adam Barth.
2410
2411         Remove the "the tree is burning!" warning previously shown
2412         when landing patches.  It was a dream.  But it's just noise now.
2413
2414         Some bots will require a restart to notice the removal of the option
2415         so I've left the --ignore-builders option in for now.
2416
2417         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2418         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2419         * Scripts/webkitpy/tool/commands/download.py:
2420         * Scripts/webkitpy/tool/commands/download_unittest.py:
2421         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2422         * Scripts/webkitpy/tool/steps/__init__.py:
2423         * Scripts/webkitpy/tool/steps/commit.py:
2424         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
2425         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2426
2427 2011-09-12  Eric Seidel  <eric@webkit.org>
2428
2429         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
2430         https://bugs.webkit.org/show_bug.cgi?id=65781
2431
2432         Reviewed by Ryosuke Niwa.
2433
2434         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
2435         to resolve the passed in url relative to the absolute url for the test.
2436
2437         I believe this is a better approach than the on used in the Qt and Chromium DRT's
2438         (which resolves the path relative to the built location of the DRT executable)
2439         and we should move this new code into a shared location in a follow-up patch.
2440
2441         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2442         (LayoutTestController::pathToLocalResource):
2443
2444 2011-09-12  Eric Seidel  <eric@webkit.org>
2445
2446         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2447         https://bugs.webkit.org/show_bug.cgi?id=67530
2448
2449         Reviewed by Adam Barth.
2450
2451         I believe I've fixed the bug in the original patch which prompted the rollout.
2452         The previous patch was using the wrong deadline for the initial read,
2453         subtracting time.time() twice from the deadline value.
2454
2455         * Scripts/webkitpy/layout_tests/port/webkit.py:
2456         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2457
2458 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
2459
2460         [Qt][WK2] WebKitTestRunner does not produce crash logs
2461         https://bugs.webkit.org/show_bug.cgi?id=67714
2462
2463         Reviewed by Chang Shu.
2464
2465         Added a simple way of generating backtrace on crash
2466         to the web process. The implementation is similar what
2467         we have in DRT. It depends on GNU libc functionality
2468         so it is only enabled where we are running in such an environment.
2469
2470         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2471         (WTR::printBacktrace):
2472         (WTR::crashHandler):
2473         (WTR::InjectedBundle::platformInitialize):
2474
2475 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
2476
2477         Added my IRC nick to the committers file.
2478
2479         * Scripts/webkitpy/common/config/committers.py:
2480
2481 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
2482
2483         The executable allocator makes it difficult to free individual
2484         chunks of executable memory
2485         https://bugs.webkit.org/show_bug.cgi?id=66363
2486
2487         Reviewed by Oliver Hunt.
2488         
2489         Introduced a best-fit, balanced-tree based allocator. The allocator
2490         required a balanced tree that does not allocate memory and that
2491         permits the removal of individual nodes directly (as opposed to by
2492         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
2493         Changed all references to executable code to use a reference counted
2494         handle.
2495
2496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2497         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
2498         (TestWebKitAPI::TEST_F):
2499         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
2500         (TestWebKitAPI::Pair::findExact):
2501         (TestWebKitAPI::Pair::remove):
2502         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
2503         (TestWebKitAPI::Pair::assertFoundAndRemove):
2504         (TestWebKitAPI::Pair::assertEqual):
2505         (TestWebKitAPI::Pair::assertSameValuesForKey):
2506         (TestWebKitAPI::Pair::testDriver):
2507         (TestWebKitAPI::TEST_F):
2508
2509 2011-09-10  Andy Estes  <aestes@apple.com>
2510
2511         Move myself from committers_unable_to_review to reviewers_list.
2512
2513         * Scripts/webkitpy/common/config/committers.py:
2514
2515 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
2516
2517         [wx] Unreviewed build fix. MSW build fixes.
2518
2519         * DumpRenderTree/config.h:
2520         * waf/build/wxpresets.py:
2521
2522 2011-09-10  Andreas Kling  <kling@webkit.org>
2523
2524         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
2525         https://bugs.webkit.org/show_bug.cgi?id=59328
2526
2527         Reviewed by Kenneth Rohde Christiansen.
2528
2529         * MiniBrowser/mac/BrowserWindowController.m:
2530         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
2531
2532 2011-09-10  Adam Barth  <abarth@webkit.org>
2533
2534         Build fix for Android.  DumpRenderTree is a client of the WebKit API
2535         and does not have access to notImplemented().
2536
2537         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2538         (openStartupDialog):
2539
2540 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
2541
2542         Add a script to create a monolithic script-test
2543         https://bugs.webkit.org/show_bug.cgi?id=67747
2544
2545         Reviewed by Darin Adler.
2546
2547         * Scripts/make-new-script-test: Added.
2548
2549 2011-09-09  Luiz Agostini  <luiz@webkit.org>
2550
2551         Adding myself to the reviewers list.
2552
2553         * Scripts/webkitpy/common/config/committers.py:
2554
2555 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
2556
2557         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
2558         https://bugs.webkit.org/show_bug.cgi?id=67855
2559
2560         Reviewed by Dirk Pranke.
2561
2562         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
2563         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
2564
2565         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
2566
2567         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2568
2569 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
2570
2571         Add myself to committers.py
2572         https://bugs.webkit.org/show_bug.cgi?id=67853
2573
2574         Reviewed by Darin Adler.
2575
2576         * Scripts/webkitpy/common/config/committers.py:
2577
2578 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2579
2580         [Qt] Remove common.pri
2581         https://bugs.webkit.org/show_bug.cgi?id=67814
2582
2583         Reviewed by Andreas Kling.
2584
2585         * Tools.pro:
2586
2587 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2588
2589         [NRWT] the nrwt check httpd with --no-http option
2590         https://bugs.webkit.org/show_bug.cgi?id=67835
2591
2592         Reviewed by Tony Chang.
2593
2594         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2595         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2596
2597 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
2598
2599         [chromium] Implement DRT support for Android.
2600         https://bugs.webkit.org/show_bug.cgi?id=67590
2601
2602         Reviewed by Tony Chang.
2603
2604         Add 2 mechanism to make DRT interaction more robust on Android:
2605         - Send 'QUIT' to DRT to make it stop.
2606         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
2607         input commands before it starts.
2608         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
2609         and <clocale> for 'LC_ALL' to compile on Android.
2610
2611         Also change to use sigaction instead of signal for TestShellGtk.cpp,
2612         as signal() man page recommends using sigaction().
2613
2614         * DumpRenderTree/DumpRenderTree.gypi:
2615         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2616         (main):
2617         * DumpRenderTree/chromium/LayoutTestController.cpp:
2618         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
2619         (AlarmHandler):
2620         (TestShell::waitTestFinished):
2621         (platformInit):
2622         (openStartupDialog):
2623         (checkLayoutTestSystemDependencies):
2624         * DumpRenderTree/chromium/TestShellGtk.cpp:
2625         (AlarmHandler):
2626         (TestShell::waitTestFinished):
2627
2628 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
2629
2630         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
2631
2632         * waf/build/settings.py:
2633
2634 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2635
2636         Unreviewed, rolling out r94851.
2637         http://trac.webkit.org/changeset/94851
2638         https://bugs.webkit.org/show_bug.cgi?id=67847
2639
2640         It broke a webkitpy test (Requested by ossy on #webkit).
2641
2642         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2643
2644 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2645
2646         [NRWT] the nrwt check httpd with --no-http option
2647         https://bugs.webkit.org/show_bug.cgi?id=67835
2648
2649         Reviewed by Csaba Osztrogonác.
2650
2651         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2652
2653 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
2654
2655         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
2656         https://bugs.webkit.org/show_bug.cgi?id=67794
2657         <rdar://problem/9892024>
2658         
2659         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
2660
2661         Reviewed by Brady Eidson.
2662
2663         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
2664         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
2665         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
2666         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
2667             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
2668             didPerformServerRedirect.
2669
2670         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
2671         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
2672             our InjectedBundleTest.
2673         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
2674             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
2675             the request.
2676         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
2677
2678         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
2679         
2680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2681         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
2682         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
2683         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
2684
2685 2011-09-08  David Levin  <levin@chromium.org>
2686
2687         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
2688         https://bugs.webkit.org/show_bug.cgi?id=67797
2689
2690         Reviewed by Eric Seidel.
2691
2692         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
2693         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
2694
2695 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
2696
2697         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
2698         https://bugs.webkit.org/show_bug.cgi?id=67723
2699
2700         Reviewed by Adam Barth.
2701
2702         * DumpRenderTree/chromium/EventSender.h:
2703         * DumpRenderTree/chromium/LayoutTestController.cpp:
2704         (LayoutTestController::LayoutTestController):
2705         (LayoutTestController::enableFixedLayoutMode):
2706         (LayoutTestController::setFixedLayoutSize):
2707         * DumpRenderTree/chromium/LayoutTestController.h:
2708
2709 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
2710
2711         Add standalone script that filters the output of build-webkit to be more human-readable
2712         https://bugs.webkit.org/show_bug.cgi?id=44081
2713
2714         Reviewed by Daniel Bates.
2715
2716         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
2717         a build script (e.g. build-webkit) and it spits out a prettier version.
2718         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
2719         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
2720
2721 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
2722
2723         Add myself to committers.py                 
2724         https://bugs.webkit.org/show_bug.cgi?id=67696
2725
2726         Reviewed by Kent Tamura.
2727
2728         * Scripts/webkitpy/common/config/committers.py:
2729
2730 2011-09-07  Adam Barth  <abarth@webkit.org>
2731
2732         rebaseline button in garden-o-matic details view should work
2733         https://bugs.webkit.org/show_bug.cgi?id=67738
2734
2735         Reviewed by Dimitri Glazkov.
2736
2737         This patch wires up the rebaseline button in garden-o-matic results
2738         details view.  The button is current per-test, so there isn't a way to
2739         rebaseline individual bots.  This is a place to start.  If we decide we
2740         want per-bot rebaselining, we'll need to think of some better UI.
2741
2742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2746
2747 2011-09-07  Eric Seidel  <eric@webkit.org>
2748
2749         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
2750         https://bugs.webkit.org/show_bug.cgi?id=67737
2751
2752         Reviewed by Adam Barth.
2753
2754         I got a little over-eager when deprecating host.port_factory in the previous commit.
2755         Turns out that Host.port_factory was already the "modern" port/factory.py
2756         it was just the Module object.  I un-deprecated the variable, and changed it from
2757         being the module to being an actual PortFactory, passing it a host object.
2758         I also taught PortFactory how to set user/executive/filesystem in the kwargs
2759         when instantiating a new Port object.
2760         This magically fixed the test_rebaseline test, since its now no longer talking
2761         to the real filesystem.
2762
2763         * Scripts/webkitpy/common/host.py:
2764         * Scripts/webkitpy/layout_tests/port/factory.py:
2765         * Scripts/webkitpy/tool/commands/queries.py:
2766         * Scripts/webkitpy/tool/mocktool.py:
2767
2768 2011-09-07  Eric Seidel  <eric@webkit.org>
2769
2770         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
2771         https://bugs.webkit.org/show_bug.cgi?id=67734
2772
2773         Reviewed by Adam Barth.
2774
2775         Right now every place that creates a Port object has to be very careful
2776         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
2777         The correct fix is for port/factory.py (which creates most port objects)
2778         to know how to pass these in automatically.  However, currently all port/factory.py
2779         functions are free functions instead of being on an object.  This patch
2780         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
2781
2782         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
2783         pass along the proper scm/user/filesystem to the Port object.
2784
2785         * Scripts/webkitpy/common/host.py:
2786         * Scripts/webkitpy/layout_tests/port/factory.py:
2787         * Scripts/webkitpy/tool/commands/queries.py:
2788         * Scripts/webkitpy/tool/mocktool.py:
2789
2790 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2791
2792         Unreviewed, rolling out r94441.
2793         http://trac.webkit.org/changeset/94441
2794         https://bugs.webkit.org/show_bug.cgi?id=67731
2795
2796         "MacEWSes are backed up due to new machines not able to reach
2797         git.webkit.org.  Disabling tests for now" (Requested by
2798         eseidel2 on #webkit).
2799
2800         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2801
2802 2011-09-07  Elliot Poger  <epoger@google.com>
2803
2804         filter test_expectations properly for chromium-mac vs chromium-cg-mac
2805         https://bugs.webkit.org/show_bug.cgi?id=67324
2806
2807         Reviewed by Dirk Pranke.
2808
2809         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2810         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2811         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2812         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2813         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2814
2815 2011-09-07  Eric Boren  <borenet@gmail.com>
2816
2817         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2818         https://bugs.webkit.org/show_bug.cgi?id=66800
2819
2820         Reviewed by Darin Fisher.
2821
2822         * DumpRenderTree/chromium/EventSender.cpp:
2823         (EventSender::sendCurrentTouchEvent):
2824
2825 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
2826
2827         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2828         https://bugs.webkit.org/show_bug.cgi?id=67254
2829
2830         Reviewed by Csaba Osztrogonác.
2831
2832         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
2833         derived from the running location of DumpRenderTree binary.
2834
2835         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2836         (LayoutTestController::pathToLocalResource):
2837         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
2838
2839 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2840
2841         REGRESSION(r94288) build-webkit doesn't work on Symbian
2842         https://bugs.webkit.org/show_bug.cgi?id=67706
2843
2844         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
2845         (buildQMakeProject):
2846
2847 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2848
2849         REGRESSION(r94288) build-webkit doesn't work on Windows
2850         https://bugs.webkit.org/show_bug.cgi?id=67646
2851
2852         Roll back r94655 with a small fix.
2853
2854         * Scripts/webkitdirs.pm:
2855         (buildQMakeProject):
2856
2857 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2858
2859         Unreviewed, rolling out r94635.
2860         http://trac.webkit.org/changeset/94635
2861         https://bugs.webkit.org/show_bug.cgi?id=67704
2862
2863         Linux Touch build is failing to compile this change.
2864         (Requested by loislo on #webkit).
2865
2866         * DumpRenderTree/chromium/EventSender.cpp:
2867         (EventSender::sendCurrentTouchEvent):
2868
2869 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2870
2871         Unreviewed, rolling out r94655.
2872         http://trac.webkit.org/changeset/94655
2873         https://bugs.webkit.org/show_bug.cgi?id=67703
2874
2875         It broke Leopard debug bot (Requested by ossy on #webkit).
2876
2877         * Scripts/webkitdirs.pm:
2878
2879 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2880
2881         REGRESSION(r94288) build-webkit doesn't work on Windows
2882         https://bugs.webkit.org/show_bug.cgi?id=67646
2883
2884         Reviewed by Csaba Osztrogonác.
2885
2886         * Scripts/webkitdirs.pm:
2887
2888 2011-09-06  Eric Boren  <borenet@gmail.com>
2889
2890         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2891         https://bugs.webkit.org/show_bug.cgi?id=66800
2892
2893         Reviewed by Darin Fisher.
2894
2895         * DumpRenderTree/chromium/EventSender.cpp:
2896         (EventSender::sendCurrentTouchEvent):
2897
2898 2011-09-06  Adam Barth  <abarth@webkit.org>
2899
2900         garden-o-matic details view should having working rebaseline and next/previous buttons
2901         https://bugs.webkit.org/show_bug.cgi?id=67659
2902
2903         Reviewed by Dimitri Glazkov.
2904
2905         This patch wires up basic back/forward buttons that let you traverse
2906         through the results we're examining in the details view.  This ended up
2907         being more code than I expected, but I wanted to keep all the state
2908         information in the DOM itself.
2909
2910         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2911         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2913
2914 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
2915
2916         fix MockFileSystem.glob(), refactor filesystem tests
2917         https://bugs.webkit.org/show_bug.cgi?id=67462
2918
2919         Reviewed by Eric Seidel.
2920
2921         In debugging why my proposed change for MockFileSystem.glob()
2922         in bug 66228 didn't work, I stumbled across two real bugs
2923         that cancelled each other out for the unit tests. I fixed those
2924         (glob shouldn't recurse into subdirs, and we weren't populating
2925         self.dirs from self.files properly).
2926
2927         I have also created a "mixin" class for tests that can be shared
2928         between the real filesystem and the mock filesystem - MockFileSystem
2929         is being used enough it needs its own tests.
2930
2931         * Scripts/webkitpy/common/system/filesystem_mock.py:
2932         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
2933         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2934
2935 2011-09-06  Anders Carlsson  <andersca@apple.com>
2936
2937         Move NPAPI headers in bridge to plugins
2938         https://bugs.webkit.org/show_bug.cgi?id=67661
2939
2940         Update forwarding headers.
2941
2942         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2943         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2944
2945 2011-09-06  Tony Chang  <tony@chromium.org>
2946
2947         [chromium] Check in 'build' for compiled binaries first
2948         https://bugs.webkit.org/show_bug.cgi?id=67549
2949
2950         Reviewed by Dirk Pranke.
2951
2952         I'm working on moving the windows build output to a common location
2953         rather than relative to the sln file.  Because of that, we need to
2954         check those build locations first for DumpRenderTree.exe.
2955
2956         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2957
2958 2011-09-06  Adam Barth  <abarth@webkit.org>
2959
2960         Use a hierarchial structure for the garden-o-matic results view
2961         https://bugs.webkit.org/show_bug.cgi?id=67620
2962
2963         Reviewed by Dimitri Glazkov.
2964
2965         This patch re-organizes the results view to use a hierachial structure
2966         for selection.  At the top-level are sections for each test.  Expanding
2967         the test section shows a tab selector for builders.
2968
2969         This structure prepares us for wiring up various actions to this view.
2970
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2972         (.):
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2974         ():
2975         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2976         (.):
2977         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2979         (.results-view>.toolbar):
2980         (.results-view>.toolbar ul.actions):
2981         (.results-view>.toolbar ul.actions li):
2982         (.results-grid table):
2983         (.results-grid table td, .results-view table th):
2984         (.results-grid table th):
2985         (.results-grid .text-result):
2986         (.results-grid .image-result):
2987
2988 2011-09-06  Adam Barth  <abarth@webkit.org>
2989
2990         garden-o-matic's base.probe generates spam in the JavaScript console
2991         https://bugs.webkit.org/show_bug.cgi?id=67622
2992
2993         Reviewed by Dimitri Glazkov.
2994
2995         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
2996         instead of HTMLScriptElement to test whether results exist.  This
2997         reduces the console.log spam and saves bandwidth because we can use a
2998         HEAD request instead of a GET request.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
3001
3002 2011-09-05  Adam Barth  <abarth@webkit.org>
3003
3004         Add a tab to garden-o-matic for viewing expected failures
3005         https://bugs.webkit.org/show_bug.cgi?id=67619
3006
3007         Reviewed by Dimitri Glazkov.
3008
3009         This patch adds a basic tab to garden-o-matic that shows all the tests
3010         failing on the bots, including the expected failures.  This patch
3011         mostly involves refactoring existing classes to allow new subclasses.
3012
3013         This view is useful for when gardeners mark tests as expected to fail
3014         and then rebaseline them later.
3015
3016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
3020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3023
3024 2011-09-05  Adam Barth  <abarth@webkit.org>
3025
3026         Fix global variable leak in garden-o-matic
3027         https://bugs.webkit.org/show_bug.cgi?id=67617
3028
3029         Reviewed by Dimitri Glazkov.
3030
3031         Caught by running the unit tests with noglobals turned on.
3032
3033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3034
3035 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
3036
3037         [Qt][WK2] Add pixel test support
3038         https://bugs.webkit.org/show_bug.cgi?id=66283
3039
3040         Reviewed by Andreas Kling.
3041
3042         Implemented pixel result generation by reusing the logic
3043         that we have in DumpRenderTree.
3044         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3045         (WTR::dumpImage):
3046         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3047
3048 2011-09-04  Robin Dunn  <robin@alldunn.com>
3049
3050         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
3051         https://bugs.webkit.org/show_bug.cgi?id=67577
3052
3053         Reviewed by Kevin Ollivier.
3054
3055         * waf/build/settings.py:
3056
3057 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
3058
3059         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
3060
3061         * waf/build/settings.py:
3062
3063 2011-09-03  Dan Bernstein  <mitz@apple.com>
3064
3065         32-bit build fix.
3066
3067         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3068         (TestWebKitAPI::Util::toSTD):
3069
3070 2011-09-03  Dan Bernstein  <mitz@apple.com>
3071
3072         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
3073         https://bugs.webkit.org/show_bug.cgi?id=67559
3074
3075         Reviewed by Darin Adler.
3076
3077         * DumpRenderTree/mac/DumpRenderTree.mm:
3078         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
3079         the call to it.
3080         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
3081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
3082         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
3083         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
3084         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3085         (TestWebKitAPI::Util::toSTD): Added.
3086
3087 2011-09-03  Adam Barth  <abarth@webkit.org>
3088
3089         garden-o-matic results view should have a better results selector
3090         https://bugs.webkit.org/show_bug.cgi?id=67542
3091
3092         Reviewed by Dimitri Glazkov.
3093
3094         This patch adds a basic grid-based results selector to the results
3095         view.  Currently, this grid just shows how the tests fail on the
3096         various bots.  A future patch will let you select which failure to view
3097         and to mark the failures for rebaselining.
3098
3099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3101           - Add some more basic functions for manipulating dictionaries.
3102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3105
3106 2011-09-03  Adam Barth  <abarth@webkit.org>
3107
3108         garden-o-matic results view should show Actual and Expected results for text failures
3109         https://bugs.webkit.org/show_bug.cgi?id=67536
3110
3111         Reviewed by Eric Seidel.
3112
3113         In the past, we didn't show actual and expected text results (we just
3114         showed the diff) because we didn't have the awesome six-by-two results
3115         grid.  Now that we do, we can move show these results.
3116
3117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3119           - Fixed some typos that were preventing these unit tests from running.
3120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3121         (.):
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3123           - Report -actual.txt and -expected.txt as possible results URLs.
3124
3125 2011-09-03  Adam Barth  <abarth@webkit.org>
3126
3127         garden-o-matic shows "ghost" failures that are already fixed
3128         https://bugs.webkit.org/show_bug.cgi?id=67535
3129
3130         Reviewed by Eric Seidel.
3131
3132         About 10% of writes fail to stick on test-results.appspot.com.  This
3133         patch causes us to fetch the full_results.json blob directly from
3134         build.chromium.org rather than relying upon AppEngine.
3135
3136         Unforuntately, we still need to get historical information from
3137         AppEngine.  That will take several patches to fix becuase I need to
3138         change the bots to write the full_results.json file to the
3139         build-specific directory in addition to the zip file.
3140
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3144
3145 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3146
3147         Unreviewed, rolling out r94458.
3148         http://trac.webkit.org/changeset/94458
3149         https://bugs.webkit.org/show_bug.cgi?id=67558
3150
3151         Caused appcache test to fail on various bots (Requested by
3152         rniwa on #webkit).
3153
3154         * Scripts/webkitpy/layout_tests/port/webkit.py:
3155         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3156
3157 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3158
3159         Unreviewed, rolling out r94453.
3160         http://trac.webkit.org/changeset/94453
3161         https://bugs.webkit.org/show_bug.cgi?id=67557
3162
3163         Caused appcache test to fail on various bots (Requested by
3164         rniwa on #webkit).
3165
3166         * Scripts/webkitpy/layout_tests/port/webkit.py:
3167
3168 2011-09-02  Michael Saboff  <msaboff@apple.com>
3169
3170         Add JSC:RegExp functional tests
3171         https://bugs.webkit.org/show_bug.cgi?id=67339
3172
3173         New perl script to build JavaScriptCore and run the RegExp tests.
3174
3175         Reviewed by Gavin Barraclough.
3176
3177         * Scripts/run-regexp-tests: Added.
3178
3179 2011-09-02  Michael Saboff  <msaboff@apple.com>
3180
3181         Add JSC:RegExp functional tests
3182         https://bugs.webkit.org/show_bug.cgi?id=67339
3183
3184         New perl script to build JavaScriptCore and run the RegExp tests.
3185
3186         Reviewed by Gavin Barraclough.
3187
3188         * Scripts/run-regexp-tests: Added.
3189
3190 2011-09-02  Eric Seidel  <eric@webkit.org>
3191
3192         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3193         https://bugs.webkit.org/show_bug.cgi?id=67530
3194
3195         Unreviewed.  Fixing typo from previous commit.
3196
3197         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
3198         which exercises the code I previously made a typo in.
3199
3200         * Scripts/webkitpy/layout_tests/port/webkit.py:
3201         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3202
3203 2011-09-02  Eric Seidel  <eric@webkit.org>
3204
3205         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3206         https://bugs.webkit.org/show_bug.cgi?id=67530
3207
3208         Reviewed by Adam Barth.
3209
3210         No functional change, just reshuffling code.
3211
3212         * Scripts/webkitpy/layout_tests/port/webkit.py:
3213
3214 2011-09-02  Darin Adler  <darin@apple.com>
3215
3216         Added Subversion ignore for .pyc generated files.
3217
3218         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
3219         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
3220         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
3221
3222 2011-09-02  Adam Barth  <abarth@webkit.org>
3223
3224         Enable testing on mac-ews
3225         https://bugs.webkit.org/show_bug.cgi?id=67505
3226
3227         Reviewed by Eric Seidel.
3228
3229         This patch enables testing on the Mac EWS, which should help
3230         contributors not turn the Mac bots red.
3231
3232         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3233
3234 2011-09-01  Beth Dakin  <bdakin@apple.com>
3235
3236         https://bugs.webkit.org/show_bug.cgi?id=67451
3237         Add a test for going back to a cached page after changing the device scale factor
3238
3239         Reviewed by Adam Roben.
3240
3241         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
3242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3243         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
3244         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
3245         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
3246         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3247         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
3248         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3249         (TestWebKitAPI::TEST_F):
3250
3251         Added new function to WebKitAgnosticTest to goBack. Separated 
3252         waitForLoadToFinish() into its own function (instead of being a part of 
3253         loadAndWaitUntilFinished()) so that it can be called from goBack as 
3254         well. Also added initializeView() so we can set the cache model.
3255         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
3256         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
3257         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3258         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
3259         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3260         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3261         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
3262         (TestWebKitAPI::WebKitAgnosticTest::goBack):
3263         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
3264
3265 2011-09-02  Anders Carlsson  <andersca@apple.com>
3266
3267         Build fix.
3268
3269         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
3270         (PrivateBrowsing::ScriptableObject::pluginTest):
3271
3272 2011-09-02  Anders Carlsson  <andersca@apple.com>
3273
3274         Move private browsing test to a PluginTest subclass
3275         https://bugs.webkit.org/show_bug.cgi?id=67498
3276
3277         Reviewed by Darin Adler.
3278
3279         * DumpRenderTree/DumpRenderTree.gypi:
3280         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3281         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3282         (pluginGetProperty):
3283         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3284         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3285         (PluginTest::NPP_SetValue):
3286         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3287         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
3288         (PrivateBrowsing::PrivateBrowsing):
3289         (PrivateBrowsing::privateBrowsingEnabled):
3290         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
3291         (PrivateBrowsing::ScriptableObject::hasProperty):
3292         (PrivateBrowsing::ScriptableObject::getProperty):
3293         (PrivateBrowsing::ScriptableObject::pluginTest):
3294         (PrivateBrowsing::NPP_New):
3295         (PrivateBrowsing::NPP_GetValue):
3296         (PrivateBrowsing::NPP_SetValue):
3297         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3298         (NPP_New):
3299         (NPP_SetValue):
3300         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3301         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3302         * GNUmakefile.am:
3303
3304 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
3305
3306         [Qt] Build dependency problems
3307         https://bugs.webkit.org/show_bug.cgi?id=38054
3308
3309         Trivial fix after r94288.
3310
3311         Rubber-stamped by Andras Becsi.
3312
3313         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
3314         (buildQMakeProject):
3315
3316 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
3317
3318         Remove my old e-mail address and add my new one.
3319
3320         Rubber-stamped by Tor Arne Vestbø.
3321
3322         * Scripts/webkitpy/common/config/committers.py:
3323
3324 2011-09-02  Philippe Normand  <pnormand@igalia.com>
3325
3326         [GTK] run-gtk-tests leaves a zombie Xvfb process
3327         https://bugs.webkit.org/show_bug.cgi?id=67389
3328
3329         Reviewed by Martin Robinson.
3330
3331         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
3332         child process instead of doing shell redirection.
3333
3334 2011-09-01  Mark Rowe  <mrowe@apple.com>
3335
3336         Fix the build by adding some more missing return types.
3337
3338         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3339         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3340
3341 2011-09-01  Eric Seidel  <eric@webkit.org>
3342
3343         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
3344         https://bugs.webkit.org/show_bug.cgi?id=66228
3345
3346         Reviewed by Dirk Pranke.
3347
3348         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
3349         The LeaksViewer tool globs for all *-leaks.txt files.
3350         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
3351
3352         In order to test this I had to fix a limitation in our MockFileSystem.glob
3353         method.  However, doing so uncovered a typo and bug in the integration tests.
3354         I've disabled the offending integration tests.
3355
3356         * Scripts/webkitpy/common/system/filesystem_mock.py:
3357         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3358         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3359
3360 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
3361
3362         Adds a LayoutTestController method to make it possible to test
3363         starting speech input via an API call.
3364         https://bugs.webkit.org/show_bug.cgi?id=60170
3365
3366         Reviewed by Dimitri Glazkov.
3367
3368         * DumpRenderTree/LayoutTestController.h:
3369         * DumpRenderTree/chromium/LayoutTestController.cpp:
3370         (LayoutTestController::LayoutTestController):
3371         (LayoutTestController::startSpeechInput):
3372         * DumpRenderTree/chromium/LayoutTestController.h:
3373         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3374         (LayoutTestController::startSpeechInput):
3375         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3376         (LayoutTestController::startSpeechInput):
3377         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3378         (LayoutTestController::startSpeechInput):
3379         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3380         (LayoutTestController::startSpeechInput):
3381         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3382         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3383         (LayoutTestController::startSpeechInput):
3384         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3385         (LayoutTestController::startSpeechInput):
3386
3387 2011-09-01  Tim Horton  <hortont424@gmail.com>
3388
3389         Fix TestWebKitAPI build on clang-2.0
3390
3391         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3392
3393 2011-09-01  Adam Barth  <abarth@webkit.org>
3394
3395         Remove unused "extension" parameter from rebaseline gardeningserver handler
3396         https://bugs.webkit.org/show_bug.cgi?id=67384
3397
3398         Reviewed by James Robinson.
3399
3400         This parameter hasn't done anything in a while.
3401
3402         * Scripts/webkitpy/tool/commands/rebaseline.py:
3403         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3404         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3405
3406 2011-09-01  Eric Seidel  <eric@webkit.org>
3407
3408         Unreviewed.
3409
3410         Fix a typo in unittests.  Unfortunately fixing it
3411         caused several assertions.  Just disabling the test
3412         instead, since it was providing no value before due to the typo.
3413
3414         * Scripts/webkitpy/layout_tests/port/test.py:
3415
3416 2011-09-01  Adam Barth  <abarth@webkit.org>
3417
3418         Add a "rebaseline" button to the garden-o-matic summary page
3419         https://bugs.webkit.org/show_bug.cgi?id=67382
3420
3421         Reviewed by Dimitri Glazkov.
3422
3423         As much as we might wish folks to not rebaseline entire test groups at
3424         once, the truth is that doing so is a common operation.  Adding a
3425         button for this operation is likely to make folks happy.
3426
3427         This patch also cleans up a bunch of plumbing surrounding failureInfo
3428         objects.
3429
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3440
3441 2011-09-01  Adam Barth  <abarth@webkit.org>
3442
3443         garden-o-matic should let the gardener assign blame for a group of test failures
3444         https://bugs.webkit.org/show_bug.cgi?id=67379
3445
3446         Reviewed by Dimitri Glazkov.
3447
3448         If a group of test failures has a large revision range, the gardener
3449         might wish to blame a specific revision for the failure.  Currently,
3450         this only effect of assigning blame in this way is to hide the other
3451         suspect commits.
3452
3453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3456
3457 2011-09-01  Adam Barth  <abarth@webkit.org>
3458
3459         Hide garden-o-matic failure table until hover
3460         https://bugs.webkit.org/show_bug.cgi?id=67376
3461
3462         Reviewed by Dimitri Glazkov.
3463
3464         This patch removes the failure table for build failures (because it
3465         does not make sense) and hides the failure table for test groups until
3466         the user hovers over the test failure block, reducing visual noise.
3467
3468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3471
3472 2011-09-01  Adam Barth  <abarth@webkit.org>
3473
3474         Switch garden-o-matic from commitData.title to commitData.summary
3475         https://bugs.webkit.org/show_bug.cgi?id=67375
3476
3477         Reviewed by Dimitri Glazkov.
3478
3479         commitData.title is a string provided by Trac, which isn't great in all
3480         cases.  commitData.summary is my attempt to find the most important
3481         one-line summary of the commit.  This patch switches garden-o-matic
3482         over to summary.
3483
3484         Also, this patch tweaks a bunch of CSS to tighten up the summary page
3485         and reduce visual noise.
3486
3487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3490
3491 2011-09-01  Adam Barth  <abarth@webkit.org>
3492
3493         Group failing tests in garden-o-matic if there are more than three in a folder
3494         https://bugs.webkit.org/show_bug.cgi?id=67373
3495
3496         Reviewed by Dimitri Glazkov.
3497
3498         Sometimes a failure will cause many tests in a given directory to fail.
3499         When that happens, it's better to list the directory as a single item
3500         (with a count) rather than spamming all the test names.
3501
3502         (This patch also updates a bunch of unit test expected results after my last commit.)
3503
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3509
3510 2011-09-01  Adam Barth  <abarth@webkit.org>
3511
3512         Lower the visual noise from the failing builders display
3513         https://bugs.webkit.org/show_bug.cgi?id=67369
3514
3515         Reviewed by Dimitri Glazkov.
3516
3517         This patch ensures that the "Building" row in the failing builders
3518         display is always last and dims it by 50% to reduce visual noise.  This
3519         lets the gardener focus on the actual failures.
3520
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
3524
3525 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3526
3527         [Qt] Build dependency problems
3528         https://bugs.webkit.org/show_bug.cgi?id=38054
3529
3530         Make clean build after the defines are changed.
3531
3532         Reviewed by Csaba Osztrogonác.
3533
3534         * Scripts/webkitdirs.pm:
3535         (buildQMakeProject):
3536
3537 2011-08-31  Adam Barth  <abarth@webkit.org>
3538
3539         Move DumpRenderTree to WebKitPlatformSupport
3540         https://bugs.webkit.org/show_bug.cgi?id=67331
3541
3542         Reviewed by Darin Fisher.
3543
3544         This patch update DumpRenderTree to account for the WebKitClient =>
3545         WebKitPlatformSupport rename.
3546
3547         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3548         (NotificationPresenter::show):
3549         * DumpRenderTree/chromium/Task.cpp:
3550         (postTask):
3551
3552 2011-08-31  Eric Seidel  <eric@webkit.org>
3553
3554         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
3555         https://bugs.webkit.org/show_bug.cgi?id=67314
3556
3557         Reviewed by Adam Barth.
3558
3559         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
3560         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
3561         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
3562
3563         I also moved a bunch of code into dashboard.css which belonged there.
3564
3565         * QueueStatusServer/handlers/activebots.py: Added.
3566         * QueueStatusServer/main.py:
3567         * QueueStatusServer/stylesheets/dashboard.css:
3568         (.queue_bubble):
3569         (.queue_name):
3570         (.last_heard_from):
3571         (.status_text):
3572         (.alive):
3573         (.behind):
3574         (.dead):
3575         * QueueStatusServer/templates/activebots.html: Added.
3576         * QueueStatusServer/templates/dashboard.html:
3577         * QueueStatusServer/templates/recentstatus.html:
3578
3579 2011-08-31  Oliver Hunt  <oliver@apple.com>
3580
3581         Move CheckedArithmeticOperations.cpp to the intended location
3582
3583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3584         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
3585
3586 2011-08-31  Elliot Poger  <epoger@google.com>
3587
3588         add unittest to validate the complete set of Chromium configurations
3589         https://bugs.webkit.org/show_bug.cgi?id=67211
3590
3591         Reviewed by Adam Barth.
3592
3593         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3594
3595 2011-08-31  Nico Weber  <thakis@chromium.org>
3596
3597         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
3598         https://bugs.webkit.org/show_bug.cgi?id=67297
3599
3600         Reviewed by Tony Chang.
3601
3602         Explicitly disable smooth scrolling in chromium's DRT.
3603
3604         * DumpRenderTree/chromium/WebPreferences.cpp:
3605         (WebPreferences::applyTo):
3606
3607 2011-08-31  Oliver Hunt  <oliver@apple.com>
3608
3609         Add Checked<> tests to windows build
3610
3611         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3612
3613 2011-08-30  Oliver Hunt  <oliver@apple.com>
3614
3615         Add support for checked arithmetic
3616         https://bugs.webkit.org/show_bug.cgi?id=67095
3617
3618         Reviewed by Sam Weinig.
3619
3620         Add test cases for Checked<>
3621
3622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3623         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
3624
3625 2011-08-31  Adam Barth  <abarth@webkit.org>
3626
3627         Move summary.html to garden-o-matic.html.
3628
3629         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
3630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
3631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
3632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
3633
3634 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
3635
3636         [chromium] DRT linux should pass nativeKeyCode to plugins
3637         https://bugs.webkit.org/show_bug.cgi?id=66679
3638
3639         Reviewed by Tony Chang.
3640
3641         * DumpRenderTree/chromium/EventSender.cpp:
3642         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
3643         (simulated) nativeKeyCode for the given input keyboard code.
3644
3645 2011-08-31  Adam Barth  <abarth@webkit.org>
3646
3647         Tighen up UI for garden-o-matic tab strip
3648         https://bugs.webkit.org/show_bug.cgi?id=67266
3649
3650         Reviewed by Dimitri Glazkov.
3651
3652         This patch add CSS to move the tab strip to the edges of the page and
3653         to remove some gratuitous border-radius.
3654
3655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
3656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3657
3658 2011-08-31  Adam Barth  <abarth@webkit.org>
3659
3660         garden-o-matic results view shouldn't be horrifically ugly
3661         https://bugs.webkit.org/show_bug.cgi?id=67264
3662
3663         Reviewed by Dimitri Glazkov.
3664
3665         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
3666
3667         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3668         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3670
3671 2011-08-31  Adam Barth  <abarth@webkit.org>
3672