Unreviewed infrastructure fix.
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Unreviewed infrastructure fix.
4
5         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
6         while the hardware is out for repair.
7
8 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
9
10         [WebXR] IDLs, stubs and build configuration for WPE
11         https://bugs.webkit.org/show_bug.cgi?id=208702
12
13         Reviewed by Dean Jackson.
14
15         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
16         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
17
18 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
19
20         [Cocoa] Limit set of classes that can be decoded when a preference has changed
21         https://bugs.webkit.org/show_bug.cgi?id=208012
22
23         Reviewed by Brent Fulgham.
24
25         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
26         (TEST):
27
28 2020-03-16  youenn fablet  <youenn@apple.com>
29
30         Unique origins should not be Potentially Trustworthy
31         https://bugs.webkit.org/show_bug.cgi?id=209049
32
33         Reviewed by Darin Adler.
34
35         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
36         (TestWebKitAPI::TEST_F):
37
38 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
39
40         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
41         https://bugs.webkit.org/show_bug.cgi?id=207324
42
43         Reviewed by Darin Adler.
44
45         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
46         (TestWebKitAPI::generateRandomData): Added.
47         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
48
49 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
50
51         Should not use variable-length-array (VLA)
52         https://bugs.webkit.org/show_bug.cgi?id=209043
53
54         Reviewed by Mark Lam.
55
56         * ContentExtensionTester/Configurations/Base.xcconfig:
57         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
58
59 2020-03-13  Alex Christensen  <achristensen@webkit.org>
60
61         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
62         https://bugs.webkit.org/show_bug.cgi?id=209011
63         <rdar://problem/59370588>
64
65         Reviewed by Youenn Fablet.
66
67         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
68         (TestWebKitAPI::TEST):
69
70 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
71
72         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
73         https://bugs.webkit.org/show_bug.cgi?id=209089
74
75         Reviewed by Tim Horton.
76
77         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
78         marketing name for the feature.
79
80         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
81         (runUntilReceivesAutoplayEvent):
82
83         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
84         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
85         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
86         be any compelling reason to compare against different types here (especially since we only set
87         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
88         these all to be `_WKAutoplayEvent`.
89
90         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
91         (-[AutoFillTestView _autofillInputView]):
92         (-[AutoFillTestView textInputHasAutoFillContext]):
93         (TestWebKitAPI::TEST):
94         (-[AutofillTestView initWithFrame:]): Deleted.
95         (-[AutofillTestView _autofillInputView]): Deleted.
96         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
97         * TestWebKitAPI/ios/UIKitSPI.h:
98
99 2020-03-13  Chris Dumez  <cdumez@apple.com>
100
101         Unreviewed, reverting r256232.
102
103         Caused ResizeObserver tests to become flaky
104
105         Reverted changeset:
106
107         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
108         override TestOptions"
109         https://bugs.webkit.org/show_bug.cgi?id=207481
110         https://trac.webkit.org/changeset/256232
111
112 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
113
114         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
115         https://bugs.webkit.org/show_bug.cgi?id=209016
116         <rdar://problem/60329530> 
117
118         Reviewed by Chris Dumez.
119
120         Re-initialize the app-bound domains when the correct
121         TestOptions parameter is set.
122
123         * WebKitTestRunner/TestController.cpp:
124         (WTR::TestController::createWebViewWithOptions):
125         (WTR::TestController::reinitializeAppBoundDomains):
126         * WebKitTestRunner/TestController.h:
127
128 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
129
130         Report all third party loads on a per-page basis
131         https://bugs.webkit.org/show_bug.cgi?id=209032
132         <rdar://problem/60397323>
133
134         Reviewed by Chris Dumez.
135
136         Mostly naming updates to reflect the change in use for this SPI call.
137         It now returns all loaded third party domains, not just prevalent ones.
138
139         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
140         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
141         (WTR::InjectedBundle::didReceiveMessageToPage):
142         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
143         (WTR::TestRunner::getLoadedThirdPartyDomains):
144         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
145         (WTR::TestRunner::getPrevalentDomains): Deleted.
146         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
147         * WebKitTestRunner/InjectedBundle/TestRunner.h:
148         * WebKitTestRunner/TestController.cpp:
149         (WTR::TestController::resetStateToConsistentValues):
150         (WTR::TestController::getLoadedThirdPartyDomains):
151         (WTR::TestController::clearLoadedThirdPartyDomains):
152         (WTR::TestController::getPrevalentDomains): Deleted.
153         (WTR::TestController::clearPrevalentDomains): Deleted.
154         * WebKitTestRunner/TestController.h:
155         * WebKitTestRunner/TestInvocation.cpp:
156         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
157         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
158         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
159         * WebKitTestRunner/TestInvocation.h:
160         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
161         (WTR::TestController::getLoadedThirdPartyDomains):
162         (WTR::TestController::clearLoadedThirdPartyDomains):
163         (WTR::TestController::getPrevalentDomains): Deleted.
164         (WTR::TestController::clearPrevalentDomains): Deleted.
165
166 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
167
168         [ews] run FindModifiedChangeLogs early in the build
169         https://bugs.webkit.org/show_bug.cgi?id=209060
170
171         Reviewed by Jonathan Bedard.
172
173         * BuildSlaveSupport/ews-build/factories.py:
174         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
175
176 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
177
178         [GTK] Add EWS testers to run GTK layout tests
179         https://bugs.webkit.org/show_bug.cgi?id=207648
180
181         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
182
183         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
184         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
185         tests (layout tests).
186
187         * BuildSlaveSupport/ews-build/config.json: Added new queue for
188         WK2 tests.
189         * BuildSlaveSupport/ews-build/factories.py:
190         (GTKTestsFactory):
191         * BuildSlaveSupport/ews-build/factories_unittest.py:
192         (TestCommitQueueFactory.test_commit_queue_factory):
193         (TestGTKFactory): Added unit-test.
194         (TestGTKFactory.test_gtk_factory):
195         * BuildSlaveSupport/ews-build/loadConfig.py:
196         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
197         (TagsForBuilderTest.test_getTagsForBuilder):
198
199 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
200
201         Add API endpoint in EWS django app to provide patch status in json format
202         https://bugs.webkit.org/show_bug.cgi?id=208940
203
204         Reviewed by Jonathan Bedard.
205
206         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
207         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
208
209 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
210
211         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
212         https://bugs.webkit.org/show_bug.cgi?id=209055
213         <rdar://problem/60272692>
214
215         Reviewed by Simon Fraser.
216
217         Now that WebKitTestRunner has a bundleID, its' user default values
218         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
219         to NO before running tests. It will be set to YES in PlatformWebView
220         if specified by the test.
221
222         * WebKitTestRunner/mac/main.mm:
223         (setDefaultsToConsistentValuesForTesting):
224
225 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
226
227         [CMake] Eleminate mismatches between Find* module names and variables they set
228         https://bugs.webkit.org/show_bug.cgi?id=208948
229
230         Reviewed by Michael Catanzaro.
231
232         * wpe/backends/CMakeLists.txt:
233
234 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
235
236         [ews-app] reduce logging
237         https://bugs.webkit.org/show_bug.cgi?id=209062
238
239         Reviewed by Jonathan Bedard.
240
241         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
242         (BugzillaBeautifulSoup.authenticate):
243         (BugzillaBeautifulSoup._load_query):
244
245 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
246
247         Crash in TextIterator::node via TextManipulationController::replace
248         https://bugs.webkit.org/show_bug.cgi?id=209048
249
250         Reviewed by Wenson Hsieh.
251
252         Added a regression test.
253
254         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
255         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
256
257 2020-03-13  Saam Barati  <sbarati@apple.com>
258
259         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
260         https://bugs.webkit.org/show_bug.cgi?id=209038
261
262         Reviewed by Keith Miller.
263
264         This allows us to automatically pull in some tests that are in non open sourced Apple
265         checkouts.
266
267         * Scripts/run-javascriptcore-tests:
268         (runJSCStressTests):
269
270 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
271
272         Crash in TextManipulationController::replace
273         https://bugs.webkit.org/show_bug.cgi?id=209021
274
275         Reviewed by Wenson Hsieh.
276
277         Added a regression test.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
280         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
281
282 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
283
284         [macOS] _AXSApplicationAccessibilityEnabled should not be called
285         https://bugs.webkit.org/show_bug.cgi?id=208953
286
287         Reviewed by Brent Fulgham.
288
289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
290
291 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
292
293         Resource load statistics data summary should return all third party data
294         https://bugs.webkit.org/show_bug.cgi?id=209000
295         <rdar://problem/60348306>
296
297         Reviewed by John Wilander.
298
299         Marked only 2 of 3 domains prevalent in data summary tests to ensure
300         the call returns all third parties, not just prevalent ones.
301         Added a more aggressive check for the size of the array at the
302         beginning of the test to ensure the array is still returning 3 values. 
303         Also removed the ASSERT statements as they seem to cause timeouts (not
304         clear crashes) when they are not true, which is hard to debug.
305         If these values are nil, the test will fail in the EXPECT_WK_STREQ
306         checks, we don't need ASSERT statements.
307
308         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
309         (TEST):
310
311 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
312
313         resultsdpy: Add script to run local instance
314         https://bugs.webkit.org/show_bug.cgi?id=208746
315
316         Rubber-stamped by Aakash Jain.
317
318         * resultsdbpy/resultsdbpy/example: Added.
319         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
320         * resultsdbpy/resultsdbpy/example/environment.py: Added.
321         (Environment): Organize environment variables used by results database.
322         (ModelFromEnvironment): Construct the database model from the environment.
323         (main): Create and drop tables, if required.
324         * resultsdbpy/resultsdbpy/example/main.py: Added.
325         (health): Web-server health check.
326         (handle_errors):
327         (main): Run results database web-server.
328         * resultsdbpy/resultsdbpy/example/worker.py: Added.
329         (main): Asynchronously process uploaded results.
330         * resultsdbpy/resultsdbpy/run: Added.
331
332 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
333
334         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
335         https://bugs.webkit.org/show_bug.cgi?id=209004
336
337         Reviewed by Tim Horton.
338
339         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
340         `use_gpu_process` is specified.
341
342         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
343         (parse_args):
344
345 2020-03-12  Matt Lewis  <jlewis3@apple.com>
346
347         Make flatpack import for run-webkit-tests only happen on linux systems
348         https://bugs.webkit.org/show_bug.cgi?id=208954
349
350         Reviewed by Philippe Normand.
351
352         * Scripts/run-webkit-tests: Added an if statement to find the system platform
353         to determine if we need the flatpackutils import. 
354
355 2020-03-12  Alex Christensen  <achristensen@webkit.org>
356
357         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
358         https://bugs.webkit.org/show_bug.cgi?id=207609
359
360         Reviewed by Ryosuke Niwa.
361
362         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
363         (TestWebKitAPI::TEST):
364
365 2020-03-12  Daniel Bates  <dabates@apple.com>
366
367         FocusController::setFocusedElement() should tell client of refocused element
368         https://bugs.webkit.org/show_bug.cgi?id=208880
369
370         Reviewed by Wenson Hsieh.
371
372         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
373         to start an input session. Currently, it does not even try.
374
375         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
376         (TEST):
377
378 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
379
380         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
381         https://bugs.webkit.org/show_bug.cgi?id=208970
382
383         Reviewed by Daniel Bates.
384
385         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
386         #!/usr/bin/env python.
387
388         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
389         probably has similar rules.
390
391         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
392         Everything else that does so is probably only used by webkit-build.
393
394         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
395
396         * gtkdoc/generate-gtkdoc:
397
398 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
399
400         [WebAuthn] Formalize the Keychain schema
401         https://bugs.webkit.org/show_bug.cgi?id=183533
402         <rdar://problem/43347926>
403
404         Reviewed by Brent Fulgham.
405
406         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
407         the original combination of RP ID and user handle.
408
409         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
410         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
411         (WTR::TestRunner::cleanUpKeychain):
412         (WTR::TestRunner::keyExistsInKeychain):
413         * WebKitTestRunner/InjectedBundle/TestRunner.h:
414         * WebKitTestRunner/TestController.h:
415         * WebKitTestRunner/TestInvocation.cpp:
416         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
417         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
418         (WTR::TestController::cleanUpKeychain):
419         (WTR::TestController::keyExistsInKeychain):
420
421 2020-03-11  Keith Miller  <keith_miller@apple.com>
422
423         Test262-runner should always consider crashes as new failures
424         https://bugs.webkit.org/show_bug.cgi?id=208943
425
426         Reviewed by Yusuke Suzuki.
427
428         Right now the runner will consider crashes with no output as passes, which is obviously bad.
429         Since we should never crash on a conformance test we should consider a crash as a new failure
430         100% of the time.
431
432         * Scripts/test262/Runner.pm:
433         (processFile):
434         (runTest):
435         (processResult):
436
437 2020-03-11  Chris Dumez  <cdumez@apple.com>
438
439         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
440         https://bugs.webkit.org/show_bug.cgi?id=208927
441         <rdar://problem/55448331>
442
443         Reviewed by Alex Christensen.
444
445         Add API test coverage.
446
447         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
448
449 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
450
451         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
452         https://bugs.webkit.org/show_bug.cgi?id=208860
453
454         Reviewed by Carlos Alberto Lopez Perez.
455
456         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
457         (StatusBubble): Added 'api-gtk'.
458         * BuildSlaveSupport/ews-build/config.json:
459         * BuildSlaveSupport/ews-build/factories.py:
460         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
461         GTK.
462         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
463         GTK.
464         (GTKBuildFactory):
465         (GTKBuildFactory.__init__): Deleted.
466         (GTKBuildAndTestFactory): Deleted.
467         (GTKBuildAndTestFactory.__init__): Deleted.
468         (GTKAPIBuildAndTestFactory): Deleted.
469         * BuildSlaveSupport/ews-build/loadConfig.py:
470
471 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
472
473         [ews] Add unit test to prevent multiple schedulers for a builder.
474         https://bugs.webkit.org/show_bug.cgi?id=208917
475
476         Reviewed by Carlos Alberto Lopez Perez.
477
478         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
479         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
480         (TagsForBuilderTest): Fixed a typo.
481
482 2020-03-11 Philippe Normand  <pnormand@igalia.com>
483
484         [GTK] Failing API tests under the Flatpak SDK environment
485         https://bugs.webkit.org/show_bug.cgi?id=208871
486
487         Reviewed by Michael Catanzaro.
488
489         The load-failed signal callback should return a boolean result,
490         otherwise we enter in unknown territory depending on how the
491         toolchain compiles this, possibly triggering bad behavior (with
492         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
493         GCC toolchain on buildbots).
494
495         Patch suggested by Michael Catanzaro.
496
497         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
498         (loadFailedCallback):
499
500 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
501
502         Sync FeatureList.pm with CMake definitions
503         https://bugs.webkit.org/show_bug.cgi?id=208866
504
505         Reviewed by Michael Catanzaro.
506
507         * Scripts/webkitperl/FeatureList.pm:
508
509 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
510
511         [ews] Add unit tests for commit queue factory
512         https://bugs.webkit.org/show_bug.cgi?id=208862
513
514         Reviewed by Jonathan Bedard.
515
516         * BuildSlaveSupport/ews-build/factories_unittest.py:
517         (TestCommitQueueFactory):
518         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
519
520 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
521
522         [ews-app] Status bubble should only display important messages in pop-over - part 3
523         https://bugs.webkit.org/show_bug.cgi?id=208865
524
525         Reviewed by Jonathan Bedard.
526
527         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
528         (StatusBubble): Added more strings to STEPS_TO_HIDE.
529
530 2020-03-10  Lauro Moura  <lmoura@igalia.com>
531
532         [WPE] MiniBrowser: Close child WebViews when exiting
533         https://bugs.webkit.org/show_bug.cgi?id=208689
534
535         Reviewed by Carlos Garcia Campos.
536
537         Store created views so we can release them before exiting.
538
539         * MiniBrowser/wpe/main.cpp:
540         (webViewClose):
541         (createWebView):
542         (main):
543
544 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
545
546         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
547         https://bugs.webkit.org/show_bug.cgi?id=208861
548
549         Reviewed by Jonathan Bedard.
550
551         * BuildSlaveSupport/ews-build/factories.py:
552         (Factory.__init__): Remove verifycqplus parameter.
553         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
554         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
555         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
556
557 2020-03-10  Philippe Normand  <pnormand@igalia.com>
558
559         [GTK] API favicon test flaky timeouts
560         https://bugs.webkit.org/show_bug.cgi?id=208189
561
562         Reviewed by Carlos Garcia Campos.
563
564         Sometimes the favicon changes already during the load. Keeping
565         track of it in the WebView favicon property notification handler
566         gets us rid of the race.
567
568         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
569         (testFaviconDatabaseGetFavicon):
570
571 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
572
573         Generate commit-queue status bubble from new EWS
574         https://bugs.webkit.org/show_bug.cgi?id=208811
575
576         Reviewed by Jonathan Bedard.
577
578         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
579         (StatusBubble._build_bubbles_for_patch):
580
581 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
582
583         Remove obsolete feature flags
584         https://bugs.webkit.org/show_bug.cgi?id=208830
585
586         Reviewed by Alex Christensen.
587
588         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
589         are no longer used.
590
591         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
592         when the compilation flag was removed in r258148.
593
594         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
595         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
596
597         * Scripts/webkitperl/FeatureList.pm:
598         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
599
600 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
601
602         WebKitTestRunner bundleID should not be cleared before every test
603         https://bugs.webkit.org/show_bug.cgi?id=208823
604         <rdar://problem/60204539>
605
606         Reviewed by Per Arne Vollan.
607
608         This is causing test failures for layout tests which rely on the Info.plist 
609         bundle identifier (not the one set via the override method).
610
611         * WebKitTestRunner/TestController.cpp:
612         (WTR::TestController::createWebViewWithOptions):
613         (WTR::TestController::ensureViewSupportsOptionsForTest):
614         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
615
616 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
617
618         [macOS] Notification observer is not removed
619         https://bugs.webkit.org/show_bug.cgi?id=208834
620
621         Reviewed by Tim Horton.
622
623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
624         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
625         (TEST):
626
627 2020-03-06  Brian Burg  <bburg@apple.com>
628
629         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
630         https://bugs.webkit.org/show_bug.cgi?id=208729
631         <rdar://problem/60105447>
632
633         Reviewed by Jonathan Bedard.
634
635         Improve upload.py to look for the svn branch and revision for the 'webkit'
636         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
637
638         * Scripts/webkitpy/common/checkout/scm/git.py:
639         (Git):
640         (Git.git_svn_id_regexp):
641         (Git._field_from_git_svn_id):
642         (Git.svn_revision):
643         (Git.svn_branch):
644         (Git.svn_url):
645         (Git.native_branch):
646         Refactor svn revision, branch, url to use the same regexp and helper code.
647
648         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
649         (StubRepository.svn_branch):
650         Expose a stub since this is used unconditionally by Port.commits_for_upload.
651
652         * Scripts/webkitpy/common/checkout/scm/svn.py:
653         (SVN.svn_branch):
654         (SVN.native_revision):
655         (SVN):
656         (SVN.native_branch):
657         Refactor so the actual implementation is contained in svn_revision / svn_branch.
658         The native_* methods call out to the SVN equivalents since this is an SVN repository.
659
660         * Scripts/webkitpy/port/base.py:
661         (Port.commits_for_upload):
662         Add special git-svn handling for the WebKit repository so that SVN branch and revision
663         is preferred over the git equivalents.
664
665 2020-03-09  Antoine Quint  <graouts@apple.com>
666
667         TestWebKitAPI fails to build on watchOS
668         https://bugs.webkit.org/show_bug.cgi?id=208820
669
670         Reviewed by Tim Horton.
671
672         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
673
674 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
675
676         resultsdbpy: Add tool to manage resultsdbpy container
677         https://bugs.webkit.org/show_bug.cgi?id=208743
678
679         Rubber-stamped by Aakash Jain.
680
681         Add tool to start, stop and restart the resultsdbpy Docker container.
682
683         * resultsdbpy/resultsdbpy/container: Added.
684
685 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
686
687         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
688         https://bugs.webkit.org/show_bug.cgi?id=208706
689
690         Reviewed by Žan Doberšek.
691
692         Add test case to check surrounding text in multiline context.
693
694         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
695         (testWebKitInputMethodContextSurrounding):
696
697 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
698
699         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
700         https://bugs.webkit.org/show_bug.cgi?id=208783
701
702         Reviewed by Brent Fulgham.
703
704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
705
706 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
707
708         Replace the use of term "rollout" to "revert" in various tools
709         https://bugs.webkit.org/show_bug.cgi?id=208775
710
711         Reviewed by Ryosuke Niwa.
712
713         See this webkit-dev thread for the originating discussion:
714         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
715
716         'rollout' is a confusing term to anyone unacquainted with WebKit;
717         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
718
719         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
720         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
721
722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
729         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
730         * BuildSlaveSupport/ews-build/steps.py:
731         * BuildSlaveSupport/ews-build/steps_unittest.py:
732         * Scripts/webkit-tools-completion.sh:
733         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
734         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
735         * Scripts/webkitpy/common/checkout/scm/svn.py:
736         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
737         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
738         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
739         * Scripts/webkitpy/tool/bot/feeders.py:
740         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
741         * Scripts/webkitpy/tool/bot/irc_command.py:
742         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
743         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
744         * Scripts/webkitpy/tool/bot/sheriff.py:
745         * Scripts/webkitpy/tool/commands/download.py:
746         * Scripts/webkitpy/tool/commands/download_unittest.py:
747         * Scripts/webkitpy/tool/commands/newcommitbot.py:
748         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
749         * Scripts/webkitpy/tool/commands/queues_unittest.py:
750         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
751         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
752         * Scripts/webkitpy/tool/steps/__init__.py:
753         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
754         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
755         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
756         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
757
758 2020-03-07  David Quesada  <david_quesada@apple.com>
759
760         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
761         https://bugs.webkit.org/show_bug.cgi?id=208781
762         rdar://problem/60061016
763
764         Reviewed by Alex Christensen.
765
766         Add a test that recreates the conditions of this crash:
767         - Send a message from the injected bundle to the UI process that contains a reply block.
768         - Hold a reference to the reply block.
769         - Let the web view deallocate.
770         - Call the block, and expect not to crash.
771
772         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
773         (localObjectInterface):
774         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
775         (-[LocalObject doSomethingWithCompletionHandler:]):
776         (TEST):
777         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
778         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
779
780 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
781
782         TextManipulationController should work with ARIA labels
783         https://bugs.webkit.org/show_bug.cgi?id=208759
784
785         Reviewed by Wenson Hsieh.
786
787         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
788         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
789         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
790         the expected number of tokens for the first item as the very first image is correctly
791         detected per the code change. 
792         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
793
794 2020-03-07  Alex Christensen  <achristensen@webkit.org>
795
796         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
797         https://bugs.webkit.org/show_bug.cgi?id=208767
798
799         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
800         The frameID of the main frame before loading is only 0 on Mac right now.
801         The test is still good because it validates that execution works in the main frame before loading.
802
803 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
804
805         [ews] commit queue is not skipping layout tests for rollout patches
806         https://bugs.webkit.org/show_bug.cgi?id=208716
807
808         Unreviewed minor fix.
809
810         * BuildSlaveSupport/ews-build/steps.py:
811         (RunWebKitTests.doStepIf):
812         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
813         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
814
815 2020-03-05  Sam Weinig  <weinig@apple.com>
816
817         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
818         https://bugs.webkit.org/show_bug.cgi?id=207436
819         <rdar://problem/59296762>
820
821         Reviewed by Darin Adler.
822
823         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
824         Remove JSC related defines.
825
826 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
827
828         AX: Provide a way to run tests in isolated tree mode
829         https://bugs.webkit.org/show_bug.cgi?id=208629
830         <rdar://problem/60075583>
831
832         Reviewed by Ryosuke Niwa.
833
834         Provide the ability to run tests for accessibility in the isolated tree mode.
835         This sends a flag over to the injected bundle which calls the right HIServices override so that
836         the system thinks it is in isolated mode.
837
838         * Scripts/compare-webkit-configurations:
839         (flag_for_comparison):
840         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
841         (parse_args):
842         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
843         (parse_args):
844         * Scripts/webkitpy/port/driver.py:
845         (Driver.cmd_line):
846         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
847         (WTR::AccessibilityController::AccessibilityController):
848         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
849         (WTR::AccessibilityController::updateIsolatedTreeMode):
850         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
851         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
852         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
853         (WTR::InjectedBundle::didReceiveMessageToPage):
854         (WTR::InjectedBundle::beginTesting):
855         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
856         * WebKitTestRunner/Options.cpp:
857         (WTR::handleOptionAccessibilityIsolatedTreeMode):
858         (WTR::OptionsHandler::OptionsHandler):
859         * WebKitTestRunner/Options.h:
860         * WebKitTestRunner/TestController.cpp:
861         (WTR::TestController::initialize):
862         (WTR::TestController::resetPreferencesToConsistentValues):
863         (WTR::TestController::resetStateToConsistentValues):
864         * WebKitTestRunner/TestController.h:
865         (WTR::TestController::accessibilityIsolatedTreeMode const):
866
867 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
868
869         [Cocoa] Re-enable CFPrefs direct mode
870         https://bugs.webkit.org/show_bug.cgi?id=208690
871
872         Reviewed by Brent Fulgham.
873
874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
875         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
876         (TEST):
877         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
878         (TestWebKitAPI::TEST):
879
880 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
881
882         UIProcess needs mechanism to specify AppBound domains
883         https://bugs.webkit.org/show_bug.cgi?id=208528
884         <rdar://problem/59980340>
885
886         Reviewed by Brent Fulgham.
887
888         Added test app-bound domains to the plist and tested that the domains
889         are properly stored in the website data store after a navigation.
890
891         * TestWebKitAPI/Info.plist:
892         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
893         (TEST):
894
895 2020-03-06  Alex Christensen  <achristensen@webkit.org>
896
897         Add SPI to disable cross origin access control checks
898         https://bugs.webkit.org/show_bug.cgi?id=208748
899
900         Reviewed by Tim Hatcher.
901
902         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
903         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
904
905 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
906
907         [webkitpy] Fix executive on Windows to run wpt server correctly
908         https://bugs.webkit.org/show_bug.cgi?id=208693
909
910         Reviewed by Jonathan Bedard.
911
912         Bug fix for Windows environment a) fixing a typo. b) fixing path
913         c) fix how to kill subprocesses.
914
915         * Scripts/webkitpy/common/system/executive.py:
916         (Executive._windows_kill_command):
917         (Executive.interrupt):
918         (Executive.kill_all):
919         * Scripts/webkitpy/port/base.py:
920         (Port.web_platform_test_server_doc_root):
921
922 2020-03-06  Alex Christensen  <achristensen@webkit.org>
923
924         Evaluating JavaScript in main frame before loading should succeed
925         https://bugs.webkit.org/show_bug.cgi?id=208733
926
927         Reviewed by Tim Horton.
928
929         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
930
931 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
932
933         TextManipulationController should preserve images
934         https://bugs.webkit.org/show_bug.cgi?id=208692
935
936         Reviewed by Wenson Hsieh.
937
938         Added tests for preserving images and their ordering.
939
940         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
941         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
942         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
943         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
944
945 2020-03-06  David Quesada  <david_quesada@apple.com>
946
947         Add _WKResourceLoadInfo.resourceType SPI
948         https://bugs.webkit.org/show_bug.cgi?id=208723
949
950         Reviewed by Alex Christensen.
951
952         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
953         (TEST):
954
955 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
956
957         Stop reporting to webkit-test-results.webkit.org
958         https://bugs.webkit.org/show_bug.cgi?id=207218
959
960         Reviewed by Alexey Proskuryakov.
961
962         * BuildSlaveSupport/build.webkit.org-config/steps.py:
963         (RunWebKitTests):
964
965 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
966
967         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
968         https://bugs.webkit.org/show_bug.cgi?id=208365
969         <rdar://problem/59877296>
970
971         Reviewed by Geoffrey Garen.
972
973         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
974         (TEST):
975
976 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
977
978         EWS should be able to fetch patch status for security bugs while processing them
979         https://bugs.webkit.org/show_bug.cgi?id=206511
980
981         Reviewed by Alexey Proskuryakov.
982
983         * BuildSlaveSupport/ews-build/steps.py:
984         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
985         (BugzillaMixin.get_patch_json): 
986         (BugzillaMixin.get_bug_json):
987         (BugzillaMixin._is_bug_closed):
988         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
989         (TransferToS3.hideStepIf): Ditto.
990
991 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
992
993         [ews] commit-queue should show the trac url for the commit on the build page
994         https://bugs.webkit.org/show_bug.cgi?id=208715
995
996         Reviewed by Jonathan Bedard.
997
998         * BuildSlaveSupport/ews-build/steps.py:
999         (PushCommitToWebKitRepo.evaluateCommand):
1000
1001 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1002
1003         Fix ResourceLoadDelegate.LoadInfo API test after r257816
1004         https://bugs.webkit.org/show_bug.cgi?id=208550
1005
1006         * TestWebKitAPI/cocoa/HTTPServer.mm:
1007         (TestWebKitAPI::HTTPServer::respondToRequests):
1008         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1009         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1010
1011 2020-03-06  Lauro Moura <lmoura@igalia.com>
1012
1013         [WPE][WebDriver] MiniBrowser should react to close session commands
1014         https://bugs.webkit.org/show_bug.cgi?id=207529
1015
1016         Reviewed by Carlos Garcia Campos.
1017
1018         Do not call g_object_unref on the first created view if it has already
1019         been disposed in the "close" signal handler.
1020
1021         Based on original patch by Yury Semikhatsky.
1022
1023         * MiniBrowser/wpe/main.cpp:
1024         (main):
1025
1026 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1027
1028         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1029         https://bugs.webkit.org/show_bug.cgi?id=208647
1030
1031         Reviewed by Carlos Garcia Campos.
1032
1033         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1034         (TestWebKitAPI::TEST):
1035
1036 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1037
1038         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1039         https://bugs.webkit.org/show_bug.cgi?id=208670
1040
1041         Reviewed by Brady Eidson.
1042
1043         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1044         (-[FrameNavigationDelegate waitForNavigations:]):
1045         (-[FrameNavigationDelegate requests]):
1046         (-[FrameNavigationDelegate frames]):
1047         (-[FrameNavigationDelegate callbacks]):
1048         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1049         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1050         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1051         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1052         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1053         (TEST):
1054
1055 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1056
1057         Add WKFrameInfo._parentFrameHandle SPI
1058         https://bugs.webkit.org/show_bug.cgi?id=208674
1059
1060         Reviewed by Brady Eidson.
1061
1062         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1063
1064 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1065
1066         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1067         https://bugs.webkit.org/show_bug.cgi?id=208626
1068         <rdar://problem/60074148>
1069
1070         Reviewed by Brent Fulgham.
1071
1072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1073         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1074         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1075         (TestWebKitAPI::TEST):
1076         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1077         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1078         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1079
1080 2020-03-05  Antoine Quint  <graouts@apple.com>
1081
1082         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1083         https://bugs.webkit.org/show_bug.cgi?id=208644
1084         <rdar://problem/60042429>
1085
1086         Reviewed by Brady Eidson.
1087
1088         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1089         
1090         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1091            empty document has been removed in favor of the document for the requested URL,
1092         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1093            correctly does not injected the style sheet.
1094
1095         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1096
1097 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1098
1099         [ews] Add build step to push commit to WebKit repository
1100         https://bugs.webkit.org/show_bug.cgi?id=208589
1101
1102         Reviewed by Jonathan Bedard.
1103
1104         * BuildSlaveSupport/ews-build/steps.py:
1105         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1106         (PushCommitToWebKitRepo.start): Initialize log observer.
1107         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1108         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1109         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1110         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1111         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1112         * BuildSlaveSupport/ews-build/factories.py:
1113
1114 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1115
1116         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1117         https://bugs.webkit.org/show_bug.cgi?id=208262
1118
1119         Reviewed by Jonathan Bedard.
1120
1121         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1122
1123 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1124
1125         commit-queue should run WK2 tests instead of WK1 tests
1126         https://bugs.webkit.org/show_bug.cgi?id=208544
1127
1128         Reviewed by Jonathan Bedard.
1129
1130         * BuildSlaveSupport/ews-build/factories.py:
1131
1132 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1133
1134         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
1135         https://bugs.webkit.org/show_bug.cgi?id=208645
1136
1137         Reviewed by Alexey Proskuryakov.
1138
1139         * BuildSlaveSupport/ews-build/steps.py:
1140         (ValidateCommiterAndReviewer.load_contributors):
1141         (ValidateCommiterAndReviewer.start):
1142
1143 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1144
1145         style-checker: Add UAF to the list of security words to warn about.
1146         https://bugs.webkit.org/show_bug.cgi?id=208643
1147
1148         Reviewed by Jonathan Bedard.
1149
1150         UAF is a common acronym used for use after free.
1151
1152         * Scripts/webkitpy/style/checkers/changelog.py:
1153         (ChangeLogChecker.check_for_unwanted_security_phrases):
1154
1155 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
1156
1157         [MSVC] Add .natvis support of WebKit types
1158         https://bugs.webkit.org/show_bug.cgi?id=193119
1159
1160         Reviewed by Don Olmstead.
1161
1162         To help the WebKit developer while debugging, this file defines how
1163         WebKit types are displayed in debugger of Visual Studio.
1164         Very limited set of WebKit types, but it changes the world.
1165
1166         * VisualStudio/WebKit.natvis: Added.
1167
1168 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1169
1170         Add system trace points around display list replay
1171         https://bugs.webkit.org/show_bug.cgi?id=208616
1172
1173         Reviewed by Simon Fraser.
1174
1175         Add a new "Display list replay" trace point.
1176
1177         * Tracing/SystemTracePoints.plist:
1178
1179 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1180
1181         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
1182         https://bugs.webkit.org/show_bug.cgi?id=208615
1183         <rdar://problem/59406743>
1184
1185         Reviewed by Alex Christensen.
1186
1187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1188         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
1189         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1190         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1191         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1192         (TEST):
1193         Also make a test written in bug 206310 actually run code.
1194
1195 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1196
1197         [build.webkit.org] Remove leaks queue
1198         https://bugs.webkit.org/show_bug.cgi?id=208580
1199
1200         Reviewed by Jonathan Bedard.
1201
1202         * BuildSlaveSupport/build.webkit.org-config/config.json:
1203         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1205
1206 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1207
1208         Add SPI to evaluate JavaScript in an iframe
1209         https://bugs.webkit.org/show_bug.cgi?id=208605
1210
1211         Reviewed by Brady Eidson.
1212
1213         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1214
1215 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
1216
1217         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
1218         https://bugs.webkit.org/show_bug.cgi?id=208533
1219         <rdar://problem/60010184>
1220
1221         Reviewed by Alex Christensen.
1222
1223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1224         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1225         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
1226         (TestWebKitAPI::TEST):
1227         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
1228         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
1229
1230 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1231
1232         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
1233         https://bugs.webkit.org/show_bug.cgi?id=208593
1234
1235         Reviewed by Brady Eidson.
1236
1237         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1238         (TestWebKitAPI::TEST):
1239
1240 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1241
1242         WKWebView's frames accessor should return a traversable type
1243         https://bugs.webkit.org/show_bug.cgi?id=208591
1244
1245         Reviewed by Brady Eidson.
1246
1247         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1248
1249 2020-03-04  Antoine Quint  <graouts@apple.com>
1250
1251         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
1252         https://bugs.webkit.org/show_bug.cgi?id=208575
1253         <rdar://problem/59773690>
1254
1255         Reviewed by Brady Eidson.
1256
1257         Add new tests for the new SPI which check:
1258         
1259         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
1260            specified WKWebView alone,
1261         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
1262         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
1263         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
1264         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
1265         6. and that the same test also works with PSON enabled.
1266
1267         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1268
1269 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
1270
1271         [macOS] test-lldb-webkit failing on debug bots
1272         https://bugs.webkit.org/show_bug.cgi?id=208545
1273
1274         Reviewed by Jonathan Bedard.
1275
1276         The lldb-webkit-test step must pass in the build configuration as an
1277         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
1278         binary that is downloaded with the rest of the build products. Without this
1279         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
1280         regardless of their actual build configuration.
1281
1282         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1283         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
1284         * Scripts/test-lldb-webkit:
1285         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
1286
1287 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1288
1289         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
1290         https://bugs.webkit.org/show_bug.cgi?id=208539
1291
1292         Unreviewed follow-up fix.
1293
1294         * BuildSlaveSupport/ews-build/steps.py:
1295
1296 2020-03-04  Daniel Bates  <dabates@apple.com>
1297
1298         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
1299         https://bugs.webkit.org/show_bug.cgi?id=208565
1300
1301         Reviewed by Wenson Hsieh.
1302
1303         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
1304         of its frame as a means to find all the editable elements in the visible content area
1305         of the web view.
1306
1307         Coincidentally this makes no difference to the test results right now because the web view
1308         happens to be located at the origin (0, 0) in the window. However if in the future the
1309         web view would be located at some other point then the tests may fail because the rectangle
1310         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
1311         rectangle for the visible content area.
1312
1313         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1314         (TEST):
1315
1316 2020-03-04  Daniel Bates  <dabates@apple.com>
1317
1318         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
1319         https://bugs.webkit.org/show_bug.cgi?id=208564
1320
1321         Reviewed by Alex Christensen.
1322
1323         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
1324         to make it easy to run just these tests.
1325
1326         Currently, the tests are organized under the test case name WebKit. This means you need to
1327         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
1328         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
1329         so that a person can run just these test using:
1330         
1331                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
1332
1333         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1334         (TEST):
1335
1336 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1337
1338         [ews] Add build step to create local git commit for commit-queue
1339         https://bugs.webkit.org/show_bug.cgi?id=208539
1340
1341         Reviewed by Jonathan Bedard.
1342
1343         * BuildSlaveSupport/ews-build/steps.py:
1344         (CreateLocalGITCommit): Build step to create local git commit.
1345         (CreateLocalGITCommit.start):
1346         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
1347         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
1348         * BuildSlaveSupport/ews-build/factories.py:
1349
1350 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
1351
1352         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
1353         https://bugs.webkit.org/show_bug.cgi?id=207948
1354
1355         Reviewed by Zalan Bujtas.
1356
1357         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
1358         so that it receives the wheel events.
1359
1360         * DumpRenderTree/mac/EventSendingController.mm:
1361         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1362         * DumpRenderTree/win/EventSender.cpp:
1363         (mouseScrollBy):
1364
1365 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
1366
1367         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
1368         https://bugs.webkit.org/show_bug.cgi?id=208520
1369         <rdar://problem/60000214>
1370
1371         Reviewed by Chris Fleizach.
1372
1373         Calling InjectedBundle::singleton().page()->page() in the constructor
1374         of the AccessibilityController is having this side effect on iOS.
1375         So #if to MAC where it's actually being used.
1376
1377         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1378         (WTR::AccessibilityController::AccessibilityController):
1379
1380 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1381
1382         Add SPI _WKResourceLoadInfo.loadedFromCache
1383         https://bugs.webkit.org/show_bug.cgi?id=208554
1384
1385         Reviewed by Wenson Hsieh.
1386
1387         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1388         (TEST):
1389
1390 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1391
1392         Batch observations and completions of text manipulations
1393         https://bugs.webkit.org/show_bug.cgi?id=208406
1394
1395         Reviewed by Wenson Hsieh.
1396
1397         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
1398         multiple paragraphs at once.
1399
1400         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1401         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
1402         (-[TextManipulationDelegate items]):
1403         (-[LegacyTextManipulationDelegate init]):
1404         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
1405         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
1406         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
1407         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
1408         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
1409         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
1410         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
1411
1412 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
1413
1414         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1415         https://bugs.webkit.org/show_bug.cgi?id=208415
1416
1417         Reviewed by Brent Fulgham.
1418
1419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1420         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1421         (TEST):
1422
1423 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1424
1425         Add response to _WKResourceLoadDelegate didCompleteWithError callback
1426         https://bugs.webkit.org/show_bug.cgi?id=208553
1427
1428         Reviewed by Simon Fraser.
1429
1430         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1431         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
1432         (TEST):
1433         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
1434
1435 2020-03-03  Brady Eidson  <beidson@apple.com>
1436
1437         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
1438         https://bugs.webkit.org/show_bug.cgi?id=198795
1439
1440         Reviewed by Chris Dumez.
1441
1442         This test appears to no longer be flaky.
1443         
1444         Let's re-enable it.
1445         
1446         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1447         (TestWebKitAPI::TEST):
1448
1449 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1450
1451         Requests sent to _WKResourceLoadDelegate should include HTTPBody
1452         https://bugs.webkit.org/show_bug.cgi?id=208550
1453
1454         Reviewed by Tim Hatcher.
1455
1456         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1457         (TEST):
1458         * TestWebKitAPI/cocoa/HTTPServer.mm:
1459         (TestWebKitAPI::HTTPServer::respondToRequests):
1460         HTTPServer now looks for Content-Length in its request.
1461         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
1462
1463 2020-03-03  Alex Christensen  <achristensen@webkit.org>
1464
1465         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
1466         https://bugs.webkit.org/show_bug.cgi?id=208522
1467
1468         Reviewed by Brian Weinstein.
1469
1470         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1471         (TEST):
1472
1473 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1474
1475         commit-queue should update working directory and reapply patch just before commiting
1476         https://bugs.webkit.org/show_bug.cgi?id=208521
1477
1478         Reviewed by Jonathan Bedard.
1479
1480         * BuildSlaveSupport/ews-build/factories.py:
1481
1482 2020-03-03  Matt Lewis  <jlewis3@apple.com>
1483
1484         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
1485         https://bugs.webkit.org/show_bug.cgi?id=208485
1486
1487         Reviewed by Jonathan Bedard.
1488
1489         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1490         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
1491         that we don't have to recreate the variables that are already created.
1492         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
1493         from each module, rather than making extra imports that we don't need.
1494         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
1495         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
1496         and not part of the host.
1497         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
1498         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
1499         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
1500         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
1501         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
1502         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
1503         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
1504         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
1505         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
1506         if we were geting any value at all
1507         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
1508         sure we aren't gabking the wrong key:value pair
1509         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
1510         come with the MockHosts and MockHost inherits from MockSystemHost.
1511         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
1512         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
1513         to the various upload steps.
1514
1515 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
1516
1517         [ews] Add build step to find list of modified changelogs
1518         https://bugs.webkit.org/show_bug.cgi?id=208514
1519
1520         Reviewed by Jonathan Bedard.
1521
1522         * BuildSlaveSupport/ews-build/factories.py:
1523         * BuildSlaveSupport/ews-build/steps.py:
1524         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
1525         (FindModifiedChangeLogs.start): Initialize log observer.
1526         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
1527         (FindModifiedChangeLogs.evaluateCommand):
1528         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
1529         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
1530         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
1531         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1532
1533 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
1534
1535         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
1536         https://bugs.webkit.org/show_bug.cgi?id=208451
1537
1538         Unreviewed test gardening.
1539
1540         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
1541
1542 2020-03-03  Jiten Mehta  <jmehta@apple.com>
1543
1544         Adopt HTTP Alternative Services Storage
1545         https://bugs.webkit.org/show_bug.cgi?id=208387
1546
1547         Reviewed by Alex Christensen.
1548
1549         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1550         (checkUntilEntryFound):
1551         (TEST):
1552
1553 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
1554
1555         Check for navigation to app-bound domain during script evaluation
1556         https://bugs.webkit.org/show_bug.cgi?id=208319
1557         <rdar://problem/57569321>
1558
1559         Reviewed by Brent Fulgham.
1560
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
1563         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1564         (TEST):
1565         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
1566         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
1567
1568 2020-03-03  Commit Queue  <commit-queue@webkit.org>
1569
1570         Unreviewed, rolling out r257754.
1571         https://bugs.webkit.org/show_bug.cgi?id=208513
1572
1573         Introduced API test failure (Requested by perarne on #webkit).
1574
1575         Reverted changeset:
1576
1577         "[Cocoa] Mapping from MIME type to UTI type should be done in
1578         the UI process"
1579         https://bugs.webkit.org/show_bug.cgi?id=208415
1580         https://trac.webkit.org/changeset/257754
1581
1582 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
1583
1584         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
1585         https://bugs.webkit.org/show_bug.cgi?id=208506
1586
1587         Reviewed by Carlos Garcia Campos.
1588
1589         * WebKitTestRunner/TestController.cpp:
1590         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
1591
1592 2020-03-02  Ben Nham  <nham@apple.com>
1593
1594         Add performance probes for HTML parsing
1595         https://bugs.webkit.org/show_bug.cgi?id=208271
1596
1597         Reviewed by Daniel Bates.
1598
1599         This adds probes that show which lines of HTML are have been parsed.
1600
1601         * Tracing/SystemTracePoints.plist:
1602
1603 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1604
1605         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1606         https://bugs.webkit.org/show_bug.cgi?id=208415
1607
1608         Reviewed by Brent Fulgham.
1609
1610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1611         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1612         (TEST):
1613
1614 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1615
1616         Unreviewed, rolling out r257725.
1617
1618         This commit caused 10 API tests to fail
1619
1620         Reverted changeset:
1621
1622         "[Cocoa] Mapping from MIME type to UTI type should be done in
1623         the UI process"
1624         https://bugs.webkit.org/show_bug.cgi?id=208415
1625         https://trac.webkit.org/changeset/257725
1626
1627 2020-03-02  Saam Barati  <sbarati@apple.com>
1628
1629         Don't skip tests unnecessarily on arm64
1630         https://bugs.webkit.org/show_bug.cgi?id=208470
1631         <rdar://problem/59968869>
1632
1633         Reviewed by Tadeu Zagallo.
1634
1635         * Scripts/run-jsc-stress-tests:
1636
1637 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
1638
1639         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
1640         https://bugs.webkit.org/show_bug.cgi?id=208434
1641
1642         Reviewed by Chris Fleizach.
1643
1644         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1645         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
1646         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
1647         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1648         (WTR::AccessibilityController::accessibleElementById): Same as above.
1649
1650 2020-03-02  John Wilander  <wilander@apple.com>
1651
1652         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
1653         https://bugs.webkit.org/show_bug.cgi?id=208399
1654         <rdar://problem/24731650>
1655
1656         Reviewed by Brent Fulgham.
1657
1658         The majority of the changes in WTR::TestController is (partially) fixing a bug
1659         where the TestRunner would statically use the default website datastore instead
1660         of the website data store configure for the page. This worked for persistent
1661         storage testing but not for ephemeral sessions which is what this patch is all
1662         about. The previous TestController::websiteDataStore() is now called
1663         TestController::defaultWebsiteDataStore() and the new
1664         TestController::websiteDataStore() returns the configured website data store.
1665         Most of the use of the default website data store should probably change but
1666         that's not really for this patch to deal with. I did however move all of
1667         resource load statistics' use to the new TestController::websiteDataStore().
1668
1669         A new TestRunner function was added: isStatisticsEphemeral()
1670         It allows test cases to query the ephemeral status of resource load statistics.
1671
1672         One problem that is mitigated in this patch but not fully fixed is that for
1673         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
1674         TestController::generatePageConfiguration() via C API 
1675         WKPageConfigurationSetWebsiteDataStore(), and then again in 
1676         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
1677         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
1678         I tried removing the latter since one session for all platforms should be
1679         Enough but got broken behavior as a result. So now both are still there
1680         and both enable resource load statistics.
1681
1682         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1683         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1684         (WTR::TestRunner::isStatisticsEphemeral):
1685         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1686         * WebKitTestRunner/TestController.cpp:
1687         (WTR::TestController::defaultWebsiteDataStore):
1688         (WTR::TestController::websiteDataStore):
1689         (WTR::TestController::generatePageConfiguration):
1690         (WTR::TestController::resetPreferencesToConsistentValues):
1691         (WTR::TestController::resetStateToConsistentValues):
1692         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1693         (WTR::TestController::decidePolicyForNavigationAction):
1694         (WTR::TestController::platformAdjustContext):
1695         (WTR::TestController::clearServiceWorkerRegistrations):
1696         (WTR::TestController::clearDOMCache):
1697         (WTR::TestController::clearDOMCaches):
1698         (WTR::TestController::clearIndexedDatabases):
1699         (WTR::TestController::clearLocalStorage):
1700         (WTR::TestController::hasDOMCache):
1701         (WTR::TestController::domCacheSize):
1702         (WTR::TestController::setStatisticsEnabled):
1703         (WTR::TestController::isStatisticsEphemeral):
1704         (WTR::TestController::setStatisticsDebugMode):
1705         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1706         (WTR::TestController::setStatisticsLastSeen):
1707         (WTR::TestController::setStatisticsMergeStatistic):
1708         (WTR::TestController::setStatisticsPrevalentResource):
1709         (WTR::TestController::setStatisticsVeryPrevalentResource):
1710         (WTR::TestController::dumpResourceLoadStatistics):
1711         (WTR::TestController::isStatisticsPrevalentResource):
1712         (WTR::TestController::isStatisticsVeryPrevalentResource):
1713         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1714         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1715         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1716         (WTR::TestController::setStatisticsHasHadUserInteraction):
1717         (WTR::TestController::isStatisticsHasHadUserInteraction):
1718         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
1719         (WTR::TestController::setStatisticsGrandfathered):
1720         (WTR::TestController::isStatisticsGrandfathered):
1721         (WTR::TestController::setUseITPDatabase):
1722         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1723         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1724         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1725         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1726         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1727         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1728         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1729         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1730         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1731         (WTR::TestController::statisticsUpdateCookieBlocking):
1732         (WTR::TestController::statisticsSubmitTelemetry):
1733         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1734         (WTR::TestController::setStatisticsIsRunningTest):
1735         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1736         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1737         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1738         (WTR::TestController::setStatisticsGrandfatheringTime):
1739         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1740         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1741         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1742         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1743         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1744         (WTR::TestController::statisticsDeleteCookiesForHost):
1745         (WTR::TestController::isStatisticsHasLocalStorage):
1746         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1747         (WTR::TestController::hasStatisticsIsolatedSession):
1748         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
1749         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
1750         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
1751         (WTR::TestController::statisticsResetToConsistentState):
1752         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1753         * WebKitTestRunner/TestController.h:
1754         * WebKitTestRunner/TestInvocation.cpp:
1755         (WTR::TestInvocation::invoke):
1756         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1757         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1758         (WTR::initializeWebViewConfiguration):
1759         (WTR::TestController::platformCreateWebView):
1760
1761 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
1762
1763         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1764         https://bugs.webkit.org/show_bug.cgi?id=208415
1765
1766         Reviewed by Brent Fulgham.
1767
1768         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1769         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1770         (TEST):
1771
1772 2020-03-02  Daniel Bates  <dabates@apple.com>
1773
1774         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
1775         https://bugs.webkit.org/show_bug.cgi?id=208352
1776         <rdar://problem/59867815>
1777
1778         Reviewed by Wenson Hsieh.
1779
1780         Update test results to reflect the new behavior. To do this I also need to fix up the test code
1781         to actually scroll the web content. This also means we now execute the same code on both Mac and
1782         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
1783         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
1784         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
1785
1786         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1787         (TEST):
1788
1789 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
1790
1791         Unreviewed, rolling out r257687.
1792
1793         This commit caused debug tests to crash for macOS & iOS
1794
1795         Reverted changeset:
1796
1797         "[Cocoa] Mapping from MIME type to UTI type should be done in
1798         the UI process"
1799         https://bugs.webkit.org/show_bug.cgi?id=208415
1800         https://trac.webkit.org/changeset/257687
1801
1802 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1803
1804         Unreviewed, rolling out r257618.
1805
1806         This allegedly causes Safari to crash when closing a window
1807         (see rdar://problem/59922725).
1808
1809         Reverted changeset:
1810
1811         "UIProcess crash after using _prepareForMoveToWindow, then
1812         deallocating the WKWebView before moving to the window"
1813         https://bugs.webkit.org/show_bug.cgi?id=208365
1814         https://trac.webkit.org/changeset/257618
1815
1816 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
1817
1818         Remove std::lock_guard
1819         https://bugs.webkit.org/show_bug.cgi?id=206451
1820
1821         Reviewed by Anders Carlsson.
1822
1823         Add std::lock_guard lint rule to prevent from using it.
1824
1825         * Scripts/webkitpy/style/checkers/cpp.py:
1826         (check_lock_guard):
1827         (check_style):
1828         (CppChecker):
1829         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1830         (WebKitStyleTest.test_lock_guard):
1831         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1832         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1833         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1834         (assertHasObjects):
1835         (assertHasOnlyObjects):
1836         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1837         (WTR::AXThread::dispatch):
1838         (WTR::AXThread::dispatchFunctionsFromAXThread):
1839         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1840         (WTR::AXThread::initializeRunLoop):
1841
1842 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
1843
1844         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
1845         https://bugs.webkit.org/show_bug.cgi?id=208415
1846
1847         Reviewed by Brent Fulgham.
1848
1849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1850         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
1851         (TEST):
1852
1853 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1854
1855         Unreviewed, rolling out r257565.
1856
1857         It broke WinCairo MiniBrowser
1858
1859         Reverted changeset:
1860
1861         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
1862         https://bugs.webkit.org/show_bug.cgi?id=206894
1863         https://trac.webkit.org/changeset/257565
1864
1865 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1866
1867         EWS fails to retry build in case of kill-old-processes exception
1868         https://bugs.webkit.org/show_bug.cgi?id=208003
1869
1870         Reviewed by Jonathan Bedard.
1871
1872         * BuildSlaveSupport/ews-build/steps.py:
1873         (KillOldProcesses.evaluateCommand):
1874         (KillOldProcesses.getResultSummary):
1875
1876 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1877
1878         [ews] commit-queue should update the ChangeLog with Reviewer name
1879         https://bugs.webkit.org/show_bug.cgi?id=206535
1880
1881         Reviewed by Jonathan Bedard.
1882
1883         * BuildSlaveSupport/ews-build/steps.py:
1884         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
1885
1886 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
1887
1888         run-javascriptcore-tests: Make upload format valid
1889         https://bugs.webkit.org/show_bug.cgi?id=208341
1890
1891         Rubber-stamped by Aakash Jain.
1892
1893         * Scripts/run-javascriptcore-tests:
1894         (uploadResults): Remove. FIXME.
1895         * Scripts/webkitdirs.pm:
1896         (splitVersionString): Handle case where the subminor version number has a - in it.
1897         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
1898
1899 2020-02-28  youenn fablet  <youenn@apple.com>
1900
1901         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
1902         https://bugs.webkit.org/show_bug.cgi?id=208130
1903
1904         Reviewed by Eric Carlson.
1905
1906         * WebKitTestRunner/TestOptions.h:
1907         Use GPU process to capture by default.
1908         We will remove this option once done verifying that every test works smoothly.
1909
1910 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
1911
1912         [ews] commit queue should skip building and testing for rollout patches
1913         https://bugs.webkit.org/show_bug.cgi?id=208329
1914
1915         Reviewed by Jonathan Bedard.
1916
1917         * BuildSlaveSupport/ews-build/steps.py:
1918         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
1919         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
1920         (RunWebKit1Tests.doStepIf): Ditto.
1921         * BuildSlaveSupport/ews-build/steps_unittest.py:
1922         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
1923         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
1924
1925 2020-02-28  Daniel Bates  <dabates@apple.com>
1926
1927         Update my watch list preferences and contributor's entry.
1928
1929         * Scripts/webkitpy/common/config/contributors.json:
1930         * Scripts/webkitpy/common/config/watchlist:
1931
1932 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
1933
1934         Fix WebCore export macros for declspec
1935         https://bugs.webkit.org/show_bug.cgi?id=208363
1936
1937         Reviewed by Konstantin Tokarev.
1938
1939         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
1940         files. Removed precompiled headers that were empty.
1941
1942         * DumpRenderTree/DumpRenderTreePrefix.h:
1943         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
1944         * MiniBrowser/win/stdafx.h:
1945         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
1946         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
1947         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
1948         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
1949         * WebKitTestRunner/PlatformFTW.cmake:
1950         * WebKitTestRunner/PlatformWin.cmake:
1951         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1952
1953 2020-02-27  Tim Horton  <timothy_horton@apple.com>
1954
1955         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1956         https://bugs.webkit.org/show_bug.cgi?id=208365
1957
1958         Reviewed by Alex Christensen.
1959
1960         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1961         (TEST):
1962         Add a test! It was a 100% repro crash before this change.
1963
1964 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
1965
1966         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
1967         https://bugs.webkit.org/show_bug.cgi?id=208260
1968         <rdar://problem/59820107>
1969
1970         Reviewed by Tim Horton.
1971
1972         Followed instructions for adding an Info.plist for Single-File Tools
1973         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
1974
1975         The default WebsiteDataStore file path will change with this test to
1976         reflect the new bundleID so we must change expectations for any api
1977         tests which rely on knowing the path.
1978
1979         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1981         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
1982         (TEST):
1983         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1984         (TEST):
1985         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
1986         (TEST):
1987         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
1988         (TEST):
1989         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1990         (TEST):
1991         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1992         (TEST):
1993         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
1994         (TEST):
1995         (defaultWebsiteCacheDirectory):
1996         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
1997         (TEST):
1998         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1999         (TEST):
2000         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2001         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2002         (TEST):
2003         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2004         (TEST):
2005         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2006         (runWebsiteDataStoreCustomPaths):
2007         (TEST):
2008         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2009         (TestWebKitAPI::resetTestState):
2010         Now that we set a bundleID, we have to reset the cache model between
2011         tests, otherwise it gets stored between tests.
2012
2013         (TestWebKitAPI::TEST):
2014         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2015         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2016
2017 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2018
2019         TextManipulationController should not generate a new item for content in manipulated paragraphs
2020         https://bugs.webkit.org/show_bug.cgi?id=208286
2021
2022         Reviewed by Wenson Hsieh.
2023
2024         Added a regression test.
2025
2026         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2027         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2028
2029 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2030
2031         run-javascriptcore-tests: Make upload format valid
2032         https://bugs.webkit.org/show_bug.cgi?id=208341
2033
2034         Reviewed by Aakash Jain.
2035
2036         * Scripts/run-javascriptcore-tests:
2037         (uploadResults): Print json blob for upload after failure for debugging.
2038
2039 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2040
2041         [CMake] Add WebKit::PAL target
2042         https://bugs.webkit.org/show_bug.cgi?id=198493
2043
2044         Reviewed by Michael Catanzaro.
2045
2046         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2047
2048         * DumpRenderTree/PlatformWin.cmake:
2049
2050 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2051
2052         Add SPI to query WKFrameInfos in a WKWebView
2053         https://bugs.webkit.org/show_bug.cgi?id=208212
2054
2055         Reviewed by Brady Eidson.
2056
2057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2058         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2059         * WebKitTestRunner/TestController.cpp:
2060         (WTR::TestController::saltForOrigin):
2061
2062 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2063
2064         Unreviewed, rolling out r257530.
2065
2066         This commit seems to have broke the build internally for
2067         watchOS
2068
2069         Reverted changeset:
2070
2071         "Add SPI to query WKFrameInfos in a WKWebView"
2072         https://bugs.webkit.org/show_bug.cgi?id=208212
2073         https://trac.webkit.org/changeset/257530
2074
2075 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2076
2077         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2078         https://bugs.webkit.org/show_bug.cgi?id=206894
2079
2080         Reviewed by Adrian Perez de Castro.
2081
2082         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2083         MiniBrowsers.
2084
2085         * MiniBrowser/gtk/CMakeLists.txt:
2086         * MiniBrowser/win/CMakeLists.txt:
2087         * MiniBrowser/wpe/CMakeLists.txt:
2088
2089 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2090
2091         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2092         https://bugs.webkit.org/show_bug.cgi?id=206456
2093
2094         Reviewed by Brady Eidson.
2095
2096         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2097         (TEST):
2098
2099 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2100
2101         _WKUserContentWorld should be a wrapper around WKContentWorld
2102         https://bugs.webkit.org/show_bug.cgi?id=208274
2103
2104         Reviewed by Brady Eidson.
2105
2106         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2107         (TEST):
2108         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2109         (TEST):
2110
2111 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2112
2113         Unreviewed, rolling out r257522.
2114
2115         Caused 16 API test failures on the bots
2116
2117         Reverted changeset:
2118
2119         "TestWebKitAPI and WebKitTestRunner should have bundle
2120         identifiers"
2121         https://bugs.webkit.org/show_bug.cgi?id=208260
2122         https://trac.webkit.org/changeset/257522
2123
2124 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2125
2126         Add SPI to query WKFrameInfos in a WKWebView
2127         https://bugs.webkit.org/show_bug.cgi?id=208212
2128
2129         Reviewed by Brady Eidson.
2130
2131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2132         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2133         * WebKitTestRunner/TestController.cpp:
2134         (WTR::TestController::saltForOrigin):
2135
2136 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2137
2138         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2139         https://bugs.webkit.org/show_bug.cgi?id=208260
2140         <rdar://problem/59820107>
2141
2142         Reviewed by Tim Horton.
2143
2144         Followed instructions for adding an Info.plist for Single-File Tools
2145         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2146
2147         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2148         * TestWebKitAPI/Info.plist: Added.
2149         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2150         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2151         * WebKitTestRunner/Info.plist: Added.
2152         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2153
2154 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2155
2156         Tests should each use a unique ResourceLoadStatistics file path for its database store
2157         https://bugs.webkit.org/show_bug.cgi?id=208206
2158         <rdar://problem/59690272>
2159
2160         Reviewed by Brady Eidson.
2161
2162         Initialize a default website data store before checking for the ITP
2163         store to ensure the directory exists after the file has been deleted.
2164
2165         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2166         (TEST):
2167
2168 2020-02-26  Christopher Reid  <chris.reid@sony.com>
2169
2170         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
2171         https://bugs.webkit.org/show_bug.cgi?id=197684
2172         <rdar://problem/59467397>
2173
2174         Reviewed by Yusuke Suzuki.
2175
2176         Add test for FileSystem::createFile
2177
2178         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2179
2180 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
2181
2182         [ews] commit-queue should verify patch committer and reviewer
2183         https://bugs.webkit.org/show_bug.cgi?id=206532
2184
2185         Reviewed by Jonathan Bedard.
2186
2187         * BuildSlaveSupport/ews-build/steps.py:
2188         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
2189         (ValidateCommiterAndReviewer._addToLog):
2190         (ValidateCommiterAndReviewer.getResultSummary):
2191         (ValidateCommiterAndReviewer.fail_build):
2192         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
2193         (ValidateCommiterAndReviewer.is_reviewer):
2194         (ValidateCommiterAndReviewer.is_committer):
2195         (ValidateCommiterAndReviewer.full_name_from_email):
2196         (ValidateCommiterAndReviewer.start):
2197
2198 2020-02-26  Daniel Bates  <dabates@apple.com>
2199
2200         [iOS] Send focus update immediately on becoming or resigning first responder
2201         https://bugs.webkit.org/show_bug.cgi?id=208082
2202         <rdar://problem/59688413>
2203
2204         Rubber-stamped by Jer Noble.
2205
2206         Add a test to ensure that selecting a position at a point after the web view
2207         becomes first responder is allowed. Such an operation is only allowed if the
2208         web view is focused.
2209
2210         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2211         (-[TestWKWebView selectPositionAtPoint:]):
2212         (TEST):
2213         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
2214
2215 2020-02-26  Chris Dumez  <cdumez@apple.com>
2216
2217         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
2218
2219         The test was added for macOS and times out on iOS.
2220
2221         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2222         (TEST):
2223
2224 2020-02-26  Youenn Fablet  <youenn@apple.com>
2225
2226         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
2227         https://bugs.webkit.org/show_bug.cgi?id=208238
2228
2229         Reviewed by Eric Carlson.
2230
2231         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2232         (TEST):
2233         Remove use of deleted parameter.
2234
2235 2020-02-25  Devin Rousso  <drousso@apple.com>
2236
2237         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
2238         https://bugs.webkit.org/show_bug.cgi?id=206911
2239         <rdar://problem/58026635>
2240
2241         Reviewed by Brian Burg.
2242
2243         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2244         (TestWebKitAPI::TEST):
2245         Add test for `WTF::HashSet::reserveInitialCapacity`.
2246
2247         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2248         (TestWebKitAPI::TEST):
2249         Actually check the value of `WTF::HashMap::capacity`.
2250
2251         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
2252         (-[InspectorDelegate _webView:didAttachInspector:])
2253         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
2254         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
2255         (TestWebKitAPI::TEST):
2256         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2257         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
2258         (TestWebKitAPI::TEST): Deleted.
2259
2260 2020-02-25  Matt Lewis  <jlewis3@apple.com>
2261
2262         Add checkout_root to stubrepository.py
2263         https://bugs.webkit.org/show_bug.cgi?id=208213
2264
2265         Reviewed by Jonathan Bedard.
2266
2267         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2268         (StubRepository.__init__):
2269
2270         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
2271         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
2272
2273 2020-02-25  Daniel Bates  <dabates@apple.com>
2274
2275         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
2276         https://bugs.webkit.org/show_bug.cgi?id=208214
2277
2278         Reviewed by Wenson Hsieh.
2279
2280         Wait until the copy operation completes before loading the second web view and testing paste
2281         to ensure that something was actually copied to the clipboard.
2282
2283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
2284         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2285         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
2286         so that we wait until the command completes.
2287
2288 2020-02-25  Chris Dumez  <cdumez@apple.com>
2289
2290         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
2291         https://bugs.webkit.org/show_bug.cgi?id=208199
2292         <rdar://problem/59746887>
2293
2294         Reviewed by Alex Christensen.
2295
2296         Add API test coverage.
2297
2298         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2299         (TEST):
2300
2301 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2302
2303         spinRunLoop should take a non-zero integer as parameter
2304         https://bugs.webkit.org/show_bug.cgi?id=208148
2305         <rdar://problem/59766682>
2306
2307         Unreviewed iOS build fix.
2308
2309         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2310         (TestWebKitAPI::Util::spinRunLoop):
2311
2312 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
2313
2314         spinRunLoop should take a non-zero integer as parameter
2315         https://bugs.webkit.org/show_bug.cgi?id=208148
2316
2317         Reviewed by Darin Adler.
2318
2319         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2320         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2321         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2322         (TestWebKitAPI::Util::spinRunLoop):
2323
2324 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2325
2326         [WTF] Add tests for CompactRefPtrTuple
2327         https://bugs.webkit.org/show_bug.cgi?id=208172
2328
2329         Reviewed by Darin Adler.
2330
2331         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
2332         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
2333
2334         * TestWebKitAPI/CMakeLists.txt:
2335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2336         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
2337         (TestWebKitAPI::TEST):
2338
2339 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
2340
2341         [ews] commit-queue should check that patch have appropriate review flag
2342         https://bugs.webkit.org/show_bug.cgi?id=208138
2343
2344         Reviewed by Jonathan Bedard.
2345
2346         * BuildSlaveSupport/ews-build/steps.py:
2347         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
2348         (BugzillaMixin._is_patch_cq_plus):
2349         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
2350         (ValidatePatch.start):
2351
2352 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
2353
2354         [WebAuthn] Implement SPI for the platform authenticator
2355         https://bugs.webkit.org/show_bug.cgi?id=208087
2356         <rdar://problem/59369305>
2357
2358         Reviewed by Brent Fulgham.
2359
2360         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
2361
2362         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
2363         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2365         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2366         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2367         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
2368         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
2369         (TestWebKitAPI::TEST):
2370         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
2371         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
2372         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
2373         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
2374
2375 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
2376
2377         Unreviewed, updating LLDB test for CompactPointerTuple.
2378         https://bugs.webkit.org/show_bug.cgi?id=207827
2379
2380         * lldb/lldb_webkit.py:
2381         (WTFCompactPointerTupleProvider):
2382         (WTFCompactPointerTupleProvider.update):
2383
2384 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
2385
2386         Provide alternate way to name Web Content process
2387         https://bugs.webkit.org/show_bug.cgi?id=205224
2388         rdar://57038084
2389
2390         Reviewed by Alex Christensen.
2391
2392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2393         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
2394         (TestWebKitAPI::TEST):
2395
2396 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
2397
2398         results.webkit.org: Link to result archives
2399         https://bugs.webkit.org/show_bug.cgi?id=207646
2400         <rdar://problem/59395807>
2401
2402         Rubber-stamped by Aakash Jain.
2403
2404         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
2405         (_ArchiveRouter): Retrieve json from archive-router endpoint.
2406         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
2407         return the most specific value.
2408         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
2409         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
2410         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
2411         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
2412         (parametersForInstance): Extract from lambda function.
2413         (testRunLink): Use parametersForInstance instead of a lambda function.
2414         (archiveLink): Return an archive link for data. 
2415         (contentForData): Add archive link to view.
2416         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2417         (TimelineFromEndpoint): Accept both suite and test.
2418         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
2419         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
2420         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
2421         * resultsdbpy/resultsdbpy/view/view_routes.py:
2422         (ViewRoutes.__init__): Add archive_route dictionary.
2423
2424 2020-02-24  Alex Christensen  <achristensen@webkit.org>
2425
2426         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
2427         https://bugs.webkit.org/show_bug.cgi?id=208035
2428         <rdar://problem/58011337>
2429
2430         Reviewed by Tim Hatcher.
2431
2432         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2433
2434 2020-02-22  Darin Adler  <darin@apple.com>
2435
2436         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
2437         https://bugs.webkit.org/show_bug.cgi?id=208099
2438
2439         Reviewed by Antti Koivisto.
2440
2441         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2442         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
2443         so we can use the -[NSString createJSStringRef] method.
2444         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
2445         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
2446
2447 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2448
2449         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
2450         https://bugs.webkit.org/show_bug.cgi?id=208096
2451         <rdar://problem/59632008>
2452
2453         Reviewed by Alexey Proskuryakov.
2454
2455         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
2456         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
2457         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
2458
2459         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
2460         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
2461         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
2462         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
2463         in the credit card expiry field.
2464
2465         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
2466
2467         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2468         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2469         (WTR::UIScriptController::setDefaultCalendarType):
2470         * WebKitTestRunner/TestController.h:
2471
2472         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
2473         identifier and calendar locale identifier.
2474
2475         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2476         (WTR::swizzledCalendar):
2477         (WTR::TestController::overriddenCalendarIdentifier const):
2478         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
2479
2480         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
2481
2482         (WTR::TestController::setDefaultCalendarType):
2483
2484         Plumb the new calendar's locale identifier through this method.
2485
2486         (WTR::TestController::cocoaResetStateToConsistentValues):
2487         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
2488         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
2489         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
2490         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
2491
2492 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
2493
2494         App-bound domains should have separate Network Sessions
2495         https://bugs.webkit.org/show_bug.cgi?id=208026
2496         <rdar://problem/59434006>
2497
2498         Reviewed by Brent Fulgham.
2499
2500         This patch is mostly test infrastructure involving 3 functions.
2501         One sets in-app browser privacy as enabled in the network process
2502         manually for the test. One ensures that setting the WebView category
2503         works properly, and the last one checks for an app-bound session for
2504         an app-bound navigation.
2505
2506         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2507         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2508         (WTR::InjectedBundle::didReceiveMessageToPage):
2509         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2510         (WTR::TestRunner::getWebViewCategory):
2511         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
2512         (WTR::TestRunner::hasAppBoundSession):
2513         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
2514         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
2515         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2516         * WebKitTestRunner/TestController.cpp:
2517         (WTR::TestController::ensureViewSupportsOptionsForTest):
2518         Clearing the bundleID should happen right before setting a new one, 
2519         otherwise it clears the ID after it is set and returns a null ID.
2520
2521         (WTR::TestController::resetStateToConsistentValues):
2522         (WTR::TestController::getWebViewCategory):
2523         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
2524         (WTR::inAppBrowserPrivacyBooleanResultCallback):
2525         (WTR::inAppBrowserPrivacyVoidResultCallback):
2526         (WTR::TestController::hasAppBoundSession):
2527         (WTR::TestController::setInAppBrowserPrivacyEnabled):
2528         * WebKitTestRunner/TestController.h:
2529         * WebKitTestRunner/TestInvocation.cpp:
2530         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2531         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2532         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
2533         (WTR::TestInvocation::didReceivePrevalentDomains):
2534         (WTR::TestInvocation::didReceiveWebViewCategory):
2535         * WebKitTestRunner/TestInvocation.h:
2536         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2537         (WTR::TestController::getWebViewCategory):
2538
2539 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
2540
2541         Build DumpRenderTree and WebKitTestRunner for macCatalyst
2542         https://bugs.webkit.org/show_bug.cgi?id=208068
2543         <rdar://problem/59676596>
2544
2545         Reviewed by Tim Horton.
2546
2547         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
2548         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2549         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
2550         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
2551         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
2552         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
2553         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
2554         * DumpRenderTree/mac/EventSendingController.h: Ditto.
2555         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
2556         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
2557         * Makefile: Add DumpRenderTree and WebKitTestRunner.
2558         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
2559         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
2560         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
2561
2562 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2563
2564         [ews] Add build step to Validate ChangeLog for commit-queue
2565         https://bugs.webkit.org/show_bug.cgi?id=208064
2566
2567         Reviewed by Jonathan Bedard.
2568
2569         * BuildSlaveSupport/ews-build/steps.py:
2570         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
2571         (ValidateChangeLogAndReviewer.start):
2572         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
2573         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
2574
2575 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
2576
2577         [ews] Add build step to set cq- flag on bugzilla patch
2578         https://bugs.webkit.org/show_bug.cgi?id=208021
2579
2580         Reviewed by Jonathan Bedard.
2581
2582         * BuildSlaveSupport/ews-build/steps.py:
2583         (BugzillaMixin.set_cq_minus_flag_on_patch):
2584         (SetCommitQueueMinusFlagOnPatch):
2585         (SetCommitQueueMinusFlagOnPatch.start):
2586         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
2587
2588 2020-02-20  Matt Lewis  <jlewis3@apple.com>
2589
2590         Stub repositories fail to upload some results due to missing head svn revision
2591         https://bugs.webkit.org/show_bug.cgi?id=207684
2592
2593         Reviewed by Jonathan Bedard.
2594
2595         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
2596         (MockHost.__init__):
2597         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2598         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2599         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2600         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
2601         * Scripts/webkitpy/port/base.py:
2602         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
2603         from using mock SCMs and more
2604         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
2605
2606 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
2607
2608         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
2609         https://bugs.webkit.org/show_bug.cgi?id=208051
2610
2611         Reviewed by Carlos Alberto Lopez Perez.
2612
2613         Verbose flag prints out each test name executed. Without this flag
2614         stdout prints out one or two periods.
2615
2616         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2617         (RunJavaScriptCoreTests.start):
2618
2619 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
2620
2621         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
2622         https://bugs.webkit.org/show_bug.cgi?id=207984
2623
2624         Reviewed by Daniel Bates.
2625
2626         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2627         (TestWebKitAPI::TEST):
2628
2629 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
2630
2631         [GTK] Improve user agent quirk for Google Docs and Google Drive
2632         https://bugs.webkit.org/show_bug.cgi?id=206506
2633
2634         Reviewed by Carlos Garcia Campos.
2635
2636         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2637         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2638         (TestWebKitAPI::TEST):
2639
2640 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2641
2642         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
2643         https://bugs.webkit.org/show_bug.cgi?id=207380
2644
2645         Reviewed by Jonathan Bedard.
2646
2647         Added a new rule 'build/export_macro'.
2648
2649         Removed a obsolete rule 'readability/webkit_export' which was used
2650         only by Chromium port (r148185).
2651
2652         * Scripts/webkitpy/style/checkers/cpp.py:
2653         (_FunctionState.export_macro):
2654         (check_function_definition):
2655         (_unix_path): Added.
2656         (is_generated_file): Use _unix_path.
2657         (check_has_config_header): Ditto.
2658         (CppChecker):
2659         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2660         (WebKitStyleTest.test_export_macro_check):
2661         (WebKitStyleTest.test_webkit_export_check): Deleted.
2662
2663 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2664
2665         [Win][MiniBrowser] Add prettier toolbar button icons
2666         https://bugs.webkit.org/show_bug.cgi?id=207999
2667
2668         Reviewed by Ross Kirsling.
2669
2670         Use a custom toolbar button icons instead of system stock icons.
2671
2672         Fixed a bug toolbar button dropdown arrows always looked being
2673         hovered. TBSTYLE_FLAT should be given.
2674
2675         Removed the window border line of Progress Indicator.
2676
2677         * MiniBrowser/win/MainWindow.cpp:
2678         (MainWindow::createToolbar):
2679         * MiniBrowser/win/MiniBrowserLib.rc:
2680         * MiniBrowser/win/MiniBrowserLibResource.h:
2681         * MiniBrowser/win/toolbar.bmp: Added.
2682
2683 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
2684
2685         Update run-webkit-tests help description for skip-failing-tests
2686         https://bugs.webkit.org/show_bug.cgi?id=208031
2687
2688         Reviewed by Alexey Proskuryakov.
2689
2690         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2691
2692 2020-02-20  Chris Dumez  <cdumez@apple.com>
2693
2694         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
2695         https://bugs.webkit.org/show_bug.cgi?id=208015
2696         <rdar://problem/59591630>
2697
2698         Reviewed by Geoffrey Garen.
2699
2700         Add API test coverage.
2701
2702         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2703         (TEST):
2704
2705 2020-02-20  Tim Horton  <timothy_horton@apple.com>
2706
2707         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
2708         https://bugs.webkit.org/show_bug.cgi?id=207998
2709         <rdar://problem/40942425>
2710
2711         Reviewed by Sam Weinig.
2712
2713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2714         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
2715         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2716         (TestWebKitAPI::TEST):
2717         Add some tests for top content insets.
2718
2719 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
2720
2721         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
2722         https://bugs.webkit.org/show_bug.cgi?id=207910
2723
2724         Unreviewed infrastructure fix.
2725
2726         * Scripts/run-javascriptcore-tests:
2727         (configurationForUpload): Use the major version instead of the sub-minor version
2728         for version name.
2729
2730 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
2731
2732         [CMake] Add WPE::libwpe target
2733         https://bugs.webkit.org/show_bug.cgi?id=207970
2734
2735         Reviewed by Adrian Perez de Castro.
2736
2737         Use the WPE::libwpe target.
2738
2739         * MiniBrowser/wpe/CMakeLists.txt:
2740         * TestWebKitAPI/PlatformWPE.cmake:
2741         * TestWebKitAPI/glib/PlatformWPE.cmake:
2742         * wpe/backends/CMakeLists.txt:
2743
2744 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2745
2746         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
2747         https://bugs.webkit.org/show_bug.cgi?id=207749
2748
2749         Reviewed by Ross Kirsling.
2750
2751         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
2752
2753         * MiniBrowser/win/MainWindow.cpp:
2754         (MainWindow::createToolbar):
2755         (MainWindow::WndProc):
2756         (MainWindow::setDefaultURLToCurrentURL):
2757         (MainWindow::goHome): Added.
2758         (MainWindow::onURLBarEnter):
2759         * MiniBrowser/win/MainWindow.h:
2760         * MiniBrowser/win/MiniBrowserLib.rc:
2761         * MiniBrowser/win/MiniBrowserLibResource.h:
2762         * MiniBrowser/win/MiniBrowserReplace.h:
2763         * MiniBrowser/win/WinMain.cpp:
2764         (wWinMain):
2765
2766 2020-02-19  Peng Liu  <peng.liu6@apple.com>
2767
2768         Fix check-webkit-style errors related to AVFoundationSPI.h
2769         https://bugs.webkit.org/show_bug.cgi?id=207834
2770
2771         Reviewed by Daniel Bates.
2772
2773         Revert the change in r256770 regarding the headers ordering.
2774         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
2775
2776         * Scripts/webkitpy/style/checkers/cpp.py:
2777         (check_include_line):
2778
2779 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
2780
2781         results.webkit.org: Correctly report JSC tests for windows
2782         https://bugs.webkit.org/show_bug.cgi?id=207910
2783
2784         Rubber-stamped by Aakash Jain.
2785
2786         * Scripts/run-javascriptcore-tests:
2787         (configurationForUpload): Give Windows a version name.
2788         * Scripts/webkitdirs.pm:
2789         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
2790         Version dictionary.
2791
2792 2020-02-19  Chris Dumez  <cdumez@apple.com>
2793
2794         Unreviewed, fix assertions in storage access API layout tests after r256882.
2795
2796         Drop dead testRunner code to toggle storage access API feature.
2797
2798         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2799         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2800         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
2801         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2802         * WebKitTestRunner/TestInvocation.cpp:
2803         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2804
2805 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
2806
2807         [WPE] Support 2D axis, smooth-motion events
2808         https://bugs.webkit.org/show_bug.cgi?id=207881
2809
2810         Reviewed by Carlos Garcia Campos.
2811
2812         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
2813
2814 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
2815
2816         Unreviewed, rolling out r256851.
2817
2818         Broke internal bots
2819
2820         Reverted changeset:
2821
2822         "Stub repositories fail to upload some results due to missing
2823         head svn revision"
2824         https://bugs.webkit.org/show_bug.cgi?id=207684
2825         https://trac.webkit.org/changeset/256851
2826
2827 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2828
2829         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
2830         https://bugs.webkit.org/show_bug.cgi?id=207883
2831
2832         Reviewed by Ross Kirsling.
2833
2834         Unlike other mouse buttons, 4th and 5th mouse buttons are
2835         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
2836         WM_XBUTTONUP events to the window under the mouse cursor.
2837         Unhandled WM_XBUTTONUP events are automatically converted to
2838         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
2839         parent window.
2840         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
2841
2842         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
2843         handled.
2844
2845         * MiniBrowser/win/BrowserWindow.h:
2846         * MiniBrowser/win/MainWindow.cpp:
2847         (MainWindow::WndProc):
2848         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2849         (WebKitBrowserWindow::navigateForwardOrBackward):
2850         * MiniBrowser/win/WebKitBrowserWindow.h:
2851         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2852         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
2853         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2854
2855 2020-02-18  Alex Christensen  <achristensen@webkit.org>
2856
2857         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
2858         https://bugs.webkit.org/show_bug.cgi?id=207912
2859         <rdar://problem/59556922>
2860
2861         Reviewed by Brian Weinstein.
2862
2863         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2864         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2865         (TEST):
2866         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2867         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
2868
2869 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2870
2871         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
2872         https://bugs.webkit.org/show_bug.cgi?id=207899
2873         <rdar://problem/55658207>
2874
2875         Reviewed by Tim Horton and Simon Fraser.
2876
2877         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
2878
2879         * WebKitTestRunner/TestController.cpp:
2880         (WTR::updateTestOptionsFromTestHeader):
2881         * WebKitTestRunner/TestOptions.h:
2882         (WTR::TestOptions::hasSameInitializationOptions const):
2883         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2884         (WTR::TestController::platformCreateWebView):
2885
2886 2020-02-18  Matt Lewis  <jlewis3@apple.com>
2887
2888         Stub repositories fail to upload some results due to missing head svn revision
2889         https://bugs.webkit.org/show_bug.cgi?id=207684
2890
2891         Reviewed by Jonathan Bedard.
2892
2893         * Scripts/webkitpy/api_tests/run_api_tests.py:
2894         (main): Added initializing the scm to the host object.
2895         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2896         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
2897         it in line with modern code.
2898         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2899         (main): Added inializing the scm to the host object.
2900         * Scripts/webkitpy/port/base.py:
2901         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
2902         from using mock SCMs and more
2903         * Scripts/webkitpy/test/main.py:
2904         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
2905         and converted the webkit_root variable to the SCM checkout root.
2906         (Tester._run_tests):
2907
2908 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
2909
2910         Move [UIDevice currentDevice] calls to UI process
2911         https://bugs.webkit.org/show_bug.cgi?id=204320
2912
2913         Reviewed by Darin Adler.
2914
2915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2916         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
2917         (TEST):
2918
2919 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
2920
2921         Move from "layer flush" terminology to "rendering update"
2922         https://bugs.webkit.org/show_bug.cgi?id=207870
2923
2924         Reviewed by Tim Horton.
2925
2926         Rename various functions and member variables to move away from the legacy "layer flush"
2927         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
2928         that we have layers is an implementation detail.
2929         
2930         Change LayerFlushThrottlingState to be an OptionSet<>.
2931
2932         * Tracing/SystemTracePoints.plist:
2933
2934 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
2935
2936         [Webkit.css] Adding popover style element
2937         This help to prevent us reinventing the wheel ever again
2938         https://bugs.webkit.org/show_bug.cgi?id=207787
2939
2940         Reviewed by Dean Jackson.
2941
2942         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
2943         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2944         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2945         (.popover):
2946         (.popover>.content):
2947         (.popover.display):
2948         (.popover .arrow):
2949         (.popover .arrow.point-top):
2950         (.popover .arrow.point-bottom):
2951         (.popover .arrow.point-left):
2952         (.popover .arrow.point-right):
2953         (@media (prefers-color-scheme: dark) .popover>.content):
2954         (@media (prefers-color-scheme: dark) .popover.display):
2955         (@media (prefers-color-scheme: dark) .popover .arrow):
2956         (.popover>.content>.section): Deleted.
2957         (.popover:focus>.content, .popover:hover>.content): Deleted.
2958         (.popover.right>.content): Deleted.
2959         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
2960         (.popover.left>.content): Deleted.
2961         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
2962         (.popover.bottom>.content): Deleted.
2963         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
2964
2965 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
2966
2967         Update WebKit Tools to issue mach extensions as needed
2968         https://bugs.webkit.org/show_bug.cgi?id=207850
2969         <rdar://problem/59521019>
2970
2971         Reviewed by Per Arne Vollan.
2972
2973         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
2974         to its child processes (WebContent, GPU, Network, etc.) as needed.
2975
2976         * MiniBrowser/MiniBrowser.entitlements:
2977         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
2978         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2980         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
2981
2982 2020-02-17  Peng Liu  <peng.liu6@apple.com>
2983
2984         Fix check-webkit-style errors related to AVFoundationSPI.h
2985         https://bugs.webkit.org/show_bug.cgi?id=207834
2986
2987         Reviewed by Eric Carlson.
2988
2989         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
2990         Soft-link headers can be included as either "file.h" or <file.h>.
2991
2992         * Scripts/webkitpy/style/checkers/cpp.py:
2993         (_classify_include):
2994         (check_include_line):
2995
2996 2020-02-17  Keith Rollin  <krollin@apple.com>
2997
2998         Unreviewed build fix after r256715.
2999
3000         Fix tvOS and watchOS builds.
3001
3002         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3003
3004 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
3005
3006         Use CF prefs direct mode in the WebContent process
3007         https://bugs.webkit.org/show_bug.cgi?id=203420
3008
3009         Reviewed by Brent Fulgham.
3010
3011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3012         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
3013         (TEST):
3014
3015 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3016
3017         EWS should be able to file Bugzilla bugs
3018         https://bugs.webkit.org/show_bug.cgi?id=207845
3019
3020         Reviewed by Alexey Proskuryakov.
3021
3022         * BuildSlaveSupport/ews-build/steps.py:
3023         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
3024
3025 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3026
3027         EWS should be able to comment on Bugzilla
3028         https://bugs.webkit.org/show_bug.cgi?id=201927
3029
3030         Reviewed by Jonathan Bedard.
3031
3032         * BuildSlaveSupport/ews-build/steps.py:
3033         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
3034         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
3035         (BugzillaMixin.close_bug): Ditto.
3036         (CommentOnBug): Build step to comment on bugzilla bug.
3037
3038 2020-02-17  Antti Koivisto  <antti@apple.com>
3039
3040         [macOS] Add trace points for layer flush runloop observer
3041         https://bugs.webkit.org/show_bug.cgi?id=207837
3042
3043         Reviewed by Sam Weinig.
3044
3045         * Tracing/SystemTracePoints.plist:
3046
3047 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
3048
3049         [CMake] Use builtin targets
3050         https://bugs.webkit.org/show_bug.cgi?id=205166
3051
3052         Reviewed by Darin Adler.
3053
3054         * TestWebKitAPI/PlatformWin.cmake:
3055
3056 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3057
3058         [ews] add SetBuildSummary step for Windows EWS
3059         https://bugs.webkit.org/show_bug.cgi?id=207556
3060
3061         Reviewed by Jonathan Bedard.
3062
3063         * BuildSlaveSupport/ews-build/factories.py:
3064         (WindowsFactory.__init__):
3065         (GTKBuildAndTestFactory.__init__):
3066         * BuildSlaveSupport/ews-build/factories_unittest.py:
3067         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
3068
3069 2020-02-17  Alberto Garcia  <berto@igalia.com>
3070
3071         [WPE] Change the QML plugin install path
3072         https://bugs.webkit.org/show_bug.cgi?id=207761
3073
3074         Reviewed by Philippe Normand.
3075
3076         * Scripts/run-qt-wpe-minibrowser:
3077         * glib/api_test_runner.py:
3078         (TestRunner._run_test_qt):
3079
3080 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3081
3082         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
3083         https://bugs.webkit.org/show_bug.cgi?id=207746
3084
3085         Reviewed by Don Olmstead.
3086
3087         * MiniBrowser/win/stdafx.h:
3088
3089 2020-02-16  Brady Eidson  <beidson@apple.com>
3090
3091         Expose "allowsContentJavaScript" on WKWebpagePreferences
3092         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
3093
3094         Reviewed by Darin Adler.
3095
3096         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3097         (TEST):
3098         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3099         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3100         (TEST):
3101         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
3102         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3103         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3104         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3105         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
3106         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
3107         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3108         * TestWebKitAPI/cocoa/TestWKWebView.h:
3109         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3110         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
3111
3112 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
3113
3114         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
3115         https://bugs.webkit.org/show_bug.cgi?id=207747
3116
3117         Reviewed by Keith Miller.
3118
3119         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
3120         (TestWebKitAPI::TEST):
3121
3122 2020-02-14  Alex Christensen  <achristensen@webkit.org>
3123
3124         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
3125         https://bugs.webkit.org/show_bug.cgi?id=207360
3126         <rdar://problem/57825317>
3127
3128         Reviewed by Ryosuke Niwa.
3129
3130         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3131         (TestWebKitAPI::TEST):
3132
3133 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
3134
3135         [CMake] Add Fontconfig::Fontconfig target
3136         https://bugs.webkit.org/show_bug.cgi?id=207730
3137
3138         Reviewed by Adrian Perez de Castro.
3139
3140         Use the Fontconfig::Fontconfig target.
3141
3142         * WebKitTestRunner/PlatformGTK.cmake:
3143
3144 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
3145
3146          Expose prevalent domains on a per-page basis
3147          https://bugs.webkit.org/show_bug.cgi?id=207523
3148          <rdar://problem/59270758>
3149
3150         Reviewed by Chris Dumez.
3151
3152         Added WebKitTestRunner functions so this functionality can be tested.
3153         clearPrevalentDomains should be called between tests to reset the
3154         state.
3155
3156         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3157         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3158         (WTR::InjectedBundle::didReceiveMessageToPage):
3159         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3160         (WTR::TestRunner::getPrevalentDomains):
3161         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
3162         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3163         * WebKitTestRunner/TestController.cpp:
3164         (WTR::TestController::resetStateToConsistentValues):
3165         (WTR::TestController::getPrevalentDomains):
3166         (WTR::TestController::clearPrevalentDomains):
3167         * WebKitTestRunner/TestController.h:
3168         * WebKitTestRunner/TestInvocation.cpp:
3169         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3170         (WTR::TestInvocation::didReceivePrevalentDomains):
3171         * WebKitTestRunner/TestInvocation.h:
3172         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3173         (WTR::TestController::getPrevalentDomains):
3174         (WTR::TestController::clearPrevalentDomains):
3175
3176 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3177
3178         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
3179         https://bugs.webkit.org/show_bug.cgi?id=207682
3180
3181         Reviewed by Ross Kirsling.
3182
3183         The toolbar placed button common controls as the toolbar buttons.
3184         However, because these buttons are focusable, shortcut keys don't
3185         work after clicking them.
3186
3187         Added Home button, Add to Bookmarks button, dropdown buttons of
3188         back and forward buttons, but they aren't implemented yet. Just
3189         placeholders at the moment.
3190
3191         * MiniBrowser/win/MainWindow.cpp:
3192         (MainWindow::createToolbar): Added.
3193         (MainWindow::resizeToolbar): Added.
3194         (MainWindow::rescaleToolbar): Added.
3195         (MainWindow::init):
3196         (MainWindow::resizeSubViews):
3197         (MainWindow::updateDeviceScaleFactor):
3198         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
3199
3200 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3201
3202         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
3203         https://bugs.webkit.org/show_bug.cgi?id=207676
3204
3205         Reviewed by Wenson Hsieh and Timothy Hatcher.
3206
3207         Added regression tests for pasting content with -apple-system-label and outdenting content.
3208
3209         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3210         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
3211         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
3212
3213 2020-02-13  Alex Christensen  <achristensen@webkit.org>
3214
3215         _WKResourceLoadInfo should conform to NSSecureCoding
3216         https://bugs.webkit.org/show_bug.cgi?id=207667
3217
3218         Reviewed by Brady Eidson.
3219
3220         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3221         (TEST):
3222
3223 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
3224
3225         [PlayStation] Add Buildbots for Debug/Release builds
3226         https://bugs.webkit.org/show_bug.cgi?id=199454
3227
3228         Reviewed by Aakash Jain.
3229
3230         * BuildSlaveSupport/build.webkit.org-config/config.json:
3231         Add PlayStation slaves, builders
3232         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3233         Use higher timeout for playstation as with win bot
3234         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3235         Set PlayStation category for playstation platform
3236         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3237         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
3238         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3239         Add PlayStation expectations
3240
3241 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
3242
3243         [iOS] Check if PIP is supported in the UI process
3244         https://bugs.webkit.org/show_bug.cgi?id=207406
3245
3246         Reviewed by Brent Fulgham.
3247
3248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3249         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
3250         (TEST):
3251
3252 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3253
3254         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
3255         https://bugs.webkit.org/show_bug.cgi?id=207397
3256         <rdar://problem/59268128>
3257
3258         Reviewed by Jer Noble.
3259
3260         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3261         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
3262
3263 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3264
3265         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
3266         https://bugs.webkit.org/show_bug.cgi?id=207696
3267
3268         Reviewed by Tim Horton.
3269
3270         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3271
3272 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3273
3274         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
3275         https://bugs.webkit.org/show_bug.cgi?id=207680
3276         <rdar://problem/59340940>
3277
3278         Reviewed by Tim Horton.
3279
3280         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
3281         the current selection works.
3282
3283         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3284         (-[TestWKWebView updateSelectionWithExtentPoint:]):
3285         * TestWebKitAPI/ios/UIKitSPI.h:
3286
3287 2020-02-13  Said Abou-Hallawa  <said@apple.com>
3288
3289         Unreviewed, rolling out r255158, 255405 and r255486
3290
3291         Caused test flakiness and PLT regression.
3292
3293         * DumpRenderTree/mac/DumpRenderTree.mm:
3294         (resetWebPreferencesToConsistentValues):
3295         * DumpRenderTree/win/DumpRenderTree.cpp:
3296         (enableExperimentalFeatures):
3297         * WebKitTestRunner/TestController.cpp:
3298         (WTR::TestController::resetPreferencesToConsistentValues):
3299
3300 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3301
3302         run-javascriptcore-tests: Allow insecure requests on upload
3303         https://bugs.webkit.org/show_bug.cgi?id=207662
3304
3305         Rubber-stamped by Aakash Jain.
3306
3307         * Scripts/run-javascriptcore-tests:
3308         (uploadResults): Allow insecure curl request when posting results.
3309
3310 2020-02-12  Truitt Savell  <tsavell@apple.com>
3311
3312         Unreviewed, rolling out r256463.
3313
3314         Caused major flakiness on Mac wk2
3315
3316         Reverted changeset:
3317
3318         "REGRESSION (r255158): http/tests/frame-throttling/raf-
3319         throttle-in-cross-origin-subframe.html is a flaky failure"
3320         https://bugs.webkit.org/show_bug.cgi?id=206839
3321         https://trac.webkit.org/changeset/256463
3322
3323 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3324
3325         results.webkit.org: Remove debug JS logging
3326         https://bugs.webkit.org/show_bug.cgi?id=207663
3327
3328         Reviewed by Aakash Jain.
3329
3330         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3331         (elapsed):
3332         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
3333         (_ToolTip.prototype.toString):
3334         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
3335         (prototype.addWithDelay):
3336         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
3337
3338 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
3339
3340         Remove CSS_DEVICE_ADAPTATION
3341         https://bugs.webkit.org/show_bug.cgi?id=203479
3342
3343         Reviewed by Tim Horton.
3344         
3345         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
3346         so remove the code.
3347
3348         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3349
3350 2020-02-12  Said Abou-Hallawa  <said@apple.com>
3351
3352         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
3353         https://bugs.webkit.org/show_bug.cgi?id=206839
3354
3355         Reviewed by Simon Fraser.
3356
3357         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
3358
3359         * DumpRenderTree/mac/DumpRenderTree.mm:
3360         (resetWebPreferencesToConsistentValues):
3361         * DumpRenderTree/win/DumpRenderTree.cpp:
3362         (enableExperimentalFeatures):
3363         * WebKitTestRunner/TestController.cpp:
3364         (WTR::TestController::resetPreferencesToConsistentValues):
3365
3366 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
3367
3368         results.webkit.org: Cache archive content
3369         https://bugs.webkit.org/show_bug.cgi?id=207589
3370
3371         Reviewed by Aakash Jain.
3372
3373         * resultsdbpy/resultsdbpy/flask_support/util.py:
3374         (cache_for): Add decorator function which sets the cache values on the returned response.
3375         * resultsdbpy/resultsdbpy/view/archive_view.py:
3376         (ArchiveView): Cache archive content client-side for 12 hours.
3377         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
3378         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
3379
3380 2020-02-12  Youenn Fablet  <youenn@apple.com>
3381
3382         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3383         https://bugs.webkit.org/show_bug.cgi?id=207537
3384
3385         Reviewed by Chris Dumez.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3388
3389 2020-02-11  Rob Buis  <rbuis@igalia.com>
3390
3391         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
3392         <https://webkit.org/b/207424>
3393         <rdar://problem/59250384>
3394
3395         Reviewed by Rob Buis.
3396
3397         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3398         (TestWebKitAPI::TEST): Add more tests.
3399
3400 2020-02-11  Commit Queue  <commit-queue@webkit.org>
3401
3402         Unreviewed, rolling out r256314.
3403         https://bugs.webkit.org/show_bug.cgi?id=207594
3404
3405         It is breaking an API test (Requested by youenn on #webkit).
3406
3407         Reverted changeset:
3408
3409         "WebSWServerConnection::registerServiceWorkerClient is not
3410         sending IPC message to UIProcess when it should"
3411         https://bugs.webkit.org/show_bug.cgi?id=207537
3412         https://trac.webkit.org/changeset/256314
3413
3414 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
3415
3416         results.webkit.org: Configuration documentation should include architecture
3417         https://bugs.webkit.org/show_bug.cgi?id=207584
3418
3419         Reviewed by Aakash Jain.
3420
3421         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
3422
3423 2020-02-11  Youenn Fablet  <youenn@apple.com>
3424
3425         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
3426         https://bugs.webkit.org/show_bug.cgi?id=207325
3427         <rdar://problem/59224810>
3428
3429         Reviewed by Eric Carlson.
3430
3431         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
3432         (TestWebKitAPI::TEST):
3433         Add a test validating that RTCRtpSender.getCapabilities does not return null.
3434         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3435
3436 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3437
3438         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
3439         https://bugs.webkit.org/show_bug.cgi?id=207557
3440
3441         Reviewed by Jonathan Bedard.
3442
3443         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
3444         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
3445         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
3446         around this by focusing an empty select element instead (for which we won't attempt to create and select any
3447         table view cells).
3448
3449         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3450
3451 2020-02-11  Alex Christensen  <achristensen@webkit.org>
3452
3453         Add WKHTTPCookieStore._getCookiesForURL SPI
3454         https://bugs.webkit.org/show_bug.cgi?id=207527
3455
3456         Reviewed by Brady Eidson.
3457
3458         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3459         (TEST):
3460
3461 2020-02-11  Youenn Fablet  <youenn@apple.com>
3462
3463         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
3464         https://bugs.webkit.org/show_bug.cgi?id=207537
3465
3466         Reviewed by Chris Dumez.
3467
3468         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3469
3470 2020-02-11  Lauro Moura  <lmoura@igalia.com>
3471
3472         [WPE][WebDriver] MiniBrowser should react to close session commands
3473         https://bugs.webkit.org/show_bug.cgi?id=207529
3474
3475         Reviewed by Carlos Garcia Campos.
3476
3477         WebDriver delete session command asks to close the WebView associated to the
3478         current automation session. We must react to it to avoid lots of
3479         timeouts and errors.
3480
3481         * MiniBrowser/wpe/main.cpp:
3482         (main): Listen to "close" signal on the main WebView.
3483
3484 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3485
3486         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
3487         https://bugs.webkit.org/show_bug.cgi?id=207525
3488         <rdar://problem/59110543>
3489
3490         Reviewed by Tim Horton.
3491
3492         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
3493         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
3494         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
3495         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
3496         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
3497         causing us to crash upon trying to create the dictionary.
3498
3499         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
3500         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
3501         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
3502         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
3503         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
3504         beginning of each API test.
3505
3506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3507         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3508         (overrideBundleIdentifier):
3509
3510         Move this to the top of the file, so it can be shared.
3511
3512         (+[WKWebView initialize]):
3513
3514         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
3515         internal class method that calls into the internal helper function, with no other side effects.
3516
3517         * TestWebKitAPI/ios/UIKitSPI.h:
3518
3519 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3520
3521         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
3522         https://bugs.webkit.org/show_bug.cgi?id=207501
3523         <rdar://problem/59323414>
3524
3525         Reviewed by Alex Christensen.
3526
3527         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
3528         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
3529         The same behavior.
3530
3531 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
3532
3533         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
3534         https://bugs.webkit.org/show_bug.cgi?id=207352
3535         <rdar://problem/59115798>
3536
3537         Reviewed by Alex Christensen.
3538
3539         Add a test to exercise the new SPI.
3540
3541         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
3542         a webpage that contains text in subframes.
3543
3544
3545 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3546
3547         [iOS] Crash when granting access to asset services
3548         https://bugs.webkit.org/show_bug.cgi?id=207520
3549
3550         Reviewed by Brent Fulgham.
3551
3552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3553         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
3554         (TEST):
3555
3556 2020-02-10  Chris Dumez  <cdumez@apple.com>
3557
3558         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
3559         https://bugs.webkit.org/show_bug.cgi?id=207481
3560
3561         Reviewed by Alexey Proskuryakov.
3562
3563         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
3564         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
3565         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
3566
3567         * DumpRenderTree/mac/DumpRenderTree.mm:
3568         (resetWebViewToConsistentStateBeforeTesting):
3569         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
3570         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
3571         over internal settings.
3572
3573 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
3574
3575         [watchOS] Notification listener is never unregistered
3576         https://bugs.webkit.org/show_bug.cgi?id=207459
3577
3578         Reviewed by Maciej Stachowiak.
3579
3580         Add a test which tests that posting a backlight level change notification will not cause a crash.
3581
3582         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3583         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
3584         (TEST):
3585
3586 2020-02-10  James Howard  <jameshoward@mac.com>
3587
3588         Standard gamepad mapping for GameControllerGamepads
3589         https://bugs.webkit.org/show_bug.cgi?id=206033
3590
3591         Reviewed by Dean Jackson.
3592
3593         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3594         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3595         (WTR::TestRunner::setMockGamepadDetails):
3596         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3597         * WebKitTestRunner/TestInvocation.cpp:
3598         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3599
3600 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3601
3602         [ews] Display flaky layout test names in build summary
3603         https://bugs.webkit.org/show_bug.cgi?id=207504
3604
3605         Reviewed by Jonathan Bedard.
3606
3607         * BuildSlaveSupport/ews-build/steps.py:
3608         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
3609         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
3610         (AnalyzeLayoutTestsResults.start):
3611
3612 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
3613
3614         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
3615         https://bugs.webkit.org/show_bug.cgi?id=207492
3616
3617         Reviewed by Jonathan Bedard.
3618
3619         * BuildSlaveSupport/ews-build/steps.py:
3620         (RunWebKitTests.evaluateCommand):
3621         (ReRunWebKitTests.evaluateCommand):
3622         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3623         * BuildSlaveSupport/ews-build/factories.py:
3624         (TestFactory.__init__):
3625
3626 2020-02-10  Truitt Savell  <tsavell@apple.com>
3627
3628         Unreviewed, rolling out r256091.
3629
3630         Broke internal builds
3631
3632         Reverted changeset:
3633
3634         "Move trivial definitions from FeatureDefines.xcconfig to
3635         PlatformEnableCocoa.h"
3636         https://bugs.webkit.org/show_bug.cgi?id=207155
3637         https://trac.webkit.org/changeset/256091
3638
3639 2020-02-10  Truitt Savell  <tsavell@apple.com>
3640
3641         Unreviewed, rolling out r256103.
3642
3643         This patch is blocking the rollout of r256091
3644
3645         Reverted changeset:
3646
3647         "Move JavaScriptCore related feature defines from
3648         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
3649         https://bugs.webkit.org/show_bug.cgi?id=207436
3650         https://trac.webkit.org/changeset/256103
3651
3652 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
3653
3654         results.webkit.org: Abstract archive storage solutions
3655         https://bugs.webkit.org/show_bug.cgi?id=207277
3656
3657         Rubber-stamped by Aakash Jain.
3658
3659         * resultsdbpy/resultsdbpy/model/archive_context.py:
3660         (ArchiveContext):