fa456009cdcf6b9a927d9a4040bd4c38422607a4
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-02  Roger Fong  <roger_fong@apple.com>
2
3         Unreviewed. Disable running tests on Win EWS queue.
4
5         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
6         (WinEWS):
7
8 2013-04-02  Lucas Forschler  <lforschler@apple.com>
9
10         Disable running tests on the MAC WK2 EWS queue.
11         
12         Unreviewed.
13         
14         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
15         (MacWK2EWS):
16
17 2013-04-02  Julie Parent  <jparent@chromium.org>
18
19         Dashboard refactor: Move dashboard specific history related features to History.
20         https://bugs.webkit.org/show_bug.cgi?id=113717
21
22         Reviewed by Ojan Vafai.
23         
24         Each dashboard now creates its own History object, with a custom
25         configuration. This changes from just overriding global functions
26         to passing in callbacks for generatePage, handleValidHashParameter,
27         and handleQueryParameterChange. Same with passing in defaultStateValues
28         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
29         variables.
30         
31         All functions related to these features are now (mostly) private
32         function on History. 
33         
34         Loader no longer needs a loadingComplete callback, since it can just
35         initialize the history object itself.
36
37         * TestResultServer/static-dashboards/aggregate_results.js:
38         (handleValidHashParameter):
39         * TestResultServer/static-dashboards/dashboard_base.js:
40         * TestResultServer/static-dashboards/flakiness_dashboard.js:
41         (generatePage):
42         (.switch.return):
43         (handleQueryParameterChange):
44         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
45         (resetGlobals):
46         * TestResultServer/static-dashboards/history.js:
47         (.):
48         * TestResultServer/static-dashboards/loader.js:
49         (.):
50         * TestResultServer/static-dashboards/loader_unittests.js:
51         * TestResultServer/static-dashboards/timeline_explorer.js:
52         (generatePage):
53         (initCurrentBuilderTestResults):
54         * TestResultServer/static-dashboards/treemap.js:
55         (generatePage):
56         (.switch.return):
57         (handleQueryParameterChange):
58
59 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
60
61         Unreviewed, rolling out r147401.
62         http://trac.webkit.org/changeset/147401
63         https://bugs.webkit.org/show_bug.cgi?id=113767
64
65         The patch makes it extremely hard to set up the dependencies
66         properly on the GTK builders (Requested by zdobersek on
67         #webkit).
68
69         * gtk/jhbuild.modules:
70
71 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
72
73         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
74         https://bugs.webkit.org/show_bug.cgi?id=113382
75
76         Reviewed by Gyuyoung Kim.
77
78         Do not show the empty tooltip box if the text is null.
79
80         * MiniBrowser/efl/main.c:
81         (popup_menu_populate):
82
83 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
84
85         [GTK] Bump required versions of some dependencies
86         https://bugs.webkit.org/show_bug.cgi?id=113282
87
88         Reviewed by Martin Robinson.
89
90         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
91
92 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
93
94         Unreviewed, rolling out r147319.
95         http://trac.webkit.org/changeset/147319
96         https://bugs.webkit.org/show_bug.cgi?id=113707
97
98         The unit test is still failing on the buildbot (Requested by
99         zdobersek on #webkit).
100
101         * Scripts/run-gtk-tests:
102         (TestRunner):
103
104 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
105
106         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
107         https://bugs.webkit.org/show_bug.cgi?id=104779
108
109         Reviewed by Carlos Garcia Campos.
110
111         * Scripts/run-gtk-tests:
112         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
113         passing in current trunk.
114
115 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
116
117         Unreviewed, rolling out r147289.
118         http://trac.webkit.org/changeset/147289
119         https://bugs.webkit.org/show_bug.cgi?id=113678
120
121         broke Win7 (dbg) build (Requested by shinyak|gardener on
122         #webkit).
123
124         * DumpRenderTree/DumpRenderTree.gypi:
125         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
126         (WebTestRunner):
127         (WebUserMediaClientMock):
128         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
129         (WebTestRunner::WebUserMediaClientMock::taskList):
130         * Scripts/webkitpy/style/checkers/cpp.py:
131         (check_function_definition):
132
133 2013-03-31  Adam Barth  <abarth@webkit.org>
134
135         configure-svn-config.sh fails
136         https://codereview.chromium.org/13392007/
137
138         Reviewed by Eric Seidel.
139
140         This script was trying to use "svn checkout" to dowload a file from
141         svn.webkit.org, but "svn checkout" only works with directories.
142         Instead, we should use "svn export".
143
144         * EWSTools/configure-svn-config.sh:
145
146 2013-03-31  Wei Jia  <wjia@chromium.org>
147
148         Allow WebUserMediaClientMock to be used by client
149         https://bugs.webkit.org/show_bug.cgi?id=113633
150
151         Reviewed by Adam Barth.
152
153         Export WebUserMediaClientMock.
154         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
155
156         * DumpRenderTree/DumpRenderTree.gypi:
157         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
158         (WebUserMediaClientMock):
159         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
160         * Scripts/webkitpy/style/checkers/cpp.py:
161         (check_function_definition):
162
163 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
164
165         Expose FeatureObserver data to WebKit clients
166         https://bugs.webkit.org/show_bug.cgi?id=113613
167
168         Reviewed by Sam Weinig.
169
170         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
171         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
172
173 2013-03-29  Greg Hughes  <ghughes@apple.com>
174
175         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
176         https://bugs.webkit.org/show_bug.cgi?id=112276
177
178         Reviewed by Chris Fleizach.
179
180         Added support to test accessibility search predicates with multiple keys.  
181
182         * DumpRenderTree/AccessibilityUIElement.cpp:
183         (uiElementForSearchPredicateCallback):
184         * DumpRenderTree/AccessibilityUIElement.h:
185         (AccessibilityUIElement):
186         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
187         (AccessibilityUIElement::uiElementForSearchPredicate):
188         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
189         (AccessibilityUIElement::uiElementForSearchPredicate):
190         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
191         (AccessibilityUIElement::uiElementForSearchPredicate):
192         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
193         (AccessibilityUIElement::uiElementForSearchPredicate):
194         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
195         (AccessibilityUIElement::uiElementForSearchPredicate):
196         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
197         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
198         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
199         (AccessibilityUIElement):
200         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
201         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
202         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
203         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
204         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
205
206 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
207
208         Fix a typo in r147147 to fix Mac EWS.
209
210         * Scripts/webkitpy/tool/commands/queues.py:
211         (PatchProcessingQueue._new_port_name_from_old):
212
213 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
214
215         [EFL] Build break with latest EFL libraries after r146265
216         https://bugs.webkit.org/show_bug.cgi?id=113558
217
218         Unreviewed build fix.
219
220         * TestWebKitAPI/PlatformWebView.h:
221         * WebKitTestRunner/PlatformWebView.h:
222
223 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
224
225         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
226
227         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
228         in libgcrypt build.
229
230 2013-03-28  Lucas Forschler  <lforschler@apple.com>
231
232         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
233
234         Unreviewed.
235
236         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
237         (MacEWS):
238
239 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
240
241         Use the right OS name on Mac EWS instead of mac-future.
242
243         Rubber-stamped by Dirk Pranke.
244
245         * Scripts/webkitpy/tool/commands/queues.py:
246         (PatchProcessingQueue._new_port_name_from_old):
247         (PatchProcessingQueue.begin_work_queue):
248         (PatchProcessingQueue._upload_results_archive_for_patch):
249
250 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
251
252         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
253         https://bugs.webkit.org/show_bug.cgi?id=112546
254
255         Reviewed by Martin Robinson.
256
257         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
258         moved back to Source/WebCore/platform. Fix an indentation issue as well.
259
260 2013-03-28  Ming Xie  <mxie@blackberry.com>
261
262         [BlackBerry] Committer Email Updates
263         https://bugs.webkit.org/show_bug.cgi?id=113435
264
265         Reviewed by Rob Buis.
266
267         Add the @blackberry.com email address for all our BlackBerry
268         WebKit committers. This is the first step for our email address
269         migration.
270
271         * Scripts/webkitpy/common/config/committers.py:
272
273 2013-03-28  Philippe Normand  <pnormand@igalia.com>
274
275         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
276         https://bugs.webkit.org/show_bug.cgi?id=113508
277
278         Reviewed by Martin Robinson.
279
280         Prevent the GStreamer plugin scanner to load system-wide
281         plugins. Only the ones built in JHBuild should be loaded and used
282         at runtime.
283
284         * efl/jhbuildrc:
285         * gtk/jhbuildrc:
286
287 2013-03-27  Philippe Normand  <pnormand@igalia.com>
288
289         [GTK] run-launcher --gtk -2 fails on a WK2-only build
290         https://bugs.webkit.org/show_bug.cgi?id=113386
291
292         Reviewed by Carlos Garcia Campos.
293
294         * Scripts/webkitdirs.pm:
295         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
296         version to 3.0. Reflect this change so the builtDylibPathForName
297         function doesn't fail to report the library as found.
298
299 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
300
301         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
302         https://bugs.webkit.org/show_bug.cgi?id=113484
303
304         Unreviewed build fix.
305
306         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
307
308         * TestWebKitAPI/CMakeLists.txt:
309         * WebKitTestRunner/CMakeLists.txt:
310
311 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
312
313         Revision for the internal jhbuild is too old
314         https://bugs.webkit.org/show_bug.cgi?id=113324
315
316         Reviewed by Martin Robinson.
317
318         Update the minimum required version to a point where jhbuild won't
319         fail installing packages when trying to remove a symlink to a directory.
320
321         * jhbuild/jhbuild-wrapper: Updated revision.
322
323 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
324
325         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
326         https://bugs.webkit.org/show_bug.cgi?id=113203
327
328         Reviewed by Philippe Normand.
329
330         We build our libsoup without GNOME support. gst-plugins-good does separate
331         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
332         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
333         build failures as the headers of those diverge. We do not use souphttpsrc, so
334         disable it when building gst-plugins-good.
335
336         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
337
338 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
339
340         Build fix after r146852. Please another reference to the Lion leaks builder.
341
342         * BuildSlaveSupport/build.webkit.org-config/config.json:
343
344 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
345
346         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
347         https://bugs.webkit.org/show_bug.cgi?id=113421
348
349         Reviewed by Dirk Pranke.
350
351         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
352         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
353         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
354         in the GTK-specific TestExpectations files.
355
356         To avoid this only enable the warnings only when not using WKTR.
357
358         * Scripts/webkitpy/layout_tests/port/gtk.py:
359         (GtkPort.warn_if_bug_missing_in_test_expectations):
360
361 2013-03-27  Antti Koivisto  <antti@apple.com>
362
363         Fix Zalan's email.
364
365         * Scripts/webkitpy/common/config/committers.py:
366
367 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
368
369         master.cfg cleanup
370         https://bugs.webkit.org/show_bug.cgi?id=113195
371
372         Reviewed by Ryosuke Niwa.
373
374         * BuildSlaveSupport/build.webkit.org-config/config.json:
375         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
376
377 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
378
379         master.cfg fine-tuning for Qt Mountain Lion Release bot
380         https://bugs.webkit.org/show_bug.cgi?id=113191
381
382         Reviewed by Ryosuke Niwa.
383
384         * BuildSlaveSupport/build.webkit.org-config/config.json:
385           - Rename the slave due to its location change.
386           - Update the platform of the slave.
387         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
388         (RunQtAPITests): Enable running WK2 API tests on Qt.
389         (RunQtAPITests.start):
390         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
391         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
392
393 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
394
395         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
396         https://bugs.webkit.org/show_bug.cgi?id=113403
397
398         Reviewed by Kenneth Rohde Christiansen.
399
400         As of Evas 1.7.5, when Wayland is detected on the system, support for
401         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
402         The code, however, seems to depend on a few other flags which must be
403         explicitly enabled.
404
405         If those additional GL-related options are passed, we end up
406         having issues on the WebKit side, so disable Wayland support for
407         now.
408
409         * efl/jhbuild.modules:
410
411 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
412
413         Unreviewed, rolling out r146864.
414         http://trac.webkit.org/changeset/146864
415         https://bugs.webkit.org/show_bug.cgi?id=113391
416
417         causes crashes on Wk2 EFL release bot (Requested by drott on
418         #webkit).
419
420         * Scripts/webkitperl/FeatureList.pm:
421
422 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
423
424         [jhbuild] Correctly specify an alternate number of make jobs.
425         https://bugs.webkit.org/show_bug.cgi?id=113396
426
427         Reviewed by Philippe Normand.
428
429         So far, we were using the `MAKEFLAGS' environment variable to pass the
430         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
431         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
432
433         We now behave more closely to the rest of the WebKit tools by first
434         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
435         not set, just letting jhbuild itself figure out how many jobs to use.
436
437         * efl/jhbuildrc:
438         * gtk/jhbuildrc:
439
440 2013-03-27  Zeno Albisser  <zeno@webkit.org>
441
442         [Qt] Remove Qt specific WorkQueueItem definitions.
443         https://bugs.webkit.org/show_bug.cgi?id=112891
444
445         This patch is preparation work for removing
446         WorkQueue related code from TestRunnerQt and
447         replacing it with generic TestRunner code.
448
449         Reviewed by Benjamin Poulain.
450
451         * DumpRenderTree/qt/TestRunnerQt.cpp:
452         (TestRunnerQt::queueBackNavigation):
453         (TestRunnerQt::queueForwardNavigation):
454         (TestRunnerQt::queueLoadHTMLString):
455         (TestRunnerQt::queueReload):
456         (TestRunnerQt::queueLoadingScript):
457         (TestRunnerQt::queueNonLoadingScript):
458         (TestRunner::queueLoad):
459         * DumpRenderTree/qt/TestRunnerQt.h:
460         (TestRunnerQt):
461         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
462         (LoadItem::invoke):
463         (LoadHTMLStringItem::invoke):
464         (LoadAlternateHTMLStringItem::invoke):
465         (ReloadItem::invoke):
466         (ScriptItem::invoke):
467         (BackForwardItem::invoke):
468         * DumpRenderTree/qt/WorkQueueItemQt.h:
469         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
470         (LoadAlternateHTMLStringItem):
471
472 2013-03-26  Julie Parent  <jparent@chromium.org>
473
474         Flakiness dashboard: simplify logic around which tests to show.
475         https://bugs.webkit.org/show_bug.cgi?id=113250
476
477         Reviewed by Ojan Vafai.
478         
479         The different filters for showing results are only used for layout
480         tests, otherwise, we show everything.
481         
482         Change the defaults to false (what layout tests used), and only
483         look at the values when viewing layout tests.
484
485         * TestResultServer/static-dashboards/flakiness_dashboard.js:
486         (htmlForTestsWithExpectationsButNoFailures):
487         (shouldHideTest):
488
489 2013-03-26  Isaac Levy  <ilevy@google.com>
490
491         Update bots on test-results.appspot
492         https://bugs.webkit.org/show_bug.cgi?id=113333
493
494         Reviewed by Ojan Vafai.
495
496         * TestResultServer/static-dashboards/builders.jsonp:
497
498 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
499
500         Unreviewed GTK gardening.
501
502         * Scripts/run-gtk-tests:
503         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
504
505 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
506
507         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
508         https://bugs.webkit.org/show_bug.cgi?id=113287
509
510         Reviewed by Jocelyn Turcotte.
511
512         * Scripts/run-qtwebkit-tests:
513         (Options.__init__):
514
515 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
516
517         [EFL] Enable IndexedDB by default
518         https://bugs.webkit.org/show_bug.cgi?id=107248
519
520         Reviewed by Laszlo Gombos.
521
522         * Scripts/webkitperl/FeatureList.pm:
523         Enable IndexedDB by default on EFL.
524
525 2013-03-26  Alan Cutter  <alancutter@chromium.org>
526
527         Sheriffbot should explain rollout failures in a human readable form.
528         https://bugs.webkit.org/show_bug.cgi?id=107092
529
530         Reviewed by Ryosuke Niwa.
531
532         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
533
534         * Scripts/webkitpy/tool/bot/irc_command.py:
535         (Rollout._check_diff_failure):
536         (Rollout.execute):
537         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
538         (IRCCommandTest.test_rollout):
539
540 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
541
542         Unreviewed GTK gardening.
543
544         * Scripts/run-gtk-tests:
545         (TestRunner): Skipping a failing unit test after r146518.
546
547 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
548
549         Remove Lion leaks builder
550         https://bugs.webkit.org/show_bug.cgi?id=113252
551
552         Reviewed by Andreas Kling.
553
554         Removed.
555
556         * BuildSlaveSupport/build.webkit.org-config/config.json:
557
558 2013-03-25  Kent Tamura  <tkent@chromium.org>
559
560         Rename ENABLE_INPUT_TYPE_DATETIME
561         https://bugs.webkit.org/show_bug.cgi?id=113254
562
563         Reviewed by Kentaro Hara.
564
565         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
566         Actually I'd like to remove the code, but we shouldn't remove it yet
567         because we shipped products with it on some platforms.
568
569         * Scripts/webkitperl/FeatureList.pm:
570         * qmake/mkspecs/features/features.pri:
571
572 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
573
574         Remove one more line that was intended to be removed in r146657.
575
576         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
577         (summarize_results):
578
579 2013-03-25  Roger Fong  <roger_fong@apple.com>
580
581         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
582         Re-enable WinEWS tests.
583
584         * Scripts/webkitpy/common/config/ports.py:
585         (WinPort.run_bindings_tests_command):
586         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
587         (WinEWS):
588
589 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
590
591         Unreviewed, rolling out r146793.
592         http://trac.webkit.org/changeset/146793
593         https://bugs.webkit.org/show_bug.cgi?id=113248
594
595         Fix did not work (Requested by rfong on #webkit).
596
597         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
598         (WinEWS):
599
600 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
601
602         REGRESSION(r146657): Test failures reported incorrectly
603         https://bugs.webkit.org/show_bug.cgi?id=113223
604
605         Reviewed by Dirk Pranke.
606
607         The bug was caused by BuildBotPrinter not taking the new behavior into account.
608
609         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
610         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
611
612         * Scripts/webkitpy/layout_tests/controllers/manager.py:
613         (Manager.run):
614
615         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
616         (RunDetails.__init__):
617         (summarize_results): Remove the line I intended to remove in r146657.
618
619         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
620         (logging_run): Return details instead of the exit code.
621         (run_and_capture): Ditto.
622
623         (RunTest.test_full_results_html):
624         (RunTest.test_hung_thread):
625         (RunTest.test_no_tests_found):
626         (RunTest.test_no_tests_found_2):
627         (RunTest.test_repeat_each_iterations_num_tests):
628         (RunTest.test_run_singly_actually_runs_tests):
629         (RunTest.test_test_list):
630         (RunTest.test_missing_and_unexpected_results):
631         (RunTest.test_pixel_test_directories):
632         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
633         (RunTest.test_crash_with_stderr):
634         (RunTest.test_no_image_failure_with_image_diff):
635         (RunTest.test_crash_log):
636         (RunTest.test_exit_after_n_failures_upload):
637         (RunTest.test_results_directory_absolute):
638         (RunTest.test_results_directory_relative):
639         (RunTest.test_retrying_and_flaky_tests):
640         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
641         (RunTest.test_retrying_uses_retries_directory):
642         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
643         (RunTest.test_output_diffs):
644         (EndToEndTest.test_reftest_with_two_notrefs):
645         (RebaselineTest.test_reset_results):
646         (RebaselineTest.test_missing_results):
647         (RebaselineTest.test_new_baseline):
648
649         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
650         (BuildBotPrinter.print_results):
651         (BuildBotPrinter.print_unexpected_results):
652         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
653         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
654
655 2013-03-25  Julie Parent  <jparent@chromium.org>
656
657         Dashboard refactor: Move cross dashboard history related code into history.js.
658         https://bugs.webkit.org/show_bug.cgi?id=113104
659
660         Reviewed by Ojan Vafai.
661
662         All functions relating to cross dashboard behavior move from being
663         globals to methods on the history.History object. Names stay the same,
664         except many are made private, ones that should have been constants now
665         are, and the long standing TODO to change "currentState" to 
666         dashboardSpecificState is done.
667         
668         We now create a global history object in dashboard_base, as an 
669         intermediate measure.  Once the dashboard specific code is
670         added to history, each DB will need to create its own, and this
671         global will be eliminated.
672         
673         * TestResultServer/static-dashboards/aggregate_results.js:
674         (handleValidHashParameter):
675         (htmlForBuilder):
676         (rawValuesHTML):
677         * TestResultServer/static-dashboards/dashboard_base.js:
678         (parseDashboardSpecificParameters):
679         (defaultValue):
680         (currentBuilderGroupCategory):
681         (currentBuilderGroupName):
682         (handleLocationChange):
683         (expectationsMap):
684         * TestResultServer/static-dashboards/flakiness_dashboard.js:
685         (generatePage):
686         (.switch.return):
687         (platformAndBuildType):
688         (individualTests):
689         (substringList):
690         (processMissingAndExtraExpectations):
691         (pathToFailureLog):
692         (showPopupForBuild):
693         (htmlForTestsWithExpectationsButNoFailures):
694         (shouldHideTest):
695         (isCrossBuilderView):
696         (tableHeaders):
697         (htmlForSingleTestRow):
698         (htmlForTableColumnHeader):
699         (generatePageForExpectationsUpdate):
700         (handleUpdate):
701         (nextUpdate):
702         (setUpdateIndex):
703         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
704         (.appendExpectationsItem):
705         (loadExpectations):
706         (.dummyNode.onload):
707         (loadExpectationsLayoutTests):
708         (appendExpectations):
709         (htmlForNavBar):
710         (checkBoxToToggleState):
711         (linkHTMLToToggleState):
712         (generatePageForBuilder):
713         (isInvalidKeyForCrossBuilderView):
714         (handleQueryParameterChange):
715         (showLegend):
716         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
717         (resetGlobals):
718         (test):
719         * TestResultServer/static-dashboards/history.js:
720         (.):
721         * TestResultServer/static-dashboards/history_unittests.js:
722         * TestResultServer/static-dashboards/loader.js:
723         (.):
724         * TestResultServer/static-dashboards/loader_unittests.js:
725         * TestResultServer/static-dashboards/timeline_explorer.js:
726         (generatePage):
727         (initCurrentBuilderTestResults):
728         (selectBuild):
729         (showResultsDelta):
730         * TestResultServer/static-dashboards/treemap.js:
731         (generatePage):
732         (.switch.return):
733         (handleFocus):
734         * TestResultServer/static-dashboards/ui.js:
735
736 2013-03-25  Roger Fong  <roger_fong@apple.com>
737
738         Unreviewed. Enable WinEWS tests again.
739
740         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
741         (WinEWS):
742
743 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
744
745         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
746         https://bugs.webkit.org/show_bug.cgi?id=112166
747
748         HarfBuzz 0.9.14 merged my patch for icu detection without
749         pkg-config files, as needed by for example Ubuntu 12.04.
750         This obsoletes our local workaround. Removed it for GTK and EFL.
751
752         Reviewed by Martin Robinson.
753
754         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
755         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
756         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
757         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
758
759 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
760
761         Unreviewed.  Move self from contributor to committer list.
762
763         * Scripts/webkitpy/common/config/committers.py:
764
765 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
766
767         EWS should use a human readable port name when uploading layout test archives
768         https://bugs.webkit.org/show_bug.cgi?id=113099
769
770         Reviewed by Dirk Pranke.
771
772         Use new port's object's name() method to report human readable port names.
773         This will also help us resolving the bug to apply layout test results posted by EWS.
774
775         * Scripts/webkitpy/tool/bot/botinfo.py:
776         (BotInfo.__init__): Take port's name.
777         (BotInfo.summary_text):
778
779         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
780         (BotInfoTest.test_summary_text):
781
782         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
783         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
784
785         * Scripts/webkitpy/tool/commands/queues.py:
786         (PatchProcessingQueue.__init__): Initialize self._port.
787         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
788         and use that for the attachment filename and the comment posted.
789
790         * Scripts/webkitpy/tool/commands/queues_unittest.py:
791         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
792         "mac-snowleopard" as expected for TestPort.
793
794 2013-03-22  Roger Fong  <roger_fong@apple.com>
795
796         Unreviewed. Turn off EWS test on Win again.
797         The battle continues.
798
799         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
800         (WinEWS):
801
802 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
803
804         NRWT: Enable pixel tests when retrying tests
805         https://bugs.webkit.org/show_bug.cgi?id=112898
806
807         Reviewed by Dirk Pranke.
808
809         * Scripts/webkitpy/layout_tests/controllers/manager.py:
810         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
811         if we've forced pixel tests in the retry.
812         (Manager._run_tests):
813         (Manager._clean_up_run): Fixed the capitalizations.
814         (Manager._force_pixel_tests_if_needed): Added.
815
816         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
817         (_interpret_test_failures): Now that this function maybe called multiple times, only set
818         'image_diff_percent' if it doesn't already exist.
819
820         (summarize_results): When the first attempt resulted in a text failure and the second attempt
821         resulted in image and text failures and we've forced to run pixel tests in the retry run,
822         treat this as a regular regression instead of a flakiness.
823
824         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
825         run had image diffs.
826
827         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
828         (summarized_results):
829
830         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
831         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
832         Also removed some dead code.
833
834         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
835         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
836         is set and pixel_tests_enabled is set to false.
837         (EndToEndTest.test_reftest_with_two_notrefs):
838
839 2013-03-22  Tim Horton  <timothy_horton@apple.com>
840
841         Make it possible to run layout tests on Retina MBP
842         https://bugs.webkit.org/show_bug.cgi?id=93673
843
844         Reviewed by Ryosuke Niwa.
845
846         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
847         windows on 2x machines still run at 1x.
848
849         * DumpRenderTree/mac/DumpRenderTree.mm:
850         (createWebViewAndOffscreenWindow):
851         Reset the window resolution to 1x on creation.
852         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
853         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
854         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
855         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
856         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
857         (WTR::PlatformWebView::PlatformWebView):
858         Add NSWindow details, reset the window resolution to 1x on creation.
859
860 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
861
862         Leak bots shouldn't build
863         https://bugs.webkit.org/show_bug.cgi?id=112774
864
865         Reviewed by Simon Fraser.
866
867         Since leak bots use regular debug builds, there is no need to build on these bots.
868         Simply downloading builds will dramatically improve the cycle time of these bots.
869
870         * BuildSlaveSupport/build.webkit.org-config/config.json:
871         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
872         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
873         TestFactory instead of BuildAndTestFactory.
874
875 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
876
877         [Qt] Fix the TestWebKitAPI build
878         https://bugs.webkit.org/show_bug.cgi?id=113044
879
880         Reviewed by Tor Arne Vestbø.
881
882         The generate-forwarding-headers script would only be run
883         after the targets in InjectedBundle.pri since the second
884         addStrictSubdirOrderBetween call in
885         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
886         the derived_sources -> injected_bundle order in SUBDIRS.
887
888         Fix it by only moving the dependent target at the end of
889         SUBDIRS, don't touch its dependency.
890
891         * qmake/mkspecs/features/functions.prf:
892
893 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
894
895         [EFL][WK2] View is not focused when fullscreen mode toggled
896         https://bugs.webkit.org/show_bug.cgi?id=113009
897
898         Reviewed by Laszlo Gombos.
899
900         Set focus on view when fullscreen mode enabled/disabled
901         by FullScreen API.
902
903         * MiniBrowser/efl/main.c:
904         (on_fullscreen_accept):
905         (on_fullscreen_deny):
906
907 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
908
909         nrwt is no longer saving retry results in the retries/ subdirectory
910         https://bugs.webkit.org/show_bug.cgi?id=112995
911
912         Reviewed by Ojan Vafai.
913
914         I think this has been broken a long time, unfortunately. This
915         patch should fix that.
916
917         In order to do so, I had to pass the directory to use from
918         the Worker object through the SingleTestWriter to the
919         TestResultWriter. While I was plumbing that through, I rationalized
920         the order of the parameter arguments a bit ...
921
922         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
923         (Worker._run_single_test):
924         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
925         (run_single_test):
926         (SingleTestRunner.__init__):
927         (SingleTestRunner._run_compare_test):
928         (SingleTestRunner._run_rebaseline):
929         (SingleTestRunner._run_reftest):
930         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
931         (write_test_result):
932         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
933         (TestResultWriterTest.test_reftest_diff_image):
934         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
935         (RunTest.test_retrying_uses_retries_directory):
936
937 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
938
939         JSC profiler should have an at-a-glance report of the success of DFG optimization
940         https://bugs.webkit.org/show_bug.cgi?id=112988
941
942         Reviewed by Geoffrey Garen.
943
944         * Scripts/display-profiler-output:
945
946 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
947
948         [chromium] Linux ASAN WebKit canary is running out of memory
949         https://bugs.webkit.org/show_bug.cgi?id=112978
950
951         Reviewed by Tony Chang.
952
953         Running the AddressSanitizer on a crash takes a lot of
954         memory, so we should serialize access to it to avoid running
955         out of memory on a machine.
956
957         * Scripts/webkitpy/layout_tests/port/chromium.py:
958         (ChromiumPort._get_crash_log):
959         * Scripts/webkitpy/layout_tests/port/http_lock.py:
960         (HttpLock.__init__):
961         (HttpLock.wait_for_httpd_lock):
962
963 2013-03-21  Min Qin  <qinmin@chromium.org>
964
965         Cleanup android media layout test code
966         https://bugs.webkit.org/show_bug.cgi?id=112944
967
968         Reviewed by Adam Barth.
969
970         Chromium change: https://codereview.chromium.org/12892010/
971         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
972         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
973         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
974         Instead, we should switch to use content shell for layout tests.
975
976         * DumpRenderTree/chromium/TestShell.cpp:
977         (TestShell::resetTestController):
978
979 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
980
981         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
982         https://bugs.webkit.org/show_bug.cgi?id=112953
983
984         Reviewed by Tony Chang.
985
986         When I created the DumpRenderTree_resources target in r144863 I
987         forgot to declare the needed dependencies on the other resource
988         targets. Due to a quirk of ordering, this appears to have been fine
989         w/ ninja but not w/ Xcode (which is still being used on the chromium
990         mac valgrind bots). Declaring the dependencies fixes the build
991         failures.
992
993         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
994
995 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
996
997         [WinCairo] Correct assert in Empty BitmapImage Test.
998         https://bugs.webkit.org/show_bug.cgi?id=112934
999
1000         Reviewed by Tim Horton.
1001
1002         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1003         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1004         to avoid ref counting assertion when leaving test scope.
1005
1006 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1007
1008         [GTK] generate-feature-defines-files is incompatible with Python3
1009         https://bugs.webkit.org/show_bug.cgi?id=112956
1010
1011         Reviewed by Martin Robinson.
1012
1013         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1014         method on the dictionary objects when iterating through said dictionaries.
1015
1016         * gtk/generate-feature-defines-files:
1017         (write_feature_defines_header):
1018         (write_flattened_feature_defines_file):
1019
1020 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1021
1022         kill-old-processes spits out error messages on Mac
1023         https://bugs.webkit.org/show_bug.cgi?id=112878
1024
1025         Reviewed by Jessie Berlin.
1026
1027         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1028         included in the list of options grep --help shows.
1029
1030         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1031
1032         * BuildSlaveSupport/kill-old-processes:
1033         (main):
1034
1035 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1036
1037         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1038         https://bugs.webkit.org/show_bug.cgi?id=112597
1039
1040         Reviewed by Xan Lopez.
1041
1042         These were introduced for the Chromium port in r105295. We need
1043         dummy implementations in order to compile the BlackBerry port.
1044
1045         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1046         (AccessibilityUIElement::scrollToMakeVisible):
1047         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1048         (AccessibilityUIElement::scrollToGlobalPoint):
1049
1050 2013-03-21  Roger Fong  <roger_fong@apple.com>
1051
1052         Re-enable WinEWS tests following r146376.
1053
1054         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1055         (WinEWS):
1056
1057 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1058
1059         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1060
1061         * Scripts/webkitpy/common/config/committers.py:
1062
1063 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1064
1065         [GTK] Missing atk in install-dependencies script
1066         https://bugs.webkit.org/show_bug.cgi?id=112272
1067
1068         Reviewed by Gustavo Noronha Silva.
1069
1070         * gtk/install-dependencies: Add missing atk dependency.
1071
1072 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1073
1074         [GTK] Missing backslash in install-dependencies script
1075         https://bugs.webkit.org/show_bug.cgi?id=112907
1076
1077         Reviewed by Philippe Normand.
1078
1079         * gtk/install-dependencies: Add missing backslash to dependencies
1080         list.
1081
1082 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1083
1084         EWS bots have stopped uploading results to bugzilla
1085         https://bugs.webkit.org/show_bug.cgi?id=101091
1086
1087         Reviewed by Adam Barth.
1088
1089         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1090         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1091         this relative file path resoled to a file inside a non-existent directory for "zip".
1092
1093         Fixed the bug by resolving both test results directory and zip archive paths in
1094         LayoutTestResultsReader.archive.
1095
1096         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1097         in the future.
1098
1099         * Scripts/webkitpy/common/system/filesystem_mock.py:
1100         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1101
1102         * Scripts/webkitpy/common/system/workspace.py:
1103         (Workspace.create_zip): Log the source path when "zip" failed.
1104
1105         * Scripts/webkitpy/common/system/workspace_mock.py:
1106         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1107
1108         * Scripts/webkitpy/common/system/workspace_unittest.py:
1109         (WorkspaceTest.test_create_zip_exception): Test that.
1110
1111         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1112         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1113         This is the actual bug fix.
1114
1115         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1116         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1117
1118 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1119
1120         [chromium] move WebThemeEngine implementations to TestRunner library
1121         https://bugs.webkit.org/show_bug.cgi?id=112751
1122
1123         Reviewed by Adam Barth.
1124
1125         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1126         * DumpRenderTree/DumpRenderTree.gypi:
1127         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1128         (WebKit):
1129         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1130         (WebTestRunner::TestInterfaces::themeEngine):
1131         (WebTestRunner):
1132         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1133         (WebKit):
1134         (TestInterfaces):
1135         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1136         (WebTestRunner::WebTestInterfaces::themeEngine):
1137         (WebTestRunner):
1138         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1139         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1140         (WebTestRunner):
1141         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1142         (WebTestRunner::WebTestThemeControlWin::box):
1143         (WebTestRunner::WebTestThemeControlWin::line):
1144         (WebTestRunner::WebTestThemeControlWin::triangle):
1145         (WebTestRunner::WebTestThemeControlWin::roundRect):
1146         (WebTestRunner::WebTestThemeControlWin::oval):
1147         (WebTestRunner::WebTestThemeControlWin::circle):
1148         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1149         (WebTestRunner::WebTestThemeControlWin::markState):
1150         (WebTestRunner::WebTestThemeControlWin::draw):
1151         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1152         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1153         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1154         (WebTestRunner):
1155         (WebTestThemeControlWin):
1156         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1157         (WebTestRunner):
1158         (WebTestThemeEngineMac):
1159         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1160         (+[FakeActiveWindow alwaysActiveWindow]):
1161         (+[FakeActiveWindow alwaysInactiveWindow]):
1162         (-[FakeActiveWindow initWithActiveControls:]):
1163         (-[FakeActiveWindow _hasActiveControls]):
1164         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1165         (WebTestRunner):
1166         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1167         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1168         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1169         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1170         (WebTestRunner):
1171         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1172         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1173         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1174         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1175         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1176         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1177         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1178         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1179         (WebTestRunner::WebTestThemeEngineWin::getSize):
1180         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1181         (WebTestRunner):
1182         (WebTestThemeEngineWin):
1183         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1184         * DumpRenderTree/chromium/TestShell.cpp:
1185         (TestShell::initialize):
1186         * DumpRenderTree/chromium/TestShell.h:
1187         (WebKit):
1188         * DumpRenderTree/chromium/TestShellMac.mm:
1189         (platformInit):
1190         * DumpRenderTree/chromium/TestShellWin.cpp:
1191         (platformInit):
1192         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1193
1194 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1195
1196         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1197
1198         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1199         New property sheet that does not link against CoreFoundation and
1200         CFNetwork.
1201         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1202         Use new TestWebKitAPICommonWinCairo property sheet.
1203         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1204         Ditto.
1205
1206 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1207
1208         [WinCairo] Unreviewed build fix for VS2010.
1209
1210         Had to add WinCairo-specific property sheets to deal with some
1211         library and path differences with the main Apple port.
1212
1213         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1214         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1215         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1216         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1217         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1218         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1219
1220 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1221
1222         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1223         https://bugs.webkit.org/show_bug.cgi?id=112849
1224
1225         Reviewed by Sam Weinig.
1226
1227         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1228         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1229         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1230
1231 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1232
1233         [WinCairo] Build WebKit Tools under VS2010
1234         https://bugs.webkit.org/show_bug.cgi?id=112821
1235
1236         Reviewed by Tim Horton.
1237
1238         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1239         Add WinCairo-specific build target.
1240         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1241         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1242         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1243         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1244         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1245         Add WinCairo-specific build target.
1246         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1247         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1248         Add WinCairo-specific build target.
1249         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1250         WinCairo-specific build target.
1251         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1252         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1253         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1254         specific build target.
1255         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1256         WinCairo-specific build target.
1257         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1258         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1259         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1260
1261 2013-03-20  Roger Fong  <roger_fong@apple.com>
1262
1263         API test gardening AppleWin port.
1264
1265         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1266
1267         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1268         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1269
1270 2013-03-20  Roger Fong  <roger_fong@apple.com>
1271
1272         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1273
1274         * EWSTools/start-queue-win.sh:
1275
1276 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1277
1278         Unreviewed, add myself to committers.py.
1279
1280 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1281
1282         Unreviewed. Adding another email for me.
1283
1284         * Scripts/webkitpy/common/config/committers.py:
1285
1286 2013-03-20  Justin Novosad  <junov@google.com>
1287
1288         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1289         https://bugs.webkit.org/show_bug.cgi?id=112605
1290
1291         Reviewed by James Robinson.
1292
1293         Deleting all the code that was used for propagating and supporting
1294         the Chromium setting for disabling deferred 2d canvas rendering.
1295
1296         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1297         (main):
1298         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1299         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1300         (WebTestRunner::WebPreferences::reset):
1301         (WebTestRunner::WebPreferences::applyTo):
1302         * DumpRenderTree/chromium/TestShell.cpp:
1303         (TestShell::TestShell):
1304         (TestShell::resetWebSettings):
1305         (TestShell::runFileTest):
1306         * DumpRenderTree/chromium/TestShell.h:
1307         (TestShell):
1308
1309 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1310
1311         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1312         https://bugs.webkit.org/show_bug.cgi?id=112699.
1313
1314         Reviewed by Adam Barth.
1315
1316         * Scripts/webkitpy/layout_tests/port/qt.py:
1317         (QtPort._search_paths):
1318         (QtPort._port_specific_expectations_files):
1319         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1320         (QtPortTest):
1321         (QtPortTest._assert_search_path):
1322         (QtPortTest._assert_expectations_files):
1323
1324 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1325
1326         [Qt] Enable kerning by default
1327         https://bugs.webkit.org/show_bug.cgi?id=112704
1328
1329         Reviewed by Jocelyn Turcotte.
1330
1331         Disable kerning by default, since some reference test expectations
1332         expect kerning to be default off.
1333
1334         * DumpRenderTree/qt/TestRunnerQt.cpp:
1335         (TestRunnerQt::reset):
1336         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1337         (WTR::activateFonts):
1338
1339 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1340
1341         [Qt] Remove empty function stubs from TestRunnerQt.
1342         https://bugs.webkit.org/show_bug.cgi?id=112799
1343
1344         We are reducing the code in TestRunnerQt step by step,
1345         in order to finally replace all of it with the generic
1346         TestRunner implementation.
1347         This patch removes several simple function stubs that
1348         currently do not implement any actual functionality.
1349
1350         Reviewed by Kenneth Rohde Christiansen.
1351
1352         * DumpRenderTree/qt/TestRunnerQt.cpp:
1353         * DumpRenderTree/qt/TestRunnerQt.h:
1354         (TestRunnerQt):
1355
1356 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1357
1358         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1359         https://bugs.webkit.org/show_bug.cgi?id=112687
1360
1361         Reviewed by Kenneth Rohde Christiansen.
1362
1363         Hide the SearchBar by default on window creation.
1364
1365         * MiniBrowser/efl/main.c:
1366         (window_create):
1367
1368 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1369
1370         Unreviewed, rolling out r146304.
1371         http://trac.webkit.org/changeset/146304
1372         https://bugs.webkit.org/show_bug.cgi?id=112788
1373
1374         to many expectations to update (Requested by antonm on
1375         #webkit).
1376
1377         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1378         * DumpRenderTree/DumpRenderTree.gypi:
1379         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1380         (WebKit):
1381         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1382         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1383         (TestInterfaces):
1384         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1385         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1386         * DumpRenderTree/chromium/TestShell.cpp:
1387         (TestShell::initialize):
1388         * DumpRenderTree/chromium/TestShell.h:
1389         (WebKit):
1390         * DumpRenderTree/chromium/TestShellMac.mm:
1391         (platformInit):
1392         * DumpRenderTree/chromium/TestShellWin.cpp:
1393         (platformInit):
1394         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1395         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1396         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1397         (WebThemeControlDRTWin::box):
1398         (WebThemeControlDRTWin::line):
1399         (WebThemeControlDRTWin::triangle):
1400         (WebThemeControlDRTWin::roundRect):
1401         (WebThemeControlDRTWin::oval):
1402         (WebThemeControlDRTWin::circle):
1403         (WebThemeControlDRTWin::nestedBoxes):
1404         (WebThemeControlDRTWin::markState):
1405         (WebThemeControlDRTWin::draw):
1406         (WebThemeControlDRTWin::drawTextField):
1407         (WebThemeControlDRTWin::drawProgressBar):
1408         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1409         (WebThemeControlDRTWin):
1410         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1411         (WebThemeEngineDRTMac):
1412         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1413         (+[FakeActiveWindow alwaysActiveWindow]):
1414         (+[FakeActiveWindow alwaysInactiveWindow]):
1415         (-[FakeActiveWindow initWithActiveControls:]):
1416         (-[FakeActiveWindow _hasActiveControls]):
1417         (WebThemeEngineDRTMac::paintScrollbarThumb):
1418         (stateToHIEnableState):
1419         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1420         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1421         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1422         (webRectToSkIRect):
1423         (drawControl):
1424         (drawTextField):
1425         (drawProgressBar):
1426         (WebThemeEngineDRTWin::paintButton):
1427         (WebThemeEngineDRTWin::paintMenuList):
1428         (WebThemeEngineDRTWin::paintScrollbarArrow):
1429         (WebThemeEngineDRTWin::paintScrollbarThumb):
1430         (WebThemeEngineDRTWin::paintScrollbarTrack):
1431         (WebThemeEngineDRTWin::paintSpinButton):
1432         (WebThemeEngineDRTWin::paintTextField):
1433         (WebThemeEngineDRTWin::paintTrackbar):
1434         (WebThemeEngineDRTWin::paintProgressBar):
1435         (WebThemeEngineDRTWin::getSize):
1436         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1437         (WebThemeEngineDRTWin):
1438         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1439
1440 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1441
1442         [Qt] Support -webkit-font-smoothing
1443         https://bugs.webkit.org/show_bug.cgi?id=106009
1444
1445         Reviewed by Jocelyn Turcotte.
1446
1447         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
1448
1449         * DumpRenderTree/qt/TestRunnerQt.cpp:
1450         (TestRunnerQt::reset):
1451
1452 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
1453
1454         [GTK] accessibility/aria-scrollbar-role.html is failing
1455         https://bugs.webkit.org/show_bug.cgi?id=98358
1456
1457         Reviewed by Martin Robinson.
1458
1459         Adds support for checking accessibility object's orientation.
1460         Orientation is checked by retrieving proper state of accessibility object.
1461
1462         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1463         (checkElementState):
1464         (AccessibilityUIElement::orientation):
1465         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1466         (WTR::AccessibilityUIElement::orientation):
1467
1468 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1469
1470         [chromium] move WebThemeEngine implementations to TestRunner library
1471         https://bugs.webkit.org/show_bug.cgi?id=112751
1472
1473         Reviewed by Adam Barth.
1474
1475         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1476         * DumpRenderTree/DumpRenderTree.gypi:
1477         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1478         (WebKit):
1479         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1480         (WebTestRunner::TestInterfaces::themeEngine):
1481         (WebTestRunner):
1482         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1483         (WebKit):
1484         (TestInterfaces):
1485         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1486         (WebTestRunner::WebTestInterfaces::themeEngine):
1487         (WebTestRunner):
1488         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1489         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1490         (WebTestRunner):
1491         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1492         (WebTestRunner::WebTestThemeControlWin::box):
1493         (WebTestRunner::WebTestThemeControlWin::line):
1494         (WebTestRunner::WebTestThemeControlWin::triangle):
1495         (WebTestRunner::WebTestThemeControlWin::roundRect):
1496         (WebTestRunner::WebTestThemeControlWin::oval):
1497         (WebTestRunner::WebTestThemeControlWin::circle):
1498         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1499         (WebTestRunner::WebTestThemeControlWin::markState):
1500         (WebTestRunner::WebTestThemeControlWin::draw):
1501         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1502         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1503         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1504         (WebTestRunner):
1505         (WebTestThemeControlWin):
1506         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1507         (WebTestRunner):
1508         (WebTestThemeEngineMac):
1509         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1510         (+[FakeActiveWindow alwaysActiveWindow]):
1511         (+[FakeActiveWindow alwaysInactiveWindow]):
1512         (-[FakeActiveWindow initWithActiveControls:]):
1513         (-[FakeActiveWindow _hasActiveControls]):
1514         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1515         (WebTestRunner):
1516         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1517         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1518         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1519         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1520         (WebTestRunner):
1521         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1522         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1523         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1524         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1525         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1526         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1527         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1528         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1529         (WebTestRunner::WebTestThemeEngineWin::getSize):
1530         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1531         (WebTestRunner):
1532         (WebTestThemeEngineWin):
1533         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1534         * DumpRenderTree/chromium/TestShell.cpp:
1535         (TestShell::initialize):
1536         * DumpRenderTree/chromium/TestShell.h:
1537         (WebKit):
1538         * DumpRenderTree/chromium/TestShellMac.mm:
1539         (platformInit):
1540         * DumpRenderTree/chromium/TestShellWin.cpp:
1541         (platformInit):
1542         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1543
1544 2013-03-19  Tony Chang  <tony@chromium.org>
1545
1546         Move testRunner.setTouchDragDropEnabled to internals.settings
1547         https://bugs.webkit.org/show_bug.cgi?id=112739
1548
1549         Reviewed by Adam Barth.
1550
1551         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1552         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
1553         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1554         (TestRunner): Remove unnecessary code.
1555         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1556         (WebTestRunner::WebPreferences::reset):
1557         (WebTestRunner::WebPreferences::applyTo): Always set to false.
1558
1559 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
1560
1561         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1562         https://bugs.webkit.org/show_bug.cgi?id=112754
1563
1564         Reviewed by Darin Fisher.
1565
1566         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1567         now that it's always defined.
1568
1569         * DumpRenderTree/chromium/WebViewHost.cpp:
1570         * DumpRenderTree/chromium/WebViewHost.h:
1571         (WebViewHost):
1572
1573 2013-03-19  Kenneth Russell  <kbr@google.com>
1574
1575         Unreviewed, rolling out r146290.
1576         http://trac.webkit.org/changeset/146290
1577         https://bugs.webkit.org/show_bug.cgi?id=112751
1578
1579         Broke Chromium Mac build.
1580
1581         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1582         * DumpRenderTree/DumpRenderTree.gypi:
1583         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1584         (WebKit):
1585         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1586         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1587         (TestInterfaces):
1588         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1589         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1590         * DumpRenderTree/chromium/TestShell.cpp:
1591         (TestShell::initialize):
1592         * DumpRenderTree/chromium/TestShell.h:
1593         (WebKit):
1594         * DumpRenderTree/chromium/TestShellMac.mm:
1595         (platformInit):
1596         * DumpRenderTree/chromium/TestShellWin.cpp:
1597         (platformInit):
1598         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1599         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1600         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1601         (WebThemeControlDRTWin::box):
1602         (WebThemeControlDRTWin::line):
1603         (WebThemeControlDRTWin::triangle):
1604         (WebThemeControlDRTWin::roundRect):
1605         (WebThemeControlDRTWin::oval):
1606         (WebThemeControlDRTWin::circle):
1607         (WebThemeControlDRTWin::nestedBoxes):
1608         (WebThemeControlDRTWin::markState):
1609         (WebThemeControlDRTWin::draw):
1610         (WebThemeControlDRTWin::drawTextField):
1611         (WebThemeControlDRTWin::drawProgressBar):
1612         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1613         (WebThemeControlDRTWin):
1614         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1615         (WebThemeEngineDRTMac):
1616         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1617         (+[FakeActiveWindow alwaysActiveWindow]):
1618         (+[FakeActiveWindow alwaysInactiveWindow]):
1619         (-[FakeActiveWindow initWithActiveControls:]):
1620         (-[FakeActiveWindow _hasActiveControls]):
1621         (WebThemeEngineDRTMac::paintScrollbarThumb):
1622         (stateToHIEnableState):
1623         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1624         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1625         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1626         (webRectToSkIRect):
1627         (drawControl):
1628         (drawTextField):
1629         (drawProgressBar):
1630         (WebThemeEngineDRTWin::paintButton):
1631         (WebThemeEngineDRTWin::paintMenuList):
1632         (WebThemeEngineDRTWin::paintScrollbarArrow):
1633         (WebThemeEngineDRTWin::paintScrollbarThumb):
1634         (WebThemeEngineDRTWin::paintScrollbarTrack):
1635         (WebThemeEngineDRTWin::paintSpinButton):
1636         (WebThemeEngineDRTWin::paintTextField):
1637         (WebThemeEngineDRTWin::paintTrackbar):
1638         (WebThemeEngineDRTWin::paintProgressBar):
1639         (WebThemeEngineDRTWin::getSize):
1640         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1641         (WebThemeEngineDRTWin):
1642         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1643
1644 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
1645
1646         [EFL] canvas-fallback-content.html is failing
1647         https://bugs.webkit.org/show_bug.cgi?id=111998
1648
1649         Reviewed by Chris Fleizach.
1650
1651         Adds support for getting platform name.
1652
1653         * DumpRenderTree/TestRunner.cpp:
1654         (TestRunner::staticValues):
1655         * DumpRenderTree/TestRunner.h:
1656         (TestRunner):
1657         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1658         (TestRunner::platformName):
1659
1660 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1661
1662         [chromium] move WebThemeEngine implementations to TestRunner library
1663         https://bugs.webkit.org/show_bug.cgi?id=112751
1664
1665         Reviewed by Adam Barth.
1666
1667         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1668         * DumpRenderTree/DumpRenderTree.gypi:
1669         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1670         (WebKit):
1671         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1672         (WebTestRunner::TestInterfaces::themeEngine):
1673         (WebTestRunner):
1674         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1675         (WebKit):
1676         (TestInterfaces):
1677         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1678         (WebTestRunner::WebTestInterfaces::themeEngine):
1679         (WebTestRunner):
1680         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1681         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1682         (WebTestRunner):
1683         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1684         (WebTestRunner::WebTestThemeControlWin::box):
1685         (WebTestRunner::WebTestThemeControlWin::line):
1686         (WebTestRunner::WebTestThemeControlWin::triangle):
1687         (WebTestRunner::WebTestThemeControlWin::roundRect):
1688         (WebTestRunner::WebTestThemeControlWin::oval):
1689         (WebTestRunner::WebTestThemeControlWin::circle):
1690         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1691         (WebTestRunner::WebTestThemeControlWin::markState):
1692         (WebTestRunner::WebTestThemeControlWin::draw):
1693         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1694         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1695         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1696         (WebTestRunner):
1697         (WebTestThemeControlWin):
1698         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1699         (WebTestRunner):
1700         (WebTestThemeEngineMac):
1701         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1702         (+[FakeActiveWindow alwaysActiveWindow]):
1703         (+[FakeActiveWindow alwaysInactiveWindow]):
1704         (-[FakeActiveWindow initWithActiveControls:]):
1705         (-[FakeActiveWindow _hasActiveControls]):
1706         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1707         (WebTestRunner):
1708         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1709         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1710         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1711         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1712         (WebTestRunner):
1713         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1714         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1715         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1716         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1717         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1718         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1719         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1720         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1721         (WebTestRunner::WebTestThemeEngineWin::getSize):
1722         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1723         (WebTestRunner):
1724         (WebTestThemeEngineWin):
1725         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1726         * DumpRenderTree/chromium/TestShell.cpp:
1727         (TestShell::initialize):
1728         * DumpRenderTree/chromium/TestShell.h:
1729         (WebKit):
1730         * DumpRenderTree/chromium/TestShellMac.mm:
1731         (platformInit):
1732         * DumpRenderTree/chromium/TestShellWin.cpp:
1733         (platformInit):
1734         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1735
1736 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1737
1738         [EFL][WK2] Separate WebView further from EwkView
1739         https://bugs.webkit.org/show_bug.cgi?id=111591
1740
1741         Reviewed by Caio Marcelo de Oliveira Filho.
1742
1743         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
1744         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
1745         since we can afford it having EWKViewGetWKView() private API to access WKView.
1746
1747         * TestWebKitAPI/PlatformWebView.h:
1748         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1749         (TestWebKitAPI::TEST):
1750         * TestWebKitAPI/efl/PlatformWebView.cpp:
1751         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1752         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1753         (TestWebKitAPI::PlatformWebView::resizeTo):
1754         (TestWebKitAPI::PlatformWebView::page):
1755         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
1756         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1757         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1758         * WebKitTestRunner/PlatformWebView.h:
1759         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1760         (WTR::EventSenderProxy::dispatchEvent):
1761         (WTR::EventSenderProxy::keyDown):
1762         (WTR::EventSenderProxy::sendTouchEvent):
1763         (WTR::EventSenderProxy::setTouchModifier):
1764         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1765         (WTR::PlatformWebView::PlatformWebView):
1766         (WTR::PlatformWebView::~PlatformWebView):
1767         (WTR::PlatformWebView::resizeTo):
1768         (WTR::PlatformWebView::page):
1769         (WTR::PlatformWebView::focus):
1770         (WTR::PlatformWebView::windowSnapshotImage):
1771
1772 2013-03-19  Roger Fong  <roger_fong@apple.com>
1773
1774         Changes to VS2010 project files should only trigger builds on Windows bots.
1775         https://bugs.webkit.org/show_bug.cgi?id=112731
1776
1777         Reviewed by Timothy Horton.
1778
1779         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1780         (_should_file_trigger_build):
1781
1782 2013-03-19  Roger Fong  <roger_fong@apple.com>
1783
1784         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
1785
1786         * Scripts/webkitpy/tool/steps/runtests.py:
1787         (RunTests.run):
1788         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1789         (RunTestsTest.test_webkit_run_unit_tests):
1790
1791 2013-03-19  Julie Parent  <jparent@chromium.org>
1792
1793         Dashboards: Introduce history namespace and unit tests.
1794         https://bugs.webkit.org/show_bug.cgi?id=112645
1795
1796         Reviewed by Ojan Vafai.
1797         
1798         Laying the framework for introducing the new history object and
1799         namespace.  This moves only static functions into the history
1800         namespace, and moves corresponding unit tests into seperate
1801         unit test file.
1802
1803         * TestResultServer/static-dashboards/aggregate_results.html:
1804         * TestResultServer/static-dashboards/dashboard_base.js:
1805         (parseCrossDashboardParameters):
1806         (parseDashboardSpecificParameters):
1807         (parseParameters):
1808         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1809         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1810         (.switch.return):
1811         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1812         * TestResultServer/static-dashboards/history.js: Added.
1813         * TestResultServer/static-dashboards/history_unittests.js: Added.
1814         * TestResultServer/static-dashboards/loader.js:
1815         (.):
1816         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1817         * TestResultServer/static-dashboards/run-unittests.html:
1818         * TestResultServer/static-dashboards/timeline_explorer.html:
1819         * TestResultServer/static-dashboards/timeline_explorer.js:
1820         * TestResultServer/static-dashboards/treemap.html:
1821         * TestResultServer/static-dashboards/treemap.js:
1822         (.switch.return):
1823         * TestResultServer/static-dashboards/ui.js:
1824
1825 2013-03-19  Daniel Bates  <dbates@webkit.org>
1826
1827         svn-apply has trouble applying a patch that adds a Windows newline to EOF
1828         https://bugs.webkit.org/show_bug.cgi?id=112732
1829
1830         Reviewed by Eric Seidel.
1831
1832         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
1833         of an existing file cannot be applied.
1834
1835         In particular, svn-{apply, unapply} compensate for differences in line endings
1836         by converting the line endings in a diff to match the line endings in the target
1837         file. The diff(1) command precedes the last line of a diff that adds a newline
1838         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
1839         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
1840         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
1841         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
1842         the newline characters in this special character sequence to match the line endings
1843         in the target file.
1844
1845         * Scripts/VCSUtils.pm:
1846         (parseDiff):
1847         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1848         Added tests:
1849             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
1850             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
1851             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
1852             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
1853         (escapeNewLineCharacters): Added.
1854         (toMacLineEndings): Added.
1855
1856 2013-03-19  James Robinson  <jamesr@chromium.org>
1857
1858         [chromium] Remove compositor settings that don't go through WebKit
1859         https://bugs.webkit.org/show_bug.cgi?id=112718
1860
1861         Reviewed by Adam Barth.
1862
1863         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1864         (main):
1865         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1866         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1867         (WebTestRunner::WebPreferences::reset):
1868         (WebTestRunner::WebPreferences::applyTo):
1869         * DumpRenderTree/chromium/TestShell.cpp:
1870         (TestShell::TestShell):
1871         (TestShell::resetWebSettings):
1872         * DumpRenderTree/chromium/TestShell.h:
1873         (TestShell):
1874
1875 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
1876
1877         Unreviewed, rolling out r146101.
1878         https://bugs.webkit.org/show_bug.cgi?id=111884
1879
1880         re-enable custom freetype on asan; this needs to be on
1881         now that the bot is running lucid.
1882
1883         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1884
1885 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
1886
1887         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
1888         https://bugs.webkit.org/show_bug.cgi?id=112365
1889
1890         Reviewed by Benjamin Poulain.
1891
1892         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
1893         harcoding it in wtf/Platform.h
1894
1895         * Scripts/webkitperl/FeatureList.pm:
1896
1897 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1898
1899         [Qt] Make ImageDiff similar to Chromium's ImageDiff
1900         https://bugs.webkit.org/show_bug.cgi?id=94782
1901
1902         Based on patch by Csaba Osztrogonác.
1903         Reviewed by Jocelyn Turcotte.
1904
1905         The diff image is generated with bright red indicating errors, but letting the base image
1906         shine through so the context of the error-pixel can be identified.
1907
1908         * DumpRenderTree/qt/ImageDiff.cpp:
1909         (main):
1910
1911 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
1912
1913         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
1914
1915         Rubber-stamped by Csaba Osztrogonác.
1916
1917         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
1918         since the latter might not cover the former.
1919
1920         * QtTestBrowser/launcherwindow.cpp:
1921         (LauncherWindow::print):
1922
1923 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
1924
1925         Style tweeks to default.css.
1926         
1927         Rubber-stamped by David Kilzer.
1928         
1929         Give visited links a different color to other links, so you can
1930         see which builds you've viewed.
1931         
1932         Make the <small> text less tiny.
1933
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1935         (small):
1936         (a:link,a:visited,a:active):
1937         (a:visited):
1938
1939 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
1940
1941         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
1942         https://bugs.webkit.org/show_bug.cgi?id=112494
1943
1944         Reviewed by Dirk Pranke.
1945
1946         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
1947         Also merged two pairs of methods to cleanup the code.
1948
1949         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1950         (PerfTestsRunner.run): Merged _upload_and_show_results.
1951         (PerfTestsRunner._generate_results): Merged _generate_output_files.
1952
1953 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
1954
1955         [chromium] build xdisplaycheck when building DRT
1956         https://bugs.webkit.org/show_bug.cgi?id=112636
1957
1958         Reviewed by Tony Chang.
1959
1960         It appears that we need xdisplaycheck to be built in order for
1961         Xvfb to be started correctly on the bots, and DRT was missing
1962         a dependency on it. This may be the cause of the ASAN bot not
1963         starting up properly (it only builds DRT).
1964
1965         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1966
1967 2013-03-18  David Levin  <levin@chromium.org>
1968
1969         Implement icon change notification dump for Chromium's test shell.
1970         https://bugs.webkit.org/show_bug.cgi?id=112614
1971
1972         This was previously implemented for some other platforms in r58111
1973         and r116547.
1974
1975         In r122806, fast/dom/icon-url-property.html stopped using it, but
1976         it is useful for tests, so I plan to re-add it to that test again.
1977
1978         Reviewed by Jochen Eisinger.
1979
1980         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1981         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
1982          icon change notifications from WebKit may be logged in test output.
1983         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1984         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
1985         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
1986         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
1987         (WebTestRunner):
1988         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
1989         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1990         (TestRunner):
1991         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1992         (WebTestRunner::WebTestProxyBase::didChangeIcon):
1993         (WebTestRunner):
1994         * DumpRenderTree/chromium/WebViewHost.cpp:
1995         (WebViewHost::didChangeIcon): Add the output about changing the icon.
1996         * DumpRenderTree/chromium/WebViewHost.h:
1997         (WebViewHost):
1998
1999 2013-03-18  Julie Parent  <jparent@chromium.org>
2000
2001         Cleanup: Move js for treemap and aggregate_results into own js files.
2002         https://bugs.webkit.org/show_bug.cgi?id=112618
2003
2004         Reviewed by Dirk Pranke.
2005         
2006         No functional changes, just moving the code into separate js file
2007         rather than inlined in the html, so we can test it, make it more
2008         modular, etc.  Other dashboard types are already done this way.
2009
2010         * TestResultServer/static-dashboards/aggregate_results.html:
2011         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2012         (generatePage):
2013         (handleValidHashParameter):
2014         (htmlForBuilder):
2015         (rawValuesHTML):
2016         (chartHTML):
2017         (filteredValues):
2018         (chart):
2019         (htmlForRevisionRows):
2020         (wrapHTMLInTable):
2021         (htmlForSummaryTable):
2022         (valuesPerExpectation):
2023         (htmlForTestType):
2024         (htmlForTableRow):
2025         (extendedEncode):
2026         * TestResultServer/static-dashboards/treemap.html:
2027         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2028         (humanReadableTime):
2029         (convertToWebTreemapFormat):
2030         (reverseSortByAverage):
2031         (generatePage):
2032         (focusPath):
2033         (.switch.return):
2034         (handleQueryParameterChange):
2035         (extractName):
2036         (fullName):
2037         (handleFocus.):
2038         (handleFocus):
2039
2040 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2041
2042         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2043         https://bugs.webkit.org/show_bug.cgi?id=112622
2044
2045         Reviewed by Dirk Pranke.
2046
2047         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2048         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2049
2050 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2051
2052         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2053         https://bugs.webkit.org/show_bug.cgi?id=112619
2054
2055         Reviewed by Dirk Pranke.
2056
2057         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2058         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2059
2060         * Scripts/webkitpy/layout_tests/port/gtk.py:
2061         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2062         Port._webkit_baseline_path method.
2063         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2064         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2065         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2066         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2067         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2068         that are expected based on the builder name.
2069
2070 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2071
2072         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2073         https://bugs.webkit.org/show_bug.cgi?id=112571
2074
2075         Reviewed by Adam Barth.
2076
2077         Update function declarations for new WebFileSystemType enum. (All
2078         changes are behind an #ifdef so we can sync required changes in embedders.)
2079
2080         * DumpRenderTree/chromium/WebViewHost.cpp:
2081         (WebViewHost::openFileSystem):
2082         (WebViewHost::deleteFileSystem):
2083         * DumpRenderTree/chromium/WebViewHost.h:
2084         (WebViewHost):
2085
2086 2013-03-18  Julie Parent  <jparent@chromium.org>
2087
2088         Cleanup: Move timeline_exporer js out of html file into js.
2089         https://bugs.webkit.org/show_bug.cgi?id=112188
2090
2091         Reviewed by Dirk Pranke.
2092         
2093         Moves the javascript out of the html file and into a new js file.
2094         This follows the format of flakiness_dashboard.{html|js}.
2095         
2096         Also moves code from dashboard_base that is used only by this one
2097         dashboard, and makes it private to the dashboard.
2098
2099         * TestResultServer/static-dashboards/dashboard_base.js:
2100         * TestResultServer/static-dashboards/timeline_explorer.html:
2101         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2102         (generatePage):
2103         (initCurrentBuilderTestResults):
2104         (shouldShowWebKitRevisionsOnly):
2105         (updateTimelineForBuilder.):
2106         (updateTimelineForBuilder):
2107         (selectBuild):
2108         (updateBuildIndicator):
2109         (.addRow):
2110         (.addNumberRow):
2111         (.inspectorNode.getElementsByTagName.0.onclick):
2112         (.inspectorNode.getElementsByTagName.1.onclick):
2113         (.inspectorNode.getElementsByTagName.2.onclick):
2114         (updateBuildInspector):
2115         (showResultsDelta):
2116         (decompressResults.addFlakyDelta):
2117         (decompressResults):
2118
2119 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2120
2121         Unreviewed, rolling out r145272.
2122         http://trac.webkit.org/changeset/145272
2123         https://bugs.webkit.org/show_bug.cgi?id=111884
2124
2125         Turns out the ASAN build is still broken; possibly there's
2126         something still setting LD_LIBRARY_PATH, or possibly there's
2127         something else wrong. In the meantime, we need it to work again.
2128
2129         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2130
2131 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2132
2133         delete-stale-build-files is too aggressive
2134         https://bugs.webkit.org/show_bug.cgi?id=112595
2135
2136         Reviewed by Tim Horton.
2137
2138         It appears that whitelisting file extensions to keep is not a good idea.
2139         Blacklist files to delete instead, and only delete .o files for now.
2140         We can add more file extensions as needed.
2141
2142         * BuildSlaveSupport/delete-stale-build-files:
2143
2144 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2145
2146         Disable accessibility notifications after each test
2147         https://bugs.webkit.org/show_bug.cgi?id=112579
2148
2149         Reviewed by Tim Horton.
2150         
2151         In WebKitTestRunner, if any tests triggered accessibility notifications,
2152         the global notification handler would thereafter be active, and fire
2153         notifications for all subsequent tests.
2154         
2155         Fix by implementing AccessibilityController::resetToConsistentState() for
2156         Mac, and using it to clear the global notification handler.
2157
2158         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2159         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2160         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2161         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2162         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2163         (e.g. because of -autorelease).
2164         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2165         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2166         if there is one.
2167         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2168         Add -stopObserving
2169         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2170         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2171         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2172         center.
2173
2174 2013-03-18  Dana Jansens  <danakj@chromium.org>
2175
2176         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2177         https://bugs.webkit.org/show_bug.cgi?id=112392
2178
2179         Reviewed by James Robinson.
2180
2181         Removes the command line flag option from DRT.
2182
2183         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2184         (main):
2185
2186 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2187
2188         [GTK] plugins/plugin-clip-subframe.html is failing
2189         https://bugs.webkit.org/show_bug.cgi?id=112570
2190
2191         Reviewed by Martin Robinson.
2192
2193         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2194
2195 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2196
2197         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2198         https://bugs.webkit.org/show_bug.cgi?id=112442
2199
2200         Reviewed by Gustavo Noronha Silva.
2201
2202         * GtkLauncher/main.c:
2203         (reloadCb):
2204         (createToolbar):
2205         (createWindow):
2206
2207 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2208
2209         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2210         https://bugs.webkit.org/show_bug.cgi?id=112205
2211
2212         Disable this API test until Geoff can fix it.
2213
2214         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2215         (TestWebKitAPI::TEST):
2216
2217 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2218
2219         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2220         https://bugs.webkit.org/show_bug.cgi?id=112478
2221
2222         Reviewed by Tony Chang.
2223
2224         There is nothing that ensures that the log messages from the plugin
2225         come in before the layout test finished loading.
2226
2227         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2228         (PassDifferentNPPStruct::NPP_SetWindow):
2229         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2230         (NPP_SetWindow):
2231
2232 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2233
2234         Have the mac port support per_test_timeout in webkitpy
2235         https://bugs.webkit.org/show_bug.cgi?id=112466
2236
2237         Reviewed by Dirk Pranke.
2238         
2239         Both WTR and DRT handle --timeout arguments, so we can
2240         have the scripts pass the timeout values down to the tools.
2241
2242         * Scripts/webkitpy/layout_tests/port/mac.py:
2243         (MacPort.supports_per_test_timeout):
2244
2245 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2246
2247         Remove setAsynchronousSpellCheckingEnabled from test runners
2248         https://bugs.webkit.org/show_bug.cgi?id=112362
2249
2250         Reviewed by Tony Chang.
2251
2252         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2253         in internals.settings, so all ports can share it.
2254
2255         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2256         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2257         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2258         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2259         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2260         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2261         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2262         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2263         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2264         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2265         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2266         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2267
2268 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2269
2270         Fix the stupid unit tests.
2271
2272         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2273         (test_sample_process):
2274
2275 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2276
2277         Collect samples for unresponsive web processes
2278         https://bugs.webkit.org/show_bug.cgi?id=112409
2279
2280         Reviewed by Tim Horton.
2281         
2282         When we detect that a subprocess was unresponsive, run the 'sample'
2283         tool on that process, for the Mac port.
2284         
2285         The sample will be linked to from the results.html page, next
2286         to the crash log link.
2287
2288         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2289         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2290         look for samples on disk.
2291         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2292         (TestResultWriter):
2293         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2294         -sample.txt files, and have it copy their contents to a new file
2295         next to the test that spawned them (as we do for crash logs).
2296         * Scripts/webkitpy/layout_tests/port/base.py:
2297         (Port.look_for_new_samples): Base class does nothing for sampling.
2298         * Scripts/webkitpy/layout_tests/port/driver.py:
2299         (Driver._check_for_driver_crash): Kick off a sample if we detected
2300         that the subprocess was unresponsive.
2301         * Scripts/webkitpy/layout_tests/port/mac.py:
2302         (MacPort.sample_file_path): Utility to generate the file path
2303         to the generated sample files at the top level of layout-test-results.
2304         (MacPort.look_for_new_crash_logs): Fix typo
2305         (MacPort.look_for_new_samples): New function to find sample files.
2306         (MacPort.sample_process): Use the utility function to get the file path.
2307
2308 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2309
2310         [Qt] Remove simple getters and setters from TestRunnerQt
2311         https://bugs.webkit.org/show_bug.cgi?id=112343
2312
2313         Reviewed by Benjamin Poulain.
2314
2315         The removed functions and boolean members
2316         are being replaced by the implementations in the
2317         generic TestRunner.h.
2318
2319         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2320         (DumpRenderTree::dumpFrameScrollPosition):
2321         (DumpRenderTree::dumpFramesAsText):
2322         (DumpRenderTree::dump):
2323         (DumpRenderTree::titleChanged):
2324         (DumpRenderTree::dumpDatabaseQuota):
2325         (DumpRenderTree::dumpApplicationCacheQuota):
2326         (DumpRenderTree::statusBarMessage):
2327         (DumpRenderTree::createWindow):
2328         * DumpRenderTree/qt/TestRunnerQt.cpp:
2329         (TestRunnerQt::reset):
2330         * DumpRenderTree/qt/TestRunnerQt.h:
2331         (TestRunnerQt):
2332
2333 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2334
2335         Update the link on build.webkit.org to refer to perf.webkit.org
2336         https://bugs.webkit.org/show_bug.cgi?id=112416
2337
2338         Reviewed by Philip Rogers.
2339
2340         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2341
2342         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2343
2344 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2345
2346         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2347         https://bugs.webkit.org/show_bug.cgi?id=112394
2348
2349         Reviewed by Philippe Normand.
2350
2351         * GtkLauncher/main.c:
2352         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2353
2354 2013-03-14  Andreas Kling  <akling@apple.com>
2355
2356         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2357         <http://webkit.org/b/111815>
2358         <rdar://problem/13380145>
2359
2360         Reviewed by Anders Carlsson.
2361
2362         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2363         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2364         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2365
2366         * WebKitTestRunner/PlatformWebView.h:
2367         (PlatformWebView):
2368         * WebKitTestRunner/TestController.cpp:
2369         (WTR::TestController::createOtherPage):
2370         (WTR::TestController::createWebViewWithOptions):
2371         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2372         (WTR::PlatformWebView::didInitializeClients):
2373
2374 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2375
2376         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2377         https://bugs.webkit.org/show_bug.cgi?id=112122
2378
2379         Reviewed by Kenneth Rohde Christiansen.
2380
2381         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2382
2383         * MiniBrowser/efl/main.c:
2384         (_Browser_Window):
2385         (search_box_show):
2386         (search_box_hide):
2387         (on_key_down):
2388         (on_url_changed):
2389         (on_search_field_aborted):
2390         (on_search_field_activated):
2391         (on_search_field_clicked):
2392         (on_search_backward_button_clicked):
2393         (on_search_forward_button_clicked):
2394         (window_create):
2395
2396 2013-03-14  Julie Parent  <jparent@chromium.org>
2397
2398         Cleanup: Remove g_resourceLoader.
2399         https://bugs.webkit.org/show_bug.cgi?id=112305
2400
2401         Reviewed by Dirk Pranke.
2402         
2403         Removing another global.
2404         
2405         Now, each dashboard creates its own loader, rather than having
2406         a general global one.
2407         
2408         Remove usage of g_resourceLoader.isLoadingComplete from 
2409         handleLocationChange by ensuring that handleLocationChange is
2410         never called before the loader is done.  It was called in two
2411         places before: 1 was from the callback when the loader is done,
2412         so that was obviously true, and the other was from onhashchange,
2413         where it would just return rather than running.  Instead, lets
2414         only register the onhashchange handler once the loader is
2415         setup, so the check is no longer necessary.
2416         
2417         Remove isLoadingComplete since it is now unused.
2418         
2419         Callback for loader is now initializeHistory, rather than just
2420         handleLocationChange which will set up the hashchange handler now.
2421         This will all eventually be moving to a new History object.
2422
2423         * TestResultServer/static-dashboards/aggregate_results.html:
2424         * TestResultServer/static-dashboards/dashboard_base.js:
2425         (handleLocationChange):
2426         (intializeHistory):
2427         (decompressResults):
2428         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2429         (generatePage):
2430         * TestResultServer/static-dashboards/loader.js:
2431         (.):
2432         * TestResultServer/static-dashboards/loader_unittests.js:
2433         * TestResultServer/static-dashboards/timeline_explorer.html:
2434         * TestResultServer/static-dashboards/treemap.html:
2435
2436 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
2437
2438         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
2439         https://bugs.webkit.org/show_bug.cgi?id=109404
2440
2441         Reviewed by Tony Chang.
2442
2443         Removes all the code related to smartInsertDeleteEnabled and
2444         selectTrailingWhitespaceEnabled settings as they will be managed from
2445         internals from now on.
2446
2447         * DumpRenderTree/TestRunner.cpp:
2448         (TestRunner::staticFunctions):
2449         * DumpRenderTree/TestRunner.h:
2450         (TestRunner):
2451         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2452         (WebKit):
2453         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2454         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2455         (DumpRenderTree):
2456         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2457         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2458         (WebTestRunner::WebTestProxy::didStopLoading):
2459         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2460         (WebTestRunner::TestRunner::TestRunner):
2461         (WebTestRunner::TestRunner::reset):
2462         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2463         (TestRunner):
2464         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2465         (WebTestRunner::WebPreferences::applyTo): Set default values for
2466         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
2467         Chromium DRT default values are different from Chromium browser.
2468         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2469         * DumpRenderTree/chromium/WebViewHost.cpp:
2470         * DumpRenderTree/chromium/WebViewHost.h:
2471         (WebViewHost):
2472         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2473         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2474         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2475         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2476         (resetDefaultsToConsistentValues):
2477         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2478         * DumpRenderTree/mac/DumpRenderTree.mm:
2479         (resetWebViewToConsistentStateBeforeTesting):
2480         * DumpRenderTree/mac/TestRunnerMac.mm:
2481         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2482         (WebCore::WebPage::resetSettings):
2483         * DumpRenderTree/qt/TestRunnerQt.cpp:
2484         * DumpRenderTree/qt/TestRunnerQt.h:
2485         (TestRunnerQt):
2486         * DumpRenderTree/win/DumpRenderTree.cpp:
2487         (resetWebViewToConsistentStateBeforeTesting):
2488         * DumpRenderTree/win/TestRunnerWin.cpp:
2489         * DumpRenderTree/wx/TestRunnerWx.cpp:
2490
2491 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2492
2493         [Qt] Disable DRT on Windows
2494
2495         Reviewed by Jocelyn Turcotte.
2496
2497         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
2498
2499         * qmake/mkspecs/features/configure.prf:
2500
2501 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2502
2503         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
2504         https://bugs.webkit.org/show_bug.cgi?id=110728
2505
2506         Reviewed by Gyuyoung Kim.
2507
2508         Use the page group to create the view object.
2509
2510         * MiniBrowser/efl/main.c:
2511         (window_create):
2512
2513 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2514
2515         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
2516
2517         Reviewed by Tor Arne Vestbø.
2518
2519         The mock versions of these web facing features should be instantiated when
2520         running in DumpRenderTree only. In order for them to work, no extra Qt modules
2521         such as QtLocation are actually needed.
2522
2523         This patch decouples enabling device orientation/motion and geolocation from
2524         the underlying Qt modules and makes them available in developer builds
2525         (!production_build) and backed by mock backends when running in drt.
2526
2527         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
2528         developers the web facing features are always enabled (although requests will
2529         time out) and the mock backends are enabled inside DRT, allowing for the layout
2530         tests to run with less dependencies.
2531
2532         In addition this also enables the mock device motion client, which was
2533         previously never instantiated.
2534
2535         * qmake/mkspecs/features/features.prf:
2536
2537 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2538
2539         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
2540         https://bugs.webkit.org/show_bug.cgi?id=112340
2541
2542         Reviewed by Simon Hausmann.
2543
2544         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2545         (DumpRenderTree::dump):
2546             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
2547         (DumpRenderTree::dumpApplicationCacheQuota):
2548         * DumpRenderTree/qt/TestRunnerQt.cpp:
2549         (TestRunnerQt::reset):
2550         * DumpRenderTree/qt/TestRunnerQt.h:
2551         (TestRunnerQt):
2552
2553 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2554
2555         [Qt] Port DRT to use TestRunner::dumpAsText()
2556         https://bugs.webkit.org/show_bug.cgi?id=112260
2557
2558         Reviewed by Benjamin Poulain.
2559
2560         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2561         (WebCore::DumpRenderTree::open):
2562         (WebCore::methodNameStringForFailedTest):
2563             Change parameter from type TestRunnerQt* to TestRunner*.
2564         (WebCore::DumpRenderTree::dump):
2565             TestRunnerQt::shouldDumpPixels() always returned true in our case.
2566             Instead we should rely on TestRunner::generatePixelResults().
2567         * DumpRenderTree/qt/TestRunnerQt.cpp:
2568         (TestRunnerQt::reset):
2569         * DumpRenderTree/qt/TestRunnerQt.h:
2570         (TestRunnerQt):
2571
2572 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2573
2574         Implement FontLoader interface
2575         https://bugs.webkit.org/show_bug.cgi?id=98395
2576
2577         Reviewed by Eric Seidel.
2578
2579         Enable FontLoadEvents runtime flag for TestShell.
2580
2581         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2582         (WebTestRunner::TestInterfaces::TestInterfaces):
2583
2584 2013-03-13  Julie Parent  <jparent@chromium.org>
2585
2586         CLeanup: remove unnecessary call to parseParameters.
2587         https://bugs.webkit.org/show_bug.cgi?id=112309
2588
2589         Reviewed by Ojan Vafai.
2590         
2591         We call parseCrossDashboardParameters when the dashboard initially
2592         loads to set the state required for loadBuildersList, and then we
2593         call it again once we are fully done with loading, so there is no
2594         reason to call it in the middle of the loading process here.
2595
2596         * TestResultServer/static-dashboards/loader.js:
2597         (.):
2598
2599 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
2600
2601         Unreviewed. Now I'm a reviewer :)
2602
2603         * Scripts/webkitpy/common/config/committers.py:
2604
2605 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
2606
2607         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
2608         https://bugs.webkit.org/show_bug.cgi?id=112277
2609
2610         Reviewed by Adam Barth.
2611
2612         * Scripts/webkitperl/FeatureList.pm:
2613         * qmake/mkspecs/features/features.pri:
2614
2615 2013-03-13  Adam Barth  <abarth@webkit.org>
2616
2617         run-perf-tests should support content_shell
2618         https://bugs.webkit.org/show_bug.cgi?id=112291
2619
2620         Reviewed by Eric Seidel.
2621
2622         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2623         (PerfTestsRunner._parse_args):
2624
2625 2013-03-13  Oliver Hunt  <oliver@apple.com>
2626
2627         Simplify Checked<> multiplication
2628         https://bugs.webkit.org/show_bug.cgi?id=112286
2629
2630         Reviewed by James Robinson.
2631
2632         Add tests for multiplication by zero and max to ensure we don't
2633         mess them up should we ever make changes to Checked<> in future.
2634
2635         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2636         (TestWebKitAPI):
2637
2638 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2639
2640         [Qt] Unreviewed prospective Windows build fix
2641
2642         Do the usual thing, include the moc generated code in the .cpp file instead
2643         of compiling it standalone, to ensure that config.h is included, too, and
2644         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
2645
2646         * DumpRenderTree/qt/EventSenderQt.cpp:
2647
2648 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2649
2650         [Qt] Port TestRunner::findString to shared interface
2651         https://bugs.webkit.org/show_bug.cgi?id=112147
2652
2653         Reviewed by Jocelyn Turcotte.
2654
2655         This patch also removes DumpRenderTree and some other helper classes from
2656         the WebCore namespace, to which they do not really belong.
2657
2658         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2659         (main):
2660         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2661         (DumpRenderTree::DumpRenderTree):
2662         (DumpRenderTree::~DumpRenderTree):
2663         (DumpRenderTree::instance):
2664         (DumpRenderTree::setShouldTimeout):
2665         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2666         (DumpRenderTree):
2667         * DumpRenderTree/qt/EventSenderQt.cpp:
2668         (EventSender::contextClick):
2669         (EventSender::sendEvent):
2670         (EventSender::postEvent):
2671         * DumpRenderTree/qt/EventSenderQt.h:
2672         (EventSender::isGraphicsBased):
2673         * DumpRenderTree/qt/TestRunnerQt.cpp:
2674         (TestRunnerQt::TestRunnerQt):
2675         (TestRunner::findString):
2676         (TestRunnerQt::setMockDeviceOrientation):
2677         (TestRunnerQt::setGeolocationPermission):
2678         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
2679         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
2680         (TestRunnerQt::setMockGeolocationPosition):
2681         * DumpRenderTree/qt/TestRunnerQt.h:
2682         (TestRunnerQt):
2683
2684 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
2685
2686         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
2687         https://bugs.webkit.org/show_bug.cgi?id=112129
2688
2689         Reviewed by Adam Barth.
2690
2691         Following Chromium
2692         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
2693         this is being renamed to better explain what it does.
2694
2695         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2696
2697 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2698
2699         [Qt] Unreviewed trivial typo fix
2700
2701         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
2702         TextRunner.h. Thanks Zeno :)
2703
2704 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
2705
2706         [Qt] Prepare DRT for transition to shared TestRunner interface
2707         https://bugs.webkit.org/show_bug.cgi?id=112144
2708
2709         Reviewed by Benjamin Poulain.
2710
2711         Prepare Qt's DRT for a transition from the QObject based TestRunner to
2712         the JSC C API based one.
2713
2714         This is impplemented by instantiating the QObject based testRunner in
2715         the global object, then instantiating the JSC C based TestRunner
2716         separately and placing it "behind" the QObject based testRunner through
2717         injection of the individual functions through proxies. (prototype
2718         chaining doesn't work due to the this object and Function.prototype.bind
2719         doesn't work due to the native function)
2720
2721         This allows for porting over method by method by removing the method
2722         from the QObject TestRunnerQt and implementing it in the JSC C based
2723         TestRunner.
2724
2725         In order for this to link and run dummy implementations of all the
2726         necessary TestRunner functions are provided.
2727
2728         * DumpRenderTree/qt/DumpRenderTree.pro:
2729         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2730         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2731         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2732         (WebCore::DumpRenderTree::initJSObjects):
2733         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2734         (DumpRenderTree):
2735         * DumpRenderTree/qt/TestRunnerQt.cpp:
2736         (TestRunner::~TestRunner):
2737         (TestRunner::addDisallowedURL):
2738         (TestRunner::queueLoad):
2739         (TestRunner::removeAllVisitedLinks):
2740         (TestRunner::setAcceptsEditing):
2741         (TestRunner::simulateLegacyWebNotificationClick):
2742         (TestRunner::setWindowIsKey):
2743         (TestRunner::setAlwaysAcceptCookies):
2744         (TestRunner::addOriginAccessWhitelistEntry):
2745         (TestRunner::setWebViewEditable):
2746         (TestRunner::clearAllApplicationCaches):
2747         (TestRunner::setTextDirection):
2748         (TestRunner::notifyDone):
2749         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2750         (TestRunner::overridePreference):
2751         (TestRunner::pathToLocalResource):
2752         (TestRunner::removeAllWebNotificationPermissions):
2753         (TestRunner::simulateWebNotificationClick):
2754         (TestRunner::closeIdleLocalStorageDatabases):
2755         (TestRunner::focusWebView):
2756         (TestRunner::setBackingScaleFactor):
2757         (TestRunner::removeChromeInputField):
2758         (TestRunner::addChromeInputField):
2759         (TestRunner::originsWithLocalStorage):
2760         (TestRunner::deleteAllLocalStorage):
2761         (TestRunner::deleteLocalStorageForOrigin):
2762         (TestRunner::observeStorageTrackerNotifications):
2763         (TestRunner::syncLocalStorage):
2764         (TestRunner::windowCount):
2765         (TestRunner::setWaitToDump):
2766         (TestRunner::waitForPolicyDelegate):
2767         (TestRunner::webHistoryItemCount):
2768         (TestRunner::showWebInspector):
2769         (TestRunner::closeWebInspector):
2770         (TestRunner::evaluateInWebInspector):
2771         (TestRunner::setSerializeHTTPLoads):
2772         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2773         (TestRunner::setCustomPolicyDelegate):
2774         (TestRunner::setDatabaseQuota):
2775         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2776         (TestRunner::resetPageVisibility):
2777         (TestRunner::keepWebHistory):
2778         (TestRunner::goBack):
2779         (TestRunner::originsWithApplicationCache):
2780         (TestRunner::applicationCacheDiskUsageForOrigin):
2781         (TestRunner::display):
2782         (TestRunner::dispatchPendingLoadRequests):
2783         (TestRunner::clearPersistentUserStyleSheet):
2784         (TestRunner::callShouldCloseOnWebView):
2785         (TestRunner::copyDecodedHostName):
2786         (TestRunner::clearBackForwardList):
2787         (TestRunner::clearAllDatabases):
2788         (TestRunner::clearApplicationCacheForOrigin):
2789         (TestRunner::apiTestGoToCurrentBackForwardItem):
2790         (TestRunner::authenticateSession):
2791         (TestRunner::abortModal):
2792         (TestRunner::setStorageDatabaseIdleInterval):
2793         (TestRunner::setAsynchronousSpellCheckingEnabled):
2794         (TestRunner::setXSSAuditorEnabled):
2795         (TestRunner::setSpatialNavigationEnabled):
2796         (TestRunner::setScrollbarPolicy):
2797         (TestRunner::setJavaScriptCanAccessClipboard):
2798         (TestRunner::setAutomaticLinkDetectionEnabled):
2799         (TestRunner::setUserStyleSheetEnabled):
2800         (TestRunner::setUserStyleSheetLocation):
2801         (TestRunner::setUseDashboardCompatibilityMode):
2802         (TestRunner::setTabKeyCyclesThroughElements):
2803         (TestRunner::setSmartInsertDeleteEnabled):
2804         (TestRunner::setSelectTrailingWhitespaceEnabled):
2805         (TestRunner::setPrivateBrowsingEnabled):
2806         (TestRunner::setPluginsEnabled):
2807         (TestRunner::setPopupBlockingEnabled):
2808         (TestRunner::setMockSpeechInputDumpRect):
2809         (TestRunner::setPersistentUserStyleSheetLocation):
2810         (TestRunner::setMockGeolocationPosition):
2811         (TestRunner::setMockGeolocationPositionUnavailableError):
2812         (TestRunner::setMockDeviceOrientation):
2813         (TestRunner::setMainFrameIsFirstResponder):
2814         (TestRunner::setIconDatabaseEnabled):
2815         (TestRunner::setGeolocationPermission):
2816         (TestRunner::setDefersLoading):
2817         (TestRunner::setCacheModel):
2818         (TestRunner::setAuthorAndUserStylesEnabled):
2819         (TestRunner::setAllowFileAccessFromFileURLs):
2820         (TestRunner::setAppCacheMaximumSize):
2821         (TestRunner::setAllowUniversalAccessFromFileURLs):
2822         (TestRunner::setApplicationCacheOriginQuota):
2823         (TestRunner::denyWebNotificationPermission):
2824         (TestRunner::grantWebNotificationPermission):
2825         (TestRunner::setValueForUser):
2826         (TestRunner::setViewModeMediaFeature):
2827         (TestRunner::setPageVisibility):
2828         (TestRunner::addMockSpeechInputResult):
2829         (TestRunner::removeOriginAccessWhitelistEntry):
2830         (TestRunner::addUserScript):
2831         (TestRunner::isCommandEnabled):
2832         (TestRunner::evaluateScriptInIsolatedWorld):
2833         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
2834         (TestRunner::copyEncodedHostName):
2835         (TestRunner::addUserStyleSheet):
2836         (TestRunner::findString):
2837         (TestRunner::execCommand):
2838         (TestRunner::localStorageDiskUsageForOrigin):
2839
2840 2013-03-12  Julie Parent  <jparent@chromium.org>
2841
2842         Cleanup: Move flatten-trie to loader.
2843         https://bugs.webkit.org/show_bug.cgi?id=112196
2844
2845         Reviewed by Dirk Pranke.
2846
2847         flatten-trie is used only by the loader, so move it there and make it
2848         private, rather than global in dashbaord_base. Moved the corresponding
2849         unit test from flakiness_dashboard_unittests to loader_unittests.
2850         
2851         * TestResultServer/static-dashboards/dashboard_base.js:
2852         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2853         * TestResultServer/static-dashboards/loader.js:
2854         (.):
2855         * TestResultServer/static-dashboards/loader_unittests.js:
2856
2857 2013-03-12  Oliver Hunt  <oliver@apple.com>
2858
2859         Unbreak api tests
2860
2861         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2862         (TestWebKitAPI):
2863
2864 2013-03-12  Tim Horton  <timothy_horton@apple.com>
2865
2866         Unreviewed, disabling tests for Win EWS.
2867
2868         win-ews obviously cannot keep up with running tests, it's >300 behind.
2869         Probably doesn't help that its (likely) running tests serially.
2870
2871         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2872         (WinEWS):
2873
2874 2013-03-12  Tim Horton  <timothy_horton@apple.com>
2875
2876         Add a --build-directory argument to delete-stale-build-files
2877         https://bugs.webkit.org/show_bug.cgi?id=112198
2878
2879         Reviewed by Ryosuke Niwa.
2880
2881         * BuildSlaveSupport/delete-stale-build-files:
2882         (main): Add --build-directory argument.
2883
2884 2013-03-12  Oliver Hunt  <oliver@apple.com>
2885
2886         Appease MSVC
2887
2888         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2889         (TestWebKitAPI):
2890
2891 2013-03-12  Oliver Hunt  <oliver@apple.com>
2892
2893         Add more Checked<> tests
2894         https://bugs.webkit.org/show_bug.cgi?id=112190
2895
2896         Reviewed by Geoffrey Garen.
2897
2898         Tests!
2899
2900         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2901         (TestWebKitAPI):
2902
2903 2013-03-12  Julie Parent  <jparent@chromium.org>
2904
2905         Cleanup: Move loading complete function into callback, rather than global.
2906         https://bugs.webkit.org/show_bug.cgi?id=112167
2907
2908         Reviewed by Dirk Pranke.
2909         
2910         Stop calling global functions, pass in proper handler to Loader
2911         constructor. Note that the callback is optional, as tests, and
2912         some potential dashboards, do not need one.
2913
2914         * TestResultServer/static-dashboards/dashboard_base.js:
2915         * TestResultServer/static-dashboards/loader.js:
2916         (.):
2917         * TestResultServer/static-dashboards/loader_unittests.js:
2918
2919 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2920
2921         [EFL][WK2] Add popup menu support to MiniBrowser
2922         https://bugs.webkit.org/show_bug.cgi?id=108934
2923
2924         Reviewed by Kenneth Rohde Christiansen.
2925
2926         Implement popup menu support in MiniBrowser by handling popup_menu_show
2927         and popup_menu_hide smart functions on the view and using the Ewk popup
2928         menu API.
2929
2930         * MiniBrowser/efl/main.c:
2931         (_Browser_Window):
2932         (on_popup_menu_discarded):
2933         (on_popup_menu_item_clicked):
2934         (popup_menu_populate):
2935         (on_popup_menu_show):
2936         (on_popup_menu_hide):
2937         (window_create): Use calloc() instead of malloc() to allocate memory for
2938         Browser_Window. This makes sure all the structs members are initialized
2939         to 0 (such as the new elm_popup_menu pointer).
2940
2941 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
2942
2943         [GTK] Set up the libPlatformGtk.la library
2944         https://bugs.webkit.org/show_bug.cgi?id=111738
2945
2946         Reviewed by Martin Robinson.
2947
2948         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
2949         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
2950         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
2951
2952 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
2953
2954         [GTK] Enable Web Audio in development builds
2955         https://bugs.webkit.org/show_bug.cgi?id=111831
2956
2957         Reviewed by Philippe Normand.
2958
2959         Web Audio is already quite well supported on the GTK port but still has a few issues
2960         that must be addressed before it is enabled by default. Despite that it should be enabled
2961         in development builds just so we are up-to-date with future feature infrastructure changes.
2962         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
2963         that's an obvious goal before enabling the feature in release builds.
2964
2965         * Scripts/webkitperl/FeatureList.pm:
2966
2967 2013-03-11  Andreas Kling  <akling@apple.com>
2968
2969         [Mac][WK1] Add support for alert() in MiniBrowser.
2970         <http://webkit.org/b/112090>
2971
2972         Reviewed by Anders Carlsson.
2973
2974         * MiniBrowser/mac/WK1BrowserWindowController.m:
2975         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2976
2977 2013-03-11  Julie Parent  <jparent@chromium.org>
2978
2979         Dashboard cleanup: Create ui.Errors
2980         https://bugs.webkit.org/show_bug.cgi?id=111785
2981
2982         Reviewed by Ojan Vafai.
2983         
2984         Create ui.Errors for handling errors the dashboards
2985         encounter. Loader now has a Error object that it can add to,
2986         and individual dashboards can show errors when desired.
2987         Currently, only flakiness_db shows errors, but this is 
2988         generic and there is no reason why other dbs wouldn't want to
2989         show errors.
2990
2991         * TestResultServer/static-dashboards/dashboard_base.js:
2992         (resourceLoadingComplete):
2993         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2994         (generatePage):
2995         * TestResultServer/static-dashboards/loader.js:
2996         (.):
2997         * TestResultServer/static-dashboards/ui.js:
2998         (.):
2999
3000 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3001
3002         Some StringHasher tests are broken because of missing null termination
3003         https://bugs.webkit.org/show_bug.cgi?id=111284
3004
3005         Reviewed by Darin Adler.
3006
3007         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3008         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3009         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3010         the bug caught by it is now fixed.
3011
3012 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3013
3014         Unreviewed, rolling out r145200.
3015         http://trac.webkit.org/changeset/145200
3016         https://bugs.webkit.org/show_bug.cgi?id=112063
3017
3018         Broke a couple of unit tests (Requested by zdobersek on
3019         #webkit).
3020
3021         * Scripts/webkitperl/FeatureList.pm:
3022
3023 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3024
3025         [GTK] WebKit2-only build fails
3026         https://bugs.webkit.org/show_bug.cgi?id=112033
3027
3028         Reviewed by Gustavo Noronha Silva.
3029
3030         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3031         generic part, WebKit1-specific part and WebKit2-specific part.
3032         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3033         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3034         directly.
3035
3036 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3037
3038         Adding myself to the committers list.
3039
3040         Unreviewed.
3041
3042         * Scripts/webkitpy/common/config/committers.py:
3043
3044 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3045
3046         [BlackBerry] Disable MathML support
3047         https://bugs.webkit.org/show_bug.cgi?id=111929
3048
3049         Reviewed by Rob Buis.
3050
3051         * Scripts/webkitperl/FeatureList.pm:
3052
3053 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3054
3055         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3056         https://bugs.webkit.org/show_bug.cgi?id=111970
3057
3058         Reviewed by Chris Fleizach.
3059
3060         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3061         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3062         undefined symbol.
3063
3064         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3065         (WTR::AccessibilityUIElement::supportedActions):
3066         (WTR):
3067
3068 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3069
3070         [chromium] Android apk targets should depend directly on Java library targets
3071         https://bugs.webkit.org/show_bug.cgi?id=111746
3072
3073         Reviewed by Eric Seidel.
3074
3075         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3076         Make DumpRenderTree_apk depend directly on base_java and net_java.
3077         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3078         Make TestWebKitAPI_apk depend directly on base_java.
3079
3080 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3081
3082         [chromium] remove obsolete user gesture methods from WebFrame
3083         https://bugs.webkit.org/show_bug.cgi?id=111696
3084
3085         Reviewed by Adam Barth.
3086
3087         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3088         (WebTestRunner::TestPlugin::handleInputEvent):
3089         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3090
3091 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3092
3093         Unreviewed, add myself to commiters.py.
3094
3095         * Scripts/webkitpy/common/config/committers.py:
3096
3097 2013-03-08  Julie Parent  <jparent@chromium.org>
3098
3099         Cleanup: Remove dead code.
3100         https://bugs.webkit.org/show_bug.cgi?id=111900
3101
3102         Reviewed by Dirk Pranke.
3103         
3104         Treemap overrides a global function that used to be in 
3105         dashboard_base, but was removed months ago in
3106         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3107         no caller. 
3108
3109         * TestResultServer/static-dashboards/treemap.html:
3110
3111 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3112
3113         Implemented new API for RTCStatsReport object.
3114         https://bugs.webkit.org/show_bug.cgi?id=110333
3115
3116         Reviewed by Adam Barth.
3117
3118         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3119         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3120
3121 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3122
3123         [chromium] use custom freetype on linux asan builds again
3124         https://bugs.webkit.org/show_bug.cgi?id=111884
3125
3126         Reviewed by Tony Chang.
3127
3128         We no longer need the workaround after chromium r186540.
3129
3130         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3131
3132 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3133
3134         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3135         https://bugs.webkit.org/show_bug.cgi?id=111798
3136
3137         Reviewed by Dirk Pranke.
3138
3139         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3140
3141         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3142
3143 2013-03-08  James Robinson  <jamesr@chromium.org>
3144
3145         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3146         https://bugs.webkit.org/show_bug.cgi?id=111632
3147
3148         Reviewed by Adrienne Walker.
3149
3150         * DumpRenderTree/chromium/WebViewHost.cpp:
3151         (WebViewHost::initializeLayerTreeView):
3152         * DumpRenderTree/chromium/WebViewHost.h:
3153         (WebViewHost):
3154
3155 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3156
3157         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3158         https://bugs.webkit.org/show_bug.cgi?id=111297
3159
3160         Reviewed by Kenneth Rohde Christiansen.
3161
3162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3163         (WTR::TestRunner::setViewModeMediaFeature):
3164
3165 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3166
3167         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3168         https://bugs.webkit.org/show_bug.cgi?id=111814
3169
3170         Reviewed by Ryosuke Niwa.
3171
3172         Add the needed supportedActions() attribute to WKTestRunner.
3173
3174         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3175         (WTR::AccessibilityUIElement::supportedActions):
3176         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3177         (AccessibilityUIElement):
3178         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3179         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3180         (WTR::AccessibilityUIElement::supportedActions):
3181
3182 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3183
3184         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3185         https://bugs.webkit.org/show_bug.cgi?id=111851
3186
3187         Reviewed by Kenneth Rohde Christiansen.
3188
3189         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3190         (TestWebKitAPI::TEST):
3191
3192             Fixed WKURLRef instance leaking.
3193
3194 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3195
3196         [EFL] [WK2] Some authentication tests fail in WebKit2
3197         https://bugs.webkit.org/show_bug.cgi?id=106407
3198
3199         Reviewed by Kenneth Rohde Christiansen.
3200
3201         Add patch from upstream for libsoup 2.40 to fix several authentication
3202         test cases.
3203
3204         * efl/jhbuild.modules:
3205         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3206
3207 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3208
3209         [GTK] Enable Web Audio in development builds
3210         https://bugs.webkit.org/show_bug.cgi?id=111831
3211
3212         Reviewed by Philippe Normand.
3213
3214         Web Audio is already quite well supported on the GTK port but still has a few issues
3215         that must be addressed before it is enabled by default. Despite that it should be enabled
3216         in development builds just so we are up-to-date with future feature infrastructure changes.
3217         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3218         that's an obvious goal before enabling the feature in release builds.
3219
3220         * Scripts/webkitperl/FeatureList.pm:
3221
3222 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3223
3224         [chromium] delay clearing the TestRunners until the main view was deleted
3225         https://bugs.webkit.org/show_bug.cgi?id=111823
3226
3227         Reviewed by Eric Seidel.
3228
3229         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3230         This may call into the test runners which assume that the delegate is
3231         always non-NULL.
3232
3233         * DumpRenderTree/chromium/TestShell.cpp:
3234         (TestShell::~TestShell):
3235
3236 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3237
3238         Sheriffbot whois command can't search by full name
3239         https://bugs.webkit.org/show_bug.cgi?id=111825
3240
3241         Reviewed by Eric Seidel.
3242
3243         Allowed multiple arguments to Sheriffbot's whois command.
3244         Updated test expectations.
3245
3246         * Scripts/webkitpy/tool/bot/irc_command.py:
3247         (Whois.execute):
3248         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3249         (IRCCommandTest.test_whois):
3250
3251 2013-03-07  Nils Barth  <nbarth@chromium.org>
3252
3253         Add Nils Barth and Koji Hara to committers.py
3254         https://bugs.webkit.org/show_bug.cgi?id=111806
3255
3256         Reviewed by Eric Seidel.
3257
3258         * Scripts/webkitpy/common/config/committers.py:
3259
3260 2013-03-07  Glenn Adams  <glenn@skynav.com>
3261
3262         run-pert-tests should have a --test-runner-count option
3263         https://bugs.webkit.org/show_bug.cgi?id=111726
3264
3265         Reviewed by Ryosuke Niwa.
3266
3267         Add --test-runner-count option to run-perf-tests, with default value of 4.
3268         This option allows command line configuration of the number of times to invoke
3269         the test runner (serially, not in parallel) when running a specific test in
3270         a test set.
3271
3272         * Scripts/webkitpy/performance_tests/perftest.py:
3273         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3274         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3275         (PerfTest.run): Rename process_run_count to test_runner_count.
3276         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3277         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3278         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3279         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3280         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3281         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3282         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3283         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3284         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3285         (MainTest.test_run_with_repeat):
3286         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3287         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3288         (MainTest.test_default_args): Add test for default option argument values.
3289         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3290
3291 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3292
3293         Add myself to reviewers.py
3294         https://bugs.webkit.org/show_bug.cgi?id=111757
3295
3296         Reviewed by Eric Seidel.
3297
3298         * Scripts/webkitpy/common/config/committers.py:
3299
3300 2013-03-07  Glenn Adams  <glenn@skynav.com>
3301
3302         run-perf-tests should have a --repeat option
3303         https://bugs.webkit.org/show_bug.cgi?id=100030
3304
3305         Reviewed by Ryosuke Niwa.
3306
3307         Add --repeat option to run-perf-tests, with default value of 1. When greater
3308         than 1, runs test set specified number of times. Note that multiple runs are
3309         not aggregated for statistical purposes.
3310
3311         Incidentally fixed typo: s/suceeds/succeeds/.
3312
3313         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3314         (PerfTestsRunner._parse_args): Add repeat option.
3315         (PerfTestsRunner.run): Add outer repeat loop.
3316         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3317         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3318         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3319         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3320         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3321         (MainTest.test_run_with_json_output): Fix typo.
3322         (MainTest.test_run_with_description): Fix typo.
3323         (MainTest.test_run_respects_no_results): Fix typo.
3324         (MainTest.test_run_with_slave_config_json): Fix typo.
3325         (MainTest.test_run_with_multiple_repositories): Fix typo.
3326         (MainTest.test_run_with_upload_json): Fix typo.
3327         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3328         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3329         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3330         (MainTest.test_parse_args): Add test for repeat option parsing.
3331
3332 2013-03-07  Julie Parent  <jparent@chromium.org>
3333
3334         showAllRuns checkbox no longer works on the stats dashboard
3335         https://bugs.webkit.org/show_bug.cgi?id=111673
3336
3337         Reviewed by Ojan Vafai.
3338
3339         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3340         so we were trying to index into an undefined object.
3341         
3342         * TestResultServer/static-dashboards/dashboard_base.js:
3343         (invalidateQueryParameters):
3344
3345 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3346
3347         [Chromium] Update #include for WebStorageNamespace.h
3348         https://bugs.webkit.org/show_bug.cgi?id=111748
3349
3350         Reviewed by Adam Barth.
3351
3352         In anticipation of removing
3353         WK/chromium/public/WebStorageNamespace.h (once downstream
3354         references have been updated)
3355
3356         * DumpRenderTree/chromium/WebViewHost.cpp:
3357
3358 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3359
3360         run-perf-tests fails due to svn_revision not working on a pure git clone
3361         https://bugs.webkit.org/show_bug.cgi?id=110839
3362
3363         Reviewed by Ryosuke Niwa.
3364
3365         Previously we would call git svn find-rev to look up the commit for
3366         a given revision, and that'll hang in a pure git checkout.
3367
3368         This patch changes the way we look up svn revisions in a git
3369         repository to use git log --grep 'git-svn-id', which is much faster
3370         than grepping ourselves. It also renames timestamp_of_latest_commit()
3371         to timestamp_of_revision() in order to accurately reflect what
3372         the method is doing. Note that this patch only changes the logic
3373         inside latest_revision() and svn_revision(). I'll file a separate
3374         bug to change git_commit_from_svn_revision().
3375
3376         This patch also contains some fixes to unit tests that had bit-rotted
3377         or were otherwise fragile, so that test-webkitpy --all would pass
3378         cleanly, and a fix to outputcapture so that
3379         test-webkitpy -p would work correctly again.
3380
3381         * Scripts/webkitpy/common/checkout/scm/git.py:
3382         (Git.svn_revision):
3383         (Git.timestamp_of_revision):
3384         * Scripts/webkitpy/common/checkout/scm/scm.py:
3385         (SCM.svn_revision):
3386         (SCM.timestamp_of_revision):
3387         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3388         (MockSCM.timestamp_of_revision):
3389         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3390         (_shared_test_commit_with_message):
3391         (test_commit_without_authorization):
3392         (test_timestamp_of_revision):
3393         * Scripts/webkitpy/common/checkout/scm/svn.py:
3394         (SVN.timestamp_of_revision):
3395         * Scripts/webkitpy/common/system/outputcapture.py:
3396           Importing unittest2 directly may not be safe if this module is
3397           imported before the autoinstaller gets a chance to set things up
3398           properly. We don't actually need unittest2 here.
3399         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3400         (PerfTestsRunner._generate_results_dict):
3401
3402 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3403
3404         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
3405         https://bugs.webkit.org/show_bug.cgi?id=111756
3406
3407         Reviewed by Kenneth Rohde Christiansen.
3408
3409         Bump libsoup to v2.40.3 to fix the regressions introduced by
3410         previous v2.40.0 bump.
3411
3412         * efl/jhbuild.modules:
3413
3414 2013-03-07  Roger Fong  <roger_fong@apple.com>
3415
3416         Re-enable Win EWS tests.
3417
3418         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3419         (WinEWS):
3420
3421 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3422
3423         [nrwt] handle corrupt http server pid files cleanly
3424         https://bugs.webkit.org/show_bug.cgi?id=111628
3425
3426         Reviewed by Eric Seidel.
3427
3428         If the pid file from a previous http server is corrupt for some
3429         reason, NRWT will just raise errors and not clean it up or recover.
3430         This patch fixes that to at least delete the pid file and
3431         not throw; not that we may still have stale http servers left on
3432         the system, since there's no way to know which pid to kill if
3433         the file was corrupted.
3434
3435         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3436         (HttpServerBase.start):
3437         (HttpServerBase.stop):
3438         (HttpServerBase._remove_pid_file):
3439         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
3440         (TestHttpServerBase):
3441         (TestHttpServerBase.test_corrupt_pid_file):
3442
3443 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
3444
3445         AX: Can't activate links with VoiceOver in Safari
3446         https://bugs.webkit.org/show_bug.cgi?id=111755
3447
3448         Reviewed by Tim Horton.
3449
3450         * DumpRenderTree/AccessibilityUIElement.cpp:
3451         (supportedActionsCallback):
3452         (AccessibilityUIElement::getJSClass):
3453         * DumpRenderTree/AccessibilityUIElement.h:
3454         (AccessibilityUIElement):
3455         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3456         (AccessibilityUIElement::supportedActions):
3457
3458 2013-03-07  Roger Fong  <roger_fong@apple.com>
3459
3460         Windows debug layout tests are crashing like crazy again.
3461         Disable tests on Win EWS bots temporarily.
3462
3463         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3464         (WinEWS):
3465
3466 2013-03-07  Roger Fong  <roger_fong@apple.com>
3467
3468         Make EWS bots build and test in release.
3469
3470         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3471         (WinEWS):
3472         * Scripts/webkitpy/tool/steps/runtests.py:
3473         (RunTests.run):
3474
3475 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3476
3477         [chromium] don't track the top loading frame if no layout test is currently running
3478         https://bugs.webkit.org/show_bug.cgi?id=111716
3479
3480         Reviewed by Kentaro Hara.
3481
3482         In DRT, we synchronously stop the test and start loading the next test
3483         URL. However, in content_shell, this happens asynchronously. It's
3484         important that the top loading frame is not changed due to stray
3485         navigation events before the next test starts.
3486
3487         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3488         (WebTestRunner::TestRunner::setTopLoadingFrame):
3489
3490 2013-03-06  Julie Parent  <jparent@chromium.org>
3491
3492         Dashboard cleanup: Move all dashboard ui related code into ui.js.
3493         https://bugs.webkit.org/show_bug.cgi?id=111621
3494
3495         Reviewed by Ojan Vafai.
3496         
3497         Creates ui.js, a package for the common UI code the various
3498         dashboards use. HTML generation is now in the ui.html namespace
3499         and popup handling is in ui.popup.
3500         Also moves the event listening for popups to ui.popup.show and
3501         removes it on ui.popup.hid rather than having listener always
3502         around.
3503
3504         * TestResultServer/static-dashboards/aggregate_results.html:
3505         * TestResultServer/static-dashboards/dashboard_base.js:
3506         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3507         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3508         (showPopupForBuild):
3509         (htmlForNavBar):
3510         (generatePageForIndividualTests.if):
3511         (generatePageForIndividualTests):
3512         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
3513         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3514         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3515         * TestResultServer/static-dashboards/run-unittests.html:
3516         * TestResultServer/static-dashboards/timeline_explorer.html:
3517         * TestResultServer/static-dashboards/treemap.html:
3518         * TestResultServer/static-dashboards/ui.js: Added.
3519         (.):
3520
3521 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
3522
3523         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
3524         https://bugs.webkit.org/show_bug.cgi?id=110584
3525
3526         Reviewed by Gyuyoung Kim.
3527
3528         Adds missing implementation of AccessibilityControllerEfl
3529         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
3530         so that it can make accessibilityController as a js object.
3531
3532         * DumpRenderTree/AccessibilityController.h:
3533         (AccessibilityController):
3534         * DumpRenderTree/AccessibilityUIElement.h:
3535         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3536         (AccessibilityController::childElementById): Moved declaration to base class.
3537         Implementation can be shared among other ports.
3538         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
3539         (AccessibilityController::focusedElement):
3540         (AccessibilityController::rootElement):
3541         (AccessibilityController::accessibleElementById):
3542         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
3543         (AccessibilityUIElement::helpText):
3544         * DumpRenderTree/efl/CMakeLists.txt:
3545         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3546         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3547         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3548         (DumpRenderTreeChrome::onWindowObjectCleared):
3549         (DumpRenderTreeChrome::accessibilityController):
3550         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3551         (DumpRenderTreeChrome):
3552         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3553
3554 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
3555
3556         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
3557         https://bugs.webkit.org/show_bug.cgi?id=42696
3558
3559         Reviewed by Andreas Kling.
3560
3561         * DumpRenderTree/TestRunner.cpp:
3562         (TestRunner::staticFunctions):
3563         * DumpRenderTree/TestRunner.h:
3564         (TestRunner):
3565         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3566         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3567         (WebTestRunner::TestRunner::TestRunner):
3568         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3569         (TestRunner):
3570         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3571         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3572         * DumpRenderTree/mac/TestRunnerMac.mm:
3573         * DumpRenderTree/qt/TestRunnerQt.cpp:
3574         * DumpRenderTree/qt/TestRunnerQt.h:
3575         (TestRunnerQt):
3576         * DumpRenderTree/win/TestRunnerWin.cpp:
3577         * DumpRenderTree/wx/TestRunnerWx.cpp:
3578
3579 2013-03-06  Roger Fong  <roger_fong@apple.com>
3580
3581         Re-enable WinEWS test and decrease iterations before clean build back to 10.
3582
3583         * EWSTools/start-queue-win.sh:
3584         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3585         (WinEWS):
3586
3587 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
3588
3589         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
3590         https://bugs.webkit.org/show_bug.cgi?id=82866
3591
3592         Reviewed by Martin Robinson.
3593
3594         * Scripts/run-gtk-tests:
3595         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
3596         it is passing now.
3597
3598 2013-03-06  Julie Parent  <jparent@chromium.org>
3599
3600         Dashboard cleanup: remove dashboard time logging.
3601         https://bugs.webkit.org/show_bug.cgi?id=111608
3602
3603         Reviewed by Dirk Pranke.
3604
3605         Remove logTime.  It was never accurate, and the dev tools
3606         have better ways to measure this if anyone cares to look
3607         into dashboard perf.
3608         
3609         * TestResultServer/static-dashboards/dashboard_base.js:
3610         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3611         (processTestRunsForBuilder):
3612         (appendHTML):
3613
3614 2013-03-06  Tony Chang  <tony@chromium.org>
3615
3616         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3617         https://bugs.webkit.org/show_bug.cgi?id=111509
3618
3619         Reviewed by Dirk Pranke.
3620
3621         Add DumpRenderTree.pak to DumpRenderTree.app again.
3622
3623         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3624
3625 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
3626
3627         [chromium] introduce WebUserGestureIndicator
3628         https://bugs.webkit.org/show_bug.cgi?id=111531
3629
3630         Reviewed by Adam Barth.
3631
3632         * DumpRenderTree/chromium/WebViewHost.cpp:
3633         (WebViewHost::createView):
3634
3635 2013-03-06  Alan Cutter  <alancutter@chromium.org>
3636
3637         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
3638         https://bugs.webkit.org/show_bug.cgi?id=73482
3639
3640         Reviewed by Ryosuke Niwa.
3641
3642         Added input checking to the UpdateChromiumDEPS step.
3643         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
3644
3645         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
3646         (RollChromiumDEPS):
3647         (RollChromiumDEPS._parse_args):
3648         (RollChromiumDEPS.execute):
3649         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
3650         (IRCCommandTest.test_roll_chromium_deps):
3651         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
3652         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
3653         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
3654         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
3655         (UpdateChromiumDEPS._fetch_last_known_good_revision):
3656         (UpdateChromiumDEPS):
3657         (UpdateChromiumDEPS._parse_revision_number):
3658         (UpdateChromiumDEPS._validate_revisions):
3659         (UpdateChromiumDEPS.run):
3660         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
3661         (UpdateChromiumDEPSTest):
3662         (UpdateChromiumDEPSTest.test_parse_revision_number):
3663         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
3664         (RollChromiumDEPS):
3665         (PostChromiumDEPSRoll):
3666
3667 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
3668
3669         [Qt][MiniBrowser] Touch mocking broken for chained getures
3670         https://bugs.webkit.org/show_bug.cgi?id=111430
3671
3672         Reviewed by Jocelyn Turcotte.
3673
3674         Make it possible again to use touch mocking to test gesture chains
3675         like pan->pinch->pan->pinch without lifting the primary "finger".
3676         For this to work we need to track the pressed mouse buttons and
3677         only synthesize touch release events when the ctrl key is released
3678         if no mouse button is pressed. Else the pressed mouse button(s)
3679         should result in a stationary touch point in a touch update event.
3680         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
3681         to check for the state of the ctrl key modifier instead of getting
3682         it from the mouse events.
3683
3684         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3685         (MiniBrowserApplication::MiniBrowserApplication):
3686         (MiniBrowserApplication::notify):
3687
3688 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3689
3690         [chromium] don't use custom freetype on linux asan for now
3691         https://bugs.webkit.org/show_bug.cgi?id=111516
3692
3693         Unreviewed, build fix.
3694
3695         Turns out the custom lib is getting picked up by other binaries
3696         on our bot, which is bad.
3697
3698         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3699
3700 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3701
3702         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3703         https://bugs.webkit.org/show_bug.cgi?id=111509
3704
3705         Unreviewed, build fix.
3706
3707         Actually comment out the flag :(.
3708
3709         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3710
3711 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3712
3713         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3714         https://bugs.webkit.org/show_bug.cgi?id=111509
3715
3716         Unreviewed, build fix.
3717
3718         r144863 appears to have broken the xcode build; I'm temporarily
3719         trying this instead, and if this doesn't work, I'll revert the
3720         other changes.
3721
3722         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3723
3724 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3725
3726         [chromium] build a DumpRenderTree.pak even on windows
3727         https://bugs.webkit.org/show_bug.cgi?id=111504
3728
3729         Reviewed by Tony Chang.
3730
3731         The Chromium Aura build uses the default theme to draw
3732         controls, and that theme requires the ui ResourceBundle
3733         to be initialized. On every other platform, we build
3734         a DumpRenderTree.pak that works for this, but on Windows we
3735         still compile the resources directly into DRT. As a first step,
3736         let's build the pak file. I will then need to land a patch
3737         in Chromium to actually load it. Then I can go back and move
3738         the resources over to just use the .pak file and no longer need
3739         the .rc's.
3740
3741         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3742
3743 2013-03-05  Julie Parent  <jparent@chromium.org>
3744         Dashboard cleanup: move string utilities into their own namespace.
3745         
3746         https://bugs.webkit.org/show_bug.cgi?id=111485
3747
3748         Reviewed by Ojan Vafai.
3749         
3750         One of many pieces to clean up dashboard_base.
3751         
3752         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
3753
3754         * TestResultServer/static-dashboards/aggregate_results.html:
3755         * TestResultServer/static-dashboards/dashboard_base.js:
3756         (isTreeMap):
3757         (isFlakinessDashboard):
3758         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3759         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3760         (determineWKPlatform):
3761         (chromiumPlatform):
3762         (platformAndBuildType):
3763         (substringList):
3764         (individualTestsForSubstringList):
3765         (filterBugs):
3766         (populateExpectationsData):
3767         (processMissingTestsWithExpectations):
3768         (processMissingAndExtraExpectations):
3769         (htmlForSingleTestRow):
3770         (.dummyNode.onload):
3771         (expectationsTitle):
3772         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3773         * TestResultServer/static-dashboards/run-unittests.html:
3774         * TestResultServer/static-dashboards/string.js: Added.
3775         * TestResultServer/static-dashboards/timeline_explorer.html:
3776         * TestResultServer/static-dashboards/treemap.html:
3777
3778 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
3779
3780         [EFL] Build break with latest EFL libraries
3781         https://bugs.webkit.org/show_bug.cgi?id=111028
3782
3783         Reviewed by Dirk Pranke.
3784
3785         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
3786         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
3787         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
3788
3789 2013-03-05  Roger Fong  <roger_fong@apple.com>
3790
3791         Increase number of WinEWS iterations to 20.
3792         Don't reboot after each iteration set.
3793         Make EWS bots just build temporarily so that the queue catches up again.
3794
3795         * EWSTools/start-queue-win.sh:
3796         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3797         (WinEWS):
3798
3799 2013-03-04  James Robinson  <jamesr@chromium.org>
3800
3801         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
3802         https://bugs.webkit.org/show_bug.cgi?id=111386
3803
3804         Reviewed by Adrienne Walker.
3805
3806         * DumpRenderTree/chromium/TestShell.cpp:
3807         (TestShell::initialize):
3808
3809 2013-03-05  Min Qin  <qinmin@chromium.org>
3810
3811         Copy dictionary to the external storage before running layout test on android
3812         https://bugs.webkit.org/show_bug.cgi?id=111480
3813
3814         Reviewed by Adam Barth.
3815
3816         TestWebKitPlatformSupport now needs to read an external dictionary file.
3817         This file does not exist on the device. We need to copy it before running layout tests.
3818
3819         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3820         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
3821         (ChromiumAndroidDriver._push_platform_resources):
3822
3823 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
3824
3825         [chromium] DRT crashes in an Aura/Win build
3826         https://bugs.webkit.org/show_bug.cgi?id=111394
3827
3828         Reviewed by Tony Chang.
3829
3830         When building (and running) with use_aura=1, we assume that
3831         we're using the default theme engine, but DRT creates the
3832         DRTWin theme engine and overwrites the default, leading to crashes
3833         in basically every test from the mismatch.
3834
3835         This fix gets us down to at least "lots of crashes" :).
3836
3837         * DumpRenderTree/chromium/TestShellWin.cpp:
3838         (platformInit):
3839
3840 2013-03-05  Eric Seidel  <eric@webkit.org>
3841
3842         Add html-parser-threaded perf test now that the threaded parser is enabled by default
3843         https://bugs.webkit.org/show_bug.cgi?id=111200
3844
3845         Reviewed by Ryosuke Niwa.
3846
3847         Had to teach run-perf-tests to ignore one more warning.
3848
3849         * Scripts/webkitpy/performance_tests/perftest.py:
3850         (PerfTest):
3851
3852 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
3853
3854         Update list of builders for test results server
3855         https://bugs.webkit.org/show_bug.cgi?id=111166
3856
3857         Reviewed by Ojan Vafai.
3858
3859         * TestResultServer/static-dashboards/builders.jsonp:
3860
3861 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
3862
3863         [GTK] Move basic dependency installation to a script
3864         https://bugs.webkit.org/show_bug.cgi?id=110692
3865
3866         Reviewed by Gustavo Noronha Silva.
3867
3868         * gtk/install-dependencies: Added. A Script which installs all dependencies
3869         necessary for building for Debian-based distributions and Fedora.
3870
3871 2013-03-05  James Robinson  <jamesr@chromium.org>
3872
3873         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
3874         https://bugs.webkit.org/show_bug.cgi?id=111440
3875
3876         Reviewed by Adrienne Walker.
3877
3878         Remove unnecessary WebCompositorSupport::shutdown call
3879
3880         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3881         (main):
3882
3883 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
3884
3885         Unreviewed build fix.
3886
3887         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
3888
3889 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
3890
3891         [Qt][MiniBrowser] Improve the update of touch indicators
3892         https://bugs.webkit.org/show_bug.cgi?id=111429
3893
3894         Reviewed by Jocelyn Turcotte.
3895
3896         MiniBrowserApplication::sendTouchEvent sends an empty list
3897         to BrowserWindow::updateVisualMockTouchPoints if the control
3898         button is released, in which case the touch indicators should
3899         be hidden so that we never end up with a leftover indicator
3900         sticking on the screen.
3901         This patch also simplifies the lookup of the indicator items by
3902         replacing the findChild search in the item tree with a QHash
3903         that stores the touch ID's and the pointers to the corresponding
3904         indicator items.
3905
3906         * MiniBrowser/qt/BrowserWindow.cpp:
3907         (BrowserWindow::updateVisualMockTouchPoints):
3908         * MiniBrowser/qt/BrowserWindow.h:
3909         (BrowserWindow):
3910
3911 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3912
3913         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
3914         https://bugs.webkit.org/show_bug.cgi?id=81042
3915
3916         Reviewed by Enrica Casucci.
3917
3918         Add setAsynchronousSpellCheckingEnabled implementation for
3919         WebKitTestRunner to have the possibility to test asynchronous
3920         spell checking implementation from bug 109577.
3921
3922         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3923         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3924         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
3925         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3926         * WebKitTestRunner/TestController.cpp:
3927         (WTR::TestController::resetStateToConsistentValues):
3928
3929 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
3930
3931         MediaStream API: Add the getStreamById method on RTCPeerConnection
3932         https://bugs.webkit.org/show_bug.cgi?id=111311
3933
3934         Reviewed by Adam Barth.
3935
3936         Changing mocks to be more realistic.
3937
3938         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3939         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
3940         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
3941         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3942         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
3943
3944 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
3945
3946         Add content shell bots to garden-o-matic for general failurse
3947         https://bugs.webkit.org/show_bug.cgi?id=111168
3948
3949         Reviewed by Adam Barth.
3950
3951         All but the WebKit (Content Shell) Android bot is stable enough. While
3952         they're not green yet, there must not be any non-layout test failures on
3953         them.
3954
3955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3956         (.):
3957
3958 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
3959
3960         [chromium] remove deprecated WebTestRunner::setFocus API
3961         https://bugs.webkit.org/show_bug.cgi?id=111354
3962
3963         Reviewed by James Robinson.
3964
3965         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3966         (WebTestDelegate):
3967
3968 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
3969
3970         Run the bindings generation tests on EWS and CQ bots
3971         https://bugs.webkit.org/show_bug.cgi?id=111358
3972
3973         Reviewed by Adam Barth.
3974
3975         The tests are super fast and not flaky.
3976
3977         * Scripts/webkitpy/common/config/ports.py:
3978         (DeprecatedPort.run_bindings_tests_command):
3979         * Scripts/webkitpy/common/config/ports_mock.py:
3980         (MockPort.run_webkit_tests_command):
3981         (MockPort):
3982         (MockPort.run_bindings_tests_command):
3983         * Scripts/webkitpy/tool/commands/download_unittest.py:
3984         * Scripts/webkitpy/tool/steps/runtests.py:
3985         (RunTests.run):
3986         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3987         (RunTestsTest.test_webkit_run_unit_tests):
3988         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3989
3990 2013-03-04  Eric Seidel  <eric@webkit.org>
3991
3992         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
3993         https://bugs.webkit.org/show_bug.cgi?id=111384
3994
3995         Reviewed by Ryosuke Niwa.
3996
3997         Sometimes I want to know why various LayoutTests are slow
3998         without having to convert them into PerformanceTests in order
3999         to use our fancy profiling.  The Driver already knows how to
4000         do the right thing, we just need to expose the options to the user.
4001
4002         Handling of these options is already unittested in the perftests_unittest.
4003
4004         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4005         (parse_args):
4006
4007 2013-03-04  Alan Cutter  <alancutter@chromium.org>
4008
4009         check-webkit-style says "Have to enable auto props in the subversion config file"
4010         https://bugs.webkit.org/show_bug.cgi?id=107724
4011
4012         Reviewed by Tony Chang.
4013
4014         Added a standard svn config file for WebKit developers to use.
4015         Updated the style and commit queue bot build scripts to load this file.
4016
4017         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
4018         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
4019         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
4020         * svn-config: Added.
4021
4022 2013-03-04  James Robinson  <jamesr@chromium.org>
4023
4024         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
4025         https://bugs.webkit.org/show_bug.cgi?id=111285
4026
4027         Reviewed by Adrienne Walker.
4028
4029         This removes the need for WebCompositorSupport::initialize and exposes
4030         slightly fewer entry points across the repository boundary.
4031
4032         * DumpRenderTree/chromium/TestShell.cpp:
4033         (TestShell::initialize):
4034         * DumpRenderTree/chromium/TestShell.h:
4035         (TestShell::webCompositorThread):
4036         (TestShell):
4037         * DumpRenderTree/chromium/WebViewHost.cpp:
4038         (WebViewHost::initializeLayerTreeView):
4039
4040 2013-03-04  Roger Fong  <roger_fong@apple.com>
4041
4042         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
4043
4044         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
4045
4046 2013-03-04  David Kilzer  <ddkilzer@apple.com>
4047
4048         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
4049
4050             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
4051                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
4052                                         ^         ~~~~~~~~~~~~~~~~~~~~~
4053             1 error generated.
4054
4055         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
4056         AccessibilityCommonMac.h.
4057
4058 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4059
4060         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
4061         https://bugs.webkit.org/show_bug.cgi?id=109828
4062
4063         Reviewed by Kenneth Rohde Christiansen.
4064
4065         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
4066         callbacks.
4067
4068         * TestWebKitAPI/CMakeLists.txt:
4069
4070             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
4071             considered.
4072
4073         * TestWebKitAPI/PlatformEfl.cmake:
4074         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
4075         (TestWebKitAPI):
4076         (TestWebKitAPI::didFinishLoadForFrame):
4077         (TestWebKitAPI::setPageLoaderClient):
4078         (TestWebKitAPI::webProcessCrashed):
4079         (TestWebKitAPI::webProcessDidRelaunch):
4080         (TestWebKitAPI::setViewClient):
4081         (TestWebKitAPI::TEST):
4082
4083 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
4084
4085         AX: Upstream iOS Accessibility DumpRenderTree changes
4086         https://bugs.webkit.org/show_bug.cgi?id=111220
4087
4088         Reviewed by David Kilzer.
4089
4090         Upstream the iOS changes for accessibility in DumpRenderTree.
4091
4092         * DumpRenderTree/AccessibilityUIElement.cpp:
4093         (headerElementAtIndexCallback):
4094         (linkedElementCallback):
4095         (elementsForRangeCallback):
4096         (increaseTextSelectionCallback):
4097         (decreaseTextSelectionCallback):
4098         (assistiveTechnologySimulatedFocusCallback):
4099         (stringForSelectionCallback):
4100         (getIPhoneLabelCallback):
4101         (getIPhoneHintCallback):
4102         (getIPhoneValueCallback):
4103         (getIPhoneIdentifierCallback):
4104         (getIPhoneTraitsCallback):
4105         (getIPhoneIsElementCallback):
4106         (getIPhoneElementTextPositionCallback):
4107         (getIPhoneElementTextLengthCallback):
4108         (AccessibilityUIElement::getJSClass):
4109         * DumpRenderTree/AccessibilityUIElement.h:
4110         (AccessibilityUIElement):
4111         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4112         * DumpRenderTree/ios: Added.
4113         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
4114         (AccessibilityController::AccessibilityController):
4115         (AccessibilityController::~AccessibilityController):
4116         (AccessibilityController::elementAtPoint):
4117         (AccessibilityController::focusedElement):
4118         (AccessibilityController::rootElement):
4119         (findAccessibleObjectById):
4120         (AccessibilityController::accessibleElementById):
4121         (AccessibilityController::setLogFocusEvents):
4122         (AccessibilityController::setLogScrollingStartEvents):
4123         (AccessibilityController::setLogValueChangeEvents):
4124         (AccessibilityController::setLogAccessibilityEvents):
4125         (AccessibilityController::addNotificationListener):
4126         (AccessibilityController::removeNotificationListener):
4127         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
4128         (AccessibilityUIElement::AccessibilityUIElement):
4129         (AccessibilityUIElement::~AccessibilityUIElement):
4130         (concatenateAttributeAndValue):
4131         (AccessibilityUIElement::iphoneLabel):
4132         (AccessibilityUIElement::iphoneHint):
4133         (AccessibilityUIElement::iphoneValue):
4134         (AccessibilityUIElement::iphoneIdentifier):
4135         (AccessibilityUIElement::iphoneTraits):
4136         (AccessibilityUIElement::iphoneIsElement):
4137         (AccessibilityUIElement::iphoneElementTextPosition):
4138         (AccessibilityUIElement::iphoneElementTextLength):
4139         (AccessibilityUIElement::url):
4140         (AccessibilityUIElement::x):
4141         (AccessibilityUIElement::y):
4142         (AccessibilityUIElement::width):
4143         (AccessibilityUIElement::height):
4144         (AccessibilityUIElement::clickPointX):
4145         (AccessibilityUIElement::clickPointY):
4146         (AccessibilityUIElement::getChildren):
4147         (AccessibilityUIElement::getChildrenWithRange):
4148         (AccessibilityUIElement::childrenCount):
4149         (AccessibilityUIElement::elementAtPoint):
4150         (AccessibilityUIElement::indexOfChild):
4151         (AccessibilityUIElement::getChildAtIndex):
4152         (AccessibilityUIElement::headerElementAtIndex):
4153         (AccessibilityUIElement::linkedElement):
4154         (AccessibilityUIElement::linkedUIElementAtIndex):
4155         (AccessibilityUIElement::ariaOwnsElementAtIndex):
4156         (AccessibilityUIElement::ariaFlowToElementAtIndex):
4157         (AccessibilityUIElement::disclosedRowAtIndex):
4158         (AccessibilityUIElement::selectedRowAtIndex):
4159         (AccessibilityUIElement::rowAtIndex):
4160         (AccessibilityUIElement::titleUIElement):
4161         (AccessibilityUIElement::parentElement):
4162         (AccessibilityUIElement::disclosedByRow):
4163         (AccessibilityUIElement::increaseTextSelection):
4164         (AccessibilityUIElement::decreaseTextSelection):
4165         (AccessibilityUIElement::stringForSelection):
4166         (AccessibilityUIElement::stringForRange):
4167         (AccessibilityUIElement::attributedStringForRange):
4168         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
4169         (AccessibilityUIElement::elementsForRange):
4170         (AccessibilityUIElement::getLinkedUIElements):
4171         (AccessibilityUIElement::getDocumentLinks):
4172         (AccessibilityUIElement::attributesOfLinkedUIElements):
4173         (AccessibilityUIElement::attributesOfDocumentLinks):
4174         (AccessibilityUIElement::attributesOfChildren):
4175         (AccessibilityUIElement::allAttributes):
4176         (AccessibilityUIElement::stringAttributeValue):
4177         (AccessibilityUIElement::isPressActionSupported):
4178         (AccessibilityUIElement::isIncrementActionSupported):
4179         (AccessibilityUIElement::isDecrementActionSupported):
4180         (AccessibilityUIElement::boolAttributeValue):
4181         (AccessibilityUIElement::isAttributeSettable):
4182         (AccessibilityUIElement::isAttributeSupported):
4183         (AccessibilityUIElement::parameterizedAttributeNames):
4184         (AccessibilityUIElement::role):
4185         (AccessibilityUIElement::subrole):
4186         (AccessibilityUIElement::roleDescription):
4187         (AccessibilityUIElement::title):
4188         (AccessibilityUIElement::description):
4189         (AccessibilityUIElement::orientation):
4190         (AccessibilityUIElement::stringValue):
4191         (AccessibilityUIElement::language):
4192         (AccessibilityUIElement::helpText):
4193         (AccessibilityUIElement::intValue):
4194         (AccessibilityUIElement::minValue):
4195         (AccessibilityUIElement::maxValue):
4196         (AccessibilityUIElement::valueDescription):
4197         (AccessibilityUIElement::insertionPointLineNumber):
4198         (AccessibilityUIElement::isEnabled):
4199         (AccessibilityUIElement::isRequired):
4200         (AccessibilityUIElement::isFocused):
4201         (AccessibilityUIElement::isSelected):
4202         (AccessibilityUIElement::isExpanded):
4203         (AccessibilityUIElement::isChecked):
4204         (AccessibilityUIElement::hierarchicalLevel):
4205         (AccessibilityUIElement::ariaIsGrabbed):
4206         (AccessibilityUIElement::ariaDropEffects):
4207         (AccessibilityUIElement::lineForIndex):
4208         (AccessibilityUIElement::boundsForRange):
4209         (AccessibilityUIElement::attributesOfColumnHeaders):
4210         (AccessibilityUIElement::attributesOfRowHeaders):
4211         (AccessibilityUIElement::attributesOfColumns):
4212         (AccessibilityUIElement::attributesOfRows):
4213         (AccessibilityUIElement::attributesOfVisibleCells):
4214         (AccessibilityUIElement::attributesOfHeader):
4215         (AccessibilityUIElement::rowCount):
4216         (AccessibilityUIElement::columnCount):
4217         (AccessibilityUIElement::indexInTable):
4218         (AccessibilityUIElement::rowIndexRange):
4219         (AccessibilityUIElement::columnIndexRange):
4220         (AccessibilityUIElement::cellForColumnAndRow):
4221         (AccessibilityUIElement::selectedTextRange):
4222         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
4223         (AccessibilityUIElement::setSelectedTextRange):
4224         (AccessibilityUIElement::increment):
4225         (AccessibilityUIElement::decrement):
4226         (AccessibilityUIElement::showMenu):
4227         (AccessibilityUIElement::press):
4228         (AccessibilityUIElement::accessibilityValue):
4229         (AccessibilityUIElement::documentEncoding):
4230         (AccessibilityUIElement::documentURI):
4231         (_accessibilityNotificationCallback):
4232         (AccessibilityUIElement::addNotificationListener):
4233         (AccessibilityUIElement::removeNotificationListener):
4234         (AccessibilityUIElement::isFocusable):
4235         (AccessibilityUIElement::isSelectable):
4236         (AccessibilityUIElement::isMultiSelectable):
4237         (AccessibilityUIElement::isSelectedOptionActive):
4238         (AccessibilityUIElement::isVisible):
4239         (AccessibilityUIElement::isOffScreen):
4240         (AccessibilityUIElement::isCollapsed):
4241         (AccessibilityUIElement::isIgnored):
4242         (AccessibilityUIElement::hasPopup):
4243         (AccessibilityUIElement::takeFocus):
4244         (AccessibilityUIElement::takeSelection):
4245         (AccessibilityUIElement::addSelection):
4246         (AccessibilityUIElement::removeSelection):
4247         (AccessibilityUIElement::uiElementForSearchPredicate):
4248         (AccessibilityUIElement::numberAttributeValue):
4249
4250 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
4251
4252         [chromium] pass all focus handling methods through the WebTestDelegate
4253         https://bugs.webkit.org/show_bug.cgi?id=111328
4254
4255         Reviewed by Nico Weber.
4256
4257         In content_shell, the focus handling is asynchronous. To allow for
4258         switching the focus synchronously between WebViews, we need to intercept
4259         didFocus and didBlur and forward it to the WebTestDelegate.
4260
4261         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4262         (WebTestDelegate):
4263         (WebTestRunner::WebTestDelegate::setFocus):
4264         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4265         (WebTestRunner::WebTestProxy::didFocus):
4266         (WebTestRunner::WebTestProxy::didBlur):
4267         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4268         (WebTestRunner::TestRunner::setWindowIsKey):
4269         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4270         (WebTestRunner::WebTestProxyBase::didFocus):
4271         (WebTestRunner):
4272         (WebTestRunner::WebTestProxyBase::didBlur):
4273         * DumpRenderTree/chromium/WebViewHost.cpp:
4274         (WebViewHost::didFocus):
4275         (WebViewHost::didBlur):
4276         (WebViewHost::setFocus):
4277         * DumpRenderTree/chromium/WebViewHost.h:
4278         (WebViewHost):
4279
4280 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
4281
4282         [GTK] No need to manually add system paths to jhbuildrc
4283         https://bugs.webkit.org/show_bug.cgi?id=110850
4284
4285         Reviewed by Gustavo Noronha Silva.
4286
4287         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
4288         already takes care of.
4289
4290 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
4291
4292         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
4293         https://bugs.webkit.org/show_bug.cgi?id=111284
4294
4295         Disabling the failing two tests on Android.
4296
4297         Reviewed by Jochen Eisinger.
4298
4299         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
4300         (TestWebKitAPI):
4301         (TestWebKitAPI::TEST):
4302