fa409e792375c4e21ba3cc89f955fbff7c59a579
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
2
3         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4         https://bugs.webkit.org/show_bug.cgi?id=194884
5
6         Reviewed by Michael Catanzaro.
7
8         * PlatformWin.cmake:
9
10 2019-02-20  Chris Dumez  <cdumez@apple.com>
11
12         Add API test for <rdar://problem/47471222>
13         https://bugs.webkit.org/show_bug.cgi?id=194847
14
15         Reviewed by Alex Christensen.
16
17         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
18
19 2019-02-20  Chris Dumez  <cdumez@apple.com>
20
21         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
22         https://bugs.webkit.org/show_bug.cgi?id=194872
23         <rdar://problem/47924500>
24
25         Reviewed by Alex Christensen.
26
27         Add API test coverage.
28
29         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
30
31 2019-02-20  Jer Noble  <jer.noble@apple.com>
32
33         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
34         https://bugs.webkit.org/show_bug.cgi?id=191332
35
36         Reviewed by Dean Jackson.
37
38         * Scripts/git-is-in-range: Added.
39
40 2019-02-20  Andy Estes  <aestes@apple.com>
41
42         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
43         https://bugs.webkit.org/show_bug.cgi?id=194869
44
45         Rubber-stamped by Jer Noble.
46
47         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
48         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
49         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
50         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
51         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
52         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
53
54 2019-02-20  Chris Dumez  <cdumez@apple.com>
55
56         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
57         https://bugs.webkit.org/show_bug.cgi?id=194857
58         <rdar://problem/47759323>
59
60         Reviewed by Alex Christensen.
61
62         Add API test coverage.
63
64         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
65
66 2019-02-20  Chris Dumez  <cdumez@apple.com>
67
68         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
69         https://bugs.webkit.org/show_bug.cgi?id=194829
70         <rdar://problem/47889906>
71
72         Reviewed by Alexey Proskuryakov.
73
74         Every time the TestOptions were changing we were creating both a new Web view and
75         a new WKContext, which would start a new Network process. In most cases, we only
76         need to contruct a new Web view and we do can keep reusing the same WKContext.
77         This patch implements this optimization and thus avoids spinning a lot of new
78         Network processes while running the layout tests.
79
80         * WebKitTestRunner/TestController.cpp:
81         (WTR::TestController::generateContextConfiguration const):
82         (WTR::TestController::generatePageConfiguration):
83         (WTR::TestController::createWebViewWithOptions):
84         (WTR::TestController::resetPreferencesToConsistentValues):
85         (WTR::updateTestOptionsFromTestHeader):
86         * WebKitTestRunner/TestController.h:
87         * WebKitTestRunner/TestOptions.h:
88         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
89         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
90         (WTR::TestOptions::hasSameInitializationOptions const):
91         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
92         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
93         (WTR::TestController::platformAddTestOptions const):
94
95 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
96
97         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
98         https://bugs.webkit.org/show_bug.cgi?id=167941
99
100         Reviewed by Carlos Garcia Campos.
101
102         * MiniBrowser/gtk/main.c:
103         (filterSavedCallback): Added.
104         (main): Support loading a JSON rule set file for content filtering.
105         * MiniBrowser/wpe/main.cpp:
106         (filterSavedCallback): Added.
107         (main): Support loading a JSON rule set file for content filtering.
108         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
109         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
110         (WTF::derefGPtr): Ditto.
111         (testEmptyStore):
112         (testSaveInvalidFilter):
113         (testSaveLoadFilter):
114         (testSavedFilterIdentifierMatch):
115         (testRemoveFilter):
116         (testSaveMultipleFilters):
117         (testSaveFilterFromFile):
118         (testFilterPersistence):
119         (beforeAll):
120         (afterAll):
121         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
122         (removeOldInjectedContentAndResetLists): Also reset content filters.
123         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
124         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
125         the element affected by the style sheet.
126         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
127         and returns it to be used by tests.
128         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
129         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
130         (serverCallback): Add support for serving a CSS style sheet for testing.
131         (beforeAll): Add call to testUserContentManagerContentFilter().
132         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
133
134 2019-02-19  Keith Rollin  <krollin@apple.com>
135
136         Add timing information to build output
137         https://bugs.webkit.org/show_bug.cgi?id=194839
138         <rdar://problem/48219609>
139
140         Reviewed by Alexey Proskuryakov.
141
142         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
143         emit each project's build time to its output. E.g.,
144
145             ** BUILD SUCCEEDED ** [0.132 sec]
146
147         * Scripts/webkitdirs.pm:
148         (XcodeOptions):
149
150 2019-02-19  Truitt Savell  <tsavell@apple.com>
151
152         Unreviewed, rolling out r241784.
153
154         Broke all OpenSource builds.
155
156         Reverted changeset:
157
158         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
159         instances view"
160         https://bugs.webkit.org/show_bug.cgi?id=172848
161         https://trac.webkit.org/changeset/241784
162
163 2019-02-19  Zalan Bujtas  <zalan@apple.com>
164
165         [LFC][Floats] Remove redundant intersecting logic
166         https://bugs.webkit.org/show_bug.cgi?id=194804
167
168         Reviewed by Antti Koivisto.
169
170         * LayoutReloaded/misc/LFC-passing-tests.txt:
171
172 2019-02-19  Dean Jackson  <dino@apple.com>
173
174         Clean-up output from generate-xcfilelists so it can be filtered
175         https://bugs.webkit.org/show_bug.cgi?id=194795
176
177         Reviewed by Joseph Pecoraro (and Keith Rollin).
178
179         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
180         make a slight tweak to filter-build-webkit so such lines are marked
181         as plain.
182
183         * Scripts/filter-build-webkit:
184         * Scripts/generate-xcfilelists:
185
186 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
187
188         pytest is not correctly auto-installed
189         https://bugs.webkit.org/show_bug.cgi?id=194707
190
191         Reviewed by Carlos Garcia Campos.
192
193         * Scripts/webkitpy/thirdparty/__init__.py:
194         (AutoinstallImportHook._install_pytest):
195
196 2019-02-18  Chris Dumez  <cdumez@apple.com>
197
198         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
199         https://bugs.webkit.org/show_bug.cgi?id=194797
200         <rdar://problem/48055151>
201
202         Reviewed by Geoffrey Garen.
203
204         Add API test coverage.
205
206         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
207
208 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
209
210         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
211         https://bugs.webkit.org/show_bug.cgi?id=194670
212         <rdar://problem/39066529>
213
214         Reviewed by Tim Horton.
215
216         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
217         pasted in an editable area as attachment elements.
218
219         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
220         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
221         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
222         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
223         (TestWebKitAPI::TEST):
224         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
225         (WTR::InjectedBundlePage::InjectedBundlePage):
226
227 2019-02-18  Alex Christensen  <achristensen@webkit.org>
228
229         Fix API test after r241728
230        ​https://bugs.webkit.org/show_bug.cgi?id=194723
231
232         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
233         (TEST):
234         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
235
236 2019-02-18  Daniel Bates  <dabates@apple.com>
237
238         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
239         https://bugs.webkit.org/show_bug.cgi?id=192824
240         <rdar://problem/47100332>
241
242         Reviewed by Wenson Hsieh.
243
244         Fix a bug where the wrong usage code was used for F13 thru F24.
245
246         * WebKitTestRunner/ios/HIDEventGenerator.mm:
247         (keyCodeForDOMFunctionKey):
248
249 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
250
251         Bytecode cache should a have a boot-specific validation
252         https://bugs.webkit.org/show_bug.cgi?id=194769
253         <rdar://problem/48149509>
254
255         Reviewed by Keith Miller.
256
257         Add test for WTF::bootSessionUUIDString()
258
259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
260         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
261         (TEST):
262
263 2019-02-18  Alex Christensen  <achristensen@webkit.org>
264
265         Disable safe browsing in WKWebView and remove its WKPreferences API
266         https://bugs.webkit.org/show_bug.cgi?id=194723
267         <rdar://problem/48122993>
268
269         Reviewed by Geoffrey Garen.
270
271         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
272         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
273         (TEST):
274         (safeBrowsingView):
275         Make tests use SPI instead of API.
276
277 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
278
279         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
280         https://bugs.webkit.org/show_bug.cgi?id=194586
281
282         Reviewed by Ross Kirsling.
283
284         * DumpRenderTree/win/DumpRenderTree.cpp:
285         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
286         * Scripts/webkitpy/port/driver.py:
287         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
288
289 2019-02-17  David Kilzer  <ddkilzer@apple.com>
290
291         Unreviewed, rolling out r241620.
292
293         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
294         (Requested by ddkilzer on #webkit.)
295
296         Reverted changeset:
297
298         "[WTF] Add environment variable helpers"
299         https://bugs.webkit.org/show_bug.cgi?id=192405
300         https://trac.webkit.org/changeset/241620
301
302 2019-02-16  Zalan Bujtas  <zalan@apple.com>
303
304         [LFC] RenderImage's default intrinsic size is 0.
305         https://bugs.webkit.org/show_bug.cgi?id=194745
306
307         Reviewed by Antti Koivisto.
308
309         * LayoutReloaded/misc/LFC-passing-tests.txt:
310
311 2019-02-16  Zalan Bujtas  <zalan@apple.com>
312
313         [LFC][BFC] Add support for block replaced intrinsic width.
314         https://bugs.webkit.org/show_bug.cgi?id=194705
315
316         Reviewed by Simon Fraser.
317
318         * LayoutReloaded/misc/LFC-passing-tests.txt:
319
320 2019-02-16  Zalan Bujtas  <zalan@apple.com>
321
322         [LFC] Apply min/max width constraints to preferred width computation
323         https://bugs.webkit.org/show_bug.cgi?id=194739
324
325         Reviewed by Simon Fraser.
326
327         * LayoutReloaded/misc/LFC-passing-tests.txt:
328
329 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
330
331         [WTF] Add environment variable helpers
332         https://bugs.webkit.org/show_bug.cgi?id=192405
333
334         Reviewed by Michael Catanzaro.
335
336         * DumpRenderTree/mac/DumpRenderTree.mm:
337         (libraryPathForDumpRenderTree):
338         * DumpRenderTree/win/DumpRenderTree.cpp:
339         (libraryPathForDumpRenderTree):
340         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
341         (setUpIOSLayoutTestCommunication):
342         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
343         (beforeAll):
344         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
345         (main):
346         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
347         (WebKitTestBus::run):
348         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
349         (WTR::getOutputDir):
350         (WTR::initializeFontConfigSetting):
351         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
352         (WTR::InjectedBundle::platformInitialize):
353         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
354         (WTR::topLevelPath):
355         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
356         (WTR::topLevelPath):
357         (WTR::getOutputDir):
358         (WTR::activateFonts):
359         * WebKitTestRunner/TestController.cpp:
360         (WTR::TestController::libraryPathForTesting):
361         (WTR::TestController::generateContextConfiguration const):
362         (WTR::TestController::generatePageConfiguration):
363         (WTR::TestController::decideDestinationWithSuggestedFilename):
364         (WTR::TestController::platformAdjustContext):
365         * WebKitTestRunner/TestController.h:
366         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
367         (WTR::TestController::cocoaPlatformInitialize):
368         (WTR::TestController::platformAdjustContext):
369         * WebKitTestRunner/gtk/main.cpp:
370         (main):
371         * WebKitTestRunner/mac/TestControllerMac.mm:
372         (WTR::TestController::configureContentExtensionForTest):
373         * WebKitTestRunner/wpe/main.cpp:
374         (main):
375         Utilize WTF::Environment where possible.
376
377 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
378
379         [iOS] WKWebView callout bar is missing Change Writing Direction item
380         https://bugs.webkit.org/show_bug.cgi?id=190015
381         <rdar://problem/44810366>
382
383         Reviewed by Tim Horton.
384
385         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
386         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
387
388         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
389         (TestWebKitAPI::TEST):
390
391 2019-02-15  Chris Dumez  <cdumez@apple.com>
392
393         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
394         https://bugs.webkit.org/show_bug.cgi?id=194717
395         <rdar://problem/47884404>
396
397         Reviewed by Brady Eidson.
398
399         Add API test coverage.
400
401         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
402
403 2019-02-15  Youenn Fablet  <youenn@apple.com>
404
405         Make navigator.mediaDevices SecureContext
406         https://bugs.webkit.org/show_bug.cgi?id=194666
407
408         Reviewed by Eric Carlson.
409
410         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
411         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
412         (TEST_F):
413
414 2019-02-15  Brian Burg  <bburg@apple.com>
415
416         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
417         https://bugs.webkit.org/show_bug.cgi?id=194411
418         <rdar://problem/47787614>
419
420         Reviewed by Joseph Pecoraro.
421
422         Remove unnecessary soft linking macro usage.
423
424         * DumpRenderTree/mac/TestRunnerMac.mm:
425         (TestRunner::inspectorTestStubURL):
426         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
427         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
428         (WTR::TestRunner::inspectorTestStubURL):
429
430 2019-02-15  Commit Queue  <commit-queue@webkit.org>
431
432         Unreviewed, rolling out r241559 and r241566.
433         https://bugs.webkit.org/show_bug.cgi?id=194710
434
435         Causes layout test crashes under GuardMalloc (Requested by
436         ryanhaddad on #webkit).
437
438         Reverted changesets:
439
440         "[WTF] Add environment variable helpers"
441         https://bugs.webkit.org/show_bug.cgi?id=192405
442         https://trac.webkit.org/changeset/241559
443
444         "Unreviewed build fix for WinCairo Debug after r241559."
445         https://trac.webkit.org/changeset/241566
446
447 2019-02-15  Zalan Bujtas  <zalan@apple.com>
448
449         [LFC] Out-of-flow box is never a float box
450         https://bugs.webkit.org/show_bug.cgi?id=194704
451
452         Reviewed by Antti Koivisto.
453
454         * LayoutReloaded/misc/LFC-passing-tests.txt:
455
456 2019-02-10  Darin Adler  <darin@apple.com>
457
458         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
459         https://bugs.webkit.org/show_bug.cgi?id=194487
460
461         Reviewed by Daniel Bates.
462
463         * DumpRenderTree/win/DumpRenderTree.cpp:
464         (applicationId): Use makeString instead of String::format.
465         (main): Ditto.
466         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
467         (TestWebKitAPI::Util::createURLForResource): Ditto.
468         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
469         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
470
471         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
472         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
473         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
474         (WTR::createStringWithAttributes): Use appendLiteral.
475         (WTR::AccessibilityUIElement::helpText const): Ditto.
476         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
477         directly instead of using String::format.
478         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
479         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
480
481 2019-02-15  Truitt Savell  <tsavell@apple.com>
482
483         Unreviewed, rolling out r241564.
484
485         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
486
487         Reverted changeset:
488
489         "[Mac] WebInspectorUI.framework does not need to be soft-
490         linked anymore"
491         https://bugs.webkit.org/show_bug.cgi?id=194411
492         https://trac.webkit.org/changeset/241564
493
494 2019-02-15  Saam barati  <sbarati@apple.com>
495
496         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
497         https://bugs.webkit.org/show_bug.cgi?id=194036
498
499         Reviewed by Yusuke Suzuki.
500
501         * Scripts/run-jsc-stress-tests:
502
503 2019-02-14  Tim Horton  <timothy_horton@apple.com>
504
505         Fix the build.
506
507         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
508         (WTR::UIScriptController::drawSquareInEditableImage):
509         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
510         (TestWebKitAPI::drawSquareInEditableImage):
511
512 2019-02-14  Tim Horton  <timothy_horton@apple.com>
513
514         Fix the build.
515
516         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
517         (WTR::UIScriptController::drawSquareInEditableImage):
518         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
519         (TestWebKitAPI::drawSquareInEditableImage):
520
521 2019-02-14  Brian Burg  <bburg@apple.com>
522
523         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
524         https://bugs.webkit.org/show_bug.cgi?id=194411
525         <rdar://problem/47787614>
526
527         Reviewed by Joseph Pecoraro.
528
529         Remove unnecessary soft linking macro usage.
530
531         * DumpRenderTree/mac/TestRunnerMac.mm:
532         (TestRunner::inspectorTestStubURL):
533         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
534         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
535         (WTR::TestRunner::inspectorTestStubURL):
536
537 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
538
539         [ews-app] status bubble should fetch builder name info from BuilderMapping table
540         https://bugs.webkit.org/show_bug.cgi?id=194599
541
542         Reviewed by Lucas Forschler.
543
544         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
545         (StatusBubble._build_bubble):
546
547 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
548
549         [ews-app] Set Foreign Key in Django build model
550         https://bugs.webkit.org/show_bug.cgi?id=194667
551
552         Reviewed by Lucas Forschler.
553
554         * BuildSlaveSupport/ews-app/ews/models/build.py:
555         (Build):
556
557 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
558
559         [WTF] Add environment variable helpers
560         https://bugs.webkit.org/show_bug.cgi?id=192405
561
562         Reviewed by Michael Catanzaro.
563
564         * DumpRenderTree/mac/DumpRenderTree.mm:
565         (libraryPathForDumpRenderTree):
566         * DumpRenderTree/win/DumpRenderTree.cpp:
567         (libraryPathForDumpRenderTree):
568         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
569         (setUpIOSLayoutTestCommunication):
570         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
571         (TestWebKitAPI::strip):
572         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
573         (beforeAll):
574         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
575         (main):
576         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
577         (WebKitTestBus::run):
578         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
579         (WTR::getOutputDir):
580         (WTR::initializeFontConfigSetting):
581         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
582         (WTR::InjectedBundle::platformInitialize):
583         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
584         (WTR::topLevelPath):
585         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
586         (WTR::topLevelPath):
587         (WTR::getOutputDir):
588         (WTR::activateFonts):
589         * WebKitTestRunner/TestController.cpp:
590         (WTR::TestController::libraryPathForTesting):
591         (WTR::TestController::generateContextConfiguration const):
592         (WTR::TestController::generatePageConfiguration):
593         (WTR::TestController::decideDestinationWithSuggestedFilename):
594         (WTR::TestController::platformAdjustContext):
595         * WebKitTestRunner/TestController.h:
596         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
597         (WTR::TestController::cocoaPlatformInitialize):
598         (WTR::TestController::platformAdjustContext):
599         * WebKitTestRunner/gtk/main.cpp:
600         (main):
601         * WebKitTestRunner/mac/TestControllerMac.mm:
602         (WTR::TestController::configureContentExtensionForTest):
603         * WebKitTestRunner/wpe/main.cpp:
604         (main):
605         Utilize WTF::Environment where possible.
606
607 2019-02-14  Chris Dumez  <cdumez@apple.com>
608
609         [PSON] Introduce a WebContent Process cache
610         https://bugs.webkit.org/show_bug.cgi?id=194594
611         <rdar://problem/46793397>
612
613         Reviewed by Geoff Garen.
614
615         Update API tests to turn on the WebContent Process cache.
616
617         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
618
619 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
620
621         Unreviewed, build fix after r241480
622
623         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
624         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
625         (-[DragAndDropSimulator initWithWebView:]):
626
627 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
628
629         AX: ARIA Reflection was disabled in error
630         https://bugs.webkit.org/show_bug.cgi?id=194647
631         <rdar://problem/48068336>
632
633         Reviewed by Ryosuke Niwa.
634
635         Remove test override now that this feature should be enabled by default.
636
637         * WebKitTestRunner/TestController.cpp:
638         (WTR::TestController::resetPreferencesToConsistentValues):
639
640 2019-02-14  Commit Queue  <commit-queue@webkit.org>
641
642         Unreviewed, rolling out r241486.
643         https://bugs.webkit.org/show_bug.cgi?id=194655
644
645         causing API failures in builds (Requested by ShawnRoberts on
646         #webkit).
647
648         Reverted changeset:
649
650         "[Cocoa] Media elements will restart network buffering just
651         before suspending"
652         https://bugs.webkit.org/show_bug.cgi?id=193691
653         https://trac.webkit.org/changeset/241486
654
655 2019-02-14  Zalan Bujtas  <zalan@apple.com>
656
657         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
658         https://bugs.webkit.org/show_bug.cgi?id=194622
659
660         Reviewed by Antti Koivisto.
661
662         * LayoutReloaded/misc/LFC-passing-tests.txt:
663
664 2019-02-14  Zalan Bujtas  <zalan@apple.com>
665
666         [LFC] Shrink-to-fit-width should be constrained by min/max width
667         https://bugs.webkit.org/show_bug.cgi?id=194653
668
669         Reviewed by Antti Koivisto.
670
671         * LayoutReloaded/misc/LFC-passing-tests.txt:
672
673 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
674
675         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
676         https://bugs.webkit.org/show_bug.cgi?id=194641
677
678         Reviewed by Geoffrey Garen.
679
680         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
681         so that the test would fail without this fix.
682
683         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
684         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
685
686 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
687
688         [ews-app] Change log level for a log statement
689
690         Unreviewed minor fix.
691
692         * BuildSlaveSupport/ews-app/ews/models/patch.py:
693         (Patch.save_patch):
694
695 2019-02-13  Jer Noble  <jer.noble@apple.com>
696
697         [Cocoa] Media elements will restart network buffering just before suspending
698         https://bugs.webkit.org/show_bug.cgi?id=193691
699
700         Reviewed by Eric Carlson.
701
702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
703         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
704         (TEST):
705
706 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
707
708         [ews-app] Fetch builder id to name mapping
709         https://bugs.webkit.org/show_bug.cgi?id=194355
710
711         Reviewed by Lucas Forschler.
712
713         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
714         (Buildbot.get_builder_id_to_name_mapping):
715         (Buildbot._get_display_name_from_builder_name):
716
717 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
718
719         Further restricting webarchive loads
720         https://bugs.webkit.org/show_bug.cgi?id=194567
721         <rdar://problem/47610130>
722
723         Reviewed by Youenn Fablet.
724
725         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
726         navigations on drop.
727
728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
729         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
730         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
731         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
732         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
733         (TestWebKitAPI::TEST):
734         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
735         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
736         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
737         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
738         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
739         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
740         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
741
742 2019-02-13  John Wilander  <wilander@apple.com>
743
744         Store Ad Click Attribution requests in the network process
745         https://bugs.webkit.org/show_bug.cgi?id=194510
746         <rdar://problem/47650118>
747
748         Reviewed by Alex Christensen and Daniel Bates.
749
750         This patch adds two TestRunner functions:
751         - dumpAdClickAttribution()
752         - clearAdClickAttribution()
753
754         They call into the network process to dump and clear Ad Click
755         Attribution state, respectively.
756
757         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
758         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
759         (WTR::TestRunner::dumpAdClickAttribution):
760         (WTR::TestRunner::clearAdClickAttribution):
761         * WebKitTestRunner/InjectedBundle/TestRunner.h:
762         * WebKitTestRunner/TestController.cpp:
763         (WTR::TestController::resetStateToConsistentValues):
764         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
765         (WTR::adClickAttributionStringResultCallback):
766         (WTR::TestController::dumpAdClickAttribution):
767         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
768         (WTR::adClickAttributionVoidCallback):
769         (WTR::TestController::clearAdClickAttribution):
770         * WebKitTestRunner/TestController.h:
771         * WebKitTestRunner/TestInvocation.cpp:
772         (WTR::TestInvocation::dumpResults):
773         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
774         (WTR::TestInvocation::dumpAdClickAttribution):
775         * WebKitTestRunner/TestInvocation.h:
776
777 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
778
779         [ews-app] Generate status-bubble
780         https://bugs.webkit.org/show_bug.cgi?id=194572
781
782         Reviewed by Lucas Forschler.
783
784         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
785         (StatusBubble._build_bubble):
786         (StatusBubble._should_show_bubble_for):
787         (StatusBubble._build_bubbles_for_patch):
788
789 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
790
791         [ews-app] Add status bubble html template
792         https://bugs.webkit.org/show_bug.cgi?id=194571
793
794         Reviewed by Lucas Forschler.
795
796         * BuildSlaveSupport/ews-app/ews/templates: Added.
797         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
798
799 2019-02-12  Chris Dumez  <cdumez@apple.com>
800
801         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
802         https://bugs.webkit.org/show_bug.cgi?id=194568
803         <rdar://problem/47944490>
804
805         Reviewed by Ryosuke Niwa.
806
807         Add API test coverage.
808
809         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
810         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
811
812 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
813
814         webkitpy: Remove bug_dummy from parsed test expectations
815         https://bugs.webkit.org/show_bug.cgi?id=194562
816         <rdar://problem/47853999>
817
818         Reviewed by Lucas Forschler.
819
820         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
821         (TestExpectationParser):
822         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
823         skipped tests.
824         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
825
826 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
827
828         [ews-app] Add method to fetch patch
829         https://bugs.webkit.org/show_bug.cgi?id=194518
830
831         Reviewed by Lucas Forschler.
832
833         * BuildSlaveSupport/ews-app/ews/models/patch.py:
834         (Patch.get_patch):
835
836 2019-02-12  Zalan Bujtas  <zalan@apple.com>
837
838         [LFC] Expand tests coverage (60 new tests -> 860)
839
840         Unreviewed test gardening (run-singly, --child-processes=1).
841
842         * LayoutReloaded/misc/LFC-passing-tests.txt:
843
844 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
845
846         Allow pages to trigger programmatic paste from script on iOS
847         https://bugs.webkit.org/show_bug.cgi?id=194271
848         <rdar://problem/47808810>
849
850         Reviewed by Tim Horton.
851
852         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
853
854         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
855         (WTR::UIScriptController::platformSetDidShowMenuCallback):
856         (WTR::UIScriptController::platformSetDidHideMenuCallback):
857         (WTR::UIScriptController::rectForMenuAction const):
858
859         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
860         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
861         for when the menu is shown or hidden.
862
863         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
864         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
865         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
866         (WTR::UIScriptController::setDidShowMenuCallback):
867         (WTR::UIScriptController::didShowMenuCallback const):
868         (WTR::UIScriptController::setDidHideMenuCallback):
869         (WTR::UIScriptController::didHideMenuCallback const):
870         (WTR::UIScriptController::platformSetDidShowMenuCallback):
871         (WTR::UIScriptController::platformSetDidHideMenuCallback):
872         (WTR::UIScriptController::rectForMenuAction const):
873         * TestRunnerShared/UIScriptContext/UIScriptController.h:
874         * WebKitTestRunner/TestController.cpp:
875         (WTR::TestController::resetPreferencesToConsistentValues):
876         (WTR::updateTestOptionsFromTestHeader):
877         * WebKitTestRunner/TestOptions.h:
878
879         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
880         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
881
882         (WTR::TestOptions::hasSameInitializationOptions const):
883         * WebKitTestRunner/UIScriptControllerCocoa.mm:
884         (WTR::UIScriptController::calendarType const):
885         (WTR::UIScriptController::platformUndoManager const):
886         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
887         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
888         (-[TestRunnerWKWebView initWithFrame:configuration:]):
889         (-[TestRunnerWKWebView dealloc]):
890         (-[TestRunnerWKWebView _didShowMenu]):
891         (-[TestRunnerWKWebView _didHideMenu]):
892
893         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
894
895         * WebKitTestRunner/ios/TestControllerIOS.mm:
896         (WTR::handleMenuWillHideNotification):
897         (WTR::handleMenuDidHideNotification):
898         (WTR::TestController::platformInitialize):
899         (WTR::TestController::platformDestroy):
900         (WTR::TestController::platformResetStateToConsistentValues):
901
902         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
903         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
904
905         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
906         (WTR::forEachViewInHierarchy):
907         (WTR::findViewInHierarchyOfType):
908
909         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
910         functions that dig through a given view's hierarchy in search of a view of a given class.
911
912         (WTR::UIScriptController::selectionStartGrabberViewRect const):
913         (WTR::UIScriptController::selectionEndGrabberViewRect const):
914         (WTR::UIScriptController::selectionCaretViewRect const):
915         (WTR::UIScriptController::selectionRangeViewRects const):
916         (WTR::UIScriptController::platformSetDidShowMenuCallback):
917         (WTR::UIScriptController::platformSetDidHideMenuCallback):
918
919         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
920
921         (WTR::UIScriptController::rectForMenuAction const):
922
923         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
924         callout bar) whose label matches the given string.
925
926         (WTR::UIScriptController::platformContentView const):
927
928         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
929         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
930         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
931
932         (WTR::UIScriptController::platformUndoManager const): Deleted.
933         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
934         (WTR::UIScriptController::platformContentView const):
935         (WTR::UIScriptController::platformUndoManager const): Deleted.
936
937 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
938
939         webkitpy: No option to only show unexpected failures in results.html for iPad
940         https://bugs.webkit.org/show_bug.cgi?id=194554
941         <rdar://problem/47922442>
942
943         Rubber-stamped by Aakash Jain.
944
945         Just because a TestExpecations file does not exist for a specific platform does not mean that
946         TestExpecations are not being used, given that platforms inherit test expectations.
947
948         * Scripts/webkitpy/port/base.py:
949         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
950         * Scripts/webkitpy/port/base_unittest.py:
951         (PortTest.test_uses_test_expectations_file):
952
953 2019-02-12  Alex Christensen  <achristensen@webkit.org>
954
955         Remove setDefersLoading infrastructure from WebKit2
956         https://bugs.webkit.org/show_bug.cgi?id=194506
957
958         Reviewed by Brady Eidson.
959
960         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
961         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
962         (WTR::TestRunner::setDefersLoading): Deleted.
963         * WebKitTestRunner/InjectedBundle/TestRunner.h:
964
965 2019-02-12  Alex Christensen  <achristensen@webkit.org>
966
967         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
968         https://bugs.webkit.org/show_bug.cgi?id=194522
969         <rdar://problem/47789393>
970
971         Reviewed by Chris Dumez.
972
973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
974         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
975         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
976         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
977
978 2019-02-12  Andy Estes  <aestes@apple.com>
979
980         [iOSMac] Enable Parental Controls Content Filtering
981         https://bugs.webkit.org/show_bug.cgi?id=194521
982         <rdar://39732376>
983
984         Reviewed by Tim Horton.
985
986         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
987
988 2019-02-12  Zalan Bujtas  <zalan@apple.com>
989
990         [LFC][IFC] Add intrinsic width support for float boxes.
991         https://bugs.webkit.org/show_bug.cgi?id=194528
992
993         Reviewed by Antti Koivisto.
994
995         Expand tests coverage (2 new tests -> 800).
996         (This is the correct test ordering --runs-singly --child-processes=1)
997
998         * LayoutReloaded/misc/LFC-passing-tests.txt:
999
1000 2019-02-12  Rob Buis  <rbuis@igalia.com>
1001
1002         Implement serializing in MIME type parser
1003         https://bugs.webkit.org/show_bug.cgi?id=193909
1004
1005         Reviewed by Darin Adler.
1006
1007         Add various tests involving upper case, non-ASCII, control/null characters,
1008         various HTTP whitespace, single quotes and an unpaired surrogate.
1009
1010         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1011         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1012         (TestWebKitAPI::serializeIfValid):
1013         (TestWebKitAPI::TEST):
1014
1015 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1016
1017         [Cocoa] Ask platform for generic font family mappings
1018         https://bugs.webkit.org/show_bug.cgi?id=187723
1019         <rdar://problem/41892438>
1020
1021         Reviewed by Brent Fulgham.
1022
1023         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1024
1025         * DumpRenderTree/mac/DumpRenderTree.mm:
1026         (allowedFontFamilySet):
1027         * WebKitTestRunner/mac/TestControllerMac.mm:
1028         (WTR::allowedFontFamilySet):
1029
1030 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1031
1032         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1033         https://bugs.webkit.org/show_bug.cgi?id=193622
1034
1035         Reviewed by Michael Catanzaro.
1036
1037         This adds support for loading content extension rule sets from the JSON files which
1038         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1039         of WKTR for this could be removed, but that is left for a follow-up patch with
1040         cleanups.
1041
1042         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1043         * WebKitTestRunner/TestController.cpp:
1044         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1045         avoid having the null-terminator copied into the result.
1046         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1047         part of the preparations to run a test.
1048         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1049         (WTR::contentExtensionStoreCallback): Added.
1050         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1051         used for content extensions test.
1052         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1053         extensions and compiling the JSON rule set for tests involving content extensions.
1054         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1055         testing and disables content extensions.
1056         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1057         resetContentExtensions().
1058         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1059         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1060         configureContentExtensionForTest(), and userContentController().
1061
1062 2019-02-11  Daniel Bates  <dabates@apple.com>
1063
1064         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1065         https://bugs.webkit.org/show_bug.cgi?id=191446
1066         <rdar://problem/45929460>
1067
1068         Reviewed by Tim Horton.
1069
1070         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1071
1072         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1073         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1074         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1075         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1076         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1077         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1078         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1079         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1080         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1081         (WTR::arrayLength):
1082         (WTR::parseModifierArray):
1083         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1084         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1085         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1086         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1087
1088 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1089
1090         Unreviewed, rolling out r241272 and r241276.
1091         https://bugs.webkit.org/show_bug.cgi?id=194514
1092
1093         Broke the Apple Internal build and the fix requires human
1094         intervention :( (Requested by dydz on #webkit).
1095
1096         Reverted changesets:
1097
1098         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1099         https://bugs.webkit.org/show_bug.cgi?id=191446
1100         https://trac.webkit.org/changeset/241272
1101
1102         "Fix internal iOS build after r241272"
1103         https://bugs.webkit.org/show_bug.cgi?id=191446
1104         https://trac.webkit.org/changeset/241276
1105
1106 2019-02-11  Truitt Savell  <tsavell@apple.com>
1107
1108         Unreviewed, rolling out r241269.
1109
1110         Caused 5 layout tests crashes on Mac WK1
1111
1112         Reverted changeset:
1113
1114         "DumpRenderTree should report unknown options"
1115         https://bugs.webkit.org/show_bug.cgi?id=191303
1116         https://trac.webkit.org/changeset/241269
1117
1118 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1119
1120         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1121         https://bugs.webkit.org/show_bug.cgi?id=194313
1122
1123         Reviewed by Tim Horton.
1124
1125         Add a helper to determine whether the web view is presenting modal UI.
1126
1127         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1128         (WTR::UIScriptController::isPresentingModally const):
1129         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1130         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1131         (WTR::UIScriptController::isPresentingModally const):
1132         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1133         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1134         (WTR::UIScriptController::calendarType const): Deleted.
1135         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1136         (WTR::UIScriptController::isPresentingModally const):
1137         (WTR::UIScriptController::calendarType const):
1138         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1139         (WTR::UIScriptController::calendarType const):
1140
1141 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1142
1143         GCHeapInspector: Show the retained sizes in more places
1144         https://bugs.webkit.org/show_bug.cgi?id=194464
1145
1146         Reviewed by Simon Fraser.
1147
1148         * GCHeapInspector/gc-heap-inspector.html:
1149         * GCHeapInspector/script/interface.js:
1150         (HeapInspectorUtils.humanReadableSize):
1151         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1152         (HeapInspectorUtils.spanForNode.span.span):
1153         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1154         (HeapSnapshotInspector.prototype.buildRoots):
1155
1156 2019-02-11  Daniel Bates  <dabates@apple.com>
1157
1158         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1159         https://bugs.webkit.org/show_bug.cgi?id=191446
1160         <rdar://problem/45929460>
1161
1162         Reviewed by Tim Horton.
1163
1164         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1165
1166         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1167         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1168         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1169         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1170         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1171         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1172         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1173         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1174         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1175         (WTR::arrayLength):
1176         (WTR::parseModifierArray):
1177         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1178         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1179         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1180         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1181
1182 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1183
1184         DumpRenderTree should report unknown options
1185         https://bugs.webkit.org/show_bug.cgi?id=191303
1186
1187         Reviewed by Frédéric Wang.
1188
1189         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1190         to report unknown options.
1191         Added and assigned test options which are currently used in tests.
1192
1193         * DumpRenderTree/TestOptions.cpp:
1194         (TestOptions::TestOptions):
1195
1196 2019-02-11  Truitt Savell  <tsavell@apple.com>
1197
1198         Unreviewed, rolling out r241229.
1199
1200         Revision broke internal builds for watchOS.
1201
1202         Reverted changeset:
1203
1204         "[Cocoa] Ask platform for generic font family mappings"
1205         https://bugs.webkit.org/show_bug.cgi?id=187723
1206         https://trac.webkit.org/changeset/241229
1207
1208 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1209
1210         [WinCairo][MiniBrowser] Basic authentication always fails.
1211         https://bugs.webkit.org/show_bug.cgi?id=194496
1212
1213         Reviewed by Don Olmstead.
1214
1215         * MiniBrowser/win/DialogHelper.h:
1216         (Dialog::getText):
1217
1218 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1219
1220         [GStreamer] GstMappedBuffer testsuite build fails
1221         https://bugs.webkit.org/show_bug.cgi?id=194495
1222
1223         Reviewed by Carlos Garcia Campos.
1224
1225         Fix the build by explicitely adding the gstreamer1.0-audio include
1226         directories to the include path.
1227
1228         * TestWebKitAPI/PlatformGTK.cmake:
1229         * TestWebKitAPI/PlatformWPE.cmake:
1230
1231 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1232
1233         [GTK][WPE] Add enable-javascript-markup setting
1234         https://bugs.webkit.org/show_bug.cgi?id=193439
1235
1236         Reviewed by Michael Catanzaro.
1237
1238         Add test cases to check the new setting.
1239
1240         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1241         (testWebKitSettings):
1242         (testWebKitSettingsJavaScriptMarkup):
1243         (beforeAll):
1244
1245 2019-02-10  Darin Adler  <darin@apple.com>
1246
1247         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1248         https://bugs.webkit.org/show_bug.cgi?id=194485
1249
1250         Reviewed by Daniel Bates.
1251
1252         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1253
1254 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1255
1256         Add more tests for clampTo<>()
1257         https://bugs.webkit.org/show_bug.cgi?id=194462
1258
1259         Reviewed by Geoffrey Garen.
1260
1261         Darin suggested to test the very last floating point number
1262         at the boundaries when truncating to integer.
1263         I added test for max/min and max-1/min-1.
1264
1265         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1266         (TestWebKitAPI::TEST):
1267
1268 2019-02-09  Darin Adler  <darin@apple.com>
1269
1270         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1271         https://bugs.webkit.org/show_bug.cgi?id=194021
1272
1273         Reviewed by Geoffrey Garen.
1274
1275         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1276         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1277         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1278
1279 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1280
1281         [LFC][IFC] Add intrinsic width support for basic inline containers
1282         https://bugs.webkit.org/show_bug.cgi?id=194473
1283
1284         Reviewed by Antti Koivisto.
1285
1286         Expand tests coverage (11 new tests -> 798)
1287
1288         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1289
1290 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1291
1292         Fix MiniBrowser's entitlements
1293         https://bugs.webkit.org/show_bug.cgi?id=192431
1294
1295         Reviewed by Joseph Pecoraro.
1296
1297         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1298         files, making it impossible to load any extension.
1299
1300         * MiniBrowser/MiniBrowser.entitlements:
1301
1302 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1303
1304         [Cocoa] Ask platform for generic font family mappings
1305         https://bugs.webkit.org/show_bug.cgi?id=187723
1306         <rdar://problem/41892438>
1307
1308         Reviewed by Brent Fulgham.
1309
1310         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1311
1312         * DumpRenderTree/mac/DumpRenderTree.mm:
1313         (allowedFontFamilySet):
1314         * WebKitTestRunner/mac/TestControllerMac.mm:
1315         (WTR::allowedFontFamilySet):
1316
1317 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1318
1319         [GTK] Implement back/forward touchpad gesture
1320         https://bugs.webkit.org/show_bug.cgi?id=193919
1321
1322         Reviewed by Michael Catanzaro.
1323
1324         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1325         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1326
1327 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1328
1329         Add SPI to use networking daemon instead of XPC service
1330         https://bugs.webkit.org/show_bug.cgi?id=194427
1331
1332         Reviewed by Geoffrey Garen
1333
1334         * MiniBrowser/MiniBrowser.entitlements:
1335
1336 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1337
1338         [ews-build] Ensure that every builder in config.json has short name
1339         https://bugs.webkit.org/show_bug.cgi?id=194461
1340
1341         Reviewed by Lucas Forschler.
1342
1343         * BuildSlaveSupport/ews-build/loadConfig.py:
1344         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1345
1346 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1347
1348         [ews-build] Add short name to config.json
1349         https://bugs.webkit.org/show_bug.cgi?id=194456
1350
1351         Reviewed by Lucas Forschler.
1352
1353         * BuildSlaveSupport/ews-build/config.json: Added short name.
1354         * BuildSlaveSupport/ews-build/loadConfig.py:
1355         (loadBuilderConfig): Set the short name as the builder description.
1356
1357 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1358
1359         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1360         https://bugs.webkit.org/show_bug.cgi?id=194418
1361
1362         Reviewed by Lucas Forschler.
1363
1364         Do not include errors trying when finding crashlogs at the end of
1365         a run-webkit-tests run since we don't process those errors.
1366
1367         * Scripts/webkitpy/port/darwin.py:
1368         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1369         * Scripts/webkitpy/port/ios_device.py:
1370         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1371         * Scripts/webkitpy/port/watch_device.py:
1372         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1373
1374 2019-02-08  Beth Dakin  <bdakin@apple.com>
1375
1376         Add afterScreenUpdates to WKSnapshotConfiguration
1377         https://bugs.webkit.org/show_bug.cgi?id=194362
1378         -and corresponding-
1379         <rdar://problem/40655528> Please add an "after screen updates" property to 
1380         WKSnapshotConfiguration (to solve blank snapshots)
1381
1382         Reviewed by Tim Horton.
1383
1384         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1385         (TEST):
1386
1387 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1388
1389         clampTo(): do not convert the input to double when dealing with integers
1390         https://bugs.webkit.org/show_bug.cgi?id=194263
1391         <rdar://problem/47692312>
1392
1393         Reviewed by Darin Adler.
1394
1395         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1396         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1397         (TestWebKitAPI::testClampFloatingPointToInteger):
1398         (TestWebKitAPI::testClampSameSignIntegers):
1399         (TestWebKitAPI::testClampUnsignedToSigned):
1400         (TestWebKitAPI::testClampSignedToUnsigned):
1401
1402 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1403
1404         webkitpy: Respect --dedicated-simulators flag
1405         https://bugs.webkit.org/show_bug.cgi?id=194416
1406         <rdar://problem/47894722>
1407
1408         Reviewed by Lucas Forschler.
1409
1410         * Scripts/webkitpy/port/device_port.py:
1411         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1412         available devices can be safely ignored.
1413
1414 2019-02-07  Keith Rollin  <krollin@apple.com>
1415
1416         Remove extra copy of 100x100-red.tga
1417         https://bugs.webkit.org/show_bug.cgi?id=194371
1418         <rdar://problem/47873465>
1419
1420         Reviewed by Said Abou-Hallawa.
1421
1422         In order to help it pass its tests, Bug 194190 added a second copy of
1423         the file 100x100-red.tga. However, it turns out that this additional
1424         file wasn't actually needed, and that that sole previous copy was
1425         sufficient. At the same time, this second copy -- which was copied to
1426         the same location in the build output as the first copy -- now caused
1427         XCBuild to complain because there were two production rules for the
1428         same output file. Address this by removing the newly-added extra copy.
1429
1430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1431         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1432
1433 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1434
1435         Deprecate WKBundlePageSetDefersLoading
1436         https://bugs.webkit.org/show_bug.cgi?id=191394
1437
1438         Reviewed by Dean Jackson.
1439
1440         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1441         (WTR::TestRunner::setDefersLoading):
1442
1443 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1444
1445         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1446         https://bugs.webkit.org/show_bug.cgi?id=194391
1447
1448         Reviewed by Antti Koivisto.
1449
1450         * LayoutReloaded/misc/LFC-passing-tests.txt:
1451
1452 2019-02-06  Keith Rollin  <krollin@apple.com>
1453
1454         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1455         https://bugs.webkit.org/show_bug.cgi?id=193975
1456         <rdar://problem/47643306>
1457
1458         Reviewed by Tim Horton.
1459
1460         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1461         the Info.plist file into the bundle. This step is not necessary as the
1462         implicit "bundle up all the build products into a framework" build
1463         phase does this already. Having the Copy Bundle Resources phase do
1464         this causes a conflict under XCBuild, which objects to two build
1465         phases producing the same file (Info.plist). Address this by removing
1466         Info.plist from the Copy Bundle Resources phase.
1467
1468         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1469
1470 2019-02-06  Keith Rollin  <krollin@apple.com>
1471
1472         Really enable the automatic checking and regenerations of .xcfilelists during builds
1473         https://bugs.webkit.org/show_bug.cgi?id=194357
1474         <rdar://problem/47861231>
1475
1476         Reviewed by Chris Dumez.
1477
1478         Bug 194124 was supposed to enable the automatic checking and
1479         regenerating of .xcfilelist files during the build. While related
1480         changes were included in that patch, the change to actually enable the
1481         operation somehow was omitted. This patch actually enables the
1482         operation. The check-xcfilelist.sh scripts now check
1483         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1484         from the checking.
1485
1486         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1487         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1488
1489 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1490
1491         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1492         <https://webkit.org/b/194286>
1493         <rdar://problem/47815558>
1494
1495         Reviewed by Alexey Proskuryakov.
1496
1497         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1498         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1499         WKRetainPtr<> to avoid leaking the WKDataRef.
1500
1501 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1502
1503         Unreviewed, fix a typo
1504
1505         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1506
1507 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1508
1509         [GTK][WPE] force libpsl build to use ICU in jhbuild
1510         https://bugs.webkit.org/show_bug.cgi?id=194288
1511
1512         Reviewed by Carlos Garcia Campos.
1513
1514         * gtk/jhbuild.modules:
1515         Require ICU for libpsl build in jhbuild, like done in WPE.
1516
1517 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1518
1519         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1520         https://bugs.webkit.org/show_bug.cgi?id=194209
1521
1522         Reviewed by Carlos Garcia Campos.
1523
1524         Enhance TestCookieManager to ensure this doesn't happen again.
1525
1526         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1527         (testCookieManagerPersistentStorage):
1528         (beforeAll):
1529
1530 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1531
1532         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1533         https://bugs.webkit.org/show_bug.cgi?id=194324
1534
1535         Reviewed by Andy Estes.
1536
1537         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1538         part of the name is already implicit, since this is in testing code in TestOptions.
1539
1540         * WebKitTestRunner/TestController.cpp:
1541         (WTR::TestController::generateContextConfiguration const):
1542         (WTR::updateTestOptionsFromTestHeader):
1543         * WebKitTestRunner/TestOptions.h:
1544         (WTR::TestOptions::hasSameInitializationOptions const):
1545
1546 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1547
1548         [ews-build] Allow * as platform for builders and workers
1549         https://bugs.webkit.org/show_bug.cgi?id=188533
1550
1551         Reviewed by Lucas Forschler.
1552
1553         * BuildSlaveSupport/ews-build/loadConfig.py:
1554         (checkWorkersAndBuildersForConsistency):
1555
1556 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1557
1558         [ews-build] Add few bots to config.json
1559         https://bugs.webkit.org/show_bug.cgi?id=194304
1560
1561         Reviewed by Lucas Forschler.
1562
1563         * BuildSlaveSupport/ews-build/config.json:
1564
1565 2019-02-05  Keith Rollin  <krollin@apple.com>
1566
1567         Enable the automatic checking and regenerations of .xcfilelists during builds
1568         https://bugs.webkit.org/show_bug.cgi?id=194124
1569         <rdar://problem/47721277>
1570
1571         Reviewed by Tim Horton.
1572
1573         Bug 193790 add a facility for checking -- during build time -- that
1574         any needed .xcfilelist files are up-to-date and for updating them if
1575         they are not. This facility was initially opt-in by setting
1576         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1577         the process seemed robust. Its now time to enable this facility and
1578         make it opt-out. If there is a need to disable this facility, set and
1579         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1580         running `make` or `build-webkit`, or before running Xcode from the
1581         command line.
1582
1583         Additionally, remove the step that generates a list of source files
1584         going into the UnifiedSources build step. It's only necessarily to
1585         specify Sources.txt and SourcesCocoa.txt as inputs.
1586
1587         * Scripts/generate-xcfilelists:
1588
1589 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1590
1591         [GTK][WPE] force libpsl build to use ICU in jhbuild
1592         https://bugs.webkit.org/show_bug.cgi?id=194288
1593
1594         Reviewed by Philippe Normand.
1595
1596         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1597         This can cause build failures if libidn is detected but libunistring is not available.
1598
1599         Make sure that ICU is used for runtime and builtin PSL data.
1600
1601         * gtk/jhbuild.modules:
1602         * wpe/jhbuild.modules:
1603
1604 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1605
1606         [ews-app] Modified timestamp should be updated on updating data
1607         https://bugs.webkit.org/show_bug.cgi?id=194295
1608
1609         Reviewed by Lucas Forschler.
1610
1611         * BuildSlaveSupport/ews-app/ews/models/build.py:
1612         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1613         * BuildSlaveSupport/ews-app/ews/models/step.py:
1614
1615 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1616
1617         Unreviewed, rolling out r240742.
1618
1619         Causes crashes on iOS simulator.
1620
1621         Reverted changeset:
1622
1623         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1624         not focused in a content-editable element"
1625         https://bugs.webkit.org/show_bug.cgi?id=192824
1626         https://trac.webkit.org/changeset/240742
1627
1628 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1629
1630         run-webkit-tests emits message "...running None" when running tests
1631         https://bugs.webkit.org/show_bug.cgi?id=194133
1632         <rdar://problem/47724738>
1633
1634         Reviewed by Lucas Forschler.
1635
1636         * Scripts/webkitpy/xcode/device_type.py:
1637         (DeviceType.__str__): Use both version mapping tables and use just the variant
1638         name if no version name is available.
1639         * Scripts/webkitpy/xcode/device_type_unittest.py:
1640         (DeviceTypeTest):
1641         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1642         an associated named.
1643
1644 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1645
1646         [WPE] require python3-setuptools for meson build in jhbuild
1647         https://bugs.webkit.org/show_bug.cgi?id=194287
1648
1649         Reviewed by Philippe Normand.
1650
1651         python3-setuptools is needed to build meson in jhbuild.
1652         It is already required by the GTK port.
1653
1654         * wpe/install-dependencies:
1655
1656 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1657
1658         [ews-app] Add method to save BuilderMapping to database
1659         https://bugs.webkit.org/show_bug.cgi?id=194264
1660
1661         Reviewed by Lucas Forschler.
1662
1663         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1664         (BuilderMapping.__str__):
1665         (BuilderMapping):
1666         (BuilderMapping.save_mapping):
1667         (BuilderMapping.update_mapping):
1668         (BuilderMapping.get_existing_mapping):
1669         (BuilderMapping.is_valid_mapping):
1670
1671 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1672
1673         [ews-app] Add timestamp fields for BuilderMappings
1674         https://bugs.webkit.org/show_bug.cgi?id=194266
1675
1676         Reviewed by Lucas Forschler.
1677
1678         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1679         (BuilderMapping):
1680
1681 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1682
1683         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1684         https://bugs.webkit.org/show_bug.cgi?id=174816
1685
1686         Reviewed by Michael Catanzaro.
1687
1688         Add tests for webkit_uri_for_display().
1689
1690         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1691         (testURIForDisplayUnaffected):
1692         (testURIForDisplayAffected):
1693         (beforeAll):
1694         (afterAll):
1695         * TestWebKitAPI/glib/CMakeLists.txt:
1696
1697 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1698
1699         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1700         https://bugs.webkit.org/show_bug.cgi?id=194158
1701         <rdar://problem/47737268>
1702
1703         Rubber-stamped by Aakash Jain.
1704
1705         * Scripts/webkitpy/port/device_port.py:
1706         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1707
1708 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1709
1710         [CG] Enable setAdditionalSupportedImageTypes for WK1
1711         https://bugs.webkit.org/show_bug.cgi?id=194190
1712
1713         Reviewed by Tim Horton.
1714
1715         Add a test similar to the one under WebKit Cocoa but make it create a
1716         WebView instead of a WKWebView.
1717
1718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1719         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1720         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1721         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1722         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1723         (TestWebKitAPI::runTest):
1724         (TestWebKitAPI::TEST):
1725
1726 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1727
1728         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1729         https://bugs.webkit.org/show_bug.cgi?id=194168
1730
1731         Reviewed by Simon Fraser.
1732
1733         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1734
1735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1736         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1737         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1738         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1739         (TEST):
1740         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1741         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1742
1743 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1744
1745         REGRESSION (r237269): webkit-patch what-broke is broken 
1746         https://bugs.webkit.org/show_bug.cgi?id=193025
1747
1748         Reviewed by Aakash Jain.
1749
1750         * Scripts/webkitpy/common/host.py:
1751         (Host.buildbot):
1752         (Host.bugzilla): Renamed to 'buildbot'.
1753
1754 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1755
1756         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1757         https://bugs.webkit.org/show_bug.cgi?id=194207
1758
1759         Reviewed by Tim Horton.
1760
1761         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1762         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1763         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1764         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1765         start and delete forwards to remove the original attachment.
1766
1767         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1768         (TestWebKitAPI::TEST):
1769
1770 2019-02-04  Youenn Fablet  <youenn@apple.com>
1771
1772         Capture state should be managed consistently when doing process swapping
1773         https://bugs.webkit.org/show_bug.cgi?id=194122
1774         <rdar://problem/47609293>
1775
1776         Reviewed by Eric Carlson.
1777
1778         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1779         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1780         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1781         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1782         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1784         (WTR::TestRunner::isDoingMediaCapture const):
1785         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1786         * WebKitTestRunner/TestController.cpp:
1787         (WTR::TestController::isDoingMediaCapture const):
1788         * WebKitTestRunner/TestController.h:
1789         * WebKitTestRunner/TestInvocation.cpp:
1790         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1791         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1792         (WTR::TestController::isDoingMediaCapture const):
1793
1794 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1795
1796         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1797         https://bugs.webkit.org/show_bug.cgi?id=194142
1798
1799         Reviewed by Ross Kirsling.
1800
1801         There three 'separator' variables in TestController.cpp. Renamed
1802         it 'pathSeparator', and unified them.
1803
1804         * WebKitTestRunner/TestController.cpp:
1805         (WTR::TestController::generateContextConfiguration const):
1806         (WTR::createTestURL):
1807         (WTR::TestController::platformAdjustContext):
1808
1809 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1810
1811         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1812         https://bugs.webkit.org/show_bug.cgi?id=194198
1813
1814         Reviewed by Antti Koivisto.
1815
1816         No need to set the banner heights on navigation now, since Page stores them.
1817
1818         * MiniBrowser/mac/WK2BrowserWindowController.m:
1819         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1820
1821 2019-02-03  John Wilander  <wilander@apple.com>
1822
1823         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1824         https://bugs.webkit.org/show_bug.cgi?id=194104
1825         <rdar://problem/47649991>
1826
1827         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1828
1829         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1830         (TestWebKitAPI::TEST):
1831             Changed numeric types from unsigned short to uint32_t.
1832
1833 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1834
1835         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1836         <https://webkit.org/b/194178>
1837         <rdar://problem/47753473>
1838
1839         Reviewed by Alexey Proskuryakov.
1840
1841         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1842         (WTR::uninstallFakeHelvetica): Pass nullptr into
1843         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1844
1845 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1846
1847         [LFC] Initialize ICB's style with fixed width/height.
1848         https://bugs.webkit.org/show_bug.cgi?id=194188
1849
1850         Reviewed by Antti Koivisto.
1851
1852         * LayoutReloaded/misc/LFC-passing-tests.txt:
1853
1854 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1855
1856         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1857         https://bugs.webkit.org/show_bug.cgi?id=194185
1858
1859         Reviewed by Antti Koivisto.
1860
1861         * LayoutReloaded/misc/LFC-passing-tests.txt:
1862
1863 2018-12-16  Darin Adler  <darin@apple.com>
1864
1865         Convert additional String::format clients to alternative approaches
1866         https://bugs.webkit.org/show_bug.cgi?id=192746
1867
1868         Reviewed by Alexey Proskuryakov.
1869
1870         * WebKitTestRunner/TestController.cpp:
1871         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1872         as an intermediate in code that ultimately constructs a WTF::String.
1873         (WTR::userMediaOriginHash): Use makeString.
1874         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1875         (WTR::TestController::didPerformClientRedirect): Ditto.
1876         (WTR::TestController::didPerformServerRedirect): Ditto.
1877         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1878
1879 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1880
1881         [ews-build] Add unit test to verify builder keys
1882         https://bugs.webkit.org/show_bug.cgi?id=194152
1883
1884         Reviewed by Lucas Forschler.
1885
1886         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1887         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1888
1889 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1890
1891         [LFC] Expand tests coverage (12 new tests -> 787)
1892
1893         Unreviewed test gardening.
1894
1895         * LayoutReloaded/misc/LFC-passing-tests.txt:
1896
1897 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1898
1899         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1900         https://bugs.webkit.org/show_bug.cgi?id=194163
1901
1902         Reviewed by Simon Fraser.
1903
1904         775
1905
1906         * LayoutReloaded/misc/LFC-passing-tests.txt:
1907
1908 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1909
1910         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1911         https://bugs.webkit.org/show_bug.cgi?id=194140
1912         <rdar://problem/47728098>
1913
1914         Reviewed by Tim Horton.
1915
1916         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1917         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1918         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1919
1920         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1921         test to induce an IPC deadlock when presenting a modal alert during touch start.
1922
1923         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1924         * WebKitTestRunner/TestController.cpp:
1925         (WTR::runJavaScriptAlert):
1926
1927         Add a client callback function for running JavaScript alerts.
1928
1929         (WTR::TestController::createOtherPage):
1930         (WTR::TestController::generateContextConfiguration const):
1931
1932         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1933         the fix in this patch.
1934
1935         (WTR::TestController::createWebViewWithOptions):
1936
1937         Plumb TestOptions to generateContextConfiguration.
1938
1939         (WTR::TestController::resetPreferencesToConsistentValues):
1940         (WTR::TestController::resetStateToConsistentValues):
1941         (WTR::updateTestOptionsFromTestHeader):
1942         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1943         (WTR::TestController::handleJavaScriptAlert):
1944         * WebKitTestRunner/TestController.h:
1945         * WebKitTestRunner/TestInvocation.cpp:
1946         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1947         * WebKitTestRunner/TestOptions.h:
1948         (WTR::TestOptions::hasSameInitializationOptions const):
1949
1950 2019-02-01  Chris Dumez  <cdumez@apple.com>
1951
1952         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1953         https://bugs.webkit.org/show_bug.cgi?id=193740
1954         <rdar://problem/47527267>
1955
1956         Reviewed by Alex Christensen.
1957
1958         Add API test coverage.
1959
1960         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1961
1962 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1963
1964         [ews-app] Add display name field to BuilderMapping model
1965         https://bugs.webkit.org/show_bug.cgi?id=194153
1966
1967         Reviewed by Lucas Forschler.
1968
1969         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1970         (BuilderMapping):
1971
1972 2019-02-01  Youenn Fablet  <youenn@apple.com>
1973
1974         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1975         https://bugs.webkit.org/show_bug.cgi?id=194155
1976
1977         Reviewed by Eric Carlson.
1978
1979         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1980         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1981         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1982
1983 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1984
1985         [LFC] Adjust replaced element's intrinsic ratio
1986         https://bugs.webkit.org/show_bug.cgi?id=194154
1987
1988         Reviewed by Antti Koivisto.
1989
1990         761
1991
1992         * LayoutReloaded/misc/LFC-passing-tests.txt:
1993
1994 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1995
1996         [WPE] Show test results in minibrowser
1997         https://bugs.webkit.org/show_bug.cgi?id=194150
1998
1999         Reviewed by Žan Doberšek.
2000
2001         * Scripts/webkitpy/port/wpe.py:
2002         (WPEPort.show_results_html_file):
2003
2004 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2005
2006         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2007         https://bugs.webkit.org/show_bug.cgi?id=194151
2008
2009         Reviewed by Žan Doberšek.
2010
2011         ALT + <- go back
2012         ALT + -> go forward
2013
2014         * MiniBrowser/wpe/main.cpp:
2015         (main):
2016
2017 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2018
2019         [LFC] Set intrinsic size on Layout::Replaced
2020         https://bugs.webkit.org/show_bug.cgi?id=194139
2021
2022         Reviewed by Antti Koivisto.
2023
2024         744
2025
2026         * LayoutReloaded/misc/LFC-passing-tests.txt:
2027
2028 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2029
2030         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2031         https://bugs.webkit.org/show_bug.cgi?id=194146
2032
2033         Reviewed by Xabier Rodriguez-Calvar.
2034
2035         It allows to open relative paths.
2036
2037         * MiniBrowser/wpe/main.cpp:
2038         (main):
2039
2040 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2041
2042         Update flakiness dashboard configuration after recent queue changes
2043         https://bugs.webkit.org/show_bug.cgi?id=194127
2044
2045         Rubber-stamped by Aakash Jain.
2046
2047         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2048
2049         * TestResultServer/static-dashboards/builders.jsonp:
2050
2051 2019-01-31  Youenn Fablet  <youenn@apple.com>
2052
2053         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2054         https://bugs.webkit.org/show_bug.cgi?id=194106
2055         <rdar://problem/47676333>
2056
2057         Reviewed by Ryosuke Niwa.
2058
2059         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2060         (TestWebKitAPI::didFinishNavigation):
2061         (TestWebKitAPI::TEST):
2062         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2063
2064 2019-01-31  Chris Dumez  <cdumez@apple.com>
2065
2066         Page zoom level is lost after a process swap or a crash
2067         https://bugs.webkit.org/show_bug.cgi?id=194105
2068         <rdar://problem/47610781>
2069
2070         Reviewed by Alex Christensen.
2071
2072         Add API test coverage.
2073
2074         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2075         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2076
2077 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2078
2079         Revert r238819 which is unneeded and caused a performance regression.
2080         https://bugs.webkit.org/show_bug.cgi?id=192272
2081         <rdar://problem/46664625>
2082
2083         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2084         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2085         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2086
2087 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2088
2089         Formalize WebKitAdditions mechanism of LoadOptimizer
2090         https://bugs.webkit.org/show_bug.cgi?id=193886
2091         <rdar://problem/47696809>
2092
2093         Reviewed by Brent Fulgham.
2094
2095         * MiniBrowser/MiniBrowser.entitlements:
2096         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2097
2098 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2099
2100         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2101         https://bugs.webkit.org/show_bug.cgi?id=194090
2102
2103         Reviewed by Antti Koivisto.
2104
2105         * LayoutReloaded/misc/LFC-passing-tests.txt:
2106
2107 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2108
2109         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2110         https://bugs.webkit.org/show_bug.cgi?id=194074
2111
2112         Reviewed by Antti Koivisto.
2113
2114         * LayoutReloaded/misc/LFC-passing-tests.txt:
2115
2116 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2117
2118         [LFC][BFC] Add support for block level replaced box.
2119         https://bugs.webkit.org/show_bug.cgi?id=194071
2120
2121         Reviewed by Antti Koivisto.
2122
2123         * LayoutReloaded/misc/LFC-passing-tests.txt:
2124
2125 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2126
2127         Fix WebKitTestRunner's testPath with Windows full paths
2128         https://bugs.webkit.org/show_bug.cgi?id=194012
2129
2130         Reviewed by Alex Christensen.
2131
2132         updateTestOptionsFromTestHeader failed to open test files because
2133         testPath returned wrong file paths. It returned a path "/C:/..."
2134         if a URL "file:///C:/..." was given.
2135
2136         * WebKitTestRunner/TestController.cpp:
2137         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2138
2139 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2140
2141         [WPE] Bump font related dependencies to match the GTK+ port
2142         https://bugs.webkit.org/show_bug.cgi?id=194017
2143
2144         Reviewed by Žan Doberšek.
2145
2146         * wpe/jhbuild.modules:
2147         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2148         * wpe/patches/icudata-stdlibs.patch: Added.
2149
2150 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2151
2152         Enable swipe tests on iOS
2153         https://bugs.webkit.org/show_bug.cgi?id=194076
2154
2155         Reviewed by Geoffrey Garen.
2156
2157         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2158         it causes a debug assertion failure in runUIScript.
2159
2160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2161         (WTR::UIScriptController::beginBackSwipe):
2162         (WTR::UIScriptController::completeBackSwipe):
2163
2164 2019-01-30  Keith Rollin  <krollin@apple.com>
2165
2166         Use correct printf format specifier
2167         https://bugs.webkit.org/show_bug.cgi?id=194062
2168         <rdar://problem/47686167>
2169
2170         Reviewed by Alexey Proskuryakov.
2171
2172         LayoutTestSpellChecker.mm is trying to format a variable of type
2173         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2174         actually an unsigned long long. Fix this by formatting with %llu.
2175
2176         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2177         (-[LayoutTestTextCheckingResult description]):
2178
2179 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2180
2181         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2182         https://bugs.webkit.org/show_bug.cgi?id=193979
2183
2184         Reviewed by Wenson Hsieh.
2185
2186         Fix the test for iOS. Make the test work with iOS UA string.
2187
2188         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2189
2190 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2191
2192         Replace High Sierra LLINT CLoop bot due to hardware failure
2193         https://bugs.webkit.org/show_bug.cgi?id=194066
2194
2195         Reviewed by Aakash Jain.
2196
2197         * BuildSlaveSupport/build.webkit.org-config/config.json:
2198
2199 2019-01-30  Keith Rollin  <krollin@apple.com>
2200
2201         [NSDragItem init] is unavailable
2202         https://bugs.webkit.org/show_bug.cgi?id=194059
2203         <rdar://problem/47685715>
2204
2205         Reviewed by Wenson Hsieh.
2206
2207         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2208         DumpRenderTree and TestWebKitAPI, which both try to create an
2209         NSDragItem in a manner that invokes this method. Address this by using
2210         -initWithPasteboardWriter instead.
2211
2212         Note that the parameter passed to initWithPasteboardWriter is likely
2213         incorrect. In both cases, the object passed does not conform to
2214         NSPasteboardWriting. However, with this fix, we're no worse off than
2215         before, and can now perform builds with newer compilers and SDKs until
2216         a real fix can be crafted. That work is tracked in
2217         https://bugs.webkit.org/show_bug.cgi?id=194060
2218
2219         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2220         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2221         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2222         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2223
2224 2019-01-30  Daniel Bates  <dabates@apple.com>
2225
2226         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2227         https://bugs.webkit.org/show_bug.cgi?id=192824
2228         <rdar://problem/47100332>
2229
2230         Reviewed by Wenson Hsieh.
2231
2232         Fix a bug where the wrong usage code was used for F13 thru F24.
2233
2234         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2235         (keyCodeForDOMFunctionKey):
2236
2237 2019-01-30  Chris Dumez  <cdumez@apple.com>
2238
2239         Regression(PSON) Load hang can occur on history navigation
2240         https://bugs.webkit.org/show_bug.cgi?id=194030
2241         <rdar://problem/47656939>
2242
2243         Reviewed by Antti Koivisto.
2244
2245         Add API test coverage.
2246
2247         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2248
2249 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2250
2251         [LFC] Expand tests coverage.
2252
2253         Unreviewed test gardening.
2254
2255         * LayoutReloaded/misc/LFC-passing-tests.txt:
2256
2257 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2258
2259         [Flatpak] Add openjpeg support
2260         https://bugs.webkit.org/show_bug.cgi?id=194019
2261
2262         Reviewed by Michael Catanzaro.
2263
2264         * flatpak/org.webkit.CommonModules.yaml:
2265
2266 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2267
2268         Unreviewed, rolling out r240708.
2269         https://bugs.webkit.org/show_bug.cgi?id=194022
2270
2271         It broke WPE build (Requested by KaL on #webkit).
2272
2273         Reverted changeset:
2274
2275         "[WPE] Bump font related dependencies to match the GTK+ port"
2276         https://bugs.webkit.org/show_bug.cgi?id=194017
2277         https://trac.webkit.org/changeset/240708
2278
2279 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2280
2281         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2282         https://bugs.webkit.org/show_bug.cgi?id=194001
2283
2284         Reviewed by Antti Koivisto.
2285
2286         * LayoutReloaded/misc/LFC-passing-tests.txt:
2287
2288 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2289
2290         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2291         https://bugs.webkit.org/show_bug.cgi?id=194020
2292
2293         Reviewed by Antti Koivisto.
2294
2295         * LayoutReloaded/misc/LFC-passing-tests.txt:
2296
2297 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2298
2299         AX: Support color well on iOS
2300         https://bugs.webkit.org/show_bug.cgi?id=194010
2301
2302         Reviewed by Joanmarie Diggs.
2303
2304         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2305         (WTR::AccessibilityUIElement::stringAttributeValue):
2306
2307 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2308
2309         [WPE] Bump font related dependencies to match the GTK+ port
2310         https://bugs.webkit.org/show_bug.cgi?id=194017
2311
2312         Reviewed by Žan Doberšek.
2313
2314         * wpe/jhbuild.modules:
2315         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2316         * wpe/patches/icudata-stdlibs.patch: Added.
2317
2318 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2319
2320         [Mac] Update window scale API usage
2321         https://bugs.webkit.org/show_bug.cgi?id=193991
2322         rdar://problem/47614795
2323
2324         Reviewed by Tim Horton.
2325
2326         * DumpRenderTree/mac/DumpRenderTree.mm:
2327         (changeWindowScaleIfNeeded):
2328         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2329         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2330         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2331
2332 2019-01-29  Chris Dumez  <cdumez@apple.com>
2333
2334         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2335         https://bugs.webkit.org/show_bug.cgi?id=193977
2336         <rdar://problem/47643716>
2337
2338         Reviewed by Geoff Garen.
2339
2340         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2341         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2342         to the previous provisional committing *before* we make the last load. 
2343
2344         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2345
2346 2019-01-29  Youenn Fablet  <youenn@apple.com>
2347
2348         Adopt new SPI to evaluate server certificate trust
2349         https://bugs.webkit.org/show_bug.cgi?id=193355
2350
2351         Reviewed by Alex Christensen.
2352
2353         Add infrastructure to handle HTTPS server trust evaluation testing.
2354
2355         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2356         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2357         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2358         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2359         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2360         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2361         * WebKitTestRunner/TestController.cpp:
2362         (WTR::TestController::resetPreferencesToConsistentValues):
2363         (WTR::TestController::didReceiveAuthenticationChallenge):
2364         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2365         * WebKitTestRunner/TestController.h:
2366         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2367         * WebKitTestRunner/TestInvocation.cpp:
2368         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2369         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2370         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2371
2372 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2373
2374         [ews-build] Add build step to print bot Configuration
2375         https://bugs.webkit.org/show_bug.cgi?id=193887
2376
2377         Reviewed by Lucas Forschler.
2378
2379         * BuildSlaveSupport/ews-build/steps.py:
2380         (PrintConfiguration): Build step to print configuration.
2381         * BuildSlaveSupport/ews-build/factories.py:
2382
2383 2019-01-29  Chris Dumez  <cdumez@apple.com>
2384
2385         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2386         https://bugs.webkit.org/show_bug.cgi?id=193967
2387         <rdar://problem/47635348>
2388
2389         Reviewed by Alex Christensen.
2390
2391         Add API test coverage.
2392
2393         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2394         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2395
2396 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2397
2398         [ews-app] Handle incoming results data
2399         https://bugs.webkit.org/show_bug.cgi?id=193973
2400
2401         Reviewed by Lucas Forschler.
2402
2403         * BuildSlaveSupport/ews-app/ews/views/results.py:
2404
2405 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2406
2407         [ews-app] Make the results url generic
2408         https://bugs.webkit.org/show_bug.cgi?id=193928
2409
2410         Reviewed by Lucas Forschler.
2411
2412         * BuildSlaveSupport/ews-app/ews/urls.py:
2413
2414 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2415
2416         [ews-build] Configure buildbot to send events to ews-app
2417         https://bugs.webkit.org/show_bug.cgi?id=193968
2418
2419         Reviewed by Lucas Forschler.
2420
2421         * BuildSlaveSupport/ews-build/events.py: Added.
2422         * BuildSlaveSupport/ews-build/master.cfg:
2423
2424 2019-01-29  Keith Rollin  <krollin@apple.com>
2425
2426         Add .xcfilelists to Run Script build phases
2427         https://bugs.webkit.org/show_bug.cgi?id=193792
2428         <rdar://problem/47201785>
2429
2430         Reviewed by Alex Christensen.
2431
2432         As part of supporting XCBuild, update the necessary Run Script build
2433         phases in their Xcode projects to refer to their associated
2434         .xcfilelist files.
2435
2436         Note that the addition of these files bumps the Xcode project version
2437         number to something that's Xcode 10 compatible. This change means that
2438         older versions of the Xcode IDE can't read these projects. Nor can it
2439         fully load workspaces that refer to these projects (the updated
2440         projects are shown as non-expandable placeholders). `xcodebuild` can
2441         still build these projects; it's just that the IDE can't open them.
2442
2443         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2444         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2445
2446 2019-01-29  John Wilander  <wilander@apple.com>
2447
2448         Add data abstraction and validation for Ad Click Attribution
2449         https://bugs.webkit.org/show_bug.cgi?id=193916
2450         <rdar://problem/47603481>
2451
2452         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2453
2454         Ad click attribution has two steps. First, the storage of an ad
2455         campaign ID for a click that takes the user to a destination
2456         site. Second, a conversion on the destination site that can be
2457         attributed to the ad click.
2458
2459         This patch adds a class that represents a request for ad click
2460         attribution. Validation makes sure that the bits of entropy
2461         reported through this mechanism is limited.
2462
2463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2464         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2465         (TestWebKitAPI::TEST):
2466
2467 2019-01-29  Chris Dumez  <cdumez@apple.com>
2468
2469         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2470         https://bugs.webkit.org/show_bug.cgi?id=193932
2471         <rdar://problem/47598947>
2472
2473         Reviewed by Brady Eidson.
2474
2475         Add API test coverage.
2476
2477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2478
2479 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2480
2481         Adding new passing LFC tests.
2482
2483         Unreviewed test gardening.
2484
2485         * LayoutReloaded/misc/LFC-passing-tests.txt:
2486
2487 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2488
2489         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2490         https://bugs.webkit.org/show_bug.cgi?id=193964
2491
2492         Reviewed by Antti Koivisto.
2493
2494         * LayoutReloaded/misc/LFC-passing-tests.txt:
2495
2496 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2497
2498         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2499         https://bugs.webkit.org/show_bug.cgi?id=193954
2500
2501         Reviewed by Antti Koivisto.
2502
2503         * LayoutReloaded/misc/LFC-passing-tests.txt:
2504
2505 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2506
2507         WebDriver: add support for running subtests
2508         https://bugs.webkit.org/show_bug.cgi?id=193904
2509
2510         Reviewed by Michael Catanzaro.
2511
2512         pytest already supports it by passing test.py::subtest, so we can do the same.
2513
2514         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2515         (get_item_name): Made this global.
2516         (CollectRecorder.__init__): Receive the parameter to ignore.
2517         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2518         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2519         (collect): Add parameter to ignore.
2520         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2521         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2522         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2523         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2524         (WebDriverTestRunnerSelenium.run): Ditto.
2525         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2526         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2527         (WebDriverTestRunnerW3C.run): Ditto.
2528
2529 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2530
2531         User agent string override for navigator.userAgent should be site specific quirks
2532         https://bugs.webkit.org/show_bug.cgi?id=193950
2533
2534         Reviewed by Brent Fulgham.
2535
2536         Updated per the _WKWebsitePolicies rename.
2537
2538         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2539         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2540
2541 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2542
2543         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2544         https://bugs.webkit.org/show_bug.cgi?id=193941
2545
2546         Reviewed by Alex Christensen.
2547
2548         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2549         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2550         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2551         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2552         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2553         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2554         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2555         * TestWebKitAPI/Tests/WTF/Time.cpp:
2556         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2557         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2558         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2559         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2560
2561 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2562
2563         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2564
2565         * Scripts/webkitpy/common/config/contributors.json:
2566
2567 2019-01-28  Andy Estes  <aestes@apple.com>
2568
2569         [watchOS] Enable Parental Controls content filtering
2570         https://bugs.webkit.org/show_bug.cgi?id=193939
2571         <rdar://problem/46641912>
2572
2573         Reviewed by Ryosuke Niwa.
2574
2575         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2576
2577 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2578
2579         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2580         <https://webkit.org/b/193884>
2581
2582         Reviewed by Jiewen Tan.
2583
2584         * Scripts/webkitpy/style/checkers/cpp.py:
2585         (check_language): Add LocalAuthentication to
2586         `frameworks_with_soft_links`.
2587
2588 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2589
2590         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2591         https://bugs.webkit.org/show_bug.cgi?id=193891
2592
2593         Reviewed by Ross Kirsling.
2594
2595         There were three problems in window sizes of WebView and the host window.
2596         1. The sizes of pixel image output were incorrect.
2597         2. The host window is going to appear after window.resize was invoked.
2598         3. window.resize resized only the host window, not WebView.
2599
2600         This change solves them with a following approach.
2601         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2602         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2603            as well as DumpRenderTree in order to match the client area and the window area.
2604         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2605         d. PlatformWebView::setWindowFrame changes both window sizes.
2606         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2607
2608         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2609         (WTR::PlatformWebView::PlatformWebView): Create the host window
2610         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2611         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2612         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2613
2614 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2615
2616         [ews-app] Add method to save Step data to database
2617         https://bugs.webkit.org/show_bug.cgi?id=193890
2618
2619         Reviewed by Lucas Forschler.
2620
2621         * BuildSlaveSupport/ews-app/ews/models/step.py:
2622         (Step.save_step): Method to save step data.
2623         (Step.update_step): Method to update step data.
2624         (Step.get_existing_step): Method to fetch existing step from database.
2625         (Step.is_valid_result): Method to validate valid step result.
2626
2627 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2628
2629         [ews-app] Add method to save Build data to database
2630         https://bugs.webkit.org/show_bug.cgi?id=193735
2631
2632         Reviewed by Lucas Forschler.
2633
2634         * BuildSlaveSupport/ews-app/ews/models/build.py:
2635         (Build.save_build): Method to save build information to database.
2636         (Build.get_existing_build): Method to fetch existing build from database.
2637         (Build.is_valid_result): Method to validate build result.
2638         * BuildSlaveSupport/ews-app/ews/common/util.py:
2639         (is_valid_int_id): Method to validate valid id.
2640
2641 2019-01-28  Chris Dumez  <cdumez@apple.com>
2642
2643         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2644         https://bugs.webkit.org/show_bug.cgi?id=193915
2645         <rdar://problem/47560907>
2646
2647         Reviewed by Alex Christensen.
2648
2649         Add API test coverage.
2650
2651         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2652
2653 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2654
2655         [ews-app] Rename id variables
2656         https://bugs.webkit.org/show_bug.cgi?id=193883
2657
2658         Reviewed by Lucas Forschler.
2659
2660         * BuildSlaveSupport/ews-app/ews/models/build.py:
2661         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2662         * BuildSlaveSupport/ews-app/ews/models/step.py:
2663         * BuildSlaveSupport/ews-app/ews/urls.py:
2664         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2665         * BuildSlaveSupport/ews-app/ews/views/results.py:
2666         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2667
2668 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2669
2670         [ews-app] Allow certain fields to be empty
2671         https://bugs.webkit.org/show_bug.cgi?id=193892
2672
2673         Reviewed by Lucas Forschler.
2674
2675         * BuildSlaveSupport/ews-app/ews/models/build.py:
2676         * BuildSlaveSupport/ews-app/ews/models/step.py:
2677
2678 2019-01-28  Rob Buis  <rbuis@igalia.com>
2679
2680         Update MIME type parser
2681         https://bugs.webkit.org/show_bug.cgi?id=180526
2682
2683         Reviewed by Frédéric Wang.
2684
2685         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2686         (TestWebKitAPI::TEST):
2687
2688 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2689
2690         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2691         https://bugs.webkit.org/show_bug.cgi?id=193896
2692
2693         Reviewed by Antti Koivisto.
2694
2695         * LayoutReloaded/misc/LFC-passing-tests.txt:
2696
2697 2018-12-15  Darin Adler  <darin@apple.com>
2698
2699         Replace many uses of String::format with more type-safe alternatives
2700         https://bugs.webkit.org/show_bug.cgi?id=192742
2701
2702         Reviewed by Mark Lam.
2703
2704         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2705         (WTR::cacheTestRunnerCallback): Use makeString.
2706         * WebKitTestRunner/TestController.cpp:
2707         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2708         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2709
2710 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2711
2712         Use a load optimizer for some sites
2713         https://bugs.webkit.org/show_bug.cgi?id=193881
2714         <rdar://problem/46325455>
2715
2716         Reviewed by Brent Fulgham.
2717
2718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2719         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2720
2721 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2722
2723         AX: Introduce a static accessibility tree
2724         https://bugs.webkit.org/show_bug.cgi?id=193348
2725         <rdar://problem/47203295>
2726
2727         Reviewed by Ryosuke Niwa.
2728
2729         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2730
2731 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2732
2733         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2734         https://bugs.webkit.org/show_bug.cgi?id=193867
2735
2736         Reviewed by Antti Koivisto.
2737
2738         * LayoutReloaded/misc/LFC-passing-tests.txt:
2739
2740 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2741
2742         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2743         https://bugs.webkit.org/show_bug.cgi?id=193865
2744
2745         Reviewed by Antti Koivisto.
2746
2747         * LayoutReloaded/misc/LFC-passing-tests.txt:
2748
2749 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2750
2751         Need a mechanism to override navigator.userAgent
2752         https://bugs.webkit.org/show_bug.cgi?id=193762
2753         <rdar://problem/47504939>
2754
2755         Reviewed by Brent Fulgham.
2756
2757         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2758
2759         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2760         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2761         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2762
2763 2019-01-25  Dean Jackson  <dino@apple.com>
2764
2765         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2766         https://bugs.webkit.org/show_bug.cgi?id=193831
2767         <rdar://problem/47399263>
2768
2769         Reviewed by Chris Dumez.
2770
2771         Two new tests that exercise cross-origin and same-origin System
2772         Previews.
2773
2774         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2775
2776 2019-01-25  Keith Rollin  <krollin@apple.com>
2777
2778         Update Xcode projects with "Check .xcfilelists" build phase
2779         https://bugs.webkit.org/show_bug.cgi?id=193790
2780         <rdar://problem/47201374>
2781
2782         Reviewed by Alex Christensen.
2783
2784         Support for XCBuild includes specifying inputs and outputs to various
2785         Run Script build phases. These inputs and outputs are specified as
2786         .xcfilelist files. Once created, these .xcfilelist files need to be
2787         kept up-to-date. In order to check that they are up-to-date or not,
2788         add an Xcode build step that invokes an external script that performs
2789         the checking. If the .xcfilelists are found to be out-of-date, update
2790         them, halt the build, and instruct the developer to restart the build
2791         with up-to-date files.
2792
2793         At this time, the checking and regenerating is performed only if the
2794         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2795         who want to use this facility can set this variable and test out the
2796         checking/regenerating. Once it seems like there are no egregious
2797         issues that upset a developer's workflow, we'll unconditionally enable
2798         this facility.
2799
2800         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2801         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2802         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2803         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2804
2805 2019-01-25  Keith Rollin  <krollin@apple.com>
2806
2807         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2808         https://bugs.webkit.org/show_bug.cgi?id=193781
2809         <rdar://problem/47201153>
2810
2811         Reviewed by Alex Christensen.
2812
2813         Part of generating the .xcfilelists used as part of adopting XCBuild
2814         includes running `make DerivedSources.make` from a standalone script.
2815         It’s important for this invocation to have the same environment as
2816         when the actual build invokes `make DerivedSources.make`. If the
2817         environments are different, then the two invocations will provide
2818         different results. In order to get the same environment in the
2819         standalone script, have the script launch xcodebuild targeting the
2820         "Apply Configuration to XCFileLists" build target, which will then
2821         re-invoke our standalone script. The script is now running again, this
2822         time in an environment with all workspace, project, target, xcconfig
2823         and other environment variables established.
2824
2825         The "Apply Configuration to XCFileLists" build target accomplishes
2826         this task via a small embedded shell script that consists only of:
2827
2828             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2829
2830         The process that invokes "Apply Configuration to XCFileLists" first
2831         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2832         evaluated and exports it into the shell environment. When xcodebuild
2833         is invoked, it inherits the value of this variable and can `eval` the
2834         contents of that variable. Our external standalone script can then set
2835         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2836         of command-line parameters needed to restart itself in the appropriate
2837         state.
2838
2839         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2840         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2841
2842 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2843
2844         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2845         https://bugs.webkit.org/show_bug.cgi?id=193802
2846         <rdar://problem/46010580>
2847
2848         Reviewed by Andy Estes.
2849
2850         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2851         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2852         (TEST):
2853
2854 2019-01-25  Daniel Bates  <dabates@apple.com>
2855
2856         [iOS] uiController.keyDown() does not translate Control modified key
2857         https://bugs.webkit.org/show_bug.cgi?id=192898
2858
2859         Reviewed by Wenson Hsieh.
2860
2861         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2862         key translation, as applicable. Among other cases, key translation occurs when performing
2863         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2864         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2865         human pressing down and releasing key(s) using a hardware keyboard.
2866
2867         * WebKitTestRunner/ios/HIDEventGenerator.h:
2868         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2869         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2870
2871         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2872         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2873         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2874         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2875         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2876         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2877         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2878         (-[HIDEventGenerator longPress:completionBlock:]):
2879         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2880         Update code for above renaming.
2881
2882         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2883         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2884
2885         (-[HIDEventGenerator keyDown:]): Added.
2886         (-[HIDEventGenerator keyUp:]): Added.
2887         (-[HIDEventGenerator keyPress:completionBlock:]):
2888         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2889         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2890         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2891         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2892         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2893         (WTR::parseModifier): Deleted.
2894
2895 2019-01-25  Keith Rollin  <krollin@apple.com>
2896
2897         Complete the implementation of generate-xcfilelists
2898         https://bugs.webkit.org/show_bug.cgi?id=193782
2899
2900         Reviewed by Alex Christensen.
2901
2902         A preliminary version of generate-xcfilelists was added in r238008.
2903         This patch updates that script in order to:
2904
2905         - Support checking of .xcfilelists
2906         - Perform better execution of `make DerivedSources.make` by
2907           relaunching generate-xcfilelists under xcodebuild
2908         - Support incremental generation and checking of .xcfilelists
2909         - Support supplementary .xcfilelists files from WebKitAdditions
2910         - Support being wrapped by parallel version of generate-xcfilelists in
2911           Internal that adds support for (re)generating WebKit projects in
2912           that repo.
2913         - Support builds that have been performed in WebKitBuild as well as
2914           ~/Library/Developer/code/DerivedData
2915         - Increase robustness and debugging facilities.
2916
2917         * Scripts/generate-xcfilelists:
2918
2919 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2920
2921         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2922         https://bugs.webkit.org/show_bug.cgi?id=193297
2923         <rdar://problem/47158841>
2924
2925         Unreviewed test case fix.
2926
2927         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2928         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2929
2930         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2931         (TEST):
2932
2933 2019-01-25  Keith Rollin  <krollin@apple.com>
2934
2935         Update existing .xcfilelists
2936         https://bugs.webkit.org/show_bug.cgi?id=193791
2937         <rdar://problem/47201706>
2938
2939         Reviewed by Alex Christensen.
2940
2941         Many .xcfilelist files were added in r238824 in order to support
2942         XCBuild. Update these with recent changes to the set of build files
2943         and with the current generate-xcfilelist script.
2944
2945         * DumpRenderTree/DerivedSources-input.xcfilelist:
2946         * DumpRenderTree/DerivedSources-output.xcfilelist:
2947         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2948         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2949
2950 2019-01-25  Keith Rollin  <krollin@apple.com>
2951
2952         Fix missing dependencies in extract-dependencies-from-makefile
2953         https://bugs.webkit.org/show_bug.cgi?id=193783
2954         <rdar://problem/47201571>
2955
2956         Reviewed by Alex Christensen.
2957
2958         The extract-dependencies-from-makefile script generates .xcfilelists
2959         for XCBuild by invoking a makefile in --debug mode, parsing the
2960         dependency information in the output, and extracting information
2961         regarding targets and dependents. However, the way `make` emits this
2962         dependency information is not rigorous, and so we need to determine
2963         what lines to look for and parse by trial and error. This approach
2964         didn't coriginally atch all the information we needed to collect, so
2965         update the script to look for the additional lines we now know to look
2966         for.
2967
2968         * Scripts/extract-dependencies-from-makefile:
2969         (Parser):
2970         (Parser.addTarget):
2971         (Parser.addPrereq):
2972         (Parser.doParse):
2973
2974 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2975
2976         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2977         https://bugs.webkit.org/show_bug.cgi?id=193297
2978         <rdar://problem/47158841>
2979
2980         Reviewed by Alex Christensen.
2981
2982         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2983             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2984         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2985         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2986         activating the message used to trigger the callback when it is set.
2987
2988 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2989
2990         WKWebView.goBack should reload if there is a safe browsing warning
2991         https://bugs.webkit.org/show_bug.cgi?id=193805
2992         <rdar://problem/46908216>
2993
2994         Reviewed by Geoff Garen.
2995
2996         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2997         (+[Simple3LookupContext sharedLookupContext]):
2998         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2999         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3000         (TEST):
3001
3002 2019-01-25  Chris Dumez  <cdumez@apple.com>
3003
3004         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3005         https://bugs.webkit.org/show_bug.cgi?id=193788
3006         <rdar://problem/47531231>
3007
3008         Reviewed by Alex Christensen.
3009
3010         Add API test coverage.
3011
3012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3013         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3014
3015 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3016
3017         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3018         https://bugs.webkit.org/show_bug.cgi?id=193771
3019
3020         Unreviewed infrastructure fix.
3021
3022         * Scripts/webkitpy/port/darwin.py:
3023         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3024
3025 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3026
3027         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3028
3029 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3030
3031         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3032
3033         * Scripts/webkitpy/common/config/contributors.json:
3034
3035 2019-01-25  Chris Dumez  <cdumez@apple.com>
3036
3037         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3038         https://bugs.webkit.org/show_bug.cgi?id=193779
3039         <rdar://problem/46170903>
3040
3041         Reviewed by Antti Koivisto.
3042
3043         Add API test that quickly navigates forward to a previous process without waiting for it to
3044         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3045         the process' previous page when reconnecting the it for the forward navigation.
3046
3047         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3048
3049 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3050
3051         Need a way for JavaScript (or bundle) code to participate in undo
3052         https://bugs.webkit.org/show_bug.cgi?id=190009
3053         <rdar://problem/44807048>
3054
3055         Reviewed by Ryosuke Niwa.
3056
3057         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3058         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3059
3060         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3061         (WTR::UIScriptController::lastUndoLabel const):
3062         (WTR::UIScriptController::firstRedoLabel const):
3063         (WTR::UIScriptController::platformUndoManager const):
3064         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3065         (WTR::UIScriptController::lastUndoLabel const):
3066         (WTR::UIScriptController::firstRedoLabel const):
3067         (WTR::UIScriptController::platformUndoManager const):
3068         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3069         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3070         (WTR::UIScriptController::lastUndoLabel const):
3071         (WTR::UIScriptController::firstRedoLabel const):
3072         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3073         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3074         (WTR::UIScriptController::lastUndoLabel const):
3075         (WTR::UIScriptController::firstRedoLabel const):
3076         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3077         (WTR::UIScriptController::platformUndoManager const):
3078         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3079         (WTR::UIScriptController::platformUndoManager const):
3080
3081 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3082
3083         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3084         https://bugs.webkit.org/show_bug.cgi?id=193824
3085
3086         Reviewed by Antti Koivisto.
3087
3088         * LayoutReloaded/misc/LFC-passing-tests.txt:
3089
3090 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3091
3092         Update macOS JSC bot configurations
3093         https://bugs.webkit.org/show_bug.cgi?id=193739
3094
3095         Reviewed by Alexey Proskuryakov.
3096
3097         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3099         (BubbleQueueServer): Move JSC EWS to Mojave section.
3100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3101         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3102         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3103
3104 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3105
3106         [Win][WebKitTestRunner] Implement EventSenderProxy
3107         https://bugs.webkit.org/show_bug.cgi?id=193755
3108
3109         Reviewed by Don Olmstead.
3110
3111         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3112         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3113         (WTR::EventSenderProxy::dispatchMessage):
3114         (WTR::EventSenderProxy::EventSenderProxy):
3115         (WTR::EventSenderProxy::mouseDown):
3116         (WTR::EventSenderProxy::mouseUp):
3117         (WTR::EventSenderProxy::mouseMoveTo):
3118         (WTR::EventSenderProxy::mouseScrollBy):
3119         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3120
3121 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3122
3123         Unreviewed fix for API test failure after r240437.
3124
3125         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3126
3127         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3128
3129 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3130
3131         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3132         https://bugs.webkit.org/show_bug.cgi?id=193787
3133         <rdar://problem/47497634>
3134
3135         Reviewed by Alexey Proskuryakov.
3136
3137         * Scripts/webkitdirs.pm:
3138         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3139
3140 2019-01-24  Truitt Savell  <tsavell@apple.com>
3141
3142         Unreviewed, rolling out r240446.
3143
3144         Casued 5 API failures
3145
3146         Reverted changeset:
3147
3148         "Activate the WebResourceLoadStatisticsStore in the
3149         NetworkProcess and deactivate it in the UIProcess."
3150         https://bugs.webkit.org/show_bug.cgi?id=193297
3151         https://trac.webkit.org/changeset/240446
3152
3153 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3154
3155         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3156         https://bugs.webkit.org/show_bug.cgi?id=193741
3157         <rdar://problem/47135030>
3158
3159         Reviewed by Antti Koivisto and Simon Fraser.
3160
3161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3162         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3163         (TestWebKitAPI::TEST):
3164
3165 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3166
3167         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3168         https://bugs.webkit.org/show_bug.cgi?id=193297
3169         <rdar://problem/47158841>
3170
3171         Reviewed by Alex Christensen.
3172
3173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3174         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3175         activating the message used to trigger the callback when it is set.
3176
3177 2019-01-24  John Wilander  <wilander@apple.com>
3178
3179         Add Ad Click Attribution as an internal/experimental feature
3180         https://bugs.webkit.org/show_bug.cgi?id=193685
3181         <rdar://problem/47450399>
3182
3183         Reviewed by Brent Fulgham.
3184
3185         Added test option adClickAttributionEnabled.
3186
3187         * DumpRenderTree/TestOptions.cpp:
3188         (TestOptions::TestOptions):
3189         * DumpRenderTree/TestOptions.h:
3190         * DumpRenderTree/mac/DumpRenderTree.mm:
3191         (setWebPreferencesForTestOptions):
3192
3193 2019-01-24  Antti Koivisto  <antti@apple.com>
3194
3195         [PSON] Flash on back navigation on Mac
3196         https://bugs.webkit.org/show_bug.cgi?id=193716
3197         <rdar://problem/47148458>
3198
3199         Reviewed by Chris Dumez.
3200
3201         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3202
3203         Closing of the previous page is delayed so waiting for didFinishNavigation is
3204         not sufficient to guarantee we have received all the messages. Wait for them.
3205
3206 2019-01-24  Chris Dumez  <cdumez@apple.com>
3207
3208         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3209         https://bugs.webkit.org/show_bug.cgi?id=193761
3210         <rdar://problem/47456405>
3211
3212         Reviewed by Alex Christensen.
3213
3214         Add API test coverage.
3215
3216         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3217
3218 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3219
3220         webkitpy: Missing PID in crashlog name should not be fatal
3221         https://bugs.webkit.org/show_bug.cgi?id=193771
3222
3223         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3224         of raising an exception.
3225
3226         Reviewed by Lucas Forschler.
3227
3228         * Scripts/webkitpy/port/darwin.py:
3229         (DarwinPort._merge_crash_logs):
3230
3231 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3232
3233         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3234         https://bugs.webkit.org/show_bug.cgi?id=193746
3235
3236         Reviewed by Youenn Fablet.
3237
3238         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3239         so we'd best just not call it.
3240
3241         * Scripts/webkitpy/w3c/test_exporter.py:
3242         (WebPlatformTestExporter.create_branch_with_patch):
3243
3244 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3245
3246         Move FileSystem to WTF
3247         https://bugs.webkit.org/show_bug.cgi?id=193602
3248
3249         Reviewed by Yusuke Suzuki.
3250
3251         * DumpRenderTree/win/DumpRenderTree.cpp:
3252         * TestWebKitAPI/CMakeLists.txt:
3253         * TestWebKitAPI/PlatformGTK.cmake:
3254         * TestWebKitAPI/PlatformJSCOnly.cmake:
3255         * TestWebKitAPI/PlatformPlayStation.cmake:
3256         * TestWebKitAPI/PlatformWPE.cmake:
3257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3258         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3259         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3260         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3261         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3262         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3263         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3264         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3265         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3266         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3267
3268 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3269
3270         [WPE] Remove hard dependency on subprocess32 for the API tests
3271
3272         Rubber-stamped by Carlos Garcia Campos.
3273
3274         * glib/api_test_runner.py:
3275         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3276         its presence only when running WPEQt tests.
3277
3278 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3279
3280         [GLIB] Expose JavaScriptCore options in GLib public API
3281         https://bugs.webkit.org/show_bug.cgi?id=188742
3282
3283         Reviewed by Michael Catanzaro.
3284
3285         Add a test for the new API.
3286
3287         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3288         (testsJSCOptions):
3289         (main):
3290
3291 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3292
3293         [GTK][WPE] Support JPEG 2000 images
3294         https://bugs.webkit.org/show_bug.cgi?id=186272
3295
3296         Reviewed by Žan Doberšek.
3297
3298         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3299
3300         * gtk/jhbuild.modules:
3301         * wpe/jhbuild.modules:
3302
3303 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3304
3305         check-webkit-style should warn when using soft-linking macros in a header
3306         <https://webkit.org/b/193750>
3307
3308         Reviewed by Darin Adler.
3309
3310         * Scripts/webkitpy/style/checkers/cpp.py:
3311         (check_language): Add softlink/header check by refactoring the
3312         softlink/framework check.
3313         (CppChecker): Enable softlink/header check by default.
3314         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3315         (CppStyleTest.test_softlink_framework): Rename from
3316         CppStyleTest.test_softlink() and change test framework name in
3317         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3318         files. Set file_name for macros that only appear in headers.
3319         (CppStyleTest.test_softlink_header): Add tests for using
3320         soft-link macros in headers.
3321
3322 2019-01-23  Chris Dumez  <cdumez@apple.com>
3323
3324         Deprecate API to limit the maximum number of WebProcesses
3325         https://bugs.webkit.org/show_bug.cgi?id=193725
3326         <rdar://problem/47464879>
3327
3328         Reviewed by Geoff Garen.
3329
3330         Update existing API tests to stop using deprecated API.
3331
3332         * MiniBrowser/mac/AppDelegate.m:
3333         (defaultConfiguration):
3334         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3335         (TestWebKitAPI::TEST):
3336         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3337         (TestWebKitAPI::TEST):
3338         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3339         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3340         (TEST):
3341         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3342         (TEST):
3343
3344 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3345
3346         [ews-app] Rename ews model buildermappings to buildermapping
3347         https://bugs.webkit.org/show_bug.cgi?id=193729
3348
3349         Reviewed by Lucas Forschler.
3350
3351         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3352         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3353         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3354
3355 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3356
3357         [ews-app] Rename ews model steps to step
3358         https://bugs.webkit.org/show_bug.cgi?id=193697
3359
3360         Reviewed by Lucas Forschler.
3361
3362         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3363         (Step): Renamed Steps to Step.
3364
3365 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3366
3367         Clean up IndexedDB files between tests
3368         https://bugs.webkit.org/show_bug.cgi?id=192796
3369         <rdar://problem/46824999>
3370
3371         Reviewed by Geoffrey Garen.
3372
3373         * DumpRenderTree/mac/DumpRenderTree.mm:
3374         (runTest):
3375         * WebKitTestRunner/TestController.cpp:
3376         (WTR::TestController::resetStateToConsistentValues):
3377         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3378         (WTR::RemoveAllIndexedDatabasesCallback):
3379         (WTR::TestController::ClearIndexedDatabases):
3380         * WebKitTestRunner/TestController.h:
3381         * WebKitTestRunner/TestInvocation.cpp:
3382         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3383
3384 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3385
3386         [ews-app] Rename ews model Builds to Build
3387         https://bugs.webkit.org/show_bug.cgi?id=193695
3388
3389         Reviewed by Lucas Forschler.
3390
3391         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3392         (Build): Renamed Builds to Build.
3393
3394 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3395
3396         webkitpy: Wait longer when launching WebKitTestRunner
3397         https://bugs.webkit.org/show_bug.cgi?id=193734
3398
3399         Reviewed by Aakash Jain.
3400
3401         * Scripts/webkitpy/port/simulator_process.py:
3402         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3403
3404 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3405
3406         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3407         https://bugs.webkit.org/show_bug.cgi?id=193182
3408         <rdar://problem/47452154>
3409
3410         Reviewed by Tim Horton.
3411
3412         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3413         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3414         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3415
3416         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3417         preventing later tests from recognizing gestures.
3418
3419         * WebKitTestRunner/ios/TestControllerIOS.mm:
3420         (WTR::TestController::platformResetStateToConsistentValues):
3421
3422         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3423
3424 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3425
3426         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3427         https://bugs.webkit.org/show_bug.cgi?id=193722
3428         <rdar://problem/47481475>
3429
3430         Reviewed by Lucas Forschler.
3431
3432         iPhone and iPad ports should both use the iOS config.
3433
3434         * Scripts/webkitpy/port/ios_simulator.py:
3435         (IPhoneSimulatorPort.__init__):
3436         (IPadSimulatorPort.__init__):
3437
3438 2019-01-23  Rob Buis  <rbuis@igalia.com>
3439
3440         Update MIME type parser
3441         https://bugs.webkit.org/show_bug.cgi?id=180526
3442
3443         Reviewed by Frédéric Wang.
3444
3445         Add unit tests for both parse modes of ParsedContentType.
3446
3447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3448         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3449         (TestWebKitAPI::TEST):
3450
3451 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3452
3453         [ews-app] fetch loop should not stop on network issues
3454         https://bugs.webkit.org/show_bug.cgi?id=193666
3455
3456         Reviewed by Lucas Forschler.
3457
3458         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3459         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3460
3461 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3462
3463         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3464         https://bugs.webkit.org/show_bug.cgi?id=189165
3465         <rdar://problem/47433765>
3466
3467         Reviewed by Tim Horton.
3468
3469         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3470         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3471         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3472         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3473         would make its way to the UI process by the time the layer tree commit is finished.
3474
3475         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3476         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3477         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3478         will fail because it asks for -_autofillContext too early.
3479
3480         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3481         is handled in the UI process.
3482
3483         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3484
3485         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3486         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3487         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3488         input session.
3489
3490         (-[AutofillTestView textInputHasAutofillContext]):
3491
3492         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3493
3494         * TestWebKitAPI/cocoa/TestWKWebView.h:
3495         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3496         (nextInputSessionChangeCount):
3497
3498         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3499         This includes changing the focused element from one to another.
3500
3501         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3502         (-[TestWKWebView didStartFormControlInteraction]):
3503         (-[TestWKWebView didEndFormControlInteraction]):
3504         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3505
3506         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3507         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3508         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3509         that doesn't require an input session to one that doesn't.
3510
3511 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3512
3513         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3514         <https://webkit.org/b/193676>
3515
3516         Reviewed by Alexey Proskuryakov.
3517
3518         * Scripts/webkitpy/style/checkers/cpp.py:
3519         (check_member_initialization_list):
3520         - Don't report missing whitespace around colon if the colon at
3521           the start of the line is formatted correctly.
3522         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3523         (WebKitStyleTest.test_member_initialization_list):
3524         - Add a test for a missing permutation of existing tests.
3525         - Add a test this false-positive.
3526         - Add blank lines between subtests to make them easier to read.
3527
3528 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3529
3530         [build.webkit.org] Unit-test failure after r237113
3531         https://bugs.webkit.org/show_bug.cgi?id=193669
3532
3533         Reviewed by Michael Catanzaro.
3534
3535         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3536         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3537         multiple or zero flags.
3538
3539 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3540
3541         Cache bytecode to disk
3542         https://bugs.webkit.org/show_bug.cgi?id=192782
3543         <rdar://problem/46084932>
3544
3545         Reviewed by Keith Miller.
3546
3547         Add test helper to execute bytecode-cache tests: it executes each test
3548         twice, the first with JSC_diskCachePath set to a temporary directory
3549         and second with JSC_forceDiskCache=true (in addition to the cache path)
3550         to guarantee that only the disk cache is being used and no new
3551         UnlinkedCodeBlocks are being created.
3552
3553         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3554         * Scripts/run-jsc-stress-tests:
3555
3556 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3557
3558         [css-logical] Implement flow-relative margin, padding and border shorthands
3559         https://bugs.webkit.org/show_bug.cgi?id=188697
3560
3561         Reviewed by Simon Fraser and Antti Koivisto.
3562
3563         * DumpRenderTree/TestOptions.cpp:
3564         (TestOptions::TestOptions):
3565         * DumpRenderTree/TestOptions.h:
3566         * DumpRenderTree/mac/DumpRenderTree.mm:
3567         (setWebPreferencesForTestOptions):
3568         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3569
3570         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3571         (JSONCSSPropertiesChecker.check_codegen_properties):
3572         Allow CSS property definitions to have a 'runtime-flag' parameter which
3573         disables the property when the specified runtime flag is disabled.
3574
3575 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3576
3577         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3578         https://bugs.webkit.org/show_bug.cgi?id=193643
3579
3580         Reviewed by Michael Catanzaro.
3581
3582         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3583         * wpe/jhbuild.modules: Ditto.
3584
3585 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3586
3587         [LFC][Floats] Take float top position into account when computing containing block height.
3588         https://bugs.webkit.org/show_bug.cgi?id=193655
3589
3590         Reviewed by Antti Koivisto.
3591
3592         * LayoutReloaded/misc/LFC-passing-tests.txt:
3593
3594 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3595
3596         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3597         <https://webkit.org/b/193645>
3598         <rdar://problem/47421574>
3599
3600         Reviewed by Alex Christensen.
3601
3602         - Now checks for local soft-linking of all frameworks that have
3603           their own *SoftLinking.{cpp,h,mm} files.
3604         - Changes softlink/uikit warning to softlink/framework.
3605
3606         * Scripts/webkitpy/style/checkers/cpp.py:
3607         (check_language):
3608         (CppChecker):
3609         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3610         (CppStyleTest):
3611
3612 2019-01-20  Saam Barati  <sbarati@apple.com>
3613
3614         Rollout r240210: It broke tests on iOS
3615         https://bugs.webkit.org/show_bug.cgi?id=193640
3616
3617         Unreviewed.
3618
3619         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3620         * Scripts/run-jsc-stress-tests:
3621
3622 2019-01-20  chris fleizach  <cfleizach@apple.com>
3623
3624         AX: Support returning relative frames for accessibility
3625         https://bugs.webkit.org/show_bug.cgi?id=193414
3626         <rdar://problem/47268501>
3627
3628         Reviewed by Zalan Bujtas.
3629
3630         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3631         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3632         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3633         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3634         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3635         (WTR::attributesOfElement):
3636         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3637
3638 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3639
3640         Unreviewed, add my new email address
3641
3642         * Scripts/webkitpy/common/config/contributors.json:
3643
3644 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3645
3646         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3647         https://bugs.webkit.org/show_bug.cgi?id=193617
3648
3649         Reviewed by Antti Koivisto.
3650
3651         * LayoutReloaded/misc/LFC-passing-tests.txt:
3652
3653 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3654
3655         Unreviewed, rolling out r240209.
3656
3657         Broke GTK/WPE injected bundle
3658
3659         Reverted changeset:
3660
3661         "AX: Support returning relative frames for accessibility"
3662         https://bugs.webkit.org/show_bug.cgi?id=193414
3663         https://trac.webkit.org/changeset/240209
3664
3665 2019-01-12  Dan Bernstein  <mitz@apple.com>
3666
3667         [Cocoa] Avoid importing directly from subumbrella frameworks
3668         https://bugs.webkit.org/show_bug.cgi?id=186016
3669         <rdar://problem/40591038>
3670
3671         Reviewed by Sam Weinig.
3672
3673         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3674           LaunchServices header.
3675         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3676           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3677         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3678           when using SDKs earlier than 10.13.
3679         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3680           and OTHER_CPLUSPLUSFLAGS.
3681         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3682           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3683         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3684           LaunchServices header.
3685
3686 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3687
3688         Cache bytecode to disk
3689         https://bugs.webkit.org/show_bug.cgi?id=192782
3690         <rdar://problem/46084932>
3691
3692         Reviewed by Keith Miller.
3693
3694         Add test helper to execute bytecode-cache tests: it executes each test
3695         twice, the first with JSC_diskCachePath set to a temporary directory
3696         and second with JSC_forceDiskCache=true (in addition to the cache path)
3697    &nb