f98da802118d1391f35661be83230f46e3f8fc8a
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-02  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC][BFC] Resolve percentage height values.
4         https://bugs.webkit.org/show_bug.cgi?id=191224
5
6         Reviewed by Antti Koivisto.
7
8         * LayoutReloaded/misc/LFC-passing-tests.txt:
9
10 2018-11-03  Alex Christensen  <achristensen@webkit.org>
11
12         Mac production builds should sign the network process xpc service with entitlements
13         https://bugs.webkit.org/show_bug.cgi?id=191209
14         <rdar://problem/45377609>
15
16         Reviewed by Geoff Garen.
17
18         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
20         (TEST):
21
22 2018-11-02  Alex Christensen  <achristensen@webkit.org>
23
24         Unreviewed, rolling out r237761.
25
26         Makes most API tests timeout and WK2 tests crash
27
28         Reverted changeset:
29
30         "Mac production builds should sign the network process xpc
31         service with entitlements"
32         https://bugs.webkit.org/show_bug.cgi?id=191209
33         https://trac.webkit.org/changeset/237761
34
35 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
36
37         Unreviewed API test gardening
38
39         * TestWebKitAPI/glib/TestExpectations.json:
40
41 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
42
43         Add new global object and preliminary Worklets support for CSS painting api
44         https://bugs.webkit.org/show_bug.cgi?id=190979
45
46         Reviewed by Chris Dumez.
47
48         * Scripts/webkitpy/bindings/main.py:
49         (BindingsTests.generate_supplemental_dependency):
50         (BindingsTests.main):
51
52 2018-11-02  Alex Christensen  <achristensen@webkit.org>
53
54         Mac production builds should sign the network process xpc service with entitlements
55         https://bugs.webkit.org/show_bug.cgi?id=191209
56         <rdar://problem/45377609>
57
58         Reviewed by Geoff Garen.
59
60         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
61         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
62         (TEST):
63
64 2018-11-02  Lucas Forschler  <lforschler@apple.com>
65
66         Add Windows 10 archive bots
67         https://bugs.webkit.org/show_bug.cgi?id=190964
68         
69         This Change updates the Apple Windows Buildbot configuration.
70         - Add Windows 10 specific builders and testers for release and debug.
71         - Refactor Windows -> Windows 7.
72         - Remove Windows 7 Debug.
73
74         Reviewed by Aakash Jain.
75
76         * BuildSlaveSupport/build.webkit.org-config/config.json:
77
78 2018-11-02  Philippe Normand  <pnormand@igalia.com>
79
80         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
81
82         Rubber-stamped by Michael Catanzaro.
83
84         This variable is useful to get rid of shell color escapes in tests stderr files.
85
86         * Scripts/webkitpy/port/gtk.py:
87         (GtkPort.setup_environ_for_server):
88         * Scripts/webkitpy/port/wpe.py:
89         (WPEPort.setup_environ_for_server):
90
91 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
92
93         Add Basic Django web app for OpenSource EWS
94         https://bugs.webkit.org/show_bug.cgi?id=191091
95
96         Reviewed by Lucas Forschler.
97
98         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
99         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
100         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
101         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
102         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
103         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
104         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
105         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
106         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
107         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
108         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
109         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
110         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
111         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
112
113 2018-11-02  Daniel Bates  <dabates@apple.com>
114
115         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
116         https://bugs.webkit.org/show_bug.cgi?id=190487
117
118         Reviewed by Tim Horton.
119
120         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
121         match my observations when using the simulator to simulate iOS 12 and add support for testing
122         right-hand side modifiers.
123
124         * DumpRenderTree/mac/EventSendingController.mm:
125         (modifierFlags):
126         (-[EventSendingController keyDown:withModifiers:withLocation:]):
127         (-[EventSendingController setTouchModifier:value:]):
128         * WebKitTestRunner/ios/HIDEventGenerator.mm:
129         (hidUsageCodeForCharacter):
130
131 2018-11-02  Chris Dumez  <cdumez@apple.com>
132
133         [PSON] Reuse SuspendedPages' process when possible, for performance
134         https://bugs.webkit.org/show_bug.cgi?id=191166
135
136         Reviewed by Geoffrey Garen.
137
138         Add API test coverage.
139
140         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
141
142 2018-11-02  Zalan Bujtas  <zalan@apple.com>
143
144         [LFC][IFC] Add support for intrinsic width calculation
145         https://bugs.webkit.org/show_bug.cgi?id=191144
146
147         Reviewed by Antti Koivisto.
148
149         * LayoutReloaded/misc/LFC-passing-tests.txt:
150
151 2018-11-01  Philippe Normand  <pnormand@igalia.com>
152
153         [Apache] Self-signed SSL certificate RSA key is considered too weak
154         https://bugs.webkit.org/show_bug.cgi?id=191156
155
156         Reviewed by Michael Catanzaro.
157
158         * Scripts/webkitpy/common/system/pemfile.py:
159
160 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
161
162         Unreviewed follow-up to r237678.
163
164         * wpe/jhbuild.modules: The patch element apparently has to be a child
165         of the branch in order for Jhbuild to properly detect and apply the
166         patch file.
167
168 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
169
170         build-jsc --wincairo should update WinCairo libraries
171         https://bugs.webkit.org/show_bug.cgi?id=191170
172
173         Reviewed by Fujii Hironori.
174
175         * Scripts/build-jsc:
176
177 2018-11-01  John Wilander  <wilander@apple.com>
178
179         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
180         https://bugs.webkit.org/show_bug.cgi?id=191119
181         <rdar://problem/44176965>
182
183         Reviewed by Chris Dumez.
184
185         This is an API test for a WebKitLegacy WebView that is first closed and then
186         JavaScript is handed a keyboard event.
187
188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
189         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
190         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
191         (-[KeyboardEventListener handleEvent:]):
192         (TestWebKitAPI::TEST):
193
194 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
195
196         Add a storage limit for IndexedDB
197         https://bugs.webkit.org/show_bug.cgi?id=190598
198         <rdar://problem/44654715>
199
200         Reviewed by Chris Dumez.
201
202         Add API for testing.
203
204         * DumpRenderTree/TestRunner.cpp:
205         (setIDBPerOriginQuotaCallback):
206         (TestRunner::staticFunctions):
207         * DumpRenderTree/TestRunner.h:
208         * DumpRenderTree/mac/TestRunnerMac.mm:
209         (TestRunner::setIDBPerOriginQuota):
210         * DumpRenderTree/win/TestRunnerWin.cpp:
211         (TestRunner::setIDBPerOriginQuota):
212         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
213         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
214         (WTR::TestRunner::setIDBPerOriginQuota):
215         * WebKitTestRunner/InjectedBundle/TestRunner.h:
216         * WebKitTestRunner/TestController.cpp:
217         (WTR::TestController::setIDBPerOriginQuota):
218         * WebKitTestRunner/TestController.h:
219         * WebKitTestRunner/TestInvocation.cpp:
220         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
221
222 2018-11-01  Chris Dumez  <cdumez@apple.com>
223
224         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
225         https://bugs.webkit.org/show_bug.cgi?id=191076
226
227         Reviewed by Geoffrey Garen.
228
229         Add API test coverage.
230
231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
232         (-[PSONNavigationDelegate init]):
233         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
234
235 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
236
237         Fix build with VIDEO and WEB_AUDIO disabled
238         https://bugs.webkit.org/show_bug.cgi?id=191147
239         <rdar://problem/45726710>
240
241         Unreviewed build fix.
242
243         This adds the missing compilation guards in the WPE MiniBrowser.
244
245         * MiniBrowser/wpe/main.cpp:
246         (main): Condition GST includes and calls.
247
248 2018-10-31  Zalan Bujtas  <zalan@apple.com>
249
250         [LFC][IFC] Add support for inline-block elements.
251         https://bugs.webkit.org/show_bug.cgi?id=191143
252
253         Reviewed by Antti Koivisto.
254
255         * LayoutReloaded/misc/LFC-passing-tests.txt:
256
257 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
258
259         [WPE] Add missing libsoup patch to jhbuild
260         https://bugs.webkit.org/show_bug.cgi?id=191149
261
262         Reviewed by Žan Doberšek.
263
264         * wpe/jhbuild.modules:
265         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
266
267 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
268
269         Fix build with VIDEO and WEB_AUDIO disabled
270         https://bugs.webkit.org/show_bug.cgi?id=191147
271
272         Reviewed by Philippe Normand.
273
274         * MiniBrowser/gtk/main.c:
275         (main): Condition GST includes and calls
276
277 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
278
279         Add Justin Michaud to the list of WebKit Committers
280         https://bugs.webkit.org/show_bug.cgi?id=191142
281
282         * Scripts/webkitpy/common/config/contributors.json:
283
284 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
285
286         Don't run JIT tests on 32-bit platforms
287         https://bugs.webkit.org/show_bug.cgi?id=191074
288
289         Reviewed by Michael Catanzaro.
290
291         * Scripts/run-jsc-stress-tests:
292
293 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
294
295         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
296         https://bugs.webkit.org/show_bug.cgi?id=190530
297         <rdar://problem/45232149>
298
299         Reviewed by Tim Horton.
300
301         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
302         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
303         is equivalent to the original file wrappers used to insert attachments in the first web view.
304
305         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
306         is still backed by the same NSFileWrapper instance.
307
308         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
309         (TestWebKitAPI::TEST):
310
311 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
312
313         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
314         https://bugs.webkit.org/show_bug.cgi?id=190949
315
316         Reviewed by Alex Christensen.
317
318         Visual Studio 2017 Community is the alternative.
319
320         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
321         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
322         (buildVisualStudioProject): Ditto.
323         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
324         (usingVisualStudioExpress): Deleted.
325
326 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
327
328         [Win][Direct2D] Support building DumpRenderTree for Direct2D
329         https://bugs.webkit.org/show_bug.cgi?id=191093
330         <rdar://problem/45685706>
331
332         Unreviewed build fix.
333
334         error C2065: 'renderTarget': undeclared identifier
335
336         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
337         (createBitmapContextFromWebView): Restored the previous implementation.
338
339 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
340
341         [PlayStation] Enable JavaScriptCore
342         https://bugs.webkit.org/show_bug.cgi?id=191072
343
344         Reviewed by Brent Fulgham.
345
346         Add platform scripts for building the PlayStation port.
347         perl Tools/Scripts/build-webkit --playstation
348
349         * Scripts/build-webkit:
350         * Scripts/build-webkittestrunner:
351         * Scripts/webkitdirs.pm:
352         (argumentsForConfiguration):
353         (determineConfigurationProductDir):
354         (isPlayStation): Added.
355         (getMSBuildPlatformArgument): Added.
356         (buildVisualStudioProject):
357         (wrapperPrefixIfNeeded):
358         (generateBuildSystemFromCMakeProject):
359         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
360
361 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
362
363         [Win][Direct2D] Support building DumpRenderTree for Direct2D
364         https://bugs.webkit.org/show_bug.cgi?id=191093
365         <rdar://problem/45685706>
366
367         Reviewed by Alex Christensen.
368
369         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
370         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
371         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
372         (pixelDumpSystemFactory): Added.
373         (printPNG): Create stub.
374         (computeMD5HashStringForBitmapContext): Ditto.
375         (dumpBitmap): Ditto.
376         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
377         (BitmapContext::createByAdoptingBitmapAndContext):
378         (BitmapContext::~BitmapContext):
379         (BitmapContext::platformContext const):
380         (BitmapContext::BitmapContext):
381         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
382         (createBitmapContextFromWebView): Update to support Direct2D.
383         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
384         logo is no longer available at this location. Switch to the new logo.
385
386 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
387
388         webkitpy: Support alternate simctl list outputs
389         https://bugs.webkit.org/show_bug.cgi?id=191090
390         <rdar://problem/45684255>
391
392         Rubber-stamped by Aakash Jain.
393
394         * Scripts/webkitpy/xcode/simulated_device.py:
395         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
396         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
397         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
398         (test_available_devices): Add iOS 12 with alternative availability format.
399
400 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
401
402         Clean up some obsolete MAX_ALLOWED macros
403         https://bugs.webkit.org/show_bug.cgi?id=190916
404
405         Reviewed by Tim Horton.
406
407         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
408         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
409         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
410
411 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
412
413         [GTK][WPE] Fixes to the PublicSuffix implementation
414         https://bugs.webkit.org/show_bug.cgi?id=191031
415
416         Reviewed by Michael Catanzaro.
417
418         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
419         (TestWebKitAPI::TEST_F): Remove a test for a domain
420         that is not registrable and shouldn't be tested there.
421
422 2018-10-29  Tim Horton  <timothy_horton@apple.com>
423
424         Modernize WebKit nibs and lprojs for localization's sake
425         https://bugs.webkit.org/show_bug.cgi?id=190911
426         <rdar://problem/45349466>
427
428         Reviewed by Dan Bernstein.
429
430         * Scripts/check-inspector-strings:
431         * Scripts/update-webkit-localizable-strings:
432         * gtk/manifest.txt.in:
433         * wpe/manifest.txt.in:
434         English->en
435
436 2018-10-29  Daniel Bates  <dabates@apple.com>
437
438         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
439         https://bugs.webkit.org/show_bug.cgi?id=191036
440
441         Reviewed by Andy Estes.
442
443         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
444         by an enum that contains two or more enumerators with the same value. For example, suppose
445         you have the following enum:
446
447         enum Flag {
448             A = 1 << 0,
449             AAlias = A,
450         };
451
452         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
453         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
454         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
455         tend to be used in bounds checks as opposed to code that adds to a set.
456
457         * lldb/lldbWebKitTester/main.cpp:
458         (testSummaryProviders):
459         * lldb/lldb_webkit.py:
460         (WTFOptionSetProvider.update):
461         * lldb/lldb_webkit_unittest.py:
462         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
463         (TestSummaryProviders):
464         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
465
466 2018-10-29  Daniel Bates  <dabates@apple.com>
467
468         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
469         https://bugs.webkit.org/show_bug.cgi?id=191033
470
471         Reviewed by Andy Estes.
472
473         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
474         We display the same details in the summary for a Frame because its Document tends to be the most
475         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
476         and whether the origin has universal access.
477
478         * lldb/lldb_webkit.py:
479         (__lldb_init_module):
480         Register new summary providers.
481
482         (WebCoreSecurityOrigin_SummaryProvider):
483         (WebCoreFrame_SummaryProvider):
484         (WebCoreDocument_SummaryProvider):
485         Add new summary providers.
486
487         (StdOptionalWrapper):
488         (StdOptionalWrapper.__init__):
489         (StdOptionalWrapper.has_value):
490         (StdOptionalWrapper.value):
491         Convenience data type that provides access to the fields of a std::optional<>.
492         
493         (WebCoreSecurityOriginProvider):
494         (WebCoreSecurityOriginProvider.__init__):
495         (WebCoreSecurityOriginProvider.is_unique):
496         (WebCoreSecurityOriginProvider.scheme):
497         (WebCoreSecurityOriginProvider.host):
498         (WebCoreSecurityOriginProvider.port):
499         (WebCoreSecurityOriginProvider.domain):
500         (WebCoreSecurityOriginProvider.has_universal_access):
501         (WebCoreSecurityOriginProvider.to_string):
502         (WebCoreFrameProvider):
503         (WebCoreFrameProvider.__init__):
504         (WebCoreFrameProvider.is_main_frame):
505         (WebCoreFrameProvider.document):
506         (WebCoreDocumentProvider):
507         (WebCoreDocumentProvider.__init__):
508         (WebCoreDocumentProvider.url):
509         (WebCoreDocumentProvider.origin):
510         (WebCoreDocumentProvider.page_cache_state):
511         (WebCoreDocumentProvider.frame):
512
513 2018-10-29  Chris Dumez  <cdumez@apple.com>
514
515         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
516         https://bugs.webkit.org/show_bug.cgi?id=190975
517         <rdar://problem/45059256>
518
519         Reviewed by Antti Koivisto.
520
521         Add API test coverage.
522
523         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
524
525 2018-10-29  Zalan Bujtas  <zalan@apple.com>
526
527         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
528         https://bugs.webkit.org/show_bug.cgi?id=191018
529
530         Reviewed by Antti Koivisto.
531
532         * LayoutReloaded/misc/LFC-passing-tests.txt:
533
534 2018-10-29  Zalan Bujtas  <zalan@apple.com>
535
536         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
537         https://bugs.webkit.org/show_bug.cgi?id=191011
538
539         Reviewed by Antti Koivisto.
540
541         * LayoutReloaded/misc/LFC-passing-tests.txt:
542
543 2018-10-29  Zalan Bujtas  <zalan@apple.com>
544
545         Missing from r237549
546
547         Reviewed by Antti Koivisto.
548
549         * LayoutReloaded/misc/LFC-passing-tests.txt:
550
551 2018-10-29  Zalan Bujtas  <zalan@apple.com>
552
553         [LFC][IFC] Add support for simple intruding floats.
554         https://bugs.webkit.org/show_bug.cgi?id=190998
555
556         Reviewed by Antti Koivisto.
557
558         * LayoutReloaded/misc/LFC-passing-tests.txt:
559
560 2018-10-29  Zalan Bujtas  <zalan@apple.com>
561
562         [LFC][IFC] Inline layout produces separate runs when float is present.
563         https://bugs.webkit.org/show_bug.cgi?id=190980
564
565         Reviewed by Antti Koivisto.
566
567         * LayoutReloaded/misc/LFC-passing-tests.txt:
568
569 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
570
571         New bytecode format for JSC
572         https://bugs.webkit.org/show_bug.cgi?id=187373
573         <rdar://problem/44186758>
574
575         Reviewed by Filip Pizlo.
576
577         Do not force ENABLE_JIT=true when $forceCLoop is false.
578
579         * Scripts/build-jsc:
580
581 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
582
583         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
584
585         Unreviewed build fix
586
587         The build fails because of some array-bound check related
588         to strcmp() macro optimizations. Disabling selective Werrors
589         when building xserver-xorg might get past this.
590
591         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
592         configuration.
593
594 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
595
596         [GTK] Update API test expectations after r237383
597         https://bugs.webkit.org/show_bug.cgi?id=186913
598
599         Unreviewed gardening.
600
601         * TestWebKitAPI/glib/TestExpectations.json: Remove
602         passing TestSSL tests.
603
604 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
605
606         [WPE] Add the WebKitVersion.h header
607         https://bugs.webkit.org/show_bug.cgi?id=191015
608
609         Reviewed by Michael Catanzaro.
610
611         * MiniBrowser/wpe/main.cpp:
612         (automationStartedCallback): Remove the FIXME and finally enable the
613         webkit_application_info_set_version() call.
614         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
615         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
616
617 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
618
619         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
620         https://bugs.webkit.org/show_bug.cgi?id=190948
621
622         Reviewed by Brent Fulgham.
623
624         vcxproj files have been removed in Bug 154388.
625
626         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
627         * Scripts/build-jsc:
628         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
629         which is not used because Windows ports are using CMake.
630
631 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
632
633         HashMap should support selecting a random entry
634         https://bugs.webkit.org/show_bug.cgi?id=190814
635
636         Reviewed by Ryosuke Niwa.
637
638         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
639         IsEvenlyDistributed to reflect the fact that we're only testing the
640         distribution. Added a test case that covers more table densities and
641         the remove() operation.
642
643 2018-10-27  Charlie Turner  <cturner@igalia.com>
644
645         [GTK] Add bubblewrap feature option
646         https://bugs.webkit.org/show_bug.cgi?id=190981
647
648         Reviewed by Xabier Rodriguez-Calvar.
649
650         Without this, it was not possible to disable the bubblewrap sandbox
651         from the webkit build scripts.
652
653         * Scripts/webkitperl/FeatureList.pm:
654
655 2018-10-26  Commit Queue  <commit-queue@webkit.org>
656
657         Unreviewed, rolling out r237479 and r237484.
658         https://bugs.webkit.org/show_bug.cgi?id=190978
659
660         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
661
662         Reverted changesets:
663
664         "New bytecode format for JSC"
665         https://bugs.webkit.org/show_bug.cgi?id=187373
666         https://trac.webkit.org/changeset/237479
667
668         "Gardening: Build fix after r237479."
669         https://bugs.webkit.org/show_bug.cgi?id=187373
670         https://trac.webkit.org/changeset/237484
671
672 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
673
674         New bytecode format for JSC
675         https://bugs.webkit.org/show_bug.cgi?id=187373
676         <rdar://problem/44186758>
677
678         Reviewed by Filip Pizlo.
679
680         Do not force ENABLE_JIT=true when $forceCLoop is false.
681
682         * Scripts/build-jsc:
683
684 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
685
686         HashMap should support selecting a random entry
687         https://bugs.webkit.org/show_bug.cgi?id=190814
688
689         Reviewed by Antti Koivisto.
690
691         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
692         more thoroughly test for randomness.
693
694 2018-10-26  Antti Koivisto  <antti@apple.com>
695
696         hashSet.remove(hashSet.random()) doesn't build
697         https://bugs.webkit.org/show_bug.cgi?id=190953
698
699         Reviewed by Chris Dumez.
700
701         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
702         (TestWebKitAPI::TEST):
703
704 2018-10-26  Zalan Bujtas  <zalan@apple.com>
705
706         [LFC][IFC] Layout floats as part of the inline content
707         https://bugs.webkit.org/show_bug.cgi?id=190942
708
709         Reviewed by Antti Koivisto.
710
711         * LayoutReloaded/misc/LFC-passing-tests.txt:
712
713 2018-10-26  Alicia Boya García  <aboya@igalia.com>
714
715         [MSE][WTF][Media] Invalid MediaTime should be falsy
716         https://bugs.webkit.org/show_bug.cgi?id=190893
717
718         Reviewed by Jer Noble.
719
720         This patch adds additional API tests for the conversions from
721         MediaTime to boolean.
722
723         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
724         (TestWebKitAPI::TEST):
725
726 2018-10-25  Chris Dumez  <cdumez@apple.com>
727
728         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
729         https://bugs.webkit.org/show_bug.cgi?id=190915
730         <rdar://problem/45059069>
731
732         Reviewed by Geoffrey Garen.
733
734         Add API test coverage.
735
736         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
737
738 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
739
740         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
741         https://bugs.webkit.org/show_bug.cgi?id=190896
742
743         Reviewed by Matt Baker.
744
745         * Scripts/webkitpy/common/config/watchlist:
746
747 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
748
749         HashMap should support selecting a random entry
750         https://bugs.webkit.org/show_bug.cgi?id=190814
751
752         Reviewed by Antti Koivisto.
753
754         Unit testing is fun and easy!
755
756         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
757         (TestWebKitAPI::ZeroHash::hash):
758         (TestWebKitAPI::TEST):
759
760 2018-10-24  Tim Horton  <timothy_horton@apple.com>
761
762         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
763         https://bugs.webkit.org/show_bug.cgi?id=190897
764
765         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
766         (TestWebKitAPI::TEST):
767         Disable the test for now.
768
769 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
770
771         Clean up some obsolete macOS version guards
772         https://bugs.webkit.org/show_bug.cgi?id=190887
773
774         Reviewed by Dan Bernstein.
775
776         * TestWebKitAPI/cocoa/TestWKWebView.mm:
777         (__simulated_forceClickAssociatedEventsMask):
778         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
779         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
780         (WTR::initializeWebViewConfiguration):
781         * WebKitTestRunner/mac/EventSenderProxy.mm:
782         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
783
784 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
785
786         Turn on Conic Gradients
787         https://bugs.webkit.org/show_bug.cgi?id=190810
788
789         Reviewed by Tim Horton.
790
791         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
792
793 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
794
795         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
796         https://bugs.webkit.org/show_bug.cgi?id=190328
797
798         Reviewed by Michael Catanzaro.
799
800         * TestWebKitAPI/CMakeLists.txt:
801         * TestWebKitAPI/PlatformWPE.cmake:
802
803 2018-10-24  Chris Dumez  <cdumez@apple.com>
804
805         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
806         https://bugs.webkit.org/show_bug.cgi?id=190846
807         <rdar://problem/45058938>
808
809         Reviewed by Antti Koivisto.
810
811         Add API test coverage.
812
813         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
814
815 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
816
817         [GTK] TestSSL failing because of missing libsoup patch
818         https://bugs.webkit.org/show_bug.cgi?id=190869
819
820         Reviewed by Michael Catanzaro.
821
822         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
823         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
824
825 2018-10-23  Justin Fan  <justin_fan@apple.com>
826
827         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
828         https://bugs.webkit.org/show_bug.cgi?id=190817
829
830         Reviewed by Dean Jackson.
831
832         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
833         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
834         (TestWebKitAPI::TEST_F):
835         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
836         (TestWebKitAPI::TEST_F):
837         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
838         (TestWebKitAPI::TEST_F):
839         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
840         (TestWebKitAPI::TEST_F):
841         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
842         (TestWebKitAPI::TEST_F):
843         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
844
845 2018-10-23  Chris Dumez  <cdumez@apple.com>
846
847         [PSON] Add support for cross-site client-side redirects
848         https://bugs.webkit.org/show_bug.cgi?id=190806
849         <rdar://problem/45047344>
850
851         Reviewed by Geoffrey Garen.
852
853         Add API test coverage.
854
855         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
856         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
857         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
858
859 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
860
861         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
862         https://bugs.webkit.org/show_bug.cgi?id=190789
863
864         Reviewed by Michael Catanzaro.
865
866         When the network process serializes certificate data to other
867         processes through the argument coders, the certificate chain, if
868         present, is lost. In practice this means that applications using
869         the public API to process certificate info have no details on the
870         certificate chain, other than the very basics included in the
871         certificate. Serialize the entire chain if available in the
872         certificate.
873
874         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
875         (testSSL): Test that the self-signed certificate has no bogus
876         issuer certificate.
877
878 2018-10-22  Tim Horton  <timothy_horton@apple.com>
879
880         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
881         https://bugs.webkit.org/show_bug.cgi?id=190801
882         <rdar://problem/43674361>
883
884         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
885         (TEST):
886         Use a parented WKWebView for this test, otherwise none of the assertions
887         about gesture recognizers work anymore.
888
889 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
890
891         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
892         https://bugs.webkit.org/show_bug.cgi?id=187972
893
894         Unreviewed test gardening.
895
896         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
897         (TestWebKitAPI::TEST): Disable the flaky test.
898
899 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
900
901         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
902         https://bugs.webkit.org/show_bug.cgi?id=190777
903
904         Reviewed by Tim Horton.
905
906         Implement isShowingDataListSuggestions on iOS. See below for more details.
907
908         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
909         (WTR::UIScriptController::isShowingDataListSuggestions const):
910
911         Add a stub implementation for DumpRenderTree.
912
913         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
914         (WTR::UIScriptController::isShowingDataListSuggestions const):
915
916         Move this stub implementation to !PLATFORM(COCOA).
917
918         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
919         (WTR::forEachViewInHierarchy):
920
921         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
922
923         (WTR::UIScriptController::isShowingDataListSuggestions const):
924
925         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
926
927 2018-10-19  Dan Bernstein  <mitz@apple.com>
928
929         [macOS] MiniBrowser has an unused injected bundle
930         https://bugs.webkit.org/show_bug.cgi?id=190770
931
932         Reviewed by Tim Horton.
933
934         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
935         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
936           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
937         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
938         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
939         * MiniBrowser/mac/Bundle: Removed.
940
941 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
942
943         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
944         https://bugs.webkit.org/show_bug.cgi?id=190621
945         <rdar://problem/45310649>
946
947         Reviewed by Tim Horton.
948
949         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
950
951         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
952         (WTR::UIScriptController::resignFirstResponder):
953         * DumpRenderTree/mac/UIScriptControllerMac.mm:
954         (WTR::UIScriptController::resignFirstResponder):
955         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
956         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
957         (WTR::UIScriptController::resignFirstResponder):
958         * TestRunnerShared/UIScriptContext/UIScriptController.h:
959         * WebKitTestRunner/UIScriptControllerCocoa.mm:
960         (WTR::UIScriptController::resignFirstResponder):
961         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
962         (WTR::PlatformWebView::makeWebViewFirstResponder):
963
964         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
965         responder on the WKWebView when running iOS layout tests.
966
967         * WebKitTestRunner/ios/TestControllerIOS.mm:
968         (WTR::TestController::platformResetStateToConsistentValues):
969
970         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
971
972 2018-10-19  Dean Jackson  <dino@apple.com>
973
974         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
975         https://bugs.webkit.org/show_bug.cgi?id=186946
976         <rdar://problem/41724248>
977
978         Reviewed by Antoine Quint.
979
980         If the incoming test has different enableWebAnimationsCSSIntegration options,
981         then we need to create a new WebView.
982
983         * DumpRenderTree/TestOptions.cpp:
984         (TestOptions::webViewIsCompatibleWithOptions const):
985
986 2018-10-19  Charlie Turner  <cturner@igalia.com>
987
988         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
989         https://bugs.webkit.org/show_bug.cgi?id=190738
990
991         Reviewed by Xabier Rodriguez-Calvar.
992
993         Add a GStreamer patch to avoid crashing when the run-time logging
994         level is TRACE. There was a missing null check which caused many
995         tests to crash.
996
997         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
998
999 2018-10-18  Alicia Boya García  <aboya@igalia.com>
1000
1001         [Media] Use nanoseconds as MaximumTimeScale
1002         https://bugs.webkit.org/show_bug.cgi?id=190631
1003
1004         Rebased MediaTime tests covering timescales over the maximum.
1005
1006         Reviewed by Jer Noble.
1007
1008         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1009         (TestWebKitAPI::TEST):
1010
1011 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
1012
1013         clean-webkit pulls in many unnecessary dependencies in webkitpy
1014         https://bugs.webkit.org/show_bug.cgi?id=190732
1015
1016         Reviewed by Alexey Proskuryakov.
1017
1018         * Scripts/webkitpy/common/host.py:
1019         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
1020         (Host):
1021         (Host.bugs):
1022         (Host.bugzilla):
1023         (Host.web):
1024
1025 2018-10-18  Chris Dumez  <cdumez@apple.com>
1026
1027         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
1028         https://bugs.webkit.org/show_bug.cgi?id=190721
1029         <rdar://problem/45059699>
1030
1031         Reviewed by Alex Christensen.
1032
1033         Add API test coverage.
1034
1035         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1036
1037 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1038
1039         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1040         https://bugs.webkit.org/show_bug.cgi?id=190729
1041
1042         Reviewed by Tim Horton.
1043
1044         * DumpRenderTree/AccessibilityController.h:
1045         * DumpRenderTree/AccessibilityTextMarker.h:
1046         * DumpRenderTree/AccessibilityUIElement.cpp:
1047         (AccessibilityUIElement::getJSClass):
1048         * DumpRenderTree/AccessibilityUIElement.h:
1049         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
1050         * DumpRenderTree/TestRunner.cpp:
1051         (getSecureEventInputIsEnabledCallback):
1052         (TestRunner::staticFunctions):
1053         (TestRunner::callUIScriptCallback):
1054         * DumpRenderTree/TestRunner.h:
1055         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1056         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
1057         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1058         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
1059         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1060         * DumpRenderTree/ios/TextInputControllerIOS.m:
1061         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1062         * DumpRenderTree/mac/AppleScriptController.m:
1063         * DumpRenderTree/mac/DumpRenderTree.mm:
1064         (createWebViewAndOffscreenWindow):
1065         (destroyWebViewAndOffscreenWindow):
1066         (resetWebPreferencesToConsistentValues):
1067         (setDefaultsToConsistentValuesForTesting):
1068         (allocateGlobalControllers):
1069         (releaseGlobalControllers):
1070         (addTestPluginsToPluginSearchPath):
1071         (prepareConsistentTestingEnvironment):
1072         (dumpRenderTree):
1073         (DumpRenderTreeMain):
1074         (dumpFrameAsPDF):
1075         (dumpBackForwardListForAllWindows):
1076         (updateDisplay):
1077         (dump):
1078         (resetWebViewToConsistentStateBeforeTesting):
1079         (runTest):
1080         (displayWebView):
1081         (displayAndTrackRepaintsWebView):
1082         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1083         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1084         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1085         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1086         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1087         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1088         (-[DumpRenderTreeWindow close]):
1089         (-[DumpRenderTreeWindow webView]):
1090         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
1091         * DumpRenderTree/mac/EventSendingController.h:
1092         * DumpRenderTree/mac/EventSendingController.mm:
1093         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1094         (+[EventSendingController webScriptNameForSelector:]):
1095         (-[EventSendingController dealloc]):
1096         (-[EventSendingController currentEventTime]):
1097         (-[EventSendingController clearKillRing]):
1098         (modifierFlags):
1099         (-[EventSendingController mouseDown:withModifiers:]):
1100         (-[EventSendingController scalePageBy:atX:andY:]):
1101         (-[EventSendingController mouseUp:withModifiers:]):
1102         (-[EventSendingController mouseMoveToX:Y:]):
1103         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1104         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1105         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1106         (-[FrameLoadDelegate init]):
1107         (-[FrameLoadDelegate dealloc]):
1108         (-[FrameLoadDelegate processWork:]):
1109         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1110         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1111         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1112         * DumpRenderTree/mac/LayoutTestHelper.m:
1113         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1114         (-[MockGeolocationProvider timerFired]):
1115         * DumpRenderTree/mac/TestRunnerMac.mm:
1116         (TestRunner::setMainFrameIsFirstResponder):
1117         (TestRunner::setAutomaticLinkDetectionEnabled):
1118         (TestRunner::setUseDashboardCompatibilityMode):
1119         (TestRunner::isCommandEnabled):
1120         (TestRunner::inspectorTestStubURL):
1121         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1122         (TestRunner::abortModal):
1123         (TestRunner::setTextDirection):
1124         (TestRunner::addChromeInputField):
1125         (TestRunner::removeChromeInputField):
1126         (TestRunner::focusWebView):
1127         (TestRunner::setBackingScaleFactor):
1128         (TestRunner::imageCountInGeneralPasteboard const):
1129         * DumpRenderTree/mac/UIDelegate.h:
1130         * DumpRenderTree/mac/UIDelegate.mm:
1131         (-[UIDelegate modalWindowWillClose:]):
1132         (-[UIDelegate webViewRunModal:]):
1133         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1134         (-[UIDelegate dealloc]):
1135         * Scripts/check-for-inappropriate-objc-class-names:
1136         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1137         * TestRunnerShared/spi/UIKitTestSPI.h:
1138         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
1139         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
1140         (WebCore::operator<<):
1141         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1142         (TestWebKitAPI::TEST):
1143         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1144         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1145         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
1146         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
1147         (TestWebKitAPI::TEST):
1148         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1149         (TestWebKitAPI::TEST):
1150         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
1151         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1152         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1153         (TEST):
1154         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
1155         (TEST):
1156         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
1157         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1158         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1159         (TEST):
1160         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
1161         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1162         (createWebViewWithCustomPasteboardDataEnabled):
1163         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
1164         (TEST):
1165         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
1166         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
1167         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1168         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1169         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1170         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
1171         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
1172         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
1173         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
1174         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
1175         (defaultWebsiteCacheDirectory):
1176         (defaultApplicationCacheDirectory):
1177         (TEST):
1178         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
1179         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
1180         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1181         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1182         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1183         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1184         (TestWebKitAPI::TEST):
1185         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
1186         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1187         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
1188         (runTestWithWidth):
1189         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
1190         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
1191         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1192         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
1193         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1194         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
1195         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1196         (platformCopyRichTextWithMultipleAttachments):
1197         (platformCopyRichTextWithImage):
1198         (platformCopyPNG):
1199         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1200         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1201         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1202         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
1203         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1204         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
1205         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1206         (TEST):
1207         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1208         (TEST):
1209         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1210         (TEST):
1211         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
1212         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1213         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
1214         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
1215         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1216         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1217         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1218         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1219         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1220         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
1221         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1222         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
1223         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
1224         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1225         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1226         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
1227         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1228         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
1229         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
1230         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1231         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
1232         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1233         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1234         (-[WKWebView _test_waitForDidFinishNavigation]):
1235         * TestWebKitAPI/cocoa/TestWKWebView.h:
1236         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1237         * TestWebKitAPI/config.h:
1238         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1239         * TestWebKitAPI/ios/TestWKWebViewController.h:
1240         * TestWebKitAPI/ios/TestWKWebViewController.mm:
1241         * TestWebKitAPI/ios/UIKitSPI.h:
1242         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1243         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1244         (WTR::InjectedBundle::beginTesting):
1245         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1246         (WTR::TestRunner::inspectorTestStubURL):
1247         * WebKitTestRunner/TestController.cpp:
1248         (WTR::TestController::webProcessName):
1249         (WTR::TestController::networkProcessName):
1250         * WebKitTestRunner/TestInvocation.cpp:
1251         (WTR::TestInvocation::invoke):
1252         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1253         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1254         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1255         (WTR::initializeWebViewConfiguration):
1256         (WTR::TestController::platformCreateWebView):
1257         (WTR::TestController::imageCountInGeneralPasteboard const):
1258         (WTR::TestController::addTestKeyToKeychain):
1259         (WTR::TestController::cleanUpKeychain):
1260         (WTR::TestController::keyExistsInKeychain):
1261         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1262         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1263         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1264
1265 2018-10-18  Chris Dumez  <cdumez@apple.com>
1266
1267         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
1268         https://bugs.webkit.org/show_bug.cgi?id=190688
1269         <rdar://problem/45354095>
1270
1271         Reviewed by Antti Koivisto.
1272
1273         Extended API test coverage to confirm that:
1274         - We do not accumulate more than 3 suspended processes.
1275         - We can navigate back 3 times and use the page cache for each of these loads.
1276
1277         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1278
1279 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1280
1281         Enable the datalist element by default on iOS and macOS
1282         https://bugs.webkit.org/show_bug.cgi?id=190594
1283         <rdar://problem/45281159>
1284
1285         Reviewed by Ryosuke Niwa and Tim Horton.
1286
1287         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1288
1289 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
1290
1291         AX: Certain tags should identify their context to iOS API
1292         https://bugs.webkit.org/show_bug.cgi?id=190622
1293         <rdar://problem/45308194>
1294
1295         Reviewed by Zalan Bujtas.
1296
1297         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1298         (AccessibilityUIElement::stringAttributeValue):
1299         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1300         (WTR::AccessibilityUIElement::stringAttributeValue):
1301
1302 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
1303
1304         Add a switch for Web SQL
1305         https://bugs.webkit.org/show_bug.cgi?id=190271
1306
1307         Reviewed by Ryosuke Niwa.
1308
1309         * WebKitTestRunner/TestController.cpp:
1310         (WTR::TestController::resetPreferencesToConsistentValues):
1311
1312 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1313
1314         Remove InjectedBundleBackForwardList
1315         https://bugs.webkit.org/show_bug.cgi?id=190640
1316
1317         Reviewed by Chris Dumez.
1318
1319         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1320         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
1321         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1322         (WTR::InjectedBundlePage::prepare):
1323         (WTR::InjectedBundlePage::dumpHistory):
1324         (WTR::hasPrefix): Deleted.
1325         (WTR::compareByTargetName): Deleted.
1326         (WTR::dumpBackForwardListItem): Deleted.
1327         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
1328         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1329         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1330         (WTR::TestRunner::clearBackForwardList):
1331
1332 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
1333
1334         Unreviewed, added myself to contributors.json.
1335
1336         * Scripts/webkitpy/common/config/contributors.json:
1337
1338 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1339
1340         Implement feature flag and bindings for CSS Painting API
1341         https://bugs.webkit.org/show_bug.cgi?id=190237
1342
1343         Reviewed by Ryosuke Niwa.
1344
1345         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1346
1347 2018-10-16  Philippe Normand  <pnormand@igalia.com>
1348
1349         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
1350
1351         * gstreamer/jhbuild.modules:
1352
1353 2018-10-16  Philippe Normand  <pnormand@igalia.com>
1354
1355         [GTK][JHBuild] Disable libmount support in glib
1356
1357         Rubber-stamped by Alejandro G. Castro.
1358
1359         This feature doesn't seem required for our setup.
1360
1361         * gtk/jhbuild.modules:
1362
1363 2018-10-15  Justin Fan  <justin_fan@apple.com>
1364
1365         Add WebGPU 2018 feature flag and experimental feature flag
1366         https://bugs.webkit.org/show_bug.cgi?id=190509
1367
1368         Reviewed by Dean Jackson.
1369
1370         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1371         for the 2018 WebGPU prototype.
1372
1373         * DumpRenderTree/TestOptions.cpp:
1374         (TestOptions::TestOptions):
1375         * DumpRenderTree/TestOptions.h:
1376         * DumpRenderTree/mac/DumpRenderTree.mm:
1377         (setWebPreferencesForTestOptions):
1378         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1379
1380 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
1381
1382         Update bot configuration for Sierra archive queues
1383         https://bugs.webkit.org/show_bug.cgi?id=190605
1384
1385         Reviewed by Aakash Jain.
1386
1387         * BuildSlaveSupport/build.webkit.org-config/config.json:
1388
1389 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1390
1391         Add support for prefers-color-scheme media query
1392         https://bugs.webkit.org/show_bug.cgi?id=190499
1393         rdar://problem/45212025
1394
1395         Reviewed by Dean Jackson.
1396
1397         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
1398         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1399
1400 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
1401
1402         [JHBuild] Add xdg-dbus-proxy module
1403         https://bugs.webkit.org/show_bug.cgi?id=190589
1404
1405         Reviewed by Michael Catanzaro.
1406
1407         * gtk/jhbuild.modules:
1408
1409 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
1410
1411         [GTK] Add new sandboxing dependencies to install-dependencies
1412         https://bugs.webkit.org/show_bug.cgi?id=190588
1413
1414         Reviewed by Michael Catanzaro.
1415
1416         * gtk/install-dependencies:
1417
1418 2018-10-15  Chris Dumez  <cdumez@apple.com>
1419
1420         Experiment: target=_blank on anchors should imply rel=noopener
1421         https://bugs.webkit.org/show_bug.cgi?id=190481
1422
1423         Reviewed by Alex Christensen.
1424
1425         Add API test coverage to make sure we can now swap process when target=_blank
1426         is specified on an anchor but rel=noopener is not.
1427
1428         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1429
1430 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1431
1432         [iOS] Can't select text after dismissing the keyboard when changing focus
1433         https://bugs.webkit.org/show_bug.cgi?id=190563
1434         <rdar://problem/44613559>
1435
1436         Reviewed by Tim Horton.
1437
1438         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1439         (WTR::UIScriptController::isShowingKeyboard const):
1440
1441         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
1442         details.
1443
1444         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1445         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1446         (WTR::UIScriptController::isShowingKeyboard const):
1447         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1448         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1449         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1450
1451         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
1452         `isShowingKeyboard` as the getter method.
1453
1454         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
1455         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
1456         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1457         (WTR::UIScriptController::isShowingKeyboard const):
1458
1459 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
1460
1461         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
1462
1463         * Scripts/run-javascriptcore-tests:
1464         (runJSCStressTests): Remove wsl-tests.yaml.
1465
1466 2018-10-15  Christopher Reid  <chris.reid@sony.com>
1467
1468         [Curl][WinCairo] Add Public Suffix support to WinCairo
1469         https://bugs.webkit.org/show_bug.cgi?id=183060
1470
1471         Reviewed by Alex Christensen.
1472
1473         Share mac's PublicSuffix tests with all ports.
1474
1475         * TestWebKitAPI/PlatformWin.cmake:
1476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1477         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
1478         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
1479
1480 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
1481
1482         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
1483         https://bugs.webkit.org/show_bug.cgi?id=190555
1484
1485         Unreviewed.
1486
1487         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
1488
1489         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
1490         * WebGPUShadingLanguageRI/All.js: Removed.
1491         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
1492         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
1493         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
1494         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
1495         * WebGPUShadingLanguageRI/Assignment.js: Removed.
1496         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
1497         * WebGPUShadingLanguageRI/Block.js: Removed.
1498         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
1499         * WebGPUShadingLanguageRI/Break.js: Removed.
1500         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
1501         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
1502         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
1503         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
1504         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
1505         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
1506         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
1507         * WebGPUShadingLanguageRI/Casts.js: Removed.
1508         * WebGPUShadingLanguageRI/Check.js: Removed.
1509         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
1510         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
1511         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
1512         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
1513         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
1514         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
1515         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
1516         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
1517         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
1518         * WebGPUShadingLanguageRI/Checker.js: Removed.
1519         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
1520         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
1521         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
1522         * WebGPUShadingLanguageRI/Continue.js: Removed.
1523         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
1524         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
1525         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
1526         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
1527         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
1528         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
1529         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
1530         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
1531         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
1532         * WebGPUShadingLanguageRI/EPtr.js: Removed.
1533         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
1534         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
1535         * WebGPUShadingLanguageRI/EnumType.js: Removed.
1536         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
1537         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
1538         * WebGPUShadingLanguageRI/Expression.js: Removed.
1539         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
1540         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
1541         * WebGPUShadingLanguageRI/Field.js: Removed.
1542         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
1543         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
1544         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
1545         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
1546         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
1547         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
1548         * WebGPUShadingLanguageRI/Func.js: Removed.
1549         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
1550         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
1551         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
1552         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
1553         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
1554         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
1555         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
1556         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
1557         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
1558         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
1559         * WebGPUShadingLanguageRI/Inline.js: Removed.
1560         * WebGPUShadingLanguageRI/Inliner.js: Removed.
1561         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
1562         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
1563         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
1564         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
1565         * WebGPUShadingLanguageRI/Lexer.js: Removed.
1566         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
1567         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
1568         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
1569         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
1570         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
1571         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
1572         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
1573         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
1574         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
1575         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
1576         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
1577         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
1578         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
1579         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
1580         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
1581         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
1582         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
1583         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
1584         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
1585         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
1586         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
1587         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
1588         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
1589         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
1590         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
1591         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
1592         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
1593         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
1594         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
1595         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
1596         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
1597         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
1598         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
1599         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
1600         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
1601         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
1602         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
1603         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
1604         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
1605         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
1606         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
1607         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
1608         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
1609         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
1610         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
1611         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
1612         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
1613         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
1614         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
1615         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
1616         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
1617         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
1618         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
1619         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
1620         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
1621         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
1622         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
1623         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
1624         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
1625         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
1626         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
1627         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
1628         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
1629         * WebGPUShadingLanguageRI/NameContext.js: Removed.
1630         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
1631         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
1632         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
1633         * WebGPUShadingLanguageRI/NativeType.js: Removed.
1634         * WebGPUShadingLanguageRI/Node.js: Removed.
1635         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
1636         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
1637         * WebGPUShadingLanguageRI/NullType.js: Removed.
1638         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
1639         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
1640         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
1641         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
1642         * WebGPUShadingLanguageRI/Parse.js: Removed.
1643         * WebGPUShadingLanguageRI/Prepare.js: Removed.
1644         * WebGPUShadingLanguageRI/Program.js: Removed.
1645         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
1646         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
1647         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
1648         * WebGPUShadingLanguageRI/PtrType.js: Removed.
1649         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
1650         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
1651         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
1652         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
1653         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
1654         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
1655         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
1656         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
1657         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
1658         * WebGPUShadingLanguageRI/Return.js: Removed.
1659         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
1660         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
1661         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
1662         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
1663         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
1664         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
1665         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
1666         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
1667         * WebGPUShadingLanguageRI/Sampler.js: Removed.
1668         * WebGPUShadingLanguageRI/Semantic.js: Removed.
1669         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
1670         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
1671         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
1672         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
1673         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
1674         * WebGPUShadingLanguageRI/StructType.js: Removed.
1675         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
1676         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
1677         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
1678         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
1679         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
1680         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
1681         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
1682         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
1683         * WebGPUShadingLanguageRI/Test.html: Removed.
1684         * WebGPUShadingLanguageRI/Test.js: Removed.
1685         * WebGPUShadingLanguageRI/Texture.js: Removed.
1686         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
1687         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
1688         * WebGPUShadingLanguageRI/Type.js: Removed.
1689         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
1690         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
1691         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
1692         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
1693         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
1694         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
1695         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
1696         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
1697         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
1698         * WebGPUShadingLanguageRI/Value.js: Removed.
1699         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
1700         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
1701         * WebGPUShadingLanguageRI/VectorType.js: Removed.
1702         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
1703         * WebGPUShadingLanguageRI/Visitor.js: Removed.
1704         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
1705         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
1706         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
1707         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
1708         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
1709         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
1710         * WebGPUShadingLanguageRI/index.html: Removed.
1711         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
1712         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
1713
1714 2018-10-15  Philippe Normand  <pnormand@igalia.com>
1715
1716         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
1717         https://bugs.webkit.org/show_bug.cgi?id=190581
1718
1719         Reviewed by Michael Catanzaro.
1720
1721         These bots don't use JHBuild and their host GStreamer version is
1722         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
1723
1724         * BuildSlaveSupport/build.webkit.org-config/config.json:
1725
1726 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1727
1728         Use pragma once in WTF
1729         https://bugs.webkit.org/show_bug.cgi?id=190527
1730
1731         Reviewed by Chris Dumez.
1732
1733         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
1734
1735         * DumpRenderTree/TestRunner.cpp:
1736         (TestRunner::queueLoadHTMLString):
1737         (TestRunner::queueLoadAlternateHTMLString):
1738         (TestRunner::queueBackNavigation):
1739         (TestRunner::queueForwardNavigation):
1740         (TestRunner::queueLoadingScript):
1741         (TestRunner::queueNonLoadingScript):
1742         (TestRunner::queueReload):
1743         * DumpRenderTree/WorkQueue.cpp:
1744         (WorkQueue::singleton): Deleted.
1745         (WorkQueue::WorkQueue): Deleted.
1746         (WorkQueue::queue): Deleted.
1747         (WorkQueue::dequeue): Deleted.
1748         (WorkQueue::count): Deleted.
1749         (WorkQueue::clear): Deleted.
1750         (WorkQueue::processWork): Deleted.
1751         * DumpRenderTree/WorkQueue.h:
1752         (WorkQueue::setFrozen): Deleted.
1753         * DumpRenderTree/WorkQueueItem.h:
1754         * DumpRenderTree/mac/DumpRenderTree.mm:
1755         (runTest):
1756         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1757         (-[FrameLoadDelegate processWork:]):
1758         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
1759         * DumpRenderTree/mac/TestRunnerMac.mm:
1760         (TestRunner::notifyDone):
1761         (TestRunner::forceImmediateCompletion):
1762         (TestRunner::queueLoad):
1763         * DumpRenderTree/win/DumpRenderTree.cpp:
1764         (runTest):
1765         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1766         (FrameLoadDelegate::processWork):
1767         (FrameLoadDelegate::locationChangeDone):
1768         * DumpRenderTree/win/TestRunnerWin.cpp:
1769         (TestRunner::notifyDone):
1770         (TestRunner::forceImmediateCompletion):
1771         (TestRunner::queueLoad):
1772
1773 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1774
1775         [JSC] Remove Option::useAsyncIterator
1776         https://bugs.webkit.org/show_bug.cgi?id=190567
1777
1778         Reviewed by Saam Barati.
1779
1780         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1781
1782 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
1783
1784         [WPE] Silence a unused-parameter warning
1785
1786         Unreviewed.
1787         * MiniBrowser/wpe/main.cpp:
1788         (decidePermissionRequest):
1789
1790 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
1791
1792         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
1793         https://bugs.webkit.org/show_bug.cgi?id=190537
1794
1795         Reviewed by Alexey Proskuryakov.
1796
1797         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
1798         needs to be split before adding it to the command since it is treated
1799         as a list of args.
1800
1801         * Scripts/webkitpy/common/config/ports.py:
1802         (DeprecatedPort.run_javascriptcore_tests_command):
1803
1804 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1805
1806         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
1807         https://bugs.webkit.org/show_bug.cgi?id=190504
1808         <rdar://problem/45117760>
1809
1810         Reviewed by Tim Horton.
1811
1812         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
1813         macOS and iOS.
1814
1815         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1816         (WTR::UIScriptController::setViewScale):
1817         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1818         (WTR::UIScriptController::setViewScale):
1819         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1820         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1821         (WTR::UIScriptController::setViewScale):
1822         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1823         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
1824
1825         Add a new file for UIScriptController methods on Cocoa platforms.
1826
1827         (WTR::UIScriptController::setViewScale):
1828         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1829         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1830         (WTR::TestController::cocoaResetStateToConsistentValues):
1831
1832         Ensure that _viewScale is reset to 1 after running a layout test.
1833
1834 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
1835
1836         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
1837         https://bugs.webkit.org/show_bug.cgi?id=190536
1838
1839         Reviewed by Alexey Proskuryakov.
1840
1841         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
1842
1843 2018-10-11  Youenn Fablet  <youenn@apple.com>
1844
1845         IOS 12 - Service worker cache not shared when added to homescreen
1846         https://bugs.webkit.org/show_bug.cgi?id=190269
1847         <rdar://problem/45009961>
1848
1849         Reviewed by Alex Christensen.
1850
1851         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1852         Add test to ensure that CacheStorage use the default website data store parameters.
1853
1854 2018-10-11  Tim Horton  <timothy_horton@apple.com>
1855
1856         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
1857         https://bugs.webkit.org/show_bug.cgi?id=190476
1858         <rdar://problem/32757191>
1859
1860         Reviewed by Megan Gardner.
1861
1862         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
1863         (TEST):
1864         Add a test that we don't crash.
1865
1866 2018-10-11  Tim Horton  <timothy_horton@apple.com>
1867
1868         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
1869
1870         * Scripts/webkitpy/tool/steps/options.py:
1871         (Options):
1872         Fix the name of the variable that the --cc-radar option writes into.
1873
1874 2018-10-10  Dean Jackson  <dino@apple.com>
1875
1876         Add --cc-radar option to webkit-patch bug creation
1877         https://bugs.webkit.org/show_bug.cgi?id=190451
1878         <rdar://problem/45176671>
1879
1880         Reviewed by Antoine Quint.
1881
1882         Add a new command line option to automatically
1883         CC radar to new or updated bugs.
1884
1885         * Scripts/webkitpy/tool/commands/commandtest.py:
1886         (CommandsTest.assert_execute_outputs):
1887         * Scripts/webkitpy/tool/commands/upload.py:
1888         (CreateBug.__init__):
1889         (CreateBug.execute):
1890         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1891         (test_prepare_with_cc):
1892         (test_prepare_with_radar):
1893         (test_prepare_with_cc_and_radar):
1894         * Scripts/webkitpy/tool/steps/createbug.py:
1895         (CreateBug.options):
1896         (CreateBug.run):
1897         * Scripts/webkitpy/tool/steps/options.py:
1898         (Options):
1899
1900 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
1901
1902         [GStreamer] Do not build gstgtk plugins
1903         https://bugs.webkit.org/show_bug.cgi?id=190463
1904
1905         Reviewed by Xabier Rodriguez-Calvar.
1906
1907         These plugins pull a GTK+ dependency that, at least in WPE,
1908         is unnecessary. The GTK+ port doesn't need it either, as far
1909         as I can tell.
1910
1911         * gstreamer/jhbuild.modules: Disable gstgtk plugins
1912
1913 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
1914
1915         [GTK][WPE] Add mediaDevices.enumerateDevices support
1916         https://bugs.webkit.org/show_bug.cgi?id=185761
1917
1918         Reviewed by Youenn Fablet.
1919
1920         Added new API test for the mediaDevices.enumerateDevices:
1921         usermedia-enumeratedevices-permission-check. And a new API test
1922         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
1923
1924         * MiniBrowser/gtk/main.c:
1925         (gotWebsiteDataCallback): Added a new section to the about:data
1926         webpage to include the information about the hash salt.
1927         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1928         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
1929         new test checking the enumerateDevices API when permission is
1930         denied and when permission is allowed for the origin.
1931         (beforeAll): Defined the new test.
1932         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1933         (serverCallback): Register a new URI for the enumerateDevices.
1934         (testWebsiteDataConfiguration): Remove the hash salts from the
1935         directories.
1936         (testWebsiteDataDeviceIdHashSalt): New test cheking the
1937         enumerateDevices API.
1938         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
1939         the init structure.
1940         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1941         (WebViewTest::initializeWebView): Make sure the media-stream is
1942         activated in the webView.
1943
1944 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1945
1946         Add WinCairo to the flakiness dashboard
1947         https://bugs.webkit.org/show_bug.cgi?id=188345
1948
1949         Reviewed by Lucas Forschler.
1950
1951         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
1952         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
1953
1954 2018-10-10  Dean Jackson  <dino@apple.com>
1955
1956         [WHSL -> MSL] Annotate semantics correctly in generated MSL
1957         https://bugs.webkit.org/show_bug.cgi?id=190452
1958         <rdar://problem/45178272>
1959
1960         Reviewed by Myles Maxfield.
1961
1962         Correctly label the appropriate semantics as [[position]]
1963         and [[color(N)]].
1964
1965         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
1966         and color attributes. Also use the semantic's index rather than
1967         a counter.
1968         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
1969         output, and only include the actual shader code.
1970
1971 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
1972
1973         build-webkit --inspector-frontend shouldn't have a nonzero exit code
1974         https://bugs.webkit.org/show_bug.cgi?id=190430
1975
1976         Reviewed by Brian Burg.
1977
1978         * Scripts/webkitdirs.pm:
1979         (argumentsForConfiguration):
1980         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
1981         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
1982
1983 2018-10-10  Tim Horton  <timothy_horton@apple.com>
1984
1985         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
1986         https://bugs.webkit.org/show_bug.cgi?id=190420
1987
1988         Reviewed by Simon Fraser.
1989
1990         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1991         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1992         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
1993         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1994         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1995         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1996         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1997         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1998         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
1999         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2000         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2001         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2002         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
2003         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2004         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
2005         Change the testing mechanism for the share sheet such that we up-front
2006         set that it should immediately return with a particular state, instead
2007         of programmatically dismissing the sheet.
2008
2009         Otherwise, running the tests on macOS doesn't work, because we pop
2010         a context menu, which spins the runloop and prevents dismissal from
2011         going through.
2012
2013 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2014
2015         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2016         https://bugs.webkit.org/show_bug.cgi?id=190429
2017
2018         Reviewed by Saam Barati.
2019
2020         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
2021         (TestWebKitAPI::TEST_F):
2022
2023 2018-10-10  Chris Dumez  <cdumez@apple.com>
2024
2025         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
2026         https://bugs.webkit.org/show_bug.cgi?id=190418
2027         <rdar://problem/45059769>
2028
2029         Reviewed by Geoffrey Garen.
2030
2031         Add API test coverage.
2032
2033         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2034
2035 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
2036
2037         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
2038         https://bugs.webkit.org/show_bug.cgi?id=190191
2039
2040         Reviewed by Michael Catanzaro.
2041
2042         * QueueStatusServer/config/queues.py:
2043         * Scripts/webkitpy/common/config/ews.json:
2044         * Scripts/webkitpy/common/config/ports.py:
2045         (DeprecatedPort.run_javascriptcore_tests_command):
2046         Add the possibility to pass arguments to run-javascriptcore-tests with
2047         the JSCTESTS_OPTIONS environment variable
2048         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2049         (test_ews_name):
2050
2051
2052 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
2053
2054         Allow run-javascriptcore-tests to distribute tests between devices
2055         https://bugs.webkit.org/show_bug.cgi?id=190190
2056
2057         Reviewed by Michael Catanzaro.
2058
2059         * Scripts/run-jsc-stress-tests:
2060         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
2061         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
2062
2063 2018-10-09  Dean Jackson  <dino@apple.com>
2064
2065         Update WHLSL to Metal tester with semantics
2066         https://bugs.webkit.org/show_bug.cgi?id=190416
2067         <rdar://problem/45145139>
2068
2069         Reviewed by Myles Maxfield.
2070
2071         A few small changes to the WHLSL to Metal tools:
2072         - Make it compile by adding some missing JS files :)
2073         - Add semantics to the default shader
2074         - Add FIXMEs to the other shaders
2075         - Create an in-browser test for the WHLSLToMetal codepath
2076         - Fix typos in the semantics checker
2077
2078         * WebGPUShadingLanguageRI/Checker.js:
2079         (Checker.prototype._checkSemantics.checkSemanticTypes):
2080         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
2081         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
2082         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
2083         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
2084         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
2085         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
2086         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
2087
2088 2018-10-09  Jer Noble  <jer.noble@apple.com>
2089
2090         Crash when closing WKWebView during enter fullscreen animation
2091         https://bugs.webkit.org/show_bug.cgi?id=190412
2092
2093         Reviewed by Brian Burg.
2094
2095         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2096         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
2097         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
2098         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
2099         (TestWebKitAPI::TEST):
2100
2101 2018-10-09  Chris Dumez  <cdumez@apple.com>
2102
2103         Anchor target should be ignored on activation when the download attribute is set
2104         https://bugs.webkit.org/show_bug.cgi?id=190408
2105
2106         Reviewed by Geoffrey Garen.
2107
2108         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
2109         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
2110         popup blocking.
2111
2112         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2113         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2114         (WTR::TestRunner::setCanOpenWindows):
2115         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2116         * WebKitTestRunner/TestController.cpp:
2117         (WTR::TestController::createOtherPage):
2118         * WebKitTestRunner/TestController.h:
2119         * WebKitTestRunner/TestInvocation.cpp:
2120         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2121         * WebKitTestRunner/TestInvocation.h:
2122
2123 2018-10-09  Jer Noble  <jer.noble@apple.com>
2124
2125         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
2126         https://bugs.webkit.org/show_bug.cgi?id=190098
2127         <rdar://problem/42822671>
2128
2129         Reviewed by Brian Burg.
2130
2131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2132         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
2133         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
2134         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
2135         (TestWebKitAPI::TEST):
2136
2137 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
2138
2139         [WebAuthN] Import CTAP HID message and packet structure from Chromium
2140         https://bugs.webkit.org/show_bug.cgi?id=189289
2141         <rdar://problem/44120310>
2142
2143         Reviewed by Brent Fulgham.
2144
2145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2146         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
2147         (TestWebKitAPI::TEST):
2148
2149 2018-10-09  Chris Dumez  <cdumez@apple.com>
2150
2151         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
2152         https://bugs.webkit.org/show_bug.cgi?id=190378
2153         <rdar://problem/45059466>
2154
2155         Reviewed by Geoffrey Garen.
2156
2157         Add API test coverage.
2158
2159         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2160
2161 2018-10-09  Jer Noble  <jer.noble@apple.com>
2162
2163         ISOTrackEncryptionBox returns incorrect defaultKeyID
2164         https://bugs.webkit.org/show_bug.cgi?id=190368
2165
2166         Reviewed by Eric Carlson.
2167
2168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2169         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
2170         (TestWebKitAPI::TEST):
2171
2172 2018-10-09  Philippe Normand  <pnormand@igalia.com>
2173
2174         [JHBuild] Update to GStreamer 1.14.4
2175         https://bugs.webkit.org/show_bug.cgi?id=190395
2176
2177         Reviewed by Xabier Rodriguez-Calvar.
2178
2179         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
2180         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
2181         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
2182         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
2183         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
2184
2185 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2186
2187         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
2188         https://bugs.webkit.org/show_bug.cgi?id=190386
2189
2190         Reviewed by Ryosuke Niwa.
2191
2192         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
2193         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
2194         of macOS.
2195
2196         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2197         (TEST):
2198
2199 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2200
2201         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
2202         https://bugs.webkit.org/show_bug.cgi?id=190342
2203         <rdar://problem/44767118>
2204
2205         Reviewed by Tim Horton.
2206
2207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2208         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2209
2210         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
2211         moving the selection around text inside nested list elements.
2212
2213         (TestWebKitAPI::checkParagraphStyles):
2214
2215         Add a new helper to check an NSParagraphStyle against expected results.
2216
2217         (TestWebKitAPI::webViewForTestingFontAttributes):
2218
2219         Allow each test to pass in the name of the test page to load.
2220
2221         (TestWebKitAPI::TEST):
2222         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
2223
2224         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
2225
2226         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
2227
2228         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
2229
2230 2018-10-08  Justin Fan  <justin_fan@apple.com>
2231
2232         WebGPU: Rename old WebGPU prototype to WebMetal
2233         https://bugs.webkit.org/show_bug.cgi?id=190325
2234         <rdar://problem/44990443>
2235
2236         Reviewed by Dean Jackson.
2237
2238         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2239
2240         * DumpRenderTree/mac/DumpRenderTree.mm:
2241         (enableExperimentalFeatures):
2242         (resetWebPreferencesToConsistentValues):
2243         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2244         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
2245         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
2246         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
2247         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
2248         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
2249         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2250         (WTR::InjectedBundle::beginTesting):
2251         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2252         (WTR::TestRunner::setWebMetalEnabled):
2253         (WTR::TestRunner::setWebGPUEnabled): Deleted.
2254         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2255
2256 2018-10-08  Commit Queue  <commit-queue@webkit.org>
2257
2258         Unreviewed, rolling out r236941.
2259         https://bugs.webkit.org/show_bug.cgi?id=190374
2260
2261         Causing API test failures in new test (Requested by jernoble
2262         on #webkit).
2263
2264         Reverted changeset:
2265
2266         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
2267         https://bugs.webkit.org/show_bug.cgi?id=190368
2268         https://trac.webkit.org/changeset/236941
2269
2270 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2271
2272         Make <input type=color> a runtime enabled (on-by-default) feature
2273         https://bugs.webkit.org/show_bug.cgi?id=189162
2274
2275         Reviewed by Wenson Hsieh and Tim Horton.
2276
2277         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2278
2279 2018-10-08  Jer Noble  <jer.noble@apple.com>
2280
2281         ISOTrackEncryptionBox returns incorrect defaultKeyID
2282         https://bugs.webkit.org/show_bug.cgi?id=190368
2283
2284         Reviewed by Eric Carlson.
2285
2286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2287         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
2288         (TestWebKitAPI::TEST):
2289
2290 2018-10-08  Alex Christensen  <achristensen@webkit.org>
2291
2292         Remove WKBundleFileHandleRef
2293         https://bugs.webkit.org/show_bug.cgi?id=190360
2294
2295         Reviewed by Tim Horton.
2296
2297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2298         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
2299         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
2300
2301 2018-10-08  Dan Bernstein  <mitz@apple.com>
2302
2303         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
2304         https://bugs.webkit.org/show_bug.cgi?id=190250
2305
2306         Reviewed by Anders Carlsson.
2307
2308         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2309
2310         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2311           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2312           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2313
2314         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
2315
2316         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
2317           around deprecated methods or categories on deprecated classes.
2318         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
2319         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2320         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
2321         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2322
2323         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2324           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2325           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2326
2327         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2328
2329         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
2330         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
2331           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
2332
2333         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2334           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
2335           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
2336
2337         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
2338           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
2339
2340         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
2341           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2342           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2343           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
2344           many C SPI headers trigger the strict prototypes warning.
2345
2346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2347
2348         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2349         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2350         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2351         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
2352         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2353         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2354         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2355         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2356         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2357         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2358         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2359         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
2360         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
2361         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
2362         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
2363         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
2364         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
2365         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
2366         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
2367         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2368         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2369         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2370         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
2371         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
2372         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2373         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
2374
2375         In all of the above, suppressed the deprecated implementations warning where needed.
2376
2377         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
2378           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
2379           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2380           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
2381           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2382           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
2383           and GCC_NO_COMMON_BLOCKS.
2384
2385         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
2386
2387         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2388         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
2389           the deprecated implementations warning.
2390
2391         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2392         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
2393
2394 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
2395
2396         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
2397         https://bugs.webkit.org/show_bug.cgi?id=189238
2398
2399         Reviewed by Xabier Rodriguez-Calvar.
2400
2401         Modifications on GStreamer, tracked in GStreamer bugzilla:
2402         https://bugzilla.gnome.org/show_bug.cgi?id=797231
2403         https://bugzilla.gnome.org/show_bug.cgi?id=765275
2404
2405         * gstreamer/jhbuild.modules: Add new patches.
2406         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
2407         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
2408         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
2409         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
2410
2411 2018-10-06  Dan Bernstein  <mitz@apple.com>
2412
2413         [Xcode] Never build yasm with ASAN
2414         https://bugs.webkit.org/show_bug.cgi?id=190327
2415
2416         Reviewed by Youenn Fablet.
2417
2418         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
2419           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
2420
2421 2018-10-05  Chris Dumez  <cdumez@apple.com>
2422
2423         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
2424         https://bugs.webkit.org/show_bug.cgi?id=190320
2425         <rdar://problem/45044814>
2426
2427         Reviewed by Geoffrey Garen.
2428
2429         Add API test coverage.
2430
2431         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2432         (TestWebKitAPI::TEST):
2433         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2434         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
2435
2436 2018-10-03  Jer Noble  <jer.noble@apple.com>
2437
2438         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
2439         https://bugs.webkit.org/show_bug.cgi?id=190266
2440
2441         Reviewed by Eric Carlson.
2442
2443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2444         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
2445         (TestWebKitAPI::TEST):
2446
2447 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
2448
2449         Unreviewed, rolling out r236866.
2450
2451         Breaks internal builds.
2452
2453         Reverted changeset:
2454
2455         "Add support for reporting "display composited video frames"
2456         through the VideoPlaybackQuality object."
2457         https://bugs.webkit.org/show_bug.cgi?id=190266
2458         https://trac.webkit.org/changeset/236866
2459
2460 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2461
2462         [WPE][JSC] Use Unified Sources for Platform-specific sources
2463         https://bugs.webkit.org/show_bug.cgi?id=190300
2464
2465         Reviewed by Yusuke Suzuki.
2466
2467         Currently the GTK port already used Unified Sources with the same source files.
2468         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
2469         to the list of libraries to link with.
2470
2471         * TestWebKitAPI/PlatformWPE.cmake:
2472
2473 2018-10-05  Zach Li  <zachli@apple.com>
2474
2475         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
2476         https://bugs.webkit.org/show_bug.cgi?id=190302
2477         <rdar://problem/45031469>
2478
2479         Reviewed by Tim Horton.
2480
2481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2482         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
2483         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
2484         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
2485         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2486         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2487         (TEST):
2488
2489 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2490
2491         [iOS] [WK2] Expose some more editing SPI on WKWebView
2492         https://bugs.webkit.org/show_bug.cgi?id=190232
2493         <rdar://problem/44963368>
2494
2495         Reviewed by Tim Horton.
2496
2497         Adds new API tests to exercise the new SPIs.
2498
2499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2500         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
2501         (-[TestWKWebView querySelectorExists:]):
2502         (TestWebKitAPI::webViewForEditActionTesting):
2503         (TestWebKitAPI::TEST):
2504         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2505         (-[TestWKWebView collapseToStart]): Deleted.
2506         (-[TestWKWebView collapseToEnd]): Deleted.
2507         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
2508         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
2509         * TestWebKitAPI/cocoa/TestWKWebView.h:
2510         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2511         (-[TestWKWebView stylePropertyAtSelectionStart:]):
2512         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
2513         (-[TestWKWebView collapseToStart]):
2514         (-[TestWKWebView collapseToEnd]):
2515
2516         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
2517
2518 2018-10-04  Jer Noble  <jer.noble@apple.com>
2519
2520         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
2521         https://bugs.webkit.org/show_bug.cgi?id=190266
2522
2523         Reviewed by Eric Carlson.
2524
2525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2526         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
2527         (TestWebKitAPI::TEST):
2528
2529 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2530
2531         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
2532         https://bugs.webkit.org/show_bug.cgi?id=190119
2533         <rdar://problem/44767062>
2534
2535         Reviewed by Tim Horton.
2536
2537         Add a new API test that loads a document containing various rich text styles. This test moves the selection
2538         around the document and checks the last set of font attributes received via the new UI delegate hook.
2539
2540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2541         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
2542         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
2543         (-[FontAttributesListener lastFontAttributes]):
2544         (-[TestWKWebView selectElementWithIdentifier:]):
2545         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
2546         (ColorExpectation::ColorExpectation):
2547         (ShadowExpectation::ShadowExpectation):
2548         (checkColor):
2549         (checkShadow):
2550         (checkFont):
2551         (webViewForTestingFontAttributes):
2552         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
2553
2554 2018-10-04  Alan Coon  <alancoon@apple.com>
2555
2556         Unreviewed, add self as contributor.
2557
2558         * Scripts/webkitpy/common/config/contributors.json:
2559
2560 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2561
2562         [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2
2563         https://bugs.webkit.org/show_bug.cgi?id=190289
2564         <rdar://problem/45020806>
2565
2566         Reviewed by Ryosuke Niwa.
2567
2568         Add new API tests to exercise two corner cases when using NSFontOptions ("Font > Styles…") to change font
2569         attributes at the current selection.
2570
2571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2572         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
2573         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2574         (webViewForFontManagerTesting):
2575         (TestWebKitAPI::TEST):
2576         * TestWebKitAPI/mac/TestFontOptions.h: Copied from Source/WebCore/editing/cocoa/FontAttributesCocoa.mm.
2577         * TestWebKitAPI/mac/TestFontOptions.mm: Added.
2578
2579         Introduce TestFontOptions, which wraps the shared NSFontOptions and swizzles `-sharedFontOptions` to return a
2580         global instance of itself. TestFontOptions supports several testing helpers to add or remove font shadows,
2581         foreground colors, and background colors.
2582
2583         (sharedFontOptionsForTesting):
2584         (+[TestFontOptions sharedInstance]):
2585         (-[TestFontOptions initWithFontOptions:]):
2586         (-[TestFontOptions selectedAttributes]):
2587         (-[TestFontOptions fontOptions]):
2588         (-[TestFontOptions shadowWidth]):
2589         (-[TestFontOptions setShadowWidth:]):
2590         (-[TestFontOptions shadowHeight]):
2591         (-[TestFontOptions setShadowHeight:]):
2592         (-[TestFontOptions setShadowBlurRadius:]):
2593         (-[TestFontOptions setHasShadow:]):
2594         (-[TestFontOptions foregroundColor]):
2595         (-[TestFontOptions setForegroundColor:]):
2596         (-[TestFontOptions backgroundColor]):
2597         (-[TestFontOptions setBackgroundColor:]):
2598         (-[TestFontOptions _dispatchFontAttributeChanges]):
2599         (-[TestFontOptions convertAttributes:]):
2600         (-[TestFontOptions setSelectedAttributes:isMultiple:]):
2601         (-[TestFontOptions forwardInvocation:]):
2602
2603 2018-10-04  Jiewen Tan  <jiewen_tan@apple.com>
2604
2605         [WebAuthN] Move time out control from WebProcess to UIProcess
2606         https://bugs.webkit.org/show_bug.cgi?id=189642
2607         <rdar://problem/44476765>
2608
2609         Reviewed by Chris Dumez.
2610
2611         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2612         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2613
2614 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2615
2616         Runtime flag and IDL for MediaRecorder
2617         https://bugs.webkit.org/show_bug.cgi?id=190018
2618
2619         Reviewed by Youenn Fablet and Chris Dumez.
2620
2621         * DumpRenderTree/mac/DumpRenderTree.mm:
2622         (enableExperimentalFeatures):
2623
2624 2018-10-04  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2625
2626         [LayoutTests][Win] Stop wpt server correctly.
2627         https://bugs.webkit.org/show_bug.cgi?id=190248
2628
2629         Reviewed by Fujii Hironori.
2630
2631         Use signal.CTRL_C_EVENT instead of signal.SIGINT for Windows.
2632         Also refactoring the detection of Windows and cygwin environment check.
2633
2634         * Scripts/webkitpy/common/system/executive.py:
2635         (Executive.__init__): Check environment once.
2636         (Executive._should_close_fds):
2637         (Executive.kill_process):
2638         (Executive.check_running_pid):
2639         (Executive.running_pids):
2640         (Executive.interrupt): Use signal.CTRL_C_EVENT for Windows.
2641         (Executive.kill_all):
2642         (Executive._child_process_encoding):
2643         (Executive._should_encode_child_process_arguments):
2644         (Executive.popen):
2645         (Executive.run_in_parallel):
2646
2647 2018-10-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2648
2649         Convert tests to use navigation client
2650         https://bugs.webkit.org/show_bug.cgi?id=190153
2651
2652         Reviewed by Alex Christensen.
2653
2654         Convert these tests from PagePolicyClient and PageLoaderClient to PageNavigationClient.
2655
2656         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2657         (TestWebKitAPI::decidePolicyForNavigationAction):
2658         (TestWebKitAPI::setPagePolicyClient):
2659         * TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:
2660         (TestWebKitAPI::didCommitNavigationCallback):
2661         (TestWebKitAPI::TEST):
2662         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
2663
2664 2018-10-03  Dan Bernstein  <mitz@apple.com>
2665
2666         [Cocoa] Let clients specify an NSFileWrapper subclassed to be used for _WKAttachment
2667         https://bugs.webkit.org/show_bug.cgi?id=190270
2668
2669         Reviewed by Wenson Hsieh.
2670
2671         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2672         (TestWebKitAPI::TEST):
2673
2674 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2675
2676         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2677         https://bugs.webkit.org/show_bug.cgi?id=190238
2678
2679         Reviewed by Antti Koivisto.
2680
2681         * DumpRenderTree/TestOptions.h:
2682         * DumpRenderTree/mac/DumpRenderTree.mm:
2683         (resetWebPreferencesToConsistentValues):
2684
2685 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2686
2687         [WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
2688         https://bugs.webkit.org/show_bug.cgi?id=179787
2689         <rdar://problem/35593389>
2690
2691         Reviewed by Tim Horton.
2692
2693         Add a test to verify that NSFontManager's selected font is updated when applying italic and bold styles using
2694         menu items.
2695
2696         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2697         (webViewForFontManagerTesting):
2698         (menuItemCellForFontAction):
2699         (TestWebKitAPI::TEST):
2700
2701 2018-10-02  Chris Dumez  <cdumez@apple.com>
2702
2703         REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing
2704         https://bugs.webkit.org/show_bug.cgi?id=190176
2705         <rdar://problem/44925871>
2706
2707         Reviewed by Alex Christensen.
2708
2709         Use a URL that is truly recognized as invalid by WebCore's URL parser.
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:
2712         (TEST):
2713
2714 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2715
2716         Remove ParsedURLString
2717         https://bugs.webkit.org/show_bug.cgi?id=190154
2718
2719         Reviewed by Chris Dumez.
2720
2721         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2722         (TestWebKitAPI::TEST_F):
2723         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2724         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2725         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2726         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2727         (TestWebKitAPI::TEST):
2728
2729 2018-10-02  Daniel Bates  <dabates@apple.com>
2730
2731         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
2732         (https://bugs.webkit.org/show_bug.cgi?id=190017)
2733
2734         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
2735             WKWebViewAutofillTests.AutofillRequiresInputSession
2736             DragAndDropTests.ExternalSourceJPEGOnly
2737             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
2738
2739         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
2740         we will look to swizzle this method for all test by default.
2741
2742         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2743         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
2744         (TestWebKitAPI::TEST):
2745         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2746         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
2747         (TestWebKitAPI::TEST):
2748         * TestWebKitAPI/ios/UIKitSPI.h:
2749
2750 2018-10-02  Dawei Fenton  <realdawei@apple.com>
2751
2752         Unreviewed, rolling out r236751.
2753
2754         broke the iOS Build
2755
2756         Reverted changeset:
2757
2758         "Fix iOS TestWebKitAPI failures following
2759         <https://trac.webkit.org/changeset/236619>"
2760         https://bugs.webkit.org/show_bug.cgi?id=190017
2761         https://trac.webkit.org/changeset/236751
2762
2763 2018-10-02  Daniel Bates  <dabates@apple.com>
2764
2765         Fix iOS TestWebKitAPI failures following <https://trac.webkit.org/changeset/236619>
2766         (https://bugs.webkit.org/show_bug.cgi?id=190017)
2767
2768         For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
2769             WKWebViewAutofillTests.AutofillRequiresInputSession
2770             DragAndDropTests.ExternalSourceJPEGOnly
2771             DragAndDropTests.ExternalSourceUTF8PlainTextOnly
2772
2773         so that the presence of a hardware keyboad does not effect their results. In <https://bugs.webkit.org/show_bug.cgi?id=190211>
2774         we will look to swizzle this method for all test by default.
2775
2776         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2777         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
2778         (TestWebKitAPI::TEST):
2779         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2780         (TestWebKitAPI::overrideIsInHardwareKeyboardMode):
2781         (TestWebKitAPI::TEST):
2782         * TestWebKitAPI/ios/UIKitSPI.h:
2783
2784 2018-10-01  Dean Jackson  <dino@apple.com>
2785
2786         Remove CSS Animation Triggers
2787         https://bugs.webkit.org/show_bug.cgi?id=190175
2788         <rdar://problem/44925626>
2789
2790         Reviewed by Simon Fraser.
2791
2792         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2793
2794 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
2795
2796         [Flatpak] Use our own check of flatpak repos
2797         https://bugs.webkit.org/show_bug.cgi?id=190194
2798
2799         Allowing us to not mess up with user installation
2800         and "--assumeyes" everywhere.
2801
2802         Reviewed by Michael Catanzaro.
2803
2804         * flatpak/flatpakutils.py:
2805         (FlatpakPackage.__init__):
2806         (FlatpakPackage.install):
2807         (FlatpakPackage.update):
2808         (WebkitFlatpak.load_from_args):
2809         (WebkitFlatpak.__init__):
2810         (WebkitFlatpak.clean_args):
2811
2812 2018-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2813
2814         [macOS] Implement a way for the UI process to request typing attributes at the current selection
2815         https://bugs.webkit.org/show_bug.cgi?id=189983
2816         <rdar://problem/44648705>
2817
2818         Reviewed by Ryosuke Niwa.
2819
2820         Adds new FontManagerTests that exercise -typingAttributesWithCompletionHandler:. See below for more detail.
2821
2822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2823         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
2824         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2825
2826         Add a new test that exercises font attribute modification via inspector bar. Also, add a new test that checks
2827         typing attributes when using subscript/superscript/unscript. Lastly, augment an existing NSFontPanel test to
2828         additionally check that shadowed text and strike-through are reflected in typing attributes.
2829
2830         (-[FontManagerTestWKWebView inspectorBarItemIdentifiers]):
2831         (-[TestWKWebView typingAttributes]):
2832
2833         Add a synchronous wrapper around `-typingAttributesWithCompletionHandler:` by spinning the runloop.
2834
2835         (-[TestWKWebView collapseToStart]):
2836         (webViewForFontManagerTesting):
2837         (TestWebKitAPI::TEST):
2838         * TestWebKitAPI/cocoa/TestWKWebView.h:
2839         * TestWebKitAPI/mac/TestInspectorBar.h: Copied from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h.
2840         * TestWebKitAPI/mac/TestInspectorBar.mm: Added.
2841
2842         Introduce subclasses of `__InspectorBarItemController` and `NSInspectorBar` for testing inspector bar interaction.
2843
2844         (-[TestInspectorBarItemController initWithInspectorBar:]):
2845         (-[TestInspectorBarItemController inspectorBar]):
2846         (-[TestInspectorBarItemController updateSelectedAttributes]):
2847         (-[TestInspectorBar initWithWebView:]):
2848         (+[TestInspectorBar standardItemControllerClass]):
2849         (+[TestInspectorBar standardTextItemIdentifiers]):
2850         (-[TestInspectorBar _setStyleControlSelected:atIndex:]):
2851         (-[TestInspectorBar chooseFontSize:]):
2852         (-[TestInspectorBar chooseFontFamily:]):
2853         (-[TestInspectorBar _chooseColor:inColorWell:]):
2854         (-[TestInspectorBar chooseForegroundColor:]):
2855         (-[TestInspectorBar chooseBackgroundColor:]):
2856         (-[TestInspectorBar formatBold:]):
2857         (-[TestInspectorBar formatItalic:]):
2858         (-[TestInspectorBar formatUnderline:]):
2859
2860         Add helper methods to TestInspectorBar to simulate interacting with various controls (e.g. color wells and font
2861         styling controls).
2862
2863         (-[TestInspectorBar itemController]):
2864         (-[TestInspectorBar setItemController:]):
2865
2866 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
2867
2868         [Flatpak] Implement icecream and ccache support
2869         https://bugs.webkit.org/show_bug.cgi?id=190146
2870
2871         Reviewed by Alejandro G. Castro.
2872
2873         * flatpak/flatpakutils.py:
2874         (WebkitFlatpak.load_from_args):
2875         (WebkitFlatpak.__init__):
2876         (WebkitFlatpak.clean_args):
2877         (WebkitFlatpak.run_in_sandbox):
2878         (WebkitFlatpak.save_config):
2879         (WebkitFlatpak):
2880         (WebkitFlatpak.setup_ccache):
2881         (WebkitFlatpak.setup_icecc):
2882         (WebkitFlatpak.setup_dev_env):
2883         * flatpak/org.webkit.WebKit.yaml:
2884
2885 2018-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2886
2887         Unreviewed, fix missing return value in TestController::keyExistsInKeychain
2888
2889         * WebKitTestRunner/TestController.cpp:
2890         (WTR::TestController::keyExistsInKeychain):
2891
2892 2018-10-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2893
2894         [WinCairo] Enable WPT tests environment.
2895         https://bugs.webkit.org/show_bug.cgi?id=190128
2896
2897         Reviewed by Youenn Fablet.
2898
2899         Escaping backslash of the path not to confuse the JSON parser.
2900
2901         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2902         (WebPlatformTestServer._prepare_config):
2903
2904 2018-10-01  Ross Kirsling  <ross.kirsling@sony.com>
2905
2906         [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
2907         https://bugs.webkit.org/show_bug.cgi?id=190150
2908
2909         Reviewed by Fujii Hironori.
2910
2911         * DumpRenderTree/win/DumpRenderTree.cpp:
2912         (setWebPreferencesForTestOptions):
2913         DRT has been recognizing this field, but not propagating its value to WebPreferences.
2914
2915 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2916
2917         Unreviewed, rolling out r236551.
2918
2919         Fails URL validating too aggressively
2920
2921         Reverted changeset:
2922
2923         "URLWithUserTypedString should return nil for URLs deemed to
2924         be invalid by WebCore::URL"
2925         https://bugs.webkit.org/show_bug.cgi?id=189979
2926         https://trac.webkit.org/changeset/236551
2927
2928 2018-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2929
2930         [iOS] Add SPI to customize the input accessory view when focusing an element
2931         https://bugs.webkit.org/show_bug.cgi?id=190152
2932         <rdar://problem/42754975>
2933
2934         Reviewed by Dan Bernstein.
2935
2936         Add an API test to verify that setting a custom input accessory view and custom input view on the form input
2937         session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
2938         `-inputAccessoryView`.
2939
2940         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2941         (webViewWithAutofocusedInput):
2942         (TestWebKitAPI::TEST):
2943         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2944         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2945         (-[TestInputDelegate setWillStartInputSessionHandler:]):
2946         (-[TestInputDelegate willStartInputSessionHandler]):
2947         (-[TestInputDelegate _webView:willStartInputSession:]):
2948
2949 2018-10-01  Sihui Liu  <sihui_liu@apple.com>
2950
2951         Remove StorageProcess
2952         https://bugs.webkit.org/show_bug.cgi?id=189975
2953
2954         Reviewed by Geoffrey Garen.
2955
2956         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2957         (TEST):
2958         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2959         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
2960         (TEST):
2961         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2962         (TEST):
2963         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2964         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2965         (WTR::TestRunner::terminateStorageProcess): Deleted.
2966         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2967         * WebKitTestRunner/TestController.cpp:
2968         (WTR::TestController::generatePageConfiguration):
2969         (WTR::TestController::databaseProcessName): Deleted.
2970         (WTR::TestController::databaseProcessDidCrash): Deleted.
2971         (WTR::TestController::terminateStorageProcess): Deleted.
2972         * WebKitTestRunner/TestController.h:
2973         * WebKitTestRunner/TestInvocation.cpp:
2974         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2975
2976 2018-10-01  Jiewen Tan  <jiewen_tan@apple.com>
2977
2978         [WebAuthN] Import a JS CBOR coder
2979         https://bugs.webkit.org/show_bug.cgi?id=189877
2980         <rdar://problem/44701124>
2981
2982         Reviewed by Chris Dumez.
2983
2984         Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
2985         only if acceptAttestation is true.
2986
2987         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2988         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2989
2990 2018-10-01  Chris Dumez  <cdumez@apple.com>
2991
2992         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
2993         https://bugs.webkit.org/show_bug.cgi?id=190052
2994
2995         Reviewed by Ryosuke Niwa.
2996
2997         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
2998         to log those events. It also uses console.log() before sending those events to indicate what the test is about
2999         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
3000         so that it can log the message.
3001         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
3002         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
3003         handler to be transformed into synchronous IPC.
3004         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
3005         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
3006         messages may end up being out of order, leading to flakiness.
3007
3008         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
3009         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
3010         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
3011
3012         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3013         (WTR::InjectedBundle::outputText):
3014
3015 2018-10-01  Daniel Bates  <dabates@apple.com>
3016
3017         [iOS] Special keys are misidentified in DOM keyboard events
3018         https://bugs.webkit.org/show_bug.cgi?id=189974
3019
3020         Reviewed by Wenson Hsieh.
3021
3022         Add support for testing keys Forward Delete and Num Lock / Clear.
3023
3024         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3025         (hidUsageCodeForCharacter):
3026
3027 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3028
3029         URL should not use TextEncoding internally
3030         https://bugs.webkit.org/show_bug.cgi?id=190111
3031
3032         Reviewed by Andy Estes.
3033
3034         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3035         (TestWebKitAPI::testUserPass):
3036         (TestWebKitAPI::TEST_F):
3037
3038 2018-10-01  Daniel Bates  <dabates@apple.com>
3039
3040         LLDB tests may use wrong configuration of lldbWebKitTester
3041         https://bugs.webkit.org/show_bug.cgi?id=189011
3042
3043         Reviewed by Dean Jackson.
3044
3045         Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
3046         Additionally, add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
3047
3048         Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
3049         script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
3050         So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
3051         to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
3052         called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
3053         test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
3054         the Python unittest module, the Python multiprocessing module, and the general principle of unit
3055         tests - to test code in isolation). The unit tests make use of the value of this environment
3056         variable to launch lldbWebKitTester binary.
3057
3058         * Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error
3059         out if this script is invoked for a non-Mac platform.
3060         * Scripts/webkitpy/test/main.py:
3061         (Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
3062         LLDB_WEBKIT_TESTER_EXECUTABLE.
3063         (_build_lldb_webkit_tester): Deleted.
3064         * lldb/dump_class_layout_unittest.py:
3065         (TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
3066         this is the only call site that needs the Host object now.
3067         (TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
3068         the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.
3069         * lldb/lldbWebKitTester/main.cpp:
3070         (testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
3071         * lldb/lldb_webkit_unittest.py:
3072         (LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
3073         variable LLDB_WEBKIT_TESTER_EXECUTABLE.
3074         (TestSummaryProviders):
3075         (TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
3076         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
3077         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
3078         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
3079         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
3080         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
3081         Add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
3082
3083 2018-10-01  Olivier Blin  <olivier.blin@softathome.com>
3084
3085         [WPE] Update install-dependencies
3086         https://bugs.webkit.org/show_bug.cgi?id=190127
3087
3088         Reviewed by Michael Catanzaro.
3089
3090         * wpe/install-dependencies:
3091         libxrandr-dev is needed for gstreamer-vaapi in jhbuild
3092         It is used by gstvaapidisplay_x11.c.
3093         Add it only for Apt, already ok for Pacman and DNF.
3094
3095         Install libevent-dev for WebRTC (like GTK)
3096
3097         Install libasound2-dev for WebRTC.
3098         Add it only for Apt, already ok for Pacam and DNF.
3099
3100         Install libgbm-dev for HeadlessViewBackend, which uses gbm.h
3101
3102 2018-10-01  Thibault Saunier  <tsaunier@igalia.com>
3103
3104         [Flatpak] Add libunwind in the sandbox
3105         https://bugs.webkit.org/show_bug.cgi?id=190123
3106
3107         Allowing us to get proper traces in GStreamer trace grabing
3108         debug functions.
3109
3110         Reviewed by Philippe Normand.
3111
3112         * flatpak/org.webkit.WebKit.yaml:
3113
3114 2018-09-29  Commit Queue  <commit-queue@webkit.org>
3115
3116         Unreviewed, rolling out r236631.
3117         https://bugs.webkit.org/show_bug.cgi?id=190112
3118
3119         Caused various eventSender tests, including fast/css/pseudo-
3120         active-style-sharing*, to fail (Requested by smfr on #webkit).
3121
3122         Reverted changeset:
3123
3124         "Regression(r236512): http/tests/navigation/keyboard-events-
3125         during-provisional-navigation.html is flaky"
3126         https://bugs.webkit.org/show_bug.cgi?id=190052
3127         https://trac.webkit.org/changeset/236631
3128
3129 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3130
3131         [WHLSL] Fix build after r236635
3132         https://bugs.webkit.org/show_bug.cgi?id=189210
3133
3134         Unreviewed.
3135
3136         * WebGPUShadingLanguageRI/Intrinsics.js:
3137         (Intrinsics.):
3138         * WebGPUShadingLanguageRI/Test.js:
3139         (tests.atomicsNull):
3140         (tests.numThreads):
3141         (tests.textureDimensionsNull):
3142
3143 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3144
3145         [WHLSL] Allow uniform buffers to be used in the interpreter
3146         https://bugs.webkit.org/show_bug.cgi?id=189210
3147
3148         Reviewed by Filip Pizlo.
3149
3150         Every lvalue is associated with an address space, and the propagation of these address spaces
3151         matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
3152         of this, so this patch just goes the last few yards. It also updates the standard library to
3153         allow for writing into all writable address spaces for out-params.
3154
3155         * WebGPUShadingLanguageRI/Checker.js:
3156         (Checker.prototype.visitAssignment):
3157         (Checker.prototype._finishVisitingPropertyAccess):
3158         * WebGPUShadingLanguageRI/Intrinsics.js:
3159         (Intrinsics.):
3160         (Intrinsics.checkFalse):
3161         (Intrinsics):
3162         * WebGPUShadingLanguageRI/StandardLibrary.js:
3163         (let.standardLibrary):
3164         * WebGPUShadingLanguageRI/Test.js:
3165         (tests.threadArrayRefLoad):
3166         (tests.threadArrayRefLoadIntLiteral):
3167         (tests.deviceArrayRefLoad):
3168         (tests.threadArrayRefStore):
3169         (tests.deviceArrayRefStore):
3170         (tests.deviceArrayRefStoreIntLiteral):
3171         (tests.threadPointerLoad):
3172         (tests.threadPointerStore):
3173         (tests.devicePointerLoad):
3174         (tests.devicePointerStore):
3175         (tests.arrayLoad):
3176         (tests.constantAddressSpace):
3177         (tests.standardLibraryDevicePointers):
3178         (tests.threadArrayLoad): Deleted.
3179         (tests.threadArrayLoadIntLiteral): Deleted.
3180         (tests.deviceArrayLoad): Deleted.
3181         (tests.threadArrayStore): Deleted.
3182         (tests.deviceArrayStore): Deleted.
3183         (tests.deviceArrayStoreIntLiteral): Deleted.
3184
3185 2018-09-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3186
3187         No DOM API to instantiate an attachment for an img element
3188         https://bugs.webkit.org/show_bug.cgi?id=189934
3189         <rdar://problem/44743222>
3190
3191         Reviewed by Ryosuke Niwa.
3192
3193         Adds 3 new API tests in WKAttachmentTests:
3194
3195         `AddAttachmentToConnectedImageElement` verifies that an image element that's already in the document can gain an
3196         attachment element via `HTMLAttachmentElement.getAttachmentIdentifier`.
3197
3198         `ChangeFileWrapperForPastedImage` verifies that an image that has been pasted produces a _WKAttachment in the UI
3199         process, and changing the file wrapper of that _WKAttachment changes the pasted image.
3200
3201         `ConnectImageWithAttachmentToDocument` verifies that script can create an image element, ensure that it has an
3202         attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
3203         then result in an image element with the contents of the _WKAttachment's file wrapper.
3204
3205         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3206         (-[TestWKWebView imageElementSize]):
3207         (-[TestWKWebView waitForImageElementSizeToBecome:]):
3208         (TestWebKitAPI::TEST):
3209         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.
3210
3211 2018-09-28  Chris Dumez  <cdumez@apple.com>
3212
3213         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
3214         https://bugs.webkit.org/show_bug.cgi?id=190052
3215
3216         Reviewed by Ryosuke Niwa.
3217
3218         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
3219         to log those events. It also uses console.log() before sending those events to indicate what the test is about
3220         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
3221         so that it can log the message.
3222         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
3223         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
3224         handler to be transformed into synchronous IPC.
3225         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
3226         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
3227         messages may end up being out of order, leading to flakiness.
3228
3229         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicating
3230         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
3231         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
3232
3233         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3234         (WTR::InjectedBundle::outputText):
3235
3236 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
3237
3238         [WHLSL] Pointers should have automatically-generated equality checks
3239         https://bugs.webkit.org/show_bug.cgi?id=189986
3240
3241         Reviewed by Filip Pizlo.
3242
3243         C allows for pointer equality, and we need it so people can do null checks.
3244         This is generated the same way all our other NativeFuncs are generated - by Checker
3245         creating NativeFuncs inside CallExpression.resolve().
3246
3247         This patch also does some general cleanup.
3248
3249         * WebGPUShadingLanguageRI/All.js: Everything the late checker does is no longer necessary.
3250         The last thing it was doing was making sure that only primitive types are in resources, but
3251         it's totally reasonable to put structs and arrays in resources, so I removed this pass. We
3252         still have to add a check to make sure resources can't live within resources, but I expect
3253         that will be done in the same place that semantics are checked.
3254         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js:
3255         (allocateAtEntryPoints.updateFunction.UpdateFunctions.prototype._addVariableDeclaration):
3256         Name the global struct for debugging purposes.
3257         * WebGPUShadingLanguageRI/CallExpression.js: 
3258         (CallExpression.prototype._resolveByInstantiation): Cleanup
3259         (CallExpression.prototype._resolveWithOperatorAnderIndexer): Ditto
3260         (CallExpression.prototype._resolveWithOperatorLength): Ditto
3261         (CallExpression.prototype._resolveWithReferenceComparator): Add support to automatically
3262         generate pointer equality NativeFuncs.
3263         * WebGPUShadingLanguageRI/EPtr.js: Implement pointer equality in the interpreter.
3264         * WebGPUShadingLanguageRI/LateChecker.js: Removed.
3265         * WebGPUShadingLanguageRI/LayoutBuffers.js: Renamed from Tools/WebGPUShadingLanguageRI/LateCheckAndLayoutBuffers.js.
3266         (layoutBuffers):
3267         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
3268         * WebGPUShadingLanguageRI/NativeFunc.js:
3269         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js:
3270         (OperatorArrayRefLength.prototype.instantiateImplementation):
3271         (OperatorArrayRefLength):
3272         * WebGPUShadingLanguageRI/Prepare.js:
3273         (let.prepare):
3274         * WebGPUShadingLanguageRI/SPIRV.html:
3275         * WebGPUShadingLanguageRI/Test.html:
3276         * WebGPUShadingLanguageRI/Test.js:
3277         (tests.ternaryExpression):
3278         (tests.break): Speed up testing time
3279         (tests.doWhile): Ditto
3280         (tests.forLoop): Ditto
3281         (tests.atomics): Ditto
3282         (tests.atomicsNull): Ditto
3283         (tests.pointerEquality): Test pointer equality
3284         (tests.standardLibraryDevicePointers):
3285         (tests.devicePtrPtr): Deleted.
3286         (tests.threadgroupPtrPtr): Deleted.
3287         (tests.constantPtrPtr): Deleted.
3288         * WebGPUShadingLanguageRI/index.html:
3289
3290 2018-09-28  Jiewen Tan  <jiewen_tan@apple.com>
3291
3292         [WebAuthN] Polish WebAuthN auto-test environment
3293         https://bugs.webkit.org/show_bug.cgi?id=189283
3294         <rdar://problem/44117828>
3295
3296         Reviewed by Chris Dumez.
3297
3298         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3299         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3300
3301 2018-09-28  Chris Dumez  <cdumez@apple.com>
3302
3303         Drop support for cross-origin-window-policy header
3304         https://bugs.webkit.org/show_bug.cgi?id=190081
3305
3306         Reviewed by Ryosuke Niwa.
3307
3308         190081_DropCrossOriginWindowPolicy
3309
3310         * DumpRenderTree/mac/DumpRenderTree.mm:
3311         (enableExperimentalFeatures):
3312         * DumpRenderTree/win/DumpRenderTree.cpp:
3313         (enableExperimentalFeatures):
3314         * WebKitTestRunner/TestController.cpp:
3315         (WTR::TestController::resetPreferencesToConsistentValues):
3316
3317 2018-09-28  Koby Boyango  <koby.b@mce.systems>
3318
3319         [WTF] Add ExternalStringImpl, a StringImpl for user controlled buffers
3320         https://bugs.webkit.org/show_bug.cgi?id=189991
3321
3322         Reviewed by Yusuke Suzuki.
3323
3324         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3325
3326 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
3327
3328         Update flakiness dashboard configuration for Mojave queues
3329         https://bugs.webkit.org/show_bug.cgi?id=190068
3330
3331         Reviewed by Alexey Proskuryakov.
3332
3333         * TestResultServer/static-dashboards/builders.jsonp:
3334
3335 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
3336
3337         Bring up queues for Mojave
3338         https://bugs.webkit.org/show_bug.cgi?id=189935
3339
3340         Unreviewed infrastructure fix.
3341
3342         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove trigger, update bot assignment.
3343
3344 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
3345
3346         Bring up queues for Mojave
3347         https://bugs.webkit.org/show_bug.cgi?id=189935
3348
3349         Reviewed by Alexey Proskuryakov.
3350
3351         * BuildSlaveSupport/build.webkit.org-config/config.json:
3352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3353         (WebKitBuildbot):
3354         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3355
3356 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
3357
3358         Increase the timeout for iOS Simulator data migration
3359         https://bugs.webkit.org/show_bug.cgi?id=190059
3360
3361         Reviewed by Aakash Jain.
3362
3363         3 minutes isn't always enough time for the data migrator to complete
3364         when booting up multiple iOS Simulators. Change the timeout to 10 minutes.
3365
3366         * Scripts/webkitpy/xcode/simulated_device.py:
3367         (SimulatedDeviceManager): Create a constant for the default timeout.
3368         (SimulatedDeviceManager.initialize_devices): Use new constant.
3369         (SimulatedDeviceManager.swap): Ditto.
3370         (SimulatedDeviceManager.wait_until_data_migration_is_done): Ditto.
3371
3372 2018-09-27  Alex Christensen  <achristensen@webkit.org>
3373
3374         URLParser should use TextEncoding through an abstract class
3375         https://bugs.webkit.org/show_bug.cgi?id=190027
3376
3377         Reviewed by Andy Estes.
3378
3379         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3380         (TestWebKitAPI::checkURL):
3381         (TestWebKitAPI::TEST_F):
3382
3383 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
3384
3385         iOS Simulator bots should pass '--dedicated-simulators' to run-webkit-tests
3386         https://bugs.webkit.org/show_bug.cgi?id=190042
3387
3388         Reviewed by Aakash Jain.
3389
3390         To make iOS Simulator bots resilient to issues that can arise from reusing
3391         existing simulators, ensure that dedicated simulators are created for each test run.
3392
3393         * Scripts/webkitpy/common/config/ports.py:
3394         (IOSSimulatorWK2Port.run_webkit_tests_command):
3395
3396 2018-09-27  Alex Christensen  <achristensen@webkit.org>
3397
3398         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
3399         https://bugs.webkit.org/show_bug.cgi?id=189979
3400
3401         Reviewed by Youenn Fablet.
3402
3403         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3404         (TestWebKitAPI::originalDataAsString):
3405         (TestWebKitAPI::TEST):
3406
3407 2018-09-27  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3408
3409         [Win][WebKit] Implement authentication dialog on MiniBrowser.
3410         https://bugs.webkit.org/show_bug.cgi?id=189846
3411
3412         Reviewed by Fujii Hironori.
3413
3414         It was implemented for WebKitLegacy, but not for WebKit.
3415         Also added text field to display Realm information.
3416
3417         * MiniBrowser/win/Common.cpp:
3418         (authDialogProc):
3419         (askCredential):
3420         (displayAuthDialog): Deleted.
3421         * MiniBrowser/win/Common.h:
3422         * MiniBrowser/win/MiniBrowserLib.rc:
3423         * MiniBrowser/win/MiniBrowserLibResource.h:
3424         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3425         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3426         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3427         (createString):
3428         (createUTF8String):
3429         (createWKString):
3430         (createWKURL):
3431         (WebKitBrowserWindow::WebKitBrowserWindow):
3432         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3433         (toNullTerminatedUTF8): Deleted.
3434         * MiniBrowser/win/WebKitBrowserWindow.h:
3435
3436 2018-09-27  Youenn Fablet  <youenn@apple.com>
3437
3438         Enable getUserMedia in mini browser
3439         https://bugs.webkit.org/show_bug.cgi?id=190012
3440
3441         Reviewed by Eric Carlson.
3442
3443         Enable MediaDevices and mock capture devices.
3444         Grant mock devices access to any getUserMedia call.
3445         Covered by manual testing.
3446
3447         * MiniBrowser/mac/AppDelegate.m:
3448         (defaultConfiguration):
3449         * MiniBrowser/mac/WK2BrowserWindowController.m:
3450         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3451         (-[WK2BrowserWindowController _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3452
3453 2018-09-27  Antoine Quint  <graouts@apple.com>
3454
3455         [Web Animations] Turn Web Animations with CSS integration on
3456         https://bugs.webkit.org/show_bug.cgi?id=184819
3457         <rdar://problem/39597337>
3458
3459         Reviewed by Dean Jackson.
3460
3461         * DumpRenderTree/TestOptions.h:
3462
3463 2018-09-26  Alex Christensen  <achristensen@webkit.org>
3464
3465         Unreviewed, rolling out r236524.
3466
3467         Broke API tests
3468
3469         Reverted changeset:
3470
3471         "URLWithUserTypedString should return nil for URLs deemed to
3472         be invalid by WebCore::URL"
3473         https://bugs.webkit.org/show_bug.cgi?id=189979
3474         https://trac.webkit.org/changeset/236524
3475
3476 2018-09-26  James Savage  <james.savage@apple.com>
3477
3478         Allow override of viewport configuration.
3479         https://bugs.webkit.org/show_bug.cgi?id=188772.
3480         <rdar://problem/43538892>.
3481
3482         Reviewed by Simon Fraser.
3483
3484         * WebKitTestRunner/TestController.cpp:
3485         (WTR::updateTestOptionsFromTestHeader): Parse new test option key from comments.
3486         * WebKitTestRunner/TestOptions.h:
3487         * WebKitTestRunner/ios/TestControllerIOS.mm:
3488         (WTR::TestController::platformConfigureViewForTest): Handle new test option by
3489         modifying the web view's preferences accordingly.
3490
3491 2018-09-26  Alex Christensen  <achristensen@webkit.org>
3492
3493         URLs with mismatched surrogate pairs in the host should fail to parse
3494         https://bugs.webkit.org/show_bug.cgi?id=190005
3495
3496         Reviewed by Chris Dumez.
3497
3498         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3499         (TestWebKitAPI::TEST_F):
3500
3501 2018-09-26  Alex Christensen  <achristensen@webkit.org>
3502
3503         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
3504         https://bugs.webkit.org/show_bug.cgi?id=189979
3505         <rdar://problem/44119696>
3506
3507         Reviewed by Chris Dumez.
3508
3509         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3510         (TestWebKitAPI::TEST):
3511
3512 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3513
3514         Selection should work across shadow boundary when initiated by a mouse drag
3515         https://bugs.webkit.org/show_bug.cgi?id=151380
3516         <rdar://problem/24363872>
3517
3518         Reviewed by Wenson Hsieh.
3519
3520         Added the support for internal:selectionAcrossShadowBoundariesEnabled test option.
3521
3522         * DumpRenderTree/TestOptions.cpp:
3523         (TestOptions::TestOptions):
3524         * DumpRenderTree/TestOptions.h:
3525         * DumpRenderTree/mac/DumpRenderTree.mm:
3526         (resetWebPreferencesToConsistentValues):
3527         (setWebPreferencesForTestOptions):
3528
3529 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3530
3531         MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
3532         https://bugs.webkit.org/show_bug.cgi?id=189989
3533
3534         Reviewed by Simon Fraser.
3535
3536         When the preference isn't found in user defaults, use the default value of each feature's enabledness.
3537
3538         * MiniBrowser/mac/AppDelegate.m:
3539         (defaultConfiguration):
3540
3541 2018-09-26  Philippe Normand  <pnormand@igalia.com>
3542
3543         [Flatpak] Bump to apr 1.6.5
3544
3545         Version 1.6.3 is no longer available on Apache's website.
3546
3547         Rubber-stamped by Michael Catanzaro.
3548
3549         * flatpak/org.webkit.WebKit.yaml:
3550
3551 2018-09-25  Jiewen Tan  <jiewen_tan@apple.com>
3552
3553         [WebAuthN] Make AuthenticatorManager
3554         https://bugs.webkit.org/show_bug.cgi?id=189279
3555         <rdar://problem/44116792>
3556
3557         Reviewed by Chris Dumez.
3558
3559         Besides the functionality to set the WebAuthenticationMockConfiguration. Three operations are
3560         added to manipulate Keychain: addTestKeyToKeychain, cleanUpKeychain and keyExistedInKeychain.
3561
3562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3563         * TestWebKitAPI/Tests/ios/LocalAuthenticator.mm: Removed.
3564         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3565         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3566         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3567         (WTR::TestRunner::addTestKeyToKeychain):
3568         (WTR::TestRunner::cleanUpKeychain):
3569         (WTR::TestRunner::isKeyExisted):
3570         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3571         * WebKitTestRunner/TestController.cpp:
3572         (WTR::TestController::addTestKeyToKeychain):
3573         (WTR::TestController::cleanUpKeychain):
3574         (WTR::TestController::isKeyExisted):
3575         (WTR::TestController::setWebAuthenticationMockConfiguration):
3576         * WebKitTestRunner/TestController.h:
3577         * WebKitTestRunner/TestInvocation.cpp:
3578         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3579         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3580         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3581         (WTR::TestController::addTestKeyToKeychain):
3582         (WTR::TestController::cleanUpKeychain):
3583         (WTR::TestController::keyExistedInKeychain):
3584
3585 2018-09-25  Sihui Liu  <sihui_liu@apple.com>
3586
3587         Move Service Worker Management from Storage Process to Network Process
3588         https://bugs.webkit.org/show_bug.cgi?id=189422
3589
3590         Reviewed by Youenn Fablet.
3591
3592         Change a check in ServiceWorkers.HasServiceWorkerRegistrationBit as storage process is not
3593         launched during service worker operations now.
3594
3595         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3596
3597 2018-09-25  Eric Carlson  <eric.carlson@apple.com>
3598
3599         [MediaStream] Update constraints supported by getDisplayMedia
3600         https://bugs.webkit.org/show_bug.cgi?id=189930
3601         <rdar://problem/44740305>
3602
3603         Unreviewed, fix test broken by r236465.
3604
3605         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
3606         (TestWebKitAPI::TEST_F):
3607
3608 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
3609
3610         [WHSL] Implement semantics
3611         https://bugs.webkit.org/show_bug.cgi?id=189134
3612
3613         Reviewed by Filip Pizlo.
3614
3615         This patch adds parsing support and adds the checks required to support HLSL-style semantics.
3616
3617         There are 3 places where semantics are allowed:
3618
3619         1. In a field in a struct. E.g.
3620
3621         struct R {
3622             float4 position : SV_Position;
3623         }
3624         vertex R foo() {
3625             ...
3626         }
3627
3628         2. In a parameter of a function. If the function is not an entry point, the semantic is ignored.
3629
3630         compute void foo(device float[] data : buffer(u0)) {
3631             ...
3632         }
3633
3634         3. On a function. This is so you don't have to create structs for the return types of simple vertex shaders.
3635
3636         vertex float4 foo() : SV_Position {
3637             ...
3638         }
3639
3640         The semantics are partitioned into 4 types:
3641
3642         1. Built-in variables. For example, : SV_Position.
3643         2. Resources. For example, : register(u0).
3644         3. Stage-in / stage-out variables. For example, : attribute(0).
3645         4. Specialization constants. For example, : specialized.
3646
3647         The semantics are validated according to a collection of rules:
3648
3649         - The same entry point can't list the same semantic twice
3650         - Each built-in type has an appropriate type that is listed in the spec. 
3651         - Each built-in is appropriate as either an input or an output of a particular shader stage
3652         - Resource semantics have to have the appropriate type (e.g. can't use register(s0) on a buffer)
3653         - Resources can't be output from entry points
3654         - The resource semantic mode must match the address space of the resource
3655         - Stage-in and stage-out variables have to be POD
3656         - Specialization constants can't be output from entry points, and have to be numbers
3657
3658         * WebGPUShadingLanguageRI/All.js:
3659         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Added.
3660         (BuiltInSemantic):
3661         (BuiltInSemantic.prototype.get name):
3662         (BuiltInSemantic.prototype.get extraArguments):
3663         (BuiltInSemantic.prototype.isAcceptableType):
3664         (BuiltInSemantic.prototype.isAcceptableForShaderType):
3665         (BuiltInSemantic.prototype.toString):
3666         * WebGPUShadingLanguageRI/CallExpression.js:
3667         (CallExpression.prototype._resolveWithOperatorAnderIndexer):
3668         (CallExpression.prototype._resolveWithOperatorLength):
3669         * WebGPUShadingLanguageRI/Checker.js:
3670         (Checker):
3671         (Checker.prototype.visitProgram):
3672         (Checker.prototype._checkSemantics.Item):
3673         (Checker.prototype._checkSemantics.Item.prototype.get type):
3674         (Checker.prototype._checkSemantics.Item.prototype.get semantic):
3675         (Checker.prototype._checkSemantics.Gatherer):
3676         (Checker.prototype._checkSemantics.Gatherer.prototype.reset):
3677         (Checker.prototype._checkSemantics.Gatherer.prototype.set currentSemantic):
3678         (Checker.prototype._checkSemantics.Gatherer.prototype.get currentSemantic):
3679         (Checker.prototype._checkSemantics.Gatherer.prototype.get result):
3680         (Checker.prototype._checkSemantics.Gatherer.prototype.visitEnumType):
3681         (Checker.prototype._checkSemantics.Gatherer.prototype.visitVectorType):
3682         (Checker.prototype._checkSemantics.Gatherer.prototype.visitMatrixType):
3683         (Checker.prototype._checkSemantics.Gatherer.prototype.visitNativeType):
3684         (Checker.prototype._checkSemantics.Gatherer.prototype.visitStructType):
3685         (Checker.prototype._checkSemantics.Gatherer.prototype.visitTypeRef):
3686         (Checker.prototype._checkSemantics.Gatherer.prototype.visitPtrType):
3687         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayRefType):
3688         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayType):
3689         (Checker.prototype._checkSemantics.Gatherer.prototype.visitFuncParameter):
3690         (Checker.prototype._checkSemantics.checkDuplicateSemantics):
3691         (Checker.prototype._checkSemantics.checkSemanticTypes):
3692         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
3693         (Checker.prototype._checkSemantics.PODChecker.prototype.visitEnumType):
3694         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayType):
3695         (Checker.prototype._checkSemantics.PODChecker.prototype.visitVectorType):
3696         (Checker.prototype._checkSemantics.PODChecker.prototype.visitMatrixType):
3697         (Checker.prototype._checkSemantics.PODChecker.prototype.visitNativeType):
3698         (Checker.prototype._checkSemantics.PODChecker.prototype.visitPtrType):
3699         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayRefType):
3700         (Checker.prototype._checkSemantics.PODChecker.prototype.visitStructType):
3701         (Checker.prototype._checkSemantics.PODChecker.prototype.visitTypeRef):
3702         (Checker.prototype._checkSemantics.PODChecker):
3703         (Checker.prototype._checkSemantics.checkPODData):
3704         (Checker.prototype._checkSemantics):
3705         (Checker.prototype._checkShaderType):
3706         (Checker.prototype._checkOperatorOverload):
3707         (Checker.prototype.visitFuncDef):
3708         (Checker.prototype.visitEnumType):
3709         (Checker.prototype.visitArrayType):
3710         (Checker.prototype.visitMakePtrExpression):
3711         (Checker.prototype.visitMakeArrayRefExpression):
3712         (Checker.prototype._finishVisitingPropertyAccess):
3713         (Checker.prototype.visitIndexExpression):
3714         (Checker.prototype.visitReturn):
3715         (Checker.prototype.visitSwitchStatement):
3716         (Checker.prototype.visitTernaryExpression):
3717         (Checker.prototype.visitCallExpression):
3718         * WebGPUShadingLanguageRI/Field.js:
3719         (Field):
3720         (Field.prototype.get semantic):
3721         (Field.prototype.toString):
3722         * WebGPUShadingLanguageRI/Func.js:
3723         (Func):
3724         (Func.prototype.get semantic):
3725         (Func.prototype.toDeclString):
3726         * WebGPUShadingLanguageRI/FuncDef.js:
3727         (FuncDef):
3728         * WebGPUShadingLanguageRI/FuncParameter.js:
3729         (FuncParameter):
3730         (FuncParameter.prototype.get semantic):
3731         (FuncParameter.prototype.toString):
3732         * WebGPUShadingLanguageRI/Intrinsics.js:
3733         * WebGPUShadingLanguageRI/LateChecker.js:
3734         (LateChecker.prototype.visitReferenceType):
3735         (LateChecker):
3736         (LateChecker.prototype._checkShaderType): Deleted.
3737         (LateChecker.prototype.visitFuncDef): Deleted.
3738         * WebGPUShadingLanguageRI/NativeFunc.js:
3739         (NativeFunc):
3740         * WebGPUShadingLanguageRI/Parse.js:
3741         (parseParameter):
3742         (parseFuncDecl):
3743         (parseFuncDef):
3744         (parseStageInOutSemantic):
3745         (parseResourceSemantic):
3746         (parseSpecializationConstantSemantic):
3747         (parseBuiltInSemantic):
3748         (parseField):
3749         (parseNativeFunc):
3750         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:
3751         (programWithUnnecessaryThingsRemoved):
3752         * WebGPUShadingLanguageRI/ResourceSemantic.js: Added.
3753         (ResourceSemantic):
3754         (ResourceSemantic.prototype.get resourceMode):
3755         (ResourceSemantic.prototype.get index):
3756         (ResourceSemantic.prototype.get space):
3757         (ResourceSemantic.prototype.isAcceptableType):
3758         (ResourceSemantic.prototype.isAcceptableForShaderType):
3759         (ResourceSemantic.prototype.toString):
3760         * WebGPUShadingLanguageRI/Rewriter.js:
3761         (Rewriter.prototype.visitFuncParameter):
3762         (Rewriter.prototype.visitField):
3763         (Rewriter.prototype.visitBuiltInSemantic):
3764         (Rewriter.prototype.visitResourceSemantic):
3765         (Rewriter.prototype.visitStageInOutSemantic):
3766         (Rewriter.prototype.visitSpecializationConstantSemantic):
3767         (Rewriter):
3768         * WebGPUShadingLanguageRI/SPIRV.html:
3769         * WebGPUShadingLanguageRI/Semantic.js: Added.
3770         (Semantic):
3771         (Semantic.prototype.get origin):
3772         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitBuiltInSemantic):
3773         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitResourceSemantic):
3774         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitStageInOutSemantic):
3775         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitSpecializationConstantSemantic):
3776         (Semantic.prototype.equalToOtherSemantic.Comparer):
3777         (Semantic.prototype.equalToOtherSemantic):
3778         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/Field.js.
3779         (SpecializationConstantSemantic):
3780         (SpecializationConstantSemantic.prototype.isAcceptableType):
3781         (SpecializationConstantSemantic.prototype.isAcceptableForShaderType):
3782         (SpecializationConstantSemantic.prototype.toString):
3783         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
3784         (StageInOutSemantic):
3785         (StageInOutSemantic.prototype.get index):
3786         (StageInOutSemantic.prototype.isAcceptableType):
3787         (StageInOutSemantic.prototype.isAcceptableForShaderType):
3788         (StageInOutSemantic.prototype.toString):
3789         * WebGPUShadingLanguageRI/StatementCloner.js:
3790         (StatementCloner.prototype.visitNativeFunc):
3791         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js:
3792         (synthesizeArrayOperatorLength):
3793         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js:
3794         (synthesizeCopyConstructorOperator):
3795         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js:
3796         (synthesizeDefaultConstructorOperator):
3797         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js:
3798         (synthesizeEnumFunctions):
3799         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
3800         (setupAnder):
3801         (synthesizeStructAccessorsForStructType):
3802         * WebGPUShadingLanguageRI/Test.html:
3803         * WebGPUShadingLanguageRI/Test.js:
3804         (tests.shaderTypes):
3805         * WebGPUShadingLanguageRI/Visitor.js:
3806         (Visitor.prototype.visitFunc):
3807         (Visitor.prototype.visitFuncParameter):
3808         (Visitor.prototype.visitField):
3809         (Visitor.prototype.visitBuiltInSemantic):
3810         (Visitor.prototype.visitResourceSemantic):
3811         (Visitor.prototype.visitStageInOutSemantic):
3812         (Visitor.prototype.visitSpecializationConstantSemantic):
3813         (Visitor):
3814         * WebGPUShadingLanguageRI/index.html:
3815
3816 2018-09-25  Thomas Denney  <tdenney@apple.com>
3817
3818         [WHLSL] Test suite for Metal code generation
3819         https://bugs.webkit.org/show_bug.cgi?id=187738
3820
3821         Reviewed by Myles C. Maxfield.
3822
3823         This patch adds an Xcode project that contains a Cocoa app that can be
3824         used for running WHLSL shaders on the GPU. It also contains an Xcode
3825         test suite that runs all of the tests in Test.js on the GPU.
3826
3827         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Added.
3828         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Added.
3829         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Added.
3830         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
3831         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Added.
3832         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Added.
3833         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Added.
3834         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Added.
3835         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Added.
3836         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Added.
3837         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Added.
3838         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Added.
3839         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Added.
3840         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Added.
3841         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Added.
3842         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Added.
3843         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Added.
3844         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Added.
3845         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Added.
3846         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Added.
3847         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Added.
3848         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Added.
3849         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Added.
3850         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Added.
3851         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Added.
3852         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Added.
3853         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Added.
3854         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Added.
3855         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Added.
3856         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Added.
3857         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Added.
3858         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Added.
3859         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Added.
3860         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Added.
3861         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Added.
3862         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Added.
3863         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Added.
3864         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Added.
3865         * WebGPUShadingLanguageRI/Test.js:
3866         (tests.lotsOfLocalVariables):
3867
3868 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
3869
3870         Unreviewed build fix after r236455
3871         https://bugs.webkit.org/show_bug.cgi?id=189121
3872
3873         * WebGPUShadingLanguageRI/Test.js:
3874         (tests.shaderStages):
3875
3876 2018-09-24  Myles C. Maxfield  <mmaxfield@apple.com>
3877
3878         [WHLSL] Not all functions should be able to run in all shader stages
3879         https://bugs.webkit.org/show_bug.cgi?id=189121
3880
3881         Reviewed by Filip Pizlo.
3882
3883         ddx() and ddy() can only run in fragment shaders, and the barrier functions can only run in compute shaders.
3884         ddx_coarse() & friends are currently implemented as just calling ddx(), so we only need to modify those functions
3885         if/when we make them native.
3886
3887         The texture sampling functions that use implicit derivatives can run in any shader stage - they just use a LOD of
3888         0. Therefore, those functions are unchanged.
3889
3890         * WebGPUShadingLanguageRI/All.js:
3891         * WebGPUShadingLanguageRI/Intrinsics.js:
3892         * WebGPUShadingLanguageRI/LateChecker.js:
3893         (LateChecker.prototype._checkShaderType):
3894         * WebGPUShadingLanguageRI/NativeFunc.js:
3895         (NativeFunc):
3896         (NativeFunc.prototype.get stage):
3897         (NativeFunc.prototype.toDeclString):
3898         * WebGPUShadingLanguageRI/Parse.js:
3899         (parseFuncDecl):
3900         (parseNativeFunc):
3901         (parseNative):
3902         * WebGPUShadingLanguageRI/Prepare.js:
3903         (let.prepare):
3904         * WebGPUShadingLanguageRI/SPIRV.html:
3905         * WebGPUShadingLanguageRI/StandardLibrary.js:
3906         (let.standardLibrary):
3907         * WebGPUShadingLanguageRI/StatementCloner.js:
3908         (StatementCloner.prototype.visitNativeFunc):
3909         * WebGPUShadingLanguageRI/Test.html:
3910         * WebGPUShadingLanguageRI/Test.js:
3911         (tests.shaderStages):
3912         * WebGPUShadingLanguageRI/WSyntaxError.js:
3913         (WSyntaxError.prototype.toString):
3914         (WSyntaxError):
3915         * WebGPUShadingLanguageRI/index.html:
3916
3917 2018-09-24  Thomas Denney  <tdenney@apple.com>
3918
3919         [WHLSL] Implement trap statements in Metal code generation
3920         https://bugs.webkit.org/show_bug.cgi?id=189615
3921
3922         Reviewed by Myles C. Maxfield.
3923
3924         Each function called by an entry point now receives an additional
3925         boolean pointer parameter, which is set to false if the function traps.
3926         After each function call (to a non-native function) this trap parameter
3927         is checked. The behavior of the interpreter has also been updated so
3928         that a function entry point catches the trap and instead returns zero,
3929         matching the behavior of compiled code.
3930
3931         * WebGPUShadingLanguageRI/Evaluator.js: Adds a new flag to allow the
3932         test suite to check for traps and also returns zero from entry points
3933         whose invocation trapped.
3934         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Pass program to function
3935         declarations.
3936         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Update dependencies.
3937         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Add program
3938         property.
3939         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Ditto.
3940         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Added.
3941         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Conforms to the
3942         new trapping behavior.
3943         * WebGPUShadingLanguageRI/Test.js: Update tests that trap.
3944
3945 2018-09-24  Thomas Denney  <tdenney@apple.com>
3946
3947         [WHLSL] It shouldn’t be possible to use ternary expressions as l-values
3948         https://bugs.webkit.org/show_bug.cgi?id=189290
3949
3950         Reviewed by Myles C. Maxfield.
3951
3952         It is no longer possible for a ternary expression to be treated as an
3953         l-value. This patch adds several test cases to verify that this is the
3954         case.
3955
3956         * WebGPUShadingLanguageRI/Checker.js:
3957         (Checker.prototype.visitTernaryExpression): No longer check isLValue.
3958         * WebGPUShadingLanguageRI/NormalUsePropertyResolver:
3959         (NormalUsePropertyResolver.visitTernaryExpression): Deleted.
3960         * WebGPUShadingLanguageRI/Rewriter.js:
3961         (Rewriter.prototype.visitTernaryExpression): No longer copy isLValue.
3962         * WebGPUShadingLanguageRI/TernaryExpression.js:
3963         (TernaryExpression):
3964         (TernaryExpression.prototype.get elseExpression):
3965         (TernaryExpression.prototype.get isLValue): Deleted.
3966         (TernaryExpression.prototype.set isLValue): Deleted.
3967         * WebGPUShadingLanguageRI/Test.js:
3968         (tests.ternaryExpression): Add checks for failure if a failure is used
3969         as an l-value.
3970         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor.prototype.visitTernaryExpression): Deleted.
3971         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor): Deleted.
3972         (tests.ternaryExpressionIsLValue): Deleted.
3973
3974 2018-09-24  Jer Noble  <jer.noble@apple.com>
3975
3976         SharedBuffer should have an equality test
3977         https://bugs.webkit.org/show_bug.cgi?id=189919
3978
3979         Reviewed by Alex Christensen.
3980
3981         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3982         (TestWebKitAPI::TEST_F):
3983
3984 2018-09-24  Alex Christensen  <achristensen@webkit.org>
3985
3986         Prepare to replace WKBundleFileHandleCreateWithPath with a version that takes a WKBundlePageRef
3987         https://bugs.webkit.org/show_bug.cgi?id=189929
3988
3989         Reviewed by Andy Estes.
3990
3991         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp:
3992
3993 2018-09-24  Thomas Denney  <tdenney@apple.com>
3994
3995         [WHLSL] Casting user-created types to themselves should always work
3996         https://bugs.webkit.org/show_bug.cgi?id=189113
3997
3998         Reviewed by Myles C. Maxfield.
3999
4000         Casting user-defined types to themselves worked already, but we didn't
4001         test it anywhere.
4002
4003         * WebGPUShadingLanguageRI/Test.js:
4004         (tests.selfCasts):
4005
4006 2018-09-24  Zan Dobersek  <zdobersek@igalia.com>
4007
4008         Unreviewed build fix for Jhbuild-using ports.
4009
4010         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch:
4011         Adjust the patch so it applies cleanly on the 1.14.3 version of the
4012         gst-plugins-good package.
4013
4014 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
4015
4016         Update flakiness dashboard configuration for iOS 12 queues
4017         https://bugs.webkit.org/show_bug.cgi?id=189688
4018
4019         Reviewed by Alexey Proskuryakov.
4020
4021         * TestResultServer/static-dashboards/builders.jsonp:
4022
4023 2018-09-24  Alicia Boya García  <aboya@igalia.com>
4024
4025         [GStreamer] Unreviewed build fix.
4026
4027         A GStreamer patch was not applying cleanly on 1.14.3.
4028
4029         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch:
4030
4031 2018-09-24  Alicia Boya García  <aboya@igalia.com>
4032
4033         [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
4034         https://bugs.webkit.org/show_bug.cgi?id=189868
4035
4036         Reviewed by Xabier Rodriguez-Calvar.
4037
4038         Added patch from https://bugzilla.gnome.org/show_bug.cgi?id=797187
4039
4040         * gstreamer/jhbuild.modules:
4041         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Added.
4042
4043 2018-09-24  Alicia Boya García  <aboya@igalia.com>
4044         [MSE][GStreamer] Add patch to jhbuild: matroskademux: Allow Matroska headers to be read more than once
4045         https://bugs.webkit.org/show_bug.cgi?id=185731
4046
4047         Reviewed by Xabier Rodriguez-Calvar.
4048
4049         Upstream bug in GStreamer: https://bugzilla.gnome.org/show_bug.cgi?id=793333
4050
4051         This fixes YTTV 35. AppendMultipleInitOpusAudio (and any other use
4052         case where two WebM initialization segments are appended on a row).
4053
4054         * gstreamer/jhbuild.modules:
4055         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Added.
4056         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Added.
4057         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Added.
4058
4059 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
4060
4061         [WHSL] Need grammar to specify kernel group size
4062         https://bugs.webkit.org/show_bug.cgi?id=189108
4063
4064         Reviewed by Dean Jackson.
4065
4066         In HLSL, compute functions are annotated with their workgroup size.
4067         For example,
4068
4069         [numthreads(3, 4, 5)] compute void foo(...) { ... }
4070
4071         * WebGPUShadingLanguageRI/All.js:
4072         * WebGPUShadingLanguageRI/Func.js:
4073         (Func):
4074         (Func.prototype.get attributeBlock):
4075         * WebGPUShadingLanguageRI/FuncAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
4076         (FuncAttribute):
4077         * WebGPUShadingLanguageRI/FuncDef.js:
4078         (FuncDef):
4079         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
4080         (FuncNumThreadsAttribute):
4081         (FuncNumThreadsAttribute.prototype.get x):
4082         (FuncNumThreadsAttribute.prototype.get y):
4083         (FuncNumThreadsAttribute.prototype.get z):
4084         * WebGPUShadingLanguageRI/LateChecker.js:
4085         (LateChecker.prototype._checkShaderType):
4086         * WebGPUShadingLanguageRI/Parse.js:
4087         (parseAttributeBlock):
4088         (parseFuncDecl):
4089         (parseFuncDef):
4090         (parseNativeFunc):
4091         * WebGPUShadingLanguageRI/SPIRV.html:
4092         * WebGPUShadingLanguageRI/StatementCloner.js:
4093         (StatementCloner.prototype.visitFuncDef):
4094         (StatementCloner.prototype.visitFuncNumThreadsAttribute):
4095         (StatementCloner):
4096         * WebGPUShadingLanguageRI/Test.html:
4097         * WebGPUShadingLanguageRI/Test.js:
4098         (tests.numThreads):
4099         * WebGPUShadingLanguageRI/Visitor.js:
4100         (Visitor.prototype.visitFunc):
4101         (Visitor.prototype.visitFuncNumThreadsAttribute):
4102         (Visitor):
4103         * WebGPUShadingLanguageRI/index.html:
4104
4105 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
4106
4107         Native functions which accept pointers need to do null checks
4108         https://bugs.webkit.org/show_bug.cgi?id=189883
4109
4110         Reviewed by Dean Jackson.
4111
4112         Simply guard all the places where we write through an author-provided pointer.
4113
4114         * WebGPUShadingLanguageRI/Intrinsics.js:
4115         (Intrinsics.):
4116         * WebGPUShadingLanguageRI/Test.js:
4117         (tests.textureDimensionsNull):
4118
4119 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
4120
4121         [WHLSL] Implement atomic operations and barriers
4122         https://bugs.webkit.org/show_bug.cgi?id=189025
4123
4124         Reviewed by Dean Jackson.
4125
4126         In the interpreter, atomic operations don't need to be atomic.
4127
4128         * WebGPUShadingLanguageRI/Intrinsics.js:
4129         (Intrinsics.):
4130         * WebGPUShadingLanguageRI/StandardLibrary.js:
4131         (let.standardLibrary):
4132         * WebGPUShadingLanguageRI/Test.js:
4133         (tests.atomics):
4134
4135 2018-09-22  Thibault Saunier  <tsaunier@igalia.com>
4136
4137         [WPE] Be very permissive in the MiniBrowser.
4138         https://bugs.webkit.org/show_bug.cgi?id=189800
4139
4140         This is just a test tool and we should make
4141         it just work, security and privacy is not really
4142         a primary focus here.
4143
4144         Reviewed by Žan Doberšek.
4145
4146         * MiniBrowser/wpe/main.cpp:
4147         (decidePermissionRequest):
4148         (main):
4149
4150 2018-09-21  Thomas Denney  <tdenney@apple.com>
4151
4152         [WHLSL] Local variables should be statically allocated
4153         https://bugs.webkit.org/show_bug.cgi?id=188402
4154
4155         Reviewed by Myles C. Maxfield.
4156
4157         An additional preparation stage is now performed so that all local
4158         variables and function parameters are allocated in a single struct at
4159         entry points. A pointer to this struct is then passed for function
4160         calls.
4161
4162         * WebGPUShadingLanguageRI/All.js: Update dependencies.
4163         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Added new stage.
4164         * WebGPUShadingLanguageRI/CallExpression.js:
4165         (CallExpression.prototype.set argumentList): Add setter because
4166         allocateAtEntryPoints needs to change this.
4167         * WebGPUShadingLanguageRI/EBufferBuilder.js: Remove a redundant
4168         constructor that wasn't used anywhere.
4169         * WebGPUShadingLanguageRI/Func.js:
4170         (Func.prototype.set parameters): Add setter.
4171         * WebGPUShadingLanguageRI/FuncDef.js:
4172         (FuncDef.prototype.set body): Ditto.
4173         * WebGPUShadingLanguageRI/Prepare.js:
4174         (let.prepare): Add call to allocateAtEntryPoints. This call cannot
4175         happen any earlier because it depends on having types for call
4176         arguments.
4177         * WebGPUShadingLanguageRI/Rewriter.js:
4178         (Rewriter.prototype.visitReturn): Resolve issue where the return
4179         statement's function wasn't copied. A null check is required as the
4180         Rewriter might be used before this property is set.
4181         * WebGPUShadingLanguageRI/SPIRV.html: Update dependencies.
4182         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Abstracted logic
4183         into a separate function so that allocateAtEntryPoints can create the
4184         accessors for the struct type it introduces.
4185         * WebGPUShadingLanguageRI/Test.html: Update dependencies.
4186         * WebGPUShadingLanguageRI/Test.js: Add new tests to verify the static
4187         allocation transform works safely.
4188         * WebGPUShadingLanguageRI/index.html: Update dependencies.
4189
4190 2018-09-21  Jonathan Bedard  <jbedard@apple.com>
4191
4192         Bring up queues for iOS 12 (Build fix)
4193         https://bugs.webkit.org/show_bug.cgi?id=189683
4194
4195         Unreviewed build fix.
4196
4197         We should not build ImageDiff as x86 by default since 32 bit projects are
4198         deprecated in Xcode. ImageDiff should only be built once.
4199
4200         * Scripts/build-webkit:
4201         * Scripts/webkitdirs.pm:
4202         (argumentsForConfiguration):
4203
4204 2018-09-21  Adrian Perez de Castro  <aperez@igalia.com>
4205
4206         [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPEToolingBackends.so()"
4207         https://bugs.webkit.org/show_bug.cgi?id=189797
4208
4209         Reviewed by Žan Doberšek.
4210
4211         * wpe/backends/CMakeLists.txt: Make libWPEToolingBackends a static library to avoid
4212         the need for installing it. This works fine because the library only contains utility
4213         code intended to be reused from other various components (MiniBrowser, WebKitTestRunner).
4214
4215 2018-09-20  Daniel Bates  <dabates@apple.com>
4216
4217         Move IOKitSPI.h from TestRunnerShared to PAL
4218         https://bugs.webkit.org/show_bug.cgi?id=189804
4219
4220         Reviewed by Wenson Hsieh.
4221
4222         Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
4223         declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.
4224
4225         No functionality changed. So, no new tests.
4226
4227         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
4228         * TestRunnerShared/spi/UIKitTestSPI.h:
4229         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4230         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4231
4232 2018-09-20  Thomas Denney  <tdenney@apple.com>
4233
4234         [WHLSL] Metal code generation
4235         https://bugs.webkit.org/show_bug.cgi?id=187735
4236
4237         Reviewed by Myles C. Maxfield.
4238
4239         Adds support for generating Metal Shading Language from WHLSL. Clients
4240         should include the file MetalCodegenAll.js and then call whlslToMsl
4241         with their program source code to compile to Metal.
4242
4243         * WebGPUShadingLanguageRI/ArrayType.js:
4244         (ArrayType.prototype.get arrayRefType): Adds the arrayRefType method to
4245         all types to find the type of that expression when it is used in a
4246         MakeArrayRefExpression.
4247         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js:
4248         (MakeArrayRefExpression):
4249         (MakeArrayRefExpression.prototype.get type): Uses the new arrayRefType
4250         getter on all types to find the type of the expression.
4251         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Added.
4252         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Added.
4253         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Added.
4254         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Added.
4255         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Added.
4256         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Added.
4257         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Added.
4258         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Added.
4259         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Added.
4260         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Added.
4261         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Added.
4262         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Added.
4263         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Added.
4264         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Added.
4265         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Added.
4266         * WebGPUShadingLanguageRI/PropertyResolver.js:
4267         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
4268         * WebGPUShadingLanguageRI/Test.js: Added awkward tests for the compiler
4269         to generate code for.
4270         (tests.incrementAndDecrement):
4271         (tests.returnIntLiteralUint):
4272         (tests.returnIntLiteralFloat):