Add monitoring of patches and queues to the QueueStatusServer
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-22  Alan Cutter  <alancutter@chromium.org>
2
3         Add monitoring of patches and queues to the QueueStatusServer
4         https://bugs.webkit.org/show_bug.cgi?id=107612
5
6         Reviewed by Adam Barth.
7
8         Created classes for recording events into the datastore and integrated them into the existing handlers.
9         Code for presenting the recorded data will come in a separate patch.
10
11         * QueueStatusServer/app.yaml:
12         * QueueStatusServer/config/__init__.py: Added.
13         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
14         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
15         * QueueStatusServer/handlers/nextpatch.py:
16         (NextPatch.get):
17         (NextPatch._assign_patch):
18         * QueueStatusServer/handlers/releasepatch.py:
19         (ReleasePatch.post):
20         * QueueStatusServer/handlers/updatestatus.py:
21         (UpdateStatus.post):
22         * QueueStatusServer/handlers/updateworkitems.py:
23         (UpdateWorkItems._parse_work_items_string):
24         (UpdateWorkItems):
25         (UpdateWorkItems._update_work_items_from_request):
26         (UpdateWorkItems._queue_from_request):
27         (UpdateWorkItems.post):
28         * QueueStatusServer/loggers/__init__.py: Added.
29         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
30         (RecordBotEvent):
31         (RecordBotEvent.activity):
32         * QueueStatusServer/loggers/recordpatchevent.py: Added.
33         (RecordPatchEvent):
34         (RecordPatchEvent.added):
35         (RecordPatchEvent.retrying):
36         (RecordPatchEvent.started):
37         (RecordPatchEvent.stopped):
38         (RecordPatchEvent.updated):
39         (RecordPatchEvent._get_patches_waiting):
40         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
41         (PatchLog):
42         (PatchLog.lookup):
43         (PatchLog.calculate_wait_duration):
44         (PatchLog.calculate_process_duration):
45         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
46         (QueueLog):
47         (QueueLog.get_current):
48         (QueueLog.create_key):
49         * QueueStatusServer/model/queuestatus.py:
50         (QueueStatus.is_retry_request):
51
52 2013-01-22  Timothy Loh  <timloh@chromium.com>
53
54         prepare-Changelog should support updating the list of changed files
55         https://bugs.webkit.org/show_bug.cgi?id=74358
56
57         Reviewed by Eric Seidel.
58
59         Needing to re-make ChangeLog entries when the list of files/functions
60         changes is a bit annoying, it'd be nice to have this more automated.
61         This patch makes `webkit-patch update' update the date line and bug
62         description if needed, and if the list of changed files/functions has
63         changed, either updates the list (if there are no annotations), or
64         otherwise appends the new list below.
65
66         * Scripts/webkitpy/tool/steps/preparechangelog.py:
67         (PrepareChangeLog._resolve_existing_entry):
68         (PrepareChangeLog):
69         (PrepareChangeLog._merge_entries):
70         (PrepareChangeLog.run):
71         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
72         (PrepareChangeLogTest.test_resolve_existing_entry):
73         (make_entry):
74         (test_ensure_bug_url):
75
76 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
77
78         Use Python 2.7 unittest syntax in our unittests
79         https://bugs.webkit.org/show_bug.cgi?id=105607
80
81         Reviewed by Eric Seidel.
82
83         * Scripts/webkitpy/**/*_unittest.py:
84
85 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
86
87         Convert disable-msg to disable for new pylint.
88         https://bugs.webkit.org/show_bug.cgi?id=107627
89
90         Reviewed by Eric Seidel.
91
92         * Scripts/webkitpy/common/checkout/scm/svn.py:
93         (SVNRepository.has_authorization_for_realm):
94         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
95         (Builder.force_build):
96         * Scripts/webkitpy/common/system/executive_mock.py:
97         (MockExecutive2.run_command):
98         * Scripts/webkitpy/layout_tests/port/base.py:
99         (Port.reference_files):
100         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
101         (ChromiumPortTestCase.test_default_configuration):
102         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
103         (PortTestCase.test_expectations_ordering):
104         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
105         (HttpServerBase._check_that_all_ports_are_available):
106         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
107         (AbstractLocalServerCommand.execute):
108         * Scripts/webkitpy/tool/commands/download.py:
109         (AbstractPatchProcessingCommand):
110         * Scripts/webkitpy/tool/commands/rebaseline.py:
111         (AbstractRebaseliningCommand):
112         (AbstractParallelRebaselineCommand):
113         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
114         (_BaseTestCase.setUp):
115         (TestAnalyzeBaselines.setUp):
116
117 2013-01-22  Frank Farzan  <frankf@chromium.org>
118
119         Flakiness dashboard: update builders.jsonp
120         https://bugs.webkit.org/show_bug.cgi?id=107610
121
122         Reviewed by Ojan Vafai.
123
124         * TestResultServer/static-dashboards/builders.jsonp:
125
126 2013-01-22  Frank Farzan  <frankf@chromium.org>
127
128         Add Android instrumentation tests from ChromiumLinux waterfall
129         https://bugs.webkit.org/show_bug.cgi?id=107597
130
131         Reviewed by Ojan Vafai.
132
133         * TestResultServer/static-dashboards/builders.js:
134         (loadBuildersList):
135
136 2013-01-21  Kentaro Hara  <haraken@chromium.org>
137
138         Implement UIEvent constructor
139         https://bugs.webkit.org/show_bug.cgi?id=107430
140
141         Reviewed by Adam Barth.
142
143         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
144
145         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
146         which is enabled on Safari and Chromium for now.
147
148         * Scripts/webkitperl/FeatureList.pm:
149
150 2013-01-22  Timothy Loh  <timloh@chromium.com>
151
152         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
153         https://bugs.webkit.org/show_bug.cgi?id=107478
154
155         Reviewed by Eric Seidel.
156
157         On the road to resolving Bug 74358, we need a few more functions in
158         changelog.py.
159         To make things easier to mock, change @staticmethods to @classmethods.
160
161         * Scripts/webkitpy/common/checkout/changelog.py:
162         (ChangeLogEntry):
163         (ChangeLogEntry._parse_reviewer_text):
164         (ChangeLogEntry._split_contributor_names):
165         (ChangeLogEntry._parse_author_name_and_email):
166         (ChangeLogEntry._parse_author_text):
167         (ChangeLogEntry._parse_touched_functions):
168         (ChangeLogEntry._parse_bug_description):
169         (ChangeLogEntry._parse_entry):
170         (ChangeLogEntry.date_line):
171         (ChangeLogEntry.bug_description):
172         (ChangeLogEntry.touched_functions):
173         (ChangeLogEntry.touched_files_text):
174         (ChangeLogEntry.is_touched_files_text_clean):
175         (ChangeLog):
176         (ChangeLog.parse_latest_entry_from_file):
177         (ChangeLog._separate_revision_and_line):
178         (ChangeLog.parse_entries_from_file):
179         (ChangeLog.set_short_description_and_bug_url):
180         (ChangeLog.delete_entries):
181         (ChangeLog.prepend_text):
182         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
183         (test_parse_log_entries_from_changelog):
184         (test_latest_entry_parse):
185         (test_set_short_description_and_bug_url):
186         (test_delete_entries):
187         (test_prepend_text):
188
189 2013-01-22  Lucas Forschler  <lforschler@apple.com>
190
191         Create a MAC EWS startup shell script.
192
193         Reviewed by Ryosuke Niwa.
194
195         * EWSTools/start-queue-mac.sh: Added.
196
197 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
198
199         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
200         https://bugs.webkit.org/show_bug.cgi?id=107230
201
202         Reviewed by David Kilzer.
203
204         * DumpRenderTree/mac/TestRunnerMac.mm:
205         (TestRunner::resetPageVisibility):
206         Fix a typo in the original implementation. resetPageVisibility should
207         pass initialState YES so an event is not dispatched, which causes
208         issues in multiple tests. This now matches other ports.
209
210 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
211
212         [GTK] Enable CSS Image Orientation feature
213         https://bugs.webkit.org/show_bug.cgi?id=99040
214
215         Reviewed by Martin Robinson.
216
217         Enable the CSS Image Orientation feature in the development
218         builds of the GTK port. The feature is still disabled in the release
219         builds.
220
221         * Scripts/webkitperl/FeatureList.pm:
222
223 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
224
225         [GTK] Enable the <template> element support in development builds
226         https://bugs.webkit.org/show_bug.cgi?id=106575
227
228         Reviewed by Martin Robinson.
229
230         Enable the <template> element support in the development builds of the GTK port.
231
232         * Scripts/webkitperl/FeatureList.pm:
233
234 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
235
236         Prettify the output of the override-feature-defines script
237         https://bugs.webkit.org/show_bug.cgi?id=106542
238
239         Reviewed by Martin Robinson.
240
241         The output now clearly lists the feature defines being overridden
242         along with the default and overriding values for each feature define.
243
244         * gtk/override-feature-defines:
245         (adjust_feature_defines_makefile):
246         (adjust_feature_defines_makefile.override_feature_define):
247
248 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
249
250         Remove uses of deprecated unittest.TestCase aliases
251         https://bugs.webkit.org/show_bug.cgi?id=102252
252
253         Reviewed by Adam Barth.
254
255         Replace the deprecated assertEquals method of the TestCase interface
256         used in some webkitpy unittests with the assertEqual method.
257
258         * Scripts/webkitpy/common/system/profiler_unittest.py:
259         (ProfilerFactoryTest._assert_default_profiler_name):
260         (ProfilerFactoryTest.test_default_profiler_output):
261         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
262         (GtkPortTest.test_expectations_files):
263         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
264         (TestHttpServer.test_win32_start_and_stop):
265
266 2013-01-22  Jer Noble  <jer.noble@apple.com>
267
268         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
269         https://bugs.webkit.org/show_bug.cgi?id=107562
270
271         Rubber-stamped by Alexy Proskuryakov.
272
273         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
274
275         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
276         (WTR::PlatformWebView::PlatformWebView):
277         (WTR::PlatformWebView::viewSupportsOptions):
278
279 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
280
281         One is not allowed to use commit-queue to make oneself a committer.
282
283         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
284
285 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
286
287         Add myself to commiters.py
288         https://bugs.webkit.org/show_bug.cgi?id=107546
289
290         Reviewed by Kentaro Hara.
291
292         * Scripts/webkitpy/common/config/committers.py:
293
294 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
295
296         [GTK] Implement TestRunner::setTextDirection
297         https://bugs.webkit.org/show_bug.cgi?id=107131
298
299         Reviewed by Philippe Normand.
300
301         * DumpRenderTree/gtk/DumpRenderTree.cpp:
302         (resetDefaultsToConsistentValues): Reset direction to default value.
303         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
304         (TestRunner::setTextDirection): Implement method using
305         gtk_widget_set_direction.
306
307 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
308
309         [chromium] move spell checking mocks to TestRunner library
310         https://bugs.webkit.org/show_bug.cgi?id=107455
311
312         Reviewed by Kent Tamura.
313
314         The content module doesn't provide its own WebSpellCheckClient.
315
316         * DumpRenderTree/DumpRenderTree.gypi:
317         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
318         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
319         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
320         (WebKit):
321         (WebTestRunner):
322         (WebTestProxyBase):
323         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
324         (WebTestRunner):
325         (WebTestRunner::makeMenuItemStringsFor):
326         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
327         (MockGrammarCheck::checkGrammarOfString):
328         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
329         (WebKit):
330         (MockGrammarCheck):
331         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
332         (MockSpellCheck::MockSpellCheck):
333         (MockSpellCheck::~MockSpellCheck):
334         (isNotASCIIAlpha):
335         (MockSpellCheck::spellCheckWord):
336         (MockSpellCheck::fillSuggestionList):
337         (MockSpellCheck::initializeIfNeeded):
338         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
339         (MockSpellCheck):
340         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
341         (WebTestRunner::SpellCheckClient::SpellCheckClient):
342         (WebTestRunner):
343         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
344         (WebTestRunner::SpellCheckClient::setDelegate):
345         (WebTestRunner::SpellCheckClient::spellCheck):
346         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
347         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
348         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
349         (WebTestRunner::SpellCheckClient::autoCorrectWord):
350         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
351         (WebTestRunner):
352         (SpellCheckClient):
353         (WebTestRunner::SpellCheckClient::taskList):
354         (WebTestRunner::SpellCheckClient::mockSpellCheck):
355         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
356         (TestDelegate):
357         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
358         (WebTestInterfaces::Internal):
359         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
360         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
361         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
362         (WebTestRunner::WebTestProxyBase::setDelegate):
363         (WebTestRunner::WebTestProxyBase::spellCheckClient):
364         (WebTestRunner):
365         * DumpRenderTree/chromium/WebViewHost.cpp:
366         (WebViewHost::WebViewHost):
367         (WebViewHost::setWebWidget):
368         * DumpRenderTree/chromium/WebViewHost.h:
369         (WebViewHost):
370
371 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
372
373         [EFL] Adds Accessibility support to wk1
374         https://bugs.webkit.org/show_bug.cgi?id=107440
375
376         Reviewed by Gyuyoung Kim.
377
378         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
379
380 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
381
382         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
383         https://bugs.webkit.org/show_bug.cgi?id=107506
384
385         Reviewed by Dan Bernstein.
386
387         * MiniBrowser/mac/WK1BrowserWindowController.m:
388         (-[WK1BrowserWindowController dealloc]):
389
390 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
391
392         Add build flag for Canvas's Path object (disabled by default)
393         https://bugs.webkit.org/show_bug.cgi?id=107473
394
395         Reviewed by Dean Jackson.
396
397         Add CANVAS_PATH build flag to build systems.
398
399         * Scripts/webkitperl/FeatureList.pm:
400
401 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
402
403         [EFL][WK2] Add APIs to set/get view source mode
404         https://bugs.webkit.org/show_bug.cgi?id=106633
405
406         Reviewed by Gyuyoung Kim.
407
408         Added a shotcut 'F8' in Minibrowser to display a source code
409         of the web page in a new window.
410
411        * MiniBrowser/efl/main.c:
412         (on_key_down):
413         (on_window_create):
414         (window_create):
415         (elm_main):
416
417 2013-01-21  Nico Weber  <thakis@chromium.org>
418
419         [chromium] Don't archive generated source files.
420         https://bugs.webkit.org/show_bug.cgi?id=106736
421
422         Reviewed by Eric Seidel.
423
424         They shouldn't be needed to run tests. They don't need a lot of space,
425         but add many lines to the "extracting" stdout. This attempts to reduce
426         that noise a bit.
427
428         * BuildSlaveSupport/built-product-archive:
429         (archiveBuiltProduct):
430
431 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
432
433         Mac DumpRenderTree's installSignalHandlers() is unreachable code
434         https://bugs.webkit.org/show_bug.cgi?id=107383
435
436         Reviewed by Sam Weinig.
437
438         The CrashHandler of DumpRenderTree were originally used for restoring
439         the color profile of the main display even if DRT crashes.
440
441         That feature was later limited to pixel tests only in r29999.
442
443         In r104351, the DRT was changed to use device color space. Making the crash
444         handlers useless, but they were left in the code since the error reporting
445         code was still reachable.
446
447         Later, r124581 refactored the code and dumpPixelsForCurrentTest
448         is being used before being assigned its value.
449         This did cause any regression because the code had become useless with the previous change.
450
451         * DumpRenderTree/mac/DumpRenderTree.mm:
452         Remove crashHandler() and installSignalHandlers() as they have become useless and
453         have been unreachable code for 6 months.
454         (dumpRenderTree):
455         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
456         at those points.
457
458 2013-01-21  Nico Weber  <thakis@chromium.org>
459
460         Make ninja the default build system for build-webkit --chromium on mac
461         https://bugs.webkit.org/show_bug.cgi?id=106737
462
463         Reviewed by Eric Seidel.
464
465         * Scripts/update-webkit-chromium:
466
467 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
468
469         Regression(r140262): Causes a lot of flakiness
470         https://bugs.webkit.org/show_bug.cgi?id=107454
471
472         Reviewed by Alexey Proskuryakov.
473
474         r140262 introduced a lot of flakiness due to fixed layout mode
475         not getting disabled on the view after being enabled for
476         specific test cases. This patch makes sure fixed layout mode
477         properly gets reset in WebKitTestRunner to avoid flakiness.
478
479         * WebKitTestRunner/TestInvocation.cpp:
480         (WTR::updateLayoutType):
481
482 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
483
484         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
485         https://bugs.webkit.org/show_bug.cgi?id=107421
486
487         Unreviewed build fix.
488
489         * Scripts/run-gtk-tests:
490         (TestRunner): skip Resource tests.
491
492 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
493
494         [EFL][WKTR] platformRunUntil() should keep the main loop running
495         https://bugs.webkit.org/show_bug.cgi?id=107442
496
497         Reviewed by Noam Rosenthal.
498
499         EFL's implementation of platformRunUntil() should keep the main loop
500         running and avoid calling sleep() between calls to
501         ecore_main_loop_iterate(). This call to sleep seems to be a source
502         of deadlocks (see Bug 106884).
503
504         * WebKitTestRunner/efl/TestControllerEfl.cpp:
505         (WTR::TestController::platformRunUntil):
506
507 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
508
509         QtTestBrowser should provide way to clear selected elements
510         https://bugs.webkit.org/show_bug.cgi?id=107437
511
512         Reviewed by Simon Hausmann.
513
514         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
515         Invoke the clearSelection prior to highlighting new elements.
516
517         * QtTestBrowser/launcherwindow.cpp:
518         (ElementHighlight):
519         (LauncherWindow::createChrome):
520         (LauncherWindow::selectElements):
521         (LauncherWindow::clearSelection):
522         * QtTestBrowser/launcherwindow.h:
523         (LauncherWindow):
524
525 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
526
527         [chromium] move methods interacting with willSendRequest to TestRunner
528         https://bugs.webkit.org/show_bug.cgi?id=107270
529
530         Reviewed by Kent Tamura.
531
532         * DumpRenderTree/chromium/DRTTestRunner.cpp:
533         (DRTTestRunner::DRTTestRunner):
534         (DRTTestRunner::waitForPolicyDelegate):
535         * DumpRenderTree/chromium/DRTTestRunner.h:
536         (DRTTestRunner):
537         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
538         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
539         (WebTestRunner::WebTestRunner::httpHeadersToClear):
540         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
541         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
542         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
543         (WebTestRunner::TestRunner::TestRunner):
544         (WebTestRunner::TestRunner::reset):
545         (WebTestRunner::TestRunner::httpHeadersToClear):
546         (WebTestRunner):
547         (WebTestRunner::TestRunner::shouldBlockRedirects):
548         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
549         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
550         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
551         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
552         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
553         (TestRunner):
554         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
555         (WebTestRunner::WebTestProxyBase::willSendRequest):
556         * DumpRenderTree/chromium/WebViewHost.cpp:
557         (WebViewHost::willSendRequest):
558         (WebViewHost::reset):
559         * DumpRenderTree/chromium/WebViewHost.h:
560         (WebViewHost):
561
562 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
563
564         [GTK] Stop building WebKit2 on GTK EWSs
565         https://bugs.webkit.org/show_bug.cgi?id=107435
566
567         Reviewed by Philippe Normand.
568
569         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
570         so stop building it on GTK EWSs.
571
572         * Scripts/webkitpy/common/config/ports.py:
573         (GtkPort.build_webkit_command):
574         * Scripts/webkitpy/common/config/ports_unittest.py:
575         (DeprecatedPortTest.test_gtk_port):
576
577 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
578
579         MediaStream API: Update the RTCPeerConnection states to match the latest specification
580         https://bugs.webkit.org/show_bug.cgi?id=107120
581
582         Reviewed by Adam Barth.
583
584         Updating mock to use the new states.
585
586         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
587         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
588         (MockWebRTCPeerConnectionHandler::initialize):
589         (MockWebRTCPeerConnectionHandler::updateICE):
590
591 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
592
593         Extend diff_parser to support the --full-index output.
594         https://bugs.webkit.org/show_bug.cgi?id=107408
595
596         Reviewed by Maciej Stachowiak.
597
598         * Scripts/webkitpy/common/checkout/diff_parser.py:
599         (git_diff_to_svn_diff):
600         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
601         (DiffParserTest):
602         (DiffParserTest.test_git_diff_to_svn_diff):
603         (git_diff_to_svn_diff):
604
605 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
606
607         Dragging over an element with scrollbars should scroll the element when dragging near edges
608         https://bugs.webkit.org/show_bug.cgi?id=39725
609
610         Reviewed by Hajime Morita.
611
612         This patch introduces canceling drag-and-drop by escape key for testing
613         behavior after cancellation drag-and-drop.
614
615         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
616         (WebTestRunner):
617         (WebTestRunner::EventSender::doMouseUp):
618         (WebTestRunner::EventSender::finishDragAndDrop):
619         (WebTestRunner::EventSender::keyDown):
620         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
621         (EventSender):
622         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
623
624 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
625
626         [chromium] move frame generation related methods to TestRunner
627         https://bugs.webkit.org/show_bug.cgi?id=107268
628
629         Reviewed by Adam Barth.
630
631         * DumpRenderTree/chromium/DRTTestRunner.cpp:
632         (DRTTestRunner::DRTTestRunner):
633         (DRTTestRunner::setWillSendRequestReturnsNull):
634         * DumpRenderTree/chromium/DRTTestRunner.h:
635         (DRTTestRunner):
636         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
637         (WebTestRunner::WebTestDelegate::display):
638         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
639         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
640         (WebTestRunner::TestRunner::TestRunner):
641         (WebTestRunner::TestRunner::display):
642         (WebTestRunner):
643         (WebTestRunner::TestRunner::displayInvalidatedRegion):
644         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
645         (TestRunner):
646         * DumpRenderTree/chromium/WebViewHost.cpp:
647         (WebViewHost::display):
648         (WebViewHost::displayInvalidatedRegion):
649         * DumpRenderTree/chromium/WebViewHost.h:
650
651 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
652
653         [chromium] move speech related methods to TestRunner library
654         https://bugs.webkit.org/show_bug.cgi?id=107266
655
656         Reviewed by Adam Barth.
657
658         * DumpRenderTree/chromium/DRTTestRunner.cpp:
659         (DRTTestRunner::DRTTestRunner):
660         (DRTTestRunner::displayInvalidatedRegion):
661         * DumpRenderTree/chromium/DRTTestRunner.h:
662         (DRTTestRunner):
663         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
664         (WebTestDelegate):
665         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
666         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
667         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
668         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
669         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
670         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
671         (WebTestRunner::TestRunner::TestRunner):
672         (WebTestRunner):
673         (WebTestRunner::TestRunner::addMockSpeechInputResult):
674         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
675         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
676         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
677         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
678         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
679         (TestRunner):
680         * DumpRenderTree/chromium/WebViewHost.cpp:
681         (WebViewHost::addMockSpeechInputResult):
682         (WebViewHost::setMockSpeechInputDumpRect):
683         (WebViewHost::addMockSpeechRecognitionResult):
684         (WebViewHost::setMockSpeechRecognitionError):
685         (WebViewHost::wasMockSpeechRecognitionAborted):
686         * DumpRenderTree/chromium/WebViewHost.h:
687
688 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
689
690         [chromium] move notification related methods to TestRunner
691         https://bugs.webkit.org/show_bug.cgi?id=107269
692
693         Reviewed by Adam Barth.
694
695         * DumpRenderTree/chromium/DRTTestRunner.cpp:
696         (DRTTestRunner::DRTTestRunner):
697         * DumpRenderTree/chromium/DRTTestRunner.h:
698         (DRTTestRunner):
699         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
700         (WebTestDelegate):
701         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
702         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
703         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
704         (WebTestRunner::TestRunner::TestRunner):
705         (WebTestRunner):
706         (WebTestRunner::TestRunner::grantWebNotificationPermission):
707         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
708         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
709         (TestRunner):
710         * DumpRenderTree/chromium/WebViewHost.cpp:
711         (WebViewHost::grantWebNotificationPermission):
712         (WebViewHost::simulateLegacyWebNotificationClick):
713         * DumpRenderTree/chromium/WebViewHost.h:
714
715 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
716
717         [chromium] move geolocation related methods to TestRunner
718         https://bugs.webkit.org/show_bug.cgi?id=107267
719
720         Reviewed by Adam Barth.
721
722         * DumpRenderTree/chromium/DRTTestRunner.cpp:
723         (DRTTestRunner::DRTTestRunner):
724         * DumpRenderTree/chromium/DRTTestRunner.h:
725         (DRTTestRunner):
726         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
727         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
728         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
729         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
730         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
731         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
732         (WebTestRunner::TestRunner::TestRunner):
733         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
734         (WebTestRunner):
735         (WebTestRunner::TestRunner::setGeolocationPermission):
736         (WebTestRunner::TestRunner::setMockGeolocationPosition):
737         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
738         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
739         (TestRunner):
740         * DumpRenderTree/chromium/WebViewHost.cpp:
741         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
742         (WebViewHost::setGeolocationPermission):
743         (WebViewHost::setMockGeolocationPosition):
744         (WebViewHost::setMockGeolocationPositionUnavailableError):
745         * DumpRenderTree/chromium/WebViewHost.h:
746
747 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
748
749         Unreviewed build fix for Qt WK2 after r140258.
750         Use the size_t type instead of unsigned for the variable
751         which holds the position of the first null character in the
752         console message.
753
754         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
755         (WTR::InjectedBundlePage::willAddMessageToConsole):
756
757 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
758
759         Unreviewed, rolling out r140260.
760         http://trac.webkit.org/changeset/140260
761         https://bugs.webkit.org/show_bug.cgi?id=107387
762
763         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
764         nothing else) (Requested by thakis__ on #webkit).
765
766         * Scripts/update-webkit-chromium:
767
768 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
769
770         Delegated scrolling: Assertion on attempt to show a CSS sticky element
771         https://bugs.webkit.org/show_bug.cgi?id=106890
772
773         Reviewed by Kenneth Rohde Christiansen.
774
775         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
776
777         * WebKitTestRunner/TestInvocation.cpp:
778         (WTR::shouldUseFixedLayout):
779         (WTR):
780         (WTR::updateLayoutType):
781
782 2013-01-19  Nico Weber  <thakis@chromium.org>
783
784         Make ninja the default build system for build-webkit --chromium on mac
785         https://bugs.webkit.org/show_bug.cgi?id=106737
786
787         Reviewed by Eric Seidel.
788
789         * Scripts/update-webkit-chromium:
790
791 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
792
793         [WK2] svg/dom/fuzz-path-parser.html is failing
794         https://bugs.webkit.org/show_bug.cgi?id=107133
795
796         Reviewed by Alexey Proskuryakov.
797
798         Console messages can contain null characters before the end of string.
799         Appending such message to the StringBuilder as a WTFString appends the
800         complete string, including the null character. This later cuts off everything
801         after the null character when the string is being printed out to the test
802         output.
803
804         To avoid this, truncate the string up to the first null character. This
805         preserves the newline character appended immediately after this and
806         stops giving incorrect output.
807
808         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
809         (WTR::InjectedBundlePage::willAddMessageToConsole):
810
811 2013-01-19  Eric Seidel  <eric@webkit.org>
812
813         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
814         https://bugs.webkit.org/show_bug.cgi?id=107367
815
816         Reviewed by Ryosuke Niwa.
817
818         Using srcdoc instead of document.write changes the error output
819         ever so slightly.  Clearly we were already trying to ignore these
820         messages, just not succeeding.  This change makes this new test "pass" correctly.
821
822         * Scripts/webkitpy/performance_tests/perftest.py:
823         (PerfTest):
824
825 2013-01-18  Dan Winship  <danw@gnome.org>
826
827         REGRESSION (r139071): run-webkit-httpd complains at launch
828         https://bugs.webkit.org/show_bug.cgi?id=107310
829
830         Reviewed by Alexey Proskuryakov.
831
832         * Scripts/webkitperl/httpd.pm:
833         (getApacheVersion): use preferred perl syntax
834
835 2013-01-18  Julie Parent  <jparent@chromium.org>
836
837         Add back 'group' as a default cross dashboard parameter, but with null as its value.
838         https://bugs.webkit.org/show_bug.cgi?id=107336
839
840         We need to have 'group' listed as a parameter, else we never parse it,
841         as we only parse parameters with defaults.
842         
843         Reviewed by Ojan Vafai.
844
845         * TestResultServer/static-dashboards/dashboard_base.js:
846
847 2013-01-18  Emil A Eklund  <eae@chromium.org>
848
849         Update LayoutUnit rounding unit test
850         https://bugs.webkit.org/show_bug.cgi?id=107322
851
852         Reviewed by Levi Weintraub.
853         
854         Update the LayoutUnitRounding test to use fromFloatRound for
855         values that cannot accurately be represented as a LayoutUnit
856         (the default behavior is to floor the value to the nearest
857         LayoutUnit).
858
859         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
860         (TestWebKitAPI::TEST):
861
862 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
863
864         VCSUtils.pm: Stop calling git repo-config.
865         https://bugs.webkit.org/show_bug.cgi?id=107294
866
867         Reviewed by Dirk Pranke.
868
869         The `repo-config' git command has been deprecated since early
870         2008, and recent versions have started warning it is deprecated.
871
872         Basically revert r27870 and use the `config' command all the time.
873
874         * Scripts/VCSUtils.pm:
875         (gitConfig):
876
877 2013-01-18  Levi Weintraub  <leviw@chromium.org>
878
879         LayoutUnit should round half consistently, not away from zero
880         https://bugs.webkit.org/show_bug.cgi?id=107208
881
882         Reviewed by Eric Seidel.
883
884         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
885         cover this change in rounding behavior.
886
887 2013-01-18  Tim Horton  <timothy_horton@apple.com>
888
889         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
890         https://bugs.webkit.org/show_bug.cgi?id=107234
891
892         Reviewed by Simon Fraser.
893
894         * DumpRenderTree/mac/DumpRenderTree.mm:
895         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
896         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
897         (WTR::PlatformWebView::PlatformWebView): Ditto.
898
899 2013-01-18  Tim Horton  <timothy_horton@apple.com>
900
901         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
902         https://bugs.webkit.org/show_bug.cgi?id=107251
903
904         Reviewed by Simon Fraser.
905
906         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
907
908         * DumpRenderTree/mac/DumpRenderTree.mm:
909         (dumpRenderTree):
910         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
911         (WTR::InjectedBundle::platformInitialize):
912
913 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
914
915         [GTK] Enable indexed database for development builds
916         https://bugs.webkit.org/show_bug.cgi?id=107299
917
918         Reviewed by Gustavo Noronha Silva.
919
920         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
921         for GTK+ development builds.
922
923 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
924
925         AX: Improve table-guessing heuristics
926         https://bugs.webkit.org/show_bug.cgi?id=107042
927
928         Reviewed by Chris Fleizach.
929
930         Implement parentElementCallback on Chromium to make testing easier.
931
932         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
933         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
934
935 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
936
937         [GTK] Add property for IndexedDB database path to WebKitGTK+
938         https://bugs.webkit.org/show_bug.cgi?id=106136
939
940         Reviewed by Gustavo Noronha Silva.
941
942         During testing, set the web database directory to DUMPRENDERTREE_TEMP
943         before falling back to the old default. This is necessary because
944         indexed database tests require that each DRT shard is using a different
945         IDB database location.
946
947         * DumpRenderTree/gtk/DumpRenderTree.cpp:
948         (temporaryDatabaseDirectory): Added this helper for getting the
949         database directory.
950         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
951
952 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
953
954         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
955         https://bugs.webkit.org/show_bug.cgi?id=107264
956
957         Reviewed by Laszlo Gombos.
958
959         Enable API test InjectedBundleFrameHitTest for hit-testing,
960         since it is now passing on both Debug and Release builds.
961
962         * TestWebKitAPI/CMakeLists.txt:
963         * TestWebKitAPI/PlatformEfl.cmake:
964
965 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
966
967         [GTK] Implement TestRunner::addUserScript
968         https://bugs.webkit.org/show_bug.cgi?id=107275
969
970         Reviewed by Philippe Normand.
971
972         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
973         (TestRunner::addUserScript): Implement method using
974         DumpRenderTreeSupportGtk::addUserScript.
975
976 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
977
978         Unreviewed, add my secondary email address to the list.
979
980         * Scripts/webkitpy/common/config/committers.py:
981
982 2013-01-18  Dan Carney  <dcarney@google.com>
983
984         [chromium] move pointerlock functions to TestRunner library
985         https://bugs.webkit.org/show_bug.cgi?id=107241
986
987         Reviewed by Jochen Eisinger.
988
989         * DumpRenderTree/chromium/DRTTestRunner.cpp:
990         (DRTTestRunner::DRTTestRunner):
991         * DumpRenderTree/chromium/DRTTestRunner.h:
992         (DRTTestRunner):
993         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
994         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
995         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
996         (WebTestRunner::WebTestDelegate::didLosePointerLock):
997         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
998         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
999         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1000         (WebTestRunner::TestRunner::TestRunner):
1001         (WebTestRunner):
1002         (WebTestRunner::TestRunner::didAcquirePointerLock):
1003         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
1004         (WebTestRunner::TestRunner::didLosePointerLock):
1005         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
1006         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
1007         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1008         (TestRunner):
1009         * DumpRenderTree/chromium/WebViewHost.h:
1010         (WebViewHost):
1011
1012 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1013
1014         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
1015         https://bugs.webkit.org/show_bug.cgi?id=106774
1016
1017         Reviewed by Martin Robinson.
1018
1019         In order to fix a long standing linespacing/font ascent & descent issue
1020         we found that FreeType commit b0962ac34e660 solves that problem.
1021         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
1022         maintainer recommending several security updates after that said commit.
1023
1024         Also, in order to avoid extra rebaselining, let's activate subpixel
1025         layout at the same time.
1026
1027         * efl/jhbuild.modules: New freetype 2.4.11
1028
1029 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1030
1031         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
1032         https://bugs.webkit.org/show_bug.cgi?id=107107
1033         PR 282192
1034
1035         Reviewed by Rob Buis.
1036
1037         The DRT application will convert relative/absolute file path to
1038         file://<real-file-path> format, so we only check for http/file prefix.
1039
1040         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1041         (BlackBerry::WebKit::isFullUrl):
1042         (WebKit):
1043         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
1044
1045 2013-01-17  Frank Farzan  <frankf@chromium.org>
1046
1047         Flakiness dashboard: Add ChromiumFYI master
1048         https://bugs.webkit.org/show_bug.cgi?id=107180
1049
1050         Reviewed by Ojan Vafai.
1051
1052         This is needed to enable Chrome Android bots
1053         to upload results for instrumentation tests.
1054
1055         * TestResultServer/generate_builders_json.py:
1056         (main):
1057         * TestResultServer/static-dashboards/builders.jsonp:
1058
1059 2013-01-17  Frank Farzan  <frankf@chromium.org>
1060
1061         Add Chrome on Android instrumentation test types to flakiness dashboard
1062         https://bugs.webkit.org/show_bug.cgi?id=106964
1063
1064         Reviewed by Ojan Vafai.
1065
1066         Specifically, add these test types:
1067         
1068          androidwebview_instrumentation_tests
1069          chromiumtestshell_instrumentation_tests
1070          contentshell_instrumentation_tests
1071         
1072         Also, add ChromiumFYI to the list of masters.
1073
1074         * TestResultServer/static-dashboards/builders.js:
1075         (loadBuildersList):
1076         * TestResultServer/static-dashboards/dashboard_base.js:
1077         (currentBuilderGroupCategory):
1078
1079 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
1080
1081         Fixing webkitpy's SCM unit tests.
1082         https://bugs.webkit.org/show_bug.cgi?id=106429
1083
1084         Reviewed by Eric Seidel.
1085
1086         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1087         (SCMDetectorTest.test_detect_scm_system):
1088         * Scripts/webkitpy/common/checkout/scm/git.py:
1089         (Git.in_working_directory):
1090         (Git.read_git_config):
1091         (Git._assert_can_squash):
1092         (Git.remote_branch_ref):
1093         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1094         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
1095         (GitTestWithMock):
1096         (GitTestWithMock.make_scm):
1097         (GitTestWithMock.test_create_patch):
1098         * Scripts/webkitpy/common/system/outputcapture.py:
1099         (OutputCapture.assert_outputs):
1100         (OutputCaptureTestCaseBase):
1101         * Scripts/webkitpy/test/printer.py:
1102         (Printer.configure):
1103
1104 2013-01-17  Julie Parent  <jparent@chromium.org>
1105
1106         Flakiness dashboard assumes there must be ToT tests
1107         https://bugs.webkit.org/show_bug.cgi?id=107155
1108
1109         Remove group as a default parameter, since we can't actually know
1110         the name of a group initially.  Instead, introduces 
1111         currentBuilderGroupName which returns the current builder group
1112         if it has been explicitly set, or picks the first one available
1113         as a default. Allows us to remove some extra code tracking this
1114         stuff as well.
1115         
1116         Reviewed by Ojan Vafai.
1117
1118         * TestResultServer/static-dashboards/dashboard_base.js:
1119         (parseCrossDashboardParameters):
1120         (currentBuilderGroupName):
1121         (currentBuilderGroup):
1122         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1123         (platformAndBuildType):
1124         * TestResultServer/static-dashboards/loader.js:
1125         (.):
1126
1127 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1128
1129         Remove NodeListsNodeData when it's no longer needed
1130         https://bugs.webkit.org/show_bug.cgi?id=107074
1131
1132         Reviewed by Darin Adler.
1133
1134         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
1135
1136         * Scripts/webkitpy/performance_tests/perftest.py:
1137         (PerfTest):
1138
1139 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
1140
1141         Ref test images are upside-down in WebKit2
1142         https://bugs.webkit.org/show_bug.cgi?id=105457
1143
1144         Reviewed by Sam "Speedy" Weinig.
1145         
1146         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
1147         from the window snapshot contained a flipped copy of the image, causing all ref
1148         and pixel images to be upside-down.
1149
1150         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1151         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1152
1153 2013-01-17  Timothy Loh  <timloh@google.com>
1154
1155         Replaced specifiers variable with is_debug in builders.py
1156         https://bugs.webkit.org/show_bug.cgi?id=107057
1157
1158         Reviewed by Dirk Pranke.
1159
1160         Replaced specifiers variable with is_debug in builders.py to simplify
1161         Bug 106259. The other specifiers are not used elsewhere in the code.
1162         Fixed builder_name_for_port_name to return a debug builder if we don't
1163         have a release builder.
1164
1165         * Scripts/webkitpy/layout_tests/port/builders.py:
1166         (all_port_names):
1167         (builder_name_for_port_name):
1168         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1169         (TestRebaselineExpectations.test_rebaseline_expectations):
1170
1171 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
1172
1173         [GTK] Build with LevelDB when IndexedDB is enabled
1174         https://bugs.webkit.org/show_bug.cgi?id=103220
1175
1176         Reviewed by Gustavo Noronha Silva.
1177
1178         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
1179         as it does not conform to WebKit style.
1180
1181 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1182
1183         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
1184         https://bugs.webkit.org/show_bug.cgi?id=107119
1185
1186         Reviewed by Laszlo Gombos.
1187
1188         Do not use ASSERT on ecore_evas_init(), since the expression inside
1189         the macro compiles out of release builds.
1190
1191         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
1192         * TestWebKitAPI/efl/PlatformWebView.cpp:
1193         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
1194
1195 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
1196
1197         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
1198         https://bugs.webkit.org/show_bug.cgi?id=104545
1199
1200         Reviewed by Yury Semikhatsky.
1201
1202         Adopt signature changes.
1203
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1205         (ProfilerAgent.getCPUProfile): Renamed.
1206         (ProfilerAgent.getHeapSnapshot): Added.
1207
1208 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
1209
1210         [GTK][EFL] NWRT should check that Xvfb is installed
1211         https://bugs.webkit.org/show_bug.cgi?id=71767
1212
1213         Reviewed by Dirk Pranke.
1214
1215         EFL and GTK ports now check that Xvfb is installed before running
1216         layout tests. The command line used to check whether Xvfb is present
1217         is a simple `which Xvfb` that should return 0 as the exit code upon
1218         success.
1219
1220         * Scripts/webkitpy/layout_tests/port/efl.py:
1221         (EflPort.show_results_html_file):
1222         (EflPort):
1223         (EflPort.check_sys_deps):
1224         * Scripts/webkitpy/layout_tests/port/gtk.py:
1225         (GtkPort.check_sys_deps):
1226         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1227         (XvfbDriver):
1228         (XvfbDriver.check_xvfb):
1229
1230 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1231
1232         sheriffbot can't tell me who "kov" is
1233         https://bugs.webkit.org/show_bug.cgi?id=106184
1234
1235         Reviewed by Eric Seidel.
1236
1237         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
1238
1239         * Scripts/webkitpy/common/config/committers.py:
1240         (Account.matches_glob):
1241         (CommitterList.contributors_by_search_string):
1242         * Scripts/webkitpy/common/config/committers_unittest.py:
1243         (CommittersTest.test_committer_lookup):
1244         * Scripts/webkitpy/tool/bot/irc_command.py:
1245         (Whois):
1246
1247 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1248
1249         Use xcrun to find path to make for Mac port
1250         <http://webkit.org/b/107091>
1251
1252         Reviewed by Dan Bernstein.
1253
1254         * Scripts/webkitpy/layout_tests/port/mac.py:
1255         (MacPort._build_java_test_support): Call self.make_command().
1256         (MacPort.make_command): Add.  Call xcrun_find().
1257         (MacPort.nm_command): Use self.xcrun_find().
1258         (MacPort.xcrun_find): Add.  Extract from nm_command().
1259
1260 2013-01-16  Sam Weinig  <sam@webkit.org>
1261
1262         Make debug-safari --target-web-process work again
1263         https://bugs.webkit.org/show_bug.cgi?id=107088
1264
1265         Reviewed by Anders Carlsson.
1266
1267         * Scripts/webkitdirs.pm:
1268         (execMacWebKitAppForDebugging):
1269         The shim is now called SecItemShim.
1270
1271 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1272
1273         GCE build scripts don't take working directory into account when calling findzone.sh
1274         https://bugs.webkit.org/show_bug.cgi?id=106962
1275
1276         Reviewed by Adam Barth.
1277
1278         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1279         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1280         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1281
1282 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1283
1284         start-queue.sh does not pass remaining parameters correctly
1285         https://bugs.webkit.org/show_bug.cgi?id=107054
1286
1287         Reviewed by Adam Barth.
1288
1289         start-queue.sh now passes all remaining params to the webkit-patch command.
1290         Previously only one additional queue parameter could be sent.
1291
1292         * EWSTools/start-queue.sh:
1293
1294 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1295
1296         check-webkit-style script cannot running in Chinese windows.
1297         https://bugs.webkit.org/show_bug.cgi?id=87548
1298
1299         Reviewed by Darin Adler.
1300
1301         * Scripts/webkitpy/common/system/platforminfo.py:
1302         (PlatformInfo._win_version_tuple_from_cmd):
1303
1304 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1305
1306         Delete an extraneous print statement.
1307         https://bugs.webkit.org/show_bug.cgi?id=106562
1308
1309         Delete the extraneous print statement introduced in r139841.
1310
1311         * Scripts/webkitpy/layout_tests/views/printing.py:
1312         (Printer.print_found):
1313
1314 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1315
1316         Please reinstate --pixel
1317         https://bugs.webkit.org/show_bug.cgi?id=101995
1318
1319         Reviewed by Dirk Pranke.
1320
1321         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
1322         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
1323         Some developers are still used to these options that were available in the ORWT.
1324
1325         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1326         (parse_args):
1327
1328 2013-01-16  Eric Seidel  <eric@webkit.org>
1329
1330         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
1331         https://bugs.webkit.org/show_bug.cgi?id=99512
1332
1333         Reviewed by Darin Adler.
1334
1335         * Scripts/run-sunspider:
1336
1337 2013-01-16  Eric Seidel  <eric@webkit.org>
1338
1339         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
1340         https://bugs.webkit.org/show_bug.cgi?id=106036
1341
1342         Reviewed by Darin Adler.
1343
1344         * Scripts/webkitpy/webkitpy.pyproj: Removed.
1345         * Scripts/webkitpy/webkitpy.sln: Removed.
1346
1347 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
1348
1349         [Chromium] Remove hardcoded chromium_*.jar in gyp files
1350         https://bugs.webkit.org/show_bug.cgi?id=104049
1351
1352         Reviewed by Eric Seidel.
1353
1354         Targets with dependencies (direct/indirect) on a java target receive
1355         the chromium_*.jar paths in the variable input_jars_paths. Targets
1356         should use that rather than hardcoding where they think the jar will
1357         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
1358         than as --jars to generate_native_test.py.
1359
1360         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1361         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1362
1363 2013-01-16  Dan Carney  <dcarney@google.com>
1364
1365         [chromium] move setMockDeviceOrientation to TestRunner library
1366         https://bugs.webkit.org/show_bug.cgi?id=106895
1367
1368         Reviewed by Jochen Eisinger.
1369
1370         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1371         (DRTTestRunner::DRTTestRunner):
1372         * DumpRenderTree/chromium/DRTTestRunner.h:
1373         (DRTTestRunner):
1374         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1375         (WebKit):
1376         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
1377         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1378         (WebTestRunner::TestRunner::TestRunner):
1379         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1380         (WebTestRunner):
1381         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1382         (TestRunner):
1383         * DumpRenderTree/chromium/WebViewHost.cpp:
1384         (WebViewHost::setDeviceOrientation):
1385         * DumpRenderTree/chromium/WebViewHost.h:
1386         (WebViewHost):
1387
1388 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1389
1390         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1391         https://bugs.webkit.org/show_bug.cgi?id=106904
1392
1393         Reviewed by Adam Barth.
1394
1395         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1396         (DRTTestRunner::DRTTestRunner):
1397         (DRTTestRunner::notifyDone):
1398         (DRTTestRunner::reset):
1399         * DumpRenderTree/chromium/DRTTestRunner.h:
1400         (DRTTestRunner):
1401         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1402         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1403         (WebTestRunner::WebTestDelegate::setFocus):
1404         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1405         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1406         (WebTestRunner::WebTestDelegate::setLocale):
1407         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1408         (WebTestRunner::TestRunner::TestRunner):
1409         (WebTestRunner::TestRunner::reset):
1410         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1411         (WebTestRunner):
1412         (WebTestRunner::TestRunner::setWindowIsKey):
1413         (WebTestRunner::TestRunner::pathToLocalResource):
1414         (WebTestRunner::TestRunner::setBackingScaleFactor):
1415         (WebTestRunner::TestRunner::setPOSIXLocale):
1416         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1417         (WebTestRunner::TestRunner::taskList):
1418         (TestRunner):
1419         * DumpRenderTree/chromium/WebViewHost.cpp:
1420         (WebViewHost::setDeviceScaleFactor):
1421         (WebViewHost::setFocus):
1422         (WebViewHost::setAcceptAllCookies):
1423         (WebViewHost::pathToLocalResource):
1424         (WebViewHost::setLocale):
1425         * DumpRenderTree/chromium/WebViewHost.h:
1426         (WebViewHost):
1427
1428 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
1429
1430         [GTK] build-webkit fails if the jhbuild wrapper is not used
1431         https://bugs.webkit.org/show_bug.cgi?id=106769
1432
1433         Reviewed by Martin Robinson.
1434
1435         Return an empty array instead of "" in
1436         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
1437         will not be recognized as a valid command when the returned array
1438         is directly passed to perl's system() call.
1439
1440         * Scripts/webkitdirs.pm:
1441         (jhbuildWrapperPrefixIfNeeded):
1442
1443 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1444
1445         [chromium] add title text direction attribute to TestRunner
1446         https://bugs.webkit.org/show_bug.cgi?id=106907
1447
1448         Reviewed by Adam Barth.
1449
1450         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1451         (DRTTestRunner::DRTTestRunner):
1452         (DRTTestRunner::reset):
1453         * DumpRenderTree/chromium/DRTTestRunner.h:
1454         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1455         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1456         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1457         (WebTestRunner::TestRunner::TestRunner):
1458         (WebTestRunner::TestRunner::reset):
1459         (WebTestRunner::TestRunner::setTitleTextDirection):
1460         (WebTestRunner):
1461         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1462         (TestRunner):
1463         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1464         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1465         * DumpRenderTree/chromium/WebViewHost.cpp:
1466         (WebViewHost::didReceiveTitle):
1467
1468 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1469
1470         NRWT still confused about test count with --repeat-each and --iterations
1471         https://bugs.webkit.org/show_bug.cgi?id=106562
1472
1473         Reviewed by Dirk Pranke.
1474
1475         Fix the printed unique test count and skipped count. This
1476         seems to have broken in r127688 ("NRWT lies about the number
1477         of tests that it's skipping when used with --repeat-each").
1478
1479         Also add a test for print_found()
1480
1481         * Scripts/webkitpy/layout_tests/views/printing.py:
1482         (Printer.print_found):
1483         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1484         (Testprinter.test_details):
1485         (Testprinter):
1486         (Testprinter.test_found):
1487
1488 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1489
1490         Unreviewed follow-up to r139769.
1491
1492         Note that omitting the WebKit1 code from the build now
1493         works for GTK as well.
1494
1495         * Scripts/build-webkit:
1496
1497 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1498
1499         test-webkitpy: truncate output to the terminal width when necessary
1500         https://bugs.webkit.org/show_bug.cgi?id=106973
1501
1502         Reviewed by Ojan Vafai.
1503
1504         this implements the same logic for test-webkitpy that we have
1505         for run-webkit-tests (and ninja).
1506
1507         No tests written as this is exercised by running test-webkitpy itself.
1508
1509         * Scripts/webkitpy/test/printer.py:
1510         (Printer.configure):
1511         (Printer._test_line):
1512
1513 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1514
1515         remove extraneous output in test-webkitpy
1516         https://bugs.webkit.org/show_bug.cgi?id=106971
1517
1518         Reviewed by Ojan Vafai.
1519
1520         We weren't ignoring or capturing the echoed output from
1521         these two tests, and getting noise in the logs as a result.
1522
1523         * Scripts/webkitpy/common/system/executive_unittest.py:
1524         (ExecutiveTest.test_auto_stringify_args):
1525         (ExecutiveTest.test_popen_args):
1526
1527 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1528
1529         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
1530         https://bugs.webkit.org/show_bug.cgi?id=106974
1531
1532         Reviewed by Ryosuke Niwa.
1533
1534         I forgot to stub out the call to check to ensure that the ports were
1535         available, so this test could fail if something was listening on 8000 or
1536         8443 on the machine.
1537
1538         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1539         (TestHttpServer.test_win32_start_and_stop):
1540
1541 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1542
1543         Unreviewed, rolling out r139792.
1544         http://trac.webkit.org/changeset/139792
1545         https://bugs.webkit.org/show_bug.cgi?id=106970
1546
1547         Broke the windows build.
1548
1549         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1550         (DRTTestRunner::DRTTestRunner):
1551         (DRTTestRunner::notifyDone):
1552         (DRTTestRunner::reset):
1553         (DRTTestRunner::setAlwaysAcceptCookies):
1554         (DRTTestRunner::setWindowIsKey):
1555         (DRTTestRunner::pathToLocalResource):
1556         (DRTTestRunner::setPOSIXLocale):
1557         (InvokeCallbackTask):
1558         (InvokeCallbackTask::InvokeCallbackTask):
1559         (InvokeCallbackTask::runIfValid):
1560         (DRTTestRunner::setBackingScaleFactor):
1561         * DumpRenderTree/chromium/DRTTestRunner.h:
1562         (DRTTestRunner):
1563         (DRTTestRunner::taskList):
1564         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1565         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1566         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1567         (WebTestRunner::TestRunner::TestRunner):
1568         (WebTestRunner::TestRunner::reset):
1569         (WebTestRunner::TestRunner::setDatabaseQuota):
1570         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1571         (TestRunner):
1572         * DumpRenderTree/chromium/WebViewHost.cpp:
1573         (WebViewHost::setPendingExtraData):
1574         (WebViewHost::setDeviceScaleFactor):
1575         * DumpRenderTree/chromium/WebViewHost.h:
1576         (WebViewHost):
1577
1578 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
1579
1580         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
1581
1582         * Scripts/webkitpy/common/config/ports.py:
1583         (MacWK2Port):
1584
1585 2013-01-15  Alan Cutter  <alancutter@chromium.org>
1586
1587         Extend sheriffbot's "help" command to be able to get help on individual commands
1588         https://bugs.webkit.org/show_bug.cgi?id=106629
1589
1590         Reviewed by Eric Seidel.
1591
1592         Added a help command to sheriffbot.
1593         Fixed some style issues and ordered the commands alphabetically.
1594
1595         * Scripts/webkitpy/tool/bot/irc_command.py:
1596         (IRCCommand):
1597         (IRCCommand.execute):
1598         (IRCCommand.usage):
1599         (IRCCommand.help):
1600         (CreateBug):
1601         (CreateBug.execute):
1602         (Help):
1603         (Help.execute):
1604         (Help._post_command_help):
1605         (Hi):
1606         (Hi.execute):
1607         (Restart):
1608         (RollChromiumDEPS):
1609         (RollChromiumDEPS._parse_args):
1610         (RollChromiumDEPS._expand_irc_nickname):
1611         (RollChromiumDEPS.execute):
1612         (Rollout):
1613         (Rollout._extract_revisions):
1614         (Rollout.execute):
1615         (Sheriffs):
1616         (Sheriffs.execute):
1617         (Whois):
1618         (Whois.execute):
1619         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1620         (IRCBotTest.test_help):
1621
1622 2013-01-15  Enrica Casucci  <enrica@apple.com>
1623
1624         Add a new set of WebKit2 APIs for text search and
1625         search results management.
1626         https://bugs.webkit.org/show_bug.cgi?id=106834.
1627         <rdar://problem/12597159>
1628
1629         Added new test for the new WebKit2 API for
1630         text search.
1631         
1632         Reviewed by Simon Fraser.
1633
1634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1635         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
1636
1637 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1638
1639         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1640         https://bugs.webkit.org/show_bug.cgi?id=106904
1641
1642         Reverting 139794. It broke the build. It appears that a header file,
1643         WebTextDirection.h, was left out.
1644
1645         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1646         (DRTTestRunner::DRTTestRunner):
1647         (DRTTestRunner::reset):
1648         * DumpRenderTree/chromium/DRTTestRunner.h:
1649         (DRTTestRunner::setTitleTextDirection):
1650         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1651         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1652         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1653         (WebTestRunner::TestRunner::TestRunner):
1654         (WebTestRunner::TestRunner::reset):
1655         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1656         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1657         (TestRunner):
1658         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1659         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1660         * DumpRenderTree/chromium/WebViewHost.cpp:
1661         (WebViewHost::didReceiveTitle):
1662
1663 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1664
1665         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1666         https://bugs.webkit.org/show_bug.cgi?id=106904
1667
1668         Reviewed by Adam Barth.
1669
1670         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1671         (DRTTestRunner::DRTTestRunner):
1672         (DRTTestRunner::notifyDone):
1673         (DRTTestRunner::reset):
1674         * DumpRenderTree/chromium/DRTTestRunner.h:
1675         (DRTTestRunner):
1676         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1677         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1678         (WebTestRunner::WebTestDelegate::setFocus):
1679         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1680         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1681         (WebTestRunner::WebTestDelegate::setLocale):
1682         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1683         (WebTestRunner::TestRunner::TestRunner):
1684         (WebTestRunner::TestRunner::reset):
1685         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1686         (WebTestRunner):
1687         (WebTestRunner::TestRunner::setWindowIsKey):
1688         (WebTestRunner::TestRunner::pathToLocalResource):
1689         (WebTestRunner::TestRunner::setBackingScaleFactor):
1690         (WebTestRunner::TestRunner::setPOSIXLocale):
1691         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1692         (WebTestRunner::TestRunner::taskList):
1693         (TestRunner):
1694         * DumpRenderTree/chromium/WebViewHost.cpp:
1695         (WebViewHost::setDeviceScaleFactor):
1696         (WebViewHost::setFocus):
1697         (WebViewHost::setAcceptAllCookies):
1698         (WebViewHost::pathToLocalResource):
1699         (WebViewHost::setLocale):
1700         * DumpRenderTree/chromium/WebViewHost.h:
1701         (WebViewHost):
1702
1703 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1704
1705         Tests with WontFix expectation are (indirectly) skipped
1706         https://bugs.webkit.org/show_bug.cgi?id=105860
1707
1708         Reviewed by Dirk Pranke.
1709
1710         Only skip the WontFix expectation if there are no other layout test
1711         expectations (like Failure, ImageOnlyFailure) listed for the test.
1712         This makes it possible to run an expected failure for which there
1713         is no reason or interest to fix. There are some ports that would like
1714         to exercise this behavior as well as specific test cases that should use
1715         such expectations.
1716
1717         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1718         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
1719         WONTFIX test if there are no expectations listed. The warning is adjusted
1720         to reflect the new behavior.
1721         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
1722         and adjust test cases for these changes.
1723         (ExpectationSyntaxTests.test_wontfix):
1724         (SemanticTests.test_skip_and_wontfix):
1725
1726 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1727
1728         [chromium] add title text direction attribute to TestRunner
1729         https://bugs.webkit.org/show_bug.cgi?id=106907
1730
1731         Reviewed by Adam Barth.
1732
1733         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1734         (DRTTestRunner::DRTTestRunner):
1735         (DRTTestRunner::reset):
1736         * DumpRenderTree/chromium/DRTTestRunner.h:
1737         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1738         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1739         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1740         (WebTestRunner::TestRunner::TestRunner):
1741         (WebTestRunner::TestRunner::reset):
1742         (WebTestRunner::TestRunner::setTitleTextDirection):
1743         (WebTestRunner):
1744         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1745         (TestRunner):
1746         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1747         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1748         * DumpRenderTree/chromium/WebViewHost.cpp:
1749         (WebViewHost::didReceiveTitle):
1750
1751 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1752
1753         nrwt: change the default # of locked shards on chromium_win to 1
1754         https://bugs.webkit.org/show_bug.cgi?id=106938
1755
1756         Reviewed by Eric Seidel.
1757
1758         It looks like LigHTTPd might be buggy or unstable if we are
1759         running multiple http tests in parallel; see
1760         http://code.google.com/p/chromium/issues/detail?id=169530 for more
1761         context as well. This change will stop running http tests in parallel
1762         and we can see if this fixes things.
1763
1764         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1765         (ChromiumWinPort.default_max_locked_shards):
1766         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1767         (ChromiumWinTest.test_path_to_image_diff):
1768         (ChromiumWinTest):
1769         (ChromiumWinTest.test_default_max_locked_shards):
1770
1771 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1772
1773         [chromium] move WebDatabase related methods to TestRunner library
1774         https://bugs.webkit.org/show_bug.cgi?id=106905
1775
1776         Reviewed by Adam Barth.
1777
1778         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1779         (DRTTestRunner::DRTTestRunner):
1780         (DRTTestRunner::reset):
1781         * DumpRenderTree/chromium/DRTTestRunner.h:
1782         (DRTTestRunner):
1783         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1784         (WebTestRunner::WebTestDelegate::clearAllDatabases):
1785         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1786         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1787         (WebTestRunner::TestRunner::TestRunner):
1788         (WebTestRunner::TestRunner::reset):
1789         (WebTestRunner::TestRunner::clearAllDatabases):
1790         (WebTestRunner):
1791         (WebTestRunner::TestRunner::setDatabaseQuota):
1792         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1793         (TestRunner):
1794         * DumpRenderTree/chromium/WebViewHost.cpp:
1795         (WebViewHost::clearAllDatabases):
1796         (WebViewHost::setDatabaseQuota):
1797         * DumpRenderTree/chromium/WebViewHost.h:
1798         (WebViewHost):
1799
1800 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
1801
1802         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
1803         functionality match the name.
1804         https://bugs.webkit.org/show_bug.cgi?id=106870
1805
1806         Reviewed by Adam Barth.
1807
1808         * Scripts/webkitpy/tool/commands/download.py:
1809         (Clean):
1810         (Update):
1811         (Build):
1812         (BuildAndTest):
1813         (CheckStyle):
1814         (BuildAttachment):
1815         (BuildAndTestAttachment):
1816         (AbstractPatchApplyingCommand):
1817         (ApplyWatchList):
1818         (AbstractPatchLandingCommand):
1819         (CreateRollout):
1820         * Scripts/webkitpy/tool/steps/__init__.py:
1821         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1822         (CleanWorkingDirectory.options):
1823         (CleanWorkingDirectory.run):
1824         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1825         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1826         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
1827
1828 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1829
1830         [Autotools] Add support for WebKit2-only builds
1831         https://bugs.webkit.org/show_bug.cgi?id=106889
1832
1833         Reviewed by Gustavo Noronha Silva.
1834
1835         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
1836         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
1837         building the GTK port through build-webkit.
1838         * Scripts/webkitdirs.pm:
1839         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
1840         arguments when not building WebKit1.
1841         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
1842         through the Autotools build system.
1843
1844 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1845
1846         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
1847         https://bugs.webkit.org/show_bug.cgi?id=106197
1848
1849         Reviewed by Martin Robinson.
1850
1851         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
1852         features. Enable them on GTK, meaning they will be enabled in development builds
1853         (i.e. when building with build-webkit).
1854
1855 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1856
1857         [GTK] Enable CSS Image Resolution feature
1858         https://bugs.webkit.org/show_bug.cgi?id=99038
1859
1860         Reviewed by Gustavo Noronha Silva.
1861
1862         Enable the CSS Image Resolution feature for the development
1863         builds of the GTK port.
1864
1865         * Scripts/webkitperl/FeatureList.pm:
1866
1867 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1868
1869         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
1870         https://bugs.webkit.org/show_bug.cgi?id=106579
1871
1872         Reviewed by Gustavo Noronha Silva.
1873
1874         The --enable-unstable-features flag is not required to be passed anymore
1875         to the configure script as it was removed in r138252.
1876
1877         * Scripts/webkitdirs.pm:
1878         (buildAutotoolsProject):
1879
1880 2013-01-15  Tony Chang  <tony@chromium.org>
1881
1882         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
1883
1884         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1885         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
1886         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1887         (TestHttpServer.test_win32_start_and_stop):
1888
1889 2013-01-15  Joshua Bell  <jsbell@chromium.org>
1890
1891         Unreviewed. Adding Michael Pruett as contributor.
1892
1893         * Scripts/webkitpy/common/config/committers.py:
1894
1895 2013-01-15  Victor Carbune  <victor@rosedu.org>
1896
1897         Unreviewed. Update my email addresses.
1898
1899         * Scripts/webkitpy/common/config/committers.py:
1900
1901 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1902
1903         [GTK] Waiting on the gdb process will lead to deadlock
1904         https://bugs.webkit.org/show_bug.cgi?id=106906
1905
1906         Reviewed by Philippe Normand.
1907
1908         Use communicate() rather than wait() on the Popen object that's running the gdb
1909         command. This avoids the deadlock that occurs on the GTK builders.
1910
1911         * Scripts/webkitpy/layout_tests/port/gtk.py:
1912         (GtkPort._get_gdb_output):
1913
1914 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1915
1916         [GTK] Limit the number of frames printed out when backtracing with gdb
1917         https://bugs.webkit.org/show_bug.cgi?id=106901
1918
1919         Reviewed by Philippe Normand.
1920
1921         Printing an unlimited number of frames when dumping the gdb backtracing
1922         output can cause timeouts in the builders. This patch limits the number
1923         of frames that are printed out to 1024.
1924
1925         * Scripts/webkitpy/layout_tests/port/gtk.py:
1926         (GtkPort._get_gdb_output):
1927
1928 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
1929
1930         [Qt] Fix ImageDiff's image format conversion
1931         https://bugs.webkit.org/show_bug.cgi?id=106880
1932
1933         Reviewed by Csaba Osztrogonác.
1934
1935         Besides actually doing the conversion this also silences the suspicious warning:
1936         "ignoring return value of function declared with warn_unused_result attribute".
1937
1938         * ImageDiff/qt/ImageDiff.cpp:
1939         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
1940         copy of the image in the given format and does not alter the image itself.
1941
1942 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1943
1944         [chromium] move remaining methods that just set a boolean flag to TestRunner library
1945         https://bugs.webkit.org/show_bug.cgi?id=106823
1946
1947         Reviewed by Darin Fisher.
1948
1949         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1950         (DRTTestRunner::DRTTestRunner):
1951         (DRTTestRunner::reset):
1952         * DumpRenderTree/chromium/DRTTestRunner.h:
1953         (DRTTestRunner):
1954         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1955         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
1956         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
1957         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
1958         (WebTestRunner::WebTestRunner::testRepaint):
1959         (WebTestRunner::WebTestRunner::sweepHorizontally):
1960         (WebTestRunner::WebTestRunner::isPrinting):
1961         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1962         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1963         (WebTestRunner::TestRunner::TestRunner):
1964         (WebTestRunner::TestRunner::reset):
1965         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
1966         (WebTestRunner):
1967         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
1968         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
1969         (WebTestRunner::TestRunner::testRepaint):
1970         (WebTestRunner::TestRunner::sweepHorizontally):
1971         (WebTestRunner::TestRunner::isPrinting):
1972         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1973         (WebTestRunner::TestRunner::dumpBackForwardList):
1974         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
1975         (WebTestRunner::TestRunner::dumpSelectionRect):
1976         (WebTestRunner::TestRunner::repaintSweepHorizontally):
1977         (WebTestRunner::TestRunner::setPrinting):
1978         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
1979         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1980         (TestRunner):
1981
1982 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1983
1984         nrwt: stub out show_results_html for mock ports
1985         https://bugs.webkit.org/show_bug.cgi?id=106848
1986
1987         Reviewed by Ojan Vafai.
1988
1989         We were accidentally using the underlying ports'
1990         show_results_html_file() implementation, which would, unsurprisingly,
1991         fail in many cases (e.g., running mock-efl on the mac).
1992
1993         No test added since we don't generally add tests for the mock
1994         implementation.
1995
1996         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1997         (MockDRTPort.show_results_html_file):
1998
1999 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2000
2001         Changing clean_working_directory/clean_local_commits and related
2002         functions to have consistent naming.
2003
2004         https://bugs.webkit.org/show_bug.cgi?id=104198
2005
2006         Reviewed by Adam Barth.
2007
2008         * Scripts/webkitpy/common/checkout/scm/git.py:
2009         * Scripts/webkitpy/common/checkout/scm/scm.py:
2010         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2011         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2012         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2013         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2014
2015 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2016
2017         Fix EWS GCE build scripts to detect which zone is available
2018         https://bugs.webkit.org/show_bug.cgi?id=106524
2019
2020         Reviewed by Adam Barth.
2021
2022         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2023         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2024         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2025         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
2026
2027 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2028
2029         Adding an error string to AmbiguousCommitError.
2030         https://bugs.webkit.org/show_bug.cgi?id=106846
2031
2032         Reviewed by Adam Barth.
2033
2034         * Scripts/webkitpy/common/checkout/scm/git.py:
2035         (AmbiguousCommitError.__init__):
2036
2037 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2038
2039         kill whole lighttpd process tree for chromium win
2040         https://bugs.webkit.org/show_bug.cgi?id=106838
2041
2042         Reviewed by Tony Chang.
2043
2044         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
2045         I think a test is causing a httpd server child process to wedge and
2046         killing the parent httpd server process isn't sufficient to ensure
2047         that the children are also killed.
2048
2049         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2050         (Lighttpd._check_and_kill):
2051         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2052         (TestHttpServer.test_start_cmd):
2053         (TestHttpServer):
2054         (TestHttpServer.test_win32_start_and_stop):
2055         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
2056         (TestHttpServer.test_win32_start_and_stop.mock_returns):
2057         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
2058
2059 2013-01-14  Nico Weber  <thakis@chromium.org>
2060
2061         [chromium] Enable `update-webkit --chromium --ninja` on windows
2062         https://bugs.webkit.org/show_bug.cgi?id=106836
2063
2064         Reviewed by Eric Seidel.
2065
2066         After running this, build-webkit --chromium will use ninja to build.
2067         Apparently there are some minor issues with that still, so it's
2068         not quite ready for use yet.
2069
2070         * Scripts/webkitdirs.pm:
2071         (determineIsChromiumNinja):
2072         (buildChromium):
2073
2074 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2075
2076         nrwt: use the same search path for baselines and TestExpectations on apple mac
2077         https://bugs.webkit.org/show_bug.cgi?id=105599
2078
2079         Reviewed by Ryosuke Niwa.
2080
2081         Bug 105583 revealed some confusion due to the fact that the Apple
2082         Mac port used a different list of directories to search for baselines
2083         and TestExpectations files (actually, pretty much every port does).
2084
2085         It seems like a good idea to use the same list for both by default, but
2086         making this happen will affect every port in slightly different ways, so
2087         we'll try this on the Apple Mac port first.
2088
2089         Note that the effective changes for this are that:
2090         1) The apple mac port will look in platform/wk2 for baselines where
2091         it didn't before (it will look after looking in mac-wk2 but before
2092         the non-wk2 dirs)
2093         2) The apple mac-snowleopard port will use the expectations in
2094         mac-lion as well as the expectations in mac-snowleopard, although
2095         I'm not even sure if mac-snowleopard is still supported ...
2096
2097         * Scripts/webkitpy/layout_tests/port/mac.py:
2098         (MacPort.default_baseline_search_path):
2099         (MacPort.expectations_files):
2100         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2101         (test_baseline_search_path):
2102
2103 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2104
2105         AX: Need to implement ColorWellRole
2106         https://bugs.webkit.org/show_bug.cgi?id=106756
2107
2108         Reviewed by Chris Fleizach.
2109
2110         Returns a string representation of the value of a color
2111         when the role is Color Well, to make it easy to write layout
2112         tests for color controls.
2113
2114         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2115
2116 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2117
2118         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
2119         https://bugs.webkit.org/show_bug.cgi?id=106682
2120
2121         Reviewed by Chris Fleizach.
2122
2123         Modify Chromium's DRT implementation of intValue to return a
2124         different value depending on the role.
2125
2126         There are actually platform-specific differences in what should
2127         be returned in the "value" of an object, so Chromium normally keeps
2128         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
2129         but this is a fine simplification to make cross-platform tests easier.
2130
2131         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2132         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
2133
2134 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
2135
2136         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
2137         https://bugs.webkit.org/show_bug.cgi?id=106785
2138
2139         Reviewed by Adam Barth.
2140
2141         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2142         (DRTTestRunner::DRTTestRunner):
2143         (DRTTestRunner::reset):
2144         * DumpRenderTree/chromium/DRTTestRunner.h:
2145         (DRTTestRunner):
2146         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2147         (WebTestProxyBase):
2148         (WebTestRunner::WebTestProxy::setStatusText):
2149         (WebTestRunner::WebTestProxy::didStopLoading):
2150         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2151         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
2152         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
2153         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2154         (WebTestRunner::TestRunner::TestRunner):
2155         (WebTestRunner::TestRunner::reset):
2156         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
2157         (WebTestRunner):
2158         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
2159         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
2160         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
2161         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2162         (TestRunner):
2163         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2164         (WebTestRunner::WebTestProxyBase::setStatusText):
2165         (WebTestRunner):
2166         (WebTestRunner::WebTestProxyBase::didStopLoading):
2167         * DumpRenderTree/chromium/WebViewHost.cpp:
2168         (WebViewHost::didStopLoading):
2169         * DumpRenderTree/chromium/WebViewHost.h:
2170         (WebViewHost):
2171
2172 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2173
2174         Web Inspector: devtools front-end doesn't have focus in TestShell
2175         https://bugs.webkit.org/show_bug.cgi?id=106778
2176
2177         Reviewed by Pavel Feldman.
2178
2179         Focus devTools window after loadURL method.
2180
2181         * DumpRenderTree/chromium/TestShell.cpp:
2182         (TestShell::runFileTest):
2183
2184 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2185
2186         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
2187         https://bugs.webkit.org/show_bug.cgi?id=106573
2188
2189         Reviewed by Philippe Normand.
2190
2191         Similarly to what's been described in bug 106569, we're building
2192         from release tarballs, so there's no reason to regenerate the
2193         autoconf-related stuff with autogen.sh, especially since we might
2194         run into trouble with automake 1.13 and deprecated macros.
2195
2196         * efl/jhbuild.modules:
2197
2198 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2199
2200         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
2201         https://bugs.webkit.org/show_bug.cgi?id=104909
2202
2203         Reviewed by Simon Hausmann.
2204
2205         To be able to build redistribuable binary packages, Qt's configure switches
2206         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
2207         dynamically link to optional system libraries.
2208         QtWebKit is doing its own configure checks for those libraries, thus adding a
2209         runtime dependency that might not be fulfilled if the packager's machine had
2210         those libraries while the user's machine won't.
2211
2212         Since in most cases where WebKit will want to use those system libraries, Qt will
2213         also be using them, remove these configure tests from WebKit.
2214
2215         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
2216         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
2217         * qmake/config.tests/libpng/libpng.cpp: Removed.
2218         * qmake/config.tests/libpng/libpng.pro: Removed.
2219         * qmake/mkspecs/features/features.prf:
2220
2221 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2222
2223         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
2224         https://bugs.webkit.org/show_bug.cgi?id=106574
2225
2226         Reviewed by Laszlo Gombos.
2227
2228         Rely on a more recent stable release, which includes support for
2229         Lua 5.2 in Edje and other assorted minor fixes.
2230
2231         While here, also use the "configure" script to build the libraries
2232         instead of relying on autogen.sh, which is not really needed with
2233         a release tarball and may have problems with automake 1.13.
2234
2235         * efl/jhbuild.modules:
2236
2237 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2238
2239         Web Inspector: fix DRT to deliver simulated events to devtools front-end
2240         https://bugs.webkit.org/show_bug.cgi?id=106650
2241
2242         Reviewed by Pavel Feldman.
2243
2244         Add separated m_devToolsTestInterfaces object to testShell which is
2245         bind to devTools webview.
2246
2247         * DumpRenderTree/chromium/TestShell.cpp:
2248         (TestShell::initialize):
2249         (TestShell::createMainWindow):
2250         (TestShell::~TestShell):
2251         (TestShell::showDevTools):
2252         (TestShell::resetTestController):
2253         (TestShell::bindJSObjectsToWindow):
2254         (TestShell::createNewWindow):
2255         * DumpRenderTree/chromium/TestShell.h:
2256         (TestShell):
2257
2258 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2259
2260         Sheriffbot command aliases need test cases
2261         https://bugs.webkit.org/show_bug.cgi?id=106754
2262
2263         Reviewed by Eric Seidel.
2264
2265         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2266         (SheriffBotTest.test_command_aliases):
2267
2268 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2269
2270         Allow users to misspell the "sheriffs" command in sheriffbot
2271         https://bugs.webkit.org/show_bug.cgi?id=106628
2272
2273         Reviewed by Steve Block.
2274
2275         * Scripts/webkitpy/tool/bot/irc_command.py:
2276
2277 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2278
2279         Make "gardeners" an alias for "sheriffs" in sherrifbot
2280         https://bugs.webkit.org/show_bug.cgi?id=106627
2281
2282         Reviewed by Eric Seidel.
2283
2284         * Scripts/webkitpy/tool/bot/irc_command.py:
2285
2286 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2287
2288         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2289         https://bugs.webkit.org/show_bug.cgi?id=105380
2290
2291         Reviewed by Eric Seidel.
2292
2293         Fix a regression introduced in r137692 where we were double-encoding
2294         the arguments to popen(); this was only an issue on windows, where
2295         we would try to encode something to mbcs, then try to encode it
2296         to unicode as if the input as ascii.
2297
2298         * Scripts/webkitpy/common/system/executive.py:
2299         (Executive.run_command):
2300
2301 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2302
2303         State who told sheriffbot to roll the Chromium deps and to what revision
2304         https://bugs.webkit.org/show_bug.cgi?id=106626
2305
2306         Reviewed by Eric Seidel.
2307
2308         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2309
2310         * Scripts/webkitpy/tool/bot/irc_command.py:
2311         (RollChromiumDEPS._expand_irc_nickname):
2312         (RollChromiumDEPS.execute):
2313         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2314         (IRCCommandTest.test_roll_chromium_deps):
2315         * Scripts/webkitpy/tool/bot/sheriff.py:
2316         (Sheriff.post_chromium_deps_roll):
2317         * Scripts/webkitpy/tool/commands/roll.py:
2318         (RollChromiumDEPS._prepare_state):
2319         (PostChromiumDEPSRoll):
2320         (PostChromiumDEPSRoll._prepare_state):
2321         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2322         (PostRollCommandsTest.test_prepare_state):
2323         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2324         (PrepareChangeLogForDEPSRoll.run):
2325
2326 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2327
2328         Add Alan Cutter as contributor
2329         https://bugs.webkit.org/show_bug.cgi?id=106747
2330
2331         Reviewed by Eric Seidel.
2332
2333         * Scripts/webkitpy/common/config/committers.py:
2334
2335 2013-01-13  Jonathan Liu  <net147@gmail.com>
2336
2337         Fix CONFIG missing link_pkgconfig on Windows
2338         https://bugs.webkit.org/show_bug.cgi?id=106647
2339
2340         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
2341         properly on Windows because they are added to PKGCONFIG but
2342         CONFIG does not contain link_pkgconfig.
2343
2344         This is because link_pkgconfig is added in unix/default_pre.prf
2345         which is only used for UNIX platforms. To fix this, move it to
2346         the general default_pre.prf.
2347
2348         Reviewed by Simon Hausmann.
2349
2350         * qmake/mkspecs/features/default_pre.prf:
2351         * qmake/mkspecs/features/unix/default_pre.prf:
2352
2353 2013-01-12  Nico Weber  <thakis@chromium.org>
2354
2355         nrwt/chromium: Don't prefer chromium over webkit build directories
2356         https://bugs.webkit.org/show_bug.cgi?id=105597
2357
2358         Reviewed by Dirk Pranke.
2359
2360         Rely on the new timestamp logic instead. Requested by dpranke in
2361         https://bugs.webkit.org/show_bug.cgi?id=105498
2362
2363         * Scripts/webkitpy/layout_tests/port/chromium.py:
2364         (ChromiumPort._static_build_path):
2365         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2366         (ChromiumLinuxPortTest.test_build_path):
2367         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2368         (ChromiumMacPortTest.test_build_path):
2369         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2370         (ChromiumWinTest.test_build_path):
2371
2372 2013-01-12  Nico Weber  <thakis@chromium.org>
2373
2374         Use ninja by default on Linux for build-webkit --chromium, bot edition
2375         https://bugs.webkit.org/show_bug.cgi?id=104434
2376
2377         Reviewed by Eric Seidel.
2378
2379         r139557 changed update-webkit to pick ninja by default on linux, but
2380         the bots run update-webkit-chromium directly so they didn't see this.
2381         Move the default for ninja into update-webkit-chromium so that it's
2382         picked up by the bots, and let update-webkit forward non-default
2383         options to there.
2384
2385         This way, the default is in one place only and both developers (who
2386         usually use update-webkit which then shells out to
2387         updat-webkit-chromium) and bots (which use update-webkit-chromium
2388         directly) see the same behavior.
2389
2390         * Scripts/update-webkit:
2391         * Scripts/update-webkit-chromium:
2392
2393 2013-01-12  Nico Weber  <thakis@chromium.org>
2394
2395         Make ninja the default build system on Linux for build-webkit --chromium
2396         https://bugs.webkit.org/show_bug.cgi?id=104434
2397
2398         Reviewed by Eric Seidel.
2399
2400         * Scripts/update-webkit:
2401
2402 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2403
2404         Migrate the remaining bots in EC2 to Google Compute Engine
2405         https://bugs.webkit.org/show_bug.cgi?id=106005
2406
2407         Reviewed by Eric Seidel.
2408
2409         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
2410
2411         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
2412         * EWSTools/boot.sh:
2413         * EWSTools/build-repo.sh:
2414         * EWSTools/start-queue.sh:
2415
2416 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
2417
2418         [chromium] move inspector related methods to TestRunner library
2419         https://bugs.webkit.org/show_bug.cgi?id=106654
2420
2421         Reviewed by Adam Barth.
2422
2423         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2424         (DRTTestRunner::DRTTestRunner):
2425         * DumpRenderTree/chromium/DRTTestRunner.h:
2426         (DRTTestRunner):
2427         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2428         (WebTestRunner::WebTestDelegate::showDevTools):
2429         (WebTestRunner::WebTestDelegate::closeDevTools):
2430         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
2431         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2432         (WebTestRunner::TestRunner::TestRunner):
2433         (WebTestRunner::TestRunner::showWebInspector):
2434         (WebTestRunner):
2435         (WebTestRunner::TestRunner::closeWebInspector):
2436         (WebTestRunner::TestRunner::evaluateInWebInspector):
2437         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2438         (TestRunner):
2439         * DumpRenderTree/chromium/WebViewHost.cpp:
2440         (WebViewHost::showDevTools):
2441         (WebViewHost::closeDevTools):
2442         (WebViewHost::evaluateInWebInspector):
2443         * DumpRenderTree/chromium/WebViewHost.h:
2444         (WebViewHost):
2445
2446 2013-01-11  Julie Parent  <jparent@chromium.org>
2447
2448         Builder should not be a valid parameter for stats dashboard
2449         https://bugs.webkit.org/show_bug.cgi?id=106698
2450
2451         Reviewed by Dirk Pranke.
2452         
2453         Since builder is a dashboard specific parameter, dashboard_base
2454         should not be handling it in handleValidHashParameterWrapper, rather,
2455         each specific dashboard should in its handleValidHashParameter function.
2456     
2457         Note that the FIXME in dashboard_base about this was actually wrong -
2458         we don't want to move it to g_crossDashboardState, because it isn't
2459         actually cross dashboard state.
2460         
2461         In fact, flakiness and treemap have the code in 
2462         handleValidHashParameter, but it is currently dead code because 
2463         dashboard_base gets to it first.
2464         
2465         Added the proper handling to timeline_explorer, since builder is
2466         valid there.
2467
2468         * TestResultServer/static-dashboards/dashboard_base.js:
2469         * TestResultServer/static-dashboards/timeline_explorer.html:
2470
2471 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2472
2473         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
2474         https://bugs.webkit.org/show_bug.cgi?id=106688
2475
2476         Reviewed by Eric Seidel.
2477
2478         Update the regular expression used to strip the garbage at the beginning.
2479
2480         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2481         (RunWebKitTests.nrwt_log_message_regexp):
2482
2483 2013-01-11  Pratik Solanki  <psolanki@apple.com>
2484
2485         TestRunner leaks when running tests
2486         https://bugs.webkit.org/show_bug.cgi?id=106683
2487
2488         Reviewed by Simon Fraser.
2489
2490         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
2491         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
2492         tests.
2493
2494         * DumpRenderTree/TestRunner.cpp:
2495         (TestRunner::makeWindowObject):
2496
2497 2013-01-11  Julie Parent  <jparent@chromium.org>
2498
2499         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
2500         https://bugs.webkit.org/show_bug.cgi?id=106247
2501
2502         Old code nulled out the loader instance when it completed loading and
2503         then later used the fact that it was null to determine if it had loaded
2504         or not.  This is not only unintuitive, but it also prevents using the
2505         loader object later on.
2506         
2507         Added new method, used it, added unit test for it.
2508         
2509         Reviewed by Dirk Pranke.
2510
2511         * TestResultServer/static-dashboards/dashboard_base.js:
2512         (resourceLoadingComplete):
2513         (handleLocationChange):
2514         * TestResultServer/static-dashboards/loader.js:
2515         (.):
2516         * TestResultServer/static-dashboards/loader_unittests.js:
2517
2518 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2519
2520         Try CRLF to LF change in r139407 again.
2521
2522         * BuildSlaveSupport/delete-stale-build-files:
2523         (main):
2524         (webkitBuildDirectory):
2525         * BuildSlaveSupport/kill-old-processes:
2526         (main):
2527
2528 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2529
2530         [GTK] Disable the unit tests timeout when running from make check
2531         https://bugs.webkit.org/show_bug.cgi?id=106670
2532
2533         Reviewed by Philippe Normand.
2534
2535         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
2536
2537 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2538
2539         Yet another unreviewed fix after r139431.
2540
2541         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
2542         the correct order.
2543
2544 2013-01-11  Dan Carney  <dcarney@google.com>
2545
2546         [chromium] move some whitespace and resize related methods to TestRunner library
2547         https://bugs.webkit.org/show_bug.cgi?id=106655
2548
2549         Reviewed by Jochen Eisinger.
2550
2551         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2552         (DRTTestRunner::DRTTestRunner):
2553         * DumpRenderTree/chromium/DRTTestRunner.h:
2554         (DRTTestRunner):
2555         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2556         (WebKit):
2557         (WebTestRunner::WebTestDelegate::setClientWindowRect):
2558         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
2559         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
2560         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2561         (WebTestRunner::TestRunner::TestRunner):
2562         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
2563         (WebTestRunner):
2564         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
2565         (WebTestRunner::TestRunner::enableAutoResizeMode):
2566         (WebTestRunner::TestRunner::disableAutoResizeMode):
2567         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2568         (TestRunner):
2569         * DumpRenderTree/chromium/WebViewHost.cpp:
2570         (WebViewHost::setClientWindowRect):
2571         * DumpRenderTree/chromium/WebViewHost.h:
2572         (WebViewHost):
2573
2574 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2575
2576         Unreviewed. Update my e-mail addresses.
2577
2578         * Scripts/webkitpy/common/config/committers.py:
2579
2580 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2581
2582         Another unreviewed fix after r139431.
2583
2584         In a way, this is also a generic bug fix, since previously isEfl()
2585         would fail when called from run-efl-tests and we thus did not use
2586         jhbuild to run our tests. This now resulted in us calling
2587         "jhbuild-wrapper run" without specifying a platform.
2588
2589         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
2590         to work.
2591
2592 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2593
2594         [Qt][WK1] Web Audio support
2595         https://bugs.webkit.org/show_bug.cgi?id=106651
2596
2597         Reviewed by Jocelyn Turcotte.
2598
2599         Implements support for dumping audio data in DumpRenderTree.
2600
2601         Adds WebAudio to toggleable features in QtTestBrowser.
2602
2603         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
2604         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
2605
2606         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2607         (WebCore::DumpRenderTree::dump):
2608         * DumpRenderTree/qt/TestRunnerQt.cpp:
2609         (TestRunner::reset):
2610         (TestRunner::overridePreference):
2611         (TestRunner::setAudioData):
2612         * DumpRenderTree/qt/TestRunnerQt.h:
2613         (TestRunner::shouldDumpAsAudio):
2614         (TestRunner::audioData):
2615         (TestRunner):
2616         * QtTestBrowser/launcherwindow.cpp:
2617         (LauncherWindow::applyPrefs):
2618         (LauncherWindow::createChrome):
2619         (LauncherWindow::toggleWebAudio):
2620         * QtTestBrowser/launcherwindow.h:
2621         (WindowOptions::WindowOptions):
2622         (WindowOptions):
2623         (LauncherWindow):
2624         * qmake/mkspecs/features/features.prf:
2625         * qmake/mkspecs/features/features.pri:
2626
2627 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2628
2629         Unreviewed jhbuild-related fix after r139431.
2630
2631         * Scripts/webkitpy/layout_tests/port/efl.py:
2632         (EflPort.__init__): Pass a string to set_option_default(), since
2633         shlex.split() will be called on it later.
2634
2635 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2636
2637         Unreviewed typo fixes after r139431.
2638
2639         * Scripts/run-javascriptcore-tests:
2640
2641 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2642
2643         [jhbuild] Remove the "run-with-jhbuild" scripts.
2644         https://bugs.webkit.org/show_bug.cgi?id=106572
2645
2646         Reviewed by Martin Robinson.
2647
2648         Both ports which use jhbuild were mostly duplicating the
2649         `run-with-jhbuild' script in their own directories for no clear reason.
2650
2651         The script itself was just a thin wrapper around the `jhbuild-wrapper',
2652         so just start using that directly and get rid of a useless middle man.
2653
2654         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
2655         instead.
2656
2657         * Scripts/run-javascriptcore-tests:
2658         * Scripts/run-launcher:
2659         * Scripts/webkitdirs.pm:
2660         (runAutogenForAutotoolsProjectIfNecessary):
2661         (buildAutotoolsProject):
2662         (jhbuildWrapperPrefixIfNeeded):
2663         (generateBuildSystemFromCMakeProject):
2664         (buildCMakeGeneratedProject):
2665         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2666         (run):
2667         * Scripts/webkitpy/layout_tests/port/efl.py:
2668         (EflPort.__init__):
2669         (EflPort._image_diff_command):
2670         * efl/run-with-jhbuild: Removed.
2671         * gtk/run-with-jhbuild: Removed.
2672
2673 2013-01-11  Alan Cutter  <alancutter@chromium.org>
2674
2675         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
2676         https://bugs.webkit.org/show_bug.cgi?id=106636
2677
2678         Reviewed by Adam Barth.
2679
2680         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
2681
2682         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2683         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2684         * EWSTools/screen-config:
2685         * EWSTools/start-queue.sh:
2686
2687 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2688
2689         kill-old-processes and delete-stale-build-files use CRLF linebreaks
2690         https://bugs.webkit.org/show_bug.cgi?id=106622
2691
2692         Reviewed by Simon Fraser.
2693
2694         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
2695         Also escape clang\+\+ correctly in kill-old-processes.
2696
2697         * BuildSlaveSupport/delete-stale-build-files:
2698         * BuildSlaveSupport/kill-old-processes:
2699
2700 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2701
2702         Build fix after r139357. It was missing a comma.
2703
2704         * QueueStatusServer/model/queues.py:
2705         (Queue):
2706
2707 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2708
2709         Fixing AuthenticationError when running test-webkitpy as a non-committer.
2710         https://bugs.webkit.org/show_bug.cgi?id=106420
2711
2712         Reviewed by Eric Seidel.
2713
2714         * Scripts/webkitpy/common/checkout/scm/git.py:
2715         (Git.push_local_commits_to_server):
2716         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2717         * Scripts/webkitpy/common/checkout/scm/svn.py:
2718         (SVNRepository):
2719         (SVNRepository.has_authorization_for_realm):
2720
2721 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2722
2723         [EFL][jhbuild] Use tarballs for gstreamer instead of git
2724         https://bugs.webkit.org/show_bug.cgi?id=106552
2725
2726         Reviewed by Laszlo Gombos.
2727
2728         Use tarballs for gstreamer instead of git in EFL's jhbuild
2729         to work around intermittent network issues on our build
2730         bots. Tarballs are fully cached and require no network
2731         operation if their checksum matches.
2732
2733         * efl/jhbuild.modules:
2734
2735 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2736
2737         Add Mac WK2 EWS bots
2738         https://bugs.webkit.org/show_bug.cgi?id=106590
2739
2740         Reviewed by Adam Barth.
2741
2742         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
2743         Also add a deprecated MacWK2Port class.
2744
2745         * QueueStatusServer/model/queues.py:
2746         (Queue):
2747         * Scripts/webkitpy/common/config/ports.py:
2748         (DeprecatedPort.port):
2749         (MacWK2Port):
2750         (MacWK2Port.run_webkit_tests_command):
2751         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2752         (MacEWS):
2753         (MacWK2EWS):
2754         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2755         (_test_ewses):
2756
2757 2013-01-10  Dan Carney  <dcarney@google.com>
2758
2759         [chromium] move webpermissionclient related methods to TestRunner library
2760         https://bugs.webkit.org/show_bug.cgi?id=106548
2761
2762         Reviewed by Jochen Eisinger.
2763
2764         * DumpRenderTree/DumpRenderTree.gypi:
2765         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2766         (DRTTestRunner::DRTTestRunner):
2767         (DRTTestRunner::reset):
2768         * DumpRenderTree/chromium/DRTTestRunner.h:
2769         (DRTTestRunner):
2770         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2771         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
2772         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2773         (WebKit):
2774         (WebTestRunner::WebTestRunner::webPermissions):
2775         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2776         (WebTestRunner::TestRunner::TestRunner):
2777         (WebTestRunner::TestRunner::setDelegate):
2778         (WebTestRunner):
2779         (WebTestRunner::TestRunner::reset):
2780         (WebTestRunner::TestRunner::webPermissions):
2781         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
2782         (WebTestRunner::TestRunner::setImagesAllowed):
2783         (WebTestRunner::TestRunner::setScriptsAllowed):
2784         (WebTestRunner::TestRunner::setStorageAllowed):
2785         (WebTestRunner::TestRunner::setPluginsAllowed):
2786         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
2787         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
2788         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2789         (WebTestRunner):
2790         (TestRunner):
2791         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
2792         (WebTestRunner):
2793         (WebTestRunner::WebPermissions::WebPermissions):
2794         (WebTestRunner::WebPermissions::~WebPermissions):
2795         (WebTestRunner::WebPermissions::allowImage):
2796         (WebTestRunner::WebPermissions::allowScriptFromSource):
2797         (WebTestRunner::WebPermissions::allowStorage):
2798         (WebTestRunner::WebPermissions::allowPlugins):
2799         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
2800         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
2801         (WebTestRunner::WebPermissions::setImagesAllowed):
2802         (WebTestRunner::WebPermissions::setScriptsAllowed):
2803         (WebTestRunner::WebPermissions::setStorageAllowed):
2804         (WebTestRunner::WebPermissions::setPluginsAllowed):
2805         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
2806         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
2807         (WebTestRunner::WebPermissions::setDelegate):
2808         (WebTestRunner::WebPermissions::setDumpCallbacks):
2809         (WebTestRunner::WebPermissions::reset):
2810         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
2811         (WebTestRunner):
2812         (WebPermissions):
2813         * DumpRenderTree/chromium/TestShell.cpp:
2814         (TestShell::initialize):
2815         (TestShell::resetTestController):
2816         (TestShell::createNewWindow):
2817         * DumpRenderTree/chromium/TestShell.h:
2818         (TestShell):
2819         * DumpRenderTree/chromium/WebViewHost.cpp:
2820         (WebViewHost::normalizeLayoutTestURL):
2821         * DumpRenderTree/chromium/WebViewHost.h:
2822         (WebViewHost):
2823
2824 2013-01-10  Alan Cutter  <alancutter@chromium.org>
2825
2826         Split EWS tool cold-boot.sh into modular components
2827         https://bugs.webkit.org/show_bug.cgi?id=106527
2828
2829         Reviewed by Adam Barth.
2830
2831         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
2832         Updated GCE bot build scripts to match.
2833         Unable to test scripts directly as they depend on being in the repository to work!
2834
2835         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2836         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2837         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
2838         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
2839         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
2840
2841 2013-01-10  Julie Parent  <jparent@chromium.org>
2842
2843         Dashboard Cleanup: Do not generate the page if we are about to reload.
2844         https://bugs.webkit.org/show_bug.cgi?id=106584
2845
2846         Reviewed by Dirk Pranke.
2847
2848         Move the logic to determine if we should generate the page into
2849         parseParameters() since that is where we have the knowledge to
2850         determine it, and return that value to handleLocationChange, 
2851         rather than passing the changed parameters back to handleLocationChange
2852         and having it make the decision.
2853         
2854         This is logically equivalent, save one case: when we are about to do
2855         a reload, we know that there is no reason to generate the page.  Old
2856         code was causing an extra page generation in this case.
2857         
2858         * TestResultServer/static-dashboards/dashboard_base.js:
2859         (parseParameters):
2860         (handleLocationChange):
2861
2862 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2863
2864         [jhbuild] Use the "configure" script to build glib
2865         https://bugs.webkit.org/show_bug.cgi?id=106569
2866
2867         Reviewed by Martin Robinson.
2868
2869         So far both EFL and GTK have been using autogen.sh to build glib.
2870         While that does work most of the time, it's not really needed since
2871         we are downloading and building stable releases from tarballs.
2872         Additionally, autogen.sh fails to work with automake 1.13 due to the
2873         usage of some macros that have been removed (this has already been
2874         fixed in glib master).
2875
2876         * efl/jhbuild.modules:
2877         * gtk/jhbuild.modules:
2878
2879 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2880
2881         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2882         (Missed a couple)
2883         https://bugs.webkit.org/show_bug.cgi?id=106536
2884
2885         Reviewed by Eric Seidel.
2886
2887         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2888
2889 2013-01-10  Tony Chang  <tony@chromium.org>
2890
2891         Speed up supplemental dependency computation
2892         https://bugs.webkit.org/show_bug.cgi?id=106503
2893
2894         Reviewed by Adam Barth.
2895
2896         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
2897
2898         * WebKitTestRunner/CMakeLists.txt:
2899
2900 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
2901
2902         Remove the ENABLE_ANIMATION_API feature define occurences
2903         https://bugs.webkit.org/show_bug.cgi?id=106544
2904
2905         Reviewed by Simon Fraser.
2906
2907         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
2908         feature define handling still lingers in various build systems and configurations
2909         but is of no use, so it should be removed.
2910
2911         * Scripts/webkitperl/FeatureList.pm:
2912         * qmake/mkspecs/features/features.pri:
2913
2914 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2915
2916         [GTK] Add support for loading web process extensions
2917         https://bugs.webkit.org/show_bug.cgi?id=105631
2918
2919         Reviewed by Gustavo Noronha Silva.
2920
2921         * MiniBrowser/gtk/GNUmakefile.am:
2922         * MiniBrowser/gtk/main.c:
2923         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
2924         bundle lib from build dir.
2925         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
2926         located in WebProcess/InjectedBundle/API/gtk.
2927         * gtk/generate-gtkdoc:
2928         (get_webkit2_options): Scan also files in
2929         WebProcess/InjectedBundle/API/gtk to generate API docs.
2930         (get_webkit2_options.injected_bundle_src_path): Helper function to
2931         build paths in WebProcess/InjectedBundle/API/gtk.
2932
2933 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2934
2935         [EFL][WK2] Writing immediately to created windows (open) fails
2936         https://bugs.webkit.org/show_bug.cgi?id=105276
2937
2938         Reviewed by Kenneth Rohde Christiansen.
2939
2940         Do not reset 'about:blank' url for the new pages in mini browser.
2941
2942         * MiniBrowser/efl/main.c:
2943         (window_create):
2944
2945 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2946
2947         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2948         https://bugs.webkit.org/show_bug.cgi?id=106536
2949
2950         Reviewed by Eric Seidel.
2951
2952         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2953
2954 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2955
2956         Converting to unittest2 so we can use assertItemsEqual, making tests
2957         not dependent on order of items.
2958         https://bugs.webkit.org/show_bug.cgi?id=106532
2959
2960         Before:
2961         Ran 1733 tests in 38.385s
2962         FAILED (failures=1, errors=22)
2963
2964         After:
2965         Ran 1733 tests in 32.298s
2966         FAILED (failures=0, errors=22)
2967
2968         Reviewed by Eric Seidel.
2969
2970         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2971         * Scripts/webkitpy/thirdparty/__init__.py:
2972         (AutoinstallImportHook._install_unittest2):
2973
2974 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2975
2976         [EFL] Add gstreamer 1.0.5 to jhbuild
2977         https://bugs.webkit.org/show_bug.cgi?id=106178
2978
2979         Reviewed by Laszlo Gombos.
2980
2981         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
2982
2983         * efl/jhbuild.modules:
2984
2985 2013-01-09  Alan Cutter  <alancutter@chromium.org>
2986
2987         Updated parameters in GCE build scripts so they now work.
2988         https://bugs.webkit.org/show_bug.cgi?id=106523
2989
2990         Reviewed by Adam Barth.
2991
2992         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2993         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2994         * EWSTools/cold-boot.sh:
2995
2996 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
2997
2998         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
2999         https://bugs.webkit.org/show_bug.cgi?id=106520
3000
3001         Reviewed by James Robinson.
3002
3003         Part of a larger refactoring series. See tracking bug 82948.
3004
3005         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3006         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3007
3008 2013-01-09  Julie Parent  <jparent@chromium.org>
3009
3010         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
3011         https://bugs.webkit.org/show_bug.cgi?id=106514
3012
3013         This is old code, as these can no longer get out of sync.
3014         permmaLinkURLHash is generated from currentState, which is set only
3015         from the location.  The commment about how these can get out of sync
3016         refers to a function that no longer exists.
3017         
3018         Reviewed by Dirk Pranke.
3019
3020         * TestResultServer/static-dashboards/dashboard_base.js:
3021         (handleLocationChange):
3022
3023 2013-01-09  Julie Parent  <jparent@chromium.org>
3024
3025         Dashboard Cleanup: Reload the page as soon as we know we need to.
3026         https://bugs.webkit.org/show_bug.cgi?id=106515
3027
3028         No need to continue parsing all of the data once we know that
3029         we need to do a reload.
3030         
3031         Reviewed by Dirk Pranke.
3032
3033         * TestResultServer/static-dashboards/dashboard_base.js:
3034         (parseParameters):
3035
3036 2013-01-09  Eric Seidel  <eric@webkit.org>
3037
3038         run-perf-tests --chromium-android --profile should show symbols for the kernel
3039         https://bugs.webkit.org/show_bug.cgi?id=106498
3040
3041         Reviewed by Adam Barth.
3042
3043         Turns out this was easy, once I finally read the output from "perf report".
3044         It appears there may be a bug in "perf record" on android, as it complains
3045         about not being able to read from /proc/kallsyms even when
3046         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
3047         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
3048         but rather just flip it to 0 long enough to grab the /proc/kallsyms
3049         and then flip it back to whatever the device had.
3050
3051         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
3052         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
3053         to symbol names.  Its world-readable, but will return all 0s if you
3054         don't have permission to see the kernel symbols.  kptr_restrict
3055         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
3056         1 is only a specific group, and 2 is "no one, not even root".
3057         By default kptr_restrict is 2 on Android it seems.
3058         More kptr_restrict docs: http://lwn.net/Articles/420403/
3059
3060         I also took this opportunity to clean up how the perf record command
3061         was built for use/display in AndroidPerf.profile_after_exit and
3062         change to always using long-form names for the arguments (to hopefully help readability).
3063
3064         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3065         (AndroidPerf.__init__):
3066         (profile_after_exit):
3067         (ChromiumAndroidDriver.__init__):
3068         (ChromiumAndroidDriver._update_kallsyms_cache):
3069         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3070
3071 2013-01-09  Julie Parent  <jparent@chromium.org>
3072
3073         Dashboard cleanup: remove dead code.
3074         https://bugs.webkit.org/show_bug.cgi?id=106509
3075
3076         Reviewed by Dirk Pranke.
3077
3078         * TestResultServer/static-dashboards/dashboard_base.js:
3079         (parseParameters):
3080
3081 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
3082
3083         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
3084         https://bugs.webkit.org/show_bug.cgi?id=105638
3085
3086         Reviewed by Martin Robinson.
3087
3088         The test was failing for two reasons:
3089         - AccessibilityRenderObject::correspondingLabelForControlElement() was
3090           not ignoring the ARIA labelled-by property
3091         - AccessibilityController::accessibleElementById() was not implemented
3092
3093         Because getting an element by ID cannot be done in the UIProcess, the
3094         decision was made to expose the element's ID as an accessible attribute
3095         of the object.
3096
3097         In addition, fixing the bug in AccessibilityRenderObject made it possible
3098         to eliminate the Gtk platform-specific expectations for another test.
3099
3100         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3101         (childElementById): Added. Walks the tree looking for the AtkObject
3102         Attribute which exposes the HTML element's ID.
3103         (AccessibilityController::accessibleElementById): Implemented.
3104         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3105         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
3106         when there is no title, as is done with the Mac port.
3107         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3108         (WTR):
3109         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3110         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
3111         Attribute which exposes the HTML element's ID.
3112         (WTR):
3113         (WTR::AccessibilityController::accessibleElementById): Implemented.
3114         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3115         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
3116         even when there is no title, as is done with the Mac port.
3117
3118 2013-01-09  Gregg Tavares  <gman@google.com>
3119
3120         Add Gregg Tavares as a committer
3121         https://bugs.webkit.org/show_bug.cgi?id=106492
3122
3123         Unreviewed.
3124
3125         * Scripts/webkitpy/common/config/committers.py:
3126
3127 2013-01-09  Roger Fong  <roger_fong@apple.com>
3128
3129         Enable seamless iFrames for Windows DRT.
3130         https://bugs.webkit.org/show_bug.cgi?id=106468.
3131
3132         Rubberstamped by Timothy Horton.
3133
3134         * DumpRenderTree/win/DumpRenderTree.cpp:
3135         (resetDefaultsToConsistentValues):
3136
3137 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
3138
3139         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
3140         https://bugs.webkit.org/show_bug.cgi?id=93979
3141
3142         Reviewed by Benjamin Poulain.
3143
3144         Implement eventSender.scheduleAsynchronousKeyDown() in
3145         WebKitTestRunner.
3146
3147         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3148         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3149         (WTR::createKeyDownMessageBody):
3150         (WTR::EventSendingController::keyDown):
3151         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3152         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3153         (EventSendingController):
3154         * WebKitTestRunner/TestController.cpp:
3155         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
3156         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3157         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3158         * WebKitTestRunner/TestController.h:
3159         (TestController):
3160
3161 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
3162
3163         [chromium] move resource load callback dumping to TestRunner library
3164         https://bugs.webkit.org/show_bug.cgi?id=106449
3165
3166         Reviewed by Adam Barth.
3167
3168         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3169         (DRTTestRunner::DRTTestRunner):
3170         (DRTTestRunner::reset):
3171         * DumpRenderTree/chromium/DRTTestRunner.h:
3172         (DRTTestRunner):
3173         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3174         (WebKit):
3175         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
3176         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3177         (WebKit):
3178         (WebTestProxyBase):
3179         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
3180         (WebTestRunner::WebTestProxy::willRequestResource):
3181         (WebTestRunner::WebTestProxy::willSendRequest):
3182         (WebTestRunner::WebTestProxy::didReceiveResponse):
3183         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
3184         (WebTestRunner::WebTestProxy::didFailResourceLoad):
3185         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3186         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
3187         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
3188         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
3189         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3190         (WebTestRunner::TestRunner::TestRunner):
3191         (WebTestRunner::TestRunner::reset):
3192         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
3193         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
3194         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
3195         (WebTestRunner):
3196         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
3197         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
3198         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
3199         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3200         (TestRunner):
3201         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3202         (WebTestRunner::WebTestProxyBase::reset):
3203         (WebTestRunner):
3204         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
3205         (WebTestRunner::WebTestProxyBase::willRequestResource):
3206         (WebTestRunner::WebTestProxyBase::willSendRequest):
3207         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
3208         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
3209         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
3210         * DumpRenderTree/chromium/WebViewHost.cpp:
3211         (WebViewHost::willSendRequest):
3212         (WebViewHost::makeURLErrorDescription):
3213         (WebViewHost::reset):
3214         * DumpRenderTree/chromium/WebViewHost.h:
3215         (WebViewHost):
3216
3217 2013-01-09  Dan Carney  <dcarney@google.com>
3218
3219         [chromium] move dumpcreateview methods to testrunner library
3220         https://bugs.webkit.org/show_bug.cgi?id=106434
3221
3222         Reviewed by Adam Barth.
3223
3224         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3225         (DRTTestRunner::DRTTestRunner):
3226         (DRTTestRunner::reset):
3227         * DumpRenderTree/chromium/DRTTestRunner.h:
3228         (DRTTestRunner):
3229         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3230         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
3231         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3232         (WebTestRunner::TestRunner::TestRunner):
3233         (WebTestRunner::TestRunner::reset):
3234         (WebTestRunner::TestRunner::shouldDumpCreateView):
3235         (WebTestRunner):
3236         (WebTestRunner::TestRunner::dumpCreateView):
3237         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3238         (TestRunner):
3239
3240 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
3241
3242         webkitpy cleanup: Merge additional_comment_text into comment_text
3243         https://bugs.webkit.org/show_bug.cgi?id=106421
3244
3245         Reviewed by Adam Barth.
3246
3247         * Scripts/webkitpy/common/config/committervalidator.py:
3248         (CommitterValidator.reject_patch_from_commit_queue):
3249         (CommitterValidator.reject_patch_from_review_queue):
3250         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3251         (Bugzilla.set_flag_on_attachment):
3252         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3253         (MockBugzilla.set_flag_on_attachment):
3254         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3255         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3256         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3257         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3258
3259 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3260
3261         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
3262         https://bugs.webkit.org/show_bug.cgi?id=106464
3263
3264         Reviewed by Martin Robinson.
3265
3266         Current version in jhbuild.modules (2.26.0) is giving trouble to
3267         when trying to build WebKitGTK from scratch, due to a segmentation
3268         fault error in gdk-pixbuf-query-loader during the 'make'
3269         phase. Raising the version to 2.26.5 fixes this issue.
3270
3271         * gtk/jhbuild.modules: Version raised, checksums updated.
3272
3273 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
3274
3275         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
3276         https://bugs.webkit.org/show_bug.cgi?id=90968.
3277
3278         Reviewed by Csaba Osztrogonác.
3279
3280         Added functionality in DRT and WTR to use any timeout value while running
3281         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
3282         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
3283         to indicate whether the current port supports setting timeout value
3284         per test (it's False by default; I enabled it only on Qt).
3285         Also corrected a typo in driver.py
3286
3287         * DumpRenderTree/DumpRenderTree.h:
3288         (TestCommand::TestCommand):
3289         (TestCommand):
3290         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3291         (parseInputLine):
3292         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3293         (WebCore::DumpRenderTree::processLine):
3294         * Scripts/webkitpy/layout_tests/port/base.py:
3295         (Port.supports_per_test_timeout):
3296         * Scripts/webkitpy/layout_tests/port/driver.py:
3297         (Driver.run_test):
3298         (Driver._command_from_driver_input):
3299         * Scripts/webkitpy/layout_tests/port/qt.py:
3300         (QtPort.supports_per_test_timeout):
3301         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3302         (WTR::InjectedBundle::InjectedBundle):
3303         (WTR::InjectedBundle::didReceiveMessage):
3304         (WTR::InjectedBundle::beginTesting):
3305         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3306         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3307         (WTR::TestRunner::setCustomTimeout):
3308         (WTR):
3309         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3310         (TestRunner):
3311         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3312         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3313         * WebKitTestRunner/TestController.cpp:
3314         (WTR::TestController::TestController):
3315         (WTR::TestController::getCustomTimeout):
3316         (WTR):
3317         (WTR::TestCommand::TestCommand):
3318         (TestCommand):
3319         (WTR::parseInputLine):
3320         (WTR::TestController::runTest):
3321         (WTR::TestController::runUntil):
3322         * WebKitTestRunner/TestController.h:
3323         (TestController):
3324         * WebKitTestRunner/TestInvocation.cpp:
3325         (WTR::TestInvocation::TestInvocation):
3326         (WTR::TestInvocation::setCustomTimeout):
3327         (WTR):
3328         (WTR::TestInvocation::invoke):
3329         * WebKitTestRunner/TestInvocation.h:
3330         (TestInvocation):
3331
3332 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3333
3334         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
3335         https://bugs.webkit.org/show_bug.cgi?id=106290
3336
3337         Reviewed by Martin Robinson.
3338
3339         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
3340         the macro isn't enabled.
3341
3342         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3343
3344 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
3345
3346         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
3347         https://bugs.webkit.org/show_bug.cgi?id=103653
3348
3349         Reviewed by Anders Carlsson.
3350
3351         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
3352         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
3353         client callback.
3354
3355         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
3356         methods to the JavaScript API.
3357         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3358         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
3359         (WTR::TestRunner::setAuthenticationUsername): Ditto.
3360         (WTR::TestRunner::setAuthenticationPassword): Ditto.
3361         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3362         (TestRunner): Added new declarations for the above.
3363         * WebKitTestRunner/TestController.cpp:
3364         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
3365         callback.
3366         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
3367         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
3368         the authentication information passed from the InjectedBundle.
3369         * WebKitTestRunner/TestController.h:
3370         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
3371         to communicate with the TestController.
3372         (WTR::TestController::setAuthenticationUsername): Ditto.
3373         (WTR::TestController::setAuthenticationPassword): Ditto.
3374         (TestController):
3375         * WebKitTestRunner/TestInvocation.cpp:
3376         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
3377         information from the InjectedBundle.
3378         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
3379         text to the TestInvocation text output.
3380         * WebKitTestRunner/TestInvocation.h:
3381         (TestInvocation): Added declaration for new method.
3382
3383 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
3384
3385         Add myself as a watcher for Web Geolocation
3386
3387         Unreviewed.
3388
3389         * Scripts/webkitpy/common/config/watchlist:
3390
3391 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3392
3393         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
3394         https://bugs.webkit.org/show_bug.cgi?id=106364
3395
3396         Reviewed by Eric Seidel.
3397
3398         When the setup_test_run method is called on the subclasses of the base Port
3399         interface, the parent method should also be called via super(), despite the
3400         parent method not doing anything at the moment.
3401
3402         The according calls to super() are required in the ChromiumPort, EflPort
3403         and GtkPort implementations.
3404
3405         * Scripts/webkitpy/layout_tests/port/chromium.py:
3406         (ChromiumPort.setup_test_run):
3407         * Scripts/webkitpy/layout_tests/port/efl.py:
3408         (EflPort.setup_test_run):
3409         * Scripts/webkitpy/layout_tests/port/gtk.py:
3410         (GtkPort.setup_test_run):
3411
3412 2013-01-08  Julie Parent  <jparent@chromium.org>
3413
3414         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
3415         https://bugs.webkit.org/show_bug.cgi?id=106356
3416
3417         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
3418         dashboard_base, assigned by Loader, and used only by dashboard_base to
3419         create error messages.  Moved the variables to be privates on the Loader
3420         object, moved error message creation to _getLoadingErrorMessages on the
3421         Loader object, and now pass the errors back to dashboard base via the
3422         resourceLoadingComplete callback.
3423         
3424         Also removed the now unused clearError function, it was only being used
3425         by unit tests to clean up global state.
3426         
3427         Reviewed by Dirk Pranke.
3428
3429         * TestResultServer/static-dashboards/dashboard_base.js:
3430         (resourceLoadingComplete):
3431         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3432         * TestResultServer/static-dashboards/loader.js:
3433         (.):
3434         * TestResultServer/static-dashboards/loader_unittests.js:
3435
3436 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3437
3438         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
3439         https://bugs.webkit.org/show_bug.cgi?id=106354
3440
3441         Reviewed by Eric Seidel.
3442
3443         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
3444         instead of those two inheriting from it. Also add a mock object of the
3445         sanitizer that's used in unit tests.
3446
3447         * Scripts/webkitpy/layout_tests/port/efl.py:
3448         (EflPort):
3449         (EflPort.__init__):
3450         (EflPort.setup_test_run):
3451         (EflPort.clean_up_test_run):
3452         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
3453         importing order.
3454         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3455         * Scripts/webkitpy/layout_tests/port/gtk.py:
3456         (GtkPort):
3457         (GtkPort.__init__):
3458         (GtkPort.setup_test_run):
3459         (GtkPort.clean_up_test_run):
3460         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
3461         importing order.
3462         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3463         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
3464         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
3465         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
3466         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
3467         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
3468         (PulseAudioSanitizerMock.unload_pulseaudio_module):
3469         (PulseAudioSanitizerMock.restore_pulseaudio_module):
3470
3471 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
3472
3473         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
3474         https://bugs.webkit.org/show_bug.cgi?id=106324
3475
3476         Reviewed by Adam Barth.
3477
3478         Since the frame load callbacks are part of the WebFrameClient, the
3479         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
3480         methods.
3481
3482         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3483         (DRTTestRunner::DRTTestRunner):
3484         (DRTTestRunner::reset):
3485         * DumpRenderTree/chromium/DRTTestRunner.h:
3486         (DRTTestRunner):
3487         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3488         (WebTestInterfaces):
3489         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3490         (WebKit):
3491         (WebTestProxyBase):
3492         (WebTestRunner):
3493         (WebTestRunner::WebTestProxy::WebTestProxy):
3494         (WebTestProxy):
3495         (WebTestRunner::WebTestProxy::didInvalidateRect):
3496         (WebTestRunner::WebTestProxy::didScrollRect):
3497         (WebTestRunner::WebTestProxy::scheduleComposite):
3498         (WebTestRunner::WebTestProxy::scheduleAnimation):
3499         (WebTestRunner::WebTestProxy::setWindowRect):
3500         (WebTestRunner::WebTestProxy::show):
3501         (WebTestRunner::WebTestProxy::didAutoResize):
3502         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
3503         (WebTestRunner::WebTestProxy::startDragging):
3504         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3505         (WebTestRunner::WebTestProxy::shouldEndEditing):
3506         (WebTestRunner::WebTestProxy::shouldInsertNode):
3507         (WebTestRunner::WebTestProxy::shouldInsertText):
3508         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3509         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3510         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3511         (WebTestRunner::WebTestProxy::didBeginEditing):
3512         (WebTestRunner::WebTestProxy::didChangeSelection):
3513         (WebTestRunner::WebTestProxy::didChangeContents):
3514         (WebTestRunner::WebTestProxy::didEndEditing):
3515         (WebTestRunner::WebTestProxy::registerIntentService):
3516         (WebTestRunner::WebTestProxy::dispatchIntent):
3517         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
3518         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
3519         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
3520         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
3521         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
3522         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
3523         (WebTestRunner::WebTestProxy::didReceiveTitle):
3524         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
3525         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
3526         (WebTestRunner::WebTestProxy::didFailLoad):
3527         (WebTestRunner::WebTestProxy::didFinishLoad):
3528         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
3529         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
3530         (WebTestRunner::WebTestProxy::didRunInsecureContent):
3531         (WebTestRunner::WebTestProxy::didDetectXSS):
3532         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3533         (WebTestRunner::WebTestRunner::setTestIsRunning):
3534         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
3535         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
3536         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3537         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
3538         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
3539         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3540         (WebTestRunner::TestRunner::TestRunner):
3541         (WebTestRunner::TestRunner::reset):
3542         (WebTestRunner::TestRunner::setTestIsRunning):
3543         (WebTestRunner):
3544         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
3545         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
3546         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3547         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
3548         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
3549         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
3550         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
3551         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
3552         (WebTestRunner::TestRunner::dumpTitleChanges):
3553         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3554         (TestRunner):
3555         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3556         (WebTestInterfaces::Internal):
3557         (WebTestRunner::WebTestInterfaces::Internal::webView):
3558         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3559         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
3560         (WebTestRunner):
3561         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
3562         (WebTestRunner::WebTestInterfaces::setWebView):
3563         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
3564         (WebTestRunner::WebTestInterfaces::webView):
3565         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3566         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
3567         (WebTestRunner):
3568         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
3569         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
3570         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
3571         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
3572         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
3573         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3574         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
3575         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
3576         (WebTestRunner::WebTestProxyBase::didFailLoad):
3577         (WebTestRunner::WebTestProxyBase::didFinishLoad):
3578         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
3579         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
3580         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
3581         (WebTestRunner::WebTestProxyBase::didDetectXSS):
3582         * DumpRenderTree/chromium/TestShell.cpp:
3583         (TestShell::runFileTest):
3584         (TestShell::testFinished):
3585         * DumpRenderTree/chromium/TestShell.h:
3586         (TestShell):
3587         * DumpRenderTree/chromium/WebViewHost.cpp:
3588         (WebViewHost::didStartProvisionalLoad):
3589         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
3590         (WebViewHost::didFailProvisionalLoad):
3591         (WebViewHost::didCommitProvisionalLoad):
3592         (WebViewHost::didReceiveTitle):
3593         (WebViewHost::didFailLoad):
3594         (WebViewHost::didFinishLoad):
3595         * DumpRenderTree/chromium/WebViewHost.h:
3596         (WebViewHost):
3597
3598 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3599
3600         [GTK] Lower the default timeout value for WebKitTestRunner
3601         https://bugs.webkit.org/show_bug.cgi?id=106353
3602
3603         Reviewed by Dirk Pranke.
3604
3605         The default timeout value for WebKitTestRunner should be lowered.
3606         The current value (80 seconds) is irrational and just leads to producing
3607         text failures for layout tests that genuinely time out. This just leads
3608         to more deviation from the GTK WK1 port in terms of test expectations.
3609
3610         The value used is the same as when running the DumpRenderTree, that's
3611         6 seconds in release builds and 12 seconds in debug builds.
3612
3613         * Scripts/webkitpy/layout_tests/port/gtk.py:
3614         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3615         (GtkPortTest.test_default_timeout_ms):
3616
3617 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3618
3619         test-webkitpy shows failure output on my linux box
3620         https://bugs.webkit.org/show_bug.cgi?id=101261
3621
3622         Reviewed by Eric Seidel.
3623
3624         Mock out the PulseAudioSanitizer methods when creating testing instances
3625         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
3626         PulseAudio output when the sanitizer was trying to unload modules which
3627         were already unloaded by another unit test that was being run in parallel.
3628
3629         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3630         (EflPortTest):
3631         (EflPortTest.make_port):
3632         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3633         (GtkPortTest):
3634         (GtkPortTest.make_port):
3635
3636 2013-01-08  Julie Parent  <jparent@chromium.org>
3637
3638         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
3639         https://bugs.webkit.org/show_bug.cgi?id=106254
3640
3641         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
3642         only to figure out if we should call addBuilderLoadErrors during
3643         handleLocationChange, which was called when the loader completed and on
3644         any hash change, but we only ever wanted to call addBuilderLoadErrors
3645         on the initial loader load.  Moved the call of addBuilderLoadErrors to
3646         resourceLoadingComplete rather than handleLocationChange, so now we
3647         only call it when we want to, and the check can go away completely.
3648
3649         Reviewed by Dirk Pranke.
3650
3651         * TestResultServer/static-dashboards/dashboard_base.js:
3652         (addBuilderLoadErrors):
3653         (resourceLoadingComplete):
3654         (handleLocationChange):
3655         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3656
3657 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
3658