f92914ba48257eb80df57231715f880d1108eccb
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
2
3         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
4
5         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
6         Fixed an incorrect ifdef.
7
8 2014-01-26  Brendan Long  <b.long@cablelabs.com>
9
10         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
11         https://bugs.webkit.org/show_bug.cgi?id=110602
12
13         Reviewed by Philippe Normand.
14
15         * DumpRenderTree/gtk/DumpRenderTree.cpp:
16         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
17         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
18
19 2014-01-24  Andy Estes  <aestes@apple.com>
20
21         [iOS] Upstream changes in Tools/DumpRenderTree
22         https://bugs.webkit.org/show_bug.cgi?id=127412
23
24         Reviewed by Simon Fraser.
25
26         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
27         which builds the DumpRenderTree static library into an app bundle as
28         expected by the iOS Simulator.
29
30         * DumpRenderTree/AccessibilityTextMarker.h:
31         * DumpRenderTree/AccessibilityUIElement.h:
32         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
33         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
34         * DumpRenderTree/DumpRenderTreePrefix.h:
35         * DumpRenderTree/PixelDumpSupport.cpp:
36         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
37         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
38         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
39         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
40         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
41         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
42         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
43         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
44         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
45         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
46         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
47         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
48         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
49         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
50         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
51         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
52         * DumpRenderTree/TestRunner.cpp:
53         * DumpRenderTree/TestRunner.h:
54         * DumpRenderTree/cg/ImageDiffCG.cpp:
55         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
56         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
57         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
58         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
59         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
60         * DumpRenderTree/ios/Info.plist: Added.
61         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
62         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
63         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
64         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
65         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
66         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
67         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
68         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
69         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
70         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
71         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
72         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
73         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
74         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
75         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
76         * DumpRenderTree/mac/AppleScriptController.m:
77         * DumpRenderTree/mac/Configurations/Base.xcconfig:
78         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
79         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
80         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
81         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
82         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
83         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
84         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
85         * DumpRenderTree/mac/DumpRenderTree.mm:
86         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
87         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
88         * DumpRenderTree/mac/DumpRenderTreeMac.h:
89         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
90         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
91         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
92         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
93         * DumpRenderTree/mac/EditingDelegate.h:
94         * DumpRenderTree/mac/EventSendingController.h:
95         * DumpRenderTree/mac/EventSendingController.mm:
96         * DumpRenderTree/mac/FrameLoadDelegate.mm:
97         * DumpRenderTree/mac/HistoryDelegate.h:
98         * DumpRenderTree/mac/LayoutTestHelper.m:
99         * DumpRenderTree/mac/MockGeolocationProvider.mm:
100         * DumpRenderTree/mac/NavigationController.h:
101         * DumpRenderTree/mac/ObjCPlugin.h:
102         * DumpRenderTree/mac/ObjCPlugin.m:
103         * DumpRenderTree/mac/ObjCPluginFunction.h:
104         * DumpRenderTree/mac/PolicyDelegate.h:
105         * DumpRenderTree/mac/ResourceLoadDelegate.h:
106         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
107         * DumpRenderTree/mac/TestRunnerMac.mm:
108         * DumpRenderTree/mac/TextInputController.h:
109         * DumpRenderTree/mac/TextInputController.m:
110         * DumpRenderTree/mac/UIDelegate.h:
111         * DumpRenderTree/mac/UIDelegate.mm:
112
113 2014-01-25  Darin Adler  <darin@apple.com>
114
115         Call deprecatedCharacters instead of characters at more call sites
116         https://bugs.webkit.org/show_bug.cgi?id=127631
117
118         Reviewed by Sam Weinig.
119
120         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
121         (TestWebKitAPI::expectBuilderContent):
122         (TestWebKitAPI::expectEmpty):
123         (TestWebKitAPI::TEST):
124         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
125         (TestWebKitAPI::TEST):
126         Use the new name.
127
128 2014-01-25  Anders Carlsson  <andersca@apple.com>
129
130         Modernize HashTable threading code
131         https://bugs.webkit.org/show_bug.cgi?id=127621
132
133         Reviewed by Darin Adler.
134
135         Explicitly include headers that used to be brought in by HashTable.h
136
137         * DumpRenderTree/JavaScriptThreading.cpp:
138
139 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
140
141         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
142
143         * Scripts/webkitpy/common/config/contributors.json:
144         * Scripts/webkitpy/common/config/watchlist:
145
146 2014-01-23  David Farler  <dfarler@apple.com>
147
148         Make WebKitTestRunner work with iOS
149         https://bugs.webkit.org/show_bug.cgi?id=127448
150
151         Reviewed by Simon Fraser.
152
153         Combined patch from Simon below with some additional xcconfig cleanups,
154         rebasing and stubbing out a couple of new functions that popped up
155         since then.
156
157         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
158
159                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
160
161                 Get WebKitTestRunner limping on iOS. Main parts:
162                 - Stub out lots of accessibility-related functions.
163                 - Stub out EventSender
164                 - Create target to make a bundled app that runs in the simulator,
165                   and copy the injected bundle library into it.
166                 - Make a UIWindow and WKView to load tests in
167
168                 It runs, load tests, and dumps results to output. More work will be
169                 required once we can execute it via the webkitpy scripts.
170
171         * WebKitTestRunner/Configurations/Base.xcconfig:
172         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
173         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
174         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
175         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
176         (WTR::AccessibilityController::addNotificationListener):
177         (WTR::AccessibilityController::removeNotificationListener):
178         (WTR::AccessibilityController::platformName):
179         (WTR::AccessibilityController::logAccessibilityEvents):
180         (WTR::AccessibilityController::resetToConsistentState):
181         (WTR::findAccessibleObjectById):
182         (WTR::AccessibilityController::accessibleElementById):
183         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
184         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
185         (WTR::AccessibilityTextMarker::isEqual):
186         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
187         (WTR::AccessibilityUIElement::AccessibilityUIElement):
188         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
189         (WTR::AccessibilityUIElement::isEqual):
190         (WTR::AccessibilityUIElement::getLinkedUIElements):
191         (WTR::AccessibilityUIElement::getDocumentLinks):
192         (WTR::AccessibilityUIElement::getChildren):
193         (WTR::AccessibilityUIElement::getChildrenWithRange):
194         (WTR::AccessibilityUIElement::childrenCount):
195         (WTR::AccessibilityUIElement::elementAtPoint):
196         (WTR::AccessibilityUIElement::indexOfChild):
197         (WTR::AccessibilityUIElement::childAtIndex):
198         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
199         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
200         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
201         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
202         (WTR::AccessibilityUIElement::rowAtIndex):
203         (WTR::AccessibilityUIElement::selectedChildAtIndex):
204         (WTR::AccessibilityUIElement::selectedChildrenCount):
205         (WTR::AccessibilityUIElement::selectedRowAtIndex):
206         (WTR::AccessibilityUIElement::titleUIElement):
207         (WTR::AccessibilityUIElement::parentElement):
208         (WTR::AccessibilityUIElement::disclosedByRow):
209         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
210         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
211         (WTR::AccessibilityUIElement::attributesOfChildren):
212         (WTR::AccessibilityUIElement::allAttributes):
213         (WTR::AccessibilityUIElement::stringAttributeValue):
214         (WTR::AccessibilityUIElement::numberAttributeValue):
215         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
216         (WTR::AccessibilityUIElement::uiElementAttributeValue):
217         (WTR::AccessibilityUIElement::boolAttributeValue):
218         (WTR::AccessibilityUIElement::isAttributeSettable):
219         (WTR::AccessibilityUIElement::isAttributeSupported):
220         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
221         (WTR::AccessibilityUIElement::role):
222         (WTR::AccessibilityUIElement::subrole):
223         (WTR::AccessibilityUIElement::roleDescription):
224         (WTR::AccessibilityUIElement::title):
225         (WTR::AccessibilityUIElement::description):
226         (WTR::AccessibilityUIElement::orientation):
227         (WTR::AccessibilityUIElement::stringValue):
228         (WTR::AccessibilityUIElement::language):
229         (WTR::AccessibilityUIElement::helpText):
230         (WTR::AccessibilityUIElement::x):
231         (WTR::AccessibilityUIElement::y):
232         (WTR::AccessibilityUIElement::width):
233         (WTR::AccessibilityUIElement::height):
234         (WTR::AccessibilityUIElement::clickPointX):
235         (WTR::AccessibilityUIElement::clickPointY):
236         (WTR::AccessibilityUIElement::intValue):
237         (WTR::AccessibilityUIElement::minValue):
238         (WTR::AccessibilityUIElement::maxValue):
239         (WTR::AccessibilityUIElement::valueDescription):
240         (WTR::AccessibilityUIElement::insertionPointLineNumber):
241         (WTR::AccessibilityUIElement::isPressActionSupported):
242         (WTR::AccessibilityUIElement::isIncrementActionSupported):
243         (WTR::AccessibilityUIElement::isDecrementActionSupported):
244         (WTR::AccessibilityUIElement::isEnabled):
245         (WTR::AccessibilityUIElement::isRequired):
246         (WTR::AccessibilityUIElement::isFocused):
247         (WTR::AccessibilityUIElement::isSelected):
248         (WTR::AccessibilityUIElement::isSelectedOptionActive):
249         (WTR::AccessibilityUIElement::isIndeterminate):
250         (WTR::AccessibilityUIElement::isExpanded):
251         (WTR::AccessibilityUIElement::isChecked):
252         (WTR::AccessibilityUIElement::hierarchicalLevel):
253         (WTR::AccessibilityUIElement::classList):
254         (WTR::AccessibilityUIElement::speak):
255         (WTR::AccessibilityUIElement::ariaIsGrabbed):
256         (WTR::AccessibilityUIElement::ariaDropEffects):
257         (WTR::AccessibilityUIElement::lineForIndex):
258         (WTR::AccessibilityUIElement::rangeForLine):
259         (WTR::AccessibilityUIElement::rangeForPosition):
260         (WTR::AccessibilityUIElement::boundsForRange):
261         (WTR::AccessibilityUIElement::stringForRange):
262         (WTR::AccessibilityUIElement::attributedStringForRange):
263         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
264         (WTR::uiElementCountForSearchPredicate):
265         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
266         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
267         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
268         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
269         (WTR::AccessibilityUIElement::attributesOfColumns):
270         (WTR::AccessibilityUIElement::attributesOfRows):
271         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
272         (WTR::AccessibilityUIElement::attributesOfHeader):
273         (WTR::AccessibilityUIElement::rowCount):
274         (WTR::AccessibilityUIElement::columnCount):
275         (WTR::AccessibilityUIElement::indexInTable):
276         (WTR::AccessibilityUIElement::rowIndexRange):
277         (WTR::AccessibilityUIElement::columnIndexRange):
278         (WTR::AccessibilityUIElement::cellForColumnAndRow):
279         (WTR::AccessibilityUIElement::horizontalScrollbar):
280         (WTR::AccessibilityUIElement::verticalScrollbar):
281         (WTR::AccessibilityUIElement::scrollToMakeVisible):
282         (WTR::AccessibilityUIElement::selectedTextRange):
283         (WTR::AccessibilityUIElement::setSelectedTextRange):
284         (WTR::AccessibilityUIElement::increment):
285         (WTR::AccessibilityUIElement::decrement):
286         (WTR::AccessibilityUIElement::showMenu):
287         (WTR::AccessibilityUIElement::press):
288         (WTR::AccessibilityUIElement::setSelectedChild):
289         (WTR::AccessibilityUIElement::accessibilityValue):
290         (WTR::AccessibilityUIElement::documentEncoding):
291         (WTR::AccessibilityUIElement::documentURI):
292         (WTR::AccessibilityUIElement::url):
293         (WTR::AccessibilityUIElement::addNotificationListener):
294         (WTR::AccessibilityUIElement::removeNotificationListener):
295         (WTR::AccessibilityUIElement::isFocusable):
296         (WTR::AccessibilityUIElement::isSelectable):
297         (WTR::AccessibilityUIElement::isMultiSelectable):
298         (WTR::AccessibilityUIElement::isVisible):
299         (WTR::AccessibilityUIElement::isOffScreen):
300         (WTR::AccessibilityUIElement::isCollapsed):
301         (WTR::AccessibilityUIElement::isIgnored):
302         (WTR::AccessibilityUIElement::hasPopup):
303         (WTR::AccessibilityUIElement::takeFocus):
304         (WTR::AccessibilityUIElement::takeSelection):
305         (WTR::AccessibilityUIElement::addSelection):
306         (WTR::AccessibilityUIElement::removeSelection):
307         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
308         (WTR::AccessibilityUIElement::textMarkerRangeLength):
309         (WTR::AccessibilityUIElement::previousTextMarker):
310         (WTR::AccessibilityUIElement::nextTextMarker):
311         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
312         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
313         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
314         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
315         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
316         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
317         (WTR::AccessibilityUIElement::textMarkerForPoint):
318         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
319         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
320         (WTR::AccessibilityUIElement::indexForTextMarker):
321         (WTR::AccessibilityUIElement::isTextMarkerValid):
322         (WTR::AccessibilityUIElement::textMarkerForIndex):
323         (WTR::AccessibilityUIElement::startTextMarker):
324         (WTR::AccessibilityUIElement::endTextMarker):
325         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
326         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
327         (WTR::AccessibilityUIElement::pathDescription):
328         (WTR::AccessibilityUIElement::supportedActions):
329         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
330         (WTR::activateFonts):
331         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
332         (WTR::EventSenderProxy::EventSenderProxy):
333         (WTR::EventSenderProxy::~EventSenderProxy):
334         (WTR::EventSenderProxy::updateClickCountForButton):
335         (WTR::EventSenderProxy::mouseDown):
336         (WTR::EventSenderProxy::mouseUp):
337         (WTR::EventSenderProxy::mouseMoveTo):
338         (WTR::EventSenderProxy::leapForward):
339         (WTR::EventSenderProxy::keyDown):
340         (WTR::EventSenderProxy::mouseScrollBy):
341         (WTR::EventSenderProxy::continuousMouseScrollBy):
342         (WTR::EventSenderProxy::addTouchPoint):
343         (WTR::EventSenderProxy::updateTouchPoint):
344         (WTR::EventSenderProxy::setTouchModifier):
345         (WTR::EventSenderProxy::setTouchPointRadius):
346         (WTR::EventSenderProxy::touchStart):
347         (WTR::EventSenderProxy::touchMove):
348         (WTR::EventSenderProxy::touchEnd):
349         (WTR::EventSenderProxy::touchCancel):
350         (WTR::EventSenderProxy::clearTouchPoints):
351         (WTR::EventSenderProxy::releaseTouchPoint):
352         (WTR::EventSenderProxy::cancelTouchPoint):
353         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
354         (WTR::InjectedBundle::platformInitialize):
355         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
356         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
357         * WebKitTestRunner/Makefile:
358         * WebKitTestRunner/TestController.cpp:
359         (WTR::TestController::initialize):
360         * WebKitTestRunner/TestController.h:
361         * WebKitTestRunner/TestInvocation.cpp:
362         (WTR::TestInvocation::invoke):
363         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
364         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
365         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
366         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
367         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
368         (-[AppDelegate applicationWillResignActive:]):
369         (-[AppDelegate applicationDidEnterBackground:]):
370         (-[AppDelegate applicationWillEnterForeground:]):
371         (-[AppDelegate applicationDidBecomeActive:]):
372         (-[AppDelegate applicationWillTerminate:]):
373         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
374         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
375         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
376         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
377         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
378         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
379         (main):
380         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
381         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
382         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
383         (-[WebKitTestRunnerAppTests setUp]):
384         (-[WebKitTestRunnerAppTests tearDown]):
385         (-[WebKitTestRunnerAppTests testExample]):
386         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
387         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
388         * WebKitTestRunner/cg/TestInvocationCG.cpp:
389         * WebKitTestRunner/iOS.xcconfig: Added.
390         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
391         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
392         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
393         (-[WebKitTestRunnerWindow isKeyWindow]):
394         (-[WebKitTestRunnerWindow setFrameOrigin:]):
395         (-[WebKitTestRunnerWindow setFrame:]):
396         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
397         (-[WebKitTestRunnerWindow backingScaleFactor]):
398         (WTR::PlatformWebView::PlatformWebView):
399         (WTR::PlatformWebView::resizeTo):
400         (WTR::PlatformWebView::~PlatformWebView):
401         (WTR::PlatformWebView::page):
402         (WTR::PlatformWebView::focus):
403         (WTR::PlatformWebView::windowFrame):
404         (WTR::PlatformWebView::setWindowFrame):
405         (WTR::PlatformWebView::didInitializeClients):
406         (WTR::PlatformWebView::addChromeInputField):
407         (WTR::PlatformWebView::removeChromeInputField):
408         (WTR::PlatformWebView::makeWebViewFirstResponder):
409         (WTR::PlatformWebView::windowSnapshotImage):
410         (WTR::PlatformWebView::viewSupportsOptions):
411         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
412         (WTR::TestController::notifyDone):
413         (WTR::TestController::platformInitialize):
414         (WTR::TestController::platformDestroy):
415         (WTR::TestController::initializeInjectedBundlePath):
416         (WTR::TestController::initializeTestPluginDirectory):
417         (WTR::TestController::platformRunUntil):
418         (WTR::TestController::platformInitializeContext):
419         (WTR::TestController::runModal):
420         (WTR::TestController::platformLibraryPathForTesting):
421         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
422         (createCFURLResponseFromResponseData):
423         (supportedNonImageMIMETypes):
424         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
425         (-[WebKitTestRunnerApp _runTestController]):
426         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
427         (main):
428
429 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
430
431         [GTK] Put cache files in XDG_CACHE_HOME
432         https://bugs.webkit.org/show_bug.cgi?id=123458
433
434         Reviewed by Martin Robinson.
435
436         * GtkLauncher/main.c:
437         (createBrowser):
438
439 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
440
441         Remove CSS Custom Filters code and tests
442         https://bugs.webkit.org/show_bug.cgi?id=127382
443
444         Reviewed by Simon Fraser.
445
446         * DumpRenderTree/gtk/DumpRenderTree.cpp:
447         (resetDefaultsToConsistentValues):
448         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
449         (TestRunner::overridePreference):
450
451 2014-01-23  Tim Horton  <timothy_horton@apple.com>
452
453         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
454         https://bugs.webkit.org/show_bug.cgi?id=127415
455         <rdar://problem/12482452>
456
457         Reviewed by Sam Weinig.
458
459         Adopt the new page loader client plugin load callback.
460
461         * WebKitTestRunner/TestController.cpp:
462         (WTR::TestController::createWebViewWithOptions):
463         (WTR::TestController::pluginLoadPolicy):
464         * WebKitTestRunner/TestController.h:
465
466 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
467
468         [Curl] There is no way to specify cache folder.
469         https://bugs.webkit.org/show_bug.cgi?id=125028
470
471         Reviewed by Brent Fulgham.
472
473         Enable disc cache in WinLauncher by setting cache folder location.
474
475         * WinLauncher/WinLauncher.cpp:
476         (getAppDataFolder): Added function to get app data folder.
477         (setCacheFolder): Added function to set cache folder.
478         (createCrashReport): Use new getAppDataFolder function.
479         (wWinMain): Use function setCacheFolder to set cache folder location.
480
481 2014-01-23  Daniel Bates  <dabates@apple.com>
482
483         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
484         https://bugs.webkit.org/show_bug.cgi?id=127379
485
486         Reviewed by Simon Fraser.
487
488         Teach build-webkit to recognize --sdk=X.
489
490         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
491         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
492         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
493         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
494
495         * Scripts/webkitdirs.pm:
496         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
497         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
498         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
499
500 2014-01-23  Commit Queue  <commit-queue@webkit.org>
501
502         Unreviewed, rolling out r162612.
503         http://trac.webkit.org/changeset/162612
504         https://bugs.webkit.org/show_bug.cgi?id=127488
505
506         broke the build (Requested by mhahnenberg on #webkit).
507
508         * Scripts/build-jsc:
509         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
510         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
511         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
512         * jsc-cli/jsc-cli/JSModule.h: Removed.
513         * jsc-cli/jsc-cli/JSModule.m: Removed.
514         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
515         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
516         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
517         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
518         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
519         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
520         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
521         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
522         * jsc-cli/jsc-cli/main.m: Removed.
523
524 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
525
526         Basic framework for a modern jsc CLI
527         https://bugs.webkit.org/show_bug.cgi?id=127435
528
529         Reviewed by Geoffrey Garen.
530
531         The most basic components of a modern jsc command line interface consist of the following:
532
533         - A simple REPL to enter commands and receive results
534         - The ability to define a module (which consists of various internal methods as well as a 
535           set of externally visible methods)
536         - The ability to load other modules at runtime
537         - The ability to interact with the underlying platform to perform various "privileged" 
538           functions (e.g. opening files, printing to the stdout, etc.)
539         
540         The basic architecture will look something like the following:
541         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
542           on the main thread and start a secondary thread with a run loop to handle various inputs 
543           from the REPL thread.
544         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
545           it might transitively load) within the run loop on the secondary thread while the main 
546           thread blocks until it has completed.
547
548         * Scripts/build-jsc:
549         * jsc-cli: Added.
550         * jsc-cli/jsc-cli: Added.
551         * jsc-cli/jsc-cli.xcodeproj: Added.
552         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
553         * jsc-cli/jsc-cli/CLIInstance.h: Added.
554         * jsc-cli/jsc-cli/CLIInstance.m: Added.
555         (-[CLIInstance init]):
556         (-[CLIInstance loadFile:]):
557         (-[CLIInstance run]):
558         * jsc-cli/jsc-cli/JSModule.h: Added.
559         * jsc-cli/jsc-cli/JSModule.m: Added.
560         (coreModules):
561         (isCoreModule):
562         (classForModule):
563         (coreModuleFullPath):
564         (resolveModuleAsFile):
565         (resolveModuleAsDirectory):
566         (nodeModulePaths):
567         (resolveAsNodeModule):
568         (+[JSModule resolve:atPath:]):
569         (globalModuleCache):
570         (isCached):
571         (cachedModule):
572         (cacheModule):
573         (+[JSModule require:atPath:]):
574         (+[JSModule require:atPath:inContext:]):
575         (-[JSModule platformObjectInContext:]):
576         (-[JSModule initWithId:filename:context:]):
577         (-[JSModule dealloc]):
578         (-[JSModule didStartLoading]):
579         (-[JSModule didFinishLoading]):
580         (-[JSModule require:]):
581         (-[JSModule exports]):
582         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
583         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
584         (jsThreadMain):
585         (+[JSRunLoopThread threadMain]):
586         (-[JSRunLoopThread initWithFiles:andContext:]):
587         (-[JSRunLoopThread startRunLoop]):
588         (-[JSRunLoopThread start]):
589         (-[JSRunLoopThread join]):
590         (-[JSRunLoopThread didReceiveInput:]):
591         (-[JSRunLoopThread performCallback:withError:]):
592         (-[JSRunLoopThread performCallback:withArguments:]):
593         (-[JSRunLoopThread didFinishRunLoopInitialization]):
594         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
595         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
596         (-[ReadEvalPrintLoop initWithJSThread:]):
597         (prompt):
598         (escapeStringForOutput):
599         (-[ReadEvalPrintLoop processNextInput]):
600         (-[ReadEvalPrintLoop run]):
601         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
602         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
603         (+[RunLoopThread threadMain]):
604         (-[RunLoopThread init]):
605         (-[RunLoopThread dealloc]):
606         (-[RunLoopThread didFinishRunLoopInitialization]):
607         (-[RunLoopThread start]):
608         (-[RunLoopThread join]):
609         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
610         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
611         (scriptInputSourceScheduleRoutine):
612         (scriptInputSourcePerformRoutine):
613         (scriptInputSourceCancelRoutine):
614         (-[ScriptInputSource initWithContext:]):
615         (-[ScriptInputSource dealloc]):
616         (-[ScriptInputSource addToCurrentRunLoop]):
617         (-[ScriptInputSource removeFromRemoteRunLoop]):
618         (-[ScriptInputSource didReceiveScript:]):
619         (-[ScriptInputSource didReceiveSignal]):
620         (-[ScriptInputSource runScriptRemotely:]):
621         (-[ScriptInputSource finishAsyncCallback:withResult:]):
622         * jsc-cli/jsc-cli/main.m: Added.
623         (main):
624
625 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
626
627         Remove a FIXME comment that is already fixed.
628         https://bugs.webkit.org/show_bug.cgi?id=127468
629
630         Reviewed by Csaba Osztrogonác.
631
632         * Scripts/webkitpy/style/filereader.py:
633         (TextFileReader.__init__):
634
635 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
636
637         [GLIB] Use GUniquePtr instead of GOwnPtr
638         https://bugs.webkit.org/show_bug.cgi?id=127431
639
640         Reviewed by Martin Robinson.
641
642         GUniquePtr is a template alias of std::unique_ptr with a custom
643         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
644         where the output pointer is needed, but it will also be replaced soon.
645
646         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
647         (printAccessibilityEvent):
648         (axObjectEventListener):
649         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
650         (indexRangeInTable):
651         (AccessibilityUIElement::role):
652         (AccessibilityUIElement::title):
653         (AccessibilityUIElement::description):
654         (AccessibilityUIElement::stringValue):
655         (AccessibilityUIElement::language):
656         (AccessibilityUIElement::lineForIndex):
657         (AccessibilityUIElement::selectedTextRange):
658         (AccessibilityUIElement::url):
659         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
660         (AccessibilityController::accessibleElementById):
661         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
662         (AccessibilityController::accessibleElementById):
663         * DumpRenderTree/gtk/DumpRenderTree.cpp:
664         (getOutputDir):
665         (getFontsPath):
666         (initializeFonts):
667         (dumpFramesAsText):
668         (compareHistoryItems):
669         (dumpHistoryItem):
670         (soupURIToStringPreservingPassword):
671         (resetDefaultsToConsistentValues):
672         (temporaryDatabaseDirectory):
673         (webViewTitleChanged):
674         (webFrameLoadStatusNotified):
675         (pathFromSoupURI):
676         (convertWebResourceToURLPath):
677         (urlSuitableForTestResult):
678         (descriptionSuitableForTestResult):
679         (willSendRequestCallback):
680         (frameLoadEventCallback):
681         * DumpRenderTree/gtk/EditingCallbacks.cpp:
682         (dumpNodePath):
683         (dumpRange):
684         (shouldApplyStyle):
685         * DumpRenderTree/gtk/EventSender.cpp:
686         (contextClickCallback):
687         (beginDragWithFilesCallback):
688         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
689         (TestRunner::pathToLocalResource):
690         (TestRunner::queueLoad):
691         (TestRunner::removeOriginAccessWhitelistEntry):
692         (TestRunner::setMockGeolocationPositionUnavailableError):
693         (TestRunner::setIconDatabaseEnabled):
694         (TestRunner::findString):
695         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
696         (TestRunner::overridePreference):
697         (TestRunner::addUserScript):
698         (TestRunner::addUserStyleSheet):
699         (TestRunner::setTextDirection):
700         * DumpRenderTree/gtk/TextInputController.cpp:
701         (setMarkedTextCallback):
702         (insertTextCallback):
703         (doCommandCallback):
704         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
705         (LoadHTMLStringItem::invoke):
706         * TestWebKitAPI/PlatformGTK.cmake:
707         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
708         (WebKitDOMNodeTest::testTagNames):
709         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
710         (testBackForwardListLimitAndCache):
711         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
712         (testContextMenuSmartSeparators):
713         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
714         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
715         (testDownloadLocalFile):
716         (testDownloadLocalFileError):
717         (addContentDispositionHTTPHeaderToResponse):
718         (serverCallback):
719         (testDownloadRemoteFileError):
720         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
721         (startTestServer):
722         (testInspectorServerPageList):
723         (openRemoteDebuggingSession):
724         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
725         (testPrintOperationPrint):
726         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
727         (addCacheHTTPHeadersToResponse):
728         (serverCallback):
729         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
730         (httpsServerCallback):
731         (httpServerCallback):
732         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
733         (testWebViewJavaScriptDialogs):
734         (testWebViewWindowProperties):
735         (testWebViewFileChooserRequest):
736         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
737         (testWebExtensionWindowObjectCleared):
738         (testWebExtensionIsolatedWorld):
739         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
740         (startTestServer):
741         (checkAtspiAccessible):
742         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
743         (serverCallback):
744         (testClearDatabase):
745         (testGetFaviconURI):
746         (webkitFaviconDatabaseFinalizedCallback):
747         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
748         (testWebContextGetPlugins):
749         (testWebContextURIScheme):
750         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
751         (testWebViewRunJavaScript):
752         (testWebViewMode):
753         (testWebViewPageVisibility):
754         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
755         (isStyleSheetInjectedForURLAtPath):
756         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
757         (testWebViewEditorCutCopyPasteNonEditable):
758         (testWebViewEditorCutCopyPasteEditable):
759         (testWebViewEditorSelectAllNonEditable):
760         (testWebViewEditorSelectAllEditable):
761         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
762         (sendRequestCallback):
763         (methodCallCallback):
764         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
765         (TestWebKitAPI::Util::createInjectedBundlePath):
766         (TestWebKitAPI::Util::createURLForResource):
767         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
768         (TestWebKitAPI::doKeyStroke):
769         (TestWebKitAPI::doMouseButtonEvent):
770         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
771         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
772         (loadFailedCallback):
773         (LoadTrackingTest::loadURI):
774         (LoadTrackingTest::loadHtml):
775         (LoadTrackingTest::loadPlainText):
776         (LoadTrackingTest::loadRequest):
777         (LoadTrackingTest::reload):
778         (LoadTrackingTest::goBack):
779         (LoadTrackingTest::goForward):
780         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
781         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
782         (registerGResource):
783         (removeNonEmptyDirectory):
784         (main):
785         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
786         (Test::getWebKit1TestResoucesDir):
787         (Test::getResourcesDir):
788         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
789         (WebKitTestBus::run):
790         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
791         (WebKitTestServer::WebKitTestServer):
792         (WebKitTestServer::getURIForPath):
793         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
794         (WebProcessTestRunner::runTest):
795         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
796         (resourceGetDataCallback):
797         (WebViewTest::mainResourceData):
798         (WebViewTest::mouseMoveTo):
799         (WebViewTest::keyStroke):
800         (WebViewTest::doMouseButtonEvent):
801         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
802         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
803         (WTR::AccessibilityController::accessibleElementById):
804         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
805         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
806         (WTR::AccessibilityUIElement::role):
807         (WTR::AccessibilityUIElement::title):
808         (WTR::AccessibilityUIElement::description):
809         (WTR::AccessibilityUIElement::stringValue):
810         (WTR::AccessibilityUIElement::language):
811         (WTR::AccessibilityUIElement::lineForIndex):
812         (WTR::AccessibilityUIElement::selectedTextRange):
813         (WTR::AccessibilityUIElement::url):
814         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
815         (WTR::getOutputDir):
816         (WTR::getFontsPath):
817         (WTR::initializeFontConfigSetting):
818         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
819         (WTR::topLevelPath):
820         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
821         (WTR::TestRunner::pathToLocalResource):
822         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
823         (WTR::TestController::initializeInjectedBundlePath):
824         (WTR::TestController::initializeTestPluginDirectory):
825
826 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
827
828         [GTK] [CMake] run-webkit-tests should support the CMake build
829         https://bugs.webkit.org/show_bug.cgi?id=126503
830
831         Reviewed by Daniel Bates.
832
833         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
834         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
835
836         * Scripts/run-launcher: Work properly with the gtkcmake flag.
837         * Scripts/webkitpy/port/gtk.py:
838         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
839         file to detect a CMake build.
840         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
841         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
842         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
843         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
844         (GtkPort._path_to_driver): Use the new helper.
845         (GtkPort._path_to_image_diff): Use the new helper.
846         (GtkPort._path_to_webcore_library): Use the new helper.
847         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
848
849 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
850
851         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
852         https://bugs.webkit.org/show_bug.cgi?id=127417
853
854         Reviewed by Gyuyoung Kim.
855
856         * EWebLauncher/main.c:
857         (on_key_down): Removed shortcut to test pre render.
858
859 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
860
861         Remove CSS3_TEXT_DECORATION define
862         https://bugs.webkit.org/show_bug.cgi?id=127333
863
864         This is required for unprefixing the text-decoration-* CSS properties.
865
866         Reviewed by Simon Fraser.
867
868         * Configurations/FeatureDefines.xcconfig:
869
870 2014-01-22  Andy Estes  <aestes@apple.com>
871
872         [iOS] Prepare for upstreaming DumpRenderTree changes
873         https://bugs.webkit.org/show_bug.cgi?id=127412
874
875         Reviewed by Simon Fraser.
876
877         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
878         an application bundle. Instead of upstreaming a separate target for the
879         app that duplicates the 'Compile Sources' phase of the tool, separate
880         out the compilation into a static library target that both the
881         command-line tool and the app can link against. Also, perform some
882         unrelated cleanup.
883
884         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
885         project file format from 2.4- to 3.2-compatible. Removed the
886         'Copy Headers' build phase and removed all files from the
887         'Compile Sources' build phase of DumpRenderTree. Added some files that
888         were missing from the project. Created a 'DumpRenderTree (Library)'
889         target for building the static library and made the 'DumpRenderTree'
890         target depend on it. Added a 'Compile Sources' build phase to this
891         target that builds the same files the DumpRenderTree target used to.
892         Created DumpRenderTreeMain.mm as the only source file of the
893         DumpRenderTree target, since targets won't link a binary without at
894         least one source file. Made DumpRenderTree (Library) use
895         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
896         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
897         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
898         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
899         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
900         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
901         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
902         This is needed to correctly link a static library containing an Objective-C
903         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
904         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
905         * DumpRenderTree/mac/DumpRenderTree.mm:
906         (DumpRenderTreeMain): Renamed from main.
907         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
908         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
909         (main): Called DumpRenderTreeMain from main.
910
911 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
912
913         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
914         https://bugs.webkit.org/show_bug.cgi?id=127073
915
916         Reviewed by Daniel Bates.
917
918         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
919         the new isCMakeBuild conditional. This allows us to share more code between ports.
920         Pass the build arguments to the removeCMakeCache function.
921         * Scripts/webkitdirs.pm:
922         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
923         because it's now shared with the CMake build.
924         (cachedArgumentFileOutOfDate): Renamed.
925         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
926         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
927         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
928         as well as checking if build-webkit has been run with different arguments.
929         (removeCMakeCache): Call shouldRemoveCMakeCache now.
930         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
931         (isCMakeBuild): Added.
932
933 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
934
935         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
936         https://bugs.webkit.org/show_bug.cgi?id=127119
937
938         Reviewed by Mario Sanchez Prada.
939
940         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
941
942         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
943         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
944         * DumpRenderTree/gtk/DumpRenderTree.cpp:
945         (resetDefaultsToConsistentValues):
946         (webViewWindowObjectCleared):
947         (main):
948         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
949         (WTR::AccessibilityController::platformName):
950         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
951         (WTR::AccessibilityUIElement::isIndeterminate):
952
953 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
954
955
956         [GTK] Add GUniquePtr
957         https://bugs.webkit.org/show_bug.cgi?id=127170
958
959         Reviewed by Gustavo Noronha Silva.
960
961         Add unit tests for GUniquePtr.
962
963         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
964         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
965         (log):
966         (takeLogStr):
967         (TestWebKitAPI::TEST):
968
969 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
970
971         Remove Nix files from Tools
972         https://bugs.webkit.org/show_bug.cgi?id=127418
973
974         Reviewed by Csaba Osztrogonác.
975
976         * Scripts/build-webkit:
977         * Scripts/update-webkit-libs-jhbuild:
978         * Scripts/webkitdirs.pm:
979         (determineArchitecture):
980         (argumentsForConfiguration):
981         (jscProductDir):
982         (builtDylibPathForName):
983         (isAppleWebKit):
984         (launcherPath):
985         (launcherName):
986         (checkRequiredSystemConfig):
987         (copyInspectorFrontendFiles):
988         (jhbuildWrapperPrefixIfNeeded):
989         (buildCMakeProjectOrExit):
990         (cmakeBasedPortName):
991         * Scripts/webkitpy/common/config/ports.py:
992         (DeprecatedPort.port):
993         (EflWK2Port.build_webkit_command):
994         * Scripts/webkitpy/port/factory.py:
995         (platform_options):
996         (PortFactory):
997         * Scripts/webkitpy/port/nix.py: Removed.
998         * Scripts/webkitpy/port/nix_unittest.py: Removed.
999
1000 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
1001
1002         Add Ian and Ricky to the contributor list
1003
1004         * Scripts/webkitpy/common/config/contributors.json:
1005         I am too old to remember all those email addresses :)
1006
1007 2014-01-21  David Farler  <dfarler@apple.com>
1008
1009         Upstream package-root for iOS
1010
1011         Reviewed by Daniel bates.
1012
1013         * Scripts/package-root: Added.
1014         (usage):
1015         * Scripts/webkitdirs.pm:
1016         (XcodeSDKPath): Added function.
1017
1018 2014-01-21  Daniel Bates  <dabates@apple.com>
1019
1020         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
1021         https://bugs.webkit.org/show_bug.cgi?id=127368
1022
1023         Reviewed by Tim Horton.
1024
1025         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
1026         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
1027         Tools.
1028
1029         * Makefile:
1030
1031 2014-01-21  Daniel Bates  <dabates@apple.com>
1032
1033         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
1034         https://bugs.webkit.org/show_bug.cgi?id=127364
1035
1036         Reviewed by Simon Fraser.
1037
1038         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
1039         projects fail to build because we need to upstream the relevant iOS changes.
1040         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
1041         aren't building TestWebKitAPI.
1042
1043         * Scripts/build-webkit:
1044
1045 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1046
1047         Unreviewed, remove myself from some watchlist entries.
1048
1049         * Scripts/webkitpy/common/config/watchlist:
1050
1051 2014-01-21  Zalan Bujtas  <zalan@apple.com>
1052
1053         Use 64 as the default value for the subpixel denominator.
1054
1055         Reviewed by Simon Fraser.
1056
1057         * lldb/lldb_webkit.py:
1058         (WebCoreLayoutUnitProvider.to_string):
1059
1060 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
1061
1062         [GTK] Fix a c++11 compliance issue for fontconfig
1063         https://bugs.webkit.org/show_bug.cgi?id=127283
1064
1065         Reviewed by Martin Robinson.
1066
1067         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
1068         hotfix until bumping fontconfig up.
1069
1070         * gtk/jhbuild.modules:
1071         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1072
1073 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1074
1075         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
1076         like run_webkit_test does
1077         https://bugs.webkit.org/show_bug.cgi?id=127349
1078
1079         Reviewed by Csaba Osztrogonác.
1080
1081         * Scripts/run-jsc-stress-tests:
1082
1083 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
1084
1085         [GTK] Allow passing extra data to web extensions
1086         https://bugs.webkit.org/show_bug.cgi?id=125990
1087
1088         Reviewed by Carlos Garcia Campos.
1089
1090         Allow passing additional information to the injected bundle. On top
1091         of the string containing the path to the web extensions directory,
1092         a GVariant can be set with additional data using
1093         webkit_web_context_set_web_extensions_initialization_user_data().
1094         Also, a new initialize-web-extensions signal is emitted before
1095         launching a new WebProcess to allow setting different user data
1096         for each process. The GVariant is serialized as a string, passed
1097         to the injected bundle, and the injected bundle deserializes back
1098         the data, which is passed to web extensions which define the
1099         webkit_web_extension_initialize_with_user_data() function (for
1100         backwards compatibility, webkit_web_extension_initialize() is
1101         used as a fallback.)
1102
1103         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1104         (initializeWebExtensions): Handles the initialize-web-extensions
1105         signal, and sets the web extensions directory and the initialization
1106         user data.
1107         (testWebExtensionInitializationUserData): New test case for checking
1108         the user data passed on initialization to web extensions.
1109         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1110         (methodCallCallback): Added implementation for the
1111         GetInitializationUserData D-Bus method, used by
1112         testWebExtensionInitializationUserData().
1113         (webkit_web_extension_initialize_with_user_data): Define the
1114         initialization function with the additional user data parameter.
1115
1116 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
1117
1118         Change my email address in contributors.json.
1119
1120         Unreviewed.
1121
1122         * Scripts/webkitpy/common/config/contributors.json:
1123
1124 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
1125
1126         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
1127         https://bugs.webkit.org/show_bug.cgi?id=127291
1128
1129         Reviewed by Mario Sanchez Prada.
1130
1131         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
1132
1133         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1134         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1135         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1136         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1137
1138 2014-01-20  Zalan Bujtas  <zalan@apple.com>
1139
1140         Force float division when calculating CSS px value.
1141
1142         Reviewed by Simon Fraser.
1143
1144         Note that in Python 3, this is the default behavior.
1145
1146         * lldb/lldb_webkit.py:
1147         (WebCoreLayoutUnitProvider.to_string):
1148
1149 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1150
1151         build.webkit.org/dashboard should display information about patches in EWS
1152         https://bugs.webkit.org/show_bug.cgi?id=127006
1153
1154         Reviewed by Ryosuke Niwa.
1155
1156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
1158         (Bugzilla.prototype.detailsURLForAttachment):
1159         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
1160         which is needed when one wants to do something with a patch EWS is stuck on.
1161
1162         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1163         Create a Bugzilla instance.
1164
1165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1166         (EWS.prototype.jsonQueueLengthURL):
1167         (EWS.prototype.jsonQueueStatusURL):
1168         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
1169
1170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1171         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
1172         of second guessing.
1173         (EWSQueue.prototype.get chartsPageURL): Added.
1174         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
1175         additional data already loaded (it's reset with every update).
1176         (EWSQueue.prototype.get patches): Get patch queue.
1177         (EWSQueue.prototype.get bots): Get bots.
1178         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
1179         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
1180
1181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1182         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
1183         in the queue.
1184         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
1185         (EWSQueueView.prototype.addTextToRow): Ditto.
1186         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
1187         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
1188         (EWSQueueView.prototype._addDividerToPopover): Ditto.
1189         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
1190         relative string.
1191         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
1192         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
1193         it when done.
1194
1195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1196         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
1197         Changed a few difficult to read padding styles to padding-left.
1198
1199 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1200
1201         Fix webkitpy tests.
1202
1203         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
1204         Added a mock implementation, as we now call this function.
1205
1206 2014-01-20  Darin Adler  <darin@apple.com>
1207
1208         Update style checker and tests to deal with override instead of OVERRIDE
1209         https://bugs.webkit.org/show_bug.cgi?id=127175
1210
1211         Reviewed by Anders Carlsson.
1212
1213         * Scripts/webkitpy/style/checkers/cpp.py:
1214         (check_braces): Use override instead of OVERRIDE.
1215         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1216         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
1217
1218 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1219
1220         EWS should provide better information to Dashboard via JSON
1221         https://bugs.webkit.org/show_bug.cgi?id=127265
1222
1223         Reviewed by Ryosuke Niwa.
1224
1225         * QueueStatusServer/app.yaml: Updated version.
1226
1227         * QueueStatusServer/main.py:
1228         * QueueStatusServer/handlers/queuelengthjson.py:
1229         Added a way to cheaply get only the queue length, which is all the dashboard
1230         needs unless a popover is opened.
1231
1232         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
1233         that we will need. Changed some field names to be more meaningful. Fixed bot listing
1234         to understand that a bot can be reprurposed and used in a different queue.
1235
1236 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1237
1238         Make uploading results to EWS work despite robots.txt
1239         https://bugs.webkit.org/show_bug.cgi?id=127296
1240
1241         Reviewed by Ryosuke Niwa.
1242
1243         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
1244         checking robots.txt.
1245
1246         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
1247         Removed a comment saying that we would want to stop doing this. Not checking
1248         robots.txt is more efficient than checking it.
1249
1250 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
1251
1252         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
1253         https://bugs.webkit.org/show_bug.cgi?id=127214
1254
1255         Reviewed by Gyuyoung Kim.
1256
1257         Followed the changes of API.
1258
1259         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1260         (drtViewAdd):
1261         * EWebLauncher/main.c:
1262         (windowCreate):
1263
1264 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
1265
1266         [EFL][WK2] Add touch events option to MiniBrowser.
1267         https://bugs.webkit.org/show_bug.cgi?id=127262
1268
1269         Reviewed by Gyuyoung Kim.
1270
1271         As a default, touch events are disabled and mouse events are enabled.
1272         If touch events option sets to true, touch events are enabled and mouse
1273         events are disabled.
1274
1275         * MiniBrowser/efl/main.c:
1276         (window_create):
1277         (elm_main):
1278
1279 2014-01-19  Zalan Bujtas  <zalan@apple.com>
1280
1281         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
1282         https://bugs.webkit.org/show_bug.cgi?id=126080
1283
1284         Reviewed by Sam Weinig.
1285
1286         This changes the output of printing LayoutUnits to be in px but it also
1287         preserves the original LayoutUnit value.
1288
1289         This will lead to lldb output like: (and it works even when subpixel is disabled)
1290
1291         (const WebCore::LayoutRect) $0 = {
1292             m_location = { x = 2.25px (144), y = 1px (64)}
1293             m_size = { width = 13.75px (880), height = 20px (1280) }
1294
1295
1296         And gdb output like:
1297
1298         m_frameRect = {
1299             m_location = LayoutPoint(0px (0), 0px(0)),
1300             m_size = LayoutSize(8px (512), 5px (320))
1301         }
1302
1303         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
1304
1305         * gdb/webkit.py:
1306         (WebCoreLayoutUnitPrinter):
1307         (WebCoreLayoutUnitPrinter.__init__):
1308         (WebCoreLayoutUnitPrinter.to_string):
1309         (WebCoreLayoutSizePrinter):
1310         (WebCoreLayoutSizePrinter.__init__):
1311         (WebCoreLayoutSizePrinter.to_string):
1312         (WebCoreLayoutPointPrinter):
1313         (WebCoreLayoutPointPrinter.__init__):
1314         (WebCoreLayoutPointPrinter.to_string):
1315         (add_pretty_printers):
1316         * lldb/lldb_webkit.py:
1317         (__lldb_init_module):
1318         (WebCoreLayoutUnit_SummaryProvider):
1319         (WebCoreLayoutSize_SummaryProvider):
1320         (WebCoreLayoutPoint_SummaryProvider):
1321         (WebCoreLayoutUnitProvider):
1322         (WebCoreLayoutUnitProvider.__init__):
1323         (WebCoreLayoutUnitProvider.to_string):
1324         (WebCoreLayoutSizeProvider):
1325         (WebCoreLayoutSizeProvider.__init__):
1326         (WebCoreLayoutSizeProvider.get_width):
1327         (WebCoreLayoutSizeProvider.get_height):
1328         (WebCoreLayoutPointProvider):
1329         (WebCoreLayoutPointProvider.__init__):
1330         (WebCoreLayoutPointProvider.get_x):
1331         (WebCoreLayoutPointProvider.get_y):
1332
1333 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1334
1335         Add robots.txt to http://webkit-queues.appspot.com
1336         https://bugs.webkit.org/show_bug.cgi?id=127240
1337
1338         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
1339
1340 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1341
1342         Add robots.txt to http://webkit-queues.appspot.com
1343         https://bugs.webkit.org/show_bug.cgi?id=127240
1344
1345         Reviewed by Ryosuke Niwa.
1346
1347         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
1348
1349         * QueueStatusServer/robots.txt: Added.
1350
1351 2014-01-18  Alberto Garcia  <berto@igalia.com>
1352
1353         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
1354         https://bugs.webkit.org/show_bug.cgi?id=127217
1355
1356         Reviewed by Daniel Bates.
1357
1358         The syntax File::Temp->tempdir() was explicitly made invalid
1359         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
1360         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
1361
1362         Use File::Temp::tempdir() instead.
1363
1364         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1365
1366 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1367
1368         build.webkit.org/dashboard should have image diff links in test results popovers
1369         https://bugs.webkit.org/show_bug.cgi?id=127188
1370
1371         Reviewed by Timothy Hatcher.
1372
1373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1374         (Buildbot.prototype.layoutTestImagesURLForIteration):
1375         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
1376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1377         (BuildbotIteration.prototype.loadLayoutTestResults):
1378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1379         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
1380         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
1381         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1382
1383 2014-01-18  Anders Carlsson  <andersca@apple.com>
1384
1385         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
1386         https://bugs.webkit.org/show_bug.cgi?id=127225
1387
1388         Reviewed by Andreas Kling.
1389
1390         This concludes the removal of over 8.8 million lines of threaded parser code.
1391
1392         * Scripts/webkitperl/FeatureList.pm:
1393
1394 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
1395
1396         build.webkit.org/dashboard should have diff links in test results popovers
1397         https://bugs.webkit.org/show_bug.cgi?id=126986
1398
1399         Reviewed by Tim Horton.
1400
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1402         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
1403         (Buildbot.prototype.layoutTestStderrURLForIteration):
1404         (Buildbot.prototype.layoutTestDiffURLForIteration):
1405         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
1406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1407         (BuildbotIteration.prototype.loadLayoutTestResults):
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1409         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1410
1411 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
1412
1413         Add the bare minimum support for branches to the bot-watchers dashboard
1414         https://bugs.webkit.org/show_bug.cgi?id=127124
1415
1416         This patch simply introduces the notion of branches into the bot-watchers dashboard.
1417         Subsequent patches will build functionality on top of this simple bit of infrastructure.
1418
1419         Reviewed by Timothy Hatcher.
1420
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1422         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
1423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1424         Initialize the Dashboard.Branch object
1425
1426 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
1427
1428         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1429         https://bugs.webkit.org/show_bug.cgi?id=127141
1430
1431         Reviewed by Alexey Proskuryakov.
1432
1433         Make sure to reset the notification handler each time.
1434
1435         * DumpRenderTree/AccessibilityController.cpp:
1436         (AccessibilityController::resetToConsistentState):
1437         * DumpRenderTree/AccessibilityController.h:
1438         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1439         (AccessibilityController::platformResetToConsistentState):
1440         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1441         (AccessibilityController::platformResetToConsistentState):
1442         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1443         (AccessibilityController::~AccessibilityController):
1444         (AccessibilityController::platformResetToConsistentState):
1445         (AccessibilityController::removeNotificationListener):
1446         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1447         (AccessibilityController::platformResetToConsistentState):
1448
1449 2014-01-17  Alberto Garcia  <berto@igalia.com>
1450
1451         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
1452         https://bugs.webkit.org/show_bug.cgi?id=82329
1453
1454         Reviewed by Carlos Garcia Campos.
1455
1456         Unskip, this is working fine now.
1457
1458         * Scripts/run-gtk-tests:
1459         (TestRunner):
1460
1461 2014-01-17  Alberto Garcia  <berto@igalia.com>
1462
1463         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
1464         https://bugs.webkit.org/show_bug.cgi?id=82328
1465
1466         Reviewed by Carlos Garcia Campos.
1467
1468         This was caused by the icon database being corrupted in the
1469         Release bot. After removing it the test works fine so it can be
1470         run again.
1471
1472         * Scripts/run-gtk-tests:
1473         (TestRunner):
1474
1475 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
1476
1477         Test results popovers at http://build.webkit.org/dashboard should link to stderr
1478         https://bugs.webkit.org/show_bug.cgi?id=126929
1479
1480         Reviewed by Timothy Hatcher.
1481
1482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1483         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
1484         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
1485
1486         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1487         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
1488
1489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1490         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1491         Add a link to stderr output if present.
1492
1493         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1494         (.test-results-popover .additional-link): Style with light grey (will use the same style
1495         for diff links).
1496
1497 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1498
1499         Automate DoYouEvenBench
1500         https://bugs.webkit.org/show_bug.cgi?id=124497
1501
1502         Reviewed by Geoffrey Garen.
1503
1504         * Scripts/webkitpy/performance_tests/perftest.py:
1505         (PerfTestMetric.__init__): Added the aggregator name as an argument.
1506         (PerfTestMetric.aggregator): Added.
1507         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
1508         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
1509         should be parsed as the metric and the aggregator respectively.
1510         (PerfTest._run_with_driver): Pass in the aggregator name.
1511         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
1512         which generates subtests of subtests within a single test file.
1513
1514         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1515         (test_parse_output_with_subtests_and_total): Added.
1516
1517         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1518         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
1519
1520         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1521         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
1522
1523 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
1524
1525         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1526         https://bugs.webkit.org/show_bug.cgi?id=127141
1527
1528         Reviewed by Alexey Proskuryakov.
1529
1530         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
1531
1532         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1533         (AccessibilityController::~AccessibilityController):
1534
1535 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1536
1537         EWS shouldn't comment on Bugzilla for failing builds or style errors
1538         https://bugs.webkit.org/show_bug.cgi?id=127079
1539
1540         Reviewed by Anders Carlsson.
1541
1542         Since patch authors and reviewers could retrieve this information from bubbles,
1543         we shouldn't spam the Bugzilla with useless comments.
1544
1545         We still post style errors but not python paths we used since it's a pure noise.
1546
1547         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1548         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1549         * Scripts/webkitpy/tool/commands/queues.py:
1550         (StyleQueue.review_patch):
1551
1552 2014-01-15  Roger Fong  <roger_fong@apple.com>
1553
1554         Add support for handling WebGL load policies.
1555         https://bugs.webkit.org/show_bug.cgi?id=126935
1556         <rdar://problem/15790448>.
1557
1558         Reviewed by Timothy Horton.
1559
1560         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
1561         (WTR::TestController::createWebViewWithOptions):
1562
1563 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1564
1565         Remove workaround for compilers not supporting explicit override control
1566         https://bugs.webkit.org/show_bug.cgi?id=127111
1567
1568         Reviewed by Anders Carlsson.
1569
1570         Now all compilers support explicit override control, this workaround can be removed.
1571
1572         * DumpRenderTree/gtk/fonts/fonts.conf:
1573         * Scripts/do-webcore-rename:
1574         Removed this rename operation from the list of contemplated future renames.
1575         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1576         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1577         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1578         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1579         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1580
1581 2014-01-16  Oliver Hunt  <oliver@apple.com>
1582
1583         Stop run-jsc from consuming stderr output
1584         https://bugs.webkit.org/show_bug.cgi?id=127115
1585
1586         Reviewed by Mark Lam.
1587
1588         Simple patch to make run-jsc easier to deal with
1589
1590         * Scripts/run-jsc:
1591
1592 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
1593
1594         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
1595         https://bugs.webkit.org/show_bug.cgi?id=126323
1596
1597         Reviewed by Csaba Osztrogonác.
1598
1599         * gtk/generate-feature-defines-files:
1600
1601 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1602
1603         [EFL][WK2] Implement TestController::setHidden
1604         https://bugs.webkit.org/show_bug.cgi?id=127036
1605
1606         Reviewed by Gyuyoung Kim.
1607
1608         WebKitTestRunner needs TestController::setHidden implementation to
1609         properly handle page visibility API layout tests after r161105.
1610
1611         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1612         (WTR::TestController::setHidden):
1613
1614 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
1615
1616         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
1617         https://bugs.webkit.org/show_bug.cgi?id=127083
1618
1619         Reviewed by Carlos Garcia Campos.
1620
1621         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
1622         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
1623
1624         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
1625         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
1626         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
1627         BrowserWindow object is being finalized, preventing the callback from firing.
1628
1629         * MiniBrowser/gtk/BrowserWindow.c:
1630         (resetEntryProgress):
1631         (webViewLoadProgressChanged):
1632         (browserWindowFinalize):
1633
1634 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
1635
1636         DumpRenderTree doesn't disable web preferences autosave
1637         https://bugs.webkit.org/show_bug.cgi?id=127062
1638
1639         Reviewed by Dan Bernstein.
1640
1641         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1642         Do it.
1643
1644 2014-01-15  Dean Jackson  <dino@apple.com>
1645
1646         Improve filter-build-webkit, especially for iOS builds
1647         https://bugs.webkit.org/show_bug.cgi?id=81046
1648
1649         Reviewed by Joseph Pecoraro.
1650
1651         Lots of updates to the filtering rules, mostly from the
1652         iOS build output. Other highlights include:
1653         - ignoring escape sequences for color ouput
1654         - detecting escaped spaces in file name regexps
1655
1656         * Scripts/filter-build-webkit:
1657         (shouldIgnoreLine):
1658
1659 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1660
1661         [GTK] Web process sometimes crashes when printing in synchronous mode
1662         https://bugs.webkit.org/show_bug.cgi?id=126979
1663
1664         Reviewed by Gustavo Noronha Silva.
1665
1666         * Scripts/run-gtk-tests:
1667         (TestRunner): Unskip
1668         /webkit2/WebKitPrintOperation/close-after-print.
1669
1670 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
1671
1672         [EFL] Change test font installed path to webkitgtk-font-tests
1673         https://bugs.webkit.org/show_bug.cgi?id=126723
1674
1675         Reviewed by Gyuyoung Kim.
1676
1677         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
1678         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
1679         hard-coded in FontManagement.cpp#105
1680
1681         * DumpRenderTree/PlatformEfl.cmake:
1682         * WebKitTestRunner/PlatformEfl.cmake:
1683         * efl/jhbuild.modules:
1684
1685 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
1686
1687         Make DoYouEvenBench runnable by run-perf-tests
1688         https://bugs.webkit.org/show_bug.cgi?id=127030
1689
1690         Reviewed by Andreas Kling.
1691
1692         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
1693         ":Total" to appear at the end of a test name. We don't do anything with it for now.
1694
1695         * Scripts/webkitpy/performance_tests/perftest.py:
1696         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
1697         to the JSON in a follow up patch for the perf dashboard.
1698         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
1699
1700 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1701
1702         [GTK] UI process crashes when the web process crashes while printing
1703         https://bugs.webkit.org/show_bug.cgi?id=126977
1704
1705         Reviewed by Gustavo Noronha Silva.
1706
1707         Add new test case to check that closing the window right after
1708         printing works. It's skipped for now, because this patch only
1709         fixes the UI process crash, but not the web process one.
1710
1711         * Scripts/run-gtk-tests:
1712         (TestRunner): Skip
1713         /webkit2/WebKitPrintOperation/close-after-print.
1714         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1715         (testPrintOperationPrintPrinter):
1716         (findPrintToFilePrinter):
1717         (testPrintOperationPrint):
1718         (testPrintOperationErrors):
1719         (testPrintOperationCloseAfterPrint):
1720         (beforeAll):
1721
1722 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
1723
1724         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
1725         https://bugs.webkit.org/show_bug.cgi?id=127002
1726
1727         Reviewed by David Kilzer.
1728
1729         * Scripts/webkitdirs.pm:
1730         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
1731
1732 2014-01-14  Commit Queue  <commit-queue@webkit.org>
1733
1734         Unreviewed, rolling out r162000.
1735         http://trac.webkit.org/changeset/162000
1736         https://bugs.webkit.org/show_bug.cgi?id=127009
1737
1738         API versioning is wrong (Requested by rfong on #webkit).
1739
1740         * MiniBrowser/mac/WK2BrowserWindowController.m:
1741         (-[WK2BrowserWindowController awakeFromNib]):
1742         * WebKitTestRunner/TestController.cpp:
1743         (WTR::TestController::createOtherPage):
1744         (WTR::TestController::createWebViewWithOptions):
1745
1746 2014-01-13  Roger Fong  <roger_fong@apple.com>
1747
1748         Add support for handling WebGL load policies.
1749         https://bugs.webkit.org/show_bug.cgi?id=126935
1750         <rdar://problem/15790448>.
1751
1752         Reviewed by Brent Fulgham.
1753
1754         * MiniBrowser/mac/WK2BrowserWindowController.m:
1755         (-[WK2BrowserWindowController awakeFromNib]):
1756         * WebKitTestRunner/TestController.cpp:
1757         (WTR::TestController::createWebViewWithOptions):
1758
1759 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
1760
1761         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
1762         https://bugs.webkit.org/show_bug.cgi?id=120110
1763
1764         Reviewed by Martin Robinson.
1765
1766         Skip the FontConfig settings initialization in WebKitTestRunner if the
1767         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
1768         This is useful when profiling the WebKitTestRunner execution, where at the startup
1769         this step takes considerable amount of time and disturbs the profiling output.
1770
1771         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1772         (WTR::initializeFontConfigSetting):
1773
1774 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
1775
1776         Add ENABLE(WEB_REPLAY) feature flag to the build system
1777         https://bugs.webkit.org/show_bug.cgi?id=126949
1778
1779         Reviewed by Joseph Pecoraro.
1780
1781         * Scripts/webkitperl/FeatureList.pm:
1782
1783 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
1784
1785         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
1786         https://bugs.webkit.org/show_bug.cgi?id=126702
1787
1788         Reviewed by Alexey Proskuryakov.
1789
1790         Resolve regression and remove a FIXME comment that is already fixed.
1791
1792         * Scripts/webkitpy/common/system/filesystem.py:
1793         (FileSystem.open_text_file_for_reading):
1794         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1795         (RealFileSystemTest.test_read_and_write_file):
1796         * Scripts/webkitpy/style/filereader.py:
1797         (TextFileReader._read_lines):
1798         * Scripts/webkitpy/style/filereader_unittest.py:
1799         (TextFileReaderTest.test_count_delete_only_file):
1800         (TextFileReaderTest):
1801         (TextFileReaderTest.test_process_malformed_file):
1802
1803 2014-01-02  Brian Holt  <brian.holt@samsung.com>
1804
1805         [GTK] Parse Valgrind xml leak files
1806         https://bugs.webkit.org/show_bug.cgi?id=119446
1807
1808         Reviewed by Alejandro G. Castro.
1809
1810         Parse the xml files generated by Valgrind to yield useful
1811         information about the memory leaks.
1812
1813         * Scripts/webkitpy/port/gtk.py:
1814         (GtkPort.__init__):
1815         (GtkPort.setup_test_run): Clear the previous output files before new
1816         run.
1817         (GtkPort.print_leaks_summary):
1818
1819         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
1820         Parse the xml files generated by Valgrind and summarise leaks
1821         into an easily understandable list.
1822         (get_text_of):
1823         (get_CDATA_of):
1824         (gather_frames):
1825         (ValgrindError):
1826         (ValgrindError.__init__):
1827         (ValgrindError.__str__):
1828         (ValgrindError.unique_string):
1829         (ValgrindError.error_hash):
1830         (ValgrindError.__hash__):
1831         (ValgrindError.__eq__):
1832         (LeakDetectorValgrind):
1833         (LeakDetectorValgrind.__init__):
1834         (LeakDetectorValgrind._parse_leaks_output):
1835         (LeakDetectorValgrind.leaks_files_in_results_directory):
1836         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
1837         (LeakDetectorValgrind.parse_and_print_leaks_detail):
1838
1839         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
1840         (make_mock_valgrind_output):
1841         (make_mock_incomplete_valgrind_output):
1842         (make_mock_valgrind_results):
1843         (make_mock_valgrind_results_incomplete):
1844         (make_mock_valgrind_results_empty):
1845         (make_mock_valgrind_results_misformatted):
1846         (mock_run_cppfilt_command):
1847         (LeakDetectorValgrindTest):
1848         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
1849         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
1850         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
1851         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
1852         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
1853         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
1854         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
1855         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
1856
1857 2014-01-13  Lucas Forschler  <lforschler@apple.com>
1858
1859         Update the LLINT CLoop Bot build infrastructure
1860         https://bugs.webkit.org/show_bug.cgi?id=126604
1861         
1862         Unreviewed.
1863         
1864         * BuildSlaveSupport/build.webkit.org-config/config.json:
1865         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1866         (CompileLLINTCLoop):
1867         (RunLLINTCLoopTests):
1868         (BuildAndTestLLINTCLoopFactory):
1869         (BuildAndTestLLINTCLoopFactory.__init__):
1870
1871 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
1872
1873         [EFL][WK2] Disable failing API tests
1874         https://bugs.webkit.org/show_bug.cgi?id=126960
1875
1876         Reviewed by Gyuyoung Kim.
1877
1878         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
1879
1880         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1881         (TestWebKitAPI::TEST):
1882
1883 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
1884
1885         Remove wdiff
1886         https://bugs.webkit.org/show_bug.cgi?id=124766
1887
1888         Reviewed by Ryosuke Niwa.
1889
1890         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1891         (ResultsJSONParserTest):
1892         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1893         (TestResultWriter):
1894         (TestResultWriter.create_text_diff_and_write_result):
1895         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1896         (summarize_results):
1897         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1898         (RunTest.test_output_diffs):
1899         * Scripts/webkitpy/port/base.py:
1900         (Port.__init__):
1901         (Port.driver_stop_timeout):
1902         (Port.check_image_diff):
1903         (Port.repository_paths):
1904         (Port._path_to_lighttpd_php):
1905         * Scripts/webkitpy/port/base_unittest.py:
1906         (PortTest.test_default_child_processes):
1907         (PortTest.test_pretty_patch_script_error):
1908         * Scripts/webkitpy/port/port_testcase.py:
1909         (PortTestCase.test_diff_image_crashed):
1910         * Scripts/webkitpy/port/test.py:
1911         (TestPort.operating_system):
1912
1913 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
1914
1915         Build fix for the GTK+ CMake port
1916
1917         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
1918
1919 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
1920
1921         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
1922         https://bugs.webkit.org/show_bug.cgi?id=126881
1923
1924         Reviewed by Carlos Garcia Campos.
1925
1926         * MiniBrowser/gtk/BrowserWindow.c:
1927         (browser_window_new):
1928         Explicitly cast GtkWindow** to gpointer* in call to
1929         g_object_add_weak_pointer to avoid compiler warnings.
1930
1931 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1932
1933         Remove parsing of old-run-webkit-tests output from master.cfg
1934         https://bugs.webkit.org/show_bug.cgi?id=126690
1935
1936         Reviewed by Csaba Osztrogonác.
1937
1938         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1939         Removed parsing of ORWT output, as it is not used anymore.
1940         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1941         Updated unit tests accordingly.
1942
1943 2014-01-13  Commit Queue  <commit-queue@webkit.org>
1944
1945         Unreviewed, rolling out r161808.
1946         http://trac.webkit.org/changeset/161808
1947         https://bugs.webkit.org/show_bug.cgi?id=126874
1948
1949         This patch make several files to be always regenerated on
1950         every make (Requested by KaL on #webkit).
1951
1952         * WebKitTestRunner/GNUmakefile.am:
1953
1954 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
1955
1956         [GTK] Make MiniBrowser windows non-transient by default
1957         https://bugs.webkit.org/show_bug.cgi?id=126840
1958
1959         Reviewed by Carlos Garcia Campos.
1960
1961         Instead of making new browser windows transient as soon as they are
1962         created, save the pointer to the parent window and set the transient
1963         state later on when handling the "run-as-modal" signal. This makes
1964         it easier to use the MiniBrowser to do tests involving multiple
1965         windows, and will be useful as well when multi-web-process mode is
1966         enabled for the GTK port.
1967
1968         * MiniBrowser/gtk/BrowserWindow.c:
1969         (webViewRunAsModal): Set the parent window using
1970         gtk_window_set_transient_for() using the saved parent
1971         window.
1972         (browser_window_new): Save the parent window using
1973         g_object_set_data() instead of making the new window
1974         transient immediately.
1975
1976 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
1977
1978         [EFL][WK2] Make API tests work again
1979         https://bugs.webkit.org/show_bug.cgi?id=126769
1980
1981         Reviewed by Gyuyoung Kim.
1982
1983         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
1984         [E]WebKit2, respectively, and this causes problems because the logic to find
1985         where WebProcess is to look in the same directory of the running process and
1986         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
1987
1988         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
1989         Gtk port, which allows us to look for WebProcess initially in this directory,
1990         if it's defined.
1991
1992         * TestWebKitAPI/efl/main.cpp:
1993         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
1994
1995 2014-01-12  Daniel Bates  <dabates@apple.com>
1996
1997         [iOS] Fix the build
1998
1999         For now, ensure we build WebKit System Interface before we build WebKit.
2000         We'll remove this constraint and the constraint to build WebKit Additions
2001         in a subsequent commit.
2002
2003         * Scripts/build-webkit:
2004
2005 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2006
2007         Unreviewed. Fix make distcheck.
2008
2009         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
2010         to EXTRA_DIST.
2011
2012 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
2013
2014         --disable-dependency-tracking causes build failure due to missing directories
2015         https://bugs.webkit.org/show_bug.cgi?id=94488
2016
2017         Reviewed by Gustavo Noronha Silva.
2018
2019         Autotools build fix: Ensure output directory existing
2020         before generating DerivedSources. This allows for
2021         --disable-dependency-tracking to be run.
2022
2023
2024         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
2025
2026 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2027
2028         [GTK] Fix return value of WebKitDownload::created-destination
2029         https://bugs.webkit.org/show_bug.cgi?id=126741
2030
2031         Reviewed by Martin Robinson.
2032
2033         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
2034         value of several callbacks.
2035
2036 2014-01-11  Sam Weinig  <sam@webkit.org>
2037
2038         Add support for null StringViews
2039         https://bugs.webkit.org/show_bug.cgi?id=126827
2040
2041         Reviewed by Anders Carlsson.
2042
2043         Add new test for StringView.
2044
2045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2046         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
2047         (TestWebKitAPI::TEST):
2048
2049 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2050
2051         Remove the BlackBerry port from trunk
2052         https://bugs.webkit.org/show_bug.cgi?id=126715
2053
2054         Reviewed by Anders Carlsson.
2055
2056         * DumpRenderTree/DumpRenderTree.h:
2057         * DumpRenderTree/PixelDumpSupport.cpp:
2058
2059 2014-01-10  Daniel Bates  <dabates@apple.com>
2060
2061         [iOS] Fix project build order
2062
2063         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
2064         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
2065         time of writing.
2066
2067         * Scripts/build-webkit:
2068
2069 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2070
2071         Move platformName property from testRunner to accessibilityController
2072         https://bugs.webkit.org/show_bug.cgi?id=126689
2073
2074         Reviewed by Chris Fleizach.
2075
2076         Move the platformName property from the testRunner into
2077         accessibilityController, since this is a concept that has only be
2078         used by accessibility tests since it got added, and also because
2079         the real intention was not to distinguish among "ports" (mac, win,
2080         gtk, efl) but between platforms (atk, mac, win).
2081
2082         This change will be very useful to merge GTK's roles-exposed.html
2083         and Mac's role-subrole-roledescription.html into one single test,
2084         since we will be specifying in the test itself which elements are
2085         supported in which accessibility "platform". In this context,
2086         being able to check accessibilityController.platformName directly
2087         against a list of supported accessibility platforms (e.g. "atk,mac")
2088         will certainly maintain the code cleaner and simpler.
2089
2090         * DumpRenderTree/TestRunner.h:
2091         (TestRunner::platformName): Removed.
2092         * DumpRenderTree/TestRunner.cpp:
2093         (getPlatformNameCallback): Removed.
2094         (TestRunner::staticValues): Removed platformName
2095         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2096         (TestRunner::platformName): Removed.
2097         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2098         (TestRunner::platformName): Removed.
2099         * DumpRenderTree/mac/TestRunnerMac.mm:
2100         (TestRunner::platformName): Removed.
2101         * DumpRenderTree/win/TestRunnerWin.cpp:
2102         (TestRunner::platformName): Removed.
2103
2104         * DumpRenderTree/AccessibilityController.h:
2105         (AccessibilityController::platformName): Added.
2106         * DumpRenderTree/AccessibilityController.cpp:
2107         (getPlatformNameCallback): Added.
2108         (AccessibilityController::getJSClass): Added platformName.
2109         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2110         (AccessibilityController::platformName): Added, returning "atk".
2111         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2112         (AccessibilityController::platformName): Ditto, returning "mac".
2113         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2114         (AccessibilityController::platformName): Ditto, returning "ios".
2115         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2116         (AccessibilityController::platformName): Ditto, returning "win".
2117
2118         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2119         (platformName): Removed.
2120         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2121         (TestRunner::platformName): Removed.
2122         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2123         (TestRunner::platformName): Removed.
2124         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2125         (TestRunner::platformName): Removed.
2126         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2127         (TestRunner::platformName): Removed.
2128         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2129         (TestRunner::platformName): Removed.
2130
2131         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2132         (WTR:AccessibilityController::platformName): Added.
2133         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2134         (platformName): Added.
2135         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2136         (WTR::AccessibilityController::platformName): Added, returning "atk".
2137         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2138         (WTR::AccessibilityController::platformName): Added, returning "mac".
2139
2140 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2141
2142         Remove the BlackBerry port from trunk
2143         https://bugs.webkit.org/show_bug.cgi?id=126715
2144
2145         Reviewed by Anders Carlsson.
2146
2147         * Scripts/webkitpy/common/config/watchlist:
2148
2149 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
2150
2151         Remove the BlackBerry files outside WebCore
2152         https://bugs.webkit.org/show_bug.cgi?id=126715
2153
2154         Reviewed by Anders Carlsson.
2155
2156         * DumpRenderTree/blackberry: Removed.
2157
2158 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
2159
2160         Remove knowledge of Blackberry from build scripts
2161         https://bugs.webkit.org/show_bug.cgi?id=126766
2162
2163         Reviewed by Anders Carlsson.
2164         
2165         Remove isBlackBerry() and references to it, and rmeove
2166         blackberry-related stuff from the watchlist.
2167
2168         * Scripts/build-webkit:
2169         * Scripts/webkit-build-directory:
2170         * Scripts/webkitdirs.pm:
2171         (determineBaseProductDir):
2172         (argumentsForConfiguration):
2173         (builtDylibPathForName):
2174         (isAppleWebKit):
2175         (buildCMakeProjectOrExit):
2176         (cmakeBasedPortArguments):
2177         (cmakeBasedPortName):
2178         * Scripts/webkitperl/FeatureList.pm:
2179         * Scripts/webkitpy/common/config/watchlist:
2180
2181 2014-01-10  Daniel Bates  <dabates@apple.com>
2182
2183         [iOS] Fix up simulator build and enable default features
2184
2185         Rubber-stamped by Joseph Pecoraro.
2186
2187         * Scripts/webkitdirs.pm:
2188         (determineArchitecture):
2189         (determinePassedArchitecture):
2190         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
2191         by default only in iOS).
2192
2193 2014-01-10  Daniel Bates  <dabates@apple.com>
2194
2195         [iOS] Upstream WebCore and Tools miscellaneous changes
2196         https://bugs.webkit.org/show_bug.cgi?id=126698
2197
2198         Reviewed by David Kilzer.
2199
2200         * Scripts/check-for-inappropriate-objc-class-names:
2201         * Scripts/check-for-webkit-framework-include-consistency:
2202
2203 2014-01-09  Dan Bernstein  <mitz@apple.com>
2204
2205         [Cocoa] Promote WKBackForwardList{,Item}.h to public
2206         https://bugs.webkit.org/show_bug.cgi?id=126707
2207
2208         Reviewed by Sam Weinig.
2209
2210         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
2211         left behind in the build products directory after a private header is made public.
2212
2213 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2214
2215         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
2216         https://bugs.webkit.org/show_bug.cgi?id=126686
2217
2218         Reviewed by Martin Robinson.
2219
2220         Test that partial files are not left on disk after a download has
2221         been cancelled after the destination has been decided. To make
2222         sure the download is cancelled after the destination has been
2223         decided and before the operation finishes, we cancel the download
2224         in the destination decided callback, and we use an infinite
2225         resource that writes chunks to the response body and never
2226         completes the body.
2227
2228         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2229         (addContentDispositionHTTPHeaderToResponse): Helper function to
2230         add the Content-Disposition to the response headers.
2231         (writeNextChunkIdle): Write next chunk to response body.
2232         (writeNextChunk): Write next chunk in an idle to avoid flooding
2233         the network with the inifnite resource.
2234         (serverCallback): Add an inifinite resource.
2235         (testDownloadRemoteFileError): Check that partial file is not
2236         present after the download has been cancelled.
2237
2238 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
2239
2240         Move myself to the committers list.
2241
2242         Unreviewed.
2243
2244         * Scripts/webkitpy/common/config/contributors.json:
2245
2246 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2247
2248         [GTK] Unreviewed build fix after r161522.
2249
2250         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
2251
2252 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2253
2254         Missleading style error when mixing system and non-system header include lines.
2255         https://bugs.webkit.org/show_bug.cgi?id=126564
2256
2257         Reviewed by Ryosuke Niwa.
2258
2259         * Scripts/webkitpy/style/checkers/cpp.py:
2260         (check_include_line):
2261         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2262         (OrderOfIncludesTest.test_check_alphabetical_include_order):
2263         (OrderOfIncludesTest.test_public_primary_header):
2264
2265 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2266
2267         [EFL] Unreviewed build fix after r161522.
2268
2269         * TestWebKitAPI/CMakeLists.txt:
2270         * TestWebKitAPI/PlatformEfl.cmake:
2271
2272 2014-01-08  Anders Carlsson  <andersca@apple.com>
2273
2274         Remove WKConnectionRef tests
2275         https://bugs.webkit.org/show_bug.cgi?id=126666
2276
2277         Reviewed by Dan Bernstein.
2278
2279         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
2280         Remove the API tests as a first step towards killing the entire thing.
2281
2282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2283         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
2284         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
2285
2286 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2287
2288         Unreviewed, rolling out r161512.
2289         http://trac.webkit.org/changeset/161512
2290         https://bugs.webkit.org/show_bug.cgi?id=126655
2291
2292         Broke webkitpy tests (Requested by ap on #webkit).
2293
2294         * Scripts/webkitpy/port/gtk.py:
2295         (GtkPort.__init__):
2296         (GtkPort.setup_test_run):
2297         (GtkPort._port_specific_expectations_files):
2298         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
2299         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
2300
2301 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2302
2303         Unreviewed, rolling out r161517.
2304         http://trac.webkit.org/changeset/161517
2305         https://bugs.webkit.org/show_bug.cgi?id=126659
2306
2307         The fix didn't completely remove the problem and is now
2308         standing in the way of the rollout of the offending patch
2309         (Requested by zdobersek on #webkit).
2310
2311         * Scripts/webkitpy/port/gtk.py:
2312         (GtkPort.__init__):
2313
2314 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2315
2316         Unreviewed. Attempting to fix webkitpy tests after r161512.
2317
2318         * Scripts/webkitpy/port/gtk.py:
2319         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
2320
2321 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2322
2323         [GTK] Parse Valgrind xml leak files
2324         https://bugs.webkit.org/show_bug.cgi?id=119446
2325
2326         Reviewed by Alejandro G. Castro.
2327
2328         Parse the xml files generated by Valgrind to yield useful
2329         information about the memory leaks.
2330
2331         * Scripts/webkitpy/port/gtk.py:
2332         (GtkPort.__init__):
2333         (GtkPort.setup_test_run): Clear the previous output files before new
2334         run.
2335         (GtkPort.print_leaks_summary):
2336
2337         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2338         Parse the xml files generated by Valgrind and summarise leaks
2339         into an easily understandable list.
2340         (get_text_of):
2341         (get_CDATA_of):
2342         (gather_frames):
2343         (ValgrindError):
2344         (ValgrindError.__init__):
2345         (ValgrindError.__str__):
2346         (ValgrindError.unique_string):
2347         (ValgrindError.error_hash):
2348         (ValgrindError.__hash__):
2349         (ValgrindError.__eq__):
2350         (LeakDetectorValgrind):
2351         (LeakDetectorValgrind.__init__):
2352         (LeakDetectorValgrind._parse_leaks_output):
2353         (LeakDetectorValgrind.leaks_files_in_results_directory):
2354         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2355         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2356
2357         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2358         (make_mock_valgrind_output):
2359         (make_mock_incomplete_valgrind_output):
2360         (make_mock_valgrind_results):
2361         (make_mock_valgrind_results_incomplete):
2362         (make_mock_valgrind_results_empty):
2363         (make_mock_valgrind_results_misformatted):
2364         (LeakDetectorValgrindTest):
2365         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2366         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2367         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2368         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2369         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2370         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2371         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2372         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2373
2374 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2375
2376         Unreviewed, rolling out r161427.
2377         http://trac.webkit.org/changeset/161427
2378         https://bugs.webkit.org/show_bug.cgi?id=126645
2379
2380         Emits a stye error on any newly added files (Requested by ap
2381         on #webkit).
2382
2383         * Scripts/webkitpy/style/checkers/cpp.py:
2384         (check_style):
2385         (CppChecker):
2386         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2387         (WebKitStyleTest.test_other):
2388
2389 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2390
2391         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
2392         https://bugs.webkit.org/show_bug.cgi?id=126580
2393
2394         Reviewed by Csaba Osztrogonác.
2395
2396         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2397         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
2398         run-webkit-tests script.
2399         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
2400         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
2401
2402 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2403
2404         Update the list of non-committer u-szeged contributors
2405         https://bugs.webkit.org/show_bug.cgi?id=126640
2406
2407         Reviewed by Csaba Osztrogonác.
2408
2409         * Scripts/webkitpy/common/config/contributors.json:
2410
2411 2014-01-08  Alberto Garcia  <berto@igalia.com>
2412
2413         Fix some compilation warnings
2414         https://bugs.webkit.org/show_bug.cgi?id=126635
2415
2416         Reviewed by Csaba Osztrogonác.
2417
2418         * GtkLauncher/main.c:
2419         (createWindow): This function is not supposed to receive any
2420         parameter, yet we are passing one.
2421
2422 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2423
2424         [GTK][WK2] unskip passing unit tests
2425         https://bugs.webkit.org/show_bug.cgi?id=126637
2426
2427         Reviewed by Carlos Garcia Campos.
2428
2429         Unskip TestResources and TestAuthentication unit tests since they
2430         are passing both under Xvfb and X.
2431
2432         * Scripts/run-gtk-tests:
2433         (TestRunner):
2434
2435 2014-01-08  Alberto Garcia  <berto@igalia.com>
2436
2437         REGRESSION(r160304): [GTK] Disable libtool fast install
2438         https://bugs.webkit.org/show_bug.cgi?id=126381
2439
2440         Reviewed by Gustavo Noronha Silva.
2441
2442         Disable the libtool fast-install mode in developer/test builds.
2443
2444         In this mode binaries are generated ready to be used directly from
2445         the build tree. Otherwise they would need to be relinked when they
2446         are executed, which can take a lot of resources, particularly in
2447         debug builds.
2448
2449         * Scripts/webkitdirs.pm:
2450         (runAutogenForAutotoolsProjectIfNecessary):
2451
2452 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2453
2454         Unreviewed GTK gardening.
2455
2456         * Scripts/run-gtk-tests:
2457         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
2458         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
2459
2460 2014-01-07  Lucas Forschler  <lforschler@apple.com>
2461
2462         Add buildbot infrasctructure for building and testing JSC cloop
2463         https://bugs.webkit.org/show_bug.cgi?id=126604
2464
2465         Reviewed by Geoffrey Garen.
2466
2467         * BuildSlaveSupport/build.webkit.org-config/config.json:
2468         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2469         (CompileCLOOP):
2470         (RunCLOOPTests):
2471         (RunCLOOPTests.countFailures):
2472         (BuildAndTestCLOOP):
2473
2474 2014-01-07  Brian Burg  <bburg@apple.com>
2475
2476         Unreviewed. Add myself as a committer.
2477
2478         * Scripts/webkitpy/common/config/contributors.json:
2479
2480 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2481
2482         Popovers at build.webkit.org/dashboard could have titles
2483         https://bugs.webkit.org/show_bug.cgi?id=126495
2484
2485         Reviewed by Timothy Hatcher.
2486
2487         Added titles to all popovers except for pending revisions one, which I would like
2488         to improve more (probably add an ETA).
2489
2490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2491         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
2492         adding a title to base class.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2495         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
2496         a divider to a separate function.
2497         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
2498         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
2499         title from above function.
2500         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
2501         variable to "content" to match all other code.
2502         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
2503         (BuildbotQueueView.prototype._addDividerToPopover): Added.
2504
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2506         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
2507         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
2508         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
2509
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2511
2512 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2513
2514         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
2515         https://bugs.webkit.org/show_bug.cgi?id=126472
2516
2517         Reviewed by Timothy Hatcher.
2518
2519         Added a delay when quickly switching to a different popover, making it easier to
2520         move mouse pointer from active element to its popover without accidentally opening
2521         a different popover.
2522
2523         Used this code to add a delay before creating a popover. This doesn't change UI
2524         behavior, as there was alerady a delay before it became visible, but it avoids
2525         flooding buildbot server with http requests when quickly moving the mouse over
2526         dashboard page.
2527
2528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
2529         Fixed a case where popover could get stuck. If content was updated while fade-out
2530         transition was already in place, the transition was removed for no good reason.
2531
2532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2533         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
2534
2535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2536         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
2537         popover delay from 1s to 800ms.
2538
2539 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2540
2541         Improve display of failed builds at build.webkit.org/dashboard
2542         https://bugs.webkit.org/show_bug.cgi?id=126542
2543         <rdar://problem/15753550>
2544
2545         Reviewed by Timothy Hatcher.
2546
2547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2548         Instead of hardcoding step name, look for the first step that failed.
2549         While at it, added a popover with more links. There are multiple, and it's good
2550         to have a choice of which one to look at in each situation.
2551
2552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2553         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
2554         of having failed. Many iterations are interrupted for whatever reason internal to
2555         Buildbot, and these are suppoed to be orange, not red.
2556         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
2557         not only WillRetry ones.
2558         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
2559         actually failed, more likely indicating a problem with code base.
2560         (BuildbotIteration.prototype.get firstFailedStepName):
2561         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
2562         (BuildbotIteration.prototype.get failureLogs): Ditto.
2563         (BuildbotIteration.prototype.update): Store complete results for the failed step.
2564         Not every failure stops the iteration, so we could have multiple failed steps,
2565         but let's see if seeing just the first one will be enough.
2566
2567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2568         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
2569         terms of successful iterations.
2570         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
2571
2572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2573         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
2574         terms of successful iterations.
2575
2576         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2577         Removed code to create a path to build output, we now take it from results JSON.
2578
2579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2580         Added styles for the new popover.
2581
2582 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2583
2584         defined constants should use all uppercase names with words separated by underscores.
2585         https://bugs.webkit.org/show_bug.cgi?id=126055
2586
2587         Reviewed by Alexey Proskuryakov.
2588
2589         * Scripts/webkitpy/style/checkers/cpp.py:
2590         (check_style):
2591         (CppChecker):
2592         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2593         (WebKitStyleTest.test_define_constants):
2594
2595 2014-01-07  Brian Holt  <brian.holt@samsung.com>
2596
2597         Unreviewed. Add myself as a committer.
2598
2599         * Scripts/webkitpy/common/config/contributors.json:
2600
2601 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2602
2603         Remove the WinCE buildbot from build.webkit.org
2604         https://bugs.webkit.org/show_bug.cgi?id=126517
2605
2606         Reviewed by Alexey Proskuryakov.
2607
2608         * BuildSlaveSupport/build.webkit.org-config/config.json:
2609         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2610         (appendCustomBuildFlags):
2611
2612 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2613
2614         [EFL] Change ATK version to 2.11.4
2615         https://bugs.webkit.org/show_bug.cgi?id=126573
2616
2617         Reviewed by Gyuyoung Kim.
2618
2619         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
2620
2621         * efl/jhbuild.modules:
2622
2623 2014-01-07  Alberto Garcia  <berto@igalia.com>
2624
2625         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
2626         https://bugs.webkit.org/show_bug.cgi?id=117275
2627
2628         Reviewed by Carlos Garcia Campos.
2629
2630         If we are not using the internal jhbuild we must not use the
2631         jhbuild-wrapper script, else it will try to download and install
2632         it.
2633
2634         * Scripts/run-launcher:
2635
2636 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2637
2638         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
2639         https://bugs.webkit.org/show_bug.cgi?id=125855
2640
2641         Reviewed by Mario Sanchez Prada.
2642
2643         Added new function isIndeterminate for testing aria-checked mixed state.
2644         I provided respective, but empty function in mac port. Mac testing it differently.
2645
2646         * DumpRenderTree/AccessibilityUIElement.cpp:
2647         (getIsIndeterminate):
2648         (AccessibilityUIElement::getJSClass):
2649         * DumpRenderTree/AccessibilityUIElement.h:
2650         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2651         (AccessibilityUIElement::isIndeterminate):
2652         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
2653         (AccessibilityUIElement::isIndeterminate):
2654         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
2655         (AccessibilityUIElement::isIndeterminate):
2656         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
2657         (AccessibilityUIElement::isIndeterminate):
2658         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2659         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2660         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2661         (WTR::AccessibilityUIElement::isIndeterminate):
2662         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2663         (WTR::AccessibilityUIElement::isIndeterminate):
2664
2665 2014-01-06  Mark Rowe  <mrowe@apple.com>
2666
2667         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
2668
2669         Reviewed by Ryosuke Niwa.
2670
2671         * DumpRenderTree/mac/DumpRenderTree.mm:
2672         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
2673         with a single case. This avoids the potential for warnings about unhandled cases.
2674         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2675         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
2676
2677 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2678
2679         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
2680         https://bugs.webkit.org/show_bug.cgi?id=126342
2681
2682         Reviewed by Gustavo Noronha Silva.
2683
2684         * CMakeLists.txt: Include the new unit tests subdirectories.
2685         * Scripts/run-gtk-tests: Update to refer to the new build locations.
2686         * Scripts/webkitpy/style/checker.py: Update the style checker.
2687         * Scripts/webkitpy/style/checker_unittest.py:
2688         * TestWebKitAPI/GNUmakefile.am:
2689         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
2690         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
2691         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
2692         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
2693         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
2694         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
2695         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
2696         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
2697         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
2698         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
2699         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
2700         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
2701         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
2702         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
2703         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
2704         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
2705         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
2706         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
2707         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
2708         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
2709         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
2710         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
2711         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
2712         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
2713         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
2714         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
2715         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
2716         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
2717         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
2718         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
2719         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
2720         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
2721         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
2722         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
2723         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
2724         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
2725         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
2726         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
2727         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
2728         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
2729         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
2730         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
2731         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
2732         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
2733         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
2734         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
2735         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
2736         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
2737         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
2738         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
2739         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
2740         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
2741         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
2742         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
2743         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
2744         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
2745         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
2746         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
2747         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
2748         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
2749         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
2750         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
2751         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
2752         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
2753         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
2754         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
2755         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
2756         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
2757         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
2758         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
2759         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
2760         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
2761         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
2762         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
2763         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
2764         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
2765         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
2766         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
2767         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
2768         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
2769         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
2770         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
2771         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
2772         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
2773         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
2774         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
2775         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
2776
2777 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
2778
2779         Gtk and Efl API test results confuse the dashboard
2780         https://bugs.webkit.org/show_bug.cgi?id=126535
2781
2782         Reviewed by Tim Horton.
2783
2784         Added "API tests" step as "platform api tests".
2785
2786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2787         (Buildbot.prototype.platformAPITestResultsURLForIteration):
2788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2789         (BuildbotIteration):
2790         (BuildbotIteration.prototype.update):
2791         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2792         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2793         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2794
2795 2014-01-06  Tim Horton  <timothy_horton@apple.com>
2796
2797         build.webkit.org/dashboard should still function if localStorage is disabled
2798         https://bugs.webkit.org/show_bug.cgi?id=126511
2799
2800         Reviewed by Alexey Proskuryakov.
2801
2802         If localStorage is disabled, we should carry on with a warning.
2803
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2805         Don't show the gear if localStorage isn't working.
2806
2807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2808         (QueueView.prototype._updateHiddenState):
2809         Bail if localStorage isn't working.
2810
2811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2812         (Settings.prototype.available):
2813
2814 2014-01-02  Roger Fong  <roger_fong@apple.com>
2815
2816         Set VSINSTALLDIR in win ews start script.
2817         https://bugs.webkit.org/show_bug.cgi?id=126407
2818
2819         Reviewed by Brent Fulgham.
2820
2821         * EWSTools/start-queue-win.sh:
2822
2823 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
2824
2825         Adding myself as a reviewer.
2826
2827         Unreviewed.
2828
2829         * Scripts/webkitpy/common/config/contributors.json:
2830
2831 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
2832
2833         Unreviewed. Unbreaking JSC tests after r161328.
2834
2835         * Scripts/webkitdirs.pm:
2836         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
2837         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
2838
2839 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
2840
2841         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
2842         https://bugs.webkit.org/show_bug.cgi?id=126212
2843
2844         Reviewed by Daniel Bates.
2845
2846         Allow building the GTK+ cmake port with --gtkcmake.
2847
2848         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
2849         when appropriate. Skip the autotoos path when isGtkAutotools is false.
2850         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
2851         Add isGtk which checks isGtkCMake || isGtkAutotools
2852         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
2853         (argumentsForConfiguration): use --gtkcmake when appropriate.
2854         (jscProductDir): Look in the CMake directory when appropriate.
2855         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
2856         (determineIsGtkCMake): Added.
2857         (isGtkCMake): Added.
2858         (isGtkAutotools): Renamed from isGtk.
2859         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
2860         (determineIsGtkAutotools): Renamed from determineIsGtk.
2861         (cmakeBasedPortName): Added a GTK+ path.
2862
2863 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
2864
2865         [GTK] [CMake] Fix the video and audio build
2866         https://bugs.webkit.org/show_bug.cgi?id=126464
2867
2868         Reviewed by Philippe Normand.
2869
2870         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
2871
2872 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2873
2874         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
2875         https://bugs.webkit.org/show_bug.cgi?id=126467
2876
2877         Reviewed by Geoffrey Garen.
2878
2879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2880         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
2881         pointer, or to tap.
2882
2883 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2884
2885         build.webkit.org/dashboard says "failed build" even if it's another step that failed
2886         https://bugs.webkit.org/show_bug.cgi?id=126461
2887
2888         Reviewed by Geoffrey Garen.
2889
2890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2891         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
2892         build page if it's not the compilation that failed. Use text from buildbot for description.
2893         Show a yellow icon if it's a different kind of failure.
2894
2895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2896         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
2897
2898 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
2899
2900         setup-git-clone fails to get email address from git
2901         https://bugs.webkit.org/show_bug.cgi?id=126446
2902
2903         Reviewed by Ryosuke Niwa.
2904
2905         The setup-git-clone command fails to get an email address from git
2906         because of a bug in VCSUtils. This patch fixes that bug, and also
2907         makes it so that when VCSUtils fails for real because of a local
2908         misconfiguration, the error message is actually presented to the user
2909         of setup-git-clone.
2910
2911         * Scripts/VCSUtils.pm:
2912         (gitConfig): Call isGit() instead of accessing $isGit directly to make
2913             sure that $isGit is properly initialized.
2914         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2915         (SetupGitClone.execute): Pull out username and email acquistion to
2916             it's own method.
2917         (SetupGitClone._get_username_and_email): Catch the exception thrown
2918             when VCSUtils fails and print out the error message so that the
2919             user actually knows why the command failed.
2920
2921 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2922
2923         It feels too hard to get rid of a popover at build.webkit.org/dashboard
2924         https://bugs.webkit.org/show_bug.cgi?id=126451
2925
2926         Reviewed by Simon Fraser.
2927
2928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2929         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
2930         when moving the mouse from an element to its popover.
2931
2932 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2933
2934         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
2935         https://bugs.webkit.org/show_bug.cgi?id=122181
2936
2937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2938         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
2939         popover.present signature change.
2940
2941 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2942
2943         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
2944         https://bugs.webkit.org/show_bug.cgi?id=122181
2945
2946         Reviewed by Timothy Hatcher and Timothy Horton.
2947
2948         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
2949         JSONP). Dashboard will load them on demand.
2950
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2952         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
2953         and made it use a function from WebKitBuildbot that builds results directory path.
2954         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
2955         a URL for full_results.json.
2956         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
2957         a URL for a crash log.
2958
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2960         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
2961         the iteration.
2962
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
2964         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
2965         popover API (see below).
2966         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
2967
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2969         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
2970         for iterations that were interrupted (previously, they were displayed incorrectly,
2971         often as passes). Install popover trackers for failure bubbles for which we can currently
2972         display something useful.
2973         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
2974         a popover for layout test regressions when we have the data loaded on demand.
2975         We have test paths, special indicators for crashes/timeouts, and links to test history
2976         at flakiness dashboard.
2977         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
2978         the popover for layout test regressions. Just shows "Loading..." until the data is
2979         loaded.
2980         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
2981         types of failures if there are multiple. There is a lot of similarity with
2982         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
2983
2984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2985         Create a global test history object, which is used for links in layout test popover.
2986
2987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
2988         Changed the API to be more like WebInspector again, allowing for changing content
2989         of an existing popover. As the size of a popover can change, making the mouse pointer
2990         enter it without a mousenter event, install a handler for mousewheel instead, and block
2991         document scrolling from this event handler when needed.
2992
2993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2994         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
2995         bubble element, making it possible to install a popover on it.
2996
2997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2998         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3001         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
3002         building a complete results URL to only building one for root results path. This is
3003         the part that depends on specific buildbot installation, everything relative to it
3004         is the same.
3005
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
3007         Build a path to test history page. In the future, we may consider adding code to
3008         load the data and display it inline.
3009
3010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3011         Added styles for this new popover.
3012
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
3014         a new file, WebKitTestHistory.js.
3015
3016 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3017
3018         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
3019         https://bugs.webkit.org/show_bug.cgi?id=126430
3020
3021         Reviewed by Martin Robinson.
3022
3023         * Scripts/run-gtk-tests:
3024         (TestRunner._setup_testing_environment):
3025         * gtk/common.py: Use common.tests_library_build_path() instead.
3026         (tests_library_build_path): Helper funtion that returns the path
3027         where the tests libraries are built.
3028
3029 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
3030
3031         [CMake] Build TestWebKitAPI tests into a directory structure
3032         https://bugs.webkit.org/show_bug.cgi?id=126358
3033
3034         Reviewed by Gyuyoung Kim.
3035
3036         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
3037         is useful for keeping the "bin" directory tidy during building and will make it easier
3038         to integrate the CMake build into the existing WebKitGTK+ scripts.
3039
3040         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
3041         and make the names simpler now that the directory identifies what category the test is in.
3042
3043 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3044
3045         Provide a visual clue when element has a popover at build.webkit.org/dashboard
3046         https://bugs.webkit.org/show_bug.cgi?id=126281
3047
3048         Reviewed by Timothy Hatcher.
3049
3050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3051         (PopoverTracker): Add a class name to elements with popovers.
3052
3053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3054         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
3055         I might have broke that recently.
3056         (*:link): Show hand cursor over links.
3057         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
3058
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3060         (.status-line .message .revision-number): Show text selection cursor on our only
3061         selectable text element.
3062         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
3063         a white shadow than with a dark one on hover.
3064
3065 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3066
3067         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
3068         https://bugs.webkit.org/show_bug.cgi?id=124652
3069
3070         Reviewed by Martin Robinson.
3071
3072         * MiniBrowser/gtk/BrowserWindow.c:
3073         (webViewDecidePolicy): Use the new API instead of
3074         webkit_web_view_can_show_mime_type().
3075
3076 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3077
3078         REGRESSION(r160304): [GTK] Disable libtool fast install
3079         https://bugs.webkit.org/show_bug.cgi?id=126381
3080
3081         Reviewed by Martin Robinson.
3082
3083         Remove -no-fast-install ld flag since fast install is now disabled
3084         globally.
3085
3086         * GNUmakefile.am:
3087         * GtkLauncher/GNUmakefile.am:
3088         * MiniBrowser/gtk/GNUmakefile.am:
3089         * TestWebKitAPI/GNUmakefile.am:
3090         * WebKitTestRunner/GNUmakefile.am:
3091
3092 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
3093
3094         Unreviewed. Add myself to EFL and related watch lists.
3095
3096         * Scripts/webkitpy/common/config/watchlist:
3097
3098 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
3099
3100         [GTK] fixing ycm_extra_conf.py file
3101         https://bugs.webkit.org/show_bug.cgi?id=126371
3102
3103         It's an attempt to fix three problems with the current ycm_extra_conf file.
3104         The current implementation assumes that it's a symlink, which is not true.
3105         Usually python creates a pyc file, and this is what you get in __file__.
3106         the .pyc is not a symlink, and the current implementation doesn't work
3107         if that's the case.
3108
3109         It also assumes that the user is in the root folder.
3110         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
3111
3112         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
3113         exception since "flag" doesn't exists.
3114
3115         All those things were fixed.
3116
3117         Reviewed by Martin Robinson.
3118
3119         * gtk/ycm_extra_conf.py:
3120         (transform_relative_paths_to_absolute_paths):
3121
3122 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3123
3124         Bindings tests results links are broken at build.webkit.org/dashboard
3125         https://bugs.webkit.org/show_bug.cgi?id=126402
3126
3127         Reviewed by Tim Horton.
3128
3129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3130         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
3131         since the beginning.
3132
3133 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3134
3135         "+" is very confusing at http://build.webkit.org/dashboard
3136         https://bugs.webkit.org/show_bug.cgi?id=126400
3137
3138         Reviewed by Tim Horton.
3139
3140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3141         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
3142         source and internal counts separately, simply add them. One can always open a popover
3143         for more detail.
3144
3145 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3146
3147         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3148         https://bugs.webkit.org/show_bug.cgi?id=126391
3149
3150         Reviewed by Dan Bernstein.
3151
3152         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
3153         One can request credentials use via Initialization.js.
3154
3155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3156         (Trac):
3157         (Trac.prototype.update):
3158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3159         (loadXML):
3160
3161 2014-01-02  Commit Queue  <commit-queue@webkit.org>
3162
3163         Unreviewed, rolling out r160846.
3164         http://trac.webkit.org/changeset/160846
3165         https://bugs.webkit.org/show_bug.cgi?id=126395
3166
3167         Breaks build scripts for Windows when Visual Studio is not
3168         installed in Program Files (Requested by rfong on #webkit).
3169
3170         * Scripts/webkitdirs.pm:
3171         (visualStudioInstallDir):
3172
3173 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
3174
3175         [GTK] [CMake] run-gtk-tests should run with the cmake build
3176         https://bugs.webkit.org/show_bug.cgi?id=126341
3177
3178         Reviewed by Carlos Garcia Campos.
3179
3180         * Scripts/run-gtk-tests:
3181         (TestRunner.__init__): Use the new calling conventions for the common script.
3182         (TestRunner._setup_testing_environment): Ditto.
3183         * gtk/common.py:
3184         (set_build_types): Added set_build_types, to avoid having build_type arguments
3185         for all functions in common.
3186         (binary_build_path): Added this function which gets the path to the built binaries.
3187         (get_build_path): Removed the build_types argument.
3188         (build_path): Removed the build_types argument and call get_build_path directly now.
3189
3190 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3191
3192         https://bugs.webkit.org/show_bug.cgi?id=126391
3193         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3194
3195         Rubber-stamped by Dan Bernstein.
3196
3197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3198         (loadXML): Quick and dirty fix, with a FIXME.
3199
3200 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
3201
3202         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
3203         https://bugs.webkit.org/show_bug.cgi?id=126349
3204
3205         Reviewed by Carlos Garcia Campos.
3206
3207         All CMake ports use "libTestNetscapePlugin," so choosing the same
3208         name in the autotools port will make the transition easier.
3209
3210         * GNUmakefile.am: Rename the plugin library.
3211
3212 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
3213
3214         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
3215         https://bugs.webkit.org/show_bug.cgi?id=126354
3216
3217         Reviewed by Carlos Garcia Campos.
3218
3219         The latest visited site for backward history should be placed on the top of a history stack
3220         as a common behavior. However currently its order is reverse.
3221
3222         * MiniBrowser/gtk/BrowserWindow.c:
3223         (browserWindowUpdateNavigationActions):
3224
3225 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
3226
3227         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
3228         https://bugs.webkit.org/show_bug.cgi?id=126297
3229
3230         Reviewed by Philippe Normand.
3231
3232         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
3233         (TestRunner): Ditto.
3234         (TestRunner._run_test): Ditto.
3235
3236 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
3237
3238         full_results.json should distinguish unexpected failures from expected ones
3239         https://bugs.webkit.org/show_bug.cgi?id=126300
3240
3241         Reviewed by Timothy Hatcher.
3242
3243         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3244         (summarize_results): Add "report" element to JSON, which tells the consumer how
3245         this result was counted for summary.
3246
3247         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3248         Updated results to include the new element.
3249
3250         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3251         (print_unexpected_results): Added a comment pointing to another place that
3252         summarizes results, and should stay in sync.
3253
3254 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
3255
3256         Replace remaning CoreIPC namespace to IPC
3257         https://bugs.webkit.org/show_bug.cgi?id=126305
3258
3259         Reviewed by Anders Carlsson.
3260
3261         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3262         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
3263         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3264         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
3265
3266 2013-12-30  Brendan Long  <self@brendanlong.com>
3267
3268         Add myself to the committers list.
3269
3270         Unreviewed.
3271
3272         * Scripts/webkitpy/common/config/contributors.json:
3273
3274 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3275
3276         [GTK] Split WebKit2APITests/TestWebKitWebView
3277         https://bugs.webkit.org/show_bug.cgi?id=126284
3278
3279         Reviewed by Philippe Normand.
3280
3281         Skip only WebKitWebView/mouse-target and all TestAuthentication
3282         tests that are timing out when running under xvfb.
3283
3284         * Scripts/run-gtk-tests:
3285         (TestRunner):
3286
3287 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3288
3289         [EFL][WK2] Disable geolocation API test
3290         https://bugs.webkit.org/show_bug.cgi?id=125851
3291
3292         Reviewed by Gyuyoung Kim.
3293
3294         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
3295
3296         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
3297
3298 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
3299
3300         [EFL] Remove ewk_view_tiled
3301         https://bugs.webkit.org/show_bug.cgi?id=125961
3302
3303         Reviewed by Gyuyoung Kim.
3304
3305         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3306         (shouldUseTiledBackingStore):
3307         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
3308         instead of switching ewk_view_tiled.
3309         (DumpRenderTreeChrome::createView):
3310         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3311         (drtViewAdd):
3312         * EWebLauncher/main.c: Removed ewk_view_tiled option.
3313         (windowCreate):
3314         (parseUserArguments):
3315
3316 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3317
3318         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
3319         https://bugs.webkit.org/show_bug.cgi?id=126278
3320
3321         Reviewed by Timothy Hatcher.
3322
3323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3324         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
3325         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
3326         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
3327
3328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3329         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
3330
3331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3332         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
3333
3334 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3335
3336         Interrupted test runs should not count at build.webkit.org/dashboard
3337         https://bugs.webkit.org/show_bug.cgi?id=126279
3338
3339         Reviewed by Timothy Hatcher.
3340
3341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3342         (BuildbotIteration.prototype.get productive):
3343         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
3344         this accessor to skips iterations that don't have relevant data. We still want to
3345         display them, but revision ranges should not be affected.
3346         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
3347
3348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3349         Use latest productive iteration instead of latest iteration for pending revision
3350         count and popovers.
3351
3352 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3353
3354         Please display (and link to) revision ranges at build.webkit.org/dashboard
3355         https://bugs.webkit.org/show_bug.cgi?id=122187
3356
3357         Reviewed by Timothy Hatcher.
3358
3359         Added popovers for revision numbers. Removed direct links, because they were misleading -
3360         a test run covers a revision range, not just the latest revision. This also makes
3361         selecting a revision for copy easier.
3362
3363         All revision numbers have the popovers for consistency, although they are most useful
3364         for iterations that are not the last ones in a view, because the content is a delta
3365         from previous iteration.
3366
3367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3368         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3369         revisionLinksForIteration() is now named revisionContentForIteration().
3370
3371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3372         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3373         Ditto.
3374
3375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3376         (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
3377
3378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3379         Refactored to support the new popover variation. Replaced revisionLinksForIteration()
3380         with a function that builds an element with popover.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3383         Changed to take a function for popover presentation instead of delegate object.
3384         We only need one delegate function, and it's easier to have multiple popovers per view class
3385         this way.
3386
3387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3388         Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
3389
3390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3391         Renamed pending-commits-popover class to commit-history-popover.
3392
3393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3394         (.status-line .message .revision-number): Added a rule for revision numbers.
3395
3396 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3397
3398         Please display information about pending runs in build.webkit.org/dashboard
3399         https://bugs.webkit.org/show_bug.cgi?id=122180
3400
3401         Reviewed by Timothy Hatcher.
3402
3403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3404         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Added a semicolon at the end of a line.
3405
3406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3407         (BuildbotQueueView.prototype._latestFinishedIteration): Factored out of _appendPendingRevisionCount.
3408         (BuildbotQueueView.prototype._appendPendingRevisionCount): Install a popover tracker over the element.
3409         (BuildbotQueueView.prototype.lineForCommit): Build an element for a particular commit ot be shown in popover.
3410         (BuildbotQueueView.prototype.presentPopoverForElement): Build and show popover content when PopoverTracker
3411         asks us to.
3412
3413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Geometry.js: Added.
3414         Taken from WebInspector with minimal changes:
3415         - Changed root name from WebInspector to Dashboard.
3416         - Removed some unused functionality.
3417         - Added Rect.containsPoint.
3418
3419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js: Added.
3420         Popover has extensive changes compared to WebInspector version, only drawing code is the same:
3421         - Fixed to work in scrollable pages - WebInspector version assumes that window
3422         and document coordinates are the same, and also erroneously dismisses a scrollable
3423         popover if scrolling cascades out of it after reaching a bound.
3424         - Simplified API and implementation to Dashboard needs, it is no longer possible to
3425         change content of an existing popover.
3426         - Rewrote visibility tracking to be more complete, and not rely on external tracker
3427         object so much.
3428         - Added code to flash scroll bars when showing a scrollable popover.
3429
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js: Added.
3431         Objects of this class show and hide popovers as appropriate for registered active elements.
3432
3433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3434         (StatusLineView.prototype.get messageElement): Added an accessor, so that we could
3435         install a popover on message element. It's the only visible element in pending commit
3436         line, but the line has different bounds, so we can't install a popover on it (it
3437         would be incorrectly positioned if we did).
3438
3439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3440         (Trac.prototype._convertCommitInfoElementToObject):
3441         - Some trac installations report author in a different element, updated to support that.
3442         - Changed to parse title out of description, because trac titles are ugly. Also,
3443         we get a nice HTML with links from the description.
3444
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3446         (Node.prototype.isAncestor): Copied from Web Inspector, only changing the form for
3447         consistency with the rest of this file (add a property on prototype with assignment
3448         instead of using Object.defineProperty).
3449         (Node.prototype.isDescendant): Ditto.
3450         (Node.prototype.isSelfOrAncestor): Ditto.
3451         (Node.prototype.isSelfOrDescendant): Ditto.
3452         (DOMTokenList.prototype.contains): Ditto.
3453
3454         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: Added.
3455         Like JS counterpart, mostly lifted from Web Inspector.
3456
3457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3458         Added style rules for pending commits popover.
3459
3460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3461         (.status-line.no-bubble .message): Changed to display:inline-block, so that it fits
3462         to content, and we can show the popover in a correct place.
3463
3464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added new files.
3465
3466 2013-12-27  Gavin Barraclough  <barraclough@apple.com>
3467
3468         Merge PageVisibilityState & ViewState::IsVisible in WebKit2
3469         https://bugs.webkit.org/show_bug.cgi?id=126214
3470
3471         Reviewed by Alexey Proskuryakov.
3472
3473         WebKit2 redundantly tracks the visibility of the view through two mechanisms - the visibility
3474         state, and the view state. Remove visibility state from the WebKit2 layer. The visibility
3475         state also tracks the prerender state - so split this out and handle it separately (a change
3476         we should make in WebCore, too).
3477
3478         Tools - WebKit2 no longer (poorly) supports a fake visibility state, so to test the page
3479         visibility mechanisms we should actually be changing characteristics of the view that will
3480         be detected by WebKit2 as a visibility change. This affects three things:
3481             1) On setVisibilityState WebKitTestRunner must actually change visibility of the view.
3482             2) The 'PageVisibilityState' test in the API tests is useless (as evidenced by the fact
3483                that page visibility has been broken in WebKit2 for a couple of months, and didn't
3484                catch this fact). Removed in favour of:
3485             3) 'PageVisibilityStateWithWindowChanges' - this is the good stuff. This actually tests
3486                the visibility mechanism. Beef this test up by adding coverage for: a) the prerender
3487             state, b) document.hidden, and c) too many state change notifications (it already looks
3488             for too few).
3489
3490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3491         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Removed.
3492             - Removed PageVisibilityState - this test was ineffective, API no longer supports this
3493               test, and behaviour is covered by PageVisibilityStateWithWindowChanges.
3494         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3495         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3496         (runJavaScriptAlert):
3497             - Add checking for too many calls to the alert.
3498         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::setPrerender):
3499             - Added methods to set visibility to prerender.
3500         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3501             - Added checking of 'document.hidden'.
3502         * WebKitTestRunner/TestController.cpp:
3503         (WTR::TestController::setVisibilityState):
3504         * WebKitTestRunner/TestController.h:
3505         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3506         (WTR::TestController::setHidden):
3507         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3508         (WTR::TestController::setHidden):
3509         * WebKitTestRunner/mac/TestControllerMac.mm:
3510         (WTR::TestController::setHidden):
3511             - Add setHidden method; call this from setVisibilityState.
3512
3513 2013-12-27  Alexey Proskuryakov  <ap@apple.com>
3514
3515         Display EWS status on bot watcher's dashboard
3516         https://bugs.webkit.org/show_bug.cgi?id=126224
3517
3518         Silence spurious exceptions, no visible behavior change.
3519
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3521         (EWSQueue.prototype.update): Removed code that was only needed for an experimental
3522         feature that wasn't landed.
3523
3524 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
3525
3526         Display EWS status on bot watcher's dashboard
3527         https://bugs.webkit.org/show_bug.cgi?id=126224
3528
3529         Reviewed by Timothy Hatcher.
3530
3531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added.
3533         Moved platform definitions out of Buildbot.js, as they are also needed for EWS.
3534
3535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3536         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: Added.
3537         (QueueView):
3538         (QueueView.prototype.updateSoon):
3539         (QueueView.prototype.update):
3540         (QueueView.prototype._updateHiddenState):
3541         Moved auto-update and hide logic to a base class, as it equally applies to EWS.
3542
3543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Added.
3544         This is a peer to Buildbot.js and WebKitBuildbot.js.
3545
3546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Added.
3547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Added.
3548         Quite simple for now, only keeping track of queue size.
3549         
3550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3551         Initialize EWS.
3552
3553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3554         Create EWS views.
3555
3556         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3557         Updated for Buildbot.Platform rename, it's now Dashboard.Platform.
3558
3559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Removed.
3560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Removed.
3561         These were empty, no reason to waste the time loading them.
3562
3563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Removed.
3564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css.
3565         Renamed, as these styles apply to all queues, not just buildbot ones (and they have to, as columns should look alike).
3566
3567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3568             - Changed page title, as it no longer displays just buildbot status.
3569             - Updated subresource lists for the new, renamed and removed files.
3570
3571 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
3572
3573         EWS status JSON should include Access-Control-Allow-Origin
3574         https://bugs.webkit.org/show_bug.cgi?id=126246
3575
3576         Reviewed by Ryosuke Niwa.
3577
3578         * QueueStatusServer/app.yaml: Update version.
3579         * QueueStatusServer/handlers/queuestatusjson.py:
3580         (QueueStatusJSON.get): Add the header field.
3581
3582 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
3583
3584         Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
3585         https://bugs.webkit.org/show_bug.cgi?id=126234
3586
3587         Reviewed by Timothy Hatcher.
3588
3589         Changed elements that are semantically links from <div> to <a>.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3592         (StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
3593         Don't try simulate a link with CSS/JS, it's not needed any more.
3594         (StatusLineView.prototype._clicked): Removed.
3595
3596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3597         Removed text-decoration rules, default ones in Main.css now work for queue elements.
3598
3599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3600         Simplified cursor rules.
3601         Added a universal rule for links to only show underline on hover, as this is what
3602         we want almost everywhere.
3603
3604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3605         (.status-line .bubble): Added text-decoration: none, as this is the one place where
3606         we don't want it even on hover.
3607         (.status-line .label): Force display: block for consistent layout between <a>
3608         and <div>.
3609
3610 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
3611
3612         Please clarify "pending" reporting at build.webkit.org/dashboard
3613         https://bugs.webkit.org/show_bug.cgi?id=122191
3614
3615         Reviewed by Timothy Hatcher.
3616
3617         Reporting the count of pending runs didn't make a lot of sense - first, runs are
3618         coalesced and sometimes even out of order, and second, buildbot's notion of pending
3619         run was confusingly different from dashboard's.
3620
3621         Let's display how many SVN revisions are pending. This can be somewhat misleading
3622         too, because some revisions (like those for other platforms) don't trigger builds,
3623         but it's better than what we had.
3624
3625         This patch also lays the groundwork for displaying detailed information about
3626         pending revisions.
3627
3628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3629         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
3630         building pending status line directly, call newly added base class method.
3631
3632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3633         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Ditto.
3634
3635         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3636         (BuildbotQueueView): Listen for events when new SVN revisions are landed, and update the view.
3637         (BuildbotQueueView.prototype._appendPendingRevisionCount): Add a line for pending
3638         SVN revisions. It uses a new style, StatusLineView.Status.NoBubble, because this
3639         information is secondary, and doesn't need as much attention.
3640         (BuildbotQueueView.prototype.revisionLinksForIteration): Build revisionURL through
3641         Trac, not through Buildbot.
3642         (BuildbotQueueView.prototype._newCommitsRecorded): Schedule an update, just like when
3643         iterations are updated.
3644
3645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3646         Initialize a global webkitTrac object.
3647
3648         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3649         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3650         Added a new style for messages without a bubble.
3651
3652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3653         Added a model class for Trac, which keeps track of SVN timeline, and notifies
3654         listeners of changes. It uses an RSS interface to Trac, because there is no JSON one.
3655
3656         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3657         (loadXML): Added a function to load XML asynchronously, just like existing JSON.load.
3658
3659         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3660         Removed tracRevisionURL() function. Now that we have a Trac object, it just makes
3661         more sense to build trac URLs through it.
3662
3663         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3664         Load Trac.js.
3665
3666 2013-12-25  Jongwoo Choi  <jw0330.choi@samsung.com>
3667
3668         [EFL] Activate keyboard homepage shortcut on efl minibrowser.
3669         https://bugs.webkit.org/show_bug.cgi?id=124636
3670
3671         Reviewed by Gyuyoung Kim.
3672
3673         * MiniBrowser/efl/main.c: Added.
3674         (on_key_down): Add a homepage shortcut using Alt + Home key. 
3675
3676 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
3677
3678         Revision selection behavior at build.webkit.org/dashboard is annoying
3679         https://bugs.webkit.org/show_bug.cgi?id=126235
3680
3681         Reviewed by Tim Horton.
3682
3683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3684         (BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
3685         selectable, not just the numbers in it.
3686         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3687         (.selectable): Make selectable enable default behavior, not user-select:all.
3688
3689 2013-12-25  Martin Robinson  <mrobinson@igalia.com>
3690
3691         [GTK] [CMake] Clean up generated sources directories
3692         https://bugs.webkit.org/show_bug.cgi?id=126216
3693
3694         Reviewed by Gustavo Noronha Silva.
3695
3696         * DumpRenderTree/PlatformGTK.cmake: Use the new derived sources variables.
3697         * GtkLauncher/CMakeLists.txt: Ditto.
3698         * MiniBrowser/gtk/CMakeLists.txt: Ditto.
3699         * TestWebKitAPI/CMakeLists.txt: Now that the EFL and GTK+ forwarding header locations differ,
3700         move the platform-specific includes to the EFL and GTK platform files. Also clean up forwarding
3701         header generation into on target.
3702         * TestWebKitAPI/PlatformEfl.cmake: Added EFL-specific locations to the include list.
3703         * TestWebKitAPI/PlatformGTK.cmake: Added GTK-specific locations to the include list.
3704         * WebKitTestRunner/CMakeLists.txt: Same as for TestWebKitAPI.
3705         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
3706         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3707         * gtk/generate-gtkdoc: Update to select the appropriate derived sources locations for
3708         the cmake build.
3709
3710 2013-12-23  Alexey Proskuryakov  <ap@apple.com>
3711
3712         Add a JSON interface for getting EWS queue status
3713         https://bugs.webkit.org/show_bug.cgi?id=126182
3714
3715         Reviewed by Ryosuke Niwa.
3716
3717         The current goal is to add an indicator of how many patches are in the queue, and
3718         the JSON also includes some other information that was easy to add.
3719
3720         * QueueStatusServer/app.yaml: Updated version for deployment.
3721
3722         * QueueStatusServer/handlers/queuestatusjson.py: Added. Returns a JSON with some
3723         bot and patch queue information.
3724
3725         * QueueStatusServer/index.yaml: Added an index for a new query that only returns
3726         bot ids.
3727
3728         * QueueStatusServer/main.py: Map /queue-status-json/ directory to QueueStatusJSON
3729         handler.
3730
3731         * QueueStatusServer/config: Added property svn:ignore.
3732         * QueueStatusServer/filters: Added property svn:ignore.
3733         * QueueStatusServer/loggers: Added property svn:ignore.
3734         * QueueStatusServer/handlers: Added property svn:ignore.
3735         * QueueStatusServer/model: Added property svn:ignore.
3736         Ignore compiled *.pyc files in all directories they appear in when running locally.
3737
3738 2013-12-23  Martin Robinson  <mrobinson@igalia.com>
3739
3740         Try to fix the build after r161017
3741
3742         * gtk/common.py:
3743         (is_cmake_build): Instead of checking whether the return value of build_path
3744         of the CMakeCache.txt file is None, check if a file actually exists at that path.
3745
3746 2013-12-23  Gustavo Noronha Silva  <gns@gnome.org>
3747
3748         [GTK] [CMake] Add support for generating gtkdoc
3749         https://bugs.webkit.org/show_bug.cgi?id=116376
3750
3751         Reviewed by Martin Robinson.
3752
3753         * gtk/common.py: look for files in the directories used by the cmake build as well.
3754
3755 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3756
3757         [GTK] Build with network process unconditionally
3758         https://bugs.webkit.org/show_bug.cgi?id=126128
3759
3760         Reviewed by Martin Robinson.
3761
3762         * Scripts/webkitperl/FeatureList.pm: Remove network-process
3763         feature command line option.
3764
3765 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3766
3767         [GTK] run-gtk-tests should always run glib tests with -k option
3768         https://bugs.webkit.org/show_bug.cgi?id=126132
3769
3770         Reviewed by Philippe Normand.
3771
3772         With -k command line option, gtester continues running all other
3773         test cases after a failure.
3774
3775         * Scripts/run-gtk-tests:
3776         (TestRunner._run_test_glib): Use -k option when runing glib tests
3777         to not stop on failure.
3778
3779 2013-12-22  Martin Robinson  <mrobinson@igalia.com>
3780
3781         [GTK][CMake] Integrate GResource for inspector files (and others?)
3782         https://bugs.webkit.org/show_bug.cgi?id=125569
3783
3784         Reviewed by Gustavo Noronha Silva.
3785
3786         * gtk/generate-inspector-gresource-manifest.py: Added.
3787
3788 2013-12-22  Csaba Osztrogonác  <ossy@webkit.org>
3789
3790         Last URTBF after r160971 to make EFL build happy.
3791
3792         * TestWebKitAPI/efl/PlatformWebView.cpp:
3793         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3794
3795 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3796
3797         Unreviewed. Add myself to some more watch lists.
3798
3799         * Scripts/webkitpy/common/config/watchlist: Watch also soup, gst
3800         and binding scripts patches.
3801
3802 2013-12-20  Commit Queue  <commit-queue@webkit.org>
3803
3804         Unreviewed, rolling out r160941.
3805         http://trac.webkit.org/changeset/160941
3806         https://bugs.webkit.org/show_bug.cgi?id=126095
3807
3808         Doesn't handle subpixel layout being disabled (Requested by
3809         smfr on #webkit).
3810
3811         * gdb/webkit.py:
3812         (JSCJSStringPrinter.to_string):
3813         (add_pretty_printers):
3814         * lldb/lldb_webkit.py:
3815         (WTFMediaTime_SummaryProvider):
3816         (WTFStringProvider.to_string):
3817
3818 2013-12-20  Bem Jones-Bey  <bjonesbe@adobe.com>
3819
3820         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
3821         https://bugs.webkit.org/show_bug.cgi?id=126080
3822
3823         Reviewed by Anders Carlsson.
3824
3825         This changes the output of printing LayoutUnits to be in px, removing
3826         the need to divide by 64 manually.
3827
3828         This will lead to gdb output like:
3829
3830         m_frameRect = {
3831             m_location = LayoutPoint(0px, 0px),
3832             m_size = LayoutSize(800px, 585px)
3833         }
3834
3835         And lldb output like:
3836
3837         (const WebCore::LayoutRect) $0 = {
3838           m_location = { x = 744px, y = 1px }
3839           m_size = { width = 236px, height = 40px }
3840         }
3841
3842         This patch is based on patch for Blink by cbiesinger@chromium.org.
3843
3844         * gdb/webkit.py:
3845         (WebCoreLayoutUnitPrinter):
3846         (WebCoreLayoutUnitPrinter.__init__):
3847         (WebCoreLayoutUnitPrinter.to_string):
3848         (WebCoreLayoutSizePrinter):
3849         (WebCoreLayoutSizePrinter.__init__):
3850         (WebCoreLayoutSizePrinter.to_string):
3851         (WebCoreLayoutPointPrinter):
3852         (WebCoreLayoutPointPrinter.__init__):
3853         (WebCoreLayoutPointPrinter.to_string):
3854         (add_pretty_printers):
3855         * lldb/lldb_webkit.py:
3856         (__lldb_init_module):
3857         (WebCoreLayoutUnit_SummaryProvider):
3858         (WebCoreLayoutSize_SummaryProvider):
3859         (WebCoreLayoutPoint_SummaryProvider):
3860         (WebCoreLayoutUnitProvider):
3861         (WebCoreLayoutUnitProvider.__init__):
3862         (WebCoreLayoutUnitProvider.to_string):
3863         (WebCoreLayoutSizeProvider):
3864         (WebCoreLayoutSizeProvider.__init__):
3865         (WebCoreLayoutSizeProvider.get_width):
3866         (WebCoreLayoutSizeProvider.get_height):
3867         (WebCoreLayoutPointProvider):
3868         (WebCoreLayoutPointProvider.__init__):
3869         (WebCoreLayoutPointProvider.get_x):
3870         (WebCoreLayoutPointProvider.get_y):
3871
3872 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
3873
3874         [GTK] [CMake] Add support for building ImageDiff
3875         https://bugs.webkit.org/show_bug.cgi?id=125960
3876
3877         Reviewed by Gustavo Noronha Silva.
3878
3879         * CMakeLists.txt: Build ImageDiff for GTK+.
3880         * ImageDiff/PlatformGTK.cmake: Added.
3881
3882 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
3883
3884         [GTK] [CMake] Add support for building DumpRenderTree
3885         https://bugs.webkit.org/show_bug.cgi?id=125767
3886
3887         Reviewed by Gustavo Noronha Silva.
3888
3889         * CMakeLists.txt: Load the DumpRenderTree cmake file for GTK+ when WebKit1 is enabled.
3890         * DumpRenderTree/PlatformGTK.cmake: Added.
3891
3892 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
3893
3894         [GTK] [CMake] Add support for building WebKitTestRunner
3895         https://bugs.webkit.org/show_bug.cgi?id=125768
3896
3897         Reviewed by Gustavo Noronha Silva.
3898
3899         * CMakeLists.txt: Compile WebKitTestRunner for GTK+ when WebKit2 is enabled.
3900         * WebKitTestRunner/CMakeLists.txt: Remove some EFL specific flags from the common
3901         build file.
3902         * WebKitTestRunner/PlatformEfl.cmake: Move the flags here.
3903         * WebKitTestRunner/PlatformGTK.cmake: Added.
3904
3905 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
3906
3907         Myles C. Maxfield is a committer now
3908
3909         Unreviewed.
3910
3911         * Scripts/webkitpy/common/config/contributors.json:
3912
3913 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3914
3915         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
3916         https://bugs.webkit.org/show_bug.cgi?id=125854
3917
3918         Reviewed by Chris Fleizach.
3919
3920         Ensure we don't ever create instances of AccessibilityUIElement
3921         wrapping invalid platform-specific accessibility objects in DRT,
3922         both for consistency with what WKTR does (so we avoid situations
3923         where some tests fail in WK2 and not in WK1) and also to avoid
3924         overlooking tests that might not be checking the right thing.
3925
3926         * DumpRenderTree/AccessibilityUIElement.cpp:
3927         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
3928         nullPtr if the platformUIElement() is not a valid one.
3929         * DumpRenderTree/AccessibilityUIElement.h:
3930         (AccessibilityUIElement::platformUIElement): Added const modifier.
3931
3932 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3933
3934         Programmatically-inserted children lack accessibility events
3935         https://bugs.webkit.org/show_bug.cgi?id=100275
3936
3937         Reviewed by Chris Fleizach.
3938
3939         Update DRT and WebKitTestRunner to handle the children-changed
3940         signal properly, considering the detail and optional parameters.
3941
3942         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
3943         (axObjectEventListener):
3944         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
3945
3946 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3947
3948         Removed unused BUILDER_BASE_URL.
3949         https://bugs.webkit.org/show_bug.cgi?id=125442
3950
3951         Reviewed by Csaba Osztrogonác.
3952
3953         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3954         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
3955
3956 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3957
3958         Removed unused BUILDER_BASE_URL.
3959         https://bugs.webkit.org/show_bug.cgi?id=125442
3960
3961         Reviewed by Csaba Osztrogonác.
3962
3963         The string constant BUILDER_BASE_URL is passed around several times,
3964         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
3965
3966         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3967         (Manager._upload_json_files):
3968         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3969         (JSONLayoutResultsGenerator.__init__):
3970         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3971         (JSONResultsGenerator.__init__):
3972
3973 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
3974
3975         check-webkit-style mistakenly flags assigning to a dereferenced pointer
3976         https://bugs.webkit.org/show_bug.cgi?id=126041
3977
3978         Reviewed by Ryosuke Niwa.
3979
3980         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
3981         sure that there is a declaration. This patch makes sure that there is a
3982         declaration in order to flag spacing around asterisks.
3983
3984         * Scripts/webkitpy/style/checkers/cpp.py:
3985         (check_spacing):
3986         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3987         (CppStyleTest.test_pointer_reference_marker_location):
3988
3989 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
3990
3991         check-webkit-style marks rvalue references as violations
3992         https://bugs.webkit.org/show_bug.cgi?id=126000
3993
3994         Reviewed by Ryosuke Niwa.
3995
3996         Previously, check-webkit-style was making sure that any line with "&&" had
3997         spaces around it. However, we can now legitimately use "&&" without a previous
3998         space when declaring an rvalue reference. This patch relaxes this check.
3999
4000         * Scripts/webkitpy/style/checkers/cpp.py:
4001         (check_spacing):
4002         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4003         (CppStyleTest.test_spacing_for_binary_ops):
4004
4005 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
4006
4007         check-webkit-style marks auto return types for functions as violations
4008         https://bugs.webkit.org/show_bug.cgi?id=125999
4009
4010         Reviewed by Ryosuke Niwa.
4011
4012         If a function declaration ends with a "->" followed by a non whitespace
4013         string, don't mark as an invalid "{" on its own line
4014
4015         * Scripts/webkitpy/style/checkers/cpp.py:
4016         (check_braces):
4017         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4018         (CppStyleTest.test_brace_at_begin_of_line):
4019
4020 2013-12-19  Alex Christensen  <achristensen@webkit.org>
4021
4022         [WinCairo] More GStreamer preparations.
4023
4024         Unreviewed.
4025
4026         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
4027         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
4028
4029 2013-12-19  Lucas Forschler  <lforschler@apple.com>
4030
4031         Add Apple Mavericks perf bot.
4032         
4033         Unreviewed.
4034
4035         * BuildSlaveSupport/build.webkit.org-config/config.json:
4036
4037 2013-12-19  Commit Queue  <commit-queue@webkit.org>
4038
4039         Unreviewed, rolling out r160842.
4040         http://trac.webkit.org/changeset/160842
4041         https://bugs.webkit.org/show_bug.cgi?id=126003
4042
4043         broke accessibility/loading-iframe-updates-axtree.html
4044         (Requested by ap on #webkit).
4045
4046         * DumpRenderTree/AccessibilityUIElement.cpp:
4047         (AccessibilityUIElement::makeJSAccessibilityUIElement):
4048         * DumpRenderTree/AccessibilityUIElement.h:
4049         (AccessibilityUIElement::platformUIElement):
4050
4051 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
4052
4053         get_test_baseline should get Host from test_config
4054         https://bugs.webkit.org/show_bug.cgi?id=125989
4055
4056         Reviewed by Ryosuke Niwa.
4057
4058         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4059         (TestConfig.__init__):
4060         (RebaselineServer._prepare_config):
4061         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4062         (get_test_baselines):
4063         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
4064         (get_test_config):
4065
4066 2013-12-19  Roger Fong  <roger_fong@apple.com>
4067
4068         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
4069         https://bugs.webkit.org/show_bug.cgi?id=125998.
4070
4071         Reviewed by Alexey Proskuryakov.
4072
4073         * Scripts/webkitdirs.pm:
4074         (visualStudioInstallDir):
4075         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
4076
4077 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
4078
4079         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
4080         https://bugs.webkit.org/show_bug.cgi?id=125854
4081
4082         Reviewed by Chris Fleizach.
4083
4084         Ensure we don't ever create instances of AccessibilityUIElement
4085         wrapping invalid platform-specific accessibility objects in DRT,
4086         both for consistency with what WKTR does (so we avoid situations
4087         where some tests fail in WK2 and not in WK1) and also to avoid
4088         overlooking tests that might not be checking the right thing.
4089
4090         * DumpRenderTree/AccessibilityUIElement.cpp:
4091         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
4092         nullPtr if the platformUIElement() is not a valid one.
4093         * DumpRenderTree/AccessibilityUIElement.h:
4094         (AccessibilityUIElement::platformUIElement): Added const modifier.
4095
4096 2013-12-18  Anders Carlsson  <andersca@apple.com>
4097
4098         Deprecate some WKMutableDictionary functions
4099         https://bugs.webkit.org/show_bug.cgi?id=125962
4100
4101         Reviewed by Tim Horton.
4102
4103         * TestWebKitAPI/PlatformUtilities.cpp:
4104         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
4105         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
4106         (TestWebKitAPI::didAssociateFormControls):
4107         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
4108         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
4109         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
4110         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4111         (WTR::createMouseMessageBody):
4112         (WTR::EventSendingController::mouseMoveTo):
4113         (WTR::EventSendingController::leapForward):
4114         (WTR::createKeyDownMessageBody):
4115         (WTR::EventSendingController::mouseScrollBy):
4116         (WTR::EventSendingController::continuousMouseScrollBy):
4117         (WTR::EventSendingController::addTouchPoint):
4118         (WTR::EventSendingController::updateTouchPoint):
4119         (WTR::EventSendingController::setTouchModifier):
4120         (WTR::EventSendingController::setTouchPointRadius):
4121         (WTR::EventSendingController::touchStart):
4122         (WTR::EventSendingController::touchMove):
4123         (WTR::EventSendingController::touchEnd):
4124         (WTR::EventSendingController::touchCancel):
4125         (WTR::EventSendingController::clearTouchPoints):
4126         (WTR::EventSendingController::releaseTouchPoint):
4127         (WTR::EventSendingController::cancelTouchPoint):
4128         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4129         (WTR::InjectedBundle::done):
4130         (WTR::InjectedBundle::setMockGeolocationPosition):
4131         (WTR::InjectedBundle::setCustomPolicyDelegate):
4132         (WTR::InjectedBundle::setVisibilityState):
4133         (WTR::InjectedBundle::queueLoad):
4134         (WTR::InjectedBundle::queueLoadHTMLString):
4135         * WebKitTestRunner/TestController.cpp:
4136         (WTR::TestController::initialize):
4137         (WTR::TestController::resetStateToConsistentValues):
4138         * WebKitTestRunner/TestInvocation.cpp:
4139         (WTR::updateThreadedScrollingForCurrentTest):
4140         (WTR::updateLayoutType):
4141         (WTR::TestInvocation::invoke):
4142
4143 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
4144
4145         [GTK] [CMake] Add support for building GtkLauncher
4146         https://bugs.webkit.org/show_bug.cgi?id=125766
4147
4148         Reviewed by Gustavo Noronha Silva.
4149
4150         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
4151         * GtkLauncher/CMakeLists.txt: Added.
4152         * GtkLauncher/main.c: Support including the CMake config file.
4153
4154 2013-12-18  Alex Christensen  <achristensen@webkit.org>
4155
4156         [WinCairo] Preparation for GStreamer on Windows.
4157         https://bugs.webkit.org/show_bug.cgi?id=125946
4158
4159         Reviewed by Brent Fulgham.
4160
4161         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
4162         Use new GStreamer property sheets for WinCairo.
4163         * win/DLLLauncher/DLLLauncherMain.cpp:
4164         (modifyPath):
4165         (wWinMain):
4166         Prepend GStreamer bin directory to path if it exists.
4167
4168 2013-12-18  Anders Carlsson  <andersca@apple.com>
4169
4170         Remove now useless test.
4171
4172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4173         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
4174         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
4175         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
4176
4177 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
4178
4179         Fix page visibility api test, initialization in WebKit2
4180         https://bugs.webkit.org/show_bug.cgi?id=125933
4181
4182         Reviewed by Anders Carlsson.
4183
4184         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
4185         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
4186
4187         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: