Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests...
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4         https://bugs.webkit.org/show_bug.cgi?id=194586
5
6         Reviewed by Ross Kirsling.
7
8         * DumpRenderTree/win/DumpRenderTree.cpp:
9         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
10         * Scripts/webkitpy/port/driver.py:
11         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
12
13 2019-02-17  David Kilzer  <ddkilzer@apple.com>
14
15         Unreviewed, rolling out r241620.
16
17         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
18         (Requested by ddkilzer on #webkit.)
19
20         Reverted changeset:
21
22         "[WTF] Add environment variable helpers"
23         https://bugs.webkit.org/show_bug.cgi?id=192405
24         https://trac.webkit.org/changeset/241620
25
26 2019-02-16  Zalan Bujtas  <zalan@apple.com>
27
28         [LFC] RenderImage's default intrinsic size is 0.
29         https://bugs.webkit.org/show_bug.cgi?id=194745
30
31         Reviewed by Antti Koivisto.
32
33         * LayoutReloaded/misc/LFC-passing-tests.txt:
34
35 2019-02-16  Zalan Bujtas  <zalan@apple.com>
36
37         [LFC][BFC] Add support for block replaced intrinsic width.
38         https://bugs.webkit.org/show_bug.cgi?id=194705
39
40         Reviewed by Simon Fraser.
41
42         * LayoutReloaded/misc/LFC-passing-tests.txt:
43
44 2019-02-16  Zalan Bujtas  <zalan@apple.com>
45
46         [LFC] Apply min/max width constraints to preferred width computation
47         https://bugs.webkit.org/show_bug.cgi?id=194739
48
49         Reviewed by Simon Fraser.
50
51         * LayoutReloaded/misc/LFC-passing-tests.txt:
52
53 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
54
55         [WTF] Add environment variable helpers
56         https://bugs.webkit.org/show_bug.cgi?id=192405
57
58         Reviewed by Michael Catanzaro.
59
60         * DumpRenderTree/mac/DumpRenderTree.mm:
61         (libraryPathForDumpRenderTree):
62         * DumpRenderTree/win/DumpRenderTree.cpp:
63         (libraryPathForDumpRenderTree):
64         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
65         (setUpIOSLayoutTestCommunication):
66         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
67         (beforeAll):
68         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
69         (main):
70         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
71         (WebKitTestBus::run):
72         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
73         (WTR::getOutputDir):
74         (WTR::initializeFontConfigSetting):
75         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
76         (WTR::InjectedBundle::platformInitialize):
77         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
78         (WTR::topLevelPath):
79         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
80         (WTR::topLevelPath):
81         (WTR::getOutputDir):
82         (WTR::activateFonts):
83         * WebKitTestRunner/TestController.cpp:
84         (WTR::TestController::libraryPathForTesting):
85         (WTR::TestController::generateContextConfiguration const):
86         (WTR::TestController::generatePageConfiguration):
87         (WTR::TestController::decideDestinationWithSuggestedFilename):
88         (WTR::TestController::platformAdjustContext):
89         * WebKitTestRunner/TestController.h:
90         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
91         (WTR::TestController::cocoaPlatformInitialize):
92         (WTR::TestController::platformAdjustContext):
93         * WebKitTestRunner/gtk/main.cpp:
94         (main):
95         * WebKitTestRunner/mac/TestControllerMac.mm:
96         (WTR::TestController::configureContentExtensionForTest):
97         * WebKitTestRunner/wpe/main.cpp:
98         (main):
99         Utilize WTF::Environment where possible.
100
101 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
102
103         [iOS] WKWebView callout bar is missing Change Writing Direction item
104         https://bugs.webkit.org/show_bug.cgi?id=190015
105         <rdar://problem/44810366>
106
107         Reviewed by Tim Horton.
108
109         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
110         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
111
112         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
113         (TestWebKitAPI::TEST):
114
115 2019-02-15  Chris Dumez  <cdumez@apple.com>
116
117         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
118         https://bugs.webkit.org/show_bug.cgi?id=194717
119         <rdar://problem/47884404>
120
121         Reviewed by Brady Eidson.
122
123         Add API test coverage.
124
125         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
126
127 2019-02-15  Youenn Fablet  <youenn@apple.com>
128
129         Make navigator.mediaDevices SecureContext
130         https://bugs.webkit.org/show_bug.cgi?id=194666
131
132         Reviewed by Eric Carlson.
133
134         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
135         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
136         (TEST_F):
137
138 2019-02-15  Brian Burg  <bburg@apple.com>
139
140         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
141         https://bugs.webkit.org/show_bug.cgi?id=194411
142         <rdar://problem/47787614>
143
144         Reviewed by Joseph Pecoraro.
145
146         Remove unnecessary soft linking macro usage.
147
148         * DumpRenderTree/mac/TestRunnerMac.mm:
149         (TestRunner::inspectorTestStubURL):
150         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
151         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
152         (WTR::TestRunner::inspectorTestStubURL):
153
154 2019-02-15  Commit Queue  <commit-queue@webkit.org>
155
156         Unreviewed, rolling out r241559 and r241566.
157         https://bugs.webkit.org/show_bug.cgi?id=194710
158
159         Causes layout test crashes under GuardMalloc (Requested by
160         ryanhaddad on #webkit).
161
162         Reverted changesets:
163
164         "[WTF] Add environment variable helpers"
165         https://bugs.webkit.org/show_bug.cgi?id=192405
166         https://trac.webkit.org/changeset/241559
167
168         "Unreviewed build fix for WinCairo Debug after r241559."
169         https://trac.webkit.org/changeset/241566
170
171 2019-02-15  Zalan Bujtas  <zalan@apple.com>
172
173         [LFC] Out-of-flow box is never a float box
174         https://bugs.webkit.org/show_bug.cgi?id=194704
175
176         Reviewed by Antti Koivisto.
177
178         * LayoutReloaded/misc/LFC-passing-tests.txt:
179
180 2019-02-10  Darin Adler  <darin@apple.com>
181
182         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
183         https://bugs.webkit.org/show_bug.cgi?id=194487
184
185         Reviewed by Daniel Bates.
186
187         * DumpRenderTree/win/DumpRenderTree.cpp:
188         (applicationId): Use makeString instead of String::format.
189         (main): Ditto.
190         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
191         (TestWebKitAPI::Util::createURLForResource): Ditto.
192         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
193         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
194
195         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
196         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
197         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
198         (WTR::createStringWithAttributes): Use appendLiteral.
199         (WTR::AccessibilityUIElement::helpText const): Ditto.
200         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
201         directly instead of using String::format.
202         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
203         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
204
205 2019-02-15  Truitt Savell  <tsavell@apple.com>
206
207         Unreviewed, rolling out r241564.
208
209         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
210
211         Reverted changeset:
212
213         "[Mac] WebInspectorUI.framework does not need to be soft-
214         linked anymore"
215         https://bugs.webkit.org/show_bug.cgi?id=194411
216         https://trac.webkit.org/changeset/241564
217
218 2019-02-15  Saam barati  <sbarati@apple.com>
219
220         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
221         https://bugs.webkit.org/show_bug.cgi?id=194036
222
223         Reviewed by Yusuke Suzuki.
224
225         * Scripts/run-jsc-stress-tests:
226
227 2019-02-14  Tim Horton  <timothy_horton@apple.com>
228
229         Fix the build.
230
231         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
232         (WTR::UIScriptController::drawSquareInEditableImage):
233         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
234         (TestWebKitAPI::drawSquareInEditableImage):
235
236 2019-02-14  Tim Horton  <timothy_horton@apple.com>
237
238         Fix the build.
239
240         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
241         (WTR::UIScriptController::drawSquareInEditableImage):
242         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
243         (TestWebKitAPI::drawSquareInEditableImage):
244
245 2019-02-14  Brian Burg  <bburg@apple.com>
246
247         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
248         https://bugs.webkit.org/show_bug.cgi?id=194411
249         <rdar://problem/47787614>
250
251         Reviewed by Joseph Pecoraro.
252
253         Remove unnecessary soft linking macro usage.
254
255         * DumpRenderTree/mac/TestRunnerMac.mm:
256         (TestRunner::inspectorTestStubURL):
257         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
258         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
259         (WTR::TestRunner::inspectorTestStubURL):
260
261 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
262
263         [ews-app] status bubble should fetch builder name info from BuilderMapping table
264         https://bugs.webkit.org/show_bug.cgi?id=194599
265
266         Reviewed by Lucas Forschler.
267
268         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
269         (StatusBubble._build_bubble):
270
271 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
272
273         [ews-app] Set Foreign Key in Django build model
274         https://bugs.webkit.org/show_bug.cgi?id=194667
275
276         Reviewed by Lucas Forschler.
277
278         * BuildSlaveSupport/ews-app/ews/models/build.py:
279         (Build):
280
281 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
282
283         [WTF] Add environment variable helpers
284         https://bugs.webkit.org/show_bug.cgi?id=192405
285
286         Reviewed by Michael Catanzaro.
287
288         * DumpRenderTree/mac/DumpRenderTree.mm:
289         (libraryPathForDumpRenderTree):
290         * DumpRenderTree/win/DumpRenderTree.cpp:
291         (libraryPathForDumpRenderTree):
292         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
293         (setUpIOSLayoutTestCommunication):
294         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
295         (TestWebKitAPI::strip):
296         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
297         (beforeAll):
298         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
299         (main):
300         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
301         (WebKitTestBus::run):
302         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
303         (WTR::getOutputDir):
304         (WTR::initializeFontConfigSetting):
305         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
306         (WTR::InjectedBundle::platformInitialize):
307         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
308         (WTR::topLevelPath):
309         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
310         (WTR::topLevelPath):
311         (WTR::getOutputDir):
312         (WTR::activateFonts):
313         * WebKitTestRunner/TestController.cpp:
314         (WTR::TestController::libraryPathForTesting):
315         (WTR::TestController::generateContextConfiguration const):
316         (WTR::TestController::generatePageConfiguration):
317         (WTR::TestController::decideDestinationWithSuggestedFilename):
318         (WTR::TestController::platformAdjustContext):
319         * WebKitTestRunner/TestController.h:
320         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
321         (WTR::TestController::cocoaPlatformInitialize):
322         (WTR::TestController::platformAdjustContext):
323         * WebKitTestRunner/gtk/main.cpp:
324         (main):
325         * WebKitTestRunner/mac/TestControllerMac.mm:
326         (WTR::TestController::configureContentExtensionForTest):
327         * WebKitTestRunner/wpe/main.cpp:
328         (main):
329         Utilize WTF::Environment where possible.
330
331 2019-02-14  Chris Dumez  <cdumez@apple.com>
332
333         [PSON] Introduce a WebContent Process cache
334         https://bugs.webkit.org/show_bug.cgi?id=194594
335         <rdar://problem/46793397>
336
337         Reviewed by Geoff Garen.
338
339         Update API tests to turn on the WebContent Process cache.
340
341         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
342
343 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
344
345         Unreviewed, build fix after r241480
346
347         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
348         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
349         (-[DragAndDropSimulator initWithWebView:]):
350
351 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
352
353         AX: ARIA Reflection was disabled in error
354         https://bugs.webkit.org/show_bug.cgi?id=194647
355         <rdar://problem/48068336>
356
357         Reviewed by Ryosuke Niwa.
358
359         Remove test override now that this feature should be enabled by default.
360
361         * WebKitTestRunner/TestController.cpp:
362         (WTR::TestController::resetPreferencesToConsistentValues):
363
364 2019-02-14  Commit Queue  <commit-queue@webkit.org>
365
366         Unreviewed, rolling out r241486.
367         https://bugs.webkit.org/show_bug.cgi?id=194655
368
369         causing API failures in builds (Requested by ShawnRoberts on
370         #webkit).
371
372         Reverted changeset:
373
374         "[Cocoa] Media elements will restart network buffering just
375         before suspending"
376         https://bugs.webkit.org/show_bug.cgi?id=193691
377         https://trac.webkit.org/changeset/241486
378
379 2019-02-14  Zalan Bujtas  <zalan@apple.com>
380
381         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
382         https://bugs.webkit.org/show_bug.cgi?id=194622
383
384         Reviewed by Antti Koivisto.
385
386         * LayoutReloaded/misc/LFC-passing-tests.txt:
387
388 2019-02-14  Zalan Bujtas  <zalan@apple.com>
389
390         [LFC] Shrink-to-fit-width should be constrained by min/max width
391         https://bugs.webkit.org/show_bug.cgi?id=194653
392
393         Reviewed by Antti Koivisto.
394
395         * LayoutReloaded/misc/LFC-passing-tests.txt:
396
397 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
398
399         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
400         https://bugs.webkit.org/show_bug.cgi?id=194641
401
402         Reviewed by Geoffrey Garen.
403
404         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
405         so that the test would fail without this fix.
406
407         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
408         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
409
410 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
411
412         [ews-app] Change log level for a log statement
413
414         Unreviewed minor fix.
415
416         * BuildSlaveSupport/ews-app/ews/models/patch.py:
417         (Patch.save_patch):
418
419 2019-02-13  Jer Noble  <jer.noble@apple.com>
420
421         [Cocoa] Media elements will restart network buffering just before suspending
422         https://bugs.webkit.org/show_bug.cgi?id=193691
423
424         Reviewed by Eric Carlson.
425
426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
427         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
428         (TEST):
429
430 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
431
432         [ews-app] Fetch builder id to name mapping
433         https://bugs.webkit.org/show_bug.cgi?id=194355
434
435         Reviewed by Lucas Forschler.
436
437         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
438         (Buildbot.get_builder_id_to_name_mapping):
439         (Buildbot._get_display_name_from_builder_name):
440
441 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
442
443         Further restricting webarchive loads
444         https://bugs.webkit.org/show_bug.cgi?id=194567
445         <rdar://problem/47610130>
446
447         Reviewed by Youenn Fablet.
448
449         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
450         navigations on drop.
451
452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
453         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
454         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
455         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
456         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
457         (TestWebKitAPI::TEST):
458         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
459         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
460         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
461         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
462         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
463         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
464         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
465
466 2019-02-13  John Wilander  <wilander@apple.com>
467
468         Store Ad Click Attribution requests in the network process
469         https://bugs.webkit.org/show_bug.cgi?id=194510
470         <rdar://problem/47650118>
471
472         Reviewed by Alex Christensen and Daniel Bates.
473
474         This patch adds two TestRunner functions:
475         - dumpAdClickAttribution()
476         - clearAdClickAttribution()
477
478         They call into the network process to dump and clear Ad Click
479         Attribution state, respectively.
480
481         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
482         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
483         (WTR::TestRunner::dumpAdClickAttribution):
484         (WTR::TestRunner::clearAdClickAttribution):
485         * WebKitTestRunner/InjectedBundle/TestRunner.h:
486         * WebKitTestRunner/TestController.cpp:
487         (WTR::TestController::resetStateToConsistentValues):
488         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
489         (WTR::adClickAttributionStringResultCallback):
490         (WTR::TestController::dumpAdClickAttribution):
491         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
492         (WTR::adClickAttributionVoidCallback):
493         (WTR::TestController::clearAdClickAttribution):
494         * WebKitTestRunner/TestController.h:
495         * WebKitTestRunner/TestInvocation.cpp:
496         (WTR::TestInvocation::dumpResults):
497         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
498         (WTR::TestInvocation::dumpAdClickAttribution):
499         * WebKitTestRunner/TestInvocation.h:
500
501 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
502
503         [ews-app] Generate status-bubble
504         https://bugs.webkit.org/show_bug.cgi?id=194572
505
506         Reviewed by Lucas Forschler.
507
508         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
509         (StatusBubble._build_bubble):
510         (StatusBubble._should_show_bubble_for):
511         (StatusBubble._build_bubbles_for_patch):
512
513 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
514
515         [ews-app] Add status bubble html template
516         https://bugs.webkit.org/show_bug.cgi?id=194571
517
518         Reviewed by Lucas Forschler.
519
520         * BuildSlaveSupport/ews-app/ews/templates: Added.
521         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
522
523 2019-02-12  Chris Dumez  <cdumez@apple.com>
524
525         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
526         https://bugs.webkit.org/show_bug.cgi?id=194568
527         <rdar://problem/47944490>
528
529         Reviewed by Ryosuke Niwa.
530
531         Add API test coverage.
532
533         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
534         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
535
536 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
537
538         webkitpy: Remove bug_dummy from parsed test expectations
539         https://bugs.webkit.org/show_bug.cgi?id=194562
540         <rdar://problem/47853999>
541
542         Reviewed by Lucas Forschler.
543
544         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
545         (TestExpectationParser):
546         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
547         skipped tests.
548         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
549
550 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
551
552         [ews-app] Add method to fetch patch
553         https://bugs.webkit.org/show_bug.cgi?id=194518
554
555         Reviewed by Lucas Forschler.
556
557         * BuildSlaveSupport/ews-app/ews/models/patch.py:
558         (Patch.get_patch):
559
560 2019-02-12  Zalan Bujtas  <zalan@apple.com>
561
562         [LFC] Expand tests coverage (60 new tests -> 860)
563
564         Unreviewed test gardening (run-singly, --child-processes=1).
565
566         * LayoutReloaded/misc/LFC-passing-tests.txt:
567
568 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
569
570         Allow pages to trigger programmatic paste from script on iOS
571         https://bugs.webkit.org/show_bug.cgi?id=194271
572         <rdar://problem/47808810>
573
574         Reviewed by Tim Horton.
575
576         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
577
578         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
579         (WTR::UIScriptController::platformSetDidShowMenuCallback):
580         (WTR::UIScriptController::platformSetDidHideMenuCallback):
581         (WTR::UIScriptController::rectForMenuAction const):
582
583         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
584         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
585         for when the menu is shown or hidden.
586
587         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
588         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
589         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
590         (WTR::UIScriptController::setDidShowMenuCallback):
591         (WTR::UIScriptController::didShowMenuCallback const):
592         (WTR::UIScriptController::setDidHideMenuCallback):
593         (WTR::UIScriptController::didHideMenuCallback const):
594         (WTR::UIScriptController::platformSetDidShowMenuCallback):
595         (WTR::UIScriptController::platformSetDidHideMenuCallback):
596         (WTR::UIScriptController::rectForMenuAction const):
597         * TestRunnerShared/UIScriptContext/UIScriptController.h:
598         * WebKitTestRunner/TestController.cpp:
599         (WTR::TestController::resetPreferencesToConsistentValues):
600         (WTR::updateTestOptionsFromTestHeader):
601         * WebKitTestRunner/TestOptions.h:
602
603         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
604         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
605
606         (WTR::TestOptions::hasSameInitializationOptions const):
607         * WebKitTestRunner/UIScriptControllerCocoa.mm:
608         (WTR::UIScriptController::calendarType const):
609         (WTR::UIScriptController::platformUndoManager const):
610         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
611         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
612         (-[TestRunnerWKWebView initWithFrame:configuration:]):
613         (-[TestRunnerWKWebView dealloc]):
614         (-[TestRunnerWKWebView _didShowMenu]):
615         (-[TestRunnerWKWebView _didHideMenu]):
616
617         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
618
619         * WebKitTestRunner/ios/TestControllerIOS.mm:
620         (WTR::handleMenuWillHideNotification):
621         (WTR::handleMenuDidHideNotification):
622         (WTR::TestController::platformInitialize):
623         (WTR::TestController::platformDestroy):
624         (WTR::TestController::platformResetStateToConsistentValues):
625
626         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
627         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
628
629         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
630         (WTR::forEachViewInHierarchy):
631         (WTR::findViewInHierarchyOfType):
632
633         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
634         functions that dig through a given view's hierarchy in search of a view of a given class.
635
636         (WTR::UIScriptController::selectionStartGrabberViewRect const):
637         (WTR::UIScriptController::selectionEndGrabberViewRect const):
638         (WTR::UIScriptController::selectionCaretViewRect const):
639         (WTR::UIScriptController::selectionRangeViewRects const):
640         (WTR::UIScriptController::platformSetDidShowMenuCallback):
641         (WTR::UIScriptController::platformSetDidHideMenuCallback):
642
643         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
644
645         (WTR::UIScriptController::rectForMenuAction const):
646
647         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
648         callout bar) whose label matches the given string.
649
650         (WTR::UIScriptController::platformContentView const):
651
652         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
653         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
654         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
655
656         (WTR::UIScriptController::platformUndoManager const): Deleted.
657         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
658         (WTR::UIScriptController::platformContentView const):
659         (WTR::UIScriptController::platformUndoManager const): Deleted.
660
661 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
662
663         webkitpy: No option to only show unexpected failures in results.html for iPad
664         https://bugs.webkit.org/show_bug.cgi?id=194554
665         <rdar://problem/47922442>
666
667         Rubber-stamped by Aakash Jain.
668
669         Just because a TestExpecations file does not exist for a specific platform does not mean that
670         TestExpecations are not being used, given that platforms inherit test expectations.
671
672         * Scripts/webkitpy/port/base.py:
673         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
674         * Scripts/webkitpy/port/base_unittest.py:
675         (PortTest.test_uses_test_expectations_file):
676
677 2019-02-12  Alex Christensen  <achristensen@webkit.org>
678
679         Remove setDefersLoading infrastructure from WebKit2
680         https://bugs.webkit.org/show_bug.cgi?id=194506
681
682         Reviewed by Brady Eidson.
683
684         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
685         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
686         (WTR::TestRunner::setDefersLoading): Deleted.
687         * WebKitTestRunner/InjectedBundle/TestRunner.h:
688
689 2019-02-12  Alex Christensen  <achristensen@webkit.org>
690
691         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
692         https://bugs.webkit.org/show_bug.cgi?id=194522
693         <rdar://problem/47789393>
694
695         Reviewed by Chris Dumez.
696
697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
698         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
699         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
700         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
701
702 2019-02-12  Andy Estes  <aestes@apple.com>
703
704         [iOSMac] Enable Parental Controls Content Filtering
705         https://bugs.webkit.org/show_bug.cgi?id=194521
706         <rdar://39732376>
707
708         Reviewed by Tim Horton.
709
710         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
711
712 2019-02-12  Zalan Bujtas  <zalan@apple.com>
713
714         [LFC][IFC] Add intrinsic width support for float boxes.
715         https://bugs.webkit.org/show_bug.cgi?id=194528
716
717         Reviewed by Antti Koivisto.
718
719         Expand tests coverage (2 new tests -> 800).
720         (This is the correct test ordering --runs-singly --child-processes=1)
721
722         * LayoutReloaded/misc/LFC-passing-tests.txt:
723
724 2019-02-12  Rob Buis  <rbuis@igalia.com>
725
726         Implement serializing in MIME type parser
727         https://bugs.webkit.org/show_bug.cgi?id=193909
728
729         Reviewed by Darin Adler.
730
731         Add various tests involving upper case, non-ASCII, control/null characters,
732         various HTTP whitespace, single quotes and an unpaired surrogate.
733
734         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
735         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
736         (TestWebKitAPI::serializeIfValid):
737         (TestWebKitAPI::TEST):
738
739 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
740
741         [Cocoa] Ask platform for generic font family mappings
742         https://bugs.webkit.org/show_bug.cgi?id=187723
743         <rdar://problem/41892438>
744
745         Reviewed by Brent Fulgham.
746
747         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
748
749         * DumpRenderTree/mac/DumpRenderTree.mm:
750         (allowedFontFamilySet):
751         * WebKitTestRunner/mac/TestControllerMac.mm:
752         (WTR::allowedFontFamilySet):
753
754 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
755
756         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
757         https://bugs.webkit.org/show_bug.cgi?id=193622
758
759         Reviewed by Michael Catanzaro.
760
761         This adds support for loading content extension rule sets from the JSON files which
762         accompany the corresponding layout test, using the C API. The Cocoa specific parts
763         of WKTR for this could be removed, but that is left for a follow-up patch with
764         cleanups.
765
766         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
767         * WebKitTestRunner/TestController.cpp:
768         (WTR::testPath): Subtract one from the length when constructing the result std::string to
769         avoid having the null-terminator copied into the result.
770         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
771         part of the preparations to run a test.
772         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
773         (WTR::contentExtensionStoreCallback): Added.
774         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
775         used for content extensions test.
776         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
777         extensions and compiling the JSON rule set for tests involving content extensions.
778         (WTR::TestController::resetContentExtensions): Removes the content extension built for
779         testing and disables content extensions.
780         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
781         resetContentExtensions().
782         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
783         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
784         configureContentExtensionForTest(), and userContentController().
785
786 2019-02-11  Daniel Bates  <dabates@apple.com>
787
788         [iOS] Mouse/Touch/Pointer events are missing modifier keys
789         https://bugs.webkit.org/show_bug.cgi?id=191446
790         <rdar://problem/45929460>
791
792         Reviewed by Tim Horton.
793
794         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
795
796         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
797         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
798         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
799         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
800         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
801         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
802         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
803         * TestRunnerShared/UIScriptContext/UIScriptController.h:
804         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
805         (WTR::arrayLength):
806         (WTR::parseModifierArray):
807         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
808         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
809         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
810         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
811
812 2019-02-11  Commit Queue  <commit-queue@webkit.org>
813
814         Unreviewed, rolling out r241272 and r241276.
815         https://bugs.webkit.org/show_bug.cgi?id=194514
816
817         Broke the Apple Internal build and the fix requires human
818         intervention :( (Requested by dydz on #webkit).
819
820         Reverted changesets:
821
822         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
823         https://bugs.webkit.org/show_bug.cgi?id=191446
824         https://trac.webkit.org/changeset/241272
825
826         "Fix internal iOS build after r241272"
827         https://bugs.webkit.org/show_bug.cgi?id=191446
828         https://trac.webkit.org/changeset/241276
829
830 2019-02-11  Truitt Savell  <tsavell@apple.com>
831
832         Unreviewed, rolling out r241269.
833
834         Caused 5 layout tests crashes on Mac WK1
835
836         Reverted changeset:
837
838         "DumpRenderTree should report unknown options"
839         https://bugs.webkit.org/show_bug.cgi?id=191303
840         https://trac.webkit.org/changeset/241269
841
842 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
843
844         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
845         https://bugs.webkit.org/show_bug.cgi?id=194313
846
847         Reviewed by Tim Horton.
848
849         Add a helper to determine whether the web view is presenting modal UI.
850
851         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
852         (WTR::UIScriptController::isPresentingModally const):
853         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
854         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
855         (WTR::UIScriptController::isPresentingModally const):
856         * TestRunnerShared/UIScriptContext/UIScriptController.h:
857         * WebKitTestRunner/UIScriptControllerCocoa.mm:
858         (WTR::UIScriptController::calendarType const): Deleted.
859         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
860         (WTR::UIScriptController::isPresentingModally const):
861         (WTR::UIScriptController::calendarType const):
862         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
863         (WTR::UIScriptController::calendarType const):
864
865 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
866
867         GCHeapInspector: Show the retained sizes in more places
868         https://bugs.webkit.org/show_bug.cgi?id=194464
869
870         Reviewed by Simon Fraser.
871
872         * GCHeapInspector/gc-heap-inspector.html:
873         * GCHeapInspector/script/interface.js:
874         (HeapInspectorUtils.humanReadableSize):
875         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
876         (HeapInspectorUtils.spanForNode.span.span):
877         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
878         (HeapSnapshotInspector.prototype.buildRoots):
879
880 2019-02-11  Daniel Bates  <dabates@apple.com>
881
882         [iOS] Mouse/Touch/Pointer events are missing modifier keys
883         https://bugs.webkit.org/show_bug.cgi?id=191446
884         <rdar://problem/45929460>
885
886         Reviewed by Tim Horton.
887
888         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
889
890         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
891         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
892         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
893         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
894         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
895         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
896         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
897         * TestRunnerShared/UIScriptContext/UIScriptController.h:
898         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
899         (WTR::arrayLength):
900         (WTR::parseModifierArray):
901         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
902         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
903         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
904         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
905
906 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
907
908         DumpRenderTree should report unknown options
909         https://bugs.webkit.org/show_bug.cgi?id=191303
910
911         Reviewed by Frédéric Wang.
912
913         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
914         to report unknown options.
915         Added and assigned test options which are currently used in tests.
916
917         * DumpRenderTree/TestOptions.cpp:
918         (TestOptions::TestOptions):
919
920 2019-02-11  Truitt Savell  <tsavell@apple.com>
921
922         Unreviewed, rolling out r241229.
923
924         Revision broke internal builds for watchOS.
925
926         Reverted changeset:
927
928         "[Cocoa] Ask platform for generic font family mappings"
929         https://bugs.webkit.org/show_bug.cgi?id=187723
930         https://trac.webkit.org/changeset/241229
931
932 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
933
934         [WinCairo][MiniBrowser] Basic authentication always fails.
935         https://bugs.webkit.org/show_bug.cgi?id=194496
936
937         Reviewed by Don Olmstead.
938
939         * MiniBrowser/win/DialogHelper.h:
940         (Dialog::getText):
941
942 2019-02-11  Philippe Normand  <pnormand@igalia.com>
943
944         [GStreamer] GstMappedBuffer testsuite build fails
945         https://bugs.webkit.org/show_bug.cgi?id=194495
946
947         Reviewed by Carlos Garcia Campos.
948
949         Fix the build by explicitely adding the gstreamer1.0-audio include
950         directories to the include path.
951
952         * TestWebKitAPI/PlatformGTK.cmake:
953         * TestWebKitAPI/PlatformWPE.cmake:
954
955 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
956
957         [GTK][WPE] Add enable-javascript-markup setting
958         https://bugs.webkit.org/show_bug.cgi?id=193439
959
960         Reviewed by Michael Catanzaro.
961
962         Add test cases to check the new setting.
963
964         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
965         (testWebKitSettings):
966         (testWebKitSettingsJavaScriptMarkup):
967         (beforeAll):
968
969 2019-02-10  Darin Adler  <darin@apple.com>
970
971         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
972         https://bugs.webkit.org/show_bug.cgi?id=194485
973
974         Reviewed by Daniel Bates.
975
976         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
977
978 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
979
980         Add more tests for clampTo<>()
981         https://bugs.webkit.org/show_bug.cgi?id=194462
982
983         Reviewed by Geoffrey Garen.
984
985         Darin suggested to test the very last floating point number
986         at the boundaries when truncating to integer.
987         I added test for max/min and max-1/min-1.
988
989         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
990         (TestWebKitAPI::TEST):
991
992 2019-02-09  Darin Adler  <darin@apple.com>
993
994         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
995         https://bugs.webkit.org/show_bug.cgi?id=194021
996
997         Reviewed by Geoffrey Garen.
998
999         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1000         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1001         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1002
1003 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1004
1005         [LFC][IFC] Add intrinsic width support for basic inline containers
1006         https://bugs.webkit.org/show_bug.cgi?id=194473
1007
1008         Reviewed by Antti Koivisto.
1009
1010         Expand tests coverage (11 new tests -> 798)
1011
1012         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1013
1014 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1015
1016         Fix MiniBrowser's entitlements
1017         https://bugs.webkit.org/show_bug.cgi?id=192431
1018
1019         Reviewed by Joseph Pecoraro.
1020
1021         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1022         files, making it impossible to load any extension.
1023
1024         * MiniBrowser/MiniBrowser.entitlements:
1025
1026 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1027
1028         [Cocoa] Ask platform for generic font family mappings
1029         https://bugs.webkit.org/show_bug.cgi?id=187723
1030         <rdar://problem/41892438>
1031
1032         Reviewed by Brent Fulgham.
1033
1034         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1035
1036         * DumpRenderTree/mac/DumpRenderTree.mm:
1037         (allowedFontFamilySet):
1038         * WebKitTestRunner/mac/TestControllerMac.mm:
1039         (WTR::allowedFontFamilySet):
1040
1041 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1042
1043         [GTK] Implement back/forward touchpad gesture
1044         https://bugs.webkit.org/show_bug.cgi?id=193919
1045
1046         Reviewed by Michael Catanzaro.
1047
1048         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1049         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1050
1051 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1052
1053         Add SPI to use networking daemon instead of XPC service
1054         https://bugs.webkit.org/show_bug.cgi?id=194427
1055
1056         Reviewed by Geoffrey Garen
1057
1058         * MiniBrowser/MiniBrowser.entitlements:
1059
1060 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1061
1062         [ews-build] Ensure that every builder in config.json has short name
1063         https://bugs.webkit.org/show_bug.cgi?id=194461
1064
1065         Reviewed by Lucas Forschler.
1066
1067         * BuildSlaveSupport/ews-build/loadConfig.py:
1068         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1069
1070 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1071
1072         [ews-build] Add short name to config.json
1073         https://bugs.webkit.org/show_bug.cgi?id=194456
1074
1075         Reviewed by Lucas Forschler.
1076
1077         * BuildSlaveSupport/ews-build/config.json: Added short name.
1078         * BuildSlaveSupport/ews-build/loadConfig.py:
1079         (loadBuilderConfig): Set the short name as the builder description.
1080
1081 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1082
1083         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1084         https://bugs.webkit.org/show_bug.cgi?id=194418
1085
1086         Reviewed by Lucas Forschler.
1087
1088         Do not include errors trying when finding crashlogs at the end of
1089         a run-webkit-tests run since we don't process those errors.
1090
1091         * Scripts/webkitpy/port/darwin.py:
1092         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1093         * Scripts/webkitpy/port/ios_device.py:
1094         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1095         * Scripts/webkitpy/port/watch_device.py:
1096         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1097
1098 2019-02-08  Beth Dakin  <bdakin@apple.com>
1099
1100         Add afterScreenUpdates to WKSnapshotConfiguration
1101         https://bugs.webkit.org/show_bug.cgi?id=194362
1102         -and corresponding-
1103         <rdar://problem/40655528> Please add an "after screen updates" property to 
1104         WKSnapshotConfiguration (to solve blank snapshots)
1105
1106         Reviewed by Tim Horton.
1107
1108         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1109         (TEST):
1110
1111 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1112
1113         clampTo(): do not convert the input to double when dealing with integers
1114         https://bugs.webkit.org/show_bug.cgi?id=194263
1115         <rdar://problem/47692312>
1116
1117         Reviewed by Darin Adler.
1118
1119         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1120         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1121         (TestWebKitAPI::testClampFloatingPointToInteger):
1122         (TestWebKitAPI::testClampSameSignIntegers):
1123         (TestWebKitAPI::testClampUnsignedToSigned):
1124         (TestWebKitAPI::testClampSignedToUnsigned):
1125
1126 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1127
1128         webkitpy: Respect --dedicated-simulators flag
1129         https://bugs.webkit.org/show_bug.cgi?id=194416
1130         <rdar://problem/47894722>
1131
1132         Reviewed by Lucas Forschler.
1133
1134         * Scripts/webkitpy/port/device_port.py:
1135         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1136         available devices can be safely ignored.
1137
1138 2019-02-07  Keith Rollin  <krollin@apple.com>
1139
1140         Remove extra copy of 100x100-red.tga
1141         https://bugs.webkit.org/show_bug.cgi?id=194371
1142         <rdar://problem/47873465>
1143
1144         Reviewed by Said Abou-Hallawa.
1145
1146         In order to help it pass its tests, Bug 194190 added a second copy of
1147         the file 100x100-red.tga. However, it turns out that this additional
1148         file wasn't actually needed, and that that sole previous copy was
1149         sufficient. At the same time, this second copy -- which was copied to
1150         the same location in the build output as the first copy -- now caused
1151         XCBuild to complain because there were two production rules for the
1152         same output file. Address this by removing the newly-added extra copy.
1153
1154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1155         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1156
1157 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1158
1159         Deprecate WKBundlePageSetDefersLoading
1160         https://bugs.webkit.org/show_bug.cgi?id=191394
1161
1162         Reviewed by Dean Jackson.
1163
1164         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1165         (WTR::TestRunner::setDefersLoading):
1166
1167 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1168
1169         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1170         https://bugs.webkit.org/show_bug.cgi?id=194391
1171
1172         Reviewed by Antti Koivisto.
1173
1174         * LayoutReloaded/misc/LFC-passing-tests.txt:
1175
1176 2019-02-06  Keith Rollin  <krollin@apple.com>
1177
1178         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1179         https://bugs.webkit.org/show_bug.cgi?id=193975
1180         <rdar://problem/47643306>
1181
1182         Reviewed by Tim Horton.
1183
1184         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1185         the Info.plist file into the bundle. This step is not necessary as the
1186         implicit "bundle up all the build products into a framework" build
1187         phase does this already. Having the Copy Bundle Resources phase do
1188         this causes a conflict under XCBuild, which objects to two build
1189         phases producing the same file (Info.plist). Address this by removing
1190         Info.plist from the Copy Bundle Resources phase.
1191
1192         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1193
1194 2019-02-06  Keith Rollin  <krollin@apple.com>
1195
1196         Really enable the automatic checking and regenerations of .xcfilelists during builds
1197         https://bugs.webkit.org/show_bug.cgi?id=194357
1198         <rdar://problem/47861231>
1199
1200         Reviewed by Chris Dumez.
1201
1202         Bug 194124 was supposed to enable the automatic checking and
1203         regenerating of .xcfilelist files during the build. While related
1204         changes were included in that patch, the change to actually enable the
1205         operation somehow was omitted. This patch actually enables the
1206         operation. The check-xcfilelist.sh scripts now check
1207         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1208         from the checking.
1209
1210         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1211         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1212
1213 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1214
1215         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1216         <https://webkit.org/b/194286>
1217         <rdar://problem/47815558>
1218
1219         Reviewed by Alexey Proskuryakov.
1220
1221         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1222         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1223         WKRetainPtr<> to avoid leaking the WKDataRef.
1224
1225 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1226
1227         Unreviewed, fix a typo
1228
1229         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1230
1231 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1232
1233         [GTK][WPE] force libpsl build to use ICU in jhbuild
1234         https://bugs.webkit.org/show_bug.cgi?id=194288
1235
1236         Reviewed by Carlos Garcia Campos.
1237
1238         * gtk/jhbuild.modules:
1239         Require ICU for libpsl build in jhbuild, like done in WPE.
1240
1241 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1242
1243         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1244         https://bugs.webkit.org/show_bug.cgi?id=194209
1245
1246         Reviewed by Carlos Garcia Campos.
1247
1248         Enhance TestCookieManager to ensure this doesn't happen again.
1249
1250         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1251         (testCookieManagerPersistentStorage):
1252         (beforeAll):
1253
1254 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1255
1256         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1257         https://bugs.webkit.org/show_bug.cgi?id=194324
1258
1259         Reviewed by Andy Estes.
1260
1261         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1262         part of the name is already implicit, since this is in testing code in TestOptions.
1263
1264         * WebKitTestRunner/TestController.cpp:
1265         (WTR::TestController::generateContextConfiguration const):
1266         (WTR::updateTestOptionsFromTestHeader):
1267         * WebKitTestRunner/TestOptions.h:
1268         (WTR::TestOptions::hasSameInitializationOptions const):
1269
1270 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1271
1272         [ews-build] Allow * as platform for builders and workers
1273         https://bugs.webkit.org/show_bug.cgi?id=188533
1274
1275         Reviewed by Lucas Forschler.
1276
1277         * BuildSlaveSupport/ews-build/loadConfig.py:
1278         (checkWorkersAndBuildersForConsistency):
1279
1280 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1281
1282         [ews-build] Add few bots to config.json
1283         https://bugs.webkit.org/show_bug.cgi?id=194304
1284
1285         Reviewed by Lucas Forschler.
1286
1287         * BuildSlaveSupport/ews-build/config.json:
1288
1289 2019-02-05  Keith Rollin  <krollin@apple.com>
1290
1291         Enable the automatic checking and regenerations of .xcfilelists during builds
1292         https://bugs.webkit.org/show_bug.cgi?id=194124
1293         <rdar://problem/47721277>
1294
1295         Reviewed by Tim Horton.
1296
1297         Bug 193790 add a facility for checking -- during build time -- that
1298         any needed .xcfilelist files are up-to-date and for updating them if
1299         they are not. This facility was initially opt-in by setting
1300         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1301         the process seemed robust. Its now time to enable this facility and
1302         make it opt-out. If there is a need to disable this facility, set and
1303         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1304         running `make` or `build-webkit`, or before running Xcode from the
1305         command line.
1306
1307         Additionally, remove the step that generates a list of source files
1308         going into the UnifiedSources build step. It's only necessarily to
1309         specify Sources.txt and SourcesCocoa.txt as inputs.
1310
1311         * Scripts/generate-xcfilelists:
1312
1313 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1314
1315         [GTK][WPE] force libpsl build to use ICU in jhbuild
1316         https://bugs.webkit.org/show_bug.cgi?id=194288
1317
1318         Reviewed by Philippe Normand.
1319
1320         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1321         This can cause build failures if libidn is detected but libunistring is not available.
1322
1323         Make sure that ICU is used for runtime and builtin PSL data.
1324
1325         * gtk/jhbuild.modules:
1326         * wpe/jhbuild.modules:
1327
1328 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1329
1330         [ews-app] Modified timestamp should be updated on updating data
1331         https://bugs.webkit.org/show_bug.cgi?id=194295
1332
1333         Reviewed by Lucas Forschler.
1334
1335         * BuildSlaveSupport/ews-app/ews/models/build.py:
1336         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1337         * BuildSlaveSupport/ews-app/ews/models/step.py:
1338
1339 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1340
1341         Unreviewed, rolling out r240742.
1342
1343         Causes crashes on iOS simulator.
1344
1345         Reverted changeset:
1346
1347         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1348         not focused in a content-editable element"
1349         https://bugs.webkit.org/show_bug.cgi?id=192824
1350         https://trac.webkit.org/changeset/240742
1351
1352 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1353
1354         run-webkit-tests emits message "...running None" when running tests
1355         https://bugs.webkit.org/show_bug.cgi?id=194133
1356         <rdar://problem/47724738>
1357
1358         Reviewed by Lucas Forschler.
1359
1360         * Scripts/webkitpy/xcode/device_type.py:
1361         (DeviceType.__str__): Use both version mapping tables and use just the variant
1362         name if no version name is available.
1363         * Scripts/webkitpy/xcode/device_type_unittest.py:
1364         (DeviceTypeTest):
1365         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1366         an associated named.
1367
1368 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1369
1370         [WPE] require python3-setuptools for meson build in jhbuild
1371         https://bugs.webkit.org/show_bug.cgi?id=194287
1372
1373         Reviewed by Philippe Normand.
1374
1375         python3-setuptools is needed to build meson in jhbuild.
1376         It is already required by the GTK port.
1377
1378         * wpe/install-dependencies:
1379
1380 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1381
1382         [ews-app] Add method to save BuilderMapping to database
1383         https://bugs.webkit.org/show_bug.cgi?id=194264
1384
1385         Reviewed by Lucas Forschler.
1386
1387         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1388         (BuilderMapping.__str__):
1389         (BuilderMapping):
1390         (BuilderMapping.save_mapping):
1391         (BuilderMapping.update_mapping):
1392         (BuilderMapping.get_existing_mapping):
1393         (BuilderMapping.is_valid_mapping):
1394
1395 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1396
1397         [ews-app] Add timestamp fields for BuilderMappings
1398         https://bugs.webkit.org/show_bug.cgi?id=194266
1399
1400         Reviewed by Lucas Forschler.
1401
1402         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1403         (BuilderMapping):
1404
1405 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1406
1407         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1408         https://bugs.webkit.org/show_bug.cgi?id=174816
1409
1410         Reviewed by Michael Catanzaro.
1411
1412         Add tests for webkit_uri_for_display().
1413
1414         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1415         (testURIForDisplayUnaffected):
1416         (testURIForDisplayAffected):
1417         (beforeAll):
1418         (afterAll):
1419         * TestWebKitAPI/glib/CMakeLists.txt:
1420
1421 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1422
1423         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1424         https://bugs.webkit.org/show_bug.cgi?id=194158
1425         <rdar://problem/47737268>
1426
1427         Rubber-stamped by Aakash Jain.
1428
1429         * Scripts/webkitpy/port/device_port.py:
1430         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1431
1432 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1433
1434         [CG] Enable setAdditionalSupportedImageTypes for WK1
1435         https://bugs.webkit.org/show_bug.cgi?id=194190
1436
1437         Reviewed by Tim Horton.
1438
1439         Add a test similar to the one under WebKit Cocoa but make it create a
1440         WebView instead of a WKWebView.
1441
1442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1443         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1444         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1445         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1446         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1447         (TestWebKitAPI::runTest):
1448         (TestWebKitAPI::TEST):
1449
1450 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1451
1452         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1453         https://bugs.webkit.org/show_bug.cgi?id=194168
1454
1455         Reviewed by Simon Fraser.
1456
1457         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1458
1459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1460         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1461         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1462         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1463         (TEST):
1464         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1465         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1466
1467 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1468
1469         REGRESSION (r237269): webkit-patch what-broke is broken 
1470         https://bugs.webkit.org/show_bug.cgi?id=193025
1471
1472         Reviewed by Aakash Jain.
1473
1474         * Scripts/webkitpy/common/host.py:
1475         (Host.buildbot):
1476         (Host.bugzilla): Renamed to 'buildbot'.
1477
1478 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1479
1480         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1481         https://bugs.webkit.org/show_bug.cgi?id=194207
1482
1483         Reviewed by Tim Horton.
1484
1485         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1486         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1487         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1488         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1489         start and delete forwards to remove the original attachment.
1490
1491         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1492         (TestWebKitAPI::TEST):
1493
1494 2019-02-04  Youenn Fablet  <youenn@apple.com>
1495
1496         Capture state should be managed consistently when doing process swapping
1497         https://bugs.webkit.org/show_bug.cgi?id=194122
1498         <rdar://problem/47609293>
1499
1500         Reviewed by Eric Carlson.
1501
1502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1503         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1504         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1505         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1506         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1507         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1508         (WTR::TestRunner::isDoingMediaCapture const):
1509         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1510         * WebKitTestRunner/TestController.cpp:
1511         (WTR::TestController::isDoingMediaCapture const):
1512         * WebKitTestRunner/TestController.h:
1513         * WebKitTestRunner/TestInvocation.cpp:
1514         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1515         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1516         (WTR::TestController::isDoingMediaCapture const):
1517
1518 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1519
1520         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1521         https://bugs.webkit.org/show_bug.cgi?id=194142
1522
1523         Reviewed by Ross Kirsling.
1524
1525         There three 'separator' variables in TestController.cpp. Renamed
1526         it 'pathSeparator', and unified them.
1527
1528         * WebKitTestRunner/TestController.cpp:
1529         (WTR::TestController::generateContextConfiguration const):
1530         (WTR::createTestURL):
1531         (WTR::TestController::platformAdjustContext):
1532
1533 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1534
1535         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1536         https://bugs.webkit.org/show_bug.cgi?id=194198
1537
1538         Reviewed by Antti Koivisto.
1539
1540         No need to set the banner heights on navigation now, since Page stores them.
1541
1542         * MiniBrowser/mac/WK2BrowserWindowController.m:
1543         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1544
1545 2019-02-03  John Wilander  <wilander@apple.com>
1546
1547         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1548         https://bugs.webkit.org/show_bug.cgi?id=194104
1549         <rdar://problem/47649991>
1550
1551         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1552
1553         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1554         (TestWebKitAPI::TEST):
1555             Changed numeric types from unsigned short to uint32_t.
1556
1557 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1558
1559         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1560         <https://webkit.org/b/194178>
1561         <rdar://problem/47753473>
1562
1563         Reviewed by Alexey Proskuryakov.
1564
1565         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1566         (WTR::uninstallFakeHelvetica): Pass nullptr into
1567         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1568
1569 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1570
1571         [LFC] Initialize ICB's style with fixed width/height.
1572         https://bugs.webkit.org/show_bug.cgi?id=194188
1573
1574         Reviewed by Antti Koivisto.
1575
1576         * LayoutReloaded/misc/LFC-passing-tests.txt:
1577
1578 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1579
1580         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1581         https://bugs.webkit.org/show_bug.cgi?id=194185
1582
1583         Reviewed by Antti Koivisto.
1584
1585         * LayoutReloaded/misc/LFC-passing-tests.txt:
1586
1587 2018-12-16  Darin Adler  <darin@apple.com>
1588
1589         Convert additional String::format clients to alternative approaches
1590         https://bugs.webkit.org/show_bug.cgi?id=192746
1591
1592         Reviewed by Alexey Proskuryakov.
1593
1594         * WebKitTestRunner/TestController.cpp:
1595         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1596         as an intermediate in code that ultimately constructs a WTF::String.
1597         (WTR::userMediaOriginHash): Use makeString.
1598         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1599         (WTR::TestController::didPerformClientRedirect): Ditto.
1600         (WTR::TestController::didPerformServerRedirect): Ditto.
1601         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1602
1603 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1604
1605         [ews-build] Add unit test to verify builder keys
1606         https://bugs.webkit.org/show_bug.cgi?id=194152
1607
1608         Reviewed by Lucas Forschler.
1609
1610         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1611         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1612
1613 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1614
1615         [LFC] Expand tests coverage (12 new tests -> 787)
1616
1617         Unreviewed test gardening.
1618
1619         * LayoutReloaded/misc/LFC-passing-tests.txt:
1620
1621 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1622
1623         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1624         https://bugs.webkit.org/show_bug.cgi?id=194163
1625
1626         Reviewed by Simon Fraser.
1627
1628         775
1629
1630         * LayoutReloaded/misc/LFC-passing-tests.txt:
1631
1632 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1633
1634         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1635         https://bugs.webkit.org/show_bug.cgi?id=194140
1636         <rdar://problem/47728098>
1637
1638         Reviewed by Tim Horton.
1639
1640         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1641         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1642         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1643
1644         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1645         test to induce an IPC deadlock when presenting a modal alert during touch start.
1646
1647         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1648         * WebKitTestRunner/TestController.cpp:
1649         (WTR::runJavaScriptAlert):
1650
1651         Add a client callback function for running JavaScript alerts.
1652
1653         (WTR::TestController::createOtherPage):
1654         (WTR::TestController::generateContextConfiguration const):
1655
1656         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1657         the fix in this patch.
1658
1659         (WTR::TestController::createWebViewWithOptions):
1660
1661         Plumb TestOptions to generateContextConfiguration.
1662
1663         (WTR::TestController::resetPreferencesToConsistentValues):
1664         (WTR::TestController::resetStateToConsistentValues):
1665         (WTR::updateTestOptionsFromTestHeader):
1666         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1667         (WTR::TestController::handleJavaScriptAlert):
1668         * WebKitTestRunner/TestController.h:
1669         * WebKitTestRunner/TestInvocation.cpp:
1670         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1671         * WebKitTestRunner/TestOptions.h:
1672         (WTR::TestOptions::hasSameInitializationOptions const):
1673
1674 2019-02-01  Chris Dumez  <cdumez@apple.com>
1675
1676         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1677         https://bugs.webkit.org/show_bug.cgi?id=193740
1678         <rdar://problem/47527267>
1679
1680         Reviewed by Alex Christensen.
1681
1682         Add API test coverage.
1683
1684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1685
1686 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1687
1688         [ews-app] Add display name field to BuilderMapping model
1689         https://bugs.webkit.org/show_bug.cgi?id=194153
1690
1691         Reviewed by Lucas Forschler.
1692
1693         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1694         (BuilderMapping):
1695
1696 2019-02-01  Youenn Fablet  <youenn@apple.com>
1697
1698         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1699         https://bugs.webkit.org/show_bug.cgi?id=194155
1700
1701         Reviewed by Eric Carlson.
1702
1703         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1704         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1705         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1706
1707 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1708
1709         [LFC] Adjust replaced element's intrinsic ratio
1710         https://bugs.webkit.org/show_bug.cgi?id=194154
1711
1712         Reviewed by Antti Koivisto.
1713
1714         761
1715
1716         * LayoutReloaded/misc/LFC-passing-tests.txt:
1717
1718 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1719
1720         [WPE] Show test results in minibrowser
1721         https://bugs.webkit.org/show_bug.cgi?id=194150
1722
1723         Reviewed by Žan Doberšek.
1724
1725         * Scripts/webkitpy/port/wpe.py:
1726         (WPEPort.show_results_html_file):
1727
1728 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1729
1730         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1731         https://bugs.webkit.org/show_bug.cgi?id=194151
1732
1733         Reviewed by Žan Doberšek.
1734
1735         ALT + <- go back
1736         ALT + -> go forward
1737
1738         * MiniBrowser/wpe/main.cpp:
1739         (main):
1740
1741 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1742
1743         [LFC] Set intrinsic size on Layout::Replaced
1744         https://bugs.webkit.org/show_bug.cgi?id=194139
1745
1746         Reviewed by Antti Koivisto.
1747
1748         744
1749
1750         * LayoutReloaded/misc/LFC-passing-tests.txt:
1751
1752 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1753
1754         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1755         https://bugs.webkit.org/show_bug.cgi?id=194146
1756
1757         Reviewed by Xabier Rodriguez-Calvar.
1758
1759         It allows to open relative paths.
1760
1761         * MiniBrowser/wpe/main.cpp:
1762         (main):
1763
1764 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1765
1766         Update flakiness dashboard configuration after recent queue changes
1767         https://bugs.webkit.org/show_bug.cgi?id=194127
1768
1769         Rubber-stamped by Aakash Jain.
1770
1771         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1772
1773         * TestResultServer/static-dashboards/builders.jsonp:
1774
1775 2019-01-31  Youenn Fablet  <youenn@apple.com>
1776
1777         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1778         https://bugs.webkit.org/show_bug.cgi?id=194106
1779         <rdar://problem/47676333>
1780
1781         Reviewed by Ryosuke Niwa.
1782
1783         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1784         (TestWebKitAPI::didFinishNavigation):
1785         (TestWebKitAPI::TEST):
1786         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1787
1788 2019-01-31  Chris Dumez  <cdumez@apple.com>
1789
1790         Page zoom level is lost after a process swap or a crash
1791         https://bugs.webkit.org/show_bug.cgi?id=194105
1792         <rdar://problem/47610781>
1793
1794         Reviewed by Alex Christensen.
1795
1796         Add API test coverage.
1797
1798         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1799         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1800
1801 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1802
1803         Revert r238819 which is unneeded and caused a performance regression.
1804         https://bugs.webkit.org/show_bug.cgi?id=192272
1805         <rdar://problem/46664625>
1806
1807         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1808         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1809         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1810
1811 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1812
1813         Formalize WebKitAdditions mechanism of LoadOptimizer
1814         https://bugs.webkit.org/show_bug.cgi?id=193886
1815         <rdar://problem/47696809>
1816
1817         Reviewed by Brent Fulgham.
1818
1819         * MiniBrowser/MiniBrowser.entitlements:
1820         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1821
1822 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1823
1824         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1825         https://bugs.webkit.org/show_bug.cgi?id=194090
1826
1827         Reviewed by Antti Koivisto.
1828
1829         * LayoutReloaded/misc/LFC-passing-tests.txt:
1830
1831 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1832
1833         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1834         https://bugs.webkit.org/show_bug.cgi?id=194074
1835
1836         Reviewed by Antti Koivisto.
1837
1838         * LayoutReloaded/misc/LFC-passing-tests.txt:
1839
1840 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1841
1842         [LFC][BFC] Add support for block level replaced box.
1843         https://bugs.webkit.org/show_bug.cgi?id=194071
1844
1845         Reviewed by Antti Koivisto.
1846
1847         * LayoutReloaded/misc/LFC-passing-tests.txt:
1848
1849 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1850
1851         Fix WebKitTestRunner's testPath with Windows full paths
1852         https://bugs.webkit.org/show_bug.cgi?id=194012
1853
1854         Reviewed by Alex Christensen.
1855
1856         updateTestOptionsFromTestHeader failed to open test files because
1857         testPath returned wrong file paths. It returned a path "/C:/..."
1858         if a URL "file:///C:/..." was given.
1859
1860         * WebKitTestRunner/TestController.cpp:
1861         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1862
1863 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1864
1865         [WPE] Bump font related dependencies to match the GTK+ port
1866         https://bugs.webkit.org/show_bug.cgi?id=194017
1867
1868         Reviewed by Žan Doberšek.
1869
1870         * wpe/jhbuild.modules:
1871         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1872         * wpe/patches/icudata-stdlibs.patch: Added.
1873
1874 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1875
1876         Enable swipe tests on iOS
1877         https://bugs.webkit.org/show_bug.cgi?id=194076
1878
1879         Reviewed by Geoffrey Garen.
1880
1881         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1882         it causes a debug assertion failure in runUIScript.
1883
1884         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1885         (WTR::UIScriptController::beginBackSwipe):
1886         (WTR::UIScriptController::completeBackSwipe):
1887
1888 2019-01-30  Keith Rollin  <krollin@apple.com>
1889
1890         Use correct printf format specifier
1891         https://bugs.webkit.org/show_bug.cgi?id=194062
1892         <rdar://problem/47686167>
1893
1894         Reviewed by Alexey Proskuryakov.
1895
1896         LayoutTestSpellChecker.mm is trying to format a variable of type
1897         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1898         actually an unsigned long long. Fix this by formatting with %llu.
1899
1900         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1901         (-[LayoutTestTextCheckingResult description]):
1902
1903 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1904
1905         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1906         https://bugs.webkit.org/show_bug.cgi?id=193979
1907
1908         Reviewed by Wenson Hsieh.
1909
1910         Fix the test for iOS. Make the test work with iOS UA string.
1911
1912         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1913
1914 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1915
1916         Replace High Sierra LLINT CLoop bot due to hardware failure
1917         https://bugs.webkit.org/show_bug.cgi?id=194066
1918
1919         Reviewed by Aakash Jain.
1920
1921         * BuildSlaveSupport/build.webkit.org-config/config.json:
1922
1923 2019-01-30  Keith Rollin  <krollin@apple.com>
1924
1925         [NSDragItem init] is unavailable
1926         https://bugs.webkit.org/show_bug.cgi?id=194059
1927         <rdar://problem/47685715>
1928
1929         Reviewed by Wenson Hsieh.
1930
1931         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1932         DumpRenderTree and TestWebKitAPI, which both try to create an
1933         NSDragItem in a manner that invokes this method. Address this by using
1934         -initWithPasteboardWriter instead.
1935
1936         Note that the parameter passed to initWithPasteboardWriter is likely
1937         incorrect. In both cases, the object passed does not conform to
1938         NSPasteboardWriting. However, with this fix, we're no worse off than
1939         before, and can now perform builds with newer compilers and SDKs until
1940         a real fix can be crafted. That work is tracked in
1941         https://bugs.webkit.org/show_bug.cgi?id=194060
1942
1943         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1944         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1945         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1946         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1947
1948 2019-01-30  Daniel Bates  <dabates@apple.com>
1949
1950         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1951         https://bugs.webkit.org/show_bug.cgi?id=192824
1952         <rdar://problem/47100332>
1953
1954         Reviewed by Wenson Hsieh.
1955
1956         Fix a bug where the wrong usage code was used for F13 thru F24.
1957
1958         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1959         (keyCodeForDOMFunctionKey):
1960
1961 2019-01-30  Chris Dumez  <cdumez@apple.com>
1962
1963         Regression(PSON) Load hang can occur on history navigation
1964         https://bugs.webkit.org/show_bug.cgi?id=194030
1965         <rdar://problem/47656939>
1966
1967         Reviewed by Antti Koivisto.
1968
1969         Add API test coverage.
1970
1971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1972
1973 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1974
1975         [LFC] Expand tests coverage.
1976
1977         Unreviewed test gardening.
1978
1979         * LayoutReloaded/misc/LFC-passing-tests.txt:
1980
1981 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1982
1983         [Flatpak] Add openjpeg support
1984         https://bugs.webkit.org/show_bug.cgi?id=194019
1985
1986         Reviewed by Michael Catanzaro.
1987
1988         * flatpak/org.webkit.CommonModules.yaml:
1989
1990 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1991
1992         Unreviewed, rolling out r240708.
1993         https://bugs.webkit.org/show_bug.cgi?id=194022
1994
1995         It broke WPE build (Requested by KaL on #webkit).
1996
1997         Reverted changeset:
1998
1999         "[WPE] Bump font related dependencies to match the GTK+ port"
2000         https://bugs.webkit.org/show_bug.cgi?id=194017
2001         https://trac.webkit.org/changeset/240708
2002
2003 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2004
2005         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2006         https://bugs.webkit.org/show_bug.cgi?id=194001
2007
2008         Reviewed by Antti Koivisto.
2009
2010         * LayoutReloaded/misc/LFC-passing-tests.txt:
2011
2012 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2013
2014         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2015         https://bugs.webkit.org/show_bug.cgi?id=194020
2016
2017         Reviewed by Antti Koivisto.
2018
2019         * LayoutReloaded/misc/LFC-passing-tests.txt:
2020
2021 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2022
2023         AX: Support color well on iOS
2024         https://bugs.webkit.org/show_bug.cgi?id=194010
2025
2026         Reviewed by Joanmarie Diggs.
2027
2028         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2029         (WTR::AccessibilityUIElement::stringAttributeValue):
2030
2031 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2032
2033         [WPE] Bump font related dependencies to match the GTK+ port
2034         https://bugs.webkit.org/show_bug.cgi?id=194017
2035
2036         Reviewed by Žan Doberšek.
2037
2038         * wpe/jhbuild.modules:
2039         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2040         * wpe/patches/icudata-stdlibs.patch: Added.
2041
2042 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2043
2044         [Mac] Update window scale API usage
2045         https://bugs.webkit.org/show_bug.cgi?id=193991
2046         rdar://problem/47614795
2047
2048         Reviewed by Tim Horton.
2049
2050         * DumpRenderTree/mac/DumpRenderTree.mm:
2051         (changeWindowScaleIfNeeded):
2052         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2053         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2054         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2055
2056 2019-01-29  Chris Dumez  <cdumez@apple.com>
2057
2058         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2059         https://bugs.webkit.org/show_bug.cgi?id=193977
2060         <rdar://problem/47643716>
2061
2062         Reviewed by Geoff Garen.
2063
2064         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2065         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2066         to the previous provisional committing *before* we make the last load. 
2067
2068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2069
2070 2019-01-29  Youenn Fablet  <youenn@apple.com>
2071
2072         Adopt new SPI to evaluate server certificate trust
2073         https://bugs.webkit.org/show_bug.cgi?id=193355
2074
2075         Reviewed by Alex Christensen.
2076
2077         Add infrastructure to handle HTTPS server trust evaluation testing.
2078
2079         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2080         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2081         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2082         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2083         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2084         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2085         * WebKitTestRunner/TestController.cpp:
2086         (WTR::TestController::resetPreferencesToConsistentValues):
2087         (WTR::TestController::didReceiveAuthenticationChallenge):
2088         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2089         * WebKitTestRunner/TestController.h:
2090         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2091         * WebKitTestRunner/TestInvocation.cpp:
2092         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2093         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2094         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2095
2096 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2097
2098         [ews-build] Add build step to print bot Configuration
2099         https://bugs.webkit.org/show_bug.cgi?id=193887
2100
2101         Reviewed by Lucas Forschler.
2102
2103         * BuildSlaveSupport/ews-build/steps.py:
2104         (PrintConfiguration): Build step to print configuration.
2105         * BuildSlaveSupport/ews-build/factories.py:
2106
2107 2019-01-29  Chris Dumez  <cdumez@apple.com>
2108
2109         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2110         https://bugs.webkit.org/show_bug.cgi?id=193967
2111         <rdar://problem/47635348>
2112
2113         Reviewed by Alex Christensen.
2114
2115         Add API test coverage.
2116
2117         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2118         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2119
2120 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2121
2122         [ews-app] Handle incoming results data
2123         https://bugs.webkit.org/show_bug.cgi?id=193973
2124
2125         Reviewed by Lucas Forschler.
2126
2127         * BuildSlaveSupport/ews-app/ews/views/results.py:
2128
2129 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2130
2131         [ews-app] Make the results url generic
2132         https://bugs.webkit.org/show_bug.cgi?id=193928
2133
2134         Reviewed by Lucas Forschler.
2135
2136         * BuildSlaveSupport/ews-app/ews/urls.py:
2137
2138 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2139
2140         [ews-build] Configure buildbot to send events to ews-app
2141         https://bugs.webkit.org/show_bug.cgi?id=193968
2142
2143         Reviewed by Lucas Forschler.
2144
2145         * BuildSlaveSupport/ews-build/events.py: Added.
2146         * BuildSlaveSupport/ews-build/master.cfg:
2147
2148 2019-01-29  Keith Rollin  <krollin@apple.com>
2149
2150         Add .xcfilelists to Run Script build phases
2151         https://bugs.webkit.org/show_bug.cgi?id=193792
2152         <rdar://problem/47201785>
2153
2154         Reviewed by Alex Christensen.
2155
2156         As part of supporting XCBuild, update the necessary Run Script build
2157         phases in their Xcode projects to refer to their associated
2158         .xcfilelist files.
2159
2160         Note that the addition of these files bumps the Xcode project version
2161         number to something that's Xcode 10 compatible. This change means that
2162         older versions of the Xcode IDE can't read these projects. Nor can it
2163         fully load workspaces that refer to these projects (the updated
2164         projects are shown as non-expandable placeholders). `xcodebuild` can
2165         still build these projects; it's just that the IDE can't open them.
2166
2167         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2168         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2169
2170 2019-01-29  John Wilander  <wilander@apple.com>
2171
2172         Add data abstraction and validation for Ad Click Attribution
2173         https://bugs.webkit.org/show_bug.cgi?id=193916
2174         <rdar://problem/47603481>
2175
2176         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2177
2178         Ad click attribution has two steps. First, the storage of an ad
2179         campaign ID for a click that takes the user to a destination
2180         site. Second, a conversion on the destination site that can be
2181         attributed to the ad click.
2182
2183         This patch adds a class that represents a request for ad click
2184         attribution. Validation makes sure that the bits of entropy
2185         reported through this mechanism is limited.
2186
2187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2188         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2189         (TestWebKitAPI::TEST):
2190
2191 2019-01-29  Chris Dumez  <cdumez@apple.com>
2192
2193         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2194         https://bugs.webkit.org/show_bug.cgi?id=193932
2195         <rdar://problem/47598947>
2196
2197         Reviewed by Brady Eidson.
2198
2199         Add API test coverage.
2200
2201         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2202
2203 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2204
2205         Adding new passing LFC tests.
2206
2207         Unreviewed test gardening.
2208
2209         * LayoutReloaded/misc/LFC-passing-tests.txt:
2210
2211 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2212
2213         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2214         https://bugs.webkit.org/show_bug.cgi?id=193964
2215
2216         Reviewed by Antti Koivisto.
2217
2218         * LayoutReloaded/misc/LFC-passing-tests.txt:
2219
2220 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2221
2222         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2223         https://bugs.webkit.org/show_bug.cgi?id=193954
2224
2225         Reviewed by Antti Koivisto.
2226
2227         * LayoutReloaded/misc/LFC-passing-tests.txt:
2228
2229 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2230
2231         WebDriver: add support for running subtests
2232         https://bugs.webkit.org/show_bug.cgi?id=193904
2233
2234         Reviewed by Michael Catanzaro.
2235
2236         pytest already supports it by passing test.py::subtest, so we can do the same.
2237
2238         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2239         (get_item_name): Made this global.
2240         (CollectRecorder.__init__): Receive the parameter to ignore.
2241         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2242         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2243         (collect): Add parameter to ignore.
2244         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2245         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2246         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2247         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2248         (WebDriverTestRunnerSelenium.run): Ditto.
2249         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2250         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2251         (WebDriverTestRunnerW3C.run): Ditto.
2252
2253 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2254
2255         User agent string override for navigator.userAgent should be site specific quirks
2256         https://bugs.webkit.org/show_bug.cgi?id=193950
2257
2258         Reviewed by Brent Fulgham.
2259
2260         Updated per the _WKWebsitePolicies rename.
2261
2262         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2263         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2264
2265 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2266
2267         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2268         https://bugs.webkit.org/show_bug.cgi?id=193941
2269
2270         Reviewed by Alex Christensen.
2271
2272         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2273         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2274         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2275         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2276         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2277         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2278         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2279         * TestWebKitAPI/Tests/WTF/Time.cpp:
2280         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2281         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2282         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2283         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2284
2285 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2286
2287         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2288
2289         * Scripts/webkitpy/common/config/contributors.json:
2290
2291 2019-01-28  Andy Estes  <aestes@apple.com>
2292
2293         [watchOS] Enable Parental Controls content filtering
2294         https://bugs.webkit.org/show_bug.cgi?id=193939
2295         <rdar://problem/46641912>
2296
2297         Reviewed by Ryosuke Niwa.
2298
2299         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2300
2301 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2302
2303         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2304         <https://webkit.org/b/193884>
2305
2306         Reviewed by Jiewen Tan.
2307
2308         * Scripts/webkitpy/style/checkers/cpp.py:
2309         (check_language): Add LocalAuthentication to
2310         `frameworks_with_soft_links`.
2311
2312 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2313
2314         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2315         https://bugs.webkit.org/show_bug.cgi?id=193891
2316
2317         Reviewed by Ross Kirsling.
2318
2319         There were three problems in window sizes of WebView and the host window.
2320         1. The sizes of pixel image output were incorrect.
2321         2. The host window is going to appear after window.resize was invoked.
2322         3. window.resize resized only the host window, not WebView.
2323
2324         This change solves them with a following approach.
2325         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2326         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2327            as well as DumpRenderTree in order to match the client area and the window area.
2328         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2329         d. PlatformWebView::setWindowFrame changes both window sizes.
2330         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2331
2332         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2333         (WTR::PlatformWebView::PlatformWebView): Create the host window
2334         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2335         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2336         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2337
2338 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2339
2340         [ews-app] Add method to save Step data to database
2341         https://bugs.webkit.org/show_bug.cgi?id=193890
2342
2343         Reviewed by Lucas Forschler.
2344
2345         * BuildSlaveSupport/ews-app/ews/models/step.py:
2346         (Step.save_step): Method to save step data.
2347         (Step.update_step): Method to update step data.
2348         (Step.get_existing_step): Method to fetch existing step from database.
2349         (Step.is_valid_result): Method to validate valid step result.
2350
2351 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2352
2353         [ews-app] Add method to save Build data to database
2354         https://bugs.webkit.org/show_bug.cgi?id=193735
2355
2356         Reviewed by Lucas Forschler.
2357
2358         * BuildSlaveSupport/ews-app/ews/models/build.py:
2359         (Build.save_build): Method to save build information to database.
2360         (Build.get_existing_build): Method to fetch existing build from database.
2361         (Build.is_valid_result): Method to validate build result.
2362         * BuildSlaveSupport/ews-app/ews/common/util.py:
2363         (is_valid_int_id): Method to validate valid id.
2364
2365 2019-01-28  Chris Dumez  <cdumez@apple.com>
2366
2367         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2368         https://bugs.webkit.org/show_bug.cgi?id=193915
2369         <rdar://problem/47560907>
2370
2371         Reviewed by Alex Christensen.
2372
2373         Add API test coverage.
2374
2375         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2376
2377 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2378
2379         [ews-app] Rename id variables
2380         https://bugs.webkit.org/show_bug.cgi?id=193883
2381
2382         Reviewed by Lucas Forschler.
2383
2384         * BuildSlaveSupport/ews-app/ews/models/build.py:
2385         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2386         * BuildSlaveSupport/ews-app/ews/models/step.py:
2387         * BuildSlaveSupport/ews-app/ews/urls.py:
2388         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2389         * BuildSlaveSupport/ews-app/ews/views/results.py:
2390         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2391
2392 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2393
2394         [ews-app] Allow certain fields to be empty
2395         https://bugs.webkit.org/show_bug.cgi?id=193892
2396
2397         Reviewed by Lucas Forschler.
2398
2399         * BuildSlaveSupport/ews-app/ews/models/build.py:
2400         * BuildSlaveSupport/ews-app/ews/models/step.py:
2401
2402 2019-01-28  Rob Buis  <rbuis@igalia.com>
2403
2404         Update MIME type parser
2405         https://bugs.webkit.org/show_bug.cgi?id=180526
2406
2407         Reviewed by Frédéric Wang.
2408
2409         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2410         (TestWebKitAPI::TEST):
2411
2412 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2413
2414         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2415         https://bugs.webkit.org/show_bug.cgi?id=193896
2416
2417         Reviewed by Antti Koivisto.
2418
2419         * LayoutReloaded/misc/LFC-passing-tests.txt:
2420
2421 2018-12-15  Darin Adler  <darin@apple.com>
2422
2423         Replace many uses of String::format with more type-safe alternatives
2424         https://bugs.webkit.org/show_bug.cgi?id=192742
2425
2426         Reviewed by Mark Lam.
2427
2428         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2429         (WTR::cacheTestRunnerCallback): Use makeString.
2430         * WebKitTestRunner/TestController.cpp:
2431         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2432         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2433
2434 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2435
2436         Use a load optimizer for some sites
2437         https://bugs.webkit.org/show_bug.cgi?id=193881
2438         <rdar://problem/46325455>
2439
2440         Reviewed by Brent Fulgham.
2441
2442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2443         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2444
2445 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2446
2447         AX: Introduce a static accessibility tree
2448         https://bugs.webkit.org/show_bug.cgi?id=193348
2449         <rdar://problem/47203295>
2450
2451         Reviewed by Ryosuke Niwa.
2452
2453         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2454
2455 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2456
2457         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2458         https://bugs.webkit.org/show_bug.cgi?id=193867
2459
2460         Reviewed by Antti Koivisto.
2461
2462         * LayoutReloaded/misc/LFC-passing-tests.txt:
2463
2464 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2465
2466         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2467         https://bugs.webkit.org/show_bug.cgi?id=193865
2468
2469         Reviewed by Antti Koivisto.
2470
2471         * LayoutReloaded/misc/LFC-passing-tests.txt:
2472
2473 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2474
2475         Need a mechanism to override navigator.userAgent
2476         https://bugs.webkit.org/show_bug.cgi?id=193762
2477         <rdar://problem/47504939>
2478
2479         Reviewed by Brent Fulgham.
2480
2481         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2482
2483         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2484         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2485         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2486
2487 2019-01-25  Dean Jackson  <dino@apple.com>
2488
2489         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2490         https://bugs.webkit.org/show_bug.cgi?id=193831
2491         <rdar://problem/47399263>
2492
2493         Reviewed by Chris Dumez.
2494
2495         Two new tests that exercise cross-origin and same-origin System
2496         Previews.
2497
2498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2499
2500 2019-01-25  Keith Rollin  <krollin@apple.com>
2501
2502         Update Xcode projects with "Check .xcfilelists" build phase
2503         https://bugs.webkit.org/show_bug.cgi?id=193790
2504         <rdar://problem/47201374>
2505
2506         Reviewed by Alex Christensen.
2507
2508         Support for XCBuild includes specifying inputs and outputs to various
2509         Run Script build phases. These inputs and outputs are specified as
2510         .xcfilelist files. Once created, these .xcfilelist files need to be
2511         kept up-to-date. In order to check that they are up-to-date or not,
2512         add an Xcode build step that invokes an external script that performs
2513         the checking. If the .xcfilelists are found to be out-of-date, update
2514         them, halt the build, and instruct the developer to restart the build
2515         with up-to-date files.
2516
2517         At this time, the checking and regenerating is performed only if the
2518         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2519         who want to use this facility can set this variable and test out the
2520         checking/regenerating. Once it seems like there are no egregious
2521         issues that upset a developer's workflow, we'll unconditionally enable
2522         this facility.
2523
2524         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2525         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2526         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2527         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2528
2529 2019-01-25  Keith Rollin  <krollin@apple.com>
2530
2531         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2532         https://bugs.webkit.org/show_bug.cgi?id=193781
2533         <rdar://problem/47201153>
2534
2535         Reviewed by Alex Christensen.
2536
2537         Part of generating the .xcfilelists used as part of adopting XCBuild
2538         includes running `make DerivedSources.make` from a standalone script.
2539         It’s important for this invocation to have the same environment as
2540         when the actual build invokes `make DerivedSources.make`. If the
2541         environments are different, then the two invocations will provide
2542         different results. In order to get the same environment in the
2543         standalone script, have the script launch xcodebuild targeting the
2544         "Apply Configuration to XCFileLists" build target, which will then
2545         re-invoke our standalone script. The script is now running again, this
2546         time in an environment with all workspace, project, target, xcconfig
2547         and other environment variables established.
2548
2549         The "Apply Configuration to XCFileLists" build target accomplishes
2550         this task via a small embedded shell script that consists only of:
2551
2552             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2553
2554         The process that invokes "Apply Configuration to XCFileLists" first
2555         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2556         evaluated and exports it into the shell environment. When xcodebuild
2557         is invoked, it inherits the value of this variable and can `eval` the
2558         contents of that variable. Our external standalone script can then set
2559         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2560         of command-line parameters needed to restart itself in the appropriate
2561         state.
2562
2563         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2564         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2565
2566 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2567
2568         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2569         https://bugs.webkit.org/show_bug.cgi?id=193802
2570         <rdar://problem/46010580>
2571
2572         Reviewed by Andy Estes.
2573
2574         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2575         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2576         (TEST):
2577
2578 2019-01-25  Daniel Bates  <dabates@apple.com>
2579
2580         [iOS] uiController.keyDown() does not translate Control modified key
2581         https://bugs.webkit.org/show_bug.cgi?id=192898
2582
2583         Reviewed by Wenson Hsieh.
2584
2585         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2586         key translation, as applicable. Among other cases, key translation occurs when performing
2587         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2588         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2589         human pressing down and releasing key(s) using a hardware keyboard.
2590
2591         * WebKitTestRunner/ios/HIDEventGenerator.h:
2592         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2593         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2594
2595         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2596         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2597         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2598         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2599         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2600         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2601         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2602         (-[HIDEventGenerator longPress:completionBlock:]):
2603         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2604         Update code for above renaming.
2605
2606         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2607         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2608
2609         (-[HIDEventGenerator keyDown:]): Added.
2610         (-[HIDEventGenerator keyUp:]): Added.
2611         (-[HIDEventGenerator keyPress:completionBlock:]):
2612         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2613         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2614         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2615         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2616         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2617         (WTR::parseModifier): Deleted.
2618
2619 2019-01-25  Keith Rollin  <krollin@apple.com>
2620
2621         Complete the implementation of generate-xcfilelists
2622         https://bugs.webkit.org/show_bug.cgi?id=193782
2623
2624         Reviewed by Alex Christensen.
2625
2626         A preliminary version of generate-xcfilelists was added in r238008.
2627         This patch updates that script in order to:
2628
2629         - Support checking of .xcfilelists
2630         - Perform better execution of `make DerivedSources.make` by
2631           relaunching generate-xcfilelists under xcodebuild
2632         - Support incremental generation and checking of .xcfilelists
2633         - Support supplementary .xcfilelists files from WebKitAdditions
2634         - Support being wrapped by parallel version of generate-xcfilelists in
2635           Internal that adds support for (re)generating WebKit projects in
2636           that repo.
2637         - Support builds that have been performed in WebKitBuild as well as
2638           ~/Library/Developer/code/DerivedData
2639         - Increase robustness and debugging facilities.
2640
2641         * Scripts/generate-xcfilelists:
2642
2643 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2644
2645         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2646         https://bugs.webkit.org/show_bug.cgi?id=193297
2647         <rdar://problem/47158841>
2648
2649         Unreviewed test case fix.
2650
2651         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2652         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2653
2654         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2655         (TEST):
2656
2657 2019-01-25  Keith Rollin  <krollin@apple.com>
2658
2659         Update existing .xcfilelists
2660         https://bugs.webkit.org/show_bug.cgi?id=193791
2661         <rdar://problem/47201706>
2662
2663         Reviewed by Alex Christensen.
2664
2665         Many .xcfilelist files were added in r238824 in order to support
2666         XCBuild. Update these with recent changes to the set of build files
2667         and with the current generate-xcfilelist script.
2668
2669         * DumpRenderTree/DerivedSources-input.xcfilelist:
2670         * DumpRenderTree/DerivedSources-output.xcfilelist:
2671         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2672         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2673
2674 2019-01-25  Keith Rollin  <krollin@apple.com>
2675
2676         Fix missing dependencies in extract-dependencies-from-makefile
2677         https://bugs.webkit.org/show_bug.cgi?id=193783
2678         <rdar://problem/47201571>
2679
2680         Reviewed by Alex Christensen.
2681
2682         The extract-dependencies-from-makefile script generates .xcfilelists
2683         for XCBuild by invoking a makefile in --debug mode, parsing the
2684         dependency information in the output, and extracting information
2685         regarding targets and dependents. However, the way `make` emits this
2686         dependency information is not rigorous, and so we need to determine
2687         what lines to look for and parse by trial and error. This approach
2688         didn't coriginally atch all the information we needed to collect, so
2689         update the script to look for the additional lines we now know to look
2690         for.
2691
2692         * Scripts/extract-dependencies-from-makefile:
2693         (Parser):
2694         (Parser.addTarget):
2695         (Parser.addPrereq):
2696         (Parser.doParse):
2697
2698 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2699
2700         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2701         https://bugs.webkit.org/show_bug.cgi?id=193297
2702         <rdar://problem/47158841>
2703
2704         Reviewed by Alex Christensen.
2705
2706         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2707             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2708         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2709         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2710         activating the message used to trigger the callback when it is set.
2711
2712 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2713
2714         WKWebView.goBack should reload if there is a safe browsing warning
2715         https://bugs.webkit.org/show_bug.cgi?id=193805
2716         <rdar://problem/46908216>
2717
2718         Reviewed by Geoff Garen.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2721         (+[Simple3LookupContext sharedLookupContext]):
2722         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2723         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2724         (TEST):
2725
2726 2019-01-25  Chris Dumez  <cdumez@apple.com>
2727
2728         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2729         https://bugs.webkit.org/show_bug.cgi?id=193788
2730         <rdar://problem/47531231>
2731
2732         Reviewed by Alex Christensen.
2733
2734         Add API test coverage.
2735
2736         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2737         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2738
2739 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2740
2741         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2742         https://bugs.webkit.org/show_bug.cgi?id=193771
2743
2744         Unreviewed infrastructure fix.
2745
2746         * Scripts/webkitpy/port/darwin.py:
2747         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2748
2749 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2750
2751         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2752
2753 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2754
2755         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2756
2757         * Scripts/webkitpy/common/config/contributors.json:
2758
2759 2019-01-25  Chris Dumez  <cdumez@apple.com>
2760
2761         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2762         https://bugs.webkit.org/show_bug.cgi?id=193779
2763         <rdar://problem/46170903>
2764
2765         Reviewed by Antti Koivisto.
2766
2767         Add API test that quickly navigates forward to a previous process without waiting for it to
2768         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2769         the process' previous page when reconnecting the it for the forward navigation.
2770
2771         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2772
2773 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2774
2775         Need a way for JavaScript (or bundle) code to participate in undo
2776         https://bugs.webkit.org/show_bug.cgi?id=190009
2777         <rdar://problem/44807048>
2778
2779         Reviewed by Ryosuke Niwa.
2780
2781         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2782         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2783
2784         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2785         (WTR::UIScriptController::lastUndoLabel const):
2786         (WTR::UIScriptController::firstRedoLabel const):
2787         (WTR::UIScriptController::platformUndoManager const):
2788         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2789         (WTR::UIScriptController::lastUndoLabel const):
2790         (WTR::UIScriptController::firstRedoLabel const):
2791         (WTR::UIScriptController::platformUndoManager const):
2792         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2793         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2794         (WTR::UIScriptController::lastUndoLabel const):
2795         (WTR::UIScriptController::firstRedoLabel const):
2796         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2797         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2798         (WTR::UIScriptController::lastUndoLabel const):
2799         (WTR::UIScriptController::firstRedoLabel const):
2800         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2801         (WTR::UIScriptController::platformUndoManager const):
2802         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2803         (WTR::UIScriptController::platformUndoManager const):
2804
2805 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2806
2807         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2808         https://bugs.webkit.org/show_bug.cgi?id=193824
2809
2810         Reviewed by Antti Koivisto.
2811
2812         * LayoutReloaded/misc/LFC-passing-tests.txt:
2813
2814 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2815
2816         Update macOS JSC bot configurations
2817         https://bugs.webkit.org/show_bug.cgi?id=193739
2818
2819         Reviewed by Alexey Proskuryakov.
2820
2821         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2823         (BubbleQueueServer): Move JSC EWS to Mojave section.
2824         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2825         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2826         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2827
2828 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2829
2830         [Win][WebKitTestRunner] Implement EventSenderProxy
2831         https://bugs.webkit.org/show_bug.cgi?id=193755
2832
2833         Reviewed by Don Olmstead.
2834
2835         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2836         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2837         (WTR::EventSenderProxy::dispatchMessage):
2838         (WTR::EventSenderProxy::EventSenderProxy):
2839         (WTR::EventSenderProxy::mouseDown):
2840         (WTR::EventSenderProxy::mouseUp):
2841         (WTR::EventSenderProxy::mouseMoveTo):
2842         (WTR::EventSenderProxy::mouseScrollBy):
2843         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2844
2845 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2846
2847         Unreviewed fix for API test failure after r240437.
2848
2849         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2850
2851         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2852
2853 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2854
2855         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2856         https://bugs.webkit.org/show_bug.cgi?id=193787
2857         <rdar://problem/47497634>
2858
2859         Reviewed by Alexey Proskuryakov.
2860
2861         * Scripts/webkitdirs.pm:
2862         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2863
2864 2019-01-24  Truitt Savell  <tsavell@apple.com>
2865
2866         Unreviewed, rolling out r240446.
2867
2868         Casued 5 API failures
2869
2870         Reverted changeset:
2871
2872         "Activate the WebResourceLoadStatisticsStore in the
2873         NetworkProcess and deactivate it in the UIProcess."
2874         https://bugs.webkit.org/show_bug.cgi?id=193297
2875         https://trac.webkit.org/changeset/240446
2876
2877 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2878
2879         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2880         https://bugs.webkit.org/show_bug.cgi?id=193741
2881         <rdar://problem/47135030>
2882
2883         Reviewed by Antti Koivisto and Simon Fraser.
2884
2885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2886         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2887         (TestWebKitAPI::TEST):
2888
2889 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2890
2891         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2892         https://bugs.webkit.org/show_bug.cgi?id=193297
2893         <rdar://problem/47158841>
2894
2895         Reviewed by Alex Christensen.
2896
2897         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2898         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2899         activating the message used to trigger the callback when it is set.
2900
2901 2019-01-24  John Wilander  <wilander@apple.com>
2902
2903         Add Ad Click Attribution as an internal/experimental feature
2904         https://bugs.webkit.org/show_bug.cgi?id=193685
2905         <rdar://problem/47450399>
2906
2907         Reviewed by Brent Fulgham.
2908
2909         Added test option adClickAttributionEnabled.
2910
2911         * DumpRenderTree/TestOptions.cpp:
2912         (TestOptions::TestOptions):
2913         * DumpRenderTree/TestOptions.h:
2914         * DumpRenderTree/mac/DumpRenderTree.mm:
2915         (setWebPreferencesForTestOptions):
2916
2917 2019-01-24  Antti Koivisto  <antti@apple.com>
2918
2919         [PSON] Flash on back navigation on Mac
2920         https://bugs.webkit.org/show_bug.cgi?id=193716
2921         <rdar://problem/47148458>
2922
2923         Reviewed by Chris Dumez.
2924
2925         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2926
2927         Closing of the previous page is delayed so waiting for didFinishNavigation is
2928         not sufficient to guarantee we have received all the messages. Wait for them.
2929
2930 2019-01-24  Chris Dumez  <cdumez@apple.com>
2931
2932         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2933         https://bugs.webkit.org/show_bug.cgi?id=193761
2934         <rdar://problem/47456405>
2935
2936         Reviewed by Alex Christensen.
2937
2938         Add API test coverage.
2939
2940         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2941
2942 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2943
2944         webkitpy: Missing PID in crashlog name should not be fatal
2945         https://bugs.webkit.org/show_bug.cgi?id=193771
2946
2947         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2948         of raising an exception.
2949
2950         Reviewed by Lucas Forschler.
2951
2952         * Scripts/webkitpy/port/darwin.py:
2953         (DarwinPort._merge_crash_logs):
2954
2955 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2956
2957         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2958         https://bugs.webkit.org/show_bug.cgi?id=193746
2959
2960         Reviewed by Youenn Fablet.
2961
2962         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2963         so we'd best just not call it.
2964
2965         * Scripts/webkitpy/w3c/test_exporter.py:
2966         (WebPlatformTestExporter.create_branch_with_patch):
2967
2968 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2969
2970         Move FileSystem to WTF
2971         https://bugs.webkit.org/show_bug.cgi?id=193602
2972
2973         Reviewed by Yusuke Suzuki.
2974
2975         * DumpRenderTree/win/DumpRenderTree.cpp:
2976         * TestWebKitAPI/CMakeLists.txt:
2977         * TestWebKitAPI/PlatformGTK.cmake:
2978         * TestWebKitAPI/PlatformJSCOnly.cmake:
2979         * TestWebKitAPI/PlatformPlayStation.cmake:
2980         * TestWebKitAPI/PlatformWPE.cmake:
2981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2982         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2983         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2984         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2985         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2986         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2987         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2988         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2989         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2990         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2991
2992 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2993
2994         [WPE] Remove hard dependency on subprocess32 for the API tests
2995
2996         Rubber-stamped by Carlos Garcia Campos.
2997
2998         * glib/api_test_runner.py:
2999         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3000         its presence only when running WPEQt tests.
3001
3002 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3003
3004         [GLIB] Expose JavaScriptCore options in GLib public API
3005         https://bugs.webkit.org/show_bug.cgi?id=188742
3006
3007         Reviewed by Michael Catanzaro.
3008
3009         Add a test for the new API.
3010
3011         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3012         (testsJSCOptions):
3013         (main):
3014
3015 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3016
3017         [GTK][WPE] Support JPEG 2000 images
3018         https://bugs.webkit.org/show_bug.cgi?id=186272
3019
3020         Reviewed by Žan Doberšek.
3021
3022         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3023
3024         * gtk/jhbuild.modules:
3025         * wpe/jhbuild.modules:
3026
3027 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3028
3029         check-webkit-style should warn when using soft-linking macros in a header
3030         <https://webkit.org/b/193750>
3031
3032         Reviewed by Darin Adler.
3033
3034         * Scripts/webkitpy/style/checkers/cpp.py:
3035         (check_language): Add softlink/header check by refactoring the
3036         softlink/framework check.
3037         (CppChecker): Enable softlink/header check by default.
3038         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3039         (CppStyleTest.test_softlink_framework): Rename from
3040         CppStyleTest.test_softlink() and change test framework name in
3041         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3042         files. Set file_name for macros that only appear in headers.
3043         (CppStyleTest.test_softlink_header): Add tests for using
3044         soft-link macros in headers.
3045
3046 2019-01-23  Chris Dumez  <cdumez@apple.com>
3047
3048         Deprecate API to limit the maximum number of WebProcesses
3049         https://bugs.webkit.org/show_bug.cgi?id=193725
3050         <rdar://problem/47464879>
3051
3052         Reviewed by Geoff Garen.
3053
3054         Update existing API tests to stop using deprecated API.
3055
3056         * MiniBrowser/mac/AppDelegate.m:
3057         (defaultConfiguration):
3058         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3059         (TestWebKitAPI::TEST):
3060         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3061         (TestWebKitAPI::TEST):
3062         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3063         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3064         (TEST):
3065         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3066         (TEST):
3067
3068 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3069
3070         [ews-app] Rename ews model buildermappings to buildermapping
3071         https://bugs.webkit.org/show_bug.cgi?id=193729
3072
3073         Reviewed by Lucas Forschler.
3074
3075         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3076         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3077         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3078
3079 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3080
3081         [ews-app] Rename ews model steps to step
3082         https://bugs.webkit.org/show_bug.cgi?id=193697
3083
3084         Reviewed by Lucas Forschler.
3085
3086         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3087         (Step): Renamed Steps to Step.
3088
3089 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3090
3091         Clean up IndexedDB files between tests
3092         https://bugs.webkit.org/show_bug.cgi?id=192796
3093         <rdar://problem/46824999>
3094
3095         Reviewed by Geoffrey Garen.
3096
3097         * DumpRenderTree/mac/DumpRenderTree.mm:
3098         (runTest):
3099         * WebKitTestRunner/TestController.cpp:
3100         (WTR::TestController::resetStateToConsistentValues):
3101         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3102         (WTR::RemoveAllIndexedDatabasesCallback):
3103         (WTR::TestController::ClearIndexedDatabases):
3104         * WebKitTestRunner/TestController.h:
3105         * WebKitTestRunner/TestInvocation.cpp:
3106         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3107
3108 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3109
3110         [ews-app] Rename ews model Builds to Build
3111         https://bugs.webkit.org/show_bug.cgi?id=193695
3112
3113         Reviewed by Lucas Forschler.
3114
3115         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3116         (Build): Renamed Builds to Build.
3117
3118 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3119
3120         webkitpy: Wait longer when launching WebKitTestRunner
3121         https://bugs.webkit.org/show_bug.cgi?id=193734
3122
3123         Reviewed by Aakash Jain.
3124
3125         * Scripts/webkitpy/port/simulator_process.py:
3126         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3127
3128 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3129
3130         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3131         https://bugs.webkit.org/show_bug.cgi?id=193182
3132         <rdar://problem/47452154>
3133
3134         Reviewed by Tim Horton.
3135
3136         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3137         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3138         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3139
3140         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3141         preventing later tests from recognizing gestures.
3142
3143         * WebKitTestRunner/ios/TestControllerIOS.mm:
3144         (WTR::TestController::platformResetStateToConsistentValues):
3145
3146         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3147
3148 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3149
3150         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3151         https://bugs.webkit.org/show_bug.cgi?id=193722
3152         <rdar://problem/47481475>
3153
3154         Reviewed by Lucas Forschler.
3155
3156         iPhone and iPad ports should both use the iOS config.
3157
3158         * Scripts/webkitpy/port/ios_simulator.py:
3159         (IPhoneSimulatorPort.__init__):
3160         (IPadSimulatorPort.__init__):
3161
3162 2019-01-23  Rob Buis  <rbuis@igalia.com>
3163
3164         Update MIME type parser
3165         https://bugs.webkit.org/show_bug.cgi?id=180526
3166
3167         Reviewed by Frédéric Wang.
3168
3169         Add unit tests for both parse modes of ParsedContentType.
3170
3171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3172         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3173         (TestWebKitAPI::TEST):
3174
3175 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3176
3177         [ews-app] fetch loop should not stop on network issues
3178         https://bugs.webkit.org/show_bug.cgi?id=193666
3179
3180         Reviewed by Lucas Forschler.
3181
3182         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3183         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3184
3185 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3186
3187         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3188         https://bugs.webkit.org/show_bug.cgi?id=189165
3189         <rdar://problem/47433765>
3190
3191         Reviewed by Tim Horton.
3192
3193         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3194         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3195         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3196         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3197         would make its way to the UI process by the time the layer tree commit is finished.
3198
3199         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3200         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3201         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3202         will fail because it asks for -_autofillContext too early.
3203
3204         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3205         is handled in the UI process.
3206
3207         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3208
3209         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3210         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3211         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3212         input session.
3213
3214         (-[AutofillTestView textInputHasAutofillContext]):
3215
3216         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3217
3218         * TestWebKitAPI/cocoa/TestWKWebView.h:
3219         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3220         (nextInputSessionChangeCount):
3221
3222         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3223         This includes changing the focused element from one to another.
3224
3225         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3226         (-[TestWKWebView didStartFormControlInteraction]):
3227         (-[TestWKWebView didEndFormControlInteraction]):
3228         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3229
3230         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3231         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3232         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3233         that doesn't require an input session to one that doesn't.
3234
3235 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3236
3237         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3238         <https://webkit.org/b/193676>
3239
3240         Reviewed by Alexey Proskuryakov.
3241
3242         * Scripts/webkitpy/style/checkers/cpp.py:
3243         (check_member_initialization_list):
3244         - Don't report missing whitespace around colon if the colon at
3245           the start of the line is formatted correctly.
3246         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3247         (WebKitStyleTest.test_member_initialization_list):
3248         - Add a test for a missing permutation of existing tests.
3249         - Add a test this false-positive.
3250         - Add blank lines between subtests to make them easier to read.
3251
3252 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3253
3254         [build.webkit.org] Unit-test failure after r237113
3255         https://bugs.webkit.org/show_bug.cgi?id=193669
3256
3257         Reviewed by Michael Catanzaro.
3258
3259         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3260         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3261         multiple or zero flags.
3262
3263 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3264
3265         Cache bytecode to disk
3266         https://bugs.webkit.org/show_bug.cgi?id=192782
3267         <rdar://problem/46084932>
3268
3269         Reviewed by Keith Miller.
3270
3271         Add test helper to execute bytecode-cache tests: it executes each test
3272         twice, the first with JSC_diskCachePath set to a temporary directory
3273         and second with JSC_forceDiskCache=true (in addition to the cache path)
3274         to guarantee that only the disk cache is being used and no new
3275         UnlinkedCodeBlocks are being created.
3276
3277         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3278         * Scripts/run-jsc-stress-tests:
3279
3280 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3281
3282         [css-logical] Implement flow-relative margin, padding and border shorthands
3283         https://bugs.webkit.org/show_bug.cgi?id=188697
3284
3285         Reviewed by Simon Fraser and Antti Koivisto.
3286
3287         * DumpRenderTree/TestOptions.cpp:
3288         (TestOptions::TestOptions):
3289         * DumpRenderTree/TestOptions.h:
3290         * DumpRenderTree/mac/DumpRenderTree.mm:
3291         (setWebPreferencesForTestOptions):
3292         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3293
3294         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3295         (JSONCSSPropertiesChecker.check_codegen_properties):
3296         Allow CSS property definitions to have a 'runtime-flag' parameter which
3297         disables the property when the specified runtime flag is disabled.
3298
3299 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3300
3301         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3302         https://bugs.webkit.org/show_bug.cgi?id=193643
3303
3304         Reviewed by Michael Catanzaro.
3305
3306         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3307         * wpe/jhbuild.modules: Ditto.
3308
3309 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3310
3311         [LFC][Floats] Take float top position into account when computing containing block height.
3312         https://bugs.webkit.org/show_bug.cgi?id=193655
3313
3314         Reviewed by Antti Koivisto.
3315
3316         * LayoutReloaded/misc/LFC-passing-tests.txt:
3317
3318 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3319
3320         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3321         <https://webkit.org/b/193645>
3322         <rdar://problem/47421574>
3323
3324         Reviewed by Alex Christensen.
3325
3326         - Now checks for local soft-linking of all frameworks that have
3327           their own *SoftLinking.{cpp,h,mm} files.
3328         - Changes softlink/uikit warning to softlink/framework.
3329
3330         * Scripts/webkitpy/style/checkers/cpp.py:
3331         (check_language):
3332         (CppChecker):
3333         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3334         (CppStyleTest):
3335
3336 2019-01-20  Saam Barati  <sbarati@apple.com>
3337
3338         Rollout r240210: It broke tests on iOS
3339         https://bugs.webkit.org/show_bug.cgi?id=193640
3340
3341         Unreviewed.
3342
3343         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3344         * Scripts/run-jsc-stress-tests:
3345
3346 2019-01-20  chris fleizach  <cfleizach@apple.com>
3347
3348         AX: Support returning relative frames for accessibility
3349         https://bugs.webkit.org/show_bug.cgi?id=193414
3350         <rdar://problem/47268501>
3351
3352         Reviewed by Zalan Bujtas.
3353
3354         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3355         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3356         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3357         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3358         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3359         (WTR::attributesOfElement):
3360         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3361
3362 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3363
3364         Unreviewed, add my new email address
3365
3366         * Scripts/webkitpy/common/config/contributors.json:
3367
3368 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3369
3370         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3371         https://bugs.webkit.org/show_bug.cgi?id=193617
3372
3373         Reviewed by Antti Koivisto.
3374
3375         * LayoutReloaded/misc/LFC-passing-tests.txt:
3376
3377 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3378
3379         Unreviewed, rolling out r240209.
3380
3381         Broke GTK/WPE injected bundle
3382
3383         Reverted changeset:
3384
3385         "AX: Support returning relative frames for accessibility"
3386         https://bugs.webkit.org/show_bug.cgi?id=193414
3387         https://trac.webkit.org/changeset/240209
3388
3389 2019-01-12  Dan Bernstein  <mitz@apple.com>
3390
3391         [Cocoa] Avoid importing directly from subumbrella frameworks
3392         https://bugs.webkit.org/show_bug.cgi?id=186016
3393         <rdar://problem/40591038>
3394
3395         Reviewed by Sam Weinig.
3396
3397         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3398           LaunchServices header.
3399         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3400           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3401         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3402           when using SDKs earlier than 10.13.
3403         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3404           and OTHER_CPLUSPLUSFLAGS.
3405         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3406           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3407         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3408           LaunchServices header.
3409
3410 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3411
3412         Cache bytecode to disk
3413         https://bugs.webkit.org/show_bug.cgi?id=192782
3414         <rdar://problem/46084932>
3415
3416         Reviewed by Keith Miller.
3417
3418         Add test helper to execute bytecode-cache tests: it executes each test
3419         twice, the first with JSC_diskCachePath set to a temporary directory
3420         and second with JSC_forceDiskCache=true (in addition to the cache path)
3421         to guarantee that only the disk cache is being used and no new
3422         UnlinkedCodeBlocks are being created.
3423
3424         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3425         * Scripts/run-jsc-stress-tests:
3426
3427 2019-01-20  chris fleizach  <cfleizach@apple.com>
3428
3429         AX: Support returning relative frames for accessibility
3430         https://bugs.webkit.org/show_bug.cgi?id=193414
3431         <rdar://problem/47268501>
3432
3433         Reviewed by Zalan Bujtas.
3434
3435         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3436         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3437         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3438         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3439         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3440         (WTR::attributesOfElement):
3441         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3442
3443 2019-01-20  Antoine Quint  <graouts@apple.com>
3444
3445         Add a POINTER_EVENTS feature flag
3446         https://bugs.webkit.org/show_bug.cgi?id=193577
3447         <rdar://problem/47408511>
3448
3449         Unreviewed. Also enable Pointer Events for iosmac.
3450
3451         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3452
3453 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3454
3455         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3456         https://bugs.webkit.org/show_bug.cgi?id=193613
3457
3458         Reviewed by Antti Koivisto.
3459
3460         * LayoutReloaded/misc/LFC-passing-tests.txt:
3461
3462 2019-01-19  Antoine Quint  <graouts@apple.com>
3463
3464         Add a POINTER_EVENTS feature flag
3465         https://bugs.webkit.org/show_bug.cgi?id=193577
3466
3467         Reviewed by Dean Jackson.
3468
3469         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3470
3471 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3472
3473         Disable the run-jsc-stress-test remote host key check [second round].
3474         https://bugs.webkit.org/show_bug.cgi?id=192988
3475
3476         Reviewed by Dewei Zhu.
3477
3478         * Scripts/run-jsc-stress-tests:
3479
3480 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3481
3482         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3483         https://bugs.webkit.org/show_bug.cgi?id=193597
3484
3485         Reviewed by Lucas Forschler.
3486
3487         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3488
3489 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3490
3491         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3492         https://bugs.webkit.org/show_bug.cgi?id=193595
3493
3494         Reviewed by Lucas Forschler.
3495
3496         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3497         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3498         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3499
3500 2019-01-18  Chris Dumez  <cdumez@apple.com>
3501
3502         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3503         https://bugs.webkit.org/show_bug.cgi?id=193588
3504         <rdar://problem/47131566>
3505
3506         Reviewed by Alex Christensen.
3507
3508         Add layout test coverage.
3509
3510         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3511
3512 2019-01-18  Jer Noble  <jer.noble@apple.com>
3513
3514         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3515         https://bugs.webkit.org/show_bug.cgi?id=189553
3516
3517         Reviewed by Tim Horton.
3518
3519         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3520
3521         * ContentExtensionTester/Configurations/Base.xcconfig:
3522         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3523         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3524         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3525         * ImageDiff/cg/Configurations/Base.xcconfig:
3526         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3527         * MiniBrowser/Configurations/Base.xcconfig:
3528         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3529         * MobileMiniBrowser/Configurations/Base.xcconfig:
3530         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3531         * Scripts/webkitpy/style/checker.py:
3532         (_all_categories):
3533         (FileType):
3534         (CheckerDispatcher._file_type):
3535         (CheckerDispatcher._create_checker):
3536         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3537         (SDKVariantChecker):
3538         (SDKVariantChecker.__init__):
3539         (SDKVariantChecker.check):
3540         * TestWebKitAPI/Configurations/Base.xcconfig:
3541         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3542         * WebEditingTester/Configurations/Base.xcconfig:
3543         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3544         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3545         * WebKitTestRunner/Configurations/Base.xcconfig:
3546         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3547         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3548         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3549
3550 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3551
3552         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3553         <https://webkit.org/b/193568>
3554         <rdar://problem/47381130>
3555
3556         Reviewed by Alex Christensen.
3557
3558         Make sure no one re-introduces UIKit soft-linking by adding a
3559         style rule.
3560
3561         * Scripts/webkitpy/style/checkers/cpp.py:
3562         (check_language): Add softlink/uikit check.
3563         (CppChecker): Enable softlink/uikit check.
3564         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3565         (CppStyleTest): Add test for softlink/uikit.
3566
3567 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3568
3569         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3570         https://bugs.webkit.org/show_bug.cgi?id=193584
3571
3572         Change "-dev" to "-devel".
3573
3574         Reviewed by Michael Catanzaro.
3575
3576         * gtk/install-dependencies:
3577
3578 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3579
3580         webkitpy: Add iPhone and iPad ports
3581         https://bugs.webkit.org/show_bug.cgi?id=193537
3582         <rdar://problem/47353390>
3583
3584         Reviewed by Lucas Forschler.
3585
3586         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3587         ports. Note that this separation is optional, the --ios-simulator command remains.
3588
3589         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3590         (RunTest.test_device_type_test_division): Drive-by fix.
3591         (RunTest.test_device_type_specific_listing): Ditto.
3592         (RunTest.test_ipad_test_division):
3593         (RunTest):
3594         (RunTest.test_ipad_listing):
3595         * Scripts/webkitpy/port/factory.py:
3596         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3597         (PortFactory):
3598         * Scripts/webkitpy/port/ios_simulator.py:
3599         (IPhoneSimulatorPort):
3600         (IPadSimulatorPort):
3601
3602 2019-01-18  Chris Dumez  <cdumez@apple.com>
3603
3604         Regression(PSON) Scroll position is not always restored properly when navigating back
3605         https://bugs.webkit.org/show_bug.cgi?id=193578
3606         <rdar://problem/47386331>
3607
3608         Reviewed by Tim Horton.
3609
3610         Add API test coverage.
3611
3612         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3613
3614 2019-01-18  Youenn Fablet  <youenn@apple.com>
3615
3616         Add a new SPI to request for cache storage quota increase
3617         https://bugs.webkit.org/show_bug.cgi?id=193323
3618
3619         Reviewed by Alex Christensen.
3620
3621         Implement WebsiteDataStore quota delegate to handle quota requests.
3622         By default, do not update quota.
3623         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3624
3625         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3626         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3627         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3628         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3629         * WebKitTestRunner/TestController.cpp:
3630         (WTR::TestController::allowCacheStorageQuotaIncrease):
3631         * WebKitTestRunner/TestController.h:
3632         * WebKitTestRunner/TestInvocation.cpp:
3633         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3634         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3635         (-[CacheStorageQuotaManager init]):
3636         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3637         (WTR::initializeWebViewConfiguration):
3638         (WTR::TestController::cocoaResetStateToConsistentValues):
3639         (WTR::TestController::allowCacheStorageQuotaIncrease):
3640
3641 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3642
3643         [ews-build] Pass owner to the triggered builds
3644         https://bugs.webkit.org/show_bug.cgi?id=193574
3645
3646         Reviewed by Lucas Forschler.
3647
3648         * BuildSlaveSupport/ews-build/factories.py:
3649         (BuildFactory.propertiesToPassToTriggers):
3650
3651 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3652
3653         [ews-app] Send patch author as a build property
3654         https://bugs.webkit.org/show_bug.cgi?id=193560
3655
3656         Reviewed by Lucas Forschler.
3657
3658         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3659         (BugzillaPatchFetcher.fetch):
3660
3661 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3662
3663         webkitpy: Implement device type specific expected results (Follow-up fix)
3664         https://bugs.webkit.org/show_bug.cgi?id=192162
3665         <rdar://problem/46345449>
3666
3667         Unreviewed infrastructure fix.
3668
3669         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3670         (Manager.run): Don't boot a device if no tests are available to run on it.
3671
3672 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3673
3674         webkitpy: Implement device type specific expected results (Follow-up fix)
3675         https://bugs.webkit.org/show_bug.cgi?id=192162
3676         <rdar://problem/46345449>
3677
3678         Unreviewed infrastructure fix.
3679
3680         * Scripts/webkitpy/api_tests/manager.py:
3681         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3682
3683 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3684
3685         webkitpy: Implement device type specific expected results (Part 2)
3686         https://bugs.webkit.org/show_bug.cgi?id=192162
3687         <rdar://problem/46345449>
3688
3689         Rubber-stamped by Aakash Jain.
3690
3691         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3692         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3693         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3694