[GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
4         https://bugs.webkit.org/show_bug.cgi?id=161149
5
6         Reviewed by Carlos Garcia Campos.
7
8         Add a new function for waiting for the accesibility bus. It sets
9         the test environment variables before starting the GLib mainloop.
10         And restores the previous environment after it has finished.
11         It also adds a timeout (5 seconds) to abort in case it has not
12         been able to detect the accesibility bus before the timeout expires.
13
14         * Scripts/run-gtk-tests:
15         (TestRunner):
16         (TestRunner._wait_for_accessibility_bus):
17         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
18         (TestRunner._start_accessibility_daemons):
19         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
20
21 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
22
23         [Win] Warning fix.
24         https://bugs.webkit.org/show_bug.cgi?id=161236
25
26         Reviewed by Brent Fulgham.
27
28         The & operator in the Test struct has no body.
29
30         * TestWebKitAPI/Tests/WTF/Vector.cpp:
31         (TestWebKitAPI::TEST):
32
33 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
34
35         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
36         https://bugs.webkit.org/show_bug.cgi?id=160736
37
38         Reviewed by Carlos Garcia Campos.
39
40         This plugs run-gtk-tests into the webkitpy testing infrastructure.
41         As a benefit of this, run-gtk-tests now can be executed over any of
42         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
43         or native xorg). A new command line switch --wayland is added for
44         run-gtk-tests.
45
46         * Scripts/run-gtk-tests:
47         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
48         Add a --wayland command line switch.
49         (TestRunner._start_accessibility_daemons):
50         (TestRunner):
51         (TestRunner.__init__):
52         (TestRunner._run_xvfb): Deleted.
53         (TestRunner._create_driver):
54         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
55         are now done by driver._setup_environ_for_test().
56         (TestRunner._tear_down_testing_environment):
57         * Scripts/webkitpy/port/driver.py:
58         (Driver.__init__): Define self._server_name in the constructor of the base class.
59         It is used by several functions, so it makes sense to store once the value here.
60         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
61         (Driver._start): Get the environment from self._setup_environ_for_test()
62         * Scripts/webkitpy/port/driver_unittest.py:
63         (DriverTest):
64         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
65         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
66         (GtkPort.__init__):
67         (GtkPort._driver_class):
68         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
69         (WestonDriver._setup_environ_for_test):
70         (WestonDriver._start):
71         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
72         (XorgDriver._setup_environ_for_test):
73         (XorgDriver._start):
74         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
75         (XvfbDriver._setup_environ_for_test):
76         (XvfbDriver._start):
77
78 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
79
80         [EFL][GTK] REGRESSION(204877): Fix the clean build
81         https://bugs.webkit.org/show_bug.cgi?id=161240
82
83         Reviewed by Carlos Garcia Campos.
84
85         * WebKitTestRunner/PlatformEfl.cmake:
86         * WebKitTestRunner/PlatformGTK.cmake:
87
88 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
89
90         EWS should indicate which bot processed the patch
91         https://bugs.webkit.org/show_bug.cgi?id=161222
92
93         Reviewed by Daniel Bates.
94
95         * QueueStatusServer/handlers/statusbubble.py:
96         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
97         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
98         Also added "Started processing patch" message to progress_statuses.
99         I might consider displaying bot id in other statuses as well later on.
100
101 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
102
103         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
104         https://bugs.webkit.org/show_bug.cgi?id=161184
105
106         Reviewed by Carlos Garcia Campos.
107
108         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
109
110 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
111
112         ews queues should update status server when they start processing patch
113         https://bugs.webkit.org/show_bug.cgi?id=161223
114
115         Reviewed by Daniel Bates.
116
117         * Scripts/webkitpy/tool/commands/queues.py:
118         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
119         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
120         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
121         * Scripts/webkitpy/tool/commands/queues_unittest.py:
122         (StyleQueueTest.test_style_queue_with_style_exception): Same.
123         (test_style_queue_with_watch_list_exception): Same.
124         (test_non_valid_patch): Same.
125
126 2016-08-25  Alex Christensen  <achristensen@webkit.org>
127
128         CMake build fix.
129
130         * DumpRenderTree/PlatformMac.cmake:
131
132 2016-08-25  Alex Christensen  <achristensen@webkit.org>
133
134         Fix URLParserTest with GuardMalloc
135         https://bugs.webkit.org/show_bug.cgi?id=161214
136         rdar://problem/28014390
137
138         Reviewed by Tim Horton.
139
140         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
141         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
142
143         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
144         (TestWebKitAPI::eq):
145         (TestWebKitAPI::checkURL):
146         (TestWebKitAPI::checkURLDifferences):
147         (TestWebKitAPI::s): Deleted.
148
149 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
150
151         Dragging against the end of the inline media scrubber causes the media scrubber to hide
152         https://bugs.webkit.org/show_bug.cgi?id=161207
153
154         Reviewed by Eric Carlson.
155
156         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
157         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
158         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
159
160         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
161         (TestWebKitAPI::TEST):
162
163 2016-08-25  Daniel Bates  <dabates@apple.com>
164
165         Watch more things.
166
167         * Scripts/webkitpy/common/config/watchlist:
168
169 2016-08-25  Daniel Bates  <dabates@apple.com>
170
171         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
172         (https://bugs.webkit.org/show_bug.cgi?id=148437)
173
174         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
175         and is not installed on the GTK Linux bots.
176
177         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
178         (writeFileWithContent): Added.
179
180 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
181
182         [Win] run-api-tests is failing.
183         https://bugs.webkit.org/show_bug.cgi?id=161140
184
185         Reviewed by Brent Fulgham.
186
187         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
188
189         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
190         (TestWebKitAPI::TEST):
191
192 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
193
194         [Win] run-api-tests is failing.
195         https://bugs.webkit.org/show_bug.cgi?id=161140
196
197         Reviewed by Brent Fulgham.
198
199         The number of times the move constructor is called is different on Windows in this test. This seems
200         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
201
202         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
203         (TestWebKitAPI::TEST):
204
205 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
206
207         Fix iOS DRT build.
208
209         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
210         (WTR::UIScriptController::zoomToScale):
211
212 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
213
214         [iOS DRT] Hook up uiController.zoomToScale() for DRT
215         https://bugs.webkit.org/show_bug.cgi?id=161173
216
217         Reviewed by Tim Horton.
218         
219         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
220         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
221         
222         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
223         the WebThread!), but queue up the callback first.
224
225         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
226         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
227         (-[DumpRenderTreeWebScrollView initWithFrame:]):
228         (-[DumpRenderTreeWebScrollView dealloc]):
229         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
230         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
231         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
232         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
233         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
234         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
235         (WTR::UIScriptController::zoomToScale):
236         * DumpRenderTree/mac/DumpRenderTree.mm:
237         (createWebViewAndOffscreenWindow):
238         * TestRunnerShared/UIScriptContext/UIScriptController.h:
239         (WTR::UIScriptController::context):
240
241 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
242
243         Attempt to fix Windows build after r204918.
244
245         Unreviewed build fix.
246
247         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
248         (ResourceLoadDelegate::willSendRequest):
249
250 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
251
252         [iOS DRT] Get basic viewport tests working in DRT
253         https://bugs.webkit.org/show_bug.cgi?id=161160
254
255         Reviewed by Tim Horton.
256         
257         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
258         scale, and get the contentVisibleRect.
259         
260         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
261         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
262         
263         One test has different results between DRT and WTR, but DRT behavior seems to differ
264         from UIWebView here, so just give it a WK1-specific result.
265
266         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
267         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
268         (-[DumpRenderTreeBrowserView documentVisibleRect]):
269         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
270         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
271         (WTR::UIScriptController::zoomScale):
272         (WTR::UIScriptController::minimumZoomScale):
273         (WTR::UIScriptController::maximumZoomScale):
274         (WTR::UIScriptController::contentVisibleRect):
275         * DumpRenderTree/mac/DumpRenderTree.mm:
276         (createWebViewAndOffscreenWindow):
277         * DumpRenderTree/mac/DumpRenderTreeMac.h:
278
279 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
280
281         Minor project rearrangement.
282
283         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
284
285 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
286
287         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
288         https://bugs.webkit.org/show_bug.cgi?id=161124
289
290         Reviewed by Daniel Bates.
291         
292         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
293         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
294         
295         Remove some unnecessary zero initializations of static variables.
296         
297         Change _setVisibleSize to use the window size, which should not be a behavior change
298         because this it just used for text autosizing, which is disabled by default,
299         and only the width is consulted.
300
301         * DumpRenderTree/mac/DumpRenderTree.mm:
302         (adjustWebDocumentForFlexibleViewport):
303         (adjustWebDocumentForStandardViewport):
304         (createWebViewAndOffscreenWindow):
305
306 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
307
308         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
309         https://bugs.webkit.org/show_bug.cgi?id=42777
310
311         Reviewed by Darin Adler.
312
313         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
314
315         * DumpRenderTree/TestRunner.cpp:
316         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
317         * DumpRenderTree/TestRunner.h:
318         (TestRunner::deferMainResourceDataLoad): Ditto.
319         (TestRunner::setDeferMainResourceDataLoad): Ditto.
320         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
321
322 2016-08-23  Anders Carlsson  <andersca@apple.com>
323
324         Add enum traits and use them in the IPC::Decoder
325         https://bugs.webkit.org/show_bug.cgi?id=161103
326
327         Reviewed by Sam Weinig.
328
329         Add API test.
330
331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
332         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
333         (TestWebKitAPI::TEST):
334
335 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
336
337         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
338
339         * DumpRenderTree/TestRunner.cpp:
340         * DumpRenderTree/mac/DumpRenderTree.mm:
341         (DumpRenderTreeMain):
342         * Scripts/run-jsc-stress-tests:
343         * TestWebKitAPI/Tests/WTF/Vector.cpp:
344         (TestWebKitAPI::TEST):
345
346 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
347
348         Try to fix Production builds.
349         
350         PRODUCTION_FRAMEWORKS_DIR was undefined here.
351
352         * DumpRenderTree/mac/Configurations/Base.xcconfig:
353
354 2016-08-24  Dan Bernstein  <mitz@apple.com>
355
356         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
357         https://bugs.webkit.org/show_bug.cgi?id=161152
358
359         Reviewed by Anders Carlsson.
360
361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
362         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
363         (TestWebKitAPI::didFinishLoadForFrame):
364         (TestWebKitAPI::TEST):
365
366 2016-08-24  Nan Wang  <n_wang@apple.com>
367
368         AX: Add test for line text marker range on iOS
369         https://bugs.webkit.org/show_bug.cgi?id=161108
370         <rdar://problem/27976405>
371
372         Reviewed by Chris Fleizach.
373
374         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
375         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
376         (AccessibilityUIElement::textMarkerRangeForElement):
377         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
378         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
379         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
380
381 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
382
383         [Win] Warning fixes.
384         https://bugs.webkit.org/show_bug.cgi?id=161079
385
386         Reviewed by Brent Fulgham.
387
388         * MiniBrowser/win/WebDownloadDelegate.cpp:
389         * MiniBrowser/win/WinMain.cpp:
390         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
391         (TestWebKitAPI::TEST):
392
393 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
394
395         Fix Windows DRT build.
396
397         * DumpRenderTree/win/TestRunnerWin.cpp:
398         (TestRunner::mainFrameJSContext):
399
400 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
401
402         Try to fix Windows build.
403         
404         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
405         so that perl finds CodeGeneratorDumpRenderTree.pm.
406
407         * DumpRenderTree/CMakeLists.txt:
408
409 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
410
411         Hook up UIScriptController in DumpRenderTree
412         https://bugs.webkit.org/show_bug.cgi?id=161064
413
414         Reviewed by Sam Weinig.
415
416         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
417         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
418         in fast/harness which test this.
419
420         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
421
422         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
423         WK2-isms. Fix the makefiles to refer to the new location.
424
425         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
426         by ID and firing them once they are complete.
427
428         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
429         * DumpRenderTree/CMakeLists.txt:
430         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
431         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
432         * DumpRenderTree/TestRunner.cpp:
433         (runUIScriptCallback):
434         (TestRunner::staticFunctions):
435         (TestRunner::cacheTestRunnerCallback):
436         (TestRunner::callTestRunnerCallback):
437         (TestRunner::clearTestRunnerCallbacks):
438         (nextUIScriptCallbackID):
439         (TestRunner::runUIScript):
440         (TestRunner::callUIScriptCallback):
441         (TestRunner::uiScriptDidComplete):
442         (TestRunner::cleanup):
443         * DumpRenderTree/TestRunner.h:
444         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
445         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
446         * DumpRenderTree/mac/DumpRenderTree.mm:
447         (runTest):
448         * DumpRenderTree/mac/TestRunnerMac.mm:
449         (TestRunner::mainFrameJSContext):
450         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
451         (WTR::UIScriptController::doAsyncTask):
452         * DumpRenderTree/win/DumpRenderTree.cpp:
453         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
454         (WTR::JSWrappable::~JSWrappable):
455         (WTR::JSValueMakeStringOrNull):
456         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
457         (WTR::JSWrapper::wrap):
458         (WTR::JSWrapper::unwrap):
459         (WTR::unwrapObject):
460         (WTR::JSWrapper::initialize):
461         (WTR::JSWrapper::finalize):
462         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
463         (WTR::toJS):
464         (WTR::setProperty):
465         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
466         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
467         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
468         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
469         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
470         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
471         * WebKitTestRunner/CMakeLists.txt:
472         * WebKitTestRunner/DerivedSources.make:
473         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
474         (WTR::JSWrappable::~JSWrappable): Deleted.
475         (WTR::JSValueMakeStringOrNull): Deleted.
476         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
477         (WTR::JSWrapper::wrap): Deleted.
478         (WTR::JSWrapper::unwrap): Deleted.
479         (WTR::unwrapObject): Deleted.
480         (WTR::JSWrapper::initialize): Deleted.
481         (WTR::JSWrapper::finalize): Deleted.
482         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
483         (WTR::toJS): Deleted.
484         (WTR::setProperty): Deleted.
485         * WebKitTestRunner/TestInvocation.cpp:
486         (WTR::TestInvocation::runUISideScript):
487         (WTR::TestInvocation::uiScriptDidComplete):
488         * WebKitTestRunner/TestInvocation.h:
489         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
490         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
491         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
492         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
493         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
494         * WebKitTestRunner/config.h:
495         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
496         (WTR::UIScriptController::contentVisibleRect):
497
498 2016-08-23  Saam Barati  <sbarati@apple.com>
499
500         JSC should have a "microbenchmarks" directory instead of "regress" directory
501         https://bugs.webkit.org/show_bug.cgi?id=161096
502
503         Rubber stamped by Mark Lam.
504
505         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
506         directory and removes all the related html and txt files. I did this because
507         that directory was only there for microbenchmarks, and not for "regression"
508         tests. I also changed the various scripts to point to it.
509
510         * Scripts/run-javascriptcore-tests:
511         (runJSCStressTests):
512         * Scripts/run-jsc-benchmarks:
513
514 2016-08-23  Alex Christensen  <achristensen@webkit.org>
515
516         Fix EFL build.
517
518         * TestWebKitAPI/CMakeLists.txt:
519         Include new directory.
520
521 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
522
523         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
524         https://bugs.webkit.org/show_bug.cgi?id=160125
525
526         Reviewed by Geoffrey Garen.
527
528         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
529         * Scripts/run-jsc-stress-tests: New test flag!
530
531 2016-08-23  Brady Eidson  <beidson@apple.com>
532
533         WK2 Gamepad layout test support.
534         https://bugs.webkit.org/show_bug.cgi?id=134671
535
536         Reviewed by Alex Christensen.
537         
538         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
539         feed back into the UIGamepadProvider.
540         
541         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
542         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
543
544         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
545         
546         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
547         (WTR::TestRunner::setMockGamepadDetails):
548         (WTR::TestRunner::setMockGamepadAxisValue):
549         (WTR::TestRunner::setMockGamepadButtonValue):
550         
551         * WebKitTestRunner/PlatformWebView.h:
552         
553         * WebKitTestRunner/TestController.cpp:
554         (WTR::TestController::initialize):
555         
556         * WebKitTestRunner/TestInvocation.cpp:
557         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
558         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
559         
560         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
561         
562         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
563         (-[WebKitTestRunnerWindow initWithFrame:]):
564         (-[WebKitTestRunnerWindow dealloc]):
565         (WTR::PlatformWebView::keyWindow):
566         
567         * WebKitTestRunner/ios/TestControllerIOS.mm:
568         (WTR::wtr_NSApplication_keyWindow):
569         (WTR::TestController::platformInitialize):
570         
571         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
572         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
573         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
574         (-[WebKitTestRunnerWindow dealloc]):
575         (WTR::PlatformWebView::keyWindow):
576         
577         * WebKitTestRunner/mac/TestControllerMac.mm:
578         (WTR::wtr_NSApplication_keyWindow):
579         (WTR::TestController::platformInitialize):
580         * WebKitTestRunner/mac/main.mm:
581
582 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
583
584         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
585         https://bugs.webkit.org/show_bug.cgi?id=161047
586         rdar://problem/27434307
587
588         Reviewed by Lucas Forschler.
589
590         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
591
592 2016-08-23  Chris Dumez  <cdumez@apple.com>
593
594         Unreviewed, rolling out r204243.
595
596         Caused some layout test failures
597
598         Reverted changeset:
599
600         "Write API test to cover crash fix in r204135"
601         https://bugs.webkit.org/show_bug.cgi?id=160587
602         http://trac.webkit.org/changeset/204243
603
604 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
605
606         Order feature option list in FeatureList.pm
607         https://bugs.webkit.org/show_bug.cgi?id=161074
608
609         Reviewed by Michael Catanzaro.
610
611         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
612
613         * Scripts/webkitperl/FeatureList.pm:
614
615 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
616
617         Stop python icon bouncing in the dock while running browser benchmarks.
618         https://bugs.webkit.org/show_bug.cgi?id=161066
619
620         Reviewed by Ryosuke Niwa.
621
622         Bouncing python icon may impact browser benchmark results.
623         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
624         (OSXBrowserDriver.prepare_env):
625         (OSXBrowserDriver.restore_env):
626
627 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
628
629         <select> menu on iPad causes shifting of hit-testing areas
630         https://bugs.webkit.org/show_bug.cgi?id=150079
631
632         Reviewed by Tim Horton.
633
634         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
635         so when it changes we have to update visible rects. We were doing this on focus, but failing
636         to do it on blur.
637
638         Added the ability to test by:
639         1. Making it possible to initiate an animated scroll in the UI process
640         2. Adding callbacks for starting and ending interaction with a form control. Sadly
641         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
642         have no way currently to know when the dimming view behind the popover animates out,
643         so for now the test keeps trying to tap a button.
644
645         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
646         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
647         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
648         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
649         (WTR::UIScriptController::didStartFormControlInteractionCallback):
650         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
651         (WTR::UIScriptController::didEndFormControlInteractionCallback):
652         (WTR::UIScriptController::scrollToOffset):
653         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
654         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
655         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
656         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
657         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
658         (-[TestRunnerWKWebView dealloc]):
659         (-[TestRunnerWKWebView didStartFormControlInteraction]):
660         (-[TestRunnerWKWebView didEndFormControlInteraction]):
661         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
662         (WTR::contentOffsetBoundedInValidRange):
663         (WTR::UIScriptController::scrollToOffset):
664         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
665         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
666
667 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
668
669         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
670         https://bugs.webkit.org/show_bug.cgi?id=160927
671
672         Reviewed by Daniel Bates.
673
674         * Scripts/process-linux-coredump: Removed.
675         * Scripts/webkitpy/port/efl.py:
676         (EflPort._get_crash_log):
677         * Scripts/webkitpy/port/gtk.py:
678         (GtkPort._get_crash_log):
679         * Scripts/webkitpy/port/linux_get_crash_log.py:
680         (GDBCrashLogGenerator.__init__):
681         (GDBCrashLogGenerator.generate_crash_log):
682         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
683         (GDBCrashLogGeneratorTest.test_generate_crash_log):
684
685 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
686
687         check-webkit-style does not work with Lambda functions in C++
688         https://bugs.webkit.org/show_bug.cgi?id=160910
689
690         Reviewed by Darin Adler.
691
692         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
693
694         * Scripts/webkitpy/style/checkers/cpp.py:
695         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
696         (check_for_non_standard_constructs): Added lambda function check.
697         (check_spacing_for_function_call): Added lambda function check.
698         (check_braces): Added lambda function check.
699         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
700         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
701
702 2016-08-21  Alex Christensen  <achristensen@webkit.org>
703
704         URLParser should parse IPv4 addresses
705         https://bugs.webkit.org/show_bug.cgi?id=161023
706
707         Reviewed by Darin Adler.
708
709         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
710         (TestWebKitAPI::TEST_F):
711         (TestWebKitAPI::checkURLDifferences):
712         We are already getting differences between the old URL::parse and the new URLParser.
713         (TestWebKitAPI::shouldFail):
714
715 2016-08-21  Daniel Bates  <dabates@apple.com>
716
717         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
718         https://bugs.webkit.org/show_bug.cgi?id=148437
719
720         Reviewed by Dan Bernstein.
721
722         * Scripts/prepare-ChangeLog:
723         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
724         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
725         assumes that its line ranges were from a unified diff without any context lines.
726         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
727         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
728         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
729         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
730         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
731         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
732         to /dev/null for the duration of the function call.
733
734 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
735
736         [EFL] Remove unnecessary a patch to mute ecore warnings
737         https://bugs.webkit.org/show_bug.cgi?id=160997
738
739         Reviewed by Darin Adler.
740
741         There is no warning messages during the layout test and perf test
742         after bumping efl version from 1.17 to 1.18. Remove it.
743
744         * efl/patches/ecore_remove_warnings.patch: Removed.
745
746 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
747
748         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
749         https://bugs.webkit.org/show_bug.cgi?id=160985
750
751         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
752         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
753         with that.
754
755         * Scripts/webkitpy/layout_tests/views/printing.py:
756         (Printer.print_config):
757         * Scripts/webkitpy/port/base.py:
758         (Port.driver_cmd_line_for_logging):
759         (Port.driver_cmd_line): Deleted.
760         * Scripts/webkitpy/port/driver.py:
761         (IOSSimulatorDriver.cmd_line):
762         * Scripts/webkitpy/port/ios.py:
763         (IOSSimulatorPort.__init__):
764         (IOSSimulatorPort.driver_cmd_line_for_logging):
765         (IOSSimulatorPort._create_simulators):
766         (IOSSimulatorPort.setup_test_run):
767         (IOSSimulatorPort._quit_ios_simulator):
768         (IOSSimulatorPort.clean_up_test_run):
769         (IOSSimulatorPort._create_device):
770         (IOSSimulatorPort):
771         (IOSSimulatorPort._remove_device):
772         (IOSSimulatorPort._testing_device):
773         (IOSSimulatorPort.device_id_for_worker_number):
774         (IOSSimulatorPort._set_device_class): Deleted.
775         (IOSSimulatorPort.testing_device): Deleted.
776         * Scripts/webkitpy/port/port_testcase.py:
777         (PortTestCase.test_driver_cmd_line):
778         * Scripts/webkitpy/xcode/simulator.py:
779         (Device.shutdown):
780         (Device):
781         (Device.delete):
782         (Device.reset):
783         (Simulator):
784         (Simulator.create_device):
785         (Simulator.remove_device):
786         (Simulator.device_number):
787         (Simulator.device_state_description):
788         (Simulator.wait_until_device_is_in_state):
789
790 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
791
792         Unreviewed, rolling out r204659.
793
794         This change appears to have caused ios-simulator LayoutTests
795         to fail when shutting down the simulator
796
797         Reverted changeset:
798
799         "REGRESSION (r204477): Running LayoutTests on ios-simulator
800         became ~15 minutes slower"
801         https://bugs.webkit.org/show_bug.cgi?id=160985
802         http://trac.webkit.org/changeset/204659
803
804 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
805
806         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
807         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
808
809 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
810
811         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
812         https://bugs.webkit.org/show_bug.cgi?id=160985
813
814         Reviewed by Alexey Proskuryakov.
815         
816         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
817         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
818         must not be @memoized, because their return value depends on the value of simulator_device_type().
819         
820         Fix by adding some global state in simulator.py that tracks the created devices 
821         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
822         and delete them in clean_up_test_run().
823         
824         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
825         that killing the Simulator apps isn't enough.
826         
827         Simulator tracks the devices in a global dictionary, since state needs to persist
828         across different instances of IOSSimulatorPort.
829         
830         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
831         any setup. Rather than implicitly creating a device here (which the old code did),
832         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
833         and set flag to say that device_id_for_worker_number() doesn't need to return a real
834         device id.
835
836         * Scripts/webkitpy/layout_tests/views/printing.py:
837         (print_options):
838         (Printer.print_config):
839         * Scripts/webkitpy/port/base.py:
840         (Port.driver_cmd_line_for_logging):
841         (Port.driver_cmd_line): Deleted.
842         * Scripts/webkitpy/port/driver.py:
843         (IOSSimulatorDriver.cmd_line):
844         * Scripts/webkitpy/port/ios.py:
845         (IOSSimulatorPort.__init__):
846         (IOSSimulatorPort.driver_cmd_line_for_logging):
847         (IOSSimulatorPort._create_simulators):
848         (IOSSimulatorPort.setup_test_run):
849         (IOSSimulatorPort.clean_up_test_run):
850         (IOSSimulatorPort._create_device):
851         (IOSSimulatorPort):
852         (IOSSimulatorPort._remove_device):
853         (IOSSimulatorPort._testing_device):
854         (IOSSimulatorPort.device_id_for_worker_number):
855         (IOSSimulatorPort._set_device_class): Deleted.
856         (IOSSimulatorPort.testing_device): Deleted.
857         * Scripts/webkitpy/port/port_testcase.py:
858         (PortTestCase.test_driver_cmd_line):
859         * Scripts/webkitpy/xcode/simulator.py:
860         (Device.shutdown):
861         (Device.delete):
862         (Device.reset):
863         (Simulator.create_device):
864         (Simulator.remove_device):
865         (Simulator.device_number):
866         (Simulator.device_state_description):
867         (Simulator.wait_until_device_is_in_state):
868
869 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
870
871         Adopt SimServiceContext in LayoutTestRelay
872         https://bugs.webkit.org/show_bug.cgi?id=161000
873         <rdar://problem/25765594>
874
875         Reviewed by Daniel Bates.
876
877         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
878         * LayoutTestRelay/LayoutTestRelay/main.m:
879
880 2016-08-19  Lucas Forschler  <lforschler@apple.com>
881
882         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
883
884         Reviewed by Kocsen Chung.
885
886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
887         (WebKitBuildbot):
888
889 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
890
891         Partial revert of r203811 - this key is not needed.
892
893         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
894
895 2016-08-19  Daniel Bates  <dabates@apple.com>
896
897         Another attempt to fix the iOS 9.3 build
898
899         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
900
901         * DumpRenderTree/mac/Configurations/Base.xcconfig:
902         * WebKitTestRunner/Configurations/Base.xcconfig:
903
904 2016-08-19  Lucas Forschler  <lforschler@apple.com>
905
906         Remove Yosemite Leaks bot from config.json
907         
908         Reviewed by Alexey Proskuryakov.
909
910         * BuildSlaveSupport/build.webkit.org-config/config.json:
911
912 2016-08-18  Dan Bernstein  <mitz@apple.com>
913
914         [Cocoa] API::Number needs to be wrapped by an NSNumber
915         https://bugs.webkit.org/show_bug.cgi?id=160977
916         <rdar://problem/27877735>
917
918         Reviewed by Anders Carlsson.
919
920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
921         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
922         (TestWebKitAPI::TEST):
923
924 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
925
926         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
927         https://bugs.webkit.org/show_bug.cgi?id=160895
928
929         Reviewed by Dean Jackson.
930
931         Link to the existing CoreText framework.
932
933         * DumpRenderTree/PlatformWin.cmake:
934         * TestWebKitAPI/PlatformWin.cmake:
935
936 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
937
938         [Win] Remove old libraries from build inputs
939         https://bugs.webkit.org/show_bug.cgi?id=160949
940
941         Reviewed by Dean Jackson.
942
943         Modify the download script to remove the old 'icuuc.lib' and
944         'icuin.lib' files for Windows builds.
945
946         * Scripts/update-webkit-auxiliary-libs:
947
948 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
949
950         Extra logging for crash reason
951         https://bugs.webkit.org/show_bug.cgi?id=160943
952
953         Reviewed by Alexey Proskuryakov.
954
955         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
956
957         * Scripts/webkitpy/port/server_process.py:
958         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
959         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
960         (ServerProcess.has_crashed): Ditto.
961
962 2016-08-17  Dan Bernstein  <mitz@apple.com>
963
964         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
965         https://bugs.webkit.org/show_bug.cgi?id=160938
966         <rdar://problem/27876652>
967
968         Reviewed by Anders Carlsson.
969
970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
971         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
972         (TestWebKitAPI::TEST):
973
974 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
975
976         AX: Support abbreviations in iOS
977         https://bugs.webkit.org/show_bug.cgi?id=160907
978
979         Reviewed by Joanmarie Diggs.
980
981         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
982         (AccessibilityUIElement::stringAttributeValue):
983         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
984         (WTR::AccessibilityUIElement::stringAttributeValue):
985
986 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
987
988         [EFL] Bump efl version from 1.17 to 1.18
989         https://bugs.webkit.org/show_bug.cgi?id=160899
990
991         Reviewed by Antonio Gomes.
992
993         To use efl-1.18, EFL port needs to update install dependencies as well.
994
995         * efl/install-dependencies:
996         * efl/jhbuild.modules:
997
998 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
999
1000         [Win] Add tests for linked fonts.
1001         https://bugs.webkit.org/show_bug.cgi?id=160898
1002
1003         Reviewed by Brent Fulgham.
1004
1005         Add tests for https://trac.webkit.org/changeset/204502.
1006
1007         * TestWebKitAPI/PlatformWin.cmake:
1008         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
1009         (TestWebKitAPI::TEST):
1010
1011 2016-08-16  Daniel Bates  <dabates@apple.com>
1012
1013         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
1014         https://bugs.webkit.org/show_bug.cgi?id=160924
1015
1016         Reviewed by Stephanie Lewis.
1017
1018         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
1019         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
1020         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
1021         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
1022         object that mocks out the file system and SCM operations.
1023
1024         * Scripts/VCSUtils.pm:
1025         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
1026         * Scripts/prepare-ChangeLog:
1027         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
1028         abstracting the logic to query the file system and SCM into functions on a delegate object that
1029         we pass to it.
1030         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
1031         (diffHeaderFormat): Deleted.
1032
1033 2016-08-16  Alex Christensen  <achristensen@webkit.org>
1034
1035         URLParser should parse URLs without credentials
1036         https://bugs.webkit.org/show_bug.cgi?id=160913
1037
1038         Reviewed by Brady Eidson.
1039
1040         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1041         (TestWebKitAPI::s):
1042         (TestWebKitAPI::checkURL):
1043         (TestWebKitAPI::TEST_F):
1044
1045 2016-08-16  Anders Carlsson  <andersca@apple.com>
1046
1047         Add WTF::ScopeExit
1048         https://bugs.webkit.org/show_bug.cgi?id=160908
1049
1050         Reviewed by Geoffrey Garen.
1051
1052         * TestWebKitAPI/CMakeLists.txt:
1053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1054         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
1055         (TestWebKitAPI::TEST):
1056
1057 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
1058
1059         EWS logs file are rotated too quickly
1060         https://bugs.webkit.org/show_bug.cgi?id=160724
1061
1062         Reviewed by Daniel Bates.
1063
1064         Currently we are rotating the log file after 10 iterations of queue. If the queue
1065         doesn't have any pending patches, these iterations result in very small amount of 
1066         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
1067         This results in a lot of log files in a day. This patch ensures that we rotate the
1068         log file when its file size is greater than or equal to 100 KB.
1069
1070         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
1071
1072 2016-08-16  Daniel Bates  <dabates@apple.com>
1073
1074         WKSI static library should be named by major iOS revision, not individual updates
1075         https://bugs.webkit.org/show_bug.cgi?id=160727
1076         <rdar://problem/22274848>
1077
1078         Reviewed by Alexey Proskuryakov.
1079
1080         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1081         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1082         * Scripts/copy-webkitlibraries-to-product-directory:
1083         * WebKitTestRunner/Configurations/Base.xcconfig:
1084         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1085
1086 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
1087
1088         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
1089         https://bugs.webkit.org/show_bug.cgi?id=160909
1090
1091         Reviewed by Enrica Casucci.
1092         
1093         Add functions to UIScriptController to dismiss the form accessory view for iOS,
1094         and to programmatically pick a row from a <select> picker.
1095
1096         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1097         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1098         (WTR::UIScriptController::dismissFormAccessoryView):
1099         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1100         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1101         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1102         (WTR::UIScriptController::dismissFormAccessoryView):
1103         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1104
1105 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1106
1107         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
1108         https://bugs.webkit.org/show_bug.cgi?id=160878
1109
1110         Reviewed by Tim Horton.
1111         
1112         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
1113         now that we have the ability to run tests in the iPad simulator.
1114
1115         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1116         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1117         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1118         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1119         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1120         * WebKitTestRunner/ios/TestControllerIOS.mm:
1121         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
1122         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1123         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1124         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1125
1126 2016-08-15  Anders Carlsson  <andersca@apple.com>
1127
1128         Add an address-of operator to RetainPtr
1129         https://bugs.webkit.org/show_bug.cgi?id=160879
1130
1131         Reviewed by Tim Horton.
1132
1133         Test HashMap and HashSet with an object whose operator& is deleted.
1134
1135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1136         Sort the Xcode project.
1137
1138         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
1139         (DeletedAddressOfOperator::DeletedAddressOfOperator):
1140         (DeletedAddressOfOperator::value):
1141         (DeletedAddressOfOperator::operator==):
1142         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
1143         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
1144         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
1145         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
1146         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1147         (TestWebKitAPI::TEST):
1148         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1149         (TestWebKitAPI::TEST):
1150
1151 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
1152
1153         False crashes in fast/text/emoji-gender-* tests
1154         https://bugs.webkit.org/show_bug.cgi?id=160779
1155
1156         Reviewed by Alexey Proskuryakov.
1157
1158         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
1159
1160         * Scripts/webkitpy/port/driver.py:
1161         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
1162         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
1163         * Scripts/webkitpy/port/server_process.py:
1164         (ServerProcess.write): Allow caller to disable crash flag on exception.
1165
1166 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1167
1168         webkitpy error in TestRunResults.merge()
1169         https://bugs.webkit.org/show_bug.cgi?id=160882
1170
1171         Reviewed by Daniel Bates.
1172         
1173         The argument to TestRunResults.merge() can be None if there are no device-specifc
1174         initial results or retry results in Manager.run(), so just return early in that case.
1175
1176         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1177         (TestRunResults.merge):
1178
1179 2016-08-15  Sam Weinig  <sam@webkit.org>
1180
1181         Speed up compile times by not including wtf/Variant.h so much
1182         https://bugs.webkit.org/show_bug.cgi?id=160847
1183
1184         Reviewed by Alex Christensen and Saam Barati.
1185
1186         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1187         (TestWebKitAPI::TEST):
1188         Explicitly use std::experimental::variant.
1189
1190 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1191
1192         Allow a port to run tests with a custom device setup
1193         https://bugs.webkit.org/show_bug.cgi?id=160833
1194
1195         Reviewed by Daniel Bates.
1196
1197         These changes allow the IOSSimulator port to run tests in iPad mode.
1198
1199         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
1200         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
1201         a custom device will be collected into a set, and run in that device's environment after
1202         the other tests have run.
1203
1204         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1205         (Manager._custom_device_for_test): If the test contains a directory matching a
1206         custom device suffix, return that custom device.
1207         (Manager._set_up_run): Push the custom device class, if any, into options so
1208         that the Worker can get to it.
1209         (Manager.run): Go through the list of tests, and break it down into device-generic
1210         tests, and tests for each device class. _run_test_subset is then called for
1211         each collection of tests, and the results merged.
1212         (Manager._run_test_subset): Some lines unwrapped.
1213         (Manager._end_test_run):
1214         (Manager._run_tests):
1215         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1216         (SingleTestRunner.__init__): Unwrapped a line.
1217         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1218         (TestRunResults.merge): Add this function to merge TestRunResults
1219         * Scripts/webkitpy/layout_tests/views/printing.py:
1220         (Printer.print_workers_and_shards): Print the custom device, if any.
1221         * Scripts/webkitpy/port/base.py:
1222         (Port): Base port has empty array of custom devices.
1223         (Port.setup_test_run): Add device_class argument.
1224         * Scripts/webkitpy/port/driver.py:
1225         (DriverInput.__repr__):
1226         (Driver.check_driver.implementation):
1227         * Scripts/webkitpy/port/efl.py:
1228         (EflPort.setup_test_run):
1229         * Scripts/webkitpy/port/gtk.py:
1230         (GtkPort.setup_test_run):
1231         * Scripts/webkitpy/port/ios.py:
1232         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
1233         (IOSSimulatorPort.__init__):
1234         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
1235         based on the custom device class.
1236         (IOSSimulatorPort._set_device_class):
1237         (IOSSimulatorPort._create_simulators): Factor some code into this function.
1238         (IOSSimulatorPort.setup_test_run):
1239         (IOSSimulatorPort.testing_device):
1240         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
1241         seemed wrong for this function. That was moved to setup_test_run().
1242         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
1243         but this happened too early, before we knew which kind of devices to create. Devices
1244         are now created in setup_test_run().
1245         * Scripts/webkitpy/port/win.py:
1246         (WinPort.setup_test_run):
1247
1248 2016-08-15  Daniel Bates  <dabates@apple.com>
1249
1250         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1251         private frameworks and libraries
1252         https://bugs.webkit.org/show_bug.cgi?id=155931
1253         <rdar://problem/25807989>
1254
1255         Reviewed by Dan Bernstein.
1256
1257         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1258         where X is the major version of the active iOS SDK.
1259
1260         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1261         * WebKitTestRunner/Configurations/Base.xcconfig:
1262
1263 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1264
1265         Add a setting and preferences to enable visual viewport mode
1266         https://bugs.webkit.org/show_bug.cgi?id=160843
1267
1268         Reviewed by Sam Weinig.
1269         
1270         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
1271
1272         * MiniBrowser/mac/SettingsController.h:
1273         * MiniBrowser/mac/SettingsController.m:
1274         (-[SettingsController _populateMenu]):
1275         (-[SettingsController validateMenuItem:]):
1276         (-[SettingsController visualViewportEnabled]):
1277         (-[SettingsController toggleVisualViewportEnabled:]):
1278         * MiniBrowser/mac/WK1BrowserWindowController.m:
1279         (-[WK1BrowserWindowController didChangeSettings]):
1280         * MiniBrowser/mac/WK2BrowserWindowController.m:
1281         (-[WK2BrowserWindowController didChangeSettings]):
1282
1283 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
1284
1285         Allow using make-dist with non-GTK ports
1286         https://bugs.webkit.org/show_bug.cgi?id=160842
1287
1288         Reviewed by Michael Catanzaro.
1289
1290         This patch adds support for setting base name of tarball and argument
1291         passed to cmake's -DPORT= via command line arguments.
1292
1293         * gtk/make-dist.py:
1294         (Distcheck.configure):
1295         (Distcheck.check):
1296         (get_tarball_root_and_output_filename_from_arguments):
1297
1298 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1299
1300         [GTK] Install script lacks gstreamer related dependencies
1301         https://bugs.webkit.org/show_bug.cgi?id=160814
1302
1303         Reviewed by Carlos Garcia Campos.
1304
1305         * gtk/install-dependencies: Fedora case had already listed this dependencies,
1306         but both Arch and Debian/Ubuntu were missing them.
1307
1308 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
1309
1310         make-dist.py should not allow unknown rules in manifest
1311         https://bugs.webkit.org/show_bug.cgi?id=160841
1312
1313         Reviewed by Carlos Garcia Campos.
1314
1315         * gtk/make-dist.py:
1316         (Manifest.process_line):
1317
1318 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1319
1320         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1321         https://bugs.webkit.org/show_bug.cgi?id=160809
1322
1323         Reviewed by Carlos Garcia Campos.
1324
1325         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1326         case, and use it also for the new package names of libpng and libgeoclue.
1327         * gtk/install-dependencies: Ditto.
1328
1329 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1330
1331         Skip to check directories existence in build-webkit
1332         https://bugs.webkit.org/show_bug.cgi?id=160691
1333
1334         Reviewed by Alex Christensen.
1335
1336         CMake checks if directories are there itself. So CMake ports
1337         don't need to check it in the build-webkit script.
1338
1339         * Scripts/build-webkit:
1340         * Scripts/webkitdirs.pm:
1341         (determineSourceDir):
1342         (isCMakeBuild):
1343
1344 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1345
1346         Make URLParser work with URLs missing URL parts
1347         https://bugs.webkit.org/show_bug.cgi?id=160824
1348
1349         Reviewed by Brady Eidson.
1350
1351         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1352         (TestWebKitAPI::s):
1353         (TestWebKitAPI::checkURL):
1354         (TestWebKitAPI::TEST_F):
1355         (TestWebKitAPI::eq): Deleted.
1356
1357 2016-08-12  John Wilander  <wilander@apple.com>
1358
1359         Add HashCountedSet API tests to TestWTFLibrary target
1360         https://bugs.webkit.org/show_bug.cgi?id=160815
1361
1362         Reviewed by Alex Christensen.
1363
1364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1365             Added HashCountedSet.cpp and sorted the file reference section
1366             according to UNIX sort.
1367
1368 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
1369
1370         run-benchmark should run JetStream 1.1 instead of 1.0.1
1371         https://bugs.webkit.org/show_bug.cgi?id=160816
1372
1373         Reviewed by Filip Pizlo.
1374
1375         Use the latest JetStream 1.1 in run-benchmark.
1376
1377         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1378         (BenchmarkBuilder.__exit__):
1379         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1380         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1381         change to JetStream directory.
1382
1383 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1384
1385         Initial URLParser implementation
1386         https://bugs.webkit.org/show_bug.cgi?id=160811
1387
1388         Reviewed by Brady Eidson.
1389
1390         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1391         (TestWebKitAPI::eq):
1392         (TestWebKitAPI::checkURL):
1393         (TestWebKitAPI::TEST_F):
1394
1395 2016-08-12  Brady Eidson  <beidson@apple.com>
1396
1397         Fix the 32-bit Mac build after:
1398         Add WK2 ExperimentalFeature support to MiniBrowser
1399         https://bugs.webkit.org/show_bug.cgi?id=160788
1400
1401         Unreviewed.
1402
1403         Sprinkle "#if WK_API_ENABLED"s liberally.
1404         
1405         * MiniBrowser/mac/AppDelegate.m:
1406         (defaultConfiguration):
1407         * MiniBrowser/mac/SettingsController.m:
1408         (-[SettingsController _populateMenu]):
1409         (-[SettingsController validateMenuItem:]):
1410
1411 2016-08-12  Philippe Normand  <pnormand@igalia.com>
1412
1413         [GStreamer][OWR] Video rendering fixes
1414         https://bugs.webkit.org/show_bug.cgi?id=160764
1415
1416         Reviewed by Xabier Rodriguez-Calvar.
1417
1418         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1419
1420 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
1421
1422         Add missing return statement in convertFast function added in r204376.
1423
1424         Unreviewed.
1425
1426         * Scripts/webkitpy/common/system/path.py:
1427         (_CygPath.convertFast):
1428
1429 2016-08-11  Brady Eidson  <beidson@apple.com>
1430
1431         Add WK2 ExperimentalFeature support to MiniBrowser.
1432         https://bugs.webkit.org/show_bug.cgi?id=160788
1433
1434         Reviewed by Alex Christensen.
1435
1436         * MiniBrowser/mac/AppDelegate.h:
1437         * MiniBrowser/mac/AppDelegate.m:
1438         (defaultConfiguration):
1439         (defaultPreferences):
1440         
1441         * MiniBrowser/mac/SettingsController.m:
1442         (-[SettingsController _populateMenu]):
1443         (-[SettingsController validateMenuItem:]):
1444         (-[SettingsController toggleExperimentalFeature:]):
1445
1446 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1447
1448         Keep EWS logs for longer
1449         https://bugs.webkit.org/show_bug.cgi?id=160776
1450
1451         Reviewed by Daniel Bates.
1452
1453         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1454
1455 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
1456
1457         iOS DRT/WTR project cleanup
1458         https://bugs.webkit.org/show_bug.cgi?id=160778
1459
1460         Reviewed by Tim Horton.
1461
1462         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1463
1464         Remove AppDelegate.* which were unused.
1465
1466         Exclude ios/Launch.storyboard on more platforms.
1467
1468         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1469         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1470         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1471         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1472         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1473         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1474         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1475
1476 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1477
1478         Fix Yosemite bots' cookie accept policies after r204365.
1479         https://bugs.webkit.org/show_bug.cgi?id=160758
1480
1481         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1482         (TEST):
1483         This makes the test fully clean up after itself.
1484
1485 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1486
1487         Fix Yosemite bots' cookie accept policies after r204365.
1488         https://bugs.webkit.org/show_bug.cgi?id=160758
1489
1490         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1491         (TEST):
1492         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1493         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1494         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1495         causing any problems because there are no other API tests that do anything with cookies.
1496         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1497         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1498         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1499
1500 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1501
1502         EWS should check if the patch is still valid before executing every major step
1503         https://bugs.webkit.org/show_bug.cgi?id=160739
1504         rdar://problem/27768813
1505
1506         Reviewed by Alexey Proskuryakov.
1507
1508         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1509         (CommitQueueTask.run): validate method is now executed in base class.
1510         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1511         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1512         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1513         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1514         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1515         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1516         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1517         * Scripts/webkitpy/tool/commands/perfalizer.py:
1518         (PerfalizerTask.validate): Added.
1519         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1520         (test_manual_reject_during_processing): Updated test case.
1521
1522 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1523
1524         Add URLParser stub
1525         https://bugs.webkit.org/show_bug.cgi?id=160770
1526
1527         Reviewed by Sam Weinig.
1528
1529         * TestWebKitAPI/PlatformGTK.cmake:
1530         * TestWebKitAPI/PlatformWin.cmake:
1531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1532         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1533         (TestWebKitAPI::TEST_F):
1534
1535 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1536
1537         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1538         https://bugs.webkit.org/show_bug.cgi?id=160761
1539
1540         Reviewed by Tim Horton.
1541
1542         Give iOS DRT a Launch storyboard.
1543
1544         Have it use a UIViewController so future forms testing works correctly.
1545
1546         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1547         can run in iPad mode.
1548
1549         Remove empty InfoPlist.strings files.
1550
1551         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1552         * DumpRenderTree/ios/Info.plist:
1553         * DumpRenderTree/ios/Launch.storyboard: Added.
1554         * DumpRenderTree/mac/DumpRenderTree.mm:
1555         (createWebViewAndOffscreenWindow):
1556         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1557         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1558         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1559         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1560
1561 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
1562
1563         [Win] Unable to reliably run tests in parallel
1564         https://bugs.webkit.org/show_bug.cgi?id=140914
1565
1566         Reviewed by Brent Fulgham.
1567
1568         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1569         processes. We can use string replacement to convert the Cygwin path to a Windows path
1570         instead.
1571
1572         * Scripts/webkitpy/common/system/path.py:
1573         (cygpathFast):
1574         * Scripts/webkitpy/port/driver.py:
1575         (Driver._command_from_driver_input):
1576
1577 2016-08-10  Alex Christensen  <achristensen@webkit.org>
1578
1579         Fix crash when changing cookie accept policy after r204327
1580         https://bugs.webkit.org/show_bug.cgi?id=160758
1581
1582         Reviewed by Simon Fraser.
1583
1584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1585         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1586         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1587         (TEST):
1588         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1589
1590 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1591
1592         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1593         https://bugs.webkit.org/show_bug.cgi?id=160757
1594
1595         Reviewed by Tim Horton.
1596
1597         When programmatically creating the test UIWindow, make a root UIViewController and parent
1598         the WKWebView in its view. This makes the app more like a normal UIKit application.
1599         
1600         Move the WKWebView down 20px to avoid the status bar.
1601         
1602         Give the UIWindow a gray background so it's obvious where the window and view positioned.
1603
1604         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1605         
1606         Remove duplicate references to Launch.storyboard.
1607
1608         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1609         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1610         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1611         (-[AppDelegate applicationWillResignActive:]): Deleted.
1612         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1613         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1614         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1615         (-[AppDelegate applicationWillTerminate:]): Deleted.
1616         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1617         (WTR::viewRectForWindowRect):
1618         (WTR::PlatformWebView::PlatformWebView):
1619         (WTR::PlatformWebView::setWindowFrame):
1620
1621 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1622
1623         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1624         https://bugs.webkit.org/show_bug.cgi?id=160748
1625
1626         Reviewed by Tim Horton.
1627         
1628         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1629         opens the door for tests using other device sizes.
1630
1631         * WebKitTestRunner/ios/TestControllerIOS.mm:
1632         (WTR::TestController::platformConfigureViewForTest):
1633
1634 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1635
1636         Sort the feature flags in the FEATURE_DEFINES lines
1637         https://bugs.webkit.org/show_bug.cgi?id=160742
1638
1639         Reviewed by Anders Carlsson.
1640         
1641         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1642
1643 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1644
1645         Logging and other minor improvements to iOS webkitpy
1646         https://bugs.webkit.org/show_bug.cgi?id=160722
1647
1648         Reviewed by Dan Bates.
1649
1650         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1651         to make it easier to debug launching issues.
1652
1653         Have reset_preferences() reset the device, rather than just nuking the data
1654         directory (which broke some versions of the simulator).
1655
1656         Make the Simulator.app launch in the background with open -g.
1657
1658         Wait for the simulator device to be in a known state in some more places.
1659
1660         * Scripts/webkitpy/port/ios.py:
1661         (IOSSimulatorPort.setup_test_run):
1662         (IOSSimulatorPort._quit_ios_simulator):
1663         (IOSSimulatorPort.clean_up_test_run):
1664         (IOSSimulatorPort.setup_environ_for_server):
1665         (IOSSimulatorPort.reset_preferences):
1666         * Scripts/webkitpy/xcode/simulator.py:
1667         (Device.create):
1668         (Device.delete):
1669         (Device):
1670         (Device.reset):
1671         (Simulator.wait_until_device_is_booted):
1672         (Simulator.wait_until_device_is_in_state):
1673         (Simulator):
1674         (Simulator.delete_device):
1675         (Simulator.reset_device):
1676         (Simulator.lookup_or_create_device):
1677
1678 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1679
1680         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1681         https://bugs.webkit.org/show_bug.cgi?id=160697
1682
1683         Reviewed by Antonio Gomes.
1684
1685         * Scripts/webkitpy/port/base.py:
1686         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1687         list of environment variables to copy.
1688
1689 2016-08-09  George Ruan  <gruan@apple.com>
1690
1691         Implement functionality of media capture on iOS
1692         https://bugs.webkit.org/show_bug.cgi?id=158945
1693         <rdar://problem/26893343>
1694
1695         Reviewed by Tim Horton.
1696
1697         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1698         Capture feature on iOS.
1699
1700 2016-08-09  Saam Barati  <sbarati@apple.com>
1701
1702         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1703         https://bugs.webkit.org/show_bug.cgi?id=160671
1704         <rdar://problem/27756112>
1705
1706         Reviewed by Mark Lam.
1707
1708         * Scripts/run-jsc-stress-tests:
1709
1710 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1711
1712         Make directory reading code in iOSSimulatorDevices() more strict
1713         https://bugs.webkit.org/show_bug.cgi?id=160702
1714
1715         Reviewed by Tim Horton.
1716
1717         * Scripts/webkitdirs.pm:
1718         (iOSSimulatorDevices):
1719
1720 2016-08-06  Sam Weinig  <sam@webkit.org>
1721
1722         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1723         https://bugs.webkit.org/show_bug.cgi?id=160638
1724
1725         Reviewed by Anders Carlsson.
1726
1727         * TestWebKitAPI/CMakeLists.txt:
1728         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1729         Add additional tests for the initial state of std::variant and using
1730         makeVisitor for visiting.
1731
1732 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1733
1734         EWS logging should ensure the logging to file is stopped on queue termination
1735         https://bugs.webkit.org/show_bug.cgi?id=160698
1736         rdar://problem/24464570
1737
1738         Reviewed by Daniel Bates.
1739
1740         * Scripts/webkitpy/tool/bot/queueengine.py:
1741         (QueueEngine._stopping): Stop logging to file on queue termination.
1742         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1743         * Scripts/webkitpy/common/system/logutils.py:
1744         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1745         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1746         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1747         * Scripts/webkitpy/tool/commands/queues.py:
1748         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1749         (AbstractQueue.queue_log_path): Same.
1750         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1751         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1752         which moved to QueueEngine now.
1753         (PatchProcessingQueue.__init__): Same.
1754         (CommitQueue.__init__): Same.
1755         (AbstractReviewQueue.__init__): Same.
1756         (StyleQueue.__init__): Same.
1757         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1758         (TestCommitQueue): Removed host parameter.
1759         (TestCommitQueue.__init__): Same.
1760         (AbstractPatchQueueTest.test_next_patch): Same.
1761         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1762         (test_commit_queue_failure): Same.
1763         (mock_run_webkit_patch):
1764         (MockCommitQueueTask.results_from_patch_test_run): Same.
1765         (test_rollout_lands): Same.
1766         (test_non_valid_patch): Same.
1767         (test_auto_retry): Same.
1768         (test_style_queue_with_watch_list_exception): Same.
1769         (TestQueue.__init__): Deleted.
1770         (TestReviewQueue.__init__): Deleted.
1771         (TestFeederQueue.__init__): Deleted.
1772
1773 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1774
1775         webkit-gtk tarball fails to build due to missing files
1776         https://bugs.webkit.org/show_bug.cgi?id=160684
1777
1778         Reviewed by Alex Christensen.
1779
1780         * gtk/manifest.txt.in: Added back spi directories.
1781
1782 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1783
1784         [GTK] Build the jhbuild with -O2 optimization level by default
1785         https://bugs.webkit.org/show_bug.cgi?id=160544
1786
1787         Reviewed by Michael Catanzaro.
1788
1789         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1790         which don't increases the required disk space significatively and
1791         provides better debug information than no passing it.
1792
1793 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1794
1795         Allow more --cmakeargs option in build-jsc and build-webkit
1796         https://bugs.webkit.org/show_bug.cgi?id=160340
1797
1798         Reviewed by Michael Catanzaro.
1799
1800         * Scripts/build-jsc:
1801         * Scripts/build-webkit:
1802
1803 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1804
1805         Do not check if WebKitLibraries folder exists on EFL and GTK
1806         https://bugs.webkit.org/show_bug.cgi?id=160659
1807
1808         Reviewed by Csaba Osztrogonác.
1809
1810         Though WebKitLibraries is only needed by mac and win ports,
1811         EFL and GTK ports have checked whether it exists.
1812
1813         * Scripts/build-webkit:
1814
1815 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1816
1817         Some EWS console logs doesn't go to log file
1818         https://bugs.webkit.org/show_bug.cgi?id=160585
1819         rdar://problem/24464570
1820
1821         Reviewed by Daniel Bates.
1822
1823         * Scripts/webkitpy/common/system/logutils.py:
1824         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1825         any possible overwriting.
1826         * Scripts/webkitpy/common/system/filesystem.py:
1827         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1828         * Scripts/webkitpy/common/system/filesystem_mock.py:
1829         (MockFileSystem.open_text_file_for_writing): Same.
1830         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1831         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1832         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1833         * Scripts/webkitpy/tool/commands/queues.py:
1834         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1835         This will ensure that all the sub-modules inside webkitpy will log to file.
1836
1837 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1838
1839         Have the iOS platform interit from the Apple platform in webkitpy
1840         https://bugs.webkit.org/show_bug.cgi?id=160672
1841
1842         Reviewed by Dan Bates.
1843         
1844         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1845         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1846         ApplePort.
1847         
1848         Since WinPort also inherits from ApplePort, it needs to stub out some things
1849         that are unavailable on Windows (leaks, sampling).
1850         
1851         Some SnowLeopard-related code and the associated test were removed.
1852
1853         * Scripts/webkitpy/port/apple.py:
1854         (ApplePort.__init__):
1855         (ApplePort):
1856         (ApplePort._make_leak_detector):
1857         (ApplePort.default_timeout_ms):
1858         (ApplePort.supports_per_test_timeout):
1859         (ApplePort.should_retry_crashes):
1860         (ApplePort._generate_all_test_configurations):
1861         (ApplePort.check_for_leaks):
1862         (ApplePort.print_leaks_summary):
1863         (ApplePort._path_to_webcore_library):
1864         (ApplePort.show_results_html_file):
1865         (ApplePort._merge_crash_logs):
1866         (ApplePort._look_for_all_crash_logs_in_log_dir):
1867         (ApplePort._get_crash_log):
1868         (ApplePort.look_for_new_crash_logs):
1869         (ApplePort.sample_process):
1870         (ApplePort.sample_file_path):
1871         (ApplePort.look_for_new_samples):
1872         (ApplePort._path_to_helper):
1873         (ApplePort.determine_full_port_name): Deleted.
1874         * Scripts/webkitpy/port/ios.py:
1875         (IOSSimulatorPort):
1876         (IOSSimulatorPort.__init__):
1877         (IOSSimulatorPort.default_timeout_ms): Deleted.
1878         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1879         (IOSSimulatorPort.should_retry_crashes): Deleted.
1880         (IOSSimulatorPort.check_for_leaks): Deleted.
1881         (IOSSimulatorPort.print_leaks_summary): Deleted.
1882         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1883         (IOSSimulatorPort.show_results_html_file): Deleted.
1884         (IOSSimulatorPort.sample_file_path): Deleted.
1885         (IOSSimulatorPort._merge_crash_logs): Deleted.
1886         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1887         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1888         (IOSSimulatorPort.look_for_new_samples): Deleted.
1889         (IOSSimulatorPort.sample_process): Deleted.
1890         (IOSSimulatorPort._path_to_helper): Deleted.
1891         (IOSSimulatorPort.make_command): Deleted.
1892         * Scripts/webkitpy/port/mac.py:
1893         (MacPort.__init__):
1894         (MacPort.make_command):
1895         (MacPort._build_java_test_support):
1896         (MacPort): Deleted.
1897         (MacPort.default_timeout_ms): Deleted.
1898         (MacPort.supports_per_test_timeout): Deleted.
1899         (MacPort.should_retry_crashes): Deleted.
1900         (MacPort.default_child_processes): Deleted.
1901         (MacPort.check_for_leaks): Deleted.
1902         (MacPort.print_leaks_summary): Deleted.
1903         (MacPort._path_to_webcore_library): Deleted.
1904         (MacPort.show_results_html_file): Deleted.
1905         (MacPort.sample_file_path): Deleted.
1906         (MacPort._merge_crash_logs): Deleted.
1907         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1908         (MacPort.look_for_new_crash_logs): Deleted.
1909         (MacPort.look_for_new_samples): Deleted.
1910         (MacPort.sample_process): Deleted.
1911         (MacPort._path_to_helper): Deleted.
1912         * Scripts/webkitpy/port/mac_unittest.py:
1913         (MacTest.test_default_child_processes): Deleted.
1914         * Scripts/webkitpy/port/win.py:
1915         (WinPort.look_for_new_samples):
1916         (WinPort):
1917         (WinPort.sample_process):
1918         (WinPort._make_leak_detector):
1919         (WinPort.check_for_leaks):
1920         (WinPort.print_leaks_summary):
1921         (WinPort._path_to_webcore_library):
1922
1923 2016-08-08  Matt Baker  <mattbaker@apple.com>
1924
1925         Unreviewed: moved myself to the reviewers list.
1926
1927         * Scripts/webkitpy/common/config/contributors.json:
1928
1929 2016-08-08  Chris Dumez  <cdumez@apple.com>
1930
1931         Update API tests in mac/SetDocumentURI.mm after r204247
1932         https://bugs.webkit.org/show_bug.cgi?id=160660
1933
1934         Reviewed by Alex Christensen.
1935
1936         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1937         (TestWebKitAPI::TEST):
1938
1939 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1940
1941         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1942         https://bugs.webkit.org/show_bug.cgi?id=159827
1943
1944         Reviewed by Daniel Bates.
1945
1946         This change was spurred by a process hang which occurred between tests and did
1947         not produce a meaningful crashlog.
1948
1949         * Scripts/webkitpy/port/driver.py:
1950         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1951
1952          * Scripts/webkitpy/port/ios.py:
1953         (IOSSimulatorPort):
1954         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1955         * Scripts/webkitpy/port/mac.py:
1956         (MacPort):
1957         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1958
1959         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1960         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1961
1962         * WebKitTestRunner/TestController.h:
1963         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1964         * WebKitTestRunner/TestInvocation.cpp:
1965         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1966
1967 2016-08-07  Dan Bernstein  <mitz@apple.com>
1968
1969         [Cocoa] Reply block leaks if the remote object doesn’t call it
1970         https://bugs.webkit.org/show_bug.cgi?id=160642
1971
1972         Reviewed by Sam Weinig.
1973
1974         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1975         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1976         (TEST): Added a test case that checks that the reply block is released even when it’s not
1977           called.
1978         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1979         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1980           calling the completion handler.
1981
1982 2016-08-07  Chris Dumez  <cdumez@apple.com>
1983
1984         Write API test to cover crash fix in r204135
1985         https://bugs.webkit.org/show_bug.cgi?id=160587
1986
1987         Reviewed by Darin Adler.
1988
1989         Add API test to cover crash fix in r204135. This reproduces the crash
1990         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1991         callback.
1992
1993         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1994         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1995         (TEST):
1996
1997 2016-08-06  Chris Dumez  <cdumez@apple.com>
1998
1999         Unreviewed, rolling out r204226.
2000
2001         Broke some API tests
2002
2003         Reverted changeset:
2004
2005         "Write API test to cover crash fix in r204135"
2006         https://bugs.webkit.org/show_bug.cgi?id=160587
2007         http://trac.webkit.org/changeset/204226
2008
2009 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
2010
2011         EWS Style Queue fails to process patches which fails validation
2012         https://bugs.webkit.org/show_bug.cgi?id=160632
2013
2014         Reviewed by Alexey Proskuryakov.
2015
2016         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2017         (StyleQueueTask.validate): Add more information about validation failure.
2018         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2019         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2020         (test_non_valid_patch): Add a unit test to test the above code path.
2021
2022 2016-08-06  Sam Weinig  <sam@webkit.org>
2023
2024         WTF needs a variant implementation
2025         https://bugs.webkit.org/show_bug.cgi?id=160618
2026
2027         Reviewed by Darin Adler.
2028
2029         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2030         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
2031         Add tests for the variant implementation.
2032
2033 2016-08-06  Chris Dumez  <cdumez@apple.com>
2034
2035         Write API test to cover crash fix in r204135
2036         https://bugs.webkit.org/show_bug.cgi?id=160587
2037
2038         Reviewed by Darin Adler.
2039
2040         Add API test to cover crash fix in r204135. This reproduces the crash
2041         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2042         callback.
2043
2044         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2045         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2046         (TEST):
2047
2048 2016-08-05  Tim Horton  <timothy_horton@apple.com>
2049
2050         run-api-tests should use a headed simulator
2051         https://bugs.webkit.org/show_bug.cgi?id=160611
2052
2053         Reviewed by Sam Weinig.
2054
2055         CADisplayLink doesn't work in a headless simulator, but is
2056         vital for the proper functioning of WebKit2 painting on iOS.
2057         So, we should not use a headless simulator.
2058
2059         * Scripts/run-api-tests:
2060         Launch a simulator app, don't just boot the simulator.
2061
2062         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2063         Re-enable a test that works now.
2064
2065 2016-08-05  Dan Bernstein  <mitz@apple.com>
2066
2067         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
2068         https://bugs.webkit.org/show_bug.cgi?id=160589
2069
2070         Reviewed by Tim Horton.
2071
2072         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
2073         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
2074           blocks, which wasn’t caught because the test wasn’t run correctly.
2075         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2076         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
2077           added a test that sends over an NSRange.
2078         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2079         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
2080           handler with the range‘s location and length.
2081
2082 2016-08-05  Enrica Casucci  <enrica@apple.com>
2083
2084         Fixing tests failing after r204175.
2085
2086         Unreviewed.
2087
2088         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
2089
2090 2016-08-05  Enrica Casucci  <enrica@apple.com>
2091
2092         Build fix after 204053.
2093
2094         Unreviewed.
2095
2096         * TestWebKitAPI/Configurations/Base.xcconfig:
2097         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2098         (-[MockContentFilterEnabler initWithCoder:]):
2099         (-[MockContentFilterEnabler dealloc]):
2100
2101 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
2102
2103         Print test name in "Last character read from DRT..." error message.
2104         https://bugs.webkit.org/show_bug.cgi?id=160559
2105
2106         Reviewed by Michael Catanzaro.
2107
2108         * Scripts/webkitpy/port/driver.py:
2109         (Driver.run_test):
2110         (Driver._read_first_block):
2111         (Driver._read_optional_image_block):
2112         (Driver._read_block):
2113         * Scripts/webkitpy/port/driver_unittest.py:
2114         (DriverTest.test_read_block):
2115         (DriverTest.test_read_binary_block):
2116         (DriverTest.test_read_base64_block):
2117
2118 2016-08-05  Commit Queue  <commit-queue@webkit.org>
2119
2120         Unreviewed, rolling out r204123.
2121         https://bugs.webkit.org/show_bug.cgi?id=160597
2122
2123         Caused layout test timeouts on Windows. (Requested by perarne
2124         on #webkit).
2125
2126         Reverted changeset:
2127
2128         "[Win] Unable to reliably run tests in parallel"
2129         https://bugs.webkit.org/show_bug.cgi?id=140914
2130         http://trac.webkit.org/changeset/204123
2131
2132 2016-08-04  Saam Barati  <sbarati@apple.com>
2133
2134         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
2135         https://bugs.webkit.org/show_bug.cgi?id=151241
2136
2137         Reviewed by Benjamin Poulain.
2138
2139         * Scripts/run-jsc-stress-tests:
2140
2141 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
2142
2143         UI improvements to Flakiness Dashboard.
2144         https://bugs.webkit.org/show_bug.cgi?id=153295
2145
2146         Reviewed by Alexey Proskuryakov.
2147
2148         * TestResultServer/static-dashboards/flakiness_dashboard.css:
2149         (td.options-container): Center text in most fields.
2150         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2151         (createBugHTML): Text/Grammar updates.
2152         (tableHeaders): Ditto.
2153         (htmlForSingleTestRow): Ditto.
2154         (headerForTestTableHtml): Ditto.
2155         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
2156         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
2157
2158 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2159
2160         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
2161         https://bugs.webkit.org/show_bug.cgi?id=160518
2162
2163         Reviewed by Michael Catanzaro.
2164
2165         * Scripts/webkitpy/thirdparty/__init__.py:
2166         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
2167         * gtk/install-dependencies:
2168
2169 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
2170
2171         Optimize bot watcher's dashboard a little
2172         https://bugs.webkit.org/show_bug.cgi?id=160515
2173         rdar://problem/26096900
2174
2175         Reviewed by Lucas Forschler.
2176
2177         Made re-sorting after loading an iteration more efficient.
2178
2179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2180         (BuildbotIteration.prototype._updateWithData):
2181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2182         (BuildbotQueue.prototype.updateIterationPosition):
2183
2184 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
2185
2186         [Win] Unable to reliably run tests in parallel
2187         https://bugs.webkit.org/show_bug.cgi?id=140914
2188
2189         Reviewed by Brent Fulgham.
2190
2191         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2192         processes. We can use string replacement to convert the Cygwin path to a Windows path
2193         instead.
2194  
2195         * Scripts/webkitpy/common/system/path.py:
2196         (cygpathFast):
2197         * Scripts/webkitpy/port/driver.py:
2198         (Driver._command_from_driver_input):
2199
2200 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
2201
2202         Document instructions for increasing process and file limits
2203         https://bugs.webkit.org/show_bug.cgi?id=160528
2204         rdar://problem/24777576
2205
2206         Reviewed by Alexey Proskuryakov.
2207
2208         * Scripts/webkitpy/port/ios.py:
2209         (IOSSimulatorPort.default_child_processes):
2210
2211 2016-08-03  Anders Carlsson  <andersca@apple.com>
2212
2213         Remove the Objective-C bindings generator
2214         https://bugs.webkit.org/show_bug.cgi?id=160526
2215
2216         Reviewed by Sam Weinig.
2217
2218         * Scripts/run-bindings-tests:
2219         Update test.
2220
2221 2016-08-03  Tim Horton  <timothy_horton@apple.com>
2222
2223         Revise a TestWebKitAPI comment to mention the actual underlying problem
2224
2225         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2226         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
2227
2228 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2229
2230         Benchmark test content-animation timeouts always
2231         https://bugs.webkit.org/show_bug.cgi?id=160057
2232
2233         Reviewed by Simon Fraser.
2234
2235         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
2236         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2237         (start):
2238
2239 2016-08-02  Nan Wang  <n_wang@apple.com>
2240
2241         AX: Simulated touch events are not working on iOS
2242         https://bugs.webkit.org/show_bug.cgi?id=160395
2243         <rdar://problem/27633597>
2244
2245         Reviewed by Chris Fleizach.
2246
2247         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2248         (WTR::AccessibilityUIElement::press):
2249         (WTR::AccessibilityUIElement::setSelectedChild):
2250
2251 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
2252
2253         run-javascriptcore-tests should accept multiple --extra-tests
2254         https://bugs.webkit.org/show_bug.cgi?id=160486
2255
2256         Reviewed by Saam Barati.
2257         
2258         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
2259         test suites. This does it by using GetOpt::Long's array support.
2260
2261         * Scripts/run-javascriptcore-tests:
2262         (runJSCStressTests):
2263
2264 2016-08-02  Enrica Casucci  <enrica@apple.com>
2265
2266         Allow building with content filtering disabled.
2267         https://bugs.webkit.org/show_bug.cgi?id=160454
2268
2269         Reviewed by Simon Fraser.
2270
2271         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2272
2273 2016-08-02  Brady Eidson  <beidson@apple.com>
2274
2275         Removing IndexedDB WebsiteData can fail for some users.
2276         https://bugs.webkit.org/show_bug.cgi?id=160463
2277
2278         Reviewed by Alex Christensen.
2279
2280         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2281
2282 2016-08-01  Alex Christensen  <achristensen@webkit.org>
2283
2284         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
2285         https://bugs.webkit.org/show_bug.cgi?id=160437
2286         <rdar://problem/27578272>
2287
2288         Reviewed by Brady Eidson.
2289
2290         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2291         (-[DownloadDelegate _download:didReceiveResponse:]):
2292         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2293         (runTest):
2294         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
2295
2296 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2297
2298         [Tools] The GDB backtrace report tool don't checks the gdb return code.
2299         https://bugs.webkit.org/show_bug.cgi?id=160414
2300
2301         Reviewed by Michael Catanzaro.
2302
2303         * Scripts/webkitpy/port/linux_get_crash_log.py:
2304         (GDBCrashLogGenerator._wait_for_corefile):
2305
2306 2016-08-01  Youenn Fablet  <youenn@apple.com>
2307
2308         Make wpt server generate its certificates in layout test results folder
2309         https://bugs.webkit.org/show_bug.cgi?id=160422
2310
2311         Reviewed by Chris Dumez.
2312
2313         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2314         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
2315
2316 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
2317
2318         Function Call on NULL Object
2319         https://bugs.webkit.org/show_bug.cgi?id=160325
2320
2321         Reviewed by Darin Adler.
2322
2323         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2324         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2325         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2326
2327 2016-08-01  Keith Miller  <keith_miller@apple.com>
2328
2329         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2330         https://bugs.webkit.org/show_bug.cgi?id=160372
2331
2332         Rubber stamped by Geoffrey Garen.
2333
2334         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2335         a new top level directory, JSTests. Having the tests in the Source directory
2336         was both confusing an inconvenient for people that just want to checkout the
2337         source code of WebKit. Since there is no other obvious place to put all the
2338         JavaScript tests a new top level directory seemed the most sensible.
2339
2340         * Scripts/import-test262-tests:
2341         * Scripts/run-javascriptcore-tests:
2342         * Scripts/update-javascriptcore-test-res:
2343
2344 2016-07-31  Nan Wang  <n_wang@apple.com>
2345
2346         AX: Add a check for touch event listener on iOS accessibility object
2347         https://bugs.webkit.org/show_bug.cgi?id=160388
2348
2349         Reviewed by Chris Fleizach.
2350
2351         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2352         (AccessibilityUIElement::boolAttributeValue):
2353         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2354         (WTR::AccessibilityUIElement::boolAttributeValue):
2355
2356 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
2357
2358         Unreviewed: add myself to the reviewers list.
2359
2360         * Scripts/webkitpy/common/config/contributors.json:
2361
2362 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
2363
2364         Undo r203939, and copy over a rule that clips the logos.
2365
2366         Sierra wasn't the only logo without transparency.
2367
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2371
2372 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
2373
2374         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2375         https://bugs.webkit.org/show_bug.cgi?id=160377
2376
2377         Reviewed by Brian Weinstein.
2378
2379         Update assets to remove the white background and use a transparent background instead.
2380
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2383
2384 2016-07-29  David Kilzer  <ddkilzer@apple.com>
2385
2386         Ignore most check-webkit-style checks for ANGLE project
2387         <https://webkit.org/b/160333>
2388
2389         Reviewed by Daniel Bates.
2390
2391         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2392         - No tabs.
2393         - No spaces at the end of lines.
2394         - No carriage returns (DOS line endings).
2395
2396 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2397
2398         Media controls are not displayed for some autoplaying videos at certain browser dimensions
2399         https://bugs.webkit.org/show_bug.cgi?id=160360
2400         <rdar://problem/27179484>
2401
2402         Reviewed by Myles C. Maxfield.
2403
2404         Adds two tests verifying that videos may be considered main content as long as they
2405         are large enough and cover a majority of the mainframe's viewport.
2406
2407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2408         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2409         (TestWebKitAPI::TEST):
2410         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2411         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2412
2413 2016-07-29  Mark Lam  <mark.lam@apple.com>
2414
2415         Gardening: removed unused variable.
2416
2417         Not reviewed.
2418
2419         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2420         (TestWebKitAPI::TEST):
2421
2422 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2423
2424         Add TestWebKitAPI support for interacting with media controls
2425         https://bugs.webkit.org/show_bug.cgi?id=160342
2426         <rdar://problem/27610246>
2427
2428         Reviewed by Beth Dakin.
2429
2430         Adds support for testing interaction with some media controls, as well as a basic test
2431         verifying that media control teardown after interaction does not result in a crash.
2432
2433         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2434         (-[WKWebView mouseDownAtPoint:]):
2435         (-[WKWebView performAfterLoading:]):
2436         (TestWebKitAPI::TEST):
2437
2438 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
2439
2440         Crash Log Clobbering on Unbound Crashes
2441         https://bugs.webkit.org/show_bug.cgi?id=160198
2442         <rdar://problem/27472618>
2443
2444         Reviewed by Alexey Proskuryakov.
2445
2446         * Scripts/webkitpy/common/system/crashlogs.py:
2447         (CrashLogs): Fix header order.
2448         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2449         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2450
2451 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2452
2453         Update for contributors.json
2454         https://bugs.webkit.org/show_bug.cgi?id=160294
2455
2456         * Scripts/webkitpy/common/config/contributors.json:
2457
2458 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2459
2460         Remove deprecated SPI for video inline / fullscreen controls
2461         https://bugs.webkit.org/show_bug.cgi?id=160318
2462
2463         Reviewed by Tim Horton.
2464
2465         * DumpRenderTree/mac/DumpRenderTree.mm:
2466         (setDefaultsToConsistentValuesForTesting): Deleted.
2467         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2468         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2469         * WebKitTestRunner/TestController.cpp:
2470         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2471         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2472         (WTR::initializeWebViewConfiguration): Deleted.
2473
2474 2016-07-28  Daniel Bates  <dabates@apple.com>
2475
2476         [iOS] TestWebKitAPI bundle targets are not code signed
2477         https://bugs.webkit.org/show_bug.cgi?id=160328
2478         <rdar://problem/27409246>
2479
2480         Reviewed by Andy Estes.
2481
2482         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2483         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2484         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2485
2486         * TestWebKitAPI/Configurations/Base.xcconfig:
2487
2488 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2489
2490         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2491
2492         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2493         (animatedResizeWebView):
2494         (TEST):
2495         This test times out only when run in the WebKit Testing simulator environment,
2496         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2497
2498 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2499
2500         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2501         https://bugs.webkit.org/show_bug.cgi?id=160289
2502         <rdar://problem/27553464>
2503
2504         Reviewed by Simon Fraser.
2505
2506         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2508         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2509         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2510         (-[AnimatedResizeWebView _endAnimatedResize]):
2511         (animatedResizeWebView):
2512         (TEST):
2513         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2514         Add two tests that ensure that hidden-content and animated resizes
2515         don't cause unnecessary synchronous waits. Only the hidden-content
2516         one fails before my patch, but it seemed reasonable to add both anyway.
2517
2518 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2519
2520         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2521         <https://webkit.org/b/83342>
2522
2523         Reviewed by Ryosuke Niwa.
2524
2525         * Scripts/webkitpy/common/checkout/scm/git.py:
2526         (Git.revisions_changing_file): Remove code to raise an exception
2527         when the file doesn't exist.  If a file was moved or renamed,
2528         then this caused the script to terminate, which was very
2529         frustrating when you wanted a list of reviewers.
2530         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2531         (SCMTest._shared_test_revisions_changing_file): Update test
2532         expectation to return an empty list of revisions.
2533         (test_create_patch_is_full_patch): Drive-by fix when running all
2534         webkitpy tests (including scm tests).
2535         * Scripts/webkitpy/common/checkout/scm/svn.py:
2536         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2537         return an empty array of revisions if this occurs.
2538
2539 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2540
2541         EWS error message "Error: * did not process patch" should include explanation
2542         https://bugs.webkit.org/show_bug.cgi?id=159903
2543         <rdar://problem/27410788>
2544
2545         Reviewed by Alexey Proskuryakov.
2546
2547         * QueueStatusServer/handlers/statusbubble.py:
2548         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2549         is not processed.
2550         * QueueStatusServer/handlers/processingtimesjson.py:
2551         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2552         of the code.
2553         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2554         (CommitQueueTask.validate): Add more information about validation failure.
2555         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2556         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2557         (EarlyWarningSystemTask.validate): Add more information about validation failure.
2558         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2559         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2560         (PatchIsNotValid.__init__): Add the failure_message argument.
2561         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2562         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2563         failure details.
2564         * Scripts/webkitpy/tool/commands/queues.py:
2565         (CommitQueue.process_work_item): Same.
2566         (StyleQueue.review_patch): Same.
2567         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2568         (test_non_valid_patch): Updated test-cases messages to match the above changes.
2569
2570 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2571
2572         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2573         https://bugs.webkit.org/show_bug.cgi?id=160262
2574
2575         Reviewed by Daniel Bates.
2576
2577         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2578         (-[LTRelayController installApp]):
2579
2580 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
2581
2582         Disable WebCoreNSURLSessionTest API tests on ios-simulator
2583         https://bugs.webkit.org/show_bug.cgi?id=160225
2584
2585         Reviewed by Alexey Proskuryakov.
2586
2587         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2588
2589 2016-07-27  Miguel Gomez  <magomez@igalia.com>
2590
2591         [GTK] Fix some video/canvas tests that should be passing
2592         https://bugs.webkit.org/show_bug.cgi?id=160023
2593
2594         Reviewed by Carlos Garcia Campos.
2595
2596         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2597         EFL or GTK platforms.
2598
2599         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2600         (WTR::TestController::platformConfigureViewForTest):
2601         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2602         (WTR::TestController::platformConfigureViewForTest):
2603
2604 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2605
2606         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2607         https://bugs.webkit.org/show_bug.cgi?id=160247
2608
2609         Reviewed by Michael Catanzaro.
2610
2611         * BuildSlaveSupport/built-product-archive:
2612         (createZip):
2613         (dirContainsdwo):
2614         (archiveBuiltProduct):
2615
2616 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2617
2618         Fix tests after r203743.
2619         https://bugs.webkit.org/show_bug.cgi?id=156947
2620
2621         * WebKitTestRunner/TestController.cpp:
2622         (WTR::TestController::resetStateToConsistentValues):
2623         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2624
2625 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2626
2627         [iPhone] Playing a video on tudou.com plays only sound, no video
2628         https://bugs.webkit.org/show_bug.cgi?id=160178
2629         <rdar://problem/27535468>
2630
2631         Reviewed by Dan Bernstein.
2632
2633         * DumpRenderTree/mac/DumpRenderTree.mm:
2634         (setDefaultsToConsistentValuesForTesting):
2635         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2636         (RequiresUserActionForPlaybackTest::SetUp):
2637         * WebKitTestRunner/TestController.cpp:
2638         (WTR::TestController::resetPreferencesToConsistentValues):
2639         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2640         (WTR::initializeWebViewConfiguration):
2641
2642 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2643
2644         Allow LOG macros to be used outside the namespace, and other logging cleanup
2645         https://bugs.webkit.org/show_bug.cgi?id=160216
2646
2647         Reviewed by Anders Carlsson.
2648         
2649         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2650
2651         * DumpRenderTree/TestRunner.cpp:
2652         * DumpRenderTree/mac/DumpRenderTree.mm:
2653         (resetWebViewToConsistentStateBeforeTesting):
2654
2655 2016-07-26  David Kilzer <ddkilzer@apple.com>
2656
2657         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2658         https://bugs.webkit.org/show_bug.cgi?id=156947
2659         <rdar://problem/23325160>
2660
2661         Reviewed by Alex Christensen.
2662
2663         * DumpRenderTree/TestRunner.cpp:
2664         (TestRunner::TestRunner):
2665         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2666         * DumpRenderTree/TestRunner.h:
2667         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2668         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2669         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2670         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2671         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2672         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2673         (WTR::TestRunner::queueNonLoadingScript):
2674         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2675         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2676         * WebKitTestRunner/TestController.cpp:
2677         (WTR::TestController::didReceiveAuthenticationChallenge):
2678         * WebKitTestRunner/TestController.h:
2679         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2680         * WebKitTestRunner/TestInvocation.cpp:
2681         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2682         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2683
2684 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2685
2686         check-for-exit-time-destructors should be usable outside Xcode
2687         <https://webkit.org/b/160195>
2688
2689         Reviewed by Darin Adler.
2690
2691         * Scripts/check-for-exit-time-destructors: Update to parse
2692         -h|--help switch, or to take one argument to a binary to check
2693         for exit time destructors on the command-line.  The clang
2694         compiler will find these at compile-time with the
2695         -Wexit-time-destructors switch, but this script will check for
2696         them after-the-fact.
2697
2698 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2699
2700         Test svn.webkit.org functionality after maintenance.
2701
2702 2016-07-25  Brady Eidson  <beidson@apple.com>
2703
2704         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2705         https://bugs.webkit.org/show_bug.cgi?id=153783
2706
2707         Reviewed by Alex Christensen.
2708
2709         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2710         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2711         
2712         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2713         
2714         Change the relevant API tests to make sure this continues to be no longer required.
2715
2716         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2717         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2718         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2719         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2720         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2721         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2722
2723 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2724
2725         Media controls should not be displayed for a video until it starts playing
2726         https://bugs.webkit.org/show_bug.cgi?id=160092
2727         <rdar://problem/26986673>
2728
2729         Reviewed by Beth Dakin.
2730
2731         Verify that multiple videos do or don't show the media controller depending on whether videos
2732         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2733         passing because we were always showing media controls for large videos with audio, even if they
2734         had not played back yet. This change ensures that large videos with audio show media controls
2735         only after they begin to play back, and not by virtue of being large enough for main content.
2736
2737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2738         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2739         (TestWebKitAPI::TEST):
2740         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2741         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2742         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2743
2744 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2745
2746         Media controls on apple.com don't disappear when movie finishes playing
2747         https://bugs.webkit.org/show_bug.cgi?id=160068
2748         <rdar://problem/26668526>
2749
2750         Reviewed by Darin Adler.
2751
2752         Adds new API tests. Please see WebCore ChangeLog for more details.
2753
2754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2755         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2756         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2757         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2758         (TestWebKitAPI::TEST):
2759         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2760         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2761         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2762         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2763         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2764
2765 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2766
2767         Unreviewed, fix test-webkitpy after r203674.
2768
2769         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2770         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2771
2772 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2773
2774         Unreviewed, forgot to commit this file in r203674.
2775
2776         * Scripts/process-linux-coredump: Added.
2777         (main):
2778
2779 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2780
2781         Improve GDB backtrace generation for GTK/EFL
2782         https://bugs.webkit.org/show_bug.cgi?id=128928
2783
2784         Reviewed by Carlos Garcia Campos.
2785
2786         The PID of the crashed process is now correctly supplied to the
2787         crash log reporter. The kernel core_pattern needs to be updated
2788         after this change to something like:
2789
2790         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2791
2792         * Scripts/process-linux-coredump: Added.
2793         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2794         * Scripts/webkitpy/port/efl.py:
2795         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2796         * Scripts/webkitpy/port/gtk.py:
2797         (GtkPort._get_crash_log): Ditto.
2798         * Scripts/webkitpy/port/linux_get_crash_log.py:
2799         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2800         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2801         (GDBCrashLogGenerator): Deleted.
2802         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2803         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2804         * WebKitTestRunner/TestController.cpp:
2805         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2806         (WTR::TestController::databaseProcessDidCrash): Ditto.
2807         (WTR::TestController::processDidCrash): Ditto.
2808
2809 2016-07-23  Youenn Fablet  <youenn@apple.com>
2810
2811         WPT stash server should be kept running when launching wpt server
2812         https://bugs.webkit.org/show_bug.cgi?id=160052
2813
2814         Reviewed by Sam Weinig.
2815
2816         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2817         (main): waiting to read stdin while stash server is started.
2818
2819 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2820
2821         Media controls should be displayed for media in media documents
2822         https://bugs.webkit.org/show_bug.cgi?id=160104
2823         <rdar://problem/27438936>
2824
2825         Reviewed by Myles C. Maxfield.
2826
2827         Verifies that even a small video with audio in a media document gets media controls.
2828
2829         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2830         (TestWebKitAPI::TEST):
2831
2832 2016-07-22  Michael Saboff  <msaboff@apple.com>
2833
2834         REGRESSION(203616): no FTL testing was inadvertently removed
2835         https://bugs.webkit.org/show_bug.cgi?id=160100
2836
2837         Rubber-stamped by Filip Pizlo.
2838
2839         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2840         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2841         logic for the runLayout and runNoisy variants to match the run test logic,
2842         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2843         enabled platforms.
2844
2845         * Scripts/run-jsc-stress-tests:
2846
2847 2016-07-22  Brady Eidson  <beidson@apple.com>
2848
2849         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2850         https://bugs.webkit.org/show_bug.cgi?id=160089
2851
2852         Reviewed by Darin Adler.
2853
2854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2855         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2856         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2857
2858 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2859
2860         [GTK] Improved exclusion patterns in make-dist.py manifest.
2861         https://bugs.webkit.org/show_bug.cgi?id=160094
2862
2863         Reviewed by Michael Catanzaro.
2864
2865         * gtk/manifest.txt.in:
2866         Exclude Platform*.cmake files for more ports.
2867         Removed obsolete .gyp and .pro.user patterns.
2868         Exclude 'Configurations' and 'spi' directories.
2869         Exclude CMakeLists.txt.user (Qt Creator IDE).
2870
2871 2016-07-22  Michael Saboff  <msaboff@apple.com>
2872
2873         Don't run FTL related JSC stress tests on non-FTL platforms
2874         https://bugs.webkit.org/show_bug.cgi?id=160033
2875
2876         Reviewed by Mark Lam.
2877
2878         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2879         Refactored several of the runXXX test methods to always runXXXDefault and made those
2880         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2881         doesn't cause a problem.
2882
2883         * Scripts/run-jsc-stress-tests:
2884
2885 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2886
2887         IWebView::mainFrame crashes if called after IWebView::close
2888         https://bugs.webkit.org/show_bug.cgi?id=32868
2889
2890         Reviewed by Brent Fulgham.
2891
2892         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2893         (TestWebKitAPI::TEST_F): Added test.
2894
2895 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2896
2897         [GTK] Enable threaded compositor by default
2898         https://bugs.webkit.org/show_bug.cgi?id=160079
2899
2900         Reviewed by Žan Doberšek.
2901
2902         * Scripts/webkitperl/FeatureList.pm:
2903
2904 2016-07-22  Youenn Fablet  <youenn@apple.com>
2905
2906         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2907         https://bugs.webkit.org/show_bug.cgi?id=159921
2908
2909         Reviewed by Brian Burg.
2910
2911         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2912
2913         * Scripts/webkitpy/codegen/main.py:
2914         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2915         (BuiltinsGeneratorTests):
2916         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2917         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2918         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2919         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2920
2921 2016-07-21  Dan Bernstein  <mitz@apple.com>
2922
2923         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2924         https://bugs.webkit.org/show_bug.cgi?id=160072
2925
2926         Reviewed by Andy Estes.
2927
2928         * Scripts/webkitdirs.pm:
2929         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2930           for old Xcode versions.
2931         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2932           to readXcodeUserDefault.
2933         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2934           debugger.
2935         (determineDebugger): Ditto.
2936         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2937           7.0.
2938         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2939           switches.
2940         (execMacWebKitAppForDebugging): Removed support for GDB.
2941
2942 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2943
2944         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2945         https://bugs.webkit.org/show_bug.cgi?id=160066
2946
2947         Reviewed by Dean Jackson.
2948
2949         * DumpRenderTree/mac/DumpRenderTree.mm:
2950         (setDefaultsToConsistentValuesForTesting): Deleted.
2951         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2952         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2953         * WebKitTestRunner/TestController.cpp:
2954         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2955         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2956         (WTR::initializeWebViewConfiguration): Deleted.
2957
2958 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2959
2960         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2961         https://bugs.webkit.org/show_bug.cgi?id=159980
2962         rdar://problem/27450825
2963
2964         Reviewed by Dan Bernstein.
2965
2966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2967         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2968         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2969         when our delegate has hit -dealloc.
2970         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2971         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2972         will not be messaged.
2973
2974 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2975
2976         Follow-up patch to r203520
2977         https://bugs.webkit.org/show_bug.cgi?id=159967
2978         <rdar://problem/26964090>
2979
2980         Unreviewed.
2981
2982         * DumpRenderTree/mac/DumpRenderTree.mm:
2983         (setDefaultsToConsistentValuesForTesting):
2984         * WebKitTestRunner/TestController.cpp:
2985         (WTR::TestController::resetPreferencesToConsistentValues):
2986
2987 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2988
2989         [iPhone] Playing a video on tudou.com plays only sound, no video
2990         https://bugs.webkit.org/show_bug.cgi?id=159967
2991         <rdar://problem/26964090>
2992
2993         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2994
2995         Migrate tests to use new SPI.
2996
2997         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2998         (RequiresUserActionForPlaybackTest::SetUp):
2999         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3000         (WTR::initializeWebViewConfiguration):
3001
3002 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
3003
3004         Clarify testing mode names in run-jsc-stress-tests
3005         https://bugs.webkit.org/show_bug.cgi?id=160021
3006
3007         Reviewed by Mark Lam.
3008
3009         Default should mean really default, not default with disabled FTL, renamed
3010         - runMozillaTestDefault to runMozillaTestNoFTL
3011         - runMozillaTestDefaultFTL to runMozillaTestDefault
3012         - runDefault to runNoFTL
3013         - runDefaultFTL to runDefault
3014         - runLayoutTestDefault to runLayoutTestNoFTL
3015         - runLayoutTestDefaultFTL to runLayoutTestDefault
3016         - runNoisyTestDefault to runNoisyTestNoFTL
3017         - runNoisyTestDefaultFTL to runNoisyTestDefault
3018
3019         * Scripts/run-jsc-stress-tests:
3020
3021 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
3022
3023         WebBackForwardList's currentIndex could get out of bounds when filtering items.
3024         https://bugs.webkit.org/show_bug.cgi?id=159986
3025
3026         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
3027         to 0.
3028
3029         Reviewed by Dan Bernstein.
3030
3031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3032         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
3033         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
3034         (TEST):
3035
3036 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3037
3038         [GTK] Web view background colors don't work in accelerated compositing mode
3039         https://bugs.webkit.org/show_bug.cgi?id=159455
3040
3041         Reviewed by Michael Catanzaro.
3042
3043         Set always RGBA visual to the view widget when setting a background color.
3044
3045         * MiniBrowser/gtk/BrowserWindow.c:
3046         (browser_window_set_background_color):
3047
3048 2016-07-20  Youenn Fablet  <youenn@apple.com>
3049
3050         Bots should run built-ins generator tests
3051         https://bugs.webkit.org/show_bug.cgi?id=159971
3052
3053         Reviewed by Alexey Proskuryakov.
3054
3055         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3056         (RunBuiltinsTests): New step to run built-in generator tests.
3057         (TestFactory.__init__): Adding an additional step for bultin generator tests.
3058         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
3060
3061 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3062
3063         Revert temporary fix r203417
3064         https://bugs.webkit.org/show_bug.cgi?id=160001
3065
3066         Reviewed by Alexey Proskuryakov.
3067
3068         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
3069
3070 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3071
3072         REGRESSION(r148588): ews classes might get garbage collected
3073         https://bugs.webkit.org/show_bug.cgi?id=159990
3074
3075         Reviewed by Ryosuke Niwa.
3076
3077         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
3078         in a variable so that they do not get garbage collected.
3079
3080 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
3081
3082         Add API test for layout constraints after exit fullscreen
3083         https://bugs.webkit.org/show_bug.cgi?id=159900
3084
3085         Reviewed by Jon Lee.
3086
3087         Added Fullscreen.LaytoutConstraints API test. 
3088         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
3089
3090         This test compares layout constraints on the web view before and after fullscreen to make sure 
3091         they are preserved.
3092
3093         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
3094         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
3095         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3096         (TestWebKitAPI::TEST):
3097
3098 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
3099
3100         Disable two failing API tests.
3101
3102         Unreviewed test gardening.
3103
3104         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
3105         (TestWebKitAPI::TEST):
3106
3107 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3108
3109         Unreviewed iOS build fix.
3110
3111         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
3112
3113 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3114
3115         Media controls don't appear when pausing a small autoplaying video
3116         https://bugs.webkit.org/show_bug.cgi?id=159972
3117         <rdar://problem/27180657>
3118
3119         Reviewed by Beth Dakin.
3120
3121         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
3122         for simulating basic user interaction in VideoControlsManager.
3123
3124         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3125         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3126         (-[WKWebView mouseDownAtPoint:]):
3127         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
3128         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
3129         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
3130         (TestWebKitAPI::TEST):
3131         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
3132
3133 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
3134
3135         [Win] MathML fonts are not found.
3136         https://bugs.webkit.org/show_bug.cgi?id=159920
3137
3138         Reviewed by Alex Christensen.
3139
3140         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
3141         for a specific registry key value.
3142
3143         * Scripts/webkitdirs.pm:
3144         (fontExists):
3145
3146 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
3147
3148         Improve prepare-ChangeLog for @media blocks
3149         https://bugs.webkit.org/show_bug.cgi?id=159907
3150
3151         Reviewed by Timothy Hatcher.
3152
3153         * Scripts/prepare-ChangeLog:
3154         (get_selector_line_ranges_for_css):
3155         Get a range for @media blocks just like a selector.
3156             Start Line = line with '{'
3157             End line = line with '}'
3158             Name = "@media ..."
3159
3160         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
3161         Improved error messages for unbalanced portions.
3162
3163         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
3164         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
3165         (.media-query::before):
3166         (@media only screen and (max-width: 980px)):
3167         (.media-query a):
3168         (@media (-webkit-min-device-pixel-ratio: 2)):
3169         (.both a):
3170         (.both b):
3171         (.media-query b):
3172         (.media-query::after):
3173
3174 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3175
3176         Fix expectedFailErrorHandler in run-jsc-stress-tests
3177         https://bugs.webkit.org/show_bug.cgi?id=159811
3178
3179         Reviewed by Yusuke Suzuki.
3180
3181         * Scripts/run-jsc-stress-tests:
3182
3183 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3184
3185         Unreviewed Mac cmake buildfix after r203426. Just for fun.
3186
3187         * TestWebKitAPI/PlatformMac.cmake:
3188
3189 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
3190
3191         The default testing mode should not involve disabling the FTL JIT
3192         https://bugs.webkit.org/show_bug.cgi?id=159929
3193
3194         Rubber stamped by Mark Lam and Saam Barati.
3195         
3196         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
3197         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
3198         FTL was not the default. You had to enable it with an option.
3199         
3200         For some reason we have kept this arrangement even though the FTL JIT is now the default on
3201         all of the major ports. This has become a serious pain. For example, it's useful to be able
3202         to say that a test should only run in the default config that is representative of what a
3203         normal user would see if they ran JSC. Clearly, this would be a config that does not
3204         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
3205         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
3206         
3207         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
3208         try to fix it, because:
3209         
3210         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
3211           have the FTL enabled never run any tests that explicitly disable the FTL, since that
3212           doesn't do anything. The code is not really structured to allow this.
3213         
3214         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
3215           disabled in testing. On the other hand there are already build bots that do FTL tests
3216           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
3217           preserving this broken feature, we should create something that (a) acknowledges the fact
3218           that the FTL is the default on those platforms that support it and (b) avoids running
3219           no-ftl tests on precisely those platforms that don't have FTL.
3220         
3221         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
3222           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
3223           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
3224           pretending that the FTL JIT is not the default just because some bots used that as an
3225           optimization.
3226         
3227         This change allows me to speed up some debug tests and paint some bots green.
3228
3229         * Scripts/run-javascriptcore-tests:
3230         (runJSCStressTests):
3231         * Scripts/run-jsc-stress-tests:
3232
3233 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3234
3235         Fix API test after r203426.
3236         https://bugs.webkit.org/show_bug.cgi?id=159949
3237
3238         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3239         (TEST):
3240         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
3241         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
3242
3243 2016-07-19  Andy Estes  <aestes@apple.com>
3244
3245         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3246         https://bugs.webkit.org/show_bug.cgi?id=159956
3247
3248         Reviewed by Dan Bernstein.
3249
3250         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
3251         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3252         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
3253         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
3254
3255 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3256
3257         Add regression test for r203392
3258         https://bugs.webkit.org/show_bug.cgi?id=159949
3259
3260         Reviewed by Brady Eidson.
3261
3262         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3263         (fileSize):
3264         (swizzledBundleIdentifierWebBookmarksD):
3265         (defaultApplicationCacheDirectory):
3266         (TEST):
3267         (swizzledBundleIdentifierMobileSafari): Deleted.
3268         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
3269         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
3270         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
3271
3272 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3273
3274         Add regression test for r203392
3275         https://bugs.webkit.org/show_bug.cgi?id=159949
3276
3277         Reviewed by Brady Eidson.
3278
3279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3280         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
3281         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
3282         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
3283         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3284         (TEST):
3285         (fileSize):
3286         (swizzledBundleIdentifierMobileSafari):
3287         (swizzledBundleIdentifierWebBookmarksD):
3288         (defaultApplicationCacheDirectory):
3289         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
3290         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
3291         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
3292         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
3293
3294 2016-07-19  Keith Miller  <keith_miller@apple.com>
3295
3296         Test262 should have a file with the revision and url
3297         https://bugs.webkit.org/show_bug.cgi?id=159937
3298
3299         Reviewed by Mark Lam.
3300
3301         The import script should update the information from
3302         the path to the test262 repository it gets.
3303
3304         * Scripts/import-test262-tests:
3305
3306 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
3307
3308         Temporary workaround for iOS EWS failing after the fix for bug 159539.
3309         To be deleted once the root cause is found and addressed.
3310
3311         * EWSTools/start-queue-mac.sh:
3312
3313 2016-07-19  Frederic Wang  <fwang@igalia.com>
3314
3315         [win] Fixup the register name for STIX Math and Latin Modern Math
3316
3317         Unreviewed follow-up of r203406
3318
3319         * Scripts/webkitdirs.pm:
3320         (checkInstalledTools):
3321
3322 2016-07-19  Frederic Wang  <fwang@igalia.com>
3323
3324         [win] Update the list of MathML fonts
3325         https://bugs.webkit.org/show_bug.cgi?id=156838
3326
3327         The set of recommended math fonts is now described at
3328         https://trac.webkit.org/wiki/MathML/Fonts
3329         We update the Perl script to use the latest list of fonts.
3330
3331         Reviewed by Brent Fulgham.
3332
3333         * Scripts/webkitdirs.pm:
3334         (checkInstalledTools):
3335
3336 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
3337
3338         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3339         https://bugs.webkit.org/show_bug.cgi?id=159342
3340
3341         Reviewed by Darin Adler.
3342
3343         Implement required functions in event sender.
3344
3345         * DumpRenderTree/PlatformWin.cmake:
3346         * DumpRenderTree/win/EventSender.cpp:
3347         (monitorWheelEvents): Added.
3348         (callAfterScrollingCompletes): Added.
3349
3350 2016-07-19  Youenn Fablet  <youenn@apple.com>
3351
3352         Add new aliases to http test server
3353         https://bugs.webkit.org/show_bug.cgi?id=159878
3354
3355         Reviewed by Darin Adler.
3356
3357         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3358         Adding explicitly these links to perl script.
3359         Extracting default alias in an aliases.json file.
3360         Reading that file from python scripts to initialize aliases from that file.
3361
3362         Python script changes covered by unit tests and changed layout test.
3363
3364         * Scripts/webkitperl/httpd.pm:
3365         (getDefaultConfigForTestDirectory): Adding 3 new aliases
3366         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3367         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3368         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3369         Adding -c directives for each alias.
3370         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3371         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3372         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3373         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3374         Adding alias directive for each alias.
3375         (Lighttpd._prepare_config):
3376         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3377         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3378         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3379         layout tests directory.
3380         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3381         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3382         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3383
3384 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
3385
3386         EWS console logs doesn't go to log file
3387         https://bugs.webkit.org/show_bug.cgi?id=159539
3388         <rdar://problem/24464570>
3389
3390         Reviewed by David Kilzer.
3391
3392         * Scripts/webkitpy/common/system/logutils.py:
3393         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3394         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3395         to filesystem. It also supports passing MockFilesystem.
3396         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3397         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3398         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3399         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3400         (_test_ews): Same.
3401         * Scripts/webkitpy/tool/commands/queues.py:
3402         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3403         (AbstractQueue._log_directory): Using filesystem object instead of os.
3404         (AbstractQueue.queue_log_path): Same.
3405         (AbstractQueue.__init__): Passed host parameter.
3406         (PatchProcessingQueue.__init__): Same.
3407         (CommitQueue.__init__): Same.
3408         (AbstractReviewQueue.__init__): Same.
3409         (StyleQueue.__init__): Same.
3410         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3411         (TestCommitQueue): Passed MockHost() as host.
3412         (TestCommitQueue.__init__): Same.
3413         (TestQueue.__init__): Same.
3414         (TestReviewQueue.__init__): Same.
3415         (TestFeederQueue.__init__): Same.
3416         (AbstractPatchQueueTest.test_next_patch): Same.
3417         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3418         (test_commit_queue_failure): Same.
3419         (MockCommitQueueTask.results_from_patch_test_run): Same.
3420         (test_rollout_lands): Same.
3421         (test_non_valid_patch): Same.
3422         (test_auto_retry): Same.
3423         (test_style_queue_with_watch_list_exception): Same.
3424
3425 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
3426
3427         WTF::Lock should be fair eventually
3428         https://bugs.webkit.org/show_bug.cgi?id=159384
3429
3430         Reviewed by Geoffrey Garen.
3431
3432         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3433
3434 2016-07-17  Sam Weinig  <sam@webkit.org>
3435
3436         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3437         <rdar://problem/26554137>
3438         https://bugs.webkit.org/show_bug.cgi?id=159856
3439
3440         Reviewed by Dan Bernstein.
3441
3442         * MiniBrowser/mac/WK2BrowserWindowController.m:
3443         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3444         Add basic window.open implementation.
3445
3446         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
3447         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
3448         to open a single non-web URL, all others are dropped.
3449
3450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3451         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
3452         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
3453         Add API for the new SPI.
3454
3455 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3456
3457         [JSC] Enable test262 module tests
3458         https://bugs.webkit.org/show_bug.cgi?id=159854
3459
3460         Reviewed by Saam Barati.
3461
3462         Use --module-file instead.
3463
3464         * Scripts/run-jsc-stress-tests:
3465
3466 2016-07-16  Chris Dumez  <cdumez@apple.com>
3467
3468         Unreviewed, rolling out r203318.
3469
3470         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
3471         SunSpider)
3472
3473         Reverted changeset:
3474
3475         "[JSC] Change some parameters based on a random search"
3476         https://bugs.webkit.org/show_bug.cgi?id=158514
3477         http://trac.webkit.org/changeset/203318
3478
3479 2016-07-16  Chris Dumez  <cdumez@apple.com>
3480
3481         Add move constructor / assignment operator to ListHashSet
3482         https://bugs.webkit.org/show_bug.cgi?id=159837
3483
3484         Reviewed by Darin Adler.
3485
3486         Add API tests.
3487
3488         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3489         (TestWebKitAPI::TEST):
3490
3491 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
3492
3493         [JSC] Change some parameters based on a random search
3494         https://bugs.webkit.org/show_bug.cgi?id=158514
3495
3496         Reviewed by Saam Barati.
3497
3498         * Scripts/run-jsc-stress-tests:
3499
3500 2016-07-15  Jon Davis  <jond@apple.com>
3501
3502         Changed the start page URL for WebKit Nightly builds.
3503         https://bugs.webkit.org/show_bug.cgi?id=159816
3504
3505         Reviewed by Timothy Hatcher.
3506
3507         * WebKitLauncher/start.html:
3508
3509 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
3510
3511         Uninitialized variable in DIBPixelData can cause a dangerous memory write
3512         https://bugs.webkit.org/show_bug.cgi?id=159414
3513
3514         Reviewed by Brent Fulgham.
3515
3516         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
3517         when the HDC parameter is invalid.
3518
3519         * TestWebKitAPI/PlatformWin.cmake:
3520         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
3521         (TestWebKitAPI::TEST):
3522
3523 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3524
3525         [GTK] Add basic tabs support to MiniBrowser
3526         https://bugs.webkit.org/show_bug.cgi?id=159803
3527
3528         Reviewed by Sergio Villar Senin.
3529
3530         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
3531         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
3532
3533         * MiniBrowser/gtk/BrowserTab.c: Added.
3534         (titleChanged):
3535         (isLoadingChanged):
3536         (decidePolicy):
3537         (removeChildIfInfoBar):
3538         (loadChanged):
3539         (createInfoBarQuestionMessage):
3540         (tlsErrorsDialogResponse):
3541         (loadFailedWithTLSerrors):
3542         (permissionRequestDialogResponse):
3543         (decidePermissionRequest):
3544         (colorChooserRGBAChanged):
3545         (popoverColorClosed):
3546         (colorChooserRequestFinished):
3547         (runColorChooserCallback):
3548         (inspectorOpenedInWindow):
3549         (inspectorClosed):
3550         (browserTabSetProperty):
3551         (browserTabFinalize):
3552         (browser_tab_init):
3553         (browserTabConstructed):
3554         (browser_tab_class_init):
3555         (getInternalURI):
3556         (browser_tab_new):
3557         (browser_tab_get_web_view):
3558         (browser_tab_load_uri):
3559         (browser_tab_get_title_widget):
3560         (browser_tab_set_status_text):
3561         (browser_tab_toggle_inspector):
3562         (browser_tab_start_search):
3563         (browser_tab_stop_search):
3564         (browser_tab_add_accelerators):
3565         (fullScreenMessageTimeoutCallback):
3566         (browser_tab_enter_fullscreen):
3567         (browser_tab_leave_fullscreen):
3568         * MiniBrowser/gtk/BrowserTab.h: Added.
3569         * MiniBrowser/gtk/BrowserWindow.c:
3570         (getExternalURI):
3571         (browserWindowSetStatusText):
3572         (reloadOrStopCallback):
3573         (goBackCallback):
3574         (goForwardCallback):
3575         (settingsCallback):
3576         (webViewURIChanged):
3577         (browserWindowHistoryItemActivated):
3578         (browserWindowUpdateNavigationActions):
3579         (webViewCreate):
3580         (webViewEnterFullScreen):
3581         (webViewLeaveFullScreen):
3582         (webViewDecidePolicy):
3583         (browserWindowCanZoomIn):
3584         (browserWindowCanZoomOut):
3585         (browserWindowZoomIn):
3586         (browserWindowZoomOut):
3587         (scrollEventCallback):
3588         (faviconChanged):
3589         (webViewIsLoadingChanged):
3590         (defaultZoomCallback):
3591         (searchCallback):
3592         (newTabCallback):
3593         (toggleWebInspector):
3594         (reloadPage):
3595         (reloadPageIgnoringCache):
3596         (stopPageLoad):
3597         (loadHomePage):
3598         (editingCommandCallback):
3599         (insertImageCommandCallback):
3600         (insertLinkCommandCallback):
3601         (browserWindowSetupEditorToolbar):
3602         (browserWindowSwitchTab):
3603         (browserWindowTabAddedOrRemoved):
3604         (browser_window_init):
3605         (browserWindowConstructed):
3606         (browserWindowSaveSession):
3607         (browserWindowDeleteEvent):
3608         (browser_window_new):
3609         (browser_window_append_view):
3610         (browser_window_load_uri):
3611         (browser_window_load_session):
3612         (browser_window_set_background_color):
3613         (resetStatusText): Deleted.
3614         (activateUriEntryCallback): Deleted.
3615         (webViewTitleChanged): Deleted.
3616         (resetEntryProgress): Deleted.
3617         (browserWindowCreateBackForwardMenu): Deleted.
3618         (webViewReadyToShow): Deleted.
3619         (webViewLoadFailed): Deleted.
3620         (webViewMouseTargetChanged): Deleted.
3621         (browserWindowUpdateZoomActions): Deleted.
3622         (webViewZoomLevelChanged): Deleted.
3623         (updateUriEntryIcon): Deleted.
3624         (zoomInCallback): Deleted.
3625         (zoomOutCallback): Deleted.
3626         (toggleFullScreen): Deleted.
3627         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3628     &nbs