Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj...
[WebKit-https.git] / Tools / ChangeLog
1 2011-03-17  Jeff Miller  <jeffm@apple.com>
2
3         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
4         
5         *.mode*
6         *.pbxuser
7         *.perspective*
8         project.xcworkspace
9         xcuserdata
10
11         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
12         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
13         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
14         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
15         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
16
17 2011-03-17  Adam Roben  <aroben@apple.com>
18
19         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
20
21         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
22         mac-wk2
23
24         Reviewed by Anders Carlsson.
25
26         * Scripts/old-run-webkit-tests:
27         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
28         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
29         we're running in WebKit2 mode.
30
31 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
32
33         Reviewed by Yury Semikhatsky.
34
35         Web Inspector: Clean up Inspector strings.
36         https://bugs.webkit.org/show_bug.cgi?id=56557
37
38         Modify the script to deal correctly with "\xNN" escapes, and to
39         check strings in Chromium's DevTools.js.
40
41         * Scripts/check-inspector-strings:
42
43 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
44
45         Reviewed by Benjamin Poulain.
46
47         Update autoinstall to install mechanize 0.2.4
48         https://bugs.webkit.org/show_bug.cgi?id=56499
49
50         Newer versions of mechanize support HTTPS proxies, which is necessary
51         for people using webkit-patch behind firewalls.
52
53         * Scripts/webkitpy/common/system/autoinstall.py:
54         * Scripts/webkitpy/thirdparty/__init__.py:
55
56 2011-03-16  Sam Weinig  <sam@webkit.org>
57
58         Reviewed by Adam Roben.
59
60         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
61         https://bugs.webkit.org/show_bug.cgi?id=56541
62
63         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
64         (WTR::InjectedBundlePage::willSendRequestForFrame):
65         Check for an empty host in addition to a null host.  This bug was introduced
66         when porting off of the KURL code and onto the WKURLRef version.
67
68 2011-03-16  Sam Weinig  <sam@webkit.org>
69
70         Reviewed by Adam Roben.
71
72         Add Lucas Forschler to the list of WebKit committers.
73
74         * Scripts/webkitpy/common/config/committers.py:
75
76 2011-03-16  Sam Weinig  <sam@webkit.org>
77
78         Reviewed upon and dictated through Adam Roben.
79
80         Escape crashing function names in results.html. This fixes an issue
81         when a crash involves a type with templates.
82
83         * Scripts/old-run-webkit-tests:
84
85 2011-03-16  Daniel Sievers  <sievers@google.com>
86
87         Reviewed by James Robinson.
88
89         Add setting to always force compositing mode
90         https://bugs.webkit.org/show_bug.cgi?id=56156
91
92         * DumpRenderTree/chromium/DumpRenderTree.cpp:
93         (main):
94         * DumpRenderTree/chromium/TestShell.cpp:
95         (TestShell::TestShell):
96         (TestShell::resetWebSettings):
97         * DumpRenderTree/chromium/TestShell.h:
98         (TestShell::setForceCompositingMode):
99         * DumpRenderTree/chromium/WebPreferences.cpp:
100         (WebPreferences::reset):
101         (WebPreferences::applyTo):
102         * DumpRenderTree/chromium/WebPreferences.h:
103
104 2011-03-15  Hayato Ito  <hayato@chromium.org>
105
106         Reviewed by Ojan Vafai.
107
108         Ignore files that will be used by reftests in old-run-webkit-tests.
109
110         https://bugs.webkit.org/show_bug.cgi?id=55936
111
112         * Scripts/old-run-webkit-tests:
113
114 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
115
116         Reviewed by Adam Roben.
117
118         Function relativeScriptsDir doesn't return the correct relative
119         Scripts directory.
120
121         * Scripts/webkitdirs.pm:
122         (relativeScriptsDir): Ensure we use the directory that contains
123         webkitdirs.pm, not the one that contains the original script that
124         was invoked.
125
126 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
127
128         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
129         fix to link against the Security framework after recent WebKitSystemInterface changes.
130
131         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
132         (LayoutTestController::originsWithLocalStorage):
133         * wx/build/settings.py:
134         * wx/build/waf_extensions.py:
135
136 2011-03-15  Sam Weinig  <sam@webkit.org>
137
138         Reviewed by Darin Adler.
139
140         Add script to convert a patch to a prettypatch and show in the default browser
141         https://bugs.webkit.org/show_bug.cgi?id=56416
142
143         This can be used either like
144             $ svn-create-patch | show-pretty-diff
145         or
146             $ show-pretty-diff patch.diff
147
148         * Scripts/show-pretty-diff: Added.
149
150 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
151
152         Rubber-stamped by Adam Roben.
153
154         Adding myself as a reviewer.
155
156         * Scripts/webkitpy/common/config/committers.py:
157
158 2011-03-15  Anders Carlsson  <andersca@apple.com>
159
160         Try to fix the Windows build.
161
162         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
163         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
164
165 2011-03-15  Anders Carlsson  <andersca@apple.com>
166
167         Reviewed by Sam Weinig.
168
169         Make sure that NP_Shutdown is always the last NPP function called
170         https://bugs.webkit.org/show_bug.cgi?id=56391
171
172         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
173
174         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
175         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
176         (PluginTest::PluginTest):
177         (PluginTest::NP_Shutdown):
178         (PluginTest::registerNPShutdownFunction):
179         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
180         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
181         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
182         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
183         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
184         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
185         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
186         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
187         (NPDeallocateCalledBeforeNPShutdown::shutdown):
188         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
189         (NP_Shutdown):
190         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
191         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
192         * GNUmakefile.am:
193
194 2011-03-15  Ilya Sherman  <isherman@chromium.org>
195
196         Reviewed by Tony Chang.
197
198         Autofilled form elements are assigned fixed background color but not text color
199         https://bugs.webkit.org/show_bug.cgi?id=48382
200
201         * DumpRenderTree/LayoutTestController.cpp:
202         (setAutofilledCallback): Added.
203         (LayoutTestController::staticFunctions):
204         * DumpRenderTree/LayoutTestController.h:
205         * DumpRenderTree/chromium/LayoutTestController.cpp:
206         (LayoutTestController::LayoutTestController):
207         (LayoutTestController::setAutofilled): Added.
208         * DumpRenderTree/chromium/LayoutTestController.h:
209         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
210         (LayoutTestController::setAutofilled): Added.
211         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
212         (LayoutTestController::setAutofilled): Added.
213         (LayoutTestController::setValueForUser): Style tweak.
214         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
215         (LayoutTestController::setAutofilled): Added (stub).
216         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
217         (LayoutTestController::setAutofilled): Added (stub).
218
219 2011-03-15  Dan Bernstein  <mitz@apple.com>
220
221         Build fix after r81135.
222
223         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
224
225 2011-03-15  Dan Bernstein  <mitz@apple.com>
226
227         Build fix after r81135.
228
229         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
230         * WebKitTestRunner/mac/TestControllerMac.mm:
231         * WebKitTestRunner/mac/TestInvocationMac.mm:
232         * WebKitTestRunner/mac/main.mm:
233
234 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
235
236         Reviewed by Adam Barth.
237
238         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
239         https://bugs.webkit.org/show_bug.cgi?id=56349
240
241         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
242         on platforms where we use it. Copied from DumpRenderTree.pro.
243
244 2011-03-15  Dan Bernstein  <mitz@apple.com>
245
246         Build fix after r81135.
247
248         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
249         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
250
251 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
252
253         Reviewed by Darin Adler.
254
255         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
256         info into the headers rather than in export symbol definition files, but disable it on 
257         all platforms initially so we can deal with port build issues one port at a time.
258         
259         https://bugs.webkit.org/show_bug.cgi?id=27551
260
261         * DumpRenderTree/cg/ImageDiffCG.cpp:
262         * DumpRenderTree/chromium/config.h:
263         * DumpRenderTree/config.h:
264         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
265         * TestWebKitAPI/TestWebKitAPIPrefix.h:
266         * WebKitAPITest/HostWindow.cpp:
267         * WebKitAPITest/TestsController.cpp:
268         * WebKitAPITest/config.h: Added.
269         * WebKitAPITest/main.cpp:
270         * WebKitAPITest/tests/WebViewDestruction.cpp:
271         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
272         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
273         * WebKitTestRunner/InjectedBundle/GCController.cpp:
274         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
275         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
276         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
277         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
278         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
279         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
280         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
281         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
282         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
283         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
284         * WebKitTestRunner/TestController.cpp:
285         * WebKitTestRunner/TestInvocation.cpp:
286         * WebKitTestRunner/config.h: Added.
287         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
288         * WebKitTestRunner/qt/TestControllerQt.cpp:
289         * WebKitTestRunner/qt/TestInvocationQt.cpp:
290         * WebKitTestRunner/qt/main.cpp:
291         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
292         * WebKitTestRunner/win/TestControllerWin.cpp:
293         * WebKitTestRunner/win/TestInvocationWin.cpp:
294         * WebKitTestRunner/win/main.cpp:
295         * wx/build/settings.py:
296
297 2011-03-15  Hayato Ito  <hayato@chromium.org>
298
299         Reviewed by Shinichiro Hamaji.
300
301         [NRWT] Add support for reftests to new-run-webkit-tests.
302
303         https://bugs.webkit.org/show_bug.cgi?id=55457
304
305         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
306         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
307         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
308         * Scripts/webkitpy/layout_tests/port/base.py:
309         * Scripts/webkitpy/layout_tests/port/dryrun.py:
310         * Scripts/webkitpy/layout_tests/port/test.py:
311         * Scripts/webkitpy/layout_tests/port/test_files.py:
312         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
313
314 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
315
316         Reviewed by Martin Robinson.
317
318         [GTK] Fix compilation warning after r80892
319         https://bugs.webkit.org/show_bug.cgi?id=56302
320
321         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
322         (LayoutTestController::originsWithLocalStorage):
323
324 2011-03-15  Robert Hogan  <robert@webkit.org>
325
326         Reviewed by Adam Barth.
327
328         Document the qmakearg argument, and hint how to build webkit2 on Qt
329         https://bugs.webkit.org/show_bug.cgi?id=56326
330
331         * Scripts/build-webkit: add --qmakearg to build-webkit --help
332
333 2011-03-15  Adam Roben  <aroben@apple.com>
334
335         Make Windows 7 Release (Tests) a core builder
336
337         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
338         give it a few more days of greenness first.
339
340         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
341
342         Reviewed by Sam Weinig.
343
344         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
345         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
346
347         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
348         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
349         Updated the core regexps to match the buildbot module. Updated the expected results to match
350         the current set of core builders.
351
352 2011-03-14  Adam Roben  <aroben@apple.com>
353
354         Add forgotten file from r81116
355
356         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
357
358 2011-03-14  Sam Weinig  <sam@webkit.org>
359
360         Reviewed by Adam Roben.
361
362         about:blank fake responses don't get serialized when sent the UIProcess
363         <rdar://problem/9108119>
364         https://bugs.webkit.org/show_bug.cgi?id=56357
365
366         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
367         (TestWebKitAPI::decidePolicyForResponse):
368         (TestWebKitAPI::TEST):
369         Add test that loads of about:blank have a response with a MIMEType of text/html.
370
371         * TestWebKitAPI/PlatformUtilities.h:
372         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
373         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
374         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
375         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
376         Add helper to get the MIMEType from a WKURLResponse.
377
378         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
379         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
380         Add new files.
381
382 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
383
384         Reviewed by Kenneth Rohde Christiansen.
385
386         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
387         https://bugs.webkit.org/show_bug.cgi?id=56006
388
389         * QtTestBrowser/launcherwindow.cpp:
390         (LauncherWindow::initializeView):
391         * QtTestBrowser/main.cpp:
392         (LauncherApplication::handleUserOptions):
393
394 2011-03-14  James Kozianski  <koz@chromium.org>
395
396         Reviewed by Ojan Vafai.
397
398         Add method to make BuildBot return test outputs
399         https://bugs.webkit.org/show_bug.cgi?id=54374
400
401         The Builder.latest_cached_build will be used by the new rebaseline
402         script to determine the build to use baselines from.
403
404         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
405         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
406
407 2011-03-14  Adam Roben  <aroben@apple.com>
408
409         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
410
411         Reviewed by Sam Weinig.
412
413         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
414         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
415         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
416         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
417         ensure the web process is initialized, then ask the bundle to run the test and assert that
418         it succeeded.
419
420         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
421         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
422         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
423         handle a given URL.
424         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
425         URL type cannot be handled).
426         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
427         result.
428
429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
430         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
431         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
432         Added new files to the project.
433
434 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
435
436         Unreviewed, rolling out r81094.
437         http://trac.webkit.org/changeset/81094
438         https://bugs.webkit.org/show_bug.cgi?id=56355
439
440         Broke the chromium DRT related build. (Requested by dave_levin
441         on #webkit).
442
443         * DumpRenderTree/chromium/DumpRenderTree.cpp:
444         (main):
445         * DumpRenderTree/chromium/LayoutTestController.cpp:
446         (LayoutTestController::LayoutTestController):
447         (LayoutTestController::layerTreeAsText):
448         * DumpRenderTree/chromium/LayoutTestController.h:
449         * DumpRenderTree/chromium/TestShell.cpp:
450         (TestShell::runFileTest):
451         (TestShell::dump):
452         * DumpRenderTree/chromium/TestShell.h:
453         (TestParams::TestParams):
454
455 2011-03-14  Daniel Sievers  <sievers@google.com>
456
457         Reviewed by Simon Fraser.
458
459         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
460         https://bugs.webkit.org/show_bug.cgi?id=56139
461
462         * DumpRenderTree/chromium/DumpRenderTree.cpp:
463         (main):
464         * DumpRenderTree/chromium/LayoutTestController.cpp:
465         (LayoutTestController::LayoutTestController):
466         (LayoutTestController::layerTreeAsText):
467         * DumpRenderTree/chromium/LayoutTestController.h:
468         (LayoutTestController::setShowDebugLayerTree):
469         * DumpRenderTree/chromium/TestShell.cpp:
470         (TestShell::runFileTest):
471         (TestShell::dump):
472         * DumpRenderTree/chromium/TestShell.h:
473         (TestParams::TestParams):
474
475 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
476
477         Reviewed by Adam Roben.
478
479         [Qt][WK2]Unbreak InjectedBundle on Qt
480         https://bugs.webkit.org/show_bug.cgi?id=54109
481
482         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
483         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
484         API's instead of KURL to analyze the URL.
485         * WebKitTestRunner/StringFunctions.h:
486         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
487         in the WebKitTestRunner project.
488         (WTR::toWK): Use adoptWK.
489         (WTR::operator<<): Added helper for printing a WKURL.
490         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
491         against WebCore.
492
493 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
494
495         Reviewed by Kenneth Rohde Christiansen.
496
497         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
498         https://bugs.webkit.org/show_bug.cgi?id=56321
499
500         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
501         to the list of exceptions for WebKit2 C API headers.
502
503 2011-03-14  Adam Roben  <aroben@apple.com>
504
505         Show the list of recent leaky builds in reverse chronological order
506
507         Previously they were being shown in a deterministic but surprising order based on
508         lexicographically sorting the build offsets (-1, -10, -2, -3...).
509
510         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
511
512         Reviewed by Darin Adler.
513
514         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
515         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
516         callback.
517
518 2011-03-14  Adam Roben  <aroben@apple.com>
519
520         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
521
522         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
523         analyze
524
525         Reviewed by David Kilzer and Joe Pecoraro.
526
527         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
528         (#url-prompt): Made this a bit taller to make room for the list of builds.
529
530         (#recent-builds-loading-indicator):
531         (#recent-builds-list):
532         Added styles for the build list and loading indicator.
533
534         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
535         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
536         it. This will unescape it.
537         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
538         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
539         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
540         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
541         prompt UI.
542         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
543         now also used when a recent build is clicked.
544
545         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
546         (RecentBuildsLoader): Store the callback.
547         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
548         builder. Find the revision number, leak count, and results URL for each one. Pass the
549         resulting info to our callback.
550
551         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
552         (range): Added this helper function to return an array containing the integers [0, n).
553
554         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
555         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
556
557 2011-03-14  Mark Rowe  <mrowe@apple.com>
558
559         Reviewed by Adam Roben.
560
561         Fix two memory leaks within LayoutTestController's storage support.
562
563         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
564         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
565         by JSStringCreateWithCFString.
566         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
567         allocate.
568
569 2011-03-14  Mark Rowe  <mrowe@apple.com>
570
571         Reviewed by Oliver Hunt.
572
573         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
574
575         * DumpRenderTree/LayoutTestController.cpp:
576         (LayoutTestController::staticFunctions): Remove duplicate entries.
577
578 2011-03-14  Alice Liu  <alice.liu@apple.com>
579
580         Reviewed by Dan Bernstein.
581
582         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
583
584         * DumpRenderTree/mac/PerlSupport/Makefile:
585         Add whitespace when joining "-arch" with the architectures passed in as arguments.
586
587 2011-03-14  Daniel Bates  <dbates@rim.com>
588
589         https://bugs.webkit.org/show_bug.cgi?id=55438
590         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
591         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
592
593         * Scripts/build-webkit:
594
595 2011-03-14  Daniel Bates  <dbates@rim.com>
596
597         Reviewed by David Kilzer.
598
599         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
600         https://bugs.webkit.org/show_bug.cgi?id=55438
601
602         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
603         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
604         CMake arguments for feature defines.
605
606         * Scripts/build-webkit:
607           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
608           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
609           - Sorted forward declarations.
610           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
611             Modified call sites as needed.
612         * Scripts/webkitdirs.pm:
613           - Added cleanCMakeGeneratedProject() to clean a CMake build.
614           - Added buildCMakeGeneratedProject() to build using generated build system.
615           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
616           - Added generateBuildSystemFromCMakeProject() to generate the build system from
617             a CMake project.
618           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
619
620 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
621
622         Reviewed by Steve Block.
623
624         Detach Geolocation from Frame when Page destroyed.
625         https://bugs.webkit.org/show_bug.cgi?id=52877
626
627         Extend the layout test controller to expose the number of pending
628         geolocation requests, so that we can test that the requests have
629         been cancelled on page close.
630
631         * DumpRenderTree/LayoutTestController.cpp:
632         (numberOfPendingGeolocationPermissionRequestsCallback):
633         (LayoutTestController::staticFunctions):
634         * DumpRenderTree/LayoutTestController.h:
635         * DumpRenderTree/chromium/LayoutTestController.cpp:
636         (LayoutTestController::LayoutTestController):
637         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
638         * DumpRenderTree/chromium/LayoutTestController.h:
639         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
640         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
641         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
642         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
643         * DumpRenderTree/mac/UIDelegate.h:
644         * DumpRenderTree/mac/UIDelegate.mm:
645         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
646         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
647         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
648         * DumpRenderTree/qt/LayoutTestControllerQt.h:
649         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
650         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
651         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
652         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
653
654
655 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
656
657         Unreviewed. Modify my email address in committers.py.
658
659         * Scripts/webkitpy/common/config/committers.py:
660
661 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
662
663         Reviewed by Kenneth Rohde Christiansen.
664
665         [Qt] QtLauncher does not load the same set of fonts as the DRT
666         https://bugs.webkit.org/show_bug.cgi?id=34959
667
668         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
669         When this option is used the webkit fonts are loaded the same
670         as they are in DumpRenderTree.  This option can be used on
671         QtTestBrowser and run-launcher.  It can only be used
672         on Linux systems with FcInit and is configured as such.
673
674         * QtTestBrowser/launcherwindow.h:
675         (WindowOptions::WindowOptions):
676         * QtTestBrowser/main.cpp:
677         (initWebKitTestFonts):
678         (launcherMain):
679         (LauncherApplication::handleUserOptions):
680
681 2011-03-12  Dan Bernstein  <mitz@apple.com>
682
683         Reviewed by Mark Rowe.
684
685         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
686         DumpRenderTree is being built for.
687
688         * DumpRenderTree/mac/PerlSupport/Makefile:
689
690 2011-03-12  Dan Bernstein  <mitz@apple.com>
691
692         Suggested by Mark Rowe.
693
694         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
695         as they were before r80915.
696
697 2011-03-12  Anders Carlsson  <andersca@apple.com>
698
699         Reviewed by Sam Weinig.
700
701         Should be able to download a PDF to the Downloads folder
702         https://bugs.webkit.org/show_bug.cgi?id=56256
703
704         * MiniBrowser/mac/BrowserWindowController.m:
705         (-[BrowserWindowController awakeFromNib]):
706         * WebKitTestRunner/TestController.cpp:
707         (WTR::TestController::createOtherPage):
708         (WTR::TestController::initialize):
709         Update for API changes.
710
711 2011-03-11  Anton D'Auria  <adauria@apple.com>
712
713         Reviewed and landed by Brady Eidson.
714
715         https://bugs.webkit.org/show_bug.cgi?id=51878
716         Add WebKit1 API to view and delete local storage
717
718         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
719
720         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
721         * DumpRenderTree/LayoutTestController.cpp:
722         (syncLocalStorageCallback):
723         (observeStorageTrackerNotificationsCallback):
724         (deleteAllLocalStorageCallback):
725         (deleteLocalStorageForOriginCallback):
726         (originsWithLocalStorageCallback):
727         (LayoutTestController::staticFunctions):
728         * DumpRenderTree/LayoutTestController.h:
729         * DumpRenderTree/StorageTrackerDelegate.h: Added.
730         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
731         (-[StorageTrackerDelegate init]):
732         (-[StorageTrackerDelegate logNotifications:controller:]):
733         (-[StorageTrackerDelegate originModified:]):
734         (-[StorageTrackerDelegate dealloc]):
735         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
736         * DumpRenderTree/chromium/LayoutTestController.cpp:
737         (LayoutTestController::LayoutTestController):
738         (LayoutTestController::deleteAllLocalStorage):
739         (LayoutTestController::originsWithLocalStorage):
740         (LayoutTestController::deleteLocalStorageForOrigin):
741         (observeStorageTrackerNotifications):
742         (syncLocalStorage):
743         * DumpRenderTree/chromium/LayoutTestController.h:
744         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
745         (LayoutTestController::originsWithLocalStorage):
746         (LayoutTestController::deleteAllLocalStorage):
747         (LayoutTestController::deleteLocalStorageForOrigin):
748         (LayoutTestController::observeStorageTrackerNotifications):
749         (LayoutTestController::syncLocalStorage):
750         * DumpRenderTree/mac/DumpRenderTree.mm:
751         (resetDefaultsToConsistentValues):
752         (allocateGlobalControllers):
753         (releaseGlobalControllers):
754         * DumpRenderTree/mac/DumpRenderTreeMac.h:
755         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
756         (LayoutTestController::syncLocalStorage):
757         (LayoutTestController::observeStorageTrackerNotifications):
758         (LayoutTestController::deleteAllLocalStorage):
759         (LayoutTestController::originsWithLocalStorage):
760         (LayoutTestController::deleteLocalStorageForOrigin):
761         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
762         (LayoutTestController::originsWithLocalStorage):
763         (LayoutTestController::deleteAllLocalStorage):
764         (LayoutTestController::deleteLocalStorageForOrigin):
765         (LayoutTestController::observeStorageTrackerNotifications):
766         (LayoutTestController::syncLocalStorage):
767         * DumpRenderTree/qt/LayoutTestControllerQt.h:
768         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
769         (LayoutTestController::clearAllApplicationCaches):
770         (LayoutTestController::syncLocalStorage):
771         (LayoutTestController::observeStorageTrackerNotifications):
772         (LayoutTestController::clearAllDatabases):
773         (LayoutTestController::deleteAllLocalStorage):
774         (LayoutTestController::originsWithLocalStorage):
775         (LayoutTestController::deleteLocalStorageForOrigin):
776         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
777         (LayoutTestController::syncLocalStorage):
778         (LayoutTestController::observeStorageTrackerNotifications):
779         (LayoutTestController::clearAllDatabases):
780         (LayoutTestController::deleteAllLocalStorage):
781         (LayoutTestController::originsWithLocalStorage):
782         (LayoutTestController::deleteLocalStorageForOrigin):
783
784 2011-03-11  Jessie Berlin  <jberlin@apple.com>
785
786         Reviewed by Adam Roben.
787
788         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
789         Process has finished launching.
790         https://bugs.webkit.org/show_bug.cgi?id=56208
791
792         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
793         (TestWebKitAPI::TEST):
794         Test that calling WKContextClearResourceCaches works with both options when called before
795         the Web Process is valid.
796
797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
798         Add the new test.
799         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
800         Ditto.
801
802 2011-03-11  Adam Roben  <aroben@apple.com>
803
804         Make it possible to view all leaks from a build at once in Leaks Viewer
805
806         You can now give Leaks Viewer the URL of a build results page (e.g.,
807         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
808         will load all the leaks files from that build.
809
810         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
811         files from a particular build at once, rather than one at a time
812
813         Reviewed by David Kilzer.
814
815         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
816         (LeaksLoader): Initialize our properties.
817         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
818         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
819         from that page.
820         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
821         so it can provide feedback. Then load each one and pass it to the client.
822         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
823         it into a DOM, pull out all the links to leaks files, and load each one.
824
825         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
826         (LeaksParser): Initialize our worker.
827         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
828
829         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
830         This code mostly came from Worker.js.
831         (LeaksParserWorker): Initialize our profile.
832         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
833         profile.
834         (LeaksParserWorker.prototype._parseLeaks):
835         (LeaksParserWorker.prototype._createNode):
836         (LeaksParserWorker.prototype._incorporateLeaks):
837         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
838         version of createProfile which adds to this.profile instead of making a new profile each
839         time.
840         (onmessage): Parse the file and send back the new profile.
841
842         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
843         (#loading-indicator):
844         (#spinner):
845         (#loading-indicator-label):
846         Tweaked styles to accomodate a longer label.
847
848         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
849         (LeaksViewer.loaded): Set up a loader and parser.
850
851         (LeaksViewer.get filesLeftToParse):
852         (LeaksViewer.set filesLeftToParse):
853         Added these simple accessors.
854
855         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
856         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
857         the parser.
858         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
859         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
860         _loadLeaksFromURL function).
861         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
862         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
863         loading indicator, including the number of files being loaded.
864         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
865         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
866         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
867         _loadingIndicatorText.
868
869         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
870         (getResource): Moved here from LeaksViewer.js.
871
872         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
873         LeaksParserWorker.js.
874
875         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
876         files, added a #loading-indicator-label element, and tweaked the prompt wording.
877
878 2011-03-11  Adam Roben  <aroben@apple.com>
879
880         Don't trigger a build when build.webkit.org's HTML files are modified
881
882         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
883
884         Reviewed by Dan Bernstein.
885
886         * Scripts/webkitpy/common/config/build.py:
887         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
888         directories that shouldn't trigger builds. Re-sorted the list.
889
890         * Scripts/webkitpy/common/config/build_unittest.py:
891         (ShouldBuildTest): Added a test to cover the above change.
892
893 2011-03-11  Adam Roben  <aroben@apple.com>
894
895         Roll out r80848
896
897         It was accidentally committed.
898
899         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
900         (LeaksViewer._loadLeaksFromURL):
901
902 2011-03-11  Tony Chang  <tony@chromium.org>
903
904         Reviewed by Ojan Vafai.
905
906         kill hung lighttpd processes on the chromium win bot
907         https://bugs.webkit.org/show_bug.cgi?id=56152
908
909         Sometimes this process doesn't exit and it holds on to
910         a log file that we can't delete or copy, causing the tests
911         to go red.
912
913         * BuildSlaveSupport/win/kill-old-processes:
914
915 2011-03-11  Ilya Sherman  <isherman@chromium.org>
916
917         Reviewed by Kent Tamura.
918
919         [Chromium] missing HTMLInputElement::setValueForUser() to tests
920         https://bugs.webkit.org/show_bug.cgi?id=55854
921
922         * DumpRenderTree/chromium/LayoutTestController.cpp:
923         (LayoutTestController::LayoutTestController):
924         (LayoutTestController::setValueForUser): Added.
925         * DumpRenderTree/chromium/LayoutTestController.h:
926
927 2011-03-10  Peter Kasting  <pkasting@google.com>
928
929         Reviewed by Dimitri Glazkov.
930
931         Clean up some gross code in TestShellWin.cpp.  No functional change.
932         https://bugs.webkit.org/show_bug.cgi?id=56048
933
934         * DumpRenderTree/chromium/TestShellWin.cpp:
935         (checkLayoutTestSystemDependencies):
936
937 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
938
939         Reviewed by Laszlo Gombos.
940
941         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
942
943         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
944         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
945
946 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
947
948         Reviewed by Kenneth Rohde Christiansen.
949
950         [EFL] Make single backing store the default for EWebLauncher
951         https://bugs.webkit.org/show_bug.cgi?id=55753
952
953         Set single backing store the default for EWebLauncher.
954
955         * EWebLauncher/main.c:
956         (main):
957
958 2011-03-10  Adam Roben  <aroben@apple.com>
959
960         Ignore errors from files being held open when creating a test result archive
961
962         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
963         fails to delete the results directory
964
965         Reviewed by Mark Rowe.
966
967         * BuildSlaveSupport/test-result-archive:
968         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
969         thrown when a process is holding a file open.
970
971 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
972
973         Unreviewed, rolling out r80701.
974         http://trac.webkit.org/changeset/80701
975         https://bugs.webkit.org/show_bug.cgi?id=56126
976
977         fast/dom/Geolocation/window-close-crash.html fails on Snow
978         Leopard release builds (Requested by mihaip on #webkit).
979
980         * DumpRenderTree/LayoutTestController.cpp:
981         (LayoutTestController::staticFunctions):
982         * DumpRenderTree/LayoutTestController.h:
983         * DumpRenderTree/chromium/LayoutTestController.cpp:
984         (LayoutTestController::LayoutTestController):
985         * DumpRenderTree/chromium/LayoutTestController.h:
986         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
987         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
988         * DumpRenderTree/mac/UIDelegate.h:
989         * DumpRenderTree/mac/UIDelegate.mm:
990         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
991         * DumpRenderTree/qt/LayoutTestControllerQt.h:
992         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
993         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
994
995 2011-03-10  Philippe Normand  <pnormand@igalia.com>
996
997         Reviewed by Gustavo Noronha Silva.
998
999         [GTK] run-gtk-tests doesn't fail if a test crashes
1000         https://bugs.webkit.org/show_bug.cgi?id=56089
1001
1002         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
1003         even if a test crashes. So run the tests individually and if a
1004         test fails remember its exit code so run-gtk-test fails too, if
1005         required.
1006
1007 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
1008
1009         Reviewed by Dmitry Titov.
1010
1011         Detach Geolocation from Frame when Page destroyed.
1012         https://bugs.webkit.org/show_bug.cgi?id=52877
1013
1014         Extend the layout test controller to expose the number of pending
1015         geolocation requests, so that we can test that the requests have
1016         been cancelled on page close.
1017
1018         * DumpRenderTree/LayoutTestController.cpp:
1019         (numberOfPendingGeolocationPermissionRequestsCallback):
1020         (LayoutTestController::staticFunctions):
1021         * DumpRenderTree/LayoutTestController.h:
1022         * DumpRenderTree/chromium/LayoutTestController.cpp:
1023         (LayoutTestController::LayoutTestController):
1024         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1025         * DumpRenderTree/chromium/LayoutTestController.h:
1026         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1027         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1028         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1029         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1030         * DumpRenderTree/mac/UIDelegate.h:
1031         * DumpRenderTree/mac/UIDelegate.mm:
1032         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1033         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1034         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1035         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1036         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1037         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1038         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1039         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1040
1041
1042 2011-03-09  Adam Roben  <aroben@apple.com>
1043
1044         Hide Leaks Viewer's URL prompt by default
1045
1046         We will show it as needed. I think I left it visible by default by accident after doing some
1047         testing.
1048
1049         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
1050         URL is passed as a query parameter, but does
1051
1052         Reviewed by Simon Fraser.
1053
1054         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1055
1056 2011-03-09  Adam Roben  <aroben@apple.com>
1057
1058         Don't use Element.classList or box-shadow in Leaks Viewer
1059
1060         They aren't supported by Safari 5. Luckily we have substitutes for them!
1061
1062         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
1063
1064         Reviewed by Simon Fraser.
1065
1066         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1067         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
1068
1069         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1070         (LeaksViewer.urlPromptButtonClicked):
1071         (LeaksViewer._displayURLPrompt):
1072         (LeaksViewer._setLoadingIndicatorHidden):
1073         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
1074
1075 2011-03-09  Adam Roben  <aroben@apple.com>
1076
1077         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
1078
1079         Rubber-stamped by David Kilzer.
1080
1081         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1082
1083 2011-03-09  Adam Roben  <aroben@apple.com>
1084
1085         Add a Leaks Viewer tool to build.webkit.org
1086
1087         This tool parses leaks from the files generated by the leaks bot and displays them in a
1088         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
1089         code).
1090
1091         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
1092         be passed to the tool via the "url" query parameter.
1093
1094         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
1095         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
1096         Inspector's Heavy profile view. But it's still pretty useful as-is.
1097
1098         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
1099
1100         Reviewed by Darin Adler.
1101
1102         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
1103         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
1104         (#url-prompt): This is the prompt itself.
1105
1106         (#loading-indicator):
1107         (#loading-indicator > img):
1108         These show a spinner in the bottom-right when we're loading a leaks file.
1109
1110         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
1111         as percentages.
1112
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
1114         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
1115         URL if one wasn't given to us as a query parameter).
1116
1117         (LeaksViewer.get loading):
1118         (LeaksViewer.set loading):
1119         (LeaksViewer.get url):
1120         (LeaksViewer.set url):
1121         Pretty simple accessors.
1122
1123         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
1124         prompt.
1125         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
1126         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
1127         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
1128         the profile to the Web Inspector code once it's been created.
1129         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
1130         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
1131         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
1132         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
1133
1134         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
1135         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
1136         (ProfilerAgent.getProfile): Store the callback.
1137         (ProfilerAgent.profileReady): Call the callback.
1138         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
1139         count and total leak counts as real values, not percentages or milliseconds.
1140
1141         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
1142         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
1143         (parseLeaks): Extract call stacks out of a leaks file.
1144         (createNode): Helper function to create a new empty profile node.
1145         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
1146         WebInspector.ProfileView.
1147
1148         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
1149
1150 2011-03-09  Dan Bernstein  <mitz@apple.com>
1151
1152         Reviewed by Adam Roben.
1153
1154         Combine multiple --ignore-tests values
1155         https://bugs.webkit.org/show_bug.cgi?id=56016
1156
1157         * Scripts/old-run-webkit-tests:
1158
1159 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
1160
1161         Reviewed by David Levin.
1162
1163         Adding myself to the committer file.
1164
1165         * Scripts/webkitpy/common/config/committers.py:
1166
1167 2011-03-08  Jessie Berlin  <jberlin@apple.com>
1168
1169         Rubber-stamped by Adam Roben.
1170
1171         Fix two leaks I introduced into the API tests.
1172
1173         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1174         (TestWebKitAPI::TEST):
1175
1176 2011-03-08  Jessie Berlin  <jberlin@apple.com>
1177
1178         Reviewed by Anders Carlsson.
1179
1180         Crash in CFNetwork visiting google.com
1181         https://bugs.webkit.org/show_bug.cgi?id=55958
1182
1183         Add a test for not trying to copy a null CFURLResponse.
1184
1185         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
1186         (TestWebKitAPI::TEST):
1187         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1188
1189 2011-03-08  Hayato Ito  <hayato@chromium.org>
1190
1191         Reviewed by Ojan Vafai.
1192
1193         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
1194
1195         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
1196
1197         https://bugs.webkit.org/show_bug.cgi?id=55450
1198
1199         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1200
1201 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         Reviewed by Martin Robinson.
1204
1205         [GTK] Add layoutTestController.setValueForUser() after r80412
1206         https://bugs.webkit.org/show_bug.cgi?id=55862
1207
1208         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1209         (LayoutTestController::setValueForUser): Implement setValueForUser()
1210
1211 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
1212
1213         Reviewed by Adam Barth.
1214
1215         Add script_shell_command to WebKitPort
1216         https://bugs.webkit.org/show_bug.cgi?id=55925
1217
1218         Add a central place where we generate the shell command from the script name.
1219         This function will be used later to detect the correct script interpreter on Win32.
1220
1221         * Scripts/webkitpy/common/config/ports.py:
1222         * Scripts/webkitpy/layout_tests/port/base.py:
1223         * Scripts/webkitpy/tool/steps/abstractstep.py:
1224         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1225
1226 2011-03-07  Ojan Vafai  <ojan@chromium.org>
1227
1228         Reviewed by Adam Barth.
1229
1230         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
1231         https://bugs.webkit.org/show_bug.cgi?id=55749
1232
1233         * Scripts/webkitpy/tool/commands/upload.py:
1234         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1235         * Scripts/webkitpy/tool/steps/__init__.py:
1236         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
1237         * Scripts/webkitpy/tool/steps/options.py:
1238
1239 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1240
1241         Reviewed by David Levin.
1242
1243         Add support for DataTransferItems
1244         https://bugs.webkit.org/show_bug.cgi?id=55115
1245
1246         Enable data transfer items in DRT.
1247
1248         * DumpRenderTree/chromium/TestShell.cpp:
1249         (TestShell::TestShell):
1250
1251 2011-03-06  Ojan Vafai  <ojan@chromium.org>
1252
1253         Reviewed by Tony Chang.
1254
1255         [test dashboard] pull treemap files
1256         https://bugs.webkit.org/show_bug.cgi?id=55852
1257
1258         * TestResultServer/handlers/dashboardhandler.py:
1259
1260 2011-03-03  Hayato Ito  <hayato@chromium.org>
1261
1262         Reviewed by Mihai Parparita.
1263
1264         [NRWT] Clear output image file used by DumpRenderTree to make sure the
1265         previous image should not be used in the ChromiumDriver.
1266
1267         Also make sure that output image from the ChromiumDriver should be ''
1268         (empty string) if a test crashes for consistency with the WebKitDriver
1269         implementation.
1270
1271         https://bugs.webkit.org/show_bug.cgi?id=55746
1272
1273         * Scripts/webkitpy/layout_tests/port/chromium.py:
1274
1275 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
1276
1277         Reviewed by Martin Robinson.
1278
1279         [Gtk] fast/js/navigator-language.html fails locally
1280         https://bugs.webkit.org/show_bug.cgi?id=55880
1281
1282         Add LANG variable to the clean environment when running
1283         old-run-webkit-tests script.
1284
1285         * Scripts/old-run-webkit-tests:
1286
1287 2011-03-07  Tony Chang  <tony@chromium.org>
1288
1289         Reviewed by Mihai Parparita.
1290
1291         [Chromium] Find .checksum files without .pngs and vice-versa
1292         https://bugs.webkit.org/show_bug.cgi?id=55236
1293
1294         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
1295             mismatched results.
1296
1297 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1298
1299         Reviewed by Beth Dakin.
1300
1301         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
1302         https://bugs.webkit.org/show_bug.cgi?id=55706
1303
1304         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
1305
1306         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1307         (AccessibilityController::focusedElement):
1308            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
1309            because it could change at any time.
1310         (AccessibilityController::rootElement):
1311
1312 2011-03-07  Sam Weinig  <sam@webkit.org>
1313
1314         Reviewed by Anders Carlsson.
1315
1316         Add unableToImplementPolicy callback for WebKit2 policy client
1317         <rdar://problem/9071902>
1318         https://bugs.webkit.org/show_bug.cgi?id=55884
1319
1320         * MiniBrowser/mac/BrowserWindowController.m:
1321         (-[BrowserWindowController awakeFromNib]):
1322         Update policy client initialization struct for new member.
1323
1324 2011-03-07  Sam Weinig  <sam@webkit.org>
1325
1326         Reviewed by Anders Carlsson.
1327
1328         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1329         https://bugs.webkit.org/show_bug.cgi?id=55827
1330
1331         * MiniBrowser/mac/BrowserWindowController.m:
1332         (decidePolicyForResponse):
1333         (-[BrowserWindowController awakeFromNib]):
1334         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1335         (TestWebKitAPI::decidePolicyForResponse):
1336         (TestWebKitAPI::TEST):
1337         Update tools for new name.
1338
1339 2011-03-06  Daniel Bates  <dbates@rim.com>
1340
1341         Reviewed by Eric Seidel and David Kilzer.
1342
1343         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
1344         https://bugs.webkit.org/show_bug.cgi?id=55503
1345
1346         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
1347         in checkForJavaSDK().
1348
1349         Also, remove extraneous space in function prototype for unlinkZeroFiles.
1350
1351         * Scripts/build-webkit:
1352
1353 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
1354
1355         Reviewed by Sam Weinig.
1356
1357         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
1358
1359         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1360         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
1361             by willSendRequestForFrame. The API expects a retained reference to the URL request.
1362
1363 2011-03-05  Ilya Sherman  <isherman@chromium.org>
1364
1365         Reviewed by Darin Adler.
1366
1367         HTMLInputElement::setValue() should schedule change event when the element is focused
1368         In service of https://code.google.com/p/chromium/issues/detail?id=42716
1369         https://bugs.webkit.org/show_bug.cgi?id=53160
1370
1371         * DumpRenderTree/LayoutTestController.cpp:
1372         (setValueForUserCallback):
1373         (LayoutTestController::staticFunctions):
1374         * DumpRenderTree/LayoutTestController.h:
1375         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1376         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1377         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1378         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
1379         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1380         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1381         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1382         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1383         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1384         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
1385
1386 2011-03-04  Mark Rowe  <mrowe@apple.com>
1387
1388         Reviewed by Alexey Proskuryakov.
1389
1390         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
1391
1392         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
1393         
1394         * DumpRenderTree/mac/CheckedMalloc.cpp:
1395         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
1396         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
1397         and then restore the initial protection flags when we're done.
1398
1399 2011-03-04  Evan Martin  <evan@chromium.org>
1400
1401         Reviewed by Tony Chang.
1402
1403         [gdb] pretty-print KURL in gdb
1404         https://bugs.webkit.org/show_bug.cgi?id=55788
1405
1406         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
1407         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
1408         pretty-printing.
1409
1410 2011-03-03  Timothy Hatcher  <timothy@apple.com>
1411
1412         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
1413
1414         Reviewed by Darin Adler.
1415
1416         * TestWebKitAPI/JavaScriptTest.cpp:
1417         (TestWebKitAPI::javaScriptCallback):
1418         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1419         (TestWebKitAPI::didRunJavaScript):
1420         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1421         (TestWebKitAPI::nullJavaScriptCallback):
1422         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1423         (TestWebKitAPI::didRunJavaScript):
1424
1425 2011-03-03  Timothy Hatcher  <timothy@apple.com>
1426
1427         Make run-api-tests show failed if a test fails.
1428
1429         https://webkit.org/b/55725
1430
1431         Reviewed by Sam Weinig.
1432
1433         * Scripts/run-api-tests:
1434         (runTest): Remove "my" from the nested $result assignment so the
1435         check outside the condition sees the real result.
1436
1437 2011-03-02  MORITA Hajime  <morrita@google.com>
1438
1439         Reviewed by Kent Tamura.
1440
1441         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
1442         https://bugs.webkit.org/show_bug.cgi?id=55434
1443
1444         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
1445         and passed the object webkit_support::PostDelayedTask directly.
1446
1447         Note that the change keeps postTask() as is because it has a
1448         semantics taht webkit_support::PostDelayedTask() has; It jumps to
1449         the main thread.
1450
1451         * DumpRenderTree/chromium/Task.cpp:
1452         (postDelayedTask):
1453         * DumpRenderTree/chromium/Task.h:
1454         (WebTask::Run):
1455
1456 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1457
1458         Reviewed by Kenneth Rohde Christiansen.
1459
1460         [QT] Implement mock client-based geolocation for layout testing
1461         https://bugs.webkit.org/show_bug.cgi?id=54334
1462
1463         Implement testing for Client-Based geolocation for QtWebkit.
1464
1465         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1466         (WebCore::DumpRenderTree::DumpRenderTree):
1467         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1468         (LayoutTestController::reset):
1469         (LayoutTestController::setGeolocationPermission):
1470         (LayoutTestController::setMockGeolocationError):
1471         (LayoutTestController::setMockGeolocationPosition):
1472
1473 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1474
1475         Unreviewed, rolling out r80237.
1476         http://trac.webkit.org/changeset/80237
1477         https://bugs.webkit.org/show_bug.cgi?id=55714
1478
1479         Windows bots aren't ready to be core (Requested by aroben on
1480         #webkit).
1481
1482         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1483         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1484
1485 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
1486
1487         Reviewed by Tony Chang.
1488
1489         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
1490         https://bugs.webkit.org/show_bug.cgi?id=55694
1491         
1492         Fixes for interruptions in NRWT:
1493         - Make TestRunInterruptedException be pickleable correctly (the base
1494           Exception class defines a __reduce__ that does not include the reason)
1495         - Fix ordering of returned arguments from TestRunner2._run_tests
1496           (interrupted and keyboard_interrupted were reversed)
1497         - Fix cancel_workers callsites (was using old name).
1498         - In handle_exception re-raise actual exception instance that was thrown
1499
1500         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1501         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1502         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1503         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1504
1505 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
1506
1507         Unreviewed.
1508
1509         Adding myself as a committer.
1510
1511         * Scripts/webkitpy/common/config/committers.py:
1512
1513 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
1514
1515         Reviewed by Mihai Parparita.
1516
1517         Teach sheriffbot to answer whois commands
1518         https://bugs.webkit.org/show_bug.cgi?id=55687
1519
1520         * Scripts/webkitpy/tool/bot/irc_command.py:
1521         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1522         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1523
1524 2011-03-03  Victoria Kirst  <vrk@google.com>
1525
1526         Reviewed by Eric Carlson.
1527
1528         Enable media tests in chromium-gpu/test_expectations
1529         https://bugs.webkit.org/show_bug.cgi?id=53608
1530
1531         Add media folder to the list of GPU test paths.
1532
1533         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1534
1535 2011-03-03  Adam Roben  <aroben@apple.com>
1536
1537         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
1538
1539         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
1540         incorrect parsing of absolute Windows-style file: URLs
1541
1542         Reviewed by Tim Hatcher.
1543
1544         * WebKitTestRunner/TestInvocation.cpp:
1545         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
1546         <http://webkit.org/b/55683>.
1547
1548 2011-03-03  Tony Chang  <tony@chromium.org>
1549
1550         Reviewed by Dimitri Glazkov.
1551
1552         [chromium] Run kill-old-processes on the chromium-win bot too
1553         https://bugs.webkit.org/show_bug.cgi?id=55630
1554
1555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1556         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
1557
1558 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1559
1560         Reviewed by Martin Robinson.
1561
1562         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
1563         https://bugs.webkit.org/show_bug.cgi?id=53960
1564
1565         * DumpRenderTree/gtk/EventSender.cpp:
1566         (sendClick):
1567         (scheduleAsynchronousClickCallback):
1568
1569 2011-03-03  Adam Roben  <aroben@apple.com>
1570
1571         Look for Windows-style paths when checking whether a test is an Inspector test
1572
1573         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
1574         out or crash on Windows 7 Release (WebKit2 Tests)
1575
1576         Reviewed by Darin Adler.
1577
1578         * WebKitTestRunner/TestInvocation.cpp:
1579         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
1580         Windows.
1581
1582 2011-03-03  Adam Roben  <aroben@apple.com>
1583
1584         Make Windows 7 Release (Tests) a core builder
1585
1586         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1587         give it a few more days of greenness first.
1588
1589         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1590
1591         Reviewed by Andreas Kling.
1592
1593         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1594         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1595
1596         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1597         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1598         Updated the core regexps to match the buildbot module. Updated the expected results to match
1599         the current set of core builders.
1600
1601 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
1602
1603         Reviewed by Andreas Kling.
1604
1605         Adding myself as a reviewer.
1606
1607         * Scripts/webkitpy/common/config/committers.py:
1608
1609 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
1610
1611         Reviewed by Xan Lopez.
1612
1613         [GTK] Extended application cache database API and added unit tests file.
1614         https://bugs.webkit.org/show_bug.cgi?id=55335
1615
1616         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
1617         of webkit_application_cache_set_maximum_size due to API exposal.
1618
1619 2011-03-02  Ojan Vafai  <ojan@chromium.org>
1620
1621         Reviewed by Adam Barth.
1622
1623         make webkit-patch upload work for security bugs
1624         https://bugs.webkit.org/show_bug.cgi?id=55655
1625
1626         The problem is that we shell out to prepare-ChangeLog,
1627         which does not authenticate with bugzilla. All it needs from
1628         bugzilla is the bug title though. We just pass it through from
1629         webkit-patch instead.
1630
1631         * Scripts/prepare-ChangeLog:
1632         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1633         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1634
1635 2011-03-01  Ojan Vafai  <ojan@chromium.org>
1636
1637         Reviewed by Tony Chang.
1638
1639         [test-dashboard] make gtest JSON match layout-tests JSON
1640         https://bugs.webkit.org/show_bug.cgi?id=55556
1641
1642         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
1643         Make this code match.
1644
1645         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1646
1647 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
1648
1649         Reviewed by Tony Chang.
1650
1651         NRWT - implement Linux Hardy 64-bit port support. This involves
1652         adding support for non-'x86' architectures and updating the
1653         "deduplicate_tests" script to correctly understand that
1654         port.name() is not always equal to basename(port.baseline_path()).
1655
1656         This change introduces two new port names: 'chromium-linux-x86'
1657         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
1658         flag will cause the code to determine which one to use at
1659         runtime, just like we currently do with 'chromium-win'.
1660
1661         https://bugs.webkit.org/show_bug.cgi?id=55535
1662
1663         * Scripts/webkitpy/common/system/executive_mock.py:
1664           Handle 'return_stderr' keyword arg to run_command()
1665         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1666         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1667         * Scripts/webkitpy/layout_tests/port/base.py:
1668         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1669         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1670         * Scripts/webkitpy/layout_tests/port/factory.py:
1671         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1672
1673 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
1674
1675         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
1676         update symlinks accordingly.
1677
1678         * wx/packaging/build-mac-installer.py:
1679
1680 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1681
1682         Unreviewed, rolling out r80139.
1683         http://trac.webkit.org/changeset/80139
1684         https://bugs.webkit.org/show_bug.cgi?id=55620
1685
1686         failing and crashing tests on Snow Leopard bot (Requested by
1687         mihaip1 on #webkit).
1688
1689         * DumpRenderTree/LayoutTestController.cpp:
1690         (LayoutTestController::staticFunctions):
1691         * DumpRenderTree/LayoutTestController.h:
1692         * DumpRenderTree/chromium/LayoutTestController.cpp:
1693         (LayoutTestController::LayoutTestController):
1694         * DumpRenderTree/chromium/LayoutTestController.h:
1695         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1696         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1697         * DumpRenderTree/mac/UIDelegate.h:
1698         * DumpRenderTree/mac/UIDelegate.mm:
1699         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1700         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1701         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1702         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1703
1704 2011-03-02  Adam Roben  <aroben@apple.com>
1705
1706         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
1707
1708         This matches DumpRenderTree on Windows.
1709
1710         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
1711         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
1712         in WebKit2
1713
1714         Reviewed by Beth Dakin.
1715
1716         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1717         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
1718         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
1719
1720 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
1721
1722         Reviewed by David Levin.
1723
1724         Add feature define for data transfer items
1725         https://bugs.webkit.org/show_bug.cgi?id=55510
1726
1727         * Scripts/build-webkit:
1728
1729 2011-03-02  Adam Roben  <aroben@apple.com>
1730
1731         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
1732
1733         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
1734         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
1735         the former location, but was getting lucky on some SnowLeopard machines because symlinks
1736         were being created there pointing into DiagnosticReports. For machines without these
1737         symlinks, crash logs were not getting captured.
1738
1739         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
1740         SnowLeopard machines
1741
1742         Reviewed by Eric Seidel.
1743
1744         * Scripts/old-run-webkit-tests:
1745         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
1746
1747 2011-03-02  Adam Roben  <aroben@apple.com>
1748
1749         Don't try to capture crash logs on platforms that haven't implemented that feature
1750
1751         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
1752         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
1753
1754         Reviewed by Joseph Pecoraro.
1755
1756         * Scripts/old-run-webkit-tests:
1757         (captureSavedCrashLog): Bail if we don't have a crash log glob.
1758         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
1759         strictly required to fix bug 55504, but seems worthwhile.
1760
1761 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
1762
1763         Reviewed by Dmitry Titov.
1764
1765         Detach Geolocation from Frame when Page destroyed.
1766         https://bugs.webkit.org/show_bug.cgi?id=52877
1767
1768         Extend the layout test controller to expose the number of pending
1769         geolocation requests, so that we can test that the requests have
1770         been cancelled on page close.
1771
1772         * DumpRenderTree/LayoutTestController.cpp:
1773         (numberOfPendingGeolocationPermissionRequestsCallback):
1774         (LayoutTestController::staticFunctions):
1775         * DumpRenderTree/LayoutTestController.h:
1776         * DumpRenderTree/chromium/LayoutTestController.cpp:
1777         (LayoutTestController::LayoutTestController):
1778         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1779         * DumpRenderTree/chromium/LayoutTestController.h:
1780         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1781         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1782         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1783         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1784         * DumpRenderTree/mac/UIDelegate.h:
1785         * DumpRenderTree/mac/UIDelegate.mm:
1786         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1787         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1788         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1789         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1790         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1791         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1792         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1793         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1794
1795
1796 2011-03-01  Kent Tamura  <tkent@chromium.org>
1797
1798         Reviewed by Dimitri Glazkov.
1799
1800         Assertion fails when a form validation bubble appears
1801         https://bugs.webkit.org/show_bug.cgi?id=55550
1802
1803         Test: fast/forms/interactive-validation-attach-assertion.html
1804
1805         * DumpRenderTree/chromium/WebPreferences.cpp:
1806         (WebPreferences::applyTo): Enable the interactive validation feature by
1807           default. This matches to Chromium browser.
1808
1809 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1810
1811         Reviewed by Kent Tamura.
1812
1813         Remove efl port style exception of Webcore/JavaScriptCore
1814         https://bugs.webkit.org/show_bug.cgi?id=55549
1815
1816         WebCore and JavaScriptCore need to adhere WebKit coding style.
1817
1818         * Scripts/webkitpy/style/checker.py:
1819
1820 2011-03-01  Tony Chang  <tony@chromium.org>
1821
1822         Reviewed by Ojan Vafai.
1823
1824         [chromium] clean up temp files on chromium-mac builder too
1825         https://bugs.webkit.org/show_bug.cgi?id=55525
1826
1827         * BuildSlaveSupport/chromium/remove-crash-logs:
1828
1829 2011-02-28  Ojan Vafai  <ojan@chromium.org>
1830
1831         Reviewed by Tony Chang.
1832
1833         wrap json in a function call to afford cross-domain loading
1834         https://bugs.webkit.org/show_bug.cgi?id=55353
1835
1836         Also delete the code that compacts the JSON. It turns out this
1837         breaks the rebaseline tool and is probably a premature optimization anyways.
1838
1839         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1840         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1841         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1842         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1843
1844 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1845
1846         Unreviewed, rolling out r80079.
1847         http://trac.webkit.org/changeset/80079
1848         https://bugs.webkit.org/show_bug.cgi?id=55547
1849
1850         "Broke the Win debug build?" (Requested by dcheng on #webkit).
1851
1852         * Scripts/build-webkit:
1853
1854 2011-03-01  Mark Rowe  <mrowe@apple.com>
1855
1856         Reviewed by Sam Weinig.
1857
1858         Update verification scripts to handle WebKit2.
1859
1860         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
1861         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
1862         WebKit2.
1863
1864 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
1865
1866         Reviewed by David Levin.
1867
1868         Add feature define for data transfer items
1869         https://bugs.webkit.org/show_bug.cgi?id=55510
1870
1871         * Scripts/build-webkit:
1872
1873 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
1874
1875         Reviewed by Timothy Hatcher.
1876
1877         All Console Messages should be passed to ChromeClients.
1878         https://bugs.webkit.org/show_bug.cgi?id=54926
1879
1880         Update DumpRenderTree's UIDelegate to use the new console message delegate.
1881
1882         * DumpRenderTree/mac/UIDelegate.mm:
1883         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1884
1885 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
1886
1887         Reviewed by Adam Barth.
1888
1889         Tragically, we stopped running the python unit tests
1890         on Chromium Win just as I was getting them to be green.
1891         This patch turns them back on.
1892
1893         https://bugs.webkit.org/show_bug.cgi?id=55521
1894
1895         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1896
1897 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
1898
1899         Reviewed by Adam Roben.
1900
1901         Disable
1902         webkitpy.common.system.executive_unittest.ExecutiveTest.\
1903            test_kill_all fails on win until it can be properly triaged.
1904
1905         https://bugs.webkit.org/show_bug.cgi?id=54790
1906
1907         * Scripts/webkitpy/common/system/executive_unittest.py:
1908
1909     2011-03-01  Helder Correia  <helder@sencha.com>
1910
1911             Unreviewed. Add myself to committers.py.
1912
1913             * Scripts/webkitpy/common/config/committers.py:
1914
1915 2011-03-01  Adam Roben  <aroben@apple.com>
1916
1917         Give up if a crash log for the web process is taking too long to be saved on Windows
1918
1919         This should keep the bots from getting stuck while waiting for a crash log, if writing a
1920         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
1921
1922         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
1923         to be saved for the web process
1924
1925         Reviewed by Steve Falkenburg.
1926
1927         * WebKitTestRunner/win/TestControllerWin.cpp:
1928         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
1929         Generalized the code slightly to handle the optional object to wait on.
1930         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
1931         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
1932         prevent us from waiting forever.
1933
1934 2011-03-01  Adam Roben  <aroben@apple.com>
1935
1936         Give WebKitLauncherWin's PDB file a name different from WebKit's
1937
1938         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
1939         fighting over the same PDB file, meaning that one of them was going to lose and not have
1940         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
1941
1942         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
1943         runs (due to missing symbols)
1944
1945         Reviewed by David Kilzer.
1946
1947         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
1948         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
1949
1950 2011-03-01  Adam Roben  <aroben@apple.com>
1951
1952         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
1953
1954         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
1955         --exit-after-n-crashes-or-timeouts limit
1956
1957         Reviewed by David Kilzer.
1958
1959         * Scripts/old-run-webkit-tests:
1960         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
1961         the number of tests that caused the web process to crash when exiting early.
1962
1963 2011-03-01  Adam Roben  <aroben@apple.com>
1964
1965         Save a crash log when the web process crashes
1966
1967         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
1968         until it has finished crashing, which guarantees that the crash log will have had time to be
1969         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
1970         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
1971
1972         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
1973         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
1974
1975         Reviewed by Sam Weinig.
1976
1977         * Scripts/old-run-webkit-tests:
1978         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
1979         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
1980         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
1981         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
1982         WebProces_*.crash files when the web process crashes.
1983
1984         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1985         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
1986         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
1987         along to platformInitialize.
1988
1989         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
1990
1991         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1992         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
1993
1994         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1995         (WTR::InjectedBundle::platformInitialize):
1996         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1997         (WTR::InjectedBundle::platformInitialize):
1998         Updated function signature.
1999
2000         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2001         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
2002         webProcessCrashingEvent, then lets the crash continue as normal.
2003
2004         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
2005         event we should use to tell the UI process we're crashing from the initializationUserData,
2006         and get a handle to that event.
2007
2008         * WebKitTestRunner/TestController.cpp:
2009         (WTR::TestController::TestController): Initialize new members.
2010         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
2011         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
2012         when a crash log is being saved on Windows. Exit right away if specified. (This is the
2013         default.)
2014
2015         * WebKitTestRunner/TestController.h: Added new members.
2016
2017         * WebKitTestRunner/win/TestControllerWin.cpp:
2018         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
2019         us it's crashing.
2020         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
2021         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
2022         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
2023         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
2024         so the test harness will know the web process has crashed and not try to kill us, then wait
2025         for the web process to finish crashing so a crash log will have time to be saved.
2026         (WTR::toWK): Simple hepler function.
2027         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
2028         process should use to tell us it is crashing in the context's initialization user data.
2029
2030 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
2031
2032         Reviewed by Tony Gentilcore.
2033
2034         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
2035         https://bugs.webkit.org/show_bug.cgi?id=55476
2036
2037         Chromium Win uses BuildAndTestFactory, not TestFactory.
2038
2039         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
2040
2041 2011-03-01  Adam Roben  <aroben@apple.com>
2042
2043         Test that the WebKit2 responsiveness timer doesn't fire too early
2044
2045         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
2046         early on Windows
2047
2048         Reviewed by Anders Carlsson.
2049
2050         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
2051
2052         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
2053         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2054         (TestWebKitAPI::didFinishLoadForFrame):
2055         (TestWebKitAPI::processDidBecomeUnresponsive):
2056         (TestWebKitAPI::setInjectedBundleClient):
2057         (TestWebKitAPI::setPageLoaderClient):
2058         Simple helper functions.
2059
2060         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
2061         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
2062         the responsiveness timer to start, but the web process should unpause before it has a chance
2063         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
2064
2065         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
2066         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
2067         Call up to the base class.
2068         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
2069         pause, sleep for 0.5 seconds, then send back a message saying we paused.
2070
2071         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2072         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
2073         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2074         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
2075
2076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2077         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2078         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2079         Added new files.
2080
2081 2011-03-01  Andras Becsi  <abecsi@webkit.org>
2082
2083         Reviewed by Csaba Osztrogonác.
2084
2085         [Qt] Clean up the project files and move common options to WebKit.pri.
2086
2087         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
2088
2089
2090 2011-03-01  Adam Roben  <aroben@apple.com>
2091
2092         Skip another multiprocessing test on Windows
2093
2094         It is sometimes failing (and may be leaving child Python processes around).
2095         <http://webkit.org/b/55087> tracks the failure.
2096
2097         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
2098         (FuncitonTests.test_get__processes): Skip this test on Windows.
2099
2100 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
2101
2102         Reviewed by Pavel Feldman.
2103
2104         Web Inspector: reduce inspector tests flakiness.
2105         https://bugs.webkit.org/show_bug.cgi?id=55401
2106
2107         * DumpRenderTree/chromium/TestShell.cpp:
2108         (TestShell::runFileTest):
2109         * DumpRenderTree/chromium/WebPreferences.cpp:
2110         (WebPreferences::reset):
2111
2112 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
2113
2114         Reviewed by James Robinson.
2115
2116         NRWT should still upload results when it exits early due to too many failures
2117         https://bugs.webkit.org/show_bug.cgi?id=55432
2118         
2119         Only keyboard interrupts should prevent results from being uploaded.
2120
2121         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2122         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2123
2124 2011-02-28  Alice Liu  <alice.liu@apple.com>
2125
2126         Reviewed by Adam Roben and Gavin Barraclough.
2127
2128         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
2129         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
2130
2131         * TestWebKitAPI/InjectedBundleController.h:
2132         (TestWebKitAPI::InjectedBundleController::bundle):
2133         * TestWebKitAPI/PlatformWebView.h:
2134         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
2135         (TestWebKitAPI::didFinishLoadForFrame):
2136         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2137         (TestWebKitAPI::setPageLoaderClient):
2138         (TestWebKitAPI::TEST):
2139         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
2140         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
2141         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2142         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
2143         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2144         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2145         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2146         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2147         
2148         Added files to:
2149         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2150         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2151         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2152
2153 2011-02-28  Adam Roben  <aroben@apple.com>
2154
2155         Start running InjectedBundle API tests on Windows
2156
2157         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
2158
2159         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
2160
2161         Reviewed by Darin Adler.
2162
2163         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
2164         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
2165         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
2166         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
2167         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
2168         These are just extracted from TestWebKitAPI.vcproj.
2169
2170         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
2171         up the DLL's filename.
2172
2173         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
2174         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
2175         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
2176
2177         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
2178         "all" configuration.
2179
2180         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
2181         injected bundle tests. Let VS resort things.
2182
2183         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
2184
2185 2011-02-28  Adam Roben  <aroben@apple.com>
2186
2187         Add a test for the paint rect passed via WM_PAINT to windowless plugins
2188
2189         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
2190         Large portions of pages with plugins paint black
2191
2192         Reviewed by Anders Carlsson.
2193
2194         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2195         (PluginTest::NPP_HandleEvent):
2196         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2197         Added NPP_HandleEvent. Just returns 0 at this level.
2198
2199         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
2200         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
2201         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
2202         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
2203         WM_PAINT has the expected coordinates.
2204
2205         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2206         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
2207         else.
2208
2209         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
2210         resort things.
2211
2212         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2213         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
2214         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
2215         webView:didFinishLoadForFrame:] in DumpRenderTree.
2216
2217         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2218         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
2219         can start running.
2220
2221 2011-02-28  Adam Roben  <aroben@apple.com>
2222
2223         Tell MiniBrowser's WKViews that they're in a window
2224
2225         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
2226
2227         Reviewed by Anders Carlsson.
2228
2229         * MiniBrowser/win/BrowserView.cpp:
2230         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
2231
2232 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
2233
2234         Reviewed by Csaba Osztrogonác.
2235
2236         The new QML tests require QML_IMPORT_PATH variable to be set in order to
2237         load the proper plugin.
2238
2239         * Scripts/run-qtwebkit-tests:
2240
2241 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
2242
2243         Unreviewed, fix spelling mistake.
2244
2245         hardware-accelated => hardware-accelerated.
2246
2247         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2248
2249 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
2250
2251         Reviewed by Andreas Kling.
2252
2253         Made sure that the build-webkit --qmake argument is always respected.
2254
2255         Previously, it would be respected during the build, but not during
2256         the early feature detection. The build would also fail if qmake was
2257         not in your path, even if you specified --qmake with a valid qmake
2258         binary.
2259
2260         [Qt] WebKit patches required to work with a modularized version of Qt
2261         https://bugs.webkit.org/show_bug.cgi?id=53916
2262
2263         * Scripts/build-webkit:
2264         * Scripts/webkitdirs.pm:
2265
2266 2011-02-27  Ojan Vafai  <ojan@chromium.org>
2267
2268         Fix failing tests from http://trac.webkit.org/changeset/79837.
2269
2270         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2271         This was just a mistake that would break if someone tried printing with this configuration.
2272         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2273         Method signature changed. Didn't notice that this method was being calling in a unittest.
2274
2275 2011-02-24  Hayato Ito  <hayato@chromium.org>
2276
2277         Reviewed by Eric Seidel.
2278
2279         [NRWT] Remove test_types/* classes.
2280
2281         This is the last patch in the series of efforts which tried to remove test_types classes.
2282         A single_test_runner module will take over responsibilities of test_type classes.
2283
2284         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
2285
2286         https://bugs.webkit.org/show_bug.cgi?id=55123
2287
2288         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2289         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2290         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2291         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2292         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
2293         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
2294         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
2295         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
2296         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
2297         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
2298
2299 2011-02-25  Ojan Vafai  <ojan@chromium.org>
2300
2301         Reviewed by Tony Chang.
2302
2303         Change results.json format to the one used by unexpected_results.json
2304         https://bugs.webkit.org/show_bug.cgi?id=52267
2305
2306         Also add runtimes in milliseconds to the JSON and make the output format more compact.
2307         Named the file full_results.json to avoid conflicting with the results.json
2308         file the test-results server currently serves up.
2309
2310         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2311         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2312         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2313         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2314         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2315         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2316
2317 2011-02-27  Adam Roben  <aroben@apple.com>
2318
2319         Followup fix to r79827
2320
2321         * DumpRenderTree/win/UIDelegate.cpp:
2322         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
2323         lastPathComponent. This matches what we did here before r79827, and matches Mac.
2324
2325 2011-02-27  Dan Bernstein  <mitz@apple.com>
2326
2327         Reviewed by Adam Roben.
2328
2329         Make bisect-builds print a trac link for the regression range
2330         https://bugs.webkit.org/show_bug.cgi?id=55331
2331
2332         * Scripts/bisect-builds:
2333
2334 2011-02-27  Adam Roben  <aroben@apple.com>
2335
2336         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
2337
2338         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
2339         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
2340         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
2341
2342         Reviewed by Anders Carlsson.
2343
2344         * DumpRenderTree/win/EditingDelegate.cpp:
2345         (indexOfFirstWordCharacter):
2346         (wordLength):
2347         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
2348
2349 2011-02-27  Adam Roben  <aroben@apple.com>
2350
2351         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
2352
2353         This matches Mac. (In fact, the code was ported from Mac!)
2354
2355         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
2356         match Mac
2357
2358         Reviewed by Anders Carlsson.
2359
2360         * DumpRenderTree/win/DumpRenderTree.cpp:
2361         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
2362         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
2363         _drt_descriptionSuitableForTestResult].
2364         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
2365
2366         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
2367
2368         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
2369         DumpRenderTree.cpp.
2370
2371 2011-02-27  Adam Roben  <aroben@apple.com>
2372
2373         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
2374
2375         This makes Bugzilla autocompletion work correctly.
2376
2377         * Scripts/webkitpy/common/config/committers.py:
2378
2379 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
2380
2381         Reviewed by Andreas Kling.
2382
2383         [Qt] fast/loader/user-stylesheet-fast-path.html fails
2384         https://bugs.webkit.org/show_bug.cgi?id=50911
2385
2386         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2387         (LayoutTestController::setUserStyleSheetLocation):
2388         Use QUrl::fromEncoded since the passed string is already encoded.
2389
2390 2011-02-27  Adam Roben  <aroben@apple.com>
2391
2392         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
2393
2394         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
2395         is different from old-run-webkit-test's. Because of this, the path to the crash log file
2396         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
2397         details.
2398
2399         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
2400         --results-directory path is used (like on the test slaves)
2401
2402         Reviewed by Dan Bernstein.
2403
2404         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
2405         made $testResultsDirectory an absolute path.
2406
2407 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
2408
2409         Reviewed by Adam Barth.
2410
2411         m_dumpAccessibilityNotifications should be initialized.
2412         https://bugs.webkit.org/show_bug.cgi?id=54874
2413
2414         * DumpRenderTree/chromium/AccessibilityController.cpp:
2415         (AccessibilityController::AccessibilityController):
2416
2417 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2418
2419         Reviewed by Pavel Feldman.
2420
2421         DumpRenderTree should reset frame opener between tests.
2422         https://bugs.webkit.org/show_bug.cgi?id=54874
2423
2424         Added clearOpener() calls between tests.
2425         Some tests are using window.open() to change current window location.
2426         This changes window.opener property whose nullity is checked before
2427         showing xml viewer.
2428
2429         * DumpRenderTree/chromium/TestShell.cpp:
2430         (TestShell::resetTestController):
2431         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2432         (resetDefaultsToConsistentValues):
2433         * DumpRenderTree/mac/DumpRenderTree.mm:
2434         (resetWebViewToConsistentStateBeforeTesting):
2435         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2436         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2437         * DumpRenderTree/win/DumpRenderTree.cpp:
2438         (resetWebViewToConsistentStateBeforeTesting):
2439         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2440         (WTR::InjectedBundlePage::reset):
2441
2442 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
2443
2444         Reviewed by Andreas Kling.
2445
2446         [Qt] Fix the focus in MiniBrowser.
2447         https://bugs.webkit.org/show_bug.cgi?id=55288
2448
2449         Give focus to the web view when a load starts.
2450
2451         * MiniBrowser/qt/BrowserWindow.cpp:
2452         (BrowserWindow::urlChanged):
2453
2454 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2455
2456         Reviewed by Adam Barth.
2457
2458         [EFL] Add coding style exceptions for EFL port
2459         https://bugs.webkit.org/show_bug.cgi?id=54733
2460
2461         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
2462         underscore-sparated values. But, style checking rule have found parameter_name errors
2463         in efl directories so far.
2464
2465         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
2466
2467 2011-02-26  David Levin  <levin@chromium.org>
2468
2469         Reviewed by Darin Adler.
2470
2471         check-webkit-style should check for spaces after periods in comments
2472         https://bugs.webkit.org/show_bug.cgi?id=55253
2473
2474         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
2475         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
2476           and fixed the name of one related test.
2477
2478 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2479
2480         Reviewed by Andreas Kling.
2481
2482         Make it possible to test the targetdensity-dpi support
2483         https://bugs.webkit.org/show_bug.cgi?id=55142
2484
2485         Test the viewport meta tag feature targetdensity-dpi by
2486         adding extra arguments to dumpConfigurationForViewport
2487
2488         Add the new arguments to the shared header and all
2489         implementation.
2490
2491         * DumpRenderTree/LayoutTestController.cpp:
2492         (dumpConfigurationForViewportCallback):
2493         * DumpRenderTree/LayoutTestController.h:
2494         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2495         (LayoutTestController::dumpConfigurationForViewport):
2496         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2497         (LayoutTestController::dumpConfigurationForViewport):
2498         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2499         (LayoutTestController::dumpConfigurationForViewport):
2500         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2501         (LayoutTestController::dumpConfigurationForViewport):
2502         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2503         (LayoutTestController::dumpConfigurationForViewport):
2504         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2505
2506 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2507
2508         Unreviewed, rolling out r79764.
2509         http://trac.webkit.org/changeset/79764
2510         https://bugs.webkit.org/show_bug.cgi?id=55295
2511
2512         "broke Chromium builds" (Requested by rniwa on #webkit).
2513
2514         * DumpRenderTree/chromium/TestShell.cpp:
2515         (TestShell::resetTestController):
2516         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2517         (resetDefaultsToConsistentValues):
2518         * DumpRenderTree/mac/DumpRenderTree.mm:
2519         (resetWebViewToConsistentStateBeforeTesting):
2520         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2521         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2522         * DumpRenderTree/win/DumpRenderTree.cpp:
2523         (resetWebViewToConsistentStateBeforeTesting):
2524         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2525         (WTR::InjectedBundlePage::reset):
2526
2527 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
2528
2529         Reviewed by David Kilzer.
2530
2531         https://bugs.webkit.org/show_bug.cgi?id=48781
2532
2533         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
2534
2535         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
2536         should paint the default broken image when an image fails to load or decode.
2537
2538         * DumpRenderTree/LayoutTestController.cpp:
2539         (LayoutTestController::LayoutTestController):
2540         (setShouldPaintBrokenImageCallback):
2541         (LayoutTestController::staticFunctions):
2542         (LayoutTestController::setShouldPaintBrokenImage):
2543         * DumpRenderTree/LayoutTestController.h:
2544         (LayoutTestController::shouldPaintBrokenImage):
2545         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2546         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
2547
2548 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2549
2550         Reviewed by Pavel Feldman.
2551
2552         DumpRenderTree should reset frame opener between tests.
2553         https://bugs.webkit.org/show_bug.cgi?id=54874
2554
2555         Added clearOpener() calls between tests.
2556         Some tests are using window.open() to change current window location.
2557         This changes window.opener property whose nullity is checked before
2558         showing xml viewer.
2559
2560         * DumpRenderTree/chromium/TestShell.cpp:
2561         (TestShell::resetTestController):
2562         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2563         (resetDefaultsToConsistentValues):
2564         * DumpRenderTree/mac/DumpRenderTree.mm:
2565         (resetWebViewToConsistentStateBeforeTesting):
2566         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2567         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2568         * DumpRenderTree/win/DumpRenderTree.cpp:
2569         (resetWebViewToConsistentStateBeforeTesting):
2570         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2571         (WTR::InjectedBundlePage::reset):
2572
2573 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
2574
2575         Reviewed by Kenneth Rohde Christiansen.
2576
2577         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
2578         https://bugs.webkit.org/show_bug.cgi?id=54809
2579
2580         * EWebLauncher/main.c: Handling -f option added.
2581         (on_key_down):
2582         (browserCreate):
2583         (main):
2584
2585 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2586
2587         Unreviewed, rolling out r79324.
2588         http://trac.webkit.org/changeset/79324
2589         https://bugs.webkit.org/show_bug.cgi?id=55260
2590
2591         Leopard Debug is once again running out of address space while
2592         linking (Requested by aroben on #webkit).
2593
2594         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2595         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2596
2597 2011-02-25  Tony Chang  <tony@chromium.org>
2598
2599         Reviewed by James Robinson.
2600
2601         Clean up temp files left by crashing DRTs on chromium-win
2602         https://bugs.webkit.org/show_bug.cgi?id=55182
2603
2604         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2605         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
2606
2607 2011-02-25  Adam Roben  <aroben@apple.com>
2608
2609         Double-check that modifying the registry worked
2610
2611         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
2612         still return a successful exit code. So we double-check here that the value we tried to
2613         write to the registry was really written.
2614
2615         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
2616         logs on Windows Vista/7
2617
2618         Reviewed by Darin Adler.
2619
2620         * Scripts/old-run-webkit-tests:
2621         (writeRegistryString): After trying to write the string value, check that it was really
2622         written.
2623
2624 2011-02-25  Adam Roben  <aroben@apple.com>
2625
2626         Set the 32-bit post-mortem debugger on 64-bit OSes
2627
2628         The post-mortem debugger is controlled by some registry values in
2629         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
2630         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
2631         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
2632         WebKitTestRunner are 32-bit, we want to use the latter location.
2633
2634         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
2635         64-bit apps, but should set it for 32-bit apps instead
2636
2637         Reviewed by Darin Adler.
2638
2639         * Scripts/old-run-webkit-tests:
2640         (readRegistryString):
2641         (writeRegistryString):
2642         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
2643         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
2644         Passing --wow32 on a 32-bit OS will not have any effect.
2645
2646 2011-02-25  Adam Roben  <aroben@apple.com>
2647
2648         Clean up code to set up crash log saving on Windows
2649
2650         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
2651
2652         Reviewed by David Kilzer.
2653
2654         * Scripts/old-run-webkit-tests:
2655         (readRegistryString):
2656         (writeRegistryString):
2657         Moved code to read strings from and write strings to the registry here...
2658
2659         (setUpWindowsCrashLogSaving): ...from here.
2660
2661 2011-02-25  Adam Roben  <aroben@apple.com>
2662
2663         Work around Cygwin's crash-suppression behavior
2664
2665         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
2666         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
2667         invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
2668         when our test apps launch to work around Cygwin's behavior.
2669
2670         Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
2671         debugger) when launched from Cygwin 1.7
2672
2673         Reviewed by Darin Adler.
2674
2675         * DumpRenderTree/win/DumpRenderTree.cpp:
2676         (main):
2677         * TestWebKitAPI/win/main.cpp:
2678         (main):
2679         * WebKitAPITest/main.cpp:
2680         (main):
2681         * WebKitTestRunner/win/TestControllerWin.cpp:
2682         (WTR::TestController::platformInitialize):
2683         Call ::SetErrorMode(0) to undo Cygwin's folly.
2684
2685 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2686
2687         Reviewed by Andreas Kling.
2688
2689         [Qt] Revert the support for QNAM affined to a different thread.
2690         https://bugs.webkit.org/show_bug.cgi?id=55149
2691
2692         Qt 4.8 will have QNAM use its own thread internally by default,
2693         no need to keep this complexity in WebKit.
2694
2695         This mainly reverts:
2696         http://trac.webkit.org/changeset/73710
2697         http://trac.webkit.org/changeset/73712
2698
2699         * QtTestBrowser/launcherwindow.cpp:
2700         (LauncherWindow::~LauncherWindow):
2701         (LauncherWindow::initializeView):
2702         (LauncherWindow::createChrome):
2703         * QtTestBrowser/launcherwindow.h:
2704         (WindowOptions::WindowOptions):
2705         * QtTestBrowser/webpage.cpp:
2706         (WebPage::WebPage):
2707         * QtTestBrowser/webpage.h:
2708
2709 2011-02-24  Adam Barth  <abarth@webkit.org>
2710
2711         Reviewed by Eric Seidel.
2712
2713         Add a script for creating gypi files
2714         https://bugs.webkit.org/show_bug.cgi?id=55113
2715
2716         This is a trivial script to create gypi files from the source code in
2717         the current directory.
2718
2719         * Scripts/make-gypi: Added.
2720
2721 2011-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2722
2723         Unreviewed, rolling out r79628.
2724         http://trac.webkit.org/changeset/79628
2725         https://bugs.webkit.org/show_bug.cgi?id=55195
2726
2727         "broke chromium win tests" (Requested by dpranke on #webkit).
2728
2729         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2730         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2731
2732 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
2733
2734         Reviewed by Mihai Parparita.
2735
2736         rebaseline-chromium-webkit-tests can't handle GPU variants
2737         https://bugs.webkit.org/show_bug.cgi?id=55002
2738
2739         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2740         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2741
2742 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
2743
2744         Reviewed by Mihai Parparita.
2745
2746         nrwt: log command used to start web server to --verbose
2747
2748         https://bugs.webkit.org/show_bug.cgi?id=55188
2749
2750         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2751         * Scripts/webkitpy/layout_tests/port/http_server.py:
2752
2753 2011-02-24  Victoria Kirst  <vrk@google.com>
2754
2755         Reviewed by Mihai Parparita.
2756
2757         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
2758         https://bugs.webkit.org/show_bug.cgi?id=55089
2759
2760         This adds an alias into the media/ directory so that http/tests/media
2761         tests can access the media resources when running in an httpd process.
2762
2763         * Scripts/webkitperl/httpd.pm:
2764         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2765         * Scripts/webkitpy/layout_tests/port/http_server.py:
2766
2767 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
2768
2769         Reviewed by Mihai Parparita.
2770
2771         nrwt: enable multiple processes by default on Chromium Win.
2772
2773         https://bugs.webkit.org/show_bug.cgi?id=55163
2774
2775         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2776         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2777
2778 2011-02-24  Sam Weinig  <sam@webkit.org>
2779
2780         Attempt to fix Qt.
2781
2782         * WebKitTestRunner/TestInvocation.cpp:
2783
2784 2011-02-24  James Robinson  <jamesr@chromium.org>
2785
2786         Unreviewed, rolling out r79598.
2787         http://trac.webkit.org/changeset/79598
2788         https://bugs.webkit.org/show_bug.cgi?id=55089
2789
2790         Appears to be causing trouble with httpd on windows
2791
2792         * Scripts/webkitperl/httpd.pm:
2793         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2794         * Scripts/webkitpy/layout_tests/port/http_server.py:
2795
2796 2011-02-24  Sam Weinig  <sam@webkit.org>
2797
2798         Reviewed by Darin Adler.
2799
2800         Add basic pixel testing support to WebKitTestRunner
2801         https://bugs.webkit.org/show_bug.cgi?id=55161
2802
2803         * Scripts/old-run-webkit-tests:
2804         Don't print color space information when using WebKitTestRunner since
2805         we don't need to change the screen.
2806
2807         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2808         (WTR::InjectedBundle::initialize):
2809         Add call to initializePlatformDefaults.
2810         
2811         (WTR::InjectedBundle::done):
2812         Return a dictionary on completion with both the text output and pixel dump override.
2813
2814         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2815         Add declaration for initializePlatformDefaults.
2816
2817         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2818         (WTR::LayoutTestController::LayoutTestController):
2819         (WTR::LayoutTestController::dumpAsText):
2820         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2821         (WTR::LayoutTestController::shouldDumpPixels):
2822         Make setting dumpAsText override the dump pixels preference.
2823
2824         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.
2825         (WTR::InjectedBundle::initializePlatformDefaults):
2826         Set platform defaults matching DumpRenderTree.
2827
2828         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
2829         (WTR::InjectedBundle::initializePlatformDefaults):
2830         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.
2831         (WTR::InjectedBundle::initializePlatformDefaults):
2832         Add stubs for initializePlatformDefaults.
2833
2834         * WebKitTestRunner/TestController.cpp:
2835         (WTR::TestController::runTest):
2836         (WTR::TestController::runTestingServerLoop):
2837         (WTR::TestController::run):
2838         Parse expected pixel results out of stdin and setup the invocation with it.
2839
2840         * WebKitTestRunner/TestInvocation.cpp:
2841         (WTR::TestInvocation::TestInvocation):
2842         Initialize new members.
2843
2844         (WTR::TestInvocation::~TestInvocation):
2845         (WTR::TestInvocation::setIsPixelTest):
2846         (WTR::sizeWebViewForCurrentTest):
2847         (WTR::TestInvocation::invoke):
2848         (WTR::TestInvocation::dump):
2849         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2850         * WebKitTestRunner/TestInvocation.h:
2851         Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.
2852
2853         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2854         (WTR::PlatformWebView::PlatformWebView):
2855         Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.
2856
2857         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
2858         (WTR::createCGContextFromPlatformView):
2859         (WTR::computeMD5HashStringForContext):
2860         (WTR::dumpBitmap):
2861         (WTR::forceRepaintFunction):
2862         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2863         Add mac specific pixel dumping support. Right now, we always pull pixels
2864         from the window server.
2865
2866         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2867         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2868         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2869         * WebKitTestRunner/win/InjectedBundle.vcproj:
2870         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2871         Add new files.
2872
2873 2011-02-24  Chang Shu  <cshu@webkit.org>
2874
2875         Reviewed by Kenneth Rohde Christiansen.
2876
2877         [Qt] Launch MiniBrowser if the test run is WebKit2. 
2878         https://bugs.webkit.org/show_bug.cgi?id=55145
2879
2880         * Scripts/old-run-webkit-tests:
2881         * Scripts/run-launcher:
2882         * Scripts/webkitdirs.pm:
2883
2884 2011-02-24  Victoria Kirst  <vrk@google.com>
2885
2886         Reviewed by Mihai Parparita.
2887
2888         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
2889         https://bugs.webkit.org/show_bug.cgi?id=55089
2890
2891         This adds an alias into the media/ directory so that http/tests/media
2892         tests can access the media resources when running in an httpd process.
2893
2894         * Scripts/webkitperl/httpd.pm:
2895         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2896         * Scripts/webkitpy/layout_tests/port/http_server.py:
2897
2898 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
2899
2900         Unreviewed, rolling out r79570.
2901         http://trac.webkit.org/changeset/79570
2902         https://bugs.webkit.org/show_bug.cgi?id=54874
2903
2904         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2905         was not updated
2906
2907         * DumpRenderTree/chromium/TestShell.cpp:
2908         (TestShell::resetTestController):
2909         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2910         (resetDefaultsToConsistentValues):
2911         * DumpRenderTree/mac/DumpRenderTree.mm:
2912         (resetWebViewToConsistentStateBeforeTesting):
2913         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2914         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2915         * DumpRenderTree/win/DumpRenderTree.cpp:
2916         (resetWebViewToConsistentStateBeforeTesting):
2917         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2918         (WTR::InjectedBundlePage::reset):
2919
2920 2011-02-24  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2921
2922         Reviewed by Laszlo Gombos.
2923
2924         [Qt] add android 2.2 user agent to QtTestBrowser
2925         https://bugs.webkit.org/show_bug.cgi?id=55085
2926
2927         Credit to Forrest Hodgkins to find right user-agent which works for youtube.
2928         * QtTestBrowser/useragentlist.txt:
2929
2930 2011-02-24  Adam Roben  <aroben@apple.com>
2931
2932         Change FrameLoadDelegate to support any number of delegates with delayed work to process
2933
2934         This makes our behavior match Mac more closely, and allows us to remove an incorrect
2935         assertion that was firing during some tests. (The assertion was claiming that there was
2936         never more than one delegate with delayed work to process, but that was not the case.)
2937
2938         Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
2939         when running http/tests/navigation/back-twice-without-commit.html
2940
2941         Reviewed by Eric Carlson.
2942
2943         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2944         (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
2945         process. A single delegate may appear in this Vector more than once (just as, on Mac, a
2946         single delegate may have multiple performSelector requests).
2947         (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
2948         assertion that the timer firing is the shared process work timer. Instead of using the
2949         single, global "delegate waiting for timer" delegate, give all delegates that have delayed
2950         work to process a chance to process their work.
2951         (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
2952         processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
2953         Vector so our processWork function will be called when the timer fires.
2954
2955 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
2956
2957         Reviewed by Alexey Proskuryakov.
2958
2959         DumpRenderTree should reset frame opener between tests.
2960         https://bugs.webkit.org/show_bug.cgi?id=54874
2961
2962         Added clearOpener() calls between tests.
2963         Some tests are using window.open() to change current window location.
2964         This changes window.opener property whose nullity is checked before
2965         showing xml viewer.
2966
2967         * DumpRenderTree/chromium/TestShell.cpp:
2968         (TestShell::resetTestController):
2969         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2970         (resetDefaultsToConsistentValues):
2971         * DumpRenderTree/mac/DumpRenderTree.mm:
2972         (resetWebViewToConsistentStateBeforeTesting):
2973         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2974         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2975         * DumpRenderTree/win/DumpRenderTree.cpp:
2976         (resetWebViewToConsistentStateBeforeTesting):
2977         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2978         (WTR::InjectedBundlePage::reset):
2979
2980 2011-02-24  Adam Roben  <aroben@apple.com>
2981
2982         Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am
2983
2984         Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
2985         but did
2986
2987         Reviewed by Anders Carlsson.
2988
2989         * Scripts/webkitpy/common/config/build.py:
2990         (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
2991         top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.
2992
2993         * Scripts/webkitpy/common/config/build_unittest.py:
2994         (ShouldBuildTest): Added some more tests.
2995
2996 2011-02-24  Andras Becsi  <abecsi@webkit.org>
2997
2998         Reviewed by Laszlo Gombos.
2999
3000         [Qt] MinGW build fails to link
3001         https://bugs.webkit.org/show_bug.cgi?id=55050
3002
3003         Prepend the libraries of subcomponents instead of appending them
3004         to fix the library order according to the dependency of the libraries
3005
3006         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3007         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3008
3009 2011-02-24  Gabor Loki  <loki@webkit.org>
3010
3011         Reviewed by Csaba Osztrogonác.
3012
3013         [Qt] Remove ARMv5 Release buildbot.
3014
3015         Remove ARMv5 Release buildbot, because there is very little difference
3016         between ARMv5 and ARMv7 Release bots, and there is also very little
3017         interest in ARMv5 build slave (compared to ARMv7).
3018
3019         * BuildSlaveSupport/build.webkit.org-config/config.json:
3020         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3021
3022 2011-02-22  Ojan Vafai  <ojan@chromium.org>
3023
3024         Reviewed by Tony Chang.
3025
3026         fix revision number finding when creating git patches
3027         https://bugs.webkit.org/show_bug.cgi?id=55024
3028
3029         HEAD~n does not walk merge commits correctly. git log however does.
3030
3031         * Scripts/webkitpy/common/checkout/scm.py:
3032         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3033
3034 2011-02-23  Kenneth Russell  <kbr@google.com>
3035
3036         Unreviewed, rolling out r79387.
3037         https://bugs.webkit.org/show_bug.cgi?id=54885
3038
3039         Reapply the code changes from r79038 since they weren't the root
3040         cause of the test timeouts.
3041
3042         * DumpRenderTree/chromium/WebViewHost.cpp:
3043         (WebViewHost::reset):
3044
3045 2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>
3046
3047         Reviewed by Laszlo Gombos.
3048
3049         [Qt] Make sure Symbian binary UIDs are unique
3050
3051         * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with
3052         QtTestBrowser.pro by changing the UID.
3053
3054 2011-02-23  Patrick Gansterer  <paroga@webkit.org>
3055
3056         Reviewed by Darin Adler.
3057
3058         Rename PLATFORM(CF) to USE(CF)
3059         https://bugs.webkit.org/show_bug.cgi?id=53540
3060
3061         * DumpRenderTree/config.h:
3062
3063 2011-02-23  Dirk Pranke  <dpranke@chromium.org>
3064
3065         Reviewed by Ojan Vafai.
3066
3067         nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults
3068         https://bugs.webkit.org/show_bug.cgi?id=55016
3069
3070         * Scripts/webkitpy/layout_tests/port/base.py:
3071         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3072         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added.
3073         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3074         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3075         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3076         * Scripts/webkitpy/layout_tests/port/mac.py:
3077         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3078         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3079         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3080
3081 2011-02-23  Tony Chang  <tony@chromium.org>
3082
3083         Reviewed by Kent Tamura.
3084
3085         [chromium] DumpRenderTree --check-layout-test-sys-deps leaks 4 temp dirs
3086         https://bugs.webkit.org/show_bug.cgi?id=55004
3087
3088         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3089         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
3090         (WebKitSupportTestEnvironment::~WebKitSupportTestEnvironment):
3091         (main): Use a C++ object to ensure that TearDownTestEnvironment
3092             gets called when --check-layout-test-sys-deps is called
3093
3094 2011-02-23  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
3095
3096         Reviewed by Anders Carlsson.
3097
3098         [Qt] [Qt] check webkit style fails in qt/tests
3099         https://bugs.webkit.org/show_bug.cgi?id=54998
3100
3101         check-webkit-style was complaining about missing config.h in WebKit/qt/test/qdeclarativewebview. This patch was originally part of 50222. Reviewer suggested to split and create a separate patch for checker.
3102
3103         * Scripts/webkitpy/style/checker.py:
3104
3105 2011-02-22  Vsevolod Vlasov  <vsevik@chromium.org>
3106
3107         Reviewed by Pavel Feldman.
3108
3109         DumpRenderTree should dump as text if test path contains "dumpAsText/"
3110         https://bugs.webkit.org/show_bug.cgi?id=54873
3111
3112         * DumpRenderTree/chromium/LayoutTestController.h:
3113         (LayoutTestController::setShouldDumpAsText):
3114         (LayoutTestController::setShouldGeneratePixelResults):
3115         * DumpRenderTree/chromium/TestShell.cpp:
3116         (TestShell::runFileTest):
3117         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3118         (shouldDumpAsText):
3119         (dump):
3120         (runTest):
3121         * DumpRenderTree/mac/DumpRenderTree.mm:
3122         (shouldDumpAsText):
3123         (runTest):
3124         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3125         (WebCore::isDumpAsTextTest):
3126         (WebCore::DumpRenderTree::open):
3127         * DumpRenderTree/win/DumpRenderTree.cpp:
3128         (shouldDumpAsText):
3129         (runTest):
3130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3131         (WTR::InjectedBundlePage::dump):
3132
3133 2011-02-22  Kenneth Russell  <kbr@google.com>
3134
3135         Reviewed by James Robinson.
3136
3137         Many tests started timing out on the chrome mac canaries around r79035
3138         https://bugs.webkit.org/show_bug.cgi?id=54885
3139
3140         Revert the code changes, but not the Chromium DEPS roll, from
3141         r79038 to see whether this clears up the timing-out tests. Was not
3142         able to reproduce the timeouts locally with a Release mode build
3143         of DRT (on Snow Leopard).
3144
3145         * DumpRenderTree/chromium/WebViewHost.cpp:
3146         (WebViewHost::reset):
3147
3148 2011-02-22  Dirk Pranke  <dpranke@chromium.org>
3149
3150         Reviewed by James Robinson.
3151
3152         nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
3153         https://bugs.webkit.org/show_bug.cgi?id=55009
3154
3155         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3156
3157 2011-02-18  Mihai Parparita  <mihaip@chromium.org>
3158
3159         Reviewed by Ojan Vafai.
3160
3161         Default to 500 for --exit-after-n-failures
3162         https://bugs.webkit.org/show_bug.cgi?id=54773
3163
3164         Make 500 the default value for --exit-after-n-failures (ORWT bots
3165         already default to this as of r75726). Similarly, change the default for
3166         --exit-after-n-crashes-or-timeouts to 20.
3167
3168         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3169
3170 2011-02-02  Martin Robinson  <mrobinson@igalia.com>
3171
3172         Reviewed by Xan Lopez.
3173
3174         [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
3175         https://bugs.webkit.org/show_bug.cgi?id=53603
3176
3177         Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
3178         to DumpRenderTreeSupportGtk for this functionality.
3179
3180         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3181         (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to
3182         false when reseting values between tests.
3183         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3184         (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace
3185         with the appropriate value.
3186
3187 2011-02-22  Adam Roben  <aroben@apple.com>
3188
3189         Don't trigger a Windows build when the top-level ChangeLog changes
3190
3191         r79320 is an example of a change that shouldn't have built on Windows, but did, because of
3192         this bug.
3193
3194         Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
3195         shouldn't
3196
3197         Reviewed by Anders Carlsson.
3198
3199         * Scripts/webkitpy/common/config/build.py:
3200         (_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
3201         ChangeLog, and re-sorted it in the list.
3202
3203         * Scripts/webkitpy/common/config/build_unittest.py:
3204         (ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.
3205
3206 2011-02-22  Sheriff Bot  <webkit.review.bot@gmail.com>
3207
3208         Unreviewed, rolling out r78691.
3209         http://trac.webkit.org/changeset/78691
3210         https://bugs.webkit.org/show_bug.cgi?id=54956
3211
3212         Leopard Debug is successfully building again (Requested by
3213         aroben on #webkit).
3214
3215         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3216         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3217
3218 2011-02-22  Ilya Tikhonovsky  <loislo@chromium.org>
3219
3220         Reviewed by Pavel Feldman.
3221
3222         Web Inspector: flakyness of inspector tests.
3223         https://bugs.webkit.org/show_bug.cgi?id=54729
3224
3225         As far as we have the protocol with sequence numbers we can simplify test harness support
3226         and drop out chomium specific methods.
3227
3228         * DumpRenderTree/DumpRenderTree.gypi:
3229         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3230         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
3231         (DRTDevToolsAgent::runtimePropertyChanged):
3232         (DRTDevToolsAgent::asyncCall):
3233         (DRTDevToolsAgent::call):
3234         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3235         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
3236         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
3237         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3238         (DRTDevToolsClient::sendMessageToBackend):
3239         (DRTDevToolsClient::asyncCall):
3240         (DRTDevToolsClient::call):
3241         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3242
3243 2011-02-22  Andras Becsi  <abecsi@webkit.org>
3244
3245         Reviewed by Laszlo Gombos.
3246
3247         [Qt] Redesign the build system
3248         https://bugs.webkit.org/show_bug.cgi?id=51339
3249
3250         Part 2.
3251
3252         Build WebCore as a static library, compile the WebKit API and WebKit2 API
3253         in a final step and link to WebKit2, WebCore and JSC libraries to fix
3254         linking issues resulting from stripped away symbols.
3255
3256         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.
3257
3258 2011-02-21  Lukasz Slachciak  <l.slachciak@samsung.com>
3259
3260         Reviewed by Antonio Gomes.
3261
3262         [EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
3263         https://bugs.webkit.org/show_bug.cgi?id=54806
3264
3265         * EWebLauncher/main.c:
3266         (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
3267
3268 2011-02-21  Dirk Pranke  <dpranke@chromium.org>
3269
3270         Reviewed by Kent Tamura.
3271
3272         nrwt: revert behavior on 10.5 to "old-threads". It's possible
3273         that r79062 has introduced a bunch of flakiness, although I
3274         can't explain why right now. This change should restore the
3275         old behavior, and then we can look at the build logs to see
3276         if the tests stop timing out or being flaky.
3277
3278         https://bugs.webkit.org/show_bug.cgi?id=54925
3279
3280         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3281         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3282         * Scripts/webkitpy/layout_tests/port/mac.py:
3283         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3284
3285 2011-02-21  Dirk Pranke  <dpranke@chromium.org>
3286
3287         Reviewed by Dimitri Glazkov.
3288
3289         nrwt: fix typo causing us to try and repeatedly shut down the servers
3290         https://bugs.webkit.org/show_bug.cgi?id=54904
3291
3292         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3293
3294 2011-02-21  Alejandro G. Castro  <alex@igalia.com>
3295
3296         Reviewed by Csaba Osztrogonác.
3297
3298         REGRESSION(r79157):
3299         plugins/get-url-with-javascript-destroying-plugin.html make the
3300         next test crash
3301         https://bugs.webkit.org/show_bug.cgi?id=54863
3302
3303         * GNUmakefile.am:
3304
3305 2011-02-20  Dirk Pranke  <dpranke@chromium.org>
3306
3307         Reviewed by Ojan Vafai.
3308
3309         test-webkitpy: stop skipping a bunch of tests on win32
3310         https://bugs.webkit.org/show_bug.cgi?id=54788
3311
3312         * Scripts/webkitpy/common/net/testoutputset_unittest.py:
3313         * Scripts/webkitpy/test/main.py:
3314
3315 2011-02-20  Dirk Pranke  <dpranke@chromium.org>
3316
3317         Reviewed by Ojan Vafai.
3318
3319         Fix various bugs related to handling of dir separators and real
3320         vs. fake filesystems that were causing test-webkitpy to fail
3321         tests on win32. These bugs have a variety of causes but are
3322         lumped together because they should be easy to review.
3323
3324         https://bugs.webkit.org/show_bug.cgi?id=54700
3325
3326         * Scripts/webkitpy/common/net/testoutput.py:
3327           Here we were using os.path.sep but not escaping it prior to
3328           using in a regexp, which  caused bad things on win32.
3329         * Scripts/webkitpy/common/net/testoutput_unittest.py:
3330           Same here.
3331         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3332           Here we were using the native filesystem instead of the mock
3333           filesystem, making some tests unnecessarily platform dependent.
3334           Also we weren't setting the default configuration for the
3335           TestChromiumWinPort.
3336         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
3337           Here we *shouldn't* use os.path.join(), just so the code becomes
3338           less platform dependent.
3339         * Scripts/webkitpy/style/checker.py:
3340           Here we should be using os.path.sep instead of "/"; the tests
3341           require the native filesystem.
3342         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3343           Here the underlying code is using os.path.sep, so we probably
3344           should as well.
3345         * Scripts/webkitpy/style/test_expectations_unittest.py:
3346           Here we should be using the filesystem hanging of the port
3347           object (which is the mocked filesystem) rather than the native
3348           one.
3349
3350 2011-02-20  Anders Carlsson  <andersca@apple.com>
3351
3352         Reviewed by Maciej Stachowiak.
3353
3354         Crash when a plug-in requests a javascript: url that destroys the plug-in
3355         https://bugs.webkit.org/show_bug.cgi?id=54837
3356         <rdar://problem/9005475>
3357
3358         Add new plug-in test.
3359
3360         * DumpRenderTree/DumpRenderTree.gypi:
3361         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3362         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3363         (PluginTest::NPN_GetURL):
3364         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3365         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added.
3366         (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin):
3367         (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
3368         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3369         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3370
3371 2011-02-19  Patrick Gansterer  <paroga@webkit.org>
3372
3373         Reviewed by Andreas Kling.
3374
3375         Make WinCE a core builder
3376         https://bugs.webkit.org/show_bug.cgi?id=54801
3377
3378         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3379         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3380
3381 2011-02-19  Lukasz Slachciak  <l.slachciak@samsung.com>
3382
3383         Reviewed by Andreas Kling.
3384
3385         Fixed problem with launching EWebLauncher with "run-launcher --efl". Incorrect path referring to non-existing .libs directory ws set.
3386         https://webkit.org/b/54778
3387
3388         * Scripts/webkitdirs.pm:
3389
3390 2011-02-18  David Levin  <levin@chromium.org>
3391
3392         Reviewed by Eric Seidel.
3393
3394         check-webkit-style: Misses brace style error when the line with the { has a } in it.
3395         https://bugs.webkit.org/show_bug.cgi?id=54769
3396
3397         * Scripts/webkitpy/style/checkers/cpp.py: Fixed the check for the close brace
3398           to only look after the last open brace, so that the open brace in this line
3399           "} else {" will still be able to trigger the error.
3400         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added related unit tests.
3401
3402 2011-02-18  Zan Dobersek  <zandobersek@gmail.com>
3403
3404         Reviewed by Martin Robinson.
3405
3406         [Gtk] Re-enable meter tag support
3407         https://bugs.webkit.org/show_bug.cgi?id=54762
3408
3409         Meter tag is supported on the Gtk port, enable it by default.
3410
3411         * Scripts/build-webkit:
3412
3413 2011-02-18  David Levin  <levin@chromium.org>
3414
3415         Reviewed by Eric Seidel.
3416
3417         check-webkit-style falsely complains about WebKitGTK+ public headers
3418         https://bugs.webkit.org/show_bug.cgi?id=54650
3419
3420         * Scripts/webkitpy/style/checker.py: Add some exceptions for the gtk files.
3421         * Scripts/webkitpy/style/checkers/cpp.py: Restrict the checks for WEBKIT_API
3422           to the chromium directory (and improved the checks slightly).
3423         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added corresponding tests.
3424
3425 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3426
3427         Reviewed by James Robinson.
3428
3429         new-run-webkit-tests: enable multiple processes by default on
3430         mac. This change removes the artificial restrictions we placed
3431         on the # of child processes we used with the old threading
3432         model, and switches to the new message-based model and multiple
3433         processes, where available. If multiple processes are not
3434         available (Leopard / Python 2.5), then we use the 'inline' model
3435         instead of the 'old-threads' model on the 'mac' port or one
3436         process on the 'chromium-mac' port. We need additional testing
3437         to see if the new 'threads' model works reliably and is worth
3438         supporting, or if we should just live with things being slightly
3439         slow.
3440
3441         https://bugs.webkit.org/show_bug.cgi?id=54596
3442
3443         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3444         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3445         * Scripts/webkitpy/layout_tests/port/mac.py:
3446         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3447         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3448
3449 2011-02-18  Andrew Wilson  <atwilson@chromium.org>
3450
3451         Unreviewed, rolling out r79047.
3452         http://trac.webkit.org/changeset/79047
3453         https://bugs.webkit.org/show_bug.cgi?id=54596
3454
3455         Broke canary bots - please watch the canaries the next time
3456         you land this
3457
3458         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3459         * Scripts/webkitpy/layout_tests/port/mac.py:
3460
3461 2011-02-18  Emil A Eklund  <eae@chromium.org>
3462
3463         Reviewed by Darin Adler.
3464
3465         Crash in EventHandler::sendContextMenuEventForKey
3466         https://bugs.webkit.org/show_bug.cgi?id=54495
3467
3468         Add support for the context menu key (VK_APPS) to EventSender for
3469         platforms that support the key.
3470
3471         * DumpRenderTree/chromium/EventSender.cpp:
3472         (EventSender::keyDown):
3473         * DumpRenderTree/gtk/EventSender.cpp:
3474         (keyDownCallback):
3475         * DumpRenderTree/qt/EventSenderQt.cpp:
3476         (EventSender::keyDown):
3477         * DumpRenderTree/win/EventSender.cpp:
3478         (keyDownCallback):
3479
3480 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3481
3482         Reviewed by Ojan Vafai.
3483
3484         new-run-webkit-tests: enable multiple processes by default on mac
3485         https://bugs.webkit.org/show_bug.cgi?id=54596
3486
3487         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3488         * Scripts/webkitpy/layout_tests/port/mac.py:
3489
3490 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3491
3492         Reviewed by Adam Roben.
3493
3494         Skip pretty patch unit tests if ruby isn't installed.
3495
3496         https://bugs.webkit.org/show_bug.cgi?id=54699
3497
3498         * Scripts/webkitpy/common/prettypatch_unittest.py:
3499
3500 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3501
3502         Reviewed by Adam Roben.
3503
3504         Skip mac.test_skipped_file_paths() when running on win32; the
3505         test has hardcoded '/' directory separators and since it's a
3506         port-specific test and we have coverage on other ports it's not
3507         worth it to make the test more generic.
3508
3509         https://bugs.webkit.org/show_bug.cgi?id=54698
3510
3511         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3512
3513 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3514
3515         Reviewed by Adam Roben.
3516
3517         Fix webkitpy.layout_tests.port.config_unittest to work on Win32.
3518
3519         https://bugs.webkit.org/show_bug.cgi?id=54703
3520
3521         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3522
3523 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3524
3525         Reviewed by Adam Roben.
3526
3527         Change the default port we're mocking out on win32 when we
3528         run mock_drt_unittest. Normally we'd default to the
3529         port-specific default, but that would be "win", which doesn't
3530         currently work.
3531
3532         https://bugs.webkit.org/show_bug.cgi?id=54708
3533
3534         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3535
3536 2011-02-18  Kenneth Russell  <kbr@google.com>
3537
3538         Reviewed by James Robinson.
3539
3540         [chromium] Clean up initialization of minimum timer interval
3541         https://bugs.webkit.org/show_bug.cgi?id=54772
3542
3543         Use new GetForegroundTabTimerInterval function in webkit_support
3544         to reset the minimum timer interval before each test.
3545
3546         * DumpRenderTree/chromium/WebViewHost.cpp:
3547         (WebViewHost::reset):
3548
3549 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3550
3551         Reviewed by Adam Roben.
3552
3553         r78494 fixed the chromium_win unittest failing under win32,
3554         but not cygwin. This fixes cygwin as well.
3555
3556         https://bugs.webkit.org/show_bug.cgi?id=54652
3557
3558         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3559
3560 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
3561
3562         Reviewed by Ojan Vafai, Mihai Parparita.
3563
3564         new-run-webkit-tests: r78522 made it impossible to create a
3565         'chromium-win' or 'chromium-mac' port; they would always get the
3566         version tacked on to the end. It turns out that we actually need
3567         to be able to create these ports in order for
3568         rebaseline-chromium-webkit-tests to work correctly given the
3569         broken coverage of our layout bots. As soon as we get SL and
3570         Win 7 bots running reliably on the canaries, we can get rid of
3571         this change. Note that we only need to change the chromium_mac
3572         and win ports because linux doesn't yet use versions and that
3573         script doesn't work with non-chromium ports.
3574
3575         Also, this change fixes a bug where we were using
3576         "platform/chromium-win-win7" and
3577         "platform/chromium-mac-snowleopard" as the baseline dirs for
3578         Win 7 and SL; we should've been using the generic directories
3579         instead since they are the newest versions of the os's.
3580
3581         https://bugs.webkit.org/show_bug.cgi?id=54691
3582
3583         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3584         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3585         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3586         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3587         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3588
3589 2011-02-16  MORITA Hajime  <morrita@google.com>
3590
3591         Reviewed by Kent Tamura.
3592
3593         [Chromium][DRT] some PostDelayedTask() accesses possibly dangling this pointer.
3594         http://webkit.org/b/53899
3595
3596         Replaced static invocation wrappers with MethodTask objects,
3597         which are removed on WebViewHost destructor.
3598         
3599         * DumpRenderTree/chromium/WebViewHost.cpp:
3600         (WebViewHost::requestCheckingOfText):
3601         (WebViewHost::scheduleAnimation):
3602         (WebViewHost::closeWidgetSoon):
3603         * DumpRenderTree/chromium/WebViewHost.h:
3604         (WebViewHost::HostMethodTask::HostMethodTask):
3605         (WebViewHost::HostMethodTask::runIfValid):
3606         (WebViewHost::taskList):
3607
3608 2011-02-07  Hayato Ito  <hayato@chromium.org>
3609
3610         Reviewed by Ojan Vafai.
3611
3612         Get rid of code which writes test results from test_type's
3613         compare_output() method.
3614         Writing test results now happens in single_test_runner, using
3615         newly introduced test_result_writer module.
3616
3617         Subsequent patches will eliminate test_type/* classes.
3618
3619         https://bugs.webkit.org/show_bug.cgi?id=53908
3620
3621         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3622         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added.
3623         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3624         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3625         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3626
3627 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
3628
3629         Reviewed by Adam Roben.
3630
3631         Add blacklist of remaining webkitpy/* modules that fail on
3632         Win32, so that test-webkitpy will at least run cleanly.
3633
3634         https://bugs.webkit.org/show_bug.cgi?id=54709
3635
3636         * Scripts/webkitpy/layout_tests/test/main.py:
3637
3638 2011-02-17  Simon Fraser  <simon.fraser@apple.com>
3639
3640         Reviewed by Sam Weinig.
3641
3642         Set a preference to ensure that scrollbars are in a predictable
3643         state for DRT.
3644
3645         * DumpRenderTree/mac/DumpRenderTree.mm:
3646         (resetDefaultsToConsistentValues):
364