[Win] Disable FTL stress tests
[WebKit-https.git] / Tools / ChangeLog
1 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
2
3         [Win] Disable FTL stress tests
4         https://bugs.webkit.org/show_bug.cgi?id=140932
5
6         Reviewed by Brent Fulgham.
7
8         * Scripts/run-javascriptcore-tests:
9
10 2015-01-27  Daniel Bates  <dabates@apple.com>
11
12         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
13         https://bugs.webkit.org/show_bug.cgi?id=140939
14
15         Reviewed by Eric Carlson.
16
17         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
18
19         * Scripts/webkitdirs.pm:
20         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
21         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
22         and define a function called wanted.
23
24 2015-01-27  Daniel Bates  <dabates@apple.com>
25
26         Teach run-webkit-app --simulator how to install custom built app
27         https://bugs.webkit.org/show_bug.cgi?id=140691
28
29         Fix inadvertent omission of directory test flag in expression to check for the
30         existence of the iOS simulator device-specific directory for user installed apps.
31
32         * Scripts/webkitdirs.pm:
33         (hasUserInstalledAppInSimulatorDevice):
34
35 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
36
37         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
38         https://bugs.webkit.org/show_bug.cgi?id=87426
39         <rdar://problem/11527899>
40
41         Reviewed by Darin Adler.
42
43         Revise COMPtr to work better with our HashMap implementation. Use
44         modern loop syntax.
45
46         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
47         (AccessibilityController::~AccessibilityController):
48         (AccessibilityController::winNotificationReceived):
49         * DumpRenderTree/win/DumpRenderTree.cpp:
50         (dumpBackForwardListForAllWindows):
51
52 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
53
54         [Win] Enable JSC stress tests by default
55         https://bugs.webkit.org/show_bug.cgi?id=128307
56
57         Reviewed by Brent Fulgham.
58
59         * Scripts/run-javascriptcore-tests:
60
61 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
62
63         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
64         arguments for build and test scripts
65         https://bugs.webkit.org/show_bug.cgi?id=139748
66
67         Reviewed by Daniel Bates.
68
69         There was much confusion resulting from the multitude of aliases used to build/test for
70         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
71         tests directory.
72
73         This fixes an issue where run-api-tests and some other scripts failed when run with
74         --simulator.
75
76         * Scripts/build-webkit:
77         * Scripts/package-root:
78         (usage):
79         * Scripts/webkitdirs.pm:
80         (argumentsForConfiguration):
81         (determineXcodeSDK):
82         * Scripts/webkitpy/port/factory.py:
83         (platform_options):
84
85 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
86
87         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
88         https://bugs.webkit.org/show_bug.cgi?id=140203
89         rdar://problem/19198492
90
91         Reviewed by Sam Weinig.
92
93         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
94         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
95         (TEST):
96
97 2015-01-26  David Kilzer  <ddkilzer@apple.com>
98
99         Add iOS EWS to build.webkit.org/dashboard
100         <http://webkit.org/b/140627>
101
102         Reviewed by Alexey Proskuryakov.
103
104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
107         (BubbleQueueServer): Add ios-ews queue info.
108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
109         Add iOS8Device platform.
110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
111         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
112         iOS device logo.
113
114 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
115
116         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
117         https://bugs.webkit.org/show_bug.cgi?id=140896
118
119         Reviewed by Michael Saboff.
120         
121         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
122         makes our script do this.
123         
124         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
125         this would be harder given llvm's autoconf setup.
126
127         * Scripts/copy-webkitlibraries-to-product-directory:
128
129 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
130
131         Update bot assignments.
132
133         * BuildSlaveSupport/build.webkit.org-config/config.json:
134
135 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
136
137         Integrate WP python server into WebKit test framework
138         https://bugs.webkit.org/show_bug.cgi?id=127094
139
140         Reviewed by Ryosuke Niwa.
141
142         This patch adds W3C web server (wptserver) as a new HTTP server.
143         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
144         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
145
146         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
147         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
148         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
149
150         * Scripts/webkitpy/common/system/executive_mock.py:
151         (MockProcess.communicate):
152         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
153         (LayoutTestRunner.__init__):
154         (LayoutTestRunner.run_tests):
155         (LayoutTestRunner.start_servers):
156         (LayoutTestRunner.stop_servers):
157         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
158         (LayoutTestRunnerTests._run_tests):
159         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
160         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
161         (LayoutTestRunnerTests):
162         (LayoutTestRunnerTests.test_servers_started):
163         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
164         (Manager.__init__):
165         (Manager._is_http_test):
166         (Manager._is_web_platform_test):
167         (Manager._run_tests):
168         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
169         (ManagerTest.test_needs_servers.get_wpt_doc_root):
170         (ManagerTest.test_needs_servers.get_manager):
171         (ManagerTest.test_needs_servers):
172         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
173         (parse_args):
174         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
175         (main):
176         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
177         (doc_root):
178         (base_url):
179         (WebPlatformTestServer):
180         (WebPlatformTestServer.__init__):
181         (WebPlatformTestServer._set_start_cmd):
182         (WebPlatformTestServer._copy_webkit_test_files):
183         (WebPlatformTestServer._clean_webkit_test_files):
184         (WebPlatformTestServer._prepare_config):
185         (WebPlatformTestServer._spawn_process):
186         (WebPlatformTestServer._stop_running_server):
187         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
188         (TestWebPlatformTestServer):
189         (TestWebPlatformTestServer.test_start_cmd):
190         * Scripts/webkitpy/port/base.py:
191         (Port.__init__):
192         (Port.to.start_web_platform_test_server):
193         (Port.to):
194         (Port.to.web_platform_test_server_doc_root):
195         (Port.to.web_platform_test_server_base_url):
196         (Port.to.stop_web_platform_test_server):
197         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
198         (Driver.__init__):
199         (Driver.is_web_platform_test):
200         (Driver.test_to_uri):
201         (Driver.uri_to_test):
202         (Driver._command_from_driver_input):
203         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
204         (DriverTest.test_test_to_uri):
205         (DriverTest.test_uri_to_test):
206
207 2015-01-26  Daniel Bates  <dabates@apple.com>
208
209         Teach run-webkit-app --simulator how to install custom built app
210         https://bugs.webkit.org/show_bug.cgi?id=140691
211
212         Reviewed by David Kilzer.
213
214         We should teach run-webkit-app --simulator how to install a custom built app.
215
216         Currently run-webkit-app --simulator can only run a system app or an app that
217         was installed using the simctl command line tool. For convenience we should
218         teach run-webkit-app --simulator how to install a custom built app.
219
220         As a side effect of this change run-safari --simulator will install and run
221         a custom built of MobileSafari (if it exists).
222
223         * Scripts/webkitdirs.pm:
224         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
225         Perl from the structure of the device.plist file.
226         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
227         file system check to determine the plist path for a Mac app bundle.
228         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
229         it will complain that it cannot find the file: "Domain ... does not exist".
230         (appDisplayNameFromBundle): Ditto.
231         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
232         until a simulator device is the specified state.
233         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
234         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
235         the specified device.
236         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
237         As implied by its name, this function will not return until the specified simulator
238         device UDID is in the shutdown state.
239         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
240         device with the specified UDID.
241         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
242         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
243         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
244         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
245         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
246         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
247         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
248         (hasUserInstalledAppInSimulatorDevice): Added.
249         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
250         "Booted" state.
251         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
252         switching between a system installed app and a custom built version of the same app (e.g.
253         custom build of MobileSafari) will erase all contents and settings in the simulator device.
254         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
255         as that was the only caller of this function.
256         (bootedIOSSimulatorDevice): Deleted.
257         (openIOSSimulator): Deleted.
258
259 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
260
261         Update bot assignments.
262
263         * BuildSlaveSupport/build.webkit.org-config/config.json:
264
265 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
266
267         Leaks bot shouldn't run JSC tests
268         https://bugs.webkit.org/show_bug.cgi?id=140877
269
270         Reviewed by Darin Adler.
271
272         Shaves off 48 minutes of time.
273
274         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
275         (TestLeaksFactory): Slim down the leaks queue.
276
277         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
278         * Scripts/webkitpy/port/ios.py:
279         (IOSSimulatorPort.print_leaks_summary):
280         * Scripts/webkitpy/port/mac.py:
281         (MacPort.print_leaks_summary):
282         Don't yell when leaks are detected.
283
284 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
285
286         Refactor run-javascriptcore-tests
287         https://bugs.webkit.org/show_bug.cgi?id=140824
288
289         Reviewed by Darin Adler.
290
291         Separated mozilla, stress test code paths and
292         determining skipped mozilla tests into subroutines.
293
294         * Scripts/run-javascriptcore-tests:
295         (runMozillaTests):
296         (runJSCStressTests):
297         (defaultJsDriverArgsForMozillaTests):
298
299 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
300
301         [buildbot] Fix grammar of TestWithFailureCount
302         https://bugs.webkit.org/show_bug.cgi?id=140884
303
304         Reviewed by Alexey Proskuryakov.
305
306         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
307         (TestWithFailureCount):
308         (TestWithFailureCount.commandComplete):
309         (TestWithFailureCount.getText2):
310         (RunUnitTests):
311         (RunPythonTests):
312         (RunPerlTests):
313         (RunLLINTCLoopTests):
314         (Run32bitJSCTests):
315         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
316         (RunLLINTCLoopTestsTest.test_failure):
317         (Run32bitJSCTestsTest.test_failure):
318         (RunUnitTestsTest.assertFailures):
319
320 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
321
322         Unreviewed. Moving myself to the committer section.
323
324         * Scripts/webkitpy/common/config/contributors.json:
325
326 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
327
328         [GTK] gtkdoc does not appear in DevHelp
329         https://bugs.webkit.org/show_bug.cgi?id=139369
330
331         Reviewed by Philippe Normand.
332
333         * gtk/generate-gtkdoc: Create the generators in the main function
334         and use them to get the local cross renference dependencies. Also
335         pass the generator module name to webkitdom.write_doc_files().
336         (get_gtkdoc_module_paths): Receive a list of local cross reference
337         dependencies.
338         (get_generator_for_config): Set the main_sgml_file property of the
339         GtkDoc object from the configuration file.
340         (generate_documentation): Generate the documentation for the given
341         generator.
342         (generate_documentation_for_config): Deleted.
343         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
344         * gtk/webkitdom.py:
345         (write_doc_files): Receive the module name used to build the
346         -sections.txt filename.
347
348 2015-01-26  Commit Queue  <commit-queue@webkit.org>
349
350         Unreviewed, rolling out r179107.
351         https://bugs.webkit.org/show_bug.cgi?id=140880
352
353         The GCC in the bots doesn't support the AsyncTask
354         implementation (Requested by KaL on #webkit).
355
356         Reverted changeset:
357
358         "[GTK] Enable IndexedDB"
359         https://bugs.webkit.org/show_bug.cgi?id=98932
360         http://trac.webkit.org/changeset/179107
361
362 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
363
364         [EFL] Bump libseccomp version to 2.1.1
365         https://bugs.webkit.org/show_bug.cgi?id=140357
366
367         Reviewed by Gyuyoung Kim.
368
369         * efl/jhbuild.modules:
370
371 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
372
373         [GTK] Enable IndexedDB
374         https://bugs.webkit.org/show_bug.cgi?id=98932
375
376         Reviewed by Žan Doberšek.
377
378         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
379
380 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
381
382         Would like leaks bot results at build.webkit.org/dashboard
383         https://bugs.webkit.org/show_bug.cgi?id=122657
384
385         Reviewed by Darin Adler.
386
387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
388         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
389         than necessary, could use the ones from buildbot in more places.
390
391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
392         (BuildbotQueue): Reflect configuration option for leaks queues.
393
394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
395         Add leaks queues to performance column. First, leaks are about performance indeed,
396         and second, this is where we have some space to spare.
397
398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
399         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
400         least a year.
401
402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
403         (table.queue-grid td): Moved height from queue-view - we can now have more than one
404         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
405         results - once the results are loaded, all rows are currently higher than that.
406
407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
408         (.leaks-popover): Added.
409
410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
411         Added.
412
413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
414         Load BuildbotLeaksQueueView.js.
415
416 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
417
418         [Win] Add WebKit message loop interface.
419         https://bugs.webkit.org/show_bug.cgi?id=140857
420
421         Reviewed by Brent Fulgham.
422
423         Added message loop interface which will run the message loop,
424         and perform required tasks (like calling CFRunLoopRunInMode)
425         on each iteration of the loop.
426
427         * WinLauncher/WinMain.cpp:
428         (wWinMain): Use new message loop interface.
429
430 2015-01-24  Dan Bernstein  <mitz@apple.com>
431
432         update-webkit’s --internal option is unused
433         https://bugs.webkit.org/show_bug.cgi?id=140861
434
435         Reviewed by Anders Carlsson.
436
437         * Scripts/update-webkit: Removed the option.
438
439 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
440
441         DumpRenderTree needs to run with Windows native controls on Windows
442         https://bugs.webkit.org/show_bug.cgi?id=25592
443
444         Reviewed by Anders Carlsson.
445
446         * DumpRenderTree/win/DumpRenderTree.cpp:
447         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
448         (prepareConsistentTestingEnvironment): Ditto.
449
450 2015-01-23  David Kilzer  <ddkilzer@apple.com>
451
452         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
453         <http://webkit.org/b/140787>
454
455         Reviewed by Daniel Bates.
456
457         * Scripts/webkitpy/port/ios.py:
458         (IOSPort.determine_full_port_name): Instead of checking the type
459         of the current host, test if /usr/bin/xcrun exists before trying
460         to use it.
461
462 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
463
464         Fix the false positive build failures on the Windows buildbots
465         https://bugs.webkit.org/show_bug.cgi?id=140819
466
467         Reviewed by Brent Fulgham.
468
469         Increase the build timeout (without producing output) to 2 hours for Windows bots,
470         the default 20 minutes is enough for others since they produce output during the build.
471
472         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
473         (BuildFactory.__init__):
474
475 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
476
477         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
478         https://bugs.webkit.org/show_bug.cgi?id=140839
479
480         Reviewed by Dean Jackson.
481
482         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
483         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
484         from the IA2Locale structure and pass it to DRT.
485
486 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
487
488         [Win] Update DRT Accessibility implementation to better match Mac.
489         https://bugs.webkit.org/show_bug.cgi?id=140830
490
491         Reviewed by Dean Jackson.
492
493         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
494         (AccessibilityUIElement::titleUIElement):
495         (AccessibilityUIElement::parentElement):
496         (convertToDRTLabel):
497         (AccessibilityUIElement::role):
498         (AccessibilityUIElement::title):
499         (AccessibilityUIElement::description):
500         (AccessibilityUIElement::stringValue):
501         (AccessibilityUIElement::helpText):
502         (AccessibilityUIElement::isFocused):
503
504 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
505
506         REGRESSION: run-perf-tests --profiler= seems to have broken
507         https://bugs.webkit.org/show_bug.cgi?id=113528
508
509         Reviewed by Daniel Bates.
510
511         The problem is that "perf --record" (or the equivalent call for
512         other profilers) is never called whenever there is a wrapper
513         option in the port. We should inject the profiler call first
514         (should it exists) and then use the port wrapper.
515
516         * Scripts/webkitpy/port/driver.py:
517         (Driver._command_wrapper):
518         * Scripts/webkitpy/port/driver_unittest.py:
519         (DriverTest.test_profiler_and_wrapper): New unit test.
520
521 2015-01-22  David Kilzer  <ddkilzer@apple.com>
522
523         configure-xcode-for-ios-development needs to import webkitdirs.pm
524         <http://webkit.org/b/140704>
525
526         Fixes the following runtime error:
527
528             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
529
530         * Scripts/configure-xcode-for-ios-development: Add back code to
531         import webkitdirs.pm for the exitStatus() method.  Not sure why
532         I removed it before patch review.
533
534 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
535
536         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
537         https://bugs.webkit.org/show_bug.cgi?id=140795
538
539         Reviewed by Jon Honeycutt.
540
541         * BuildSlaveSupport/build.webkit.org-config/config.json:
542         r178847 accidentally remove the scheduler for this bot. Re-add it to the
543         Yosemite scheduler.
544
545 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
546
547         [Win] Expose missing editing features through WebView interface
548         https://bugs.webkit.org/show_bug.cgi?id=140773
549         <rdar://problem/19565421>
550
551         Reviewed by Dean Jackson.
552
553         Connect the various WebView editing delegate methods to our
554         test infrastructure. Also prefer _bstr_t to raw BSTR types
555         to simplify life cycle management.
556
557         * DumpRenderTree/win/DumpRenderTree.cpp:
558         (resetWebViewToConsistentStateBeforeTesting):
559         * DumpRenderTree/win/EditingDelegate.cpp:
560         (EditingDelegate::QueryInterface):
561         (dumpPath):
562         (dump):
563         (EditingDelegate::shouldBeginEditingInDOMRange):
564         (EditingDelegate::shouldEndEditingInDOMRange):
565         (EditingDelegate::shouldInsertNode):
566         (EditingDelegate::shouldInsertText):
567         (EditingDelegate::shouldDeleteDOMRange):
568         (EditingDelegate::shouldChangeSelectedDOMRange):
569         (EditingDelegate::shouldApplyStyle):
570         (EditingDelegate::shouldChangeTypingStyle):
571         (EditingDelegate::doPlatformCommand):
572         (EditingDelegate::webViewDidBeginEditing):
573         (EditingDelegate::webViewDidChange):
574         (EditingDelegate::webViewDidEndEditing):
575         (EditingDelegate::webViewDidChangeTypingStyle):
576         (EditingDelegate::webViewDidChangeSelection):
577         (EditingDelegate::checkSpellingOfString):
578         (EditingDelegate::onNotify):
579         * DumpRenderTree/win/EditingDelegate.h:
580
581 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
582
583         Add a build flag for ES6 class syntax
584         https://bugs.webkit.org/show_bug.cgi?id=140760
585
586         Reviewed by Michael Saboff.
587
588         * Scripts/webkitperl/FeatureList.pm:
589
590 2015-01-22  Daniel Bates  <dabates@apple.com>
591
592         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
593         runtime in simctl output
594         https://bugs.webkit.org/show_bug.cgi?id=140751
595
596         Reviewed by David Kilzer.
597
598         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
599         with an error because it does not know how to parse the output of the simctl tool
600         to identify an Apple Internal runtime.
601
602         * Scripts/webkitpy/xcode/simulator.py:
603         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
604         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
605         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
606         the runtime is an internal runtime.
607         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
608         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
609         appropriate value.
610         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
611         it updates the appropriate Runtime object.
612         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
613         looking up a Runtime object for an internal runtime.
614
615 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
616
617         LeaksViewer doesn't show recent builds if there are less than 10
618         https://bugs.webkit.org/show_bug.cgi?id=140716
619
620         Reviewed by Tim Horton.
621
622         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
623
624 2015-01-22  Lucas Forschler  <lforschler@apple.com>
625
626         Add Apple build slaves.
627         Fixed text alignment for slave list.
628         
629         Unreviewed.
630         
631         * BuildSlaveSupport/build.webkit.org-config/config.json:
632
633 2015-01-21  Lucas Forschler  <lforschler@apple.com>
634
635         Teach build.webkit.org about bot308 and bot309.
636         
637         Unreviewed.
638         
639         * BuildSlaveSupport/build.webkit.org-config/config.json:
640
641 2015-01-21  Lucas Forschler  <lforschler@apple.com>
642
643         Add two Apple Mavericks slaves.
644         
645         Unreviewed.
646         
647         * BuildSlaveSupport/build.webkit.org-config/config.json:
648
649 2015-01-21  Daniel Bates  <dabates@apple.com>
650
651         Add iOS WebKit1 TestExpectation file
652         https://bugs.webkit.org/show_bug.cgi?id=140739
653
654         Reviewed by David Kilzer.
655
656         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
657         expectations in directory LayoutTests/platform/ios-simulator-wk1.
658
659         * Scripts/webkitpy/port/ios.py:
660         (IOSSimulatorPort.default_baseline_search_path):
661
662 2015-01-21  David Kilzer  <ddkilzer@apple.com>
663
664         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
665         <http://webkit.org/b/140704>
666
667         Reviewed by Daniel Bates.
668
669         * Scripts/configure-xcode-for-ios-development:
670         - Update copyright.
671         - Remove FIXME addressed by r178709.
672         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
673         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
674         missing headers from iphonesimulator SDK to iphoneos SDK.
675         (sdkDirectory): Add method that returns SDK directory.
676         (sdkPlatformDirectory): Extract method from
677         xcodeSDKSpecificationsPath() that returns SDK platform
678         directory.
679         (xcodeSDKSpecificationsPath): Update to use
680         sdkPlatformDirectory().
681
682 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
683
684         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
685         https://bugs.webkit.org/show_bug.cgi?id=140731
686
687         Reviewed by Tim Horton.
688
689         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
690         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
691
692 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
693
694         [Win] eventSender does not support scalePageBy
695         https://bugs.webkit.org/show_bug.cgi?id=140726
696         <rdar://problem/19549865>
697
698         Reviewed by Dean Jackson.
699
700         * DumpRenderTree/win/EventSender.cpp:
701         (scalePageByCallback): Provide implementation using new WebView method.
702
703 2015-01-21  Lucas Forschler  <lforschler@apple.com>
704
705         Remove Apple Mountain Lion Build & Test slaves.
706         
707         Unreviewed.
708
709         * BuildSlaveSupport/build.webkit.org-config/config.json:
710
711 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
712
713         Remove ENABLE(INSPECTOR) ifdef guards
714         https://bugs.webkit.org/show_bug.cgi?id=140668
715
716         Reviewed by Darin Adler.
717
718         * DumpRenderTree/mac/TestRunnerMac.mm:
719         (TestRunner::showWebInspector):
720         (TestRunner::closeWebInspector):
721         (TestRunner::evaluateInWebInspector):
722         * Scripts/webkitperl/FeatureList.pm:
723         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
724         (WTR::TestRunner::showWebInspector):
725         (WTR::TestRunner::closeWebInspector):
726         (WTR::TestRunner::evaluateInWebInspector):
727         * WebKitTestRunner/TestInvocation.cpp:
728         (WTR::TestInvocation::invoke):
729
730 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
731
732         Update build.webkit.org/dashboard to match current Mac queues.
733
734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
741         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
742         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
743
744 2015-01-20  Lucas Forschler  <lforschler@apple.com>
745
746         Update Apple MountainLion Leaks slave to Yosemite
747         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
748         
749         Unreviewed.
750
751         * BuildSlaveSupport/build.webkit.org-config/config.json:
752
753 2015-01-20  Lucas Forschler  <lforschler@apple.com>
754
755         Update LeaksViewer from MountainLion to Yosemite
756         
757         Reviewed by Alexey Proskuryakov.
758
759         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
760         (LeaksViewer._displayURLPrompt):
761
762 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
763
764         Fix EWS python unit tests and address code comments as per 140476
765         https://bugs.webkit.org/show_bug.cgi?id=140637
766
767         Reviewed by David Kilzer.
768
769         * Scripts/webkitpy/port/base.py:
770         (Port):
771         (Port.__init__):
772         Adds DEFAULT_ARCHITECTURE member.
773         (Port.architecture):
774         Removes architecture member and instead uses
775         self.get_option('architecture'). Also removes redundant architecture
776         method.
777         (Port.set_architecture):
778         Adds a setter for the architecture variable to be able to set a flag
779         upon modification.
780         (Port.test_configuration):
781         Uses self.architecture() instead of self._architecture.
782         * Scripts/webkitpy/port/ios.py:
783         Overrides DEFAULT_ARCHITECTURE.
784         (IOSPort):
785         (IOSPort.determine_full_port_name):
786         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
787         strip. Fixes regex to not match arbitrary characters after the
788         relevent digits are matched.
789         (IOSPort.__init__):
790         Removes old _architecture defaulting strategy.
791         (IOSPort._build_driver_flags):
792         Uses self.architecture() instead of self._architecture.
793         (IOSSimulatorPort):
794         Overrides DEFAULT_ARCHITECTURE.
795         (IOSSimulatorPort.__init__):
796         Removes old _architecture defaulting strategy.
797         * Scripts/webkitpy/port/mac.py:
798         (MacPort):
799         Overrides DEFAULT_ARCHITECTURE.
800         (MacPort.__init__):
801         Removes old _architecture defaulting strategy.
802         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
803         (AbstractEarlyWarningSystem.run_command):
804         Checks the did_override_architecture flag to determine whether to add
805         the --architecture option.
806         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
807         Uses ews.architecture rather than trying to discern the correct
808         architecture using a port object.
809         (EarlyWarningSystemTest._default_expected_logs):
810         * Scripts/webkitpy/tool/commands/queues.py:
811         Removes use of optparse, and removes the import statement.
812         (AbstractQueue.__init__):
813         (PatchProcessingQueue.begin_work_queue):
814
815 2015-01-20  Sam Weinig  <sam@webkit.org>
816
817         Attempt to fix Mountain Lion and EFL tests.
818
819         * WebKitTestRunner/TestController.cpp:
820         (WTR::TestController::initialize):
821         Disable Process-per-tab and network process on Mountain Lion and EFL.
822
823 2015-01-20  Darin Adler  <darin@apple.com>
824
825         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
826         https://bugs.webkit.org/show_bug.cgi?id=140679
827
828         Reviewed by Anders Carlsson.
829
830         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
831         Removed a reference to SVGElementInstanceList.
832
833 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
834
835         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
836         https://bugs.webkit.org/show_bug.cgi?id=140028
837
838         Reviewed by Carlos Garcia Campos.
839
840         This won't work as expected, since this function is called before the
841         WebViewTest constructor completes.
842
843         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
844
845 2015-01-20  David Kilzer  <ddkilzer@apple.com>
846
847         configure-xcode-for-ios-development needs to update iPhoneOS SDK
848         <http://webkit.org/b/140661>
849
850         Reviewed by Daniel Bates.
851
852         * Scripts/configure-xcode-for-ios-development: Add for() loop to
853         run createXcodeSpecificationFilesForSDKIfNeeded() for both
854         "iphoneos" and "iphonesimulator" SDKs.
855         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
856         the main body of the script.
857
858 2015-01-20  Tomas Popela  <tpopela@redhat.com>
859
860         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
861         https://bugs.webkit.org/show_bug.cgi?id=139443
862
863         Reviewed by Carlos Garcia Campos.
864
865         Create the new test cases for setting the editable property on the web
866         view and on the contenteditable enabled document. Also rework the
867         current tests that are expecting that the web view is editable.
868
869         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
870         (loadTestHtml):
871         (testWebViewEditorCutCopyPasteNonEditable):
872         (testWebViewEditorCutCopyPasteEditable):
873         (testWebViewEditorSelectAllNonEditable):
874         (testWebViewEditorSelectAllEditable):
875         (runEditorEditableCutTests):
876         (testWebViewEditorEditableOnNonEditable):
877         (testWebViewEditorEditableOnContentEditable):
878         (testWebViewEditorNonEditable):
879         (beforeAll):
880         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
881         (WebViewTest::isEditable):
882         (WebViewTest::setEditable):
883
884 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
885
886         [GTK] Add an option to create WebKitWebView snapshots with transparent background
887         https://bugs.webkit.org/show_bug.cgi?id=140617
888
889         Reviewed by Gustavo Noronha Silva.
890
891         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
892         (testWebViewSnapshot): Check that the same snapshot with
893         transparent background is different than the default one filled
894         with white.
895
896 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
897
898         [GTK] Add API to change the WebKitWebView background color
899         https://bugs.webkit.org/show_bug.cgi?id=140610
900
901         Reviewed by Gustavo Noronha Silva.
902
903         Add --bg-color command line option to MiniBrowser to be able to
904         manually test the API passing any RGBA color to MiniBrowser.
905         Also add a simple unit test to check that getting and setting
906         colors from the API point of view.
907
908         * MiniBrowser/gtk/BrowserWindow.c:
909         (browser_window_set_background_color):
910         * MiniBrowser/gtk/BrowserWindow.h:
911         * MiniBrowser/gtk/main.c:
912         (createBrowserWindow):
913         (parseBackgroundColor):
914         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
915         (testWebViewBackgroundColor):
916         (beforeAll):
917
918 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
919
920         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
921         https://bugs.webkit.org/show_bug.cgi?id=140665
922
923         Reviewed by Brian Burg.
924
925         * DumpRenderTree/win/UIDelegate.cpp:
926         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
927         match expected test output.
928
929 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
930
931         Remove the support for custom suffixes on ChangeLog
932         https://bugs.webkit.org/show_bug.cgi?id=140648
933
934         Reviewed by David Kilzer.
935
936         Custom suffixes were used for the iOS branch of WebKit.
937         Now that everything is opensource, there is no need for it.
938
939         * Scripts/VCSUtils.pm:
940         (changeLogSuffix): Deleted.
941         (changeLogFileName): Deleted.
942         * Scripts/commit-log-editor:
943         * Scripts/prepare-ChangeLog:
944         (getLatestChangeLogs):
945         (generateNewChangeLogs):
946         (generateFileList):
947         * Scripts/resolve-ChangeLogs:
948         (findChangeLog):
949
950 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
951
952         Adjust naming of action menu SPI
953         https://bugs.webkit.org/show_bug.cgi?id=140644
954         <rdar://problem/19448129>
955
956         Reviewed by Brian Weinstein.
957
958         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
959         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
960         (TestWebKitAPI::TEST):
961
962 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
963
964         [GTK] Generate the make dist manifest from a CMake template file
965         https://bugs.webkit.org/show_bug.cgi?id=139387
966
967         Reviewed by Martin Robinson.
968
969         Remove the code that performs variable substitution on manifest.txt.
970         Replace the custom variables used in that file with CMake variables.
971
972         * gtk/make-dist.py:
973         (Manifest.add_directory):
974         (Manifest.get_full_source_path):
975         (Manifest.process_line):
976         (Manifest.resolve_variables): Deleted.
977         (Manifest.get_full_tarball_path): Deleted.
978         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
979
980 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
981
982         [Win] Correct merge error in last commit.
983
984         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
985         (findAccessibleObjectById): Undo accidental paste made during landing.
986
987 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
988
989         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
990         https://bugs.webkit.org/show_bug.cgi?id=139906
991
992         Reviewed by Dean Jackson.
993
994         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
995         to use them. This patch fixes that.
996
997         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
998         (findAccessibleObjectById):
999         (AccessibilityController::focusedElement):
1000         (logEventProc):
1001         (notificationListenerProc):
1002         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1003         (AccessibilityUIElement::getChildAtIndex):
1004         (AccessibilityUIElement::titleUIElement):
1005         (self):
1006         (AccessibilityUIElement::role):
1007         (AccessibilityUIElement::valueDescription):
1008         (accessibilityState):
1009         (AccessibilityUIElement::isChecked):
1010         * DumpRenderTree/win/DumpRenderTree.cpp:
1011         (dumpFrameScrollPosition):
1012         (dumpFramesAsText):
1013         * DumpRenderTree/win/PolicyDelegate.cpp:
1014         (PolicyDelegate::decidePolicyForNavigationAction):
1015         * DumpRenderTree/win/UIDelegate.cpp:
1016         (UIDelegate::exceededDatabaseQuota):
1017         * WinLauncher/Common.cpp:
1018         (setWindowText):
1019
1020 2015-01-19  Dean Jackson  <dino@apple.com>
1021
1022         Add "override" to fix the build with newer clangs.
1023
1024         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1025         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
1026
1027 2015-01-19  David Kilzer  <ddkilzer@apple.com>
1028
1029         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
1030         <http://webkit.org/b/140623>
1031
1032         Reviewed by Daniel Bates.
1033
1034         * Scripts/build-webkit: Update help for --device switch.
1035         * Scripts/webkitdirs.pm:
1036         (determineXcodeSDK): When passing --device, prefer the internal
1037         iOS SDK if it exists, else fall back to the external iOS SDK.
1038         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
1039         xcodebuild instead of trying to sanitize values.
1040
1041 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
1042
1043         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
1044         https://bugs.webkit.org/show_bug.cgi?id=140606
1045
1046         Reviewed by Csaba Osztrogonác.
1047
1048         * Scripts/webkitpy/bindings/main.py:
1049         (BindingsTests.generate_supplemental_dependency):
1050         (BindingsTests.main):
1051
1052 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1053
1054         [GTK] [WK2] TestWebKitWebView snapshot fails
1055         https://bugs.webkit.org/show_bug.cgi?id=120404
1056
1057         Reviewed by Žan Doberšek.
1058
1059         Rework the test to make sure the snapshot is always created at the
1060         desired size.
1061
1062         * Scripts/run-gtk-tests:
1063         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
1064         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1065         (testWebViewSnapshot): Use a fixed size for the document, and
1066         disable scrollbars to make sure the visible area is always the
1067         WebView size.
1068         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1069         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
1070         and height parameters to create the window with a given size.
1071         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1072
1073 2015-01-18  David Kilzer  <ddkilzer@apple.com>
1074
1075         iOS EWS queue name should be consistent
1076         <http://webkit.org/b/140585>
1077
1078         Reviewed by Daniel Bates.
1079
1080         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
1081         to 'ios'.
1082         * Scripts/webkitpy/common/config/ports.py: Ditto.
1083         (DeprecatedPort.port):
1084         (IOSPort):
1085         * Scripts/webkitpy/port/ios.py: Ditto.
1086         (IOSPort):
1087
1088         * Scripts/webkitpy/port/factory.py:
1089         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
1090         appears before ios.IOSPort.  If this is not done,
1091         `run-webkit-tests --ios-simulator` will get the wrong Port class
1092         (IOSPort instead of IOSSimulatorPort) due to the way that
1093         PortFactory.get() uses prefix matching of <Port>.port_name to
1094         find the correct class to use.
1095
1096 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
1097
1098         build.webkit.org/dashboard: OS X EWS is now on Mavericks
1099         https://bugs.webkit.org/show_bug.cgi?id=140595
1100
1101         Reviewed by Csaba Osztrogonác.
1102
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1104         (BubbleQueueServer):
1105
1106 2015-01-17  David Kilzer  <ddkilzer@apple.com>
1107
1108         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
1109
1110         * Scripts/webkitpy/port/ios.py:
1111         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
1112         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
1113         the Mountain Lion and Mavericks bots.
1114
1115 2015-01-17  David Kilzer  <ddkilzer@apple.com>
1116
1117         Attempt to fix webkitpy tests on GTK Linux ports
1118
1119         * Scripts/webkitpy/port/ios.py:
1120         (IOSPort.determine_full_port_name): Set a sensible default if
1121         not running on a Mac platform or if no iOS SDK is installed.
1122
1123 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
1124
1125         Create iOS-EWS client queue
1126         https://bugs.webkit.org/show_bug.cgi?id=140476
1127
1128         Reviewed by Alexey Proskuryakov.
1129
1130         * EWSTools/start-queue-mac.sh:
1131         Adds call to configure-xcode-for-ios-development for iOS EWS.
1132         * Scripts/webkitpy/common/config/ews.json:
1133         Adds the iOS EWS config entry.
1134         * Scripts/webkitpy/common/config/ports.py:
1135         (DeprecatedPort.port):
1136         Adds IOSPort to the port map.
1137         (IOSPort):
1138         (IOSPort.build_webkit_command):
1139         Adds --sdk=iphoneos to the webkit build command.
1140         * Scripts/webkitpy/port/base.py:
1141         (Port.architecture):
1142         Adds an accessor for the architecture member variable.
1143         * Scripts/webkitpy/port/factory.py:
1144         (PortFactory):
1145         Adds IOSPort to the port class list.
1146         * Scripts/webkitpy/port/ios.py:
1147         Adds the IOSPort to encapsulate iOS-specific things.
1148         (IOSPort):
1149         (IOSPort.determine_full_port_name):
1150         (IOSPort.__init__):
1151         (IOSPort._build_driver_flags):
1152         (IOSPort.operating_system):
1153         * Scripts/webkitpy/tool/commands/download_unittest.py:
1154         Adds the archetecture option to the mock options.
1155         (DownloadCommandsTest._default_options):
1156         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1157         Appends the archetecture option into calls to webkit-patch.
1158         (AbstractEarlyWarningSystem.review_patch):
1159         (AbstractEarlyWarningSystem.run_command):
1160         (AbstractEarlyWarningSystem.load_ews_classes):
1161         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1162         Adds logic to soothe the unittest now that --architecture is being
1163         thrown around everywhere.
1164         (EarlyWarningSystemTest._default_expected_logs):
1165         * Scripts/webkitpy/tool/commands/queues.py:
1166         Adds glue code to ferry the --architecture option around.
1167         (AbstractQueue.__init__):
1168         (PatchProcessingQueue.begin_work_queue):
1169         * Scripts/webkitpy/tool/steps/abstractstep.py:
1170         Adds the archetecture option to all AbstractSteps so that
1171         EarlyWarningSystem doesn't start shoving --architecture into
1172         unsuspecting commands.
1173         (AbstractStep.options):
1174         * Scripts/webkitpy/tool/steps/build.py:
1175         Translates the --architecture option into an ARCHS= format to pass to
1176         build-webkit.
1177         (Build.build):
1178         * Scripts/webkitpy/tool/steps/options.py:
1179         Adds a definition for the --architecture option.
1180         (Options):
1181
1182 2015-01-16  Sam Weinig  <sam@webkit.org>
1183
1184         Add a basic configuration object for WKView
1185         https://bugs.webkit.org/show_bug.cgi?id=140559
1186
1187         Reviewed by Anders Carlsson.
1188
1189         Add tests for WKPageConfigurationRef.
1190
1191         * TestWebKitAPI/PlatformWebView.h:
1192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1193         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
1194         (TestWebKitAPI::TEST):
1195         (TestWebKitAPI::didFinishLoadForFrame):
1196         (TestWebKitAPI::setPageLoaderClient):
1197         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1198         (TestWebKitAPI::PlatformWebView::initialize):
1199         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1200
1201 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
1202
1203         WeakPtr functions crash when created with default constructor
1204         https://bugs.webkit.org/show_bug.cgi?id=140479
1205
1206         Reviewed by Andreas Kling.
1207
1208         Add WeakPtr API tests.
1209
1210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1211         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
1212         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
1213
1214 2015-01-16  Chris Dumez  <cdumez@apple.com>
1215
1216         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
1217         https://bugs.webkit.org/show_bug.cgi?id=140568
1218
1219         Reviewed by Alexey Proskuryakov.
1220
1221         Fix the script parsing CSSPropertyNames.in to stop splitting lines
1222         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
1223         e.g. "Longhands=background-position-x|background-position-y".
1224         This would confuse the script and treat this as a CSS property:
1225         "background-position-x|background-position-y".
1226
1227         We now split on white space and treat the first string on the line
1228         to be the property name (this is the syntax in this file).
1229
1230         * Scripts/webkitpy/w3c/test_converter.py:
1231         (_W3CTestConverter.__init__):
1232         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
1233
1234 2015-01-16  Daniel Bates  <dabates@apple.com>
1235
1236         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
1237         https://bugs.webkit.org/show_bug.cgi?id=135589
1238
1239         Reviewed by David Kilzer.
1240
1241         Derived from a patch by David Farler.
1242
1243         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
1244         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
1245         in terms of the simctl command line utility.
1246
1247         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
1248         (eraseIOSSimulatorDevice): Added.
1249         (bootedIOSSimulatorDevice): Added.
1250         (iosSimulatorApplicationsPath): Added.
1251         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
1252         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
1253         (quitIOSSimulator): Added.
1254         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
1255         the specified name and currently selected iOS runtime.
1256         (isIOSSimulatorSystemInstalledApp): Added.
1257         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
1258         (deleteiOSSimulatorDevice): Deleted.
1259         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
1260         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
1261
1262 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
1263
1264         Resurrect the WinCairo bot.
1265         https://bugs.webkit.org/show_bug.cgi?id=139908
1266
1267         Reviewed by Csaba Osztrogonác.
1268
1269         * BuildSlaveSupport/build.webkit.org-config/config.json:
1270         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1271         (appendCustomBuildFlags):
1272         * BuildSlaveSupport/test-result-archive:
1273         (archiveTestResults):
1274         Add WinCairo buildbot.
1275
1276 2015-01-16  Chris Dumez  <cdumez@apple.com>
1277
1278         webkit-patch should auto-install the keyring python module
1279         https://bugs.webkit.org/show_bug.cgi?id=140547
1280
1281         Reviewed by David Kilzer.
1282
1283         Auto-install the keyring python module. This is the module that
1284         webkit-patch uses for cross-platform access to the keyring
1285         service.
1286
1287         Without this module, if the password if not in the keychain,
1288         webkit-patch will keep asking for your username / password and
1289         never remember them.
1290
1291         * Scripts/webkitpy/common/net/credentials.py:
1292         * Scripts/webkitpy/thirdparty/__init__.py:
1293         (AutoinstallImportHook.find_module):
1294         (AutoinstallImportHook._install_keyring):
1295
1296 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
1297
1298         Remove ENABLE(SQL_DATABASE) guards
1299         https://bugs.webkit.org/show_bug.cgi?id=140434
1300
1301         Reviewed by Darin Adler.
1302
1303         * Scripts/webkitperl/FeatureList.pm:
1304
1305 2015-01-15  Daniel Bates  <dabates@apple.com>
1306
1307         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
1308         https://bugs.webkit.org/show_bug.cgi?id=139685
1309         <rdar://problem/19281317>
1310
1311         Reviewed by Simon Fraser.
1312
1313         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
1314         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
1315
1316         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
1317         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
1318         before DRT dumps the output of a test. In particular, the WebThread may start a new page
1319         load (say, as a result of continued JavaScript execution), which will ultimately lead to
1320         dumping the test result again. Instead we want DRT to dump the test result synchronously
1321         such that we capture the state of the web page either when the page is loaded or when
1322         window.testRunner.notifyDone() is called.
1323
1324         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1325         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
1326         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
1327         flush CA transactions to the window.
1328         * DumpRenderTree/mac/DumpRenderTree.mm:
1329         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
1330         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
1331         (dump): Renamed; formerly named dumpTestResults().
1332         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
1333         enabling repaint support on iOS.
1334         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
1335         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
1336         (dumpTestResults): Deleted.
1337
1338 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
1339
1340         [Win] Miscellaneous DRT fixes
1341         https://bugs.webkit.org/show_bug.cgi?id=116562
1342
1343         Reviewed by Tim Horton.
1344
1345         While investigating the cause of several Windows crashes, I found:
1346         (1) Messy conversions to and from BSTR types
1347         (2) Weird mixes of wide-string and narrow string conversions
1348         (3) Passing nullptr to some CoreFoundation routines that do not
1349             permit null arguments.
1350         (4) Commands to link the executable to the VS2005 runtime.
1351
1352         This patch cleans up these issues to improve DRT reliability on
1353         Windows.
1354
1355         * DumpRenderTree/cg/ImageDiffCG.cpp:
1356         (main): Get rid of VS2005 runtime linking.
1357         * DumpRenderTree/win/DumpRenderTree.cpp:
1358         (urlSuitableForTestResult): Protect against being asked
1359         to process an empty URL.
1360         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
1361         than converting to/from wchar_t buffers.
1362         (runTest): Simplify string and BSTR handling.
1363         (createWebViewAndOffscreenWindow): Ditto.
1364         (main): Get rid of VS2005 runtime linking.
1365         * DumpRenderTree/win/TestRunnerWin.cpp:
1366         (jsStringRefToWString): Simplify code.
1367         (TestRunner::pathToLocalResource):
1368         (TestRunner::setUserStyleSheetLocation):
1369         * TestWebKitAPI/win/main.cpp: Get rid of
1370         VS2005 runtime linking.
1371         * win/DLLLauncher/DLLLauncherMain.cpp:
1372         (wWinMain): Ditto.
1373
1374 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
1375
1376         Stop hardcoding mac-mountainlion in commit queue
1377         https://bugs.webkit.org/show_bug.cgi?id=140492
1378
1379         Reviewed by Anders Carlsson.
1380
1381         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
1382         there should be no change in behavior, because:
1383         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
1384         using it to create a port object.
1385         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
1386         is actually correct to use "mac" for the name there. We only used to get the expected
1387         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
1388         for unknown deprecated port names.
1389
1390         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
1391
1392 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
1393
1394         Create iOS-EWS server queue
1395         https://bugs.webkit.org/show_bug.cgi?id=140473
1396
1397         Reviewed by Benjamin Poulain.
1398
1399         * QueueStatusServer/app.yaml: Updates the SVN version number.
1400         * QueueStatusServer/config/queues.py: Add ios-ews queue.
1401         * QueueStatusServer/model/queues.py:         
1402         (Queue.display_name): Makes sure the display name is pretty!
1403
1404 2015-01-14  Daniel Bates  <dabates@apple.com>
1405
1406         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
1407         https://bugs.webkit.org/show_bug.cgi?id=140301
1408         <rdar://problem/19389266>
1409
1410         Reviewed by Jon Honeycutt.
1411
1412         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
1413         with an unavailable runtime.
1414
1415         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1416         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
1417         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
1418         specified runtime cannot be used because it is unavailable.
1419         * Scripts/webkitpy/port/ios.py:
1420         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
1421         which was formerly named testing_device.
1422         * Scripts/webkitpy/xcode/simulator.py:
1423         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
1424         more robust than looking up the simulator device by name and runtime. This approach also
1425         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
1426         unavailable runtimes under the same iOS heading it would use to show it as available).
1427         (Simulator.find_device_by_udid): Added.
1428         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
1429         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
1430         (Simulator.available_runtimes): Added.
1431         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
1432         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
1433         first element of the sorted list is the runtime with the highest version number.
1434         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
1435
1436 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
1437
1438         Remove WK2 Windows cruft
1439         https://bugs.webkit.org/show_bug.cgi?id=140440
1440
1441         Reviewed by Anders Carlsson.
1442
1443         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
1444         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
1445         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
1446
1447 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
1448
1449         Fix TestWTF failed in TestWebKitAPI
1450         https://bugs.webkit.org/show_bug.cgi?id=140333
1451
1452         Reviewed by Sam Weinig.
1453
1454         Clear the std::ostringstream before starting test.
1455
1456         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1457         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
1458
1459 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1460
1461         TestWebKitWebContext depends on British English spellcheck dictionary
1462         https://bugs.webkit.org/show_bug.cgi?id=140403
1463
1464         Reviewed by Martin Robinson.
1465
1466         Install all English hunspell dictionaries on Fedora and Arch.
1467
1468         * gtk/install-dependencies:
1469
1470 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1471
1472         [GTK] install-dependencies should grok dnf
1473         https://bugs.webkit.org/show_bug.cgi?id=140396
1474
1475         Reviewed by Martin Robinson.
1476
1477         Fedora: install dependencies with dnf if yum is not installed.
1478
1479         * gtk/install-dependencies:
1480
1481 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
1482
1483         [EFL][GTK] Fix build after r178309  
1484         https://bugs.webkit.org/show_bug.cgi?id=140381
1485
1486         Reviewed by Gyuyoung Kim.
1487
1488         * TestWebKitAPI/CMakeLists.txt: Added the API directory
1489
1490 2015-01-11  Sam Weinig  <sam@webkit.org>
1491
1492         Remove support for SharedWorkers
1493         https://bugs.webkit.org/show_bug.cgi?id=140344
1494
1495         Reviewed by Anders Carlsson.
1496
1497         * Scripts/webkitperl/FeatureList.pm:
1498
1499 2015-01-12  Anders Carlsson  <andersca@apple.com>
1500
1501         Make delegates conform to formal delegate protocols
1502         https://bugs.webkit.org/show_bug.cgi?id=140370
1503
1504         Reviewed by Dan Bernstein.
1505
1506         * DumpRenderTree/mac/TestRunnerMac.mm:
1507         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1508         (TestRunner::setGeolocationPermission):
1509
1510 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1511
1512         build-webkit: silence output of 'which'
1513         https://bugs.webkit.org/show_bug.cgi?id=140278
1514
1515         Reviewed by Daniel Bates.
1516
1517         Use a more elegent test for the existance of ninja and eclipse.
1518
1519         * Scripts/webkitdirs.pm:
1520         (commandExists): Don't assume the command supports --version
1521         (canUseNinja): Use commandExists()
1522         (canUseEclipse): Use commandExists()
1523
1524 2015-01-09  Sam Weinig  <sam@webkit.org>
1525
1526         Update the output format for run-api-tests
1527         https://bugs.webkit.org/show_bug.cgi?id=140332
1528
1529         Reviewed by Dan Bernstein.
1530
1531         Changes the output format for run-api-tests be a bit simpler (no longer 
1532         indented based on suite, as we were not really using suite very well) but
1533         also include details in the case of failure.
1534
1535         Changes verbose mode to no longer spew out the gtest default printer output,
1536         as the custom printer now includes the failure information.
1537
1538         * Scripts/run-api-tests:
1539         (runTestsBySuite):
1540         (runTest):
1541         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
1542         with colorized variants and strip out leaks spew (the leaks can be added back using
1543         the new --show-leaks argument).
1544
1545         * TestWebKitAPI/TestsController.cpp:
1546         (TestWebKitAPI::Printer::OnTestPartResult):
1547         (TestWebKitAPI::Printer::OnTestEnd):
1548         (TestWebKitAPI::TestsController::run):
1549         Implement a custom result printer that just prints out the information we want.
1550
1551 2015-01-09  Sam Weinig  <sam@webkit.org>
1552
1553         TestWebKitAPI should print out the lists that fail at the end
1554         https://bugs.webkit.org/show_bug.cgi?id=140329
1555
1556         Reviewed by Tim Horton.
1557
1558         * Scripts/run-api-tests:
1559         (runTestsBySuite):
1560         Print out failures and timeouts in all modes, not just verbose.
1561
1562 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
1563
1564         Make bmalloc work with ASan
1565         https://bugs.webkit.org/show_bug.cgi?id=140194
1566
1567         Reviewed by Mark Lam.
1568
1569         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
1570         ASan automatically (by forwarding to system malloc at runtime).
1571
1572 2015-01-09  Daniel Bates  <dabates@apple.com>
1573
1574         [iOS] Make DumpRenderTree build with public SDK
1575         https://bugs.webkit.org/show_bug.cgi?id=140311
1576
1577         Reviewed by Sam Weinig.
1578
1579         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
1580         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
1581         Additionally, remove unused header CoreGraphics/CGFontDB.h.
1582
1583         * DumpRenderTree/mac/DumpRenderTree.mm:
1584         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
1585
1586 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
1587
1588         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
1589         https://bugs.webkit.org/show_bug.cgi?id=140300
1590
1591         Reviewed by Simon Fraser.
1592
1593         * WebKitTestRunner/TestController.cpp:
1594         (WTR::TestController::createOtherPage):
1595         (WTR::TestController::updateWindowScaleForTest):
1596         (WTR::TestController::configureViewForTest):
1597         * WebKitTestRunner/TestController.h:
1598
1599 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1600
1601         Unreviewed. Moving myself to the committer section.
1602
1603         * Scripts/webkitpy/common/config/contributors.json:
1604
1605 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1606
1607         Add a script to check for platform layering violations
1608         https://bugs.webkit.org/show_bug.cgi?id=140248
1609
1610         Reviewed by Darin Adler.
1611
1612         It prints all the cases where files inside platform include
1613         headers that are not in platform directory.
1614
1615         * Scripts/check-for-platform-layering-violations: Added.
1616         (get_platform_headers):
1617         (check_source_file):
1618
1619 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1620
1621         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
1622         https://bugs.webkit.org/show_bug.cgi?id=139884
1623
1624         Reviewed by Tim Horton.
1625
1626         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1627         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
1628         what the "nominal resolution" is, but this appears to work in practice.
1629
1630 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
1631
1632         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
1633         https://bugs.webkit.org/show_bug.cgi?id=140256
1634
1635         Reviewed by Anders Carlsson.
1636
1637         * DumpRenderTree/win/DumpRenderTree.cpp:
1638         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
1639         running with heap validation checks.
1640         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
1641         the "svg\\W3C-SVG-1.1" test directory.
1642         (removeFontFallbackIfPresent): Use nullptr instead of 0.
1643         * DumpRenderTree/win/TestRunnerWin.cpp:
1644         (TestRunner::clearPersistentUserStyleSheet): Ditto.
1645
1646 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1647
1648         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1649         https://bugs.webkit.org/show_bug.cgi?id=140218
1650
1651         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
1652         Undone an accidental change - check for self.has_crashed() again. This code path
1653         is for ports that don't have a signal handler printing #CRASHED when main process
1654         crashes.
1655
1656         * Scripts/webkitpy/port/driver_unittest.py:
1657         (DriverTest.test_check_for_driver_crash.assert_crash):
1658         (DriverTest.test_check_for_driver_crash):
1659         Updated the tests, all changes are expected.
1660
1661 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1662
1663         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1664         https://bugs.webkit.org/show_bug.cgi?id=140218
1665
1666         Reviewed by Darin Adler.
1667
1668         * Scripts/webkitpy/port/driver.py:
1669         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
1670         "process crashed" condition. These don't make sense together - it's either a crash
1671         or a timeout, and we should detect those properly at a much lower level.
1672         (Driver.run_test): Ditto.
1673         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
1674         cases.
1675
1676         * WebKitTestRunner/TestController.h:
1677         * WebKitTestRunner/TestController.cpp:
1678         (WTR::TestController::webProcessName): 
1679         (WTR::TestController::processDidCrash):
1680         Factored out hardcoded child process names, as we now use these in two places.
1681
1682         * WebKitTestRunner/TestInvocation.cpp:
1683         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
1684         process name, so that it can be sampled (fixes sampling on Mavericks and above).
1685
1686 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1687
1688         Reorder my list of email addresses, keeping the Bugzilla address at the
1689         top since Bugzilla and other webkitpy scripts rely on that ordering.
1690
1691         * Scripts/webkitpy/common/config/contributors.json:
1692
1693 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1694
1695         Moving myself to the reviewers section and updating
1696         the list of my email addresses.
1697
1698         * Scripts/webkitpy/common/config/contributors.json:
1699
1700 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1701
1702         [GTK] Build gtk-doc without gtkdoc-mktmpl
1703         https://bugs.webkit.org/show_bug.cgi?id=140225
1704
1705         Reviewed by Darin Adler.
1706
1707         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
1708         don't modify the tmpl files that it generates, it's not doing anything
1709         for us.
1710
1711         * gtk/gtkdoc.py:
1712         (GTKDoc.generate):
1713         (GTKDoc._run_gtkdoc_scangobj):
1714         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
1715
1716 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
1717
1718         [GTK][ThreadedCompositor] Add support for threaded compositor.
1719         https://bugs.webkit.org/show_bug.cgi?id=118265
1720
1721         Reviewed by Martin Robinson.
1722
1723         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
1724         autotools build systems. The feature is disabled by default.
1725         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
1726         from the feature flags.
1727
1728         * Scripts/webkitperl/FeatureList.pm:
1729
1730 2015-01-07  Daniel Bates  <dabates@apple.com>
1731
1732         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1733         https://bugs.webkit.org/show_bug.cgi?id=137371
1734
1735         Reviewed by David Kilzer.
1736
1737         Use SPI wrapper headers instead of directly referencing private SPI headers.
1738
1739         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1740         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1741         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1742         to the list of iOS header search directories so that we can include header UIKitSPI.h.
1743         * DumpRenderTree/mac/DumpRenderTree.mm:
1744         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1745         * DumpRenderTree/mac/EventSendingController.mm:
1746         * DumpRenderTree/mac/TestRunnerMac.mm:
1747
1748 2015-01-07  Commit Queue  <commit-queue@webkit.org>
1749
1750         Unreviewed, rolling out r178068.
1751         https://bugs.webkit.org/show_bug.cgi?id=140235
1752
1753         Breaks the iOS build (Requested by enrica on #webkit).
1754
1755         Reverted changeset:
1756
1757         "[iOS] Make WebKit2 build with public iOS SDK and more build
1758         fixes for DRT"
1759         https://bugs.webkit.org/show_bug.cgi?id=137371
1760         http://trac.webkit.org/changeset/178068
1761
1762 2015-01-07  Daniel Bates  <dabates@apple.com>
1763
1764         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1765         https://bugs.webkit.org/show_bug.cgi?id=137371
1766
1767         Reviewed by David Kilzer.
1768
1769         Use SPI wrapper headers instead of directly referencing private SPI headers.
1770
1771         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1772         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1773         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1774         to the list of header search directories so that we can include header UIKitSPI.h.
1775         * DumpRenderTree/mac/DumpRenderTree.mm:
1776         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1777         * DumpRenderTree/mac/EventSendingController.mm:
1778         * DumpRenderTree/mac/TestRunnerMac.mm:
1779
1780 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
1781
1782         [Win] Unreviewed test change to improve run reproducibility
1783
1784         * Scripts/webkitpy/port/win.py:
1785         (WinPort.default_child_processes): Run a single DRT instance to help
1786         identify failures caused by earlier test runs.
1787
1788 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1789
1790         Myles C. Maxfield is a reviewer now
1791         https://bugs.webkit.org/show_bug.cgi?id=140196
1792
1793         Reviewed by Dean Jackson.
1794
1795         * Scripts/webkitpy/common/config/contributors.json:
1796
1797 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1798
1799         Make webkit-patch try harder to find keychain credentials
1800         https://bugs.webkit.org/show_bug.cgi?id=140170
1801
1802         Reviewed by Ryosuke Niwa.
1803
1804         When the user manually enters a password into webkit-patch, we hand that off to the
1805         Keyring Python module. However, that module creates a generic password entry instead
1806         of an internet password entry. We should look for both kinds.
1807
1808         * Scripts/webkitpy/common/net/credentials.py:
1809         (Credentials._run_security_tool):
1810         (Credentials._credentials_from_keychain):
1811         * Scripts/webkitpy/common/net/credentials_unittest.py:
1812         (test_security_output_parse_entry_not_found):
1813         (_assert_security_call):
1814
1815 2015-01-06  Anders Carlsson  <andersca@apple.com>
1816
1817         Try to fix the Mountain Lion build.
1818
1819         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1820         (TestWebKitAPI::didGetImageForMatchResult):
1821
1822 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1823
1824         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
1825         https://bugs.webkit.org/show_bug.cgi?id=140095
1826
1827         Reviewed by Anders Carlsson.
1828
1829         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
1830         builds, but not in debug ones.
1831
1832 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
1833
1834         [Win] Extend WinLauncher with support for Page Zoom
1835         https://bugs.webkit.org/show_bug.cgi?id=140152
1836
1837         Reviewed by Anders Carlsson.
1838
1839         * WinLauncher/Common.cpp:
1840         (WndProc):
1841         * WinLauncher/WinLauncher.cpp:
1842         (WinLauncher::resetZoom):
1843         (WinLauncher::zoomIn):
1844         (WinLauncher::zoomOut):
1845         * WinLauncher/WinLauncher.h:
1846         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
1847         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1848         * win/DLLLauncher/DLLLauncherMain.cpp:
1849         (wWinMain):
1850
1851 2015-01-06  Anders Carlsson  <andersca@apple.com>
1852
1853         Fix API tests that are broken under HiDPI
1854         https://bugs.webkit.org/show_bug.cgi?id=140146
1855
1856         Reviewed by Tim Horton.
1857
1858         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1859         (TestWebKitAPI::didGetImageForMatchResult):
1860         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
1861
1862         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1863         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1864         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
1865         out in a window that has a backing scale factor of 1.
1866  
1867         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1868         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
1869         Ditto.
1870
1871 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1872
1873         ADDRESS_SANITIZER macro is overloaded
1874         https://bugs.webkit.org/show_bug.cgi?id=140130
1875
1876         Reviewed by Anders Carlsson.
1877
1878         * WebKitTestRunner/TestController.cpp: Use the new macro.
1879
1880 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
1881
1882         Remove some stale class names in check-for-inappropriate-objc-class-names
1883         https://bugs.webkit.org/show_bug.cgi?id=140104
1884
1885         Reviewed by Darin Adler.
1886
1887         * Scripts/check-for-inappropriate-objc-class-names:
1888         These UIWK* classes no longer exist.
1889
1890 2015-01-05  Anders Carlsson  <andersca@apple.com>
1891
1892         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
1893         https://bugs.webkit.org/show_bug.cgi?id=140096
1894         rdar://problem/19368938
1895
1896         Reviewed by Alexey Proskuryakov.
1897
1898         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
1899         since clientInfo points to a web view, not the test controller.
1900
1901         * WebKitTestRunner/TestController.cpp:
1902         (WTR::TestController::createOtherPage):
1903
1904 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
1905
1906         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
1907         https://bugs.webkit.org/show_bug.cgi?id=140077
1908
1909         Reviewed by Csaba Osztrogonác.
1910
1911         WebKit C SPI is available on EFL,GTK.
1912         Changed the define order to pass the API test.
1913
1914         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1915         (TestWebKitAPI::TEST):
1916
1917 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
1918
1919         Simplify WebKitTestRunner timeout tracking
1920         https://bugs.webkit.org/show_bug.cgi?id=140036
1921
1922         Reviewed by Darin Adler.
1923
1924         The code for configuring timeouts was mostly dead, because run-webkit-tests never
1925         passes the --timeout option to WebKitTestRunner.
1926
1927         * WebKitTestRunner/Options.h:
1928         * WebKitTestRunner/Options.cpp:
1929         (WTR::Options::Options):
1930         (WTR::OptionsHandler::OptionsHandler):
1931         (WTR::handleOptionTimeout): Deleted.
1932         Removed support for --timeout. Timeouts are passed for each test individually,
1933         and defaults are good enough for the rare cases where WebKitTestRunner is run
1934         manually without run-webkit-tests.
1935
1936         * WebKitTestRunner/TestController.cpp:
1937         (WTR::TestController::TestController):
1938         (WTR::TestController::initialize):
1939         (WTR::TestController::resetStateToConsistentValues):
1940         (WTR::TestController::reattachPageToWebProcess):
1941         (WTR::TestController::runUntil):
1942         * WebKitTestRunner/TestController.h:
1943         Simplified runUntil by passing the actual timeout, not an enum.
1944         Increased short timeout for ASan enabled builds, as WebProcess launching takes
1945         quite a while.
1946
1947         * WebKitTestRunner/TestInvocation.cpp:
1948         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
1949
1950         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1951         (WTR::TestController::platformRunUntil):
1952         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1953         (WTR::TestController::platformRunUntil):
1954         Build fixes.
1955
1956 2015-01-02  Anders Carlsson  <andersca@apple.com>
1957
1958         Remove now unused storage tracker glue from DumpRenderTree
1959         https://bugs.webkit.org/show_bug.cgi?id=140045
1960
1961         Reviewed by Darin Adler.
1962
1963         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1964         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
1965         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
1966         * DumpRenderTree/TestRunner.cpp:
1967         (TestRunner::staticFunctions):
1968         (syncLocalStorageCallback): Deleted.
1969         (observeStorageTrackerNotificationsCallback): Deleted.
1970         (deleteAllLocalStorageCallback): Deleted.
1971         (deleteLocalStorageForOriginCallback): Deleted.
1972         (localStorageDiskUsageForOriginCallback): Deleted.
1973         (originsWithLocalStorageCallback): Deleted.
1974         * DumpRenderTree/TestRunner.h:
1975         * DumpRenderTree/mac/DumpRenderTree.mm:
1976         (allocateGlobalControllers):
1977         (releaseGlobalControllers):
1978         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1979         * DumpRenderTree/mac/TestRunnerMac.mm:
1980         (TestRunner::syncLocalStorage): Deleted.
1981         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1982         (TestRunner::observeStorageTrackerNotifications): Deleted.
1983         (TestRunner::deleteAllLocalStorage): Deleted.
1984         (TestRunner::originsWithLocalStorage): Deleted.
1985         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1986         * DumpRenderTree/win/TestRunnerWin.cpp:
1987         (TestRunner::syncLocalStorage): Deleted.
1988         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1989         (TestRunner::observeStorageTrackerNotifications): Deleted.
1990         (TestRunner::deleteAllLocalStorage): Deleted.
1991         (TestRunner::originsWithLocalStorage): Deleted.
1992         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1993
1994 2015-01-01  Darin Adler  <darin@apple.com>
1995
1996         We often misspell identifier as "identifer"
1997         https://bugs.webkit.org/show_bug.cgi?id=140025
1998
1999         Reviewed by Michael Saboff.
2000
2001         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2002         * Scripts/webkitdirs.pm:
2003         (appIdentifierFromBundle):
2004         (installAndLaunchIOSWebKitAppInSimulator):
2005         Fix misspellings
2006
2007 2015-01-01  Zalan Bujtas  <zalan@apple.com>
2008
2009         Saturated arithmetics: Incorrect float/double clamping.
2010         https://bugs.webkit.org/show_bug.cgi?id=139888
2011         rdar://problem/19330885
2012
2013         Reviewed by Simon Fraser.
2014
2015         Clamp float and double values correctly when applying saturated arithmetics.
2016
2017         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2018         (TestWebKitAPI::TEST):
2019
2020 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
2021
2022         [EFL] Bump version of ATK used by jhbuild to 2.15.2
2023         https://bugs.webkit.org/show_bug.cgi?id=139816
2024
2025         Reviewed by Gyuyoung Kim.
2026
2027         Bump version of ATK used by jhbuild to 2.15.2
2028
2029         * efl/jhbuild.modules:
2030
2031 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
2032
2033         [jhBuild] cairo build error (-flto)
2034         https://bugs.webkit.org/show_bug.cgi?id=139056
2035
2036         Reviewed by Philippe Normand.
2037
2038         cairo fails to link  with gcc 4.9 due to lto
2039         related issue. This problem has been partially
2040         addressed by cairo:
2041         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
2042         use the cairo --disable-lto option and remove jhbuild
2043         makeargs fixes the issue.
2044
2045         * gtk/jhbuild.modules:
2046         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
2047
2048 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
2049         [Mac] Enable kerning, ligatures, and printer fonts 
2050         https://bugs.webkit.org/show_bug.cgi?id=139970
2051
2052         Rubber stamped by Simon Fraser.
2053
2054         Flip the switch.
2055
2056         * DumpRenderTree/mac/DumpRenderTree.mm:
2057         * WebKitTestRunner/TestController.cpp:
2058         * WebKitTestRunner/mac/main.mm:
2059
2060 2014-12-26  Dan Bernstein  <mitz@apple.com>
2061
2062         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2063         https://bugs.webkit.org/show_bug.cgi?id=139950
2064
2065         Reviewed by David Kilzer.
2066
2067         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2068         in a manner that works with Xcode 5.1.1.
2069
2070 2014-12-24  Dan Bernstein  <mitz@apple.com>
2071
2072         Engineering builds of MiniBrowser ignore deprecated declaration warnings
2073         https://bugs.webkit.org/show_bug.cgi?id=139941
2074
2075         Reviewed by Darin Adler.
2076
2077         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
2078         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
2079         to YES.
2080         * MiniBrowser/mac/AppDelegate.m:
2081         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
2082         deprecated NSOKButton.
2083
2084 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2085
2086         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
2087         https://bugs.webkit.org/show_bug.cgi?id=134763
2088
2089         Reviewed by Ryosuke Niwa.
2090
2091         Adding an option to disable test harness link conversion.
2092
2093         * Scripts/webkitpy/w3c/test_converter.py:
2094         (convert_for_webkit):
2095         (_W3CTestConverter.__init__):
2096         (_W3CTestConverter.convert_attributes_if_needed):
2097         * Scripts/webkitpy/w3c/test_importer.py:
2098         (parse_args):
2099         (TestImporter.import_tests):
2100
2101 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2102
2103         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
2104         https://bugs.webkit.org/show_bug.cgi?id=139933
2105
2106         Reviewed by Daniel Bates.
2107
2108         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
2109         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
2110         until ReportCrash lets it go.
2111
2112         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
2113         even get the actual crash log eventually - even when it times out waiting for the log, it
2114         makes a second lookup at the very end, after all tests finish. There may be further
2115         improvements needed here, but this small fix addresses most cases that happen in practice.
2116
2117         * DumpRenderTree/mac/DumpRenderTree.mm:
2118         (writeCrashedMessageOnFatalError):
2119         (dumpRenderTree):
2120         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
2121
2122         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
2123         unhelpful comment.
2124
2125 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2126
2127         Don't force -O1 for debug ASan builds
2128         https://bugs.webkit.org/show_bug.cgi?id=139926
2129
2130         Reviewed by Darin Adler.
2131
2132         * asan/asan.xcconfig:
2133
2134 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2135
2136         Simplify building with ASan
2137         https://bugs.webkit.org/show_bug.cgi?id=139916
2138
2139         Reviewed by Mark Rowe.
2140
2141         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
2142         We could also update Configuration file format, but that's a little scary because
2143         of how many places in code read it.
2144
2145         * Scripts/webkitdirs.pm:
2146         (determineASanIsEnabled): Read it from ASan configuration file.
2147         (argumentsForConfiguration): Added a FIXME.
2148         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
2149         (XcodeOptions): Pass the options needed for ASan.
2150
2151         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
2152         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
2153         that automatically.
2154
2155 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2156
2157         TestWebKitAPI build is broken when ASan is enabled
2158         https://bugs.webkit.org/show_bug.cgi?id=139902
2159
2160         Reviewed by Darin Adler.
2161
2162         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2163         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
2164         Inherit linker flags from DebugRelease, which respects ASAN.
2165
2166 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
2167
2168         Sort the Xcode project file.
2169
2170         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2171
2172 2014-12-22  Lucas Forschler  <lforschler@apple.com>
2173
2174         Update apple-mac-114 to bot629.
2175         
2176         Unreviewed.
2177         
2178         * BuildSlaveSupport/build.webkit.org-config/config.json:
2179
2180 2014-12-22  Lucas Forschler  <lforschler@apple.com>
2181
2182         Replace Apple bot104 with bot124.
2183         
2184         Unreviewed.
2185         
2186         * BuildSlaveSupport/build.webkit.org-config/config.json:
2187
2188 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
2189
2190         URTBF after r177639.
2191
2192         * TestWebKitAPI/CMakeLists.txt:
2193
2194 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2195
2196         [EFL] MiniBrowser steals web view's focus
2197         https://bugs.webkit.org/show_bug.cgi?id=139482
2198
2199         Reviewed by Gyuyoung Kim.
2200
2201         Although we set focus on ewk_view while MiniBrowser initialization
2202         Ecore steals it in a favor of main window. As a result
2203         focused element on web page is unable to receive events.
2204
2205         * MiniBrowser/efl/main.c:
2206         (window_create):
2207         Prevent window from stealing web view's focus on start up.
2208
2209 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
2210
2211         [Win] Revise DRT logic to match Mac.
2212
2213         Rubberstamped by Anders Carlsson.
2214
2215         Update the Windows logic to perform initialization of preferences and WebKit
2216         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
2217         the same circumstances as the Mac version.
2218
2219         * DumpRenderTree/win/DumpRenderTree.cpp:
2220         (dump):
2221         (resetWebPreferencesToConsistentValues):
2222         (setDefaultsToConsistentValuesForTesting):
2223         (resetWebViewToConsistentStateBeforeTesting):
2224         (sizeWebViewForCurrentTest):
2225         (runTest):
2226         (createWebViewAndOffscreenWindow):
2227         (allocateGlobalControllers):
2228         (prepareConsistentTestingEnvironment):
2229         (main):
2230         (resetDefaultsToConsistentValues): Deleted.
2231
2232 2014-12-19  Roger Fong  <roger_fong@apple.com>
2233
2234         Unreviewed. Rollout r177605.
2235
2236         * EWSTools/start-queue-win.sh:
2237
2238 2014-12-19  Roger Fong  <roger_fong@apple.com>
2239
2240         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
2241
2242         * EWSTools/start-queue-win.sh:
2243
2244 2014-12-19  Daniel Bates  <dabates@apple.com>
2245
2246         [iOS] Add WebKitSystemInterface for iOS 8.1
2247         https://bugs.webkit.org/show_bug.cgi?id=139831
2248
2249         Reviewed by Alexey Proskuryakov.
2250
2251         Implement support in copy-webkitlibraries-to-product-directory to copy
2252         WebKitSystemInterface for iOS to the product directory and have build-webkit
2253         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
2254
2255         * Scripts/build-webkit:
2256         * Scripts/copy-webkitlibraries-to-product-directory:
2257
2258 2014-12-19  Daniel Bates  <dabates@apple.com>
2259
2260         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
2261         https://bugs.webkit.org/show_bug.cgi?id=139829
2262
2263         Reviewed by Alexey Proskuryakov.
2264
2265         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
2266         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
2267         expects the Xcode SDK to be specified using the --sdk-name command line argument.
2268
2269         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
2270         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
2271         logic to both avoid duplicating effort and make the command line options for
2272         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
2273         with the approach used in other WebKit tools.
2274
2275         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
2276         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
2277         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
2278
2279         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
2280         improve the readability of the code.
2281         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
2282         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
2283         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
2284         be included in a library.
2285         (unpackIfNecessary): Modified to call executeRanlib().
2286
2287 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
2288
2289         REGRESSION (177368): Some tests started to immediately time out
2290         https://bugs.webkit.org/show_bug.cgi?id=139826
2291
2292         Reviewed by Daniel Bates.
2293
2294         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
2295         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
2296         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
2297         ends in a load failure, we don't dump, so we used to leak the timer.
2298         
2299         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
2300         Added a comment.
2301
2302 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
2303
2304         [Win] Add accessor for serializing HTTP loads
2305         https://bugs.webkit.org/show_bug.cgi?id=139817
2306
2307         Reviewed by Mark Lam.
2308
2309         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
2310         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
2311         remove some redundant code from the destructor.
2312
2313 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
2314
2315         Clean up a fix for performance test bot failing to build
2316         https://bugs.webkit.org/show_bug.cgi?id=139818
2317
2318         Reviewed by Csaba Osztrogonác.
2319
2320         The "_1" in step name was annoying.
2321
2322         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2323         (CleanBuildIfScheduled.start):
2324         (RunAndUploadPerfTests):
2325         (DownloadAndPerfTestFactory.__init__):
2326         (DownloadAndPerfTestWebKit2Factory.__init__):
2327         (CleanBuildUnconditionally): Deleted.
2328         (CleanBuildUnconditionally.start): Deleted.
2329
2330 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
2331
2332         REGRESSION(r177535): It broke the GTK performance bot
2333         https://bugs.webkit.org/show_bug.cgi?id=139811
2334
2335         Reviewed by Carlos Garcia Campos.
2336
2337         Trigger clean build only on mac platform.
2338
2339         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2340         (DownloadAndPerfTestFactory.__init__):
2341         (DownloadAndPerfTestWebKit2Factory.__init__):
2342
2343 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
2344
2345         Unreviewed, moved myself to the list of committers.
2346
2347         * Scripts/webkitpy/common/config/contributors.json:
2348
2349 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
2350
2351         [Win] Update DumpRenderTree to more closely match Mac version
2352         https://bugs.webkit.org/show_bug.cgi?id=139799
2353
2354         Reviewed by Tim Horton.
2355
2356         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2357         (AccessibilityController::accessibleElementById): Correct
2358         use of BSTR to avoid leak.
2359         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
2360         update to match Mac version more closely.
2361         (dumpFramesAsText):
2362         (dump):
2363         (resetDefaultsToConsistentValues):
2364         (resetWebViewToConsistentStateBeforeTesting):
2365         (sizeWebViewForCurrentTest):
2366         (runTest):
2367         (openWindows):
2368         (windowToWebViewMap):
2369         (createWebViewAndOffscreenWindow):
2370         (sharedCFURLCache):
2371         (initializeGlobalsFromCommandLineOptions):
2372         (main):
2373         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2374         (TestRunner::addDisallowedURL):
2375         (TestRunner::applicationCacheDiskUsageForOrigin):
2376         (TestRunner::syncLocalStorage):
2377         (TestRunner::localStorageDiskUsageForOrigin):
2378         (TestRunner::observeStorageTrackerNotifications):
2379         (TestRunner::clearApplicationCacheForOrigin):
2380         (TestRunner::originsWithApplicationCache):
2381         (TestRunner::deleteAllLocalStorage):
2382         (TestRunner::setStorageDatabaseIdleInterval):
2383         (TestRunner::closeIdleLocalStorageDatabases):
2384         (TestRunner::originsWithLocalStorage):
2385         (TestRunner::deleteLocalStorageForOrigin):
2386         (TestRunner::copyDecodedHostName):
2387         (TestRunner::copyEncodedHostName):
2388         (TestRunner::keepWebHistory):
2389         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2390         (TestRunner::setAppCacheMaximumSize):
2391         (TestRunner::setCustomPolicyDelegate):
2392         (TestRunner::goBack):
2393         (TestRunner::setDefersLoading):
2394         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2395         (TestRunner::setMockDeviceOrientation):
2396         (TestRunner::setMockGeolocationPosition):
2397         (TestRunner::setMockGeolocationPositionUnavailableError):
2398         (TestRunner::setIconDatabaseEnabled):
2399         (TestRunner::setMainFrameIsFirstResponder):
2400         (TestRunner::setSpatialNavigationEnabled):
2401         (TestRunner::setPluginsEnabled):
2402         (TestRunner::setAutomaticLinkDetectionEnabled):
2403         (TestRunner::setUseDashboardCompatibilityMode):
2404         (TestRunner::dispatchPendingLoadRequests):
2405         (TestRunner::findString):
2406         (TestRunner::setCacheModel):
2407         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2408         (TestRunner::setWebViewEditable):
2409         (TestRunner::authenticateSession):
2410         (TestRunner::abortModal):
2411         (TestRunner::setSerializeHTTPLoads):
2412         (TestRunner::addChromeInputField):
2413         (TestRunner::removeChromeInputField):
2414         (TestRunner::focusWebView):
2415         (TestRunner::setBackingScaleFactor):
2416         (TestRunner::grantWebNotificationPermission):
2417         (TestRunner::denyWebNotificationPermission):
2418         (TestRunner::removeAllWebNotificationPermissions):
2419         (TestRunner::simulateWebNotificationClick):
2420
2421 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
2422
2423         Add strong typing to RefCounter interface, return value as a bool.
2424         https://bugs.webkit.org/show_bug.cgi?id=139776
2425
2426         Reviewed by Geoff Garen.
2427
2428         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
2429         This means there is no compile time type checking to prevent mistakes. Update the count()
2430         method to token<>(), templated on type used to identify the token being returned.
2431         Calls to token<T>() will return a result of type RefCounter::Token<T>.
2432
2433         There are a few problems with the fact the counter will return you an exact count of the
2434         number of outstanding tokens:
2435           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
2436             to do so if the value is only readable as a boolean.
2437           - It is desirable to provide the value as an argument to the callback, however to make
2438             this useful for integer values it is also necessary to indicate the direction of change
2439             (0->1 is often interesting where 2->1 is not).
2440           - There is a mismatch between the precision of returning a count, and the inherent
2441             imprecision of a token based mechanism, where it may be difficult to guarantee
2442             absolutely no unnecessary refcount churn, and thus unintentional counter values.
2443
2444         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2445         (TestWebKitAPI::TEST):
2446             - update API test.
2447
2448 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
2449
2450         Disable retries on Mac Release WK2 testers
2451         https://bugs.webkit.org/show_bug.cgi?id=139798
2452
2453         Reviewed by Simon Fraser.
2454
2455         * BuildSlaveSupport/build.webkit.org-config/config.json:
2456
2457 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
2458
2459         Perf tests frequently fail saying "build not up to date"
2460         https://bugs.webkit.org/show_bug.cgi?id=139786
2461
2462         Illegitimately yet authoritatively reviewed by Lucas Forschler.
2463
2464         Undo the rest of the first fix, and implement the behavior differently.
2465
2466         is_clean isn't automatically forwarded from config.json to properties.
2467
2468         * BuildSlaveSupport/build.webkit.org-config/config.json:
2469         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2470         (CleanBuildUnconditionally):
2471         (CleanBuildUnconditionally.start):
2472         (DownloadAndPerfTestFactory.__init__):
2473         (DownloadAndPerfTestWebKit2Factory.__init__):
2474
2475 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
2476
2477         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
2478         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
2479         found nothing.
2480
2481         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2482         (BuildAndPerfTestFactory):
2483         (BuildAndPerfTestWebKit2Factory):
2484
2485 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
2486
2487         Perf tests frequently fail saying "build not up to date"
2488         https://bugs.webkit.org/show_bug.cgi?id=139786
2489
2490         Reviewed by Ryosuke Niwa.
2491
2492         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
2493         directory to get rid of stale precompiled headers, and let it rebuild
2494         DumpRenderTree each time, that's fast.
2495
2496         Also, removed unused "build and perf test" code.
2497
2498         * BuildSlaveSupport/build.webkit.org-config/config.json:
2499
2500 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
2501
2502         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
2503
2504         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
2505         it easier to see what steps are missing when running under Windows.
2506
2507         * DumpRenderTree/win/TestRunnerWin.cpp:
2508         (TestRunner::callShouldCloseOnWebView):
2509         (TestRunner::clearAllApplicationCaches):
2510         (TestRunner::applicationCacheDiskUsageForOrigin):
2511         (TestRunner::syncLocalStorage):
2512         (TestRunner::localStorageDiskUsageForOrigin):
2513         (TestRunner::observeStorageTrackerNotifications):
2514         (TestRunner::clearApplicationCacheForOrigin):
2515         (TestRunner::originsWithApplicationCache):
2516         (TestRunner::clearAllDatabases):
2517         (TestRunner::deleteAllLocalStorage):
2518         (TestRunner::setStorageDatabaseIdleInterval):
2519         (TestRunner::closeIdleLocalStorageDatabases):
2520         (TestRunner::originsWithLocalStorage):
2521         (TestRunner::deleteLocalStorageForOrigin):
2522         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2523         (jsStringRefToWString):
2524         (TestRunner::setAppCacheMaximumSize):
2525         (TestRunner::setDatabaseQuota):
2526         (TestRunner::goBack):
2527         (TestRunner::setDefersLoading):
2528         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2529         (TestRunner::setAutomaticLinkDetectionEnabled):
2530         (TestRunner::dispatchPendingLoadRequests):
2531         (TestRunner::overridePreference):
2532         (TestRunner::removeAllVisitedLinks):
2533         (TestRunner::waitForPolicyDelegate):
2534         (TestRunner::resetPageVisibility):
2535         (TestRunner::setPageVisibility):
2536         (TestRunner::grantWebNotificationPermission):
2537         (TestRunner::denyWebNotificationPermission):
2538         (TestRunner::removeAllWebNotificationPermissions):
2539         (TestRunner::simulateWebNotificationClick):
2540         (TestRunner::simulateLegacyWebNotificationClick):
2541
2542 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
2543
2544         [Win] Correct Windows tests after Bug 139149 (edit)
2545         https://bugs.webkit.org/show_bug.cgi?id=139781
2546
2547         Reviewed by Anders Carlsson.
2548
2549         * DumpRenderTree/win/TestRunnerWin.cpp:
2550         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
2551         interface.
2552
2553 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
2554
2555         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
2556         https://bugs.webkit.org/show_bug.cgi?id=139748
2557
2558         Reviewed by Daniel Bates.
2559         
2560         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
2561         have all been updated.
2562
2563         * Scripts/webkitpy/port/factory.py:
2564         (platform_options):
2565
2566 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
2567
2568         Build more of TestWebKitAPI for iOS
2569         https://bugs.webkit.org/show_bug.cgi?id=139747
2570
2571         Reviewed by Daniel Bates.
2572         
2573         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
2574         which excluded some tests that should be run for iOS.
2575         
2576         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
2577         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
2578         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
2579         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
2580         
2581         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
2582         to share code between Mac and iOS.
2583
2584         * TestWebKitAPI/Configurations/Base.xcconfig:
2585         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2586         * TestWebKitAPI/InjectedBundleController.cpp:
2587         * TestWebKitAPI/InjectedBundleMain.cpp:
2588         * TestWebKitAPI/JavaScriptTest.cpp:
2589         * TestWebKitAPI/PlatformUtilities.cpp:
2590         * TestWebKitAPI/PlatformUtilities.h:
2591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2592         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2593         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2594         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2595         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2596         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2597         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
2598         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2599         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2600         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2601         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2602         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2603         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
2604         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2605         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2606         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2607         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2608         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2609         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2610         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2611         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2612         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2613         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2614         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2615         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2616         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2617         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2618         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2619         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
2620         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2621         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2622         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2623         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2624         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2625         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2626         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2627         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
2628         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2629         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2630         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2631         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2632         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2633         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2634         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2635         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2636         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2637         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2638         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2639         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
2640         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2641         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2642         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2643         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2644         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2645         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2646         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2647         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2648         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2649         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2650         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2651         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2652         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2653         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2654         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2655         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2656         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2657         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2658         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2659         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2660         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2661         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2662         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2663         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2664         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2665         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2666         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
2667         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
2668         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2669         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2670         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2671         (TestWebKitAPI::TEST):
2672         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2673         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2674         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2675         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2676         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
2677         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2678         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2679         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2680         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2681         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
2682         (TEST):
2683         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2684         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2685         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2686         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2687         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2688         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2689         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2690         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2691         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2692         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2693         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
2694         (TestWebKitAPI::Util::run):
2695         (TestWebKitAPI::Util::sleep):
2696         (TestWebKitAPI::Util::toSTD):
2697         * TestWebKitAPI/config.h:
2698         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2699         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2700         (TestWebKitAPI::Util::run): Deleted.
2701         (TestWebKitAPI::Util::sleep): Deleted.
2702         (TestWebKitAPI::Util::toSTD): Deleted.
2703
2704 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2705
2706         [GTK] Add support for FTL JIT on ARM64
2707         https://bugs.webkit.org/show_bug.cgi?id=139677
2708
2709         Reviewed by Csaba Osztrogonác.
2710
2711         * gtk/jhbuild-optional.modules:
2712         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2713         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2714
2715 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
2716
2717         [GTK] Implement webkit_web_view_is_playing_audio()
2718         https://bugs.webkit.org/show_bug.cgi?id=138918
2719
2720         Reviewed by Carlos Garcia Campos.
2721
2722         Add test case case for webkit_web_view_is_playing_audio() and the
2723         WebKitWebView::is-playing-audio property.
2724
2725         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2726         (urlForResource): Utility function to get URLs pointing to resources
2727         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
2728         (testWebViewIsPlayingAudio): Added.
2729         (beforeAll):
2730         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2731         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
2732         API tests resources directory, or the WebKit2 C API tests resources
2733         directory. The default value of the flag is to use the WebKit2 GTK
2734         one, to avoid having to change existing tests.
2735         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2736         (isPlayingAudioChanged): Added.
2737         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
2738         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2739
2740 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2741
2742         [GTK] [EFL] Enable per_test_timeout
2743         https://bugs.webkit.org/show_bug.cgi?id=139771
2744
2745         Reviewed by Csaba Osztrogonác.
2746
2747         This is needed to make WKTR use either the default port timeout, or the
2748         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
2749         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
2750
2751         * Scripts/webkitpy/port/efl.py:
2752         (EflPort.supports_per_test_timeout): Enabled.
2753         * Scripts/webkitpy/port/gtk.py:
2754         (GtkPort.supports_per_test_timeout): Enabled.
2755
2756 2014-12-17  Lucas Forschler  <lforschler@apple.com>
2757
2758         Move Apple buildbot slaves to their new home.
2759         
2760         Reviewed by Roger Fong.
2761
2762         * BuildSlaveSupport/build.webkit.org-config/config.json:
2763
2764 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2765
2766         REGRESSION (r177363): Gtk and Efl testing is broken
2767         https://bugs.webkit.org/show_bug.cgi?id=139734
2768
2769         Reviewed by Simon Fraser.
2770
2771         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2772         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2773         affected both script and tool timeout. This is still the right place for this logic,
2774         but it would be a larger refactoring than I can do right now.
2775
2776         * Scripts/webkitpy/port/base.py:
2777         (Port.supports_per_test_timeout): Added a FIXME.
2778         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2779         to avoid making tests take more time.
2780
2781         * Scripts/webkitpy/port/driver.py:
2782         (Driver.run_test): Adjust script timeout here.
2783         (Driver._check_for_driver_timeout): Fix the timeout detection.
2784         (Driver._read_block): Actually use the timeout detection code.
2785
2786         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2787         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2788
2789         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
2790         Update results for the new default.
2791
2792         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2793         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
2794         actually a good one.
2795
2796 2014-12-17  Commit Queue  <commit-queue@webkit.org>
2797
2798         Unreviewed, rolling out r177456.
2799         https://bugs.webkit.org/show_bug.cgi?id=139749
2800
2801         Broke webkitpy and Mac tests (Requested by ap on #webkit).
2802
2803         Reverted changeset:
2804
2805         "REGRESSION (r177363): Gtk and Efl testing is broken"
2806         https://bugs.webkit.org/show_bug.cgi?id=139734
2807         http://trac.webkit.org/changeset/177456
2808
2809 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2810
2811         REGRESSION (r177363): Gtk and Efl testing is broken
2812         https://bugs.webkit.org/show_bug.cgi?id=139734
2813
2814         Reviewed by Simon Fraser.
2815
2816         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2817         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2818         affected both script and tool timeout. This is still the right place for this logic,
2819         but it would be a larger refactoring than I can do right now.
2820
2821         * Scripts/webkitpy/port/base.py:
2822         (Port.supports_per_test_timeout): Added a FIXME.
2823         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2824         to avoid making tests take more time.
2825
2826         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
2827
2828         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2829         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2830
2831 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2832
2833         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
2834         https://bugs.webkit.org/show_bug.cgi?id=139725
2835
2836         Reviewed by Martin Robinson.
2837
2838         The timeout is already in milliseconds, so we don't need to do any conversion.
2839
2840         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2841         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2842
2843 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
2844
2845         [EFL]Fix build warning in MiniBrowser
2846         https://bugs.webkit.org/show_bug.cgi?id=139723
2847
2848         Reviewed by Darin Adler.
2849
2850         The warning is caused by the compiler wanting the first argument to be a
2851         string literal, not a dynamically created string.
2852
2853         * MiniBrowser/efl/main.c:
2854         (quit):
2855
2856 2014-12-16  Sam Weinig  <sam@webkit.org>
2857
2858         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
2859         https://bugs.webkit.org/show_bug.cgi?id=139718
2860
2861         Reviewed by Mark Rowe.
2862
2863         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
2864         files into a static lib which the command line utility can link link against.
2865         This will allow us to create a TestWebKitAPI.app that can run on iOS.
2866
2867         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2868         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
2869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2870
2871 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
2872
2873         Sort out timeout implementations in DRT and WKTR
2874         https://bugs.webkit.org/show_bug.cgi?id=139671
2875
2876         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
2877         with the tool.
2878
2879         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2880         (RunTest.test_hung_thread):
2881
2882 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
2883
2884         Sort out timeout implementations in DRT and WKTR
2885         https://bugs.webkit.org/show_bug.cgi?id=139671
2886
2887         Reviewed by Simon Fraser.
2888
2889         Test timeout implementation had many deficiencies, please see the bug for details.
2890         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
2891         [ Slow ] modifiers should work a lot better.
2892
2893         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
2894         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
2895         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
2896         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
2897         DumpRenderTree already read the --timeout option from command line, and webkitpy
2898         was already configured to pass it on Mac and iOS. Let's actually use it.
2899         TestCommand already had the same 30 second default, so this doesn't change behavior
2900         when DRT is ran manually without the option.
2901         Windows DumpRenderTree will need to be fixed separately (that's easy).
2902
2903         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
2904         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
2905         slightly better to use stderr in both, as this is an out of band message, but
2906         that's a larger refactoring, and the difference is minimal in practice.
2907
2908         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2909         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
2910         different. We want the tool to reliably detect timeouts that can be detected, and
2911         not race with the script for that.
2912
2913         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
2914         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
2915         is honored inmore cases, that could make tests run slower.
2916         * Scripts/webkitpy/port/driver.py:
2917         (Driver.__init__):
2918         (Driver.run_test):
2919         (Driver.cmd_line):
2920         (Driver._check_for_driver_timeout):
2921         Detect tests that have the timeout output, and make these have the proper Timeout result.
2922
2923         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
2924         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
2925
2926         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2927         (WTR::TestRunner::setCustomTimeout): Deleted.
2928         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2929         (WTR::TestRunner::setCustomTimeout):
2930         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2931         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2932         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2933         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2934         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2935         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2936         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2937         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2938         Updated to use a timeout passed from UI process, which used to be ignored.
2939
2940         * WebKitTestRunner/TestController.cpp:
2941         (WTR::TestController::TestController):
2942         (WTR::TestController::runUntil):
2943         (WTR::TestController::getCustomTimeout): Deleted.
2944         * WebKitTestRunner/TestController.h:
2945         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
2946         Changed default message timeouts to match new run-webkit-tests timeout. These don't
2947         affect ports where timeout is passed per test (shouldn't they all be like that?).
2948
2949         * WebKitTestRunner/TestInvocation.cpp:
2950         (WTR::TestInvocation::invoke):
2951         (WTR::TestInvocation::setCustomTimeout): Deleted.
2952         * WebKitTestRunner/TestInvocation.h:
2953         (WTR::TestInvocation::setCustomTimeout):
2954         (WTR::TestInvocation::customTimeout):
2955         Ditto.
2956
2957 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2958
2959         [EFL] Add logging domain for MiniBrowser
2960         https://bugs.webkit.org/show_bug.cgi?id=139642
2961
2962         Reviewed by Gyuyoung Kim.
2963
2964         Similarly to EWebKit2, provide logging facility for MiniBrowser
2965         based on Eina Log module to have a convenient way to display
2966         all/subset/none messages for EFL based libraries and MiniBrowser.
2967
2968         Usage:
2969         1. Disable all messages:
2970            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
2971
2972         2. Enable all messages:
2973            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
2974
2975         3. Enable MiniBrowser and EWebkit2 messages only:
2976            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
2977
2978         More information and examples you can find here:
2979         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
2980
2981         * MiniBrowser/efl/main.c:
2982         (on_mouse_wheel):
2983         (on_window_resize):
2984         (save_page_contents_callback):
2985         (script_execute_callback):
2986         (on_key_down):
2987         (on_download_request):
2988         (on_download_finished):
2989         (on_download_failed):
2990         (quit):
2991         (on_refresh_button_clicked):
2992         (on_stop_button_clicked):
2993         (navigation_button_longpress_process):
2994         (on_popup_menu_item_clicked):
2995         (popup_menu_populate):
2996         (on_popup_menu_show):
2997         (on_window_create):
2998         (context_menu_item_selected_cb):
2999         (context_menu_populate):
3000         (on_context_menu_show):
3001         (on_context_menu_hide):
3002         (on_navigation_policy_decision):
3003         (window_create):
3004         (parse_cookies_policy):
3005         (elm_main):
3006         (has_scheme):
3007         (list_item_label_get):
3008         (on_popup_menu_hide):
3009         (on_window_close):
3010         (on_home_button_clicked):
3011         Replace locally info() macro with newly introduced
3012         one which uses Eina Log module. There is no logic change.
3013
3014 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3015
3016         [EFL] FTL JIT not working on ARM64
3017         https://bugs.webkit.org/show_bug.cgi?id=139295
3018
3019         Reviewed by Michael Saboff.
3020
3021         Added patches for llvm to add ARM64 support for FTL JIT
3022
3023         * efl/jhbuild.modules:
3024         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
3025         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
3026
3027 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
3028
3029         Move Said to the committers section.
3030
3031         * Scripts/webkitpy/common/config/contributors.json:
3032
3033 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
3034
3035         Implement Data Detectors immediate actions for WebKit2
3036         https://bugs.webkit.org/show_bug.cgi?id=139617
3037         <rdar://problem/19198539>
3038
3039         Reviewed by Beth Dakin.
3040
3041         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3042         (TestWebKitAPI::TEST):
3043         Temporarily disable the action menu tests while the
3044         underlying code is in flux.
3045
3046 2014-12-14  Andreas Kling  <akling@apple.com>
3047
3048         Replace PassRef with Ref/Ref&& across the board.
3049         <https://webkit.org/b/139587>
3050
3051         Reviewed by Darin Adler.
3052
3053         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3054         (TestWebKitAPI::passWithRef):
3055         (TestWebKitAPI::TEST):
3056         (TestWebKitAPI::passWithPassRef): Deleted.
3057         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3058         (TestWebKitAPI::TEST):
3059         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3060         (TestWebKitAPI::TEST):
3061         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3062         (TestWebKitAPI::createTestValue):
3063
3064 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3065
3066         [EFL] MiniBrowser's window_create may return NULL
3067         https://bugs.webkit.org/show_bug.cgi?id=139585
3068
3069         Reviewed by Gyuyoung Kim.
3070
3071         Move NULL checking before using object which window_create
3072         returns.
3073
3074         * MiniBrowser/efl/main.c:
3075         (elm_main):
3076
3077 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
3078
3079         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
3080         https://bugs.webkit.org/show_bug.cgi?id=73030
3081
3082         Reviewed by Anders Carlsson.
3083
3084         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
3085         database to empty to avoid having it fetch default favicons at random times.
3086         DumpRenderTree also disables it, and also it has a way for tests to temporarily
3087         enable it.
3088
3089 2014-12-12  Lucas Forschler  <lforschler@apple.com>
3090
3091         Update Apple owned build slaves after infrastructure update.
3092         
3093         Reviewed by Ryosuke Niwa.
3094
3095         * BuildSlaveSupport/build.webkit.org-config/config.json:
3096
3097 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3098
3099         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
3100         https://bugs.webkit.org/show_bug.cgi?id=139537
3101
3102         Reviewed by Carlos Garcia Campos.
3103
3104         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
3105         of get_dependencies_path().
3106         * jhbuild/jhbuildutils.py:
3107         (get_dependencies_path): Fix the function to return the new
3108         dependencies path: DependenciesPORT.
3109         (enter_jhbuild_environment_if_available): Pass the port name
3110         when invoking get_dependencies_path().
3111
3112 2014-12-10  Lucas Forschler  <lforschler@apple.com>
3113
3114         Update Apple owned build slaves.
3115         
3116         Rubber-stamped by Dana Burkart.
3117         
3118         * BuildSlaveSupport/build.webkit.org-config/config.json:
3119
3120 2014-12-10  Daniel Bates  <dabates@apple.com>
3121
3122         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
3123         timeout instead of test failure
3124         https://bugs.webkit.org/show_bug.cgi?id=139525
3125
3126         Reviewed by Zalan Bujtas.
3127
3128         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
3129         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
3130         output.
3131
3132         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
3133         for the WebThread to spin its run loop before dumping its output. A test that
3134         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
3135         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
3136         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
3137         because run-webkit-tests may terminate a DumpRenderTree.app process when it
3138         exceeds its process time limit (defaults to 35ms) regardless of whether such
3139         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
3140
3141         * Scripts/webkitpy/port/ios.py:
3142         (IOSSimulatorPort.default_timeout_ms):
3143
3144 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3145
3146         [GTK][WK2] Add HTML5 Notifications support
3147         https://bugs.webkit.org/show_bug.cgi?id=61140
3148
3149         Reviewed by Carlos Garcia Campos.
3150
3151         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
3152         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3153         (testWebViewNotification):
3154         (beforeAll):
3155         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
3156         (permissionRequestDialogCallback):
3157         (webViewDecidePermissionRequest):
3158         (geolocationRequestDialogCallback): Deleted.
3159
3160 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
3161
3162         Fix webkitpy test expectation
3163
3164         Not sure what I messed up, but TOTAL_SKIPS was not right.
3165
3166         * Scripts/webkitpy/port/test.py:
3167
3168 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
3169
3170         Remove virtual test support from webkitpy
3171         https://bugs.webkit.org/show_bug.cgi?id=139427
3172
3173         Reviewed by Alexey Proskuryakov.
3174
3175         It seems that the only concrete client of virtual tests is the unit tests :D
3176
3177         This patch tries to clean as much useless code as possible.
3178
3179         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3180         (RunTest.test_tolerance):
3181         (RunTest.test_virtual): Deleted.
3182         * Scripts/webkitpy/layout_tests/views/printing.py:
3183         (Printer._print_test_trace):
3184         * Scripts/webkitpy/port/base.py:
3185         (Port.expected_filename):
3186         (Port.tests):
3187         (Port.test_isfile):
3188         (Port.test_isdir):
3189         (Port.sample_process):
3190         (Port.find_system_pid):
3191         (Port.test_expectations_file_position):
3192         (Port.virtual_test_suites): Deleted.
3193         (Port): Deleted.
3194         (Port.populated_virtual_test_suites): Deleted.
3195         (Port._virtual_tests): Deleted.
3196         (Port.lookup_virtual_test_base): Deleted.
3197         (Port.lookup_virtual_test_args): Deleted.
3198         (VirtualTestSuite): Deleted.
3199         (VirtualTestSuite.__init__): Deleted.
3200         (VirtualTestSuite.__repr__): Deleted.
3201         * Scripts/webkitpy/port/base_unittest.py:
3202         (PortTest.test_test_exists):
3203         (PortTest.test_test_isfile):
3204         (PortTest.test_test_isdir):
3205         (PortTest.test_tests):
3206         * Scripts/webkitpy/port/driver.py:
3207         (DriverProxy.run_test): Deleted.
3208         * Scripts/webkitpy/port/test.py:
3209         (TestPort._skipped_tests_for_unsupported_features):
3210         (TestPort.all_baseline_variants):
3211         (TestPort.virtual_test_suites): Deleted.
3212         * Scripts/webkitpy/tool/commands/queries.py:
3213         (PrintBaselines.__init__):
3214         (PrintBaselines.execute):
3215         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3216         (PrintBaselinesTest.test_basic):
3217         (PrintBaselinesTest.test_multiple):
3218         (PrintBaselinesTest.test_csv):
3219
3220 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3221
3222         Blink Merge: Remove 'http_lock' code from webkitpy
3223         https://bugs.webkit.org/show_bug.cgi?id=136722
3224
3225         Reviewed by Alexey Proskuryakov.
3226
3227         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
3228         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
3229
3230         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3231         (LayoutTestRunner.__init__):
3232         (LayoutTestRunner.run_tests):
3233         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
3234         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
3235         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3236         (FakePrinter.flush):
3237         (LayoutTestRunnerTests._runner):
3238         (LayoutTestRunnerTests._run_tests):
3239         (LayoutTestRunnerTests.test_servers_started):
3240         (LockCheckingRunner): Deleted.
3241         (LockCheckingRunner.__init__): Deleted.
3242         (LockCheckingRunner.handle_finished_list): Deleted.
3243         (LayoutTestRunnerTests.test_http_locking): Deleted.
3244         * Scripts/webkitpy/port/base.py:
3245         (Port.__init__):
3246         (Port.to.http_server_supports_ipv6):
3247         (Port.to.stop_websocket_server):
3248         (Port.to.acquire_http_lock): Deleted.
3249         (Port.to.release_http_lock): Deleted.
3250         * Scripts/webkitpy/port/http_lock.py: Removed.
3251         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
3252         * Scripts/webkitpy/port/ios.py:
3253         (IOSSimulatorPort.show_results_html_file):
3254         (IOSSimulatorPort.acquire_http_lock): Deleted.
3255         (IOSSimulatorPort): Deleted.
3256         (IOSSimulatorPort.release_http_lock): Deleted.
3257         * Scripts/webkitpy/port/mac.py:
3258         (MacPort.show_results_html_file):
3259         (MacPort): Deleted.
3260         (MacPort.acquire_http_lock): Deleted.
3261         (MacPort.release_http_lock): Deleted.
3262         * Scripts/webkitpy/port/mock_drt.py:
3263         (MockDRTPort.start_websocket_server):
3264         (MockDRTPort.stop_websocket_server):
3265         (MockDRTPort.acquire_http_lock): Deleted.
3266         (MockDRTPort.release_http_lock): Deleted.
3267         * Scripts/webkitpy/port/mock_drt_unittest.py:
3268         (MockDRTPortTest.test_uses_apache):
3269         (MockDRTPortTest.integration_test_http_lock): Deleted.
3270         * Scripts/webkitpy/port/port_testcase.py:
3271         (PortTestCase.assert_servers_are_up):
3272         (PortTestCase.integration_test_http_lock): Deleted.
3273         * Scripts/webkitpy/port/test.py:
3274         (TestPort.start_websocket_server):
3275         (TestPort.stop_websocket_server):
3276         (TestPort.acquire_http_lock): Deleted.
3277         (TestPort.release_http_lock): Deleted.
3278
3279 2014-12-09  Alberto Garcia  <berto@igalia.com>
3280
3281         convertToUTF8String converts null string to empty string
3282         https://bugs.webkit.org/show_bug.cgi?id=133904
3283
3284         Reviewed by Carlos Garcia Campos.
3285
3286         Test that trying to get the value of a non-existent attribute
3287         returns 0 instead of an empty string.
3288
3289         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3290         (WebKitDOMNodeTest::testInsertion):
3291
3292 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
3293
3294         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
3295         https://bugs.webkit.org/show_bug.cgi?id=139070
3296
3297         Reviewed by Carlos Garcia Campos.
3298
3299         * gtk/jhbuild.modules:
3300
3301 2014-12-08  Tim Horton  <timothy_horton@apple.com>
3302
3303         Add action menu tests
3304         https://bugs.webkit.org/show_bug.cgi?id=139156
3305
3306         Reviewed by Dean Jackson.
3307
3308         * TestWebKitAPI/PlatformWebView.h:
3309         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3310         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3311         Add a mechanism allowing tests to provide their own WKView subclass.
3312
3313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3314         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
3315         Add a file with lots of menu targets.
3316
3317         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
3318         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
3319         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
3320         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
3321         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
3322
3323         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
3324
3325         (TestWebKitAPI::didFinishLoadForFrameCallback):
3326         (TestWebKitAPI::didFinishDownloadCallback):
3327         (TestWebKitAPI::didCreateDownloadDestinationCallback):
3328         Watch downloads and ensure that they match the content we expect.
3329
3330         (TestWebKitAPI::watchPasteboardForString):
3331         (TestWebKitAPI::watchPasteboardForImage):
3332         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
3333         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
3334         (TestWebKitAPI::javaScriptStringCallback):
3335         (TestWebKitAPI::javaScriptBoolCallback):
3336         (TestWebKitAPI::callJavaScriptReturningString):
3337         (TestWebKitAPI::callJavaScriptReturningBool):
3338         (TestWebKitAPI::watchEditableAreaForString):
3339         (TestWebKitAPI::waitForVideoReady):
3340         (TestWebKitAPI::retrieveSelection):
3341         (TestWebKitAPI::retrieveSelectionInElement):
3342         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
3343         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
3344         Add many helpers for testing, especially to make asynchronous things synchronous.
3345
3346         (TestWebKitAPI::windowPointForTarget):
3347         (TestWebKitAPI::inset8):
3348         Hard-code points in action-menu-targets.html for hit testing.
3349
3350         (TestWebKitAPI::TEST):
3351         Add a suite of tests for WebKit2 action menus.
3352
3353         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
3354         (TestWebKitAPI::createActionContextForPhoneNumber):
3355         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
3356         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
3357         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
3358         (TestWebKitAPI::ActionMenuTest::drawRect):
3359         (TestWebKitAPI::ActionMenuTest::didCreatePage):
3360         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
3361         so that we can test that infrastructure.
3362
3363 2014-12-08  Philippe Normand  <pnormand@igalia.com>
3364
3365         [GTK] UserMedia Permission Request API
3366         https://bugs.webkit.org/show_bug.cgi?id=136449
3367
3368         Reviewed by Carlos Garcia Campos.
3369
3370         The GTK version of the MiniBrowser has gained UserMedia permission
3371         request support.
3372
3373         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
3374         requires user permission to access audio/video devices.
3375         (permissionRequestDialogCallback):
3376         (webViewDecidePermissionRequest):
3377         (geolocationRequestDialogCallback): Deleted.
3378
3379 2014-12-08  Anders Carlsson  <andersca@apple.com>
3380
3381         Add a stubbed out method for clearing out the website data store
3382         https://bugs.webkit.org/show_bug.cgi?id=139404
3383
3384         Reviewed by Antti Koivisto.
3385
3386         Add a debug menu item for testing clearing of website data.
3387
3388         * MiniBrowser/mac/MainMenu.xib:
3389         * MiniBrowser/mac/WK2BrowserWindowController.m:
3390         (-[WK2BrowserWindowController clearWebsiteData:]):
3391
3392 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
3393
3394         Update style checker to deal with "const override"
3395         https://bugs.webkit.org/show_bug.cgi?id=139371
3396
3397         Reviewed by Csaba Osztrogonác.
3398
3399         check-webkit-style shouldn't complain about an open brace to start a
3400         line after a function definition with const override.
3401
3402         * Scripts/webkitpy/style/checkers/cpp.py:
3403         (check_braces):
3404         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3405         (CppStyleTest.test_brace_at_begin_of_line):
3406
3407 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3408
3409         [GTK] Fix GObject DOM bindings API break tests after r176920
3410         https://bugs.webkit.org/show_bug.cgi?id=139368
3411
3412         Reviewed by Gustavo Noronha Silva.
3413
3414         Remove the @version from the symbol name before comparing.
3415
3416         * gtk/check-for-webkitdom-api-breaks:
3417         (read_expected_api):
3418
3419 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3420
3421         Remove the option to automatically update the GObject DOM bindings symbols file
3422         https://bugs.webkit.org/show_bug.cgi?id=139366
3423
3424         Reviewed by Martin Robinson.
3425
3426         It's currently broken, because symbols now need to be in a
3427         specific order. Now that the symbols file only contains stable
3428         API, it's not a problem to manually update it every time new API
3429         is added.
3430
3431         * gtk/check-for-webkitdom-api-breaks:
3432         (read_expected_api):
3433         (check_api):
3434         (write_expected_api): Deleted.
3435
3436 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3437
3438         [GTK] Use GMainLoopSource in WebKitTestRunner
3439         https://bugs.webkit.org/show_bug.cgi?id=138831
3440
3441         Reviewed by Sergio Villar Senin.
3442
3443         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3444         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3445         (WTR::TestRunner::platformInitialize):
3446         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3447         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3448         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
3449         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3450         (WTR::TestController::notifyDone):
3451         (WTR::TestController::platformRunUntil):
3452         (WTR::cancelTimeout): Deleted.
3453
3454 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3455
3456         [GTK] Missing API detected in GObject DOM bindings after r176630
3457         https://bugs.webkit.org/show_bug.cgi?id=139201
3458
3459         Reviewed by Gustavo Noronha Silva.
3460
3461         Handle deprecated symbols again when generating the GObject DOM
3462         bindings documentation.
3463
3464         * gtk/webkitdom.py:
3465         (WebKitDOMDocGenerator):
3466         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
3467         (WebKitDOMDocGenerator.generate):
3468         (WebKitDOMDocGeneratorSections.__init__):
3469         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
3470         (WebKitDOMDocGeneratorSections.write_section):
3471
3472 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
3473
3474         [EFL][jhbuild] Fix libsoup build with clang
3475         https://bugs.webkit.org/show_bug.cgi?id=139088
3476
3477         Reviewed by Gyuyoung Kim.
3478
3479         * efl/jhbuild.modules:
3480         * efl/patches/soup-clang-warning-fix1.patch: Added.
3481         * efl/patches/soup-clang-warning-fix2.patch: Added.
3482
3483 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
3484
3485         [Mac] DumpRenderTree sets storage directory incorrectly
3486         https://bugs.webkit.org/show_bug.cgi?id=139347
3487
3488         Reviewed by Dan Bernstein.
3489
3490         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3491         Don't use user defaults to pass per-instance paths, as user defaults are shared
3492         across all instances.
3493
3494 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
3495
3496         AX: I cannot activate links on the mobile version of news.google.com
3497         https://bugs.webkit.org/show_bug.cgi?id=139330
3498
3499         Reviewed by Simon Fraser.
3500
3501         Implement press for iOS.
3502
3503         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3504         (AccessibilityUIElement::press):
3505
3506 2014-12-05  Daniel Bates  <dabates@apple.com>
3507
3508         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
3509         https://bugs.webkit.org/show_bug.cgi?id=139326
3510
3511         Reviewed by Anders Carlsson.
3512
3513         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
3514         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
3515         using the same scale factor as used in WebKit.
3516
3517         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3518         (createBitmapContextFromWebView):
3519
3520 2014-12-05  Anders Carlsson  <andersca@apple.com>
3521
3522         REGRESSION (r176677): All tests crash on Windows
3523         https://bugs.webkit.org/show_bug.cgi?id=139321
3524
3525         Reviewed by Alexey Proskuryakov.
3526
3527         * DumpRenderTree/win/DumpRenderTree.cpp:
3528         (runTest):
3529         Don't call CFRelease on the url while we have an outstanding pointer to its string,
3530         and use the right number of bytes when allocating the testURL buffer.
3531
3532 2014-12-05  Daniel Bates  <dabates@apple.com>
3533
3534         [iOS] DumpRenderTree produces many reference test mismatches
3535         https://bugs.webkit.org/show_bug.cgi?id=139314
3536
3537         Reviewed by Simon Fraser.
3538
3539         Fixes an issue where the scale factor used to render the snapshot taken by
3540         DumpRenderTree may differ from the device scale factor. In particular, the
3541         scale factor used to render a snapshot of a test may differ from the scale
3542         factor used to render the snapshot of its expected result.
3543
3544         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
3545         snapshot the UIWebBrowserView. This SPI always render using a scale factor
3546         of one when the backing store for the LegacyTileLayer objects were out-of-
3547         date regardless of the device scale factor. Instead we should use UIImage
3548         and CALayer API to perform the snapshot with respect to the device scale
3549         factor.
3550
3551         Additionally write iOS pixel dump support logic in terms of existing
3552         DumpRenderTree abstractions so as to support generating and comparing
3553         pixel dump checksums as well as make the iOS code more consistent with
3554         the logic used by other ports.
3555
3556         * DumpRenderTree/PixelDumpSupport.cpp:
3557         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
3558         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3559         (BitmapContext::createFromUIImage): Added.
3560         (BitmapContext::pixelData): Added.
3561         (BitmapContext::BitmapContext): Added.
3562         (computeMD5HashStringForBitmapContext): Added.
3563         (dumpBitmap): Added.
3564         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
3565         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
3566
3567 2014-12-05  Anders Carlsson  <andersca@apple.com>
3568
3569         Give all web pages a website data store
3570         https://bugs.webkit.org/show_bug.cgi?id=139317
3571
3572         Reviewed by Tim Horton.
3573
3574         * MiniBrowser/mac/AppDelegate.m:
3575         (-[BrowserAppDelegate newPrivateWindow:]):
3576         Don't release the controller - it's implicitly retained by the window.
3577
3578 2014-12-05  Daniel Bates  <dabates@apple.com>
3579
3580         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
3581         https://bugs.webkit.org/show_bug.cgi?id=137581
3582         <rdar://problem/18642906>
3583
3584         Reviewed by Simon Fraser.
3585
3586         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
3587         of the test that proceeded the currently running test.
3588
3589         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3590         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
3591         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
3592         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
3593
3594 2014-12-05  Jer Noble  <jer.noble@apple.com>
3595
3596         [WTF] MediaTime should support round-tripping from and to doubles.
3597         https://bugs.webkit.org/show_bug.cgi?id=139248
3598
3599         Reviewed by Eric Carlson.
3600
3601         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
3602         the MediaTimes after this change.
3603
3604         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3605         (WTF::operator<<):
3606         (TestWebKitAPI::TEST):
3607         * lldb/lldb_webkit.py:
3608         (WTFMediaTime_SummaryProvider):
3609         (WTFMediaTimeProvider.timeValueAsDouble):
3610         (WTFMediaTimeProvider.isIndefinite):
3611         (WTFMediaTimeProvider):
3612         (WTFMediaTimeProvider.hasDoubleValue):
3613
3614 2014-12-05  Anders Carlsson  <andersca@apple.com>
3615
3616         Add a private browsing mode to MiniBrowser
3617         https://bugs.webkit.org/show_bug.cgi?id=139308
3618
3619         Reviewed by Sam Weinig.
3620
3621         * MiniBrowser/mac/AppDelegate.m:
3622      &nb