f764a9776f86b0c728084f2b34437a96360a0d13
[WebKit-https.git] / Tools / ChangeLog
1 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
2
3         [Win] Implement modal dialog support in MiniBrowser.
4         https://bugs.webkit.org/show_bug.cgi?id=158976
5
6         Reviewed by Brent Fulgham.
7
8         * MiniBrowser/win/PrintWebUIDelegate.cpp:
9         (PrintWebUIDelegate::createWebViewWithRequest):
10         (getHandleFromWebView):
11         (PrintWebUIDelegate::webViewClose):
12         (PrintWebUIDelegate::setFrame):
13         (PrintWebUIDelegate::webViewFrame):
14         (PrintWebUIDelegate::canRunModal):
15         (findTopLevelParent):
16         (PrintWebUIDelegate::runModal):
17         (PrintWebUIDelegate::createModalDialog):
18         * MiniBrowser/win/PrintWebUIDelegate.h:
19         (PrintWebUIDelegate::webViewClose):
20         (PrintWebUIDelegate::setFrame):
21         (PrintWebUIDelegate::webViewFrame):
22         (PrintWebUIDelegate::canRunModal):
23         (PrintWebUIDelegate::runModal):
24
25 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
26
27         window.showModalDialog doesn't work in DumpRenderTree on Windows
28         https://bugs.webkit.org/show_bug.cgi?id=53675
29
30         Reviewed by Brent Fulgham.
31
32         Implement modal dialog support in DumpRenderTree.
33
34         * DumpRenderTree/win/UIDelegate.cpp:
35         (UIDelegate::canRunModal):
36         (getHandleFromWebView):
37         (UIDelegate::createModalDialog):
38         (findTopLevelParent):
39         (UIDelegate::runModal):
40         (UIDelegate::webViewClose):
41         * DumpRenderTree/win/UIDelegate.h:
42
43 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
44
45         Fix formatting issues reported by check-webkit-style
46         https://bugs.webkit.org/show_bug.cgi?id=159008
47
48         Reviewed by Alexey Proskuryakov.
49
50         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
51         There is no functionality change.
52
53         * Scripts/webkitpy/tool/bot/irc_command.py:
54         (Restart.execute):
55         (Rollout):
56         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
57         (IRCBotTest.test_exception_during_command):
58         (IRCBotTest.test_exception_during_command.CommandWithException):
59         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
60         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
61         (test_missing_unit_test_results_path):
62         (test_layout_test_results):
63         * Scripts/webkitpy/tool/bot/queueengine.py:
64         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
65         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
66         (AbstractSequencedCommand):
67         (AbstractSequencedCommand.__init__):
68         * Scripts/webkitpy/tool/commands/download.py:
69         (Land):
70         * Scripts/webkitpy/tool/commands/openbugs.py:
71         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
72         (OpenBugsTest):
73         * Scripts/webkitpy/tool/commands/queries.py:
74         (PatchesToCommitQueue):
75         (PatchesToCommitQueue.__init__):
76         (PatchesToCommitQueue._needs_commit_queue):
77         * Scripts/webkitpy/tool/commands/queries_unittest.py:
78         (PrintExpectationsTest.test_platform):
79         (PrintBaselinesTest):
80         (PrintBaselinesTest.setUp):
81         * Scripts/webkitpy/tool/commands/queues.py:
82         (AbstractQueue):
83         (AbstractQueue.__init__):
84         (AbstractQueue.execute):
85         * Scripts/webkitpy/tool/commands/queues_unittest.py:
86         (test_auto_retry):
87         * Scripts/webkitpy/tool/commands/rebaseline.py:
88         (AbstractParallelRebaselineCommand._files_to_add):
89         (AbstractParallelRebaselineCommand):
90         (AbstractParallelRebaselineCommand._rebaseline):
91         * Scripts/webkitpy/tool/commands/setupgitclone.py:
92         (SetupGitClone):
93         * Scripts/webkitpy/tool/commands/sheriffbot.py:
94         * Scripts/webkitpy/tool/commands/stepsequence.py:
95         * Scripts/webkitpy/tool/commands/upload.py:
96         (PostCommits._comment_text_for_commit):
97         (PostCommits):
98         (PostCommits.execute):
99         (MarkBugFixed):
100         (MarkBugFixed.__init__):
101         * Scripts/webkitpy/tool/commands/upload_unittest.py:
102         (UploadCommandsTest):
103         (UploadCommandsTest.test_commit_message_for_current_diff):
104         * Scripts/webkitpy/tool/grammar_unittest.py:
105         (GrammarTest):
106         (GrammarTest.test_join_with_separators):
107         * Scripts/webkitpy/tool/multicommandtool.py:
108         (HelpCommand.__init__):
109         (HelpCommand):
110         (HelpCommand._help_epilog):
111         (HelpCommand._remove_help_options):
112         (MultiCommandTool):
113         (MultiCommandTool.__init__):
114         (MultiCommandTool.main):
115         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
116         (TrivialCommand):
117         (TrivialCommand.__init__):
118         (MultiCommandToolTest):
119         (MultiCommandToolTest._assert_tool_main_outputs):
120         (MultiCommandToolTest.test_retry):
121         (test_command_help):
122         * Scripts/webkitpy/tool/steps/__init__.py:
123         * Scripts/webkitpy/tool/steps/abstractstep.py:
124         * Scripts/webkitpy/tool/steps/applypatch.py:
125         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
126         (ApplyPatchWithLocalCommit):
127         (ApplyPatchWithLocalCommit.options):
128         * Scripts/webkitpy/tool/steps/build.py:
129         * Scripts/webkitpy/tool/steps/checkstyle.py:
130         (CheckStyle):
131         (CheckStyle.options):
132         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
133         * Scripts/webkitpy/tool/steps/closebug.py:
134         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
135         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
136         (CloseBugForLandDiffTest):
137         (CloseBugForLandDiffTest.test_empty_state):
138         * Scripts/webkitpy/tool/steps/closepatch.py:
139         * Scripts/webkitpy/tool/steps/commit.py:
140         (Commit.run):
141         * Scripts/webkitpy/tool/steps/confirmdiff.py:
142         * Scripts/webkitpy/tool/steps/editchangelog.py:
143         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
144         * Scripts/webkitpy/tool/steps/metastep.py:
145         (MetaStep):
146         (MetaStep.__init__):
147         (MetaStep.run):
148         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
149         * Scripts/webkitpy/tool/steps/options.py:
150         (Options):
151         * Scripts/webkitpy/tool/steps/postdiff.py:
152         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
153         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
154         * Scripts/webkitpy/tool/steps/preparechangelog.py:
155         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
156         (PrepareChangeLogTest):
157         (PrepareChangeLogTest.test_resolve_existing_entry):
158         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
159         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
160         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
161         * Scripts/webkitpy/tool/steps/revertrevision.py:
162         * Scripts/webkitpy/tool/steps/runtests.py:
163         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
164         * Scripts/webkitpy/tool/steps/steps_unittest.py:
165         (StepsTest):
166         (StepsTest._step_options):
167         * Scripts/webkitpy/tool/steps/update.py:
168         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
169         (UpdateChangeLogsWithReviewerTest):
170         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
171         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
172         * Scripts/webkitpy/tool/steps/validatereviewer.py:
173
174 2016-06-21  Chris Dumez  <cdumez@apple.com>
175
176         Unreviewed, rolling out r202296.
177
178         Broke basic browsing in Safari
179
180         Reverted changeset:
181
182         "WKWebView with no WKNavigationDelegate does not follow
183         universal links"
184         https://bugs.webkit.org/show_bug.cgi?id=158997
185         http://trac.webkit.org/changeset/202296
186
187 2016-06-21  Anders Carlsson  <andersca@apple.com>
188
189         Fix build.
190
191         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
192
193 2016-06-21  Anders Carlsson  <andersca@apple.com>
194
195         Begin moving the Apple Pay code to the open source repository
196         https://bugs.webkit.org/show_bug.cgi?id=158998
197
198         Reviewed by Tim Horton.
199
200         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
201         Add ENABLE_APPLE_PAY.
202
203 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
204
205         Add system tracing points for requestAnimationFrame() workflow
206         https://bugs.webkit.org/show_bug.cgi?id=158723
207
208         Reviewed by Simon Fraser.
209
210         Add new plist entries to be used by kdebug_trace() viewing tools.
211
212         * Tracing/SystemTracePoints.plist:
213
214 2016-06-21  Sam Weinig  <sam@webkit.org>
215
216         WKWebView with no WKNavigationDelegate does not follow universal links
217         <rdar://problem/24374110>
218         https://bugs.webkit.org/show_bug.cgi?id=158997
219
220         Reviewed by Dan Bernstein.
221
222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
223         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
224         Add a new test that shows that we have a default navigation delegate by swizzling
225         -[NSWorkspace openURL:]. This will only be called if there is a default client.
226
227 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
228
229         run-javascriptcore-tests should have flag to skip mozilla tests
230         https://bugs.webkit.org/show_bug.cgi?id=158963
231         rdar://problem/25838924
232
233         Reviewed by Alexey Proskuryakov.
234
235         * Scripts/run-javascriptcore-tests:
236         (runJSCStressTests): Added flag to skip mozilla tests.
237
238 2016-06-20  Commit Queue  <commit-queue@webkit.org>
239
240         Unreviewed, rolling out r202136.
241         https://bugs.webkit.org/show_bug.cgi?id=158932
242
243         JSBench wasn't regressed by r202002 and r202111 on iOS after
244         all (Requested by rniwa_ on #webkit).
245
246         Reverted changeset:
247
248         "Unreviewed, rolling out r202002 and r202111."
249         https://bugs.webkit.org/show_bug.cgi?id=158638
250         http://trac.webkit.org/changeset/202136
251
252 2016-06-20  Keith Rollin  <krollin@apple.com>
253
254         Remove RefPtr::release() and change calls sites to use WTFMove()
255         https://bugs.webkit.org/show_bug.cgi?id=158369
256
257         Reviewed by Chris Dumez.
258
259         RefPtr::release() releases its managed pointer awkwardly. It's more
260         direct and clearer to use WTFMove to transfer ownership of the managed
261         pointer.
262
263         As part of this cleanup, also change a lot of explicit data types to
264         'auto'.
265
266         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
267         (createBitmapContextFromWebView):
268         (createPagedBitmapContext):
269         * DumpRenderTree/mac/TestRunnerMac.mm:
270         (TestRunner::setMockGeolocationPosition):
271         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
272         (TestWebKitAPI::TEST):
273         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
274         (TestWebKitAPI::TEST):
275
276 2016-06-20  Tim Horton  <timothy_horton@apple.com>
277
278         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
279         https://bugs.webkit.org/show_bug.cgi?id=158947
280
281         Reviewed by Simon Fraser.
282
283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
284         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
285         (TestWebKitAPI::didFinishLoadForFrame):
286         (TestWebKitAPI::setPageLoaderClient):
287         (TestWebKitAPI::TEST):
288         Add a test ensuring that in-window state changes are deferred when using
289         the SPI for deferring them, as fixed in r202230.
290
291 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
292
293         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
294         https://bugs.webkit.org/show_bug.cgi?id=158931
295
296         Reviewed by Alexey Proskuryakov.
297
298         * WebKitTestRunner/TestInvocation.cpp:
299         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
300
301 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
302
303         Add test expectations for macOS Sierra
304         https://bugs.webkit.org/show_bug.cgi?id=158903
305
306         Reviewed by Alex Christensen.
307
308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
311         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
312         Added dashboard support.
313
314         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
315         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
316         Trigger the right build queues on check-in.
317
318         * Scripts/webkitpy/common/system/platforminfo.py:
319         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
320         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
321         * Scripts/webkitpy/port/mac.py:
322         * Scripts/webkitpy/port/mac_unittest.py:
323         * TestResultServer/static-dashboards/flakiness_dashboard.js:
324         Added cases for Sierra, and updated tests for new baseline search paths.
325
326 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
327
328         Another buid fix for master.cfg.
329
330         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
331         (CompileWebKit.start):
332
333 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
334
335         Another buid fix for master.cfg.
336
337         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
338         (CompileWebKit.start):
339
340 2016-06-19  Lucas Forschler  <lforschler@apple.com>
341
342         Fix master.cfg
343         
344         Unreviewed build fix.
345
346         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
347         (CompileWebKit.start):
348
349 2016-06-19  Lucas Forschler  <lforschler@apple.com>
350
351         Test another commit.
352         
353         Unreviewed.
354
355 2016-06-19  Lucas Forschler  <lforschler@apple.com>
356
357         Testing fix for trac-mirror.
358         
359         Unreviewed.
360
361 2016-06-19  Lucas Forschler  <lforschler@apple.com>
362
363         Test a commit against the SVN 1.9 server upgrade.
364         
365         Unreviewed.
366         
367 2016-06-17  Daniel Bates  <dabates@apple.com>
368
369         Unreviewed, rolling out r202186.
370
371         Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
372         builds.
373
374         Reverted changeset:
375
376         "File scheme should not allow access of a resource on a
377         different volume."
378         https://bugs.webkit.org/show_bug.cgi?id=158552
379         http://trac.webkit.org/changeset/202186
380
381 2016-06-17  Pranjal Jumde  <pjumde@apple.com>
382
383         File scheme should not allow access of a resource on a different volume.
384         https://bugs.webkit.org/show_bug.cgi?id=158552
385         <rdar://problem/15307582>
386
387         Reviewed by Brent Fulgham.
388
389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
390         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
391         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
392         (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
393         When the main page load is complete fetch the contents of the document to check if iframe was loaded
394         (createPartition):
395         Create a disk image and load the contents of the file.
396         (cleanUp):
397         (TestWebKitAPI::TEST):
398
399 2016-06-17  Enrique Ocaña González  <eocanha@igalia.com>
400
401         Unreviewed. Added myself to the list of committers.
402
403         * Scripts/webkitpy/common/config/contributors.json:
404
405 2016-06-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
406
407         [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
408         https://bugs.webkit.org/show_bug.cgi?id=158141
409
410         Reviewed by Michael Catanzaro.
411
412         * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
413         (Port._is_debian_php_version_7):
414         (Port._debian_php_version):
415         (Port._apache_config_file_name_for_platform):
416         * efl/install-dependencies:
417         * gtk/install-dependencies:
418
419 2016-06-16  Filip Pizlo  <fpizlo@apple.com>
420
421         Baseline JIT should be concurrent
422         https://bugs.webkit.org/show_bug.cgi?id=158755
423
424         Reviewed by Geoffrey Garen.
425         
426         Need to disable concurrent JIT when running profiler tests. We should have been doing this
427         all along.
428
429         * Scripts/run-jsc-stress-tests:
430
431 2016-06-16  Per Arne Vollan  <pvollan@apple.com>
432
433         [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
434         https://bugs.webkit.org/show_bug.cgi?id=140798
435
436         Reviewed by Brent Fulgham.
437        
438         Make sure layout is up-to-date before trying to find named elements. 
439
440         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
441         (AccessibilityController::rootElement):
442
443 2016-06-16  Chris Dumez  <cdumez@apple.com>
444
445         Unreviewed, rolling out r202002 and r202111.
446
447         Ryosuke says this was a JSBench regression on iOS
448
449         Reverted changesets:
450
451         "Make HashMap and HashSet work with Refs"
452         https://bugs.webkit.org/show_bug.cgi?id=158638
453         http://trac.webkit.org/changeset/202002
454
455         "Improve HashMap and HashSet support for Ref"
456         https://bugs.webkit.org/show_bug.cgi?id=158789
457         http://trac.webkit.org/changeset/202111
458
459 2016-06-15  Simon Fraser  <simon.fraser@apple.com>
460
461         [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
462         https://bugs.webkit.org/show_bug.cgi?id=158828
463
464         Reviewed by Enrica Casucci.
465         
466         Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
467         zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
468
469         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
470         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
471         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
472         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
473         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
474         * WebKitTestRunner/ios/TestControllerIOS.mm:
475         (WTR::TestController::platformResetStateToConsistentValues):
476         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
477         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
478         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
479
480 2016-06-15  Sam Weinig  <sam@webkit.org>
481
482         Forward/Back keyboard shortcuts need to flip for RTL
483         https://bugs.webkit.org/show_bug.cgi?id=158823
484         <rdar://problem/25975359>
485
486         Reviewed by Darin Adler.
487
488         Add tests for flipping the behavior of command-left and command-right
489         under RTL mode.
490
491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
492         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
493         (-[CommandBackForwardOffscreenWindow isKeyWindow]):
494         (-[CommandBackForwardOffscreenWindow isVisible]):
495         (simulateCommandArrow):
496         (WebKit2_CommandBackForwardTest::SetUp):
497         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
498         (WebKit2_CommandBackForwardTestWKView::SetUp):
499         (WebKit2_CommandBackForwardTestWKView::loadFiles):
500         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
501         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
502         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
503
504 2016-06-15  Tim Horton  <timothy_horton@apple.com>
505
506         Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
507         https://bugs.webkit.org/show_bug.cgi?id=158824
508         <rdar://problem/23713857>
509
510         Reviewed by Simon Fraser.
511
512         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
513         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
514         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
515         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
516         (TEST):
517         Add a test for _shouldExpandContentToViewHeightForAutoLayout.
518
519 2016-06-13  Simon Fraser  <simon.fraser@apple.com>
520
521         [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
522         https://bugs.webkit.org/show_bug.cgi?id=158714
523
524         Reviewed by Enrica Casucci.
525
526         Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
527         method that gets called from UIKit.
528
529         Add a test that exercises it.
530
531         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
532         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
533         (WTR::UIScriptController::keyboardAccessoryBarNext):
534         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
535         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
536         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
537         (WTR::UIScriptController::keyboardAccessoryBarNext):
538         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
539
540 2016-06-15  Sam Weinig  <sam@webkit.org>
541
542         Improve HashMap and HashSet support for Ref
543         https://bugs.webkit.org/show_bug.cgi?id=158789
544
545         Reviewed by Chris Dumez.
546
547         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
548         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
549         Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
550
551 2016-06-15  Aakash Jain  <aakash_jain@apple.com>
552
553         Too much log data generated during layout-tests on iOS Simulator
554         https://bugs.webkit.org/show_bug.cgi?id=158751
555
556         Reviewed by Alexey Proskuryakov.
557
558         * Scripts/webkitpy/port/ios.py:
559         (IOSSimulatorPort.developer_dir): memoized the property so that it is not called
560         repeatedly.
561
562 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
563
564         [Win][CMake] Changes in WebKit options are not reflected in incremental builds.
565         https://bugs.webkit.org/show_bug.cgi?id=158727
566
567         Reviewed by Alex Christensen.
568
569         Delete CMake cache file if WebKit options have been modified.
570
571         * Scripts/build-webkit:
572         * Scripts/webkitdirs.pm:
573         (shouldRemoveCMakeCache):
574
575 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
576
577         Enabling Shadow DOM for all platforms
578         https://bugs.webkit.org/show_bug.cgi?id=158738
579
580         Reviewed by Ryosuke Niwa.
581
582         Removed Shadow DOM from options (enabled by default)
583
584         * Scripts/webkitperl/FeatureList.pm:
585         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
586
587 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
588
589         [Win] The test accessibility/selected-text-range-aria-elements.html is failing.
590         https://bugs.webkit.org/show_bug.cgi?id=158732
591
592         Reviewed by Brent Fulgham.
593
594         Implement selectedTextRange() method.
595
596         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
597         (AccessibilityUIElement::selectedTextRange):
598
599 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
600
601         [Win] MiniBrowser is not DPI aware.
602         https://bugs.webkit.org/show_bug.cgi?id=158733
603
604         Reviewed by Brent Fulgham.
605
606         Call Win32 api function to let Windows know that we will scale the contents ourselves.
607
608         * MiniBrowser/win/WinMain.cpp:
609         (wWinMain):
610
611 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
612
613         Unreviewed: add new email address to contributors.json.
614
615         * Scripts/webkitpy/common/config/contributors.json:
616
617 2016-06-14  Keith Miller  <keith_miller@apple.com>
618
619         JSBench should use geometric mean
620         https://bugs.webkit.org/show_bug.cgi?id=158775
621
622         Reviewed by Mark Lam.
623
624         For some reason JSBench was using algebraic mean. Since each test
625         is pretty substantially different it should use geometric mean
626         instead.
627
628         * Scripts/run-jsc-benchmarks:
629
630 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
631
632         Debug crash logs are not fully symbolicated on Yosemite
633         https://bugs.webkit.org/show_bug.cgi?id=158760
634
635         Reviewed by Darin Adler.
636
637         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
638         for debug builds on Yosemite.
639
640 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
641
642         Tests don't work in iOS Simulator when ASan is enabled
643         https://bugs.webkit.org/show_bug.cgi?id=158726
644
645         Reviewed by David Kilzer.
646
647         * Scripts/webkitpy/port/driver.py:
648         (Driver._setup_environ_for_driver): Added a FIXME.
649         * Scripts/webkitpy/port/ios.py:
650         (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
651         simulator into LayoutTestRelay, which is a macOS tool.
652
653 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
654
655         Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
656         https://bugs.webkit.org/show_bug.cgi?id=158756
657
658         Reviewed by Alexey Proskuryakov.
659
660         * Scripts/webkitpy/xcode/simulator.py:
661         (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
662         the "simulator device" is still in booted state. Since we ensured that simulator device 
663         was in booted state earlier in this method, this indicates that simulator device has shut down
664         unexpectedly.
665
666 2016-06-14  David Kilzer  <ddkilzer@apple.com>
667
668         Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
669         <https://webkit.org/b/158743>
670
671         Unreviewed build fix.
672
673         * DumpRenderTree/PlatformMac.cmake: Fix silly typo.
674
675 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
676
677         Too much log data generated during layout-tests on iOS Simulator
678         https://bugs.webkit.org/show_bug.cgi?id=158751
679
680         Reviewed by Alexey Proskuryakov.
681
682         * Scripts/webkitpy/port/ios.py:
683         (IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
684         (IOSSimulatorPort.clean_up_test_run): Ditto.
685         (IOSSimulatorPort._createSimulatorApp): Ditto.
686
687 2016-06-14  David Kilzer  <ddkilzer@apple.com>
688
689         Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken
690         <https://webkit.org/b/158743>
691
692         Unreviewed build fix.
693
694         The fix in r202056 clobbered DumpRenderTree_SOURCES and
695         TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt,
696         so the build failure is now that we're not building the common
697         sources.
698
699         Fix that by saving the common sources (which are all C++ source
700         files) into *_Cpp_SOURCES lists first, then setting the compiler
701         flags, then creating the final *_SOURCES lists.
702
703         * DumpRenderTree/PlatformMac.cmake: Add
704         ${TestNetscapePlugin_Cpp_SOURCES} to list that needs
705         "-std=c++14" compiler switch.
706         (TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source
707         files for TestNetscapePlugin.  Seeded with
708         ${TestNetscapePlugin_SOURCES} from CMakeLists.txt.
709         (TestNetscapePlugin_SOURCES): Add
710         ${TestNetscapePlugin_Cpp_SOURCES} to the list of files.
711         (DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files
712         with ${DumpRenderTree_SOURCES} from CMakeLists.txt.
713         (DumpRenderTree_SOURCES): Reformat and sort source lists.
714
715 2016-06-14  David Kilzer  <ddkilzer@apple.com>
716
717         REGRESSION (r202020): El Capitan CMake Debug build broken
718         <https://webkit.org/b/158743>
719
720         Reviewed by Alex Christensen.
721
722         The bug was that pure C++ source files (and Objective-C source
723         files) were being compiled as Objective-C++ source files.  This
724         is obviously incorrect, so the fix was to split out the list of
725         source files by language, then define compiler switches based on
726         each file type.
727
728         * DumpRenderTree/PlatformMac.cmake: Replace add_definitions()
729         with separate foreach loops that set compiler flags based on
730         each source file's type.
731         (TestNetscapePlugin_ObjCpp_SOURCES): Rename from
732         TestNetscapePlugin_SOURCES.
733         (TestNetscapePlugin_SOURCES): Create based on
734         ${TestNetscapePlugin_ObjCpp_SOURCES}.
735         (DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES.
736         (DumpRenderTree_Cpp_SOURCES): Ditto.
737         (DumpRenderTree_ObjCpp_SOURCES): Ditto.
738         (DumpRenderTree_SOURCES): Create from above three lists.
739
740 2016-06-14  Lucas Forschler  <lforschler@apple.com>
741
742         <rdar://problem/26685782>
743         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
744
745         Rubber-stamped by Jessie Berlin.
746
747         * Scripts/copy-webkitlibraries-to-product-directory:
748
749 2016-06-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
750
751         Activate CMake export compile commands option
752         https://bugs.webkit.org/show_bug.cgi?id=158734
753
754         Reviewed by Alex Christensen.
755
756         * Scripts/webkitdirs.pm:
757         (generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
758         This allows using ymcd for WebKit hacking.
759
760 2016-06-14  David Kilzer  <ddkilzer@apple.com>
761
762         Modernize DumpRenderTreeMac.h
763         <https://webkit.org/b/158721>
764
765         Reviewed by Andy Estes.
766
767         * DumpRenderTree/mac/DumpRenderTreeMac.h:
768         - Update copyright.
769         - Update license.
770         - Use #pragma once.
771         - Use OBJC_CLASS macro.
772
773 2016-06-13  David Kilzer  <ddkilzer@apple.com>
774
775         False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
776         <https://webkit.org/b/158716>
777
778         Reviewed by Andy Estes.
779
780         * DumpRenderTree/mac/DumpRenderTree.mm:
781         (destroyWebViewAndOffscreenWindow): Change this function to take
782         a WebView, and assert that it's the same as [mainFrame webView].
783         (dumpRenderTree): Pass 'webView' into
784         destroyWebViewAndOffscreenWindow().
785         * DumpRenderTree/mac/DumpRenderTreeMac.h:
786         (createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
787         this function returns a +1 WebView.  Declare this method only for
788         Objective-C[++] source.
789
790 2016-06-13  Sam Weinig  <sam@webkit.org>
791
792         Make HashMap and HashSet work with Refs
793         https://bugs.webkit.org/show_bug.cgi?id=158638
794
795         Reviewed by Darin Adler.
796
797         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
798         (TestWebKitAPI::TEST):
799         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
800         (TestWebKitAPI::TEST):
801         Add tests for using Refs in HashMaps (both as key and value) and HashSets.
802
803 2016-06-13  Mark Lam  <mark.lam@apple.com>
804
805         Add a mechanism for collecting LLINT stats.
806         https://bugs.webkit.org/show_bug.cgi?id=158668
807
808         Reviewed by Filip Pizlo.
809
810         * DumpRenderTree/mac/DumpRenderTree.mm:
811         (DumpRenderTreeMain):
812
813 2016-06-13  Romain Bellessort  <romain.bellessort@crf.canon.fr>
814
815         [GTK] Enabling Shadow DOM by default
816         https://bugs.webkit.org/show_bug.cgi?id=158686
817
818         Reviewed by Carlos Garcia Campos.
819
820         Added support for enabling Shadow DOM by default for GTK.
821         Changed GTK test expectations for fast/shadow-dom tests (most tests
822         pass).
823
824         * Scripts/webkitperl/FeatureList.pm:
825
826 2016-06-12  Aakash Jain  <aakash_jain@apple.com>
827
828         run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
829         https://bugs.webkit.org/show_bug.cgi?id=158651
830         rdar://problem/26499824
831
832         Reviewed by Daniel Bates.
833
834         This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails 
835         to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
836         and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
837         for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
838         still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened, 
839         so that Simulator is implicitly registered with LaunchServices while opening it.
840
841         * Scripts/webkitdirs.pm:
842         (relaunchIOSSimulator):
843         Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
844         (quitIOSSimulator):
845         Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still 
846         attempt to launch the simulator.
847         (waitUntilIOSSimulatorDeviceIsInState):
848         Added a FIXME.
849
850 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
851
852         Addressing post-review comments after r201978.
853         https://bugs.webkit.org/show_bug.cgi?id=158649
854         <rdar://problem/13258122>
855
856         Unreviewed.
857
858         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
859         (TestWebKitAPI::TEST):
860
861 2016-06-11  Alexey Proskuryakov  <ap@apple.com>
862
863         Unreviewed leak fix after r201863.
864
865         * DumpRenderTree/mac/DumpRenderTree.mm:
866         (dumpFramesAsText):
867
868 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
869
870         [Cocoa] Map commonly used Chinese Windows font names to names present on Cocoa operating systems
871         https://bugs.webkit.org/show_bug.cgi?id=158649
872         <rdar://problem/13258122>
873
874         Reviewed by Darin Adler.
875
876         * TestWebKitAPI/Tests/WTF/WTFString.h:
877         (TestWebKitAPI::TEST):
878
879 2016-06-10  Alex Christensen  <achristensen@webkit.org>
880
881         Fix CMake build.
882
883         * TestWebKitAPI/PlatformMac.cmake:
884
885 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
886
887         Rename JSAir to Air.js
888
889         Rubber stamped by Mark Lam.
890
891         * Scripts/run-javascriptcore-tests:
892
893 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
894
895         JSC Stress Test failing: jsair-tests.yaml/test.js.ftl-eager-no-cjit
896         https://bugs.webkit.org/show_bug.cgi?id=158571
897
898         Reviewed by Keith Miller.
899         
900         Unskip the JSAir test.
901
902         * Scripts/run-javascriptcore-tests:
903         (runJSCStressTests):
904
905 2016-06-10  Sam Weinig  <sam@webkit.org>
906
907         Re-disable the UserMedia tests which are timing out.
908
909         They used to be accidentally disabled, due to not including
910         the FeatureDefines correctly, but not we explicitly disable it.
911
912         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
913         (TestWebKitAPI::TEST):
914
915 2016-06-10  Alex Christensen  <achristensen@webkit.org>
916
917         Introduce WTF::UniqueRef
918         https://bugs.webkit.org/show_bug.cgi?id=158596
919
920         Reviewed by Brady Eidson.
921
922         * TestWebKitAPI/CMakeLists.txt:
923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
924         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added.
925         (TestWebKitAPI::B::B):
926         (TestWebKitAPI::C::C):
927         (TestWebKitAPI::function):
928         (TestWebKitAPI::TEST):
929
930 2016-06-10  Sam Weinig  <sam@webkit.org>
931
932         Refactor TestWebKitAPI to allow just testing WTF
933         https://bugs.webkit.org/show_bug.cgi?id=158625
934
935         Reviewed by Tim Horton.
936
937         Extract all the WTF tests into a new target to allow a faster build / test / fix
938         cycle when working on WTF bugs and features.
939         
940         By calling `run-api-tests --wtf-only`, you don't need to have a build of JavaScriptCore/WebCore/etc
941         to test WTF only changes.
942
943         * Scripts/build-api-tests:
944         * Scripts/run-api-tests:
945         (buildTestTool):
946         (testToolPaths):
947         Add new options to build-api-tests and run-api-tests to only build/run the WTF test runner.
948
949         * TestWebKitAPI/CMakeLists.txt:
950         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Added.
951         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Added.
952         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
953         Add two new targets, TestWTFLibrary which contains all the WTF tests, and TestWTF,
954         the test runner that runs the WTF tests.
955     
956         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
957         Use Utilities.h rather than PlatformUtilities.h.
958
959         * TestWebKitAPI/Utilities.h: Added.
960         * TestWebKitAPI/PlatformUtilities.h:
961         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
962         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm: Added.
963         Move the sleep and run functions into a new Utilities.h/cpp file. This file contains utilities
964         that don't depend on anything in the WebKit project. 
965
966 2016-06-10  Brady Eidson  <beidson@apple.com>
967
968         REGRESSION(r201928?) API test WTF.StringOperators failing
969         https://bugs.webkit.org/show_bug.cgi?id=158623
970
971         Unreviewed, but buddy coded with Alex Christensen.
972
973         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
974         (TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed
975           to use string concatenation, otherwise the linker will mess up on the symbol related to
976           this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.
977
978 2016-06-10  Brady Eidson  <beidson@apple.com>
979
980         WTF_CrossThreadTask.Basic fails in all non mac ports.
981         https://bugs.webkit.org/show_bug.cgi?id=158612
982
983         Reviewed by Alex Christensen.
984
985         The test is very sensitive to argument evaluation order which is explicitly undefined in C++.
986         
987         Instead, we should just count the appropriate events to forget their order.
988         
989         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
990         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
991         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
992         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
993         (TestWebKitAPI::LifetimeLogger::fullName):
994         (TestWebKitAPI::testFunction):
995         (TestWebKitAPI::TEST):
996         (TestWebKitAPI::LifetimeLogger::log): Deleted.
997         (TestWebKitAPI::LifetimeLogger::takeLogStr): Deleted.
998
999 2016-06-09  Alex Christensen  <achristensen@webkit.org>
1000
1001         Clean up Tools *.vcxproj after switching to CMake.
1002
1003         * DumpRenderTree/DumpRenderTree.sln: Removed.
1004         * DumpRenderTree/DumpRenderTree.vcxproj: Removed.
1005         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Removed.
1006         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
1007         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
1008         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Removed.
1009         * DumpRenderTree/PlatformWin.cmake:
1010         * DumpRenderTree/win/TestNetscapePlugin.def: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def.
1011         * DumpRenderTree/win/TestNetscapePlugin.rc: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc.
1012         * DumpRenderTree/win/resource.h: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h.
1013         * MiniBrowser/MiniBrowser.vcxproj: Removed.
1014         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Removed.
1015         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Removed.
1016         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Removed.
1017         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Removed.
1018         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Removed.
1019         * MiniBrowser/MiniBrowser.vcxproj/small.ico: Removed.
1020         * MiniBrowser/win/CMakeLists.txt:
1021         * MiniBrowser/win/MiniBrowser.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico.
1022         * MiniBrowser/win/MiniBrowser.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc.
1023         * MiniBrowser/win/MiniBrowserLib.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc.
1024         * MiniBrowser/win/MiniBrowserLibResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h.
1025         * MiniBrowser/win/MiniBrowserResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h.
1026         * MiniBrowser/win/small.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/small.ico.
1027         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
1028         * win/DLLLauncher/DLLLauncherWinCairo.props: Removed.
1029
1030 2016-06-09  Zalan Bujtas  <zalan@apple.com>
1031
1032         Add testing support for 3x device scale factor.
1033         https://bugs.webkit.org/show_bug.cgi?id=158597
1034
1035         Reviewed by Simon Fraser.
1036
1037         Set 3x device scale factor on the test canvas when the test url is prefixed with hidpi-3x-. 
1038
1039         * DumpRenderTree/mac/DumpRenderTree.mm:
1040         (changeWindowScaleIfNeeded):
1041         * WebKitTestRunner/TestController.cpp:
1042         (WTR::TestController::updateWindowScaleForTest):
1043         * WebKitTestRunner/TestOptions.cpp:
1044         (WTR::deviceScaleFactorForTest):
1045         (WTR::TestOptions::TestOptions):
1046         (WTR::isHiDPITestPath): Deleted.
1047         * WebKitTestRunner/TestOptions.h:
1048
1049 2016-06-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1050
1051         Add comments to clarify feature enablement
1052         https://bugs.webkit.org/show_bug.cgi?id=158567
1053
1054         Reviewed by Alex Christensen.
1055
1056         * Scripts/webkitperl/FeatureList.pm:
1057
1058 2016-06-09  Filip Pizlo  <fpizlo@apple.com>
1059
1060         Unreviewed, skip jsair tests while we figure out the debug timeouts.
1061
1062         * Scripts/run-javascriptcore-tests:
1063         (runJSCStressTests):
1064
1065 2016-06-09  Commit Queue  <commit-queue@webkit.org>
1066
1067         Unreviewed, rolling out r201815.
1068         https://bugs.webkit.org/show_bug.cgi?id=158570
1069
1070         This broke the cmake build. (Requested by lforschler on
1071         #webkit).
1072
1073         Reverted changeset:
1074
1075         "Teach cmake about libWebKitSystemInterfaceOSX10.12"
1076         http://trac.webkit.org/changeset/201815
1077
1078 2016-06-09  Brady Eidson  <beidson@apple.com>
1079
1080         Greatly simplify CrossThreadTask.h.
1081         https://bugs.webkit.org/show_bug.cgi?id=158542
1082
1083         Reviewed by Darin Adler.
1084
1085         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1086         (TestWebKitAPI::TEST):
1087
1088 2016-06-09  Chris Dumez  <cdumez@apple.com>
1089
1090         Unreviewed, rolling out r201836, r201845, and r201848.
1091
1092         Looks like a 1-2% PLT regression on iOS
1093
1094         Reverted changesets:
1095
1096         "[JSC] Change some parameters based on a random search"
1097         https://bugs.webkit.org/show_bug.cgi?id=158514
1098         http://trac.webkit.org/changeset/201836
1099
1100         "Tempory fix for the debug bots"
1101         http://trac.webkit.org/changeset/201845
1102
1103         "Change thresholdForOptimizeSoon to match
1104         thresholdForOptimizeAfterWarmUp"
1105         http://trac.webkit.org/changeset/201848
1106
1107 2016-06-09  Michael Saboff  <msaboff@apple.com>
1108
1109         WebKitTestRunner and DumpRenderTree do not handle dangling surrogate characters
1110         https://bugs.webkit.org/show_bug.cgi?id=154863
1111
1112         Reviewed by Alexey Proskuryakov.
1113
1114         Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling
1115         surrogates.  Changed the extraction of inner text from frames in DumpRenderTree
1116         to use the new WKStringGetUTF8CStringNonStrict() function instead of NSString
1117         conversion since NSString doesn't have a way to handle dangling surrogates.
1118         The code added in DumpRenderTree matches what was changed in WebKitTestRunner.
1119
1120         * DumpRenderTree/mac/DumpRenderTree.mm:
1121         (dumpFramesAsText):
1122         * WebKitTestRunner/StringFunctions.h:
1123         (WTR::toWTFString):
1124
1125 2016-06-08  Hunseop Jeong  <hs85.jeong@samsung.com>
1126
1127         Try to fix the EFL build. 
1128
1129         Unreviewed. 
1130
1131         * TestWebKitAPI/CMakeLists.txt:
1132
1133 2016-06-08  Alex Christensen  <achristensen@webkit.org>
1134
1135        Fix WinCairo build
1136
1137         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1138
1139 2016-06-08  Alex Christensen  <achristensen@webkit.org>
1140
1141         Fix WinCairo build
1142
1143         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1144         (BitmapContext::createByAdoptingBitmapAndContext):
1145         (BitmapContext::~BitmapContext):
1146
1147 2016-06-08  Benjamin Poulain  <benjamin@webkit.org>
1148
1149         [JSC] Change some parameters based on a random search
1150         https://bugs.webkit.org/show_bug.cgi?id=158514
1151
1152         Reviewed by Filip Pizlo.
1153
1154         * Scripts/run-jsc-stress-tests:
1155
1156 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
1157
1158         tests fail if display sleeps while run-webkit-tests is running
1159         https://bugs.webkit.org/show_bug.cgi?id=153919
1160
1161         Reviewed by Alexey Proskuryakov.
1162
1163         * DumpRenderTree/mac/LayoutTestHelper.m:
1164         (releaseSleepAssertions): Release both Display sleep and System sleep assertions.
1165         (addSleepAssertions): Add sleep assertion for both Display sleep and System sleep.
1166
1167 2016-06-08  Lucas Forschler  <lforschler@apple.com>
1168
1169         Reverted changeset 201814.
1170
1171         * Scripts/copy-webkitlibraries-to-product-directory:
1172
1173 2016-06-08  Per Arne Vollan  <pvollan@apple.com>
1174
1175         [Win] Shadow DOM tests are failing.
1176         https://bugs.webkit.org/show_bug.cgi?id=158524
1177
1178         Reviewed by Brent Fulgham.
1179
1180         Enable Shadow DOM when running tests.
1181
1182         * DumpRenderTree/win/DumpRenderTree.cpp:
1183         (resetWebPreferencesToConsistentValues):
1184
1185 2016-06-08  Lucas Forschler  <lforschler@apple.com>
1186
1187         Teach cmake about libWebKitSystemInterfaceOSX10.12
1188         This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake
1189
1190         Rubber-stamped by Alex Christensen.
1191  
1192         * DumpRenderTree/PlatformMac.cmake:
1193         * WebKitTestRunner/PlatformMac.cmake:
1194
1195 2016-06-07  Lucas Forschler  <lforschler@apple.com>
1196
1197         <rdar://problem/26685782>
1198         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
1199
1200         Rubber-stamped by Jessie Berlin.
1201
1202         * Scripts/copy-webkitlibraries-to-product-directory:
1203
1204 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
1205
1206         Don't try to cleanup non-existing ios Simulators
1207         https://bugs.webkit.org/show_bug.cgi?id=158510
1208
1209         Reviewed by Alexey Proskuryakov.
1210
1211         * Scripts/webkitpy/port/ios.py:
1212         (IOSSimulatorPort.clean_up_test_run): 
1213         Check if simulator exists before trying to clean it up.
1214
1215 2016-06-08  Brady Eidson  <beidson@apple.com>
1216
1217         Try to fix the Windows build.
1218
1219         Unreviewed.
1220
1221         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1222         (TestWebKitAPI::LifetimeLogger::log):
1223         (TestWebKitAPI::LifetimeLogger::takeLogStr):
1224         (TestWebKitAPI::testFunction):
1225         (TestWebKitAPI::TEST):
1226         (TestWebKitAPI::log): Deleted. (VS was seeing it as a dupe symbol)
1227         (TestWebKitAPI::takeLogStr): Deleted. (VS was seeing it as a dupe symbol)
1228
1229 2016-06-08  Brady Eidson  <beidson@apple.com>
1230
1231         Make CrossThreadCopier more efficient (fewer copies!).
1232         https://bugs.webkit.org/show_bug.cgi?id=158456
1233
1234         Reviewed by Alex Christensen.
1235
1236         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1237         (TestWebKitAPI::TEST):
1238
1239 2016-06-07  Filip Pizlo  <fpizlo@apple.com>
1240
1241         Add result validation to JSAir
1242         https://bugs.webkit.org/show_bug.cgi?id=158493
1243
1244         Reviewed by Saam Barati.
1245         
1246         Run JSAir.
1247
1248         * Scripts/run-javascriptcore-tests:
1249         (runJSCStressTests):
1250
1251 2016-06-08  Brady Eidson  <beidson@apple.com>
1252
1253         Add an API test that confirms object constructor/destructor calls during creation of a CrossThreadTask.
1254         https://bugs.webkit.org/show_bug.cgi?id=158528
1255
1256         Reviewed by Alex Christensen.
1257
1258         * TestWebKitAPI/CMakeLists.txt:
1259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1260         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: Added.
1261         (TestWebKitAPI::log):
1262         (TestWebKitAPI::takeLogStr):
1263         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
1264         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
1265         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
1266         (TestWebKitAPI::testFunction):
1267         (TestWebKitAPI::TEST):
1268
1269 2016-06-08  Konstantin Tokarev  <annulen@yandex.ru>
1270
1271         TestWebKitAPI: Removed redunandant check PLATFORM(GTK) && !defined(BUILDING_WEBKIT2__)
1272         https://bugs.webkit.org/show_bug.cgi?id=158521
1273
1274         Reviewed by Carlos Garcia Campos.
1275
1276         * TestWebKitAPI/config.h:
1277
1278 2016-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1279
1280         [GTK] Use a longer timeout for glib unit tests
1281         https://bugs.webkit.org/show_bug.cgi?id=158476
1282
1283         Reviewed by Darin Adler.
1284
1285         The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the
1286         same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in
1287         the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for
1288         GLib tests.
1289
1290         * Scripts/run-gtk-tests:
1291         (TestRunner._run_test_glib):
1292
1293 2016-06-07  Keith Rollin  <krollin@apple.com>
1294
1295         Remove all uses of PassRefPtr in WTF
1296         https://bugs.webkit.org/show_bug.cgi?id=157596
1297         <rdar://problem/26234391>
1298
1299         Reviewed by Chris Dumez.
1300
1301         Update calls to interfaces that no longer take or return PassRefPtrs.
1302
1303         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1304         (TestWebKitAPI::stringFromUTF8):
1305         (TestWebKitAPI::TEST):
1306
1307 2016-06-07  Per Arne Vollan  <pvollan@apple.com>
1308
1309         [Win] Imported markup insertion test is failing.
1310         https://bugs.webkit.org/show_bug.cgi?id=158477
1311
1312         Reviewed by Darin Adler.
1313
1314         Make sure the empty synchronous request is loaded after each test.
1315
1316         * DumpRenderTree/win/DumpRenderTree.cpp:
1317         (runTest):
1318
1319 2016-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1320
1321         REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
1322         https://bugs.webkit.org/show_bug.cgi?id=158417
1323
1324         Reviewed by Michael Catanzaro.
1325
1326         The toolchain on armhf (ARMv7) seems unable to properly handle
1327         a shared library that doesn't link with anything.
1328
1329         And libicudata is built by default in this way because it only
1330         contains static data.
1331
1332         That makes icu unusable on armhf because the linker will be
1333         unable to resolve the libicudata dependencies.
1334
1335         Most (if not all) distributions workaround this by linking
1336         libicudata with libc6, which is already a needed dependency for
1337         any of the other icu shared libraries.
1338
1339         So import here the Debian patch fixing this issue. For further
1340         details check https://bugs.debian.org/653457
1341
1342         * gtk/jhbuild.modules:
1343         * gtk/patches/icudata-stdlibs.patch: Added.
1344
1345 2016-06-06  Per Arne Vollan  <pvollan@apple.com>
1346
1347         REGRESSION (r104174): 500+ tests failing on Windows
1348         https://bugs.webkit.org/show_bug.cgi?id=75965
1349
1350         Reviewed by Michael Catanzaro.
1351
1352         Reset WebView scale factors before running next test.
1353
1354         * DumpRenderTree/win/DumpRenderTree.cpp:
1355         (resetWebViewToConsistentStateBeforeTesting):
1356
1357 2016-06-04  Alexey Proskuryakov  <ap@apple.com>
1358
1359         REGRESSION (r201263): Some tests have become flaky timeouts.
1360         https://bugs.webkit.org/show_bug.cgi?id=157990
1361
1362         Reviewed by Darin Adler.
1363
1364         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
1365         It is somewhat legitimate for WebContent to not respond to messages after the test
1366         is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently,
1367         without making the current test fail.
1368
1369 2016-06-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1370
1371         [GTK] Update YouCompleteMe script to make all include paths absolute
1372         https://bugs.webkit.org/show_bug.cgi?id=158301
1373
1374         Reviewed by Michael Catanzaro.
1375
1376         Before this patch, some include paths were not made absolute.
1377         This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
1378
1379         * gtk/ycm_extra_conf.py:
1380
1381 2016-06-03  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1382
1383         Unreviewed: add myself to the committers list.
1384
1385         * Scripts/webkitpy/common/config/contributors.json:
1386
1387 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
1388
1389         [Win] Fetch API tests are failing.
1390         https://bugs.webkit.org/show_bug.cgi?id=158296
1391
1392         Reviewed by Alex Christensen.
1393
1394         Enable Fetch API when running tests.
1395
1396         * DumpRenderTree/win/DumpRenderTree.cpp:
1397         (resetWebPreferencesToConsistentValues):
1398
1399 2016-06-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1400
1401         Really display failing JSC stress tests in buildbot dashboard
1402         https://bugs.webkit.org/show_bug.cgi?id=158324
1403
1404         Reviewed by Alexey Proskuryakov.
1405
1406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1407         (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1409         (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
1410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1411         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
1412         membership in array.
1413         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
1414         generated after the first time.
1415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1416         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
1417
1418 2016-06-02  Michael Saboff  <msaboff@apple.com>
1419
1420         [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
1421         https://bugs.webkit.org/show_bug.cgi?id=158317
1422
1423         Reviewed by Saam Barati.
1424
1425         Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
1426         variant.
1427
1428         * Scripts/run-jsc-stress-tests:
1429
1430 2016-06-02  Aakash Jain  <aakash_jain@apple.com>
1431
1432         LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
1433         https://bugs.webkit.org/show_bug.cgi?id=158305
1434
1435         Reviewed by Alexey Proskuryakov.
1436
1437         * Scripts/webkitpy/port/ios.py:
1438         (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
1439
1440 2016-06-01  Brian Burg  <bburg@apple.com>
1441
1442         REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
1443         https://bugs.webkit.org/show_bug.cgi?id=158227
1444         <rdar://problem/26232464>
1445
1446         Reviewed by Alexey Proskuryakov.
1447
1448         Add a regression test that runs on Mac only.
1449
1450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1451         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
1452         (-[DummyNavigationDelegate webView:didFinishNavigation:]):
1453         (TEST):
1454         * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
1455
1456 2016-06-01  Chris Fleizach  <cfleizach@apple.com>
1457
1458         AX: iOS: VoiceOver can't access attachments in mail messages
1459         https://bugs.webkit.org/show_bug.cgi?id=158198
1460
1461         Reviewed by Joanmarie Diggs.
1462
1463         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1464         (AccessibilityUIElement::stringForRange):
1465         (AccessibilityUIElement::attributedStringForRange):
1466         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1467         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1468         (WTR::AccessibilityUIElement::attributedStringForRange):
1469         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1470
1471 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1472
1473         Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
1474
1475         It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
1476         timeout is applied per tester program not per test case, so we need to mark the whole test
1477         WebKit2Gtk/TestInspectorServer as slow.
1478
1479         * Scripts/run-gtk-tests:
1480         (TestRunner):
1481         (TestRunner._run_test_glib):
1482
1483 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1484
1485         Unreviewed. Skip media permission request GTK+ unit tests.
1486
1487         They are timing out in the bots.
1488
1489         * Scripts/run-gtk-tests:
1490         (TestRunner):
1491
1492 2016-05-31  Jer Noble  <jer.noble@apple.com>
1493
1494         Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
1495         the #if check.
1496
1497         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1498
1499 2016-05-31  Jer Noble  <jer.noble@apple.com>
1500
1501         Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
1502
1503         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1504
1505 2016-05-31  Jer Noble  <jer.noble@apple.com>
1506
1507         Unreviewed build fix; only run FullscreetTopContentInset test on platforms
1508         where WK_API_ENABLED is set.
1509
1510         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1511
1512 2016-05-31  Jer Noble  <jer.noble@apple.com>
1513
1514         REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
1515         https://bugs.webkit.org/show_bug.cgi?id=158156
1516         <rdar://problem/26519589>
1517
1518         Reviewed by Darin Adler.
1519
1520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1521         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
1522         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
1523         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1524         (TestWebKitAPI::TEST):
1525
1526 2016-05-31  Jon Lee  <jonlee@apple.com>
1527
1528         Unreviewed: add myself to the reviewers list.
1529
1530         * Scripts/webkitpy/common/config/contributors.json:
1531
1532 2016-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1533
1534         [GTK] Provide alternative mirror for the ICU tarball.
1535         https://bugs.webkit.org/show_bug.cgi?id=154530
1536
1537         Unreviewed.
1538
1539         * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
1540         a hard time trying to download the ICU tarball from download.icu-project.org
1541         (which redirects to sourceforge and gives problems with something related to
1542         SSL). Provide this alternative mirror to make things working back.
1543
1544 2016-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1545
1546         [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
1547         https://bugs.webkit.org/show_bug.cgi?id=158200
1548
1549         Reviewed by Philippe Normand.
1550
1551         This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
1552         POSITION_UNAVAILABLE is returned without asking the API layer.
1553
1554         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1555         (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
1556         POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
1557         document title, and use user script messages that are more reliable instead.
1558
1559 2016-05-28  Aakash Jain  <aakash_jain@apple.com>
1560
1561         tests fail if display sleeps while run-webkit-tests is running
1562         https://bugs.webkit.org/show_bug.cgi?id=153919
1563
1564         Reviewed by Darin Adler.
1565
1566         * DumpRenderTree/mac/LayoutTestHelper.m:
1567         (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
1568
1569 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1570
1571         Display failing JSC stress tests in buildbot dashboard
1572         https://bugs.webkit.org/show_bug.cgi?id=156595
1573
1574         Reviewed by Alexey Proskuryakov.
1575
1576         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1577         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
1578         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1580         (BuildbotCombinedQueueView.prototype.update):
1581         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1582         (BuildbotIteration):
1583         (BuildbotIteration.prototype._parseData):
1584         (BuildbotIteration.prototype.loadLayoutTestResults):
1585         (BuildbotIteration.prototype.):
1586         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
1587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1588         (BuildbotQueueView.prototype._createLoadingIndicator):
1589         (BuildbotQueueView.prototype.):
1590         (BuildbotQueueView.prototype._onPopoverCopy):
1591         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
1592         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
1593         (BuildbotQueueView.prototype._addIterationHeadingToPopover):
1594         (BuildbotQueueView.prototype._testStepFailureDescription):
1595         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1597         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
1598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1599         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
1600         (BuildbotTesterQueueView.prototype.update):
1601         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1602         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
1603         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
1604         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
1605         (BuildbotTesterQueueView.prototype.): Deleted.
1606         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
1609         (MockBuildbot):
1610         (MockBuildbot.prototype.buildPageURLForIteration):
1611         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
1612         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
1613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
1614         (MockBuildbotQueue):
1615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
1616         (MockBuildbotTestResults):
1617         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
1618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
1619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1620
1621 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1622
1623         Display failing JSC stress tests in buildbot dashboard
1624         https://bugs.webkit.org/show_bug.cgi?id=156595
1625
1626         Reviewed by Alexey Proskuryakov.
1627
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1629         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of
1630         JSC tests.
1631         (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output
1632         of JSC tests.
1633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1634         (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover.
1635         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1636         (BuildbotIteration): Add javaScriptCoreTestResults variable.
1637         (BuildbotIteration.prototype.): Check for javascriptcore tests step.
1638         (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace.
1639         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server.
1640         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1641         (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function.
1642         (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text
1643         from popovers.
1644         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's
1645         inner HTML from the JSC failure data.
1646         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble
1647         for JSC results and handle request failures.
1648         (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass.
1649         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass.
1650         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1651         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests.
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1653         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose 
1654         only failures are JSC tests.
1655         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy.
1656         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator.
1657         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass.
1658         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass.
1659         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead.
1660         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files.
1661         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added.
1662         (MockBuildbot): Mocked version of Buildbot, only containing URL methods.
1663         (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js
1664         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test.
1665         (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js
1666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
1667         (MockBuildbotQueue): Use a MockBuildbot() instead of a string.
1668         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added.
1669         (MockBuildbotTestResults): Mocked version of BuildbotTestResults.
1670         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable.
1671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
1672         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests.
1673
1674 2016-05-27  Chris Dumez  <cdumez@apple.com>
1675
1676         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
1677         https://bugs.webkit.org/show_bug.cgi?id=158111
1678
1679         Reviewed by Darin Adler.
1680
1681         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
1682         These are often used cross-thread and copying the captured lambda variables can be
1683         dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
1684         capture).
1685
1686         * WebKitTestRunner/TestController.cpp:
1687         (WTR::TestController::decidePolicyForNavigationAction):
1688
1689 2016-05-27  Brady Eidson  <beidson@apple.com>
1690
1691         Modern IDB: After closing a Netflix video, trying to watch it again fails.
1692         <rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
1693
1694         Reviewed by Alex Christensen.
1695
1696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1697         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
1698         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
1699         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
1700
1701 2016-05-27  Joanmarie Diggs  <jdiggs@igalia.com>
1702
1703         AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
1704         https://bugs.webkit.org/show_bug.cgi?id=158152
1705
1706         Reviewed by Chris Fleizach.
1707
1708         The failure is actually a bug fix because only one child is being added, but two
1709         notifications were being emitted. Now there is only one notification. To verify
1710         this was the case, we really should examine the child reportedly being added. That
1711         child is the ATK event's any_data, so pass along that child to the listener.
1712
1713         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1714
1715 2016-05-26  Alex Christensen  <achristensen@webkit.org>
1716
1717         Expose content extension failure error codes in SPI
1718         https://bugs.webkit.org/show_bug.cgi?id=158095
1719         rdar://problem/26475651
1720
1721         Reviewed by Anders Carlsson.
1722
1723         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1724         (checkDomain):
1725         (TEST_F):
1726         Add tests that use the new enum.
1727
1728 2016-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1729
1730         New intl-numberformat.js test fails on many Linux platforms
1731         https://bugs.webkit.org/show_bug.cgi?id=154530
1732
1733         Reviewed by Darin Adler.
1734
1735         The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
1736         icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
1737         jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
1738
1739         * gtk/jhbuild.modules:
1740
1741 2016-05-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1742
1743         [JSC] Allow JSBench to use precise time
1744         https://bugs.webkit.org/show_bug.cgi?id=158050
1745
1746         Reviewed by Geoffrey Garen.
1747
1748         JSBench use `new Date().getTime()` without options and there is no way to use precise time.
1749         This patch modifies the JSBench code to inject the code taking the precise time.
1750         `currentTimeInMS` is given by the benchmerk harness and JSBench uses it.
1751         run-jsc-benchmark switches this function's implementation between `Date.now()` and
1752         testRunner's precise time one.
1753
1754         While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
1755         the contents are not changed for a long time. As described in the original paper[1], the
1756         tests can be generated by using JSBench's record & replay system, but in that case, we can
1757         adopt this modification by changing the tool side.
1758
1759         We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
1760         u?rem.js implementation is required when it is executed in u?rem.html without harness.
1761         And harness.js implementation is required when it is executed in the JSBench's harness.
1762         In these implementation, we follow the JetStream's time measuring function: performance.now(),
1763         preciseTime(), or Date.now().
1764
1765         [1]: http://dl.acm.org/citation.cfm?id=2048119
1766
1767         * Scripts/run-jsc-benchmarks:
1768
1769 2016-05-26  Brent Fulgham  <bfulgham@apple.com>
1770
1771         Unreviewed test fix after r201427.
1772         https://bugs.webkit.org/show_bug.cgi?id=157423
1773         <rdar://problem/23751632>
1774
1775         A debug assertion was firing during some test runs due to the Geolocation permission
1776         being turned off during the test. The timer logic was originally written to assert
1777         if the timer fired when permissions were disabled. But this is no longer valid,
1778         because we expect the Geolocation system to be active and become deactivated if the
1779         browsing context violates one of the security criteria.
1780
1781         * DumpRenderTree/mac/UIDelegate.mm:
1782         (-[UIDelegate timerFired]): Remove invalid assertion.
1783
1784 2016-05-26  Filip Pizlo  <fpizlo@apple.com>
1785
1786         ScopedLambda should have a lifetime story that makes sense to the compiler
1787         https://bugs.webkit.org/show_bug.cgi?id=158118
1788
1789         Reviewed by Mark Lam.
1790         
1791         Added a test case. This test crashes before the fix and now it passes.
1792
1793         * TestWebKitAPI/CMakeLists.txt:
1794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1795         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
1796         (TestWebKitAPI::TEST):
1797
1798 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
1799
1800         Build fix
1801
1802         Rubber stamped by Lucas Forschler.
1803
1804         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1805         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1806
1807 2016-05-25  Anders Carlsson  <andersca@apple.com>
1808
1809         Get rid of WTF/Functional.h
1810         https://bugs.webkit.org/show_bug.cgi?id=158081
1811
1812         Reviewed by Chris Dumez.
1813
1814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1815         * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
1816         (TestWebKitAPI::returnFortyTwo): Deleted.
1817         (TestWebKitAPI::TEST): Deleted.
1818         (TestWebKitAPI::multiplyByTwo): Deleted.
1819         (TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
1820         (TestWebKitAPI::multiply): Deleted.
1821         (TestWebKitAPI::subtract): Deleted.
1822         (TestWebKitAPI::A::A): Deleted.
1823         (TestWebKitAPI::A::f): Deleted.
1824         (TestWebKitAPI::A::addF): Deleted.
1825         (TestWebKitAPI::B::B): Deleted.
1826         (TestWebKitAPI::B::~B): Deleted.
1827         (TestWebKitAPI::B::ref): Deleted.
1828         (TestWebKitAPI::B::deref): Deleted.
1829         (TestWebKitAPI::B::f): Deleted.
1830         (TestWebKitAPI::B::g): Deleted.
1831         (TestWebKitAPI::Number::create): Deleted.
1832         (TestWebKitAPI::Number::~Number): Deleted.
1833         (TestWebKitAPI::Number::value): Deleted.
1834         (TestWebKitAPI::Number::Number): Deleted.
1835         (TestWebKitAPI::multiplyNumberByTwo): Deleted.
1836
1837 2016-05-25  Daniel Bates  <dabates@apple.com> and Brent Fulgham  <bfulgham@apple.com>
1838
1839         [WebSockets] No infrastructure for testing secure web sockets (wss)
1840         https://bugs.webkit.org/show_bug.cgi?id=157884
1841         <rdar://problem/26477197>
1842
1843         Reviewed by Andy Estes.
1844
1845         Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
1846         using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also
1847         teaches run-webkit-httpd to start and stop the Web Socket servers.
1848
1849         Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method,
1850         'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate
1851         we do for our HTTPS tests.
1852         
1853         * DumpRenderTree/TestRunner.cpp:
1854         (setAllowsAnySSLCertificateCallback):
1855         (TestRunner::setAllowsAnySSLCertificate):
1856         * DumpRenderTree/TestRunner.h:
1857         * DumpRenderTree/mac/DumpRenderTree.mm:
1858         (resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests.
1859         * Scripts/run-webkit-httpd:
1860         (main): Start the websocket server at launch.
1861         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1862         (Manager.__init__): Remove dead code.
1863         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1864         (PyWebSocket.__init__): Cleanup code.
1865         (PyWebSocket): Pass '--tls-client-ca' to start command.
1866         (PyWebSocket._prepare_config): Cleanups.
1867         * Scripts/webkitpy/port/base.py:
1868         (Port.to.start_http_server):
1869         (Port.to):
1870         (Port.to._extract_certificate_from_pem): Added.
1871         (Port.to._extract_private_key_from_pem): Added.
1872         (Port.to.start_websocket_server): Start secure socket server.
1873         (Port.to.stop_websocket_server): Stop secure socket server.
1874         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API.
1875         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1876         (WTR::InjectedBundle::setAllowsAnySSLCertificate): Added.
1877         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1878         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1879         (WTR::TestRunner::setAllowsAnySSLCertificate): Added.
1880         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1881
1882 2016-05-25  Keith Miller  <keith_miller@apple.com>
1883
1884         run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
1885         https://bugs.webkit.org/show_bug.cgi?id=158077
1886
1887         Reviewed by Mark Lam.
1888
1889         Since we didn't have JSBench in the tree before we needed to lookup the path to it from
1890         benchmark config file. That's no longer the case so we should just fix it in the script.
1891
1892         * Scripts/run-jsc-benchmarks:
1893
1894 2016-05-24  Aakash Jain  <aakash_jain@apple.com>
1895
1896         Reorganize dashboard code: move code from _timeIntervalString to base class
1897         https://bugs.webkit.org/show_bug.cgi?id=158047
1898         rdar://problem/26457274
1899
1900         Reviewed by Alexey Proskuryakov and Dean Johnson.
1901
1902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1903         (BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
1904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1905         (QueueView.prototype._readableTimeString): Same.
1906
1907 2016-05-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1908
1909         [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports
1910         https://bugs.webkit.org/show_bug.cgi?id=158016
1911
1912         Reviewed by Darin Adler.
1913
1914         This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports.
1915         This change encourages us to run tests with the browser-heap in nix environments.
1916         Two things are modified.
1917
1918         1. Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment.
1919
1920             In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port.
1921             For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib"
1922             while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib".
1923             And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports.
1924
1925         2. Add --dependencies option to add dependent library paths.
1926
1927             While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path,
1928             typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH.
1929             Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths.
1930             The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies.
1931             Multiple additional dependent library paths can be added by using --dependencies multiple times.
1932
1933         By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.).
1934         Example:
1935             `Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench`
1936
1937         * Scripts/run-jsc-benchmarks:
1938
1939 2016-05-20  Keith Miller  <keith_miller@apple.com>
1940         We should have JSBench in PerformanceTests
1941         https://bugs.webkit.org/show_bug.cgi?id=157952
1942
1943         Rubber-stamped by Saam Barati.
1944
1945         This changes the runner to use the layout of the newest version of JSBench.
1946
1947         * Scripts/run-jsc-benchmarks:
1948
1949 2016-05-24  Chris Dumez  <cdumez@apple.com>
1950
1951         Use auto for some of our lambda function parameters
1952         https://bugs.webkit.org/show_bug.cgi?id=158001
1953
1954         Reviewed by Darin Adler.
1955
1956         Use auto for some of our lambda function parameters now that we build with c++14.
1957
1958         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1959         (WTR::InjectedBundle::willDestroyPage):
1960
1961 2016-05-23  Brady Eidson  <beidson@apple.com>
1962
1963         check-webkit-style gets flags std::literals::chrono_literals as bad naming.
1964         https://bugs.webkit.org/show_bug.cgi?id=157969
1965
1966         Reviewed by Alex Christensen.
1967
1968         * Scripts/webkitpy/style/checkers/cpp.py:
1969         (check_identifier_name_in_declaration):
1970         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1971         (WebKitStyleTest.test_names):
1972
1973 2016-05-22  Alexey Proskuryakov  <ap@apple.com>
1974
1975         RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
1976         https://bugs.webkit.org/show_bug.cgi?id=157977
1977         rdar://problem/20874156
1978
1979         Reviewed by David Kilzer.
1980
1981         * WebKitTestRunner/TestInvocation.cpp:
1982         (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
1983         a timeout detected. If we don't, there is a chance that the process is not quite frozen,
1984         and will still send a response that we no longer expect.
1985         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
1986         too, as stdout is not available, at least not in the case that I was observing.
1987
1988 2016-05-22  Brady Eidson  <beidson@apple.com>
1989
1990         Move to C++14.
1991         https://bugs.webkit.org/show_bug.cgi?id=157948
1992
1993         Reviewed by Michael Catanzaro.
1994
1995         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1996         * MiniBrowser/Configurations/Base.xcconfig:
1997         * TestWebKitAPI/Configurations/Base.xcconfig:
1998         * WebKitTestRunner/Configurations/Base.xcconfig:
1999
2000 2016-05-21  Aakash Jain  <aakash_jain@apple.com>
2001
2002         Simulator launch fails intermittently due to failure in checking simulator boot status
2003         https://bugs.webkit.org/show_bug.cgi?id=157965
2004         rdar://problem/26402404
2005
2006         Reviewed by Alexey Proskuryakov.
2007
2008         * Scripts/webkitpy/xcode/simulator.py:
2009         (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
2010         whether simulator has finished booting.
2011
2012 2016-05-21  Dan Bernstein  <mitz@apple.com>
2013
2014         Silence warnings from svn propget when using newer versions of Subversion.
2015         https://bugs.webkit.org/show_bug.cgi?id=157879
2016
2017         Reviewed by Daniel Bates.
2018
2019         * Scripts/prepare-ChangeLog:
2020         (attributeCommand): Redirect svn propget stderr to /dev/null.
2021         * Scripts/svn-create-patch:
2022         (findMimeType): Ditto.
2023
2024 2016-05-20  Ryosuke Niwa  <rniwa@webkit.org>
2025
2026         run-benchmark's results should contain Animometer's debug output
2027         https://bugs.webkit.org/show_bug.cgi?id=157941
2028
2029         Reviewed by Stephanie Lewis.
2030
2031         Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
2032         The result can be dragged and dropped into Animometer's developer.html page.
2033
2034         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2035         (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
2036         (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
2037         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
2038         Modified the patch to store the debug output.
2039         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2040         (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
2041         when the request body is larger than a certain size on twisted.
2042
2043 2016-05-20  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2044
2045         Use clearer names for JSON output of javascriptcore test results
2046         https://bugs.webkit.org/show_bug.cgi?id=157921
2047
2048         Reviewed by Alexey Proskuryakov.
2049
2050         "failures" and "apiTestResult" were somewhat ambiguous names. 
2051         
2052         * Scripts/run-javascriptcore-tests:
2053         (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
2054
2055 2016-05-20  Chris Dumez  <cdumez@apple.com>
2056
2057         Unreviewed, fix API test introduced in r201213.
2058
2059         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2060         (TestWebKitAPI::TEST):
2061
2062 2016-05-20  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
2063
2064         Implement operator== for WeakPtr
2065         https://bugs.webkit.org/show_bug.cgi?id=157883
2066
2067         Reviewed by Chris Dumez.
2068
2069         Implement operator== and operator!= for WeakPtr and update code to use the operators.
2070
2071         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2072         (TestWebKitAPI::TEST):
2073
2074 2016-05-19  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2075
2076         Add JSON results to 32-bit and CLoop JSC tests
2077         https://bugs.webkit.org/show_bug.cgi?id=157929
2078
2079         Reviewed by Alexey Proskuryakov.
2080
2081         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2082         (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
2083         (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
2084
2085 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2086
2087         Typo fix in import-test262-tests
2088         https://bugs.webkit.org/show_bug.cgi?id=157902
2089
2090         Reviewed by Keith Miller.
2091
2092         * Scripts/import-test262-tests:
2093
2094 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2095
2096         [EFL] Fix the gst-libav build on ARM Thumb2 after r199649
2097         https://bugs.webkit.org/show_bug.cgi?id=157893
2098
2099         Reviewed by Antonio Gomes.
2100
2101         * efl/patches/gst-libav.patch:
2102
2103 2016-05-19  Jer Noble  <jer.noble@apple.com>
2104
2105         REGRESSION(r200951): VideoControlsManager API tests time out
2106         https://bugs.webkit.org/show_bug.cgi?id=157896
2107         <rdar://problem/26326293>
2108
2109         Reviewed by Eric Carlson.
2110
2111         Explicitly disable user gesture requirements for playback.
2112
2113         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2114         (TestWebKitAPI::TEST):
2115
2116 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2117
2118         Slow JSC stress tests times out in 32 bit debug mode
2119         https://bugs.webkit.org/show_bug.cgi?id=154964
2120
2121         Reviewed by Michael Catanzaro.
2122
2123         * Scripts/run-javascriptcore-tests:
2124         (runJSCStressTests): Pass through the --debug option.
2125         * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
2126
2127 2016-05-18  Aakash Jain  <aakash_jain@apple.com>
2128
2129         Remove underline from Status Bubbles on dashboard
2130         https://bugs.webkit.org/show_bug.cgi?id=157870
2131         rdar://problem/26332321
2132
2133         Reviewed by Alexey Proskuryakov.
2134
2135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style 
2136         change made in http://trac.webkit.org/r200880
2137
2138 2016-05-18  Michael Saboff  <msaboff@apple.com>
2139
2140         r199812 broke test262
2141         https://bugs.webkit.org/show_bug.cgi?id=157595
2142
2143         Reviewed by Filip Pizlo.
2144
2145         Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
2146         This run type will not run with the --memory-limited option.  Without that option,
2147         we'll only the default test variant.
2148
2149         * Scripts/run-jsc-stress-tests:
2150
2151 2016-05-18  Simon Fraser  <simon.fraser@apple.com>
2152
2153         REGRESSION (r200534) Command-+ no longer zooms pages 
2154         https://bugs.webkit.org/show_bug.cgi?id=157826
2155         rdar://problem/26334636
2156
2157         Reviewed by Dean Jackson.
2158
2159         * DumpRenderTree/mac/DumpRenderTree.mm:
2160         (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
2161
2162 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
2163
2164         [GTK] accessibility/meter-element.html is failing
2165         https://bugs.webkit.org/show_bug.cgi?id=115633
2166
2167         Reviewed by Chris Fleizach.
2168
2169         Implement AccessibilityUIElement::valueDescription() and add mapping
2170         from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
2171
2172         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2173         (WTR::AccessibilityUIElement::valueDescription):
2174
2175 2016-05-18  Brady Eidson  <beidson@apple.com>
2176
2177         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
2178         https://bugs.webkit.org/show_bug.cgi?id=157823
2179
2180         Reviewed by Alex Christensen.
2181
2182         * DumpRenderTree/mac/TestRunnerMac.mm:
2183         (TestRunner::clearAllDatabases):
2184         
2185         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2186         (WTR::TestRunner::clearAllDatabases):
2187         
2188         * WebKitTestRunner/TestInvocation.cpp:
2189         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2190
2191 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
2192
2193         AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
2194         https://bugs.webkit.org/show_bug.cgi?id=157822
2195
2196         Reviewed by Chris Fleizach.
2197
2198         Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
2199         nullptr upon failure.
2200
2201         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2202         (WTR::AccessibilityUIElement::helpText):
2203
2204 2016-05-17  Beth Dakin  <bdakin@apple.com>
2205
2206         Make handleAcceptedCandidate a public function
2207         https://bugs.webkit.org/show_bug.cgi?id=157763
2208         -and corresponding-
2209         rdar://problem/26206397
2210
2211         Reviewed by Tim Horton.
2212
2213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2214         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
2215         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
2216         (-[DoNotLeakWebView dealloc]):
2217         (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
2218         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2219         (TestWebKitAPI::TEST):
2220
2221 2016-05-17  Keith Miller  <keith_miller@apple.com>
2222
2223         Add test262 harness support code
2224         https://bugs.webkit.org/show_bug.cgi?id=157797
2225
2226         Reviewed by Filip Pizlo.
2227
2228         The import-test262-tests script is used to generate the yaml file used to run test262. It
2229         takes a path to the local copy of the Test262 repository as well as an optional path to file
2230         containing a list of failures. This script currently just creates the yaml file used to run
2231         the script. It does not relocate the test files into our tests directory. In the future I
2232         plan to add that feature but it didn't seem essential for the first iteration. Since many
2233         test262 tests need to be run in both strict and non-strict mode, import-test262-tests
2234         creates two separate runs for those tests. This enables us to distinguish between failures
2235         in only one of the two modes.
2236
2237         This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
2238         to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
2239         takes an actual test file along with the metadata associated with it. prepareTest262Fixture
2240         takes a fixture file (used by module tests for importing) and makes sure that file is
2241         properly relocated to the test runner directory.
2242
2243         The proccess I used to import the tests was to first run import-test262-tests to create a
2244         yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
2245         passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
2246         output to a file and collected all the lines with "FAIL" in it. Finally, I reran
2247         import-test262-tests with the new failure file to create the final yaml.
2248
2249         * Scripts/import-test262-tests: Added.
2250         * Scripts/run-jsc-stress-tests:
2251
2252 2016-05-16  Enrica Casucci  <enrica@apple.com>
2253
2254         build fix after r200968 and r200969
2255
2256         Unreviewed.
2257
2258         * DumpRenderTree/mac/EventSendingController.mm:
2259         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2260
2261 2016-05-16  Jer Noble  <jer.noble@apple.com>
2262
2263         API test WebKit2.MSEIsPlayingAudio timing out after r200951
2264         https://bugs.webkit.org/show_bug.cgi?id=157748
2265
2266         Reviewed by Eric Carlson.
2267
2268         The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
2269         "user gesture" check fails at that point.  Call play() up front; playback will begin as soon
2270         as enough data is loaded.
2271
2272         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
2273
2274 2016-05-16  Enrica Casucci  <enrica@apple.com>
2275
2276         Remove unused initializer for WebEvent on iOS.
2277         https://bugs.webkit.org/show_bug.cgi?id=157689
2278
2279         Reviewed by Anders Carlsson.
2280
2281         Adopting different initializer for WebEvent to fix the build.
2282
2283         * DumpRenderTree/mac/EventSendingController.mm:
2284         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2285
2286 2016-05-16  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2287
2288         Add machine-readable results for JSC API tests to the Buildbot json log
2289         https://bugs.webkit.org/show_bug.cgi?id=157642
2290
2291         Reviewed by Geoffrey Garen.
2292
2293         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2294         (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
2295         * Scripts/run-javascriptcore-tests:
2296         (runJSCStressTests): Abstracted out writing JSON to file (new function below)
2297         (writeJsonDataIfApplicable): Added
2298
2299 2016-04-06  Jer Noble  <jer.noble@apple.com>
2300
2301         [WK2] Add API to WKWebViewConfiguration to control autoplay policy.
2302         https://bugs.webkit.org/show_bug.cgi?id=156312
2303
2304         Reviewed by Dan Bernstein.
2305
2306         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2307         (WTR::initializeWebViewConfiguration):
2308         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2309         (TEST_F):
2310
2311 2016-05-16  Brent Fulgham  <bfulgham@apple.com>
2312
2313         REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
2314         https://bugs.webkit.org/show_bug.cgi?id=157630
2315         <rdar://problem/25277577>
2316
2317         Reviewed by Simon Fraser.
2318
2319         Update test infrastructure to support checking the number of images in the pasteboard.
2320
2321         * DumpRenderTree/TestRunner.cpp:
2322         (imageCountInGeneralPasteboardCallback): Added.
2323         (TestRunner::staticFunctions):
2324         * DumpRenderTree/TestRunner.h:
2325         * DumpRenderTree/mac/TestRunnerMac.mm:
2326         (TestRunner::imageCountInGeneralPasteboard): Added.
2327         * DumpRenderTree/win/TestRunnerWin.cpp:
2328         (TestRunner::imageCountInGeneralPasteboard): Added stub method.
2329         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2330         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2331         (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
2332         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2333         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2334         (WTR::TestRunner::imageCountInGeneralPasteboard): Added.
2335         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2336         * WebKitTestRunner/TestController.cpp:
2337         (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
2338         * WebKitTestRunner/TestController.h:
2339         * WebKitTestRunner/TestInvocation.cpp:
2340         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
2341         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2342         (WTR::TestController::imageCountInGeneralPasteboard): Added.
2343
2344 2016-05-13  Dewei Zhu  <dewei_zhu@apple.com>
2345
2346         Fix JSBench which causes math domain error in run-benchmark script.
2347         https://bugs.webkit.org/show_bug.cgi?id=157697
2348         <rdar://problem/26279292>
2349
2350         Reviewed by Ryosuke Niwa.
2351
2352         Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
2353         Also fix a round-off error while calculating stdev.
2354
2355         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2356         (BenchmarkResults._format_values):
2357         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
2358
2359 2016-05-13  Brady Eidson  <beidson@apple.com>
2360
2361         Extend protector naming code style guideline to cover operator= assignment.
2362         https://bugs.webkit.org/show_bug.cgi?id=157693
2363
2364         Reviewed by Darin Adler.
2365
2366         * Scripts/webkitpy/style/checkers/cpp.py:
2367         (check_identifier_name_in_declaration):
2368         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2369         (WebKitStyleTest.test_names):
2370
2371 2016-05-13  Aakash Jain  <aakash_jain@apple.com>
2372
2373         Dashboard code restructuring
2374         https://bugs.webkit.org/show_bug.cgi?id=157680
2375         <rdar://problem/14736888>
2376
2377         Reviewed by Alexey Proskuryakov.
2378
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
2380         (BubbleQueueView.prototype.addLinkToRow): Moved to base class.
2381         (BubbleQueueView.prototype.addTextToRow): Moved to base class.
2382         (BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
2383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2384         (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2386         (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2388         (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2390         (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
2391         additional argument.
2392         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
2393         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
2394         (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
2395         (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2397         (documentReady): Display any customView if available.
2398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2399         (QueueView.prototype.addLinkToRow): Moved from child class, no changes.
2400         (QueueView.prototype.addTextToRow): Moved from child class, no changes.
2401         (QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
2402         (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
2403         by taking latestIterationGetter method as an argument.
2404         (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
2405         (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
2406         (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2408         (a:hover:link): Underline only when there is a link.
2409
2410 2016-05-13  Yoav Weiss  <yoav@yoav.ws>
2411
2412         Turn on WEB_TIMING for all ports
2413         https://bugs.webkit.org/show_bug.cgi?id=157673
2414
2415         Reviewed by Alex Christensen.
2416
2417         * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
2418
2419 2016-05-13  Brady Eidson  <beidson@apple.com>
2420
2421         Protector Ref/RefPtrs should have a specified naming style.
2422         https://bugs.webkit.org/show_bug.cgi?id=157591
2423
2424         Reviewed by Darin Adler.
2425
2426         * Scripts/webkitpy/style/checkers/cpp.py:
2427         (check_identifier_name_in_declaration):
2428         (CppChecker):
2429         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2430         (WebKitStyleTest.test_names):
2431
2432 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
2433
2434         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
2435         https://bugs.webkit.org/show_bug.cgi?id=157564
2436
2437         Reviewed by Darin Adler.
2438
2439         * Scripts/webkitperl/FeatureList.pm:
2440         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2441
2442 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
2443
2444         [GTK] accessibility/aria-readonly.html is failing
2445         https://bugs.webkit.org/show_bug.cgi?id=98357
2446
2447         Reviewed by Chris Fleizach.
2448
2449         Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
2450         AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
2451         ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
2452         with range verification for inputs which implement AtkValue. The latter two
2453         additions are admittedly a heuristic workaround for platform accessibility
2454         API differences. But they should be sufficient to facilitate cross-platform
2455         testing of isAttributeSettable() for form elements which lack ARIA attributes.
2456
2457         Bump the minimum version of at-spi2-core and at-spi2-atk
2458         to 2.15.4 (earliest version that supports STATE_READ_ONLY).
2459
2460         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2461         (WTR::AccessibilityUIElement::isAttributeSettable):
2462         * gtk/jhbuild.modules:
2463
2464 2016-05-10  Ryan Haddad  <ryanhaddad@apple.com>
2465
2466         Another attempt to fix the build after r200668.
2467
2468         Unreviewed build fix.
2469
2470         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2471         (TEST):
2472
2473 2016-05-10  Dan Bernstein  <mitz@apple.com>
2474
2475         Tried to fix the Mac build after r200668.
2476
2477         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2478         (WTR::TestController::platformCreateWebView):
2479
2480 2016-05-10  Sam Weinig  <sam@webkit.org>
2481
2482         Tweak underline style for data detected links
2483         https://bugs.webkit.org/show_bug.cgi?id=157546
2484
2485         Reviewed by Tim Horton.
2486
2487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2488         * TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
2489         (TestWebKitAPI::TEST):
2490         Add tests for the new Color::getHSV() function.
2491
2492 2016-05-10  Filip Pizlo  <fpizlo@apple.com>
2493
2494         Internal JSC profiler should have a timestamped log of events for each code block
2495         https://bugs.webkit.org/show_bug.cgi?id=157538
2496
2497         Reviewed by Benjamin Poulain.
2498
2499         * Scripts/display-profiler-output:
2500
2501 2016-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2502
2503         [Linux] Remove seccomp filters support
2504         https://bugs.webkit.org/show_bug.cgi?id=157380
2505
2506         Reviewed by Darin Adler.
2507
2508         * Scripts/webkitperl/FeatureList.pm:
2509         * TestWebKitAPI/PlatformEfl.cmake:
2510         * TestWebKitAPI/PlatformGTK.cmake:
2511         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
2512         * efl/jhbuild.modules:
2513         * gtk/jhbuild.modules:
2514
2515 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
2516
2517         [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
2518         https://bugs.webkit.org/show_bug.cgi?id=157496
2519         rdar://problem/22963278
2520
2521         Reviewed by Tim Horton.
2522
2523         Enhance UIScriptController to generate a drag, which is useful for scrolling.
2524
2525         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2526         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2527         (WTR::UIScriptController::dragFromPointToPoint):
2528         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2529         * WebKitTestRunner/ios/HIDEventGenerator.h:
2530         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2531         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2532         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2533         (WTR::UIScriptController::dragFromPointToPoint):
2534
2535 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
2536
2537         Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
2538         https://bugs.webkit.org/show_bug.cgi?id=157480
2539
2540         Reviewed by Zalan Bujtas.
2541
2542         Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
2543         and move it next to the other iOS text autosizing tests.
2544         
2545         Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
2546
2547         * DumpRenderTree/TestRunner.cpp:
2548         (setTextAutosizingEnabledCallback): Deleted.
2549         (TestRunner::staticFunctions): Deleted.
2550         * DumpRenderTree/mac/TestRunnerMac.mm:
2551         (TestRunner::setTextAutosizingEnabled): Deleted.
2552
2553 2016-05-07  Darin Adler  <darin@apple.com>
2554
2555         Next step on dictionary bindings, along with other bindings refinements
2556         https://bugs.webkit.org/show_bug.cgi?id=157451
2557
2558         Reviewed by Chris Dumez.
2559
2560         * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
2561         Also skip test expectations in a directory that this was modifying unnecessarily.
2562
2563 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
2564
2565         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
2566         https://bugs.webkit.org/show_bug.cgi?id=157432
2567         rdar://problem/16406720
2568
2569         Reviewed by Dean Jackson.
2570
2571         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
2572
2573         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
2574         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
2575         These two settings are shared with TEXT_AUTOSIZING.
2576
2577         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
2578
2579         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
2580         without changes.
2581
2582         An implication of this set of changes is that the way clients enable text autosizing
2583         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
2584         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
2585         on iPhone only, not iPad.
2586
2587         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
2588         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
2589
2590         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
2591         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
2592         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
2593
2594         * DumpRenderTree/mac/DumpRenderTree.mm:
2595         (resetWebPreferencesToConsistentValues):
2596         * DumpRenderTree/mac/TestRunnerMac.mm:
2597         (TestRunner::setTextAutosizingEnabled):
2598         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2599         * WebKitTestRunner/ios/TestControllerIOS.mm:
2600         (WTR::TestController::platformResetPreferencesToConsistentValues):
2601
2602 2016-05-06  Dean Jackson  <dino@apple.com>
2603
2604         Regions, Shapes and Tracks don't need runtime features
2605         https://bugs.webkit.org/show_bug.cgi?id=157426
2606         <rdar://problem/26146262>
2607
2608         Reviewed by Simon Fraser.
2609
2610         The following RuntimeEnabledFeatures can be removed since
2611         we have no need to disable them (they are stable and have
2612         shipped for a while):
2613         - CSS Regions
2614         - CSS Shapes
2615         - Media tracks
2616
2617         * DumpRenderTree/mac/DumpRenderTree.mm:
2618         (resetWebPreferencesToConsistentValues): Deleted.
2619
2620 2016-05-06  Ryan Haddad  <ryanhaddad@apple.com>
2621
2622         Increase delay when launching multiple ios-simulators in parallel
2623         https://bugs.webkit.org/show_bug.cgi?id=157422
2624
2625         Reviewed by Alexey Proskuryakov.
2626
2627         Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
2628         this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.
2629
2630         * Scripts/webkitpy/port/ios.py:
2631         (IOSSimulatorPort.setup_test_run):
2632
2633 2016-05-06  Per Arne Vollan  <peavo@outlook.com>
2634
2635         [Win] Remove WinXP support.
2636         https://bugs.webkit.org/show_bug.cgi?id=157416
2637
2638         Reviewed by Brent Fulgham.
2639
2640         * win/DLLLauncher/DLLLauncherMain.cpp:
2641         (enableTerminationOnHeapCorruption):
2642
2643 2016-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2644
2645         [css-grid] Unprefix CSS Grid Layout properties
2646         https://bugs.webkit.org/show_bug.cgi?id=157137
2647
2648         Reviewed by Simon Fraser.
2649
2650         Remove "-webkit" prefix from all the grid layout properties,
2651         including the display value.
2652         Update the source code to remove the prefix where it was used too.
2653
2654         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2655         (TestWebKitAPI::TEST):
2656
2657 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2658
2659         Partially revert http://trac.webkit.org/r200504
2660         Improve HTTP test names in WebKitTestRunner's crash report information
2661         https://bugs.webkit.org/show_bug.cgi?id=157389
2662
2663         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
2664         in crash reporter information.
2665
2666 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2667
2668         Improve HTTP test names in WebKitTestRunner's crash report information
2669         https://bugs.webkit.org/show_bug.cgi?id=157389
2670
2671         Reviewed by Alex Christensen.
2672
2673         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2674         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
2675
2676         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2677         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
2678         use other port numbers too. For http tests, return the complete URL string, not
2679         just the path.
2680
2681 2016-05-04  Alex Christensen  <achristensen@webkit.org>
2682
2683         Blocked redirected main resource requests need descriptive errors
2684         https://bugs.webkit.org/show_bug.cgi?id=156828
2685         rdar://problem/25711316
2686
2687         Reviewed by Daniel Bates.
2688
2689         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2690         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2691         Print out the error type to make sure we have the most descriptive error type.
2692
2693 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
2694
2695         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
2696         https://bugs.webkit.org/show_bug.cgi?id=157341
2697
2698         Reviewed by Xabier Rodriguez-Calvar.
2699
2700         * gtk/jhbuild.modules:
2701         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
2702         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
2703
2704 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2705
2706         Add JSC test results in JSON format to a Buildbot log
2707         https://bugs.webkit.org/show_bug.cgi?id=156920
2708
2709         Reviewed by Daniel Bates.
2710
2711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2712         (RunJavaScriptCoreTests): Move command-line option for output file out
2713         of WithProperties.
2714
2715 2016-05-04  Dean Jackson  <dino@apple.com>
2716
2717         TestRunner should always enable all the experimental features
2718         https://bugs.webkit.org/show_bug.cgi?id=157360
2719         <rdar://problem/26099748>
2720
2721         Reviewed by Anders Carlsson.
2722
2723         Call the new SPI that enables all the experimental features.
2724
2725         * WebKitTestRunner/TestController.cpp:
2726         (WTR::TestController::resetPreferencesToConsistentValues):
2727
2728 2016-05-04  Mark Lam  <mark.lam@apple.com>
2729
2730         ES6 Function.name inferred from property names of literal objects can break some websites.
2731         https://bugs.webkit.org/show_bug.cgi?id=157246
2732
2733         Reviewed by Geoffrey Garen.
2734
2735         * WebKitTestRunner/TestController.cpp:
2736         (WTR::TestController::resetPreferencesToConsistentValues):
2737         (WTR::updateTestOptionsFromTestHeader):
2738         * WebKitTestRunner/TestOptions.h:
2739
2740         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2741         (WTR::PlatformWebView::viewSupportsOptions):
2742         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2743         (WTR::PlatformWebView::viewSupportsOptions):
2744         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
2745
2746 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
2747
2748         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
2749         https://bugs.webkit.org/show_bug.cgi?id=157331
2750
2751         Reviewed by Chris Fleizach.
2752
2753         Add AXLandmarkRegion to the landmark strings handled by roleToString
2754         for objects with ATK_ROLE_LANDMARK.
2755
2756         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2757
2758 2016-05-03  Beth Dakin  <bdakin@apple.com>
2759
2760         Add VideoControlsManager tests
2761         https://bugs.webkit.org/show_bug.cgi?id=157332
2762         -and corresponding-
2763         rdar://problem/24358431
2764
2765         Reviewed by Sam Weinig.
2766
2767         This patch adds three VideoControlsManager tests.
2768
2769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2770         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2771         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
2772         (-[DidPlayMessageHandler initWithWKWebView:]):
2773         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2774         (TestWebKitAPI::TEST):
2775         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
2776         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
2777         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
2778
2779 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2780
2781         [ATK] accessibility/document-attributes.html is failing
2782         https://bugs.webkit.org/show_bug.cgi?id=125348
2783
2784         Reviewed by Chris Fleizach.
2785
2786         The test was failing because the WebArea is now being exposed with the role of
2787         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
2788         change was made, documentEncoding() and documentURI() were not updated accordingly.
2789
2790         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2791         (WTR::AccessibilityUIElement::documentEncoding):
2792         (WTR::AccessibilityUIElement::documentURI):
2793
2794 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
2795
2796         [Win] Unreviewed build fix.
2797
2798         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
2799         environment at start of queue run.
2800
2801 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2802
2803         [ATK] accessibility/content-editable-as-textarea.html fails
2804         https://bugs.webkit.org/show_bug.cgi?id=155353
2805
2806         Reviewed by Darin Adler.
2807
2808         The test was timing out because it expected an AXValueChanged notification.
2809         In ATK, AXValueChanged notifications are made for widgets which implement
2810         the AtkValue interface (sliders, progress bars, etc.). We should be listening
2811         for AXTextChanged instead. AtkText's text-insert and text-remove have been
2812         added to the AccessibilityNotificationHandler.
2813
2814         Also, ATK's AccessibilityUIElement support had a number of unimplemented
2815         methods that are being used as part of the previously-failing test. Those
2816         methods are now implemented so that the ATK results are much more similar
2817         to those on the Mac.
2818
2819         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2820         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2821         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2822         (WTR::AccessibilityUIElement::stringAttributeValue):
2823         (WTR::AccessibilityUIElement::rangeForLine):
2824         (WTR::AccessibilityUIElement::boundsForRange):
2825         (WTR::AccessibilityUIElement::attributedStringForRange):
2826
2827 2016-05-02  Brady Eidson  <beidson@apple.com>
2828
2829         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
2830         https://bugs.webkit.org/show_bug.cgi?id=157274
2831
2832         Reviewed by Alex Christensen.
2833
2834         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
2835         and reset them in between tests:
2836         * DumpRenderTree/TestRunner.cpp:
2837         (accummulateLogsForChannel):
2838         (TestRunner::staticFunctions):
2839         (TestRunner::waitToDumpWatchdogTimerFired):
2840         (TestRunner::setAccummulateLogsForChannel):
2841         * DumpRenderTree/TestRunner.h:
2842         * DumpRenderTree/mac/DumpRenderTree.mm:
2843         (resetWebViewToConsistentStateBeforeTesting):
2844
2845         Also add the new method to WKTR's TestRunner, but just stubbed for now:
2846         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2847         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2848         (WTR::TestRunner::accummulateLogsForChannel):
2849         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2850
2851 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2852
2853         Add fail-fast option to run-javascriptcore-tests
2854         https://bugs.webkit.org/show_bug.cgi?id=157270
2855
2856         Reviewed by Geoffrey Garen.
2857
2858         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
2859         Defaults to yes, which is the current behavior.
2860
2861 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2862
2863         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
2864         https://bugs.webkit.org/show_bug.cgi?id=157268
2865
2866         Reviewed by Michael Catanzaro.
2867
2868         * MiniBrowser/gtk/CMakeLists.txt:
2869
2870 2016-04-30  Darin Adler  <darin@apple.com>
2871
2872         Streamline and remove unused bindings generation code
2873         https://bugs.webkit.org/show_bug.cgi?id=157237
2874
2875         Reviewed by Chris Dumez.
2876
2877         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2878         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2879         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2880         Replace non-standard "int" with standard "long", which means the same thing.
2881
2882 2016-04-30  Darin Adler  <darin@apple.com>
2883
2884         Next batch of conversions to use C++ enum class instead of strings for enumerations
2885         https://bugs.webkit.org/show_bug.cgi?id=157232
2886
2887         Reviewed by Chris Dumez.
2888
2889         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
2890         checking. We don't want to waste time trying to make our generated code match our style.
2891
2892 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2893
2894         Add JSC test results in JSON format to a Buildbot log.
2895         https://bugs.webkit.org/show_bug.cgi?id=156920
2896
2897         Reviewed by Daniel Bates.
2898
2899         Generate JSON results for JSC tests and upload them to the master
2900         using Buildbot's logfiles machinery.
2901
2902         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2903         (RunJavaScriptCoreTests): Use --json-output option when invoking the
2904         run-javascriptcore-tests Perl script, and expose this JSON output as a 
2905         Buildbot log.
2906         * Scripts/run-javascriptcore-tests:
2907         (runJSCStressTests): Change key names and remove redundant count key.
2908
2909 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
2910
2911         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
2912         https://bugs.webkit.org/show_bug.cgi?id=146719
2913
2914         Reviewed by Chris Fleizach.
2915
2916         Implement roleDescription() so that the implementation can be tested.
2917
2918         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2919         (WTR::AccessibilityUIElement::roleDescription):
2920
2921 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
2922
2923         Don't throttle GuardMalloc on 8-core Macs
2924         https://bugs.webkit.org/show_bug.cgi?id=157108
2925
2926         Reviewed by Alex Christensen.
2927
2928         This was making them slower unnecessarily.
2929
2930         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
2931
2932 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
2933
2934         Unreviewed: add myself to the committers list.
2935
2936         * Scripts/webkitpy/common/config/contributors.json:
2937
2938 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2939
2940         Fix text in log files autogenerated by import-w3c-tests
2941         https://bugs.webkit.org/show_bug.cgi?id=157021
2942
2943         Unreviewed. Fixing the second typo.
2944
2945         * Scripts/webkitpy/w3c/test_importer.py:
2946         (TestImporter.write_import_log):
2947
2948 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
2949
2950         WebCore on Mac ignores the user's preferred region (country) while getting the language
2951         https://bugs.webkit.org/show_bug.cgi?id=156993
2952
2953         Reviewed by Geoffrey Garen.
2954
2955         Change the test expectations for this test. If the variant is not explicitly specified in
2956         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
2957
2958         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2959         (TestWebKitAPI::languageForSystemLanguage):
2960         (TestWebKitAPI::TEST):
2961
2962 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2963
2964         Remove the build flag for template elements
2965         https://bugs.webkit.org/show_bug.cgi?id=157022
2966
2967         Reviewed by Daniel Bates.
2968
2969         Removed the build option.
2970
2971         * Scripts/webkitperl/FeatureList.pm:
2972
2973 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2974
2975         Fix text in log files autogenerated by import-w3c-tests
2976         https://bugs.webkit.org/show_bug.cgi?id=157021
2977
2978         Reviewed by Chris Dumez.
2979
2980         s/Webkit/WebKit/ and end each sentence with a period.
2981
2982         * Scripts/webkitpy/w3c/test_importer.py:
2983         (TestImporter.write_import_log):
2984
2985 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
2986
2987         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
2988         https://bugs.webkit.org/show_bug.cgi?id=156929
2989
2990         Reviewed by Darin Adler.
2991
2992         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2993         (TestWebKitAPI::TEST):
2994
2995 2016-04-25  Caitlin Potter  <caitp@igalia.com>
2996
2997         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
2998         https://bugs.webkit.org/show_bug.cgi?id=156976
2999
3000         Reviewed by Darin Adler.
3001
3002         Mitigate style-checker spam on bugs which introduce new JavaScript
3003         token types.
3004
3005         * Scripts/webkitpy/style/checkers/cpp.py:
3006         (_EnumState.__init__):
3007         (_EnumState.process_clean_line):
3008         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3009         (NoNonVirtualDestructorsTest.test_enum_casing):
3010
3011 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
3012
3013         Fix issues with content-animation performance tests
3014         https://bugs.webkit.org/show_bug.cgi?id=157001
3015
3016         Reviewed by Sam Weinig.
3017
3018         Add patch content for svg-animation.html, and fix the paths in the patch so
3019         it applies correctly.
3020
3021         Add the patch file to the .plan file.
3022
3023         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
3024         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
3025
3026 2016-04-25  Brady Eidson  <beidson@apple.com>
3027
3028         Tweaking IndexedDB watchlist and adding myself to it.
3029
3030         * Scripts/webkitpy/common/config/watchlist:
3031
3032 2016-04-25  Commit Queue  <commit-queue@webkit.org>
3033
3034         Unreviewed, rolling out r199916.
3035         https://bugs.webkit.org/show_bug.cgi?id=156989
3036
3037         Might break buildbot when master is restarted (Requested by
3038         Srinivasan Vijayaraghava, Guest100, on #webkit).
3039
3040         Reverted changeset:
3041
3042         "Add JSC test results in json format to a buildbot log"
3043         https://bugs.webkit.org/show_bug.cgi?id=156920
3044         http://trac.webkit.org/changeset/199916
3045
3046 2016-04-23  Chris Dumez  <cdumez@apple.com>
3047
3048         [WebIDL] Drop [Default] WebKit-IDL extended attribute
3049         https://bugs.webkit.org/show_bug.cgi?id=156955
3050
3051         Reviewed by Darin Adler.
3052
3053         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3054
3055 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
3056
3057         Really enable INDEXED_DATABASE on Apple Mac cmake build
3058         https://bugs.webkit.org/show_bug.cgi?id=156902
3059
3060         Reviewed by Michael Catanzaro.
3061
3062         * Scripts/webkitperl/FeatureList.pm:
3063
3064 2016-04-23  Andy Estes  <aestes@apple.com>
3065
3066         check-webkit-style: fix false-positive warnings about @synchronized
3067         https://bugs.webkit.org/show_bug.cgi?id=156957
3068
3069         Reviewed by Dan Bernstein.
3070
3071         * Scripts/webkitpy/style/checkers/cpp.py:
3072         (check_spacing_for_function_call): Ignore @synchronized lines.
3073         (check_braces): Ditto.
3074         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3075         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
3076
3077 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3078
3079         Add JSC test results in json format to a buildbot log
3080         https://bugs.webkit.org/show_bug.cgi?id=156920
3081
3082         Reviewed by Alexey Proskuryakov.
3083
3084         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3085         (RunJavaScriptCoreTests):
3086         Add runtime flag to output json into buildbot
3087         * Scripts/run-javascriptcore-tests:
3088         (runJSCStressTests):
3089         Change key names and remove redundant count key
3090
3091 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
3092
3093         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
3094
3095         Unreviewed test gardening.
3096
3097         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3098         (TestWebKitAPI::TEST):
3099
3100 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3101
3102         [GTK] Enable the download attribute support
3103         https://bugs.webkit.org/show_bug.cgi?id=99025
3104
3105         Reviewed by Žan Doberšek.
3106
3107         * Scripts/webkitperl/FeatureList.pm:
3108
3109 2016-04-21  Keith Miller  <keith_miller@apple.com>
3110
3111         WebScriptObject description swizzler should work in a multi-threaded world
3112         https://bugs.webkit.org/show_bug.cgi?id=156808
3113
3114         Add a test for our NSObject swizzling TLS implementation. The test runs on
3115         two threads. One in JS and another in Objective-C. We expect the JS thread
3116         to use our NSObject description override and the Objective-C thread to act
3117         as though it was using the original NSObject description method.
3118
3119         Reviewed by Geoffrey Garen.
3120
3121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3122         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
3123         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
3124         (nsObjectDescriptionTest):
3125         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
3126         (TestWebKitAPI::TEST):
3127
3128 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3129
3130         [GTK] WebKitWebView should claim the contents size as its natural size
3131         https://bugs.webkit.org/show_bug.cgi?id=156835
3132
3133         Reviewed by Žan Doberšek.
3134
3135         Add test case to check the WebKitWebView preferred size.
3136
3137         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3138         (testWebViewPreferredSize):
3139         (beforeAll):
3140
3141 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
3142
3143         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
3144         https://bugs.webkit.org/show_bug.cgi?id=156827
3145         
3146         Update the .plan file now that the files are present in SVN.
3147
3148         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
3149
3150 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
3151
3152         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
3153         https://bugs.webkit.org/show_bug.cgi?id=156827
3154         rdar://problem/24358135
3155
3156         Reviewed by Stephanie Lewis.
3157
3158         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
3159         and collate results across them. Also add the ability for the browser_driver to supply
3160         additional results, allowing for tests that collect results data in native code, rather
3161         than generating it in the web page.
3162
3163         Add a set of "content animation" tests that use this new functionality, which test
3164         CSS animation and requestAnimationFrame performance.
3165
3166         'plan' files have two new optional keys:
3167             'test_files': a list of files to run as a suite
3168             'options': optional parameters. Currently supports one new option,
3169                 'animation_command', which affects the way that iOS tests are run,
3170                 and is passed to MobileSafari as a parameter on launch.
3171
3172         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3173         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
3174         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
3175         (BenchmarkRunner):
3176         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
3177         running a single test. It starts and stops the http_server_driver.
3178         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
3179         key, otherwise look for the new 'test_files' and load each in a loop.
3180         (BenchmarkRunner._dump):
3181         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3182         (BrowserDriver.launch_url): Pass options.
3183         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
3184         (BrowserDriver):
3185         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
3186         (GTKMiniBrowserDriver.launch_url):
3187         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3188         (OSXBrowserDriver.close_browsers):
3189         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
3190         (OSXBrowserDriver._terminiate_processes): Deleted.
3191         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3192         (OSXChromeDriver.launch_url):
3193         (OSXChromeCanaryDriver.launch_url):
3194         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3195         (OSXFirefoxDriver.launch_url):
3196         (OSXFirefoxNightlyDriver.launch_url):
3197         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3198         (OSXSafariDriver.launch_url):
3199         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
3200         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
3201
3202 2016-04-20  Dustin Falgout  <dustin@falgout.us>
3203
3204         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
3205         https://bugs.webkit.org/show_bug.cgi?id=156651
3206
3207         Reviewed by Michael Catanzaro.
3208
3209         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3210         (testWebKitSettings):
3211
3212 2016-04-20  Brady Eidson  <beidson@apple.com>
3213
3214         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
3215         https://bugs.webkit.org/show_bug.cgi?id=156782
3216
3217         Reviewed by Alex Christensen.
3218
3219         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3220
3221 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
3222
3223         Unreviewed build fix after r199752.
3224
3225         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3226         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
3227
3228 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
3229
3230         Remove remaining bits of dynamic <link> rel='icon' loading
3231         https://bugs.webkit.org/show_bug.cgi?id=156727
3232
3233         Reviewed by Darin Adler.
3234
3235         Remove unused test infrastructure. This code never existed in WebKit2
3236         testing since was only used on Windows.
3237
3238         * DumpRenderTree/TestRunner.cpp:
3239         (dumpIconChangesCallback): Deleted.
3240         * DumpRenderTree/TestRunner.h:
3241         (TestRunner::dumpIconChanges): Deleted.
3242         (TestRunner::setDumpIconChanges): Deleted.
3243
3244 2016-04-19  Keith Miller  <keith_miller@apple.com>
3245
3246         ObjcInstance::stringValue should not call NSObject's description method
3247         https://bugs.webkit.org/show_bug.cgi?id=156758
3248
3249         Reviewed by Geoffrey Garen.
3250
3251         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
3252         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
3253         call the NSObjects description method without first swizzling it.
3254
3255         * DumpRenderTree/mac/ObjCController.m:
3256         (+[ObjCController isSelectorExcludedFromWebScript:]):
3257         (+[ObjCController webScriptNameForSelector:]):
3258         (-[ObjCController testArrayOfObjects]):
3259         (-[ObjCController testObject]):
3260
3261 2016-04-18  Dan Bernstein  <mitz@apple.com>
3262
3263         Fixed building with old Xcode.
3264
3265         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3266         (TEST):
3267
3268 2016-04-18  Dean Jackson  <dino@apple.com>
3269
3270         New SPI to export a dictionary of runtime features
3271         https://bugs.webkit.org/show_bug.cgi?id=156645
3272         <rdar://problem/23621666>
3273
3274         Reviewed by Darin Adler.
3275
3276         Test the experimental features SPI on WKPreferences.
3277
3278         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3279
3280 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
3281
3282         [JSCOnly] Implement RunLoop and remove glib dependency
3283         https://bugs.webkit.org/show_bug.cgi?id=155706
3284
3285         Reviewed by Michael Catanzaro.
3286
3287         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
3288         Platform specific ones locate under jsconly directory since
3289         it is not `generic` (Since it includes the GLIB event loop case).
3290
3291         * CMakeLists.txt:
3292         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
3293         * TestWebKitAPI/PlatformUtilities.h:
3294         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3295         (TestWebKitAPI::TEST):
3296         * TestWebKitAPI/config.h:
3297         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
3298         (TestWebKitAPI::Util::run):
3299         (TestWebKitAPI::Util::sleep):
3300         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
3301         (main):
3302
3303 2016-04-18  Jon Lee  <jonlee@apple.com>
3304
3305         Update Animometer plan.
3306         https://bugs.webkit.org/show_bug.cgi?id=156652
3307
3308         Reviewed by Darin Adler.
3309
3310         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
3311
3312 2016-04-18  Dana Burkart  <dburkart@apple.com>
3313
3314         svn-apply: add option for ignoring changes to ChangeLog files
3315         https://bugs.webkit.org/show_bug.cgi?id=156618
3316
3317         Reviewed by Darin Adler.
3318
3319         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
3320         patch() if the file in question is a ChangeLog.
3321
3322         * Scripts/svn-apply:
3323         (patch):
3324
3325 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3326
3327         Pending API Request URL is wrong after reloading
3328         https://bugs.webkit.org/show_bug.cgi?id=139342
3329
3330         Reviewed by Darin Adler.
3331
3332         Update test case to check that the active URL should remain the
3333         same after a reload.
3334
3335         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
3336         (TestWebKitAPI::TEST):
3337
3338 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3339
3340         Pending API request URL no set when loading Data, Alternate HTML or plain text
3341         https://bugs.webkit.org/show_bug.cgi?id=136916
3342
3343         Reviewed by Darin Adler.
3344
3345         Add new test to check that active URL is the requested one right
3346         after calling WKPage load methods.
3347
3348         * TestWebKitAPI/PlatformEfl.cmake:
3349         * TestWebKitAPI/PlatformGTK.cmake:
3350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3351         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
3352         (TestWebKitAPI::TEST):
3353         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3354         (WebViewTest::loadPlainText): Remove FIXME.
3355         (WebViewTest::loadBytes): Ditto.
3356         (WebViewTest::loadAlternateHTML): Ditto.
3357
3358 2016-04-18  Commit Queue  <commit-queue@webkit.org>
3359
3360         Unreviewed, rolling out r199660.
3361         https://bugs.webkit.org/show_bug.cgi?id=156691
3362
3363         It broke the iOS build (Requested by KaL on #webkit).
3364
3365         Reverted changeset:
3366
3367         "Pending API request URL no set when loading Data, Alternate
3368         HTML or plain text"
3369         https://bugs.webkit.org/show_bug.cgi?id=136916
3370         http://trac.webkit.org/changeset/199660
3371
3372 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3373
3374         Pending API request URL no set when loading Data, Alternate HTML or plain text
3375         https://bugs.webkit.org/show_bug.cgi?id=136916
3376
3377         Reviewed by Darin Adler.
3378
3379         Add new test to check that active URL is the requested one right
3380         after calling WKPage load methods.
3381
3382         * TestWebKitAPI/PlatformEfl.cmake:
3383         * TestWebKitAPI/PlatformGTK.cmake:
3384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3385         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
3386         (TestWebKitAPI::TEST):
3387         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3388         (WebViewTest::loadPlainText): Remove FIXME.
3389         (WebViewTest::loadBytes): Ditto.
3390         (WebViewTest::loadAlternateHTML): Ditto.
3391
3392 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
3393
3394         Fix incorrect assumption that APPLE implies Mac.
3395         https://bugs.webkit.org/show_bug.cgi?id=156679
3396
3397         Addresses build failure introduced in r198947
3398
3399         Reviewed by Alex Christensen.
3400
3401         * CMakeLists.txt:
3402
3403 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3404
3405         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
3406         https://bugs.webkit.org/show_bug.cgi?id=156621
3407
3408         Reviewed by Martin Robinson.
3409
3410         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
3411         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
3412         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
3413
3414         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3415         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
3416
3417 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3418
3419         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
3420         https://bugs.webkit.org/show_bug.cgi?id=156655
3421
3422         Reviewed by Antonio Gomes.
3423
3424         To support html5 video feature, we should bump gstreamer version.
3425
3426         * efl/jhbuild.modules:
3427         * efl/patches/gst-libav.patch: Update against newer version.
3428         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
3429
3430 2016-04-16  Sam Weinig  <sam@webkit.org>
3431
3432         More build fixing.
3433
3434         * MiniBrowser/mac/BrowserWindowController.m:
3435         (-[BrowserWindowController share:]):
3436
3437 2016-04-16  Sam Weinig  <sam@webkit.org>
3438
3439         Another build fix.
3440
3441         * MiniBrowser/mac/BrowserWindowController.m:
3442         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
3443
3444 2016-04-16  Sam Weinig  <sam@webkit.org>
3445
3446         Fix 32-bit build.
3447
3448         * MiniBrowser/mac/BrowserWindowController.m:
3449         (-[BrowserWindowController share:]):
3450         (-[BrowserWindowController fetch:]):
3451         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
3452
3453 2016-04-15  Sam Weinig  <sam@webkit.org>
3454
3455         Add support for NSSharingService to MiniBrowser, for no great reasons
3456         https://bugs.webkit.org/show_bug.cgi?id=156658
3457
3458         Reviewed by Darin Adler.
3459
3460         * MiniBrowser/mac/BrowserWindow.xib:
3461         * MiniBrowser/mac/BrowserWindowController.h:
3462         Add the share button.
3463
3464         * MiniBrowser/mac/BrowserWindowController.m:
3465         (-[BrowserWindowController windowDidLoad]):
3466         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
3467
3468         (-[BrowserWindowController share:]):
3469         Show the picker when the button is pressed.
3470         (-[BrowserWindowController mainContentView]):
3471         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
3472
3473         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
3474         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
3475         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
3476         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
3477         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
3478         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3479         Add delegate methods.
3480
3481         * MiniBrowser/mac/WK1BrowserWindowController.m:
3482         (-[WK1BrowserWindowController mainContentView]):
3483         * MiniBrowser/mac/WK2BrowserWindowController.m:
3484         (-[WK2BrowserWindowController mainContentView]):
3485         Implement to return the web view.
3486
3487 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
3488
3489         Build fix.
3490
3491         Temporary workaround for rdar://problem/25754945.
3492
3493         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3494
3495 2016-04-15  Commit Queue  <commit-queue@webkit.org>
3496
3497         Unreviewed, rolling out r199600.
3498         https://bugs.webkit.org/show_bug.cgi?id=156642
3499
3500         It didn't help (Requested by ap_ on #webkit).
3501
3502         Reverted changeset:
3503
3504         "Build fix."
3505         http://trac.webkit.org/changeset/199600
3506
3507 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
3508
3509         Build fix.
3510
3511         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
3512
3513 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
3514
3515         Some GuardMalloc bots are not happy when running many parallel processes
3516         https://bugs.webkit.org/show_bug.cgi?id=156614
3517         rdar://problem/24711525
3518
3519         Reviewed by David Kilzer.
3520
3521         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
3522
3523 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
3524
3525         Make <a download> a runtime enabled option
3526         https://bugs.webkit.org/show_bug.cgi?id=156583
3527         <rdar://problem/25733449>
3528
3529         Reviewed by Alex Christensen.
3530
3531         * DumpRenderTree/mac/DumpRenderTree.mm:
3532         (resetWebPreferencesToConsistentValues):
3533         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3534         (WTR::InjectedBundle::beginTesting):
3535         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3536         (WTR::TestRunner::setDownloadAttributeEnabled):
3537         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3538
3539 2016-04-14  Anders Carlsson  <andersca@apple.com>
3540
3541         Another build fix attempt.
3542
3543         * MiniBrowser/mac/WK2BrowserWindowController.m:
3544
3545 2016-04-14  Anders Carlsson  <andersca@apple.com>
3546
3547         Fix build.
3548
3549         * MiniBrowser/mac/WK2BrowserWindowController.m:
3550         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3551
3552 2016-04-14  Anders Carlsson  <andersca@apple.com>
3553
3554         [Mac] Add API for open panel handling to WKWebView
3555         https://bugs.webkit.org/show_bug.cgi?id=137759
3556         rdar://problem/23278623
3557
3558         Reviewed by Tim Horton.
3559
3560         Have MiniBrowser implement the new delegate method.
3561
3562         * MiniBrowser/mac/WK2BrowserWindowController.m:
3563         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3564
3565 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
3566
3567         Unreviewed, rolling out r199554.
3568
3569         The change breaks Yosemite Release/Debug build
3570
3571         Reverted changeset:
3572
3573         "[Mac] Add API for open panel handling to WKWebView"
3574         https://bugs.webkit.org/show_bug.cgi?id=137759
3575         http://trac.webkit.org/changeset/199554
3576
3577 2016-04-14  Anders Carlsson  <andersca@apple.com>
3578
3579         [Mac] Add API for open panel handling to WKWebView
3580         https://bugs.webkit.org/show_bug.cgi?id=137759
3581         rdar://problem/23278623
3582
3583         Reviewed by Tim Horton.
3584
3585         Have MiniBrowser implement the new delegate method.
3586
3587         * MiniBrowser/mac/WK2BrowserWindowController.m:
3588         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3589
3590 2016-04-14  Jon Lee  <jonlee@apple.com>
3591
3592         Update Animometer plan
3593         https://bugs.webkit.org/show_bug.cgi?id=156569
3594
3595         Reviewed by Alex Christensen.
3596
3597         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
3598         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
3599
3600 2016-04-13  Alex Christensen  <achristensen@webkit.org>
3601
3602         CMake MiniBrowser should be an app bundle
3603         https://bugs.webkit.org/show_bug.cgi?id=156521
3604
3605         Reviewed by Brent Fulgham.
3606
3607         * MiniBrowser/mac/CMakeLists.txt:
3608         Make an app bundle and compile nibs.
3609         * MiniBrowser/mac/Info.plist:
3610         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
3611
3612 2016-04-13  Chris Dumez  <cdumez@apple.com>
3613
3614         We should not speculatively revalidate cached redirects
3615         https://bugs.webkit.org/show_bug.cgi?id=156548
3616         <rdar://problem/25583886>
3617
3618         Reviewed by Darin Adler.
3619
3620         Re-enable speculative loading in the context of layout tests. This was
3621         turned off by mistake when speculative loading was turned into a
3622         setting recently.
3623
3624         * WebKitTestRunner/TestController.cpp:
3625         (WTR::TestController::generatePageConfiguration):
3626
3627 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
3628
3629         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
3630         https://bugs.webkit.org/show_bug.cgi?id=155367
3631
3632         Reviewed by Darin Adler.
3633
3634         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
3635         Don't flakily consume the return code with waitpid, callers need to do waitpid on
3636         their own. Not sure if this line of code was even intentional.
3637
3638 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
3639
3640         [OS X] Flakey crash after ScrollAnimatorMac destruction
3641         https://bugs.webkit.org/show_bug.cgi?id=156372
3642
3643         Reviewed by Darin Adler.
3644
3645         Implement the new <!-- webkit-test-runner --> flag.
3646
3647         * WebKitTestRunner/TestController.cpp:
3648         (WTR::TestController::createWebViewWithOptions):
3649         (WTR::TestController::ensureViewSupportsOptionsForTest):
3650         (WTR::TestController::resetPreferencesToConsistentValues):
3651         (WTR::TestController::resetStateToConsistentValues):
3652         (WTR::updateTestOptionsFromTestHeader):
3653         * WebKitTestRunner/TestController.h:
3654         * WebKitTestRunner/TestInvocation.cpp:
3655         (WTR::TestInvocation::invoke):
3656         * WebKitTestRunner/TestOptions.h:
3657         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3658         (WKR::PlatformWebView::viewSupportsOptions):
3659
3660 2016-04-12  Tomas Popela  <tpopela@redhat.com>
3661
3662         Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
3663         https://bugs.webkit.org/show_bug.cgi?id=156338
3664
3665         Reviewed by Michael Catanzaro.
3666
3667         Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
3668         for the i686 where it is supported and not for other architectures
3669         (such as s390(x) and ppc(64)) where the build will fail with these
3670         CXXFLAGS.
3671
3672         * Scripts/webkitdirs.pm:
3673         (generateBuildSystemFromCMakeProject):
3674
3675 2016-04-11  Alex Christensen  <achristensen@webkit.org>
3676
3677         Build MiniBrowser with CMake on Mac
3678         https://bugs.webkit.org/show_bug.cgi?id=156471
3679
3680         Reviewed by Daniel Bates.
3681
3682         * CMakeLists.txt:
3683         * DumpRenderTree/CMakeLists.txt:
3684         * DumpRenderTree/PlatformWin.cmake:
3685         * MiniBrowser/mac/CMakeLists.txt: Added.
3686
3687 2016-04-11  Ryuan Choi  <ryuan.choi@navercorp.com>
3688
3689         [EFL] Do not pass context to EwkViewCreate
3690         https://bugs.webkit.org/show_bug.cgi?id=156461
3691
3692         Reviewed by Darin Adler.
3693
3694         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
3695         (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
3696         * TestWebKitAPI/efl/PlatformWebView.cpp:
3697         (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
3698         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3699         (WTR::PlatformWebView::PlatformWebView): Ditto.
3700
3701 2016-04-11  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
3702
3703         [CMake] Make FOLDER property INHERITED
3704         https://bugs.webkit.org/show_bug.cgi?id=156460
3705
3706         Reviewed by Brent Fulgham.
3707
3708         * CMakeLists.txt:
3709         * DumpRenderTree/CMakeLists.txt:
3710         * DumpRenderTree/PlatformWin.cmake:
3711         * ImageDiff/CMakeLists.txt:
3712         * MiniBrowser/efl/CMakeLists.txt:
3713         * MiniBrowser/gtk/CMakeLists.txt:
3714         * MiniBrowser/win/CMakeLists.txt:
3715         Set FOLDER property as a directory property not a target property
3716
3717 2016-04-10  Caitlin Potter  <caitp@igalia.com>
3718
3719         [Tools] correctly check for braces in multiline branches in macro definition
3720         https://bugs.webkit.org/show_bug.cgi?id=156441
3721
3722         Reviewed by Darin Adler.
3723
3724         Prevents emitting whitespace/braces warning for code like the
3725         following:
3726
3727         ```
3728         #define MACRO(x) \
3729             if (x) { \
3730                 doTheThing(); \
3731                 continue; \
3732             }
3733         ```
3734
3735         * Scripts/webkitpy/style/checkers/cpp.py:
3736         (check_braces):
3737         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3738         (WebKitStyleTest.test_line_breaking):
3739
3740 2016-04-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3741
3742         Testharness-based tests that time out should be able to produce a detailed output
3743         https://bugs.webkit.org/show_bug.cgi?id=145313
3744
3745         Reviewed by Xabier Rodriguez-Calvar.
3746
3747         Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
3748
3749         * DumpRenderTree/TestRunner.cpp:
3750         (getTimeoutCallback): The js "timeout" property getter.
3751         (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
3752         * DumpRenderTree/TestRunner.h:
3753         (TestRunner::timeout): Adding access to DRT m_timeout private value.
3754         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
3755         * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
3756         (WTR::TestRunner::timeout):
3757
3758 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
3759
3760         stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
3761         https://bugs.webkit.org/show_bug.cgi?id=156387
3762
3763         Rubber-stamped by Dan Bernstein.
3764
3765         * Scripts/webkitpy/style/checkers/featuredefines.py:
3766         (FeatureDefinesChecker.check):
3767
3768 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
3769
3770         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
3771         https://bugs.webkit.org/show_bug.cgi?id=156384
3772
3773         Reviewed by Ryosuke Niwa.
3774
3775         * Scripts/webkitperl/FeatureList.pm:
3776         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3777
3778 2016-04-06  Dean Jackson  <dino@apple.com>
3779
3780         Watchlist modifications:
3781         - remove roger_fong
3782         - add myself to a few areas
3783         - remove graouts from WebInspectorAPI
3784
3785         * Scripts/webkitpy/common/config/watchlist:
3786
3787 2016-04-07  Simon Fraser  <simon.fraser@apple.com>
3788
3789         Make it possible to test effect of view exposed rect on tiled backing
3790         https://bugs.webkit.org/show_bug.cgi?id=156365
3791
3792         Reviewed by Tim Horton.
3793
3794         Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
3795         testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
3796
3797         testRunner.setViewSize() is used instead of using window.resizeTo(), since we
3798         can't easily resize a window to larger than the screen being tested on.
3799
3800         * DumpRenderTree/TestRunner.cpp:
3801         (setViewSizeCallback):
3802         (TestRunner::staticFunctions):
3803         * DumpRenderTree/TestRunner.h:
3804         * DumpRenderTree/mac/TestRunnerMac.mm:
3805         (TestRunner::setViewSize):
3806         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3807         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3808         (WTR::InjectedBundle::postSetViewSize):
3809         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3810         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3811         (WTR::TestRunner::setViewSize):
3812         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3813         * WebKitTestRunner/TestInvocation.cpp:
3814         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3815
3816 2016-04-07  Jason Marcell  <jmarcell@apple.com>
3817
3818         Adding layout tests for the bot watcher's dashboard QUnit tests.
3819         https://bugs.webkit.org/show_bug.cgi?id=155272
3820
3821         Reviewed by Daniel Bates.
3822
3823         Moved supporting resources into a resources folder and updated index.html accordingly
3824         to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
3825
3826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
3827         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
3828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
3829         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
3830         (MockBuildbotQueue):
3831         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
3832         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
3833         (MockBuildbotQueueView):
3834         (MockBuildbotQueueView.prototype._latestProductiveIteration):
3835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
3836         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
3837         (MockTrac):
3838         (MockTrac.prototype.get oldestRecordedRevisionNumber):
3839         (MockTrac.prototype.get latestRecordedRevisionNumber):
3840         (MockTrac.prototype.loadMoreHistoricalData):
3841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
3842         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
3843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
3844         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
3845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
3846         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
3847         Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
3848         (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
3849         * Scripts/run-dashboard-tests: Added.
3850
3851 2016-04-06  ChangSeok Oh  <changseok@webkit.org>
3852
3853         Unreviewed, Update my primary email address and expertise.
3854
3855         * Scripts/webkitpy/common/config/contributors.json:
3856
3857 2016-04-06  Jon Lee  <jonlee@apple.com>
3858
3859         Update the Animometer patch and plan files
3860         https://bugs.webkit.org/show_bug.cgi?id=156263
3861
3862         Reviewed by Ryosuke Niwa.
3863
3864         Measure the latest set of tests by updating the plan revision to r199134.
3865
3866         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
3867         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
3868         of the developer page.
3869
3870 2016-04-06  Saam barati  <sbarati@apple.com>
3871
3872         jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
3873         https://bugs.webkit.org/show_bug.cgi?id=156187
3874
3875         Reviewed by Keith Miller.
3876
3877         * Scripts/run-jsc-stress-tests:
3878
3879 2016-04-06  Alex Christensen  <achristensen@webkit.org>
3880
3881         Compile WebKitTestRunner with CMake on Mac
3882         https://bugs.webkit.org/show_bug.cgi?id=156310
3883
3884         Reviewed by Daniel Bates.
3885
3886         * CMakeLists.txt:
3887         * WebKitTestRunner/CMakeLists.txt:
3888         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3889         * WebKitTestRunner/PlatformEfl.cmake:
3890         * WebKitTestRunner/PlatformGTK.cmake:
3891         * WebKitTestRunner/PlatformMac.cmake: Added.
3892
3893 2016-04-05  Simon Fraser  <simon.fraser@apple.com>
3894
3895         Implement operator== and operator!= for Optional<>
3896         https://bugs.webkit.org/show_bug.cgi?id=156266
3897
3898         Reviewed by Anders Carlsson.
3899
3900         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3901         (TestWebKitAPI::TEST):
3902
3903 2016-04-05  Alex Christensen  <achristensen@webkit.org>
3904
3905         Make CMake-generated binaries on Mac able to run
3906         https://bugs.webkit.org/show_bug.cgi?id=156268
3907
3908         Reviewed by Daniel Bates.
3909
3910         * DumpRenderTree/CMakeLists.txt:
3911         * DumpRenderTree/PlatformMac.cmake:
3912         * DumpRenderTree/PlatformWin.cmake:
3913         * TestWebKitAPI/PlatformMac.cmake:
3914
3915 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3916
3917         [Fetch API] Add a runtime flag to fetch API and related constructs
3918         https://bugs.webkit.org/show_bug.cgi?id=156113
3919  
3920         Reviewed by Alex Christensen.
3921
3922         * DumpRenderTree/TestRunner.h:
3923         * DumpRenderTree/mac/DumpRenderTree.mm:
3924         (resetWebPreferencesToConsistentValues):
3925         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3926         (WTR::InjectedBundle::beginTesting):
3927         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3928         (WTR::TestRunner::setWebGL2Enabled):
3929         (WTR::TestRunner::setFetchAPIEnabled):
3930         (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
3931         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3932
3933 2016-04-05  Keith Miller  <keith_miller@apple.com>
3934
3935         Make Keith a reviewer!
3936         https://bugs.webkit.org/show_bug.cgi?id=156246
3937
3938         Reviewed by Mark Lam.
3939
3940         * Scripts/webkitpy/common/config/contributors.json:
3941
3942 2016-04-05  Antoine Quint  <graouts@apple.com>
3943
3944         [WebGL2] Allow enabling WebGL2 with a runtime flag
3945         https://bugs.webkit.org/show_bug.cgi?id=156166
3946         <rdar://problem/25526929>
3947
3948         Always enable WebGL2 during testing.
3949
3950         Reviewed by Dean Jackson.
3951
3952         * DumpRenderTree/mac/DumpRenderTree.mm:
3953         (resetWebPreferencesToConsistentValues):
3954         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3955         (WTR::InjectedBundle::beginTesting):
3956         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3957         (WTR::TestRunner::setWebGL2Enabled):
3958         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3959
3960 2016-04-04  Bill Ming  <mbbill@gmail.com>
3961
3962         [win] run-webkit-tests failed to launch DumpRenderTree
3963         https://bugs.webkit.org/show_bug.cgi?id=156150
3964
3965         Reviewed by Alex Christensen.
3966
3967         * Tools/Scripts/webkitpy/port/base.py:
3968
3969 2016-04-04  Bill Ming  <mbbill@gmail.com>
3970
3971         prepare-ChangeLog set endl incorrectly.
3972         https://bugs.webkit.org/show_bug.cgi?id=156151
3973
3974         Reviewed by Alex Christensen.
3975
3976         * Tools/Scripts/prepare-ChangeLog:
3977
3978 2016-04-03  Sam Weinig  <sam@webkit.org>
3979
3980         Add SPI to allow install script message handlers in isolated worlds
3981         https://bugs.webkit.org/show_bug.cgi?id=156153
3982
3983         Reviewed by Anders Carlsson.
3984
3985         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3986         Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
3987
3988 2016-04-04  Jiewen Tan  <jiewen_tan@apple.com>
3989
3990         Build fix for r198956.
3991
3992         Unreviewed.
3993
3994         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
3995         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3996         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3997         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3998
3999 2016-04-04  Bill Ming  <mbbill@gmail.com>
4000
4001         [win] prepare-ChangeLog should treat windows path differently.
4002         https://bugs.webkit.org/show_bug.cgi?id=156120
4003
4004         Reviewed by Brent Fulgham.
4005
4006         * Scripts/prepare-ChangeLog:
4007
4008 2016-04-04  Alejandro G. Castro  <alex@igalia.com>
4009
4010         REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
4011         https://bugs.webkit.org/show_bug.cgi?id=156164
4012
4013         Reviewed by Philippe Normand.
4014
4015         Enable the new WEB_RTC option by default for Gtk+.
4016
4017         * Scripts/webkitperl/FeatureList.pm:
4018
4019 2016-04-03  Dan Bernstein  <mitz@apple.com>
4020
4021         Use the correct value for the first nightly build with frameworks built for OS X 10.11.
4022
4023         * Scripts/bisect-builds:
4024         (makeNightlyList):
4025
4026 2016-04-03  Dan Bernstein  <mitz@apple.com>
4027
4028         Made bisect-builds work again.
4029
4030         Rubber-stamped by Sam Weinig.
4031
4032         * Scripts/bisect-builds:
4033         Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11.
4034
4035 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
4036
4037         Build fix for r198956.
4038
4039         Unreviewed.
4040
4041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4042         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm.
4043         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]):
4044         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]):
4045         (TEST):
4046         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
4047         (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]):
4048         (TestWebKitAPI::TEST):
4049
4050 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
4051
4052         WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs
4053         https://bugs.webkit.org/show_bug.cgi?id=155995
4054         <rdar://problem/14967004>
4055
4056         Reviewed by Andy Estes.
4057
4058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4059         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm:
4060         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
4061         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didStartProvisionalNavigation:]):
4062         (TEST):
4063         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Added.
4064         (literalURL):
4065         (-[LoadInvalidURLNavigationActionDelegate webView:didCommitNavigation:]):
4066         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
4067         (TestWebKitAPI::TEST):
4068         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html: Added.
4069         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: Added.
4070         (-[LoadInvalidURLWebFrameLoadDelegate webView:didCommitLoadForFrame:]):
4071         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
4072         (TestWebKitAPI::TEST):
4073
4074 2016-04-01  Brent Fulgham  <bfulgham@apple.com>
4075
4076         Confirm <a download> satisfies specification criteria
4077         https://bugs.webkit.org/show_bug.cgi?id=156057
4078
4079         Reviewed by Andy Estes.
4080
4081         Revise WebKitTestRunner:
4082         (1) Provide a download client delegate.
4083         (2) Teach WKTR to wait to finish a test until a download finishes.
4084         (3) Allow WKTR to notify the current TestRunner that it can finish.
4085
4086         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4087         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4088         (WTR::InjectedBundle::didReceiveMessageToPage): Update to recognize a new
4089         message "NotifyDownloadDone".
4090         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4091         (WTR::InjectedBundlePage::decidePolicyForNavigationAction): Handle 'download'
4092         attribute case.
4093         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4094         (WTR::TestRunner::waitUntilDownload): Added.
4095         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4096         (WTR::TestRunner::shouldFinishAfterDownload): Added.
4097         * WebKitTestRunner/TestController.cpp:
4098         (WTR::TestController::createWebViewWithOptions): Set up the download client.
4099         (WTR::TestController::downloadDidStart): Added.
4100         (WTR::TestController::decideDestinationWithSuggestedFilename): Added.
4101         (WTR::TestController::downloadDidFinish): Added.
4102         (WTR::TestController::downloadDidFail): Added.
4103         (WTR::TestController::downloadDidCancel): Added.
4104         * WebKitTestRunner/TestController.h:
4105         * WebKitTestRunner/TestInvocation.cpp:
4106         (WTR::TestInvocation::notifyDownloadDone): Added.
4107         * WebKitTestRunner/TestInvocation.h:
4108
4109 2016-04-01  Alex Christensen  <achristensen@webkit.org>
4110
4111         Compile DumpRenderTree with CMake on Mac
4112         https://bugs.webkit.org/show_bug.cgi?id=156088
4113
4114         Reviewed by Brent Fulgham.
4115
4116         * CMakeLists.txt:
4117         * DumpRenderTree/CMakeLists.txt:
4118         * DumpRenderTree/DefaultPolicyDelegate.m:
4119         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
4120         * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
4121         * DumpRenderTree/PlatformMac.cmake: Added.
4122         * DumpRenderTree/PlatformWin.cmake:
4123         * DumpRenderTree/mac/AppleScriptController.m:
4124         (convertAEDescToObject):
4125         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
4126         * DumpRenderTree/mac/LayoutTestHelper.m:
4127
4128 2016-03-31  Bill Ming  <mbbill@gmail.com>
4129
4130         https://bugs.webkit.org/show_bug.cgi?id=156094
4131         [Win] TestWebCore target build sometimes fail.
4132
4133         Reviewed by Alex Christensen.
4134
4135         * Tools/TestWebKitAPI/PlatformWin.cmake:
4136
4137 2016-03-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4138
4139         [EFL] Bump EFL version to 1.17.0
4140         https://bugs.webkit.org/show_bug.cgi?id=153008
4141
4142         Reviewed by Michael Catanzaro.
4143
4144         Original author is Csaba Osztrogonác  <ossy@webkit.org>
4145
4146         * efl/jhbuild.modules:
4147
4148 2016-03-31  Daniel Bates  <dabates@apple.com>
4149
4150         run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
4151         https://bugs.webkit.org/show_bug.cgi?id=156071
4152         <rdar://problem/25467827>
4153
4154         Reviewed by Brent Fulgham.
4155
4156         Fixes an issue where run-webkit-tests will fail to create the suffixed user's cache directory
4157         on non-Apple Internal machines with System Integrity Protection enabled because the OS only
4158         honors the suffix, specified by the environment variable DIRHELPER_USER_DIR_SUFFIX, in
4159         privileged processes. And python(1) does not have sufficient privileges. As a workaround for
4160         systems that have System Integrity Protection enabled we compute the path to the suffixed
4161         user's cache directory by hand.
4162
4163         Additionally, fix an issue where the user's cache directory created by run-webkit-test was
4164         never deleted on cessation of the test run.
4165
4166         * Scripts/webkitpy/port/driver.py:
4167         (Driver._start): Actually store the path to the user's cache directory in self._driver_user_cache_directory
4168         so that we can delete this directory on cessation of the test run.
4169         * Scripts/webkitpy/port/mac.py:
4170         (MacPort):
4171         (MacPort._path_to_user_cache_directory): Unset the environment variable DIRHELPER_USER_DIR_SUFFIX (if set),
4172         query the OS for the path to the user's cache directory and concatenate this path with the
4173         specified suffix.
4174
4175 2016-03-31  Jiewen Tan  <jiewen_tan@apple.com>
4176
4177         WebKit should set Original URL of a download request correctly
4178         https://bugs.webkit.org/show_bug.cgi?id=155914
4179         <rdar://problem/10473811>
4180
4181         Reviewed by Anders Carlsson.
4182
4183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4184         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
4185         (-[DownloadRequestOriginalURLDelegate initWithExpectOriginalURL:]):
4186         (-[DownloadRequestOriginalURLDelegate _downloadDidStart:]):
4187         (-[DownloadRequestOriginalURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4188         (TEST):
4189         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Added.
4190         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Added.
4191         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Added.
4192
4193 2016-03-30  Dewei Zhu  <dewei_zhu@apple.com>
4194
4195         Extend animometer timeout for slow CPUs.
4196         https://bugs.webkit.org/show_bug.cgi?id=156047
4197
4198         Reviewed by Ryosuke Niwa.
4199
4200         Extend animometer timeout to 30 minutes for slow device.
4201
4202         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
4203
4204 2016-03-30  Daniel Bates  <dabates@apple.com>
4205
4206         run-webkit-tests must create parent directory of user's cache directory before running tests
4207         https://bugs.webkit.org/show_bug.cgi?id=156009
4208         <rdar://problem/25442682>
4209
4210         Reviewed by Alexey Proskuryakov.
4211
4212         The script run-webkit-tests must create the parent directory of the user's cache directory
4213         before running tests because a WebKit2 child process expects that this directory exists
4214         when it starts.
4215
4216         The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
4217         user's temporary directory and user's cache directory via the environment variable
4218         DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
4219         as part of setting up the test environment. But run-webkit-tests does not create the user's
4220         cache directory. Therefore there is race between the time AppKit creates it and when the
4221         launched WebContent and Network processes query for the path to the user's cache directory
4222         such that the OS may return the empty string to the WebContent and Network processes if
4223         queried for this directory before AppKit creates it.
4224
4225         * Scripts/webkitpy/port/base.py:
4226         (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
4227         empty string. We will override this method for the OS X port to return the path to the
4228         user's cache directory with the specified suffix.
4229         (Port.remove_cache_directory): Deleted.
4230         * Scripts/webkitpy/port/driver.py:
4231         (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
4232         to the suffix to use for the user's temporary and cache directories and the path to the
4233         user's cache directory, respectively.
4234         (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
4235         to self._driver_user_directory_suffix.
4236         (Driver._start): Compute the user directory suffix and the path to the user's cache
4237         directory. Create the user's cache directory (if applicable).
4238         (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
4239         * Scripts/webkitpy/port/mac.py:
4240         (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
4241         (MacPort.remove_cache_directory): Deleted.
4242
4243 2016-03-29  Benjamin Poulain  <bpoulain@apple.com>
4244
4245         [WTF] Removing a smart pointer from HashTable issues two stores to the same location
4246         https://bugs.webkit.org/show_bug.cgi?id=155676
4247
4248         Reviewed by Darin Adler.
4249
4250         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4251         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4252
4253 2016-03-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
4254
4255         Add machine-readable results for JSC stress tests
4256         https://bugs.webkit.org/show_bug.cgi?id=155771
4257
4258         Reviewed by Darin Adler and Dean Johnson
4259
4260         Add an option to output JSC stress test results to a user-specified file in JSON format.
4261
4262         * Scripts/run-javascriptcore-tests:
4263         (runJSCStressTests): Add JSON output support
4264         (readAllLines): Remove trailing newline from the end of each item
4265
4266 2016-03-29  Alex Christensen  <achristensen@webkit.org>
4267
4268         Fix Windows build.
4269
4270         * TestWebKitAPI/PlatformWin.cmake:
4271
4272 2016-03-29  Timothy Hatcher  <timothy@apple.com>
4273
4274         Update WebKit nightly to have a red needle to better match Safari
4275
4276         https://bugs.webkit.org/show_bug.cgi?id=155983
4277
4278         Reviewed by Joseph Pecoraro.
4279
4280         * WebKitLauncher/webkit.icns:
4281
4282 2016-03-28  Joanmarie Diggs  <jdiggs@igalia.com>
4283
4284         Adding myself as a reviewer.
4285
4286         Unreviewed.
4287
4288         * Scripts/webkitpy/common/config/contributors.json:
4289
4290 2016-03-25  Dewei Zhu  <dewei_zhu@apple.com>
4291
4292         Dromaeo patch used by run-benchmark should not include an invalid address.
4293         https://bugs.webkit.org/show_bug.cgi?id=155910
4294
4295         Reviewed by Ryosuke Niwa.
4296
4297         Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
4298         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
4299
4300 2016-03-25  Daniel Bates  <dabates@apple.com>
4301
4302         Add WebKitSystemInterface for iOS 9.3
4303         https://bugs.webkit.org/show_bug.cgi?id=155893
4304
4305         Rubber-stamped by Alexey Proskuryakov.
4306
4307         * Scripts/copy-webkitlibraries-to-product-directory:
4308
4309 2016-03-25  Daniel Bates  <dabates@apple.com>
4310
4311         Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
4312         in copy-webkitlibraries-to-product-directory
4313         https://bugs.webkit.org/show_bug.cgi?id=155869
4314
4315         Reviewed by Alexey Proskuryakov.
4316
4317         It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
4318         webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
4319         line argument.
4320
4321         * Scripts/copy-webkitlibraries-to-product-directory:
4322
4323 2016-03-25  Konstantin Tokarev  <annulen@yandex.ru>
4324
4325         Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
4326         https://bugs.webkit.org/show_bug.cgi?id=155882
4327
4328         Reviewed by Michael Catanzaro.
4329
4330