[Web Animations] Turn Web Animations with CSS integration on for test runners
[WebKit-https.git] / Tools / ChangeLog
1 2018-05-18  Antoine Quint  <graouts@apple.com>
2
3         [Web Animations] Turn Web Animations with CSS integration on for test runners
4         https://bugs.webkit.org/show_bug.cgi?id=184819
5         <rdar://problem/39597337>
6
7         Reviewed by Jon Lee.
8
9         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
10         integration flag on.
11
12         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
13         comment directly at the top of the file since test runners now set the flag on by default
14         and a dedicated directory exists for tests that need to run with this flag off.
15
16         * DumpRenderTree/TestOptions.cpp:
17         (TestOptions::TestOptions):
18         * DumpRenderTree/TestOptions.h:
19         * DumpRenderTree/mac/DumpRenderTree.mm:
20         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
21         (runTest):
22         * WebKitTestRunner/TestController.cpp:
23         (WTR::TestController::resetPreferencesToConsistentValues):
24         (WTR::updateTestOptionsFromTestHeader):
25         * WebKitTestRunner/TestOptions.cpp:
26         (WTR::isLegacyAnimationEngineTestPath):
27         (WTR::TestOptions::TestOptions):
28         * WebKitTestRunner/TestOptions.h:
29
30 2018-05-17  Nan Wang  <n_wang@apple.com>
31
32         AX: [macOS] Expose the primary screen height through AX API
33         https://bugs.webkit.org/show_bug.cgi?id=185742
34
35         Reviewed by Chris Fleizach.
36
37         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
38         (attributesOfElement):
39         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
40         (WTR::attributesOfElement):
41
42 2018-05-17  Commit Queue  <commit-queue@webkit.org>
43
44         Unreviewed, rolling out r231912.
45         https://bugs.webkit.org/show_bug.cgi?id=185750
46
47         It is prompting the user when there is no WPT changes
48         (Requested by bmac on #webkit).
49
50         Reverted changeset:
51
52         "Export changes to web-platform-test as part of the webkit-
53         patch upload workflow"
54         https://bugs.webkit.org/show_bug.cgi?id=184914
55         https://trac.webkit.org/changeset/231912
56
57 2018-05-17  Valerie R Young  <valerie@bocoup.com>
58
59         test262/Runner.pm: expand $INC to find webkitdirs.pm
60         https://bugs.webkit.org/show_bug.cgi?id=185739
61
62         Reviewed by Michael Saboff.
63
64         * Scripts/test262/Runner.pm:
65         (getBuildPath):
66
67 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
68
69         [WPE] Implement and enable FULLSCREEN_API
70         https://bugs.webkit.org/show_bug.cgi?id=185676
71
72         Reviewed by Žan Doberšek.
73
74         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
75         (testWebViewFullScreen):
76
77 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
78
79         Export changes to web-platform-test as part of the webkit-patch upload workflow
80         https://bugs.webkit.org/show_bug.cgi?id=184914
81
82         Reviewed by Youenn Fablet.
83
84         * Scripts/webkitpy/tool/commands/upload.py:
85         (Upload):
86         (CreateBug.execute):
87         (WPTChangeExport):
88         * Scripts/webkitpy/tool/steps/__init__.py:
89         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
90         (WPTChangeExport):
91         (WPTChangeExport.options):
92         (WPTChangeExport.run):
93         * Scripts/webkitpy/w3c/common.py:
94         * Scripts/webkitpy/w3c/test_exporter.py:
95         (WebPlatformTestExporter):
96         (WebPlatformTestExporter.__init__):
97         (WebPlatformTestExporter.username):
98         (WebPlatformTestExporter.token):
99         (WebPlatformTestExporter._github):
100         (WebPlatformTestExporter._wpt_fork_branch_github_url):
101         (WebPlatformTestExporter._wpt_fork_remote):
102         (WebPlatformTestExporter._wpt_fork_push_url):
103         (WebPlatformTestExporter._git):
104         (WebPlatformTestExporter._branch_name):
105         (WebPlatformTestExporter._public_branch_name):
106         (WebPlatformTestExporter.has_wpt_changes):
107         (WebPlatformTestExporter._create_patch):
108         (WebPlatformTestExporter.create_git_patch):
109         (WebPlatformTestExporter._prompt_for_token):
110         (WebPlatformTestExporter._prompt_for_username):
111         (WebPlatformTestExporter._ensure_username_and_token):
112         (WebPlatformTestExporter._validate_and_save_token):
113         (WebPlatformTestExporter.push_to_wpt_fork):
114         (WebPlatformTestExporter.make_pull_request):
115         (WebPlatformTestExporter.delete_local_branch):
116         (parse_args):
117         (TestExporter): Deleted.
118         (TestExporter.__init__): Deleted.
119         (TestExporter._ensure_wpt_repository): Deleted.
120         (TestExporter._fetch_wpt_repository): Deleted.
121         (TestExporter._ensure_new_branch_name): Deleted.
122         (TestExporter.download_and_commit_patch): Deleted.
123         (TestExporter.clean): Deleted.
124         (TestExporter.create_branch_with_patch): Deleted.
125         (TestExporter.push_to_wpt_fork): Deleted.
126         (TestExporter.make_pull_request): Deleted.
127         (TestExporter.create_wpt_pull_request): Deleted.
128         (TestExporter.delete_local_branch): Deleted.
129         (TestExporter.create_git_patch): Deleted.
130         (TestExporter.create_upload_remote_if_needed): Deleted.
131         (TestExporter.do_export): Deleted.
132         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
133         (TestExporterTest.test_export):
134         (TestExporterTest.test_export_with_specific_branch):
135         (TestExporterTest):
136         (TestExporterTest.test_export_interactive_mode):
137         (TestExporterTest.test_export_invalid_token):
138         (TestExporterTest.test_export_wrong_token):
139
140 2018-05-17  Valerie R Young  <valerie@bocoup.com>
141
142         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
143         https://bugs.webkit.org/show_bug.cgi?id=185650
144
145         Reviewed by Michael Saboff.
146
147         First, use jsc from CLI arg, then try to use webkit-build-directory,
148         if that doesn't work, look for jsc in the $PATH
149
150         * Scripts/test262/Runner.pm:
151         (processCLI):
152         (getBuildPath):
153         (runTest):
154
155 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
156
157         Test262-Runner: Adds a --timeout option
158         https://bugs.webkit.org/show_bug.cgi?id=185696
159
160         Reviewed by Michael Saboff.
161
162         The timeout option is used to set a timeout execution in ms for each test run in JSC.
163         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
164         * Scripts/test262/Runner.pm:
165         (processCLI):
166         (runTest):
167
168 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
169
170         Test262-Runner: Set timer for each test run
171         https://bugs.webkit.org/show_bug.cgi?id=185692
172
173         Reviewed by Michael Saboff.
174
175         Sets a high resolution timer for each execution call of JSC, reporting
176         the time in the results report to allow identifying slow tests.
177         * Scripts/test262/Runner.pm:
178         (main):
179         (processFile):
180         (runTest):
181         (processResult):
182
183 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
184
185         Add support for Intl NumberFormat formatToParts
186         https://bugs.webkit.org/show_bug.cgi?id=185375
187
188         Reviewed by Yusuke Suzuki.
189
190         Add flag for NumberFormat formatToParts.
191
192         * Scripts/webkitperl/FeatureList.pm:
193         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
194
195 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
196
197         [Win] Use C++17 in MSVC
198         https://bugs.webkit.org/show_bug.cgi?id=185232
199
200         Reviewed by Alex Christensen.
201
202         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
203         conflicts with ::byte defined in Windows' header.
204
205         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
206         (WindowedPluginTest::WindowedPluginTest):
207         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
208         (logEventProc):
209         (stringEvent):
210         (AccessibilityController::winNotificationReceived):
211         * DumpRenderTree/win/TextInputController.cpp:
212         (markedRangeCallback):
213         (firstRectForCharacterRangeCallback):
214         (selectedRangeCallback):
215         * DumpRenderTree/win/TextInputController.h:
216         * DumpRenderTree/win/TextInputControllerWin.cpp:
217         (TextInputController::markedRange):
218         (TextInputController::firstRectForCharacterRange):
219         (TextInputController::selectedRange):
220
221 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
222
223         Session cookies aren't reliably set when using default WKWebSiteDataStore
224         https://bugs.webkit.org/show_bug.cgi?id=185624
225         <rdar://problem/39111626>
226
227         Reviewed by Geoffrey Garen.
228
229         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
230
231         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
232         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
233         (TEST):
234
235 2018-05-16  Valerie R Young  <valerie@bocoup.com>
236
237         test262/Runner.pm: save to supplied expectation file if supplied
238         https://bugs.webkit.org/show_bug.cgi?id=185660
239
240         Reviewed by Michael Saboff.
241
242         * Scripts/test262/Runner.pm:
243         (processCLI):
244         (main):
245
246 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
247
248         Unreviewed, rolling out r231763.
249
250         The test added with this change is failing an assertion.
251
252         Reverted changeset:
253
254         "NSEvent event trackers don't work from WebKitTestRunner"
255         https://bugs.webkit.org/show_bug.cgi?id=185383
256         https://trac.webkit.org/changeset/231763
257
258 2018-05-15  David Kilzer  <ddkilzer@apple.com>
259
260         TestWebKitAPI: Fix warnings found by new clang compiler
261         <https://webkit.org/b/185631>
262
263         Reviewed by Michael Catanzaro.
264
265         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
266         (TestWebKitAPI::TEST):
267         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
268         (TestWebKitAPI::TEST):
269         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
270         (TestWebKitAPI::TEST):
271         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
272         (TestWebKitAPI::TEST):
273         - Add #pragma statements to ignore the new
274           -Wself-assign-overloaded warning and to ignore
275           this as an unknown warning on older clang versions.  We want
276           to keep these self assigments as this code is designed to test
277           that use case.
278
279         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
280         (TestWebKitAPI::didFindStringMatches):
281         - Replace the "rect = rect;" statement that was used to avoid an
282           unused variable warning with two expectations.
283
284         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
285         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
286         - Switch from -integerValue to -unsignedIntegerValue when
287           comparing against _WKRectEdgeAll since it's an enum declared
288           as an NSUInteger.
289
290 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
291
292         Unreviewed, rolling out r230749
293
294         This did not work as desired.
295
296         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
297         (TestWebKitAPI::TEST):
298
299 2018-05-15  Antoine Quint  <graouts@apple.com>
300
301         [Web Animations] Expose Web Animations CSS integration as an experimental feature
302         https://bugs.webkit.org/show_bug.cgi?id=185647
303
304         Reviewed by Dean Jackson.
305
306         Rename the Web Animations CSS integration flag.
307
308         * DumpRenderTree/TestOptions.cpp:
309         (TestOptions::TestOptions):
310         * DumpRenderTree/TestOptions.h:
311         * DumpRenderTree/mac/DumpRenderTree.mm:
312         (setWebPreferencesForTestOptions):
313         * WebKitTestRunner/TestController.cpp:
314         (WTR::TestController::resetPreferencesToConsistentValues):
315         (WTR::updateTestOptionsFromTestHeader):
316         * WebKitTestRunner/TestOptions.h:
317         (WTR::TestOptions::hasSameInitializationOptions const):
318
319 2018-05-14  Brady Eidson  <beidson@apple.com>
320
321         Add an API test to guard against regressions while re-entering setDefersLoading:.
322         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
323
324         Reviewed by Chris Dumez.
325
326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
327         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
328         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
329         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
330         (-[DefersScheme initWithBytes:]):
331         (-[DefersScheme webView:startURLSchemeTask:]):
332         (-[DefersScheme webView:stopURLSchemeTask:]):
333         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
334         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
335         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
336         (-[DoubleDefersLoadingPlugIn dealloc]):
337
338 2018-05-14  Daniel Bates  <dabates@apple.com>
339
340         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
341         https://bugs.webkit.org/show_bug.cgi?id=185599
342         <rdar://problem/22493890>
343
344         Reviewed by Simon Fraser.
345
346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
348         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
349         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
350         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
351         (TestWebKitAPI::TEST):
352         * TestWebKitAPI/ios/set-timeout-function.html: Added.
353
354 2018-05-14  Valerie R Young  <valerie@bocoup.com>
355
356         test262/Runner.pm: small bugs in CLI and error codes
357         https://bugs.webkit.org/show_bug.cgi?id=185629
358
359         Reviewed by Michael Saboff.
360
361         Fix two commandline args with use '-f', correct
362         error code of failures.
363
364         * Scripts/test262/Runner.pm:
365         (processCLI):
366         (main):
367
368 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
369
370         Disable API tests that time out after pointer poisioning was disabled.
371         https://bugs.webkit.org/show_bug.cgi?id=185586
372
373         Unreviewed test gardening.
374
375         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
376         (TestWebKitAPI::TEST):
377         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
378         (TestWebKitAPI::TEST):
379         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
380         (TestWebKitAPI::TEST):
381         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
382         (TestWebKitAPI::TEST):
383
384 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
385
386         Test262-Runner: Fix RegExp for capturing tests metadata"
387         https://bugs.webkit.org/show_bug.cgi?id=185622
388
389         Reviewed by Michael Saboff.
390
391         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
392         both LF and CRLF forms.
393
394         The fix also allows the runner to capture the proper results from two specific files using CR and
395         CRLF line terminators. They are updated in the expectations file.
396         * Scripts/test262/Runner.pm:
397         (parseData):
398
399 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
400
401         NSEvent event trackers don't work from WebKitTestRunner
402         https://bugs.webkit.org/show_bug.cgi?id=185383
403         rdar://problem/40025045
404
405         Reviewed by Simon Fraser.
406
407         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
408         NSEvent swipe tracking is used for webkit swipe navigation.
409
410         * WebKitTestRunner/mac/EventSenderProxy.mm:
411         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
412
413 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
414
415         Test262 Runner should search for the Debug JSC by default
416         https://bugs.webkit.org/show_bug.cgi?id=185562
417
418         Reviewed by Michael Saboff.
419
420         The Test262 Runner is now searching for the Debug build of JSC by
421         default, not the Release build.
422
423         This fix allows a similar call from the previous runner, making
424         it compatible with the current build bot configuration parameters.
425
426         This patch also adds some minor improvements the verbose mode output.
427
428         * Scripts/test262/Runner.pm:
429         (processCLI):
430         (main):
431         (getBuildPath):
432         (processResult):
433
434 2018-05-11  Charles Vazac  <cvazac@gmail.com>
435
436         Runtime feature flag for Server-Timing
437         https://bugs.webkit.org/show_bug.cgi?id=184758
438
439         Reviewed by Youenn Fablet.
440
441         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
442         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
443
444 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
445
446         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
447         https://bugs.webkit.org/show_bug.cgi?id=185418
448
449         Reviewed by Alex Christensen.
450
451         All WK1 related code should be moved into MiniBrowser for the preparation
452         of Bug 184770.
453
454         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
455
456         * MiniBrowser/win/Common.cpp:
457         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
458         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
459         * MiniBrowser/win/Common.h: Added.
460         * MiniBrowser/win/MiniBrowser.cpp:
461         (MiniBrowser::init): Moved the initilization code from wWinMain.
462         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
463         * MiniBrowser/win/MiniBrowser.h:
464         (MiniBrowser::setCacheFolder): Changed to a private method.
465         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
466         * MiniBrowser/win/WinMain.cpp:
467         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
468
469 2018-05-11  Brady Eidson  <beidson@apple.com>
470
471         Make sure history navigations reuse the existing process when necessary.
472         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
473
474         Reviewed by Ryosuke Niwa.
475
476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
477
478 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
479
480         [JSC][GLIB] Add introspectable alternatives to functions using vargars
481         https://bugs.webkit.org/show_bug.cgi?id=185508
482
483         Reviewed by Michael Catanzaro.
484
485         Add test cases for the new API.
486
487         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
488         (testJSCFunction):
489         (testJSCObject):
490
491 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
492
493         [Build Bot] Restore configuration options to the Test262 Runner
494
495         During the switch from the previous Test262 runner to the new one,
496         a call for an extra configurations options got removed.
497
498         This call is important to inform the script to find the debug or
499         release build of JSC. It's being restored in this patch.
500
501         https://bugs.webkit.org/show_bug.cgi?id=185513
502
503         Reviewed by Yusuke Suzuki.
504
505         * BuildSlaveSupport/build.webkit.org-config/steps.py:
506         (RunTest262Tests):
507
508 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
509
510         REGRESSION (r230998): Cannot stream API test output
511         https://bugs.webkit.org/show_bug.cgi?id=185090
512
513         Reviewed by Ryosuke Niwa.
514
515         Change run-api-tests so that the stdout and stderr of a test will be printed
516         before it's result. If -v is passed, the output of single test runs will be
517         streamed. 
518
519         * Scripts/webkitpy/api_tests/run_api_tests.py:
520         (run): Use print_timestamps flag.
521         (parse_args): Add timestamps option to print timestamps in the log.
522         * Scripts/webkitpy/api_tests/runner.py:
523         (Runner): Add running status.
524         (Runner.__init__): Add number of workers and a flag to detect if a newline
525         is needed at the beginning of a log line.
526         (Runner.run): Turn off most logging coming from server process since it is
527         not constructive for API tests.
528         (Runner.handle): Add new log message to stream stdout and stderr instead of
529         caching values until the test run finished.
530         (_Worker._run_single_test): Log stdout and stderr in real time.
531         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
532         the test.
533         (_Worker.post): Provide a post with explicitly enumerated argument names.
534         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
535         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
536         (MeteredStream.write): Allow for verbose logging without timestamps.
537         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
538         (RegularTest): Add print_timestamps flag.
539         (RegularTest.setUp):
540         (RegularTest.test_logging_not_included):
541         (VerboseTest.test_log_args):
542         (VerboseWithOutTimestamp):
543         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
544
545 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
546
547         build-webkit can erroneously warn about Xcode being too old
548         https://bugs.webkit.org/show_bug.cgi?id=185533
549
550         Reviewed by Dan Bernstein.
551
552         Don't assume the version number is always a single digit.
553
554         * Scripts/webkitdirs.pm:
555         (determineXcodeVersion):
556
557 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
558
559         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
560         https://bugs.webkit.org/show_bug.cgi?id=185528
561
562         Reviewed by Lucas Forschler.
563
564         * BuildSlaveSupport/build.webkit.org-config/factories.py:
565         (TestFactory.__init__):
566         * BuildSlaveSupport/build.webkit.org-config/steps.py:
567         (InstallWinCairoDependencies):
568
569 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
570
571         Fix some -Wstring-op-truncation warnings
572         https://bugs.webkit.org/show_bug.cgi?id=185496
573
574         Reviewed by Alex Christensen.
575
576         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
577         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
578         set the last bucket to NUL.
579
580         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
581         (TestWebKitAPI::testAtomicStringNumber):
582         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
583         (TestWebKitAPI::testStringNumberFixedPrecision):
584         (TestWebKitAPI::testStringNumberFixedWidth):
585         (TestWebKitAPI::testStringNumber):
586
587 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
588
589         [Win][MiniBrowser] Add a separate WndProc for the layered window
590         https://bugs.webkit.org/show_bug.cgi?id=185460
591
592         Reviewed by Brent Fulgham.
593
594         All WK1 related code should be moved into MiniBrowser for the
595         preparation of Bug 184770.
596
597         The layered window was using WndProc of the main window. The
598         layered window is specific only for WK1. the main window will be
599         shared among WK1 and WK2.
600
601         This change add a new WndProc for the layer window.
602
603         * MiniBrowser/win/Common.cpp:
604         (WndProc): Removed code for the layered windows.
605         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
606         * MiniBrowser/win/MiniBrowser.cpp:
607         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
608         (viewWndProc): New WndProc for the layered windows.
609         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
610         * MiniBrowser/win/MiniBrowser.h:
611         (MiniBrowser::hwnd):
612         * MiniBrowser/win/WinMain.cpp:
613         (wWinMain): Added m_viewWnd.
614
615 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
616
617         Support --verbose in run-javascriptcore-tests
618         https://bugs.webkit.org/show_bug.cgi?id=185492
619
620         Reviewed by Daniel Bates.
621
622         * Scripts/run-javascriptcore-tests:
623         (runJSCStressTests):
624
625 2018-05-10  Valerie R Young  <valerie@bocoup.com>
626
627         test262/Runner.pm: --failing-files uses results file not expectations
628         https://bugs.webkit.org/show_bug.cgi?id=185395
629
630         Reviewed by Michael Saboff.
631
632         --failing-files arg now uses results file to find failing tests
633         to rerun. It will look in the test262-results directory from whereever
634         the script is run, or a results.yaml file can be supplied via command
635         line argument.
636         --expectations arg added for suppling expectation file.
637
638         * Scripts/test262/Runner.pm:
639         (processCLI):
640         (main):
641         (loadImportFile):
642         (findAllFailing):
643
644 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
645
646         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
647         https://bugs.webkit.org/show_bug.cgi?id=185506
648
649         Reviewed by Philippe Normand.
650
651         Useful for testing and debugging.
652
653         * MiniBrowser/gtk/main.c:
654         (main):
655
656 2018-05-09  Chris Dumez  <cdumez@apple.com>
657
658         Unreviewed Windows build fix after r231622.
659
660         * DumpRenderTree/win/DumpRenderTree.cpp:
661         (enableExperimentalFeatures):
662
663 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
664
665         Update WebKit.WebsiteDataStoreCustomPaths after r231536
666         https://bugs.webkit.org/show_bug.cgi?id=185486
667         <rdar://problem/37214391>
668
669         Reviewed by Chris Dumez.
670
671         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
672
673         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
674         (TEST):
675
676 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
677
678         Test262-Runner: Improve the verbose output
679         https://bugs.webkit.org/show_bug.cgi?id=185491
680
681         Reviewed by Michael Saboff.
682
683         * Scripts/test262/Import.pm:
684         (transferFiles):
685         * Scripts/test262/Runner.pm:
686         (processResult):
687
688 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
689
690         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
691         https://bugs.webkit.org/show_bug.cgi?id=185488
692
693         Reviewed by Michael Saboff.
694
695         * Scripts/test262/Runner.pm:
696         (processCLI):
697         (getBuildPath):
698         (runTest):
699
700 2018-05-09  Richard Houle  <rhoule@apple.com>
701
702         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
703         https://bugs.webkit.org/show_bug.cgi?id=185260
704         <rdar://problem/39290394>
705
706         Reviewed by Tim Horton.
707
708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
709         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
710         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
711         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
712         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
713         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
714
715 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
716
717         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
718         https://bugs.webkit.org/show_bug.cgi?id=185481
719
720         Reviewed by Philippe Normand.
721
722         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
723
724         * Scripts/webkitpy/port/gtk.py:
725         (GtkPort.setup_environ_for_server):
726
727 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
728
729         Set build.webkit.org to use the new Test262-runner
730         https://bugs.webkit.org/show_bug.cgi?id=184933
731
732         Reviewed by Aakash Jain.
733
734         * BuildSlaveSupport/build.webkit.org-config/steps.py:
735         (RunTest262Tests):
736         (RunTest262Tests.countFailures):
737         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
738
739 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
740
741         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
742         https://bugs.webkit.org/show_bug.cgi?id=185461
743
744         Reviewed by Michael Catanzaro.
745
746         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
747
748         * gtk/jhbuild.modules:
749
750 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
751
752         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
753
754         * wpe/manifest.txt.in: Distribute the NEWS.
755
756 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
757
758         [WPE] Build cleanly with GCC 8 and ICU 60
759         https://bugs.webkit.org/show_bug.cgi?id=185462
760
761         Reviewed by Carlos Alberto Lopez Perez.
762
763         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
764         sure why this was never noticed until now or why the bots are OK.
765         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
766         * gtk/patches/glib-cast-function-type.patch: Added.
767         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
768         * wpe/patches/glib-cast-function-type.patch: Added.
769
770 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
771
772         [JSC][GTK][JSCONLY] Use capstone disassembler
773         https://bugs.webkit.org/show_bug.cgi?id=185283
774
775         Reviewed by Michael Catanzaro.
776
777         * gtk/manifest.txt.in:
778         * wpe/manifest.txt.in:
779
780 2018-05-09  Antti Koivisto  <antti@apple.com>
781
782         Add OptionSet::operator& and operator bool
783         https://bugs.webkit.org/show_bug.cgi?id=185306
784
785         Reviewed by Anders Carlsson.
786
787         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
788         (TestWebKitAPI::TEST):
789
790 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
791
792         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
793         https://bugs.webkit.org/show_bug.cgi?id=185340
794
795         Reviewed by Tim Horton.
796
797         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
798         non-empty text in a contenteditable.
799
800         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
801         (TestWebKitAPI::TEST):
802
803 2018-05-08  Valerie R Young  <valerie@bocoup.com>
804
805         test262/Runner.pm: create results dir for results of test262 run
806         https://bugs.webkit.org/show_bug.cgi?id=185392
807
808         Reviewed by Michael Saboff.
809
810         New directory test262-results created from where ever script is
811         called.
812
813         * Scripts/test262/Runner.pm:
814         (processCLI):
815
816 2018-05-08  Valerie R Young  <valerie@bocoup.com>
817
818         test262/Runner.pm: lower number of processes per core
819         https://bugs.webkit.org/show_bug.cgi?id=185426
820
821         Reviewed by Michael Saboff.
822
823         * Scripts/test262/Runner.pm:
824         (getProcesses):
825
826 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
827
828         Test262-Runner: Add base Perl UnicodeData
829         https://bugs.webkit.org/show_bug.cgi?id=185444
830
831         Reviewed by Michael Saboff.
832
833         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
834         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
835
836 2018-05-08  Daniel Bates  <dabates@apple.com>
837
838         Add tests to ensure that the Strong Password appearance is removed on form reset
839         https://bugs.webkit.org/show_bug.cgi?id=185440
840
841         Reviewed by Ryosuke Niwa.
842
843         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
844         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
845         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
846         (TEST):
847
848 2018-05-08  Daniel Bates  <dabates@apple.com>
849
850         Resign Strong Password appearance when text field value changes
851         https://bugs.webkit.org/show_bug.cgi?id=185433
852         <rdar://problem/39958508>
853
854         Reviewed by Ryosuke Niwa.
855
856         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
857         when the field has the Strong Password button and its value changes.
858
859         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
860         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
861         (TEST):
862
863 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
864
865         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
866         https://bugs.webkit.org/show_bug.cgi?id=185365
867
868         Reviewed by Saam Barati.
869         
870         Make it possible to measure compile times.
871         
872         Rolling back in after fixing cloop builds.
873
874         * Scripts/run-jsc-benchmarks:
875
876 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
877
878         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
879         https://bugs.webkit.org/show_bug.cgi?id=185414
880
881         Reviewed by Tim Horton.
882
883         Adjust a test expectation to check that the resulting DOM contains an attachment element,
884         anchor element, and another attachment element in that order. This ensures that the test
885         still passes, even after the anchor element is followed by a line break.
886
887         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
888         (TestWebKitAPI::TEST):
889
890 2018-05-08  Commit Queue  <commit-queue@webkit.org>
891
892         Unreviewed, rolling out r231491.
893         https://bugs.webkit.org/show_bug.cgi?id=185434
894
895         Setting the Created key on a cookie does not work yet, due a
896         bug in CFNetwork (Requested by ggaren on #webkit).
897
898         Reverted changeset:
899
900         "[WKHTTPCookieStore getAllCookies] returns inconsistent
901         creation time"
902         https://bugs.webkit.org/show_bug.cgi?id=185041
903         https://trac.webkit.org/changeset/231491
904
905 2018-05-08  Valerie R Young  <valerie@bocoup.com>
906
907         test262/Runner.pm: move input files to JSTests/test262
908         https://bugs.webkit.org/show_bug.cgi?id=185389
909
910         Reviewed by Michael Saboff.
911
912         * Scripts/test262/Runner.pm:
913         (processCLI):
914
915 2018-05-08  Chris Dumez  <cdumez@apple.com>
916
917         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
918
919         * Scripts/webkitpy/performance_tests/perftest.py:
920         (PerfTest):
921
922 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
923
924         Unreviewed, rolling out r231468.
925
926         Broke the CLoop build
927
928         Reverted changeset:
929
930         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
931         any abstract values"
932         https://bugs.webkit.org/show_bug.cgi?id=185365
933         https://trac.webkit.org/changeset/231468
934
935 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
936
937         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
938         https://bugs.webkit.org/show_bug.cgi?id=185041
939         <rdar://problem/34684214>
940
941         Reviewed by Geoffrey Garen.
942
943         Add API test Coverage.
944
945         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
946         (TEST):
947
948 2018-05-08  Chris Dumez  <cdumez@apple.com>
949
950         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
951
952         * Scripts/webkitpy/performance_tests/perftest.py:
953         (PerfTest):
954
955 2018-05-08  Chris Dumez  <cdumez@apple.com>
956
957         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
958
959         * Scripts/webkitpy/performance_tests/perftest.py:
960         (PerfTest):
961
962 2018-05-07  Chris Dumez  <cdumez@apple.com>
963
964         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
965
966         * Scripts/webkitpy/performance_tests/perftest.py:
967         (PerfTest):
968
969 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
970
971         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
972         https://bugs.webkit.org/show_bug.cgi?id=185365
973
974         Reviewed by Saam Barati.
975         
976         Make it possible to measure compile times.
977
978         * Scripts/run-jsc-benchmarks:
979
980 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
981
982         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
983         https://bugs.webkit.org/show_bug.cgi?id=185390
984
985         Reviewed by Michael Saboff.
986
987         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
988
989 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
990
991         Check for com.apple.datamigrator before declaring simulators booted
992         https://bugs.webkit.org/show_bug.cgi?id=185315
993         <rdar://problem/39986261>
994
995         Reviewed by David Kilzer.
996
997         * Scripts/webkitdirs.pm:
998         (waitUntilProcessNotRunning): Wait until a process is not found.
999         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
1000         a simulator booted.
1001         * Scripts/webkitpy/common/system/executive_mock.py:
1002         (MockExecutive2.__init__): Define _running_pids.
1003         * Scripts/webkitpy/xcode/simulated_device.py:
1004         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
1005         declaring that devices have been booted, increase the timeout since data migration will frequently
1006         take longer than 60 seconds, especially with multiple simulators booting.
1007         (SimulatedDeviceManager.swap): Ditto.
1008         (SimulatedDeviceManager):
1009         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
1010         processes running.
1011
1012 2018-05-07  Daniel Bates  <dabates@apple.com>
1013
1014         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
1015         https://bugs.webkit.org/show_bug.cgi?id=185054
1016         <rdar://problem/39773209>
1017
1018         Reviewed by Ryosuke Niwa.
1019
1020         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
1021
1022         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
1023         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
1024         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
1025         tests for the port.
1026
1027         * Scripts/webkitpy/port/mac.py:
1028         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
1029         have Apple Additions.
1030         * Scripts/webkitpy/port/mac_unittest.py:
1031         (MacTest.test_factory_with_future_version): Added.
1032         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
1033         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
1034         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
1035         is absent.
1036
1037 2018-05-07  Brian Burg  <bburg@apple.com>
1038
1039         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1040         https://bugs.webkit.org/show_bug.cgi?id=184861
1041         <rdar://problem/39153768>
1042
1043         Reviewed by Timothy Hatcher.
1044
1045         Add a new test that checks whether a new process is used for navigation when
1046         an Inspector is shown. Also check that the behavior reverts to normal after
1047         the Inspector has been closed.
1048
1049         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1050
1051 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1052
1053         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
1054         https://bugs.webkit.org/show_bug.cgi?id=185289
1055         <rdar://problem/35756912>
1056
1057         Reviewed by Tim Horton and Darin Adler.
1058
1059         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
1060         sessions.
1061
1062         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1063         (TestWebKitAPI::TEST):
1064
1065 2018-05-04  Timothy Hatcher  <timothy@apple.com>
1066
1067         Deprecate legacy WebView and friends
1068         https://bugs.webkit.org/show_bug.cgi?id=185279
1069         rdar://problem/33268700
1070
1071         Reviewed by Tim Horton.
1072
1073         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
1074         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
1075
1076 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1077
1078         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
1079         https://bugs.webkit.org/show_bug.cgi?id=185314
1080
1081         Reviewed by Michael Saboff.
1082
1083         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
1084
1085 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
1086
1087         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
1088         https://bugs.webkit.org/show_bug.cgi?id=184196
1089         <rdar://problem/39054481>
1090
1091         Reviewed by Tim Horton.
1092
1093         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
1094         earlier than 11.3. Also re-enables these tests.
1095
1096         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1097         (TestWebKitAPI::TEST):
1098         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
1099         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
1100
1101 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
1102
1103         Text shaping in the simple path is flipped in the y direction
1104         https://bugs.webkit.org/show_bug.cgi?id=185062
1105         <rdar://problem/39778678>
1106
1107         Reviewed by Simon Fraser.
1108
1109         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
1110
1111         * Scripts/webkitpy/common/config/contributors.json:
1112
1113 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1114
1115         Test262-Runner: place the processCLI inside the main call
1116         https://bugs.webkit.org/show_bug.cgi?id=185304
1117
1118         Reviewed by Michael Saboff.
1119
1120         * Scripts/test262/Runner.pm:
1121         (main):
1122
1123 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1124
1125         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
1126         https://bugs.webkit.org/show_bug.cgi?id=174730
1127
1128         Reviewed by Michael Catanzaro.
1129
1130         Update unit tests to check that User-Agent header is included in HTTP download requests.
1131
1132         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1133         (testDownloadRemoteFile):
1134         (testWebViewDownloadURI):
1135         (testPolicyResponseDownload):
1136         (testPolicyResponseDownloadCancel):
1137         (testDownloadMIMEType):
1138         (testContextMenuDownloadActions):
1139
1140 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
1141
1142         [WinCairo] Test archive must use Python zipfile, just like build product.
1143         https://bugs.webkit.org/show_bug.cgi?id=185265
1144
1145         Reviewed by Per Arne Vollan.
1146
1147         * BuildSlaveSupport/test-result-archive:
1148         (archive_test_results):
1149         Copy over Win32-oriented archiving logic from built-product-archive.
1150
1151 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
1152
1153         cleanup modules usage for the Test262-Runner
1154         https://bugs.webkit.org/show_bug.cgi?id=185263
1155
1156         Reviewed by Michael Saboff.
1157
1158         * Scripts/test262-runner:
1159         * Scripts/test262/Runner.pm:
1160         (processCLI):
1161
1162 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1163
1164         test262/Runner.pm: minor fixes
1165         https://bugs.webkit.org/show_bug.cgi?id=185250
1166
1167         Reviewed by Michael Saboff.
1168
1169         Add comments, change output and fix bug: unintended interpolation
1170         of filename when running jsc.
1171
1172         * Scripts/test262/Runner.pm:
1173         (processCLI):
1174         (main):
1175         (runTest):
1176
1177 2018-05-03  Chris Dumez  <cdumez@apple.com>
1178
1179         Load hangs if the WebProcess fails to launch
1180         https://bugs.webkit.org/show_bug.cgi?id=185225
1181         <rdar://problem/38249058>
1182
1183         Reviewed by Geoff Garen.
1184
1185         Add API test coverage.
1186
1187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1188         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
1189         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
1190         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
1191         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1192         (TEST):
1193
1194 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
1195
1196         [WinCairo] Add JSC test bots
1197         https://bugs.webkit.org/show_bug.cgi?id=185234
1198
1199         Reviewed by Per Arne Vollan.
1200
1201         * BuildSlaveSupport/build.webkit.org-config/config.json:
1202         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1203         (RunJavaScriptCoreTests.start):
1204
1205 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1206
1207         WebKit should send fake macOS user agent to docs.google.com
1208         https://bugs.webkit.org/show_bug.cgi?id=185165
1209
1210         Reviewed by Carlos Garcia Campos.
1211
1212         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1213         (TestWebKitAPI::TEST):
1214
1215 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1216
1217         test262/Runner.pm: performance improvements
1218         https://bugs.webkit.org/show_bug.cgi?id=185202
1219
1220         Reviewed by Michael Saboff.
1221
1222         Batch the tests by the number of processes, and give each process
1223         a file to save results to to avoid threading. Do not parallelize
1224         when running small sets of tests.
1225
1226         * Scripts/test262/Runner.pm:
1227         (processCLI):
1228         (main):
1229         (processFile):
1230         (processResult):
1231
1232 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
1233
1234         Unreviewed, rolling out r231253.
1235
1236         The API test added with this change is crashing on the bots.
1237
1238         Reverted changeset:
1239
1240         "Web Inspector: opt out of process swap on navigation if a Web
1241         Inspector frontend is connected"
1242         https://bugs.webkit.org/show_bug.cgi?id=184861
1243         https://trac.webkit.org/changeset/231253
1244
1245 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1246
1247         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
1248         https://bugs.webkit.org/show_bug.cgi?id=183348
1249
1250         Reviewed by Michael Catanzaro.
1251
1252         Add a test case to reproduce the crash.
1253
1254         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1255         (testWebViewCloseQuickly):
1256         (beforeAll):
1257
1258 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
1259
1260         Can't copy and paste URLs that have no title into Mail (macOS)
1261         https://bugs.webkit.org/show_bug.cgi?id=185205
1262         <rdar://problem/36352406>
1263
1264         Reviewed by Tim Horton.
1265
1266         Added test to verify behavior when copying and pasting a URL without a title.
1267
1268         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1269         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1270         (TestWebKitAPI::TEST):
1271
1272 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1273
1274         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
1275         https://bugs.webkit.org/show_bug.cgi?id=184699
1276
1277         Unreviewed follow-up fix after r231230.
1278
1279         * Scripts/generate-jsc-bundle:
1280         (generate_wrapper_script): Quote the arguments passed to jsc.
1281
1282 2018-05-02  Brian Burg  <bburg@apple.com>
1283
1284         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1285         https://bugs.webkit.org/show_bug.cgi?id=184861
1286         <rdar://problem/39153768>
1287
1288         Reviewed by Ryosuke Niwa.
1289
1290         Add a new test that checks whether a new process is used for navigation when
1291         an Inspector is shown. Also check that the behavior reverts to normal after
1292         the Inspector has been closed.
1293
1294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1295
1296 2018-05-02  Valerie R Young  <valerie@bocoup.com>
1297
1298         test262/Runner.pm: save summary to file
1299         https://bugs.webkit.org/show_bug.cgi?id=185200
1300
1301         Reviewed by Michael Saboff.
1302
1303         * Scripts/test262/Runner.pm:
1304         (processCLI):
1305         (main):
1306         (summarizeResults):
1307
1308 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1309
1310         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
1311         https://bugs.webkit.org/show_bug.cgi?id=184699
1312
1313         Reviewed by Gustavo Noronha Silva.
1314
1315         This adds a new step for the GTK 64-bit release build bot and the
1316         GTK 32-bit release build&test bot.
1317
1318         This step will be run as one of the lasts ones (after the product
1319         is built) and will execute the script generate-jsc-bundle.
1320         This script will take care of creating a JSC bundle and uploading
1321         it to a server defined on a configuration file that has to be
1322         deployed on the bots with the required server data and credentials
1323         for this upload.
1324
1325         In this case, the built products should then be accessible at
1326         <https://webkitgtk.org/jsc-built-products>. But the implementation
1327         is not tied to any specific server. All the details about where
1328         to upload the file is done in configuration file that is kept
1329         private on each bot outside of the WebKit source tree.
1330
1331         The script also supports generating a JSC bundle locally and not
1332         uploading it anywhere. This is the default mode of running.
1333         The remote upload will only be activated if a --remote-config-file
1334         parameter is passed (which is done from the buildbot config)
1335
1336         * BuildSlaveSupport/build.webkit.org-config/config.json:
1337         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1338         (BuildFactory):
1339         (BuildFactory.__init__):
1340         (TestFactory):
1341         (TestFactory.__init__):
1342         (BuildAndGenerateJSCBundleFactory):
1343         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
1344         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1345         (GenerateJSCBundle):
1346         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1347         * Scripts/generate-jsc-bundle: Added.
1348         (ldd_get_libs_and_interpreter):
1349         (generate_readme):
1350         (generate_wrapper_script):
1351         (copy_and_remove_rpath):
1352         (createJSCBundle):
1353         (sha256sum):
1354         (uploadJSCBundle):
1355         (main):
1356
1357 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1358
1359         PSON: Make WebKitTestRunner work with process swap on navigation turned on
1360         https://bugs.webkit.org/show_bug.cgi?id=185111
1361
1362         Reviewed by Chris Dumez.
1363
1364         Add the basic support for running layout tests with process-swap-on-navigation turned on.
1365
1366         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
1367         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
1368
1369         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
1370         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
1371         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
1372         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
1373
1374         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1375         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
1376         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
1377         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
1378         beginTesting with BegingTestingMode::Resume when this boolean is set.
1379         (WTR::InjectedBundle::didReceiveMessageToPage):
1380         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
1381         bundle after a process swap on navigation.
1382         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1383         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1384         (WTR::InjectedBundlePage::dump):
1385         (WTR::InjectedBundlePage::frameDidChangeLocation):
1386         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1387         (WTR::TestRunner::TestRunner):
1388         (WTR::TestRunner::shouldDumpPixels const): Added.
1389         (WTR::TestRunner::setDumpPixels): Added.
1390         (WTR::TestRunner::dumpAsText):
1391         (WTR::TestRunner::whatToDump const): Added.
1392         (WTR::TestRunner::setWhatToDump): Added.
1393         (WTR::TestRunner::waitUntilDone):
1394         (WTR::TestRunner::setWaitUntilDone): Added.
1395         (WTR::TestRunner::shouldWaitUntilDone): Added.
1396         (WTR::TestRunner::notifyDone):
1397         (WTR::TestRunner::forceImmediateCompletion):
1398         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
1399         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
1400         (WTR::TestRunner::setAudioResult):
1401         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1402         (WTR::TestRunner::dumpChildFramesAsText):
1403         (WTR::TestRunner::dumpDOMAsWebArchive):
1404         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
1405         (WTR::TestRunner::whatToDump const): Moved to cpp.
1406         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
1407         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
1408         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
1409         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
1410         * WebKitTestRunner/TestInvocation.cpp:
1411         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
1412         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
1413         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
1414         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
1415         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
1416         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
1417         started as a result of a process swap on navigation (m_startedTesting is true).
1418         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
1419         support initializing the injected bundle in a process swapped after navigation and set/get messages for
1420         the states which must persist across process swaps within a test.
1421         * WebKitTestRunner/TestInvocation.h:
1422         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1423         * Tools/WebKitTestRunner/WhatToDump.h:
1424         (WTR::WhatToDump): Added.
1425
1426 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
1427
1428         Auto save the results for Test262
1429         https://bugs.webkit.org/show_bug.cgi?id=184926
1430
1431         Reviewed by Michael Saboff.
1432
1433         * Scripts/test262/Runner.pm:
1434         (processCLI):
1435         (main):
1436         (parseError):
1437         (processResult):
1438         (summarizeResults):
1439         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
1440
1441 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
1442
1443         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
1444         https://bugs.webkit.org/show_bug.cgi?id=185164
1445
1446         Reviewed by David Kilzer.
1447
1448         * Scripts/webkitpy/common/system/executive.py:
1449         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
1450         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
1451
1452 2018-05-01  Chris Dumez  <cdumez@apple.com>
1453
1454         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
1455         https://bugs.webkit.org/show_bug.cgi?id=184918
1456         <rdar://problem/39705516>
1457
1458         Reviewed by Wenson Hsieh.
1459
1460         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
1461         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
1462         asynchronously because we ask the client if it is OK to do the load and the policy
1463         delegates are asynchronous nowadays.
1464
1465         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1466         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
1467         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1468         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1469         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
1470         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
1471         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
1472
1473 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
1474
1475         [WinCairo] Align buildbot test stages with AppleWin.
1476         https://bugs.webkit.org/show_bug.cgi?id=185094
1477
1478         Reviewed by Brent Fulgham.
1479
1480         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1481         (TestFactory.__init__):
1482         Do run API tests, don't run dashboard tests.
1483
1484         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1485         (RunUnitTests):
1486         Call run-api-tests with Python, not Perl (bugfix for r230998).
1487
1488         * Scripts/webkitpy/port/win.py:
1489         (WinPort.environment_for_api_tests):
1490         Retrieve necessary Windows environment variables.
1491
1492 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
1493
1494         [MediaStream] remove WK1 support
1495         https://bugs.webkit.org/show_bug.cgi?id=185136
1496
1497         Reviewed by Youenn Fablet.
1498
1499         * DumpRenderTree/mac/UIDelegate.mm:
1500         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
1501
1502 2018-05-01  Chris Dumez  <cdumez@apple.com>
1503
1504         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
1505         https://bugs.webkit.org/show_bug.cgi?id=185157
1506
1507         Reviewed by Geoffrey Garen.
1508
1509         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
1510         common configuration and should therefore be the configuration we test by default.
1511
1512         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1513         (WTR::InjectedBundlePage::decidePolicyForResponse):
1514
1515 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
1516
1517         WebAssembly: add support for stream APIs - JavaScript API
1518         https://bugs.webkit.org/show_bug.cgi?id=183442
1519
1520         Reviewed by Yusuke Suzuki and JF Bastien.
1521
1522         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1523
1524 2018-04-30  Mark Lam  <mark.lam@apple.com>
1525
1526         Apply PtrTags to the MetaAllocator and friends.
1527         https://bugs.webkit.org/show_bug.cgi?id=185110
1528         <rdar://problem/39533895>
1529
1530         Reviewed by Saam Barati.
1531
1532         Update the test to match MetaAllocator changes in WTF.
1533
1534         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1535         (TestWebKitAPI::TEST_F):
1536         (WTF::tagForPtr):
1537         (WTF::ptrTagName):
1538
1539 2018-04-30  Alex Christensen  <achristensen@webkit.org>
1540
1541         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
1542         https://bugs.webkit.org/show_bug.cgi?id=180955
1543
1544         Reviewed by Andy Estes.
1545
1546         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1547         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
1548         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
1549
1550 2018-04-30  JF Bastien  <jfbastien@apple.com>
1551
1552         Use some C++17 features
1553         https://bugs.webkit.org/show_bug.cgi?id=185135
1554
1555         Reviewed by Alex Christensen.
1556
1557         * DumpRenderTree/PlatformMac.cmake:
1558         * gtk/ycm_extra_conf.py:
1559         (FlagsForFile):
1560
1561 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1562
1563         Use WordLock instead of std::mutex for Threading
1564         https://bugs.webkit.org/show_bug.cgi?id=185121
1565
1566         Reviewed by Geoffrey Garen.
1567
1568         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1569         (TEST):
1570
1571 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1572
1573         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
1574         https://bugs.webkit.org/show_bug.cgi?id=185103
1575
1576         Reviewed by Carlos Garcia Campos.
1577
1578         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1579         (TestWebKitAPI::TEST):
1580
1581 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
1582
1583         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
1584         https://bugs.webkit.org/show_bug.cgi?id=185052
1585
1586         Reviewed by Geoffrey Garen.
1587
1588         Modified API test to provide correct test cases for HTTPOnly flag.
1589
1590         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1591         (TEST):
1592
1593 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
1594
1595         Token misspelled "tocken" in error message string
1596         https://bugs.webkit.org/show_bug.cgi?id=185030
1597
1598         Reviewed by Saam Barati.
1599
1600         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
1601
1602 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
1603
1604         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
1605         https://bugs.webkit.org/show_bug.cgi?id=185049
1606
1607         Reviewed by Keith Miller.
1608
1609         * Scripts/run-javascriptcore-tests:
1610         (runJSCStressTests):
1611         * Scripts/run-jsc-stress-tests:
1612
1613 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1614
1615         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
1616         https://bugs.webkit.org/show_bug.cgi?id=185066
1617
1618         Reviewed by Youenn Fablet.
1619
1620         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
1621         WebKit should not swap WebContent process in this case.
1622
1623         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1624         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1625         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1626
1627 2018-04-27  Nan Wang  <n_wang@apple.com>
1628
1629         AX: Accessibility needs to know which part of the content view is visible on iOS
1630         https://bugs.webkit.org/show_bug.cgi?id=185085
1631         <rdar://problem/39801363>
1632
1633         Reviewed by Chris Fleizach.
1634
1635         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1636         (WTR::AccessibilityUIElement::stringAttributeValue):
1637
1638 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1639
1640         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
1641         https://bugs.webkit.org/show_bug.cgi?id=185050
1642         <rdar://problem/39624038>
1643
1644         Reviewed by Tim Horton.
1645
1646         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
1647         tested by the layout test added in this patch.
1648
1649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1650         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
1651
1652 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1653
1654         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
1655         https://bugs.webkit.org/show_bug.cgi?id=185061
1656
1657         Reviewed by Aakash Jain.
1658
1659         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1660         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
1661         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
1662
1663 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1664
1665         Add release bots for WinCairo.
1666         https://bugs.webkit.org/show_bug.cgi?id=185042
1667
1668         Reviewed by Lucas Forschler.
1669
1670         * BuildSlaveSupport/build.webkit.org-config/config.json:
1671         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
1672
1673 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
1674
1675         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
1676         https://bugs.webkit.org/show_bug.cgi?id=184938
1677         <rdar://problem/34737395>
1678
1679         Reviewed by Geoffrey Garen.
1680
1681         Add API test coverage.
1682
1683         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1684         (TEST):
1685
1686 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1687
1688         WinCairo test bots should run JSC tests with options for Windows command prompt.
1689         https://bugs.webkit.org/show_bug.cgi?id=185019
1690
1691         Reviewed by Per Arne Vollan.
1692
1693         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1694         (RunJavaScriptCoreTests.start):
1695
1696 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1697
1698         WinCairo WKL Debug Test bot is not using DRT.
1699         https://bugs.webkit.org/show_bug.cgi?id=185009
1700
1701         Reviewed by Per Arne Vollan.
1702
1703         * BuildSlaveSupport/build.webkit.org-config/config.json:
1704
1705 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
1706
1707         Disable content filtering in minimal simulator mode
1708         https://bugs.webkit.org/show_bug.cgi?id=185027
1709         <rdar://problem/39736091>
1710
1711         Reviewed by Jer Noble.
1712
1713         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1714
1715 2018-04-26  Brady Eidson  <beidson@apple.com>
1716
1717         Add a setting for keeping around all processes and always reusing them per-origin.
1718         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
1719
1720         Reviewed by Andy Estes.
1721
1722         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1723
1724 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
1725
1726         [INTL] Implement Intl.PluralRules
1727         https://bugs.webkit.org/show_bug.cgi?id=184312
1728
1729         Reviewed by JF Bastien.
1730
1731         Added Intl.PluralRules feature flag.
1732
1733         * Scripts/webkitperl/FeatureList.pm:
1734         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1735
1736 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1737
1738         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
1739         https://bugs.webkit.org/show_bug.cgi?id=184643
1740
1741         Reviewed by Žan Doberšek.
1742
1743         Add missing INCLUDE_DIRS in many places.
1744
1745         Adapt to single-header WPE includes.
1746
1747         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
1748
1749         * TestWebKitAPI/PlatformWPE.cmake:
1750         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1751         (testWebViewWebBackend):
1752         * TestWebKitAPI/glib/PlatformWPE.cmake:
1753         * WebKitTestRunner/EventSenderProxy.h:
1754         * WebKitTestRunner/PlatformWPE.cmake:
1755         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1756         * wpe/HeadlessViewBackend/CMakeLists.txt:
1757         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
1758         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
1759         * wpe/jhbuild.modules:
1760
1761 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
1762
1763         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
1764         https://bugs.webkit.org/show_bug.cgi?id=184982
1765
1766         Rubber-stamped by Aakash Jain.
1767
1768         Correctly count the number of API test failures.
1769
1770         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1771         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
1772         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1773         * Scripts/webkitpy/api_tests/manager.py:
1774         (Manager.run): Disabled tests are not run.
1775
1776 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
1777
1778         Remove access to keychain from the WebContent process
1779         https://bugs.webkit.org/show_bug.cgi?id=184428
1780         <rdar://problem/13150903>
1781
1782         Reviewed by Brent Fulgham.
1783
1784         This patch does the followings:
1785         1. Added an API test for this patch.
1786         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
1787
1788         * DumpRenderTree/mac/UIDelegate.mm:
1789         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
1790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1791         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
1792         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
1793         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1794         (TestWebKitAPI::TEST_F):
1795         * WebKitTestRunner/TestController.cpp:
1796         (WTR::copySignedPublicKeyAndChallengeString):
1797         (WTR::TestController::createOtherPage):
1798         (WTR::TestController::createWebViewWithOptions):
1799
1800 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1801
1802         [Extra zoom mode] The search field on www.bing.com is missing label text
1803         https://bugs.webkit.org/show_bug.cgi?id=184975
1804         <rdar://problem/39723081>
1805
1806         Reviewed by Tim Horton.
1807
1808         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
1809         focused element in extra zoom mode.
1810
1811         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1812         (WTR::UIScriptController::formInputLabel const):
1813         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1814         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1815         (WTR::UIScriptController::formInputLabel const):
1816         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1817         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1818         (WTR::UIScriptController::formInputLabel const):
1819
1820 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1821
1822         [WPE] Should load injected bundle from builddir in developer builds
1823         https://bugs.webkit.org/show_bug.cgi?id=184983
1824
1825         Reviewed by Carlos Alberto Lopez Perez.
1826
1827         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
1828
1829         * Scripts/run-minibrowser:
1830
1831 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1832
1833         [WPE] libgstggtk.so broken in jhbuild environment
1834         https://bugs.webkit.org/show_bug.cgi?id=184984
1835
1836         Reviewed by Carlos Alberto Lopez Perez.
1837
1838         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
1839         gst-plugins-good.
1840
1841         * wpe/jhbuild.modules:
1842
1843 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1844
1845         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
1846         https://bugs.webkit.org/show_bug.cgi?id=184962
1847
1848         Reviewed by Youenn Fablet.
1849
1850         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
1851
1852         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1853         (ProcessSwap.SameOriginBlobNavigation): Added.
1854         (ProcessSwap.CrossOriginBlobNavigation): Added.
1855         (ProcessSwap.NavigateToAboutBlank): Added.
1856         (ProcessSwap.NavigateToDataURL): Added.
1857
1858 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1859
1860         [WPE] Remove deprecated functions and properties from the API
1861         https://bugs.webkit.org/show_bug.cgi?id=179295
1862
1863         Reviewed by Žan Doberšek.
1864
1865         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1866         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
1867         to rewrite LoadTrackingTest to not require the web view at construction time.
1868         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1869         (testWebKitSettings): Don't test private browsing setting, which is gone.
1870         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
1871
1872 2018-04-25  Andy Estes  <aestes@apple.com>
1873
1874         [Mac] Number of drop items is always 0 when performing a DHTML drag
1875         https://bugs.webkit.org/show_bug.cgi?id=184943
1876
1877         Reviewed by Ryosuke Niwa.
1878
1879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1880         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
1881         (-[DragInfo numberOfValidItemsForDrop]):
1882         (-[DragInfo setNumberOfValidItemsForDrop:]):
1883         (TestWebKitAPI::TEST):
1884         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
1885
1886 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
1887
1888         API test harness should be Python
1889         https://bugs.webkit.org/show_bug.cgi?id=181043
1890         <rdar://problem/36164410>
1891
1892         Reviewed by David Kilzer.
1893
1894         Run API tests from a Python script rather than Perl. The Python API tests have
1895         the same structure as the layout tests.
1896
1897         * Scripts/run-api-tests: Changed from Perl to Python.
1898         * Scripts/webkitpy/api_tests: Added.
1899         * Scripts/webkitpy/api_tests/__init__.py: Added.
1900         * Scripts/webkitpy/api_tests/manager.py: Added.
1901         (Manager):
1902         (Manager.__init__):
1903         (Manager._test_list_from_output): Construct a list of tests from the output of
1904         TestWTF and TestWebKitAPI.
1905         (Manager._find_test_subset): Given a list of all possible tests and command line
1906         arguments, return a list of tests which match the provided arguments.
1907         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
1908         to determine which tests will be run.
1909         (Manager._print_test_result): Formatted print of a test with it's output.
1910         (Manager._print_tests_result_with_status): Print all tests and output for tests
1911         which ran with a specified exit status.
1912         (Manager.run): Collect all tests, run them and then print results from the run.
1913         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
1914         (main): Parse arguments, construct a port, early exit for illegal ports and
1915         then run tests.
1916         (run): Setup logging and printing before using the Manager to run tests.
1917         (parse_args): Use argparse to define all options used by run-api-tests.
1918         * Scripts/webkitpy/api_tests/runner.py: Added.
1919         (Runner):
1920         (Runner.__init__):
1921         (Runner._shard_tests): Split tests so that each suite runs together.
1922         (Runner.command_for_port): Run a command on the device specified by the given
1923         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
1924         this function would be entirely replaced by the server_process factory owned
1925         by the port object.
1926         (Runner.run): Run all shards in the message_pool.
1927         (Runner.handle): Handle reports from child processes.
1928         (Runner.result_map_by_status): Return a mapping of tests to output for tests
1929         which exit with a specific status.
1930         (_Worker):
1931         (_Worker.__init__):
1932         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
1933         (_Worker._run_single_test): Runs a single test in a single child process.
1934         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
1935         child process. If this technique fails, the remaining tests are run singly.
1936         (_Worker.handle): Run the specified shard.
1937         * Scripts/webkitpy/port/base.py:
1938         (Port):
1939         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
1940         (Port.environment_for_api_tests): Return the environment needed to run
1941         the TestWebKitAPI binary.
1942         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
1943         used when running API tests.
1944         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
1945         * Scripts/webkitpy/port/mac.py:
1946         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
1947         * Scripts/webkitpy/port/server_process.py: 
1948         (ServerProcess.pop_all_buffered_stdout):
1949
1950 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1951
1952         Incorrect number of WebDriver test failures shown in the bots
1953         https://bugs.webkit.org/show_bug.cgi?id=184959
1954
1955         Reviewed by Michael Catanzaro.
1956
1957         The regular expression we are using to get the number of failures from the log is matching a particular test
1958         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
1959         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
1960
1961         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1962         (RunWebDriverTests.commandComplete):
1963
1964 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1965
1966         [GTK] Implement MouseEvent.buttons
1967         https://bugs.webkit.org/show_bug.cgi?id=184913
1968
1969         Reviewed by Žan Doberšek.
1970
1971         Include the mouse buttons state in WTR synthesized events.
1972
1973         * WebKitTestRunner/EventSenderProxy.h:
1974         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1975         (WTR::EventSenderProxy::EventSenderProxy):
1976         (WTR::EventSenderProxy::createMouseButtonEvent):
1977         (WTR::EventSenderProxy::mouseDown):
1978         (WTR::EventSenderProxy::mouseUp):
1979         (WTR::EventSenderProxy::mouseMoveTo):
1980
1981 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
1982
1983         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
1984         https://bugs.webkit.org/show_bug.cgi?id=184954
1985
1986         Reviewed by Michael Catanzaro.
1987
1988         * BuildSlaveSupport/build.webkit.org-config/config.json:
1989
1990 2018-04-24  Saam Barati  <sbarati@apple.com>
1991
1992         Keep around a pre-warmed process when doing process swap on navigation
1993         https://bugs.webkit.org/show_bug.cgi?id=184765
1994         <rdar://problem/39685099>
1995
1996         Reviewed by Ryosuke Niwa and Brady Eidson.
1997
1998         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1999
2000 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
2001
2002         [build.webkit.org] unit-tests fail when passwords.json is missing
2003         https://bugs.webkit.org/show_bug.cgi?id=180390
2004
2005         Reviewed by Carlos Alberto Lopez Perez.
2006
2007         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2008         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
2009         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2010         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
2011         (BuildBotConfigLoader._mock_open): Deleted.
2012         (BuildBotConfigLoader.load_config): Deleted.
2013
2014 2018-04-24  John Wilander  <wilander@apple.com>
2015
2016         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
2017         https://bugs.webkit.org/show_bug.cgi?id=184560
2018         <rdar://problem/38901344>
2019
2020         Reviewed by Youenn Fablet and Daniel Bates.
2021
2022         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
2023         We consume the From-Origin response header and only load the resource if:
2024         - The header is non-existent, empty, or invalid.
2025         - The header specifies 'same' and the resource's origin matches the originating
2026           document's origin and the origins up the frame tree.
2027         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
2028           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
2029
2030         This feature is experimental and off by default.
2031
2032         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2033         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
2034         (TestWebKitAPI::TEST):
2035             Tests for From-Origin header parsing.
2036
2037 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2038
2039         Unreviewed. Update W3C WebDriver imported tests.
2040
2041         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2042         (WebDriverW3CExecutor.__init__):
2043
2044 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
2045
2046         [WPE] Remove libgbm dependency
2047         https://bugs.webkit.org/show_bug.cgi?id=184906
2048
2049         Reviewed by Carlos Garcia Campos.
2050
2051         Stop searching for libgbm, using its compiler flags for the
2052         HeadlessViewBackend compilation and linking against the .so object.
2053         This is not necessary anymore after r230562 switched to a different
2054         backend implementation for testing.
2055
2056         * wpe/HeadlessViewBackend/CMakeLists.txt:
2057         * wpe/install-dependencies:
2058
2059 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2060
2061         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
2062         https://bugs.webkit.org/show_bug.cgi?id=184816
2063
2064         Reviewed by Michael Catanzaro.
2065
2066         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
2067         timeout.
2068
2069         * TestWebKitAPI/glib/TestExpectations.json:
2070         * glib/api_test_runner.py:
2071         (TestRunner._run_test_glib.is_slow_test):
2072         (TestRunner._run_test_glib):
2073         * glib/glib_test_runner.py:
2074         (GLibTestRunner.__init__):
2075         (GLibTestRunner._stop_timeout):
2076         (GLibTestRunner._subtest_start):
2077         (GLibTestRunner._subtest_end):
2078
2079 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2080
2081         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
2082         https://bugs.webkit.org/show_bug.cgi?id=184901
2083         <rdar://problem/39664797>
2084
2085         Reviewed by Tim Horton.
2086
2087         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
2088         interacting with the UI. See WebKit ChangeLogs for more detail.
2089
2090         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2091         (WTR::UIScriptController::setTimePickerValue):
2092         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2093         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2094         (WTR::UIScriptController::setTimePickerValue):
2095         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2096         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2097         (WTR::UIScriptController::setTimePickerValue):
2098
2099 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2100
2101         [LayoutFormattingContext] Initial commit.
2102         https://bugs.webkit.org/show_bug.cgi?id=184896
2103
2104         Reviewed by Antti Koivisto.
2105
2106         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2107
2108 2018-04-23  Chris Dumez  <cdumez@apple.com>
2109
2110         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
2111         https://bugs.webkit.org/show_bug.cgi?id=184801
2112
2113         Reviewed by Geoffrey Garen.
2114
2115         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
2116         This is a more common configuration and therefore should be the default testing configuration.
2117
2118         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2119         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2120         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
2121         is now asked for the policy decision.
2122
2123 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
2124
2125         [GTK][WPE] Add Debug bots (build and tests) for WPE
2126         https://bugs.webkit.org/show_bug.cgi?id=184887
2127
2128         Reviewed by Carlos Alberto Lopez Perez.
2129
2130         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
2131         wpe-linux-bot-4
2132
2133         Both bots have already the credentials ready to authenticated against
2134         build.webkit.org. They provides the bots for the "debug" configuration over
2135         the "WPE" platform and building for the "x86_64" architecture:
2136         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
2137
2138         * BuildSlaveSupport/build.webkit.org-config/config.json:
2139         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2140
2141 2018-04-23  Chris Dumez  <cdumez@apple.com>
2142
2143         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
2144         https://bugs.webkit.org/show_bug.cgi?id=184848
2145         <rdar://problem/39145306>
2146
2147         Reviewed by Brady Eidson.
2148
2149         Add API test coverage.
2150
2151         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2152         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2153         (TEST):
2154
2155 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
2156
2157         [GTK][WPE] TestSSL fails due to additional TLS errors returned
2158         https://bugs.webkit.org/show_bug.cgi?id=184860
2159
2160         Reviewed by Carlos Garcia Campos.
2161
2162         Add script and config file for regenerating the test certificate.
2163         Regenerate it. TestSSL no longer fails on my machine.
2164
2165         I do see a ton of network process crashes and JavaScript errors, none of
2166         which prevent the test from passing, but this commit only claims to fix
2167         the certificate validation portion of the test.
2168
2169         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
2170         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
2171         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
2172
2173 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2174
2175         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
2176         https://bugs.webkit.org/show_bug.cgi?id=184815
2177
2178         Reviewed by Michael Catanzaro.
2179
2180         This is because in the test we are calling both join and detach. We should only call join.
2181
2182         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2183         (testsJSCVirtualMachine):
2184
2185 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2186
2187         [GLIB] Test /jsc/prototypes crashes in debug
2188         https://bugs.webkit.org/show_bug.cgi?id=184814
2189
2190         Reviewed by Michael Catanzaro.
2191
2192         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
2193
2194         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2195         (barCreate):
2196         (barFree):
2197
2198 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2199
2200         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
2201         https://bugs.webkit.org/show_bug.cgi?id=184804
2202
2203         Reviewed by Carlos Garcia Campos.
2204
2205         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2206         (WebSocketTest::WebSocketTest):
2207         (WebSocketTest::~WebSocketTest):
2208         (WebSocketTest::serverWebSocketCallback):
2209         (WebSocketTest::webSocketTestResultCallback):
2210         (WebSocketTest::connectToServerAndWaitForEvents):
2211         (testWebSocketTLSErrors):
2212         (beforeAll):
2213
2214 2018-04-20  Chris Dumez  <cdumez@apple.com>
2215
2216         Unreviewed, update 2 more API tests after r230876.
2217
2218         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2219         (TEST):
2220         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2221         (TestWebKitAPI::TEST):
2222
2223 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2224
2225         Adjust geolocation feature flag
2226         https://bugs.webkit.org/show_bug.cgi?id=184856
2227
2228         Reviewed by Wenson Hsieh.
2229
2230         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2231
2232 2018-04-20  Chris Dumez  <cdumez@apple.com>
2233
2234         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
2235         https://bugs.webkit.org/show_bug.cgi?id=184210
2236         <rdar://problem/39072354>
2237
2238         Reviewed by Wenson Hsieh.
2239
2240         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
2241         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
2242         Add viewport meta tags.
2243
2244         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2245         (-[WKWebView _test_waitForDidFinishNavigation]):
2246         Update _test_waitForDidFinishNavigation to wait for the next presentation update
2247         to make iOS API tests happy without having to modify each of them.
2248
2249 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2250
2251         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
2252
2253         https://bugs.webkit.org/show_bug.cgi?id=184849
2254         rdar://problem/39386405
2255
2256         Reviewed by Brian Burg.
2257
2258         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
2259         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
2260         CGColor pointer from NSColor each time.
2261
2262 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2263
2264         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
2265         https://bugs.webkit.org/show_bug.cgi?id=184822
2266         <rdar://problem/38807319>
2267
2268         Reviewed by Tim Horton.
2269
2270         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
2271         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
2272         SPI. See other ChangeLogs for more detail.
2273
2274         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2275         (WTR::UIScriptController::enterText):
2276         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2277
2278         Add UIScriptController support for simulating text entry in the currently focused element.
2279
2280         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2281         (WTR::UIScriptController::enterText):
2282         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2283         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2284
2285         Add TestRunner bindings for registering injected bundle form client callbacks.
2286
2287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2288         (WTR::handleTextDidChangeInTextField):
2289         (WTR::handleTextFieldDidBeginEditing):
2290         (WTR::handleTextFieldDidEndEditing):
2291         (WTR::InjectedBundle::didCreatePage):
2292
2293         Set the injected bundle form editor client.
2294
2295         (WTR::InjectedBundle::setUpInjectedBundleClients):
2296         (WTR::InjectedBundle::textDidChangeInTextField):
2297         (WTR::InjectedBundle::textFieldDidBeginEditing):
2298         (WTR::InjectedBundle::textFieldDidEndEditing):
2299         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2300         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2301         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
2302         (WTR::TestRunner::textDidChangeInTextFieldCallback):
2303         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
2304         (WTR::TestRunner::textFieldDidBeginEditingCallback):
2305         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
2306         (WTR::TestRunner::textFieldDidEndEditingCallback):
2307         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2308         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2309         (WTR::UIScriptController::enterText):
2310
2311 2018-04-20  Youenn Fablet  <youenn@apple.com>
2312
2313         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
2314         https://bugs.webkit.org/show_bug.cgi?id=184369
2315
2316         Reviewed by Chris Dumez.
2317
2318         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2319         (TEST):
2320
2321 2018-04-20  Daniel Bates  <dabates@apple.com>
2322
2323         Remove Strong Password decoration when text field type changes
2324         https://bugs.webkit.org/show_bug.cgi?id=184795
2325         <rdar://problem/38325108>
2326
2327         Reviewed by Antti Koivisto.
2328
2329         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2330         when the field has the Strong Password button and its type changes.
2331
2332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2333         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
2334         (didResignInputElementStrongPasswordAppearance):
2335         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2336         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2337         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
2338         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2339         (TEST):
2340
2341 2018-04-20  Brady Eidson  <beidson@apple.com>
2342
2343         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
2344         https://bugs.webkit.org/show_bug.cgi?id=184807
2345
2346         Reviewed by Chris Dumez.
2347
2348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2349         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
2350
2351 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2352
2353         Unreviewed. Mark TestJSC as slow in debug.
2354
2355         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
2356
2357         * TestWebKitAPI/glib/TestExpectations.json:
2358
2359 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2360
2361         [GTK] Local cross references are broken in API documentation
2362         https://bugs.webkit.org/show_bug.cgi?id=184771
2363
2364         Reviewed by Michael Catanzaro.
2365
2366         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
2367         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
2368         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
2369         the cases.
2370
2371         * gtk/gtkdoc.py:
2372         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
2373         anything here.
2374         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
2375         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
2376         which gtkdoc-fixxref always uses absolute paths.
2377         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
2378
2379 2018-04-19  Brady Eidson  <beidson@apple.com>
2380
2381         Make back forward cache work with process swapping.
2382         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
2383
2384         Reviewed by Chris Dumez.
2385
2386         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2387
2388 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2389
2390         Enable Objective-C weak references
2391         <https://webkit.org/b/184789>
2392         <rdar://problem/39571716>
2393
2394         Reviewed by Dan Bernstein.
2395
2396         * ContentExtensionTester/Configurations/Base.xcconfig:
2397         (CLANG_ENABLE_OBJC_WEAK): Enable.
2398         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2399         (CLANG_ENABLE_OBJC_WEAK): Enable.
2400         * ImageDiff/cg/Configurations/Base.xcconfig:
2401         (CLANG_ENABLE_OBJC_WEAK): Enable.
2402         * MiniBrowser/Configurations/Base.xcconfig:
2403         (CLANG_ENABLE_OBJC_WEAK): Enable.
2404         * TestWebKitAPI/Configurations/Base.xcconfig:
2405         (CLANG_ENABLE_OBJC_WEAK): Enable.
2406         * WebEditingTester/Configurations/Base.xcconfig:
2407         (CLANG_ENABLE_OBJC_ARC): Re-order.
2408         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
2409         end of file.
2410         (CLANG_ENABLE_OBJC_WEAK): Enable.
2411         * WebKitTestRunner/Configurations/Base.xcconfig:
2412         (CLANG_ENABLE_OBJC_WEAK): Enable.
2413
2414 2018-04-19  Chris Dumez  <cdumez@apple.com>
2415
2416         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
2417         https://bugs.webkit.org/show_bug.cgi?id=184209
2418         <rdar://problem/39145306>
2419
2420         Reviewed by Ryosuke Niwa.
2421
2422         Add API test coverage.
2423
2424         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2425         (TEST):
2426
2427 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2428
2429         [WinCairo][EWS] Build bot should clean user temp directory each time.
2430         https://bugs.webkit.org/show_bug.cgi?id=184761
2431
2432         Reviewed by Lucas Forschler.
2433
2434         * EWSTools/Start-Queue.ps1:
2435         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
2436
2437 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2438
2439         Buildbots using Python zipfile should enable compression
2440         https://bugs.webkit.org/show_bug.cgi?id=184759
2441
2442         Reviewed by Lucas Forschler.
2443
2444         * BuildSlaveSupport/built-product-archive:
2445         (createZipManually):
2446         Default is to archive without compressing, so tell it to compress as well. 
2447
2448 2018-04-18  Nan Wang  <n_wang@apple.com>
2449
2450         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
2451         https://bugs.webkit.org/show_bug.cgi?id=184742
2452
2453         Reviewed by Chris Fleizach.
2454
2455         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2456         (AccessibilityUIElement::increment):
2457         (AccessibilityUIElement::decrement):
2458         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2459         (WTR::AccessibilityUIElement::asyncIncrement):
2460         (WTR::AccessibilityUIElement::asyncDecrement):
2461         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2462         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2463         (WTR::AccessibilityUIElement::increment):
2464         (WTR::AccessibilityUIElement::decrement):
2465         (WTR::AccessibilityUIElement::asyncIncrement):
2466         (WTR::AccessibilityUIElement::asyncDecrement):
2467
2468 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2469
2470         Fix archive step for WinCairo build bot.
2471         https://bugs.webkit.org/show_bug.cgi?id=184715
2472
2473         Reviewed by Lucas Forschler.
2474
2475         * BuildSlaveSupport/built-product-archive:
2476         (archiveBuiltProduct):
2477         (extractBuiltProduct):
2478
2479 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
2480
2481         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
2482         https://bugs.webkit.org/show_bug.cgi?id=184570
2483         <rdar://problem/34807323>
2484
2485         Reviewed by Chris Dumez.
2486
2487         Add API test coverage.
2488
2489         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
2490         (TEST):
2491
2492 2018-04-18  Chris Dumez  <cdumez@apple.com>
2493
2494         Add support for converting a local window to a remote window
2495         https://bugs.webkit.org/show_bug.cgi?id=184515
2496         <rdar://problem/39011318>
2497
2498         Reviewed by Ryosuke Niwa.
2499
2500         * MiniBrowser/mac/AppDelegate.m:
2501         (defaultConfiguration):
2502         * MiniBrowser/mac/SettingsController.h:
2503         * MiniBrowser/mac/SettingsController.m:
2504         (-[SettingsController _populateMenu]):
2505         (-[SettingsController validateMenuItem:]):
2506         (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]):
2507         (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]):
2508         Add menu entry in minibrowser to turn on process swap on cross-origin window.open().
2509
2510         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2511         Turn on process swap on cross-origin window.open() for corresponding test and update
2512         test to expect that a new WebProcess is created.
2513
2514         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2515         (WTR::InjectedBundlePage::decidePolicyForResponse):
2516         Add null checks for injectedBundle.testRunner(). When we swap process on navigation,
2517         the InjectedBundlePage::decidePolicyForResponse() gets called in the new process.
2518         In this new process, we have constructed a InjectedBundlePage for the page but we
2519         have not initialized the InjectedBundle members such as testRunner.
2520
2521         * WebKitTestRunner/TestController.cpp:
2522         (WTR::TestController::createWebViewWithOptions):
2523         (WTR::updateTestOptionsFromTestHeader):
2524         * WebKitTestRunner/TestOptions.h:
2525         (WTR::TestOptions::hasSameInitializationOptions const):
2526         Add a way for layout tests to turn on process swap on navigation via a test header.
2527
2528 2018-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2529
2530         Unreviewed, reland r230697, r230720, and r230724.
2531         https://bugs.webkit.org/show_bug.cgi?id=184600
2532
2533         * Scripts/run-jsc-stress-tests:
2534
2535 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2536
2537         [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
2538         https://bugs.webkit.org/show_bug.cgi?id=184687
2539
2540         Reviewed by Michael Catanzaro.
2541
2542         Add test cases for the new API.
2543
2544         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2545         (fooCreate):
2546         (fooFree):
2547         (fooGetProperty):
2548         (fooSetProperty):
2549         (testJSCPromises):
2550         (testJSCGarbageCollector):
2551         (testsJSCVirtualMachine):
2552         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2553         (windowObjectClearedCallback):
2554
2555 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2556
2557         [Extra zoom mode] Programmatically changing focus when an element already has focus is a confusing experience
2558         https://bugs.webkit.org/show_bug.cgi?id=184635
2559         <rdar://problem/39440642>
2560
2561         Reviewed by Tim Horton.
2562
2563         Add plumbing to support invoking `didHideKeyboardCallback` and `didShowKeyboardCallback` when (respectively)
2564         dismissing or presenting fullscreen input view controllers in extra zoom mode.
2565
2566         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2567         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2568         (-[TestRunnerWKWebView dealloc]):
2569         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2570         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2571         (-[TestRunnerWKWebView _keyboardDidShow:]):
2572         (-[TestRunnerWKWebView _keyboardDidHide:]):
2573         (-[TestRunnerWKWebView _webView:didPresentFocusedElementViewController:]):
2574         (-[TestRunnerWKWebView _webView:didDismissFocusedElementViewController:]):
2575
2576 2018-04-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2577
2578         [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
2579         https://bugs.webkit.org/show_bug.cgi?id=184573
2580
2581         Reviewed by Carlos Alberto Lopez Perez.
2582
2583         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2584         (TestWebKitAPI::TEST):
2585
2586 2018-04-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2587
2588         [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
2589         https://bugs.webkit.org/show_bug.cgi?id=184524
2590
2591         Reviewed by Alex Christensen.
2592
2593         Resurrect PlatformWebView for Windows port which was removed in Bug 104607.
2594
2595         * TestWebKitAPI/PlatformWebView.h:
2596         * TestWebKitAPI/PlatformWin.cmake:
2597         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
2598         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2599         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2600         (TestWebKitAPI::Util::moduleDirectory):
2601         (TestWebKitAPI::Util::createInjectedBundlePath):
2602         (TestWebKitAPI::Util::createURLForResource):
2603         (TestWebKitAPI::Util::URLForNonExistentResource):
2604         (TestWebKitAPI::Util::isKeyDown):
2605         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2606         (TestWebKitAPI::PlatformWebView::registerWindowClass):
2607         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2608         (TestWebKitAPI::PlatformWebView::initialize):
2609         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2610         (TestWebKitAPI::PlatformWebView::page const):
2611         (TestWebKitAPI::PlatformWebView::resizeTo):
2612         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2613         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2614         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2615         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2616         (TestWebKitAPI::PlatformWebView::wndProc):
2617         * TestWebKitAPI/win/UtilitiesWin.cpp: Added.
2618         (TestWebKitAPI::Util::run):
2619         (TestWebKitAPI::Util::spinRunLoop):
2620         (TestWebKitAPI::Util::sleep):
2621
2622 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2623
2624         Fix hasher tests for system with 32 bit longs
2625         https://bugs.webkit.org/show_bug.cgi?id=184708
2626         <rdar://problem/39459977>
2627
2628         Reviewed by Mark Lam.
2629
2630         Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
2631
2632         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
2633         (TestWebKitAPI::TEST):
2634
2635 2018-04-17  Commit Queue  <commit-queue@webkit.org>
2636
2637         Unreviewed, rolling out r230697, r230720, and r230724.
2638         https://bugs.webkit.org/show_bug.cgi?id=184717
2639
2640         These caused multiple failures on the Test262 testers.
2641         (Requested by mlewis13 on #webkit).
2642
2643         Reverted changesets:
2644
2645         "[WebAssembly][Modules] Prototype wasm import"
2646         https://bugs.webkit.org/show_bug.cgi?id=184600
2647         https://trac.webkit.org/changeset/230697
2648
2649         "[WebAssembly][Modules] Implement function import from wasm
2650         modules"
2651         https://bugs.webkit.org/show_bug.cgi?id=184689
2652         https://trac.webkit.org/changeset/230720
2653
2654         "[JSC] Rename runWebAssembly to runWebAssemblySuite"
2655         https://bugs.webkit.org/show_bug.cgi?id=184703
2656         https://trac.webkit.org/changeset/230724
2657
2658 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2659
2660         Unreviewed rollout of r230632. Regression in memory usage.
2661
2662         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2663
2664         * DumpRenderTree/TestOptions.h:
2665         * DumpRenderTree/mac/DumpRenderTree.mm:
2666         (runTest):
2667         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference): Deleted.
2668         * WebKitTestRunner/TestController.cpp:
2669         (WTR::TestController::resetPreferencesToConsistentValues):
2670         * WebKitTestRunner/TestOptions.cpp:
2671         (WTR::TestOptions::TestOptions):
2672         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2673         * WebKitTestRunner/TestOptions.h:
2674
2675 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2676
2677         [JSC] Rename runWebAssembly to runWebAssemblySuite
2678         https://bugs.webkit.org/show_bug.cgi?id=184703
2679
2680         Reviewed by JF Bastien.
2681
2682         * Scripts/run-jsc-stress-tests:
2683
2684 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2685
2686         [WebAssembly][Modules] Implement function import from wasm modules
2687         https://bugs.webkit.org/show_bug.cgi?id=184689
2688
2689         Reviewed by JF Bastien.
2690
2691         Add runWebAssemblyDirect, which runs wasm file directly.
2692
2693         * Scripts/run-jsc-stress-tests:
2694
2695 2018-04-17  Saam Barati  <sbarati@apple.com>
2696
2697         Add system trace points for process launch and for initializeWebProcess
2698         https://bugs.webkit.org/show_bug.cgi?id=184669
2699
2700         Reviewed by Simon Fraser.
2701
2702         * Tracing/SystemTracePoints.plist:
2703
2704 2018-04-17  Ross Kirsling  <ross.kirsling@sony.com>
2705
2706         Add debug bots for WinCairo.
2707         https://bugs.webkit.org/show_bug.cgi?id=184663
2708
2709         Reviewed by Lucas Forschler.
2710
2711         * BuildSlaveSupport/build.webkit.org-config/config.json:
2712         Add a debug build bot and two debug test bots.
2713
2714         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2715         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2716         Add a WinCairo category to build.webkit.org.
2717
2718 2018-04-17  Zalan Bujtas  <zalan@apple.com>
2719
2720         [LayoutReloaded] Set inline-block box position.
2721         https://bugs.webkit.org/show_bug.cgi?id=184690
2722
2723         Reviewed by Antti Koivisto.
2724
2725         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2726         (InlineFormattingContext.prototype._handleInlineBlock):
2727         * LayoutReloaded/Utils.js:
2728         (Utils._dumpBox):
2729         * LayoutReloaded/test/inline-block-with-fixed-width-height.html:
2730
2731 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2732
2733         [GLIB] Add API to clear JSCContext uncaught exception
2734         https://bugs.webkit.org/show_bug.cgi?id=184685
2735
2736         Reviewed by Žan Doberšek.
2737
2738         Add test cases for the new API.
2739
2740         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2741         (testJSCExceptions):
2742
2743 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2744
2745         [GLIB] Add API to query, delete and enumerate properties
2746         https://bugs.webkit.org/show_bug.cgi?id=184647
2747
2748         Reviewed by Michael Catanzaro.
2749
2750         Add test cases for the new API.
2751
2752         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2753         (testJSCObject):
2754         (testJSCClass):
2755         (testJSCPrototypes):
2756
2757 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2758
2759         [LayoutReloaded] Add support for replaced box.
2760         https://bugs.webkit.org/show_bug.cgi?id=184680
2761
2762         Reviewed by Antti Koivisto.
2763
2764         Basic support for inline replaced.
2765
2766         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2767         (InlineFormattingContext.prototype._handleInlineBox):
2768         (InlineFormattingContext.prototype._handleInlineBlock):
2769         (InlineFormattingContext.prototype._handleReplaced):
2770         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
2771         (Line.prototype.lastLineBox):
2772         (Line.prototype.addInlineBox):
2773         (Line.prototype.addInlineContainerBox): Deleted.
2774         * LayoutReloaded/TreeBuilder.js:
2775         (TreeBuilder.prototype._createAndAttachBox):
2776         * LayoutReloaded/Utils.js:
2777         (Utils._dumpBox):
2778         * LayoutReloaded/test/index.html:
2779         * LayoutReloaded/test/inline-simple-replaced.html: Added.
2780
2781 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2782
2783         [LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
2784         https://bugs.webkit.org/show_bug.cgi?id=184679
2785
2786         Reviewed by Antti Koivisto.
2787
2788         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2789         (InlineFormattingContext):
2790         (InlineFormattingContext.prototype.layout):
2791         (InlineFormattingContext.prototype._handleInlineContainer):
2792         (InlineFormattingContext.prototype._handleInlineContent):
2793         (InlineFormattingContext.prototype._handleInlineBlock):
2794         (InlineFormattingContext.prototype._handleReplacedBox):
2795         (InlineFormattingContext.prototype._clearNeedsLayoutAndMoveToNextSibling):
2796         (InlineFormattingContext.prototype._handleInlineBlockContainer): Deleted.
2797         (InlineFormattingContext.prototype._clearAndMoveToNext): Deleted.
2798
2799 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2800
2801         [LayoutReloaded] Introduce fragmentation state/context.
2802         https://bugs.webkit.org/show_bug.cgi?id=184677
2803
2804         Reviewed by Antti Koivisto.
2805
2806         State/context for fragmented content (multicol, regions, pagination etc).
2807
2808         * LayoutReloaded/FormattingContext/FragmentationContext.js: Added.
2809         (FragmentationContext):
2810         * LayoutReloaded/FormattingState/FragmentationState.js: Added.
2811         (FragmentationState):
2812         (FragmentationState.prototype.formattingState):
2813
2814 2018-04-16  Andy Estes  <aestes@apple.com>
2815
2816         [iOS] Enable WKPDFView by default
2817         https://bugs.webkit.org/show_bug.cgi?id=184675
2818         <rdar://problem/27885452>
2819
2820         Reviewed by Darin Adler.
2821
2822         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
2823
2824 2018-04-16  Leo Balter  <leonardo.balter@gmail.com>
2825
2826         Perl-based Test262 runner
2827         https://bugs.webkit.org/show_bug.cgi?id=183343
2828
2829         Reviewed by Michael Saboff.
2830
2831         * Scripts/test262-helpers/README.md: Added.
2832         * Scripts/test262-helpers/agent.js: Added.
2833         (262.getGlobal):
2834         (262.setGlobal):
2835         (262.destroy):
2836         (262.IsHTMLDDA):
2837         * Scripts/test262-helpers/cpanfile: Added.
2838         * Scripts/test262-helpers/cpanfile.snapshot: Added.
2839         * Scripts/test262-helpers/test262-runner.pl: Added.
2840         (main):
2841         (processFile):
2842         (getScenarios):
2843         (addScenario):
2844         (compileTest):
2845         (runTest):
2846         (processResult):
2847         (getTempFile):
2848         (getContents):
2849         (parseData):
2850         (getHarness):
2851         * Scripts/test262-helpers/tests.log: Added.
2852
2853 2018-04-15  Andy Estes  <aestes@apple.com>
2854
2855         [iOS] Add API tests for PDF find-in-page
2856         https://bugs.webkit.org/show_bug.cgi?id=184634
2857
2858         Reviewed by Dan Bernstein.
2859
2860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2861         * TestWebKitAPI/Tests/WebKit/find.pdf: Added.
2862         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
2863         (-[TestFindDelegate findString]):
2864         (-[TestFindDelegate _webView:didCountMatches:forString:]):
2865         (-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
2866         (-[TestFindDelegate _webView:didFailToFindString:]):
2867         (loadWebView):
2868         (TEST):
2869
2870 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2871
2872         [LayoutReloaded] Update class documentation
2873         https://bugs.webkit.org/show_bug.cgi?id=184625
2874
2875         Reviewed by Antti Koivisto.
2876
2877         * LayoutReloaded/DisplayTree/Box.js:
2878         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
2879         * LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
2880         * LayoutReloaded/FormattingContext/FloatingContext.js:
2881         * LayoutReloaded/FormattingContext/FormattingContext.js:
2882         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2883         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
2884         * LayoutReloaded/FormattingState/BlockFormattingState.js:
2885         * LayoutReloaded/FormattingState/FloatingState.js:
2886         * LayoutReloaded/FormattingState/FormattingState.js:
2887         * LayoutReloaded/FormattingState/InlineFormattingState.js:
2888         * LayoutReloaded/LayoutState.js:
2889         * LayoutReloaded/LayoutTree/BlockContainer.js:
2890         * LayoutReloaded/LayoutTree/Box.js:
2891         * LayoutReloaded/LayoutTree/Container.js:
2892         * LayoutReloaded/LayoutTree/InlineBox.js:
2893         * LayoutReloaded/LayoutTree/InlineContainer.js:
2894         * LayoutReloaded/LayoutTree/Text.js:
2895         * LayoutReloaded/misc/headers/BlockContainer.h: Removed.
2896         * LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
2897         * LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
2898         * LayoutReloaded/misc/headers/Box.h: Removed.
2899         * LayoutReloaded/misc/headers/Container.h: Removed.
2900         * LayoutReloaded/misc/headers/FloatingContext.h: Removed.
2901         * LayoutReloaded/misc/headers/FormattingContext.h: Removed.
2902         * LayoutReloaded/misc/headers/InitialBlockContainer.h: Removed.
2903         * LayoutReloaded/misc/headers/InlineBox.h: Removed.
2904         * LayoutReloaded/misc/headers/LayoutContext.h: Removed.
2905         * LayoutReloaded/misc/headers/Line.h: Removed.
2906         * LayoutReloaded/misc/headers/Text.h: Removed.
2907
2908 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2909
2910         [LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
2911         https://bugs.webkit.org/show_bug.cgi?id=184621
2912
2913         Reviewed by Antti Koivisto.
2914
2915         This is just a simple, mark ancestors dirty implementation.
2916
2917         * LayoutReloaded/FormattingState/FormattingState.js:
2918         (FormattingState.prototype.markNeedsLayout):
2919         * LayoutReloaded/LayoutState.js:
2920         (LayoutState.prototype.markNeedsLayout):
2921         (LayoutState.prototype.setNeedsLayoutById): Deleted.
2922         (LayoutState.prototype.setNeedsLayout): Deleted.
2923         * LayoutReloaded/TreeBuilder.js:
2924         (TreeBuilder.prototype._createAndAttachBox):
2925         (TreeBuilder.prototype._findBox): Deleted.
2926         * LayoutReloaded/Utils.js:
2927         (Utils.layoutBoxById):
2928         * LayoutReloaded/test/index.html:
2929         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html:
2930
2931 2018-04-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2932
2933         [WPE] [webkitpy] The driver requirements should be checked before starting the tests
2934         https://bugs.webkit.org/show_bug.cgi?id=184595
2935
2936         Reviewed by Michael Catanzaro.
2937
2938         Ensure Driver.check_driver() is checked at check_sys_deps() time.
2939
2940         * Scripts/webkitpy/port/wpe.py:
2941         (WPEPort.check_sys_deps):
2942
2943 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2944
2945         Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
2946
2947         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
2948
2949 2018-04-13  Jonathan Bedard  <jbedard@apple.com>
2950
2951         Boot fewer simulators in CI/EWS machines
2952         https://bugs.webkit.org/show_bug.cgi?id=184594
2953         <rdar://problem/39188082>
2954
2955         Reviewed by Alexey Proskuryakov.
2956
2957         This is a temporary workaround fro <rdar://problem/39393590>.
2958
2959         * Scripts/webkitpy/xcode/simulated_device.py:
2960         (SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.
2961
2962 2018-04-13  Brady Eidson  <beidson@apple.com>
2963
2964         Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.
2965         https://bugs.webkit.org/show_bug.cgi?id=184559
2966
2967         Reviewed by Alex Christensen.
2968
2969         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2970
2971 2018-04-13  Chris Dumez  <cdumez@apple.com>
2972
2973         input.webkitEntries does not work as expected when folder contains accented chars
2974         https://bugs.webkit.org/show_bug.cgi?id=184517
2975         <rdar://problem/39265537>
2976
2977         Reviewed by Alex Christensen.
2978
2979         Add API test coverage.
2980
2981         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2982         (TestWebKitAPI::TEST_F):
2983
2984 2018-04-13  Thibault Saunier  <tsaunier@igalia.com>
2985
2986         Update my emails ordering in contributors.json
2987         https://bugs.webkit.org/show_bug.cgi?id=184587
2988
2989         Rubber-stamped by Philippe Normand.
2990
2991         Bugzilla seems to pick up tsaunier@igalia.com which is not the one I use there.
2992
2993         * Scripts/webkitpy/common/config/contributors.json:
2994
2995 2018-04-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2996
2997         [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
2998         https://bugs.webkit.org/show_bug.cgi?id=184388
2999
3000         Reviewed by Carlos Alberto Lopez Perez.
3001
3002         Remove libxkbcommon from the JHBuild environment. We could alternatively add
3003         xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
3004         not believe it depends on anything else in the JHBuild environment.
3005
3006         * wpe/install-dependencies:
3007         * wpe/jhbuild.modules:
3008
3009 2018-04-12  Antoine Quint  <graouts@apple.com>
3010
3011         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3012         https://bugs.webkit.org/show_bug.cgi?id=184569
3013         <rdar://problem/38671301>
3014
3015         Reviewed by Jon Lee.
3016
3017         We set the default value for the CSS Animations and CSS Transitions as Web Animations flag to true
3018         but override it to be false always in the LayoutTests/legacy-animation-engine directory.
3019
3020         * DumpRenderTree/TestOptions.h:
3021         * DumpRenderTree/mac/DumpRenderTree.mm:
3022         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference):
3023         (runTest):
3024         * WebKitTestRunner/TestController.cpp:
3025         (WTR::TestController::resetPreferencesToConsistentValues):
3026         * WebKitTestRunner/TestOptions.cpp:
3027         (WTR::isLegacyAnimationEngineTestPath):
3028         (WTR::TestOptions::TestOptions):
3029         * WebKitTestRunner/TestOptions.h:
3030
3031 2018-04-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3032
3033         [GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
3034         https://bugs.webkit.org/show_bug.cgi?id=184531
3035
3036         Reviewed by Michael Catanzaro.
3037
3038         It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
3039         run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
3040         we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
3041         ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
3042         implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.
3043
3044         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3045         (TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
3046         * TestWebKitAPI/glib/UtilitiesGLib.cpp:
3047         (TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
3048         (TestWebKitAPI::Util::sleep): Ditto.
3049
3050 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3051
3052         [LayoutReloaded] Add support for incremental layout
3053         https://bugs.webkit.org/show_bug.cgi?id=184578
3054
3055         Reviewed by Antti Koivisto.
3056
3057         * LayoutReloaded/Layout.js:
3058         (layout):
3059         * LayoutReloaded/LayoutState.js:
3060         (LayoutState.prototype.rootContainer):
3061         (LayoutState.prototype.setNeedsLayoutById):
3062         * LayoutReloaded/Utils.js:
3063         (Utils.layoutTreeDump):
3064         * LayoutReloaded/test/TestHarness.js:
3065         (verifyLayout):
3066         (runLayout):
3067         (verifyLayoutTreeDump): Deleted.
3068         * LayoutReloaded/test/index.html:
3069         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.
3070
3071 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3072
3073         [LayoutReloaded] Move root container ownership to layout state
3074         https://bugs.webkit.org/show_bug.cgi?id=184575
3075
3076         Reviewed by Antti Koivisto.
3077
3078         Now the root container is on the associated layout state (ICB only at this point though).
3079
3080         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3081         (BlockFormattingContext.prototype.layout):
3082         * LayoutReloaded/FormattingContext/FormattingContext.js:
3083         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3084         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3085         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3086         (InlineFormattingContext.prototype._handleFloatingBox):
3087         * LayoutReloaded/Layout.js:
3088         (layout):
3089         * LayoutReloaded/LayoutState.js:
3090         (LayoutState):
3091         (LayoutState.prototype.formattingContext):
3092         (LayoutState.prototype.establishedFormattingState):
3093         (LayoutState.prototype.formattingStateForBox):
3094         (LayoutState.prototype.needsLayout):
3095         (LayoutState.prototype.displayBox):
3096         (LayoutState.prototype._formattingContext):
3097         (LayoutState.prototype.layout): Deleted.
3098         (LayoutState.prototype.formattingStates): Deleted.
3099         (LayoutState.prototype.initialDisplayBox): Deleted.
3100         * LayoutReloaded/Utils.js:
3101         (Utils._dumpBox):
3102         (Utils._findDisplayBox): Deleted.
3103
3104 2018-04-12  Jonathan Bedard  <jbedard@apple.com>
3105
3106         Fix --build-directory flag for run-webkit-tests
3107         https://bugs.webkit.org/show_bug.cgi?id=184545
3108         <rdar://problem/39385080>
3109
3110         Rubber-stamped by Aakash Jain.
3111
3112         The --build-directory path does not work with iOS-Simulator.
3113
3114         * Scripts/webkitpy/port/base.py:
3115         (Port._build_path): Use the port configuration to calculate the root directory.
3116         * Scripts/webkitpy/port/base_unittest.py:
3117         (PortTest.test_build_path): Test build directories for embedded configurations.
3118
3119 2018-04-12  Ross Kirsling  <ross.kirsling@sony.com>
3120
3121         pemfile.py should not assume POSIX line endings
3122         https://bugs.webkit.org/show_bug.cgi?id=184507
3123
3124         Reviewed by Daniel Bates.
3125
3126         * Scripts/webkitpy/common/system/pemfile.py:
3127         (_parse_pem_format):
3128         * Scripts/webkitpy/common/system/pemfile_unittest.py:
3129         (PemFileTest.test_parse_crlf):
3130         (PemFileTest.test_parse_cr):
3131
3132 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3133
3134         [LayoutReloaded] Minor cleanup in LayoutSate
3135         https://bugs.webkit.org/show_bug.cgi?id=184546
3136
3137         Reviewed by Antti Koivisto.
3138
3139         * LayoutReloaded/FormattingContext/FormattingContext.js:
3140         (FormattingContext.isInFormattingContext):
3141         * LayoutReloaded/FormattingState/FormattingState.js:
3142         (FormattingState.prototype.displayBoxes):
3143         (FormattingState.prototype.displayBox):
3144         (FormattingState.prototype._markSubTreeNeedsLayout):
3145         (FormattingState):
3146         (FormattingState.prototype.displayBoxMap): Deleted.
3147         * LayoutReloaded/LayoutState.js:
3148         (LayoutState.prototype.formattingStateForBox):
3149         (LayoutState.prototype.needsLayout):
3150         (LayoutState.prototype.displayBox):
3151         (LayoutState.prototype._createFormattingState):
3152         (LayoutState):
3153         * LayoutReloaded/LayoutTree/Box.js:
3154         (Layout.Box.prototype.isFormattingContextDescendant): Deleted.
3155         * LayoutReloaded/LayoutTree/Container.js:
3156         (Layout.Container.prototype.isContainingBlockDescendant): Deleted.
3157         * LayoutReloaded/Utils.js:
3158         (Utils._findDisplayBox):
3159
3160 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3161
3162         [LayoutReloaded] Introduce needsLayout to InlineFormattingContext
3163         https://bugs.webkit.org/show_bug.cgi?id=184538
3164
3165         Reviewed by Antti Koivisto.
3166
3167         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3168         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3169         (BlockFormattingContext):
3170         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout): Deleted.
3171         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout): Deleted.
3172         * LayoutReloaded/FormattingContext/FormattingContext.js:
3173         (FormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3174         (FormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3175         (FormattingContext):
3176         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3177         (InlineFormattingContext.prototype.layout):
3178         (InlineFormattingContext.prototype._handleInlineContainer):
3179         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3180         (InlineFormattingContext.prototype._handleInlineContent):
3181         (InlineFormattingContext.prototype._clearAndMoveToNext):
3182         (InlineFormattingContext):
3183
3184 2018-04-12  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3185
3186         [GStreamer] Speed up GStreamer dependency build by removing examples compilation
3187         https://bugs.webkit.org/show_bug.cgi?id=184528
3188
3189         Reviewed by Philippe Normand.
3190
3191         * gstreamer/jhbuild.modules: Added --disable-examples for GStreamer package.
3192
3193 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
3194
3195         [WPE] Switch testing process to using WPEBackend-fdo
3196         https://bugs.webkit.org/show_bug.cgi?id=184357
3197
3198         Reviewed by Carlos Alberto Lopez Perez.
3199
3200         Switch WPE testing to using the WPEBackend-fdo implementation that
3201         depends on the WL_bind_wayland_display EGL extension, as defined under
3202         the freedesktop.org project.
3203         https://cgit.freedesktop.org/mesa/mesa/tree/docs/specs/WL_bind_wayland_display.spec
3204
3205         HeadlessViewBackend is refactored to use the WPEBackend-fdo API, but
3206         otherwise is not changed in functionality.
3207
3208         Unit tests now have to unconditionally use HeadlessViewBackend as a
3209         wpe_view_backend provider, since WPEBackend-fdo does not provide a
3210         default wpe_view_backend implementation. Unit tests covering that are
3211         adjusted to instead use a mock wpe_view_backend interface.
3212
3213         * Scripts/webkitdirs.pm:
3214         (builtDylibPathForName): Fix the libWPEWebKit.so name to also include
3215         the API version that was added in r230449.
3216         * Scripts/webkitpy/port/waylanddriver.py:
3217         (WaylandDriver._setup_environ_for_test): Export EGL_PLATFORM=wayland.
3218         * Scripts/webkitpy/port/wpe.py:
3219         (WPEPort._driver_class): Use WaylandDriver by default.
3220         * TestWebKitAPI/PlatformWebView.h:
3221         (): Deleted.
3222         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3223         (testWebViewWebBackend):
3224         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3225         (Test::createWebViewBackend):
3226         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
3227         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3228         (TestWebKitAPI::PlatformWebView::initialize):
3229         * wpe/HeadlessViewBackend/CMakeLists.txt:
3230         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
3231         (getEGLDisplay):
3232         (HeadlessViewBackend::HeadlessViewBackend):
3233         (HeadlessViewBackend::~HeadlessViewBackend):
3234         (HeadlessViewBackend::backend const):
3235         (HeadlessViewBackend::createSnapshot):
3236         (HeadlessViewBackend::performUpdate):
3237         (HeadlessViewBackend::makeCurrent): Deleted.
3238         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
3239         * wpe/jhbuild.modules: Module name cleanup. Dyz version is bumped.
3240
3241 2018-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3242
3243         [GTK] Switch to use always complex text code path
3244         https://bugs.webkit.org/show_bug.cgi?id=183285
3245
3246         Reviewed by Michael Catanzaro.
3247
3248         Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
3249
3250         * WebKitTestRunner/gtk/main.cpp:
3251         (main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.
3252
3253 2018-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3254
3255         [GLIB] Handle strings containing null characters
3256         https://bugs.webkit.org/show_bug.cgi?id=184450
3257
3258         Reviewed by Michael Catanzaro.
3259
3260         Add test case for strings with null characters and update all calls to evaluate to pass the script length.
3261
3262         * TestWebKitAPI/PlatformGTK.cmake:
3263         * TestWebKitAPI/PlatformWPE.cmake:
3264         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3265         (testJSCBasic):
3266         (testJSCFunction):
3267         (testJSCObject):
3268         (testJSCClass):
3269         (testJSCPrototypes):
3270         (testJSCExceptions):
3271         (testJSCPromises):
3272         (testJSCGarbageCollector):
3273         (testJSCWeakValue):
3274         (testsJSCVirtualMachine):
3275         (testsJSCAutocleanups):
3276         * TestWebKitAPI/Tests/JavaScriptCore/glib/script.js: Added.
3277         * TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp:
3278         (DOMElementTest::testAutoFill):
3279         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3280         (WebKitWebEditorTest::testSelectionChanged):
3281         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3282         (WebKitFrameTest::testJavaScriptValues):
3283         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3284         (consoleMessageSentCallback):
3285         (methodCallCallback):
3286
3287 2018-04-11  Zan Dobersek  <zdobersek@igalia.com>
3288
3289         [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
3290         https://bugs.webkit.org/show_bug.cgi?id=184513
3291
3292         Reviewed by Michael Catanzaro.
3293
3294         Update the WPE-specific testWebViewWebBackend() test case, removing the
3295         test that passes a null WebKitWebViewBackend object to the
3296         webkit_web_view_new() call.
3297
3298         Helper createWebViewBackend() that's called via Test::createWebView()
3299         variations is updated to, in case of not using the headless backend,
3300         return a WebKitWebViewBackend instance that wraps around a
3301         default wpe_view_backend object.
3302
3303         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3304         (testWebViewWebBackend):
3305         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3306         (Test::createWebViewBackend):
3307
3308 2018-04-11  Zalan Bujtas  <zalan@apple.com>
3309
3310         [LayoutReloaded] Introduce needsLayout flag
3311         https://bugs.webkit.org/show_bug.cgi?id=184527
3312
3313         Reviewed by Antti Koivisto.
3314
3315         Use the formatting state to mark boxes dirty.
3316
3317         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3318         (BlockFormattingContext.prototype.layout):
3319         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3320         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3321         (BlockFormattingContext):
3322         * LayoutReloaded/FormattingContext/FormattingContext.js:
3323         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3324         * LayoutReloaded/FormattingState/FormattingState.js:
3325         (FormattingState):
3326         (FormattingState.prototype.markNeedsLayout):
3327         (FormattingState.prototype.clearNeedsLayout):
3328         (FormattingState.prototype.needsLayout):
3329         (FormattingState.prototype.layoutNeeded):
3330         (FormattingState.prototype._markSubTreeNeedsLayout):
3331         * LayoutReloaded/LayoutState.js:
3332         (LayoutState.prototype.formattingStateForBox):
3333         (LayoutState.prototype.setNeedsLayout):
3334         (LayoutState.prototype.needsLayout):
3335         * LayoutReloaded/LayoutTree/Box.js:
3336         (Layout.Box.prototype.isFormattingContextDescendant):
3337         * LayoutReloaded/LayoutTree/Container.js:
3338         (Layout.Container.prototype.isContainingBlockDescendant):
3339
3340 2018-04-11  Jonathan Bedard  <jbedard@apple.com>
3341
3342         Fix TestInvocation class for newer versions of clang.
3343         https://bugs.webkit.org/show_bug.cgi?id=184508
3344         <rdar://problem/39328648>
3345
3346         Reviewed by Alexey Proskuryakov.
3347
3348         Declare TestInvocation to be final so it does not require a virtual destructor.
3349
3350         * WebKitTestRunner/TestInvocation.h:
3351
3352 2018-04-10  Alex Christensen  <achristensen@webkit.org>
3353
3354         IDN spoofing with Hebrew combining characters
3355         https://bugs.webkit.org/show_bug.cgi?id=184472
3356         <rdar://problem/39148687>
3357
3358         Reviewed by Brent Fulgham.
3359
3360         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3361         (TestWebKitAPI::TEST):
3362
3363 2018-04-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3364
3365         [Extra zoom mode] Missing label when focusing a <select> with a title attribute but no associated <label>
3366         https://bugs.webkit.org/show_bug.cgi?id=184352
3367         <rdar://problem/39237683>
3368
3369         Reviewed by Andy Estes.
3370
3371         Add support for UIScriptController::selectFormPopoverTitle, which returns the title of the current select
3372         popover's UITableViewController (for testing purposes).
3373
3374         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3375         (WTR::UIScriptController::selectFormPopoverTitle const):
3376         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3377         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3378         (WTR::UIScriptController::selectFormPopoverTitle const):
3379         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3380         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3381         (WTR::UIScriptController::selectFormPopoverTitle const):
3382
3383 2018-04-10  Nan Wang  <n_wang@apple.com>
3384
3385         AX: Expose strong password fields on iOS
3386         https://bugs.webkit.org/show_bug.cgi?id=184465
3387         <rdar://problem/39325104>
3388
3389         Reviewed by Chris Fleizach.
3390
3391         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3392         (AccessibilityUIElement::boolAttributeValue):
3393         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3394         (WTR::AccessibilityUIElement::boolAttributeValue):
3395
3396 2018-04-10  Zalan Bujtas  <zalan@apple.com>
3397
3398         [LayoutReloaded] Add support for out-of-flow descendants in inline formatting context.
3399         https://bugs.webkit.org/show_bug.cgi?id=184454
3400
3401         Reviewed by Antti Koivisto.
3402
3403         When the containing block of an out-of-flow positioned element establishes an inline formatting context.
3404         This is mostly about moving out-of-flow logic from BlockFormattingContext to the base class.
3405
3406         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3407         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3408         (BlockFormattingContext):
3409         (BlockFormattingContext.prototype._layoutOutOfFlowDescendants): Deleted.
3410         (BlockFormattingContext.prototype._computeOutOfFlowWidth): Deleted.
3411         (BlockFormattingContext.prototype._computeInFlowWidth): Deleted.
3412         (BlockFormattingContext.prototype._computeOutOfFlowHeight): Deleted.
3413         (BlockFormattingContext.prototype._computeOutOfFlowPosition): Deleted.
3414         (BlockFormattingContext.prototype._shrinkToFitWidth): Deleted.
3415         * LayoutReloaded/FormattingContext/FormattingContext.js:
3416         (FormattingContext.prototype._placeInFlowPositionedChildren):
3417         (FormattingContext.prototype._computeInFlowWidth):
3418         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3419         (FormattingContext.prototype._computeOutOfFlowWidth):
3420         (FormattingContext.prototype._computeOutOfFlowHeight):
3421         (FormattingContext.prototype._computeOutOfFlowPosition):
3422         (FormattingContext.prototype._shrinkToFitWidth):
3423         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3424         (InlineFormattingContext.prototype.layout):
3425         (InlineFormattingContext.prototype._handleInlineContainer):
3426         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3427         (InlineFormattingContext.prototype._placeOutOfFlowDescendants): Deleted.
3428         * LayoutReloaded/test/index.html:
3429         * LayoutReloaded/test/inline-with-out-of-flow-descendant.html: Added.
3430
3431 2018-04-09  Zan Dobersek  <zdobersek@igalia.com>
3432
3433         WKTR: Enable DOM cache, SW registration directory cleanup on non-Cocoa platforms
3434         https://bugs.webkit.org/show_bug.cgi?id=184414
3435
3436         Reviewed by Michael Catanzaro.
3437
3438         Enable clearServiceWorkerRegistrations(), clearDOMCache() and
3439         clearDOMCaches() implementations in WebKitTestRunner's TestController
3440         class for non-Cocoa platforms. Implementations depend on the generic
3441         WK2 C API that other ports can leverage as well.
3442
3443         The clearDOMCache() and clearDOMCaches() calls are now operational for
3444         tests that invoke them. clearServiceWorkerRegistrations() and
3445         clearDOMCaches() are also called between each test, cleaning up relevant
3446         resources.
3447
3448         The TestController::getAllStorageAccessEntries() stub for non-Cocoa
3449         platforms is moved into the main !PLATFORM(COCOA) block.
3450
3451         * WebKitTestRunner/TestController.cpp:
3452         (WTR::TestController::getAllStorageAccessEntries):
3453         (WTR::clearServiceWorkerRegistrationsCallback):
3454         (WTR::TestController::clearServiceWorkerRegistrations):
3455         (WTR::clearDOMCacheCallback):
3456         (WTR::TestController::clearDOMCache):
3457         (WTR::TestController::clearDOMCaches):
3458
3459 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3460
3461         [LayoutReloaded] Add support for relatively positioned containers in inline formatting context.
3462         https://bugs.webkit.org/show_bug.cgi?id=184439
3463
3464         Reviewed by Antti Koivisto.
3465
3466         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3467         (BlockFormattingContext.prototype._placeInFlowPositionedChildren): Deleted.
3468         (BlockFormattingContext.prototype._computeInFlowPositionedPosition): Deleted.
3469         * LayoutReloaded/FormattingContext/FormattingContext.js:
3470         (FormattingContext.prototype._computeInFlowPositionedPosition):
3471         (FormattingContext.prototype._placeInFlowPositionedChildren):
3472         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3473         (InlineFormattingContext.prototype._placeInFlowPositionedChildren): Deleted.
3474         * LayoutReloaded/Utils.js:
3475         (Utils._dumpBox):
3476         (Utils._dumpLines.):
3477         (Utils._dumpLines):
3478         (Utils.precisionRoundWithDecimals):
3479         (Utils.precisionRound):
3480         (Utils):
3481         * LayoutReloaded/test/index.html:
3482         * LayoutReloaded/test/inline-with-relative-positioning.html: Added.
3483
3484 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3485
3486         [LayoutReloaded] Remove Layout.InitialContainingBlock class
3487         https://bugs.webkit.org/show_bug.cgi?id=184436
3488
3489         Reviewed by Antti Koivisto.
3490
3491         * LayoutReloaded/LayoutTree/Box.js:
3492         (Layout.Box.prototype.establishesBlockFormattingContext):
3493         * LayoutReloaded/LayoutTree/InitialBlockContainer.js: Removed.
3494         * LayoutReloaded/TreeBuilder.js:
3495         (TreeBuilder.prototype.createTree):
3496         * LayoutReloaded/test/index.html:
3497
3498 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3499
3500         [LayoutReloaded] Add support for inline-block.
3501         https://bugs.webkit.org/show_bug.cgi?id=184434
3502
3503         Reviewed by Antti Koivisto.
3504
3505         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3506         (InlineFormattingContext):
3507         (InlineFormattingContext.prototype.layout):
3508         (InlineFormattingContext.prototype._handleInlineContainer):
3509         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3510         (InlineFormattingContext.prototype._handleInlineContent):
3511         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3512         (Line.prototype.addInlineContainerBox):
3513         (Line.prototype.addTextLineBox):
3514         (Line):
3515         * LayoutReloaded/LayoutTree/Box.js:
3516         (Layout.Box.prototype.isInlineBlockBox):
3517         * LayoutReloaded/Utils.js:
3518         (LayoutRect.prototype.growHorizontally):
3519         (Utils.isBlockContainerElement):
3520         (Utils.isInlineBlockElement):
3521         (Utils._dumpLines.):
3522         (Utils._dumpLines):
3523         * LayoutReloaded/test/index.html:
3524         * LayoutReloaded/test/inline-block-with-fixed-width-height.html: Added.
3525
3526 2018-04-09  Timothy Hatcher  <timothy@apple.com>
3527
3528         Add support for setting a background color on WKWebView and WKView
3529         https://bugs.webkit.org/show_bug.cgi?id=184426
3530
3531         Reviewed by Wenson Hsieh.
3532
3533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3534         * TestWebKitAPI/Tests/mac/BackgroundColor.mm: Added.
3535
3536 2018-04-09  Charlie Turner  <cturner@igalia.com>
3537
3538         [WPE] Add some missing install dependencies
3539         https://bugs.webkit.org/show_bug.cgi?id=184383
3540
3541         Reviewed by Michael Catanzaro.
3542
3543         * wpe/install-dependencies:
3544
3545 2018-04-09  Sihui Liu  <sihui_liu@apple.com>
3546
3547         REGRESSION(r229929): localStorage is broken for WebInspector
3548         https://bugs.webkit.org/show_bug.cgi?id=184382
3549         <rdar://problem/39257355>
3550
3551         Reviewed by Chris Dumez.
3552
3553         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3554         (TEST):
3555         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-empty-string-value.html:
3556
3557 2018-04-09  Zan Dobersek  <zdobersek@igalia.com>
3558
3559         Unreviewed follow-up to r230389.
3560
3561         * WebKitTestRunner/TestController.cpp:
3562         (WTR::TestController::platformAdjustContext): Use the 'ServiceWorkers'
3563         subdirectory for the temporary testing-purpose SW registration directory
3564         like it's used in Cocoa's TestController, addressing the review comment
3565         that I forgot about.
3566
3567 2018-04-08  Zan Dobersek  <zdobersek@igalia.com>
3568
3569         Non-Cocoa ports use default directory for ServiceWorker data during testing
3570         https://bugs.webkit.org/show_bug.cgi?id=183784
3571
3572         Reviewed by Youenn Fablet.
3573
3574         * WebKitTestRunner/TestController.cpp:
3575         (WTR::TestController::platformAdjustContext): Set the service worker registration
3576         directory through the new WKWebsiteDataStore API for non-Cocoa ports.
3577
3578 2018-04-08  Zalan Bujtas  <zalan@apple.com>
3579
3580         [LayoutReloaded] Adjust line with inline container's margin border and padding
3581         https://bugs.webkit.org/show_bug.cgi?id=184409
3582
3583         Reviewed by Antti Koivisto.
3584
3585         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3586         (InlineFormattingContext.prototype.layout):
3587         (InlineFormattingContext.prototype._handleFloatingBox):
3588         (InlineFormattingContext.prototype._adjustLineForInlineContainerStart):
3589         (InlineFormattingContext.prototype._adjustLineForInlineContainerEnd):
3590         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3591         (Line.prototype.shrink):
3592         (Line.prototype.adjustWithOffset):
3593         (Line.prototype.moveContentHorizontally):
3594         (Line.prototype.addTextLineBox):
3595         (Line):
3596         (Line.prototype.addFloatingBox): Deleted.
3597         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3598         * LayoutReloaded/test/index.html:
3599         * LayoutReloaded/test/inline-with-padding-border-margin-offsets.html: Added.
3600
3601 2018-04-07  Zalan Bujtas  <zalan@apple.com>
3602
3603         [LayoutReloaded] Add support for InlineContainer
3604         https://bugs.webkit.org/show_bug.cgi?id=184394
3605
3606         Reviewed by Antti Koivisto.
3607
3608         * LayoutReloaded/FormattingContext/FormattingContext.js:
3609         (FormattingContext.prototype._addToLayoutQueue):
3610         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3611         (InlineFormattingContext.prototype.layout):
3612         (InlineFormattingContext.prototype._handleInlineContent):
3613         (InlineFormattingContext.prototype._handleFloatingBox):
3614         (InlineFormattingContext.prototype._adjustLineForInlineContainerStart):
3615         (InlineFormattingContext.prototype._adjustLineForInlineContainerEnd):
3616         (InlineFormattingContext.prototype._placeInFlowPositionedChildren):
3617         (InlineFormattingContext.prototype._placeOutOfFlowDescendants):
3618         (InlineFormattingContext.prototype._createNewLine):
3619         (InlineFormattingContext.prototype._handleContent): Deleted.
3620         * LayoutReloaded/LayoutState.js:
3621         (LayoutState.prototype._createFormattingState):
3622         * LayoutReloaded/LayoutTree/Box.js:
3623         (Layout.Box.prototype.isContainer):
3624         (Layout.Box.prototype.isInlineContainer):
3625         (Layout.Box.prototype.isInlineBox):
3626         * LayoutReloaded/LayoutTree/Container.js:
3627         (Layout.Container.prototype.isContainer): Deleted.
3628         * LayoutReloaded/LayoutTree/InlineContainer.js: Added.
3629         (Layout.InlineContainer):
3630         * LayoutReloaded/TreeBuilder.js:
3631         (TreeBuilder.prototype._createAndAttachBox):
3632         * LayoutReloaded/Utils.js:
3633         (Utils._dumpBox):
3634         (Utils.precisionRound):
3635         (Utils):
3636         * LayoutReloaded/test/index.html:
3637         * LayoutReloaded/test/inline-content-simple2.html: Added.
3638         * LayoutReloaded/test/inline-floating1.html: Added.
3639         * LayoutReloaded/test/inline-formatting-context-floats1.html: Added.
3640         * LayoutReloaded/test/inline-formatting-context-floats2.html: Added.
3641
3642 2018-04-07  Timothy Hatcher  <timothy@apple.com>
3643
3644         Use the system's link color when system appearance is desired for a WebView.
3645
3646         https://bugs.webkit.org/show_bug.cgi?id=184353
3647         rdar://problem/9420053
3648
3649         Reviewed by Wenson Hsieh.
3650
3651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3652         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm: Added.
3653         (TestWebKitAPI::WebKit::LinkColor):
3654         (TestWebKitAPI::WebKit::LinkColorWithSystemAppearance):
3655
3656 2018-04-06  Zalan Bujtas  <zalan@apple.com>
3657
3658         Rebaseline LayoutReloaded patch file.
3659
3660         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3661
3662 2018-04-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3663
3664         [Win][WebCore] Expose a constant for scrollbar pixels per line (cScrollbarPixelsPerLine)
3665         https://bugs.webkit.org/show_bug.cgi?id=184296
3666
3667         Reviewed by Alex Christensen.
3668
3669         * DumpRenderTree/win/EventSender.cpp:
3670         (mouseScrollBy): Removed the duplicated cScrollbarPixelsPerLine
3671         definition. Use WebCore::cScrollbarPixelsPerLine.
3672
3673 2018-04-06  Zalan Bujtas  <zalan@apple.com>
3674
3675         Rebaseline LayoutReloaded patch file.
3676