f68de7a852504d6f4bed4dfc8a121c7ba4623801
[WebKit-https.git] / Tools / ChangeLog
1 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
2
3         [Timeline]: Make timeline header width automatic, instead of fixed width
4         https://bugs.webkit.org/show_bug.cgi?id=200059
5
6         Reviewed by Jonathan Bedard.
7
8         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
9         (.dot.crash):
10         (.timeline>.header): Deleted.
11         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
12         (.timeline>.content):
13         (.timeline>.header):
14
15 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
16
17         [ESNext] Implement nullish coalescing
18         https://bugs.webkit.org/show_bug.cgi?id=200072
19
20         Reviewed by Darin Adler.
21
22         * Scripts/run-jsc-stress-tests:
23
24 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
25
26         Add Takashi Komori and Tomoki Imai as contributors
27
28         Unreviewed.
29
30         * Scripts/webkitpy/common/config/contributors.json:
31
32 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
33
34         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
35         https://bugs.webkit.org/show_bug.cgi?id=200103
36
37         Reviewed by Mark Lam.
38
39         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
40         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
41
42         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
43         to the future implementation changes while it catches the severe issues we had.
44
45         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
46         (assertEmptyPointerSet):
47         (assertHasOnlyObjects):
48         (assertClean):
49         (TEST):
50         (allocateAndDeallocate):
51
52 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
53
54         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
55         https://bugs.webkit.org/show_bug.cgi?id=200074
56
57         Reviewed by Michael Catanzaro.
58
59         There was a latent issue. PluginTest::indicateTestFailure was
60         using WTF::sleep without linking WTF.
61
62         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
63         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
64
65 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
66
67         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
68         https://bugs.webkit.org/show_bug.cgi?id=200073
69
70         Reviewed by Michael Catanzaro.
71
72         * TestWebKitAPI/PlatformGTK.cmake:
73         * TestWebKitAPI/PlatformWPE.cmake:
74         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
75
76 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
77
78         [webkitperl] runCommand doesn't work in Windows Perl
79         https://bugs.webkit.org/show_bug.cgi?id=199900
80
81         Reviewed by Don Olmstead.
82
83         runCommand was always failing implicit fork by using 'open' with
84         '-|' in Windows Perl. Explicitly specify the command to 'open' not
85         to do the implicit fork.
86
87         There is one more difference between Windows and Unix. 'open'
88         successes on Windows even for non existent command while it fails
89         on Unix. So, return the same error code on Unix as well as
90         Windows.
91
92         * Scripts/VCSUtils.pm: Specified the command to 'open'.
93         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
94         command is not available on Windows. Use Perl ($^X) instead.
95
96 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
97
98         Allow Clients to Add Fields to the AutoFillContext Dictionary.
99         https://bugs.webkit.org/show_bug.cgi?id=199326
100         rdar://problem/42816957
101
102         Reviewed by Wenson Hsieh.
103
104         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
105         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
106         is being properly populated with additional context dictionary.
107
108         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
109         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
110         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
111         which will populate the additional autofill context dictionary.
112
113         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
114         populates the additional autofill context dictionary.
115
116         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
117         context dictionary.
118
119         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the 
120         input field requires strong password work.
121
122         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
123         input field requires strong password work.
124
125         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
126         password work.
127
128 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
129
130         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
131         https://bugs.webkit.org/show_bug.cgi?id=199489
132
133         Reviewed by Aakash Jain.
134
135         * BuildSlaveSupport/build.webkit.org-config/steps.py:
136         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
137         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
138         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
139         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
140         (runTest): Record test binary failure
141         (reportTestFailures): Report test binary failure
142         (runJSCStressTests): 
143         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
144         (JscOnlyPort.build_jsc_command):
145         (JscOnlyPort):
146         (JscOnlyPort.run_javascriptcore_tests_command):
147         * Scripts/webkitpy/common/config/ports_unittest.py:
148         (DeprecatedPortTest.test_jsconly_port):
149
150 2019-07-24  Zalan Bujtas  <zalan@apple.com>
151
152         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
153         https://bugs.webkit.org/show_bug.cgi?id=200079
154         <rdar://problem/53474325>
155
156         Reviewed by Wenson Hsieh.
157
158         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
159
160         * WebKitTestRunner/ios/TestControllerIOS.mm:
161         (WTR::TestController::platformResetPreferencesToConsistentValues):
162
163 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
164
165         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
166         https://bugs.webkit.org/show_bug.cgi?id=199927
167
168         Reviewed by Alex Christensen.
169
170         convertAbsolutepathToWebKitPath was failing to convert paths on
171         Windows Perl due to path separators mismatch.
172
173         Renamed convertAbsolutepathToWebKitPath to
174         convertAbsolutePathToRelativeUnixPath, and changed it to replace
175         paths to relative Unix paths.
176
177         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
178         (convertAbsolutePathToRelativeUnixPath): Added.
179         (convertAbsolutepathToWebKitPath): Deleted.
180
181 2019-07-23  Alex Christensen  <achristensen@webkit.org>
182
183         Fix iOS API test after r247759
184         https://bugs.webkit.org/show_bug.cgi?id=200045
185
186         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
187         (TEST):
188         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
189         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
190
191 2019-07-23  Keith Rollin  <krollin@apple.com>
192
193         Remove rest of NavigatorContentUtils support
194         https://bugs.webkit.org/show_bug.cgi?id=200052
195         <rdar://problem/53467357>
196
197         Reviewed by Alex Christensen.
198
199         Bug 196070 removes most of the support for the never-used
200         NavigatorContentUtils facility. However, there were still a couple of
201         left-over references after that change. This patch sweeps those up.
202
203         * Scripts/webkitperl/FeatureList.pm:
204
205 2019-07-23  Alex Christensen  <achristensen@webkit.org>
206
207         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
208         https://bugs.webkit.org/show_bug.cgi?id=200045
209
210         Reviewed by Mark Lam.
211
212         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
213         (TEST):
214
215 2019-07-23  Russell Epstein  <repstein@apple.com>
216
217         Unreviewed, rolling out r247745.
218
219         This broke API test
220         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
221         indicated by EWS
222
223         Reverted changeset:
224
225         "Move javaScriptConfigurationDirectory SPI from
226         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
227         runtime switchable"
228         https://bugs.webkit.org/show_bug.cgi?id=200045
229         https://trac.webkit.org/changeset/247745
230
231 2019-07-23  Alex Christensen  <achristensen@webkit.org>
232
233         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
234         https://bugs.webkit.org/show_bug.cgi?id=200045
235
236         Reviewed by Mark Lam.
237
238         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
239         (TEST):
240
241 2019-07-23  Alex Christensen  <achristensen@webkit.org>
242
243         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
244         https://bugs.webkit.org/show_bug.cgi?id=199972
245
246         Reviewed by Jer Noble.
247
248         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
249         (TEST):
250
251 2019-07-23  Alicia Boya García  <aboya@igalia.com>
252
253         [WTF] Add DataMutex and MainThreadData wrappers
254         https://bugs.webkit.org/show_bug.cgi?id=199831
255
256         Reviewed by Alex Christensen.
257
258         Added a very simple test that checks that DataMutex<T> indeed takes
259         the lock and indeed holds data.
260
261         * TestWebKitAPI/CMakeLists.txt:
262         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
263         (TestWebKitAPI::TEST):
264
265 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
266
267         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
268         https://bugs.webkit.org/show_bug.cgi?id=200021
269         <rdar://problem/53301325>
270
271         Reviewed by Ryosuke Niwa.
272
273         Add support for grabbing the child menu items of a context menu item.
274
275         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
276         (WTR::getMenuItemChildrenCallback):
277
278 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
279
280         WebKit should strip away system font names from the pasted content
281         https://bugs.webkit.org/show_bug.cgi?id=199975
282         <rdar://problem/53336353>
283
284         Reviewed by Darin Adler.
285
286         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
287
288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
289         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
290         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
291
292 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
293
294         [ews-build] EWS fails to parse multi-line full_results.json
295         https://bugs.webkit.org/show_bug.cgi?id=199992
296
297         Reviewed by Alexey Proskuryakov.
298
299         * BuildSlaveSupport/ews-build/layout_test_failures.py:
300         (LayoutTestFailures.results_from_string): Concatenate content into single line.
301         * BuildSlaveSupport/ews-build/steps_unittest.py:
302         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
303
304 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
305
306         resultsdbpy: Handle case where the previous commit doesn't have the changelog
307         https://bugs.webkit.org/show_bug.cgi?id=200015
308
309         Reviewed by Aakash Jain.
310
311         * resultsdbpy/resultsdbpy/model/repository.py:
312         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
313
314 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
315
316         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
317         https://bugs.webkit.org/show_bug.cgi?id=200013
318         <rdar://problem/52526901>
319
320         Reviewed by Simon Fraser.
321
322         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
323
324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
325         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
326         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
327         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
328         * TestWebKitAPI/ios/UIKitSPI.h:
329
330 2019-07-22  Jer Noble  <jer.noble@apple.com>
331
332         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
333         https://bugs.webkit.org/show_bug.cgi?id=199971
334         <rdar://problem/51951218>
335
336         Reviewed by Alex Christensen.
337
338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
339         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
340         (TestWebKitAPI::TEST):
341
342 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
343
344         [ews-build] Add an EWS to run services tests
345         https://bugs.webkit.org/show_bug.cgi?id=199994
346
347         Reviewed by Jonathan Bedard.
348
349         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
350         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
351         * BuildSlaveSupport/ews-build/steps.py:
352         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
353         (RunEWSUnitTests): Build step to run EWS unit-tests.
354         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
355         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
356         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
357
358 2019-07-22  Youenn Fablet  <youenn@apple.com>
359
360         Disable MediaRecorder for legacy WebKit
361         https://bugs.webkit.org/show_bug.cgi?id=200001
362         <rdar://problem/53400030>
363
364         Reviewed by Eric Carlson.
365
366         Enable MediaRecorder for testing purposes.
367
368         * DumpRenderTree/mac/DumpRenderTree.mm:
369         (createWebViewAndOffscreenWindow):
370
371 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
372
373         results.webkit.org: Timeline header is too small
374         https://bugs.webkit.org/show_bug.cgi?id=199955
375
376         Reviewed by Aakash Jain.
377
378         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
379         (.timeline>.header): Make timeline header larder to fit configuration names.
380
381 2019-07-22  Alex Christensen  <achristensen@webkit.org>
382
383         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
384         https://bugs.webkit.org/show_bug.cgi?id=199954
385
386         Reviewed by Geoff Garen.
387
388         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
389         (TEST):
390
391 2019-07-22  Alex Christensen  <achristensen@webkit.org>
392
393         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
394         https://bugs.webkit.org/show_bug.cgi?id=199917
395
396         Reviewed by Sam Weinig.
397
398         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
399         (TEST):
400
401 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
402
403         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
404         https://bugs.webkit.org/show_bug.cgi?id=199980
405
406         Reviewed by Jonathan Bedard.
407
408         * BuildSlaveSupport/ews-build/steps.py:
409         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
410         * BuildSlaveSupport/ews-build/steps_unittest.py:
411         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
412         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
413
414 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
415
416         [webkitpy] Add an unit test for setting up the driver environment without starting it.
417         https://bugs.webkit.org/show_bug.cgi?id=199945
418
419         Reviewed by Michael Catanzaro.
420
421         This adds an unit test for the change implemented in r247663.
422
423         * Scripts/webkitpy/port/driver_unittest.py:
424         (DriverTest.test_setup_environ_base_vars):
425         (DriverTest):
426         (DriverTest.test_setup_environ_without_starting_driver):
427
428 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
429
430         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
431         https://bugs.webkit.org/show_bug.cgi?id=199993
432         <rdar://problem/49523528>
433
434         Reviewed by Beth Dakin.
435
436         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
437
438         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
439         (TestWebKitAPI::TEST):
440         * TestWebKitAPI/cocoa/TestWKWebView.h:
441
442 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
443
444         Add accessibilityInsertText for text insertion in edit fields.
445         https://bugs.webkit.org/show_bug.cgi?id=199973
446
447         Reviewed by Chris Fleizach.
448
449         Renamed accessibilityInsertText to _accessibilityInsertText.
450
451         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
452         (AccessibilityUIElement::insertText):
453         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
454         (AccessibilityUIElement::insertText):
455         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
456         (WTR::AccessibilityUIElement::insertText):
457         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
458         (WTR::AccessibilityUIElement::insertText):
459
460 2019-07-20  Chris Dumez  <cdumez@apple.com>
461
462         Speed up HashTable decoding by reserving capacity and avoiding rehashing
463         https://bugs.webkit.org/show_bug.cgi?id=199982
464
465         Reviewed by Saam Barati.
466
467         Add API test coverage.
468
469         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
470         (TestWebKitAPI::TEST):
471
472 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
473
474         Add accessibilityInsertText for text insertion in edit fields.
475         https://bugs.webkit.org/show_bug.cgi?id=199973
476
477         Reviewed by Chris Fleizach.
478
479         Glue code to run new LayoutTests.
480         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
481         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
482         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
483         (WTR::AccessibilityUIElement::insertText):
484         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
485         (WTR::AccessibilityUIElement::insertText):
486         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
487         (WTR::AccessibilityUIElement::insertText):
488         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
489         (WTR::AccessibilityUIElement::insertText):
490
491 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
492
493         Move webkit.css to opensource to support resultsdbpy's frontend
494         https://bugs.webkit.org/show_bug.cgi?id=199957
495
496         Reviewed by Jonathan Bedard.
497
498         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
499         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
500         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
501         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
502
503 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
504
505         Move Ref.js to WebKit to support resultsdbpy's frontend
506         https://bugs.webkit.org/show_bug.cgi?id=199956
507
508         Reviewed by Jonathan Bedard.
509
510         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
511         * resultsdbpy/resultsdbpy/view/static/js/search.js:
512         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
513         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
514         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
515         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
516         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
517         * resultsdbpy/resultsdbpy/view/templates/base.html:
518         * resultsdbpy/resultsdbpy/view/templates/commits.html:
519         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
520         * resultsdbpy/resultsdbpy/view/templates/search.html:
521         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
522         * resultsdbpy/resultsdbpy/view/view_routes.py:
523
524 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
525
526         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
527         https://bugs.webkit.org/show_bug.cgi?id=199945
528
529         Reviewed by Michael Catanzaro.
530
531         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
532         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
533         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
534
535         * Scripts/webkitpy/port/driver.py:
536         (Driver._setup_environ_for_driver):
537         (Driver._create_temporal_directories):
538         (Driver):
539         (Driver._start):
540         (Driver._delete_temporal_directories):
541         (Driver.stop):
542         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
543         (main):
544         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
545         (WebDriverTestRunner.__init__):
546         * glib/api_test_runner.py:
547         (TestRunner._setup_testing_environment): Ditto.
548
549 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
550
551         [ews-build] Display pre-existing Layout test failure names in the build summary
552         https://bugs.webkit.org/show_bug.cgi?id=199941
553
554         Reviewed by Jonathan Bedard.
555
556         * BuildSlaveSupport/ews-build/steps.py:
557         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
558
559 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
560
561         [GTK][WPE] run-webkit-tests should run with a temporal homedir
562         https://bugs.webkit.org/show_bug.cgi?id=199738
563
564         Reviewed by Michael Catanzaro.
565
566         Run the tests with an empty homedir that is created inside the driver tmpdir.
567         The driver tmpdir is a random directory created for each test runner that is purged after the run.
568
569         This is done to ensure that the test results are not affected by the user settings of any library.
570
571         * Scripts/webkitpy/port/driver.py:
572         (Driver._setup_environ_for_driver):
573         * Scripts/webkitpy/port/driver_unittest.py:
574         (DriverTest.test_setup_environ_base_vars):
575         (DriverTest):
576         (DriverTest.test_create_temporal_home_dir):
577
578 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
579
580         Remove pywebsockets from thirdparty
581         https://bugs.webkit.org/show_bug.cgi?id=199710
582
583         Reviewed by Jonathan Bedard.
584
585         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
586         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
587
588         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
589         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
590         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
591         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
592         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
593         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
594         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
595         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
596         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
597         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
598         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
599         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
600         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
601         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
602         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
603         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
604         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
605         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
606         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
607         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
608         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
609         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
610
611 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
612
613         results.webkit.org: Move resultsdbpy to WebKit
614         https://bugs.webkit.org/show_bug.cgi?id=199837
615         <rdar://problem/53172130>
616
617         Rubber-stamped by Aakash Jain.
618
619         Moving the entirety of the resultsdbpy library, which provides utilities to build
620         a database designed to store, visualize and organize test results, into WebKit.
621
622         * Scripts/webkitpy/style/checker.py:
623         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
624         * resultsdbpy: Added.
625         * resultsdbpy/MANIFEST.in: Added.
626         * resultsdbpy/README.md: Added.
627         * resultsdbpy/resultsdbpy: Added.
628         * resultsdbpy/resultsdbpy/__init__.py: Added.
629         * resultsdbpy/resultsdbpy/controller: Added.
630         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
631         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
632         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
633         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
634         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
635         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
636         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
637         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
638         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
639         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
640         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
641         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
642         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
643         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
644         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
645         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
646         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
647         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
648         * resultsdbpy/resultsdbpy/flask_support: Added.
649         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
650         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
651         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
652         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
653         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
654         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
655         * resultsdbpy/resultsdbpy/model: Added.
656         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
657         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
658         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
659         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
660         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
661         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
662         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
663         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
664         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
665         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
666         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
667         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
668         * resultsdbpy/resultsdbpy/model/docker.py: Added.
669         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
670         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
671         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
672         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
673         * resultsdbpy/resultsdbpy/model/model.py: Added.
674         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
675         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
676         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
677         * resultsdbpy/resultsdbpy/model/repository.py: Added.
678         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
679         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
680         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
681         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
682         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
683         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
684         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
685         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
686         * resultsdbpy/resultsdbpy/run-tests: Added.
687         * resultsdbpy/resultsdbpy/view: Added.
688         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
689         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
690         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
691         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
692         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
693         * resultsdbpy/resultsdbpy/view/static: Added.
694         * resultsdbpy/resultsdbpy/view/static/css: Added.
695         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
696         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
697         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
698         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
699         * resultsdbpy/resultsdbpy/view/static/js: Added.
700         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
701         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
702         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
703         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
704         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
705         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
706         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
707         * resultsdbpy/resultsdbpy/view/templates: Added.
708         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
709         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
710         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
711         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
712         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
713         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
714         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
715         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
716         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
717         * resultsdbpy/setup.py: Added.
718
719 2019-07-18  Alex Christensen  <achristensen@webkit.org>
720
721         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
722         https://bugs.webkit.org/show_bug.cgi?id=199923
723
724         Reviewed by Youenn Fablet.
725
726         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
727         (TestWebKitAPI::TEST):
728
729 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
730
731         [ews-build] Enable iOS WK2 tester queue on new EWS
732         https://bugs.webkit.org/show_bug.cgi?id=199867
733
734         Reviewed by Jonathan Bedard.
735
736         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
737         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
739         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
740
741 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
742
743         [ews-build] Add build step to AnalyzeLayoutTestsResults
744         https://bugs.webkit.org/show_bug.cgi?id=199877
745
746         Reviewed by Jonathan Bedard.
747
748         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
749
750         * BuildSlaveSupport/ews-build/steps.py:
751         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
752         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
753         (AnalyzeLayoutTestsResults.report_failure):
754         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
755         (AnalyzeLayoutTestsResults.retry_build):
756         (AnalyzeLayoutTestsResults._results_failed_different_tests):
757         (AnalyzeLayoutTestsResults._report_flaky_tests):
758         (AnalyzeLayoutTestsResults.start):
759         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
760
761 2019-07-18  Alex Christensen  <achristensen@webkit.org>
762
763         Move NetworkCache ownership from NetworkProcess to NetworkSession
764         https://bugs.webkit.org/show_bug.cgi?id=199817
765
766         Reviewed by Geoff Garen.
767
768         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
769         (TEST):
770         * TestWebKitAPI/cocoa/TestWKWebView.h:
771         * TestWebKitAPI/cocoa/TestWKWebView.mm:
772         (-[WKWebView synchronouslyLoadRequest:]):
773
774 2019-07-18  Youenn Fablet  <youenn@apple.com>
775
776         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
777         https://bugs.webkit.org/show_bug.cgi?id=199769
778         <rdar://problem/49390297>
779
780         Reviewed by Myles C. Maxfield.
781
782         Add a font containing one extended character not found in system fonts.
783
784         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
785         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
786
787 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
788
789         Unreviewed, Add Olivier Blin as contributor
790
791         * Scripts/webkitpy/common/config/contributors.json:
792
793 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
794
795         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
796         https://bugs.webkit.org/show_bug.cgi?id=199855
797
798         Reviewed by Michael Catanzaro.
799
800         The webkitpy drivers for GTK and WPE use their own versions for setting
801         up the environment and starting/stopping the drivers.
802         This refactors those drivers to use the base class driver functions.
803         As a benefit we get some fixes like support for setting the profiler
804         environment variables, and a simpler code.
805
806         * Scripts/webkitpy/port/driver.py:
807         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
808         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
809         * Scripts/webkitpy/port/headlessdriver.py:
810         (HeadlessDriver._setup_environ_for_test):
811         * Scripts/webkitpy/port/waylanddriver.py:
812         (WaylandDriver._setup_environ_for_test):
813         * Scripts/webkitpy/port/westondriver.py:
814         (WestonDriver._setup_environ_for_test):
815         (WestonDriver.stop):
816         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
817         (WestonDriverTest.make_driver):
818         * Scripts/webkitpy/port/xorgdriver.py:
819         (XorgDriver._setup_environ_for_test):
820         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
821         (XvfbDriver._setup_environ_for_test):
822         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
823         (XvfbDriverTest.make_driver):
824         (XvfbDriverTest.test_start):
825         (XvfbDriverTest.test_start_arbitrary_worker_number):
826         * Scripts/webkitpy/w3c/wpt_runner.py:
827         (main): Start the driver before trying to get its environment to define all the environment variables.
828         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
829         (WebDriverTestRunner.__init__): Ditto.
830         * glib/api_test_runner.py:
831         (TestRunner._setup_testing_environment): Ditto.
832
833 2019-07-17  Antoine Quint  <graouts@apple.com>
834
835         Disable Pointer Events prior to watchOS 6
836         https://bugs.webkit.org/show_bug.cgi?id=199890
837         <rdar://problem/53206113>
838
839         Reviewed by Dean Jackson.
840
841         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
842
843 2019-07-17  Christopher Reid  <chris.reid@sony.com>
844
845         Bytecode cache should use FileSystem
846         https://bugs.webkit.org/show_bug.cgi?id=199759
847
848         Reviewed by Yusuke Suzuki.
849
850         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
851
852 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
853
854         check-webkit-style: Add limited Python3 support
855         https://bugs.webkit.org/show_bug.cgi?id=199870
856
857         Rubber-stamped by Aakash Jain.
858
859         Since new services will be added in the near future which are Python 3, we
860         need to support Python 3 style checks. For now, assume all Python files are
861         Python 2 unless otherwise specified.
862
863         * Scripts/webkitpy/style/checker.py:
864         (_all_categories): Add pycodestyle to valid categories for testing.
865         (CheckerDispatcher._create_checker): Check that the provided Python file is in
866         one of the declared Python 3 directories.
867         * Scripts/webkitpy/style/checkers/python.py:
868         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
869         instead of pep8.
870         (Python3Checker.__init__):
871         (Python3Checker.check):
872         * Scripts/webkitpy/thirdparty/__init__.py:
873         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
874         (AutoinstallImportHook._install_pycodestyle):
875
876 2019-07-17  Sam Weinig  <weinig@apple.com>
877
878         Add StringBuilder member function which allows makeString() style variadic argument construction
879         https://bugs.webkit.org/show_bug.cgi?id=198997
880
881         Reviewed by Darin Adler.
882
883         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
884         Add basic test showing that StringBuilder::flexibleAppend can be used to 
885         append one or more string adaptable types. 
886
887         * TestWebKitAPI/CMakeLists.txt:
888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
889         Add WTFStringUtilities.cpp
890
891         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
892         Add basic test showing that StringBuilder::flexibleAppend can be used to 
893         append one or more string adaptable types. 
894
895         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
896         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
897         * TestWebKitAPI/WTFStringUtilities.h:
898         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
899         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
900
901 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
902
903         Remove the file superfluously added in r247535.
904
905         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
906         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
907
908 2019-07-17  Alex Christensen  <achristensen@webkit.org>
909
910         Add a runtime-disabled dialog element skeleton
911         https://bugs.webkit.org/show_bug.cgi?id=199839
912
913         Reviewed by Ryosuke Niwa.
914
915         * DumpRenderTree/mac/DumpRenderTree.mm:
916         (resetWebPreferencesToConsistentValues):
917         * WebKitTestRunner/TestController.cpp:
918         (WTR::TestController::resetPreferencesToConsistentValues):
919         Enable the dialog element for layout tests.
920
921 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
922
923         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
924         https://bugs.webkit.org/show_bug.cgi?id=199851
925
926         Reviewed by Wenson Hsieh.
927
928         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
929         this code is getting directly triggered from UIKeyboard's code.
930
931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
932         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
933         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
934         * TestWebKitAPI/ios/UIKitSPI.h:
935
936 2019-07-17  Commit Queue  <commit-queue@webkit.org>
937
938         Unreviewed, rolling out r247505.
939         https://bugs.webkit.org/show_bug.cgi?id=199871
940
941         "Caused failed ASSERT in stress test" (Requested by creid on
942         #webkit).
943
944         Reverted changeset:
945
946         "Bytecode cache should use FileSystem"
947         https://bugs.webkit.org/show_bug.cgi?id=199759
948         https://trac.webkit.org/changeset/247505
949
950 2019-07-17  Russell Epstein  <russell_e@apple.com>
951
952         Adding self to contributors.json
953
954         Unreviewed.
955
956         * Scripts/webkitpy/common/config/contributors.json:
957
958 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
959
960         [ews-build] Parse full_results.json for layout-tests
961         https://bugs.webkit.org/show_bug.cgi?id=199804
962
963         Reviewed by Jonathan Bedard.
964
965         * BuildSlaveSupport/ews-build/steps.py:
966         (RunWebKitTests.start): Monitor json output.
967         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
968         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
969         by the patch or are pre-existing.
970         (ReRunWebKitTests.commandComplete): Ditto.
971         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
972         * BuildSlaveSupport/ews-build/steps_unittest.py:
973         (BuildStepMixinAdditions.getProperty): Added.
974         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
975         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
976
977 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
978
979         Unreviewed, rolling out r247512.
980
981         Broke API test runners
982
983         Reverted changeset:
984
985         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
986         for setting up the environment and start the drivers."
987         https://bugs.webkit.org/show_bug.cgi?id=199855
988         https://trac.webkit.org/changeset/247512
989
990 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
991
992         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
993         https://bugs.webkit.org/show_bug.cgi?id=199855
994
995         Reviewed by Carlos Garcia Campos.
996
997         The webkitpy drivers for GTK and WPE use their own versions for setting
998         up the environment and starting/stopping the drivers.
999         This refactors those drivers to use the base class driver functions.
1000         As a benefit we get some fixes like support for setting the profiler
1001         environment variables, and a simpler code.
1002
1003         * Scripts/webkitpy/port/driver.py:
1004         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
1005         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
1006         * Scripts/webkitpy/port/headlessdriver.py:
1007         (HeadlessDriver._setup_environ_for_test):
1008         * Scripts/webkitpy/port/waylanddriver.py:
1009         (WaylandDriver._setup_environ_for_test):
1010         * Scripts/webkitpy/port/westondriver.py:
1011         (WestonDriver._setup_environ_for_test):
1012         (WestonDriver.stop):
1013         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
1014         (WestonDriverTest.make_driver):
1015         * Scripts/webkitpy/port/xorgdriver.py:
1016         (XorgDriver._setup_environ_for_test):
1017         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
1018         (XvfbDriver._setup_environ_for_test):
1019         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
1020         (XvfbDriverTest.make_driver):
1021         (XvfbDriverTest.test_start):
1022         (XvfbDriverTest.test_start_arbitrary_worker_number):
1023
1024 2019-07-16  Christopher Reid  <chris.reid@sony.com>
1025
1026         Bytecode cache should use FileSystem
1027         https://bugs.webkit.org/show_bug.cgi?id=199759
1028
1029         Reviewed by Yusuke Suzuki.
1030
1031         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1032
1033 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
1034
1035         svn-create-patch duplicates diffs when adding directories
1036         https://bugs.webkit.org/show_bug.cgi?id=199842
1037
1038         Reviewed by Dewei Zhu.
1039
1040         * Scripts/svn-create-patch:
1041         (findKind): Add function which returns what 'kind' of file the provided path is.
1042         (generateFileList): If the path is a directory and being added, don't add it.
1043         Instead, rely on the fact that its children will be added.
1044
1045 2019-07-16  Tim Horton  <timothy_horton@apple.com>
1046
1047         NSTextFinder holes don't scroll with the page
1048         https://bugs.webkit.org/show_bug.cgi?id=199815
1049         <rdar://problem/52280514>
1050
1051         Reviewed by Simon Fraser.
1052
1053         * MiniBrowser/mac/WK2BrowserWindowController.m:
1054         (-[MiniBrowserNSTextFinder performAction:]):
1055         (-[WK2BrowserWindowController awakeFromNib]):
1056         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
1057         -performAction: so that we can intercept the close action and
1058         hide our own find UI, since there is no delegate for that action yet.
1059
1060         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1061         (TEST):
1062
1063 2019-07-15  Keith Miller  <keith_miller@apple.com>
1064
1065         JSGlobalObject type macros should support feature flags and WeakRef should have one
1066         https://bugs.webkit.org/show_bug.cgi?id=199601
1067
1068         Reviewed by Mark Lam.
1069
1070         JSC options need to be set before the window is created for the test.
1071
1072         * DumpRenderTree/mac/DumpRenderTree.mm:
1073         (resetWebViewToConsistentStateBeforeTesting):
1074         * DumpRenderTree/win/DumpRenderTree.cpp:
1075         (setJSCOptions):
1076         (resetWebViewToConsistentStateBeforeTesting):
1077
1078 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1079
1080         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
1081         https://bugs.webkit.org/show_bug.cgi?id=193108
1082
1083         Reviewed by Simon Fraser.
1084
1085         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
1086         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
1087         at the wrong scale.
1088
1089         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1090         (takeWindowSnapshot):
1091         (createBitmapContextFromWebView):
1092
1093 2019-07-15  Brady Eidson  <beidson@apple.com>
1094
1095         Make WKURLSchemeTask thread safe.
1096         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
1097
1098         Reviewed by Alex Christensen.
1099
1100         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1101
1102 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
1103
1104         Unreviewed, a build fix after r247437
1105
1106         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1107         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
1108
1109 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1110
1111         [macOS 10.15] Cannot unbold selected text when the system font is used
1112         https://bugs.webkit.org/show_bug.cgi?id=199788
1113         <rdar://problem/52142570>
1114
1115         Reviewed by Tim Horton.
1116
1117         Add a new API test to verify that bolding and unbolding updates the
1118         shared font manager's selected font.
1119
1120         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1121         (TestWebKitAPI::TEST):
1122
1123 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
1124
1125         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
1126         https://bugs.webkit.org/show_bug.cgi?id=199790
1127         <rdar://problem/52790112>
1128
1129         Reviewed by Brent Fulgham.
1130
1131         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
1132
1133         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1134         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
1135         (configureSOAuthorizationWebView):
1136         (TestWebKitAPI::TEST):
1137         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
1138         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
1139         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1140         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
1141         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
1142
1143 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
1144
1145         window.openDatabase is not writable
1146         https://bugs.webkit.org/show_bug.cgi?id=199737
1147         <rdar://problem/52551332>
1148
1149         Reviewed by Chris Dumez.
1150
1151         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
1152         (TEST):
1153         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
1154
1155 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
1156
1157         [ews-build] Parse and display layout test failures
1158         https://bugs.webkit.org/show_bug.cgi?id=199709
1159
1160         Rubber-stamped by Jonathan Bedard.
1161
1162         * BuildSlaveSupport/ews-build/steps.py:
1163         (RunWebKitTests.start): Initialize log_observer.
1164         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
1165         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
1166         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
1167         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
1168         (RunWebKitTests.getResultSummary): Update build and step summary.
1169         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
1170
1171 2019-07-15  Commit Queue  <commit-queue@webkit.org>
1172
1173         Unreviewed, rolling out r247393.
1174         https://bugs.webkit.org/show_bug.cgi?id=199797
1175
1176         broke mips and arm EWS (Requested by guijemont on #webkit).
1177
1178         Reverted changeset:
1179
1180         "run-javascriptcore-tests won't report test results for
1181         testmasm, testair, testb3, testdfg and test api"
1182         https://bugs.webkit.org/show_bug.cgi?id=199489
1183         https://trac.webkit.org/changeset/247393
1184
1185 2019-07-12  Andy Estes  <aestes@apple.com>
1186
1187         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
1188         https://bugs.webkit.org/show_bug.cgi?id=199768
1189         <rdar://problem/52002206>
1190
1191         Reviewed by Geoffrey Garen.
1192
1193         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1194         (TEST):
1195
1196 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1197
1198         [ews-build] Remove wincairo queue from old EWS and dashboard
1199         https://bugs.webkit.org/show_bug.cgi?id=199776
1200
1201         Reviewed by Don Olmstead.
1202
1203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1204         * QueueStatusServer/config/queues.py:
1205
1206 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1207
1208         [ews-build] Enable wincairo queue on new EWS
1209         https://bugs.webkit.org/show_bug.cgi?id=199593
1210
1211         Reviewed by Don Olmstead.
1212
1213         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
1214         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
1215         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1216         (StatusBubble): Enable wincairo status-bubble.
1217
1218 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1219
1220         [ews-app] Enable logging for clicking SubmitToEWS button
1221         https://bugs.webkit.org/show_bug.cgi?id=199757
1222
1223         Unreviewed minor infrastructure fix.
1224
1225         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1226         (SubmitToEWS.post): Change logging level from debug to info.
1227
1228 2019-07-12  Alex Christensen  <achristensen@webkit.org>
1229
1230         Enable client certificate authentication unit test
1231         https://bugs.webkit.org/show_bug.cgi?id=199735
1232
1233         Reviewed by Chris Dumez.
1234
1235         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1236         (TEST):
1237         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
1238         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
1239
1240 2019-07-12  Alex Christensen  <achristensen@webkit.org>
1241
1242         Begin unifying TestWebKitAPI build
1243         https://bugs.webkit.org/show_bug.cgi?id=199728
1244
1245         Reviewed by Keith Miller.
1246
1247         * TestWebKitAPI/Configurations/Base.xcconfig:
1248         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
1249         * TestWebKitAPI/Sources.txt: Added.
1250         * TestWebKitAPI/SourcesCocoa.txt: Added.
1251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1252
1253 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
1254
1255         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1256         https://bugs.webkit.org/show_bug.cgi?id=199489
1257         <rdar://problem/47891081>
1258
1259         Reviewed by Aakash Jain.
1260
1261         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1262         (RunJavaScriptCoreTests.countFailures):
1263         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1264         * Scripts/run-javascriptcore-tests:
1265         (runTest):
1266         (reportTestFailures):
1267         (runJSCStressTests):
1268
1269 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
1270
1271         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
1272         https://bugs.webkit.org/show_bug.cgi?id=199743
1273
1274         Reviewed by Jonathan Bedard.
1275
1276         * BuildSlaveSupport/ews-build/steps.py:
1277         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1278
1279 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
1280
1281         Unreviewed follow-up fix to r247364.
1282         [ews-build] Add build step to clean up .git/index.lock file
1283         https://bugs.webkit.org/show_bug.cgi?id=199722
1284
1285         * BuildSlaveSupport/ews-build/steps.py:
1286         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
1287         to be run after this step.
1288
1289 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
1290
1291         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
1292         https://bugs.webkit.org/show_bug.cgi?id=199524
1293         <rdar://problem/52783816>
1294
1295         Reviewed by Saam Barati.
1296
1297         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
1298         But this test has several problems.
1299
1300         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
1301            number is calculated by pageSize / sizeof(T), and this does not account the header
1302            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
1303            is very small, we can have many objects in one IsoPage. As a result, we need a large
1304            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
1305            less than numObjects.
1306
1307         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
1308            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
1309            page. This also makes the intention of this test wrong.
1310
1311         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
1312
1313         We make this test robust while we still keep this test white-box one to test the critical feature
1314         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
1315         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
1316         tier live, and check whether the deallocated memory is reused.
1317
1318         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1319         (TEST):
1320
1321 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
1322
1323         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
1324         https://bugs.webkit.org/show_bug.cgi?id=199625
1325
1326         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
1327         with ENABLE(ACCESSIBILITY) in the code.
1328
1329         Additionally, the TestRunner code generator now honors the
1330         Conditional IDL format.
1331
1332         Reviewed by Konstantin Tokarev.
1333
1334         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1335         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
1336         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
1337         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1338         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1339         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
1340         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
1341         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1342         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1343         (_generateImplementationFile):
1344
1345 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
1346
1347         [ews-build] Add build step to clean up .git/index.lock file
1348         https://bugs.webkit.org/show_bug.cgi?id=199722
1349
1350         Reviewed by Jonathan Bedard.
1351
1352         * BuildSlaveSupport/ews-build/steps.py:
1353         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
1354         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
1355         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
1356         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1357
1358 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
1359
1360         [iOS 13] Enable WebKit build
1361         https://bugs.webkit.org/show_bug.cgi?id=199481
1362         <rdar://problem/52619048>
1363
1364         Reviewed by Tim Horton.
1365
1366         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
1367
1368 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
1369
1370         Add test expectations and baselines for iOS 13
1371         https://bugs.webkit.org/show_bug.cgi?id=199329
1372
1373         Reviewed by Jonathan Bedard.
1374
1375         * Scripts/webkitpy/port/ios.py:
1376         (IOSPort): Increment current version to 13.
1377         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
1378         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
1379         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
1380         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
1381         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
1382         (IOSSimulatorTest.make_port):
1383         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
1384         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
1385         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
1386         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
1387         (IOSTest.make_port):
1388
1389 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
1390
1391         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
1392         https://bugs.webkit.org/show_bug.cgi?id=199692
1393
1394         Reviewed by Chris Fleizach.
1395
1396         Add support for output of AXDeletion and AXInsertion roles for tests.
1397         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
1398         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
1399
1400         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1401         * gtk/jhbuild.modules:
1402         * wpe/jhbuild.modules:
1403
1404 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
1405
1406         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
1407         https://bugs.webkit.org/show_bug.cgi?id=199707
1408
1409         Reviewed by Aakash Jain.
1410
1411         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
1412
1413 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
1414
1415         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
1416         https://bugs.webkit.org/show_bug.cgi?id=199693
1417         rdar://problem/51930364
1418
1419         Reviewed by Tim Horton.
1420         
1421         New API tests that test scrollability with various combinations of content, insets,
1422         input accessory bars etc.
1423
1424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1425         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
1426         (TestWebKitAPI::webViewWithAutofocusedInput):
1427         (TestWebKitAPI::TEST):
1428
1429 2019-07-10  Tim Horton  <timothy_horton@apple.com>
1430
1431         Long pressing on attachments will crash the WebContent process
1432         https://bugs.webkit.org/show_bug.cgi?id=199696
1433         <rdar://problem/52920241>
1434
1435         Reviewed by Dean Jackson.
1436
1437         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1438         (TestWebKitAPI::TEST):
1439         Add a test that previously crashed.
1440
1441 2019-07-10  Dean Jackson  <dino@apple.com>
1442
1443         Support MacCatalyst in run-webkit-app
1444         https://bugs.webkit.org/show_bug.cgi?id=199690
1445
1446         Reviewed by Tim Horton.
1447
1448         Add a --maccatalyst option to run-webkit-app that
1449         can launch MacCatalyst applications with a built WebKit.
1450
1451         * Scripts/webkitdirs.pm:
1452         (argumentsForConfiguration):
1453         (determineXcodeSDK):
1454         (xcodeSDKPlatformName):
1455         (determineConfigurationProductDir):
1456         (determinePortName):
1457         (isCatalystWebKit):
1458         (isAppleCocoaWebKit):
1459         (willUseCatalystSDK):
1460
1461 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
1462
1463         [MacOS] Filter VPA info logged to stdout
1464         https://bugs.webkit.org/show_bug.cgi?id=199673
1465
1466         Reviewed by Eric Carlson.
1467
1468         * Scripts/webkitpy/port/mac.py:
1469         (MacPort.logging_patterns_to_strip):
1470
1471 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
1472
1473         Unreviewed, rolling out r247286.
1474
1475         Caused TestWTF.WTF.StringOperators to fail on debug bots
1476
1477         Reverted changeset:
1478
1479         "Add StringBuilder member function which allows makeString()
1480         style variadic argument construction"
1481         https://bugs.webkit.org/show_bug.cgi?id=198997
1482         https://trac.webkit.org/changeset/247286
1483
1484 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
1485
1486         [ews-build] Explicitly use perl or python while invoking scripts
1487         https://bugs.webkit.org/show_bug.cgi?id=199669
1488
1489         Reviewed by Jonathan Bedard.
1490
1491         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
1492         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1493
1494 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
1495
1496         Run tests on mips EWS
1497         https://bugs.webkit.org/show_bug.cgi?id=196854
1498
1499         Reviewed by Carlos Garcia Campos.
1500
1501         * Scripts/webkitpy/common/config/ews.json:
1502
1503 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1504
1505         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
1506         https://bugs.webkit.org/show_bug.cgi?id=199579
1507
1508         Reviewed by Carlos Garcia Campos.
1509
1510         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
1511         (TestWebKitAPI::TEST):
1512
1513 2019-07-09  Chris Dumez  <cdumez@apple.com>
1514
1515         Fix integer type encoding / decoding in WKRemoteObjectCoder
1516         https://bugs.webkit.org/show_bug.cgi?id=199643
1517         <rdar://problem/52732342>
1518
1519         Reviewed by Anders Carlsson.
1520
1521         Update API test coverage.
1522
1523         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1524         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1525         (TEST):
1526         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1527         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
1528         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
1529         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
1530         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
1531
1532 2019-07-09  Sam Weinig  <weinig@apple.com>
1533
1534         Add StringBuilder member function which allows makeString() style variadic argument construction
1535         https://bugs.webkit.org/show_bug.cgi?id=198997
1536
1537         Reviewed by Darin Adler.
1538
1539         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1540         Add basic test showing that StringBuilder::flexibleAppend can be used to 
1541         append one or more string adaptable types. 
1542
1543 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
1544
1545         Only allow fetching and removing session credentials from WebsiteDataStore
1546         https://bugs.webkit.org/show_bug.cgi?id=199385
1547         <rdar://problem/52622080>
1548
1549         Reviewed by Alex Christensen.
1550
1551         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
1552         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
1553         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
1554
1555         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1556         (TEST):
1557         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1558         (TestWebKitAPI::TEST):
1559
1560 2019-07-09  Alex Christensen  <achristensen@webkit.org>
1561
1562         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
1563         https://bugs.webkit.org/show_bug.cgi?id=199628
1564
1565         Reviewed by Brady Eidson.
1566
1567         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1568         (TestWebKitAPI::TEST_F):
1569
1570 2019-07-09  Alex Christensen  <achristensen@webkit.org>
1571
1572         Remove invalid assertion in URLParser::domainToASCII
1573         https://bugs.webkit.org/show_bug.cgi?id=199624
1574
1575         Reviewed by Brady Eidson.
1576
1577         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1578         (TestWebKitAPI::TEST_F):
1579
1580 2019-07-09  Alex Christensen  <achristensen@webkit.org>
1581
1582         URLParser should reserialize IPv6 addresses that end with a colon
1583         https://bugs.webkit.org/show_bug.cgi?id=199627
1584
1585         Reviewed by Brady Eidson.
1586
1587         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
1588         (TestWebKitAPI::TEST_F):
1589
1590 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
1591
1592         [ews-build] Do not run unix commands for windows in PrintConfiguration
1593         https://bugs.webkit.org/show_bug.cgi?id=199605
1594
1595         Reviewed by Jonathan Bedard.
1596
1597         * BuildSlaveSupport/ews-build/steps.py:
1598
1599 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1600
1601         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
1602         https://bugs.webkit.org/show_bug.cgi?id=199487
1603
1604         Reviewed by Ross Kirsling.
1605
1606         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
1607         failing to open testglobalscope_constructors_file which was
1608         created by using tempfile.mkstemp() because it keeps the file
1609         open. Use tempfile.mkdtemp() to create temporary files in the
1610         temporary directory instead of tempfile.mkstemp().
1611
1612         * Scripts/webkitpy/bindings/main.py:
1613         (BindingsTests.run_tests):
1614         (BindingsTests.main):
1615         (BindingsTests.close_and_remove): Deleted.
1616
1617 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
1618
1619         [ews-build] Add KillOldProcesses step before running API or Layout tests
1620         https://bugs.webkit.org/show_bug.cgi?id=199592
1621
1622         Reviewed by Jonathan Bedard.
1623
1624         * BuildSlaveSupport/ews-build/factories.py:
1625
1626 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
1627
1628         test-webkitpy: Explicitly use Python 2.7 lldb library
1629         https://bugs.webkit.org/show_bug.cgi?id=199578
1630         <rdar://problem/51853557>
1631
1632         Reviewed by Aakash Jain.
1633
1634         * Scripts/webkitpy/common/system/systemhost.py:
1635         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
1636         * Scripts/webkitpy/test/main.py:
1637         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
1638
1639 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
1640
1641         Add test expectations and baselines for Catalina
1642         https://bugs.webkit.org/show_bug.cgi?id=199328
1643
1644         Reviewed by Jonathan Bedard.
1645
1646         * Scripts/webkitpy/port/mac.py:
1647         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
1648
1649 2019-07-08  Christopher Reid  <chris.reid@sony.com>
1650
1651         Implement MappedFileData for Windows
1652         https://bugs.webkit.org/show_bug.cgi?id=198269
1653
1654         Reviewed by Darin Adler.
1655
1656         * TestWebKitAPI/PlatformWin.cmake:
1657
1658 2019-07-08  Charlie Turner  <cturner@igalia.com>
1659
1660         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
1661         https://bugs.webkit.org/show_bug.cgi?id=197558
1662
1663         Reviewed by Xabier Rodriguez-Calvar.
1664
1665         On shutdown we can easily deadlock the web process if we don't
1666         ensure all network operations are completed before comitting state
1667         changes. In HLS, make sure the network operations are cancelled,
1668         and also prevent hlsdemux's retry logic from scuppering our
1669         efforts.
1670
1671         * gstreamer/jhbuild.modules: Include the patch.
1672         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
1673
1674 2019-07-08  Antoine Quint  <graouts@apple.com>
1675
1676         [Pointer Events] Enable only on the most recent version of the supported iOS family
1677         https://bugs.webkit.org/show_bug.cgi?id=199562
1678         <rdar://problem/52766511>
1679
1680         Reviewed by Dean Jackson.
1681
1682         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1683
1684 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
1685
1686         Long hang when loading a cnn.com page on iOS
1687         https://bugs.webkit.org/show_bug.cgi?id=199556
1688
1689         Reviewed by Zalan Bujtas.
1690
1691         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
1692         to load a test page of your choice.
1693
1694         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
1695         (-[WebViewController viewDidLoad]):
1696
1697 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
1698
1699         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
1700         https://bugs.webkit.org/show_bug.cgi?id=199503
1701
1702         Reviewed by Wenson Hsieh.
1703
1704         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
1705         _requestActivatedElementAtPosition
1706
1707         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1708         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1709         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1710         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1711         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1712         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1713         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1714         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1715         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1716         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1717         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
1718         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
1719
1720 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
1721
1722         Unreviewed, rolling out r247115.
1723
1724         Breaks lldbWebKitTester (and by extension, test-webkitpy)
1725
1726         Reverted changeset:
1727
1728         "[WHLSL] Standard library is too big to directly include in
1729         WebCore"
1730         https://bugs.webkit.org/show_bug.cgi?id=198186
1731         https://trac.webkit.org/changeset/247115
1732
1733 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
1734
1735         Unreviewed, rolling out r247123.
1736
1737         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
1738         fail.
1739
1740         Reverted changeset:
1741
1742         "Only allow fetching and removing session credentials from
1743         WebsiteDataStore"
1744         https://bugs.webkit.org/show_bug.cgi?id=199385
1745         https://trac.webkit.org/changeset/247123
1746
1747 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1748
1749         Touching media controls sometimes shows software keyboard
1750         https://bugs.webkit.org/show_bug.cgi?id=199490
1751         <rdar://problem/52076270>
1752
1753         Reviewed by Eric Carlson.
1754
1755         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
1756         ChangeLog entries for more detail.
1757
1758         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1759         (WTR::UIScriptController::hasInputSession const):
1760         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1761         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1762         (WTR::UIScriptController::hasInputSession const):
1763         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1764         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1765         (WTR::UIScriptController::hasInputSession const):
1766
1767 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
1768
1769         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
1770         https://bugs.webkit.org/show_bug.cgi?id=199458
1771
1772         Reviewed by Michael Catanzaro.
1773
1774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1775         * QueueStatusServer/config/queues.py:
1776
1777 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1778
1779         [GTK] Fix browserperfdash script after r239522
1780         https://bugs.webkit.org/show_bug.cgi?id=199496
1781
1782         Reviewed by Michael Catanzaro.
1783
1784         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
1785         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
1786
1787 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1788
1789         [webkitpy] test-webkitpy is broken on Linux since r246662
1790         https://bugs.webkit.org/show_bug.cgi?id=199493
1791
1792         Reviewed by Michael Catanzaro.
1793
1794         * Scripts/webkitpy/test/main.py:
1795         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
1796
1797 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1798
1799         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
1800         https://bugs.webkit.org/show_bug.cgi?id=199406
1801
1802         Reviewed by Michael Catanzaro.
1803
1804         Install the Woff2 libraries and headers from the system package
1805         and stop building them on the JHBuild.
1806
1807         * gtk/install-dependencies:
1808         * gtk/jhbuild.modules:
1809         * wpe/install-dependencies:
1810         * wpe/jhbuild.modules:
1811
1812 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1813
1814         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
1815         https://bugs.webkit.org/show_bug.cgi?id=199449
1816
1817         Reviewed by Michael Catanzaro.
1818
1819         * Scripts/webkitdirs.pm:
1820         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
1821
1822 2019-07-01  Philippe Normand  <pnormand@igalia.com>
1823
1824         Unreviewed, GTK a11y tests fix after r247071
1825
1826         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1827         (WTR::AccessibilityUIElement::popupValue const):
1828
1829 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
1830
1831         [ews-build] Enable WPE and GTK queues on new EWS
1832         https://bugs.webkit.org/show_bug.cgi?id=199234
1833
1834         Reviewed by Jonathan Bedard.
1835
1836         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
1837         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
1838         * BuildSlaveSupport/ews-build/steps.py:
1839         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
1840         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1841         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1842         (StatusBubble): Enable gtk and wpe status-bubbles.
1843
1844 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
1845
1846         Only allow fetching and removing session credentials from WebsiteDataStore
1847         https://bugs.webkit.org/show_bug.cgi?id=199385
1848
1849         Reviewed by Alex Christensen.
1850
1851         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1852         (TestWebKitAPI::TEST):
1853
1854 2019-07-03  Tim Horton  <timothy_horton@apple.com>
1855
1856         UI process exception when dragging an <attachment> with no content type
1857         https://bugs.webkit.org/show_bug.cgi?id=199480
1858         <rdar://problem/44351353>
1859
1860         Reviewed by Wenson Hsieh.
1861
1862         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1863         (TestWebKitAPI::TEST):
1864         Add a test; before the change, it crashes.
1865
1866 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
1867
1868         [Catalina] Enable WebKit build
1869         https://bugs.webkit.org/show_bug.cgi?id=199209
1870
1871         Reviewed by Darin Adler.
1872
1873         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
1874
1875 2019-07-03  Sam Weinig  <weinig@apple.com>
1876
1877         Adopt simple structured bindings in more places
1878         https://bugs.webkit.org/show_bug.cgi?id=199247
1879
1880         Reviewed by Alex Christensen.
1881
1882         Replaces simple uses of std::tie() with structured bindings. Does not touch
1883         uses of std::tie() that are not initial declarations, use std::ignore or in
1884         case where the binding is captured by a lambda, as structured bindings don't
1885         work for those cases yet.
1886
1887         * TestWebKitAPI/ios/PreferredContentMode.mm:
1888         (TestWebKitAPI::TEST):
1889
1890 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
1891
1892         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
1893
1894         * BuildSlaveSupport/ews-build/steps.py:
1895         (PrintConfiguration.run):
1896
1897 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1898
1899         [ews-build] Add build steps to Install Wpe and Gtk dependencies
1900         https://bugs.webkit.org/show_bug.cgi?id=199408
1901
1902         Reviewed by Michael Catanzaro.
1903
1904         * BuildSlaveSupport/ews-build/steps.py:
1905         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
1906         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
1907         (InstallWpeDependencies): Ditto for WPE.
1908         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1909
1910 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1911
1912         [ews-build] Allow skipping uploading built product for few builders
1913         https://bugs.webkit.org/show_bug.cgi?id=199422
1914
1915         Reviewed by Michael Catanzaro.
1916
1917         * BuildSlaveSupport/ews-build/steps.py:
1918         (CompileWebKit.__init__): Added optional skipUpload parameter.
1919         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
1920
1921 2019-07-02  Tim Horton  <timothy_horton@apple.com>
1922
1923         REGRESSION (r243240): Unable to swipe back in Safari
1924         https://bugs.webkit.org/show_bug.cgi?id=199394
1925         <rdar://problem/51137447>
1926
1927         Reviewed by Wenson Hsieh.
1928
1929         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1930         Make sure that we actually end up with swipe gesture recognizers installed
1931         after process swap and crash.
1932
1933 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
1934
1935         Enhance support of aria-haspopup per ARIA 1.1 specification.
1936         https://bugs.webkit.org/show_bug.cgi?id=199216
1937         <rdar://problem/46221342>
1938
1939         Reviewed by Chris Fleizach.
1940
1941         * DumpRenderTree/AccessibilityUIElement.cpp:
1942         (getPopupValueCallback):
1943         (AccessibilityUIElement::getJSClass):
1944         * DumpRenderTree/AccessibilityUIElement.h:
1945         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1946         (AccessibilityUIElement::popupValue const):
1947         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1948         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1949         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1950         (WTR::AccessibilityUIElement::popupValue const):
1951         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1952         (WTR::AccessibilityUIElement::popupValue const):
1953
1954 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1955
1956         [ews-build] Do not print worker environment variables in each build step [part 2]
1957         https://bugs.webkit.org/show_bug.cgi?id=199405
1958
1959         Reviewed by Jonathan Bedard.
1960
1961         * BuildSlaveSupport/ews-build/steps.py:
1962         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
1963         (CleanWorkingDirectory.__init__): Ditto.
1964         (RunBindingsTests.__init__): Ditto.
1965         (RunWebKitPerlTests.__init__): Ditto.
1966         (RunWebKitPyTests.__init__): Ditto.
1967         (CompileWebKit.__init__): Ditto.
1968         (ArchiveTestResults.__init__): Ditto.
1969         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1970
1971 2019-07-02  Jer Noble  <jer.noble@apple.com>
1972
1973         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
1974         https://bugs.webkit.org/show_bug.cgi?id=199381
1975         <rdar://problem/52483103>
1976
1977         Reviewed by Eric Carlson.
1978
1979         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1980
1981 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1982
1983         [ews-build] Update bot configuration for WPE and GTK
1984         https://bugs.webkit.org/show_bug.cgi?id=199238
1985
1986         Reviewed by Michael Catanzaro.
1987
1988         * BuildSlaveSupport/ews-build/config.json:
1989
1990 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
1991
1992         [ews-build] Make PrintConfiguration platform aware
1993         https://bugs.webkit.org/show_bug.cgi?id=196657
1994
1995         Reviewed by Lucas Forschler.
1996
1997         * BuildSlaveSupport/ews-build/steps.py:
1998         (PrintConfiguration): Specified platform-specific command lists.
1999         (PrintConfiguration.run): Override run method and specify platform specific commands.
2000         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2001
2002 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
2003
2004         [Wasm-References] Disable references by default
2005         https://bugs.webkit.org/show_bug.cgi?id=199390
2006
2007         Reviewed by Saam Barati.
2008
2009         * Scripts/run-jsc-stress-tests:
2010
2011 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
2012
2013         Unreviewed. Revert r246965 to fix build break
2014         since r247019 reverted its related changes.
2015
2016         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2017         (WTR::AccessibilityUIElement::popupValue const): Deleted.
2018
2019 2019-07-01  Alex Christensen  <achristensen@webkit.org>
2020
2021         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
2022         https://bugs.webkit.org/show_bug.cgi?id=199371
2023         <rdar://problem/52352905>
2024
2025         Reviewed by Tim Horton.
2026
2027         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2028         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
2029         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
2030         (-[NavigationActionSPIDelegate spiCalled]):
2031         (TEST):
2032
2033 2019-07-01  Alex Christensen  <achristensen@webkit.org>
2034
2035         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
2036         https://bugs.webkit.org/show_bug.cgi?id=199296
2037         <rdar://problem/51041960>
2038
2039         Reviewed by Darin Adler.
2040
2041         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2042         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
2043
2044 2019-07-01  Truitt Savell  <tsavell@apple.com>
2045
2046         Unreviewed, rolling out r246958.
2047
2048         Broke inspector/dom/getAccessibilityPropertiesForNode.html
2049
2050         Reverted changeset:
2051
2052         "Enhance support of aria-haspopup per ARIA 1.1 specification."
2053         https://bugs.webkit.org/show_bug.cgi?id=199216
2054         https://trac.webkit.org/changeset/246958
2055
2056 2019-07-01  Philippe Normand  <pnormand@igalia.com>
2057
2058         Unreviewed, GTK a11y tests fix after r246958
2059
2060         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2061         (WTR::AccessibilityUIElement::popupValue const):
2062
2063 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
2064
2065         Enhance support of aria-haspopup per ARIA 1.1 specification.
2066         https://bugs.webkit.org/show_bug.cgi?id=199216
2067         <rdar://problem/46221342>
2068
2069         Reviewed by Chris Fleizach.
2070
2071         * DumpRenderTree/AccessibilityUIElement.cpp:
2072         (getPopupValueCallback):
2073         (AccessibilityUIElement::getJSClass):
2074         * DumpRenderTree/AccessibilityUIElement.h:
2075         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2076         (AccessibilityUIElement::popupValue const):
2077         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2078         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2079         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2080         (WTR::AccessibilityUIElement::popupValue const):
2081         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2082         (WTR::AccessibilityUIElement::popupValue const):
2083
2084 2019-06-28  Robin Morisset  <rmorisset@apple.com>
2085
2086         Adding myself as a reviewer to contributors.json.
2087
2088         Unreviewed.
2089
2090         * Scripts/webkitpy/common/config/contributors.json:
2091
2092 2019-06-28  Jer Noble  <jer.noble@apple.com>
2093
2094         Add new -[WKWebView _closeAllMediaPresentations] SPI
2095         https://bugs.webkit.org/show_bug.cgi?id=199294
2096         <rdar://problem/51965958>
2097
2098         Reviewed by Alex Christensen.
2099
2100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2101         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
2102         (TEST):
2103
2104 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
2105
2106         Add a regression test for change r246901
2107         https://bugs.webkit.org/show_bug.cgi?id=199290
2108
2109         Reviewed by Geoffrey Garen.
2110
2111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2112         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2113         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2114         (TEST):
2115         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
2116
2117 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
2118
2119         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
2120         https://bugs.webkit.org/show_bug.cgi?id=199317
2121
2122         Reviewed by Michael Catanzaro.
2123
2124         While IconDatabase and all code using it was removed,
2125         ENABLE_ICONDATABASE still exists as build option and C++ macro.
2126
2127         * Scripts/webkitperl/FeatureList.pm:
2128         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2129         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
2130         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
2131
2132 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2133
2134         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
2135         https://bugs.webkit.org/show_bug.cgi?id=199310
2136         <rdar://problem/52292137>
2137
2138         Reviewed by Megan Gardner.
2139
2140         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
2141         _elementDidFocus.
2142
2143         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2144         (TestWebKitAPI::TEST):
2145         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2146         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2147         (-[TestInputDelegate setDidStartInputSessionHandler:]):
2148         (-[TestInputDelegate didStartInputSessionHandler]):
2149
2150         Add plumbing for a handler block in TestInputDelegate.
2151
2152         (-[TestInputDelegate setWillStartInputSessionHandler:]):
2153
2154         Drive-by style fixes to add a space between id and < for Objective-C protocols.
2155
2156         (-[TestInputDelegate willStartInputSessionHandler]):
2157         (-[TestInputDelegate _webView:willStartInputSession:]):
2158         (-[TestInputDelegate _webView:didStartInputSession:]):
2159         * TestWebKitAPI/cocoa/TestWKWebView.h:
2160         * TestWebKitAPI/ios/UIKitSPI.h:
2161
2162         Add a declaration for _selectionClipRects.
2163
2164 2019-06-27  Zalan Bujtas  <zalan@apple.com>
2165
2166         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
2167         https://bugs.webkit.org/show_bug.cgi?id=199303
2168         <rdar://problem/51340927>
2169
2170         Reviewed by Tim Horton.
2171
2172         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2173         (TEST):
2174
2175 2019-06-27  Beth Dakin  <bdakin@apple.com>
2176
2177         Upstream use of MACCATALYST
2178         https://bugs.webkit.org/show_bug.cgi?id=199245
2179         rdar://problem/51687723
2180
2181         Reviewed by Tim Horton.
2182
2183         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
2184         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
2185         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
2186         * MiniBrowser/Configurations/SDKVariant.xcconfig:
2187         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
2188         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2189         (JavaScriptCoreGenerator):
2190         (WebCoreGenerator):
2191         (WebKitGenerator):
2192         * TestWebKitAPI/Configurations/Base.xcconfig:
2193         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2194         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
2195         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2196         * WebEditingTester/Configurations/SDKVariant.xcconfig:
2197         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
2198         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
2199         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
2200
2201 2019-06-27  Saam Barati  <sbarati@apple.com>
2202
2203         Make WEBGPU enabled only on Mojave and later.
2204
2205         Rubber-stamped by Myles C. Maxfield.
2206
2207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2208
2209 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
2210
2211         [ews-build] Do not print worker environment variables in each build step
2212         https://bugs.webkit.org/show_bug.cgi?id=197319
2213
2214         Reviewed by Lucas Forschler.
2215
2216         * BuildSlaveSupport/ews-build/steps.py:
2217         (CheckOutSource.__init__): Disabled logging of environment variables.
2218         (ApplyPatch.__init__): Ditto.
2219         (KillOldProcesses.__init__): Ditto.
2220         (ArchiveBuiltProduct.__init__): Ditto.
2221         (DownloadBuiltProduct.__init__): Ditto.
2222         (ExtractBuiltProduct.__init__): Ditto.
2223         (RunAPITests.__init__): Ditto.
2224         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2225
2226 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
2227
2228         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
2229         https://bugs.webkit.org/show_bug.cgi?id=199232
2230         <rdar://problem/51718328>
2231
2232         Reviewed by Youenn Fablet.
2233
2234         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2235         (TestWebKitAPI::TEST):
2236         Add a test that utilizes TCPServer as local files always omit referrer.
2237
2238 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
2239
2240         [ews-build] Add configuration and architecture for WPE and GTK builders
2241         https://bugs.webkit.org/show_bug.cgi?id=199249
2242
2243         Reviewed by Jonathan Bedard.
2244
2245         * BuildSlaveSupport/ews-build/config.json:
2246
2247 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
2248
2249         [ews-build] Add check for duplicate workers in config.json
2250         https://bugs.webkit.org/show_bug.cgi?id=199240
2251
2252         Reviewed by Jonathan Bedard.
2253
2254         * BuildSlaveSupport/ews-build/loadConfig.py:
2255         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
2256         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2257         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
2258
2259 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
2260
2261         [Win] MiniBrowser should make better font choices
2262         https://bugs.webkit.org/show_bug.cgi?id=199244
2263
2264         Reviewed by Brent Fulgham.
2265
2266         * MiniBrowser/win/MainWindow.cpp:
2267         (MainWindow::updateDeviceScaleFactor):
2268         * MiniBrowser/win/MiniBrowserLib.rc:
2269
2270 2019-06-26  Alex Christensen  <achristensen@webkit.org>
2271
2272         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
2273         https://bugs.webkit.org/show_bug.cgi?id=199230
2274         <rdar://51757107>
2275
2276         Reviewed by Andy Estes.
2277
2278         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2279         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2280         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2281         * WebKitTestRunner/TestController.cpp:
2282         (WTR::TestController::generatePageConfiguration):
2283         (WTR::TestController::createWebViewWithOptions):
2284         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
2285         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
2286         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2287         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
2288         * WebKitTestRunner/TestController.h:
2289         * WebKitTestRunner/TestInvocation.cpp:
2290         (WTR::TestInvocation::invoke):
2291         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2292
2293 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
2294
2295         [Win][MiniBrowser] Remove obsolete code after r246814.
2296         https://bugs.webkit.org/show_bug.cgi?id=199233
2297
2298         Reviewed by Fujii Hironori.
2299
2300         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2301         (MiniBrowserWebHost::didFinishLoadForFrame):
2302         (SimpleEventListener::SimpleEventListener): Deleted.
2303         (SimpleEventListener::handleEvent): Deleted.
2304
2305 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
2306
2307         Implement a new SPI to inform clients about AppSSO
2308         https://bugs.webkit.org/show_bug.cgi?id=199085
2309         <rdar://problem/50028246>
2310
2311         Reviewed by Geoffrey Garen.
2312
2313         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2314         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
2315         (-[TestSOAuthorizationNavigationDelegate init]):
2316         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
2317         (TestWebKitAPI::TEST):
2318
2319 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
2320
2321         [ews-build] Retry Layout test in case of failures
2322         https://bugs.webkit.org/show_bug.cgi?id=199194
2323
2324         Reviewed by Jonathan Bedard.
2325
2326         * BuildSlaveSupport/ews-build/steps.py:
2327         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
2328         (ReRunWebKitTests): Build step to re-run layout tests.
2329         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
2330         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
2331         (RunWebKitTestsWithoutPatch.evaluateCommand):
2332
2333 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
2334
2335         [ews-build] Combine various patchFailed*Tests properties
2336         https://bugs.webkit.org/show_bug.cgi?id=199193
2337
2338         Reviewed by Jonathan Bedard.
2339
2340         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
2341         can also be used for layout-tests later on.
2342         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2343
2344 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
2345
2346         [Win] MiniBrowser should default to webkit.org
2347         https://bugs.webkit.org/show_bug.cgi?id=199201
2348
2349         Reviewed by Don Olmstead.
2350
2351         * MiniBrowser/win/BrowserWindow.h:
2352         * MiniBrowser/win/MiniBrowserReplace.h:
2353         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2354         (WebKitBrowserWindow::loadHTMLString): Deleted.
2355         * MiniBrowser/win/WebKitBrowserWindow.h:
2356         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2357         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
2358         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2359         * MiniBrowser/win/WinMain.cpp:
2360         (wWinMain):
2361
2362 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2363
2364         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
2365         https://bugs.webkit.org/show_bug.cgi?id=199192
2366         <rdar://problem/51554509>
2367
2368         Reviewed by Tim Horton.
2369
2370         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
2371         verify that we gracefully handle web process termination and web view unparenting mid-drag.
2372
2373         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2374         (TestWebKitAPI::TEST):
2375         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2376         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2377         (-[DragAndDropSimulator _resetSimulatedState]):
2378         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
2379         (-[DragAndDropSimulator _advanceProgress]):
2380         (-[DragAndDropSimulator liftPreviews]):
2381         (-[DragAndDropSimulator cancellationPreviews]):
2382         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
2383         (-[DragAndDropSimulator sessionWillBeginBlock]):
2384         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
2385
2386 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
2387
2388         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
2389         https://bugs.webkit.org/show_bug.cgi?id=199178
2390
2391         Reviewed by Jonathan Bedard.
2392
2393         * BuildSlaveSupport/ews-build/steps.py:
2394         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
2395         (ExtractTestResults.__init__): Ditto.
2396         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
2397
2398 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2399
2400         Add user agent quirk for bankofamerica.com
2401         https://bugs.webkit.org/show_bug.cgi?id=199154
2402
2403         Reviewed by Carlos Garcia Campos.
2404
2405         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2406         (TestWebKitAPI::TEST):
2407
2408 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2409
2410         Fully rename WebKitGTK+ -> WebKitGTK everywhere
2411         https://bugs.webkit.org/show_bug.cgi?id=199159
2412
2413         Reviewed by Carlos Garcia Campos.
2414
2415         * BuildSlaveSupport/gtk/README:
2416         * MiniBrowser/gtk/BrowserWindow.c:
2417         * MiniBrowser/gtk/main.c:
2418         (aboutURISchemeRequestCallback):
2419         * Scripts/webkitpy/common/config/contributionareas.py:
2420         * Scripts/webkitpy/common/config/contributors.json:
2421         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
2422         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2423         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2424         (testWebViewResources):
2425         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2426         (testWebViewMouseTarget):
2427         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2428         (testWebExtensionGetTitle):
2429         (testDocumentLoadedSignal):
2430         (testWebExtensionFormControlsAssociated):
2431         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2432         (testWebKitSettingsUserAgent):
2433         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2434         (testWebViewRunJavaScript):
2435         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
2436         (main):
2437         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2438         (prepareContextMenuTestView):
2439         (testContextMenuPopulateMenu):
2440         (testContextMenuCustomMenu):
2441         (testContextMenuDisableMenu):
2442         (testContextMenuSubMenu):
2443         (testContextMenuDismissed):
2444         (testContextMenuWebExtensionMenu):
2445         (testContextMenuWebExtensionNode):
2446         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2447         (testInspectorDefault):
2448         (testInspectorManualAttachDetach):
2449         (testInspectorCustomContainerDestroyed):
2450         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2451         (testWebViewPrint):
2452         (testPrintOperationPrint):
2453         (testPrintOperationErrors):
2454         * gtk/install-dependencies:
2455         * gtk/jhbuild.modules:
2456         * gtkdoc/generate-gtkdoc:
2457         * wpe/install-dependencies:
2458
2459 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2460
2461         contributors.json not canonicalized since r243297
2462         https://bugs.webkit.org/show_bug.cgi?id=199161
2463
2464         Reviewed by Alexey Proskuryakov.
2465
2466         Canonicalize it using 'validate-committer-lists --canonicalize'
2467
2468         * Scripts/webkitpy/common/config/contributors.json:
2469
2470 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
2471
2472         webkitpy: Build style should be lower-case
2473         https://bugs.webkit.org/show_bug.cgi?id=199158
2474
2475         Reviewed by Aakash Jain.
2476
2477         * Scripts/webkitpy/test/main.py:
2478         (Tester._run_tests): Make all styles lower-case.
2479
2480 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2481
2482         [ews-build] Remove iOS queue from old EWS and dashboard
2483         https://bugs.webkit.org/show_bug.cgi?id=199150
2484
2485         Reviewed by Jonathan Bedard.
2486
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2488         * QueueStatusServer/config/queues.py:
2489
2490 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
2491
2492         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
2493         https://bugs.webkit.org/show_bug.cgi?id=198795
2494
2495         Unreviewed test gardening.
2496
2497         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2498         (TestWebKitAPI::TEST): Disable flaky test.
2499
2500 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2501
2502         [ews-build] Enable iOS-12-Build queue on new EWS
2503         https://bugs.webkit.org/show_bug.cgi?id=199149
2504
2505         Reviewed by Jonathan Bedard.
2506
2507         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
2508         this queue.
2509         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2510         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
2511         will keep the builders to the left and testers to the right.
2512
2513 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2514
2515         [ews-build] Upload test results after running layout-tests
2516         https://bugs.webkit.org/show_bug.cgi?id=199120
2517
2518         Reviewed by Jonathan Bedard.
2519
2520         * BuildSlaveSupport/ews-build/steps.py:
2521         (RunWebKitTests.evaluateCommand):
2522         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2523
2524 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
2525
2526         [ews-build] EWS should provide option to download layout test results zip file
2527         https://bugs.webkit.org/show_bug.cgi?id=199121
2528
2529         Reviewed by Jonathan Bedard.
2530
2531         * BuildSlaveSupport/ews-build/steps.py:
2532         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
2533         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
2534
2535 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2536
2537         Add user agent quirk for Google Drive
2538         https://bugs.webkit.org/show_bug.cgi?id=199153
2539
2540         Reviewed by Carlos Garcia Campos.
2541
2542         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2543         (TestWebKitAPI::TEST):
2544
2545 2019-06-22  Zalan Bujtas  <zalan@apple.com>
2546
2547         [LFC] Expand tests coverage (328 new tests -> 2652).
2548
2549         * LayoutReloaded/misc/LFC-passing-tests.txt:
2550
2551 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
2552
2553         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
2554         https://bugs.webkit.org/show_bug.cgi?id=199107
2555         <rdar://problem/43663611>
2556
2557         Reviewed by Chris Fleizach.
2558
2559         iOS implementation for AccessibilityUIElement::hasPopup.
2560         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2561         (WTR::AccessibilityUIElement::hasPopup const):
2562
2563 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
2564
2565         Unreviewed, add myself to CMake watchlist
2566
2567         * Scripts/webkitpy/common/config/watchlist:
2568
2569 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
2570
2571         openDatabase should return an empty object when WebSQL is disabled
2572         https://bugs.webkit.org/show_bug.cgi?id=198805
2573
2574         Reviewed by Geoffrey Garen.
2575
2576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2577         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
2578         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
2579         (TEST):
2580         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
2581
2582 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
2583
2584         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
2585         https://bugs.webkit.org/show_bug.cgi?id=199114
2586         <rdar://problem/51671674>
2587
2588         Reviewed by Youenn Fablet.
2589
2590         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2591         (-[TestSOAuthorizationNavigationDelegate init]):
2592         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2593         (configureSOAuthorizationWebView):
2594         (TestWebKitAPI::TEST):
2595
2596 2019-06-21  Youenn Fablet  <youenn@apple.com>
2597
2598         WebPageProxy should use the right path for sandbox extension
2599         https://bugs.webkit.org/show_bug.cgi?id=198902
2600         <rdar://problem/50772810>
2601
2602         Reviewed by Geoffrey Garen.
2603
2604         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2605         (TEST):
2606         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2607
2608 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2609
2610         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
2611         https://bugs.webkit.org/show_bug.cgi?id=199094
2612
2613         Reviewed by Carlos Garcia Campos.
2614
2615         * MiniBrowser/gtk/BrowserTab.c:
2616         (runColorChooserCallback):
2617         (browserTabConstructed):
2618         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2619         (testWebViewSyncRequestOnMaxConns):
2620         (beforeAll):
2621         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2622         (testWebSocketTLSErrors):
2623         (beforeAll):
2624         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2625         (WebKitTestServer::~WebKitTestServer):
2626         (WebKitTestServer::getWebSocketURIForPath const):
2627         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2628         (WTR::AccessibilityUIElement::rowHeaders const):
2629         (WTR::AccessibilityUIElement::columnHeaders const):
2630         (WTR::AccessibilityUIElement::isAttributeSettable):
2631         (WTR::AccessibilityUIElement::x):
2632         (WTR::AccessibilityUIElement::y):
2633         (WTR::AccessibilityUIElement::width):
2634         (WTR::AccessibilityUIElement::height):
2635         (WTR::AccessibilityUIElement::clickPointX):
2636         (WTR::AccessibilityUIElement::clickPointY):
2637         (WTR::AccessibilityUIElement::intValue const):
2638         (WTR::AccessibilityUIElement::minValue):
2639         (WTR::AccessibilityUIElement::maxValue):
2640         (WTR::stringAtOffset):
2641
2642 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
2643
2644         test-webkitpy is broken on macOS Catalina
2645         https://bugs.webkit.org/show_bug.cgi?id=199078
2646
2647         Reviewed by Jonathan Bedard.
2648
2649         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
2650         to the runner.
2651         (main): 
2652         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
2653
2654 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
2655
2656         Change status to "committer" in contributors.json
2657
2658         Unreviewed.
2659
2660         * Scripts/webkitpy/common/config/contributors.json:
2661
2662 2019-06-20  Alex Christensen  <achristensen@webkit.org>
2663
2664         Add unit test for UIContextMenuConfiguration API
2665         https://bugs.webkit.org/show_bug.cgi?id=199043
2666
2667         Reviewed by Wenson Hsieh.
2668
2669         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2670         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
2671         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
2672         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
2673         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
2674         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
2675         (TEST):
2676         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
2677         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
2678         (-[TestContextMenuDriver delegate]):
2679         (-[TestContextMenuDriver setDelegate:]):
2680         (-[TestContextMenuDriver view]):
2681         (-[TestContextMenuDriver setView:]):
2682         (-[TestContextMenuDriver allowableMovement]):
2683         (-[TestContextMenuDriver setAllowableMovement:]):
2684         (-[TestContextMenuDriver primaryGestureRecognizer]):
2685         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
2686         (-[TestContextMenuDriver touchDuration]):
2687         (-[TestContextMenuDriver setTouchDuration:]):
2688         (-[TestContextMenuDriver locationInCoordinateSpace:]):
2689         (-[TestContextMenuDriver cancelInteraction]):
2690         (-[TestContextMenuDriver begin:]):
2691         (-[TestContextMenuDriver clickDown]):
2692         (-[TestContextMenuDriver clickUp]):
2693         (-[TestContextMenuDriver end]):
2694         * TestWebKitAPI/ios/UIKitSPI.h:
2695
2696 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
2697
2698         [ews-app] Status bubble should not turn orange when any build step is skipped
2699         https://bugs.webkit.org/show_bug.cgi?id=199079
2700
2701         Reviewed by Jonathan Bedard.
2702
2703         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2704
2705 2019-06-20  Alex Christensen  <achristensen@webkit.org>
2706
2707         Fix an internal engineering build after r246605
2708        ​https://bugs.webkit.org/show_bug.cgi?id=197800
2709
2710         * TestWebKitAPI/TCPServer.cpp:
2711
2712 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
2713
2714         [ews-build] Triggered builds should use same revision as parent build
2715         https://bugs.webkit.org/show_bug.cgi?id=198289
2716
2717         Reviewed by Jonathan Bedard.
2718
2719         * BuildSlaveSupport/ews-build/steps.py:
2720         (CheckOutSpecificRevision): Build step to checkout specific revision.
2721         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
2722         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
2723         (CheckOutSpecificRevision.start): Run appropriate git command.
2724         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
2725         builds use same revision as parent build.
2726         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2727         * BuildSlaveSupport/ews-build/factories.py:
2728         (Factory.__init__): Added CheckOutSpecificRevision step.
2729
2730 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
2731
2732         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
2733         https://bugs.webkit.org/show_bug.cgi?id=199073
2734
2735         Reviewed by Jonathan Bedard.
2736
2737         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
2738
2739 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
2740
2741         [GTK] Enable navigation swipe layout tests
2742         https://bugs.webkit.org/show_bug.cgi?id=198995
2743
2744         Reviewed by Michael Catanzaro.
2745
2746         Add a way for tests to enable and then control swipe gesture on GTK.
2747
2748         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
2749         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
2750         * WebKitTestRunner/PlatformGTK.cmake:
2751         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2752         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
2753         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
2754         (WTR::UIScriptController::beginBackSwipe):
2755         (WTR::UIScriptController::completeBackSwipe):
2756
2757 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
2758
2759         [GTK] HTTP layout tests don't run in flatpak
2760         https://bugs.webkit.org/show_bug.cgi?id=199067
2761
2762         Reviewed by Michael Catanzaro.
2763
2764         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
2765         check that path. Instead, add /app/lib/perl to Apache config directly.
2766
2767         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
2768         /.flatpak-info instead.
2769
2770         * Scripts/webkitpy/port/base.py:
2771         (Port._is_flatpak):
2772         (Port._in_flatpak_sandbox):
2773         * flatpak/flatpakutils.py:
2774         (WebkitFlatpak.run_in_sandbox):
2775         (is_sandboxed):
2776
2777 2019-06-18  Darin Adler  <darin@apple.com>
2778
2779         Tidy up the remaining bits of the AtomicString to AtomString rename
2780         https://bugs.webkit.org/show_bug.cgi?id=198990
2781
2782         Reviewed by Michael Catanzaro.
2783
2784         * Scripts/do-webcore-rename: Removed already-done renames.
2785         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
2786
2787 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2788
2789         [GTK] Remove support for GTK2 plugins
2790         https://bugs.webkit.org/show_bug.cgi?id=199065
2791
2792         Reviewed by Sergio Villar Senin.
2793
2794         * EWSTools/ubuntu-ews-packages:
2795         * TestWebKitAPI/PlatformGTK.cmake:
2796         * WebKitTestRunner/PlatformGTK.cmake:
2797         * flatpak/org.webkit.GTK.yaml:
2798         * gtk/install-dependencies:
2799
2800 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
2801
2802         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
2803         https://bugs.webkit.org/show_bug.cgi?id=199053
2804
2805         Reviewed by Saam Barati.
2806
2807         Added a test stressing IsoHeap with multiple threads.
2808
2809         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2810         (assertHasObjects):
2811         (assertHasOnlyObjects):
2812         (assertClean):
2813         (TEST):
2814
2815 2019-06-19  Zalan Bujtas  <zalan@apple.com>
2816
2817         [LFC] Expand tests coverage (1126 new tests -> 2324).
2818
2819         * LayoutReloaded/misc/LFC-passing-tests.txt:
2820
2821 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2822
2823         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
2824         https://bugs.webkit.org/show_bug.cgi?id=198957
2825
2826         Reviewed by Alex Christensen.
2827
2828         * TestWebKitAPI/CMakeLists.txt:
2829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2830         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
2831
2832 2019-06-19  Keith Rollin  <krollin@apple.com>
2833
2834         Relocate some test tools in non-mac builds
2835         https://bugs.webkit.org/show_bug.cgi?id=198984
2836         <rdar://problem/51873261>
2837
2838         Reviewed by Andy Estes.
2839
2840         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
2841         TestNetscapePlugin get created in
2842         WebKit.framework/Versions/A/Resources on non-mac builds. This is
2843         incorrect, as those bundles are shallow bundles that don't use the
2844         Versions hierarchy. Instead, store these files directly in
2845         WebKit.framework.
2846
2847         Note that getting rid of just the "Versions/A" path components and
2848         putting the files in WebKit.framework/Resources doesn't work as
2849         `codesign` treats the result as an invalid layout.
2850
2851         The work in this patch involves changing the definition of the custom
2852         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
2853         variable INSTALL_PATH is defined in terms of this variable. In order
2854         to increase visiblity into this relationship, move both of these
2855         variables into .xcconfig files if they weren't already. This
2856         refactoring was done in a way to be the least disruptive and most
2857         compatible with the previous definitions, even at the cost of being
2858         repetitive.
2859
2860         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2861         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2862         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2863         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2864         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2865         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2866
2867 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
2868
2869         [ews-build] Patch link should open the pretty patch
2870         https://bugs.webkit.org/show_bug.cgi?id=199031
2871
2872         Reviewed by Jonathan Bedard.
2873
2874         * BuildSlaveSupport/ews-build/steps.py:
2875         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
2876
2877 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
2878
2879         [ews-build] Add step to analyze Compile WebKit failures
2880         https://bugs.webkit.org/show_bug.cgi?id=199025
2881
2882         Reviewed by Jonathan Bedard.
2883
2884         * BuildSlaveSupport/ews-build/steps.py:
2885         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
2886         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
2887         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
2888         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
2889         this step is run only when compile-webkit failed.
2890
2891 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
2892
2893         [ews-build] Send email notifications for failures
2894         https://bugs.webkit.org/show_bug.cgi?id=198919
2895
2896         Reviewed by Jonathan Bedard.
2897
2898         * BuildSlaveSupport/ews-build/master.cfg:
2899
2900 2019-06-19  Alex Christensen  <achristensen@webkit.org>
2901
2902         Add a unit test for client certificate authentication
2903         https://bugs.webkit.org/show_bug.cgi?id=197800
2904
2905         Reviewed by Youenn Fablet.
2906
2907         Make better abstractions for reading and writing from/to TCPServer.
2908         Add a unit test that causes a client certificate authentication challenge to happen.
2909
2910         * TestWebKitAPI/TCPServer.cpp:
2911         (TestWebKitAPI::TCPServer::TCPServer):
2912         (TestWebKitAPI::TCPServer::read):
2913         (TestWebKitAPI::TCPServer::write):
2914         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
2915         (TestWebKitAPI::TCPServer::respondWithOK):
2916         * TestWebKitAPI/TCPServer.h:
2917         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2918         (credentialWithIdentity):
2919         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2920         (TEST):
2921         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
2922         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2923         (-[ClientCertificateDelegate challengeCount]):
2924         (TestWebKitAPI::TEST):
2925         (respondWithChallengeThenOK): Deleted.
2926         (credentialWithIdentityAndKeychainPath): Deleted.
2927         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
2928         (TEST):
2929         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2930         (TestWebKitAPI::TEST):
2931         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2932         (TEST):
2933         (readRequest): Deleted.
2934         (writeResponse): Deleted.
2935         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2936         (TestWebKitAPI::TEST):
2937         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
2938
2939 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2940
2941         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
2942
2943         System headers are being included without SYSTEM again here.
2944
2945         * TestWebKitAPI/PlatformGTK.cmake:
2946
2947 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
2948
2949         [JSC] JSLock should be WebThread aware
2950         https://bugs.webkit.org/show_bug.cgi?id=198911
2951
2952         Reviewed by Geoffrey Garen.
2953
2954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2955         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
2956         (TestWebKitAPI::TEST):
2957
2958 2019-06-18  Keith Miller  <keith_miller@apple.com>
2959
2960         webkit-patch should allow for a bugzilla url not just bugzilla id
2961         https://bugs.webkit.org/show_bug.cgi?id=198972
2962
2963         Reviewed by Dewei Zhu.
2964
2965         When prompting for a bugzilla id or a new title we should also
2966         allow for a bugzilla url.
2967
2968         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
2969         (PromptForBugOrTitle.run):
2970
2971 2019-06-18  David Quesada  <david_quesada@apple.com>
2972
2973         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
2974         https://bugs.webkit.org/show_bug.cgi?id=198954
2975         rdar://problem/51711556
2976
2977         Reviewed by Alex Christensen.
2978
2979         For these tests, kill the web process after the download starts. This makes the deallocation
2980         of the download-originating web views, which these tests depend on, more reliable.
2981
2982         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2983         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2984         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2985
2986 2019-06-18  Dan Bernstein  <mitz@apple.com>
2987
2988         Revert workaround for bug 198904 from run-webkit-archive
2989         https://bugs.webkit.org/show_bug.cgi?id=198931
2990
2991         Reviewed by Alexey Proskuryakov.
2992
2993         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
2994         pick up the built frameworks.
2995
2996         * WebKitArchiveSupport/run-webkit-archive:
2997         (set_dyld_framework_path):
2998
2999 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
3000
3001         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
3002         https://bugs.webkit.org/show_bug.cgi?id=198854
3003         <rdar://problem/51386058>
3004
3005         Reviewed by Geoffrey Garen.
3006
3007         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3008         (TestWebKitAPI::TEST):
3009
3010 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
3011
3012         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
3013         https://bugs.webkit.org/show_bug.cgi?id=198831
3014
3015         Reviewed by Žan Doberšek.
3016
3017         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
3018         * wpe/jhbuild.modules: Ditto.
3019         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
3020         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
3021
3022 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
3023
3024         Move SOAuthorization from WebKitAdditions to WebKit
3025         https://bugs.webkit.org/show_bug.cgi?id=198874
3026         <rdar://problem/47573431>
3027
3028         Reviewed by Brent Fulgham.
3029
3030         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
3031
3032         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3034         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
3035         (-[TestSOAuthorizationNavigationDelegate init]):
3036         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
3037         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3038         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3039         (-[TestSOAuthorizationViewController viewDidAppear]):
3040         (-[TestSOAuthorizationViewController viewDidDisappear]):
3041         (overrideCanPerformAuthorizationWithURL):
3042         (overrideSetDelegate):
3043         (overrideBeginAuthorizationWithURL):
3044         (overrideCancelAuthorization):
3045         (overrideAddObserverForName):
3046         (overrideIsURLFromAppleOwnedDomain):
3047         (resetState):
3048         (configureSOAuthorizationWebView):
3049         (generateHtml):
3050         (checkAuthorizationOptions):
3051         (TestWebKitAPI::TEST):
3052
3053 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
3054
3055         Ensure ITP state is relayed to Network Process on restart
3056         https://bugs.webkit.org/show_bug.cgi?id=198797
3057         <rdar://problem/51646944>
3058
3059         Reviewed by Youenn Fablet.
3060
3061         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3062         (cleanupITPDatabase): Added.
3063         (TEST:EnableDisableITP): Update to use cleanup method.
3064         (TEST:NetworkProcessRestart): Added.
3065
3066 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
3067
3068         New EWS can't process patches larger than 640kb
3069         https://bugs.webkit.org/show_bug.cgi?id=198851
3070
3071         Reviewed by Jonathan Bedard.
3072
3073         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
3074
3075 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
3076
3077         webkitpy: Add macOS Catalina, iOS 13
3078         https://bugs.webkit.org/show_bug.cgi?id=198492
3079
3080         Reviewed by Alexey Proskuryakov.
3081
3082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
3083         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
3084         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
3086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
3087         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
3088         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3090         * BuildSlaveSupport/ews-build/steps.py:
3091         * Scripts/webkitpy/common/version_name_map.py:
3092         * Scripts/webkitpy/common/version_name_map_unittest.py:
3093         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3094         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3095
3096 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3097
3098         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
3099
3100         * gtk/jhbuild.modules:
3101         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
3102         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
3103
3104 2019-06-16  Zalan Bujtas  <zalan@apple.com>
3105
3106         [LFC] Expand tests coverage (325 new tests -> 1198).
3107
3108         * LayoutReloaded/misc/LFC-passing-tests.txt:
3109
3110 2019-06-16  Darin Adler  <darin@apple.com>
3111
3112         Rename AtomicString to AtomString
3113         https://bugs.webkit.org/show_bug.cgi?id=195276
3114
3115         Reviewed by Michael Catanzaro.
3116
3117         * many files: Let do-webcore-rename do the renaming.
3118
3119         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
3120         that mention "atomic string" and changed them to instead say "atom string".
3121
3122 2019-06-16  Zalan Bujtas  <zalan@apple.com>
3123
3124         [LFC] Unreviewed test gardening.
3125
3126         Unsupported alignments.
3127
3128         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
3129         fast/borders/empty-outline-border-assert.html -vertical-align: super
3130         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
3131
3132         * LayoutReloaded/misc/LFC-passing-tests.txt:
3133
3134 2019-06-15  Youenn Fablet  <youenn@apple.com>
3135
3136         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
3137         https://bugs.webkit.org/show_bug.cgi?id=198780
3138
3139         Reviewed by Jonathan Bedard.
3140
3141         * Scripts/webkitpy/w3c/test_importer.py:
3142         (TestImporter._webkit_test_runner_options):
3143         In case the test file cannot be read as text, consider that there is no WTR option.
3144
3145 2019-06-14  Youenn Fablet  <youenn@apple.com>
3146
3147         WebResourceLoadStatisticsStore should not use its network session if invalidated
3148         https://bugs.webkit.org/show_bug.cgi?id=198814
3149
3150         Reviewed by Geoffrey Garen.
3151
3152         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3153         (TEST):
3154
3155 2019-06-14  Youenn Fablet  <youenn@apple.com>
3156
3157         import-w3c-tests should respect WEBKIT_OUTPUTDIR
3158         https://bugs.webkit.org/show_bug.cgi?id=198682
3159         <rdar://problem/51536931>
3160
3161         Reviewed by Jonathan Bedard.
3162
3163         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
3164         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
3165
3166         * Scripts/webkitpy/common/webkit_finder.py:
3167         (WebKitFinder.path_from_webkit_outputdir):
3168         * Scripts/webkitpy/w3c/common.py:
3169         (WPTPaths):
3170         (WPTPaths.checkout_directory):
3171         (WPTPaths.wpt_checkout_path):
3172         * Scripts/webkitpy/w3c/test_importer.py:
3173         (TestImporter.__init__):
3174         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3175         (test_checkout_directory):
3176
3177 2019-06-13  Antoine Quint  <graouts@apple.com>
3178
3179         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
3180         https://bugs.webkit.org/show_bug.cgi?id=198800
3181         <rdar://problem/51679634>
3182
3183         Reviewed by Tim Horton.
3184
3185         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
3186         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
3187
3188         * DumpRenderTree/mac/EventSendingController.mm:
3189         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
3190         (-[EventSendingController mouseDown:withModifiers:]):
3191         (-[EventSendingController mouseUp:withModifiers:]):
3192         (-[EventSendingController mouseMoveToX:Y:]):
3193
3194 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3195
3196         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
3197         https://bugs.webkit.org/show_bug.cgi?id=198820
3198
3199         Reviewed by Ross Kirsling.
3200
3201         WebView window paints nothing because it is moved out of the
3202         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
3203         as DumpRenderTree does.
3204
3205         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3206         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
3207
3208 2019-06-13  Tim Horton  <timothy_horton@apple.com>
3209
3210         Make it possible for validate-committer-lists to dump a mailmap file
3211         https://bugs.webkit.org/show_bug.cgi?id=198517
3212
3213         Reviewed by Simon Fraser.
3214
3215         Mailmaps wildly improve the output of various Git tools, including
3216         `git shortlog -sne`, mapping committers to our canonical name/email pair.
3217
3218         * Scripts/validate-committer-lists:
3219         (CommitterListFromGit):
3220         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
3221         Add some missing legacy username mappings.
3222
3223         (dump_mailmap):
3224         (dump_mailmap.format_email):
3225         (dump_mailmap.format_email_with_gitsvn_uuid):
3226         (dump_mailmap.map_emails_to_legacy_username):
3227         (main):
3228         Add `validate-committer-lists --dump-mailmap`, which generates
3229         one given committers.json and the existing mapping of legacy username
3230         to email addresses that exists in validate-committer-lists.
3231
3232 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
3233
3234         Replace double-quotes with single quotes in loadConfig.py
3235         https://bugs.webkit.org/show_bug.cgi?id=198792
3236
3237         Reviewed by Jonathan Bedard.
3238
3239         * BuildSlaveSupport/ews-build/loadConfig.py:
3240         * BuildSlaveSupport/ews-build/steps_unittest.py:
3241
3242 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
3243
3244         Add mechanism and test case to check if ITP is active
3245         https://bugs.webkit.org/show_bug.cgi?id=198694
3246         <rdar://problem/51557704>
3247
3248         Reviewed by Youenn Fablet.
3249
3250         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3251         (TEST):
3252
3253 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3254
3255         [WPE][GTK] Deprecate WebSQL APIs
3256         https://bugs.webkit.org/show_bug.cgi?id=195011
3257
3258         Reviewed by Carlos Garcia Campos.
3259
3260         * MiniBrowser/gtk/main.c:
3261         (gotWebsiteDataCallback):
3262         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3263         (testWebsiteDataConfiguration):
3264         (testWebsiteDataEphemeral):
3265         (testWebsiteDataDatabases):
3266
3267 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3268
3269         [WPE][GTK] Enable hyperlink auditing
3270         https://bugs.webkit.org/show_bug.cgi?id=197845
3271
3272         Reviewed by Carlos Garcia Campos.
3273
3274         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3275         (testWebKitSettings):
3276
3277 2019-06-11  Keith Rollin  <krollin@apple.com>
3278
3279         Open up xcfilelist processing to more platforms
3280         https://bugs.webkit.org/show_bug.cgi?id=198675
3281         <rdar://problem/51533238>
3282
3283         Reviewed by Jonathan Bedard.
3284
3285         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
3286         platforms on which to perform xcfilelist generation/updating.
3287
3288         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3289         (JavaScriptCoreGenerator):
3290         (WebCoreGenerator):
3291         (WebKitGenerator):
3292
3293 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
3294
3295         webkitpy: Fix device ASan reporting, add testing for report configurations
3296         https://bugs.webkit.org/show_bug.cgi?id=198756
3297
3298         Reviewed by Aakash Jain.
3299
3300         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
3301         configuration thoroughly in webkitpy.
3302
3303         * Scripts/webkitpy/port/config.py:
3304         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
3305         * Scripts/webkitpy/port/device_port.py:
3306         (DevicePort.configuration_for_upload): Add ASan as style.
3307         * Scripts/webkitpy/port/ios_device_unittest.py:
3308         (IOSDeviceTest):
3309         (IOSDeviceTest.test_default_upload_configuration):
3310         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3311         (IOSSimulatorTest.test_default_upload_configuration):
3312         * Scripts/webkitpy/port/mock_drt_unittest.py:
3313         (MockDRTPortTest.test_asan_upload_configuration):
3314         * Scripts/webkitpy/port/port_testcase.py:
3315         (test_default_upload_configuration):
3316         (test_debug_upload_configuration):
3317         (test_asan_upload_configuration):
3318         (test_guard_malloc_configuration):
3319         * Scripts/webkitpy/port/watch_simulator_unittest.py:
3320         (WatchSimulatorTest):
3321         (WatchSimulatorTest.test_default_upload_configuration):
3322
3323 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3324
3325         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
3326         https://bugs.webkit.org/show_bug.cgi?id=198749
3327
3328         Reviewed by Carlos Garcia Campos.
3329
3330         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3331         (TestWebKitAPI::TEST):
3332
3333 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3334
3335         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
3336         https://bugs.webkit.org/show_bug.cgi?id=198735
3337         <rdar://problem/51557159>
3338
3339         Reviewed by Megan Gardner.
3340
3341         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
3342         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
3343
3344         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3345         (TestWebKitAPI::TEST):
3346
3347 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
3348
3349         Unreviewed, add myself to the JavaScriptCore watchlist.
3350
3351         * Scripts/webkitpy/common/config/watchlist:
3352
3353 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
3354
3355         Unreviewed, change my status to be a WebKit reviewer
3356
3357         * Scripts/webkitpy/common/config/contributors.json:
3358
3359 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3360
3361         [WPE] Use new exported image API from fdo backend
3362         https://bugs.webkit.org/show_bug.cgi?id=198558
3363
3364         Reviewed by Philippe Normand.
3365
3366         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
3367         WPEToolingBackends that already depends on fdo backend and libxkb
3368         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
3369         * wpe/backends/HeadlessViewBackend.cpp:
3370         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
3371         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
3372         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
3373         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
3374         * wpe/backends/HeadlessViewBackend.h:
3375         * wpe/backends/ViewBackend.cpp:
3376         (WPEToolingBackends::ViewBackend::initialize):
3377         * wpe/backends/ViewBackend.h:
3378         * wpe/backends/WindowViewBackend.cpp:
3379         (WPEToolingBackends::WindowViewBackend::displayBuffer):
3380         * wpe/backends/WindowViewBackend.h:
3381
3382 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
3383
3384         Extend run-benchmark to allow diagnosing before closing browser on test failure.
3385         https://bugs.webkit.org/show_bug.cgi?id=198729
3386
3387         Reviewed by Ryosuke Niwa.
3388
3389         Add '--diagnose-directory' option to store diagnose information when test failed.
3390
3391         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3392         (BenchmarkRunner.__init__):
3393         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3394         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
3395         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
3396         (parse_args):
3397         (run_benchmark_plan):
3398         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
3399         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
3400         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3401         (WebServerBenchmarkRunner.__init__):
3402         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
3403
3404 2019-06-10  Sam Weinig  <weinig@apple.com>
3405
3406         Remove Dashboard support
3407         https://bugs.webkit.org/show_bug.cgi?id=198615
3408
3409         Reviewed by Ryosuke Niwa.
3410
3411         * DumpRenderTree/TestRunner.cpp:
3412         (TestRunner::staticFunctions):
3413         (setUseDashboardCompatibilityModeCallback): Deleted.
3414         * DumpRenderTree/TestRunner.h:
3415         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3416         * DumpRenderTree/mac/DumpRenderTree.mm:
3417         (resetWebViewToConsistentStateBeforeTesting):
3418         * DumpRenderTree/mac/TestRunnerMac.mm:
3419         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
3420         * ImageDiff/cg/Configurations/Base.xcconfig:
3421         * Scripts/webkitperl/FeatureList.pm:
3422         * TestWebKitAPI/Configurations/Base.xcconfig:
3423         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3425         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
3426         * WebKitTestRunner/Configurations/Base.xcconfig:
3427         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3428         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3429         (WTR::InjectedBundle::beginTesting):
3430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3431         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
3432         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3433
3434 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
3435
3436         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
3437         https://bugs.webkit.org/show_bug.cgi?id=198616
3438         rdar://problem/36386573
3439
3440         Reviewed by David Kilzer.
3441
3442         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
3443
3444         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3445         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3446         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
3447         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
3448         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
3449         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
3450         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
3451         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3452         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3453         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3454
3455 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3456
3457         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
3458         https://bugs.webkit.org/show_bug.cgi?id=198699
3459         <rdar://problem/50501718>
3460
3461         Reviewed by Simon Fraser.
3462
3463         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
3464         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
3465         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
3466         viewport parameters are used.
3467
3468         * WebKitTestRunner/ios/TestControllerIOS.mm:
3469         (WTR::TestController::platformResetPreferencesToConsistentValues):
3470         (WTR::TestController::platformConfigureViewForTest):
3471
3472 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
3473
3474         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
3475         https://bugs.webkit.org/show_bug.cgi?id=198023
3476
3477         Reviewed by Saam Barati.
3478
3479         * Scripts/run-jsc-stress-tests:
3480
3481 2019-06-10  Timothy Hatcher  <timothy@apple.com>
3482
3483         Integrate dark mode support for iOS.
3484         https://bugs.webkit.org/show_bug.cgi?id=198687
3485         rdar://problem/51545643
3486
3487         Reviewed by Tim Horton.
3488
3489         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3490
3491 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
3492
3493         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
3494         https://bugs.webkit.org/show_bug.cgi?id=198723
3495
3496         Reviewed by Aakash Jain.
3497
3498         * Scripts/webkitpy/xcode/simulated_device.py:
3499         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
3500
3501 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
3502
3503         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
3504         https://bugs.webkit.org/show_bug.cgi?id=198635
3505         <rdar://problem/46010232>
3506
3507         Reviewed by Ryosuke Niwa.
3508
3509         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3510         (areCookiesEqual):
3511         (TEST):
3512
3513 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
3514
3515         [JHBuild] Bump shared-mime-info to version ≥ 1.6
3516         https://bugs.webkit.org/show_bug.cgi?id=198714
3517
3518         Reviewed by Carlos Garcia Campos.
3519
3520         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
3521         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
3522         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
3523
3524 2019-06-10  Philippe Normand  <pnormand@igalia.com>
3525
3526         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
3527         https://bugs.webkit.org/show_bug.cgi?id=198713
3528
3529         Reviewed by Carlos Garcia Campos.
3530
3531         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
3532         patches currently used in JHBuild.
3533
3534 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
3535
3536         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
3537         https://bugs.webkit.org/show_bug.cgi?id=198711
3538
3539         Reviewed by Philippe Normand.
3540
3541         * flatpak/org.webkit.GTK.yaml: Also include modules from
3542         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
3543
3544 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
3545
3546         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
3547         avoids double-free condition that's causing bots to exit early.
3548
3549         * gtk/jhbuild.modules:
3550         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
3551         * wpe/jhbuild.modules:
3552         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
3553
3554 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3555
3556         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
3557         https://bugs.webkit.org/show_bug.cgi?id=198655
3558
3559         Reviewed by Ross Kirsling.
3560
3561         MediaCapabilities is enabled by default for WK2, but WinCairo
3562         doesn't implemented yet. Disable it in MiniBrowser.
3563
3564         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3565         (WebKitBrowserWindow::create):
3566
3567 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3568
3569         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
3570         https://bugs.webkit.org/show_bug.cgi?id=198693
3571         <rdar://problem/51555371>
3572
3573         Reviewed by Tim Horton.
3574
3575         Augment an existing API test to exercise three additional scenarios:
3576             -   The web view configuration's application name is never set; the default should not include
3577                 "Mobile/15E148" in desktop mode.
3578             -   The application name is explicitly set to nil; the default application name should still not include
3579                 "Mobile/15E148".
3580             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
3581                 this when generating the user agent, even in desktop mode.
3582
3583         * TestWebKitAPI/ios/PreferredContentMode.mm:
3584         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
3585         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
3586         (TestWebKitAPI::TEST):
3587
3588 2019-06-08  Zalan Bujtas  <zalan@apple.com>
3589
3590         [LFC] Unreviewed test gardening.
3591
3592         Remove rtl tests. They were mistakenly marked as pass.
3593
3594         * LayoutReloaded/misc/LFC-passing-tests.txt:
3595
3596 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3597
3598         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
3599         https://bugs.webkit.org/show_bug.cgi?id=198664
3600
3601         Reviewed by Simon Fraser.
3602
3603         Delete repeated entries which were submitted by mistake.
3604
3605         * Tracing/SystemTracePoints.plist:
3606
3607 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3608
3609         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
3610         https://bugs.webkit.org/show_bug.cgi?id=198631
3611         <rdar://problem/51505431>
3612
3613         Reviewed by Tim Horton.
3614
3615         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
3616
3617         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3618         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
3619         (-[CustomInputWebView inputView]):
3620         (-[CustomInputWebView inputAccessoryView]):
3621         (TestWebKitAPI::TEST):
3622
3623 2019-06-07  Daniel Bates  <dabates@apple.com>
3624
3625         [lldb-webkit] Pretty-print all kinds of Documents
3626         https://bugs.webkit.org/show_bug.cgi?id=198620
3627
3628         Reviewed by Simon Fraser.
3629
3630         Register formatters for all classes derived from WebCore::Document so we get nice summaries
3631         without having to drill down in Xcode- or casting- to the base class, Document.
3632
3633         Older LLDB versions use to do this automatically, but this functionality was removed in newer
3634         versions:
3635             [[
3636                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
3637                 chains, but also through inheritance chains. This feature has been removed since it
3638                 significantly degrades performance. You need to set up your formatters for every type in
3639                 inheritance chains to which you want the formatter to apply.
3640             ]]
3641             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
3642
3643         * lldb/lldb_webkit.py:
3644         (__lldb_init_module):
3645
3646 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
3647
3648         webkitpy: Support reporting results for uncommon test configurations
3649         https://bugs.webkit.org/show_bug.cgi?id=198662
3650         <rdar://problem/51524128>
3651
3652         Reviewed by Aakash Jain.
3653
3654         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3655         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
3656         * Scripts/webkitpy/port/base.py:
3657         (Port.configuration_for_upload): Set flavor based on options.
3658         * Scripts/webkitpy/results/options.py:
3659         (upload_options): Add result-report-flavor option.
3660         * Scripts/webkitpy/test/main.py:
3661         (Tester._run_tests): Set flavor based on options.
3662
3663 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3664
3665         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
3666         https://bugs.webkit.org/show_bug.cgi?id=198641
3667         <rdar://problem/51266310>
3668
3669         Reviewed by Tim Horton.
3670
3671         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
3672         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
3673         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
3674         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
3675         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
3676         reproduces on iOS simulator.
3677
3678         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
3679         representation is actually ignored by most clients anyways (including WebKit), in favor of using
3680         "com.apple.flat-rtfd".
3681
3682         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3683         (TestWebKitAPI::TEST):
3684         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3685         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
3686         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3687
3688 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3689
3690         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
3691         https://bugs.webkit.org/show_bug.cgi?id=198607
3692
3693         Reviewed by Michael Catanzaro.
3694
3695         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
3696         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
3697         determine the type of the tests.
3698
3699         * Scripts/run-gtk-tests:
3700         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
3701         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
3702         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
3703         (GtkTestRunner.is_google_test): Ditto.
3704         * Scripts/run-wpe-tests:
3705         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
3706         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
3707         (WPETestRunner.is_google_test): Ditto.
3708         * glib/api_test_runner.py:
3709         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
3710         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
3711
3712 2019-06-06  Keith Rollin  <krollin@apple.com>
3713
3714         Remove SSL-based tests from TestWebKitAPI on some configurations
3715         https://bugs.webkit.org/show_bug.cgi?id=198551
3716         <rdar://problem/51424996>
3717
3718         Reviewed by Jonathan Bedard.
3719
3720         Not all platforms have SSL handy, so don't include SSL-based tests on
3721         those platforms.
3722
3723         * TestWebKitAPI/TCPServer.cpp:
3724         * TestWebKitAPI/TCPServer.h:
3725         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3726         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
3727         * TestWebKitAPI/config.h:
3728
3729 2019-06-06  Daniel Bates  <dabates@apple.com>
3730
3731         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
3732         non-default port number
3733         https://bugs.webkit.org/show_bug.cgi?id=198618
3734
3735         Reviewed by Brent Fulgham.
3736
3737         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
3738         a string before we concatenate it with another string when building the string representation
3739         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
3740         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
3741
3742         * lldb/lldb_webkit.py:
3743         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
3744
3745 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
3746
3747         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
3748         https://bugs.webkit.org/show_bug.cgi?id=198613
3749
3750         Reviewed by Alexey Proskuryakov.
3751
3752         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
3753
3754 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
3755
3756         webkitpluginhost: Support ASan as a style
3757         https://bugs.webkit.org/show_bug.cgi?id=198586
3758         <rdar://problem/51459088>
3759
3760         Reviewed by Alexey Proskuryakov.
3761
3762         * Scripts/webkitpy/port/base.py:
3763         (Port.configuration_for_upload): Add ASan as a style.
3764         * Scripts/webkitpy/port/config.py:
3765         (Config._read_configuration):
3766         (Config):
3767         (Config.asan): Add property to check if the ASan configuration is active.
3768         * Scripts/webkitpy/port/config_unittest.py:
3769         (ConfigTest.test_default_configuration__scripterror):
3770         (ConfigTest):
3771         (ConfigTest.test_asan):
3772         * Scripts/webkitpy/test/main.py:
3773         (Tester._run_tests): Add Asan as a style.
3774
3775 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
3776
3777         block-spammers tool doesn't block e-mail
3778         https://bugs.webkit.org/show_bug.cgi?id=198570
3779
3780         Reviewed by Jonathan Bedard.
3781
3782         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
3783         recognize "false" here. Also, request body is unnecessary.
3784
3785 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3786
3787         [GTK][WPE] Enable PSON
3788         https://bugs.webkit.org/show_bug.cgi?id=194979
3789
3790         Reviewed by Žan Doberšek.
3791
3792         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
3793
3794         * gtk/jhbuild.modules:
3795         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
3796         * wpe/jhbuild.modules:
3797         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
3798
3799 2019-06-05  Andy Estes  <aestes@apple.com>
3800
3801         [macOS] Stop calling -[NSDraggingItem setItem:]
3802         https://bugs.webkit.org/show_bug.cgi?id=198588
3803         <rdar://problem/48297453>
3804
3805         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
3806
3807         Reviewed by Wenson Hsieh.
3808
3809         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
3810         TestRunnerShared group.
3811
3812         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3813         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3814         Changed to call -[NSDraggingItem _initWithItem:] when available.
3815
3816         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
3817         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
3818         declarations here from DumpRenderTree.
3819
3820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3821         Added TestRunnerShared/spi/AppKitTestSPI.h.
3822
3823         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3824         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3825         Changed to call -[NSDraggingItem _initWithItem:] when available.
3826
3827 2019-06-05  Jer Noble  <jer.noble@apple.com>
3828
3829         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
3830         https://bugs.webkit.org/show_bug.cgi?id=198585
3831
3832         Reviewed by Chris Dumez.
3833
3834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3835         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3836         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
3837         (TEST):
3838         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
3839
3840 2019-06-05  Alex Christensen  <achristensen@webkit.org>
3841
3842         Re-enable safe browsing in WKWebView
3843         https://bugs.webkit.org/show_bug.cgi?id=196161
3844         <rdar://problem/49171413>
3845
3846         Reviewed by Ryosuke Niwa.
3847
3848         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3849         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3850         (TEST):
3851         (safeBrowsingView):
3852
3853 == Rolled over to ChangeLog-2019-06-05 ==