f6689476a671df35f636ed2a2f44a2bf91eb9b26
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Add WeakHashSet
4         https://bugs.webkit.org/show_bug.cgi?id=195152
5
6         Reviewed by Antti Koivisto.
7
8         Added tests for WeakHashSet.
9
10         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
11         (TestWebKitAPI::Base::Base): Moved.
12         (TestWebKitAPI::Derived::foo): Moved.
13         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
14         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
15         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
16         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
17
18 2019-03-04  Chris Dumez  <cdumez@apple.com>
19
20         Do not share WebProcesses between private and regular sessions
21         https://bugs.webkit.org/show_bug.cgi?id=195189
22         <rdar://problem/48421064>
23
24         Reviewed by Alex Christensen.
25
26         Add API test coverage.
27
28         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
29         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
30
31 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
32
33         [WPE] Enable web process sandbox
34         https://bugs.webkit.org/show_bug.cgi?id=195169
35
36         Reviewed by Daniel Bates.
37
38         * wpe/install-dependencies:
39         * wpe/jhbuild.modules:
40
41 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
42
43         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
44         https://bugs.webkit.org/show_bug.cgi?id=195206
45
46         Reviewed by Žan Doberšek.
47
48         Add a new test case.
49
50         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
51         (testJSCClass):
52
53 2019-03-04  Charlie Turner  <cturner@igalia.com>
54
55         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
56         https://bugs.webkit.org/show_bug.cgi?id=194898
57
58         Reviewed by Žan Doberšek.
59
60         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
61         a GCC extension that permits arithmetic on void* pointer. Inline
62         the macro until this issue is fixed upstream.
63
64 2019-03-03  Tim Horton  <timothy_horton@apple.com>
65
66         Rid the world of WK_API_ENABLED
67         https://bugs.webkit.org/show_bug.cgi?id=195263
68
69         Reviewed by Dan Bernstein.
70
71         List of changed files elided because it's useless.
72
73 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
74
75         Unreviewed follow-up to r242292.
76
77         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
78
79         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
80         (TestWebKitAPI::testStrip): Renamed from strip.
81         (TestWebKitAPI::TEST):
82
83 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
84
85         Unreviewed, remove accidentally-committed URLHelpers.cpp test
86
87         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
88         and bug #194272 for details.
89
90         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
91
92 2019-03-03  Tim Horton  <timothy_horton@apple.com>
93
94         Remove some more unused 32-bit code
95         https://bugs.webkit.org/show_bug.cgi?id=195255
96
97         Reviewed by Darin Adler.
98
99         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
100         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
101         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
102         (NPP_New):
103         (NPP_HandleEvent):
104         (handleEventCarbon): Deleted.
105
106 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
107
108         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
109
110         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
111         (TestWebKitAPI::TEST):
112
113 2019-03-01  Darin Adler  <darin@apple.com>
114
115         Finish removing String::format
116         https://bugs.webkit.org/show_bug.cgi?id=194893
117
118         Reviewed by Daniel Bates.
119 '
120         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
121
122 2019-03-01  Alex Christensen  <achristensen@webkit.org>
123
124         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
125         https://bugs.webkit.org/show_bug.cgi?id=195229
126         <rdar://problem/48520362>
127
128         Reviewed by Chris Dumez.
129
130         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
131         (TEST):
132
133 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
134
135         Add a system trace scope for event region building
136         https://bugs.webkit.org/show_bug.cgi?id=195226
137
138         Reviewed by Jon Lee.
139
140         This trace scope measures the time spend converting element rects into Region objects,
141         which can be large on some pages.
142
143         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
144
145         * Tracing/SystemTracePoints.plist:
146
147 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
148
149         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
150         https://bugs.webkit.org/show_bug.cgi?id=194612
151
152         Reviewed by Alex Christensen.
153
154         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
155         Just test the new string-processing function and don't touch the actual environment.
156         (Test cases are all as before, but based on operator== instead of strcmp.)
157
158 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
159
160         [ews-app] Update primary keys for handling multiple Buildbot instances
161         https://bugs.webkit.org/show_bug.cgi?id=195120
162
163         Reviewed by Stephanie Lewis.
164
165         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
166         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
167         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
168
169         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
170         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
171         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
172         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
173         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
174         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
175
176 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
177
178         [WinCairo] Enable service worker
179         https://bugs.webkit.org/show_bug.cgi?id=188318
180
181         Reviewed by Youenn Fablet.
182
183         * DumpRenderTree/DumpRenderTreePrefix.h:
184         * TestWebKitAPI/PlatformWin.cmake:
185         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
186         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
187         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
188
189 2019-03-01  Justin Fan  <justin_fan@apple.com>
190
191         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
192         https://bugs.webkit.org/show_bug.cgi?id=195191
193
194         Rubber-stamped by Dean Jackson.
195
196         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
197
198         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
199
200 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
201
202         Unreviewed, fix lldb webkitpy tests
203         https://bugs.webkit.org/show_bug.cgi?id=194375
204
205         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
206
207         * lldb/lldb_webkit.py:
208         (WTFStringImplProvider.is_8bit):
209
210 2019-02-28  David Quesada  <david_quesada@apple.com>
211
212         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
213         https://bugs.webkit.org/show_bug.cgi?id=195121
214         rdar://problem/48450302
215
216         Reviewed by Alex Christensen.
217
218         Add API tests for -WKNavigationAction._shouldPerformDownload in various
219         configurations where the 'download' attribute is absent, blank, or populated
220         with a filename, and where the anchor element is same-origin or cross-origin
221         (meaning the 'download' attribute shouldn't be honored).
222
223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
224         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
225         (-[NavigationActionTestDelegate init]):
226         (-[NavigationActionTestDelegate navigationAction]):
227         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
228         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
229         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
230         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
231         (TEST):
232
233 2019-02-28  Antoine Quint  <graouts@apple.com>
234
235         Enable the Pointer Events runtime flag by default
236         https://bugs.webkit.org/show_bug.cgi?id=195156
237
238         Reviewed by Dean Jackson.
239
240         * DumpRenderTree/mac/DumpRenderTree.mm:
241         (enableExperimentalFeatures):
242
243 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
244
245         Several PasteImage API tests are flaky
246         https://bugs.webkit.org/show_bug.cgi?id=195160
247
248         Reviewed by Tim Horton.
249
250         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
251         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
252         listening for a "load" event after image load is already complete.
253
254         To address this, make these tests first register a "load" event handler, then run script to insert an image
255         element into the document, and finally wait until the load event is observed before checking image size.
256
257         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
258
259 2019-02-28  Chris Dumez  <cdumez@apple.com>
260
261         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
262         https://bugs.webkit.org/show_bug.cgi?id=195107
263
264         Reviewed by Alex Christensen.
265
266         Give some time for the zoom level to get restored.
267
268         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
269
270 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
271
272         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
273         https://bugs.webkit.org/show_bug.cgi?id=194958
274
275         Reviewed by Geoffrey Garen.
276
277         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
278         (TEST):
279
280 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
281
282         [ews-app] Update method to save build to handle builder_display_name
283         https://bugs.webkit.org/show_bug.cgi?id=195047
284
285         Reviewed by Dewei Zhu.
286
287         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
288         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
289
290 2019-02-28  Justin Fan  <justin_fan@apple.com>
291
292         [Web GPU] Enable Web GPU only on 64-bit
293         https://bugs.webkit.org/show_bug.cgi?id=195139
294
295         Because Metal is only supported on 64 bit apps.
296
297         Unreviewed build fix.
298
299         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
300
301 2019-02-27  Youenn Fablet  <youenn@apple.com>
302
303         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
304         https://bugs.webkit.org/show_bug.cgi?id=194959
305
306         Reviewed by Chris Dumez.
307
308         Spin loop until getting the condition to remove flakiness.
309
310         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
311
312 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
313
314         [ews-build] Buildbot should include builder_display_name in the build events
315         https://bugs.webkit.org/show_bug.cgi?id=195045
316
317         Reviewed by Dewei Zhu.
318
319         * BuildSlaveSupport/ews-build/events.py:
320         (Events.buildStarted): Included builder_display_name in event data. Also renamed
321         buildername to builder_name to be consistent in naming style.
322         (Events.buildFinished): Ditto.
323
324 2019-02-27  Chris Dumez  <cdumez@apple.com>
325
326         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
327         https://bugs.webkit.org/show_bug.cgi?id=194480
328
329         Reviewed by Brady Eidson.
330
331         Update existing API test to make it more likely to reproduce the issue.
332
333         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
334
335 2019-02-27  Brady Eidson  <beidson@apple.com>
336
337         Universal links from Google search results pages don't open the app.
338         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
339
340         Reviewed by Geoffrey Garen.
341
342         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
343         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
344         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
345         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
346
347 2019-02-27  Chris Dumez  <cdumez@apple.com>
348
349         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
350         https://bugs.webkit.org/show_bug.cgi?id=195102
351
352         Reviewed by Geoffrey Garen.
353
354         If the number of processes is not yet what we expect, wait a bit and check again to give
355         processes some time to exit.
356
357         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
358
359 2019-02-27  Chris Dumez  <cdumez@apple.com>
360
361         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
362         https://bugs.webkit.org/show_bug.cgi?id=194545
363
364         Reviewed by Brady Eidson.
365
366         Make sure the test navigates forward and then back only once. Previously, navigating
367         back would trigger a navigation again in a timer.
368
369         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
370
371 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
372
373         High Sierra Debug JSC test queue should use faster hardware
374         https://bugs.webkit.org/show_bug.cgi?id=194603
375
376         Rubber-stamped by Alexey Proskuryakov.
377
378         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
379
380         * BuildSlaveSupport/build.webkit.org-config/config.json:
381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
382         (BubbleQueueServer):
383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
384         (WebKitBuildbot):
385         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
386         * QueueStatusServer/config/queues.py:
387         * Scripts/webkitpy/common/config/ews.json:
388         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
389         (test_ews_name):
390
391 2019-02-27  John Wilander  <wilander@apple.com>
392
393         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
394         https://bugs.webkit.org/show_bug.cgi?id=195071
395         <rdar://problem/48417690>
396
397         Reviewed by Alex Christensen and Brent Fulgham.
398
399         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
400         (TestWebKitAPI::createURL):
401             Convenience function.
402         (TestWebKitAPI::TEST):
403             WebCore::AdClickAttribution now takes a URL when creating Source and
404             Destination.
405         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
406         (TestWebKitAPI::TEST):
407             WebCore::AdClickAttribution now takes a URL when creating Source and
408             Destination.
409
410 2019-02-27  Antoine Quint  <graouts@apple.com>
411
412         Support Pointer Events on macOS
413         https://bugs.webkit.org/show_bug.cgi?id=195008
414         <rdar://problem/47454419>
415
416         Reviewed by Dean Jackson.
417
418         * DumpRenderTree/mac/DumpRenderTree.mm:
419         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
420         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
421
422 2019-02-26  Mark Lam  <mark.lam@apple.com>
423
424         Remove remaining poisoning code.
425         https://bugs.webkit.org/show_bug.cgi?id=194138
426
427         Reviewed by Saam Barati.
428
429         * TestWebKitAPI/CMakeLists.txt:
430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
431         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
432         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
433         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
434         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
435         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
436         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
437
438 2019-02-26  Alex Christensen  <achristensen@webkit.org>
439
440         Move ephemeral local storage from WebProcess to UIProcess
441         https://bugs.webkit.org/show_bug.cgi?id=195074
442         <rdar://problem/47937975>
443
444         Reviewed by Geoff Garen.
445
446         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
447
448 2019-02-20  Jer Noble  <jer.noble@apple.com>
449
450         [Cocoa] Media elements will restart network buffering just before suspending
451         https://bugs.webkit.org/show_bug.cgi?id=193691
452
453         Reviewed by Eric Carlson.
454
455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
456         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
457         (TEST):
458
459 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
460
461         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
462         https://bugs.webkit.org/show_bug.cgi?id=191652
463
464         Reviewed by Alex Christensen.
465
466         Fix WinCairo MiniBrowser behavior of authentication dialog.
467
468         * MiniBrowser/win/WebKitBrowserWindow.cpp:
469         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
470
471 2019-02-26  Youenn Fablet  <youenn@apple.com>
472
473         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
474         https://bugs.webkit.org/show_bug.cgi?id=195028
475         <rdar://problem/48243733>
476
477         Reviewed by Eric Carlson.
478
479         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
480
481 2019-02-26  Philippe Normand  <pnormand@igalia.com>
482
483         [WPE] Add API for webview background color configuration
484         https://bugs.webkit.org/show_bug.cgi?id=192305
485
486         Reviewed by Michael Catanzaro.
487
488         * MiniBrowser/wpe/main.cpp:
489         (main): Add a new option to configure the webview background
490         color. Example: --bg-color=transparent.
491         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
492         (testWebViewBackgroundColor): Enable background color API tests for WPE.
493         (beforeAll): Ditto.
494
495 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
496
497         scalableNativeWebpageParameters() is not preserved on new page navigation.
498         https://bugs.webkit.org/show_bug.cgi?id=194892
499         <rdar://problem/47538280>
500
501         Reviewed by Wenson Hsieh.
502         
503         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
504
505         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
506         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
507         * DumpRenderTree/mac/UIScriptControllerMac.mm:
508         (WTR::UIScriptController::allowsViewportShrinkToFit):
509         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
510         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
511         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
512         * TestRunnerShared/UIScriptContext/UIScriptController.h:
513         * WebKitTestRunner/UIScriptControllerCocoa.mm:
514         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
515
516 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
517
518         [ews-app] Add model for handling multiple Buildbot instances
519         https://bugs.webkit.org/show_bug.cgi?id=194863
520
521         Reviewed by Stephanie Lewis.
522
523         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
524
525 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
526
527         [ews-app] Remove BuilderMapping table
528         https://bugs.webkit.org/show_bug.cgi?id=194961
529
530         Reviewed by Stephanie Lewis.
531
532         Store builder name directly in build table, instead of having a separate
533         table for it.
534
535         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
536         * BuildSlaveSupport/ews-app/ews/models/build.py:
537         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
538         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
539
540 2019-02-25  John Wilander  <wilander@apple.com>
541
542         Introduce and adopt new class RegistrableDomain for eTLD+1
543         https://bugs.webkit.org/show_bug.cgi?id=194791
544         <rdar://problem/48179240>
545
546         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
547
548         This patch adds an API test and replaces two instances of
549         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
550
551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
552         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
553         (TestWebKitAPI::TEST):
554             Changed two strings to make sure the registrable domains are still considered
555             invalid and pass the test.
556         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
557         (TestWebKitAPI::TEST):
558         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
559         (WTR::InjectedBundle::didReceiveMessageToPage):
560
561 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
562
563         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
564         https://bugs.webkit.org/show_bug.cgi?id=195001
565
566         Reviewed by Carlos Garcia Campos.
567
568         API version 1.0 always includes the functionality previously guarded with
569         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
570         unconditionally.
571
572         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
573         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
574         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
575         (WebViewTest::showInWindow): Ditto.
576         (WebViewTest::hideView): Ditto.
577         * wpe/backends/HeadlessViewBackend.cpp:
578         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
579         * wpe/backends/ViewBackend.cpp:
580         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
581         * wpe/backends/WindowViewBackend.cpp:
582         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
583         WPE_BACKEND_CHECK_VERSION().
584         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
585
586 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
587
588         [Flatpak] Add support for flatpak > 1.1.2
589         https://bugs.webkit.org/show_bug.cgi?id=194088
590
591         Flatpak 1.2 is now out so we need to support that
592         version now.
593
594         Reviewed by Michael Catanzaro.
595
596         * flatpak/flatpakutils.py:
597         (check_flatpak):
598         (FlatpakPackages.__init__):
599         (FlatpakPackages.__detect_packages):
600         (FlatpakPackages.__detect_packages.in):
601         (FlatpakRepos.update):
602
603 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
604
605         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
606         https://bugs.webkit.org/show_bug.cgi?id=194998
607
608         Reviewed by Carlos Garcia Campos.
609
610         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
611         to a Git checkout and using the latest commit containing various fixes
612         and improvements.
613
614 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
615
616         [WPE][GTK] Remove user agent quirk for washingtonpost.com
617         https://bugs.webkit.org/show_bug.cgi?id=194981
618
619         Reviewed by Žan Doberšek.
620
621         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
622         (TestWebKitAPI::TEST):
623
624 2019-02-23  Keith Miller  <keith_miller@apple.com>
625
626         Add new mac target numbers
627         https://bugs.webkit.org/show_bug.cgi?id=194955
628
629         Reviewed by Tim Horton.
630
631         * DumpRenderTree/mac/Configurations/Base.xcconfig:
632         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
633         * MiniBrowser/Configurations/Base.xcconfig:
634         * TestWebKitAPI/Configurations/Base.xcconfig:
635         * WebKitTestRunner/Configurations/Base.xcconfig:
636
637 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
638
639         [WinCairo] Enable wk1/wk2 suffix for platform search path.
640         https://bugs.webkit.org/show_bug.cgi?id=194846
641
642         Reviewed by Don Olmstead.
643
644         Added _search_paths() and _port_specific_expectations_files() for
645         WinCairoPort.
646
647         * Scripts/webkitpy/port/win.py:
648         (WinCairoPort.default_baseline_search_path):
649         (WinCairoPort):
650         (WinCairoPort._port_specific_expectations_files):
651         (WinCairoPort._search_paths):
652
653 2019-02-22  Tim Horton  <timothy_horton@apple.com>
654
655         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
656         https://bugs.webkit.org/show_bug.cgi?id=194963
657
658         Reviewed by Dean Jackson.
659
660         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
661         Do a `contains` check instead of `equals`, because in debug builds we
662         put the GraphicsLayer pointer in a prefix.
663
664 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
665
666         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
667         https://bugs.webkit.org/show_bug.cgi?id=194873
668         <rdar://problem/46701974>
669
670         Reviewed by Tim Horton.
671
672         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
673
674         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
675         (WTR::UIScriptController::menuRect const):
676         (WTR::UIScriptController::isShowingMenu const):
677         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
678         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
679         (WTR::UIScriptController::menuRect const):
680
681         Add a function to query the bounds of the callout menu in content coordinates.
682
683         (WTR::UIScriptController::isShowingMenu const):
684
685         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
686
687         * TestRunnerShared/UIScriptContext/UIScriptController.h:
688         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
689         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
690         (WTR::UIScriptController::rectForMenuAction const):
691         (WTR::UIScriptController::menuRect const):
692         (WTR::UIScriptController::isShowingMenu const):
693         (WTR::findViewInHierarchyOfType): Deleted.
694
695 2019-02-22  Chris Dumez  <cdumez@apple.com>
696
697         Regression(PSON) Unable to preview password-protected documents on iCloud.com
698         https://bugs.webkit.org/show_bug.cgi?id=194954
699         <rdar://problem/48127957>
700
701         Reviewed by Alex Christensen.
702
703         Add API test coverage.
704
705         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
706         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
707         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
708         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
709
710 2019-02-22  Chris Dumez  <cdumez@apple.com>
711
712         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
713         https://bugs.webkit.org/show_bug.cgi?id=194924
714         <rdar://problem/48216125>
715
716         Reviewed by Geoffrey Garen.
717
718         Add API test coverage.
719
720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
721
722 2019-02-22  Chris Dumez  <cdumez@apple.com>
723
724         Unreviewed, disable API test added in r241928 on iOS.
725
726         The cache is not enabled on devices with less than 3GB of RAM.
727
728         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
729
730 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
731
732         Hardcode Visual Viewports on everywhere except iOS WK1
733         https://bugs.webkit.org/show_bug.cgi?id=194928
734
735         Reviewed by Zalan Bujtas.
736
737         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
738         change the default value of the Setting to 'true', and hardcode WebView on iOS to
739         set it to false. The setting has shipped for several years and there's no need to turn
740         it off now.
741
742         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
743         Visual Viewports are not enabled.
744         
745         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
746         that only runs in WK2
747
748         * MiniBrowser/mac/SettingsController.h:
749         * MiniBrowser/mac/SettingsController.m:
750         (-[SettingsController init]):
751         (-[SettingsController _populateMenu]):
752         (-[SettingsController validateMenuItem:]):
753         (-[SettingsController visualViewportEnabled]): Deleted.
754         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
755         * MiniBrowser/mac/WK1BrowserWindowController.m:
756         (-[WK1BrowserWindowController didChangeSettings]):
757         * MiniBrowser/mac/WK2BrowserWindowController.m:
758         (-[WK2BrowserWindowController didChangeSettings]):
759
760 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
761
762         Discard cached processes when clearing website data store
763         https://bugs.webkit.org/show_bug.cgi?id=194894
764
765         Reviewed by Chris Dumez.
766
767         Added a test case.
768
769         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
770         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
771
772 2019-02-21  Alex Christensen  <achristensen@webkit.org>
773
774         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
775         https://bugs.webkit.org/show_bug.cgi?id=194914
776         <rdar://problem/47586889>
777
778         Reviewed by Geoffrey Garen.
779
780         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
781         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
782         (TEST):
783         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
784
785 2019-02-21  David Kilzer  <ddkilzer@apple.com>
786
787         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
788         <https://webkit.org/b/194761>
789
790         Reviewed by Myles Maxfield.
791
792         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
793         (WTR::activateSystemCoreWebFonts): Log `error` to console if
794         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
795         to use ARC-compliant cast.
796         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
797         ARC-compliant cast.
798         (WTR::installFakeHelvetica): Log `error` to console if
799         CTFontManagerRegisterFontsForURL() fails, but only on supported
800         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
801         Call CFRelease() on `error` to fix the leak.  Update to use
802         ARC-compliant cast.
803         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
804         cast.
805
806 2019-02-21  Chris Dumez  <cdumez@apple.com>
807
808         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
809         https://bugs.webkit.org/show_bug.cgi?id=194481
810
811         Reviewed by Alex Christensen.
812
813         Give the processes a chance to shutdown and wait until we reached the expected number
814         of processes.
815
816         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
817
818 2019-02-21  Tim Horton  <timothy_horton@apple.com>
819
820         Fix the macOS build
821
822         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
823
824 2019-02-21  Tim Horton  <timothy_horton@apple.com>
825
826         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
827
828         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
829         I am a backwards.
830
831 2019-02-21  Tim Horton  <timothy_horton@apple.com>
832
833         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
834
835         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
836         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
837         We could force on UI-side compositing, but I feel like the test might be more
838         valuable exercising the normal path on each platform (though the original
839         bug was also UI-side specific). Though we can't validate that the overlay
840         layer was installed successfully, there are layout tests that do that.
841
842 2019-02-21  Tim Horton  <timothy_horton@apple.com>
843
844         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
845         https://bugs.webkit.org/show_bug.cgi?id=194845
846         <rdar://problem/47944579>
847
848         Reviewed by Antti Koivisto.
849
850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
851         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
852
853 2019-02-21  Zalan Bujtas  <zalan@apple.com>
854
855         [LFC][Floats] Add support for placing formatting roots in-between floats.
856         https://bugs.webkit.org/show_bug.cgi?id=194902
857
858         Reviewed by Antti Koivisto.
859
860         * LayoutReloaded/misc/LFC-passing-tests.txt:
861
862 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
863
864         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
865         https://bugs.webkit.org/show_bug.cgi?id=194901
866
867         Unreviewed build fix.
868
869         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
870         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
871         WPEBackend-fdo-0.1 as library name.
872
873 2019-02-21  Rob Buis  <rbuis@igalia.com>
874
875         Update MIME type parser
876         https://bugs.webkit.org/show_bug.cgi?id=180526
877
878         Reviewed by Darin Adler.
879
880         Add tests involving leading and trailing whitespace, non-token
881         characters and quoted strings.
882
883         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
884         (TestWebKitAPI::TEST):
885
886 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
887
888         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
889         https://bugs.webkit.org/show_bug.cgi?id=194884
890
891         Reviewed by Michael Catanzaro.
892
893         * PlatformWin.cmake:
894
895 2019-02-20  Chris Dumez  <cdumez@apple.com>
896
897         Add API test for <rdar://problem/47471222>
898         https://bugs.webkit.org/show_bug.cgi?id=194847
899
900         Reviewed by Alex Christensen.
901
902         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
903
904 2019-02-20  Chris Dumez  <cdumez@apple.com>
905
906         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
907         https://bugs.webkit.org/show_bug.cgi?id=194872
908         <rdar://problem/47924500>
909
910         Reviewed by Alex Christensen.
911
912         Add API test coverage.
913
914         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
915
916 2019-02-20  Jer Noble  <jer.noble@apple.com>
917
918         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
919         https://bugs.webkit.org/show_bug.cgi?id=191332
920
921         Reviewed by Dean Jackson.
922
923         * Scripts/git-is-in-range: Added.
924
925 2019-02-20  Andy Estes  <aestes@apple.com>
926
927         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
928         https://bugs.webkit.org/show_bug.cgi?id=194869
929
930         Rubber-stamped by Jer Noble.
931
932         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
933         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
934         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
935         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
936         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
937         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
938
939 2019-02-20  Chris Dumez  <cdumez@apple.com>
940
941         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
942         https://bugs.webkit.org/show_bug.cgi?id=194857
943         <rdar://problem/47759323>
944
945         Reviewed by Alex Christensen.
946
947         Add API test coverage.
948
949         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
950
951 2019-02-20  Chris Dumez  <cdumez@apple.com>
952
953         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
954         https://bugs.webkit.org/show_bug.cgi?id=194829
955         <rdar://problem/47889906>
956
957         Reviewed by Alexey Proskuryakov.
958
959         Every time the TestOptions were changing we were creating both a new Web view and
960         a new WKContext, which would start a new Network process. In most cases, we only
961         need to contruct a new Web view and we do can keep reusing the same WKContext.
962         This patch implements this optimization and thus avoids spinning a lot of new
963         Network processes while running the layout tests.
964
965         * WebKitTestRunner/TestController.cpp:
966         (WTR::TestController::generateContextConfiguration const):
967         (WTR::TestController::generatePageConfiguration):
968         (WTR::TestController::createWebViewWithOptions):
969         (WTR::TestController::resetPreferencesToConsistentValues):
970         (WTR::updateTestOptionsFromTestHeader):
971         * WebKitTestRunner/TestController.h:
972         * WebKitTestRunner/TestOptions.h:
973         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
974         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
975         (WTR::TestOptions::hasSameInitializationOptions const):
976         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
977         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
978         (WTR::TestController::platformAddTestOptions const):
979
980 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
981
982         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
983         https://bugs.webkit.org/show_bug.cgi?id=167941
984
985         Reviewed by Carlos Garcia Campos.
986
987         * MiniBrowser/gtk/main.c:
988         (filterSavedCallback): Added.
989         (main): Support loading a JSON rule set file for content filtering.
990         * MiniBrowser/wpe/main.cpp:
991         (filterSavedCallback): Added.
992         (main): Support loading a JSON rule set file for content filtering.
993         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
994         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
995         (WTF::derefGPtr): Ditto.
996         (testEmptyStore):
997         (testSaveInvalidFilter):
998         (testSaveLoadFilter):
999         (testSavedFilterIdentifierMatch):
1000         (testRemoveFilter):
1001         (testSaveMultipleFilters):
1002         (testSaveFilterFromFile):
1003         (testFilterPersistence):
1004         (beforeAll):
1005         (afterAll):
1006         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1007         (removeOldInjectedContentAndResetLists): Also reset content filters.
1008         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1009         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1010         the element affected by the style sheet.
1011         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1012         and returns it to be used by tests.
1013         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1014         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1015         (serverCallback): Add support for serving a CSS style sheet for testing.
1016         (beforeAll): Add call to testUserContentManagerContentFilter().
1017         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1018
1019 2019-02-19  Keith Rollin  <krollin@apple.com>
1020
1021         Add timing information to build output
1022         https://bugs.webkit.org/show_bug.cgi?id=194839
1023         <rdar://problem/48219609>
1024
1025         Reviewed by Alexey Proskuryakov.
1026
1027         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1028         emit each project's build time to its output. E.g.,
1029
1030             ** BUILD SUCCEEDED ** [0.132 sec]
1031
1032         * Scripts/webkitdirs.pm:
1033         (XcodeOptions):
1034
1035 2019-02-19  Truitt Savell  <tsavell@apple.com>
1036
1037         Unreviewed, rolling out r241784.
1038
1039         Broke all OpenSource builds.
1040
1041         Reverted changeset:
1042
1043         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1044         instances view"
1045         https://bugs.webkit.org/show_bug.cgi?id=172848
1046         https://trac.webkit.org/changeset/241784
1047
1048 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1049
1050         [LFC][Floats] Remove redundant intersecting logic
1051         https://bugs.webkit.org/show_bug.cgi?id=194804
1052
1053         Reviewed by Antti Koivisto.
1054
1055         * LayoutReloaded/misc/LFC-passing-tests.txt:
1056
1057 2019-02-19  Dean Jackson  <dino@apple.com>
1058
1059         Clean-up output from generate-xcfilelists so it can be filtered
1060         https://bugs.webkit.org/show_bug.cgi?id=194795
1061
1062         Reviewed by Joseph Pecoraro (and Keith Rollin).
1063
1064         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1065         make a slight tweak to filter-build-webkit so such lines are marked
1066         as plain.
1067
1068         * Scripts/filter-build-webkit:
1069         * Scripts/generate-xcfilelists:
1070
1071 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1072
1073         pytest is not correctly auto-installed
1074         https://bugs.webkit.org/show_bug.cgi?id=194707
1075
1076         Reviewed by Carlos Garcia Campos.
1077
1078         * Scripts/webkitpy/thirdparty/__init__.py:
1079         (AutoinstallImportHook._install_pytest):
1080
1081 2019-02-18  Chris Dumez  <cdumez@apple.com>
1082
1083         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1084         https://bugs.webkit.org/show_bug.cgi?id=194797
1085         <rdar://problem/48055151>
1086
1087         Reviewed by Geoffrey Garen.
1088
1089         Add API test coverage.
1090
1091         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1092
1093 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1094
1095         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1096         https://bugs.webkit.org/show_bug.cgi?id=194670
1097         <rdar://problem/39066529>
1098
1099         Reviewed by Tim Horton.
1100
1101         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1102         pasted in an editable area as attachment elements.
1103
1104         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1105         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1106         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1107         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1108         (TestWebKitAPI::TEST):
1109         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1110         (WTR::InjectedBundlePage::InjectedBundlePage):
1111
1112 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1113
1114         Fix API test after r241728
1115        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1116
1117         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1118         (TEST):
1119         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1120
1121 2019-02-18  Daniel Bates  <dabates@apple.com>
1122
1123         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1124         https://bugs.webkit.org/show_bug.cgi?id=192824
1125         <rdar://problem/47100332>
1126
1127         Reviewed by Wenson Hsieh.
1128
1129         Fix a bug where the wrong usage code was used for F13 thru F24.
1130
1131         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1132         (keyCodeForDOMFunctionKey):
1133
1134 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1135
1136         Bytecode cache should a have a boot-specific validation
1137         https://bugs.webkit.org/show_bug.cgi?id=194769
1138         <rdar://problem/48149509>
1139
1140         Reviewed by Keith Miller.
1141
1142         Add test for WTF::bootSessionUUIDString()
1143
1144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1145         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1146         (TEST):
1147
1148 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1149
1150         Disable safe browsing in WKWebView and remove its WKPreferences API
1151         https://bugs.webkit.org/show_bug.cgi?id=194723
1152         <rdar://problem/48122993>
1153
1154         Reviewed by Geoffrey Garen.
1155
1156         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1157         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1158         (TEST):
1159         (safeBrowsingView):
1160         Make tests use SPI instead of API.
1161
1162 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1163
1164         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1165         https://bugs.webkit.org/show_bug.cgi?id=194586
1166
1167         Reviewed by Ross Kirsling.
1168
1169         * DumpRenderTree/win/DumpRenderTree.cpp:
1170         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1171         * Scripts/webkitpy/port/driver.py:
1172         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1173
1174 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1175
1176         Unreviewed, rolling out r241620.
1177
1178         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1179         (Requested by ddkilzer on #webkit.)
1180
1181         Reverted changeset:
1182
1183         "[WTF] Add environment variable helpers"
1184         https://bugs.webkit.org/show_bug.cgi?id=192405
1185         https://trac.webkit.org/changeset/241620
1186
1187 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1188
1189         [LFC] RenderImage's default intrinsic size is 0.
1190         https://bugs.webkit.org/show_bug.cgi?id=194745
1191
1192         Reviewed by Antti Koivisto.
1193
1194         * LayoutReloaded/misc/LFC-passing-tests.txt:
1195
1196 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1197
1198         [LFC][BFC] Add support for block replaced intrinsic width.
1199         https://bugs.webkit.org/show_bug.cgi?id=194705
1200
1201         Reviewed by Simon Fraser.
1202
1203         * LayoutReloaded/misc/LFC-passing-tests.txt:
1204
1205 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1206
1207         [LFC] Apply min/max width constraints to preferred width computation
1208         https://bugs.webkit.org/show_bug.cgi?id=194739
1209
1210         Reviewed by Simon Fraser.
1211
1212         * LayoutReloaded/misc/LFC-passing-tests.txt:
1213
1214 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1215
1216         [WTF] Add environment variable helpers
1217         https://bugs.webkit.org/show_bug.cgi?id=192405
1218
1219         Reviewed by Michael Catanzaro.
1220
1221         * DumpRenderTree/mac/DumpRenderTree.mm:
1222         (libraryPathForDumpRenderTree):
1223         * DumpRenderTree/win/DumpRenderTree.cpp:
1224         (libraryPathForDumpRenderTree):
1225         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1226         (setUpIOSLayoutTestCommunication):
1227         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1228         (beforeAll):
1229         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1230         (main):
1231         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1232         (WebKitTestBus::run):
1233         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1234         (WTR::getOutputDir):
1235         (WTR::initializeFontConfigSetting):
1236         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1237         (WTR::InjectedBundle::platformInitialize):
1238         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1239         (WTR::topLevelPath):
1240         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1241         (WTR::topLevelPath):
1242         (WTR::getOutputDir):
1243         (WTR::activateFonts):
1244         * WebKitTestRunner/TestController.cpp:
1245         (WTR::TestController::libraryPathForTesting):
1246         (WTR::TestController::generateContextConfiguration const):
1247         (WTR::TestController::generatePageConfiguration):
1248         (WTR::TestController::decideDestinationWithSuggestedFilename):
1249         (WTR::TestController::platformAdjustContext):
1250         * WebKitTestRunner/TestController.h:
1251         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1252         (WTR::TestController::cocoaPlatformInitialize):
1253         (WTR::TestController::platformAdjustContext):
1254         * WebKitTestRunner/gtk/main.cpp:
1255         (main):
1256         * WebKitTestRunner/mac/TestControllerMac.mm:
1257         (WTR::TestController::configureContentExtensionForTest):
1258         * WebKitTestRunner/wpe/main.cpp:
1259         (main):
1260         Utilize WTF::Environment where possible.
1261
1262 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1263
1264         [iOS] WKWebView callout bar is missing Change Writing Direction item
1265         https://bugs.webkit.org/show_bug.cgi?id=190015
1266         <rdar://problem/44810366>
1267
1268         Reviewed by Tim Horton.
1269
1270         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1271         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1272
1273         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1274         (TestWebKitAPI::TEST):
1275
1276 2019-02-15  Chris Dumez  <cdumez@apple.com>
1277
1278         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1279         https://bugs.webkit.org/show_bug.cgi?id=194717
1280         <rdar://problem/47884404>
1281
1282         Reviewed by Brady Eidson.
1283
1284         Add API test coverage.
1285
1286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1287
1288 2019-02-15  Youenn Fablet  <youenn@apple.com>
1289
1290         Make navigator.mediaDevices SecureContext
1291         https://bugs.webkit.org/show_bug.cgi?id=194666
1292
1293         Reviewed by Eric Carlson.
1294
1295         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1296         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1297         (TEST_F):
1298
1299 2019-02-15  Brian Burg  <bburg@apple.com>
1300
1301         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1302         https://bugs.webkit.org/show_bug.cgi?id=194411
1303         <rdar://problem/47787614>
1304
1305         Reviewed by Joseph Pecoraro.
1306
1307         Remove unnecessary soft linking macro usage.
1308
1309         * DumpRenderTree/mac/TestRunnerMac.mm:
1310         (TestRunner::inspectorTestStubURL):
1311         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1312         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1313         (WTR::TestRunner::inspectorTestStubURL):
1314
1315 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1316
1317         Unreviewed, rolling out r241559 and r241566.
1318         https://bugs.webkit.org/show_bug.cgi?id=194710
1319
1320         Causes layout test crashes under GuardMalloc (Requested by
1321         ryanhaddad on #webkit).
1322
1323         Reverted changesets:
1324
1325         "[WTF] Add environment variable helpers"
1326         https://bugs.webkit.org/show_bug.cgi?id=192405
1327         https://trac.webkit.org/changeset/241559
1328
1329         "Unreviewed build fix for WinCairo Debug after r241559."
1330         https://trac.webkit.org/changeset/241566
1331
1332 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1333
1334         [LFC] Out-of-flow box is never a float box
1335         https://bugs.webkit.org/show_bug.cgi?id=194704
1336
1337         Reviewed by Antti Koivisto.
1338
1339         * LayoutReloaded/misc/LFC-passing-tests.txt:
1340
1341 2019-02-10  Darin Adler  <darin@apple.com>
1342
1343         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1344         https://bugs.webkit.org/show_bug.cgi?id=194487
1345
1346         Reviewed by Daniel Bates.
1347
1348         * DumpRenderTree/win/DumpRenderTree.cpp:
1349         (applicationId): Use makeString instead of String::format.
1350         (main): Ditto.
1351         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1352         (TestWebKitAPI::Util::createURLForResource): Ditto.
1353         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1354         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1355
1356         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1357         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1358         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1359         (WTR::createStringWithAttributes): Use appendLiteral.
1360         (WTR::AccessibilityUIElement::helpText const): Ditto.
1361         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1362         directly instead of using String::format.
1363         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1364         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1365
1366 2019-02-15  Truitt Savell  <tsavell@apple.com>
1367
1368         Unreviewed, rolling out r241564.
1369
1370         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1371
1372         Reverted changeset:
1373
1374         "[Mac] WebInspectorUI.framework does not need to be soft-
1375         linked anymore"
1376         https://bugs.webkit.org/show_bug.cgi?id=194411
1377         https://trac.webkit.org/changeset/241564
1378
1379 2019-02-15  Saam barati  <sbarati@apple.com>
1380
1381         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1382         https://bugs.webkit.org/show_bug.cgi?id=194036
1383
1384         Reviewed by Yusuke Suzuki.
1385
1386         * Scripts/run-jsc-stress-tests:
1387
1388 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1389
1390         Fix the build.
1391
1392         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1393         (WTR::UIScriptController::drawSquareInEditableImage):
1394         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1395         (TestWebKitAPI::drawSquareInEditableImage):
1396
1397 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1398
1399         Fix the build.
1400
1401         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1402         (WTR::UIScriptController::drawSquareInEditableImage):
1403         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1404         (TestWebKitAPI::drawSquareInEditableImage):
1405
1406 2019-02-14  Brian Burg  <bburg@apple.com>
1407
1408         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1409         https://bugs.webkit.org/show_bug.cgi?id=194411
1410         <rdar://problem/47787614>
1411
1412         Reviewed by Joseph Pecoraro.
1413
1414         Remove unnecessary soft linking macro usage.
1415
1416         * DumpRenderTree/mac/TestRunnerMac.mm:
1417         (TestRunner::inspectorTestStubURL):
1418         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1419         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1420         (WTR::TestRunner::inspectorTestStubURL):
1421
1422 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1423
1424         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1425         https://bugs.webkit.org/show_bug.cgi?id=194599
1426
1427         Reviewed by Lucas Forschler.
1428
1429         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1430         (StatusBubble._build_bubble):
1431
1432 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1433
1434         [ews-app] Set Foreign Key in Django build model
1435         https://bugs.webkit.org/show_bug.cgi?id=194667
1436
1437         Reviewed by Lucas Forschler.
1438
1439         * BuildSlaveSupport/ews-app/ews/models/build.py:
1440         (Build):
1441
1442 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1443
1444         [WTF] Add environment variable helpers
1445         https://bugs.webkit.org/show_bug.cgi?id=192405
1446
1447         Reviewed by Michael Catanzaro.
1448
1449         * DumpRenderTree/mac/DumpRenderTree.mm:
1450         (libraryPathForDumpRenderTree):
1451         * DumpRenderTree/win/DumpRenderTree.cpp:
1452         (libraryPathForDumpRenderTree):
1453         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1454         (setUpIOSLayoutTestCommunication):
1455         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1456         (TestWebKitAPI::strip):
1457         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1458         (beforeAll):
1459         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1460         (main):
1461         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1462         (WebKitTestBus::run):
1463         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1464         (WTR::getOutputDir):
1465         (WTR::initializeFontConfigSetting):
1466         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1467         (WTR::InjectedBundle::platformInitialize):
1468         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1469         (WTR::topLevelPath):
1470         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1471         (WTR::topLevelPath):
1472         (WTR::getOutputDir):
1473         (WTR::activateFonts):
1474         * WebKitTestRunner/TestController.cpp:
1475         (WTR::TestController::libraryPathForTesting):
1476         (WTR::TestController::generateContextConfiguration const):
1477         (WTR::TestController::generatePageConfiguration):
1478         (WTR::TestController::decideDestinationWithSuggestedFilename):
1479         (WTR::TestController::platformAdjustContext):
1480         * WebKitTestRunner/TestController.h:
1481         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1482         (WTR::TestController::cocoaPlatformInitialize):
1483         (WTR::TestController::platformAdjustContext):
1484         * WebKitTestRunner/gtk/main.cpp:
1485         (main):
1486         * WebKitTestRunner/mac/TestControllerMac.mm:
1487         (WTR::TestController::configureContentExtensionForTest):
1488         * WebKitTestRunner/wpe/main.cpp:
1489         (main):
1490         Utilize WTF::Environment where possible.
1491
1492 2019-02-14  Chris Dumez  <cdumez@apple.com>
1493
1494         [PSON] Introduce a WebContent Process cache
1495         https://bugs.webkit.org/show_bug.cgi?id=194594
1496         <rdar://problem/46793397>
1497
1498         Reviewed by Geoff Garen.
1499
1500         Update API tests to turn on the WebContent Process cache.
1501
1502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1503
1504 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1505
1506         Unreviewed, build fix after r241480
1507
1508         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1509         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1510         (-[DragAndDropSimulator initWithWebView:]):
1511
1512 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1513
1514         AX: ARIA Reflection was disabled in error
1515         https://bugs.webkit.org/show_bug.cgi?id=194647
1516         <rdar://problem/48068336>
1517
1518         Reviewed by Ryosuke Niwa.
1519
1520         Remove test override now that this feature should be enabled by default.
1521
1522         * WebKitTestRunner/TestController.cpp:
1523         (WTR::TestController::resetPreferencesToConsistentValues):
1524
1525 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1526
1527         Unreviewed, rolling out r241486.
1528         https://bugs.webkit.org/show_bug.cgi?id=194655
1529
1530         causing API failures in builds (Requested by ShawnRoberts on
1531         #webkit).
1532
1533         Reverted changeset:
1534
1535         "[Cocoa] Media elements will restart network buffering just
1536         before suspending"
1537         https://bugs.webkit.org/show_bug.cgi?id=193691
1538         https://trac.webkit.org/changeset/241486
1539
1540 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1541
1542         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1543         https://bugs.webkit.org/show_bug.cgi?id=194622
1544
1545         Reviewed by Antti Koivisto.
1546
1547         * LayoutReloaded/misc/LFC-passing-tests.txt:
1548
1549 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1550
1551         [LFC] Shrink-to-fit-width should be constrained by min/max width
1552         https://bugs.webkit.org/show_bug.cgi?id=194653
1553
1554         Reviewed by Antti Koivisto.
1555
1556         * LayoutReloaded/misc/LFC-passing-tests.txt:
1557
1558 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1559
1560         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1561         https://bugs.webkit.org/show_bug.cgi?id=194641
1562
1563         Reviewed by Geoffrey Garen.
1564
1565         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1566         so that the test would fail without this fix.
1567
1568         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1569         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1570
1571 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1572
1573         [ews-app] Change log level for a log statement
1574
1575         Unreviewed minor fix.
1576
1577         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1578         (Patch.save_patch):
1579
1580 2019-02-13  Jer Noble  <jer.noble@apple.com>
1581
1582         [Cocoa] Media elements will restart network buffering just before suspending
1583         https://bugs.webkit.org/show_bug.cgi?id=193691
1584
1585         Reviewed by Eric Carlson.
1586
1587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1588         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1589         (TEST):
1590
1591 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1592
1593         [ews-app] Fetch builder id to name mapping
1594         https://bugs.webkit.org/show_bug.cgi?id=194355
1595
1596         Reviewed by Lucas Forschler.
1597
1598         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1599         (Buildbot.get_builder_id_to_name_mapping):
1600         (Buildbot._get_display_name_from_builder_name):
1601
1602 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1603
1604         Further restricting webarchive loads
1605         https://bugs.webkit.org/show_bug.cgi?id=194567
1606         <rdar://problem/47610130>
1607
1608         Reviewed by Youenn Fablet.
1609
1610         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1611         navigations on drop.
1612
1613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1614         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1615         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1616         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1617         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1618         (TestWebKitAPI::TEST):
1619         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1620         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1621         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1622         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1623         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1624         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1625         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1626
1627 2019-02-13  John Wilander  <wilander@apple.com>
1628
1629         Store Ad Click Attribution requests in the network process
1630         https://bugs.webkit.org/show_bug.cgi?id=194510
1631         <rdar://problem/47650118>
1632
1633         Reviewed by Alex Christensen and Daniel Bates.
1634
1635         This patch adds two TestRunner functions:
1636         - dumpAdClickAttribution()
1637         - clearAdClickAttribution()
1638
1639         They call into the network process to dump and clear Ad Click
1640         Attribution state, respectively.
1641
1642         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1643         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1644         (WTR::TestRunner::dumpAdClickAttribution):
1645         (WTR::TestRunner::clearAdClickAttribution):
1646         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1647         * WebKitTestRunner/TestController.cpp:
1648         (WTR::TestController::resetStateToConsistentValues):
1649         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1650         (WTR::adClickAttributionStringResultCallback):
1651         (WTR::TestController::dumpAdClickAttribution):
1652         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1653         (WTR::adClickAttributionVoidCallback):
1654         (WTR::TestController::clearAdClickAttribution):
1655         * WebKitTestRunner/TestController.h:
1656         * WebKitTestRunner/TestInvocation.cpp:
1657         (WTR::TestInvocation::dumpResults):
1658         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1659         (WTR::TestInvocation::dumpAdClickAttribution):
1660         * WebKitTestRunner/TestInvocation.h:
1661
1662 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1663
1664         [ews-app] Generate status-bubble
1665         https://bugs.webkit.org/show_bug.cgi?id=194572
1666
1667         Reviewed by Lucas Forschler.
1668
1669         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1670         (StatusBubble._build_bubble):
1671         (StatusBubble._should_show_bubble_for):
1672         (StatusBubble._build_bubbles_for_patch):
1673
1674 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1675
1676         [ews-app] Add status bubble html template
1677         https://bugs.webkit.org/show_bug.cgi?id=194571
1678
1679         Reviewed by Lucas Forschler.
1680
1681         * BuildSlaveSupport/ews-app/ews/templates: Added.
1682         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1683
1684 2019-02-12  Chris Dumez  <cdumez@apple.com>
1685
1686         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1687         https://bugs.webkit.org/show_bug.cgi?id=194568
1688         <rdar://problem/47944490>
1689
1690         Reviewed by Ryosuke Niwa.
1691
1692         Add API test coverage.
1693
1694         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1695         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1696
1697 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1698
1699         webkitpy: Remove bug_dummy from parsed test expectations
1700         https://bugs.webkit.org/show_bug.cgi?id=194562
1701         <rdar://problem/47853999>
1702
1703         Reviewed by Lucas Forschler.
1704
1705         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1706         (TestExpectationParser):
1707         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1708         skipped tests.
1709         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1710
1711 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1712
1713         [ews-app] Add method to fetch patch
1714         https://bugs.webkit.org/show_bug.cgi?id=194518
1715
1716         Reviewed by Lucas Forschler.
1717
1718         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1719         (Patch.get_patch):
1720
1721 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1722
1723         [LFC] Expand tests coverage (60 new tests -> 860)
1724
1725         Unreviewed test gardening (run-singly, --child-processes=1).
1726
1727         * LayoutReloaded/misc/LFC-passing-tests.txt:
1728
1729 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1730
1731         Allow pages to trigger programmatic paste from script on iOS
1732         https://bugs.webkit.org/show_bug.cgi?id=194271
1733         <rdar://problem/47808810>
1734
1735         Reviewed by Tim Horton.
1736
1737         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1738
1739         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1740         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1741         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1742         (WTR::UIScriptController::rectForMenuAction const):
1743
1744         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1745         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1746         for when the menu is shown or hidden.
1747
1748         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1749         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1750         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1751         (WTR::UIScriptController::setDidShowMenuCallback):
1752         (WTR::UIScriptController::didShowMenuCallback const):
1753         (WTR::UIScriptController::setDidHideMenuCallback):
1754         (WTR::UIScriptController::didHideMenuCallback const):
1755         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1756         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1757         (WTR::UIScriptController::rectForMenuAction const):
1758         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1759         * WebKitTestRunner/TestController.cpp:
1760         (WTR::TestController::resetPreferencesToConsistentValues):
1761         (WTR::updateTestOptionsFromTestHeader):
1762         * WebKitTestRunner/TestOptions.h:
1763
1764         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1765         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1766
1767         (WTR::TestOptions::hasSameInitializationOptions const):
1768         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1769         (WTR::UIScriptController::calendarType const):
1770         (WTR::UIScriptController::platformUndoManager const):
1771         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1772         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1773         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1774         (-[TestRunnerWKWebView dealloc]):
1775         (-[TestRunnerWKWebView _didShowMenu]):
1776         (-[TestRunnerWKWebView _didHideMenu]):
1777
1778         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1779
1780         * WebKitTestRunner/ios/TestControllerIOS.mm:
1781         (WTR::handleMenuWillHideNotification):
1782         (WTR::handleMenuDidHideNotification):
1783         (WTR::TestController::platformInitialize):
1784         (WTR::TestController::platformDestroy):
1785         (WTR::TestController::platformResetStateToConsistentValues):
1786
1787         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1788         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1789
1790         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1791         (WTR::forEachViewInHierarchy):
1792         (WTR::findViewInHierarchyOfType):
1793
1794         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1795         functions that dig through a given view's hierarchy in search of a view of a given class.
1796
1797         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1798         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1799         (WTR::UIScriptController::selectionCaretViewRect const):
1800         (WTR::UIScriptController::selectionRangeViewRects const):
1801         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1802         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1803
1804         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1805
1806         (WTR::UIScriptController::rectForMenuAction const):
1807
1808         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1809         callout bar) whose label matches the given string.
1810
1811         (WTR::UIScriptController::platformContentView const):
1812
1813         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1814         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1815         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1816
1817         (WTR::UIScriptController::platformUndoManager const): Deleted.
1818         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1819         (WTR::UIScriptController::platformContentView const):
1820         (WTR::UIScriptController::platformUndoManager const): Deleted.
1821
1822 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1823
1824         webkitpy: No option to only show unexpected failures in results.html for iPad
1825         https://bugs.webkit.org/show_bug.cgi?id=194554
1826         <rdar://problem/47922442>
1827
1828         Rubber-stamped by Aakash Jain.
1829
1830         Just because a TestExpecations file does not exist for a specific platform does not mean that
1831         TestExpecations are not being used, given that platforms inherit test expectations.
1832
1833         * Scripts/webkitpy/port/base.py:
1834         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1835         * Scripts/webkitpy/port/base_unittest.py:
1836         (PortTest.test_uses_test_expectations_file):
1837
1838 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1839
1840         Remove setDefersLoading infrastructure from WebKit2
1841         https://bugs.webkit.org/show_bug.cgi?id=194506
1842
1843         Reviewed by Brady Eidson.
1844
1845         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1846         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1847         (WTR::TestRunner::setDefersLoading): Deleted.
1848         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1849
1850 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1851
1852         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1853         https://bugs.webkit.org/show_bug.cgi?id=194522
1854         <rdar://problem/47789393>
1855
1856         Reviewed by Chris Dumez.
1857
1858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1859         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1860         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1861         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1862
1863 2019-02-12  Andy Estes  <aestes@apple.com>
1864
1865         [iOSMac] Enable Parental Controls Content Filtering
1866         https://bugs.webkit.org/show_bug.cgi?id=194521
1867         <rdar://39732376>
1868
1869         Reviewed by Tim Horton.
1870
1871         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1872
1873 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1874
1875         [LFC][IFC] Add intrinsic width support for float boxes.
1876         https://bugs.webkit.org/show_bug.cgi?id=194528
1877
1878         Reviewed by Antti Koivisto.
1879
1880         Expand tests coverage (2 new tests -> 800).
1881         (This is the correct test ordering --runs-singly --child-processes=1)
1882
1883         * LayoutReloaded/misc/LFC-passing-tests.txt:
1884
1885 2019-02-12  Rob Buis  <rbuis@igalia.com>
1886
1887         Implement serializing in MIME type parser
1888         https://bugs.webkit.org/show_bug.cgi?id=193909
1889
1890         Reviewed by Darin Adler.
1891
1892         Add various tests involving upper case, non-ASCII, control/null characters,
1893         various HTTP whitespace, single quotes and an unpaired surrogate.
1894
1895         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1896         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1897         (TestWebKitAPI::serializeIfValid):
1898         (TestWebKitAPI::TEST):
1899
1900 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1901
1902         [Cocoa] Ask platform for generic font family mappings
1903         https://bugs.webkit.org/show_bug.cgi?id=187723
1904         <rdar://problem/41892438>
1905
1906         Reviewed by Brent Fulgham.
1907
1908         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1909
1910         * DumpRenderTree/mac/DumpRenderTree.mm:
1911         (allowedFontFamilySet):
1912         * WebKitTestRunner/mac/TestControllerMac.mm:
1913         (WTR::allowedFontFamilySet):
1914
1915 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1916
1917         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1918         https://bugs.webkit.org/show_bug.cgi?id=193622
1919
1920         Reviewed by Michael Catanzaro.
1921
1922         This adds support for loading content extension rule sets from the JSON files which
1923         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1924         of WKTR for this could be removed, but that is left for a follow-up patch with
1925         cleanups.
1926
1927         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1928         * WebKitTestRunner/TestController.cpp:
1929         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1930         avoid having the null-terminator copied into the result.
1931         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1932         part of the preparations to run a test.
1933         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1934         (WTR::contentExtensionStoreCallback): Added.
1935         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1936         used for content extensions test.
1937         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1938         extensions and compiling the JSON rule set for tests involving content extensions.
1939         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1940         testing and disables content extensions.
1941         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1942         resetContentExtensions().
1943         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1944         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1945         configureContentExtensionForTest(), and userContentController().
1946
1947 2019-02-11  Daniel Bates  <dabates@apple.com>
1948
1949         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1950         https://bugs.webkit.org/show_bug.cgi?id=191446
1951         <rdar://problem/45929460>
1952
1953         Reviewed by Tim Horton.
1954
1955         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1956
1957         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1958         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1959         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1960         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1961         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1962         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1963         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1964         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1965         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1966         (WTR::arrayLength):
1967         (WTR::parseModifierArray):
1968         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1969         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1970         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1971         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1972
1973 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1974
1975         Unreviewed, rolling out r241272 and r241276.
1976         https://bugs.webkit.org/show_bug.cgi?id=194514
1977
1978         Broke the Apple Internal build and the fix requires human
1979         intervention :( (Requested by dydz on #webkit).
1980
1981         Reverted changesets:
1982
1983         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1984         https://bugs.webkit.org/show_bug.cgi?id=191446
1985         https://trac.webkit.org/changeset/241272
1986
1987         "Fix internal iOS build after r241272"
1988         https://bugs.webkit.org/show_bug.cgi?id=191446
1989         https://trac.webkit.org/changeset/241276
1990
1991 2019-02-11  Truitt Savell  <tsavell@apple.com>
1992
1993         Unreviewed, rolling out r241269.
1994
1995         Caused 5 layout tests crashes on Mac WK1
1996
1997         Reverted changeset:
1998
1999         "DumpRenderTree should report unknown options"
2000         https://bugs.webkit.org/show_bug.cgi?id=191303
2001         https://trac.webkit.org/changeset/241269
2002
2003 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2004
2005         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2006         https://bugs.webkit.org/show_bug.cgi?id=194313
2007
2008         Reviewed by Tim Horton.
2009
2010         Add a helper to determine whether the web view is presenting modal UI.
2011
2012         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2013         (WTR::UIScriptController::isPresentingModally const):
2014         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2015         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2016         (WTR::UIScriptController::isPresentingModally const):
2017         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2018         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2019         (WTR::UIScriptController::calendarType const): Deleted.
2020         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2021         (WTR::UIScriptController::isPresentingModally const):
2022         (WTR::UIScriptController::calendarType const):
2023         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2024         (WTR::UIScriptController::calendarType const):
2025
2026 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2027
2028         GCHeapInspector: Show the retained sizes in more places
2029         https://bugs.webkit.org/show_bug.cgi?id=194464
2030
2031         Reviewed by Simon Fraser.
2032
2033         * GCHeapInspector/gc-heap-inspector.html:
2034         * GCHeapInspector/script/interface.js:
2035         (HeapInspectorUtils.humanReadableSize):
2036         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2037         (HeapInspectorUtils.spanForNode.span.span):
2038         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2039         (HeapSnapshotInspector.prototype.buildRoots):
2040
2041 2019-02-11  Daniel Bates  <dabates@apple.com>
2042
2043         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2044         https://bugs.webkit.org/show_bug.cgi?id=191446
2045         <rdar://problem/45929460>
2046
2047         Reviewed by Tim Horton.
2048
2049         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2050
2051         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2052         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2053         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2054         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2055         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2056         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2057         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2058         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2059         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2060         (WTR::arrayLength):
2061         (WTR::parseModifierArray):
2062         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2063         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2064         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2065         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2066
2067 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2068
2069         DumpRenderTree should report unknown options
2070         https://bugs.webkit.org/show_bug.cgi?id=191303
2071
2072         Reviewed by Frédéric Wang.
2073
2074         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2075         to report unknown options.
2076         Added and assigned test options which are currently used in tests.
2077
2078         * DumpRenderTree/TestOptions.cpp:
2079         (TestOptions::TestOptions):
2080
2081 2019-02-11  Truitt Savell  <tsavell@apple.com>
2082
2083         Unreviewed, rolling out r241229.
2084
2085         Revision broke internal builds for watchOS.
2086
2087         Reverted changeset:
2088
2089         "[Cocoa] Ask platform for generic font family mappings"
2090         https://bugs.webkit.org/show_bug.cgi?id=187723
2091         https://trac.webkit.org/changeset/241229
2092
2093 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2094
2095         [WinCairo][MiniBrowser] Basic authentication always fails.
2096         https://bugs.webkit.org/show_bug.cgi?id=194496
2097
2098         Reviewed by Don Olmstead.
2099
2100         * MiniBrowser/win/DialogHelper.h:
2101         (Dialog::getText):
2102
2103 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2104
2105         [GStreamer] GstMappedBuffer testsuite build fails
2106         https://bugs.webkit.org/show_bug.cgi?id=194495
2107
2108         Reviewed by Carlos Garcia Campos.
2109
2110         Fix the build by explicitely adding the gstreamer1.0-audio include
2111         directories to the include path.
2112
2113         * TestWebKitAPI/PlatformGTK.cmake:
2114         * TestWebKitAPI/PlatformWPE.cmake:
2115
2116 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2117
2118         [GTK][WPE] Add enable-javascript-markup setting
2119         https://bugs.webkit.org/show_bug.cgi?id=193439
2120
2121         Reviewed by Michael Catanzaro.
2122
2123         Add test cases to check the new setting.
2124
2125         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2126         (testWebKitSettings):
2127         (testWebKitSettingsJavaScriptMarkup):
2128         (beforeAll):
2129
2130 2019-02-10  Darin Adler  <darin@apple.com>
2131
2132         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2133         https://bugs.webkit.org/show_bug.cgi?id=194485
2134
2135         Reviewed by Daniel Bates.
2136
2137         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2138
2139 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2140
2141         Add more tests for clampTo<>()
2142         https://bugs.webkit.org/show_bug.cgi?id=194462
2143
2144         Reviewed by Geoffrey Garen.
2145
2146         Darin suggested to test the very last floating point number
2147         at the boundaries when truncating to integer.
2148         I added test for max/min and max-1/min-1.
2149
2150         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2151         (TestWebKitAPI::TEST):
2152
2153 2019-02-09  Darin Adler  <darin@apple.com>
2154
2155         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2156         https://bugs.webkit.org/show_bug.cgi?id=194021
2157
2158         Reviewed by Geoffrey Garen.
2159
2160         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2161         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2162         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2163
2164 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2165
2166         [LFC][IFC] Add intrinsic width support for basic inline containers
2167         https://bugs.webkit.org/show_bug.cgi?id=194473
2168
2169         Reviewed by Antti Koivisto.
2170
2171         Expand tests coverage (11 new tests -> 798)
2172
2173         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2174
2175 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2176
2177         Fix MiniBrowser's entitlements
2178         https://bugs.webkit.org/show_bug.cgi?id=192431
2179
2180         Reviewed by Joseph Pecoraro.
2181
2182         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2183         files, making it impossible to load any extension.
2184
2185         * MiniBrowser/MiniBrowser.entitlements:
2186
2187 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2188
2189         [Cocoa] Ask platform for generic font family mappings
2190         https://bugs.webkit.org/show_bug.cgi?id=187723
2191         <rdar://problem/41892438>
2192
2193         Reviewed by Brent Fulgham.
2194
2195         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2196
2197         * DumpRenderTree/mac/DumpRenderTree.mm:
2198         (allowedFontFamilySet):
2199         * WebKitTestRunner/mac/TestControllerMac.mm:
2200         (WTR::allowedFontFamilySet):
2201
2202 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2203
2204         [GTK] Implement back/forward touchpad gesture
2205         https://bugs.webkit.org/show_bug.cgi?id=193919
2206
2207         Reviewed by Michael Catanzaro.
2208
2209         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2210         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2211
2212 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2213
2214         Add SPI to use networking daemon instead of XPC service
2215         https://bugs.webkit.org/show_bug.cgi?id=194427
2216
2217         Reviewed by Geoffrey Garen
2218
2219         * MiniBrowser/MiniBrowser.entitlements:
2220
2221 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2222
2223         [ews-build] Ensure that every builder in config.json has short name
2224         https://bugs.webkit.org/show_bug.cgi?id=194461
2225
2226         Reviewed by Lucas Forschler.
2227
2228         * BuildSlaveSupport/ews-build/loadConfig.py:
2229         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2230
2231 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2232
2233         [ews-build] Add short name to config.json
2234         https://bugs.webkit.org/show_bug.cgi?id=194456
2235
2236         Reviewed by Lucas Forschler.
2237
2238         * BuildSlaveSupport/ews-build/config.json: Added short name.
2239         * BuildSlaveSupport/ews-build/loadConfig.py:
2240         (loadBuilderConfig): Set the short name as the builder description.
2241
2242 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2243
2244         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2245         https://bugs.webkit.org/show_bug.cgi?id=194418
2246
2247         Reviewed by Lucas Forschler.
2248
2249         Do not include errors trying when finding crashlogs at the end of
2250         a run-webkit-tests run since we don't process those errors.
2251
2252         * Scripts/webkitpy/port/darwin.py:
2253         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2254         * Scripts/webkitpy/port/ios_device.py:
2255         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2256         * Scripts/webkitpy/port/watch_device.py:
2257         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2258
2259 2019-02-08  Beth Dakin  <bdakin@apple.com>
2260
2261         Add afterScreenUpdates to WKSnapshotConfiguration
2262         https://bugs.webkit.org/show_bug.cgi?id=194362
2263         -and corresponding-
2264         <rdar://problem/40655528> Please add an "after screen updates" property to 
2265         WKSnapshotConfiguration (to solve blank snapshots)
2266
2267         Reviewed by Tim Horton.
2268
2269         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2270         (TEST):
2271
2272 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2273
2274         clampTo(): do not convert the input to double when dealing with integers
2275         https://bugs.webkit.org/show_bug.cgi?id=194263
2276         <rdar://problem/47692312>
2277
2278         Reviewed by Darin Adler.
2279
2280         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2281         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2282         (TestWebKitAPI::testClampFloatingPointToInteger):
2283         (TestWebKitAPI::testClampSameSignIntegers):
2284         (TestWebKitAPI::testClampUnsignedToSigned):
2285         (TestWebKitAPI::testClampSignedToUnsigned):
2286
2287 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2288
2289         webkitpy: Respect --dedicated-simulators flag
2290         https://bugs.webkit.org/show_bug.cgi?id=194416
2291         <rdar://problem/47894722>
2292
2293         Reviewed by Lucas Forschler.
2294
2295         * Scripts/webkitpy/port/device_port.py:
2296         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2297         available devices can be safely ignored.
2298
2299 2019-02-07  Keith Rollin  <krollin@apple.com>
2300
2301         Remove extra copy of 100x100-red.tga
2302         https://bugs.webkit.org/show_bug.cgi?id=194371
2303         <rdar://problem/47873465>
2304
2305         Reviewed by Said Abou-Hallawa.
2306
2307         In order to help it pass its tests, Bug 194190 added a second copy of
2308         the file 100x100-red.tga. However, it turns out that this additional
2309         file wasn't actually needed, and that that sole previous copy was
2310         sufficient. At the same time, this second copy -- which was copied to
2311         the same location in the build output as the first copy -- now caused
2312         XCBuild to complain because there were two production rules for the
2313         same output file. Address this by removing the newly-added extra copy.
2314
2315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2316         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2317
2318 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2319
2320         Deprecate WKBundlePageSetDefersLoading
2321         https://bugs.webkit.org/show_bug.cgi?id=191394
2322
2323         Reviewed by Dean Jackson.
2324
2325         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2326         (WTR::TestRunner::setDefersLoading):
2327
2328 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2329
2330         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2331         https://bugs.webkit.org/show_bug.cgi?id=194391
2332
2333         Reviewed by Antti Koivisto.
2334
2335         * LayoutReloaded/misc/LFC-passing-tests.txt:
2336
2337 2019-02-06  Keith Rollin  <krollin@apple.com>
2338
2339         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2340         https://bugs.webkit.org/show_bug.cgi?id=193975
2341         <rdar://problem/47643306>
2342
2343         Reviewed by Tim Horton.
2344
2345         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2346         the Info.plist file into the bundle. This step is not necessary as the
2347         implicit "bundle up all the build products into a framework" build
2348         phase does this already. Having the Copy Bundle Resources phase do
2349         this causes a conflict under XCBuild, which objects to two build
2350         phases producing the same file (Info.plist). Address this by removing
2351         Info.plist from the Copy Bundle Resources phase.
2352
2353         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2354
2355 2019-02-06  Keith Rollin  <krollin@apple.com>
2356
2357         Really enable the automatic checking and regenerations of .xcfilelists during builds
2358         https://bugs.webkit.org/show_bug.cgi?id=194357
2359         <rdar://problem/47861231>
2360
2361         Reviewed by Chris Dumez.
2362
2363         Bug 194124 was supposed to enable the automatic checking and
2364         regenerating of .xcfilelist files during the build. While related
2365         changes were included in that patch, the change to actually enable the
2366         operation somehow was omitted. This patch actually enables the
2367         operation. The check-xcfilelist.sh scripts now check
2368         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2369         from the checking.
2370
2371         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2372         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2373
2374 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2375
2376         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2377         <https://webkit.org/b/194286>
2378         <rdar://problem/47815558>
2379
2380         Reviewed by Alexey Proskuryakov.
2381
2382         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2383         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2384         WKRetainPtr<> to avoid leaking the WKDataRef.
2385
2386 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2387
2388         Unreviewed, fix a typo
2389
2390         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2391
2392 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2393
2394         [GTK][WPE] force libpsl build to use ICU in jhbuild
2395         https://bugs.webkit.org/show_bug.cgi?id=194288
2396
2397         Reviewed by Carlos Garcia Campos.
2398
2399         * gtk/jhbuild.modules:
2400         Require ICU for libpsl build in jhbuild, like done in WPE.
2401
2402 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2403
2404         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2405         https://bugs.webkit.org/show_bug.cgi?id=194209
2406
2407         Reviewed by Carlos Garcia Campos.
2408
2409         Enhance TestCookieManager to ensure this doesn't happen again.
2410
2411         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2412         (testCookieManagerPersistentStorage):
2413         (beforeAll):
2414
2415 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2416
2417         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2418         https://bugs.webkit.org/show_bug.cgi?id=194324
2419
2420         Reviewed by Andy Estes.
2421
2422         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2423         part of the name is already implicit, since this is in testing code in TestOptions.
2424
2425         * WebKitTestRunner/TestController.cpp:
2426         (WTR::TestController::generateContextConfiguration const):
2427         (WTR::updateTestOptionsFromTestHeader):
2428         * WebKitTestRunner/TestOptions.h:
2429         (WTR::TestOptions::hasSameInitializationOptions const):
2430
2431 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2432
2433         [ews-build] Allow * as platform for builders and workers
2434         https://bugs.webkit.org/show_bug.cgi?id=188533
2435
2436         Reviewed by Lucas Forschler.
2437
2438         * BuildSlaveSupport/ews-build/loadConfig.py:
2439         (checkWorkersAndBuildersForConsistency):
2440
2441 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2442
2443         [ews-build] Add few bots to config.json
2444         https://bugs.webkit.org/show_bug.cgi?id=194304
2445
2446         Reviewed by Lucas Forschler.
2447
2448         * BuildSlaveSupport/ews-build/config.json:
2449
2450 2019-02-05  Keith Rollin  <krollin@apple.com>
2451
2452         Enable the automatic checking and regenerations of .xcfilelists during builds
2453         https://bugs.webkit.org/show_bug.cgi?id=194124
2454         <rdar://problem/47721277>
2455
2456         Reviewed by Tim Horton.
2457
2458         Bug 193790 add a facility for checking -- during build time -- that
2459         any needed .xcfilelist files are up-to-date and for updating them if
2460         they are not. This facility was initially opt-in by setting
2461         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2462         the process seemed robust. Its now time to enable this facility and
2463         make it opt-out. If there is a need to disable this facility, set and
2464         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2465         running `make` or `build-webkit`, or before running Xcode from the
2466         command line.
2467
2468         Additionally, remove the step that generates a list of source files
2469         going into the UnifiedSources build step. It's only necessarily to
2470         specify Sources.txt and SourcesCocoa.txt as inputs.
2471
2472         * Scripts/generate-xcfilelists:
2473
2474 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2475
2476         [GTK][WPE] force libpsl build to use ICU in jhbuild
2477         https://bugs.webkit.org/show_bug.cgi?id=194288
2478
2479         Reviewed by Philippe Normand.
2480
2481         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2482         This can cause build failures if libidn is detected but libunistring is not available.
2483
2484         Make sure that ICU is used for runtime and builtin PSL data.
2485
2486         * gtk/jhbuild.modules:
2487         * wpe/jhbuild.modules:
2488
2489 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2490
2491         [ews-app] Modified timestamp should be updated on updating data
2492         https://bugs.webkit.org/show_bug.cgi?id=194295
2493
2494         Reviewed by Lucas Forschler.
2495
2496         * BuildSlaveSupport/ews-app/ews/models/build.py:
2497         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2498         * BuildSlaveSupport/ews-app/ews/models/step.py:
2499
2500 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2501
2502         Unreviewed, rolling out r240742.
2503
2504         Causes crashes on iOS simulator.
2505
2506         Reverted changeset:
2507
2508         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2509         not focused in a content-editable element"
2510         https://bugs.webkit.org/show_bug.cgi?id=192824
2511         https://trac.webkit.org/changeset/240742
2512
2513 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2514
2515         run-webkit-tests emits message "...running None" when running tests
2516         https://bugs.webkit.org/show_bug.cgi?id=194133
2517         <rdar://problem/47724738>
2518
2519         Reviewed by Lucas Forschler.
2520
2521         * Scripts/webkitpy/xcode/device_type.py:
2522         (DeviceType.__str__): Use both version mapping tables and use just the variant
2523         name if no version name is available.
2524         * Scripts/webkitpy/xcode/device_type_unittest.py:
2525         (DeviceTypeTest):
2526         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2527         an associated named.
2528
2529 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2530
2531         [WPE] require python3-setuptools for meson build in jhbuild
2532         https://bugs.webkit.org/show_bug.cgi?id=194287
2533
2534         Reviewed by Philippe Normand.
2535
2536         python3-setuptools is needed to build meson in jhbuild.
2537         It is already required by the GTK port.
2538
2539         * wpe/install-dependencies:
2540
2541 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2542
2543         [ews-app] Add method to save BuilderMapping to database
2544         https://bugs.webkit.org/show_bug.cgi?id=194264
2545
2546         Reviewed by Lucas Forschler.
2547
2548         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2549         (BuilderMapping.__str__):
2550         (BuilderMapping):
2551         (BuilderMapping.save_mapping):
2552         (BuilderMapping.update_mapping):
2553         (BuilderMapping.get_existing_mapping):
2554         (BuilderMapping.is_valid_mapping):
2555
2556 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2557
2558         [ews-app] Add timestamp fields for BuilderMappings
2559         https://bugs.webkit.org/show_bug.cgi?id=194266
2560
2561         Reviewed by Lucas Forschler.
2562
2563         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2564         (BuilderMapping):
2565
2566 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2567
2568         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2569         https://bugs.webkit.org/show_bug.cgi?id=174816
2570
2571         Reviewed by Michael Catanzaro.
2572
2573         Add tests for webkit_uri_for_display().
2574
2575         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2576         (testURIForDisplayUnaffected):
2577         (testURIForDisplayAffected):
2578         (beforeAll):
2579         (afterAll):
2580         * TestWebKitAPI/glib/CMakeLists.txt:
2581
2582 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2583
2584         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2585         https://bugs.webkit.org/show_bug.cgi?id=194158
2586         <rdar://problem/47737268>
2587
2588         Rubber-stamped by Aakash Jain.
2589
2590         * Scripts/webkitpy/port/device_port.py:
2591         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2592
2593 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2594
2595         [CG] Enable setAdditionalSupportedImageTypes for WK1
2596         https://bugs.webkit.org/show_bug.cgi?id=194190
2597
2598         Reviewed by Tim Horton.
2599
2600         Add a test similar to the one under WebKit Cocoa but make it create a
2601         WebView instead of a WKWebView.
2602
2603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2604         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2605         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2606         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2607         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2608         (TestWebKitAPI::runTest):
2609         (TestWebKitAPI::TEST):
2610
2611 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2612
2613         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2614         https://bugs.webkit.org/show_bug.cgi?id=194168
2615
2616         Reviewed by Simon Fraser.
2617
2618         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2619
2620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2621         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2622         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2623         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2624         (TEST):
2625         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2626         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2627
2628 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2629
2630         REGRESSION (r237269): webkit-patch what-broke is broken 
2631         https://bugs.webkit.org/show_bug.cgi?id=193025
2632
2633         Reviewed by Aakash Jain.
2634
2635         * Scripts/webkitpy/common/host.py:
2636         (Host.buildbot):
2637         (Host.bugzilla): Renamed to 'buildbot'.
2638
2639 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2640
2641         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2642         https://bugs.webkit.org/show_bug.cgi?id=194207
2643
2644         Reviewed by Tim Horton.
2645
2646         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2647         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2648         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2649         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2650         start and delete forwards to remove the original attachment.
2651
2652         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2653         (TestWebKitAPI::TEST):
2654
2655 2019-02-04  Youenn Fablet  <youenn@apple.com>
2656
2657         Capture state should be managed consistently when doing process swapping
2658         https://bugs.webkit.org/show_bug.cgi?id=194122
2659         <rdar://problem/47609293>
2660
2661         Reviewed by Eric Carlson.
2662
2663         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2664         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2665         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2666         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2667         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2668         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2669         (WTR::TestRunner::isDoingMediaCapture const):
2670         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2671         * WebKitTestRunner/TestController.cpp:
2672         (WTR::TestController::isDoingMediaCapture const):
2673         * WebKitTestRunner/TestController.h:
2674         * WebKitTestRunner/TestInvocation.cpp:
2675         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2676         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2677         (WTR::TestController::isDoingMediaCapture const):
2678
2679 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2680
2681         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2682         https://bugs.webkit.org/show_bug.cgi?id=194142
2683
2684         Reviewed by Ross Kirsling.
2685
2686         There three 'separator' variables in TestController.cpp. Renamed
2687         it 'pathSeparator', and unified them.
2688
2689         * WebKitTestRunner/TestController.cpp:
2690         (WTR::TestController::generateContextConfiguration const):
2691         (WTR::createTestURL):
2692         (WTR::TestController::platformAdjustContext):
2693
2694 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2695
2696         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2697         https://bugs.webkit.org/show_bug.cgi?id=194198
2698
2699         Reviewed by Antti Koivisto.
2700
2701         No need to set the banner heights on navigation now, since Page stores them.
2702
2703         * MiniBrowser/mac/WK2BrowserWindowController.m:
2704         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2705
2706 2019-02-03  John Wilander  <wilander@apple.com>
2707
2708         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2709         https://bugs.webkit.org/show_bug.cgi?id=194104
2710         <rdar://problem/47649991>
2711
2712         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2713
2714         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2715         (TestWebKitAPI::TEST):
2716             Changed numeric types from unsigned short to uint32_t.
2717
2718 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2719
2720         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2721         <https://webkit.org/b/194178>
2722         <rdar://problem/47753473>
2723
2724         Reviewed by Alexey Proskuryakov.
2725
2726         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2727         (WTR::uninstallFakeHelvetica): Pass nullptr into
2728         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2729
2730 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2731
2732         [LFC] Initialize ICB's style with fixed width/height.
2733         https://bugs.webkit.org/show_bug.cgi?id=194188
2734
2735         Reviewed by Antti Koivisto.
2736
2737         * LayoutReloaded/misc/LFC-passing-tests.txt:
2738
2739 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2740
2741         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2742         https://bugs.webkit.org/show_bug.cgi?id=194185
2743
2744         Reviewed by Antti Koivisto.
2745
2746         * LayoutReloaded/misc/LFC-passing-tests.txt:
2747
2748 2018-12-16  Darin Adler  <darin@apple.com>
2749
2750         Convert additional String::format clients to alternative approaches
2751         https://bugs.webkit.org/show_bug.cgi?id=192746
2752
2753         Reviewed by Alexey Proskuryakov.
2754
2755         * WebKitTestRunner/TestController.cpp:
2756         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2757         as an intermediate in code that ultimately constructs a WTF::String.
2758         (WTR::userMediaOriginHash): Use makeString.
2759         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2760         (WTR::TestController::didPerformClientRedirect): Ditto.
2761         (WTR::TestController::didPerformServerRedirect): Ditto.
2762         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2763
2764 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2765
2766         [ews-build] Add unit test to verify builder keys
2767         https://bugs.webkit.org/show_bug.cgi?id=194152
2768
2769         Reviewed by Lucas Forschler.
2770
2771         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2772         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2773
2774 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2775
2776         [LFC] Expand tests coverage (12 new tests -> 787)
2777
2778         Unreviewed test gardening.
2779
2780         * LayoutReloaded/misc/LFC-passing-tests.txt:
2781
2782 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2783
2784         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2785         https://bugs.webkit.org/show_bug.cgi?id=194163
2786
2787         Reviewed by Simon Fraser.
2788
2789         775
2790
2791         * LayoutReloaded/misc/LFC-passing-tests.txt:
2792
2793 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2794
2795         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2796         https://bugs.webkit.org/show_bug.cgi?id=194140
2797         <rdar://problem/47728098>
2798
2799         Reviewed by Tim Horton.
2800
2801         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2803         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2804
2805         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2806         test to induce an IPC deadlock when presenting a modal alert during touch start.
2807
2808         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2809         * WebKitTestRunner/TestController.cpp:
2810         (WTR::runJavaScriptAlert):
2811
2812         Add a client callback function for running JavaScript alerts.
2813
2814         (WTR::TestController::createOtherPage):
2815         (WTR::TestController::generateContextConfiguration const):
2816
2817         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2818         the fix in this patch.
2819
2820         (WTR::TestController::createWebViewWithOptions):
2821
2822         Plumb TestOptions to generateContextConfiguration.
2823
2824         (WTR::TestController::resetPreferencesToConsistentValues):
2825         (WTR::TestController::resetStateToConsistentValues):
2826         (WTR::updateTestOptionsFromTestHeader):
2827         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2828         (WTR::TestController::handleJavaScriptAlert):
2829         * WebKitTestRunner/TestController.h:
2830         * WebKitTestRunner/TestInvocation.cpp:
2831         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2832         * WebKitTestRunner/TestOptions.h:
2833         (WTR::TestOptions::hasSameInitializationOptions const):
2834
2835 2019-02-01  Chris Dumez  <cdumez@apple.com>
2836
2837         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2838         https://bugs.webkit.org/show_bug.cgi?id=193740
2839         <rdar://problem/47527267>
2840
2841         Reviewed by Alex Christensen.
2842
2843         Add API test coverage.
2844
2845         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2846
2847 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2848
2849         [ews-app] Add display name field to BuilderMapping model
2850         https://bugs.webkit.org/show_bug.cgi?id=194153
2851
2852         Reviewed by Lucas Forschler.
2853
2854         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2855         (BuilderMapping):
2856
2857 2019-02-01  Youenn Fablet  <youenn@apple.com>
2858
2859         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2860         https://bugs.webkit.org/show_bug.cgi?id=194155
2861
2862         Reviewed by Eric Carlson.
2863
2864         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2865         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2866         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2867
2868 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2869
2870         [LFC] Adjust replaced element's intrinsic ratio
2871         https://bugs.webkit.org/show_bug.cgi?id=194154
2872
2873         Reviewed by Antti Koivisto.
2874
2875         761
2876
2877         * LayoutReloaded/misc/LFC-passing-tests.txt:
2878
2879 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2880
2881         [WPE] Show test results in minibrowser
2882         https://bugs.webkit.org/show_bug.cgi?id=194150
2883
2884         Reviewed by Žan Doberšek.
2885
2886         * Scripts/webkitpy/port/wpe.py:
2887         (WPEPort.show_results_html_file):
2888
2889 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2890
2891         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2892         https://bugs.webkit.org/show_bug.cgi?id=194151
2893
2894         Reviewed by Žan Doberšek.
2895
2896         ALT + <- go back
2897         ALT + -> go forward
2898
2899         * MiniBrowser/wpe/main.cpp:
2900         (main):
2901
2902 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2903
2904         [LFC] Set intrinsic size on Layout::Replaced
2905         https://bugs.webkit.org/show_bug.cgi?id=194139
2906
2907         Reviewed by Antti Koivisto.
2908
2909         744
2910
2911         * LayoutReloaded/misc/LFC-passing-tests.txt:
2912
2913 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2914
2915         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2916         https://bugs.webkit.org/show_bug.cgi?id=194146
2917
2918         Reviewed by Xabier Rodriguez-Calvar.
2919
2920         It allows to open relative paths.
2921
2922         * MiniBrowser/wpe/main.cpp:
2923         (main):
2924
2925 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2926
2927         Update flakiness dashboard configuration after recent queue changes
2928         https://bugs.webkit.org/show_bug.cgi?id=194127
2929
2930         Rubber-stamped by Aakash Jain.
2931
2932         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2933
2934         * TestResultServer/static-dashboards/builders.jsonp:
2935
2936 2019-01-31  Youenn Fablet  <youenn@apple.com>
2937
2938         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2939         https://bugs.webkit.org/show_bug.cgi?id=194106
2940         <rdar://problem/47676333>
2941
2942         Reviewed by Ryosuke Niwa.
2943
2944         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2945         (TestWebKitAPI::didFinishNavigation):
2946         (TestWebKitAPI::TEST):
2947         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2948
2949 2019-01-31  Chris Dumez  <cdumez@apple.com>
2950
2951         Page zoom level is lost after a process swap or a crash
2952         https://bugs.webkit.org/show_bug.cgi?id=194105
2953         <rdar://problem/47610781>
2954
2955         Reviewed by Alex Christensen.
2956
2957         Add API test coverage.
2958
2959         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2960         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2961
2962 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2963
2964         Revert r238819 which is unneeded and caused a performance regression.
2965         https://bugs.webkit.org/show_bug.cgi?id=192272
2966         <rdar://problem/46664625>
2967
2968         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2969         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2970         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2971
2972 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2973
2974         Formalize WebKitAdditions mechanism of LoadOptimizer
2975         https://bugs.webkit.org/show_bug.cgi?id=193886
2976         <rdar://problem/47696809>
2977
2978         Reviewed by Brent Fulgham.
2979
2980         * MiniBrowser/MiniBrowser.entitlements:
2981         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2982
2983 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2984
2985         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2986         https://bugs.webkit.org/show_bug.cgi?id=194090
2987
2988         Reviewed by Antti Koivisto.
2989
2990         * LayoutReloaded/misc/LFC-passing-tests.txt:
2991
2992 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2993
2994         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2995         https://bugs.webkit.org/show_bug.cgi?id=194074
2996
2997         Reviewed by Antti Koivisto.
2998
2999         * LayoutReloaded/misc/LFC-passing-tests.txt:
3000
3001 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3002
3003         [LFC][BFC] Add support for block level replaced box.
3004         https://bugs.webkit.org/show_bug.cgi?id=194071
3005
3006         Reviewed by Antti Koivisto.
3007
3008         * LayoutReloaded/misc/LFC-passing-tests.txt:
3009
3010 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3011
3012         Fix WebKitTestRunner's testPath with Windows full paths
3013         https://bugs.webkit.org/show_bug.cgi?id=194012
3014
3015         Reviewed by Alex Christensen.
3016
3017         updateTestOptionsFromTestHeader failed to open test files because
3018         testPath returned wrong file paths. It returned a path "/C:/..."
3019         if a URL "file:///C:/..." was given.
3020
3021         * WebKitTestRunner/TestController.cpp:
3022         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3023
3024 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3025
3026         [WPE] Bump font related dependencies to match the GTK+ port
3027         https://bugs.webkit.org/show_bug.cgi?id=194017
3028
3029         Reviewed by Žan Doberšek.
3030
3031         * wpe/jhbuild.modules:
3032         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3033         * wpe/patches/icudata-stdlibs.patch: Added.
3034
3035 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3036
3037         Enable swipe tests on iOS
3038         https://bugs.webkit.org/show_bug.cgi?id=194076
3039
3040         Reviewed by Geoffrey Garen.
3041
3042         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3043         it causes a debug assertion failure in runUIScript.
3044
3045         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3046         (WTR::UIScriptController::beginBackSwipe):
3047         (WTR::UIScriptController::completeBackSwipe):
3048
3049 2019-01-30  Keith Rollin  <krollin@apple.com>
3050
3051         Use correct printf format specifier
3052         https://bugs.webkit.org/show_bug.cgi?id=194062
3053         <rdar://problem/47686167>
3054
3055         Reviewed by Alexey Proskuryakov.
3056
3057         LayoutTestSpellChecker.mm is trying to format a variable of type
3058         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3059         actually an unsigned long long. Fix this by formatting with %llu.
3060
3061         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3062         (-[LayoutTestTextCheckingResult description]):
3063
3064 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3065
3066         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3067         https://bugs.webkit.org/show_bug.cgi?id=193979
3068
3069         Reviewed by Wenson Hsieh.
3070
3071         Fix the test for iOS. Make the test work with iOS UA string.
3072
3073         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3074
3075 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3076
3077         Replace High Sierra LLINT CLoop bot due to hardware failure
3078         https://bugs.webkit.org/show_bug.cgi?id=194066
3079
3080         Reviewed by Aakash Jain.
3081
3082         * BuildSlaveSupport/build.webkit.org-config/config.json:
3083
3084 2019-01-30  Keith Rollin  <krollin@apple.com>
3085
3086         [NSDragItem init] is unavailable
3087         https://bugs.webkit.org/show_bug.cgi?id=194059
3088         <rdar://problem/47685715>
3089
3090         Reviewed by Wenson Hsieh.
3091
3092         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3093         DumpRenderTree and TestWebKitAPI, which both try to create an
3094         NSDragItem in a manner that invokes this method. Address this by using
3095         -initWithPasteboardWriter instead.
3096
3097         Note that the parameter passed to initWithPasteboardWriter is likely
3098         incorrect. In both cases, the object passed does not conform to
3099         NSPasteboardWriting. However, with this fix, we're no worse off than
3100         before, and can now perform builds with newer compilers and SDKs until
3101         a real fix can be crafted. That work is tracked in
3102         https://bugs.webkit.org/show_bug.cgi?id=194060
3103
3104         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3105         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3106         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3107         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3108
3109 2019-01-30  Daniel Bates  <dabates@apple.com>
3110
3111         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3112         https://bugs.webkit.org/show_bug.cgi?id=192824
3113         <rdar://problem/47100332>
3114
3115         Reviewed by Wenson Hsieh.
3116
3117         Fix a bug where the wrong usage code was used for F13 thru F24.
3118
3119         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3120         (keyCodeForDOMFunctionKey):
3121
3122 2019-01-30  Chris Dumez  <cdumez@apple.com>
3123
3124         Regression(PSON) Load hang can occur on history navigation
3125         https://bugs.webkit.org/show_bug.cgi?id=194030
3126         <rdar://problem/47656939>
3127
3128         Reviewed by Antti Koivisto.
3129
3130         Add API test coverage.
3131
3132         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3133
3134 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3135
3136         [LFC] Expand tests coverage.
3137
3138         Unreviewed test gardening.
3139
3140         * LayoutReloaded/misc/LFC-passing-tests.txt:
3141
3142 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3143
3144         [Flatpak] Add openjpeg support
3145         https://bugs.webkit.org/show_bug.cgi?id=194019
3146
3147         Reviewed by Michael Catanzaro.
3148
3149         * flatpak/org.webkit.CommonModules.yaml:
3150
3151 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3152
3153         Unreviewed, rolling out r240708.
3154         https://bugs.webkit.org/show_bug.cgi?id=194022
3155
3156         It broke WPE build (Requested by KaL on #webkit).
3157
3158         Reverted changeset:
3159
3160         "[WPE] Bump font related dependencies to match the GTK+ port"
3161         https://bugs.webkit.org/show_bug.cgi?id=194017
3162         https://trac.webkit.org/changeset/240708
3163
3164 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3165
3166         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3167         https://bugs.webkit.org/show_bug.cgi?id=194001
3168
3169         Reviewed by Antti Koivisto.
3170
3171         * LayoutReloaded/misc/LFC-passing-tests.txt:
3172
3173 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3174
3175         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3176         https://bugs.webkit.org/show_bug.cgi?id=194020
3177
3178         Reviewed by Antti Koivisto.
3179
3180         * LayoutReloaded/misc/LFC-passing-tests.txt:
3181
3182 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3183
3184         AX: Support color well on iOS
3185         https://bugs.webkit.org/show_bug.cgi?id=194010
3186
3187         Reviewed by Joanmarie Diggs.
3188
3189         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3190         (WTR::AccessibilityUIElement::stringAttributeValue):
3191
3192 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3193
3194         [WPE] Bump font related dependencies to match the GTK+ port
3195         https://bugs.webkit.org/show_bug.cgi?id=194017
3196
3197         Reviewed by Žan Doberšek.
3198
3199         * wpe/jhbuild.modules:
3200         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3201         * wpe/patches/icudata-stdlibs.patch: Added.
3202
3203 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3204
3205         [Mac] Update window scale API usage
3206         https://bugs.webkit.org/show_bug.cgi?id=193991
3207         rdar://problem/47614795
3208
3209         Reviewed by Tim Horton.
3210
3211         * DumpRenderTree/mac/DumpRenderTree.mm:
3212         (changeWindowScaleIfNeeded):
3213         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3214         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3215         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3216
3217 2019-01-29  Chris Dumez  <cdumez@apple.com>
3218
3219         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3220         https://bugs.webkit.org/show_bug.cgi?id=193977
3221         <rdar://problem/47643716>
3222
3223         Reviewed by Geoff Garen.
3224
3225         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3226         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3227         to the previous provisional committing *before* we make the last load. 
3228
3229         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3230
3231 2019-01-29  Youenn Fablet  <youenn@apple.com>
3232
3233         Adopt new SPI to evaluate server certificate trust
3234         https://bugs.webkit.org/show_bug.cgi?id=193355
3235
3236         Reviewed by Alex Christensen.
3237
3238         Add infrastructure to handle HTTPS server trust evaluation testing.
3239
3240         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3241         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3242         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3243         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3244         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3245         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3246         * WebKitTestRunner/TestController.cpp:
3247         (WTR::TestController::resetPreferencesToConsistentValues):
3248         (WTR::TestController::didReceiveAuthenticationChallenge):
3249         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3250         * WebKitTestRunner/TestController.h:
3251         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3252         * WebKitTestRunner/TestInvocation.cpp:
3253         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3254         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3255         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3256
3257 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3258
3259         [ews-build] Add build step to print bot Configuration
3260         https://bugs.webkit.org/show_bug.cgi?id=193887
3261
3262         Reviewed by Lucas Forschler.
3263
3264         * BuildSlaveSupport/ews-build/steps.py:
3265         (PrintConfiguration): Build step to print configuration.
3266         * BuildSlaveSupport/ews-build/factories.py:
3267
3268 2019-01-29  Chris Dumez  <cdumez@apple.com>
3269
3270         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3271         https://bugs.webkit.org/show_bug.cgi?id=193967
3272         <rdar://problem/47635348>
3273
3274         Reviewed by Alex Christensen.
3275
3276         Add API test coverage.
3277
3278         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3279         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3280
3281 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3282
3283         [ews-app] Handle incoming results data
3284         https://bugs.webkit.org/show_bug.cgi?id=193973
3285
3286         Reviewed by Lucas Forschler.
3287
3288         * BuildSlaveSupport/ews-app/ews/views/results.py:
3289
3290 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3291
3292         [ews-app] Make the results url generic
3293         https://bugs.webkit.org/show_bug.cgi?id=193928
3294
3295         Reviewed by Lucas Forschler.
3296
3297         * BuildSlaveSupport/ews-app/ews/urls.py:
3298
3299 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3300
3301         [ews-build] Configure buildbot to send events to ews-app
3302         https://bugs.webkit.org/show_bug.cgi?id=193968
3303
3304         Reviewed by Lucas Forschler.
3305
3306         * BuildSlaveSupport/ews-build/events.py: Added.
3307         * BuildSlaveSupport/ews-build/master.cfg:
3308
3309 2019-01-29  Keith Rollin  <krollin@apple.com>
3310
3311         Add .xcfilelists to Run Script build phases
3312         https://bugs.webkit.org/show_bug.cgi?id=193792
3313         <rdar://problem/47201785>
3314
3315         Reviewed by Alex Christensen.
3316
3317         As part of supporting XCBuild, update the necessary Run Script build
3318         phases in their Xcode projects to refer to their associated
3319         .xcfilelist files.
3320
3321         Note that the addition of these files bumps the Xcode project version
3322         number to something that's Xcode 10 compatible. This change means that
3323         older versions of the Xcode IDE can't read these projects. Nor can it
3324         fully load workspaces that refer to these projects (the updated
3325         projects are shown as non-expandable placeholders). `xcodebuild` can
3326         still build these projects; it's just that the IDE can't open them.
3327
3328         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3329         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3330
3331 2019-01-29  John Wilander  <wilander@apple.com>
3332
3333         Add data abstraction and validation for Ad Click Attribution
3334         https://bugs.webkit.org/show_bug.cgi?id=193916
3335         <rdar://problem/47603481>
3336
3337         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3338
3339         Ad click attribution has two steps. First, the storage of an ad
3340         campaign ID for a click that takes the user to a destination
3341         site. Second, a conversion on the destination site that can be
3342         attributed to the ad click.
3343
3344         This patch adds a class that represents a request for ad click
3345         attribution. Validation makes sure that the bits of entropy
3346         reported through this mechanism is limited.
3347
3348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3349         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3350         (TestWebKitAPI::TEST):
3351
3352 2019-01-29  Chris Dumez  <cdumez@apple.com>
3353
3354         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3355         https://bugs.webkit.org/show_bug.cgi?id=193932
3356         <rdar://problem/47598947>
3357
3358         Reviewed by Brady Eidson.
3359
3360         Add API test coverage.
3361
3362         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3363
3364 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3365
3366         Adding new passing LFC tests.
3367
3368         Unreviewed test gardening.
3369
3370         * LayoutReloaded/misc/LFC-passing-tests.txt:
3371
3372 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3373
3374         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3375         https://bugs.webkit.org/show_bug.cgi?id=193964
3376
3377         Reviewed by Antti Koivisto.
3378
3379         * LayoutReloaded/misc/LFC-passing-tests.txt:
3380
3381 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3382
3383         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3384         https://bugs.webkit.org/show_bug.cgi?id=193954
3385
3386         Reviewed by Antti Koivisto.
3387
3388         * LayoutReloaded/misc/LFC-passing-tests.txt:
3389
3390 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3391
3392         WebDriver: add support for running subtests
3393         https://bugs.webkit.org/show_bug.cgi?id=193904
3394
3395         Reviewed by Michael Catanzaro.
3396
3397         pytest already supports it by passing test.py::subtest, so we can do the same.
3398
3399         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3400         (get_item_name): Made this global.
3401         (CollectRecorder.__init__): Receive the parameter to ignore.
3402         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3403         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3404         (collect): Add parameter to ignore.
3405         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3406         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3407         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3408         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3409         (WebDriverTestRunnerSelenium.run): Ditto.
3410         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3411         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3412         (WebDriverTestRunnerW3C.run): Ditto.
3413
3414 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3415
3416         User agent string override for navigator.userAgent should be site specific quirks
3417         https://bugs.webkit.org/show_bug.cgi?id=193950
3418
3419         Reviewed by Brent Fulgham.
3420
3421         Updated per the _WKWebsitePolicies rename.
3422
3423         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3424         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3425
3426 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3427
3428         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3429         https://bugs.webkit.org/show_bug.cgi?id=193941
3430
3431         Reviewed by Alex Christensen.
3432
3433         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3434         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3435         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3436         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3437         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3438         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3439         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3440         * TestWebKitAPI/Tests/WTF/Time.cpp:
3441         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3442         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3443         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3444         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3445
3446 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3447
3448         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3449
3450         * Scripts/webkitpy/common/config/contributors.json:
3451
3452 2019-01-28  Andy Estes  <aestes@apple.com>
3453
3454         [watchOS] Enable Parental Controls content filtering
3455         https://bugs.webkit.org/show_bug.cgi?id=193939
3456         <rdar://problem/46641912>
3457
3458         Reviewed by Ryosuke Niwa.
3459
3460         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3461
3462 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3463
3464         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3465         <https://webkit.org/b/193884>
3466
3467         Reviewed by Jiewen Tan.
3468
3469         * Scripts/webkitpy/style/checkers/cpp.py:
3470         (check_language): Add LocalAuthentication to
3471         `frameworks_with_soft_links`.
3472
3473 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3474
3475         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3476         https://bugs.webkit.org/show_bug.cgi?id=193891
3477
3478         Reviewed by Ross Kirsling.
3479
3480         There were three problems in window sizes of WebView and the host window.
3481         1. The sizes of pixel image output were incorrect.
3482         2. The host window is going to appear after window.resize was invoked.
3483         3. window.resize resized only the host window, not WebView.
3484
3485         This change solves them with a following approach.
3486         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3487         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3488            as well as DumpRenderTree in order to match the client area and the window area.
3489         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3490         d. PlatformWebView::setWindowFrame changes both window sizes.
3491         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3492
3493         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3494         (WTR::PlatformWebView::PlatformWebView): Create the host window
3495         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3496         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3497         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3498
3499 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3500
3501         [ews-app] Add method to save Step data to database
3502         https://bugs.webkit.org/show_bug.cgi?id=193890
3503
3504         Reviewed by Lucas Forschler.
3505
3506         * BuildSlaveSupport/ews-app/ews/models/step.py:
3507         (Step.save_step): Method to save step data.
3508         (Step.update_step): Method to update step data.
3509         (Step.get_existing_step): Method to fetch existing step from database.
3510         (Step.is_valid_result): Method to validate valid step result.
3511
3512 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3513
3514         [ews-app] Add method to save Build data to database
3515         https://bugs.webkit.org/show_bug.cgi?id=193735
3516
3517         Reviewed by Lucas Forschler.
3518
3519         * BuildSlaveSupport/ews-app/ews/models/build.py:
3520         (Build.save_build): Method to save build information to database.
3521         (Build.get_existing_build): Method to fetch existing build from database.
3522         (Build.is_valid_result): Method to validate build result.
3523         * BuildSlaveSupport/ews-app/ews/common/util.py:
3524         (is_valid_int_id): Method to validate valid id.
3525
3526 2019-01-28  Chris Dumez  <cdumez@apple.com>
3527
3528         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3529         https://bugs.webkit.org/show_bug.cgi?id=193915
3530         <rdar://problem/47560907>
3531
3532         Reviewed by Alex Christensen.
3533
3534         Add API test coverage.
3535
3536         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3537
3538 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3539
3540         [ews-app] Rename id variables
3541         https://bugs.webkit.org/show_bug.cgi?id=193883
3542
3543         Reviewed by Lucas Forschler.
3544
3545         * BuildSlaveSupport/ews-app/ews/models/build.py:
3546         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3547         * BuildSlaveSupport/ews-app/ews/models/step.py:
3548         * BuildSlaveSupport/ews-app/ews/urls.py:
3549         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3550         * BuildSlaveSupport/ews-app/ews/views/results.py:
3551         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3552
3553 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3554
3555         [ews-app] Allow certain fields to be empty
3556         https://bugs.webkit.org/show_bug.cgi?id=193892
3557
3558         Reviewed by Lucas Forschler.
3559
3560         * BuildSlaveSupport/ews-app/ews/models/build.py:
3561         * BuildSlaveSupport/ews-app/ews/models/step.py:
3562
3563 2019-01-28  Rob Buis  <rbuis@igalia.com>
3564
3565         Update MIME type parser
3566         https://bugs.webkit.org/show_bug.cgi?id=180526
3567
3568         Reviewed by Frédéric Wang.
3569
3570         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3571         (TestWebKitAPI::TEST):
3572
3573 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3574
3575         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3576         https://bugs.webkit.org/show_bug.cgi?id=193896
3577
3578         Reviewed by Antti Koivisto.
3579
3580         * LayoutReloaded/misc/LFC-passing-tests.txt:
3581
3582 2018-12-15  Darin Adler  <darin@apple.com>
3583
3584         Replace many uses of String::format with more type-safe alternatives
3585         https://bugs.webkit.org/show_bug.cgi?id=192742
3586
3587         Reviewed by Mark Lam.
3588
3589         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3590         (WTR::cacheTestRunnerCallback): Use makeString.
3591         * WebKitTestRunner/TestController.cpp:
3592         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3593         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3594
3595 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3596
3597         Use a load optimizer for some sites
3598         https://bugs.webkit.org/show_bug.cgi?id=193881
3599         <rdar://problem/46325455>
3600
3601         Reviewed by Brent Fulgham.
3602
3603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3604         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3605
3606 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3607
3608         AX: Introduce a static accessibility tree
3609         https://bugs.webkit.org/show_bug.cgi?id=193348
3610         <rdar://problem/47203295>
3611
3612         Reviewed by Ryosuke Niwa.
3613
3614         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3615
3616 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3617
3618         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3619         https://bugs.webkit.org/show_bug.cgi?id=193867
3620
3621         Reviewed by Antti Koivisto.
3622
3623         * LayoutReloaded/misc/LFC-passing-tests.txt:
3624
3625 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3626
3627         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3628         https://bugs.webkit.org/show_bug.cgi?id=193865
3629
3630         Reviewed by Antti Koivisto.
3631
3632         * LayoutReloaded/misc/LFC-passing-tests.txt:
3633
3634 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3635
3636         Need a mechanism to override navigator.userAgent
3637         https://bugs.webkit.org/show_bug.cgi?id=193762
3638         <rdar://problem/47504939>
3639
3640         Reviewed by Brent Fulgham.
3641
3642         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3643
3644         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3645         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3646         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3647
3648 2019-01-25  Dean Jackson  <dino@apple.com>
3649
3650         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3651         https://bugs.webkit.org/show_bug.cgi?id=193831
3652         <rdar://problem/47399263>
3653
3654         Reviewed by Chris Dumez.
3655
3656         Two new tests that exercise cross-origin and same-origin System
3657         Previews.
3658
3659         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3660
3661 2019-01-25  Keith Rollin  <krollin@apple.com>
3662
3663         Update Xcode projects with "Check .xcfilelists" build phase
3664         https://bugs.webkit.org/show_bug.cgi?id=193790
3665         <rdar://problem/47201374>
3666
3667         Reviewed by Alex Christensen.
3668
3669         Support for XCBuild includes specifying inputs and outputs to various
3670         Run Script build phases. These inputs and outputs are specified as
3671         .xcfilelist files. Once created, these .xcfilelist files need to be
3672         kept up-to-date. In order to check that they are up-to-date or not,
3673         add an Xcode build step that invokes an external script that performs
3674         the checking. If the .xcfilelists are found to be out-of-date, update
3675         them, halt the build, and instruct the developer to restart the build
3676         with up-to-date files.
3677
3678         At this time, the checking and regenerating is performed only if the
3679         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3680         who want to use this facility can set this variable and test out the
3681         checking/regenerating. Once it seems like there are no egregious
3682         issues that upset a developer's workflow, we'll unconditionally enable
3683         this facility.
3684
3685         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3686         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3687         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3688         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3689
3690 2019-01-25  Keith Rollin  <krollin@apple.com>
3691
3692         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3693         https://bugs.webkit.org/show_bug.cgi?id=193781
3694         <rdar://problem/47201153>
3695
3696         Reviewed by Alex Christensen.
3697
3698         Part of generating the .xcfilelists used as part of adopting XCBuild
3699         includes running `make DerivedSources.make` from a standalone script.
3700         It’s important for this invocation to have the same environment as
3701         when the actual build invokes `make DerivedSources.make`. If the
3702         environments are different, then the two invocations will provide
3703         different results. In order to get the same environment in the
3704         standalone script, have the script launch xcodebuild targeting the
3705         "Apply Configuration to XCFileLists" build target, which will then
3706         re-invoke our standalone script. The script is now running again, this
3707         time in an environment with all workspace, project, target, xcconfig
3708         and other environment variables established.
3709
3710         The "Apply Configuration to XCFileLists" build target accomplishes
3711         this task via a small embedded shell script that consists only of:
3712
3713             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3714
3715         The process that invokes "Apply Configuration to XCFileLists" first
3716         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be