f66868eb6abfdced7e709203dd95921014724085
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2
3         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
4         https://bugs.webkit.org/show_bug.cgi?id=196743
5         <rdar://problem/43897551>
6
7         Reviewed by Tim Horton.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
10         (TEST):
11
12 2019-04-09  Youenn Fablet  <youenn@apple.com>
13
14         Close service worker database on network process suspension
15         https://bugs.webkit.org/show_bug.cgi?id=196623
16         <rdar://problem/48930869>
17
18         Reviewed by Alex Christensen.
19
20         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
21
22 2019-04-09  Daniel Bates  <dabates@apple.com>
23
24         [iPad] Should open popover when the spacebar is pressed
25         https://bugs.webkit.org/show_bug.cgi?id=196360
26         <rdar://problem/49389129>
27
28         Reviewed by Brent Fulgham.
29
30         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
31
32         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
33         (WTR::UIScriptController::isShowingPopover const): Added.
34         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
35         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
36         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
37         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
38         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
39         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
40         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
41         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
42         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
43         (WTR::UIScriptController::isShowingPopover const): Added.
44         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
45         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
46         * TestRunnerShared/UIScriptContext/UIScriptController.h:
47         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
48         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
49         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
50         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
51         (-[TestRunnerWKWebView _willPresentPopover]): Added.
52         (-[TestRunnerWKWebView _didDismissPopover]): Added.
53         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
54         (WTR::UIScriptController::isShowingPopover const): Added.
55         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
56         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
57
58 2019-04-09  Alex Christensen  <achristensen@webkit.org>
59
60         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
61         https://bugs.webkit.org/show_bug.cgi?id=196665
62         <rdar://45115669>
63
64         Reviewed by Geoff Garen.
65
66         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
67         (goBack):
68         (+[SimpleLookupContext sharedLookupContext]):
69         (-[SimpleLookupContext lookUpURL:completionHandler:]):
70         (TEST):
71         (+[Simple3LookupContext sharedLookupContext]): Deleted.
72         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
73
74 2019-04-09  John Wilander  <wilander@apple.com>
75
76         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
77         https://bugs.webkit.org/show_bug.cgi?id=196558
78         <rdar://problem/47650245>
79
80         Reviewed by Youenn Fablet.
81
82         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
83         (TestWebKitAPI::TEST):
84             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
85
86 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
87
88         [CMake] Apple builds should use ICU_INCLUDE_DIRS
89         https://bugs.webkit.org/show_bug.cgi?id=196720
90
91         Reviewed by Konstantin Tokarev.
92
93         * TestWebKitAPI/PlatformMac.cmake:
94
95 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
96
97         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
98         https://bugs.webkit.org/show_bug.cgi?id=196694
99         <rdar://problem/48388734>
100
101         Rubber-stamped by Aakash Jain.
102
103         * Scripts/webkitpy/port/image_diff.py:
104         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
105         * Scripts/webkitpy/port/server_process.py:
106         (ServerProcess.has_available_stdout): Check if stdout has data in it.
107         (ServerProcess._wait_for_data_and_update_buffers_using_select):
108         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
109         * Scripts/webkitpy/port/server_process_mock.py:
110         (MockServerProcess.has_available_stdout):
111         * Scripts/webkitpy/port/server_process_unittest.py:
112         (TestServerProcess.serial_test_basic):
113
114 2019-04-09  Jer Noble  <jer.noble@apple.com>
115
116         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
117         https://bugs.webkit.org/show_bug.cgi?id=196097
118
119         Reviewed by Eric Carlson.
120
121         Drive-by bug fix: allow tests to play audio without a user gesture by default.
122
123         * DumpRenderTree/mac/DumpRenderTree.mm:
124         (resetWebPreferencesToConsistentValues):
125         * WebKitTestRunner/TestController.cpp:
126         (WTR::TestController::resetPreferencesToConsistentValues):
127
128 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
129
130         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
131         https://bugs.webkit.org/show_bug.cgi?id=196690
132
133         Reviewed by Michael Catanzaro.
134
135         * QueueStatusServer/config/queues.py:
136         * Scripts/webkitpy/common/config/ews.json:
137         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
138         (test_ews_name):
139
140 2019-04-09  Chris Dumez  <cdumez@apple.com>
141
142         Loads using loadHTMLString() cause flashing when process-swapping
143         https://bugs.webkit.org/show_bug.cgi?id=196714
144         <rdar://problem/49637354>
145
146         Reviewed by Antti Koivisto.
147
148         Add API test coverage.
149
150         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
151
152 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
153
154         Unreviewed. Fix ATK accessibility tests after r244059.
155
156         We are failing to load the injected bundle due to undefined symbol
157         AccessibilityUIElement::replaceTextInRange().
158
159         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
160         (WTR::AccessibilityUIElement::replaceTextInRange):
161
162 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
163
164         AX: Support API: accessibilityReplaceRange:withText
165         https://bugs.webkit.org/show_bug.cgi?id=196636
166
167         Unreviewed build fix for Windows port.
168
169         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
170         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
171
172 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
173
174         [CMake][WinCairo] Separate copied headers into different directories
175         https://bugs.webkit.org/show_bug.cgi?id=196655
176
177         Reviewed by Michael Catanzaro.
178
179         * DumpRenderTree/CMakeLists.txt:
180         * MiniBrowser/win/CMakeLists.txt:
181         * TestWebKitAPI/CMakeLists.txt:
182         * TestWebKitAPI/PlatformWin.cmake:
183
184 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
185
186         Log stack-trace for run-webkit-tests when interrupted
187         https://bugs.webkit.org/show_bug.cgi?id=176393
188         <rdar://problem/34262310>
189
190         Reviewed by Lucas Forschler.
191
192         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
193         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
194         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
195         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
196         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
198         (main): Set handlers to log stack trace on interruption.
199
200 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
201
202         AX: Support API: accessibilityReplaceRange:withText
203         https://bugs.webkit.org/show_bug.cgi?id=196636
204
205         Unreviewed build fix for Windows port.
206
207         * DumpRenderTree/AccessibilityUIElement.cpp:
208         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
209
210 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
211
212         [ews-build] Scripts using Buildbot API have CORS error
213         https://bugs.webkit.org/show_bug.cgi?id=196709
214
215         Reviewed by Alexey Proskuryakov.
216
217         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
218
219 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
220
221         AX: Support API: accessibilityReplaceRange:withText
222         https://bugs.webkit.org/show_bug.cgi?id=196636
223
224         Reviewed by Daniel Bates.
225
226         * DumpRenderTree/AccessibilityUIElement.cpp:
227         (replaceTextInRangeCallback):
228         (AccessibilityUIElement::replaceTextInRange):
229         (AccessibilityUIElement::getJSClass):
230         * DumpRenderTree/AccessibilityUIElement.h:
231         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
232         (AccessibilityUIElement::replaceTextInRange):
233         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
234         (AccessibilityUIElement::replaceTextInRange):
235         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
236         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
237         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
238         (WTR::AccessibilityUIElement::replaceTextInRange):
239         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
240         (WTR::AccessibilityUIElement::replaceTextInRange):
241
242 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
243
244         [iOS] Do not allow starting selection drags when selection views are not visible
245         https://bugs.webkit.org/show_bug.cgi?id=196686
246         <rdar://problem/49399192>
247
248         Reviewed by Tim Horton.
249
250         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
251         also add some new API tests to cover scenarios where the web view is not first responder.
252
253         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
254         (TestWebKitAPI::TEST):
255         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
256
257         Add a switch to optionally make the web view first responder when starting the simulated drag.
258
259         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
260         (-[DragAndDropSimulator initWithWebView:]):
261         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
262
263 2019-04-08  Justin Fan  <justin_fan@apple.com>
264
265         [Web GPU] Fix Web GPU experimental feature on iOS
266         https://bugs.webkit.org/show_bug.cgi?id=196632
267
268         Reviewed by Myles C. Maxfield.
269
270         Properly make Web GPU available on iOS 11+.
271
272         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
273
274 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
275
276         [ews-build] Do not upload archive when Compile Fails
277         https://bugs.webkit.org/show_bug.cgi?id=196674
278
279         Reviewed by Alexey Proskuryakov.
280
281         * BuildSlaveSupport/ews-build/factories.py:
282         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
283         * BuildSlaveSupport/ews-build/steps.py:
284         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
285         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
286         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
287
288 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
289
290         Enable DFG on MIPS
291         https://bugs.webkit.org/show_bug.cgi?id=196689
292
293         Reviewed by Žan Doberšek.
294
295         Since the bytecode change, we enabled the baseline JIT on mips in
296         r240432, but DFG is still missing. With this change, all tests are
297         passing on a ci20 board.
298
299         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
300
301 2019-04-08  Philippe Normand  <pnormand@igalia.com>
302
303         [Flatpak] Second run update-webkitwpe-flatpak fails
304         https://bugs.webkit.org/show_bug.cgi?id=192702
305
306         Reviewed by Carlos Garcia Campos.
307
308         * flatpak/flatpakutils.py:
309         (FlatpakObject.flatpak): Fix typo.
310         (FlatpakPackage.install): When installing, also update to the configured remote commit.
311         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
312
313 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
314
315         [GTK][WPE] outlook.live.com displays old-fashioned UI
316         https://bugs.webkit.org/show_bug.cgi?id=196642
317
318         Reviewed by Carlos Garcia Campos.
319
320         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
321         (TestWebKitAPI::TEST): New Mac platform quirk test.
322
323 2019-04-07  Commit Queue  <commit-queue@webkit.org>
324
325         Unreviewed, rolling out r243956.
326         https://bugs.webkit.org/show_bug.cgi?id=196688
327
328         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
329         by aakashjain on #webkit).
330
331         Reverted changeset:
332
333         "Clicking "Go Back" from a safe browsing warning from an
334         iframe should navigate the WKWebView back to the previous
335         page"
336         https://bugs.webkit.org/show_bug.cgi?id=196665
337         https://trac.webkit.org/changeset/243956
338
339 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
340
341         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
342         https://bugs.webkit.org/show_bug.cgi?id=196669
343
344         Reviewed by Geoffrey Garen.
345
346         Added three new unit tests for WeakHashSet.
347
348         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
349         (WTF_WeakPtr.WeakHashSetConstObjects):
350         (WTF_WeakPtr.WeakHashSetComputesEmpty):
351         (WTF_WeakPtr.WeakHashSetComputeSize):
352
353 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
354
355         Hide next and previous form control buttons when WKWebView is editable
356         https://bugs.webkit.org/show_bug.cgi?id=196672
357         <rdar://problem/35625321>
358
359         Reviewed by Tim Horton.
360
361         Add a new API test.
362
363         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
364         (-[TestWKWebView lastTrailingBarButtonGroup]):
365         (TestWebKitAPI::TEST):
366         * TestWebKitAPI/ios/UIKitSPI.h:
367
368 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
369
370         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
371         https://bugs.webkit.org/show_bug.cgi?id=196077
372         <rdar://problem/49108202>
373
374         Reviewed by Chris Dumez.
375
376         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
377         on new web view.
378
379         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
380
381 2019-04-05  Saam Barati  <sbarati@apple.com>
382
383         Make compare-results understand MotionMark
384         https://bugs.webkit.org/show_bug.cgi?id=196666
385
386         Reviewed by Yusuke Suzuki.
387
388         * Scripts/compare-results:
389         (PLT5Results):
390         (detectMotionMark):
391         (detectMotionMark1_1):
392         (motionMarkResults):
393         (motionMark1_1Results):
394         (detectBenchmark):
395         (biggerIsBetter):
396         (main):
397
398 2019-04-05  Alex Christensen  <achristensen@webkit.org>
399
400         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
401         https://bugs.webkit.org/show_bug.cgi?id=196665
402         <rdar://45115669>
403
404         Reviewed by Geoff Garen.
405
406         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
407         (goBack):
408         (+[SimpleLookupContext sharedLookupContext]):
409         (-[SimpleLookupContext lookUpURL:completionHandler:]):
410         (TEST):
411         (+[Simple3LookupContext sharedLookupContext]): Deleted.
412         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
413
414 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
415
416         [ews-build] Add configuration and architecture for windows builders
417         https://bugs.webkit.org/show_bug.cgi?id=196660
418
419         Reviewed by Lucas Forschler.
420
421         * BuildSlaveSupport/ews-build/config.json:
422
423 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
424
425         webkitpy: Don't run subsequent rounds if interrupted
426         https://bugs.webkit.org/show_bug.cgi?id=196646
427
428         Reviewed by Aakash Jain.
429
430         * Scripts/webkitpy/layout_tests/controllers/manager.py:
431         (Manager.run): Bail out if interrupted.
432
433 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
434
435         Test sessionStorage in PSON private browsing mode
436         https://bugs.webkit.org/show_bug.cgi?id=196561
437
438         Reviewed by Alex Christensen.
439
440         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
441
442 2019-04-05  Commit Queue  <commit-queue@webkit.org>
443
444         Unreviewed, rolling out r243833.
445         https://bugs.webkit.org/show_bug.cgi?id=196645
446
447         This change breaks build of WPE and GTK ports (Requested by
448         annulen on #webkit).
449
450         Reverted changeset:
451
452         "[CMake][WTF] Mirror XCode header directories"
453         https://bugs.webkit.org/show_bug.cgi?id=191662
454         https://trac.webkit.org/changeset/243833
455
456 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
457
458         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
459         https://bugs.webkit.org/show_bug.cgi?id=196635
460
461         Reviewed by Antti Koivisto.
462         
463         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
464         for a test to enable async frame scrolling via:
465             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
466         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
467         
468         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
469
470         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
471         (WTR::InjectedBundle::beginTesting):
472         * WebKitTestRunner/TestController.cpp:
473         (WTR::TestController::resetPreferencesToConsistentValues):
474
475 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
476
477         Use a correct LC_RPATH when building with ASan
478         https://bugs.webkit.org/show_bug.cgi?id=196576
479
480         Reviewed by David Kilzer.
481
482         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
483         so that ../Frameworks is checked. This is simpler and more reliable than updating
484         each SPC service xcconfig.
485
486 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
487
488         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
489         https://bugs.webkit.org/show_bug.cgi?id=196629
490
491         Reviewed by Lucas Forschler.
492
493         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
494
495 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
496
497         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
498         https://bugs.webkit.org/show_bug.cgi?id=196618
499
500         Reviewed by Lucas Forschler.
501
502         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
503         (StatusBubble): Added QUEUE_TRIGGERS.
504         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
505         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
506         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
507         its parent(builder).
508
509 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
510
511         [ews-app] Status-bubble steps are sometimes displayed in reverse order
512         https://bugs.webkit.org/show_bug.cgi?id=196625
513
514         Reviewed by Lucas Forschler.
515
516         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
517         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
518
519 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
520
521         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
522         https://bugs.webkit.org/show_bug.cgi?id=196630
523
524         Reviewed by Wenson Hsieh.
525
526         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
527
528 2019-04-04  Youenn Fablet  <youenn@apple.com>
529
530         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
531         https://bugs.webkit.org/show_bug.cgi?id=196543
532
533         Reviewed by Alex Christensen.
534
535         * WebKitTestRunner/TestController.cpp:
536         (WTR::TestController::generatePageConfiguration):
537
538 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
539
540         [ews-app] Status bubble should not display skipped buildbot steps
541         https://bugs.webkit.org/show_bug.cgi?id=196584
542
543         Reviewed by Lucas Forschler.
544
545         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
546
547 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
548
549         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
550         https://bugs.webkit.org/show_bug.cgi?id=196620
551
552         Reviewed by Lucas Forschler.
553
554         * BuildSlaveSupport/ews-app/ews/config.py:
555
556 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
557
558         [Win] DumpRenderTreeWatchDog.py is not checked into source
559         https://bugs.webkit.org/show_bug.cgi?id=196567
560         <rdar://problem/49525901>
561
562         Reviewed by Lucas Forschler.
563
564         This script is used on Win EWS bots to terminate hanging DRT processes.
565
566         * EWSTools/dumprendertreewatchdog.py: Added.
567
568 2019-04-04  Chris Dumez  <cdumez@apple.com>
569
570         Unreviewed, roll out r243858 which made tests time out.
571
572         Disable new API tests on Windows instead.
573
574         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
575         (TestWebKitAPI::TEST):
576
577 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
578
579         [ATK] Cleanup WebPageAccessibilityObjectAtk
580         https://bugs.webkit.org/show_bug.cgi?id=196537
581
582         Reviewed by Michael Catanzaro.
583
584         Also consider files under atk directories as exceptions for GObject conventions.
585
586         * Scripts/webkitpy/style/checkers/cpp.py:
587         (check_identifier_name_in_declaration):
588
589 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
590
591         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
592         https://bugs.webkit.org/show_bug.cgi?id=196588
593         <rdar://problem/49365787>
594
595         Unreviewed build fix for Windows port.
596
597         error C3861: 'kill': identifier not found
598
599         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
600         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
601
602 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
603
604         [ews-build] Cancel build and similar operations should have authentication
605         https://bugs.webkit.org/show_bug.cgi?id=196520
606
607         Reviewed by Dewei Zhu.
608
609         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
610         environment variables.
611
612 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
613
614         [ews-build] Do not trigger queues which are not in production yet
615         https://bugs.webkit.org/show_bug.cgi?id=196581
616
617         Reviewed by Dewei Zhu.
618
619         * BuildSlaveSupport/ews-build/config.json:
620
621 2019-04-03  Chris Dumez  <cdumez@apple.com>
622
623         Unreviewed, fix typo in the name of API test added in r243848.
624
625         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
626         (TestWebKitAPI::TEST):
627
628 2019-04-03  Chris Dumez  <cdumez@apple.com>
629
630         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
631         https://bugs.webkit.org/show_bug.cgi?id=196588
632         <rdar://problem/49365787>
633
634         Reviewed by Ryosuke Niwa.
635
636         Add API test coverage.
637
638         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
639         (TestWebKitAPI::nullJavaScriptCallback):
640         (TestWebKitAPI::didCrashCheckFrames):
641         (TestWebKitAPI::TEST):
642
643 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
644
645         run-webkit-tests: Upload test results (new results database)
646         https://bugs.webkit.org/show_bug.cgi?id=196577
647         <rdar://problem/34841155>
648
649         Reviewed by Lucas Forschler.
650
651         * Scripts/webkitpy/layout_tests/controllers/manager.py:
652         (Manager.run): Upload results after each device shard, since the configuration will be
653         different for each device.
654         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
655         uploaded to a results database.
656         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
657         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
658
659 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
660
661         -apple-trailing-word is needed for browser detection
662         https://bugs.webkit.org/show_bug.cgi?id=196575
663
664         Unreviewed.
665
666         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
667
668 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
669
670         [CMake][WTF] Mirror XCode header directories
671         https://bugs.webkit.org/show_bug.cgi?id=191662
672
673         Reviewed by Konstantin Tokarev.
674
675         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
676         builds.
677
678         * CMakeLists.txt:
679         * DumpRenderTree/CMakeLists.txt:
680         * DumpRenderTree/PlatformWin.cmake:
681         * MiniBrowser/win/CMakeLists.txt:
682         * TestWebKitAPI/CMakeLists.txt:
683         * TestWebKitAPI/PlatformWin.cmake:
684         * WebKitTestRunner/PlatformGTK.cmake:
685         * WebKitTestRunner/PlatformWin.cmake:
686
687 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
688
689         [ews-app] Status bubble should not display certain infrastructure status messages
690         https://bugs.webkit.org/show_bug.cgi?id=196550
691
692         Reviewed by Lucas Forschler.
693
694         Do not display the steps which are un-needed for end-user. This information is still avaiable
695         if the user click on the bubble and look at the Buildbot build.
696         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
697         (StatusBubble._steps_messages):
698         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
699
700 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
701
702         [ews-build] Use https for sending data to ews-app
703         https://bugs.webkit.org/show_bug.cgi?id=196492
704
705         Reviewed by Lucas Forschler.
706
707         * BuildSlaveSupport/ews-build/events.py:
708
709 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
710
711         Remove support for -apple-trailing-word
712         https://bugs.webkit.org/show_bug.cgi?id=196525
713
714         Reviewed by Zalan Bujtas.
715
716         This CSS property is nonstandard and not used.
717
718         * Scripts/webkitperl/FeatureList.pm:
719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
720
721 2019-04-03  Youenn Fablet  <youenn@apple.com>
722
723         Add a test for DOMCache on multiple browsing in case of private browsing
724         https://bugs.webkit.org/show_bug.cgi?id=196524
725
726         Reviewed by Alex Christensen.
727
728         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
729         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
730
731 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
732
733         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
734         https://bugs.webkit.org/show_bug.cgi?id=196540
735
736         Reviewed by Aakash Jain.
737
738         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
739
740 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
741
742         Add plumbing for a compatibility mode preference in WebKit
743         https://bugs.webkit.org/show_bug.cgi?id=196005
744
745         Reviewed by Tim Horton.
746
747         Add new API tests.
748
749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
750         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
751
752 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
753
754         [WPE][GTK] Update libsrtp dependency package for Debian
755         https://bugs.webkit.org/show_bug.cgi?id=196528
756
757         Reviewed by Frédéric Wang.
758
759         * gtk/install-dependencies:
760         * wpe/install-dependencies:
761
762 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
763
764         [WK2] Add support for Window's beforeprint / afterprint events
765         https://bugs.webkit.org/show_bug.cgi?id=196478
766         <rdar://problem/49535124>
767
768         Unreviewed build fix for MSVC.
769
770         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
771
772         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
773
774         * WebKitTestRunner/TestController.cpp:
775         (WTR::printFrame): Use int and float literals.
776
777 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
778
779         [ews-build] Reassign bots to queues
780
781         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
782
783 2019-04-02  Chris Dumez  <cdumez@apple.com>
784
785         [WK2] Add support for Window's beforeprint / afterprint events
786         https://bugs.webkit.org/show_bug.cgi?id=196478
787
788         Reviewed by Alex Christensen.
789
790         Add minimal implementation for printFrame in WebKitTestRunner.
791
792         * WebKitTestRunner/TestController.cpp:
793         (WTR::printFrame):
794         (WTR::TestController::createOtherPage):
795         (WTR::TestController::createWebViewWithOptions):
796
797 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
798
799         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
800         https://bugs.webkit.org/show_bug.cgi?id=196491
801
802         Reviewed by Lucas Forschler.
803
804         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
805
806 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
807
808         [ews-build] Configure buildbot try credentials in environment variables
809         https://bugs.webkit.org/show_bug.cgi?id=196501
810
811         Reviewed by Lucas Forschler.
812
813         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
814         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
815         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
816
817 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
818
819         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
820         https://bugs.webkit.org/show_bug.cgi?id=196496
821         <rdar://problem/49521634>
822
823         Reviewed by Chris Dumez.
824
825         Add new API tests (see WebKit ChangeLog for more detail).
826
827         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
828         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
829         (TEST):
830
831 2019-04-02  David Kilzer  <ddkilzer@apple.com>
832
833         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
834         <https://webkit.org/b/196499>
835
836         Reviewed by Alexey Proskuryakov.
837
838         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
839         ENABLE_ADDRESS_SANITIZER.
840
841 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
842
843         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
844         https://bugs.webkit.org/show_bug.cgi?id=182757
845
846         Reviewed by Don Olmstead.
847
848         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
849         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
850
851 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
852
853         run-api-tests: Upload test results
854         https://bugs.webkit.org/show_bug.cgi?id=196323
855         <rdar://problem/49356714>
856
857         Reviewed by Lucas Forschler.
858
859         * Scripts/webkitpy/api_tests/manager.py:
860         (Manager):
861         (Manager.run): Upload results to a results database.
862         * Scripts/webkitpy/api_tests/run_api_tests.py:
863         (parse_args): Add upload arguments.
864         * Scripts/webkitpy/port/base.py:
865         (Port):
866         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
867         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
868         with commits from any other associated repositories.
869         * Scripts/webkitpy/port/device.py:
870         (Device):
871         (Device.build_version): Access build_versoin of underlying platform device.
872         * Scripts/webkitpy/port/ios_simulator_unittest.py:
873         (IOSSimulatorTest):
874         (IOSSimulatorTest.test_configuration_for_upload):
875         * Scripts/webkitpy/port/device_port.py:
876         (DevicePort):
877         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
878         the same as the machine uploading results.
879         * Scripts/webkitpy/port/mac.py:
880         (MacPort):
881         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
882         * Scripts/webkitpy/port/mac_unittest.py:
883         (MacTest):
884         (MacTest.test_configuration_for_upload):
885         * Scripts/webkitpy/xcode/simulated_device.py:
886         (SimulatedDeviceManager._create_device_with_runtime):
887         (SimulatedDevice.__init__): Create simulated device with a build_version.
888         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
889         (test_existing_simulator):
890
891 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
892
893         Remove extra newline characters (Follow-up fix to r243707)
894
895         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
896
897 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
898
899         [ews-app] Use API_KEY to accept results data
900         https://bugs.webkit.org/show_bug.cgi?id=196461
901
902         Reviewed by Dewei Zhu.
903
904         * BuildSlaveSupport/ews-app/ews/views/results.py:
905         (Results.post): Validate EWS_API_KEY before accepting any data.
906         * BuildSlaveSupport/ews-build/events.py:
907         (Events.sendData): Send EWS_API_KEY if available along with event data.
908
909 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
910
911         Unable to copy and paste a PDF from Notes into Mail compose body
912         https://bugs.webkit.org/show_bug.cgi?id=196442
913         <rdar://problem/48573098>
914
915         Reviewed by Tim Horton.
916
917         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
918         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
919         to be specified on the item providers.
920
921         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
922         (TestWebKitAPI::mapItemForTesting):
923         (TestWebKitAPI::contactItemForTesting):
924
925 2019-04-01  Tim Horton  <timothy_horton@apple.com>
926
927         Make UIWKDocumentContext rects per-character instead of per-word
928         https://bugs.webkit.org/show_bug.cgi?id=196459
929
930         Reviewed by Wenson Hsieh.
931
932         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
933         (TEST):
934         Adjust test results due to switching to per-character rects.
935
936 2019-04-01  Chris Dumez  <cdumez@apple.com>
937
938         UIProcess crash when a prewarmed process is terminated
939         https://bugs.webkit.org/show_bug.cgi?id=196451
940         <rdar://problem/49245471>
941
942         Reviewed by Geoffrey Garen.
943
944         Add API test coverage.
945
946         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
947         (TEST):
948
949 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
950
951         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
952         https://bugs.webkit.org/show_bug.cgi?id=196449
953
954         Reviewed by Lucas Forschler.
955
956         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
957         (StatusBubble.get_os_details): Method to get OS and Xcode details.
958         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
959         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
960
961 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
962
963         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
964         https://bugs.webkit.org/show_bug.cgi?id=196444
965
966         Reviewed by Lucas Forschler.
967
968         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
969
970 2019-04-01  Alex Christensen  <achristensen@webkit.org>
971
972         Add SPI to canonicalize NSURLs with WTF::URL
973         https://bugs.webkit.org/show_bug.cgi?id=196415
974         <rdar://problem/44980271>
975
976         Reviewed by Darin Adler.
977
978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
979         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
980         (TestWebKitAPI::TEST):
981
982 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
983
984         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
985         https://bugs.webkit.org/show_bug.cgi?id=196441
986
987         Reviewed by Carlos Garcia Campos.
988
989         Don't cache the wpe_view_backend object that might not exist yet at the
990         time of EventSenderProxy constructor invocation, but instead retrieve
991         that object whenever it's required for event dispatching. This should
992         avoid crashes in this constructor now that it's invoked before any
993         PlatformWindow has been set up (as changed in r243496).
994
995         * WebKitTestRunner/EventSenderProxy.h:
996         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
997         (WTR::viewBackend):
998         (WTR::EventSenderProxy::EventSenderProxy):
999         (WTR::EventSenderProxy::mouseDown):
1000         (WTR::EventSenderProxy::mouseUp):
1001         (WTR::EventSenderProxy::mouseMoveTo):
1002         (WTR::EventSenderProxy::mouseScrollBy):
1003         (WTR::EventSenderProxy::keyDown):
1004         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1005
1006 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1007
1008         [Win][WebKit] MiniBrowser should support high DPI display
1009         https://bugs.webkit.org/show_bug.cgi?id=196391
1010
1011         Reviewed by Alex Christensen.
1012
1013         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1014         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1015         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1016         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1017
1018 2019-03-31  Sam Weinig  <weinig@apple.com>
1019
1020         Remove more i386 specific configurations
1021         https://bugs.webkit.org/show_bug.cgi?id=196430
1022
1023         Reviewed by Alexey Proskuryakov.
1024
1025         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1026         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1027
1028 2019-03-31  Andy Estes  <aestes@apple.com>
1029
1030         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1031         https://bugs.webkit.org/show_bug.cgi?id=196433
1032         <rdar://problem/49293305>
1033
1034         Reviewed by Tim Horton.
1035
1036         Enhanced API test coverage to include all navigation response policy decisions in both
1037         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1038
1039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1040         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1041         (TestWebKitAPI::TEST):
1042         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1043         (readFile):
1044         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1045         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1046         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1047         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1048         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1049         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1050         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1051         (-[QuickLookDelegate _downloadDidStart:]):
1052         (-[QuickLookDelegate _download:didReceiveResponse:]):
1053         (-[QuickLookDelegate _download:didReceiveData:]):
1054         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1055         (-[QuickLookDelegate _downloadDidFinish:]):
1056         (-[QuickLookDelegate _download:didFailWithError:]):
1057         (-[QuickLookDelegate _downloadDidCancel:]):
1058         (-[QuickLookDelegate verifyDownload]):
1059         (runTest):
1060         (runTestDecideBeforeLoading):
1061         (runTestDecideAfterLoading):
1062         (TEST):
1063         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1064         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1065         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1066         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1067         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1068         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1069         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1070         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1071         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1072         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1073         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1074         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1075         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1076         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1077
1078 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1079
1080         [CMake] add testdfg as target with build-jsc
1081         https://bugs.webkit.org/show_bug.cgi?id=196393
1082
1083         Reviewed by Saam Barati.
1084
1085         Added testdfg as one of the targets to build when
1086         using CMake.
1087
1088         * Scripts/build-jsc:
1089
1090 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1091
1092         Delete WebMetal implementation in favor of WebGPU
1093         https://bugs.webkit.org/show_bug.cgi?id=195418
1094
1095         Reviewed by Dean Jackson.
1096
1097         * DumpRenderTree/mac/DumpRenderTree.mm:
1098         (enableExperimentalFeatures):
1099         (resetWebPreferencesToConsistentValues):
1100         * Scripts/webkitperl/FeatureList.pm:
1101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1103         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1104         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1105         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1106         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1107         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1108         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1109         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1110         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1111         (WTR::InjectedBundle::beginTesting):
1112         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1113         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1114         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1115
1116 2019-03-29  Chris Dumez  <cdumez@apple.com>
1117
1118         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1119         https://bugs.webkit.org/show_bug.cgi?id=196405
1120         <rdar://problem/49428130>
1121
1122         Reviewed by Wenson Hsieh.
1123
1124         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1125         the popover presentation methods to be no-ops. Use this in the new test added in
1126         r243523 so that we do not swizzle those methods for all tests. This is needed because
1127         those WatchOS tests rely on the popover getting presented and interactive.
1128
1129         * WebKitTestRunner/TestController.cpp:
1130         (WTR::updateTestOptionsFromTestHeader):
1131         * WebKitTestRunner/TestController.h:
1132         * WebKitTestRunner/TestOptions.h:
1133         (WTR::TestOptions::hasSameInitializationOptions const):
1134         * WebKitTestRunner/ios/TestControllerIOS.mm:
1135         (WTR::TestController::platformInitialize):
1136         (WTR::TestController::platformResetStateToConsistentValues):
1137
1138 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1139
1140         [Curl] Add Server Trust Evaluation Support.
1141         https://bugs.webkit.org/show_bug.cgi?id=191646
1142
1143         Reviewed by Fujii Hironori.
1144
1145         Implemented MiniBrowser UI for asking if user trusts the server.
1146
1147         * MiniBrowser/win/Common.cpp:
1148         (askServerTrustEvaluation):
1149         (replaceString):
1150         * MiniBrowser/win/Common.h:
1151         * MiniBrowser/win/MiniBrowserLib.rc:
1152         * MiniBrowser/win/MiniBrowserLibResource.h:
1153         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1154         (createPEMString):
1155         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1156         (WebKitBrowserWindow::canTrustServerCertificate):
1157         * MiniBrowser/win/WebKitBrowserWindow.h:
1158
1159 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1160
1161         Implement ResizeObserver.
1162         https://bugs.webkit.org/show_bug.cgi?id=157743
1163
1164         Reviewed by Simon Fraser.
1165
1166         Support resizeObserverEnabled webPreferences.
1167
1168         * DumpRenderTree/TestOptions.cpp:
1169         (TestOptions::TestOptions):
1170         * DumpRenderTree/TestOptions.h:
1171         * DumpRenderTree/mac/DumpRenderTree.mm:
1172         (setWebPreferencesForTestOptions):
1173         * DumpRenderTree/win/DumpRenderTree.cpp:
1174         (enableExperimentalFeatures):
1175         * Scripts/webkitperl/FeatureList.pm:
1176         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1177
1178 2019-03-28  John Wilander  <wilander@apple.com>
1179
1180         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1181         https://bugs.webkit.org/show_bug.cgi?id=196281
1182         <rdar://problem/48938748>
1183
1184         Reviewed by Alex Christensen.
1185
1186         This patch adds the function isStatisticsHasLocalStorage() to the
1187         TestRunner. With it, the page can query the WebsiteDataStore in the
1188         UI process to make sure that it sees LocalStorage.
1189
1190         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1192         (WTR::TestRunner::isStatisticsHasLocalStorage):
1193         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1194         * WebKitTestRunner/TestController.cpp:
1195         (WTR::TestController::isStatisticsHasLocalStorage):
1196         * WebKitTestRunner/TestController.h:
1197         * WebKitTestRunner/TestInvocation.cpp:
1198         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1199
1200 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1201
1202         API::Data::createWithoutCopying should do a null check before calling CFRelease
1203         https://bugs.webkit.org/show_bug.cgi?id=196276
1204         <rdar://problem/48059859>
1205
1206         Reviewed by Alex Christensen.
1207
1208         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1209
1210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1211         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1212         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1213         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1214         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1215         (TestWebKitAPI::TEST):
1216
1217 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1218
1219         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1220         https://bugs.webkit.org/show_bug.cgi?id=186276
1221
1222         Reviewed by Carlos Garcia Campos.
1223
1224         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1225         (webViewLoadChanged):
1226         (testWebResourceGetDataError):
1227         (testWebResourceGetDataEmpty):
1228         (beforeAll):
1229         (webViewloadChanged): Deleted.
1230
1231 2019-03-27  Andy Estes  <aestes@apple.com>
1232
1233         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1234         https://bugs.webkit.org/show_bug.cgi?id=196317
1235
1236         Reviewed by Dan Bernstein.
1237
1238         package-root copies built products into a staging directory using ditto(1), which does not
1239         follow symbolic links as it traverses a directory. Now that the files in
1240         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1241         itself, these become broken links when ditto'd into the staging directory.
1242
1243         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1244
1245         * Scripts/package-root:
1246
1247 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1248
1249         [ews-app] Update display text of Submit for ews analysis
1250         https://bugs.webkit.org/show_bug.cgi?id=196309
1251
1252         Reviewed by Dewei Zhu.
1253
1254         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1255
1256 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1257
1258         run-webkit-tests should check for leaks in WebKit processes
1259         <https://webkit.org/b/193772>
1260         <rdar://problem/46526680>
1261
1262         Reviewed by Ryosuke Niwa.
1263
1264         This works by doing the following:
1265         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1266           The list of child processes are returned one per line:
1267           process.name: pid
1268         - Run the "#LIST CHILD PROCESSES" command just before the
1269           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1270           processes on the ServerProcess object.
1271         - When the `--leaks` switch is handled, run check_for_leaks() on
1272           each child process after the main test harness.
1273
1274         * DumpRenderTree/mac/DumpRenderTree.mm:
1275         (handleControlCommand):
1276         - Use strncmp() instead of strcmp().
1277         - Add support for handling "#LIST CHILD PROCESSES" command.
1278
1279         * Scripts/webkitpy/port/base.py:
1280         (Port.check_for_leaks):
1281         * Scripts/webkitpy/port/darwin.py:
1282         (DarwinPort.check_for_leaks):
1283         - Rename redundant 'process_pid' argument to 'process_id'.
1284
1285         * Scripts/webkitpy/port/driver.py:
1286         (Driver.do_post_tests_work):
1287         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1288           longer the only command this sends to WebKitTestRunner.
1289         - If the `--leaks` switch is present, send the
1290           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1291           result using Port.set_webkit_processes().
1292         (Driver._parse_child_processes_output):
1293         - Add helper method to parse list of child process names and
1294           process IDs returned from WebKitTestRunner.
1295
1296         * Scripts/webkitpy/port/ios_device.py:
1297         (IOSDevicePort.check_for_leaks):
1298         - Rename redundant 'process_pid' argument to 'process_id'.
1299
1300         * Scripts/webkitpy/port/leakdetector.py:
1301         (LeakDetector._parse_leaks_output):
1302         - Return early if there is no leaks_output.
1303         (LeakDetector.check_for_leaks):
1304         - Rename redundant 'process_pid' argument to 'process_id'.
1305
1306         * Scripts/webkitpy/port/server_process.py:
1307         (ServerProcess.__init__):
1308         (ServerProcess.child_processes):
1309         (ServerProcess.set_child_processes):
1310         - Add instance variable to Port to store list of child process
1311           names and process IDs returned from WebKitTestRunner.
1312         (ServerProcess._start):
1313         - Clear self._child_processes.
1314         (ServerProcess.stop):
1315         - If self._child_processes is set, call
1316           self._port.check_for_leaks() for each child process.
1317
1318         * Scripts/webkitpy/port/server_process_unittest.py:
1319         (TrivialMockPort.check_for_leaks):
1320         - Rename redundant 'process_pid' argument to 'process_id'.
1321
1322         * Scripts/webkitpy/port/simulator_process.py:
1323         (SimulatorProcess.stop):
1324         - If self._child_processes is set, call
1325           self._port.check_for_leaks() for each child process.
1326
1327         * Scripts/webkitpy/port/watch_device.py:
1328         (WatchDevicePort.check_for_leaks):
1329         - Rename redundant 'process_pid' argument to 'process_id'.
1330
1331         * WebKitTestRunner/TestController.cpp:
1332         (WTR::TestController::dumpResponse):
1333         - Extract method from findAndDumpWorldLeaks() so that it may be
1334           reused by findAndDumpWebKitProcessIdentifiers().
1335         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1336         - Add method to output process name and process ID of both the
1337           WebContent and Networking processes.
1338         (WTR::TestController::findAndDumpWorldLeaks):
1339         - Fix missing newline in output when there were no abandoned
1340           documents.
1341         - Call dumpResponse() for extracted code.
1342         (WTR::TestController::handleControlCommand):
1343         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1344         - Use strncmp() instead of strcmp().
1345         - Call findAndDumpWebKitProcessIdentifiers() when
1346           "#LIST CHILD PROCESSES" command is sent.
1347         * WebKitTestRunner/TestController.h:
1348         (WTR::TestController::dumpResponse):
1349         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1350         - Declare methods.
1351
1352 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1353
1354         Unreviewed. Add GLib API test cases after r243434.
1355
1356         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1357         (testWebViewActiveURI):
1358         (serverCallback):
1359         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1360         (sendRequestCallback):
1361
1362 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1363
1364         Geolocation request not complete when watch request was started in a different web process
1365         https://bugs.webkit.org/show_bug.cgi?id=195996
1366
1367         Reviewed by Alex Christensen.
1368
1369         Add a test case.
1370
1371         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1372         (TestWebKitAPI::runJavaScriptAlert):
1373         (TestWebKitAPI::TEST):
1374
1375 2019-03-26  Keith Rollin  <krollin@apple.com>
1376
1377         Update the way generate-xcfilelists returns strings from functions
1378         https://bugs.webkit.org/show_bug.cgi?id=195975
1379         <rdar://problem/49040807>
1380
1381         Reviewed by Dean Jackson.
1382
1383         There are places where generate-xcfilelists executes assignments with
1384         statements like:
1385
1386             FOO=$(some_function)
1387
1388         where "some_function" return a string by echoing it. E.g.
1389
1390             some_function()
1391             {
1392                 echo "Hello, World"
1393             }
1394
1395         This is a common idiom, but it has a problem if "some_function" needs
1396         to call "exit" in an attempt to halt the entire script right then and
1397         there. Since "some_function" is called inside of $(), it's being
1398         executed in a sub-shell. Calling exit in that sub-shell simply exits
1399         that shell; it doesn't not exit the outer shell in which the main part
1400         of the script is still running. As such, the main script keeps
1401         executing when the intent was for the script to halt.
1402
1403         The solution to this is to use a different idiom for returning
1404         strings. The one we now is to pass in the name of the variable to
1405         receive the string result:
1406
1407             some_function()
1408             {
1409                 variable_name=$1
1410                 eval $variable_name ="Hello, World"
1411             }
1412
1413         The call site now looks like
1414
1415             some_function FOO
1416
1417         Because there's no invocation of a sub-shell, some_function can now
1418         call "exit" if it wants to, and the entire script will exit at that
1419         point.
1420
1421         * Scripts/generate-xcfilelists:
1422
1423 2019-03-26  Chris Dumez  <cdumez@apple.com>
1424
1425         Add basic layout test coverage for File Picker on iOS
1426         https://bugs.webkit.org/show_bug.cgi?id=196265
1427
1428         Reviewed by Wenson Hsieh.
1429
1430         Add layout test infrastructure to test the file picker on iOS.
1431
1432         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1433         (WTR::UIScriptController::dismissFilePicker):
1434         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1435         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1436         (WTR::UIScriptController::dismissFilePicker):
1437         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1438         * WebKitTestRunner/TestController.cpp:
1439         (WTR::TestController::createWebViewWithOptions):
1440         (WTR::updateTestOptionsFromTestHeader):
1441         * WebKitTestRunner/TestOptions.h:
1442         (WTR::TestOptions::hasSameInitializationOptions const):
1443         * WebKitTestRunner/ios/TestControllerIOS.mm:
1444         (overridePresentViewController):
1445         (WTR::TestController::platformInitialize):
1446         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1447         (WTR::UIScriptController::dismissFilePicker):
1448
1449 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1450
1451         Implement async paste method on UIWKInteractionViewProtocol
1452         https://bugs.webkit.org/show_bug.cgi?id=196267
1453         <rdar://problem/49236346>
1454
1455         Reviewed by Tim Horton.
1456
1457         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1458         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1459         are now a part of all iOS 12 internal SDKs.
1460
1461         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1462
1463         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1464         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1465
1466         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1467         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1468         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1469         * TestWebKitAPI/ios/UIKitSPI.h:
1470
1471 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1472
1473         [ews-build] Use PostgreSQL for ews.webkit.org database
1474         https://bugs.webkit.org/show_bug.cgi?id=196270
1475
1476         Reviewed by Lucas Forschler.
1477
1478         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1479
1480 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1481
1482         [ews] Reset simctl states on reboot
1483         https://bugs.webkit.org/show_bug.cgi?id=196260
1484
1485         Rubber-stamped by Aakash Jain.
1486
1487         * EWSTools/start-queue-mac.sh:
1488
1489 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1490
1491         [ews-build] Use PostgreSQL for ews-build database
1492         https://bugs.webkit.org/show_bug.cgi?id=196229
1493
1494         Reviewed by Lucas Forschler.
1495
1496         * BuildSlaveSupport/ews-build/master.cfg:
1497
1498 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1499
1500         [ews-build] Get master_hostname dynamically in master.cfg
1501         https://bugs.webkit.org/show_bug.cgi?id=196255
1502
1503         Reviewed by Lucas Forschler.
1504
1505         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1506         send events data in test mode.
1507
1508 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1509
1510         [ews-app] Set db_constraint to False for Foreign Keys
1511         https://bugs.webkit.org/show_bug.cgi?id=196252
1512
1513         Reviewed by Lucas Forschler.
1514
1515         * BuildSlaveSupport/ews-app/ews/models/build.py:
1516         * BuildSlaveSupport/ews-app/ews/models/step.py:
1517
1518 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1519
1520         [ews-build] is_test_mode_enabled should default to True
1521         https://bugs.webkit.org/show_bug.cgi?id=196248
1522
1523         Reviewed by Lucas Forschler.
1524
1525         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1526
1527 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1528
1529         [ews-app] Add webkitperl to ENABLED_QUEUES
1530         https://bugs.webkit.org/show_bug.cgi?id=196253
1531
1532         Reviewed by Lucas Forschler.
1533
1534         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1535
1536 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1537
1538         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1539         https://bugs.webkit.org/show_bug.cgi?id=196211
1540         rdar://problem/49110552
1541
1542         Reviewed by Tim Horton.
1543
1544         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1545         Make sure that EventSenderProxy always exists when running tests. We used to create
1546         it when resetting before the first test, which is a bit too late.
1547
1548         * WebKitTestRunner/TestController.h:
1549         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1550         (WTR::TestController::platformCreateWebView):
1551         (WTR::TestController::platformCreateOtherPage):
1552         (WTR::TestController::finishCreatingPlatformWebView):
1553         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1554         (WTR::PlatformWebView::PlatformWebView):
1555         Moved some code that made NSWindow use NSEvent during web view creation. We may
1556         need to move more if some other case us found, but this is enough for now.
1557
1558 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1559
1560         Unreviewed. Fix typo in GLib geolocation API after r243285.
1561
1562         gelocation -> geolocation.
1563
1564         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1565         (testGeolocationManagerWatchPosition):
1566
1567 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1568
1569         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1570         https://bugs.webkit.org/show_bug.cgi?id=196213
1571
1572         Reviewed by Geoff Garen.
1573
1574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1575         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1576         (credentialWithIdentityAndKeychainPath):
1577         (-[ChallengeDelegate webView:didFinishNavigation:]):
1578         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1579         (TestWebKitAPI::TEST):
1580
1581 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1582
1583         Expected shouldn't assume its contained types are copyable
1584         https://bugs.webkit.org/show_bug.cgi?id=195986
1585
1586         Reviewed by JF Bastien.
1587
1588         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1589         (TestWebKitAPI::NonCopyable::operator== const):
1590         (TestWebKitAPI::NonCopyable::operator!= const):
1591         (TestWebKitAPI::TEST):
1592
1593 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1594
1595         Remove some now-unnecessary dynamic class lookup
1596         https://bugs.webkit.org/show_bug.cgi?id=196237
1597
1598         Reviewed by Simon Fraser.
1599
1600         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1601         (makeRequest):
1602         (TEST):
1603
1604 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1605
1606         Unreviewed, rolling out r243450.
1607
1608         AppleWin and WinCairo port builds get broken.
1609
1610         Reverted changeset:
1611
1612         "Add test for fix of #196095"
1613         https://bugs.webkit.org/show_bug.cgi?id=196097
1614         https://trac.webkit.org/changeset/243450
1615
1616 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1617
1618         Unreviewed, rolling out r243465.
1619         https://bugs.webkit.org/show_bug.cgi?id=196226
1620
1621         the test doesn't build (Requested by thorton on #webkit).
1622
1623         Reverted changeset:
1624
1625         "Do not terminate the NetworkProcess if a third party
1626         application sends a NSCredential with a SecIdentityRef"
1627         https://bugs.webkit.org/show_bug.cgi?id=196213
1628         https://trac.webkit.org/changeset/243465
1629
1630 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1631
1632         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1633         https://bugs.webkit.org/show_bug.cgi?id=196213
1634
1635         Reviewed by Geoff Garen.
1636
1637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1638         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1639         (credentialWithIdentityAndKeychainPath):
1640         (-[ChallengeDelegate webView:didFinishNavigation:]):
1641         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1642         (TestWebKitAPI::TEST):
1643
1644 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1645
1646         [ews-build] Gracefully handle missing patch_id in events
1647         https://bugs.webkit.org/show_bug.cgi?id=196216
1648
1649         Reviewed by Lucas Forschler.
1650
1651         * BuildSlaveSupport/ews-build/events.py:
1652
1653 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1654
1655         [ews-build] use lz4 compression for improving buildbot performance
1656         https://bugs.webkit.org/show_bug.cgi?id=196155
1657
1658         Reviewed by Lucas Forschler.
1659
1660         * BuildSlaveSupport/ews-build/master.cfg:
1661
1662 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1663
1664         Pull some API testing helper methods out of TestWKWebView
1665         https://bugs.webkit.org/show_bug.cgi?id=196212
1666
1667         Reviewed by Tim Horton.
1668
1669         Refactor some more API testing utility methods, so that they can be used in
1670         tests that do not use TestWKWebView.
1671
1672         * TestWebKitAPI/cocoa/TestWKWebView.h:
1673         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1674         (-[WKWebView loadTestPageNamed:]):
1675         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1676         (-[WKWebView synchronouslyLoadHTMLString:]):
1677         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1678         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1679         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1680         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1681         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1682
1683 2019-03-25  Jer Noble  <jer.noble@apple.com>
1684
1685         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1686         https://bugs.webkit.org/show_bug.cgi?id=196097
1687
1688         Reviewed by Eric Carlson.
1689
1690         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1691
1692         * DumpRenderTree/mac/DumpRenderTree.mm:
1693         (resetWebPreferencesToConsistentValues):
1694         * WebKitTestRunner/TestController.cpp:
1695         (WTR::TestController::resetPreferencesToConsistentValues):
1696
1697 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1698
1699         Pull IPadUserInterfaceSwizzler out into a separate header file
1700         https://bugs.webkit.org/show_bug.cgi?id=196193
1701
1702         Reviewed by Anders Carlsson.
1703
1704         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1705         be used in other API tests.
1706
1707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1708         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1709         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1710         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1711         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1712         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1713         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1714
1715 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1716
1717         Remove NavigatorContentUtils in WebCore/Modules
1718         https://bugs.webkit.org/show_bug.cgi?id=196070
1719
1720         Reviewed by Alex Christensen.
1721
1722         NavigatorContentUtils was to support the custom scheme spec [1].
1723         However, in WebKit side, no port has supported the feature in
1724         WebKit layer after EFL port was removed. So there has been the
1725         only IDL implementation of the NavigatorContentUtils in WebCore.
1726         So we don't need to keep the implementation in WebCore anymore.
1727
1728         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1729
1730         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1731
1732 2019-03-24  Andy Estes  <aestes@apple.com>
1733
1734         [watchOS] Remove unused Proximity Networking code
1735         https://bugs.webkit.org/show_bug.cgi?id=196188
1736
1737         Reviewed by Tim Horton.
1738
1739         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1740         (TEST):
1741
1742 2019-03-23  Keith Miller  <keith_miller@apple.com>
1743
1744         Refactor clz/ctz and fix getLSBSet.
1745         https://bugs.webkit.org/show_bug.cgi?id=196162
1746
1747         Reviewed by Saam Barati.
1748
1749         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1750
1751         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1752         (TestWebKitAPI::TEST):
1753
1754 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1755
1756         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1757         https://bugs.webkit.org/show_bug.cgi?id=196143
1758
1759         Reviewed by Michael Catanzaro.
1760
1761         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1762         directories.
1763
1764         * Scripts/webkitpy/style/checkers/cpp.py:
1765         (check_identifier_name_in_declaration):
1766         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1767         (WebKitStyleTest.test_names):
1768
1769 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1770
1771         [Flatpak] Manifest expanding fails for qt WPE extension
1772         https://bugs.webkit.org/show_bug.cgi?id=196148
1773
1774         Reviewed by Alex Christensen.
1775
1776         * flatpak/flatpakutils.py:
1777         (expand_submodules_recurse): The last recurse manifest expand
1778         iteration might lead to a single module so take it into account
1779         and don't try to recurse further.
1780
1781 2019-03-22  Chris Dumez  <cdumez@apple.com>
1782
1783         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1784         https://bugs.webkit.org/show_bug.cgi?id=195348
1785         <rdar://problem/48622090>
1786
1787         Reviewed by Alex Christensen.
1788
1789         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1790         to NO when test.options().shouldIgnoreMetaViewport is false.
1791
1792         * WebKitTestRunner/ios/TestControllerIOS.mm:
1793         (WTR::TestController::platformConfigureViewForTest):
1794
1795 2019-03-22  Chris Dumez  <cdumez@apple.com>
1796
1797         Prewarmed processes should be usable with any website data store
1798         https://bugs.webkit.org/show_bug.cgi?id=196104
1799
1800         Reviewed by Alex Christensen.
1801
1802         Add API test coverage.
1803
1804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1805         (runInitialWarmedProcessUsedTest):
1806         (TEST):
1807
1808 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1809
1810         Back out local changes to Alex's Subversion working directory
1811
1812         They were accidentally committed.
1813
1814         * Scripts/webkitpy/common/system/abstractexecutive.py:
1815         (AbstractExecutive.wait_newest):
1816         * Scripts/webkitpy/common/system/executive.py:
1817         (Executive.running_pids):
1818         * Scripts/webkitpy/common/system/executive_mock.py:
1819         (MockExecutive.running_pids):
1820         * Scripts/webkitpy/common/system/executive_unittest.py:
1821         (ExecutiveTest.serial_test_running_pids):
1822         * Scripts/webkitpy/port/darwin.py:
1823         (DarwinPort.check_for_leaks):
1824         * Scripts/webkitpy/port/leakdetector.py:
1825         (LeakDetector.check_for_leaks):
1826         - This was the hack attached to Bug 193772.
1827
1828         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1829         (+[WebKitTestRunnerEvent mouseLocation]):
1830         - This works around a crash on an internal build.
1831
1832 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1833
1834         Fix the build after r243354
1835         https://bugs.webkit.org/show_bug.cgi?id=196138
1836         <rdar://problem/49145951>
1837
1838         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1839         (TEST):
1840         * TestWebKitAPI/ios/UIKitSPI.h:
1841
1842 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1843
1844         Adopt UIWKDocumentContext
1845         https://bugs.webkit.org/show_bug.cgi?id=196040
1846         <rdar://problem/48642440>
1847
1848         Reviewed by Ryosuke Niwa.
1849
1850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1851         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1852         (makeRequest):
1853         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1854         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1855         (applyStyle):
1856         (TEST):
1857         Add tests for UIWKDocumentContext.
1858
1859         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1860         (TEST):
1861         (recursiveFindWKContentView): Deleted.
1862         * TestWebKitAPI/cocoa/TestWKWebView.h:
1863         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1864         (recursiveFindWKContentView):
1865         (-[TestWKWebView wkContentView]):
1866         * TestWebKitAPI/ios/UIKitSPI.h:
1867         Share the WKContentView finding code between tests.
1868
1869 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1870
1871         [iOS WK2] Turn on async overflow scrolling by default
1872         https://bugs.webkit.org/show_bug.cgi?id=196011
1873         rdar://problem/48453859
1874
1875         Reviewed by Antti Koivisto.
1876         
1877         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1878         since so many basic layout tests have different results when compositing is triggered for
1879         overflow.
1880         
1881         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1882
1883         * WebKitTestRunner/TestController.cpp:
1884         (WTR::TestController::resetPreferencesToConsistentValues):
1885
1886 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1887
1888         [ews-build] Retry API test in case of failures
1889         https://bugs.webkit.org/show_bug.cgi?id=196004
1890
1891         Reviewed by Lucas Forschler.
1892
1893         * BuildSlaveSupport/ews-build/steps.py:
1894         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1895         (CompileWebKitToT.doStepIf): Ditto.
1896         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1897         (ReRunAPITests): Re-run API tests.
1898         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1899         (RunAPITestsWithoutPatch): Run API tests without patch.
1900         (RunAPITestsWithoutPatch.doStepIf):
1901         (RunAPITestsWithoutPatch.hideStepIf):
1902         (RunAPITestsWithoutPatch.evaluateCommand):
1903         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1904         (AnalyzeAPITestsResults.start):
1905         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1906         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1907         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1908         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1909
1910 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1911
1912         [ews-build] Update queues configurations
1913         https://bugs.webkit.org/show_bug.cgi?id=196074
1914
1915         Reviewed by Dewei Zhu.
1916
1917         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1918         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1919
1920 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1921
1922         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1923         https://bugs.webkit.org/show_bug.cgi?id=195680
1924         <rdar://problem/48903534>
1925
1926         Unreviewed infrastructure fix.
1927
1928         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1929         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1930
1931 2019-03-21  Andy Estes  <aestes@apple.com>
1932
1933         [iOS] Apple Pay should be available in documents with no user agent scripts
1934         https://bugs.webkit.org/show_bug.cgi?id=196061
1935         <rdar://problem/48649391>
1936
1937         Reviewed by Brady Eidson.
1938
1939         Added API tests and related infrastructure.
1940
1941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1942         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1943         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1944         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1945         (TestWebKitAPI::TEST):
1946         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1947         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1948         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1949         * TestWebKitAPI/cocoa/TestProtocol.mm:
1950         (-[TestProtocol startLoading]):
1951         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1952         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1953         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1954         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1955
1956 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1957
1958         REGRESSSION (r243297): webkitpy tests broken
1959         https://bugs.webkit.org/show_bug.cgi?id=196108
1960
1961         Reviewed by Aakash Jain.
1962
1963         r243297 updated contributors.json, which broke a few unit tests.
1964
1965         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1966         (IRCCommandTest.test_whois):
1967         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1968
1969 2019-03-21  Chris Dumez  <cdumez@apple.com>
1970
1971         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1972         https://bugs.webkit.org/show_bug.cgi?id=196041
1973         <rdar://problem/49083230>
1974
1975         Reviewed by Alex Christensen.
1976
1977         Add API test coverage.
1978
1979         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1980         (TEST):
1981
1982 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1983
1984         Add SPI to inform applications of WKContentRuleList actions
1985         https://bugs.webkit.org/show_bug.cgi?id=195965
1986         <rdar://problem/42664365>
1987
1988         Reviewed by Geoff Garen.
1989
1990         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1991         (TestWebKitAPI::allActionsForResourceLoad):
1992         (TestWebKitAPI::testRequest):
1993         (TestWebKitAPI::TEST_F):
1994         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1995         (Notification::description):
1996         (Notification::operator== const):
1997         (toVector):
1998         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1999         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2000         (makeContentRuleList):
2001         (TEST):
2002         (makeWarnContentRuleList): Deleted.
2003
2004 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2005
2006         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2007         https://bugs.webkit.org/show_bug.cgi?id=196088
2008
2009         Reviewed by Brian Burg.
2010
2011         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2012         Support checks when only one platform is specified. Also deprecate macosx() and
2013         force the use of macos() instead.
2014
2015         * Scripts/webkitpy/style/checkers/cpp.py:
2016         (check_min_versions_of_wk_api_available):
2017         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2018         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2019
2020 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2021
2022         Update status inactive committers' status to 'contributor'.
2023
2024         * Scripts/webkitpy/common/config/contributors.json:
2025
2026 2019-03-21  Xan Lopez  <xan@igalia.com>
2027
2028         [JSC][x86] Drop support for x87 floating point
2029         https://bugs.webkit.org/show_bug.cgi?id=194853
2030
2031         Reviewed by Don Olmstead.
2032
2033         Force SSE2 on x86/32bit builds.
2034
2035         * Scripts/webkitdirs.pm:
2036         (generateBuildSystemFromCMakeProject):
2037
2038 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2039
2040         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2041         https://bugs.webkit.org/show_bug.cgi?id=196073
2042
2043         Reviewed by Michael Catanzaro.
2044
2045         Add test cases to check functions and constructors with no arguments but receiving user data.
2046
2047         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2048         (checkUserData):
2049         (testJSCFunction):
2050         (fooCreateWithUserData):
2051         (testJSCClass):
2052
2053 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2054
2055         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2056
2057         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2058
2059         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2060
2061 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2062
2063         [GTK][WPE] Add API to provide geolocation information
2064         https://bugs.webkit.org/show_bug.cgi?id=195940
2065
2066         Reviewed by Michael Catanzaro.
2067
2068         Add a new test to check the new API.
2069
2070         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2071         (testGeolocationManagerCurrentPosition):
2072         (testGeolocationManagerWatchPosition):
2073         (beforeAll):
2074         (afterAll):
2075         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2076         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2077         (beforeAll): Ditto.
2078         * TestWebKitAPI/glib/CMakeLists.txt:
2079
2080 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2081
2082         [GLib] Returning G_TYPE_OBJECT from a method does not work
2083         https://bugs.webkit.org/show_bug.cgi?id=195574
2084
2085         Reviewed by Michael Catanzaro.
2086
2087         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2088
2089         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2090         (getGFile):
2091         (getParent):
2092         (createGString):
2093         (getGString):
2094         (getGStringCopyWillRaise):
2095         (getGStringCopy):
2096         (getGStringStr):
2097         (getGStringLen):
2098         (freeGString):
2099         (testJSCClass):
2100
2101 2019-03-20  Saam Barati  <sbarati@apple.com>
2102
2103         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2104         https://bugs.webkit.org/show_bug.cgi?id=195721
2105
2106         Reviewed by Filip Pizlo.
2107
2108         * Scripts/run-javascriptcore-tests:
2109
2110 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2111
2112         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2113         https://bugs.webkit.org/show_bug.cgi?id=196049
2114
2115         Reviewed by Tim Horton.
2116
2117         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2118         overflow scrolling in general, so rename it.
2119
2120         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2121
2122 2019-03-20  Daniel Bates  <dabates@apple.com>
2123
2124         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2125         https://bugs.webkit.org/show_bug.cgi?id=196031
2126         <rdar://problem/49078172>
2127
2128         Reviewed by Tim Horton.
2129
2130         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2131         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2132         same code path used when the Done button is pressed to dismiss the <select> picker.
2133
2134         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2135         (TestWebKitAPI::TEST):
2136
2137 2019-03-20  Chris Dumez  <cdumez@apple.com>
2138
2139         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2140         https://bugs.webkit.org/show_bug.cgi?id=196029
2141         <rdar://problem/48954651>
2142
2143         Reviewed by Tim Horton.
2144
2145         Add API test coverage.
2146
2147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2148
2149 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2150
2151         [ews-build] Improve failure summary string for ApplyPatch step
2152         https://bugs.webkit.org/show_bug.cgi?id=195995
2153
2154         Reviewed by Alexey Proskuryakov.
2155
2156         * BuildSlaveSupport/ews-build/steps.py:
2157         (ApplyPatch.getResultSummary): Override getResultSummary.
2158
2159 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2160
2161         AX: Implement support for new meter ARIA role
2162         https://bugs.webkit.org/show_bug.cgi?id=195966
2163
2164         Reviewed by Chris Fleizach.
2165
2166         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2167         to AXLevelIndicator.
2168
2169         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2170
2171 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2172
2173         [WebAuthN] Implement FIDO AppID extension
2174         https://bugs.webkit.org/show_bug.cgi?id=143491
2175         <rdar://problem/48298273>
2176
2177         Reviewed by Brent Fulgham.
2178
2179         Add a test that covers the new flag of convertToU2fSignCommand.
2180
2181         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2182         (TestWebKitAPI::TEST):
2183         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2184         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2185         (TestWebKitAPI::TEST):
2186
2187 2019-03-19  Keith Rollin  <krollin@apple.com>
2188
2189         Add support for more platforms to generate-xcfilelists
2190         https://bugs.webkit.org/show_bug.cgi?id=195977
2191
2192         Reviewed by Alexey Proskuryakov.
2193
2194         generate-xcfilelists incorrectly complains when involved with building
2195         WebKit for iphonesimulator:
2196
2197             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2198             …
2199             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2200
2201         Address this by teaching generate-xcfilelists about more platforms.
2202
2203         * Scripts/generate-xcfilelists:
2204
2205 2019-03-19  John Wilander  <wilander@apple.com>
2206
2207         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2208         https://bugs.webkit.org/show_bug.cgi?id=195923
2209         <rdar://problem/49001272>
2210
2211         Reviewed by Alex Christensen.
2212
2213         This patch does the following to the TestRunner:
2214         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2215         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2216         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2217
2218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2219         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2220         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2221         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2222         * WebKitTestRunner/TestController.cpp:
2223         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2224         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2225         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2226         * WebKitTestRunner/TestController.h:
2227         * WebKitTestRunner/TestInvocation.cpp:
2228         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2229
2230 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2231
2232         [CMake] Support more clang and gcc sanitizers
2233         https://bugs.webkit.org/show_bug.cgi?id=195956
2234
2235         Reviewed by Michael Catanzaro.
2236
2237         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2238
2239 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2240
2241         [ews-build] Improve summary for PrintConfiguration step
2242         https://bugs.webkit.org/show_bug.cgi?id=195945
2243
2244         Reviewed by Lucas Forschler.
2245
2246         * BuildSlaveSupport/ews-build/steps.py:
2247         (PrintConfiguration.getResultSummary): Override getResultSummary.
2248
2249 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2250
2251         [ews-build] Improve summary for CheckOutSource step
2252         https://bugs.webkit.org/show_bug.cgi?id=195963
2253
2254         Reviewed by Lucas Forschler.
2255
2256         * BuildSlaveSupport/ews-build/steps.py:
2257         (CheckOutSource.getResultSummary):
2258
2259 2019-03-19  Daniel Bates  <dabates@apple.com>
2260
2261         [iOS] Focus not preserved when switching between tabs
2262         https://bugs.webkit.org/show_bug.cgi?id=195820
2263         <rdar://problem/43614450>
2264
2265         Reviewed by Brent Fulgham.
2266
2267         Add tests to ensure that we restore focus when resigning and becoming first responder.
2268
2269         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2270         (TestWebKitAPI::TEST):
2271
2272 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2273
2274         Make WTFLogChannelState and WTFLogLevel enum classes
2275         https://bugs.webkit.org/show_bug.cgi?id=195904
2276
2277         Reviewed by Eric Carlson.
2278
2279         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2280         (TestWebKitAPI::TEST_F):
2281
2282 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2283
2284         [GStreamer][EME] Backported mssdemux protection data crash fix
2285         https://bugs.webkit.org/show_bug.cgi?id=195918
2286
2287         Reviewed by Philippe Normand.
2288
2289         * gstreamer/jhbuild.modules:
2290         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2291
2292 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2293
2294         Unreviewed, rolling out r243132.
2295
2296         Broke GTK build
2297
2298         Reverted changeset:
2299
2300         "Make WTFLogChannelState and WTFLogLevel enum classes"
2301         https://bugs.webkit.org/show_bug.cgi?id=195904
2302         https://trac.webkit.org/changeset/243132
2303
2304 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2305
2306         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2307
2308         * Scripts/webkitdirs.pm:
2309         (builtDylibPathForName): Adjust the shared library name that's changed
2310         with the API version bump in r243073.
2311
2312 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2313
2314         Make WTFLogChannelState and WTFLogLevel enum classes
2315         https://bugs.webkit.org/show_bug.cgi?id=195904
2316
2317         Reviewed by Eric Carlson.
2318
2319         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2320         (TestWebKitAPI::TEST_F):
2321
2322 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2323
2324         Disable flaky test added in r2431100
2325         https://webkit.org/b/195785
2326
2327         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2328         (TestWebKitAPI::TEST):
2329         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2330
2331 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2332
2333         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2334         https://bugs.webkit.org/show_bug.cgi?id=195916
2335
2336         Reviewed by Tim Horton.
2337
2338         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2339         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2340
2341 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2342
2343         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2344
2345         * Scripts/webkitpy/common/config/contributors.json:
2346
2347 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2348
2349         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2350         https://bugs.webkit.org/show_bug.cgi?id=195785
2351
2352         Reviewed by Geoffrey Garen.
2353
2354         * TestWebKitAPI/TCPServer.cpp: Added.
2355         (TestWebKitAPI::TCPServer::TCPServer):
2356         (TestWebKitAPI::TCPServer::~TCPServer):
2357         (TestWebKitAPI::TCPServer::socketBindListen):
2358         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2359         * TestWebKitAPI/TCPServer.h: Added.
2360         (TestWebKitAPI::TCPServer::port const):
2361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2362         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2363         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2364         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2365         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2366         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2367         (TestWebKitAPI::respondSlowly):
2368         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2369         (TestWebKitAPI::downloadAtRate):
2370         (TestWebKitAPI::TEST):
2371
2372 2019-03-18  Saam Barati  <sbarati@apple.com>
2373
2374         Add a plan file for JetStream 2
2375         https://bugs.webkit.org/show_bug.cgi?id=190734
2376
2377         Reviewed by Mark Lam.
2378
2379         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2380
2381 2019-03-18  Chris Dumez  <cdumez@apple.com>
2382
2383         Delay WebProcess launch until a load is triggered in a Web view
2384         https://bugs.webkit.org/show_bug.cgi?id=195758
2385         <rdar://problem/48126013>
2386
2387         Reviewed by Geoff Garen.
2388
2389         Add API test coverage. Also update some existing API tests to not expect
2390         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2391
2392         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2393         (TestWebKitAPI::TEST):
2394         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2395         (TestWebKitAPI::TEST):
2396         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2397         (TEST):
2398         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2399         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2400         (TEST):
2401         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2402         (TEST):
2403         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2404
2405 2019-03-18  Xan Lopez  <xan@igalia.com>
2406
2407         [CMake] Prevent potential warning when determining $architecture
2408         https://bugs.webkit.org/show_bug.cgi?id=195891
2409
2410         Reviewed by Michael Catanzaro.
2411
2412         It's possible for generateBuildSystemForCMakeProject to be called
2413         before determineArchitecture() is ever called. This will make the
2414         first eq check with $architecture to be bogus (and print a
2415         warning). Change that to an eq check with architecture(), which
2416         implicitly calls determineArchitecture() if needed, and change all
2417         the other similar cases in the method in the same way to prevent
2418         future bugs like this one.
2419
2420         * Scripts/webkitdirs.pm:
2421         (generateBuildSystemFromCMakeProject):
2422
2423 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2424
2425         [WPE] Tarballs generated with “make dist” cannot build documentation
2426         https://bugs.webkit.org/show_bug.cgi?id=195885
2427
2428         Reviewed by Carlos Garcia Campos.
2429
2430         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2431
2432 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2433
2434         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2435         https://bugs.webkit.org/show_bug.cgi?id=195883
2436
2437         Reviewed by Carlos Garcia Campos.
2438
2439         * gtkdoc/gtkdoc.py:
2440         (GTKDoc._run_command): When commands fail to run, include the full command line for
2441         the program invocation and the output it has generated on the standard error stream.
2442
2443 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2444
2445         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2446         https://bugs.webkit.org/show_bug.cgi?id=195786
2447
2448         Reviewed by Philippe Normand.
2449
2450         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2451         * wpe/jhbuild.modules: Ditto.
2452
2453 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2454
2455         [ews-build] Don't run clean builds on EWS builders
2456         https://bugs.webkit.org/show_bug.cgi?id=195851
2457
2458         Reviewed by Geoffrey Garen.
2459
2460         * BuildSlaveSupport/ews-build/factories.py:
2461
2462 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2463
2464         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2465         https://bugs.webkit.org/show_bug.cgi?id=195849
2466
2467         Reviewed by Chris Dumez.
2468
2469         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2470
2471         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2472         (runWebsiteDataStoreCustomPaths):
2473
2474 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2475
2476         webkitpy: Upload test results
2477         https://bugs.webkit.org/show_bug.cgi?id=195755
2478         <rdar://problem/48896182>
2479
2480         Reviewed by Aakash Jain.
2481
2482         Establish a new format for uploading results that is not tied to layout tests, apply
2483         that format to webkitpy tests.
2484
2485         * Scripts/webkitpy/common/checkout/scm/git.py:
2486         (Git.native_branch): Return what branch the current checkout is on.
2487         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2488         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2489         * Scripts/webkitpy/common/checkout/scm/svn.py:
2490         (SVN.native_branch): Ditto.
2491         * Scripts/webkitpy/common/system/platforminfo.py:
2492         (PlatformInfo.build_version): Return a build version for Mac.
2493         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2494         (MockPlatformInfo.__init__):
2495         (MockPlatformInfo.build_version):
2496         * Scripts/webkitpy/results: Added.
2497         * Scripts/webkitpy/results/__init__.py: Added.
2498         * Scripts/webkitpy/results/options.py: Added.
2499         (upload_options): OptParse list for upload options.
2500         * Scripts/webkitpy/results/upload.py: Added.
2501         (Upload): Class which enforces the upload format expected by the results server.
2502         (Upload.Expectations):
2503         (Upload.create_configuration):
2504         (Upload.create_commit):
2505         (Upload.create_details):
2506         (Upload.create_run_stats):
2507         (Upload.create_test_result):
2508         (Upload.__init__):
2509         (Upload.Encoder): Encode Upload object as json.
2510         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2511         * Scripts/webkitpy/results/upload_unittest.py: Added.
2512         * Scripts/webkitpy/test/main.py:
2513         (Tester._parse_args): Add upload arguments.
2514         (Tester._run_tests): Allow results to be uploaded.
2515         * Scripts/webkitpy/test/runner.py:
2516         (Runner.__init__): Record which tests were run, rather than just counting them.
2517         (Runner.handle):
2518         * Scripts/webkitpy/test/runner_unittest.py:
2519         (RunnerTest.test_run):
2520         * Scripts/webkitpy/thirdparty/__init__.py:
2521         (AutoinstallImportHook.find_module): Add requests auto-install.
2522         (AutoinstallImportHook._install_requests):
2523         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2524         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2525
2526 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2527
2528         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2529         https://bugs.webkit.org/show_bug.cgi?id=195810
2530
2531         Reviewed by Tim Horton.
2532
2533         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2534         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2535         ending certain layout tests.
2536
2537         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2538         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2539         (-[TestRunnerWKWebView dealloc]):
2540         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2541
2542         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2543         helper method when destroying the web view, and when resetting state between tests.
2544
2545         * WebKitTestRunner/ios/TestControllerIOS.mm:
2546         (WTR::TestController::platformResetStateToConsistentValues):
2547
2548         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2549
2550 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2551
2552         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2553         https://bugs.webkit.org/show_bug.cgi?id=190350
2554         <rdar://problem/45089503>
2555
2556         Reviewed by Geoffrey Garen.
2557
2558         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2559         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2560         (TEST):
2561         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2562         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2563         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2564         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2565         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2566         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2567         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2568         (runTest):
2569         (createDirectories):
2570         (TEST):
2571         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2572         (TEST):
2573         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2574         (TEST):
2575
2576 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2577
2578         Add support to WebPage for getting the contents as an attributed string.
2579         https://bugs.webkit.org/show_bug.cgi?id=195636
2580         rdar://problem/45055697
2581
2582         Reviewed by Tim Horton.
2583
2584         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2585         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2586
2587 2019-03-15  Chris Dumez  <cdumez@apple.com>
2588
2589         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2590         https://bugs.webkit.org/show_bug.cgi?id=195747
2591
2592         Reviewed by Geoff Garen.
2593
2594         Add API test coverage.
2595
2596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2597
2598 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2599
2600         Unreviewed, rolling out r242952.
2601
2602         Causing API failures on iOS Simulator
2603
2604         Reverted changeset:
2605
2606         "[PSON] Make sure the WebProcessCache is leverage when
2607         relaunching a process after termination"
2608         https://bugs.webkit.org/show_bug.cgi?id=195747
2609         https://trac.webkit.org/changeset/242952
2610
2611 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2612
2613         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2614         https://bugs.webkit.org/show_bug.cgi?id=195740
2615
2616         Reviewed by Ross Kirsling.
2617
2618         window.open doesn't work for WebKitBrowserWindow because it is not
2619         implemented yet.
2620
2621         1. Implemented createNewPage callback of WKPageUIClient.
2622         2. Changed MainWindow to take a BrowserWindow factory function
2623           instead of BrowserWindowType to be flexible to create
2624           BrowserWindow with extra settings.
2625         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2626           because it is not relevant with MainWindow anymore.
2627
2628         * MiniBrowser/win/Common.cpp:
2629         (parseCommandLine):
2630         * MiniBrowser/win/Common.h:
2631         (CommandLineOptions::CommandLineOptions):
2632         * MiniBrowser/win/MainWindow.cpp:
2633         (MainWindow::MainWindow):
2634         (MainWindow::create):
2635         (MainWindow::init):
2636         (MainWindow::WndProc):
2637         * MiniBrowser/win/MainWindow.h:
2638         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2639         (PrintWebUIDelegate::createWebViewWithRequest):
2640         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2641         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2642         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2643         (WebKitBrowserWindow::updateProxySettings):
2644         (WebKitBrowserWindow::createNewPage):
2645         * MiniBrowser/win/WebKitBrowserWindow.h:
2646         * MiniBrowser/win/WinMain.cpp:
2647         (wWinMain):
2648
2649 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2650
2651         Make it possible to test scrolling tree layer manipulation more easily
2652         https://bugs.webkit.org/show_bug.cgi?id=195780
2653
2654         Reviewed by Tim Horton.
2655         
2656         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2657         cuts off communication of scrolling tree scrolls back to the web process
2658         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2659         allows tests to trigger scrolls which run the scrolling tree layer positioning
2660         logic, but never get another commit from the web process that might mask
2661         scrolling tree bugs.
2662         
2663         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2664         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2665         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2666
2667         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2668         (WTR::UIScriptController::scrollUpdatesDisabled const):
2669         (WTR::UIScriptController::setScrollUpdatesDisabled):
2670         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2671         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2672         (WTR::UIScriptController::scrollUpdatesDisabled const):
2673         (WTR::UIScriptController::setScrollUpdatesDisabled):
2674         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2675         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2676         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2677         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2678         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2679         * WebKitTestRunner/ios/TestControllerIOS.mm:
2680         (WTR::TestController::platformResetStateToConsistentValues):
2681         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2682         (WTR::UIScriptController::scrollUpdatesDisabled const):
2683         (WTR::UIScriptController::setScrollUpdatesDisabled):
2684
2685 2019-03-14  Youenn Fablet  <youenn@apple.com>
2686
2687         Move IDB storage in private browsing mode to NetworkProcess
2688         https://bugs.webkit.org/show_bug.cgi?id=195602
2689
2690         Reviewed by Brady Eidson.
2691
2692         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2693         (TEST):
2694
2695 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2696
2697         [ews-build] Make descriptionDone messages more readable
2698         https://bugs.webkit.org/show_bug.cgi?id=195760
2699
2700         Reviewed by Lucas Forschler.
2701
2702         * BuildSlaveSupport/ews-build/steps.py:
2703         * BuildSlaveSupport/ews-build/steps_unittest.py:
2704
2705 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2706
2707         [ews-build] Generate status-bubble hover-over messages
2708         https://bugs.webkit.org/show_bug.cgi?id=195680
2709
2710         Reviewed by Lucas Forschler.
2711
2712         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2713         (StatusBubble):
2714         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2715         on hover-over.
2716         (StatusBubble._iso_time):
2717         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2718         hover-over message.
2719         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2720
2721 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2722
2723         [ews-app] Gracefully handle the case when state_string is None
2724         https://bugs.webkit.org/show_bug.cgi?id=195753
2725
2726         Reviewed by Lucas Forschler.
2727
2728         * BuildSlaveSupport/ews-app/ews/models/build.py:
2729         * BuildSlaveSupport/ews-app/ews/models/step.py:
2730
2731 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2732
2733         [ews-app] Status bubble display pending for currently running build step
2734         https://bugs.webkit.org/show_bug.cgi?id=195744
2735
2736         Reviewed by Lucas Forschler.
2737
2738         * BuildSlaveSupport/ews-build/events.py:
2739         (Events.stepStarted): If state_string is pending, replace it with step name.
2740
2741 2019-03-14  Chris Dumez  <cdumez@apple.com>
2742
2743         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2744         https://bugs.webkit.org/show_bug.cgi?id=195750
2745
2746         Reviewed by Geoffrey Garen.
2747
2748         Add API test coverage.
2749
2750         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2751         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2752         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2753         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2754
2755 2019-03-14  Chris Dumez  <cdumez@apple.com>
2756
2757         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2758         https://bugs.webkit.org/show_bug.cgi?id=195747
2759
2760         Reviewed by Geoff Garen.
2761
2762         Add API test coverage.
2763
2764         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2765
2766 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2767
2768         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2769         https://bugs.webkit.org/show_bug.cgi?id=195725
2770         <rdar://problem/48545062>
2771
2772         Reviewed by Tim Horton.
2773
2774         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2775         handler is nil.
2776
2777         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2778         (TestWebKitAPI::TEST):
2779
2780 2019-03-13  Sam Weinig  <sam@webkit.org>
2781
2782         Add utility function to allow easy reverse range-based iteration of a container
2783         https://bugs.webkit.org/show_bug.cgi?id=195542
2784
2785         Reviewed by Antti Koivisto.
2786
2787         * TestWebKitAPI/CMakeLists.txt:
2788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2789         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2790         (TestWebKitAPI::TEST):
2791         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2792
2793 2019-03-13  Chris Dumez  <cdumez@apple.com>
2794
2795         Use a ServiceWorker process per registrable domain
2796         https://bugs.webkit.org/show_bug.cgi?id=195649
2797
2798         Reviewed by Youenn Fablet.
2799
2800         Update API test coverage.
2801
2802         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2803
2804 2019-03-13  Chris Dumez  <cdumez@apple.com>
2805
2806         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2807         https://bugs.webkit.org/show_bug.cgi?id=195684
2808         <rdar://problem/48294714>
2809
2810         Reviewed by Antti Koivisto.
2811
2812         Add API test coverage.
2813
2814         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2815
2816 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2817
2818         [ews-app] Remove unused patch view
2819         https://bugs.webkit.org/show_bug.cgi?id=195669
2820
2821         Reviewed by Lucas Forschler.
2822
2823         * BuildSlaveSupport/ews-app/ews/urls.py:
2824         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2825
2826 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2827
2828         [ews-app] Use Buildbot result code variables
2829         https://bugs.webkit.org/show_bug.cgi?id=195668
2830
2831         Reviewed by Alexey Proskuryakov.
2832
2833         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2834         (Buildbot): Added Buildbot result code variables.
2835         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2836         (StatusBubble._build_bubble): Used Buildbot result code variables.
2837
2838 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2839
2840         [Flatpak] Expand submodule recursively
2841         https://bugs.webkit.org/show_bug.cgi?id=195672
2842
2843         Building WPE with flatpak was impossible without that as it was raising an exception.
2844         Also update wpebackend-fdo to match what is built in jhbuild
2845
2846         Reviewed by Philippe Normand.
2847
2848         * flatpak/flatpakutils.py:
2849         (expand_submodules_recurse):
2850         (expand_manifest):
2851         * flatpak/org.webkit.WPEModules.yaml:
2852
2853 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2854
2855         [ews-app] status bubble should be hidden for certain builds
2856         https://bugs.webkit.org/show_bug.cgi?id=194597
2857
2858         Reviewed by Dewei Zhu.
2859
2860         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2861         (StatusBubble._build_bubble):
2862         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2863         because the patch didn't have relevant changes.
2864         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2865         in production yet.
2866
2867 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2868
2869         [Win] Fix a slew of simple clang-cl warnings.
2870         https://bugs.webkit.org/show_bug.cgi?id=195652
2871
2872         Reviewed by Don Olmstead.
2873
2874         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2875         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2876
2877 2019-03-12  Justin Fan  <justin_fan@apple.com>
2878
2879         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2880         https://bugs.webkit.org/show_bug.cgi?id=195518
2881         <rdar://problem/46322356>
2882
2883         Reviewed by Myles C. Maxfield.
2884
2885         * DumpRenderTree/DerivedSources-input.xcfilelist:
2886         * DumpRenderTree/DerivedSources-output.xcfilelist:
2887
2888 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2889
2890         Unreviewed, rolling out r242825.
2891         https://bugs.webkit.org/show_bug.cgi?id=195648
2892
2893         "Broke webkitpy tests with my change to
2894         lldb_dump_class_layout.py" (Requested by rmorisset on
2895         #webkit).
2896
2897         Reverted changeset:
2898
2899         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2900         classes with suspicious padding"
2901         https://bugs.webkit.org/show_bug.cgi?id=195573
2902         https://trac.webkit.org/changeset/242825
2903
2904 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2905
2906         [ews-build] Show status bubbles while the patch is waiting in queue
2907         https://bugs.webkit.org/show_bug.cgi?id=195618
2908
2909         Reviewed by Lucas Forschler.
2910
2911         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2912         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2913         enabled in initial deployment.
2914         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2915         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2916         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2917         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2918         (StatusBubble._build_bubbles_for_patch):
2919
2920 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2921
2922         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2923         https://bugs.webkit.org/show_bug.cgi?id=195573
2924
2925         Reviewed by Simon Fraser.
2926
2927         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2928
2929         * Scripts/dump-class-layout:
2930         (main):
2931         * lldb/lldb_dump_class_layout.py:
2932         (ClassLayout.__init__):
2933         (ClassLayout._compute_padding_recursive):
2934         (LLDBDebuggerInstance.dump_layout_for_classname):
2935         (LLDBDebuggerInstance):
2936         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2937         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2938
2939 2019-03-12  Chris Dumez  <cdumez@apple.com>
2940
2941         Device Orientation access permission should be denied unless explicitly granted by the client
2942         https://bugs.webkit.org/show_bug.cgi?id=195625
2943
2944         Reviewed by Youenn Fablet.
2945
2946         add API test coverage.
2947
2948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2949         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2950         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2951         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2952         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2953         (runDeviceOrientationTest):
2954         (TEST):
2955         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2956         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2957
2958 2019-03-12  Jer Noble  <jer.noble@apple.com>
2959
2960         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2961         https://bugs.webkit.org/show_bug.cgi?id=195137
2962         <rdar://problem/48810307>
2963
2964         Reviewed by Eric Carlson.
2965
2966         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2967         (TestWebKitAPI::TEST):
2968
2969 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2970
2971         [ews-build] Change urls from uat to production
2972         https://bugs.webkit.org/show_bug.cgi?id=195566
2973
2974         Reviewed by Lucas Forschler.
2975
2976         * BuildSlaveSupport/ews-app/ews/config.py:
2977         * BuildSlaveSupport/ews-build/events.py:
2978         * BuildSlaveSupport/ews-build/steps.py:
2979
2980 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2981
2982         [ews-build] change max_builds for local-worker to 1
2983         https://bugs.webkit.org/show_bug.cgi?id=195568
2984
2985         Reviewed by Lucas Forschler.
2986
2987         * BuildSlaveSupport/ews-build/loadConfig.py:
2988
2989 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2990
2991         Fix the build
2992
2993         * TestRunnerShared/spi/PencilKitTestSPI.h:
2994         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2995
2996 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2997
2998         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2999         https://bugs.webkit.org/show_bug.cgi?id=194131
3000
3001         Reviewed by Michael Catanzaro.
3002
3003         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3004         (uriChanged):
3005         (testUnfinishedSubresourceLoad):
3006         (serverCallback):
3007         (beforeAll):
3008
3009 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3010
3011         WTF::Expected should use std::addressof instead of operator&
3012         https://bugs.webkit.org/show_bug.cgi?id=195604
3013
3014         Reviewed by Myles Maxfield.
3015
3016         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3017         (TestWebKitAPI::Unique::Unique):
3018         (TestWebKitAPI::Unique::operator&):
3019         (TestWebKitAPI::TEST):
3020
3021 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3022
3023         Add Optional to Forward.h.
3024         https://bugs.webkit.org/show_bug.cgi?id=195586
3025
3026         Reviewed by Darin Adler.
3027
3028         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3029         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3030         Remove unnecessary includes from headers.
3031
3032 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3033
3034         Add testing API to hit-test and scroll overflow scrollers
3035         https://bugs.webkit.org/show_bug.cgi?id=195278
3036
3037         Reviewed by Antti Koivisto.
3038         
3039         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3040         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3041         
3042         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3043
3044         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3045         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3046         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3047         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3048         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3049         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3050         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3051         (WTR::enclosingScrollViewIncludingSelf):
3052         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3053
3054 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3055
3056         API test WebKit.RequestTextInputContext fails on iOS
3057         https://bugs.webkit.org/show_bug.cgi?id=195585
3058
3059         Reviewed by Wenson Hsieh and Simon Fraser.
3060
3061         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3062         (applyStyle):
3063         (TEST):
3064         Add a viewport, so that the coordinates match up on iOS.
3065         Scroll by moving the UIScrollView's contentOffset.
3066
3067 2019-03-11  Chris Dumez  <cdumez@apple.com>
3068
3069         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3070         https://bugs.webkit.org/show_bug.cgi?id=195506
3071         <rdar://problem/48733477>
3072
3073         Reviewed by Alex Christensen.
3074
3075         Add API test coverage.
3076
3077         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3078
3079 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3080
3081         Adding myself to contributors.json
3082
3083         Unreviewed, addming myself to contributors.json .
3084
3085         * Scripts/webkitpy/common/config/contributors.json:
3086
3087 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3088
3089         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3090         https://bugs.webkit.org/show_bug.cgi?id=195511
3091         <rdar://problem/44873269>
3092
3093         Reviewed by Darin Adler.
3094
3095         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3096         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3097         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3098         (TEST_F):
3099
3100 2019-03-11  Chris Dumez  <cdumez@apple.com>
3101
3102         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3103         https://bugs.webkit.org/show_bug.cgi?id=195561
3104
3105         Reviewed by Youenn Fablet.
3106
3107         Make sure the JS in the test requests for permission to receive device orientation events.
3108
3109         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3110
3111 2019-03-11  Youenn Fablet  <youenn@apple.com>
3112
3113         Allow storage quota increase by default in WTR
3114         https://bugs.webkit.org/show_bug.cgi?id=195541
3115
3116         Reviewed by Geoffrey Garen.
3117
3118         Allow storage quota increase by default in WTR.
3119         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3120         Use this for tests that explicitly need cache increase.
3121
3122         Instead of increasing quota by 2, make sure the next request is
3123         granted by adding all given parameters.
3124
3125         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3127         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3128         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3129         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3130         * WebKitTestRunner/TestController.cpp:
3131         (WTR::TestController::setAllowStorageQuotaIncrease):
3132         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3133         * WebKitTestRunner/TestController.h:
3134         * WebKitTestRunner/TestInvocation.cpp:
3135         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3136         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3137         (WTR::TestController::cocoaResetStateToConsistentValues):
3138         (WTR::TestController::setAllowStorageQuotaIncrease):
3139         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3140         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3141         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3142
3143 2019-03-11  Xan Lopez  <xan@igalia.com>
3144
3145         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3146         https://bugs.webkit.org/show_bug.cgi?id=194147
3147
3148         Reviewed by Michael Saboff.
3149
3150         To make --32-bit work correctly on Linux/64bit we need to:
3151
3152         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3153         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3154         unfortunately CMake only allows us to do this during
3155         crosscompilation, which is overkill here.
3156         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3157         pkg-config detection module uses the x86 .pc files instead of the
3158         x86_64 ones.
3159         - Set the -m32 flags for the compiler.
3160
3161         * Scripts/webkitdirs.pm:
3162         (generateBuildSystemFromCMakeProject):
3163
3164 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3165
3166         Add MotionMark-1.1 plan file for run-benchmark script.
3167         https://bugs.webkit.org/show_bug.cgi?id=195481
3168
3169         Rubber-stamped by Darin Adler.
3170
3171         Run-benchmark script should support MontionMark-1.1.
3172
3173         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3174
3175 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3176
3177         [ews-app] Add support for submit-to-ews url
3178         https://bugs.webkit.org/show_bug.cgi?id=195477
3179
3180         Reviewed by Lucas Forschler.
3181
3182         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3183         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3184         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3185         * BuildSlaveSupport/ews-app/ews/urls.py:
3186         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3187
3188 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3189
3190         Unreviewed, rolling out r242688, r242643, r242624.
3191
3192         Caused multiple layout test failures and crashes on iOS and macOS.
3193
3194         Reverted changeset:
3195
3196         "requestAnimationFrame should execute before the next frame"
3197         https://bugs.webkit.org/show_bug.cgi?id=177484
3198         https://trac.webkit.org/changeset/242624/webkit
3199
3200         * Tracing/SystemTracePoints.plist:
3201
3202 2019-03-11  John Wilander  <wilander@apple.com>
3203
3204         Resource Load Statistics: Make it possible exclude localhost from classification
3205         https://bugs.webkit.org/show_bug.cgi?id=195474
3206         <rdar://problem/47520577>
3207
3208         Reviewed by Brent Fulgham.
3209
3210         This patch allows for localhost to be excluded from classification and
3211         treatment as a prevalent resource.
3212
3213         The WebKit Tools change adds a new function called
3214         testRunner.setStatisticsIsRunningTest() which can be used to control this
3215         behavior.
3216
3217         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3218         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3219         (WTR::TestRunner::setStatisticsIsRunningTest):
3220         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3221         * WebKitTestRunner/TestController.cpp:
3222         (WTR::TestController::setStatisticsIsRunningTest):
3223         * WebKitTestRunner/TestController.h:
3224         * WebKitTestRunner/TestInvocation.cpp:
3225         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3226
3227 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3228
3229         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3230         https://bugs.webkit.org/show_bug.cgi?id=195560
3231
3232         Reviewed by Lucas Forschler.
3233
3234         * BuildSlaveSupport/ews-build/master.cfg:
3235
3236 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3237
3238         Unreviewed, rolling out r242698.
3239
3240         API test crashes on bots.
3241
3242         Reverted changeset:
3243
3244         "Add a WKContentRuleList variant that uses copied memory
3245         instead of mmap'd shared memory for class A containerized
3246         apps"
3247         https://bugs.webkit.org/show_bug.cgi?id=195511
3248         https://trac.webkit.org/changeset/242698
3249
3250 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3251
3252         [WPE] Enable web process sandbox
3253         https://bugs.webkit.org/show_bug.cgi?id=195169
3254
3255         Reviewed by Daniel Bates.
3256
3257         * wpe/install-dependencies:
3258         * wpe/jhbuild.modules:
3259
3260 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3261
3262         [ews-app] Use port 17000 for worker communication
3263         https://bugs.webkit.org/show_bug.cgi?id=195558
3264
3265         Reviewed by Lucas Forschler.
3266
3267         * BuildSlaveSupport/ews-build/master.cfg:
3268
3269 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3270
3271         [ews-build] unit-tests fail when passwords.json is missing
3272         https://bugs.webkit.org/show_bug.cgi?id=195557
3273
3274         Reviewed by Lucas Forschler.
3275
3276         * BuildSlaveSupport/ews-build/loadConfig.py:
3277         (loadBuilderConfig):
3278         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3279         (ConfigDotJSONTest.test_configuration):
3280         * BuildSlaveSupport/ews-build/master.cfg:
3281
3282 2019-03-11  Truitt Savell  <tsavell@apple.com>
3283
3284         Unreviewed, rolling out r242702.
3285
3286         Broke High Sierra builders.
3287
3288         Reverted changeset:
3289
3290         "Add utility function to allow easy reverse range-based
3291         iteration of a container"
3292         https://bugs.webkit.org/show_bug.cgi?id=195542
3293         https://trac.webkit.org/changeset/242702
3294
3295 2019-03-11  Sam Weinig  <sam@webkit.org>
3296
3297         Add utility function to allow easy reverse range-based iteration of a container
3298         https://bugs.webkit.org/show_bug.cgi?id=195542
3299
3300         Reviewed by Antti Koivisto.
3301
3302         * TestWebKitAPI/CMakeLists.txt:
3303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3304         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3305         (TestWebKitAPI::TEST):
3306         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3307
3308 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3309
3310         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3311         https://bugs.webkit.org/show_bug.cgi?id=195511
3312         <rdar://problem/44873269>
3313
3314         Reviewed by Darin Adler.
3315
3316         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3317         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3318         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3319         (TEST_F):
3320
3321 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3322
3323         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3324         https://bugs.webkit.org/show_bug.cgi?id=195499
3325
3326         Reviewed by Darin Adler.
3327
3328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3329         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3330         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3331         (-[WKWebView synchronouslyFocusTextInputContext:]):
3332         (applyStyle):
3333         (applyIframe):
3334         (TEST):
3335         Add some tests for this SPI.
3336
3337 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3338
3339         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3340         https://bugs.webkit.org/show_bug.cgi?id=181151
3341
3342         Reviewed by Don Olmstead.
3343
3344         * TestWebKitAPI/CMakeLists.txt:
3345         * TestWebKitAPI/PlatformWin.cmake:
3346         Enable TestWTF RunLoop tests in all platforms.
3347
3348         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3349         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3350         (TestWebKitAPI::DerivedOneShotTimer::fired):
3351         (TestWebKitAPI::TEST):
3352         Only a few platforms support nested RunLoop.
3353
3354         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3355         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3356
3357 2019-03-10  David Quesada  <david_quesada@apple.com>
3358
3359         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3360         https://bugs.webkit.org/show_bug.cgi?id=152480
3361
3362         Reviewed by Chris Dumez.
3363
3364         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3365         there are no additional references to the process pool besides the one held by
3366         the download, waits for the download to finish (in the sense that the
3367         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3368         measure, also check that the process pool has been deallocated at the end of the
3369         test. The test wouldn't be meaningful if the process pool were still alive.
3370
3371         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3372         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3373         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3374             The download will be canceled because the delegate does not implement the
3375             method to decide the download's destination, so this is where we know the
3376             DownloadProxyMap is done with the DownloadProxy.
3377         (TEST):
3378
3379 2019-03-08  Chris Dumez  <cdumez@apple.com>
3380
3381         Add support for Device Orientation / Motion permission API
3382         https://bugs.webkit.org/show_bug.cgi?id=195329
3383         <rdar://problem/47645367>
3384
3385         Reviewed by Geoffrey Garen.
3386
3387         Add test infrastructure to help test the Device Orientation / Motion permission API.
3388
3389         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3390         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3391         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3392         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3393         * WebKitTestRunner/TestController.cpp:
3394         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3395         (WTR::TestController::createWebViewWithOptions):
3396         (WTR::TestController::resetStateToConsistentValues):
3397         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3398         * WebKitTestRunner/TestController.h:
3399         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3400         * WebKitTestRunner/TestInvocation.cpp:
3401         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3402
3403 2019-03-08  Saam barati  <sbarati@apple.com>
3404
3405         Add a compare-results script to compare benchmark results
3406         https://bugs.webkit.org/show_bug.cgi?id=195486
3407         <rdar://problem/48723397>
3408
3409         Reviewed by Geoffrey Garen.
3410
3411         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3412         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3413         to extend it to learn about our other benchmarks.
3414
3415         * Scripts/compare-results: Added.
3416         (readJSONFile):
3417         (detectJetStream2):
3418         (JetStream2Results):
3419         (detectSpeedometer2):
3420         (Speedometer2Results):
3421         (detectPLT5):
3422         (PLT5Results):
3423         (detectBenchmark):
3424         (biggerIsBetter):
3425         (ttest):
3426         (getOptions):
3427         (main):
3428
3429 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3430
3431         Ensure old tab state is cleared between iterations of run-benchmark
3432         https://bugs.webkit.org/show_bug.cgi?id=195393
3433         <rdar://problem/46885583>
3434
3435         Reviewed by Dewei Zhu.
3436
3437         a) ensure the default to restore state is not set
3438         b) terminate Safari correctly
3439         c) Set the system default to ignore Persistent State in Safari
3440
3441         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3442         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3443         (OSXBrowserDriver.prepare_env): 
3444         (OSXBrowserDriver.restore_env):
3445         (OSXBrowserDriver.close_browsers):
3446         (OSXBrowserDriver._terminate_processes):
3447         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3448         (OSXChromeDriver):
3449         (OSXChromeCanaryDriver):
3450         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3451         (OSXFirefoxDriver):
3452         (OSXFirefoxNightlyDriver):
3453         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3454         (OSXSafariDriver):
3455         (OSXSafariDriver.prepare_env):
3456
3457 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3458
3459         [GTK] Several InputMethodFilter tests are failing
3460         https://bugs.webkit.org/show_bug.cgi?id=195408
3461
3462         Reviewed by Carlos Garcia Campos.
3463
3464         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3465         Regressed in r241751.
3466         Hexadecimal values of keycodes are expressed now in upper letters.
3467         Composited characters should be cast to UTF8 strings.
3468
3469         (TestWebKitAPI::TEST):
3470
3471 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3472
3473         [GTK] Make Tools/gtkdoc python3 compatible
3474         https://bugs.webkit.org/show_bug.cgi?id=195359
3475
3476         Reviewed by Carlos Garcia Campos.
3477
3478         * gtkdoc/generate-gtkdoc:
3479         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3480         work with Python 2 and 3.
3481         (get_gtkdoc_module_paths):
3482         The iteritems() was removed in Python 3, so let's use items() that's
3483         available in Python 2 and 3.
3484         (get_generator_for_config):
3485         * gtkdoc/gtkdoc.py:
3486         (GTKDoc._run_command):
3487         The sys.stdout.write() is expecting str in Python 3 and not bytes
3488         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3489         for passing the bytes there.
3490
3491 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3492
3493         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3494         https://bugs.webkit.org/show_bug.cgi?id=195346
3495         <rdar://problem/48667048>
3496
3497         Unreviewed build fix for clang-cl.
3498
3499         * DumpRenderTree/win/DumpRenderTree.cpp:
3500         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3501
3502 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3503
3504         requestAnimationFrame should execute before the next frame
3505         https://bugs.webkit.org/show_bug.cgi?id=177484
3506
3507         Reviewed by Simon Fraser.
3508
3509         Add trace points for the page RenderingUpdate.
3510
3511         * Tracing/SystemTracePoints.plist:
3512
3513 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3514
3515         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3516         https://bugs.webkit.org/show_bug.cgi?id=195353
3517         <rdar://problem/48626394>
3518
3519         Reviewed by Simon Fraser.
3520
3521         * WebKitTestRunner/ios/TestControllerIOS.mm:
3522         (WTR::TestController::platformResetPreferencesToConsistentValues):
3523
3524 2019-03-07  John Wilander  <wilander@apple.com>
3525
3526         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3527         https://bugs.webkit.org/show_bug.cgi?id=195383
3528         <rdar://problem/48570136>
3529
3530         Reviewed by Brent Fulgham.
3531
3532         This patch adds test infrastructure to purge only script-accessible cookies,
3533         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3534
3535         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3537         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3538         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3539         * WebKitTestRunner/TestController.cpp:
3540         (WTR::TestController::statisticsDeleteCookiesForHost):
3541         * WebKitTestRunner/TestController.h:
3542         * WebKitTestRunner/TestInvocation.cpp:
3543         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3544
3545 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3546
3547         Unreviewed, rolling out r242354.
3548         https://bugs.webkit.org/show_bug.cgi?id=195402
3549
3550         breaks layout tests in all configurations (Requested by
3551         zdobersek on #webkit).
3552
3553         Reverted changeset:
3554
3555         "[WPE] Enable web process sandbox"
3556         https://bugs.webkit.org/show_bug.cgi?id=195169
3557         https://trac.webkit.org/changeset/242354
3558
3559 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3560
3561         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3562         https://bugs.webkit.org/show_bug.cgi?id=195346
3563
3564         Reviewed by Fujii Hironori.
3565
3566         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3567         (TestWebKitAPI::TEST):
3568         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3569
3570         * DumpRenderTree/win/DumpRenderTree.cpp:
3571         (findFontFallback):
3572         (addFontFallbackIfPresent):
3573         (removeFontFallbackIfPresent):
3574         (main):
3575         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3576         (TestWebKitAPI::Util::moduleDirectory):
3577         (TestWebKitAPI::Util::createInjectedBundlePath):
3578         Use wchar helpers as needed.
3579
3580 2019-03-06  Rob Buis  <rbuis@igalia.com>
3581
3582         Consider supporting the `referrerpolicy` attribute.
3583         https://bugs.webkit.org/show_bug.cgi?id=179053
3584
3585         Reviewed by Darin Adler.
3586
3587         Add a runtime flag for referrerpolicy attribute.
3588
3589         * DumpRenderTree/mac/DumpRenderTree.mm:
3590         (enableExperimentalFeatures):
3591
3592 2019-03-05  Daniel Bates  <dabates@apple.com>
3593
3594         Update expected API test result following r242379
3595         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3596
3597         Update expected x-coordinate of selection rect now that the left padding of
3598         a textarea is sized in ems (so dependent on the font size) just like the left
3599         padding of a text field.
3600
3601         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3602         (TestWebKitAPI::TEST):
3603
3604 2019-03-05  David Quesada  <david_quesada@apple.com>
3605
3606         [WK2] It should be possible to follow links with 'download' attributes
3607         https://bugs.webkit.org/show_bug.cgi?id=195145
3608         rdar://problem/48462642
3609
3610         Reviewed by Alex Christensen.
3611
3612         Add a unit test to verify that activating links with 'download' attributes now
3613         navigates to the linked resource, rather than starts downloading it. Add another
3614         to verify that it is still possible to explicitly download the link via the
3615         'Download' navigation action policy.
3616
3617         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3618         (-[DownloadAttributeTestDelegate init]):
3619         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3620         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3621         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3622         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3623         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3624         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3625         (TEST):
3626         * WebKitTestRunner/TestController.cpp:
3627         (WTR::TestController::decidePolicyForNavigationAction):
3628         * WebKitTestRunner/TestController.h:
3629
3630 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3631
3632         [Curl] Implement Cookie Accept Policy.
3633         https://bugs.webkit.org/show_bug.cgi?id=191645
3634
3635         Reviewed by Fujii Hironori.
3636
3637         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3638         (TestWebKitAPI::Curl::TEST_F):
3639
3640 2019-03-05  Youenn Fablet  <youenn@apple.com>
3641
3642         Rename requestCacheStorageSpace to requestStorageSpace
3643         https://bugs.webkit.org/show_bug.cgi?id=195282
3644
3645         Reviewed by Chris Dumez.
3646
3647         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3648         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3649         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3650
3651 2019-03-05  Brady Eidson  <beidson@apple.com>
3652
3653         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3654         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3655
3656         Reviewed by Tim Horton.
3657
3658         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3659         different directory into that same WKWebView should work.
3660
3661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3662         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3663
3664 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3665
3666         Add WeakHashSet
3667         https://bugs.webkit.org/show_bug.cgi?id=195152
3668
3669         Reviewed by Antti Koivisto.
3670
3671         Added tests for WeakHashSet.
3672
3673         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3674         (TestWebKitAPI::Base::Base): Moved.
3675         (TestWebKitAPI::Derived::foo): Moved.
3676         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3677         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3678         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3679         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3680
3681 2019-03-04  Chris Dumez  <cdumez@apple.com>
3682
3683         Do not share WebProcesses between private and regular sessions
3684         https://bugs.webkit.org/show_bug.cgi?id=195189
3685         <rdar://problem/48421064>
3686
3687         Reviewed by Alex Christensen.
3688
3689         Add API test coverage.
3690
3691         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3692         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3693
3694 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3695
3696         [WPE] Enable web process sandbox
3697         https://bugs.webkit.org/show_bug.cgi?id=195169
3698
3699         Reviewed by Daniel Bates.
3700
3701         * wpe/install-dependencies:
3702         * wpe/jhbuild.modules:
3703