1 2015-04-29 Martin Robinson <mrobinson@igalia.com>
3 [GTK] Add support for automatic hyphenation
4 https://bugs.webkit.org/show_bug.cgi?id=44478
6 Reviewed by Carlos Garcia Campos.
8 * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
9 all systems will use the same dictionaries for testing purposes.
11 2015-04-29 Jake Nielsen <jacob_nielsen@apple.com>
13 Failure when building WebKit for appletvsimulator.
14 https://bugs.webkit.org/show_bug.cgi?id=144356
16 Reviewed by Alexey Proskuryakov.
18 Changes Makefile logic to check for "not OS X" rather than "is iOS" to
19 make TVOS and WatchOS behave correctly.
22 * WebKitTestRunner/Makefile:
24 2015-04-29 Alexey Proskuryakov <ap@apple.com>
26 Use-after-free when invalidating WKPageForceRepaint callback
27 https://bugs.webkit.org/show_bug.cgi?id=144401
28 rdar://problem/20741111
30 Reviewed by Tim Horton.
32 * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
34 * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
35 Don't do anything on error, because the context may be a stale pointer now.
37 2015-04-29 David Kilzer <ddkilzer@apple.com>
39 check-webkit-style: Don't complain about returning value from Objective-C method call in header
40 <http://webkit.org/b/144395>
42 Reviewed by Andy Estes.
44 * Scripts/webkitpy/style/checkers/cpp.py:
45 (check_spacing): Update regex so 'return' is ignored if it
46 precedes the whitespace and bracket. Change category name to
47 'whitespace/brackets'. Add period to error message.
48 (CppChecker): Add 'whitespace/brackets' as a category.
49 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
50 (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
51 'CppChecker.categories' since that's where the list lives now.
52 (CppStyleTest.test_spacing_before_brackets): Add tests for
53 'whitespace/brackets' issues and non-issues.
55 2015-04-29 Alex Christensen <achristensen@webkit.org>
59 * Scripts/webkitdirs.pm:
60 (determinePassedConfiguration):
61 WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
63 2015-04-29 Myles C. Maxfield <mmaxfield@apple.com>
65 [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
66 https://bugs.webkit.org/show_bug.cgi?id=132159
68 Reviewed by Darin Adler.
70 Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
71 swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
73 * DumpRenderTree/mac/DumpRenderTree.mm:
76 (createWebViewAndOffscreenWindow):
77 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
79 * WebKitTestRunner/mac/TestControllerMac.mm:
80 (WTR::allowedFontFamilySet):
81 (WTR::systemHiddenFontFamilySet):
82 (WTR::generateWhitelist):
83 (WTR::TestController::platformInitializeContext):
85 2015-04-29 Alexey Proskuryakov <ap@apple.com>
87 fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
88 https://bugs.webkit.org/show_bug.cgi?id=144155
90 Reviewed by Andreas Kling.
92 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
93 Make sure that test window is "visible" before each test. While there is no concrete
94 evidence that this is the problem indeed, the behavior is consistent with what would
95 happen for an invisible window. Also, WKTR obviously needs to do this to protect
96 against potential buggy tests that hide the window and don't show it.
98 2015-04-29 Carlos Garcia Campos <cgarcia@igalia.com>
100 Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
102 Latest changes in the inspector UI made this test fail. We were
103 relying that the sidebar was always visible and the first 'li'
104 element of the inspector was the one containing the title. This is
105 no longer true, so better use document title that is not likely
108 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
109 (openRemoteDebuggingSession):
111 2015-04-29 Andres Gomez <agomez@igalia.com>
113 Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
115 * Scripts/webkitpy/common/config/contributors.json:
117 2015-04-29 Andres Gomez <agomez@igalia.com>
119 Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
121 * Scripts/webkitpy/common/config/watchlist:
123 2015-04-29 Hunseop Jeong <hs85.jeong@samsung.com>
125 [EFL] Allow to run the tests on the native X display
126 https://bugs.webkit.org/show_bug.cgi?id=144247
128 Reviewed by Gyuyoung Kim.
130 Added the USE_NATIVE_XDISPLAY option for the WTR.
131 We can select the Xorg driver if environment variable is set up before running the tests.
133 * Scripts/webkitpy/port/efl.py:
134 (EflPort._driver_class):
136 2015-04-29 Joonghun Park <jh718.park@samsung.com>
138 [GTK] Add libnotify-dev in gtk install-dependencies
139 https://bugs.webkit.org/show_bug.cgi?id=144379
141 Reviewed by Žan Doberšek.
143 * gtk/install-dependencies:
145 2015-04-28 Ryuan Choi <ryuan.choi@navercorp.com>
147 [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
148 https://bugs.webkit.org/show_bug.cgi?id=143001
150 Reviewed by Gyuyoung Kim.
152 * WebKitTestRunner/TestController.cpp:
153 (WTR::shouldUseFixedLayout):
155 2015-04-28 Dewei Zhu <dewei_zhu@apple.com>
157 Increase stablility of run-benchmark script
158 https://bugs.webkit.org/show_bug.cgi?id=144361
160 Reviewed by Ryosuke Niwa.
162 * Scripts/run-benchmark:
164 * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
165 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
166 (GenericBenchmarkBuilder.clean):
167 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
168 (BenchmarkRunner.__init__):
169 (BenchmarkRunner.execute):
170 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
171 (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
172 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
173 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
174 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
175 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
176 (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
177 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
178 (HTTPServerDriver.fetchResult):
180 (HTTPServerDriver.killServer): Add kill server interface.
181 (HTTPServerDriver.getReturnCode): Add get return code interface.
182 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
183 (SimpleHTTPServerDriver.serve):
184 (SimpleHTTPServerDriver.fetchResult):
185 (SimpleHTTPServerDriver):
186 (SimpleHTTPServerDriver.killServer):
187 (SimpleHTTPServerDriver.getReturnCode):
188 * Scripts/webkitpy/benchmark_runner/utils.py:
189 (forceRemove): Provide python version of 'rm -rf'.
191 2015-04-28 Sam Weinig <sam@webkit.org>
193 [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
194 https://bugs.webkit.org/show_bug.cgi?id=144363
196 Reviewed by Alex Christensen.
198 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
199 (TestWebKitAPI::createNFAs):
200 (TestWebKitAPI::TEST_F):
201 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
202 (TestWebKitAPI::countLiveNodes):
203 (TestWebKitAPI::createNFAs):
204 (TestWebKitAPI::buildDFAFromPatterns):
205 Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
207 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
209 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
210 https://bugs.webkit.org/show_bug.cgi?id=144304
212 Reviewed by Geoffrey Garen.
214 * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
215 set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
216 * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
218 2015-04-28 Commit Queue <commit-queue@webkit.org>
220 Unreviewed, rolling out r183514.
221 https://bugs.webkit.org/show_bug.cgi?id=144359
223 It broke cloop test bots (Requested by mcatanzaro on #webkit).
227 "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
228 https://bugs.webkit.org/show_bug.cgi?id=144304
229 http://trac.webkit.org/changeset/183514
231 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
233 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
234 https://bugs.webkit.org/show_bug.cgi?id=144304
236 Reviewed by Geoffrey Garen.
238 * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
239 checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
240 of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
241 * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
243 2015-04-28 Gyuyoung Kim <gyuyoung.kim@webkit.org>
245 [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
246 https://bugs.webkit.org/show_bug.cgi?id=144319
248 Reviewed by Csaba Osztrogonác.
250 * TestWebKitAPI/CMakeLists.txt:
251 * TestWebKitAPI/PlatformEfl.cmake:
253 2015-04-28 Joseph Pecoraro <pecoraro@apple.com>
255 Fix common typo "targetting" => "targeting"
256 https://bugs.webkit.org/show_bug.cgi?id=144349
258 Reviewed by Daniel Bates.
260 * Scripts/webkitdirs.pm:
261 (execMacWebKitAppForDebugging):
263 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com>
265 [GTK][jhbuild] Mesa build failure with llvm 3.6
266 https://bugs.webkit.org/show_bug.cgi?id=144250
268 Reviewed by Žan Doberšek.
270 Bump the version of Mesa to 10.5.4
272 * gtk/jhbuild.modules:
274 2015-04-28 Alexey Proskuryakov <ap@apple.com>
276 Disable App Nap in WebKitTestRunner UI process
277 https://bugs.webkit.org/show_bug.cgi?id=144308
279 Reviewed by Daniel Bates.
281 * WebKitTestRunner/mac/main.mm:
282 (disableAppNapInUIProcess):
285 2015-04-28 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
287 [GTK] Update JHBuild Mesa download directory
288 https://bugs.webkit.org/show_bug.cgi?id=144318
290 Update the download directory of Mesa module since the previous one
291 doesn't exist any more.
293 Reviewed by Žan Doberšek.
295 * gtk/jhbuild.modules:
297 2015-04-28 Commit Queue <commit-queue@webkit.org>
299 Unreviewed, rolling out r183477.
300 https://bugs.webkit.org/show_bug.cgi?id=144334
302 Roll back the Mesa dependency bump in fear of uncaught
303 regressions while the testing bots are no-op. (Requested by
304 zdobersek on #webkit).
308 "[GTK][jhbuild] Mesa build failure with llvm 3.6"
309 https://bugs.webkit.org/show_bug.cgi?id=144250
310 http://trac.webkit.org/changeset/183477
312 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com>
314 [GTK][jhbuild] Mesa build failure with llvm 3.6
315 https://bugs.webkit.org/show_bug.cgi?id=144250
317 Reviewed by Žan Doberšek.
319 Bump the version of Mesa to 10.5.4
321 * gtk/jhbuild.modules:
323 2015-04-27 Dewei Zhu <dewei_zhu@apple.com>
325 Add '__init__.py' and fix known bug in benchmark runner.
326 https://bugs.webkit.org/show_bug.cgi?id=144296
328 Reviewed by Ryosuke Niwa
330 * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
331 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
332 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
333 (BenchmarkRunner.__init__):
334 (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
335 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
336 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
338 2015-04-27 Alexey Proskuryakov <ap@apple.com>
342 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
343 (-[AccessibilityNotificationHandler _notificationReceived:]):
344 Use -objectForKey:, not array subscript.
346 2015-04-27 Alexey Proskuryakov <ap@apple.com>
348 Catch unexpected exits in DumpRenderTree
349 https://bugs.webkit.org/show_bug.cgi?id=144288
351 Reviewed by Tim Horton.
353 * DumpRenderTree/mac/DumpRenderTree.mm:
355 (DumpRenderTreeMain):
357 2015-04-27 Alexey Proskuryakov <ap@apple.com>
361 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
362 (-[AccessibilityNotificationHandler _notificationReceived:]):
363 Use -objectForKey:, not array subscript.
365 2015-04-27 Alexey Proskuryakov <ap@apple.com>
367 fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
368 https://bugs.webkit.org/show_bug.cgi?id=144155
370 Reviewed by Tim Horton.
372 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
373 Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
374 and we clearly don't want App Nap while testing.
376 2015-04-22 Martin Robinson <mrobinson@igalia.com>
378 [CMake] Autogenerate cmakeconfig.h.cmake
379 https://bugs.webkit.org/show_bug.cgi?id=143997
381 Reviewed by Csaba Osztrogonác.
383 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
384 definitions since TestNetscapePlugIn does not use cmakeconfig.h.
386 2015-04-27 Brent Fulgham <bfulgham@apple.com>
388 REGRESSION(r182879): Images and video can no longer be downloaded
389 https://bugs.webkit.org/show_bug.cgi?id=144267
390 <rdar://problem/20702844>
392 Reviewed by Simon Fraser.
394 Revise tests to check for proper download menu state.
395 1. Downloading a loal image should be disabled.
396 2. Downloading a local media file should be disabled.
397 3. Downloading non-downloadable media should be disabled.
399 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
400 (TestWebKitAPI::TEST):
402 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
404 Merge run-launcher into run-minibrowser
405 https://bugs.webkit.org/show_bug.cgi?id=141928
407 Reviewed by Darin Adler.
409 * Scripts/run-iexploder-tests:
410 (runSafariWithIExploder):
411 * Scripts/run-launcher: Removed.
412 * Scripts/run-minibrowser:
413 * Scripts/webkitdirs.pm:
415 * Scripts/webkitpy/port/efl.py:
416 (EflPort.show_results_html_file):
417 * Scripts/webkitpy/port/efl_unittest.py:
418 (EflPortTest.test_show_results_html_file):
419 * Scripts/webkitpy/port/gtk.py:
420 (GtkPort.print_leaks_summary):
421 (GtkPort.show_results_html_file):
423 * Scripts/webkitpy/port/gtk_unittest.py:
424 (GtkPortTest.test_show_results_html_file):
426 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
428 [buildbot] Fix the output of perf-test buildstep on timeout
429 https://bugs.webkit.org/show_bug.cgi?id=144097
431 Reviewed by Ryosuke Niwa.
433 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
434 (RunAndUploadPerfTests.getText2):
435 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
436 (RunAndUploadPerfTestsTest.test_buildbot_timeout):
437 (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
439 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
441 [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
442 https://bugs.webkit.org/show_bug.cgi?id=143874
444 Reviewed by Gyuyoung Kim.
446 * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
448 2015-04-24 Philippe Normand <pnormand@igalia.com>
450 [JHBuild] Move to upstream OpenWebRTC
451 https://bugs.webkit.org/show_bug.cgi?id=144145
453 Reviewed by Carlos Garcia Campos.
455 * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
456 and add a new simple patch to gst-plugins-base, required for
458 * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
459 * gtk/jhbuild.modules: Ditto.
460 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
462 2015-04-26 Yusuke Suzuki <utatane.tea@gmail.com>
464 [ES6] Implement ES6 template literals
465 https://bugs.webkit.org/show_bug.cgi?id=142691
467 Reviewed by Darin Adler.
469 Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
471 * Scripts/webkitperl/FeatureList.pm:
473 2015-04-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
475 [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake
476 https://bugs.webkit.org/show_bug.cgi?id=144217
478 Reviewed by Darin Adler.
480 * WebKitTestRunner/PlatformEfl.cmake:
482 2015-04-26 Doug Russell <d_russell@apple.com>
484 AX: richer text change notifications (142719)
485 https://bugs.webkit.org/show_bug.cgi?id=142719
487 Reviewed by Darin Adler.
489 Richer accessibility value change notifications. Introduce AXTextEditType,
490 postTextStateChangeNotification and postTextReplacementNotification to give assistive
491 tech apps more reliable context for responding to changes in web content. Also implement
492 a mechanism to post value changes in password form fields in coalesced ticks to thwart
493 analyzing the cadence of changes.
495 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
496 and an overload of postTextReplacementNotification to give assistive tech apps more
497 reliable context for responding to changes in web content selection. Also block posting
498 selection changes on password fields.
500 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
501 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
502 (-[AccessibilityNotificationHandler stopObserving]):
503 (-[AccessibilityNotificationHandler _notificationReceived:]):
504 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
505 (AccessibilityUIElement::removeNotificationListener):
506 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
507 (-[AccessibilityNotificationHandler _notificationReceived:]):
508 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
509 (WTR::AccessibilityUIElement::removeNotificationListener):
511 2015-04-25 Sungmann Cho <sungmann.cho@navercorp.com>
513 Add myself to contributors.json
514 https://bugs.webkit.org/show_bug.cgi?id=144204
516 Reviewed by Darin Adler.
518 * Scripts/webkitpy/common/config/contributors.json:
520 2015-04-25 Martin Robinson <mrobinson@igalia.com>
522 Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
523 https://bugs.webkit.org/show_bug.cgi?id=144182
525 Reviewed by Simon Fraser.
527 * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
529 2015-04-25 Dewei Zhu <dewei_zhu@apple.com>
531 https://bugs.webkit.org/show_bug.cgi?id=144038
533 Reviewed by Ryosuke Niwa
535 Add a script to run Speedometer and JetStream on a browser.
537 * Scripts/run-benchmark: Wrapper script to run benchmark.
539 * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
540 * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
541 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
542 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
543 (BenchmarkBuilderFactory):
544 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
545 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
546 (GenericBenchmarkBuilder):
547 (GenericBenchmarkBuilder.prepare):
548 (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
549 (GenericBenchmarkBuilder._applyPatch):
550 (GenericBenchmarkBuilder.clean):
551 * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
552 (JetStreamBenchmarkBuilder):
553 (JetStreamBenchmarkBuilder.prepare):
554 (JetStreamBenchmarkBuilder._runCreateScript):
555 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
557 (BenchmarkRunner.__init__):
558 (BenchmarkRunner.execute):
559 (BenchmarkRunner.dump):
560 (BenchmarkRunner.wrap):
561 (BenchmarkRunner.merge):
562 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
563 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
565 (BrowserDriver.prepareEnv):
566 (BrowserDriver.launchUrl):
567 (BrowserDriver.closeBrowser):
568 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
569 (BrowserDriverFactory):
570 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
571 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
573 (OSXChromeDriver.prepareEnv):
574 (OSXChromeDriver.launchUrl):
575 (OSXChromeDriver.closeBrowsers):
576 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
578 (OSXSafariDriver.prepareEnv):
579 (OSXSafariDriver.launchUrl):
580 (OSXSafariDriver.closeBrowsers):
581 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
582 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
583 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
584 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
585 * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
587 (GenericFactory.iterateGetItem):
588 (GenericFactory.create):
589 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
590 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
592 (ServerControl.render_GET):
593 (ServerControl.render_POST):
594 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
596 (HTTPServerDriver.serve):
597 (HTTPServerDriver.fetchResult):
598 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
599 (HTTPServerDriverFactory):
600 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
601 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
602 (SimpleHTTPServerDriver):
603 (SimpleHTTPServerDriver.depends):
604 (SimpleHTTPServerDriver.__init__):
605 (SimpleHTTPServerDriver.serve):
606 (SimpleHTTPServerDriver.baseUrl):
607 (SimpleHTTPServerDriver.fetchResult):
608 * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
609 (ModuleNotFoundError):
611 (getPathFromProjectRoot):
616 (timeout.handle_timeout):
620 2015-04-24 Commit Queue <commit-queue@webkit.org>
622 Unreviewed, rolling out r183303.
623 https://bugs.webkit.org/show_bug.cgi?id=144181
625 Change was incorrect, broke builds (Requested by smfr on
631 http://trac.webkit.org/changeset/183303
633 2015-04-24 Simon Fraser <simon.fraser@apple.com>
637 * MiniBrowser/mac/WK2BrowserWindowController.m:
638 (-[WK2BrowserWindowController initWithConfiguration:]):
640 2015-04-24 Brent Fulgham <bfulgham@apple.com>
642 Disable ActionMenusPDFTest due to timeout on test bot
644 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
645 (TestWebKitAPI::TEST):
647 2015-04-24 Commit Queue <commit-queue@webkit.org>
649 Unreviewed, rolling out r183266.
650 https://bugs.webkit.org/show_bug.cgi?id=144164
652 Broke 32-bit build and a test. (Requested by ap on #webkit).
656 "AX: richer text change notifications (142719)"
657 https://bugs.webkit.org/show_bug.cgi?id=142719
658 http://trac.webkit.org/changeset/183266
660 2015-04-24 Brent Fulgham <bfulgham@apple.com>
662 REGRESSION: WebKit2.ActionMenusTest API test fails
663 https://bugs.webkit.org/show_bug.cgi?id=144149
664 <rdar://problem/20677770>
666 Reviewed by Tim Horton.
668 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
669 as the 'ActionMenusPDFTest'.
670 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
671 (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
672 to match the hit test on the 'action-menu-target.pdf' test file.
674 2015-04-24 Daniel Bates <dabates@apple.com>
676 Cleanup: Use @memoized for property IOSSimulator.testing_device
677 https://bugs.webkit.org/show_bug.cgi?id=141715
679 Reviewed by Darin Adler.
681 Simplify the caching of the result of IOSSimulator.testing_device
682 and make the code more readable by making use of the @memoized declarator
683 instead of explicitly managing a private instance variable,
684 IOSSimulator._testing_device, for the cached result.
686 * Scripts/webkitpy/port/ios.py:
687 (IOSPort.determine_full_port_name):
688 (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
690 (IOSSimulatorPort.testing_device): No need to cache the created device object in
691 IOSSimulatorPort._testing_device since we are marking this function @memoized.
692 (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
693 of caching in local variable since we only make use of this value exactly once in this function.
694 (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
695 been used since being added in r178622. So, we can remove this constructor since
696 it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
698 2015-04-24 Anders Carlsson <andersca@apple.com>
700 Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
701 https://bugs.webkit.org/show_bug.cgi?id=144158
703 Reviewed by Beth Dakin.
705 * MiniBrowser/mac/WK2BrowserWindowController.m:
706 (-[WK2BrowserWindowController initWithConfiguration:]):
708 2015-04-24 Doug Russell <d_russell@apple.com>
710 AX: richer text change notifications (142719)
711 https://bugs.webkit.org/show_bug.cgi?id=142719
713 Reviewed by Darin Adler.
715 Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
717 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
719 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
720 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
721 (-[AccessibilityNotificationHandler stopObserving]):
722 (-[AccessibilityNotificationHandler _notificationReceived:]):
723 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
724 (AccessibilityUIElement::removeNotificationListener):
725 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
726 (-[AccessibilityNotificationHandler _notificationReceived:]):
727 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
728 (WTR::AccessibilityUIElement::removeNotificationListener):
730 2015-04-24 Darin Adler <darin@apple.com>
732 Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
733 https://bugs.webkit.org/show_bug.cgi?id=128007
735 Reviewed by Anders Carlsson.
737 * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
738 * DumpRenderTree/win/UIDelegate.h: Ditto.
740 * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
741 * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
743 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
745 * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
746 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
747 * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
748 (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
749 * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
750 (WebKitDOMDOMWindowTest::create): Ditto.
751 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
752 (documentLoadedCallback): Use a queue of DelayedSignal objects instead
753 of smart pointers to DelayedSIgnal objects.
754 (uriChangedCallback): Ditto.
756 2015-04-24 Brent Fulgham <bfulgham@apple.com>
758 [Mac] Unreviewed test fix.
759 https://bugs.webkit.org/show_bug.cgi?id=144149
761 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
762 (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
765 2015-04-23 Darin Adler <darin@apple.com>
767 Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
768 https://bugs.webkit.org/show_bug.cgi?id=144090
770 Reviewed by Anders Carlsson.
772 * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
774 2015-04-23 Michael Saboff <msaboff@apple.com>
776 lldb macro btjs sometimes can't get a frame description
777 https://bugs.webkit.org/show_bug.cgi?id=144130
779 Reviewed by Filip Pizlo.
781 We look to execute ExecState::describeFrame(). It appears that in some contexts the
782 debugger can't find ExecState. In those cases, CallFrame works as it is a typedef of
783 ExecState. Therefore we can fallback to using CallFrame::describeFrame().
785 * lldb/lldb_webkit.py:
788 2015-04-23 Alex Christensen <achristensen@webkit.org>
790 Use less memory when compiling content extensions.
791 https://bugs.webkit.org/show_bug.cgi?id=144051
793 Reviewed by Darin Adler and Benjamin Poulain.
795 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
796 (TestWebKitAPI::TEST_F):
797 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
798 (TestWebKitAPI::countLiveNodes):
800 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
802 [CMake] Clean up JSC JIT options
803 https://bugs.webkit.org/show_bug.cgi?id=143998
805 Reviewed by Filip Pizlo.
807 * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
808 * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
810 2015-04-21 Brent Fulgham <bfulgham@apple.com>
812 [Mac] Extend action menus to support PDF
813 https://bugs.webkit.org/show_bug.cgi?id=143895
814 <rdar://problem/19003333>
816 Reviewed by Tim Horton.
818 Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
819 of PDF content works.
821 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
822 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
823 * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
824 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
825 (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
826 Update to support PDF tests.
827 (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
828 (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
830 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
832 Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
834 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
836 (testWebViewAudioOnlyUserMediaPermissionRequests):
838 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
840 Add myself to watchlist
841 https://bugs.webkit.org/show_bug.cgi?id=144041
843 Reviewed by Alex Christensen.
845 Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
847 * Scripts/webkitpy/common/config/watchlist:
849 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
851 [GTK] MiniBrowser should use NetworkProcess by default
852 https://bugs.webkit.org/show_bug.cgi?id=143948
854 Reviewed by Sergio Villar Senin.
856 Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
857 unless MINIBROWSER_SINGLEPROCESS environment variable is present.
859 * MiniBrowser/gtk/main.c:
862 2015-04-21 Matthew Hanson <matthew_hanson@apple.com>
864 Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
866 Unreviewed build fix.
868 * Scripts/prepare-ChangeLog:
869 (get_function_line_ranges_for_cpp):
870 Use grep instead of any to determine if a string is an element of an array.
872 2015-04-21 Anders Carlsson <andersca@apple.com>
875 https://bugs.webkit.org/show_bug.cgi?id=144002
877 Reviewed by Andreas Kling.
879 * MiniBrowser/mac/WK2BrowserWindowController.m:
880 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
882 2015-04-21 Philippe Normand <pnormand@igalia.com>
884 [GTK] jhbuild should not use a branch for openwebrtc
885 https://bugs.webkit.org/show_bug.cgi?id=143981
887 Reviewed by Carlos Garcia Campos.
889 * gtk/jhbuild.modules:
891 2015-04-20 Matthew Hanson <matthew_hanson@apple.com>
893 Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
895 Unreviewed build fix.
897 The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
898 However, it has been exposed by List::MoreUtils since its inception. This patch uses
899 the any function exposed by List::MoreUtils for greater compatibility.
901 * Scripts/prepare-ChangeLog:
902 Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
903 the any function in all of versions of Perl used by our infrastructure.
905 2015-04-20 Alex Christensen <achristensen@webkit.org>
907 Remove unnecessary logs when resetting tests.
909 * WebKitTestRunner/mac/TestControllerMac.mm:
910 (WTR::TestController::platformResetPreferencesToConsistentValues):
911 In r183020 I added some logs when compiling or removing content extensions fails.
912 We often try to remove a content extension that does not exist, and that is not a problem.
914 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
916 prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
917 https://bugs.webkit.org/show_bug.cgi?id=143897
919 Reviewed by David Kilzer.
921 This is a speculative fix that addresses two issues:
923 1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
924 We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
926 So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
930 Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
931 Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
933 This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
934 to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
936 The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
938 2. Creating git diffs from HEAD and not origin/master by default.
940 Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
941 when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
943 * Scripts/prepare-ChangeLog:
945 Use HEAD instead of origin/master in default Git case.
947 (generateFunctionLists):
948 Ensure that the end line is not less than the start line.
950 (extractLineRangeAfterChange):
951 Set the end line to the start line if the end line is less than the start line.
953 (extractLineRangeBeforeChange):
956 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
958 Suppress warning in prepare-ChangeLog.
959 https://bugs.webkit.org/show_bug.cgi?id=143882
961 Reviewed by David Kilzer.
963 Prune noisy prepare-ChangeLog output by using the List::Util::any function
964 instead of the deprecated smartmatch operator.
966 * Scripts/prepare-ChangeLog:
967 Import the List::Util::any function.
969 (get_function_line_ranges_for_cpp):
970 Use the any function instead of smartmatch.
972 2015-04-20 Anders Carlsson <andersca@apple.com>
974 Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
975 https://bugs.webkit.org/show_bug.cgi?id=143966
977 Reviewed by Dan Bernstein.
979 * MiniBrowser/mac/WK2BrowserWindowController.m:
981 (-[WK2BrowserWindowController fetchWebsiteData:]):
982 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
983 (-[WK2BrowserWindowController clearWebsiteData:]):
985 2015-04-20 Alex Christensen <achristensen@webkit.org>
987 Fix content extension test flakiness.
988 https://bugs.webkit.org/show_bug.cgi?id=143950
990 Reviewed by Brady Eidson.
992 * WebKitTestRunner/mac/TestControllerMac.mm:
993 (WTR::TestController::platformResetPreferencesToConsistentValues):
994 Remove the TestContentExtensions if it exists.
995 (WTR::TestController::platformConfigureViewForTest):
996 Log errors in case there are any.
998 2015-04-20 Alex Christensen <achristensen@webkit.org>
1000 Properly report errors from _WKUserContentExtensionStore.
1001 https://bugs.webkit.org/show_bug.cgi?id=143808
1003 Reviewed by Darin Adler.
1005 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1008 2015-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
1010 Add a rule for NetworkCache to watchlist file
1011 https://bugs.webkit.org/show_bug.cgi?id=143945
1013 Reviewed by Sergio Villar Senin.
1015 And add myself to the list of watchers.
1017 * Scripts/webkitpy/common/config/watchlist:
1019 2015-04-19 Darin Adler <darin@apple.com>
1021 Update RefPtr documentation and deprecation
1022 https://bugs.webkit.org/show_bug.cgi?id=143936
1024 Reviewed by Andreas Kling.
1026 * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
1028 2015-04-19 Yusuke Suzuki <utatane.tea@gmail.com>
1030 Introduce bytecode intrinsics
1031 https://bugs.webkit.org/show_bug.cgi?id=143926
1033 Reviewed by Filip Pizlo.
1035 Change cpplint to accept emit_intrinsic_XXX.
1037 * Scripts/webkitpy/style/checkers/cpp.py:
1038 (check_identifier_name_in_declaration):
1040 2015-04-18 Simon Fraser <simon.fraser@apple.com>
1042 Fix lldb_webkit.py to show StringImpls correctly
1043 https://bugs.webkit.org/show_bug.cgi?id=143920
1045 Reviewed by Andreas Kling.
1047 Update WTFStringImplProvider's is_8bit to use the correct bitmask.
1049 * lldb/lldb_webkit.py:
1050 (WTFStringImplProvider.is_8bit):
1052 2015-04-17 Daniel Bates <dabates@apple.com>
1054 Not able to build WebKit against iOS Simulator 8.3 SDK
1055 https://bugs.webkit.org/show_bug.cgi?id=143883
1057 Reviewed by David Kilzer.
1059 Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
1060 so that Xcode uses them.
1062 * Scripts/copy-webkitlibraries-to-product-directory:
1064 2015-04-17 Beth Dakin <bdakin@apple.com>
1066 Force mouse events should go through normal mouse event handling code paths
1067 https://bugs.webkit.org/show_bug.cgi?id=143749
1069 rdar://problem/20472895
1071 Reviewed by Dean Jackson.
1073 Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
1074 Since there is not a way to create an NSEventTypePressure from scratch, we
1075 subclass NSEvent and override all of the critical methods.
1077 * WebKitTestRunner/EventSenderProxy.h:
1078 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1079 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1080 (WTR::EventSendingController::mouseForceDown):
1081 (WTR::EventSendingController::mouseForceUp):
1082 (WTR::EventSendingController::mouseForceChanged):
1083 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1084 * WebKitTestRunner/TestController.cpp:
1085 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1086 * WebKitTestRunner/mac/EventSenderProxy.mm:
1087 (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1088 (-[EventSenderPressureEvent timestamp]):
1089 (-[EventSenderPressureEvent type]):
1090 (-[EventSenderPressureEvent locationInWindow]):
1091 (-[EventSenderPressureEvent location]):
1092 (-[EventSenderPressureEvent stage]):
1093 (-[EventSenderPressureEvent pressure]):
1094 (-[EventSenderPressureEvent phase]):
1095 (-[EventSenderPressureEvent eventNumber]):
1096 (WTR::EventSenderProxy::mouseForceDown):
1097 (WTR::EventSenderProxy::mouseForceUp):
1098 (WTR::EventSenderProxy::mouseForceChanged):
1100 2015-04-17 Alexey Proskuryakov <ap@apple.com>
1102 build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
1103 https://bugs.webkit.org/show_bug.cgi?id=143885
1105 Reviewed by Tim Horton.
1107 Fixed a case where we have two builds with the same revision(s). An in order build
1108 is one for which the revision is strictly higher.
1110 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1111 (BuildbotQueue.prototype._checkForInOrderResult):
1112 (BuildbotQueue.prototype.compareIterationsByRevisions):
1114 2015-04-17 Commit Queue <commit-queue@webkit.org>
1116 Unreviewed, rolling out r182912 and r182920.
1117 https://bugs.webkit.org/show_bug.cgi?id=143881
1119 Build breakage in some configurations (Requested by ap on
1122 Reverted changesets:
1124 "Force mouse events should go through normal mouse event
1125 handling code paths"
1126 https://bugs.webkit.org/show_bug.cgi?id=143749
1127 http://trac.webkit.org/changeset/182912
1129 http://trac.webkit.org/changeset/182920
1131 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
1133 [GTK] One more unreviewed fix after r182882.
1135 * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
1137 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
1139 [GTK] Unreviewed speculative clean build fix after r182882.
1141 TestWebKitAPI's forwarding header generator depended on WeKit2's
1142 which generated SOUP related forwarding headers too.
1144 This dependency isn't necessary and was removed by r182882 to make
1145 forwarding header generators parallelizable. But in this case
1146 TestWebKitAPI's and WebKitTestRunner's forwarding header generator
1147 should generate SOUP related forwarding headers too similar to EFL.
1149 * TestWebKitAPI/PlatformGTK.cmake:
1150 * WebKitTestRunner/PlatformGTK.cmake:
1152 2015-04-17 Carlos Garcia Campos <cgarcia@igalia.com>
1154 [SOUP] Redirect to non HTTP destination is broken
1155 https://bugs.webkit.org/show_bug.cgi?id=143866
1157 Reviewed by Sergio Villar Senin.
1159 Add a unit test to check that redirect to a data URI works.
1161 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1162 (testRedirectToDataURI):
1166 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
1168 Changes method of quitting iOS Simulator to be more correct.
1169 https://bugs.webkit.org/show_bug.cgi?id=143847
1170 <rdar://problem/20530344>
1172 Reviewed by Darin Adler.
1174 Fixes by addressing the app by ID rather than by name.
1176 * Scripts/webkitdirs.pm:
1178 * Scripts/webkitpy/port/ios.py:
1179 (IOSSimulatorPort.check_sys_deps):
1181 2015-04-16 Anders Carlsson <andersca@apple.com>
1183 Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
1184 https://bugs.webkit.org/show_bug.cgi?id=143844
1186 Reviewed by Dan Bernstein.
1188 * MiniBrowser/mac/AppDelegate.m:
1189 (-[BrowserAppDelegate newPrivateWindow:]):
1190 * MiniBrowser/mac/WK2BrowserWindowController.m:
1191 (-[WK2BrowserWindowController initWithConfiguration:]):
1192 (-[WK2BrowserWindowController fetchWebsiteData:]):
1193 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1194 (-[WK2BrowserWindowController clearWebsiteData:]):
1196 2015-04-16 Alex Christensen <achristensen@webkit.org>
1200 * WebKitTestRunner/mac/TestControllerMac.mm:
1201 (WTR::TestController::platformResetPreferencesToConsistentValues):
1202 (WTR::TestController::platformConfigureViewForTest):
1203 Added WK_API_ENABLED.
1205 2015-04-16 Alex Christensen <achristensen@webkit.org>
1207 Removed unused WKUserContentFilterRef.
1208 https://bugs.webkit.org/show_bug.cgi?id=143852
1210 Reviewed by Sam Weinig.
1212 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1213 * WebKitTestRunner/mac/TestControllerMac.mm:
1214 (WTR::TestController::platformResetPreferencesToConsistentValues):
1215 (WTR::TestController::platformConfigureViewForTest):
1217 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
1219 Unreviewed. Adding myself as a commiter in contributers.json.
1221 * Scripts/webkitpy/common/config/contributors.json:
1223 2015-04-16 Alexey Proskuryakov <ap@apple.com>
1225 It is very hard to attach a debugger to WebProcess to debug tests
1226 https://bugs.webkit.org/show_bug.cgi?id=143837
1228 Reviewed by Chris Dumez.
1230 --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
1231 WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
1233 Now it disables all timeouts in tools, as is best for debugging tests.
1235 * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
1236 that the script doesn't terminate DRT/WKTR when there is no output for a long time.
1238 * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
1239 now has the same functionality.
1241 2015-04-16 Beth Dakin <bdakin@apple.com>
1243 Force mouse events should go through normal mouse event handling code paths
1244 https://bugs.webkit.org/show_bug.cgi?id=143749
1246 rdar://problem/20472895
1248 Reviewed by Dean Jackson.
1250 Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
1251 Since there is not a way to create an NSEventTypePressure from scratch, we
1252 subclass NSEvent and override all of the critical methods.
1254 * WebKitTestRunner/EventSenderProxy.h:
1255 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1256 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1257 (WTR::EventSendingController::mouseForceDown):
1258 (WTR::EventSendingController::mouseForceUp):
1259 (WTR::EventSendingController::mouseForceChanged):
1260 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1261 * WebKitTestRunner/TestController.cpp:
1262 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1263 * WebKitTestRunner/mac/EventSenderProxy.mm:
1264 (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1265 (-[EventSenderPressureEvent timestamp]):
1266 (-[EventSenderPressureEvent type]):
1267 (-[EventSenderPressureEvent locationInWindow]):
1268 (-[EventSenderPressureEvent location]):
1269 (-[EventSenderPressureEvent stage]):
1270 (-[EventSenderPressureEvent pressure]):
1271 (-[EventSenderPressureEvent phase]):
1272 (-[EventSenderPressureEvent eventNumber]):
1273 (WTR::EventSenderProxy::mouseForceDown):
1274 (WTR::EventSenderProxy::mouseForceUp):
1275 (WTR::EventSenderProxy::mouseForceChanged):
1277 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
1279 [EFL] Bump LLVM to version 3.6.0 on X86_64
1280 https://bugs.webkit.org/show_bug.cgi?id=143604
1282 Reviewed by Gyuyoung Kim.
1284 * efl/jhbuild.modules:
1285 * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
1286 * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
1287 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
1288 * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
1290 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
1292 [EFL] Remove an unnecessary workaround from jhbuildrc
1293 https://bugs.webkit.org/show_bug.cgi?id=143823
1295 Reviewed by Gyuyoung Kim.
1299 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
1301 [GTK] Run forwarding headers generator unconditionally
1302 https://bugs.webkit.org/show_bug.cgi?id=143819
1304 Reviewed by Carlos Garcia Campos.
1306 * TestWebKitAPI/PlatformGTK.cmake:
1307 * WebKitTestRunner/PlatformGTK.cmake:
1309 2015-04-15 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1311 [EFL] Add gnutls to jhbuild.module
1312 https://bugs.webkit.org/show_bug.cgi?id=143777
1314 Reviewed by Csaba Osztrogonác.
1316 EFL port has required at least 3.0.0 version of gnutls since r176712.
1317 However some old linux distributions don't support 3.0.0 version. Besides
1318 other projects sometimes need to use lower version of gnutls.
1320 This patch supports to download gnutls through jhbuild, and use it.
1322 * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev.
1323 * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
1325 2015-04-15 Mark Lam <mark.lam@apple.com>
1327 Remove obsolete VMInspector debugging tool.
1328 https://bugs.webkit.org/show_bug.cgi?id=143798
1330 Reviewed by Michael Saboff.
1332 * TestWebKitAPI/CMakeLists.txt:
1333 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1334 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1335 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1336 * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
1338 2015-04-15 Jer Noble <jer.noble@apple.com>
1340 Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
1342 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1344 2015-04-15 Jer Noble <jer.noble@apple.com>
1346 Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
1348 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1349 (TestWebKitAPI::TEST_F):
1351 2015-04-15 Chris Dumez <cdumez@apple.com>
1353 [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
1354 https://bugs.webkit.org/show_bug.cgi?id=143779
1356 Reviewed by Brent Fulgham.
1358 Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
1359 similarly to what is done on Mac / WK1. Without this, PageCache could
1360 stay enabled after page cache tests and cause weird behaviors.
1362 * DumpRenderTree/win/DumpRenderTree.cpp:
1363 (resetWebPreferencesToConsistentValues):
1365 2015-04-14 Simon Fraser <simon.fraser@apple.com>
1367 Re-enable custom dilation for antialiased fonts
1368 https://bugs.webkit.org/show_bug.cgi?id=143738
1370 Reviewed by Tim Horton.
1372 Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
1373 but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
1374 a private WebKit pref. This pref defaults to YES, enabling the feature by default
1375 in WK1 as we do for WK2.
1377 * DumpRenderTree/mac/DumpRenderTree.mm:
1378 (resetWebPreferencesToConsistentValues):
1379 * WebKitTestRunner/TestController.cpp:
1380 (WTR::TestController::resetPreferencesToConsistentValues):
1382 2015-04-14 Brent Fulgham <bfulgham@apple.com>
1384 Correct layering violation in DumpRenderTree Build
1385 https://bugs.webkit.org/show_bug.cgi?id=143732
1387 Reviewed by Simon Fraser.
1389 Correct a layering violation in DumpRenderTree by calling functions on the
1390 WebCoreTestSupport library, rather than attempting to work with WebCore
1393 * DumpRenderTree/mac/EventSendingController.mm:
1394 (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
1395 than WebCore itself.,
1396 (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
1398 2015-04-14 Benjamin Poulain <benjamin@webkit.org>
1400 Add a conservative DFA minimizer for the content extension matcher
1401 https://bugs.webkit.org/show_bug.cgi?id=143501
1403 Reviewed by Alex Christensen.
1405 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1406 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1408 2015-04-14 Daniel Bates <dabates@apple.com>
1410 Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
1411 https://bugs.webkit.org/show_bug.cgi?id=143693
1412 <rdar://problem/20530316>
1414 Reviewed by Tim Horton.
1416 Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
1417 to use the fixed layout code on iOS at this time.
1419 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
1421 2015-04-14 Dominik Röttsches <dominik.rottsches@intel.com>
1423 Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
1424 https://bugs.webkit.org/show_bug.cgi?id=143705
1426 Unreviewed change to watchlist file.
1428 * Scripts/webkitpy/common/config/watchlist:
1430 2015-04-14 KwangHyuk Kim <hyuki.kim@samsung.com>
1432 [EFL] favicon wasn't updated for google.com sometimes.
1433 https://bugs.webkit.org/show_bug.cgi?id=141940
1435 Reviewed by Gyuyoung Kim.
1437 As elm_entry_utf8_to_markup can include additional characters, parameter for the
1438 on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
1440 * MiniBrowser/efl/main.c:
1443 2015-04-13 Tim Horton <timothy_horton@apple.com>
1445 Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
1446 https://bugs.webkit.org/show_bug.cgi?id=143560
1447 <rdar://problem/16302047>
1449 Reviewed by Darin Adler.
1451 * MiniBrowser/mac/BrowserWindowController.h:
1452 * MiniBrowser/mac/MainMenu.xib:
1453 * MiniBrowser/mac/WK1BrowserWindowController.m:
1454 (-[WK1BrowserWindowController setScale:]):
1455 * MiniBrowser/mac/WK2BrowserWindowController.m:
1456 (viewScaleForMenuItemTag):
1457 (-[WK2BrowserWindowController setScale:]):
1458 (-[WK2BrowserWindowController validateMenuItem:]):
1459 Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
1460 When in use, we resize the window so that the view fits correctly, and
1461 use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
1462 layout size will not change when scaling down (but will update appropriately
1463 when the view is resized).
1465 2015-04-13 Alexey Proskuryakov <ap@apple.com>
1467 build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
1468 https://bugs.webkit.org/show_bug.cgi?id=138630
1470 Reviewed by Tim Horton.
1472 Make sure that we always load at least one in order productive iteration.
1474 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1475 (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
1476 is done loading at least one iteration that wasn't an out of order build.
1477 (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
1478 when that's needed to check for out of order builds.
1479 (BuildbotQueue.prototype.update): Ditto.
1480 (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
1481 result, and if it does not, load more iterations.
1482 (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
1483 an in order iteration loaded too.
1484 (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
1485 corrected to always sort loaded iterations before unloaded ones.
1487 2015-04-10 Brent Fulgham <bfulgham@apple.com>
1489 Expand test infrastructure to support scrolling tests
1490 https://bugs.webkit.org/show_bug.cgi?id=143286
1491 <rdar://problem/20375516>
1493 Reviewed by Simon Fraser.
1495 Extend the WK1 and WK2 test programs to support two new EventSender commands:
1496 (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
1497 block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
1498 (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
1499 relevant rubberband, scroll, and scroll-snap animations are finished.
1501 * DumpRenderTree/mac/EventSendingController.mm:
1502 (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
1503 and 'monitorWheelEvents'.
1504 (+[EventSendingController webScriptNameForSelector:]): Ditto.
1505 (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
1506 debugging test failures.
1507 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
1508 (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
1509 function, then passes it to WebCore to be called once the test deferrals have been cleared.
1510 (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
1511 'callAfterScrollingCompletes' method.
1512 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
1513 and 'monitorWheelEvents'.
1514 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1515 (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
1516 callback function, then passes it to WebCore to be called once the test deferrals have been cleared
1517 (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
1518 'callAfterScrollingComplates' method.
1519 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1521 2015-04-13 Alexey Proskuryakov <ap@apple.com>
1523 build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
1524 https://bugs.webkit.org/show_bug.cgi?id=143656
1526 Reviewed by Darin Adler.
1528 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1529 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1531 2015-04-13 Sergio Villar Senin <svillar@igalia.com>
1533 REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
1534 https://bugs.webkit.org/show_bug.cgi?id=142387
1536 Reviewed by Carlos Garcia Campos.
1538 Running mixed content is blocked by default since r181134. Updated
1539 the test case to reflect the new default settings.
1541 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1542 (testInsecureContent):
1544 2015-04-13 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1546 Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
1547 https://bugs.webkit.org/show_bug.cgi?id=143667
1549 Reviewed by Csaba Osztrogonác.
1551 ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
1552 since r169017. Added $hardwareConcurrencySupport for it.
1554 Additionally networkInfoSupport is removed because this feature was removed due to spec out.
1556 * Scripts/webkitperl/FeatureList.pm:
1558 2015-04-13 Csaba Osztrogonác <ossy@webkit.org>
1560 [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
1561 https://bugs.webkit.org/show_bug.cgi?id=143664
1563 Reviewed by Gyuyoung Kim.
1565 * Scripts/webkitperl/FeatureList.pm:
1567 2015-04-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1569 [EFL] Enable Media Source
1570 https://bugs.webkit.org/show_bug.cgi?id=143635
1572 Reviewed by Csaba Osztrogonác.
1574 * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
1576 2015-04-12 Alexey Proskuryakov <ap@apple.com>
1578 build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
1579 https://bugs.webkit.org/show_bug.cgi?id=143646
1581 Reviewed by David Kilzer.
1583 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1584 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1586 2015-04-11 Alexey Proskuryakov <ap@apple.com>
1588 Use en_US spell checker for tests on Mac instead of Multilingual
1589 https://bugs.webkit.org/show_bug.cgi?id=143641
1591 Reviewed by Dan Bernstein.
1593 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1594 While at it, override NSUserDictionaryReplacementItems, so that user replacements
1595 cannot affect tests.
1597 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
1598 Made this more like WebKit1 version.
1600 2015-04-10 Tim Horton <timothy_horton@apple.com>
1602 Replace setFixedLayoutSizeEnabled: with an enum of layout modes
1603 https://bugs.webkit.org/show_bug.cgi?id=143576
1605 Reviewed by Simon Fraser.
1607 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
1611 2015-04-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1613 Update my email address and expertise.
1614 https://bugs.webkit.org/show_bug.cgi?id=143586
1616 Unreviewed, just update my info.
1618 * Scripts/webkitpy/common/config/contributors.json:
1620 2015-04-09 Joseph Pecoraro <pecoraro@apple.com>
1622 Flakiness Dashboard not loading insecure content if loaded with https URL
1623 https://bugs.webkit.org/show_bug.cgi?id=143570
1625 Reviewed by Alexey Proskuryakov.
1627 * TestResultServer/app.yaml:
1628 * TestResultServer/static-dashboards/loader.js:
1629 Switch to https scheme.
1631 2015-04-09 Csaba Osztrogonác <ossy@webkit.org>
1633 [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
1634 https://bugs.webkit.org/show_bug.cgi?id=142907
1636 Reviewed by Carlos Garcia Campos.
1638 * TestWebKitAPI/PlatformEfl.cmake:
1639 * TestWebKitAPI/PlatformGTK.cmake:
1640 * WebKitTestRunner/PlatformEfl.cmake:
1641 * WebKitTestRunner/PlatformGTK.cmake:
1643 2015-04-08 Brent Fulgham <bfulgham@apple.com>
1645 [Mac] Unreviewed test fix after r182584
1646 https://bugs.webkit.org/show_bug.cgi?id=143452
1648 Put both of these tests back to their original state now that the underlying
1651 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1652 (TestWebKitAPI::TEST):
1653 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1654 (TestWebKitAPI::TEST):
1656 2015-04-08 Filip Pizlo <fpizlo@apple.com>
1658 run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
1659 https://bugs.webkit.org/show_bug.cgi?id=143553
1661 Reviewed by Ryosuke Niwa.
1663 Remove the spurious printVMs left over from an earlier change.
1665 * Scripts/run-jsc-benchmarks:
1667 2015-04-08 Brent Fulgham <bfulgham@apple.com>
1669 [Mac] Unreviewed test fix after r182581
1671 The behavior of control-left-click is controlled by a system preference.
1672 Our test bots have this turned off.
1674 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1675 (TestWebKitAPI::TEST):
1676 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1677 (TestWebKitAPI::TEST):
1679 2015-04-08 Brent Fulgham <bfulgham@apple.com>
1681 [Mac] WebKit is not honoring OS preferences for secondary click behaviors
1682 https://bugs.webkit.org/show_bug.cgi?id=143452
1683 <rdar://problem/20437483>
1685 Reviewed by Tim Horton.
1687 Add a new API test to confirm that Cocoa mouse button press events are properly
1688 tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
1690 The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
1691 some registered event handlers that the expected button press and context menu
1692 events are received.
1694 The WK1 unit test creates an NSEvent with the desired button press state, and then
1695 uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
1696 We check the resulting PlatformMouseEvent for proper state.
1698 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
1699 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
1700 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1701 * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
1702 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
1703 (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
1704 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1705 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1706 (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
1708 * TestWebKitAPI/mac/PlatformWebViewMac.h:
1710 2015-04-08 Michael Catanzaro <mcatanzaro@igalia.com>
1712 [GTK] Add pango to jhbuild-optional.modules
1713 https://bugs.webkit.org/show_bug.cgi?id=143537
1715 Reviewed by Martin Robinson.
1717 * gtk/jhbuild-optional.modules: Add pango.
1719 2015-04-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
1721 [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
1722 https://bugs.webkit.org/show_bug.cgi?id=143530
1724 Reviewed by Žan Doberšek.
1726 Assume that the default value for display (:0) is reserved and start checking on :1
1727 Adjust webkitpy test and include two new test cases for this bug (display number not specified)
1728 and for X server named Xorg.bin (previous bug 1376599)
1730 * Scripts/webkitpy/port/xvfbdriver.py:
1731 (XvfbDriver._next_free_display)
1732 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1733 (XvfbDriverTest.test_start_no_pixel_tests):
1734 (XvfbDriverTest.test_start_pixel_tests):
1735 (XvfbDriverTest.test_start_arbitrary_worker_number):
1736 (XvfbDriverTest.test_next_free_display):
1737 (XvfbDriverTest.test_start_next_worker):
1738 2015-04-08 Alex Christensen <achristensen@webkit.org>
1740 Block popups from content extensions.
1741 https://bugs.webkit.org/show_bug.cgi?id=143497
1743 Reviewed by Brady Eidson.
1745 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1746 (TestWebKitAPI::TEST_F):
1749 2015-04-08 Alex Christensen <achristensen@webkit.org> and Patrick Gansterer <paroga@webkit.org>
1751 Add CMake build system for WinCairo port.
1752 https://bugs.webkit.org/show_bug.cgi?id=115944
1754 Reviewed by Chris Dumez.
1757 * WinLauncher/CMakeLists.txt: Added.
1759 2015-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
1761 [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
1762 https://bugs.webkit.org/show_bug.cgi?id=143521
1764 Reviewed by Martin Robinson.
1766 Add a way to detect unexpected web process crashes to WebViewTest,
1767 and a test case to testDOMCache to trigger the crash.
1769 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1770 (WebKitDOMNodeTest::testDOMCache):
1771 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1772 (testWebKitWebViewProcessCrashed):
1773 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1774 (WebViewTest::WebViewTest):
1775 (WebViewTest::webProcessCrashed):
1776 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1778 2015-04-07 Alexey Proskuryakov <ap@apple.com>
1780 PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
1781 rdar://problem/20461342
1783 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1785 2015-04-07 Commit Queue <commit-queue@webkit.org>
1787 Unreviewed, rolling out r182511.
1788 https://bugs.webkit.org/show_bug.cgi?id=143507
1790 caused debug test failures (Requested by alexchristensen on
1795 "Block popups from content extensions."
1796 https://bugs.webkit.org/show_bug.cgi?id=143497
1797 http://trac.webkit.org/changeset/182511
1799 2015-04-07 Alex Christensen <achristensen@webkit.org>
1801 Block popups from content extensions.
1802 https://bugs.webkit.org/show_bug.cgi?id=143497
1804 Reviewed by Brady Eidson.
1806 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1807 (TestWebKitAPI::TEST_F):
1810 2015-04-07 Benjamin Poulain <benjamin@webkit.org>
1812 Get the features.json files ready for open contributions
1813 https://bugs.webkit.org/show_bug.cgi?id=143436
1815 Reviewed by Darin Adler.
1817 * Scripts/webkitpy/style/checkers/jsonchecker.py:
1818 (JSONFeaturesChecker.check):
1819 Extend the syntax checking a bit, but leave everything non-mandatory
1820 very loose until we figure what fields are important.
1822 2015-04-07 Tim Horton <timothy_horton@apple.com>
1824 Expose and test fixedLayoutSize via modern WebKit SPI
1825 https://bugs.webkit.org/show_bug.cgi?id=143500
1827 Reviewed by Simon Fraser.
1829 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1830 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
1831 (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
1833 Add a test that verifies that fixedLayoutSize works at all, that
1834 it persists through a navigation, and that turning it back off reverts to
1835 laying out at the size of the view.
1837 2015-04-07 Michael Catanzaro <mcatanzaro@igalia.com>
1839 Unreviewed. Add myself as a committer.
1841 * Scripts/webkitpy/common/config/contributors.json:
1843 2015-04-07 Brent Fulgham <bfulgham@apple.com>
1845 [Win] Bots complain about missing /etc/catalog
1846 https://bugs.webkit.org/show_bug.cgi?id=143484
1848 Reviewed by Chris Dumez.
1850 The libxml2 build on Mac, iOS, and Windows does not provide the set
1851 of default catalog files. We do not actually need these for our
1852 purposes, but we get warnings and some bot flakiness because they
1855 We can avoid both problems the same way the Mac and iOS ports do,
1856 by setting the XML_CATALOG_FILES environment variable to 'empty string',
1857 which avoid the warnings and bot problems.
1859 * Scripts/webkitpy/port/win.py:
1860 (WinPort.setup_environ_for_server): Added.
1862 2015-04-06 Sam Weinig <sam@webkit.org>
1864 Use content extensions in MiniBrowser.
1865 https://bugs.webkit.org/show_bug.cgi?id=143446
1867 Reviewed by Alex Christensen.
1869 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1870 * MiniBrowser/mac/AppDelegate.h:
1871 * MiniBrowser/mac/AppDelegate.m:
1872 (-[BrowserAppDelegate init]):
1873 (-[BrowserAppDelegate showExtensionsManager:]):
1874 (-[BrowserAppDelegate userContentContoller]):
1875 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1876 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1877 (-[ExtensionManagerWindowController init]):
1878 (-[ExtensionManagerWindowController windowDidLoad]):
1879 (-[ExtensionManagerWindowController add:]):
1880 (-[ExtensionManagerWindowController remove:]):
1881 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1882 * MiniBrowser/mac/MainMenu.xib:
1884 2015-04-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
1886 web-platform-tests server should retrieve the modules file relatively to its docroot path
1887 https://bugs.webkit.org/show_bug.cgi?id=142742
1889 Reviewed by Darin Adler.
1891 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1892 (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
1894 2015-04-06 Commit Queue <commit-queue@webkit.org>
1896 Unreviewed, rolling out r182445.
1897 https://bugs.webkit.org/show_bug.cgi?id=143459
1899 broke 32 bit build (Requested by alexchristensen on #webkit).
1903 "Use content extensions in MiniBrowser."
1904 https://bugs.webkit.org/show_bug.cgi?id=143446
1905 http://trac.webkit.org/changeset/182445
1907 2015-04-06 Sam Weinig <sam@webkit.org>
1909 Use content extensions in MiniBrowser.
1910 https://bugs.webkit.org/show_bug.cgi?id=143446
1912 Reviewed by Alex Christensen.
1914 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1915 * MiniBrowser/mac/AppDelegate.h:
1916 * MiniBrowser/mac/AppDelegate.m:
1917 (-[BrowserAppDelegate init]):
1918 (-[BrowserAppDelegate showExtensionsManager:]):
1919 (-[BrowserAppDelegate userContentContoller]):
1920 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1921 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1922 (-[ExtensionManagerWindowController init]):
1923 (-[ExtensionManagerWindowController windowDidLoad]):
1924 (-[ExtensionManagerWindowController add:]):
1925 (-[ExtensionManagerWindowController remove:]):
1926 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1927 * MiniBrowser/mac/MainMenu.xib:
1929 2015-04-06 Michael Catanzaro <mcatanzaro@gnome.org>
1931 [GTK] install-dependencies should prefer dnf to yum
1932 https://bugs.webkit.org/show_bug.cgi?id=143441
1934 Reviewed by Martin Robinson.
1936 Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
1938 * gtk/install-dependencies:
1940 2015-04-06 Andy Estes <aestes@apple.com>
1942 [iOS] 'make clean' fails in Tools/WebKitTestRunner
1943 https://bugs.webkit.org/show_bug.cgi?id=143455
1945 Reviewed by Dan Bernstein.
1947 This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
1948 Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
1950 * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
1952 2015-04-06 Alexey Proskuryakov <ap@apple.com>
1954 WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
1955 https://bugs.webkit.org/show_bug.cgi?id=143450
1957 Reviewed by Anders Carlsson.
1959 * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
1960 Make sure that the view is actually closed, regardless of anything else that happens beneath.
1961 Also, removed unnecessary get() calls.
1963 2015-04-03 Alexey Proskuryakov <ap@apple.com>
1965 Reduce the dependency on Flash in regression tests
1966 https://bugs.webkit.org/show_bug.cgi?id=143391
1968 Reviewed by Anders Carlsson.
1970 * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
1971 Only allow QuickTime and the test plug-in.
1973 2015-04-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
1975 W3C test importer should generate the modules installed dynamically to run wpt tests
1976 https://bugs.webkit.org/show_bug.cgi?id=142738
1978 Reviewed by Ryosuke Niwa.
1980 The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
1981 The implementation is done within TestDownloader and it is activated for the WPT repository.
1982 LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
1984 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1985 (WebPlatformTestServer._install_modules): Updated to cope with path as array.
1986 * Scripts/webkitpy/w3c/test_downloader.py:
1987 (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
1989 (TestDownloader._git_submodules_description): Computes submodule description.
1990 (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
1991 * Scripts/webkitpy/w3c/test_importer.py:
1992 (TestImporter.do_import): Added the possibility to post process the tests.
1994 (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
1995 (TestImporter.should_convert_test_harness_links): Updated according new options format.
1996 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1997 (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
1998 (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
1999 (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
2000 (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
2001 (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
2003 2015-04-05 Antti Koivisto <antti@apple.com>
2005 Bloom filter should support longer hashes
2006 https://bugs.webkit.org/show_bug.cgi?id=143419
2008 Reviewed by Dan Bernstein.
2010 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
2011 (TestWebKitAPI::generateRandomDigests):
2012 (TestWebKitAPI::TEST):
2014 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
2016 run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
2017 https://bugs.webkit.org/show_bug.cgi?id=143372
2019 Reviewed by Darin Adler.
2021 * Scripts/run-jsc-stress-tests:
2023 2015-04-03 Antti Koivisto <antti@apple.com>
2025 Add non-counting bloom filter class
2026 https://bugs.webkit.org/show_bug.cgi?id=143366
2028 Reviewed by Sam Weinig.
2030 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2031 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
2032 (TestWebKitAPI::generateRandomHashes):
2033 (TestWebKitAPI::TEST):
2035 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
2037 FTL JIT tests should fail if LLVM library isn't available
2038 https://bugs.webkit.org/show_bug.cgi?id=143374
2040 Reviewed by Mark Lam.
2042 * Scripts/run-jsc-stress-tests:
2044 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
2046 [EFL] Speedup jhbuild with disable running autogen.sh
2047 https://bugs.webkit.org/show_bug.cgi?id=143369
2049 Reviewed by Gyuyoung Kim.
2051 * efl/jhbuild.modules:
2053 2015-04-01 Alexey Proskuryakov <ap@apple.com>
2055 filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
2056 https://bugs.webkit.org/show_bug.cgi?id=143282
2058 Reviewed by Daniel Bates.
2060 * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
2062 2015-04-01 Alexey Proskuryakov <ap@apple.com>
2064 When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
2065 https://bugs.webkit.org/show_bug.cgi?id=143240
2066 rdar://problem/19990425
2068 Reviewed by Tim Horton.
2070 * DumpRenderTree/mac/LayoutTestHelper.m:
2071 (colorProfileURLForDisplay):
2072 (saveDisplayColorProfiles):
2073 Gracefully handle it when the current profile cannot be retrieved, fixing at
2074 least one case when LayoutTestHelper couldn't start.
2076 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2077 (Manager._set_up_run):
2078 (Manager._force_pixel_tests_if_needed):
2079 * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
2080 * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
2081 Return and check an error from start_helper().
2083 2015-04-01 Brent Fulgham <bfulgham@apple.com>
2085 [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
2086 https://bugs.webkit.org/show_bug.cgi?id=143321
2088 Reviewed by Alexey Proskuryakov.
2090 * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
2092 2015-04-01 Enrica Casucci <enrica@apple.com>
2094 Injected bundle messages should be at the page level.
2095 https://bugs.webkit.org/show_bug.cgi?id=143283
2097 Reviewed by Alexey Proskuryakov.
2099 Updating WebKitTestRunner to use the new page level messaging.
2100 The author of this patch is Tim Horton, I just finished it.
2102 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2103 (WTR::EventSendingController::mouseDown):
2104 (WTR::EventSendingController::mouseUp):
2105 (WTR::EventSendingController::mouseMoveTo):
2106 (WTR::EventSendingController::leapForward):
2107 (WTR::EventSendingController::scheduleAsynchronousClick):
2108 (WTR::EventSendingController::keyDown):
2109 (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2110 (WTR::EventSendingController::mouseScrollBy):
2111 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2112 (WTR::EventSendingController::continuousMouseScrollBy):
2113 (WTR::EventSendingController::addTouchPoint):
2114 (WTR::EventSendingController::updateTouchPoint):
2115 (WTR::EventSendingController::setTouchModifier):
2116 (WTR::EventSendingController::setTouchPointRadius):
2117 (WTR::EventSendingController::touchStart):
2118 (WTR::EventSendingController::touchMove):
2119 (WTR::EventSendingController::touchEnd):
2120 (WTR::EventSendingController::touchCancel):
2121 (WTR::EventSendingController::clearTouchPoints):
2122 (WTR::EventSendingController::releaseTouchPoint):
2123 (WTR::EventSendingController::cancelTouchPoint):
2124 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2125 (WTR::InjectedBundle::didReceiveMessage):
2126 (WTR::InjectedBundle::didReceiveMessageToPage):
2127 (WTR::InjectedBundle::done):
2128 (WTR::InjectedBundle::outputText):
2129 (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2130 (WTR::InjectedBundle::postAddChromeInputField):
2131 (WTR::InjectedBundle::postRemoveChromeInputField):
2132 (WTR::InjectedBundle::postFocusWebView):
2133 (WTR::InjectedBundle::postSetBackingScaleFactor):
2134 (WTR::InjectedBundle::postSetWindowIsKey):
2135 (WTR::InjectedBundle::postSimulateWebNotificationClick):
2136 (WTR::InjectedBundle::postSetAddsVisitedLinks):
2137 (WTR::InjectedBundle::setGeolocationPermission):
2138 (WTR::InjectedBundle::setMockGeolocationPosition):
2139 (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2140 (WTR::InjectedBundle::setUserMediaPermission):
2141 (WTR::InjectedBundle::setCustomPolicyDelegate):
2142 (WTR::InjectedBundle::setHidden):
2143 (WTR::InjectedBundle::setCacheModel):
2144 (WTR::InjectedBundle::shouldProcessWorkQueue):
2145 (WTR::InjectedBundle::processWorkQueue):
2146 (WTR::InjectedBundle::queueBackNavigation):
2147 (WTR::InjectedBundle::queueForwardNavigation):
2148 (WTR::InjectedBundle::queueLoad):
2149 (WTR::InjectedBundle::queueLoadHTMLString):
2150 (WTR::InjectedBundle::queueReload):
2151 (WTR::InjectedBundle::queueLoadingScript):
2152 (WTR::InjectedBundle::queueNonLoadingScript):
2153 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2154 (WTR::TestRunner::setHandlesAuthenticationChallenges):
2155 (WTR::TestRunner::setAuthenticationUsername):
2156 (WTR::TestRunner::setAuthenticationPassword):
2157 (WTR::TestRunner::secureEventInputIsEnabled):
2158 (WTR::TestRunner::setBlockAllPlugins):
2159 * WebKitTestRunner/TestController.cpp:
2160 (WTR::TestController::createWebViewWithOptions):
2161 (WTR::TestController::resetStateToConsistentValues):
2162 (WTR::TestController::didReceivePageMessageFromInjectedBundle):
2163 (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
2164 * WebKitTestRunner/TestController.h:
2165 * WebKitTestRunner/TestInvocation.cpp:
2166 (WTR::TestInvocation::invoke):
2167 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2169 2015-04-01 Commit Queue <commit-queue@webkit.org>
2171 Unreviewed, rolling out r182174 and r182177.
2172 https://bugs.webkit.org/show_bug.cgi?id=143314
2174 Try to correct EWS failures (Requested by bfulgham on
2177 Reverted changesets:
2179 "Python SCM should be able to retrieve untracked files"
2180 https://bugs.webkit.org/show_bug.cgi?id=143135
2181 http://trac.webkit.org/changeset/182174
2183 "[buildbot] clean-build script should remove untracked files
2184 and revert local changes too"
2185 https://bugs.webkit.org/show_bug.cgi?id=142400
2186 http://trac.webkit.org/changeset/182177
2188 2015-04-01 Alex Christensen <achristensen@webkit.org>
2190 [Content Extensions] Properly handle regexes that match everything.
2191 https://bugs.webkit.org/show_bug.cgi?id=143281
2193 Reviewed by Benjamin Poulain.
2195 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2196 (TestWebKitAPI::testRequest):
2197 (TestWebKitAPI::makeBackend):
2198 (TestWebKitAPI::TEST_F):
2199 Removed duplicate code and added test.
2201 2015-03-31 Benjamin Poulain <bpoulain@apple.com>
2203 Content Extensions: split the state machines to minimize prefix states
2204 https://bugs.webkit.org/show_bug.cgi?id=143253
2206 Reviewed by Alex Christensen.
2208 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2209 (TestWebKitAPI::TEST_F):
2210 (TestWebKitAPI::testPatternStatus):
2212 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com>
2214 Clean up Identifier factories to clarify the meaning of StringImpl*
2215 https://bugs.webkit.org/show_bug.cgi?id=143146
2217 Reviewed by Filip Pizlo.
2219 Simple API tests for StringImpl are added.
2221 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2222 (TestWebKitAPI::TEST):
2224 2015-03-31 Csaba Osztrogonác <ossy@webkit.org>
2226 [EFL] Add AArch64 builder and tester bot to build.webkit.org
2227 https://bugs.webkit.org/show_bug.cgi?id=143092
2229 Reviewed by Gyuyoung Kim.
2231 * BuildSlaveSupport/build.webkit.org-config/config.json:
2232 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2234 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2236 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
2238 [buildbot] clean-build script should remove untracked files and revert local changes too
2239 https://bugs.webkit.org/show_bug.cgi?id=142400
2241 Reviewed by Ryosuke Niwa.
2243 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
2244 A helper routine SCM.discard_untracked_files is added for that purpose.
2246 * BuildSlaveSupport/clean-build:
2247 (main): Making call to Scripts/clean-webkit
2248 * Scripts/clean-webkit: Added.
2249 (main): Revert changes and delete untracked files.
2250 * Scripts/webkitpy/common/checkout/scm/scm.py:
2251 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
2252 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2253 (SCMTest._shared_test_discard_untracked_files):
2254 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
2256 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
2258 Python SCM should be able to retrieve untracked files
2259 https://bugs.webkit.org/show_bug.cgi?id=143135
2261 Reviewed by Ryosuke Niwa.
2263 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
2264 Ignored files may be included or not in this list according boolean passed to the function.
2266 * Scripts/webkitpy/common/checkout/scm/git.py:
2267 (Git.untracked_files):
2268 * Scripts/webkitpy/common/checkout/scm/scm.py:
2269 (SCM.untracked_files):
2270 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2271 (SCMTest._shared_test_untracked_files):
2272 (test_untracked_files):
2273 (GitSVNTest.test_untracked_files):
2274 * Scripts/webkitpy/common/checkout/scm/svn.py:
2275 (SVN.untracked_files):
2277 2015-03-30 Alex Christensen <achristensen@webkit.org>
2279 [Content Extensions] Correctly handle regular expressions matching everything
2280 https://bugs.webkit.org/show_bug.cgi?id=143235
2282 Reviewed by Benjamin Poulain.
2284 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2285 (TestWebKitAPI::checkCompilerError):
2286 (TestWebKitAPI::TEST_F):
2287 Test ContentExtensionErrors.
2289 2015-03-30 Alexey Proskuryakov <ap@apple.com>
2291 DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
2292 https://bugs.webkit.org/show_bug.cgi?id=143241
2293 rdar://problem/20351297
2295 Reviewed by Mark Lam.
2297 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2299 2015-03-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2301 [CMake][EFL] Remove redundant library link and include path
2302 https://bugs.webkit.org/show_bug.cgi?id=143221
2304 Reviewed by Csaba Osztrogonác.
2306 * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
2308 2015-03-30 Sam Weinig <sam@webkit.org>
2310 [Content Extensions] Flesh out the UserContentExtensionStore
2311 https://bugs.webkit.org/show_bug.cgi?id=143123
2313 Reviewed by Benjamin Poulain.
2315 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2316 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
2317 Add tests for _WKUserContentExtensionStore.
2319 2015-03-30 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
2321 Update install-dependencies Fedora packages after r181624
2322 https://bugs.webkit.org/show_bug.cgi?id=143215
2324 Add json-glib, libv4l, openssl and pulseaudio development packages to
2325 the Fedora list providing we need them to build WebKit dependencies
2326 for this distribution.
2328 Reviewed by Philippe Normand.
2330 * gtk/install-dependencies:
2332 2015-03-30 Commit Queue <commit-queue@webkit.org>
2334 Unreviewed, rolling out r182119.
2335 https://bugs.webkit.org/show_bug.cgi?id=143196
2337 problem with syntax (Requested by youenn on #webkit).
2341 "[buildbot] clean-build script should remove untracked files
2342 and revert local changes too"
2343 https://bugs.webkit.org/show_bug.cgi?id=142400
2344 http://trac.webkit.org/changeset/182119
2346 2015-03-30 Benjamin Poulain <benjamin@webkit.org>
2348 Start the features.json files
2349 https://bugs.webkit.org/show_bug.cgi?id=143207
2351 Reviewed by Darin Adler.
2353 I kept the style checking light. We'll have to figure
2354 what is the best format for each field.
2356 * Scripts/webkitpy/style/checker.py:
2357 (CheckerDispatcher._create_checker):
2358 * Scripts/webkitpy/style/checkers/jsonchecker.py:
2359 (JSONContributorsChecker.check):
2360 (JSONFeaturesChecker):
2361 (JSONFeaturesChecker.check):
2363 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr>
2365 [buildbot] clean-build script should remove untracked files and revert local changes too
2366 https://bugs.webkit.org/show_bug.cgi?id=142400
2368 Reviewed by Ryosuke Niwa.
2370 This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
2372 * BuildSlaveSupport/clean-build:
2373 (main): Adding call to Tools/Scripts/clean-webkit.
2374 * Scripts/clean-webkit: Added.
2375 (main): Removes untracked and changed files.
2376 * Scripts/webkitpy/common/checkout/scm/git.py:
2377 (Git.untracked_files): Retrieves GIT untracked files.
2378 * Scripts/webkitpy/common/checkout/scm/scm.py:
2379 (SCM.untracked_files): Retrieves SVN untracked files.
2381 (SCM.discard_untracked_files): Deletes untracked files/folders.
2382 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2383 (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
2384 (test_untracked_files):
2385 (GitSVNTest.test_untracked_files):
2386 * Scripts/webkitpy/common/checkout/scm/svn.py:
2387 (SVN.untracked_files):
2389 2015-03-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2391 [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
2392 https://bugs.webkit.org/show_bug.cgi?id=143138
2394 Reviewed by Csaba Osztrogonác.
2396 INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
2397 be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
2399 * ImageDiff/CMakeLists.txt:
2400 Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
2401 * WebKitTestRunner/CMakeLists.txt: ditto.
2403 2015-03-27 Myles C. Maxfield <mmaxfield@apple.com>
2405 Support building WTF on Windows without Cygwin
2406 https://bugs.webkit.org/show_bug.cgi?id=143084
2408 Reviewed by Brent Fulgham.
2410 Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
2411 This patch also migrates to using File::Spec->catfile() for directory separators.
2413 * Scripts/update-webkit-dependency:
2415 * Scripts/update-webkit-support-libs:
2417 (downloadExpectedVersionNumber):
2419 (toUnixPath): Deleted.
2420 * Scripts/webkitdirs.pm:
2421 (determineSourceDir):
2422 (windowsSourceSourceDir):
2423 (windowsLibrariesDir):
2425 (checkInstalledTools):
2426 (buildVisualStudioProject):
2428 2015-03-27 Alex Christensen <achristensen@webkit.org>
2431 https://bugs.webkit.org/show_bug.cgi?id=143086
2433 Reviewed by Brent Fulgham.
2435 * Scripts/webkitdirs.pm:
2436 (buildVisualStudioProject):
2437 (runSvnUpdateAndResolveChangeLogs):
2438 Use ActivePerl-friendly perl.
2440 2015-03-27 Csaba Osztrogonác <ossy@webkit.org>
2442 URTBF after r182059 to fix the EFL build.
2444 * TestWebKitAPI/CMakeLists.txt:
2446 2015-03-26 Alexey Proskuryakov <ap@apple.com>
2448 Layout test results URL loads in WK1 but not WK2 minibrowser
2449 https://bugs.webkit.org/show_bug.cgi?id=143117
2451 Reviewed by Tim Horton.
2453 * MiniBrowser/mac/WK2BrowserWindowController.m:
2454 (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
2456 (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
2458 2015-03-26 Jer Noble <jer.noble@apple.com>
2460 Add --allowed-host support to run-webkit-tests
2461 https://bugs.webkit.org/show_bug.cgi?id=142938
2463 Reviewed by Brent Fulgham.
2465 Accept --allowed-host arguments from run-webkit-tests and pass them through to
2466 DumpRenderTree and WebKitTestRunner.
2468 Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
2469 are placed in the wrong location. The argument is compared with each tests's path, and if a
2470 relative path or a path with '..' was used, results are placed alongside the test. Take the
2471 absolute path of the --layout-test-dir argument, collapsing path components like '..'.
2473 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2475 * Scripts/webkitpy/port/base.py:
2477 (Port.allowed_hosts):
2478 * Scripts/webkitpy/port/driver.py:
2481 2015-03-26 Jer Noble <jer.noble@apple.com>
2483 [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
2484 https://bugs.webkit.org/show_bug.cgi?id=142931
2486 Reviewed by Brent Fulgham.
2488 Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
2489 over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
2490 WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
2493 To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
2494 hostname to a whitelist; requests to these hosts will allowed to proceed normally.
2496 Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
2497 injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
2498 top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
2499 the top loading frame from the page, as we do elsewhere in this class.
2501 * DumpRenderTree/TestRunner.h:
2502 (TestRunner::allowedHosts):
2503 (TestRunner::setAllowedHosts):
2504 * DumpRenderTree/mac/DumpRenderTree.mm:
2505 (initializeGlobalsFromCommandLineOptions):
2507 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2509 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2510 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2511 (WTR::InjectedBundle::didReceiveMessage):
2512 (WTR::InjectedBundle::isAllowedHost):
2513 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2514 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2515 (WTR::isAllowedHost):
2516 (WTR::InjectedBundlePage::willSendRequestForFrame):
2517 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2518 * WebKitTestRunner/Options.cpp:
2519 (WTR::handleOptionAllowedHost):
2520 (WTR::OptionsHandler::OptionsHandler):
2521 * WebKitTestRunner/Options.h:
2522 * WebKitTestRunner/TestController.cpp:
2523 (WTR::TestController::initialize):
2524 (WTR::TestController::resetStateToConsistentValues):
2525 * WebKitTestRunner/TestController.h:
2527 2015-03-26 Brady Eidson <beidson@apple.com>
2529 Apply ContentExtension actions after redirects.
2530 <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
2532 Reviewed by Alex Christensen.
2534 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2535 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
2536 which is specifically interesting to a new test.
2538 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
2540 [EFL] Disable building libseccomp on AArch64
2541 https://bugs.webkit.org/show_bug.cgi?id=143094
2543 Reviewed by Gyuyoung Kim.
2547 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
2549 [jhbuild] git should use only 1 thread for cloning jhbuild
2550 https://bugs.webkit.org/show_bug.cgi?id=143095
2552 Reviewed by Gyuyoung Kim.
2554 * jhbuild/jhbuild-wrapper:
2557 2015-03-25 Joseph Pecoraro <pecoraro@apple.com>
2559 Update prepare-ChangeLog to work with ES6 Class syntax
2560 https://bugs.webkit.org/show_bug.cgi?id=143069
2562 Reviewed by Timothy Hatcher.
2564 * Scripts/prepare-ChangeLog:
2565 (get_function_line_ranges_for_javascript):
2566 Better handle ES6 Class syntax.
2568 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2569 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2572 (DerivedClass.staticMethod):
2573 (DerivedClass.prototype.method.nestedFunctionInsideMethod):
2574 (DerivedClass.prototype.method):
2575 (DerivedClass.prototype.get getter):
2576 (namespace.MyClass):
2577 (namespace.MyClass.staticMethod):
2578 (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
2579 (namespace.MyClass.prototype.method):
2580 (namespace.MyClass.prototype.get getter):
2583 2015-03-25 Filip Pizlo <fpizlo@apple.com>
2585 Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
2586 https://bugs.webkit.org/show_bug.cgi?id=142993
2588 Reviewed by Mark Lam.
2590 Bunch of support for testing executable allocation failure.
2592 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
2594 * Scripts/run-javascriptcore-tests:
2595 (runJSCStressTests):
2596 * Scripts/run-jsc-stress-tests:
2598 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
2600 Fix Windows build from r181977.
2604 * Scripts/update-webkit-dependency:
2606 2015-03-25 Sam Weinig <sam@webkit.org>
2608 Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
2610 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2611 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2613 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
2615 Migrate update-webkit for Windows to not require Cygwin
2616 https://bugs.webkit.org/show_bug.cgi?id=143040
2618 Reviewed by Brent Fulgham.
2620 * Scripts/update-webkit-dependency:
2622 (toUnixPath): Deleted.
2623 * Scripts/webkitdirs.pm:
2625 (checkInstalledTools):
2628 2015-03-25 Sam Weinig <sam@webkit.org>
2630 [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
2631 https://bugs.webkit.org/show_bug.cgi?id=143059
2633 Reviewed by Alex Christensen.
2635 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2636 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2637 Update for new interface of compileRuleList().
2639 2015-03-25 Alex Christensen <achristensen@webkit.org>
2641 [Content Extensions] Add multi-DFA compiling and interpreting.
2642 https://bugs.webkit.org/show_bug.cgi?id=143010
2644 Reviewed by Benjamin Poulain.
2646 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2647 (TestWebKitAPI::testRequest):
2648 (TestWebKitAPI::TEST_F):
2649 Add some tests for ignore-previous-rules and large rulesets.
2651 2015-03-25 Alexey Proskuryakov <ap@apple.com>
2653 Mavericks WK1 still runs JSC tests
2654 https://bugs.webkit.org/show_bug.cgi?id=143035
2656 Reviewed by Csaba Osztrogonác.
2658 * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
2661 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
2664 2015-03-25 Commit Queue <commit-queue@webkit.org>
2666 Unreviewed, rolling out r181932.
2667 https://bugs.webkit.org/show_bug.cgi?id=143041
2669 The test fails most of the time on bots (Requested by ap on
2674 "[Content Extensions] Add multi-DFA compiling and
2676 https://bugs.webkit.org/show_bug.cgi?id=143010
2677 http://trac.webkit.org/changeset/181932
2679 2015-03-24 Alex Christensen <achristensen@webkit.org>
2681 [Content Extensions] Add multi-DFA compiling and interpreting.
2682 https://bugs.webkit.org/show_bug.cgi?id=143010
2684 Reviewed by Benjamin Poulain.
2686 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2687 (TestWebKitAPI::testRequest):
2688 (TestWebKitAPI::TEST_F):
2689 Add some tests for ignore-previous-rules and large rulesets.
2691 2015-03-24 Benjamin Poulain <bpoulain@apple.com>
2693 Make URL filter patterns matching consistent and add a simple canonicalization step
2694 https://bugs.webkit.org/show_bug.cgi?id=142998
2696 Reviewed by Alex Christensen.
2698 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2700 2015-03-24 Csaba Osztrogonác <ossy@webkit.org>
2702 [EFL] Add OpenWebRTC in jhbuild
2703 https://bugs.webkit.org/show_bug.cgi?id=142778
2705 Reviewed by Gyuyoung Kim.
2707 Original patch by Philippe Normand <pnormand@igalia.com>
2709 * efl/install-dependencies: Dependencies for OpenWebRTC.
2710 * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
2711 the openwebrtc gst plugins.
2713 2015-03-23 Brent Fulgham <bfulgham@apple.com>
2715 Regression(r181257): WTF_WorkQueue.Simple is flaky
2716 https://bugs.webkit.org/show_bug.cgi?id=142560
2718 Remove the check that the refCount has returned to one after the
2719 individual tasks have completed. It's too nondeterministic when
2720 the reference count will be reduced.
2722 Reviewed by Alexey Proskuryakov
2724 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2725 (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
2727 2015-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2729 [CMake][EFL] Put failure API test excutables into failure directory
2730 https://bugs.webkit.org/show_bug.cgi?id=142965
2732 Reviewed by Csaba Osztrogonác.
2734 Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
2736 * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
2737 * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
2739 2015-03-22 Benjamin Poulain <benjamin@webkit.org>
2741 CSS Selectors: fix attribute case-insensitive matching of Contain and List
2742 https://bugs.webkit.org/show_bug.cgi?id=142932
2744 Reviewed by Darin Adler.
2746 Add tests for the new features and fix some existing tests using the
2747 stringFromUTF8() utility recently added by Dhi.
2749 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2750 (TestWebKitAPI::stringFromUTF8):
2751 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2753 2015-03-22 Michael Catanzaro <mcatanzaro@igalia.com>
2755 [GTK] install-dependencies should install orc
2756 https://bugs.webkit.org/show_bug.cgi?id=142955
2758 Reviewed by Martin Robinson.
2760 Install orc, needed by openwebrtc
2762 * gtk/install-dependencies:
2764 2015-03-22 Benjamin Poulain <bpoulain@apple.com>
2766 Detect when url filter pattern with groups match the empty string
2767 https://bugs.webkit.org/show_bug.cgi?id=142930
2769 Reviewed by Sam Weinig.
2771 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2773 2015-03-22 Anders Carlsson <andersca@apple.com>
2775 _WKWebsiteDataStore should clear WebSQL databases
2776 https://bugs.webkit.org/show_bug.cgi?id=142947
2778 Reviewed by Sam Weinig.
2780 Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
2782 * MiniBrowser/mac/WK2BrowserWindowController.m:
2783 (-[WK2BrowserWindowController fetchWebsiteData:]):
2784 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2785 (-[WK2BrowserWindowController clearWebsiteData:]):
2787 2015-03-20 Mark Hahnenberg <mhahnenb@gmail.com>
2789 GCTimer should know keep track of nested GC phases
2790 https://bugs.webkit.org/show_bug.cgi?id=142675
2792 Reviewed by Darin Adler.
2794 Adds a tool to aid in parsing the GC phase timing output into a
2795 tree-like structure based on the parent-child relationships
2796 of nested GC phases.
2798 * Scripts/parse-gc-phase-timings: Added.
2801 (Timing.__unicode__):
2805 (print_timing_node):
2806 (print_timing_tree):
2810 2015-03-20 Brent Fulgham <bfulgham@apple.com>
2812 [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
2814 * Scripts/webkitpy/common/config/ews.json:
2816 2015-03-20 Philippe Normand <pnormand@igalia.com>
2818 [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
2819 https://bugs.webkit.org/show_bug.cgi?id=142867
2821 Rubber-stamped by Csaba Osztrogon.
2823 * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
2824 a fixed revision for the openwebrtc-gst-plugins.
2826 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
2828 Unreviewed build fix. Don't try to report stats for all benchmarks.
2829 Just report the geometric mean of preferred means.
2831 * Scripts/run-jsc-benchmarks:
2833 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
2835 run-jsc-benchmarks should only report preferred mean
2836 https://bugs.webkit.org/show_bug.cgi?id=142874
2838 Reviewed by Geoffrey Garen.
2840 Just collect statistics for the preferred mean.
2842 * Scripts/run-jsc-benchmarks:
2844 2015-03-19 Alex Christensen <achristensen@webkit.org>
2846 [Content Extensions] Test regular expression parse failures.
2847 https://bugs.webkit.org/show_bug.cgi?id=142872
2849 Reviewed by Benjamin Poulain.
2851 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2852 (TestWebKitAPI::testPatternStatus):
2853 (TestWebKitAPI::TEST_F):
2854 Added tests for each parsing status.
2856 2015-03-19 Alex Christensen <achristensen@webkit.org>
2858 Fix API tests after r181754.
2860 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2861 (TestWebKitAPI::testRequest):
2863 2015-03-19 Brady Eidson <beidson@apple.com>
2865 Part of content extensions should apply css selectors
2866 https://bugs.webkit.org/show_bug.cgi?id=142604
2868 Reviewed by Alex Christensen.
2870 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2871 (WebCore::ContentExtensions::operator<<):
2873 2015-03-19 Brent Fulgham <bfulgham@apple.com>
2875 [Win] Activate tests on EWS
2876 https://bugs.webkit.org/show_bug.cgi?id=142850
2878 Reviewed by Alexey Proskuryakov.
2880 * Scripts/webkitpy/common/config/ews.json: Add me as
2881 the EWS bot watcher, and activate tests.
2883 2015-03-19 Csaba Osztrogonác <ossy@webkit.org>
2885 [GTK] Fix inspector userinterface related incremental build issue
2886 https://bugs.webkit.org/show_bug.cgi?id=142849
2888 Reviewed by Carlos Garcia Campos.
2890 * Scripts/webkitdirs.pm:
2891 (shouldRemoveCMakeCache):
2893 2015-03-18 Alex Christensen <achristensen@webkit.org>
2895 [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
2896 https://bugs.webkit.org/show_bug.cgi?id=142799
2898 Reviewed by Brady Eidson.
2900 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2901 (TestWebKitAPI::testPattern):
2902 (TestWebKitAPI::TEST_F):
2903 Start testing regex failures.
2905 2015-03-18 Dhi Aurrahman <diorahman@rockybars.com>
2907 Fix StringView typos after r181525 and r181558
2908 https://bugs.webkit.org/show_bug.cgi?id=142772
2910 Reviewed by Darin Adler.
2912 Add some tests in [1] to cover the StringView::startsWith,
2913 StringView::startsWithIgnoringASCIICase, StringView::endsWith and
2914 StringView::endsWithIgnoringASCIICase implementations.
2916 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2917 (TestWebKitAPI::TEST):
2919 2015-03-18 Dana Burkart <dburkart@apple.com>
2921 Remove extraneous import to fix the build.
2925 * Scripts/webkitpy/port/driver.py:
2927 2015-03-18 Dana Burkart <dburkart@apple.com>
2929 ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
2930 https://bugs.webkit.org/show_bug.cgi?id=142547
2932 Reviewed by Alexey Proskuryakov.
2934 * Scripts/webkitpy/port/driver.py:
2935 (Driver._setup_environ_for_driver):
2937 2015-03-18 Alexey Proskuryakov <ap@apple.com>
2939 Tweak how AppleSystemFontOSSubversion default is added
2940 https://bugs.webkit.org/show_bug.cgi?id=142835
2942 Reviewed by Dan Bernstein.
2944 * DumpRenderTree/mac/DumpRenderTree.mm:
2945 (setDefaultsToConsistentValuesForTesting):
2947 2015-03-18 Dan Bernstein <mitz@apple.com>
2949 prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
2950 https://bugs.webkit.org/show_bug.cgi?id=142815
2952 Reviewed by Darin Adler.
2954 * Scripts/prepare-ChangeLog:
2955 (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
2956 quotation mark, use new variable $quotation_mark to remember what we are looking for, and
2957 keep consuming the quoted text until the matching quotation mark is reached. Emit the
2958 warning only if a line ends without a backslash before the matching quotation mark was found.
2960 2015-03-18 Joseph Pecoraro <pecoraro@apple.com>
2962 Remove unused "preprocessor" parameter to sub-CodeGenerators
2963 https://bugs.webkit.org/show_bug.cgi?id=142793
2965 Reviewed by Darin Adler.
2967 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2970 2015-03-18 Csaba Osztrogonác <ossy@webkit.org>
2972 [EFL] Bump gstreamer version to 1.4.4
2973 https://bugs.webkit.org/show_bug.cgi?id=142782
2975 Reviewed by Philippe Normand.
2977 * efl/jhbuild.modules:
2978 * efl/patches/gst-libav.patch:
2979 * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
2980 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2982 2015-03-17 Tim Horton <timothy_horton@apple.com>
2986 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2987 (WTR::InjectedBundle::platformInitialize):
2989 2015-03-17 Dean Jackson <dino@apple.com>
2991 check-webkit-style should allow "bool a : 1"
2992 https://bugs.webkit.org/show_bug.cgi?id=142794
2994 Reviewed by Brent Fulgham.
2996 We should allow member bitfields of the form:
3000 It seems that Visual Studio 8 was the last compiler that
3001 wasn't happy about not using unsigned here. We already have
3002 about 500 cases (in WebCore) where people were ignoring this rule.
3004 * Scripts/webkitpy/style/checkers/cpp.py:
3005 (check_language): Allow "bool".
3006 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
3007 (CppStyleTest.test_enum_bitfields):
3008 (CppStyleTest.test_plain_integral_bitfields):
3010 2015-03-17 Benjamin Poulain <bpoulain@apple.com>
3012 Compile character ranges targeting the same state as range check in the bytecode
3013 https://bugs.webkit.org/show_bug.cgi?id=142759
3015 Reviewed by Alex Christensen.
3017 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3018 (TestWebKitAPI::TEST_F):
3020 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
3022 W3C test parser and converter should use test importer host
3023 https://bugs.webkit.org/show_bug.cgi?id=142729
3025 Reviewed by Bem Jones-Bey.
3027 When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
3028 This enables adding more TestImporter unit testing.
3029 This patch also ensures that the git object instantiated by TestDownloader is using the
3030 same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
3032 * Scripts/webkitpy/common/system/filesystem_mock.py:
3033 (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
3034 * Scripts/webkitpy/w3c/test_downloader.py:
3035 (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
3036 (TestDownloader.checkout_test_repository): Making use of the new git function.
3037 * Scripts/webkitpy/w3c/test_importer.py:
3038 (TestImporter.find_importable_tests): Adding host as parameter to the parser.
3039 (TestImporter.import_tests): Adding host as parameter to the converter.
3040 * Scripts/webkitpy/w3c/test_importer_unittest.py:
3041 (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
3043 (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
3044 * Scripts/webkitpy/w3c/test_parser.py:
3045 (TestParser.__init__): Adding host as parameter constructor.
3047 2015-03-17 Carlos Garcia Campos <cgarcia@igalia.com>
3049 [GTK] WebKitDOM objects leaking
3050 https://bugs.webkit.org/show_bug.cgi?id=118788
3052 Reviewed by Darin Adler and Sergio Villar Senin.
3054 Update DOMObjectCache unit test to check that DOM objects are also
3055 released when new contents are loaded in the web view, and the old
3056 document is detached from the frame.
3058 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3059 (testWebKitDOMObjectCache):
3060 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3063 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
3065 W3C test importer default import folder should be LayoutTests/imported/w3c
3066 https://bugs.webkit.org/show_bug.cgi?id=142728
3068 Reviewed by Bem Jones-Bey.
3070 * Scripts/webkitpy/w3c/test_importer.py:
3071 (parse_args): Updating the default destination option value to 'imported/w3c'.
3073 2015-03-17 Philippe Normand <pnormand@igalia.com>
3075 [GTK] basic OpenWebRTC build support
3076 https://bugs.webkit.org/show_bug.cgi?id=142393
3078 Reviewed by Carlos Garcia Campos.
3080 * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
3081 is not the upstream OpenWebRTC repository. This temporary fork
3082 contains a few patches needed by WebKit for audio/video rendering.
3084 2015-03-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3086 [CMake][EFL] Build test tools only for developer mode
3087 https://bugs.webkit.org/show_bug.cgi?id=142761
3089 Reviewed by Csaba Osztrogonác.
3091 Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
3095 2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
3097 Remove never used "useLayerOnTop" bindings generator argument
3098 https://bugs.webkit.org/show_bug.cgi?id=142773
3100 Reviewed by Darin Adler.
3102 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3105 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
3107 Enable ES6 classes by default
3108 https://bugs.webkit.org/show_bug.cgi?id=142774
3110 Reviewed by Gavin Barraclough.
3112 * Scripts/webkitperl/FeatureList.pm:
3114 2015-03-16 Alexey Proskuryakov <ap@apple.com>
3116 Fix webkitpy tests after r181585.
3118 Looks like "me" cannot be anyone's email, it's a special case.
3120 * Scripts/webkitpy/common/config/contributors.json:
3122 2015-03-16 Alexey Proskuryakov <ap@apple.com>
3124 Add tolerance to WebAudio tests
3125 https://bugs.webkit.org/show_bug.cgi?id=142676
3127 Reviewed by Tim Horton.
3129 * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
3131 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3132 (TestResultWriter.create_audio_diff_and_write_result):
3133 * Scripts/webkitpy/layout_tests/models/test_failures.py:
3134 (FailureAudio.write_failure):
3135 * Scripts/webkitpy/port/base.py:
3136 (Port.do_audio_results_differ):
3137 Diff audio failures.
3139 * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
3140 tests to use real parseable WAV data, and got rid of base64, which there didn't
3141 seem to have been any reason for.
3143 2015-03-16 Alexey Proskuryakov <ap@apple.com>
3145 [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
3146 https://bugs.webkit.org/show_bug.cgi?id=142720
3148 Reviewed by Myles C. Maxfield.
3150 Activate system copies of Microsoft fonts for the current process, thus overriding
3151 any other ones that could be preferred by the system otherwise.
3153 * DumpRenderTree/mac/DumpRenderTree.mm:
3154 (activateSystemCoreWebFonts):
3156 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3157 (WTR::activateSystemCoreWebFonts):
3158 (WTR::activateFonts):
3160 2015-03-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
3162 Created Streams API watchlist
3163 https://bugs.webkit.org/show_bug.cgi?id=142684
3165 Reviewed by Benjamin Poulain.
3167 * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
3168 watchlist and added Benjamin, Youenn and me to it.
3170 2015-03-15 Benjamin Poulain <benjamin@webkit.org>
3172 CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
3173 https://bugs.webkit.org/show_bug.cgi?id=142715
3175 Reviewed by Brent Fulgham.
3177 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3178 (TestWebKitAPI::TEST):
3180 2015-03-15 Benjamin Poulain <bpoulain@apple.com>
3182 Change the exact attribute matching to be ASCII case-insensitive
3183 https://bugs.webkit.org/show_bug.cgi?id=142609
3185 Reviewed by Darin Adler.
3187 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3188 * TestWebKitAPI/Tests/WTF/StringView.cpp:
3190 2015-03-13 Youenn Fablet <youenn.fablet@crf.canon.fr>
3192 WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
3193 https://bugs.webkit.org/show_bug.cgi?id=134764
3195 Reviewed by Ryosuke Niwa.
3197 TestDownloader is introduced to download W3C tests from the official
3198 W3C tests repositories (https://github.com/w3c/web-platform-tests.git
3199 and https://github.com/w3c/csswg-test.git).
3200 TestDownloader clones the repositories and checkouts revisions of the tests
3201 defined in LayoutTests/imported/w3c/resources/TestRepositories.
3203 Similarly to https://codereview.chromium.org/148173016,
3204 TestDownloader copies part of the files based on the rules
3205 defined in LayoutTests/imported/w3c/resources/ImportExpectations.
3207 TestDownloader is used by TestImporter when no source directory is provided.
3209 * Scripts/webkitpy/w3c/test_downloader.py: Added.
3211 (TestDownloader.default_options):
3212 (TestDownloader.load_test_repositories):
3213 (TestDownloader.__init__):
3214 (TestDownloader.checkout_test_repository):
3215 (TestDownloader._init_paths_from_expectations):
3216 (TestDownloader._add_test_suite_paths):
3217 (TestDownloader._empty_directory):
3218 (TestDownloader.copy_tests):
3219 (TestDownloader.download_tests):
3220 * Scripts/webkitpy/w3c/test_importer.py:
3223 (TestImporter.__init__):
3224 (TestImporter.do_import):
3225 (TestImporter.test_downloader):
3226 (TestImporter.find_importable_tests.should_keep_subdir):
3227 (TestImporter.should_convert_test_harness_links):
3228 (TestImporter.import_tests):
3229 (TestImporter.write_import_log):
3231 2015-03-12 Alexey Proskuryakov <ap@apple.com>
3233 [Mavericks] Test snapshots are 1600x1200 on Retina devices
3234 https://bugs.webkit.org/show_bug.cgi?id=142630
3236 Reviewed by Tim Horton.
3238 * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3239 Removed an ifdef that disabled the fix on Mavericks.
3241 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
3243 Remove isWK2 cruft from webkitdirs.pm after r170426
3244 https://bugs.webkit.org/show_bug.cgi?id=142618
3246 Reviewed by Daniel Bates.
3248 * Scripts/webkitdirs.pm:
3251 2015-03-12 Alexey Proskuryakov <ap@apple.com>
3253 testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
3254 https://bugs.webkit.org/show_bug.cgi?id=138687
3256 Reviewed by Carlos Garcia Campos.
3258 Always change cookie policy from UI process, as changing it from WebProcess doesn't
3259 affect other processes.
3261 The implementation is imperfect, because the change happens asynchronously, but I
3262 don't expect it to be a problem in practice.
3264 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3265 (WTR::InjectedBundle::beginTesting):
3266 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3267 (WTR::TestRunner::setAlwaysAcceptCookies):
3268 * WebKitTestRunner/TestInvocation.cpp:
3269 (WTR::TestInvocation::invoke):
3270 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3272 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
3274 [EFL] Enable building EFL 1.13 with NEON support
3275 https://bugs.webkit.org/show_bug.cgi?id=142619
3277 Reviewed by Gyuyoung Kim.
3279 * efl/jhbuild.modules:
3281 2015-03-11 Alex Christensen <achristensen@webkit.org>
3283 [Content Extensions] Add resource type and load type triggers.
3284 https://bugs.webkit.org/show_bug.cgi?id=142422
3286 Reviewed by Benjamin Poulain.
3288 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3289 (TestWebKitAPI::testRequest):
3290 (TestWebKitAPI::mainDocumentRequest):
3291 (TestWebKitAPI::TEST_F):
3292 (TestWebKitAPI::testURL): Deleted.
3294 2015-03-10 Sam Weinig <sam@webkit.org>
3296 Allow adding a button in input elements for auto fill related functionality
3297 <rdar://problem/19782066>
3298 https://bugs.webkit.org/show_bug.cgi?id=142564
3300 Reviewed by Anders Carlsson.
3302 * WebKitTestRunner/TestController.cpp:
3303 (WTR::TestController::createOtherPage):
3304 (WTR::TestController::createWebViewWithOptions):
3305 Update for new callback.
3307 2015-03-11 Benjamin Poulain <bpoulain@apple.com>
3309 Add basic support for BOL and EOL assertions to the URL Filter parser
3310 https://bugs.webkit.org/show_bug.cgi?id=142568
3312 Reviewed by Alex Christensen.
3314 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3315 (TestWebKitAPI::TEST_F):
3317 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
3319 [GTK] Add support for handling TLS errors to MiniBrowser
3320 https://bugs.webkit.org/show_bug.cgi?id=142576
3322 Reviewed by Sergio Villar Senin.
3324 It's useful for testing TLS errors handling itself, but also to
3325 allow ignoring TLS errors when testing.
3327 * MiniBrowser/gtk/BrowserWindow.c:
3328 (webViewLoadFailedWithTLSerrors):
3329 (browserWindowConstructed):
3331 2015-03-11 Myles C. Maxfield <mmaxfield@apple.com>
3333 Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
3334 https://bugs.webkit.org/show_bug.cgi?id=142569
3336 Reviewed by David Hyatt.
3338 Test Optional::valueOrCompute().
3340 * TestWebKitAPI/Tests/WTF/Optional.cpp:
3341 (TestWebKitAPI::TEST):
3343 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
3345 [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
3346 https://bugs.webkit.org/show_bug.cgi?id=126688
3348 Reviewed by Gustavo Noronha Silva.
3350 * CMakeLists.txt: Build testing tools only for developer builds,
3351 but MiniBrowser when ENABLE_MINIBROWSER option is ON.
3352 * MiniBrowser/gtk/CMakeLists.txt: Only add
3353 -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
3354 and add a rule to install the MiniBrowser.
3355 * MiniBrowser/gtk/main.c:
3356 (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
3359 2015-03-11 Brent Fulgham <bfulgham@apple.com>
3361 Add some DateMath tests to TestWebKitAPI
3362 https://bugs.webkit.org/show_bug.cgi?id=142565
3364 Reviewed by Alexey Proskuryakov.
3366 * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
3367 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
3368 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
3369 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
3370 * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
3372 2015-03-10 Brent Fulgham <bfulgham@apple.com>
3374 Regression(r181257): WTF_WorkQueue.Simple is flaky
3375 https://bugs.webkit.org/show_bug.cgi?id=142560
3377 Unreviewed attempt to improve test stability.
3379 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
3380 the WorkQueue a little later to redue flakiness.
3382 2015-03-10 Myles C. Maxfield <mmaxfield@apple.com>
3384 Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
3385 https://bugs.webkit.org/show_bug.cgi?id=142555
3387 Reviewed by Simon Fraser.
3389 * DumpRenderTree/mac/DumpRenderTree.mm:
3390 (setDefaultsToConsistentValuesForTesting):
3391 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3392 (WTR::InjectedBundle::platformInitialize):
3394 2015-03-10 Alex Christensen <achristensen@webkit.org>
3396 Use unsigned for HashSet size.
3397 https://bugs.webkit.org/show_bug.cgi?id=142518
3399 Reviewed by Benjamin Poulain.
3401 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3402 (TestWebKitAPI::TEST):
3403 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3404 (TestWebKitAPI::testInitialCapacity):
3405 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3406 (TestWebKitAPI::TEST):
3408 2015-03-10 Daniel Bates <dabates@apple.com>
3410 [iOS] Add WebKitSystemInterface for iOS 8.2
3411 https://bugs.webkit.org/show_bug.cgi?id=142505
3413 Rubber-stamped by Anders Carlsson.
3415 Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
3416 I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
3417 copy-webkitlibraries-to-product-directory in r181286.
3419 * Scripts/copy-webkitlibraries-to-product-directory:
3421 2015-03-10 Benjamin Poulain <bpoulain@apple.com>
3423 Extend URL filter's Term definition to support groups/subpatterns
3424 https://bugs.webkit.org/show_bug.cgi?id=142519
3426 Reviewed by Alex Christensen.
3428 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3429 (TestWebKitAPI::testURL):
3431 2015-03-06 Jer Noble <jer.noble@apple.com>
3433 Add an option to run-webkit-tests to override the LayoutTests/ directory
3434 https://bugs.webkit.org/show_bug.cgi?id=142418
3436 Reviewed by David Kilzer.
3438 Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
3439 directory. The base port will parse the options during initialization and store the override
3440 location if present. layout_tests_dir() will return this overridden location if set.
3442 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3444 * Scripts/webkitpy/port/base.py:
3446 (Port.layout_tests_dir):
3448 2015-03-09 Martin Robinson <mrobinson@igalia.com>
3450 [CMake] Enable WorkQueue tests for CMake ports
3451 https://bugs.webkit.org/show_bug.cgi?id=142473
3453 Reviewed by Darin Adler.
3455 * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
3456 the list of source files.
3457 * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
3458 to the list of include directories for EFL.
3460 2015-03-09 David Kilzer <ddkilzer@apple.com>
3462 Attempt to fix timeouts on iOS Simulator layout tests
3464 * Scripts/webkitpy/port/ios.py:
3465 (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
3466 Simulator end after the first 50 tests time out. Some analysis
3467 this past weekend shows that the 'Booted' status in the output
3468 of `xcrun simctl list` is not sufficient (and watching the test
3469 run shows that SpringBoard hasn't fully started to the point
3470 where it's displaying icons on the home screen). The workaround
3471 until we have a better fix is to add an arbitrary timeout to let
3472 SpringBoard finish launching. In practice, 15 seconds is
3473 probably enough, but 30 seconds should nearly always work.
3475 2015-03-09 Per Arne Vollan <peavo@outlook.com>
3477 Unreviewed. Add myself as a committer.
3479 * Scripts/webkitpy/common/config/contributors.json:
3481 2015-03-09 David Kilzer <ddkilzer@apple.com>
3483 Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
3485 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3486 (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
3487 an expectation that will fail if we hit the race condition.
3488 This test is inherently racy and will deadlock if the first job
3489 for queue2 takes the mutex lock before the second job for
3492 2015-03-08 Brent Fulgham <bfulgham@apple.com>
3494 [Win] WTF::WorkQueue does not balance ref/deref properly
3495 https://bugs.webkit.org/show_bug.cgi?id=142471
3497 Reviewed by Antti Koivisto.
3499 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3500 (TestWebKitAPI::TEST): Check that the refcount is correct.
3502 2015-03-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3504 Do not show passing test result on output of EFL layout test
3505 https://bugs.webkit.org/show_bug.cgi?id=142380
3507 Reviewed by Darin Adler.
3509 To show passing tests has caused inconvenience when we detect problem tests
3510 in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
3511 in order not to show passing tests in the output of EFL layout test.
3513 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3514 (RunWebKitTests.start):
3516 2015-03-08 Brent Fulgham <bfulgham@apple.com>
3518 Unreviewed build fix.
3520 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3521 (TestWebKitAPI::TEST): Remove two unused variables.
3523 2015-03-08 Brent Fulgham <bfulgham@apple.com>
3525 Add some WorkQueue tests to TestWebKitAPI
3526 https://bugs.webkit.org/show_bug.cgi?id=142447
3528 Reviewed by Sam Weinig.
3530 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3531 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3532 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3533 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
3534 (TestWebKitAPI::simpleTest):
3535 (TestWebKitAPI::longTest):
3536 (TestWebKitAPI::thirdTest):
3537 (TestWebKitAPI::finishedTests):
3538 (TestWebKitAPI::TEST):
3539 (TestWebKitAPI::longTest2):
3541 2015-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
3543 Remove willDestroyFrame in WKBundlePageLoaderClient
3544 https://bugs.webkit.org/show_bug.cgi?id=142389
3546 Reviewed by Anders Carlsson.
3548 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3549 (WTR::InjectedBundlePage::InjectedBundlePage):
3551 2015-03-07 Brent Fulgham <bfulgham@apple.com>
3553 [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
3554 https://bugs.webkit.org/show_bug.cgi?id=142433
3556 Reviewed by Darin Adler.
3558 Include more TestWebKitAPI tests when building for Windows. Also
3559 fix a build error in MetaAllocator.cpp caused by one of the
3560 Microsoft headers #defining 'small'.
3562 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3563 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3564 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3566 2015-03-06 Sam Weinig <sam@webkit.org>
3568 [Content Extensions] Move compiling of content extensions to the UIProcess
3569 https://bugs.webkit.org/show_bug.cgi?id=142402
3571 Reviewed by Benjamin Poulain.
3573 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3574 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
3575 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3576 (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
3577 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3578 (TestWebKitAPI::TEST_F):
3579 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
3580 Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
3583 2015-03-06 Brent Fulgham <bfulgham@apple.com>
3585 [Win] Correct Windows build.
3587 Rubberstamped by Michael Saboff
3589 * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
3592 2015-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
3594 [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
3595 https://bugs.webkit.org/show_bug.cgi?id=142385
3597 Reviewed by Sergio Villar Senin.
3599 Use stack allocated GMainLoopSources to make sure they are
3600 cancelled automatically if the test finishes before they have
3603 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3604 (testWebViewSyncRequestOnMaxConns):
3606 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
3608 Remove Mountain Lion libraries since ML isn't supported
3609 https://bugs.webkit.org/show_bug.cgi?id=142332
3611 Reviewed by Darin Adler.
3613 * Scripts/copy-webkitlibraries-to-product-directory:
3615 2015-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
3617 Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
3618 https://bugs.webkit.org/show_bug.cgi?id=142083
3620 Reviewed by Simon Fraser.
3622 Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
3624 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3625 (WebPlatformTestServer._copy_webkit_test_files):
3627 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
3629 setup-git-clone fails due to the failure to download python-irclib-0.4.8
3630 https://bugs.webkit.org/show_bug.cgi?id=141946
3632 Reviewed by Ryosuke Niwa.
3634 Check in ircbot.py and irclib.py to avoid network problems in the future.
3636 * Scripts/webkitpy/common/net/irc/ircbot.py:
3637 * Scripts/webkitpy/thirdparty/__init__.py:
3638 (AutoinstallImportHook.find_module):
3639 (AutoinstallImportHook._install_irc): Deleted.
3640 * Scripts/webkitpy/thirdparty/__init___unittest.py:
3641 (ThirdpartyTest.test_imports):
3642 * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
3643 * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
3644 * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
3646 2015-03-06 David Kilzer <ddkilzer@apple.com>
3648 Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
3650 See also fix to config.json in r181097.
3652 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3653 (WebKitBuildbot): Add missing "WK2" to the names of the perf
3656 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
3658 run-jsc-stress-tests should determine the architecture from ELF binaries
3659 https://bugs.webkit.org/show_bug.cgi?id=142335
3661 Reviewed by Darin Adler.
3663 * Scripts/run-jsc-stress-tests:
3665 2015-03-05 David Kilzer <ddkilzer@apple.com>
3667 [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
3668 <http://webkit.org/b/142226>
3670 Reviewed by Darin Adler.
3672 * Scripts/webkitpy/port/ios.py:
3673 (IOSSimulatorPort.default_baseline_search_path): Switch the
3674 TestExpectations order of ios-simulator-wk2 from this:
3675 ios-simulator-wk2, wk2, ios-simulator
3677 ios-simulator-wk2, ios-simualtor, wk2
3679 2015-03-05 Brent Fulgham <bfulgham@apple.com>
3681 [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
3682 https://bugs.webkit.org/show_bug.cgi?id=142370
3684 Reviewed by Dean Jackson.
3686 * Scripts/webkitdirs.pm:
3687 (buildVisualStudioProject): Tell MSBuild to output log files to two separate
3688 logs, one for warnings, the other for errors.
3689 * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
3690 into the standard BuildOutput.htm document.
3692 2015-03-05 David Kilzer <ddkilzer@apple.com>