Use more C++17
[WebKit-https.git] / Tools / ChangeLog
1 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         Use more C++17
4         https://bugs.webkit.org/show_bug.cgi?id=185176
5
6         Reviewed by JF Bastien.
7
8         * DumpRenderTree/mac/Configurations/Base.xcconfig:
9         * ImageDiff/cg/Configurations/Base.xcconfig:
10         * MiniBrowser/Configurations/Base.xcconfig:
11         * MobileMiniBrowser/Configurations/Base.xcconfig:
12         * TestWebKitAPI/Configurations/Base.xcconfig:
13         * WebKitTestRunner/Configurations/Base.xcconfig:
14
15 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
16
17         [WinCairo] Enable WebKit build by default
18         https://bugs.webkit.org/show_bug.cgi?id=185141
19
20         Reviewed by Per Arne Vollan.
21
22         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
23         WebKitForwardingHeaders because config.h includes a header of WK2.
24
25         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
26         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
27
28 2018-05-21  Jer Noble  <jer.noble@apple.com>
29
30         Complete fix for enabling modern EME by default
31         https://bugs.webkit.org/show_bug.cgi?id=185770
32         <rdar://problem/40368220>
33
34         Reviewed by Eric Carlson.
35
36         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
37
38 2018-05-18  Christopher Reid  <chris.reid@sony.com>
39
40         Unreviewed, add myself as a WebKit committer.
41
42         * Scripts/webkitpy/common/config/contributors.json:
43
44 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
45
46         Unreviewed, rolling out r222967.
47
48         It's not ready yet
49
50         Reverted changeset:
51
52         "[GTK][WPE] Add API to configure and enable resource load
53         statistics"
54         https://bugs.webkit.org/show_bug.cgi?id=177943
55         https://trac.webkit.org/changeset/222967
56
57 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
58
59         [GTK] MiniBrowser crashes when loading twice quickly
60         https://bugs.webkit.org/show_bug.cgi?id=185763
61
62         Reviewed by Michael Catanzaro.
63
64         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
65         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
66         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
67         leaked, it will crash when scheduled if the window has already been destroyed.
68
69         * MiniBrowser/gtk/BrowserWindow.c:
70         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
71
72 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
73
74         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
75         https://bugs.webkit.org/show_bug.cgi?id=185624
76         <rdar://problem/39111626>
77
78         Reviewed by Chris Dumez.
79
80         Modified expectation to make test more robust as cookies can be returned in different orders.
81
82         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
83         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
84         (TEST):
85
86 2018-05-18  Commit Queue  <commit-queue@webkit.org>
87
88         Unreviewed, rolling out r231982.
89         https://bugs.webkit.org/show_bug.cgi?id=185793
90
91         Caused layout test failures (Requested by realdawei on
92         #webkit).
93
94         Reverted changeset:
95
96         "Complete fix for enabling modern EME by default"
97         https://bugs.webkit.org/show_bug.cgi?id=185770
98         https://trac.webkit.org/changeset/231982
99
100 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
101
102         Handle failure to extend sandbox gracefully
103         https://bugs.webkit.org/show_bug.cgi?id=185779
104         <rdar://problem/40316349>
105
106         Unreviewed, fix test results.
107
108         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
109         (TEST_F):
110
111 2018-05-18  Jer Noble  <jer.noble@apple.com>
112
113         Complete fix for enabling modern EME by default
114         https://bugs.webkit.org/show_bug.cgi?id=185770
115         <rdar://problem/40368220>
116
117         Reviewed by Eric Carlson.
118
119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
120
121 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
122
123         Handle failure to extend sandbox gracefully
124         https://bugs.webkit.org/show_bug.cgi?id=185779
125         <rdar://problem/40316349>
126
127         Reviewed by Brent Fulgham.
128
129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
130         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
131         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
132         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
133         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
134         (MediaCaptureSimulateFailedSandbox::SetUp):
135         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
136         (TEST_F):
137         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
138
139 2018-05-18  Daniel Bates  <dabates@apple.com>
140
141         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
142         https://bugs.webkit.org/show_bug.cgi?id=185774
143
144         Reviewed by Andy Estes.
145
146         For now, the script debug-safari is not supported for WebKit for iOS. To
147         fix this we differentiate between the Apple Mac port and Apple embedded
148         ports.
149
150         * Scripts/webkitdirs.pm:
151         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
152         (isAppleMacWebKit): Added.
153         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
154         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
155         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
156         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
157         (runSafari): Ditto.
158         (runMiniBrowser): Ditto.
159         (debugMiniBrowser): Ditto.
160         (runWebKitTestRunner): Ditto.
161         (debugWebKitTestRunner): Ditto.
162
163 2018-05-18  Antoine Quint  <graouts@apple.com>
164
165         [Web Animations] Turn Web Animations with CSS integration on for test runners
166         https://bugs.webkit.org/show_bug.cgi?id=184819
167         <rdar://problem/39597337>
168
169         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
170
171         * DumpRenderTree/TestOptions.cpp:
172         (TestOptions::TestOptions):
173         * DumpRenderTree/TestOptions.h:
174         * DumpRenderTree/mac/DumpRenderTree.mm:
175         (runTest):
176         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
177         * WebKitTestRunner/TestController.cpp:
178         (WTR::TestController::resetPreferencesToConsistentValues):
179         (WTR::updateTestOptionsFromTestHeader):
180         * WebKitTestRunner/TestOptions.cpp:
181         (WTR::TestOptions::TestOptions):
182         (WTR::isLegacyAnimationEngineTestPath): Deleted.
183         * WebKitTestRunner/TestOptions.h:
184
185 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
186
187         [Win][MiniBrowser] Create MainWindow even in transparent mode
188         https://bugs.webkit.org/show_bug.cgi?id=185597
189
190         Reviewed by Per Arne Vollan.
191
192         The current implementations doesn't create the MainWindow in
193         transparent mode. The screenshot is in Bug 58300.
194
195         There were three problems:
196         - Can't control the WebView. ie. going backward and forward.
197         - Can't quit the program.
198         - It makes implementation complicated.
199
200         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
201         even in the transparent mode.
202         * MiniBrowser/win/WinMain.cpp:
203         (wWinMain): Create the main window even in the transparent mode.
204
205 2018-05-18  Antoine Quint  <graouts@apple.com>
206
207         [Web Animations] Turn Web Animations with CSS integration on for test runners
208         https://bugs.webkit.org/show_bug.cgi?id=184819
209         <rdar://problem/39597337>
210
211         Reviewed by Jon Lee.
212
213         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
214         integration flag on.
215
216         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
217         comment directly at the top of the file since test runners now set the flag on by default
218         and a dedicated directory exists for tests that need to run with this flag off.
219
220         * DumpRenderTree/TestOptions.cpp:
221         (TestOptions::TestOptions):
222         * DumpRenderTree/TestOptions.h:
223         * DumpRenderTree/mac/DumpRenderTree.mm:
224         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
225         (runTest):
226         * WebKitTestRunner/TestController.cpp:
227         (WTR::TestController::resetPreferencesToConsistentValues):
228         (WTR::updateTestOptionsFromTestHeader):
229         * WebKitTestRunner/TestOptions.cpp:
230         (WTR::isLegacyAnimationEngineTestPath):
231         (WTR::TestOptions::TestOptions):
232         * WebKitTestRunner/TestOptions.h:
233
234 2018-05-17  Nan Wang  <n_wang@apple.com>
235
236         AX: [macOS] Expose the primary screen height through AX API
237         https://bugs.webkit.org/show_bug.cgi?id=185742
238
239         Reviewed by Chris Fleizach.
240
241         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
242         (attributesOfElement):
243         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
244         (WTR::attributesOfElement):
245
246 2018-05-17  Commit Queue  <commit-queue@webkit.org>
247
248         Unreviewed, rolling out r231912.
249         https://bugs.webkit.org/show_bug.cgi?id=185750
250
251         It is prompting the user when there is no WPT changes
252         (Requested by bmac on #webkit).
253
254         Reverted changeset:
255
256         "Export changes to web-platform-test as part of the webkit-
257         patch upload workflow"
258         https://bugs.webkit.org/show_bug.cgi?id=184914
259         https://trac.webkit.org/changeset/231912
260
261 2018-05-17  Valerie R Young  <valerie@bocoup.com>
262
263         test262/Runner.pm: expand $INC to find webkitdirs.pm
264         https://bugs.webkit.org/show_bug.cgi?id=185739
265
266         Reviewed by Michael Saboff.
267
268         * Scripts/test262/Runner.pm:
269         (getBuildPath):
270
271 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
272
273         [WPE] Implement and enable FULLSCREEN_API
274         https://bugs.webkit.org/show_bug.cgi?id=185676
275
276         Reviewed by Žan Doberšek.
277
278         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
279         (testWebViewFullScreen):
280
281 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
282
283         Export changes to web-platform-test as part of the webkit-patch upload workflow
284         https://bugs.webkit.org/show_bug.cgi?id=184914
285
286         Reviewed by Youenn Fablet.
287
288         * Scripts/webkitpy/tool/commands/upload.py:
289         (Upload):
290         (CreateBug.execute):
291         (WPTChangeExport):
292         * Scripts/webkitpy/tool/steps/__init__.py:
293         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
294         (WPTChangeExport):
295         (WPTChangeExport.options):
296         (WPTChangeExport.run):
297         * Scripts/webkitpy/w3c/common.py:
298         * Scripts/webkitpy/w3c/test_exporter.py:
299         (WebPlatformTestExporter):
300         (WebPlatformTestExporter.__init__):
301         (WebPlatformTestExporter.username):
302         (WebPlatformTestExporter.token):
303         (WebPlatformTestExporter._github):
304         (WebPlatformTestExporter._wpt_fork_branch_github_url):
305         (WebPlatformTestExporter._wpt_fork_remote):
306         (WebPlatformTestExporter._wpt_fork_push_url):
307         (WebPlatformTestExporter._git):
308         (WebPlatformTestExporter._branch_name):
309         (WebPlatformTestExporter._public_branch_name):
310         (WebPlatformTestExporter.has_wpt_changes):
311         (WebPlatformTestExporter._create_patch):
312         (WebPlatformTestExporter.create_git_patch):
313         (WebPlatformTestExporter._prompt_for_token):
314         (WebPlatformTestExporter._prompt_for_username):
315         (WebPlatformTestExporter._ensure_username_and_token):
316         (WebPlatformTestExporter._validate_and_save_token):
317         (WebPlatformTestExporter.push_to_wpt_fork):
318         (WebPlatformTestExporter.make_pull_request):
319         (WebPlatformTestExporter.delete_local_branch):
320         (parse_args):
321         (TestExporter): Deleted.
322         (TestExporter.__init__): Deleted.
323         (TestExporter._ensure_wpt_repository): Deleted.
324         (TestExporter._fetch_wpt_repository): Deleted.
325         (TestExporter._ensure_new_branch_name): Deleted.
326         (TestExporter.download_and_commit_patch): Deleted.
327         (TestExporter.clean): Deleted.
328         (TestExporter.create_branch_with_patch): Deleted.
329         (TestExporter.push_to_wpt_fork): Deleted.
330         (TestExporter.make_pull_request): Deleted.
331         (TestExporter.create_wpt_pull_request): Deleted.
332         (TestExporter.delete_local_branch): Deleted.
333         (TestExporter.create_git_patch): Deleted.
334         (TestExporter.create_upload_remote_if_needed): Deleted.
335         (TestExporter.do_export): Deleted.
336         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
337         (TestExporterTest.test_export):
338         (TestExporterTest.test_export_with_specific_branch):
339         (TestExporterTest):
340         (TestExporterTest.test_export_interactive_mode):
341         (TestExporterTest.test_export_invalid_token):
342         (TestExporterTest.test_export_wrong_token):
343
344 2018-05-17  Valerie R Young  <valerie@bocoup.com>
345
346         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
347         https://bugs.webkit.org/show_bug.cgi?id=185650
348
349         Reviewed by Michael Saboff.
350
351         First, use jsc from CLI arg, then try to use webkit-build-directory,
352         if that doesn't work, look for jsc in the $PATH
353
354         * Scripts/test262/Runner.pm:
355         (processCLI):
356         (getBuildPath):
357         (runTest):
358
359 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
360
361         Test262-Runner: Adds a --timeout option
362         https://bugs.webkit.org/show_bug.cgi?id=185696
363
364         Reviewed by Michael Saboff.
365
366         The timeout option is used to set a timeout execution in ms for each test run in JSC.
367         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
368         * Scripts/test262/Runner.pm:
369         (processCLI):
370         (runTest):
371
372 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
373
374         Test262-Runner: Set timer for each test run
375         https://bugs.webkit.org/show_bug.cgi?id=185692
376
377         Reviewed by Michael Saboff.
378
379         Sets a high resolution timer for each execution call of JSC, reporting
380         the time in the results report to allow identifying slow tests.
381         * Scripts/test262/Runner.pm:
382         (main):
383         (processFile):
384         (runTest):
385         (processResult):
386
387 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
388
389         Add support for Intl NumberFormat formatToParts
390         https://bugs.webkit.org/show_bug.cgi?id=185375
391
392         Reviewed by Yusuke Suzuki.
393
394         Add flag for NumberFormat formatToParts.
395
396         * Scripts/webkitperl/FeatureList.pm:
397         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
398
399 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
400
401         [Win] Use C++17 in MSVC
402         https://bugs.webkit.org/show_bug.cgi?id=185232
403
404         Reviewed by Alex Christensen.
405
406         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
407         conflicts with ::byte defined in Windows' header.
408
409         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
410         (WindowedPluginTest::WindowedPluginTest):
411         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
412         (logEventProc):
413         (stringEvent):
414         (AccessibilityController::winNotificationReceived):
415         * DumpRenderTree/win/TextInputController.cpp:
416         (markedRangeCallback):
417         (firstRectForCharacterRangeCallback):
418         (selectedRangeCallback):
419         * DumpRenderTree/win/TextInputController.h:
420         * DumpRenderTree/win/TextInputControllerWin.cpp:
421         (TextInputController::markedRange):
422         (TextInputController::firstRectForCharacterRange):
423         (TextInputController::selectedRange):
424
425 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
426
427         Session cookies aren't reliably set when using default WKWebSiteDataStore
428         https://bugs.webkit.org/show_bug.cgi?id=185624
429         <rdar://problem/39111626>
430
431         Reviewed by Geoffrey Garen.
432
433         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
434
435         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
436         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
437         (TEST):
438
439 2018-05-16  Valerie R Young  <valerie@bocoup.com>
440
441         test262/Runner.pm: save to supplied expectation file if supplied
442         https://bugs.webkit.org/show_bug.cgi?id=185660
443
444         Reviewed by Michael Saboff.
445
446         * Scripts/test262/Runner.pm:
447         (processCLI):
448         (main):
449
450 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
451
452         Unreviewed, rolling out r231763.
453
454         The test added with this change is failing an assertion.
455
456         Reverted changeset:
457
458         "NSEvent event trackers don't work from WebKitTestRunner"
459         https://bugs.webkit.org/show_bug.cgi?id=185383
460         https://trac.webkit.org/changeset/231763
461
462 2018-05-15  David Kilzer  <ddkilzer@apple.com>
463
464         TestWebKitAPI: Fix warnings found by new clang compiler
465         <https://webkit.org/b/185631>
466
467         Reviewed by Michael Catanzaro.
468
469         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
470         (TestWebKitAPI::TEST):
471         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
472         (TestWebKitAPI::TEST):
473         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
474         (TestWebKitAPI::TEST):
475         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
476         (TestWebKitAPI::TEST):
477         - Add #pragma statements to ignore the new
478           -Wself-assign-overloaded warning and to ignore
479           this as an unknown warning on older clang versions.  We want
480           to keep these self assigments as this code is designed to test
481           that use case.
482
483         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
484         (TestWebKitAPI::didFindStringMatches):
485         - Replace the "rect = rect;" statement that was used to avoid an
486           unused variable warning with two expectations.
487
488         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
489         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
490         - Switch from -integerValue to -unsignedIntegerValue when
491           comparing against _WKRectEdgeAll since it's an enum declared
492           as an NSUInteger.
493
494 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
495
496         Unreviewed, rolling out r230749
497
498         This did not work as desired.
499
500         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
501         (TestWebKitAPI::TEST):
502
503 2018-05-15  Antoine Quint  <graouts@apple.com>
504
505         [Web Animations] Expose Web Animations CSS integration as an experimental feature
506         https://bugs.webkit.org/show_bug.cgi?id=185647
507
508         Reviewed by Dean Jackson.
509
510         Rename the Web Animations CSS integration flag.
511
512         * DumpRenderTree/TestOptions.cpp:
513         (TestOptions::TestOptions):
514         * DumpRenderTree/TestOptions.h:
515         * DumpRenderTree/mac/DumpRenderTree.mm:
516         (setWebPreferencesForTestOptions):
517         * WebKitTestRunner/TestController.cpp:
518         (WTR::TestController::resetPreferencesToConsistentValues):
519         (WTR::updateTestOptionsFromTestHeader):
520         * WebKitTestRunner/TestOptions.h:
521         (WTR::TestOptions::hasSameInitializationOptions const):
522
523 2018-05-14  Brady Eidson  <beidson@apple.com>
524
525         Add an API test to guard against regressions while re-entering setDefersLoading:.
526         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
527
528         Reviewed by Chris Dumez.
529
530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
531         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
532         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
533         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
534         (-[DefersScheme initWithBytes:]):
535         (-[DefersScheme webView:startURLSchemeTask:]):
536         (-[DefersScheme webView:stopURLSchemeTask:]):
537         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
538         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
539         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
540         (-[DoubleDefersLoadingPlugIn dealloc]):
541
542 2018-05-14  Daniel Bates  <dabates@apple.com>
543
544         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
545         https://bugs.webkit.org/show_bug.cgi?id=185599
546         <rdar://problem/22493890>
547
548         Reviewed by Simon Fraser.
549
550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
551         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
552         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
553         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
554         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
555         (TestWebKitAPI::TEST):
556         * TestWebKitAPI/ios/set-timeout-function.html: Added.
557
558 2018-05-14  Valerie R Young  <valerie@bocoup.com>
559
560         test262/Runner.pm: small bugs in CLI and error codes
561         https://bugs.webkit.org/show_bug.cgi?id=185629
562
563         Reviewed by Michael Saboff.
564
565         Fix two commandline args with use '-f', correct
566         error code of failures.
567
568         * Scripts/test262/Runner.pm:
569         (processCLI):
570         (main):
571
572 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
573
574         Disable API tests that time out after pointer poisioning was disabled.
575         https://bugs.webkit.org/show_bug.cgi?id=185586
576
577         Unreviewed test gardening.
578
579         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
580         (TestWebKitAPI::TEST):
581         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
582         (TestWebKitAPI::TEST):
583         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
584         (TestWebKitAPI::TEST):
585         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
586         (TestWebKitAPI::TEST):
587
588 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
589
590         Test262-Runner: Fix RegExp for capturing tests metadata"
591         https://bugs.webkit.org/show_bug.cgi?id=185622
592
593         Reviewed by Michael Saboff.
594
595         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
596         both LF and CRLF forms.
597
598         The fix also allows the runner to capture the proper results from two specific files using CR and
599         CRLF line terminators. They are updated in the expectations file.
600         * Scripts/test262/Runner.pm:
601         (parseData):
602
603 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
604
605         NSEvent event trackers don't work from WebKitTestRunner
606         https://bugs.webkit.org/show_bug.cgi?id=185383
607         rdar://problem/40025045
608
609         Reviewed by Simon Fraser.
610
611         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
612         NSEvent swipe tracking is used for webkit swipe navigation.
613
614         * WebKitTestRunner/mac/EventSenderProxy.mm:
615         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
616
617 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
618
619         Test262 Runner should search for the Debug JSC by default
620         https://bugs.webkit.org/show_bug.cgi?id=185562
621
622         Reviewed by Michael Saboff.
623
624         The Test262 Runner is now searching for the Debug build of JSC by
625         default, not the Release build.
626
627         This fix allows a similar call from the previous runner, making
628         it compatible with the current build bot configuration parameters.
629
630         This patch also adds some minor improvements the verbose mode output.
631
632         * Scripts/test262/Runner.pm:
633         (processCLI):
634         (main):
635         (getBuildPath):
636         (processResult):
637
638 2018-05-11  Charles Vazac  <cvazac@gmail.com>
639
640         Runtime feature flag for Server-Timing
641         https://bugs.webkit.org/show_bug.cgi?id=184758
642
643         Reviewed by Youenn Fablet.
644
645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
646         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
647
648 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
649
650         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
651         https://bugs.webkit.org/show_bug.cgi?id=185418
652
653         Reviewed by Alex Christensen.
654
655         All WK1 related code should be moved into MiniBrowser for the preparation
656         of Bug 184770.
657
658         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
659
660         * MiniBrowser/win/Common.cpp:
661         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
662         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
663         * MiniBrowser/win/Common.h: Added.
664         * MiniBrowser/win/MiniBrowser.cpp:
665         (MiniBrowser::init): Moved the initilization code from wWinMain.
666         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
667         * MiniBrowser/win/MiniBrowser.h:
668         (MiniBrowser::setCacheFolder): Changed to a private method.
669         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
670         * MiniBrowser/win/WinMain.cpp:
671         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
672
673 2018-05-11  Brady Eidson  <beidson@apple.com>
674
675         Make sure history navigations reuse the existing process when necessary.
676         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
677
678         Reviewed by Ryosuke Niwa.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
681
682 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
683
684         [JSC][GLIB] Add introspectable alternatives to functions using vargars
685         https://bugs.webkit.org/show_bug.cgi?id=185508
686
687         Reviewed by Michael Catanzaro.
688
689         Add test cases for the new API.
690
691         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
692         (testJSCFunction):
693         (testJSCObject):
694
695 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
696
697         [Build Bot] Restore configuration options to the Test262 Runner
698
699         During the switch from the previous Test262 runner to the new one,
700         a call for an extra configurations options got removed.
701
702         This call is important to inform the script to find the debug or
703         release build of JSC. It's being restored in this patch.
704
705         https://bugs.webkit.org/show_bug.cgi?id=185513
706
707         Reviewed by Yusuke Suzuki.
708
709         * BuildSlaveSupport/build.webkit.org-config/steps.py:
710         (RunTest262Tests):
711
712 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
713
714         REGRESSION (r230998): Cannot stream API test output
715         https://bugs.webkit.org/show_bug.cgi?id=185090
716
717         Reviewed by Ryosuke Niwa.
718
719         Change run-api-tests so that the stdout and stderr of a test will be printed
720         before it's result. If -v is passed, the output of single test runs will be
721         streamed. 
722
723         * Scripts/webkitpy/api_tests/run_api_tests.py:
724         (run): Use print_timestamps flag.
725         (parse_args): Add timestamps option to print timestamps in the log.
726         * Scripts/webkitpy/api_tests/runner.py:
727         (Runner): Add running status.
728         (Runner.__init__): Add number of workers and a flag to detect if a newline
729         is needed at the beginning of a log line.
730         (Runner.run): Turn off most logging coming from server process since it is
731         not constructive for API tests.
732         (Runner.handle): Add new log message to stream stdout and stderr instead of
733         caching values until the test run finished.
734         (_Worker._run_single_test): Log stdout and stderr in real time.
735         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
736         the test.
737         (_Worker.post): Provide a post with explicitly enumerated argument names.
738         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
739         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
740         (MeteredStream.write): Allow for verbose logging without timestamps.
741         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
742         (RegularTest): Add print_timestamps flag.
743         (RegularTest.setUp):
744         (RegularTest.test_logging_not_included):
745         (VerboseTest.test_log_args):
746         (VerboseWithOutTimestamp):
747         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
748
749 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
750
751         build-webkit can erroneously warn about Xcode being too old
752         https://bugs.webkit.org/show_bug.cgi?id=185533
753
754         Reviewed by Dan Bernstein.
755
756         Don't assume the version number is always a single digit.
757
758         * Scripts/webkitdirs.pm:
759         (determineXcodeVersion):
760
761 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
762
763         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
764         https://bugs.webkit.org/show_bug.cgi?id=185528
765
766         Reviewed by Lucas Forschler.
767
768         * BuildSlaveSupport/build.webkit.org-config/factories.py:
769         (TestFactory.__init__):
770         * BuildSlaveSupport/build.webkit.org-config/steps.py:
771         (InstallWinCairoDependencies):
772
773 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
774
775         Fix some -Wstring-op-truncation warnings
776         https://bugs.webkit.org/show_bug.cgi?id=185496
777
778         Reviewed by Alex Christensen.
779
780         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
781         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
782         set the last bucket to NUL.
783
784         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
785         (TestWebKitAPI::testAtomicStringNumber):
786         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
787         (TestWebKitAPI::testStringNumberFixedPrecision):
788         (TestWebKitAPI::testStringNumberFixedWidth):
789         (TestWebKitAPI::testStringNumber):
790
791 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
792
793         [Win][MiniBrowser] Add a separate WndProc for the layered window
794         https://bugs.webkit.org/show_bug.cgi?id=185460
795
796         Reviewed by Brent Fulgham.
797
798         All WK1 related code should be moved into MiniBrowser for the
799         preparation of Bug 184770.
800
801         The layered window was using WndProc of the main window. The
802         layered window is specific only for WK1. the main window will be
803         shared among WK1 and WK2.
804
805         This change add a new WndProc for the layer window.
806
807         * MiniBrowser/win/Common.cpp:
808         (WndProc): Removed code for the layered windows.
809         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
810         * MiniBrowser/win/MiniBrowser.cpp:
811         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
812         (viewWndProc): New WndProc for the layered windows.
813         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
814         * MiniBrowser/win/MiniBrowser.h:
815         (MiniBrowser::hwnd):
816         * MiniBrowser/win/WinMain.cpp:
817         (wWinMain): Added m_viewWnd.
818
819 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
820
821         Support --verbose in run-javascriptcore-tests
822         https://bugs.webkit.org/show_bug.cgi?id=185492
823
824         Reviewed by Daniel Bates.
825
826         * Scripts/run-javascriptcore-tests:
827         (runJSCStressTests):
828
829 2018-05-10  Valerie R Young  <valerie@bocoup.com>
830
831         test262/Runner.pm: --failing-files uses results file not expectations
832         https://bugs.webkit.org/show_bug.cgi?id=185395
833
834         Reviewed by Michael Saboff.
835
836         --failing-files arg now uses results file to find failing tests
837         to rerun. It will look in the test262-results directory from whereever
838         the script is run, or a results.yaml file can be supplied via command
839         line argument.
840         --expectations arg added for suppling expectation file.
841
842         * Scripts/test262/Runner.pm:
843         (processCLI):
844         (main):
845         (loadImportFile):
846         (findAllFailing):
847
848 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
849
850         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
851         https://bugs.webkit.org/show_bug.cgi?id=185506
852
853         Reviewed by Philippe Normand.
854
855         Useful for testing and debugging.
856
857         * MiniBrowser/gtk/main.c:
858         (main):
859
860 2018-05-09  Chris Dumez  <cdumez@apple.com>
861
862         Unreviewed Windows build fix after r231622.
863
864         * DumpRenderTree/win/DumpRenderTree.cpp:
865         (enableExperimentalFeatures):
866
867 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
868
869         Update WebKit.WebsiteDataStoreCustomPaths after r231536
870         https://bugs.webkit.org/show_bug.cgi?id=185486
871         <rdar://problem/37214391>
872
873         Reviewed by Chris Dumez.
874
875         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
876
877         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
878         (TEST):
879
880 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
881
882         Test262-Runner: Improve the verbose output
883         https://bugs.webkit.org/show_bug.cgi?id=185491
884
885         Reviewed by Michael Saboff.
886
887         * Scripts/test262/Import.pm:
888         (transferFiles):
889         * Scripts/test262/Runner.pm:
890         (processResult):
891
892 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
893
894         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
895         https://bugs.webkit.org/show_bug.cgi?id=185488
896
897         Reviewed by Michael Saboff.
898
899         * Scripts/test262/Runner.pm:
900         (processCLI):
901         (getBuildPath):
902         (runTest):
903
904 2018-05-09  Richard Houle  <rhoule@apple.com>
905
906         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
907         https://bugs.webkit.org/show_bug.cgi?id=185260
908         <rdar://problem/39290394>
909
910         Reviewed by Tim Horton.
911
912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
913         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
914         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
915         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
916         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
917         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
918
919 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
920
921         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
922         https://bugs.webkit.org/show_bug.cgi?id=185481
923
924         Reviewed by Philippe Normand.
925
926         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
927
928         * Scripts/webkitpy/port/gtk.py:
929         (GtkPort.setup_environ_for_server):
930
931 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
932
933         Set build.webkit.org to use the new Test262-runner
934         https://bugs.webkit.org/show_bug.cgi?id=184933
935
936         Reviewed by Aakash Jain.
937
938         * BuildSlaveSupport/build.webkit.org-config/steps.py:
939         (RunTest262Tests):
940         (RunTest262Tests.countFailures):
941         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
942
943 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
944
945         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
946         https://bugs.webkit.org/show_bug.cgi?id=185461
947
948         Reviewed by Michael Catanzaro.
949
950         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
951
952         * gtk/jhbuild.modules:
953
954 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
955
956         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
957
958         * wpe/manifest.txt.in: Distribute the NEWS.
959
960 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
961
962         [WPE] Build cleanly with GCC 8 and ICU 60
963         https://bugs.webkit.org/show_bug.cgi?id=185462
964
965         Reviewed by Carlos Alberto Lopez Perez.
966
967         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
968         sure why this was never noticed until now or why the bots are OK.
969         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
970         * gtk/patches/glib-cast-function-type.patch: Added.
971         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
972         * wpe/patches/glib-cast-function-type.patch: Added.
973
974 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
975
976         [JSC][GTK][JSCONLY] Use capstone disassembler
977         https://bugs.webkit.org/show_bug.cgi?id=185283
978
979         Reviewed by Michael Catanzaro.
980
981         * gtk/manifest.txt.in:
982         * wpe/manifest.txt.in:
983
984 2018-05-09  Antti Koivisto  <antti@apple.com>
985
986         Add OptionSet::operator& and operator bool
987         https://bugs.webkit.org/show_bug.cgi?id=185306
988
989         Reviewed by Anders Carlsson.
990
991         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
992         (TestWebKitAPI::TEST):
993
994 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
995
996         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
997         https://bugs.webkit.org/show_bug.cgi?id=185340
998
999         Reviewed by Tim Horton.
1000
1001         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
1002         non-empty text in a contenteditable.
1003
1004         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1005         (TestWebKitAPI::TEST):
1006
1007 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1008
1009         test262/Runner.pm: create results dir for results of test262 run
1010         https://bugs.webkit.org/show_bug.cgi?id=185392
1011
1012         Reviewed by Michael Saboff.
1013
1014         New directory test262-results created from where ever script is
1015         called.
1016
1017         * Scripts/test262/Runner.pm:
1018         (processCLI):
1019
1020 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1021
1022         test262/Runner.pm: lower number of processes per core
1023         https://bugs.webkit.org/show_bug.cgi?id=185426
1024
1025         Reviewed by Michael Saboff.
1026
1027         * Scripts/test262/Runner.pm:
1028         (getProcesses):
1029
1030 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
1031
1032         Test262-Runner: Add base Perl UnicodeData
1033         https://bugs.webkit.org/show_bug.cgi?id=185444
1034
1035         Reviewed by Michael Saboff.
1036
1037         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
1038         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
1039
1040 2018-05-08  Daniel Bates  <dabates@apple.com>
1041
1042         Add tests to ensure that the Strong Password appearance is removed on form reset
1043         https://bugs.webkit.org/show_bug.cgi?id=185440
1044
1045         Reviewed by Ryosuke Niwa.
1046
1047         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
1048         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
1049         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1050         (TEST):
1051
1052 2018-05-08  Daniel Bates  <dabates@apple.com>
1053
1054         Resign Strong Password appearance when text field value changes
1055         https://bugs.webkit.org/show_bug.cgi?id=185433
1056         <rdar://problem/39958508>
1057
1058         Reviewed by Ryosuke Niwa.
1059
1060         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
1061         when the field has the Strong Password button and its value changes.
1062
1063         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1064         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1065         (TEST):
1066
1067 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
1068
1069         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
1070         https://bugs.webkit.org/show_bug.cgi?id=185365
1071
1072         Reviewed by Saam Barati.
1073         
1074         Make it possible to measure compile times.
1075         
1076         Rolling back in after fixing cloop builds.
1077
1078         * Scripts/run-jsc-benchmarks:
1079
1080 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1081
1082         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
1083         https://bugs.webkit.org/show_bug.cgi?id=185414
1084
1085         Reviewed by Tim Horton.
1086
1087         Adjust a test expectation to check that the resulting DOM contains an attachment element,
1088         anchor element, and another attachment element in that order. This ensures that the test
1089         still passes, even after the anchor element is followed by a line break.
1090
1091         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1092         (TestWebKitAPI::TEST):
1093
1094 2018-05-08  Commit Queue  <commit-queue@webkit.org>
1095
1096         Unreviewed, rolling out r231491.
1097         https://bugs.webkit.org/show_bug.cgi?id=185434
1098
1099         Setting the Created key on a cookie does not work yet, due a
1100         bug in CFNetwork (Requested by ggaren on #webkit).
1101
1102         Reverted changeset:
1103
1104         "[WKHTTPCookieStore getAllCookies] returns inconsistent
1105         creation time"
1106         https://bugs.webkit.org/show_bug.cgi?id=185041
1107         https://trac.webkit.org/changeset/231491
1108
1109 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1110
1111         test262/Runner.pm: move input files to JSTests/test262
1112         https://bugs.webkit.org/show_bug.cgi?id=185389
1113
1114         Reviewed by Michael Saboff.
1115
1116         * Scripts/test262/Runner.pm:
1117         (processCLI):
1118
1119 2018-05-08  Chris Dumez  <cdumez@apple.com>
1120
1121         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
1122
1123         * Scripts/webkitpy/performance_tests/perftest.py:
1124         (PerfTest):
1125
1126 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1127
1128         Unreviewed, rolling out r231468.
1129
1130         Broke the CLoop build
1131
1132         Reverted changeset:
1133
1134         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
1135         any abstract values"
1136         https://bugs.webkit.org/show_bug.cgi?id=185365
1137         https://trac.webkit.org/changeset/231468
1138
1139 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
1140
1141         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
1142         https://bugs.webkit.org/show_bug.cgi?id=185041
1143         <rdar://problem/34684214>
1144
1145         Reviewed by Geoffrey Garen.
1146
1147         Add API test Coverage.
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1150         (TEST):
1151
1152 2018-05-08  Chris Dumez  <cdumez@apple.com>
1153
1154         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1155
1156         * Scripts/webkitpy/performance_tests/perftest.py:
1157         (PerfTest):
1158
1159 2018-05-08  Chris Dumez  <cdumez@apple.com>
1160
1161         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1162
1163         * Scripts/webkitpy/performance_tests/perftest.py:
1164         (PerfTest):
1165
1166 2018-05-07  Chris Dumez  <cdumez@apple.com>
1167
1168         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
1169
1170         * Scripts/webkitpy/performance_tests/perftest.py:
1171         (PerfTest):
1172
1173 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
1174
1175         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
1176         https://bugs.webkit.org/show_bug.cgi?id=185365
1177
1178         Reviewed by Saam Barati.
1179         
1180         Make it possible to measure compile times.
1181
1182         * Scripts/run-jsc-benchmarks:
1183
1184 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
1185
1186         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
1187         https://bugs.webkit.org/show_bug.cgi?id=185390
1188
1189         Reviewed by Michael Saboff.
1190
1191         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
1192
1193 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
1194
1195         Check for com.apple.datamigrator before declaring simulators booted
1196         https://bugs.webkit.org/show_bug.cgi?id=185315
1197         <rdar://problem/39986261>
1198
1199         Reviewed by David Kilzer.
1200
1201         * Scripts/webkitdirs.pm:
1202         (waitUntilProcessNotRunning): Wait until a process is not found.
1203         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
1204         a simulator booted.
1205         * Scripts/webkitpy/common/system/executive_mock.py:
1206         (MockExecutive2.__init__): Define _running_pids.
1207         * Scripts/webkitpy/xcode/simulated_device.py:
1208         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
1209         declaring that devices have been booted, increase the timeout since data migration will frequently
1210         take longer than 60 seconds, especially with multiple simulators booting.
1211         (SimulatedDeviceManager.swap): Ditto.
1212         (SimulatedDeviceManager):
1213         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
1214         processes running.
1215
1216 2018-05-07  Daniel Bates  <dabates@apple.com>
1217
1218         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
1219         https://bugs.webkit.org/show_bug.cgi?id=185054
1220         <rdar://problem/39773209>
1221
1222         Reviewed by Ryosuke Niwa.
1223
1224         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
1225
1226         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
1227         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
1228         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
1229         tests for the port.
1230
1231         * Scripts/webkitpy/port/mac.py:
1232         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
1233         have Apple Additions.
1234         * Scripts/webkitpy/port/mac_unittest.py:
1235         (MacTest.test_factory_with_future_version): Added.
1236         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
1237         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
1238         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
1239         is absent.
1240
1241 2018-05-07  Brian Burg  <bburg@apple.com>
1242
1243         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1244         https://bugs.webkit.org/show_bug.cgi?id=184861
1245         <rdar://problem/39153768>
1246
1247         Reviewed by Timothy Hatcher.
1248
1249         Add a new test that checks whether a new process is used for navigation when
1250         an Inspector is shown. Also check that the behavior reverts to normal after
1251         the Inspector has been closed.
1252
1253         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1254
1255 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1256
1257         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
1258         https://bugs.webkit.org/show_bug.cgi?id=185289
1259         <rdar://problem/35756912>
1260
1261         Reviewed by Tim Horton and Darin Adler.
1262
1263         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
1264         sessions.
1265
1266         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1267         (TestWebKitAPI::TEST):
1268
1269 2018-05-04  Timothy Hatcher  <timothy@apple.com>
1270
1271         Deprecate legacy WebView and friends
1272         https://bugs.webkit.org/show_bug.cgi?id=185279
1273         rdar://problem/33268700
1274
1275         Reviewed by Tim Horton.
1276
1277         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
1278         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
1279
1280 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1281
1282         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
1283         https://bugs.webkit.org/show_bug.cgi?id=185314
1284
1285         Reviewed by Michael Saboff.
1286
1287         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
1288
1289 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
1290
1291         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
1292         https://bugs.webkit.org/show_bug.cgi?id=184196
1293         <rdar://problem/39054481>
1294
1295         Reviewed by Tim Horton.
1296
1297         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
1298         earlier than 11.3. Also re-enables these tests.
1299
1300         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1301         (TestWebKitAPI::TEST):
1302         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
1303         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
1304
1305 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
1306
1307         Text shaping in the simple path is flipped in the y direction
1308         https://bugs.webkit.org/show_bug.cgi?id=185062
1309         <rdar://problem/39778678>
1310
1311         Reviewed by Simon Fraser.
1312
1313         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
1314
1315         * Scripts/webkitpy/common/config/contributors.json:
1316
1317 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
1318
1319         Test262-Runner: place the processCLI inside the main call
1320         https://bugs.webkit.org/show_bug.cgi?id=185304
1321
1322         Reviewed by Michael Saboff.
1323
1324         * Scripts/test262/Runner.pm:
1325         (main):
1326
1327 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1328
1329         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
1330         https://bugs.webkit.org/show_bug.cgi?id=174730
1331
1332         Reviewed by Michael Catanzaro.
1333
1334         Update unit tests to check that User-Agent header is included in HTTP download requests.
1335
1336         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1337         (testDownloadRemoteFile):
1338         (testWebViewDownloadURI):
1339         (testPolicyResponseDownload):
1340         (testPolicyResponseDownloadCancel):
1341         (testDownloadMIMEType):
1342         (testContextMenuDownloadActions):
1343
1344 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
1345
1346         [WinCairo] Test archive must use Python zipfile, just like build product.
1347         https://bugs.webkit.org/show_bug.cgi?id=185265
1348
1349         Reviewed by Per Arne Vollan.
1350
1351         * BuildSlaveSupport/test-result-archive:
1352         (archive_test_results):
1353         Copy over Win32-oriented archiving logic from built-product-archive.
1354
1355 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
1356
1357         cleanup modules usage for the Test262-Runner
1358         https://bugs.webkit.org/show_bug.cgi?id=185263
1359
1360         Reviewed by Michael Saboff.
1361
1362         * Scripts/test262-runner:
1363         * Scripts/test262/Runner.pm:
1364         (processCLI):
1365
1366 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1367
1368         test262/Runner.pm: minor fixes
1369         https://bugs.webkit.org/show_bug.cgi?id=185250
1370
1371         Reviewed by Michael Saboff.
1372
1373         Add comments, change output and fix bug: unintended interpolation
1374         of filename when running jsc.
1375
1376         * Scripts/test262/Runner.pm:
1377         (processCLI):
1378         (main):
1379         (runTest):
1380
1381 2018-05-03  Chris Dumez  <cdumez@apple.com>
1382
1383         Load hangs if the WebProcess fails to launch
1384         https://bugs.webkit.org/show_bug.cgi?id=185225
1385         <rdar://problem/38249058>
1386
1387         Reviewed by Geoff Garen.
1388
1389         Add API test coverage.
1390
1391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1392         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
1393         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
1394         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
1395         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1396         (TEST):
1397
1398 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
1399
1400         [WinCairo] Add JSC test bots
1401         https://bugs.webkit.org/show_bug.cgi?id=185234
1402
1403         Reviewed by Per Arne Vollan.
1404
1405         * BuildSlaveSupport/build.webkit.org-config/config.json:
1406         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1407         (RunJavaScriptCoreTests.start):
1408
1409 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1410
1411         WebKit should send fake macOS user agent to docs.google.com
1412         https://bugs.webkit.org/show_bug.cgi?id=185165
1413
1414         Reviewed by Carlos Garcia Campos.
1415
1416         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1417         (TestWebKitAPI::TEST):
1418
1419 2018-05-03  Valerie R Young  <valerie@bocoup.com>
1420
1421         test262/Runner.pm: performance improvements
1422         https://bugs.webkit.org/show_bug.cgi?id=185202
1423
1424         Reviewed by Michael Saboff.
1425
1426         Batch the tests by the number of processes, and give each process
1427         a file to save results to to avoid threading. Do not parallelize
1428         when running small sets of tests.
1429
1430         * Scripts/test262/Runner.pm:
1431         (processCLI):
1432         (main):
1433         (processFile):
1434         (processResult):
1435
1436 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
1437
1438         Unreviewed, rolling out r231253.
1439
1440         The API test added with this change is crashing on the bots.
1441
1442         Reverted changeset:
1443
1444         "Web Inspector: opt out of process swap on navigation if a Web
1445         Inspector frontend is connected"
1446         https://bugs.webkit.org/show_bug.cgi?id=184861
1447         https://trac.webkit.org/changeset/231253
1448
1449 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1450
1451         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
1452         https://bugs.webkit.org/show_bug.cgi?id=183348
1453
1454         Reviewed by Michael Catanzaro.
1455
1456         Add a test case to reproduce the crash.
1457
1458         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1459         (testWebViewCloseQuickly):
1460         (beforeAll):
1461
1462 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
1463
1464         Can't copy and paste URLs that have no title into Mail (macOS)
1465         https://bugs.webkit.org/show_bug.cgi?id=185205
1466         <rdar://problem/36352406>
1467
1468         Reviewed by Tim Horton.
1469
1470         Added test to verify behavior when copying and pasting a URL without a title.
1471
1472         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1473         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1474         (TestWebKitAPI::TEST):
1475
1476 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1477
1478         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
1479         https://bugs.webkit.org/show_bug.cgi?id=184699
1480
1481         Unreviewed follow-up fix after r231230.
1482
1483         * Scripts/generate-jsc-bundle:
1484         (generate_wrapper_script): Quote the arguments passed to jsc.
1485
1486 2018-05-02  Brian Burg  <bburg@apple.com>
1487
1488         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
1489         https://bugs.webkit.org/show_bug.cgi?id=184861
1490         <rdar://problem/39153768>
1491
1492         Reviewed by Ryosuke Niwa.
1493
1494         Add a new test that checks whether a new process is used for navigation when
1495         an Inspector is shown. Also check that the behavior reverts to normal after
1496         the Inspector has been closed.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1499
1500 2018-05-02  Valerie R Young  <valerie@bocoup.com>
1501
1502         test262/Runner.pm: save summary to file
1503         https://bugs.webkit.org/show_bug.cgi?id=185200
1504
1505         Reviewed by Michael Saboff.
1506
1507         * Scripts/test262/Runner.pm:
1508         (processCLI):
1509         (main):
1510         (summarizeResults):
1511
1512 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1513
1514         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
1515         https://bugs.webkit.org/show_bug.cgi?id=184699
1516
1517         Reviewed by Gustavo Noronha Silva.
1518
1519         This adds a new step for the GTK 64-bit release build bot and the
1520         GTK 32-bit release build&test bot.
1521
1522         This step will be run as one of the lasts ones (after the product
1523         is built) and will execute the script generate-jsc-bundle.
1524         This script will take care of creating a JSC bundle and uploading
1525         it to a server defined on a configuration file that has to be
1526         deployed on the bots with the required server data and credentials
1527         for this upload.
1528
1529         In this case, the built products should then be accessible at
1530         <https://webkitgtk.org/jsc-built-products>. But the implementation
1531         is not tied to any specific server. All the details about where
1532         to upload the file is done in configuration file that is kept
1533         private on each bot outside of the WebKit source tree.
1534
1535         The script also supports generating a JSC bundle locally and not
1536         uploading it anywhere. This is the default mode of running.
1537         The remote upload will only be activated if a --remote-config-file
1538         parameter is passed (which is done from the buildbot config)
1539
1540         * BuildSlaveSupport/build.webkit.org-config/config.json:
1541         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1542         (BuildFactory):
1543         (BuildFactory.__init__):
1544         (TestFactory):
1545         (TestFactory.__init__):
1546         (BuildAndGenerateJSCBundleFactory):
1547         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
1548         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1549         (GenerateJSCBundle):
1550         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1551         * Scripts/generate-jsc-bundle: Added.
1552         (ldd_get_libs_and_interpreter):
1553         (generate_readme):
1554         (generate_wrapper_script):
1555         (copy_and_remove_rpath):
1556         (createJSCBundle):
1557         (sha256sum):
1558         (uploadJSCBundle):
1559         (main):
1560
1561 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1562
1563         PSON: Make WebKitTestRunner work with process swap on navigation turned on
1564         https://bugs.webkit.org/show_bug.cgi?id=185111
1565
1566         Reviewed by Chris Dumez.
1567
1568         Add the basic support for running layout tests with process-swap-on-navigation turned on.
1569
1570         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
1571         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
1572
1573         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
1574         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
1575         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
1576         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
1577
1578         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1579         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
1580         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
1581         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
1582         beginTesting with BegingTestingMode::Resume when this boolean is set.
1583         (WTR::InjectedBundle::didReceiveMessageToPage):
1584         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
1585         bundle after a process swap on navigation.
1586         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1587         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1588         (WTR::InjectedBundlePage::dump):
1589         (WTR::InjectedBundlePage::frameDidChangeLocation):
1590         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1591         (WTR::TestRunner::TestRunner):
1592         (WTR::TestRunner::shouldDumpPixels const): Added.
1593         (WTR::TestRunner::setDumpPixels): Added.
1594         (WTR::TestRunner::dumpAsText):
1595         (WTR::TestRunner::whatToDump const): Added.
1596         (WTR::TestRunner::setWhatToDump): Added.
1597         (WTR::TestRunner::waitUntilDone):
1598         (WTR::TestRunner::setWaitUntilDone): Added.
1599         (WTR::TestRunner::shouldWaitUntilDone): Added.
1600         (WTR::TestRunner::notifyDone):
1601         (WTR::TestRunner::forceImmediateCompletion):
1602         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
1603         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
1604         (WTR::TestRunner::setAudioResult):
1605         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1606         (WTR::TestRunner::dumpChildFramesAsText):
1607         (WTR::TestRunner::dumpDOMAsWebArchive):
1608         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
1609         (WTR::TestRunner::whatToDump const): Moved to cpp.
1610         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
1611         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
1612         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
1613         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
1614         * WebKitTestRunner/TestInvocation.cpp:
1615         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
1616         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
1617         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
1618         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
1619         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
1620         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
1621         started as a result of a process swap on navigation (m_startedTesting is true).
1622         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
1623         support initializing the injected bundle in a process swapped after navigation and set/get messages for
1624         the states which must persist across process swaps within a test.
1625         * WebKitTestRunner/TestInvocation.h:
1626         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1627         * Tools/WebKitTestRunner/WhatToDump.h:
1628         (WTR::WhatToDump): Added.
1629
1630 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
1631
1632         Auto save the results for Test262
1633         https://bugs.webkit.org/show_bug.cgi?id=184926
1634
1635         Reviewed by Michael Saboff.
1636
1637         * Scripts/test262/Runner.pm:
1638         (processCLI):
1639         (main):
1640         (parseError):
1641         (processResult):
1642         (summarizeResults):
1643         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
1644
1645 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
1646
1647         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
1648         https://bugs.webkit.org/show_bug.cgi?id=185164
1649
1650         Reviewed by David Kilzer.
1651
1652         * Scripts/webkitpy/common/system/executive.py:
1653         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
1654         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
1655
1656 2018-05-01  Chris Dumez  <cdumez@apple.com>
1657
1658         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
1659         https://bugs.webkit.org/show_bug.cgi?id=184918
1660         <rdar://problem/39705516>
1661
1662         Reviewed by Wenson Hsieh.
1663
1664         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
1665         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
1666         asynchronously because we ask the client if it is OK to do the load and the policy
1667         delegates are asynchronous nowadays.
1668
1669         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1670         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
1671         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1672         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1673         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
1674         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
1675         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
1676
1677 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
1678
1679         [WinCairo] Align buildbot test stages with AppleWin.
1680         https://bugs.webkit.org/show_bug.cgi?id=185094
1681
1682         Reviewed by Brent Fulgham.
1683
1684         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1685         (TestFactory.__init__):
1686         Do run API tests, don't run dashboard tests.
1687
1688         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1689         (RunUnitTests):
1690         Call run-api-tests with Python, not Perl (bugfix for r230998).
1691
1692         * Scripts/webkitpy/port/win.py:
1693         (WinPort.environment_for_api_tests):
1694         Retrieve necessary Windows environment variables.
1695
1696 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
1697
1698         [MediaStream] remove WK1 support
1699         https://bugs.webkit.org/show_bug.cgi?id=185136
1700
1701         Reviewed by Youenn Fablet.
1702
1703         * DumpRenderTree/mac/UIDelegate.mm:
1704         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
1705
1706 2018-05-01  Chris Dumez  <cdumez@apple.com>
1707
1708         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
1709         https://bugs.webkit.org/show_bug.cgi?id=185157
1710
1711         Reviewed by Geoffrey Garen.
1712
1713         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
1714         common configuration and should therefore be the configuration we test by default.
1715
1716         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1717         (WTR::InjectedBundlePage::decidePolicyForResponse):
1718
1719 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
1720
1721         WebAssembly: add support for stream APIs - JavaScript API
1722         https://bugs.webkit.org/show_bug.cgi?id=183442
1723
1724         Reviewed by Yusuke Suzuki and JF Bastien.
1725
1726         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1727
1728 2018-04-30  Mark Lam  <mark.lam@apple.com>
1729
1730         Apply PtrTags to the MetaAllocator and friends.
1731         https://bugs.webkit.org/show_bug.cgi?id=185110
1732         <rdar://problem/39533895>
1733
1734         Reviewed by Saam Barati.
1735
1736         Update the test to match MetaAllocator changes in WTF.
1737
1738         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1739         (TestWebKitAPI::TEST_F):
1740         (WTF::tagForPtr):
1741         (WTF::ptrTagName):
1742
1743 2018-04-30  Alex Christensen  <achristensen@webkit.org>
1744
1745         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
1746         https://bugs.webkit.org/show_bug.cgi?id=180955
1747
1748         Reviewed by Andy Estes.
1749
1750         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1751         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
1752         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
1753
1754 2018-04-30  JF Bastien  <jfbastien@apple.com>
1755
1756         Use some C++17 features
1757         https://bugs.webkit.org/show_bug.cgi?id=185135
1758
1759         Reviewed by Alex Christensen.
1760
1761         * DumpRenderTree/PlatformMac.cmake:
1762         * gtk/ycm_extra_conf.py:
1763         (FlagsForFile):
1764
1765 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1766
1767         Use WordLock instead of std::mutex for Threading
1768         https://bugs.webkit.org/show_bug.cgi?id=185121
1769
1770         Reviewed by Geoffrey Garen.
1771
1772         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1773         (TEST):
1774
1775 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1776
1777         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
1778         https://bugs.webkit.org/show_bug.cgi?id=185103
1779
1780         Reviewed by Carlos Garcia Campos.
1781
1782         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1783         (TestWebKitAPI::TEST):
1784
1785 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
1786
1787         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
1788         https://bugs.webkit.org/show_bug.cgi?id=185052
1789
1790         Reviewed by Geoffrey Garen.
1791
1792         Modified API test to provide correct test cases for HTTPOnly flag.
1793
1794         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1795         (TEST):
1796
1797 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
1798
1799         Token misspelled "tocken" in error message string
1800         https://bugs.webkit.org/show_bug.cgi?id=185030
1801
1802         Reviewed by Saam Barati.
1803
1804         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
1805
1806 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
1807
1808         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
1809         https://bugs.webkit.org/show_bug.cgi?id=185049
1810
1811         Reviewed by Keith Miller.
1812
1813         * Scripts/run-javascriptcore-tests:
1814         (runJSCStressTests):
1815         * Scripts/run-jsc-stress-tests:
1816
1817 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1818
1819         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
1820         https://bugs.webkit.org/show_bug.cgi?id=185066
1821
1822         Reviewed by Youenn Fablet.
1823
1824         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
1825         WebKit should not swap WebContent process in this case.
1826
1827         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1828         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1829         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1830
1831 2018-04-27  Nan Wang  <n_wang@apple.com>
1832
1833         AX: Accessibility needs to know which part of the content view is visible on iOS
1834         https://bugs.webkit.org/show_bug.cgi?id=185085
1835         <rdar://problem/39801363>
1836
1837         Reviewed by Chris Fleizach.
1838
1839         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1840         (WTR::AccessibilityUIElement::stringAttributeValue):
1841
1842 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1843
1844         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
1845         https://bugs.webkit.org/show_bug.cgi?id=185050
1846         <rdar://problem/39624038>
1847
1848         Reviewed by Tim Horton.
1849
1850         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
1851         tested by the layout test added in this patch.
1852
1853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1854         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
1855
1856 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1857
1858         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
1859         https://bugs.webkit.org/show_bug.cgi?id=185061
1860
1861         Reviewed by Aakash Jain.
1862
1863         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1864         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
1865         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
1866
1867 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1868
1869         Add release bots for WinCairo.
1870         https://bugs.webkit.org/show_bug.cgi?id=185042
1871
1872         Reviewed by Lucas Forschler.
1873
1874         * BuildSlaveSupport/build.webkit.org-config/config.json:
1875         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
1876
1877 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
1878
1879         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
1880         https://bugs.webkit.org/show_bug.cgi?id=184938
1881         <rdar://problem/34737395>
1882
1883         Reviewed by Geoffrey Garen.
1884
1885         Add API test coverage.
1886
1887         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1888         (TEST):
1889
1890 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1891
1892         WinCairo test bots should run JSC tests with options for Windows command prompt.
1893         https://bugs.webkit.org/show_bug.cgi?id=185019
1894
1895         Reviewed by Per Arne Vollan.
1896
1897         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1898         (RunJavaScriptCoreTests.start):
1899
1900 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1901
1902         WinCairo WKL Debug Test bot is not using DRT.
1903         https://bugs.webkit.org/show_bug.cgi?id=185009
1904
1905         Reviewed by Per Arne Vollan.
1906
1907         * BuildSlaveSupport/build.webkit.org-config/config.json:
1908
1909 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
1910
1911         Disable content filtering in minimal simulator mode
1912         https://bugs.webkit.org/show_bug.cgi?id=185027
1913         <rdar://problem/39736091>
1914
1915         Reviewed by Jer Noble.
1916
1917         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1918
1919 2018-04-26  Brady Eidson  <beidson@apple.com>
1920
1921         Add a setting for keeping around all processes and always reusing them per-origin.
1922         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
1923
1924         Reviewed by Andy Estes.
1925
1926         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1927
1928 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
1929
1930         [INTL] Implement Intl.PluralRules
1931         https://bugs.webkit.org/show_bug.cgi?id=184312
1932
1933         Reviewed by JF Bastien.
1934
1935         Added Intl.PluralRules feature flag.
1936
1937         * Scripts/webkitperl/FeatureList.pm:
1938         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1939
1940 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1941
1942         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
1943         https://bugs.webkit.org/show_bug.cgi?id=184643
1944
1945         Reviewed by Žan Doberšek.
1946
1947         Add missing INCLUDE_DIRS in many places.
1948
1949         Adapt to single-header WPE includes.
1950
1951         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
1952
1953         * TestWebKitAPI/PlatformWPE.cmake:
1954         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1955         (testWebViewWebBackend):
1956         * TestWebKitAPI/glib/PlatformWPE.cmake:
1957         * WebKitTestRunner/EventSenderProxy.h:
1958         * WebKitTestRunner/PlatformWPE.cmake:
1959         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1960         * wpe/HeadlessViewBackend/CMakeLists.txt:
1961         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
1962         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
1963         * wpe/jhbuild.modules:
1964
1965 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
1966
1967         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
1968         https://bugs.webkit.org/show_bug.cgi?id=184982
1969
1970         Rubber-stamped by Aakash Jain.
1971
1972         Correctly count the number of API test failures.
1973
1974         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1975         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
1976         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1977         * Scripts/webkitpy/api_tests/manager.py:
1978         (Manager.run): Disabled tests are not run.
1979
1980 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
1981
1982         Remove access to keychain from the WebContent process
1983         https://bugs.webkit.org/show_bug.cgi?id=184428
1984         <rdar://problem/13150903>
1985
1986         Reviewed by Brent Fulgham.
1987
1988         This patch does the followings:
1989         1. Added an API test for this patch.
1990         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
1991
1992         * DumpRenderTree/mac/UIDelegate.mm:
1993         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
1994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1995         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
1996         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
1997         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1998         (TestWebKitAPI::TEST_F):
1999         * WebKitTestRunner/TestController.cpp:
2000         (WTR::copySignedPublicKeyAndChallengeString):
2001         (WTR::TestController::createOtherPage):
2002         (WTR::TestController::createWebViewWithOptions):
2003
2004 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2005
2006         [Extra zoom mode] The search field on www.bing.com is missing label text
2007         https://bugs.webkit.org/show_bug.cgi?id=184975
2008         <rdar://problem/39723081>
2009
2010         Reviewed by Tim Horton.
2011
2012         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
2013         focused element in extra zoom mode.
2014
2015         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2016         (WTR::UIScriptController::formInputLabel const):
2017         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2018         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2019         (WTR::UIScriptController::formInputLabel const):
2020         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2021         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2022         (WTR::UIScriptController::formInputLabel const):
2023
2024 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2025
2026         [WPE] Should load injected bundle from builddir in developer builds
2027         https://bugs.webkit.org/show_bug.cgi?id=184983
2028
2029         Reviewed by Carlos Alberto Lopez Perez.
2030
2031         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
2032
2033         * Scripts/run-minibrowser:
2034
2035 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2036
2037         [WPE] libgstggtk.so broken in jhbuild environment
2038         https://bugs.webkit.org/show_bug.cgi?id=184984
2039
2040         Reviewed by Carlos Alberto Lopez Perez.
2041
2042         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
2043         gst-plugins-good.
2044
2045         * wpe/jhbuild.modules:
2046
2047 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2048
2049         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
2050         https://bugs.webkit.org/show_bug.cgi?id=184962
2051
2052         Reviewed by Youenn Fablet.
2053
2054         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
2055
2056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2057         (ProcessSwap.SameOriginBlobNavigation): Added.
2058         (ProcessSwap.CrossOriginBlobNavigation): Added.
2059         (ProcessSwap.NavigateToAboutBlank): Added.
2060         (ProcessSwap.NavigateToDataURL): Added.
2061
2062 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2063
2064         [WPE] Remove deprecated functions and properties from the API
2065         https://bugs.webkit.org/show_bug.cgi?id=179295
2066
2067         Reviewed by Žan Doberšek.
2068
2069         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2070         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
2071         to rewrite LoadTrackingTest to not require the web view at construction time.
2072         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2073         (testWebKitSettings): Don't test private browsing setting, which is gone.
2074         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
2075
2076 2018-04-25  Andy Estes  <aestes@apple.com>
2077
2078         [Mac] Number of drop items is always 0 when performing a DHTML drag
2079         https://bugs.webkit.org/show_bug.cgi?id=184943
2080
2081         Reviewed by Ryosuke Niwa.
2082
2083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2084         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2085         (-[DragInfo numberOfValidItemsForDrop]):
2086         (-[DragInfo setNumberOfValidItemsForDrop:]):
2087         (TestWebKitAPI::TEST):
2088         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
2089
2090 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
2091
2092         API test harness should be Python
2093         https://bugs.webkit.org/show_bug.cgi?id=181043
2094         <rdar://problem/36164410>
2095
2096         Reviewed by David Kilzer.
2097
2098         Run API tests from a Python script rather than Perl. The Python API tests have
2099         the same structure as the layout tests.
2100
2101         * Scripts/run-api-tests: Changed from Perl to Python.
2102         * Scripts/webkitpy/api_tests: Added.
2103         * Scripts/webkitpy/api_tests/__init__.py: Added.
2104         * Scripts/webkitpy/api_tests/manager.py: Added.
2105         (Manager):
2106         (Manager.__init__):
2107         (Manager._test_list_from_output): Construct a list of tests from the output of
2108         TestWTF and TestWebKitAPI.
2109         (Manager._find_test_subset): Given a list of all possible tests and command line
2110         arguments, return a list of tests which match the provided arguments.
2111         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
2112         to determine which tests will be run.
2113         (Manager._print_test_result): Formatted print of a test with it's output.
2114         (Manager._print_tests_result_with_status): Print all tests and output for tests
2115         which ran with a specified exit status.
2116         (Manager.run): Collect all tests, run them and then print results from the run.
2117         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
2118         (main): Parse arguments, construct a port, early exit for illegal ports and
2119         then run tests.
2120         (run): Setup logging and printing before using the Manager to run tests.
2121         (parse_args): Use argparse to define all options used by run-api-tests.
2122         * Scripts/webkitpy/api_tests/runner.py: Added.
2123         (Runner):
2124         (Runner.__init__):
2125         (Runner._shard_tests): Split tests so that each suite runs together.
2126         (Runner.command_for_port): Run a command on the device specified by the given
2127         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
2128         this function would be entirely replaced by the server_process factory owned
2129         by the port object.
2130         (Runner.run): Run all shards in the message_pool.
2131         (Runner.handle): Handle reports from child processes.
2132         (Runner.result_map_by_status): Return a mapping of tests to output for tests
2133         which exit with a specific status.
2134         (_Worker):
2135         (_Worker.__init__):
2136         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
2137         (_Worker._run_single_test): Runs a single test in a single child process.
2138         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
2139         child process. If this technique fails, the remaining tests are run singly.
2140         (_Worker.handle): Run the specified shard.
2141         * Scripts/webkitpy/port/base.py:
2142         (Port):
2143         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
2144         (Port.environment_for_api_tests): Return the environment needed to run
2145         the TestWebKitAPI binary.
2146         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
2147         used when running API tests.
2148         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
2149         * Scripts/webkitpy/port/mac.py:
2150         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
2151         * Scripts/webkitpy/port/server_process.py: 
2152         (ServerProcess.pop_all_buffered_stdout):
2153
2154 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2155
2156         Incorrect number of WebDriver test failures shown in the bots
2157         https://bugs.webkit.org/show_bug.cgi?id=184959
2158
2159         Reviewed by Michael Catanzaro.
2160
2161         The regular expression we are using to get the number of failures from the log is matching a particular test
2162         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
2163         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
2164
2165         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2166         (RunWebDriverTests.commandComplete):
2167
2168 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2169
2170         [GTK] Implement MouseEvent.buttons
2171         https://bugs.webkit.org/show_bug.cgi?id=184913
2172
2173         Reviewed by Žan Doberšek.
2174
2175         Include the mouse buttons state in WTR synthesized events.
2176
2177         * WebKitTestRunner/EventSenderProxy.h:
2178         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2179         (WTR::EventSenderProxy::EventSenderProxy):
2180         (WTR::EventSenderProxy::createMouseButtonEvent):
2181         (WTR::EventSenderProxy::mouseDown):
2182         (WTR::EventSenderProxy::mouseUp):
2183         (WTR::EventSenderProxy::mouseMoveTo):
2184
2185 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
2186
2187         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
2188         https://bugs.webkit.org/show_bug.cgi?id=184954
2189
2190         Reviewed by Michael Catanzaro.
2191
2192         * BuildSlaveSupport/build.webkit.org-config/config.json:
2193
2194 2018-04-24  Saam Barati  <sbarati@apple.com>
2195
2196         Keep around a pre-warmed process when doing process swap on navigation
2197         https://bugs.webkit.org/show_bug.cgi?id=184765
2198         <rdar://problem/39685099>
2199
2200         Reviewed by Ryosuke Niwa and Brady Eidson.
2201
2202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2203
2204 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
2205
2206         [build.webkit.org] unit-tests fail when passwords.json is missing
2207         https://bugs.webkit.org/show_bug.cgi?id=180390
2208
2209         Reviewed by Carlos Alberto Lopez Perez.
2210
2211         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2212         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
2213         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2214         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
2215         (BuildBotConfigLoader._mock_open): Deleted.
2216         (BuildBotConfigLoader.load_config): Deleted.
2217
2218 2018-04-24  John Wilander  <wilander@apple.com>
2219
2220         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
2221         https://bugs.webkit.org/show_bug.cgi?id=184560
2222         <rdar://problem/38901344>
2223
2224         Reviewed by Youenn Fablet and Daniel Bates.
2225
2226         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
2227         We consume the From-Origin response header and only load the resource if:
2228         - The header is non-existent, empty, or invalid.
2229         - The header specifies 'same' and the resource's origin matches the originating
2230           document's origin and the origins up the frame tree.
2231         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
2232           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
2233
2234         This feature is experimental and off by default.
2235
2236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2237         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
2238         (TestWebKitAPI::TEST):
2239             Tests for From-Origin header parsing.
2240
2241 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2242
2243         Unreviewed. Update W3C WebDriver imported tests.
2244
2245         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2246         (WebDriverW3CExecutor.__init__):
2247
2248 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
2249
2250         [WPE] Remove libgbm dependency
2251         https://bugs.webkit.org/show_bug.cgi?id=184906
2252
2253         Reviewed by Carlos Garcia Campos.
2254
2255         Stop searching for libgbm, using its compiler flags for the
2256         HeadlessViewBackend compilation and linking against the .so object.
2257         This is not necessary anymore after r230562 switched to a different
2258         backend implementation for testing.
2259
2260         * wpe/HeadlessViewBackend/CMakeLists.txt:
2261         * wpe/install-dependencies:
2262
2263 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2264
2265         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
2266         https://bugs.webkit.org/show_bug.cgi?id=184816
2267
2268         Reviewed by Michael Catanzaro.
2269
2270         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
2271         timeout.
2272
2273         * TestWebKitAPI/glib/TestExpectations.json:
2274         * glib/api_test_runner.py:
2275         (TestRunner._run_test_glib.is_slow_test):
2276         (TestRunner._run_test_glib):
2277         * glib/glib_test_runner.py:
2278         (GLibTestRunner.__init__):
2279         (GLibTestRunner._stop_timeout):
2280         (GLibTestRunner._subtest_start):
2281         (GLibTestRunner._subtest_end):
2282
2283 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2284
2285         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
2286         https://bugs.webkit.org/show_bug.cgi?id=184901
2287         <rdar://problem/39664797>
2288
2289         Reviewed by Tim Horton.
2290
2291         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
2292         interacting with the UI. See WebKit ChangeLogs for more detail.
2293
2294         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2295         (WTR::UIScriptController::setTimePickerValue):
2296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2297         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2298         (WTR::UIScriptController::setTimePickerValue):
2299         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2300         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2301         (WTR::UIScriptController::setTimePickerValue):
2302
2303 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2304
2305         [LayoutFormattingContext] Initial commit.
2306         https://bugs.webkit.org/show_bug.cgi?id=184896
2307
2308         Reviewed by Antti Koivisto.
2309
2310         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2311
2312 2018-04-23  Chris Dumez  <cdumez@apple.com>
2313
2314         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
2315         https://bugs.webkit.org/show_bug.cgi?id=184801
2316
2317         Reviewed by Geoffrey Garen.
2318
2319         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
2320         This is a more common configuration and therefore should be the default testing configuration.
2321
2322         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2323         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2324         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
2325         is now asked for the policy decision.
2326
2327 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
2328
2329         [GTK][WPE] Add Debug bots (build and tests) for WPE
2330         https://bugs.webkit.org/show_bug.cgi?id=184887
2331
2332         Reviewed by Carlos Alberto Lopez Perez.
2333
2334         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
2335         wpe-linux-bot-4
2336
2337         Both bots have already the credentials ready to authenticated against
2338         build.webkit.org. They provides the bots for the "debug" configuration over
2339         the "WPE" platform and building for the "x86_64" architecture:
2340         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
2341
2342         * BuildSlaveSupport/build.webkit.org-config/config.json:
2343         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2344
2345 2018-04-23  Chris Dumez  <cdumez@apple.com>
2346
2347         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
2348         https://bugs.webkit.org/show_bug.cgi?id=184848
2349         <rdar://problem/39145306>
2350
2351         Reviewed by Brady Eidson.
2352
2353         Add API test coverage.
2354
2355         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2356         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2357         (TEST):
2358
2359 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
2360
2361         [GTK][WPE] TestSSL fails due to additional TLS errors returned
2362         https://bugs.webkit.org/show_bug.cgi?id=184860
2363
2364         Reviewed by Carlos Garcia Campos.
2365
2366         Add script and config file for regenerating the test certificate.
2367         Regenerate it. TestSSL no longer fails on my machine.
2368
2369         I do see a ton of network process crashes and JavaScript errors, none of
2370         which prevent the test from passing, but this commit only claims to fix
2371         the certificate validation portion of the test.
2372
2373         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
2374         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
2375         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
2376
2377 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2378
2379         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
2380         https://bugs.webkit.org/show_bug.cgi?id=184815
2381
2382         Reviewed by Michael Catanzaro.
2383
2384         This is because in the test we are calling both join and detach. We should only call join.
2385
2386         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2387         (testsJSCVirtualMachine):
2388
2389 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2390
2391         [GLIB] Test /jsc/prototypes crashes in debug
2392         https://bugs.webkit.org/show_bug.cgi?id=184814
2393
2394         Reviewed by Michael Catanzaro.
2395
2396         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
2397
2398         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2399         (barCreate):
2400         (barFree):
2401
2402 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2403
2404         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
2405         https://bugs.webkit.org/show_bug.cgi?id=184804
2406
2407         Reviewed by Carlos Garcia Campos.
2408
2409         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2410         (WebSocketTest::WebSocketTest):
2411         (WebSocketTest::~WebSocketTest):
2412         (WebSocketTest::serverWebSocketCallback):
2413         (WebSocketTest::webSocketTestResultCallback):
2414         (WebSocketTest::connectToServerAndWaitForEvents):
2415         (testWebSocketTLSErrors):
2416         (beforeAll):
2417
2418 2018-04-20  Chris Dumez  <cdumez@apple.com>
2419
2420         Unreviewed, update 2 more API tests after r230876.
2421
2422         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2423         (TEST):
2424         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2425         (TestWebKitAPI::TEST):
2426
2427 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2428
2429         Adjust geolocation feature flag
2430         https://bugs.webkit.org/show_bug.cgi?id=184856
2431
2432         Reviewed by Wenson Hsieh.
2433
2434         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2435
2436 2018-04-20  Chris Dumez  <cdumez@apple.com>
2437
2438         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
2439         https://bugs.webkit.org/show_bug.cgi?id=184210
2440         <rdar://problem/39072354>
2441
2442         Reviewed by Wenson Hsieh.
2443
2444         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
2445         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
2446         Add viewport meta tags.
2447
2448         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2449         (-[WKWebView _test_waitForDidFinishNavigation]):
2450         Update _test_waitForDidFinishNavigation to wait for the next presentation update
2451         to make iOS API tests happy without having to modify each of them.
2452
2453 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2454
2455         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
2456
2457         https://bugs.webkit.org/show_bug.cgi?id=184849
2458         rdar://problem/39386405
2459
2460         Reviewed by Brian Burg.
2461
2462         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
2463         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
2464         CGColor pointer from NSColor each time.
2465
2466 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2467
2468         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
2469         https://bugs.webkit.org/show_bug.cgi?id=184822
2470         <rdar://problem/38807319>
2471
2472         Reviewed by Tim Horton.
2473
2474         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
2475         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
2476         SPI. See other ChangeLogs for more detail.
2477
2478         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2479         (WTR::UIScriptController::enterText):
2480         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2481
2482         Add UIScriptController support for simulating text entry in the currently focused element.
2483
2484         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2485         (WTR::UIScriptController::enterText):
2486         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2487         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2488
2489         Add TestRunner bindings for registering injected bundle form client callbacks.
2490
2491         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2492         (WTR::handleTextDidChangeInTextField):
2493         (WTR::handleTextFieldDidBeginEditing):
2494         (WTR::handleTextFieldDidEndEditing):
2495         (WTR::InjectedBundle::didCreatePage):
2496
2497         Set the injected bundle form editor client.
2498
2499         (WTR::InjectedBundle::setUpInjectedBundleClients):
2500         (WTR::InjectedBundle::textDidChangeInTextField):
2501         (WTR::InjectedBundle::textFieldDidBeginEditing):
2502         (WTR::InjectedBundle::textFieldDidEndEditing):
2503         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2504         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2505         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
2506         (WTR::TestRunner::textDidChangeInTextFieldCallback):
2507         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
2508         (WTR::TestRunner::textFieldDidBeginEditingCallback):
2509         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
2510         (WTR::TestRunner::textFieldDidEndEditingCallback):
2511         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2512         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2513         (WTR::UIScriptController::enterText):
2514
2515 2018-04-20  Youenn Fablet  <youenn@apple.com>
2516
2517         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
2518         https://bugs.webkit.org/show_bug.cgi?id=184369
2519
2520         Reviewed by Chris Dumez.
2521
2522         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2523         (TEST):
2524
2525 2018-04-20  Daniel Bates  <dabates@apple.com>
2526
2527         Remove Strong Password decoration when text field type changes
2528         https://bugs.webkit.org/show_bug.cgi?id=184795
2529         <rdar://problem/38325108>
2530
2531         Reviewed by Antti Koivisto.
2532
2533         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2534         when the field has the Strong Password button and its type changes.
2535
2536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2537         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
2538         (didResignInputElementStrongPasswordAppearance):
2539         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2540         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2541         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
2542         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2543         (TEST):
2544
2545 2018-04-20  Brady Eidson  <beidson@apple.com>
2546
2547         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
2548         https://bugs.webkit.org/show_bug.cgi?id=184807
2549
2550         Reviewed by Chris Dumez.
2551
2552         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2553         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
2554
2555 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2556
2557         Unreviewed. Mark TestJSC as slow in debug.
2558
2559         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
2560
2561         * TestWebKitAPI/glib/TestExpectations.json:
2562
2563 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2564
2565         [GTK] Local cross references are broken in API documentation
2566         https://bugs.webkit.org/show_bug.cgi?id=184771
2567
2568         Reviewed by Michael Catanzaro.
2569
2570         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
2571         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
2572         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
2573         the cases.
2574
2575         * gtk/gtkdoc.py:
2576         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
2577         anything here.
2578         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
2579         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
2580         which gtkdoc-fixxref always uses absolute paths.
2581         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
2582
2583 2018-04-19  Brady Eidson  <beidson@apple.com>
2584
2585         Make back forward cache work with process swapping.
2586         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
2587
2588         Reviewed by Chris Dumez.
2589
2590         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2591
2592 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2593
2594         Enable Objective-C weak references
2595         <https://webkit.org/b/184789>
2596         <rdar://problem/39571716>
2597
2598         Reviewed by Dan Bernstein.
2599
2600         * ContentExtensionTester/Configurations/Base.xcconfig:
2601         (CLANG_ENABLE_OBJC_WEAK): Enable.
2602         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2603         (CLANG_ENABLE_OBJC_WEAK): Enable.
2604         * ImageDiff/cg/Configurations/Base.xcconfig:
2605         (CLANG_ENABLE_OBJC_WEAK): Enable.
2606         * MiniBrowser/Configurations/Base.xcconfig:
2607         (CLANG_ENABLE_OBJC_WEAK): Enable.
2608         * TestWebKitAPI/Configurations/Base.xcconfig:
2609         (CLANG_ENABLE_OBJC_WEAK): Enable.
2610         * WebEditingTester/Configurations/Base.xcconfig:
2611         (CLANG_ENABLE_OBJC_ARC): Re-order.
2612         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
2613         end of file.
2614         (CLANG_ENABLE_OBJC_WEAK): Enable.
2615         * WebKitTestRunner/Configurations/Base.xcconfig:
2616         (CLANG_ENABLE_OBJC_WEAK): Enable.
2617
2618 2018-04-19  Chris Dumez  <cdumez@apple.com>
2619
2620         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
2621         https://bugs.webkit.org/show_bug.cgi?id=184209
2622         <rdar://problem/39145306>
2623
2624         Reviewed by Ryosuke Niwa.
2625
2626         Add API test coverage.
2627
2628         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2629         (TEST):
2630
2631 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2632
2633         [WinCairo][EWS] Build bot should clean user temp directory each time.
2634         https://bugs.webkit.org/show_bug.cgi?id=184761
2635
2636         Reviewed by Lucas Forschler.
2637
2638         * EWSTools/Start-Queue.ps1:
2639         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
2640
2641 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2642
2643         Buildbots using Python zipfile should enable compression
2644         https://bugs.webkit.org/show_bug.cgi?id=184759
2645
2646         Reviewed by Lucas Forschler.
2647
2648         * BuildSlaveSupport/built-product-archive:
2649         (createZipManually):
2650         Default is to archive without compressing, so tell it to compress as well. 
2651
2652 2018-04-18  Nan Wang  <n_wang@apple.com>
2653
2654         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
2655         https://bugs.webkit.org/show_bug.cgi?id=184742
2656
2657         Reviewed by Chris Fleizach.
2658
2659         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2660         (AccessibilityUIElement::increment):
2661         (AccessibilityUIElement::decrement):
2662         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2663         (WTR::AccessibilityUIElement::asyncIncrement):
2664         (WTR::AccessibilityUIElement::asyncDecrement):
2665         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2666         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2667         (WTR::AccessibilityUIElement::increment):
2668         (WTR::AccessibilityUIElement::decrement):
2669         (WTR::AccessibilityUIElement::asyncIncrement):
2670         (WTR::AccessibilityUIElement::asyncDecrement):
2671
2672 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2673
2674         Fix archive step for WinCairo build bot.
2675         https://bugs.webkit.org/show_bug.cgi?id=184715
2676
2677         Reviewed by Lucas Forschler.
2678
2679         * BuildSlaveSupport/built-product-archive:
2680         (archiveBuiltProduct):
2681         (extractBuiltProduct):
2682
2683 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
2684
2685         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
2686         https://bugs.webkit.org/show_bug.cgi?id=184570
2687         <rdar://problem/34807323>
2688
2689         Reviewed by Chris Dumez.
2690
2691         Add API test coverage.
2692
2693         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
2694         (TEST):
2695
2696 2018-04-18  Chris Dumez  <cdumez@apple.com>
2697
2698         Add support for converting a local window to a remote window
2699         https://bugs.webkit.org/show_bug.cgi?id=184515
2700         <rdar://problem/39011318>
2701
2702         Reviewed by Ryosuke Niwa.
2703
2704         * MiniBrowser/mac/AppDelegate.m:
2705         (defaultConfiguration):
2706         * MiniBrowser/mac/SettingsController.h:
2707         * MiniBrowser/mac/SettingsController.m:
2708         (-[SettingsController _populateMenu]):
2709         (-[SettingsController validateMenuItem:]):
2710         (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]):
2711         (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]):
2712         Add menu entry in minibrowser to turn on process swap on cross-origin window.open().
2713
2714         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2715         Turn on process swap on cross-origin window.open() for corresponding test and update
2716         test to expect that a new WebProcess is created.
2717
2718         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2719         (WTR::InjectedBundlePage::decidePolicyForResponse):
2720         Add null checks for injectedBundle.testRunner(). When we swap process on navigation,
2721         the InjectedBundlePage::decidePolicyForResponse() gets called in the new process.
2722         In this new process, we have constructed a InjectedBundlePage for the page but we
2723         have not initialized the InjectedBundle members such as testRunner.
2724
2725         * WebKitTestRunner/TestController.cpp:
2726         (WTR::TestController::createWebViewWithOptions):
2727         (WTR::updateTestOptionsFromTestHeader):
2728         * WebKitTestRunner/TestOptions.h:
2729         (WTR::TestOptions::hasSameInitializationOptions const):
2730         Add a way for layout tests to turn on process swap on navigation via a test header.
2731
2732 2018-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2733
2734         Unreviewed, reland r230697, r230720, and r230724.
2735         https://bugs.webkit.org/show_bug.cgi?id=184600
2736
2737         * Scripts/run-jsc-stress-tests:
2738
2739 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2740
2741         [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
2742         https://bugs.webkit.org/show_bug.cgi?id=184687
2743
2744         Reviewed by Michael Catanzaro.
2745
2746         Add test cases for the new API.
2747
2748         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2749         (fooCreate):
2750         (fooFree):
2751         (fooGetProperty):
2752         (fooSetProperty):
2753         (testJSCPromises):
2754         (testJSCGarbageCollector):
2755         (testsJSCVirtualMachine):
2756         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2757         (windowObjectClearedCallback):
2758
2759 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2760
2761         [Extra zoom mode] Programmatically changing focus when an element already has focus is a confusing experience
2762         https://bugs.webkit.org/show_bug.cgi?id=184635
2763         <rdar://problem/39440642>
2764
2765         Reviewed by Tim Horton.
2766
2767         Add plumbing to support invoking `didHideKeyboardCallback` and `didShowKeyboardCallback` when (respectively)
2768         dismissing or presenting fullscreen input view controllers in extra zoom mode.
2769
2770         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2771         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2772         (-[TestRunnerWKWebView dealloc]):
2773         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2774         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2775         (-[TestRunnerWKWebView _keyboardDidShow:]):
2776         (-[TestRunnerWKWebView _keyboardDidHide:]):
2777         (-[TestRunnerWKWebView _webView:didPresentFocusedElementViewController:]):
2778         (-[TestRunnerWKWebView _webView:didDismissFocusedElementViewController:]):
2779
2780 2018-04-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2781
2782         [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
2783         https://bugs.webkit.org/show_bug.cgi?id=184573
2784
2785         Reviewed by Carlos Alberto Lopez Perez.
2786
2787         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2788         (TestWebKitAPI::TEST):
2789
2790 2018-04-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2791
2792         [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
2793         https://bugs.webkit.org/show_bug.cgi?id=184524
2794
2795         Reviewed by Alex Christensen.
2796
2797         Resurrect PlatformWebView for Windows port which was removed in Bug 104607.
2798
2799         * TestWebKitAPI/PlatformWebView.h:
2800         * TestWebKitAPI/PlatformWin.cmake:
2801         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
2802         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2803         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2804         (TestWebKitAPI::Util::moduleDirectory):
2805         (TestWebKitAPI::Util::createInjectedBundlePath):
2806         (TestWebKitAPI::Util::createURLForResource):
2807         (TestWebKitAPI::Util::URLForNonExistentResource):
2808         (TestWebKitAPI::Util::isKeyDown):
2809         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2810         (TestWebKitAPI::PlatformWebView::registerWindowClass):
2811         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2812         (TestWebKitAPI::PlatformWebView::initialize):
2813         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2814         (TestWebKitAPI::PlatformWebView::page const):
2815         (TestWebKitAPI::PlatformWebView::resizeTo):
2816         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2817         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2818         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2819         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2820         (TestWebKitAPI::PlatformWebView::wndProc):
2821         * TestWebKitAPI/win/UtilitiesWin.cpp: Added.
2822         (TestWebKitAPI::Util::run):
2823         (TestWebKitAPI::Util::spinRunLoop):
2824         (TestWebKitAPI::Util::sleep):
2825
2826 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2827
2828         Fix hasher tests for system with 32 bit longs
2829         https://bugs.webkit.org/show_bug.cgi?id=184708
2830         <rdar://problem/39459977>
2831
2832         Reviewed by Mark Lam.
2833
2834         Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
2835
2836         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
2837         (TestWebKitAPI::TEST):
2838
2839 2018-04-17  Commit Queue  <commit-queue@webkit.org>
2840
2841         Unreviewed, rolling out r230697, r230720, and r230724.
2842         https://bugs.webkit.org/show_bug.cgi?id=184717
2843
2844         These caused multiple failures on the Test262 testers.
2845         (Requested by mlewis13 on #webkit).
2846
2847         Reverted changesets:
2848
2849         "[WebAssembly][Modules] Prototype wasm import"
2850         https://bugs.webkit.org/show_bug.cgi?id=184600
2851         https://trac.webkit.org/changeset/230697
2852
2853         "[WebAssembly][Modules] Implement function import from wasm
2854         modules"
2855         https://bugs.webkit.org/show_bug.cgi?id=184689
2856         https://trac.webkit.org/changeset/230720
2857
2858         "[JSC] Rename runWebAssembly to runWebAssemblySuite"
2859         https://bugs.webkit.org/show_bug.cgi?id=184703
2860         https://trac.webkit.org/changeset/230724
2861
2862 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2863
2864         Unreviewed rollout of r230632. Regression in memory usage.
2865
2866         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2867
2868         * DumpRenderTree/TestOptions.h:
2869         * DumpRenderTree/mac/DumpRenderTree.mm:
2870         (runTest):
2871         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference): Deleted.
2872         * WebKitTestRunner/TestController.cpp:
2873         (WTR::TestController::resetPreferencesToConsistentValues):
2874         * WebKitTestRunner/TestOptions.cpp:
2875         (WTR::TestOptions::TestOptions):
2876         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2877         * WebKitTestRunner/TestOptions.h:
2878
2879 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2880
2881         [JSC] Rename runWebAssembly to runWebAssemblySuite
2882         https://bugs.webkit.org/show_bug.cgi?id=184703
2883
2884         Reviewed by JF Bastien.
2885
2886         * Scripts/run-jsc-stress-tests:
2887
2888 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2889
2890         [WebAssembly][Modules] Implement function import from wasm modules
2891         https://bugs.webkit.org/show_bug.cgi?id=184689
2892
2893         Reviewed by JF Bastien.
2894
2895         Add runWebAssemblyDirect, which runs wasm file directly.
2896
2897         * Scripts/run-jsc-stress-tests:
2898
2899 2018-04-17  Saam Barati  <sbarati@apple.com>
2900
2901         Add system trace points for process launch and for initializeWebProcess
2902         https://bugs.webkit.org/show_bug.cgi?id=184669
2903
2904         Reviewed by Simon Fraser.
2905
2906         * Tracing/SystemTracePoints.plist:
2907
2908 2018-04-17  Ross Kirsling  <ross.kirsling@sony.com>
2909
2910         Add debug bots for WinCairo.
2911         https://bugs.webkit.org/show_bug.cgi?id=184663
2912
2913         Reviewed by Lucas Forschler.
2914
2915         * BuildSlaveSupport/build.webkit.org-config/config.json:
2916         Add a debug build bot and two debug test bots.
2917
2918         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2919         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2920         Add a WinCairo category to build.webkit.org.
2921
2922 2018-04-17  Zalan Bujtas  <zalan@apple.com>
2923
2924         [LayoutReloaded] Set inline-block box position.
2925         https://bugs.webkit.org/show_bug.cgi?id=184690
2926
2927         Reviewed by Antti Koivisto.
2928
2929         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2930         (InlineFormattingContext.prototype._handleInlineBlock):
2931         * LayoutReloaded/Utils.js:
2932         (Utils._dumpBox):
2933         * LayoutReloaded/test/inline-block-with-fixed-width-height.html:
2934
2935 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2936
2937         [GLIB] Add API to clear JSCContext uncaught exception
2938         https://bugs.webkit.org/show_bug.cgi?id=184685
2939
2940         Reviewed by Žan Doberšek.
2941
2942         Add test cases for the new API.
2943
2944         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2945         (testJSCExceptions):
2946
2947 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2948
2949         [GLIB] Add API to query, delete and enumerate properties
2950         https://bugs.webkit.org/show_bug.cgi?id=184647
2951
2952         Reviewed by Michael Catanzaro.
2953
2954         Add test cases for the new API.
2955
2956         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2957         (testJSCObject):
2958         (testJSCClass):
2959         (testJSCPrototypes):
2960
2961 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2962
2963         [LayoutReloaded] Add support for replaced box.
2964         https://bugs.webkit.org/show_bug.cgi?id=184680
2965
2966         Reviewed by Antti Koivisto.
2967
2968         Basic support for inline replaced.
2969
2970         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2971         (InlineFormattingContext.prototype._handleInlineBox):
2972         (InlineFormattingContext.prototype._handleInlineBlock):
2973         (InlineFormattingContext.prototype._handleReplaced):
2974         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
2975         (Line.prototype.lastLineBox):
2976         (Line.prototype.addInlineBox):
2977         (Line.prototype.addInlineContainerBox): Deleted.
2978         * LayoutReloaded/TreeBuilder.js:
2979         (TreeBuilder.prototype._createAndAttachBox):
2980         * LayoutReloaded/Utils.js:
2981         (Utils._dumpBox):
2982         * LayoutReloaded/test/index.html:
2983         * LayoutReloaded/test/inline-simple-replaced.html: Added.
2984
2985 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2986
2987         [LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
2988         https://bugs.webkit.org/show_bug.cgi?id=184679
2989
2990         Reviewed by Antti Koivisto.
2991
2992         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2993         (InlineFormattingContext):
2994         (InlineFormattingContext.prototype.layout):
2995         (InlineFormattingContext.prototype._handleInlineContainer):
2996         (InlineFormattingContext.prototype._handleInlineContent):
2997         (InlineFormattingContext.prototype._handleInlineBlock):
2998         (InlineFormattingContext.prototype._handleReplacedBox):
2999         (InlineFormattingContext.prototype._clearNeedsLayoutAndMoveToNextSibling):
3000         (InlineFormattingContext.prototype._handleInlineBlockContainer): Deleted.
3001         (InlineFormattingContext.prototype._clearAndMoveToNext): Deleted.
3002
3003 2018-04-16  Zalan Bujtas  <zalan@apple.com>
3004
3005         [LayoutReloaded] Introduce fragmentation state/context.
3006         https://bugs.webkit.org/show_bug.cgi?id=184677
3007
3008         Reviewed by Antti Koivisto.
3009
3010         State/context for fragmented content (multicol, regions, pagination etc).
3011
3012         * LayoutReloaded/FormattingContext/FragmentationContext.js: Added.
3013         (FragmentationContext):
3014         * LayoutReloaded/FormattingState/FragmentationState.js: Added.
3015         (FragmentationState):
3016         (FragmentationState.prototype.formattingState):
3017
3018 2018-04-16  Andy Estes  <aestes@apple.com>
3019
3020         [iOS] Enable WKPDFView by default
3021         https://bugs.webkit.org/show_bug.cgi?id=184675
3022         <rdar://problem/27885452>
3023
3024         Reviewed by Darin Adler.
3025
3026         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
3027
3028 2018-04-16  Leo Balter  <leonardo.balter@gmail.com>
3029
3030         Perl-based Test262 runner
3031         https://bugs.webkit.org/show_bug.cgi?id=183343
3032
3033         Reviewed by Michael Saboff.
3034
3035         * Scripts/test262-helpers/README.md: Added.
3036         * Scripts/test262-helpers/agent.js: Added.
3037         (262.getGlobal):
3038         (262.setGlobal):
3039         (262.destroy):
3040         (262.IsHTMLDDA):
3041         * Scripts/test262-helpers/cpanfile: Added.
3042         * Scripts/test262-helpers/cpanfile.snapshot: Added.
3043         * Scripts/test262-helpers/test262-runner.pl: Added.
3044         (main):
3045         (processFile):
3046         (getScenarios):
3047         (addScenario):
3048         (compileTest):
3049         (runTest):
3050         (processResult):
3051         (getTempFile):
3052         (getContents):
3053         (parseData):
3054         (getHarness):
3055         * Scripts/test262-helpers/tests.log: Added.
3056
3057 2018-04-15  Andy Estes  <aestes@apple.com>
3058
3059         [iOS] Add API tests for PDF find-in-page
3060         https://bugs.webkit.org/show_bug.cgi?id=184634
3061
3062         Reviewed by Dan Bernstein.
3063
3064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3065         * TestWebKitAPI/Tests/WebKit/find.pdf: Added.
3066         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
3067         (-[TestFindDelegate findString]):
3068         (-[TestFindDelegate _webView:didCountMatches:forString:]):
3069         (-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
3070         (-[TestFindDelegate _webView:didFailToFindString:]):
3071         (loadWebView):
3072         (TEST):
3073
3074 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3075
3076         [LayoutReloaded] Update class documentation
3077         https://bugs.webkit.org/show_bug.cgi?id=184625
3078
3079         Reviewed by Antti Koivisto.
3080
3081         * LayoutReloaded/DisplayTree/Box.js:
3082         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3083         * LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
3084         * LayoutReloaded/FormattingContext/FloatingContext.js:
3085         * LayoutReloaded/FormattingContext/FormattingContext.js:
3086         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3087         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3088         * LayoutReloaded/FormattingState/BlockFormattingState.js:
3089         * LayoutReloaded/FormattingState/FloatingState.js:
3090         * LayoutReloaded/FormattingState/FormattingState.js:
3091         * LayoutReloaded/FormattingState/InlineFormattingState.js:
3092         * LayoutReloaded/LayoutState.js:
3093         * LayoutReloaded/LayoutTree/BlockContainer.js:
3094         * LayoutReloaded/LayoutTree/Box.js:
3095         * LayoutReloaded/LayoutTree/Container.js:
3096         * LayoutReloaded/LayoutTree/InlineBox.js:
3097         * LayoutReloaded/LayoutTree/InlineContainer.js:
3098         * LayoutReloaded/LayoutTree/Text.js:
3099         * LayoutReloaded/misc/headers/BlockContainer.h: Removed.
3100         * LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
3101         * LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
3102         * LayoutReloaded/misc/headers/Box.h: Removed.
3103         * LayoutReloaded/misc/headers/Container.h: Removed.
3104         * LayoutReloaded/misc/headers/FloatingContext.h: Removed.
3105         * LayoutReloaded/misc/headers/FormattingContext.h: Removed.
3106         * LayoutReloaded/misc/headers/InitialBlockContainer.h: Removed.
3107         * LayoutReloaded/misc/headers/InlineBox.h: Removed.
3108         * LayoutReloaded/misc/headers/LayoutContext.h: Removed.
3109         * LayoutReloaded/misc/headers/Line.h: Removed.
3110         * LayoutReloaded/misc/headers/Text.h: Removed.
3111
3112 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3113
3114         [LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
3115         https://bugs.webkit.org/show_bug.cgi?id=184621
3116
3117         Reviewed by Antti Koivisto.
3118
3119         This is just a simple, mark ancestors dirty implementation.
3120
3121         * LayoutReloaded/FormattingState/FormattingState.js:
3122         (FormattingState.prototype.markNeedsLayout):
3123         * LayoutReloaded/LayoutState.js:
3124         (LayoutState.prototype.markNeedsLayout):
3125         (LayoutState.prototype.setNeedsLayoutById): Deleted.
3126         (LayoutState.prototype.setNeedsLayout): Deleted.
3127         * LayoutReloaded/TreeBuilder.js:
3128         (TreeBuilder.prototype._createAndAttachBox):
3129         (TreeBuilder.prototype._findBox): Deleted.
3130         * LayoutReloaded/Utils.js:
3131         (Utils.layoutBoxById):
3132         * LayoutReloaded/test/index.html:
3133         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html:
3134
3135 2018-04-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3136
3137         [WPE] [webkitpy] The driver requirements should be checked before starting the tests
3138         https://bugs.webkit.org/show_bug.cgi?id=184595
3139
3140         Reviewed by Michael Catanzaro.
3141
3142         Ensure Driver.check_driver() is checked at check_sys_deps() time.
3143
3144         * Scripts/webkitpy/port/wpe.py:
3145         (WPEPort.check_sys_deps):
3146
3147 2018-04-13  Zalan Bujtas  <zalan@apple.com>
3148
3149         Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
3150
3151         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3152
3153 2018-04-13  Jonathan Bedard  <jbedard@apple.com>
3154
3155         Boot fewer simulators in CI/EWS machines
3156         https://bugs.webkit.org/show_bug.cgi?id=184594
3157         <rdar://problem/39188082>
3158
3159         Reviewed by Alexey Proskuryakov.
3160
3161         This is a temporary workaround fro <rdar://problem/39393590>.
3162
3163         * Scripts/webkitpy/xcode/simulated_device.py:
3164         (SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.
3165
3166 2018-04-13  Brady Eidson  <beidson@apple.com>
3167
3168         Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.
3169         https://bugs.webkit.org/show_bug.cgi?id=184559
3170
3171         Reviewed by Alex Christensen.
3172
3173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3174
3175 2018-04-13  Chris Dumez  <cdumez@apple.com>
3176
3177         input.webkitEntries does not work as expected when folder contains accented chars
3178         https://bugs.webkit.org/show_bug.cgi?id=184517
3179         <rdar://problem/39265537>
3180
3181         Reviewed by Alex Christensen.
3182
3183         Add API test coverage.
3184
3185         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3186         (TestWebKitAPI::TEST_F):
3187
3188 2018-04-13  Thibault Saunier  <tsaunier@igalia.com>
3189
3190         Update my emails ordering in contributors.json
3191         https://bugs.webkit.org/show_bug.cgi?id=184587
3192
3193         Rubber-stamped by Philippe Normand.
3194
3195         Bugzilla seems to pick up tsaunier@igalia.com which is not the one I use there.
3196
3197         * Scripts/webkitpy/common/config/contributors.json:
3198
3199 2018-04-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3200
3201         [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
3202         https://bugs.webkit.org/show_bug.cgi?id=184388
3203
3204         Reviewed by Carlos Alberto Lopez Perez.
3205
3206         Remove libxkbcommon from the JHBuild environment. We could alternatively add
3207         xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
3208         not believe it depends on anything else in the JHBuild environment.
3209
3210         * wpe/install-dependencies:
3211         * wpe/jhbuild.modules:
3212
3213 2018-04-12  Antoine Quint  <graouts@apple.com>
3214
3215         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3216         https://bugs.webkit.org/show_bug.cgi?id=184569
3217         <rdar://problem/38671301>
3218
3219         Reviewed by Jon Lee.
3220
3221         We set the default value for the CSS Animations and CSS Transitions as Web Animations flag to true
3222         but override it to be false always in the LayoutTests/legacy-animation-engine directory.
3223
3224         * DumpRenderTree/TestOptions.h:
3225         * DumpRenderTree/mac/DumpRenderTree.mm:
3226         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference):
3227         (runTest):
3228         * WebKitTestRunner/TestController.cpp:
3229         (WTR::TestController::resetPreferencesToConsistentValues):
3230         * WebKitTestRunner/TestOptions.cpp:
3231         (WTR::isLegacyAnimationEngineTestPath):
3232         (WTR::TestOptions::TestOptions):
3233         * WebKitTestRunner/TestOptions.h:
3234
3235 2018-04-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3236
3237         [GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
3238         https://bugs.webkit.org/show_bug.cgi?id=184531
3239
3240         Reviewed by Michael Catanzaro.
3241
3242         It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
3243         run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
3244         we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
3245         ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
3246         implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.
3247
3248         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3249         (TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
3250         * TestWebKitAPI/glib/UtilitiesGLib.cpp:
3251         (TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
3252         (TestWebKitAPI::Util::sleep): Ditto.
3253
3254 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3255
3256         [LayoutReloaded] Add support for incremental layout
3257         https://bugs.webkit.org/show_bug.cgi?id=184578
3258
3259         Reviewed by Antti Koivisto.
3260
3261         * LayoutReloaded/Layout.js:
3262         (layout):
3263         * LayoutReloaded/LayoutState.js:
3264         (LayoutState.prototype.rootContainer):
3265         (LayoutState.prototype.setNeedsLayoutById):
3266         * LayoutReloaded/Utils.js:
3267         (Utils.layoutTreeDump):
3268         * LayoutReloaded/test/TestHarness.js:
3269         (verifyLayout):
3270         (runLayout):
3271         (verifyLayoutTreeDump): Deleted.
3272         * LayoutReloaded/test/index.html:
3273         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.
3274
3275 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3276
3277         [LayoutReloaded] Move root container ownership to layout state
3278         https://bugs.webkit.org/show_bug.cgi?id=184575
3279
3280         Reviewed by Antti Koivisto.
3281
3282         Now the root container is on the associated layout state (ICB only at this point though).
3283
3284         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3285         (BlockFormattingContext.prototype.layout):
3286         * LayoutReloaded/FormattingContext/FormattingContext.js:
3287         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3288         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3289         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3290         (InlineFormattingContext.prototype._handleFloatingBox):
3291         * LayoutReloaded/Layout.js:
3292         (layout):
3293         * LayoutReloaded/LayoutState.js:
3294         (LayoutState):
3295         (LayoutState.prototype.formattingContext):
3296         (LayoutState.prototype.establishedFormattingState):
3297         (LayoutState.prototype.formattingStateForBox):
3298         (LayoutState.prototype.needsLayout):
3299         (LayoutState.prototype.displayBox):
3300         (LayoutState.prototype._formattingContext):
3301         (LayoutState.prototype.layout): Deleted.
3302         (LayoutState.prototype.formattingStates): Deleted.
3303         (LayoutState.prototype.initialDisplayBox): Deleted.
3304         * LayoutReloaded/Utils.js:
3305         (Utils._dumpBox):
3306         (Utils._findDisplayBox): Deleted.
3307
3308 2018-04-12  Jonathan Bedard  <jbedard@apple.com>
3309
3310         Fix --build-directory flag for run-webkit-tests
3311         https://bugs.webkit.org/show_bug.cgi?id=184545
3312         <rdar://problem/39385080>
3313
3314         Rubber-stamped by Aakash Jain.
3315
3316         The --build-directory path does not work with iOS-Simulator.
3317
3318         * Scripts/webkitpy/port/base.py:
3319         (Port._build_path): Use the port configuration to calculate the root directory.
3320         * Scripts/webkitpy/port/base_unittest.py:
3321         (PortTest.test_build_path): Test build directories for embedded configurations.
3322
3323 2018-04-12  Ross Kirsling  <ross.kirsling@sony.com>
3324
3325         pemfile.py should not assume POSIX line endings
3326         https://bugs.webkit.org/show_bug.cgi?id=184507
3327
3328         Reviewed by Daniel Bates.
3329
3330         * Scripts/webkitpy/common/system/pemfile.py:
3331         (_parse_pem_format):
3332         * Scripts/webkitpy/common/system/pemfile_unittest.py:
3333         (PemFileTest.test_parse_crlf):
3334         (PemFileTest.test_parse_cr):
3335
3336 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3337
3338         [LayoutReloaded] Minor cleanup in LayoutSate
3339         https://bugs.webkit.org/show_bug.cgi?id=184546
3340
3341         Reviewed by Antti Koivisto.
3342
3343         * LayoutReloaded/FormattingContext/FormattingContext.js:
3344         (FormattingContext.isInFormattingContext):
3345         * LayoutReloaded/FormattingState/FormattingState.js:
3346         (FormattingState.prototype.displayBoxes):
3347         (FormattingState.prototype.displayBox):
3348         (FormattingState.prototype._markSubTreeNeedsLayout):
3349         (FormattingState):
3350         (FormattingState.prototype.displayBoxMap): Deleted.
3351         * LayoutReloaded/LayoutState.js:
3352         (LayoutState.prototype.formattingStateForBox):
3353         (LayoutState.prototype.needsLayout):
3354         (LayoutState.prototype.displayBox):
3355         (LayoutState.prototype._createFormattingState):
3356         (LayoutState):
3357         * LayoutReloaded/LayoutTree/Box.js:
3358         (Layout.Box.prototype.isFormattingContextDescendant): Deleted.
3359         * LayoutReloaded/LayoutTree/Container.js:
3360         (Layout.Container.prototype.isContainingBlockDescendant): Deleted.
3361         * LayoutReloaded/Utils.js:
3362         (Utils._findDisplayBox):
3363
3364 2018-04-12  Zalan Bujtas  <zalan@apple.com>
3365
3366         [LayoutReloaded] Introduce needsLayout to InlineFormattingContext
3367         https://bugs.webkit.org/show_bug.cgi?id=184538
3368
3369         Reviewed by Antti Koivisto.
3370
3371         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3372         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3373         (BlockFormattingContext):
3374         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout): Deleted.
3375         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout): Deleted.
3376         * LayoutReloaded/FormattingContext/FormattingContext.js:
3377         (FormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3378         (FormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3379         (FormattingContext):
3380         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3381         (InlineFormattingContext.prototype.layout):
3382         (InlineFormattingContext.prototype._handleInlineContainer):
3383         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3384         (InlineFormattingContext.prototype._handleInlineContent):
3385         (InlineFormattingContext.prototype._clearAndMoveToNext):
3386         (InlineFormattingContext):
3387
3388 2018-04-12  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3389
3390         [GStreamer] Speed up GStreamer dependency build by removing examples compilation
3391         https://bugs.webkit.org/show_bug.cgi?id=184528
3392
3393         Reviewed by Philippe Normand.
3394
3395         * gstreamer/jhbuild.modules: Added --disable-examples for GStreamer package.
3396
3397 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
3398
3399         [WPE] Switch testing process to using WPEBackend-fdo
3400         https://bugs.webkit.org/show_bug.cgi?id=184357
3401
3402         Reviewed by Carlos Alberto Lopez Perez.
3403
3404         Switch WPE testing to using the WPEBackend-fdo implementation that
3405         depends on the WL_bind_wayland_display EGL extension, as defined under
3406         the freedesktop.org project.
3407         https://cgit.freedesktop.org/mesa/mesa/tree/docs/specs/WL_bind_wayland_display.spec
3408
3409         HeadlessViewBackend is refactored to use the WPEBackend-fdo API, but
3410         otherwise is not changed in functionality.
3411
3412         Unit tests now have to unconditionally use HeadlessViewBackend as a
3413         wpe_view_backend provider, since WPEBackend-fdo does not provide a
3414         default wpe_view_backend implementation. Unit tests covering that are
3415         adjusted to instead use a mock wpe_view_backend interface.
3416
3417         * Scripts/webkitdirs.pm:
3418         (builtDylibPathForName): Fix the libWPEWebKit.so name to also include
3419         the API version that was added in r230449.
3420         * Scripts/webkitpy/port/waylanddriver.py:
3421         (WaylandDriver._setup_environ_for_test): Export EGL_PLATFORM=wayland.
3422         * Scripts/webkitpy/port/wpe.py:
3423         (WPEPort._driver_class): Use WaylandDriver by default.
3424         * TestWebKitAPI/PlatformWebView.h:
3425         (): Deleted.
3426         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3427         (testWebViewWebBackend):
3428         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3429         (Test::createWebViewBackend):
3430         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
3431         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3432         (TestWebKitAPI::PlatformWebView::initialize):
3433         * wpe/HeadlessViewBackend/CMakeLists.txt:
3434         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
3435         (getEGLDisplay):
3436         (HeadlessViewBackend::HeadlessViewBackend):
3437         (HeadlessViewBackend::~HeadlessViewBackend):
3438         (HeadlessViewBackend::backend const):
3439         (HeadlessViewBackend::createSnapshot):
3440         (HeadlessViewBackend::performUpdate):
3441         (HeadlessViewBackend::makeCurrent): Deleted.
3442         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
3443         * wpe/jhbuild.modules: Module name cleanup. Dyz version is bumped.
3444
3445 2018-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3446
3447         [GTK] Switch to use always complex text code path
3448         https://bugs.webkit.org/show_bug.cgi?id=183285
3449
3450         Reviewed by Michael Catanzaro.
3451
3452         Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
3453
3454         * WebKitTestRunner/gtk/main.cpp:
3455         (main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.
3456
3457 2018-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3458
3459         [GLIB] Handle strings containing null characters
3460         https://bugs.webkit.org/show_bug.cgi?id=184450
3461
3462         Reviewed by Michael Catanzaro.
3463
3464         Add test case for strings with null characters and update all calls to evaluate to pass the script length.
3465
3466         * TestWebKitAPI/PlatformGTK.cmake:
3467         * TestWebKitAPI/PlatformWPE.cmake:
3468         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3469         (testJSCBasic):
3470         (testJSCFunction):
3471         (testJSCObject):
3472         (testJSCClass):
3473         (testJSCPrototypes):
3474         (testJSCExceptions):
3475         (testJSCPromises):
3476         (testJSCGarbageCollector):
3477         (testJSCWeakValue):
3478         (testsJSCVirtualMachine):
3479         (testsJSCAutocleanups):
3480         * TestWebKitAPI/Tests/JavaScriptCore/glib/script.js: Added.
3481         * TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp:
3482         (DOMElementTest::testAutoFill):
3483         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3484         (WebKitWebEditorTest::testSelectionChanged):
3485         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3486         (WebKitFrameTest::testJavaScriptValues):
3487         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3488         (consoleMessageSentCallback):
3489         (methodCallCallback):
3490
3491 2018-04-11  Zan Dobersek  <zdobersek@igalia.com>
3492
3493         [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
3494         https://bugs.webkit.org/show_bug.cgi?id=184513
3495
3496         Reviewed by Michael Catanzaro.
3497
3498         Update the WPE-specific testWebViewWebBackend() test case, removing the
3499         test that passes a null WebKitWebViewBackend object to the
3500         webkit_web_view_new() call.
3501
3502         Helper createWebViewBackend() that's called via Test::createWebView()
3503         variations is updated to, in case of not using the headless backend,
3504         return a WebKitWebViewBackend instance that wraps around a
3505         default wpe_view_backend object.
3506
3507         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3508         (testWebViewWebBackend):
3509         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3510         (Test::createWebViewBackend):
3511
3512 2018-04-11  Zalan Bujtas  <zalan@apple.com>
3513
3514         [LayoutReloaded] Introduce needsLayout flag
3515         https://bugs.webkit.org/show_bug.cgi?id=184527
3516
3517         Reviewed by Antti Koivisto.
3518
3519         Use the formatting state to mark boxes dirty.
3520
3521         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3522         (BlockFormattingContext.prototype.layout):
3523         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3524         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3525         (BlockFormattingContext):
3526         * LayoutReloaded/FormattingContext/FormattingContext.js:
3527         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3528         * LayoutReloaded/FormattingState/FormattingState.js:
3529         (FormattingState):
3530         (FormattingState.prototype.markNeedsLayout):
3531         (FormattingState.prototype.clearNeedsLayout):
3532         (FormattingState.prototype.needsLayout):
3533         (FormattingState.prototype.layoutNeeded):
3534         (FormattingState.prototype._markSubTreeNeedsLayout):
3535         * LayoutReloaded/LayoutState.js:
3536         (LayoutState.prototype.formattingStateForBox):
3537         (LayoutState.prototype.setNeedsLayout):
3538         (LayoutState.prototype.needsLayout):
3539         * LayoutReloaded/LayoutTree/Box.js:
3540         (Layout.Box.prototype.isFormattingContextDescendant):
3541         * LayoutReloaded/LayoutTree/Container.js:
3542         (Layout.Container.prototype.isContainingBlockDescendant):
3543
3544 2018-04-11  Jonathan Bedard  <jbedard@apple.com>
3545
3546         Fix TestInvocation class for newer versions of clang.
3547         https://bugs.webkit.org/show_bug.cgi?id=184508
3548         <rdar://problem/39328648>
3549
3550         Reviewed by Alexey Proskuryakov.
3551
3552         Declare TestInvocation to be final so it does not require a virtual destructor.
3553
3554         * WebKitTestRunner/TestInvocation.h:
3555
3556 2018-04-10  Alex Christensen  <achristensen@webkit.org>
3557
3558         IDN spoofing with Hebrew combining characters
3559         https://bugs.webkit.org/show_bug.cgi?id=184472
3560         <rdar://problem/39148687>
3561
3562         Reviewed by Brent Fulgham.
3563
3564         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3565         (TestWebKitAPI::TEST):
3566
3567 2018-04-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3568
3569         [Extra zoom mode] Missing label when focusing a <select> with a title attribute but no associated <label>
3570         https://bugs.webkit.org/show_bug.cgi?id=184352
3571         <rdar://problem/39237683>
3572
3573         Reviewed by Andy Estes.
3574
3575         Add support for UIScriptController::selectFormPopoverTitle, which returns the title of the current select
3576         popover's UITableViewController (for testing purposes).
3577
3578         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3579         (WTR::UIScriptController::selectFormPopoverTitle const):
3580         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3581         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3582         (WTR::UIScriptController::selectFormPopoverTitle const):
3583         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3584         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3585         (WTR::UIScriptController::selectFormPopoverTitle const):
3586
3587 2018-04-10  Nan Wang  <n_wang@apple.com>
3588
3589         AX: Expose strong password fields on iOS
3590         https://bugs.webkit.org/show_bug.cgi?id=184465
3591         <rdar://problem/39325104>
3592
3593         Reviewed by Chris Fleizach.
3594
3595         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3596         (AccessibilityUIElement::boolAttributeValue):
3597         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3598         (WTR::AccessibilityUIElement::boolAttributeValue):
3599
3600 2018-04-10  Zalan Bujtas  <zalan@apple.com>
3601
3602         [LayoutReloaded] Add support for out-of-flow descendants in inline formatting context.
3603         https://bugs.webkit.org/show_bug.cgi?id=184454
3604
3605         Reviewed by Antti Koivisto.
3606
3607         When the containing block of an out-of-flow positioned element establishes an inline formatting context.
3608         This is mostly about moving out-of-flow logic from BlockFormattingContext to the base class.
3609
3610         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3611         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3612         (BlockFormattingContext):
3613         (BlockFormattingContext.prototype._layoutOutOfFlowDescendants): Deleted.
3614         (BlockFormattingContext.prototype._computeOutOfFlowWidth): Deleted.
3615         (BlockFormattingContext.prototype._computeInFlowWidth): Deleted.
3616         (BlockFormattingContext.prototype._computeOutOfFlowHeight): Deleted.
3617         (BlockFormattingContext.prototype._computeOutOfFlowPosition): Deleted.
3618         (BlockFormattingContext.prototype._shrinkToFitWidth): Deleted.
3619         * LayoutReloaded/FormattingContext/FormattingContext.js:
3620         (FormattingContext.prototype._placeInFlowPositionedChildren):
3621         (FormattingContext.prototype._computeInFlowWidth):
3622         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3623         (FormattingContext.prototype._computeOutOfFlowWidth):
3624         (FormattingContext.prototype._computeOutOfFlowHeight):
3625         (FormattingContext.prototype._computeOutOfFlowPosition):
3626         (FormattingContext.prototype._shrinkToFitWidth):
3627         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3628         (InlineFormattingContext.prototype.layout):
3629         (InlineFormattingContext.prototype._handleInlineContainer):
3630         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3631         (InlineFormattingContext.prototype._placeOutOfFlowDescendants): Deleted.
3632         * LayoutReloaded/test/index.html:
3633         * LayoutReloaded/test/inline-with-out-of-flow-descendant.html: Added.
3634
3635 2018-04-09  Zan Dobersek  <zdobersek@igalia.com>
3636
3637         WKTR: Enable DOM cache, SW registration directory cleanup on non-Cocoa platforms
3638         https://bugs.webkit.org/show_bug.cgi?id=184414
3639
3640         Reviewed by Michael Catanzaro.
3641
3642         Enable clearServiceWorkerRegistrations(), clearDOMCache() and
3643         clearDOMCaches() implementations in WebKitTestRunner's TestController
3644         class for non-Cocoa platforms. Implementations depend on the generic
3645         WK2 C API that other ports can leverage as well.
3646
3647         The clearDOMCache() and clearDOMCaches() calls are now operational for
3648         tests that invoke them. clearServiceWorkerRegistrations() and
3649         clearDOMCaches() are also called between each test, cleaning up relevant
3650         resources.
3651
3652         The TestController::getAllStorageAccessEntries() stub for non-Cocoa
3653         platforms is moved into the main !PLATFORM(COCOA) block.
3654
3655         * WebKitTestRunner/TestController.cpp:
3656         (WTR::TestController::getAllStorageAccessEntries):
3657         (WTR::clearServiceWorkerRegistrationsCallback):
3658         (WTR::TestController::clearServiceWorkerRegistrations):
3659         (WTR::clearDOMCacheCallback):
3660         (WTR::TestController::clearDOMCache):
3661         (WTR::TestController::clearDOMCaches):
3662
3663 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3664
3665         [LayoutReloaded] Add support for relatively positioned containers in inline formatting context.
3666         https://bugs.webkit.org/show_bug.cgi?id=184439
3667
3668         Reviewed by Antti Koivisto.
3669
3670         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3671         (BlockFormattingContext.prototype._placeInFlowPositionedChildren): Deleted.
3672         (BlockFormattingContext.prototype._computeInFlowPositionedPosition): Deleted.
3673         * LayoutReloaded/FormattingContext/FormattingContext.js:
3674         (FormattingContext.prototype._computeInFlowPositionedPosition):
3675         (FormattingContext.prototype._placeInFlowPositionedChildren):