f5f7af14ee6e8cbba36199d95a8be2622279d73c
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Remove unused patch view
4         https://bugs.webkit.org/show_bug.cgi?id=195669
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/urls.py:
9         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
10
11 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-app] Use Buildbot result code variables
14         https://bugs.webkit.org/show_bug.cgi?id=195668
15
16         Reviewed by Alexey Proskuryakov.
17
18         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
19         (Buildbot): Added Buildbot result code variables.
20         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
21         (StatusBubble._build_bubble): Used Buildbot result code variables.
22
23 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
24
25         [Flatpak] Expand submodule recursively
26         https://bugs.webkit.org/show_bug.cgi?id=195672
27
28         Building WPE with flatpak was impossible without that as it was raising an exception.
29         Also update wpebackend-fdo to match what is built in jhbuild
30
31         Reviewed by Philippe Normand.
32
33         * flatpak/flatpakutils.py:
34         (expand_submodules_recurse):
35         (expand_manifest):
36         * flatpak/org.webkit.WPEModules.yaml:
37
38 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
39
40         [ews-app] status bubble should be hidden for certain builds
41         https://bugs.webkit.org/show_bug.cgi?id=194597
42
43         Reviewed by Dewei Zhu.
44
45         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
46         (StatusBubble._build_bubble):
47         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
48         because the patch didn't have relevant changes.
49         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
50         in production yet.
51
52 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
53
54         [Win] Fix a slew of simple clang-cl warnings.
55         https://bugs.webkit.org/show_bug.cgi?id=195652
56
57         Reviewed by Don Olmstead.
58
59         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
60         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
61
62 2019-03-12  Justin Fan  <justin_fan@apple.com>
63
64         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
65         https://bugs.webkit.org/show_bug.cgi?id=195518
66         <rdar://problem/46322356>
67
68         Reviewed by Myles C. Maxfield.
69
70         * DumpRenderTree/DerivedSources-input.xcfilelist:
71         * DumpRenderTree/DerivedSources-output.xcfilelist:
72
73 2019-03-12  Commit Queue  <commit-queue@webkit.org>
74
75         Unreviewed, rolling out r242825.
76         https://bugs.webkit.org/show_bug.cgi?id=195648
77
78         "Broke webkitpy tests with my change to
79         lldb_dump_class_layout.py" (Requested by rmorisset on
80         #webkit).
81
82         Reverted changeset:
83
84         "Alter Tools/Scripts/dump-class-layout to be able to dump all
85         classes with suspicious padding"
86         https://bugs.webkit.org/show_bug.cgi?id=195573
87         https://trac.webkit.org/changeset/242825
88
89 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
90
91         [ews-build] Show status bubbles while the patch is waiting in queue
92         https://bugs.webkit.org/show_bug.cgi?id=195618
93
94         Reviewed by Lucas Forschler.
95
96         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
97         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
98         enabled in initial deployment.
99         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
100         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
101         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
102         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
103         (StatusBubble._build_bubbles_for_patch):
104
105 2019-03-12  Robin Morisset  <rmorisset@apple.com>
106
107         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
108         https://bugs.webkit.org/show_bug.cgi?id=195573
109
110         Reviewed by Simon Fraser.
111
112         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
113
114         * Scripts/dump-class-layout:
115         (main):
116         * lldb/lldb_dump_class_layout.py:
117         (ClassLayout.__init__):
118         (ClassLayout._compute_padding_recursive):
119         (LLDBDebuggerInstance.dump_layout_for_classname):
120         (LLDBDebuggerInstance):
121         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
122         (LLDBDebuggerInstance.layout_for_classname): Deleted.
123
124 2019-03-12  Chris Dumez  <cdumez@apple.com>
125
126         Device Orientation access permission should be denied unless explicitly granted by the client
127         https://bugs.webkit.org/show_bug.cgi?id=195625
128
129         Reviewed by Youenn Fablet.
130
131         add API test coverage.
132
133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
134         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
135         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
136         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
137         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
138         (runDeviceOrientationTest):
139         (TEST):
140         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
141         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
142
143 2019-03-12  Jer Noble  <jer.noble@apple.com>
144
145         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
146         https://bugs.webkit.org/show_bug.cgi?id=195137
147         <rdar://problem/48810307>
148
149         Reviewed by Eric Carlson.
150
151         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
152         (TestWebKitAPI::TEST):
153
154 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
155
156         [ews-build] Change urls from uat to production
157         https://bugs.webkit.org/show_bug.cgi?id=195566
158
159         Reviewed by Lucas Forschler.
160
161         * BuildSlaveSupport/ews-app/ews/config.py:
162         * BuildSlaveSupport/ews-build/events.py:
163         * BuildSlaveSupport/ews-build/steps.py:
164
165 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
166
167         [ews-build] change max_builds for local-worker to 1
168         https://bugs.webkit.org/show_bug.cgi?id=195568
169
170         Reviewed by Lucas Forschler.
171
172         * BuildSlaveSupport/ews-build/loadConfig.py:
173
174 2019-03-12  Tim Horton  <timothy_horton@apple.com>
175
176         Fix the build
177
178         * TestRunnerShared/spi/PencilKitTestSPI.h:
179         * TestWebKitAPI/ios/PencilKitTestSPI.h:
180
181 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
182
183         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
184         https://bugs.webkit.org/show_bug.cgi?id=194131
185
186         Reviewed by Michael Catanzaro.
187
188         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
189         (uriChanged):
190         (testUnfinishedSubresourceLoad):
191         (serverCallback):
192         (beforeAll):
193
194 2019-03-11  Alex Christensen  <achristensen@webkit.org>
195
196         WTF::Expected should use std::addressof instead of operator&
197         https://bugs.webkit.org/show_bug.cgi?id=195604
198
199         Reviewed by Myles Maxfield.
200
201         * TestWebKitAPI/Tests/WTF/Expected.cpp:
202         (TestWebKitAPI::Unique::Unique):
203         (TestWebKitAPI::Unique::operator&):
204         (TestWebKitAPI::TEST):
205
206 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
207
208         Add Optional to Forward.h.
209         https://bugs.webkit.org/show_bug.cgi?id=195586
210
211         Reviewed by Darin Adler.
212
213         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
214         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
215         Remove unnecessary includes from headers.
216
217 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
218
219         Add testing API to hit-test and scroll overflow scrollers
220         https://bugs.webkit.org/show_bug.cgi?id=195278
221
222         Reviewed by Antti Koivisto.
223         
224         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
225         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
226         
227         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
228
229         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
230         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
231         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
232         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
233         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
234         * TestRunnerShared/UIScriptContext/UIScriptController.h:
235         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
236         (WTR::enclosingScrollViewIncludingSelf):
237         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
238
239 2019-03-11  Tim Horton  <timothy_horton@apple.com>
240
241         API test WebKit.RequestTextInputContext fails on iOS
242         https://bugs.webkit.org/show_bug.cgi?id=195585
243
244         Reviewed by Wenson Hsieh and Simon Fraser.
245
246         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
247         (applyStyle):
248         (TEST):
249         Add a viewport, so that the coordinates match up on iOS.
250         Scroll by moving the UIScrollView's contentOffset.
251
252 2019-03-11  Chris Dumez  <cdumez@apple.com>
253
254         Assert in WebPageProxy::suspendCurrentPageIfPossible()
255         https://bugs.webkit.org/show_bug.cgi?id=195506
256         <rdar://problem/48733477>
257
258         Reviewed by Alex Christensen.
259
260         Add API test coverage.
261
262         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
263
264 2019-03-11  Shawn Roberts  <sroberts@apple.com>
265
266         Adding myself to contributors.json
267
268         Unreviewed, addming myself to contributors.json .
269
270         * Scripts/webkitpy/common/config/contributors.json:
271
272 2019-03-11  Alex Christensen  <achristensen@webkit.org>
273
274         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
275         https://bugs.webkit.org/show_bug.cgi?id=195511
276         <rdar://problem/44873269>
277
278         Reviewed by Darin Adler.
279
280         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
281         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
282         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
283         (TEST_F):
284
285 2019-03-11  Chris Dumez  <cdumez@apple.com>
286
287         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
288         https://bugs.webkit.org/show_bug.cgi?id=195561
289
290         Reviewed by Youenn Fablet.
291
292         Make sure the JS in the test requests for permission to receive device orientation events.
293
294         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
295
296 2019-03-11  Youenn Fablet  <youenn@apple.com>
297
298         Allow storage quota increase by default in WTR
299         https://bugs.webkit.org/show_bug.cgi?id=195541
300
301         Reviewed by Geoffrey Garen.
302
303         Allow storage quota increase by default in WTR.
304         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
305         Use this for tests that explicitly need cache increase.
306
307         Instead of increasing quota by 2, make sure the next request is
308         granted by adding all given parameters.
309
310         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
311         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
312         (WTR::TestRunner::setAllowStorageQuotaIncrease):
313         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
314         * WebKitTestRunner/InjectedBundle/TestRunner.h:
315         * WebKitTestRunner/TestController.cpp:
316         (WTR::TestController::setAllowStorageQuotaIncrease):
317         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
318         * WebKitTestRunner/TestController.h:
319         * WebKitTestRunner/TestInvocation.cpp:
320         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
321         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
322         (WTR::TestController::cocoaResetStateToConsistentValues):
323         (WTR::TestController::setAllowStorageQuotaIncrease):
324         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
325         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
326         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
327
328 2019-03-11  Xan Lopez  <xan@igalia.com>
329
330         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
331         https://bugs.webkit.org/show_bug.cgi?id=194147
332
333         Reviewed by Michael Saboff.
334
335         To make --32-bit work correctly on Linux/64bit we need to:
336
337         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
338         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
339         unfortunately CMake only allows us to do this during
340         crosscompilation, which is overkill here.
341         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
342         pkg-config detection module uses the x86 .pc files instead of the
343         x86_64 ones.
344         - Set the -m32 flags for the compiler.
345
346         * Scripts/webkitdirs.pm:
347         (generateBuildSystemFromCMakeProject):
348
349 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
350
351         Add MotionMark-1.1 plan file for run-benchmark script.
352         https://bugs.webkit.org/show_bug.cgi?id=195481
353
354         Rubber-stamped by Darin Adler.
355
356         Run-benchmark script should support MontionMark-1.1.
357
358         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
359
360 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
361
362         [ews-app] Add support for submit-to-ews url
363         https://bugs.webkit.org/show_bug.cgi?id=195477
364
365         Reviewed by Lucas Forschler.
366
367         * BuildSlaveSupport/ews-app/ews/fetcher.py:
368         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
369         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
370         * BuildSlaveSupport/ews-app/ews/urls.py:
371         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
372
373 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
374
375         Unreviewed, rolling out r242688, r242643, r242624.
376
377         Caused multiple layout test failures and crashes on iOS and macOS.
378
379         Reverted changeset:
380
381         "requestAnimationFrame should execute before the next frame"
382         https://bugs.webkit.org/show_bug.cgi?id=177484
383         https://trac.webkit.org/changeset/242624/webkit
384
385         * Tracing/SystemTracePoints.plist:
386
387 2019-03-11  John Wilander  <wilander@apple.com>
388
389         Resource Load Statistics: Make it possible exclude localhost from classification
390         https://bugs.webkit.org/show_bug.cgi?id=195474
391         <rdar://problem/47520577>
392
393         Reviewed by Brent Fulgham.
394
395         This patch allows for localhost to be excluded from classification and
396         treatment as a prevalent resource.
397
398         The WebKit Tools change adds a new function called
399         testRunner.setStatisticsIsRunningTest() which can be used to control this
400         behavior.
401
402         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
403         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
404         (WTR::TestRunner::setStatisticsIsRunningTest):
405         * WebKitTestRunner/InjectedBundle/TestRunner.h:
406         * WebKitTestRunner/TestController.cpp:
407         (WTR::TestController::setStatisticsIsRunningTest):
408         * WebKitTestRunner/TestController.h:
409         * WebKitTestRunner/TestInvocation.cpp:
410         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
411
412 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
413
414         [ews-build] Disable waterfall and console view for ews-build.webkit.org
415         https://bugs.webkit.org/show_bug.cgi?id=195560
416
417         Reviewed by Lucas Forschler.
418
419         * BuildSlaveSupport/ews-build/master.cfg:
420
421 2019-03-11  Alex Christensen  <achristensen@webkit.org>
422
423         Unreviewed, rolling out r242698.
424
425         API test crashes on bots.
426
427         Reverted changeset:
428
429         "Add a WKContentRuleList variant that uses copied memory
430         instead of mmap'd shared memory for class A containerized
431         apps"
432         https://bugs.webkit.org/show_bug.cgi?id=195511
433         https://trac.webkit.org/changeset/242698
434
435 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
436
437         [WPE] Enable web process sandbox
438         https://bugs.webkit.org/show_bug.cgi?id=195169
439
440         Reviewed by Daniel Bates.
441
442         * wpe/install-dependencies:
443         * wpe/jhbuild.modules:
444
445 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
446
447         [ews-app] Use port 17000 for worker communication
448         https://bugs.webkit.org/show_bug.cgi?id=195558
449
450         Reviewed by Lucas Forschler.
451
452         * BuildSlaveSupport/ews-build/master.cfg:
453
454 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
455
456         [ews-build] unit-tests fail when passwords.json is missing
457         https://bugs.webkit.org/show_bug.cgi?id=195557
458
459         Reviewed by Lucas Forschler.
460
461         * BuildSlaveSupport/ews-build/loadConfig.py:
462         (loadBuilderConfig):
463         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
464         (ConfigDotJSONTest.test_configuration):
465         * BuildSlaveSupport/ews-build/master.cfg:
466
467 2019-03-11  Truitt Savell  <tsavell@apple.com>
468
469         Unreviewed, rolling out r242702.
470
471         Broke High Sierra builders.
472
473         Reverted changeset:
474
475         "Add utility function to allow easy reverse range-based
476         iteration of a container"
477         https://bugs.webkit.org/show_bug.cgi?id=195542
478         https://trac.webkit.org/changeset/242702
479
480 2019-03-11  Sam Weinig  <sam@webkit.org>
481
482         Add utility function to allow easy reverse range-based iteration of a container
483         https://bugs.webkit.org/show_bug.cgi?id=195542
484
485         Reviewed by Antti Koivisto.
486
487         * TestWebKitAPI/CMakeLists.txt:
488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
489         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
490         (TestWebKitAPI::TEST):
491         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
492
493 2019-03-10  Alex Christensen  <achristensen@webkit.org>
494
495         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
496         https://bugs.webkit.org/show_bug.cgi?id=195511
497         <rdar://problem/44873269>
498
499         Reviewed by Darin Adler.
500
501         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
502         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
503         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
504         (TEST_F):
505
506 2019-03-10  Tim Horton  <timothy_horton@apple.com>
507
508         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
509         https://bugs.webkit.org/show_bug.cgi?id=195499
510
511         Reviewed by Darin Adler.
512
513         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
514         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
515         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
516         (-[WKWebView synchronouslyFocusTextInputContext:]):
517         (applyStyle):
518         (applyIframe):
519         (TEST):
520         Add some tests for this SPI.
521
522 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
523
524         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
525         https://bugs.webkit.org/show_bug.cgi?id=181151
526
527         Reviewed by Don Olmstead.
528
529         * TestWebKitAPI/CMakeLists.txt:
530         * TestWebKitAPI/PlatformWin.cmake:
531         Enable TestWTF RunLoop tests in all platforms.
532
533         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
534         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
535         (TestWebKitAPI::DerivedOneShotTimer::fired):
536         (TestWebKitAPI::TEST):
537         Only a few platforms support nested RunLoop.
538
539         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
540         (TestWebKitAPI::DerivedRepeatingTimer::fired):
541
542 2019-03-10  David Quesada  <david_quesada@apple.com>
543
544         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
545         https://bugs.webkit.org/show_bug.cgi?id=152480
546
547         Reviewed by Chris Dumez.
548
549         Add a unit test based on Daniel Bates's test case that starts a download, ensures
550         there are no additional references to the process pool besides the one held by
551         the download, waits for the download to finish (in the sense that the
552         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
553         measure, also check that the process pool has been deallocated at the end of the
554         test. The test wouldn't be meaningful if the process pool were still alive.
555
556         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
557         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
558         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
559             The download will be canceled because the delegate does not implement the
560             method to decide the download's destination, so this is where we know the
561             DownloadProxyMap is done with the DownloadProxy.
562         (TEST):
563
564 2019-03-08  Chris Dumez  <cdumez@apple.com>
565
566         Add support for Device Orientation / Motion permission API
567         https://bugs.webkit.org/show_bug.cgi?id=195329
568         <rdar://problem/47645367>
569
570         Reviewed by Geoffrey Garen.
571
572         Add test infrastructure to help test the Device Orientation / Motion permission API.
573
574         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
575         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
576         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
577         * WebKitTestRunner/InjectedBundle/TestRunner.h:
578         * WebKitTestRunner/TestController.cpp:
579         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
580         (WTR::TestController::createWebViewWithOptions):
581         (WTR::TestController::resetStateToConsistentValues):
582         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
583         * WebKitTestRunner/TestController.h:
584         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
585         * WebKitTestRunner/TestInvocation.cpp:
586         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
587
588 2019-03-08  Saam barati  <sbarati@apple.com>
589
590         Add a compare-results script to compare benchmark results
591         https://bugs.webkit.org/show_bug.cgi?id=195486
592         <rdar://problem/48723397>
593
594         Reviewed by Geoffrey Garen.
595
596         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
597         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
598         to extend it to learn about our other benchmarks.
599
600         * Scripts/compare-results: Added.
601         (readJSONFile):
602         (detectJetStream2):
603         (JetStream2Results):
604         (detectSpeedometer2):
605         (Speedometer2Results):
606         (detectPLT5):
607         (PLT5Results):
608         (detectBenchmark):
609         (biggerIsBetter):
610         (ttest):
611         (getOptions):
612         (main):
613
614 2019-03-08  Stephanie Lewis  <slewis@apple.com>
615
616         Ensure old tab state is cleared between iterations of run-benchmark
617         https://bugs.webkit.org/show_bug.cgi?id=195393
618         <rdar://problem/46885583>
619
620         Reviewed by Dewei Zhu.
621
622         a) ensure the default to restore state is not set
623         b) terminate Safari correctly
624         c) Set the system default to ignore Persistent State in Safari
625
626         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
627         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
628         (OSXBrowserDriver.prepare_env): 
629         (OSXBrowserDriver.restore_env):
630         (OSXBrowserDriver.close_browsers):
631         (OSXBrowserDriver._terminate_processes):
632         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
633         (OSXChromeDriver):
634         (OSXChromeCanaryDriver):
635         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
636         (OSXFirefoxDriver):
637         (OSXFirefoxNightlyDriver):
638         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
639         (OSXSafariDriver):
640         (OSXSafariDriver.prepare_env):
641
642 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
643
644         [GTK] Several InputMethodFilter tests are failing
645         https://bugs.webkit.org/show_bug.cgi?id=195408
646
647         Reviewed by Carlos Garcia Campos.
648
649         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
650         Regressed in r241751.
651         Hexadecimal values of keycodes are expressed now in upper letters.
652         Composited characters should be cast to UTF8 strings.
653
654         (TestWebKitAPI::TEST):
655
656 2019-03-07  Tomas Popela  <tpopela@redhat.com>
657
658         [GTK] Make Tools/gtkdoc python3 compatible
659         https://bugs.webkit.org/show_bug.cgi?id=195359
660
661         Reviewed by Carlos Garcia Campos.
662
663         * gtkdoc/generate-gtkdoc:
664         ConfigParser was reworked in Python 3.2 so we have adapt the code to
665         work with Python 2 and 3.
666         (get_gtkdoc_module_paths):
667         The iteritems() was removed in Python 3, so let's use items() that's
668         available in Python 2 and 3.
669         (get_generator_for_config):
670         * gtkdoc/gtkdoc.py:
671         (GTKDoc._run_command):
672         The sys.stdout.write() is expecting str in Python 3 and not bytes
673         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
674         for passing the bytes there.
675
676 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
677
678         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
679         https://bugs.webkit.org/show_bug.cgi?id=195346
680         <rdar://problem/48667048>
681
682         Unreviewed build fix for clang-cl.
683
684         * DumpRenderTree/win/DumpRenderTree.cpp:
685         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
686
687 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
688
689         requestAnimationFrame should execute before the next frame
690         https://bugs.webkit.org/show_bug.cgi?id=177484
691
692         Reviewed by Simon Fraser.
693
694         Add trace points for the page RenderingUpdate.
695
696         * Tracing/SystemTracePoints.plist:
697
698 2019-03-07  Zalan Bujtas  <zalan@apple.com>
699
700         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
701         https://bugs.webkit.org/show_bug.cgi?id=195353
702         <rdar://problem/48626394>
703
704         Reviewed by Simon Fraser.
705
706         * WebKitTestRunner/ios/TestControllerIOS.mm:
707         (WTR::TestController::platformResetPreferencesToConsistentValues):
708
709 2019-03-07  John Wilander  <wilander@apple.com>
710
711         Resource Load Statistics: Make it possible to purge only script-accessible cookies
712         https://bugs.webkit.org/show_bug.cgi?id=195383
713         <rdar://problem/48570136>
714
715         Reviewed by Brent Fulgham.
716
717         This patch adds test infrastructure to purge only script-accessible cookies,
718         including a new testRunner function called statisticsDeleteCookiesForHost().git a
719
720         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
721         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
722         (WTR::TestRunner::statisticsDeleteCookiesForHost):
723         * WebKitTestRunner/InjectedBundle/TestRunner.h:
724         * WebKitTestRunner/TestController.cpp:
725         (WTR::TestController::statisticsDeleteCookiesForHost):
726         * WebKitTestRunner/TestController.h:
727         * WebKitTestRunner/TestInvocation.cpp:
728         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
729
730 2019-03-07  Commit Queue  <commit-queue@webkit.org>
731
732         Unreviewed, rolling out r242354.
733         https://bugs.webkit.org/show_bug.cgi?id=195402
734
735         breaks layout tests in all configurations (Requested by
736         zdobersek on #webkit).
737
738         Reverted changeset:
739
740         "[WPE] Enable web process sandbox"
741         https://bugs.webkit.org/show_bug.cgi?id=195169
742         https://trac.webkit.org/changeset/242354
743
744 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
745
746         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
747         https://bugs.webkit.org/show_bug.cgi?id=195346
748
749         Reviewed by Fujii Hironori.
750
751         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
752         (TestWebKitAPI::TEST):
753         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
754
755         * DumpRenderTree/win/DumpRenderTree.cpp:
756         (findFontFallback):
757         (addFontFallbackIfPresent):
758         (removeFontFallbackIfPresent):
759         (main):
760         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
761         (TestWebKitAPI::Util::moduleDirectory):
762         (TestWebKitAPI::Util::createInjectedBundlePath):
763         Use wchar helpers as needed.
764
765 2019-03-06  Rob Buis  <rbuis@igalia.com>
766
767         Consider supporting the `referrerpolicy` attribute.
768         https://bugs.webkit.org/show_bug.cgi?id=179053
769
770         Reviewed by Darin Adler.
771
772         Add a runtime flag for referrerpolicy attribute.
773
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (enableExperimentalFeatures):
776
777 2019-03-05  Daniel Bates  <dabates@apple.com>
778
779         Update expected API test result following r242379
780         (https://bugs.webkit.org/show_bug.cgi?id=195125)
781
782         Update expected x-coordinate of selection rect now that the left padding of
783         a textarea is sized in ems (so dependent on the font size) just like the left
784         padding of a text field.
785
786         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
787         (TestWebKitAPI::TEST):
788
789 2019-03-05  David Quesada  <david_quesada@apple.com>
790
791         [WK2] It should be possible to follow links with 'download' attributes
792         https://bugs.webkit.org/show_bug.cgi?id=195145
793         rdar://problem/48462642
794
795         Reviewed by Alex Christensen.
796
797         Add a unit test to verify that activating links with 'download' attributes now
798         navigates to the linked resource, rather than starts downloading it. Add another
799         to verify that it is still possible to explicitly download the link via the
800         'Download' navigation action policy.
801
802         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
803         (-[DownloadAttributeTestDelegate init]):
804         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
805         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
806         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
807         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
808         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
809         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
810         (TEST):
811         * WebKitTestRunner/TestController.cpp:
812         (WTR::TestController::decidePolicyForNavigationAction):
813         * WebKitTestRunner/TestController.h:
814
815 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
816
817         [Curl] Implement Cookie Accept Policy.
818         https://bugs.webkit.org/show_bug.cgi?id=191645
819
820         Reviewed by Fujii Hironori.
821
822         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
823         (TestWebKitAPI::Curl::TEST_F):
824
825 2019-03-05  Youenn Fablet  <youenn@apple.com>
826
827         Rename requestCacheStorageSpace to requestStorageSpace
828         https://bugs.webkit.org/show_bug.cgi?id=195282
829
830         Reviewed by Chris Dumez.
831
832         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
833         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
834         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
835
836 2019-03-05  Brady Eidson  <beidson@apple.com>
837
838         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
839         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
840
841         Reviewed by Tim Horton.
842
843         Loading a file: URL into a WKWebView and then loading another file: url from a completely
844         different directory into that same WKWebView should work.
845
846         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
847         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
848
849 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
850
851         Add WeakHashSet
852         https://bugs.webkit.org/show_bug.cgi?id=195152
853
854         Reviewed by Antti Koivisto.
855
856         Added tests for WeakHashSet.
857
858         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
859         (TestWebKitAPI::Base::Base): Moved.
860         (TestWebKitAPI::Derived::foo): Moved.
861         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
862         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
863         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
864         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
865
866 2019-03-04  Chris Dumez  <cdumez@apple.com>
867
868         Do not share WebProcesses between private and regular sessions
869         https://bugs.webkit.org/show_bug.cgi?id=195189
870         <rdar://problem/48421064>
871
872         Reviewed by Alex Christensen.
873
874         Add API test coverage.
875
876         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
877         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
878
879 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
880
881         [WPE] Enable web process sandbox
882         https://bugs.webkit.org/show_bug.cgi?id=195169
883
884         Reviewed by Daniel Bates.
885
886         * wpe/install-dependencies:
887         * wpe/jhbuild.modules:
888
889 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
890
891         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
892         https://bugs.webkit.org/show_bug.cgi?id=195206
893
894         Reviewed by Žan Doberšek.
895
896         Add a new test case.
897
898         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
899         (testJSCClass):
900
901 2019-03-04  Charlie Turner  <cturner@igalia.com>
902
903         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
904         https://bugs.webkit.org/show_bug.cgi?id=194898
905
906         Reviewed by Žan Doberšek.
907
908         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
909         a GCC extension that permits arithmetic on void* pointer. Inline
910         the macro until this issue is fixed upstream.
911
912 2019-03-03  Tim Horton  <timothy_horton@apple.com>
913
914         Rid the world of WK_API_ENABLED
915         https://bugs.webkit.org/show_bug.cgi?id=195263
916
917         Reviewed by Dan Bernstein.
918
919         List of changed files elided because it's useless.
920
921 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
922
923         Unreviewed follow-up to r242292.
924
925         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
926
927         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
928         (TestWebKitAPI::testStrip): Renamed from strip.
929         (TestWebKitAPI::TEST):
930
931 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
932
933         Unreviewed, remove accidentally-committed URLHelpers.cpp test
934
935         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
936         and bug #194272 for details.
937
938         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
939
940 2019-03-03  Tim Horton  <timothy_horton@apple.com>
941
942         Remove some more unused 32-bit code
943         https://bugs.webkit.org/show_bug.cgi?id=195255
944
945         Reviewed by Darin Adler.
946
947         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
948         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
949         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
950         (NPP_New):
951         (NPP_HandleEvent):
952         (handleEventCarbon): Deleted.
953
954 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
955
956         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
957
958         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
959         (TestWebKitAPI::TEST):
960
961 2019-03-01  Darin Adler  <darin@apple.com>
962
963         Finish removing String::format
964         https://bugs.webkit.org/show_bug.cgi?id=194893
965
966         Reviewed by Daniel Bates.
967 '
968         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
969
970 2019-03-01  Alex Christensen  <achristensen@webkit.org>
971
972         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
973         https://bugs.webkit.org/show_bug.cgi?id=195229
974         <rdar://problem/48520362>
975
976         Reviewed by Chris Dumez.
977
978         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
979         (TEST):
980
981 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
982
983         Add a system trace scope for event region building
984         https://bugs.webkit.org/show_bug.cgi?id=195226
985
986         Reviewed by Jon Lee.
987
988         This trace scope measures the time spend converting element rects into Region objects,
989         which can be large on some pages.
990
991         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
992
993         * Tracing/SystemTracePoints.plist:
994
995 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
996
997         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
998         https://bugs.webkit.org/show_bug.cgi?id=194612
999
1000         Reviewed by Alex Christensen.
1001
1002         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1003         Just test the new string-processing function and don't touch the actual environment.
1004         (Test cases are all as before, but based on operator== instead of strcmp.)
1005
1006 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
1007
1008         [ews-app] Update primary keys for handling multiple Buildbot instances
1009         https://bugs.webkit.org/show_bug.cgi?id=195120
1010
1011         Reviewed by Stephanie Lewis.
1012
1013         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
1014         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
1015         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
1016
1017         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
1018         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
1019         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
1020         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
1021         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
1022         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
1023
1024 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
1025
1026         [WinCairo] Enable service worker
1027         https://bugs.webkit.org/show_bug.cgi?id=188318
1028
1029         Reviewed by Youenn Fablet.
1030
1031         * DumpRenderTree/DumpRenderTreePrefix.h:
1032         * TestWebKitAPI/PlatformWin.cmake:
1033         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
1034         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
1035         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1036
1037 2019-03-01  Justin Fan  <justin_fan@apple.com>
1038
1039         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
1040         https://bugs.webkit.org/show_bug.cgi?id=195191
1041
1042         Rubber-stamped by Dean Jackson.
1043
1044         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
1045
1046         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1047
1048 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
1049
1050         Unreviewed, fix lldb webkitpy tests
1051         https://bugs.webkit.org/show_bug.cgi?id=194375
1052
1053         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
1054
1055         * lldb/lldb_webkit.py:
1056         (WTFStringImplProvider.is_8bit):
1057
1058 2019-02-28  David Quesada  <david_quesada@apple.com>
1059
1060         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
1061         https://bugs.webkit.org/show_bug.cgi?id=195121
1062         rdar://problem/48450302
1063
1064         Reviewed by Alex Christensen.
1065
1066         Add API tests for -WKNavigationAction._shouldPerformDownload in various
1067         configurations where the 'download' attribute is absent, blank, or populated
1068         with a filename, and where the anchor element is same-origin or cross-origin
1069         (meaning the 'download' attribute shouldn't be honored).
1070
1071         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1072         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
1073         (-[NavigationActionTestDelegate init]):
1074         (-[NavigationActionTestDelegate navigationAction]):
1075         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
1076         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
1077         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1078         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
1079         (TEST):
1080
1081 2019-02-28  Antoine Quint  <graouts@apple.com>
1082
1083         Enable the Pointer Events runtime flag by default
1084         https://bugs.webkit.org/show_bug.cgi?id=195156
1085
1086         Reviewed by Dean Jackson.
1087
1088         * DumpRenderTree/mac/DumpRenderTree.mm:
1089         (enableExperimentalFeatures):
1090
1091 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1092
1093         Several PasteImage API tests are flaky
1094         https://bugs.webkit.org/show_bug.cgi?id=195160
1095
1096         Reviewed by Tim Horton.
1097
1098         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
1099         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
1100         listening for a "load" event after image load is already complete.
1101
1102         To address this, make these tests first register a "load" event handler, then run script to insert an image
1103         element into the document, and finally wait until the load event is observed before checking image size.
1104
1105         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1106
1107 2019-02-28  Chris Dumez  <cdumez@apple.com>
1108
1109         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
1110         https://bugs.webkit.org/show_bug.cgi?id=195107
1111
1112         Reviewed by Alex Christensen.
1113
1114         Give some time for the zoom level to get restored.
1115
1116         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1117
1118 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
1119
1120         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
1121         https://bugs.webkit.org/show_bug.cgi?id=194958
1122
1123         Reviewed by Geoffrey Garen.
1124
1125         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
1126         (TEST):
1127
1128 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
1129
1130         [ews-app] Update method to save build to handle builder_display_name
1131         https://bugs.webkit.org/show_bug.cgi?id=195047
1132
1133         Reviewed by Dewei Zhu.
1134
1135         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
1136         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
1137
1138 2019-02-28  Justin Fan  <justin_fan@apple.com>
1139
1140         [Web GPU] Enable Web GPU only on 64-bit
1141         https://bugs.webkit.org/show_bug.cgi?id=195139
1142
1143         Because Metal is only supported on 64 bit apps.
1144
1145         Unreviewed build fix.
1146
1147         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1148
1149 2019-02-27  Youenn Fablet  <youenn@apple.com>
1150
1151         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
1152         https://bugs.webkit.org/show_bug.cgi?id=194959
1153
1154         Reviewed by Chris Dumez.
1155
1156         Spin loop until getting the condition to remove flakiness.
1157
1158         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1159
1160 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
1161
1162         [ews-build] Buildbot should include builder_display_name in the build events
1163         https://bugs.webkit.org/show_bug.cgi?id=195045
1164
1165         Reviewed by Dewei Zhu.
1166
1167         * BuildSlaveSupport/ews-build/events.py:
1168         (Events.buildStarted): Included builder_display_name in event data. Also renamed
1169         buildername to builder_name to be consistent in naming style.
1170         (Events.buildFinished): Ditto.
1171
1172 2019-02-27  Chris Dumez  <cdumez@apple.com>
1173
1174         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
1175         https://bugs.webkit.org/show_bug.cgi?id=194480
1176
1177         Reviewed by Brady Eidson.
1178
1179         Update existing API test to make it more likely to reproduce the issue.
1180
1181         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1182
1183 2019-02-27  Brady Eidson  <beidson@apple.com>
1184
1185         Universal links from Google search results pages don't open the app.
1186         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1187
1188         Reviewed by Geoffrey Garen.
1189
1190         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1191         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1192         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1193         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1194
1195 2019-02-27  Chris Dumez  <cdumez@apple.com>
1196
1197         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1198         https://bugs.webkit.org/show_bug.cgi?id=195102
1199
1200         Reviewed by Geoffrey Garen.
1201
1202         If the number of processes is not yet what we expect, wait a bit and check again to give
1203         processes some time to exit.
1204
1205         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1206
1207 2019-02-27  Chris Dumez  <cdumez@apple.com>
1208
1209         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1210         https://bugs.webkit.org/show_bug.cgi?id=194545
1211
1212         Reviewed by Brady Eidson.
1213
1214         Make sure the test navigates forward and then back only once. Previously, navigating
1215         back would trigger a navigation again in a timer.
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1218
1219 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1220
1221         High Sierra Debug JSC test queue should use faster hardware
1222         https://bugs.webkit.org/show_bug.cgi?id=194603
1223
1224         Rubber-stamped by Alexey Proskuryakov.
1225
1226         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1227
1228         * BuildSlaveSupport/build.webkit.org-config/config.json:
1229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1230         (BubbleQueueServer):
1231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1232         (WebKitBuildbot):
1233         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1234         * QueueStatusServer/config/queues.py:
1235         * Scripts/webkitpy/common/config/ews.json:
1236         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1237         (test_ews_name):
1238
1239 2019-02-27  John Wilander  <wilander@apple.com>
1240
1241         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1242         https://bugs.webkit.org/show_bug.cgi?id=195071
1243         <rdar://problem/48417690>
1244
1245         Reviewed by Alex Christensen and Brent Fulgham.
1246
1247         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1248         (TestWebKitAPI::createURL):
1249             Convenience function.
1250         (TestWebKitAPI::TEST):
1251             WebCore::AdClickAttribution now takes a URL when creating Source and
1252             Destination.
1253         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1254         (TestWebKitAPI::TEST):
1255             WebCore::AdClickAttribution now takes a URL when creating Source and
1256             Destination.
1257
1258 2019-02-27  Antoine Quint  <graouts@apple.com>
1259
1260         Support Pointer Events on macOS
1261         https://bugs.webkit.org/show_bug.cgi?id=195008
1262         <rdar://problem/47454419>
1263
1264         Reviewed by Dean Jackson.
1265
1266         * DumpRenderTree/mac/DumpRenderTree.mm:
1267         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1268         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1269
1270 2019-02-26  Mark Lam  <mark.lam@apple.com>
1271
1272         Remove remaining poisoning code.
1273         https://bugs.webkit.org/show_bug.cgi?id=194138
1274
1275         Reviewed by Saam Barati.
1276
1277         * TestWebKitAPI/CMakeLists.txt:
1278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1279         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1280         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1281         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1282         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1283         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1284         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1285
1286 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1287
1288         Move ephemeral local storage from WebProcess to UIProcess
1289         https://bugs.webkit.org/show_bug.cgi?id=195074
1290         <rdar://problem/47937975>
1291
1292         Reviewed by Geoff Garen.
1293
1294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1295
1296 2019-02-20  Jer Noble  <jer.noble@apple.com>
1297
1298         [Cocoa] Media elements will restart network buffering just before suspending
1299         https://bugs.webkit.org/show_bug.cgi?id=193691
1300
1301         Reviewed by Eric Carlson.
1302
1303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1305         (TEST):
1306
1307 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1308
1309         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1310         https://bugs.webkit.org/show_bug.cgi?id=191652
1311
1312         Reviewed by Alex Christensen.
1313
1314         Fix WinCairo MiniBrowser behavior of authentication dialog.
1315
1316         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1317         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1318
1319 2019-02-26  Youenn Fablet  <youenn@apple.com>
1320
1321         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1322         https://bugs.webkit.org/show_bug.cgi?id=195028
1323         <rdar://problem/48243733>
1324
1325         Reviewed by Eric Carlson.
1326
1327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1328
1329 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1330
1331         [WPE] Add API for webview background color configuration
1332         https://bugs.webkit.org/show_bug.cgi?id=192305
1333
1334         Reviewed by Michael Catanzaro.
1335
1336         * MiniBrowser/wpe/main.cpp:
1337         (main): Add a new option to configure the webview background
1338         color. Example: --bg-color=transparent.
1339         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1340         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1341         (beforeAll): Ditto.
1342
1343 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1344
1345         scalableNativeWebpageParameters() is not preserved on new page navigation.
1346         https://bugs.webkit.org/show_bug.cgi?id=194892
1347         <rdar://problem/47538280>
1348
1349         Reviewed by Wenson Hsieh.
1350         
1351         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1352
1353         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1354         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1355         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1356         (WTR::UIScriptController::allowsViewportShrinkToFit):
1357         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1358         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1359         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1360         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1361         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1362         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1363
1364 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1365
1366         [ews-app] Add model for handling multiple Buildbot instances
1367         https://bugs.webkit.org/show_bug.cgi?id=194863
1368
1369         Reviewed by Stephanie Lewis.
1370
1371         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1372
1373 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1374
1375         [ews-app] Remove BuilderMapping table
1376         https://bugs.webkit.org/show_bug.cgi?id=194961
1377
1378         Reviewed by Stephanie Lewis.
1379
1380         Store builder name directly in build table, instead of having a separate
1381         table for it.
1382
1383         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1384         * BuildSlaveSupport/ews-app/ews/models/build.py:
1385         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1386         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1387
1388 2019-02-25  John Wilander  <wilander@apple.com>
1389
1390         Introduce and adopt new class RegistrableDomain for eTLD+1
1391         https://bugs.webkit.org/show_bug.cgi?id=194791
1392         <rdar://problem/48179240>
1393
1394         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1395
1396         This patch adds an API test and replaces two instances of
1397         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1398
1399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1400         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1401         (TestWebKitAPI::TEST):
1402             Changed two strings to make sure the registrable domains are still considered
1403             invalid and pass the test.
1404         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1405         (TestWebKitAPI::TEST):
1406         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1407         (WTR::InjectedBundle::didReceiveMessageToPage):
1408
1409 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1410
1411         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1412         https://bugs.webkit.org/show_bug.cgi?id=195001
1413
1414         Reviewed by Carlos Garcia Campos.
1415
1416         API version 1.0 always includes the functionality previously guarded with
1417         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1418         unconditionally.
1419
1420         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1421         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1422         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1423         (WebViewTest::showInWindow): Ditto.
1424         (WebViewTest::hideView): Ditto.
1425         * wpe/backends/HeadlessViewBackend.cpp:
1426         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1427         * wpe/backends/ViewBackend.cpp:
1428         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1429         * wpe/backends/WindowViewBackend.cpp:
1430         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1431         WPE_BACKEND_CHECK_VERSION().
1432         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1433
1434 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1435
1436         [Flatpak] Add support for flatpak > 1.1.2
1437         https://bugs.webkit.org/show_bug.cgi?id=194088
1438
1439         Flatpak 1.2 is now out so we need to support that
1440         version now.
1441
1442         Reviewed by Michael Catanzaro.
1443
1444         * flatpak/flatpakutils.py:
1445         (check_flatpak):
1446         (FlatpakPackages.__init__):
1447         (FlatpakPackages.__detect_packages):
1448         (FlatpakPackages.__detect_packages.in):
1449         (FlatpakRepos.update):
1450
1451 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1452
1453         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1454         https://bugs.webkit.org/show_bug.cgi?id=194998
1455
1456         Reviewed by Carlos Garcia Campos.
1457
1458         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1459         to a Git checkout and using the latest commit containing various fixes
1460         and improvements.
1461
1462 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1463
1464         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1465         https://bugs.webkit.org/show_bug.cgi?id=194981
1466
1467         Reviewed by Žan Doberšek.
1468
1469         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1470         (TestWebKitAPI::TEST):
1471
1472 2019-02-23  Keith Miller  <keith_miller@apple.com>
1473
1474         Add new mac target numbers
1475         https://bugs.webkit.org/show_bug.cgi?id=194955
1476
1477         Reviewed by Tim Horton.
1478
1479         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1480         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1481         * MiniBrowser/Configurations/Base.xcconfig:
1482         * TestWebKitAPI/Configurations/Base.xcconfig:
1483         * WebKitTestRunner/Configurations/Base.xcconfig:
1484
1485 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1486
1487         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1488         https://bugs.webkit.org/show_bug.cgi?id=194846
1489
1490         Reviewed by Don Olmstead.
1491
1492         Added _search_paths() and _port_specific_expectations_files() for
1493         WinCairoPort.
1494
1495         * Scripts/webkitpy/port/win.py:
1496         (WinCairoPort.default_baseline_search_path):
1497         (WinCairoPort):
1498         (WinCairoPort._port_specific_expectations_files):
1499         (WinCairoPort._search_paths):
1500
1501 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1502
1503         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1504         https://bugs.webkit.org/show_bug.cgi?id=194963
1505
1506         Reviewed by Dean Jackson.
1507
1508         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1509         Do a `contains` check instead of `equals`, because in debug builds we
1510         put the GraphicsLayer pointer in a prefix.
1511
1512 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1513
1514         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1515         https://bugs.webkit.org/show_bug.cgi?id=194873
1516         <rdar://problem/46701974>
1517
1518         Reviewed by Tim Horton.
1519
1520         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1521
1522         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1523         (WTR::UIScriptController::menuRect const):
1524         (WTR::UIScriptController::isShowingMenu const):
1525         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1526         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1527         (WTR::UIScriptController::menuRect const):
1528
1529         Add a function to query the bounds of the callout menu in content coordinates.
1530
1531         (WTR::UIScriptController::isShowingMenu const):
1532
1533         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1534
1535         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1536         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1537         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1538         (WTR::UIScriptController::rectForMenuAction const):
1539         (WTR::UIScriptController::menuRect const):
1540         (WTR::UIScriptController::isShowingMenu const):
1541         (WTR::findViewInHierarchyOfType): Deleted.
1542
1543 2019-02-22  Chris Dumez  <cdumez@apple.com>
1544
1545         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1546         https://bugs.webkit.org/show_bug.cgi?id=194954
1547         <rdar://problem/48127957>
1548
1549         Reviewed by Alex Christensen.
1550
1551         Add API test coverage.
1552
1553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1554         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1555         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1556         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1557
1558 2019-02-22  Chris Dumez  <cdumez@apple.com>
1559
1560         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1561         https://bugs.webkit.org/show_bug.cgi?id=194924
1562         <rdar://problem/48216125>
1563
1564         Reviewed by Geoffrey Garen.
1565
1566         Add API test coverage.
1567
1568         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1569
1570 2019-02-22  Chris Dumez  <cdumez@apple.com>
1571
1572         Unreviewed, disable API test added in r241928 on iOS.
1573
1574         The cache is not enabled on devices with less than 3GB of RAM.
1575
1576         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1577
1578 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1579
1580         Hardcode Visual Viewports on everywhere except iOS WK1
1581         https://bugs.webkit.org/show_bug.cgi?id=194928
1582
1583         Reviewed by Zalan Bujtas.
1584
1585         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1586         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1587         set it to false. The setting has shipped for several years and there's no need to turn
1588         it off now.
1589
1590         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1591         Visual Viewports are not enabled.
1592         
1593         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1594         that only runs in WK2
1595
1596         * MiniBrowser/mac/SettingsController.h:
1597         * MiniBrowser/mac/SettingsController.m:
1598         (-[SettingsController init]):
1599         (-[SettingsController _populateMenu]):
1600         (-[SettingsController validateMenuItem:]):
1601         (-[SettingsController visualViewportEnabled]): Deleted.
1602         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1603         * MiniBrowser/mac/WK1BrowserWindowController.m:
1604         (-[WK1BrowserWindowController didChangeSettings]):
1605         * MiniBrowser/mac/WK2BrowserWindowController.m:
1606         (-[WK2BrowserWindowController didChangeSettings]):
1607
1608 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1609
1610         Discard cached processes when clearing website data store
1611         https://bugs.webkit.org/show_bug.cgi?id=194894
1612
1613         Reviewed by Chris Dumez.
1614
1615         Added a test case.
1616
1617         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1618         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1619
1620 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1621
1622         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1623         https://bugs.webkit.org/show_bug.cgi?id=194914
1624         <rdar://problem/47586889>
1625
1626         Reviewed by Geoffrey Garen.
1627
1628         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1629         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1630         (TEST):
1631         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1632
1633 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1634
1635         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1636         <https://webkit.org/b/194761>
1637
1638         Reviewed by Myles Maxfield.
1639
1640         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1641         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1642         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1643         to use ARC-compliant cast.
1644         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1645         ARC-compliant cast.
1646         (WTR::installFakeHelvetica): Log `error` to console if
1647         CTFontManagerRegisterFontsForURL() fails, but only on supported
1648         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1649         Call CFRelease() on `error` to fix the leak.  Update to use
1650         ARC-compliant cast.
1651         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1652         cast.
1653
1654 2019-02-21  Chris Dumez  <cdumez@apple.com>
1655
1656         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1657         https://bugs.webkit.org/show_bug.cgi?id=194481
1658
1659         Reviewed by Alex Christensen.
1660
1661         Give the processes a chance to shutdown and wait until we reached the expected number
1662         of processes.
1663
1664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1665
1666 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1667
1668         Fix the macOS build
1669
1670         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1671
1672 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1673
1674         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1675
1676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1677         I am a backwards.
1678
1679 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1680
1681         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1682
1683         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1684         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1685         We could force on UI-side compositing, but I feel like the test might be more
1686         valuable exercising the normal path on each platform (though the original
1687         bug was also UI-side specific). Though we can't validate that the overlay
1688         layer was installed successfully, there are layout tests that do that.
1689
1690 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1691
1692         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1693         https://bugs.webkit.org/show_bug.cgi?id=194845
1694         <rdar://problem/47944579>
1695
1696         Reviewed by Antti Koivisto.
1697
1698         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1699         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1700
1701 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1702
1703         [LFC][Floats] Add support for placing formatting roots in-between floats.
1704         https://bugs.webkit.org/show_bug.cgi?id=194902
1705
1706         Reviewed by Antti Koivisto.
1707
1708         * LayoutReloaded/misc/LFC-passing-tests.txt:
1709
1710 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1711
1712         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1713         https://bugs.webkit.org/show_bug.cgi?id=194901
1714
1715         Unreviewed build fix.
1716
1717         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1718         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1719         WPEBackend-fdo-0.1 as library name.
1720
1721 2019-02-21  Rob Buis  <rbuis@igalia.com>
1722
1723         Update MIME type parser
1724         https://bugs.webkit.org/show_bug.cgi?id=180526
1725
1726         Reviewed by Darin Adler.
1727
1728         Add tests involving leading and trailing whitespace, non-token
1729         characters and quoted strings.
1730
1731         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1732         (TestWebKitAPI::TEST):
1733
1734 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1735
1736         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1737         https://bugs.webkit.org/show_bug.cgi?id=194884
1738
1739         Reviewed by Michael Catanzaro.
1740
1741         * PlatformWin.cmake:
1742
1743 2019-02-20  Chris Dumez  <cdumez@apple.com>
1744
1745         Add API test for <rdar://problem/47471222>
1746         https://bugs.webkit.org/show_bug.cgi?id=194847
1747
1748         Reviewed by Alex Christensen.
1749
1750         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1751
1752 2019-02-20  Chris Dumez  <cdumez@apple.com>
1753
1754         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1755         https://bugs.webkit.org/show_bug.cgi?id=194872
1756         <rdar://problem/47924500>
1757
1758         Reviewed by Alex Christensen.
1759
1760         Add API test coverage.
1761
1762         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1763
1764 2019-02-20  Jer Noble  <jer.noble@apple.com>
1765
1766         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1767         https://bugs.webkit.org/show_bug.cgi?id=191332
1768
1769         Reviewed by Dean Jackson.
1770
1771         * Scripts/git-is-in-range: Added.
1772
1773 2019-02-20  Andy Estes  <aestes@apple.com>
1774
1775         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1776         https://bugs.webkit.org/show_bug.cgi?id=194869
1777
1778         Rubber-stamped by Jer Noble.
1779
1780         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1781         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1782         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1783         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1785         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1786
1787 2019-02-20  Chris Dumez  <cdumez@apple.com>
1788
1789         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1790         https://bugs.webkit.org/show_bug.cgi?id=194857
1791         <rdar://problem/47759323>
1792
1793         Reviewed by Alex Christensen.
1794
1795         Add API test coverage.
1796
1797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1798
1799 2019-02-20  Chris Dumez  <cdumez@apple.com>
1800
1801         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1802         https://bugs.webkit.org/show_bug.cgi?id=194829
1803         <rdar://problem/47889906>
1804
1805         Reviewed by Alexey Proskuryakov.
1806
1807         Every time the TestOptions were changing we were creating both a new Web view and
1808         a new WKContext, which would start a new Network process. In most cases, we only
1809         need to contruct a new Web view and we do can keep reusing the same WKContext.
1810         This patch implements this optimization and thus avoids spinning a lot of new
1811         Network processes while running the layout tests.
1812
1813         * WebKitTestRunner/TestController.cpp:
1814         (WTR::TestController::generateContextConfiguration const):
1815         (WTR::TestController::generatePageConfiguration):
1816         (WTR::TestController::createWebViewWithOptions):
1817         (WTR::TestController::resetPreferencesToConsistentValues):
1818         (WTR::updateTestOptionsFromTestHeader):
1819         * WebKitTestRunner/TestController.h:
1820         * WebKitTestRunner/TestOptions.h:
1821         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1822         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1823         (WTR::TestOptions::hasSameInitializationOptions const):
1824         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1825         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1826         (WTR::TestController::platformAddTestOptions const):
1827
1828 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1829
1830         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1831         https://bugs.webkit.org/show_bug.cgi?id=167941
1832
1833         Reviewed by Carlos Garcia Campos.
1834
1835         * MiniBrowser/gtk/main.c:
1836         (filterSavedCallback): Added.
1837         (main): Support loading a JSON rule set file for content filtering.
1838         * MiniBrowser/wpe/main.cpp:
1839         (filterSavedCallback): Added.
1840         (main): Support loading a JSON rule set file for content filtering.
1841         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1842         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1843         (WTF::derefGPtr): Ditto.
1844         (testEmptyStore):
1845         (testSaveInvalidFilter):
1846         (testSaveLoadFilter):
1847         (testSavedFilterIdentifierMatch):
1848         (testRemoveFilter):
1849         (testSaveMultipleFilters):
1850         (testSaveFilterFromFile):
1851         (testFilterPersistence):
1852         (beforeAll):
1853         (afterAll):
1854         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1855         (removeOldInjectedContentAndResetLists): Also reset content filters.
1856         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1857         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1858         the element affected by the style sheet.
1859         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1860         and returns it to be used by tests.
1861         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1862         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1863         (serverCallback): Add support for serving a CSS style sheet for testing.
1864         (beforeAll): Add call to testUserContentManagerContentFilter().
1865         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1866
1867 2019-02-19  Keith Rollin  <krollin@apple.com>
1868
1869         Add timing information to build output
1870         https://bugs.webkit.org/show_bug.cgi?id=194839
1871         <rdar://problem/48219609>
1872
1873         Reviewed by Alexey Proskuryakov.
1874
1875         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1876         emit each project's build time to its output. E.g.,
1877
1878             ** BUILD SUCCEEDED ** [0.132 sec]
1879
1880         * Scripts/webkitdirs.pm:
1881         (XcodeOptions):
1882
1883 2019-02-19  Truitt Savell  <tsavell@apple.com>
1884
1885         Unreviewed, rolling out r241784.
1886
1887         Broke all OpenSource builds.
1888
1889         Reverted changeset:
1890
1891         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1892         instances view"
1893         https://bugs.webkit.org/show_bug.cgi?id=172848
1894         https://trac.webkit.org/changeset/241784
1895
1896 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1897
1898         [LFC][Floats] Remove redundant intersecting logic
1899         https://bugs.webkit.org/show_bug.cgi?id=194804
1900
1901         Reviewed by Antti Koivisto.
1902
1903         * LayoutReloaded/misc/LFC-passing-tests.txt:
1904
1905 2019-02-19  Dean Jackson  <dino@apple.com>
1906
1907         Clean-up output from generate-xcfilelists so it can be filtered
1908         https://bugs.webkit.org/show_bug.cgi?id=194795
1909
1910         Reviewed by Joseph Pecoraro (and Keith Rollin).
1911
1912         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1913         make a slight tweak to filter-build-webkit so such lines are marked
1914         as plain.
1915
1916         * Scripts/filter-build-webkit:
1917         * Scripts/generate-xcfilelists:
1918
1919 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1920
1921         pytest is not correctly auto-installed
1922         https://bugs.webkit.org/show_bug.cgi?id=194707
1923
1924         Reviewed by Carlos Garcia Campos.
1925
1926         * Scripts/webkitpy/thirdparty/__init__.py:
1927         (AutoinstallImportHook._install_pytest):
1928
1929 2019-02-18  Chris Dumez  <cdumez@apple.com>
1930
1931         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1932         https://bugs.webkit.org/show_bug.cgi?id=194797
1933         <rdar://problem/48055151>
1934
1935         Reviewed by Geoffrey Garen.
1936
1937         Add API test coverage.
1938
1939         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1940
1941 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1942
1943         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1944         https://bugs.webkit.org/show_bug.cgi?id=194670
1945         <rdar://problem/39066529>
1946
1947         Reviewed by Tim Horton.
1948
1949         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1950         pasted in an editable area as attachment elements.
1951
1952         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1953         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1954         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1955         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1956         (TestWebKitAPI::TEST):
1957         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1958         (WTR::InjectedBundlePage::InjectedBundlePage):
1959
1960 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1961
1962         Fix API test after r241728
1963        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1964
1965         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1966         (TEST):
1967         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1968
1969 2019-02-18  Daniel Bates  <dabates@apple.com>
1970
1971         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1972         https://bugs.webkit.org/show_bug.cgi?id=192824
1973         <rdar://problem/47100332>
1974
1975         Reviewed by Wenson Hsieh.
1976
1977         Fix a bug where the wrong usage code was used for F13 thru F24.
1978
1979         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1980         (keyCodeForDOMFunctionKey):
1981
1982 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1983
1984         Bytecode cache should a have a boot-specific validation
1985         https://bugs.webkit.org/show_bug.cgi?id=194769
1986         <rdar://problem/48149509>
1987
1988         Reviewed by Keith Miller.
1989
1990         Add test for WTF::bootSessionUUIDString()
1991
1992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1993         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1994         (TEST):
1995
1996 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1997
1998         Disable safe browsing in WKWebView and remove its WKPreferences API
1999         https://bugs.webkit.org/show_bug.cgi?id=194723
2000         <rdar://problem/48122993>
2001
2002         Reviewed by Geoffrey Garen.
2003
2004         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2005         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2006         (TEST):
2007         (safeBrowsingView):
2008         Make tests use SPI instead of API.
2009
2010 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2011
2012         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
2013         https://bugs.webkit.org/show_bug.cgi?id=194586
2014
2015         Reviewed by Ross Kirsling.
2016
2017         * DumpRenderTree/win/DumpRenderTree.cpp:
2018         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
2019         * Scripts/webkitpy/port/driver.py:
2020         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
2021
2022 2019-02-17  David Kilzer  <ddkilzer@apple.com>
2023
2024         Unreviewed, rolling out r241620.
2025
2026         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
2027         (Requested by ddkilzer on #webkit.)
2028
2029         Reverted changeset:
2030
2031         "[WTF] Add environment variable helpers"
2032         https://bugs.webkit.org/show_bug.cgi?id=192405
2033         https://trac.webkit.org/changeset/241620
2034
2035 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2036
2037         [LFC] RenderImage's default intrinsic size is 0.
2038         https://bugs.webkit.org/show_bug.cgi?id=194745
2039
2040         Reviewed by Antti Koivisto.
2041
2042         * LayoutReloaded/misc/LFC-passing-tests.txt:
2043
2044 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2045
2046         [LFC][BFC] Add support for block replaced intrinsic width.
2047         https://bugs.webkit.org/show_bug.cgi?id=194705
2048
2049         Reviewed by Simon Fraser.
2050
2051         * LayoutReloaded/misc/LFC-passing-tests.txt:
2052
2053 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2054
2055         [LFC] Apply min/max width constraints to preferred width computation
2056         https://bugs.webkit.org/show_bug.cgi?id=194739
2057
2058         Reviewed by Simon Fraser.
2059
2060         * LayoutReloaded/misc/LFC-passing-tests.txt:
2061
2062 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
2063
2064         [WTF] Add environment variable helpers
2065         https://bugs.webkit.org/show_bug.cgi?id=192405
2066
2067         Reviewed by Michael Catanzaro.
2068
2069         * DumpRenderTree/mac/DumpRenderTree.mm:
2070         (libraryPathForDumpRenderTree):
2071         * DumpRenderTree/win/DumpRenderTree.cpp:
2072         (libraryPathForDumpRenderTree):
2073         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2074         (setUpIOSLayoutTestCommunication):
2075         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2076         (beforeAll):
2077         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2078         (main):
2079         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2080         (WebKitTestBus::run):
2081         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2082         (WTR::getOutputDir):
2083         (WTR::initializeFontConfigSetting):
2084         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2085         (WTR::InjectedBundle::platformInitialize):
2086         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2087         (WTR::topLevelPath):
2088         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2089         (WTR::topLevelPath):
2090         (WTR::getOutputDir):
2091         (WTR::activateFonts):
2092         * WebKitTestRunner/TestController.cpp:
2093         (WTR::TestController::libraryPathForTesting):
2094         (WTR::TestController::generateContextConfiguration const):
2095         (WTR::TestController::generatePageConfiguration):
2096         (WTR::TestController::decideDestinationWithSuggestedFilename):
2097         (WTR::TestController::platformAdjustContext):
2098         * WebKitTestRunner/TestController.h:
2099         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2100         (WTR::TestController::cocoaPlatformInitialize):
2101         (WTR::TestController::platformAdjustContext):
2102         * WebKitTestRunner/gtk/main.cpp:
2103         (main):
2104         * WebKitTestRunner/mac/TestControllerMac.mm:
2105         (WTR::TestController::configureContentExtensionForTest):
2106         * WebKitTestRunner/wpe/main.cpp:
2107         (main):
2108         Utilize WTF::Environment where possible.
2109
2110 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2111
2112         [iOS] WKWebView callout bar is missing Change Writing Direction item
2113         https://bugs.webkit.org/show_bug.cgi?id=190015
2114         <rdar://problem/44810366>
2115
2116         Reviewed by Tim Horton.
2117
2118         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
2119         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
2120
2121         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2122         (TestWebKitAPI::TEST):
2123
2124 2019-02-15  Chris Dumez  <cdumez@apple.com>
2125
2126         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
2127         https://bugs.webkit.org/show_bug.cgi?id=194717
2128         <rdar://problem/47884404>
2129
2130         Reviewed by Brady Eidson.
2131
2132         Add API test coverage.
2133
2134         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2135
2136 2019-02-15  Youenn Fablet  <youenn@apple.com>
2137
2138         Make navigator.mediaDevices SecureContext
2139         https://bugs.webkit.org/show_bug.cgi?id=194666
2140
2141         Reviewed by Eric Carlson.
2142
2143         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2144         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2145         (TEST_F):
2146
2147 2019-02-15  Brian Burg  <bburg@apple.com>
2148
2149         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2150         https://bugs.webkit.org/show_bug.cgi?id=194411
2151         <rdar://problem/47787614>
2152
2153         Reviewed by Joseph Pecoraro.
2154
2155         Remove unnecessary soft linking macro usage.
2156
2157         * DumpRenderTree/mac/TestRunnerMac.mm:
2158         (TestRunner::inspectorTestStubURL):
2159         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2160         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2161         (WTR::TestRunner::inspectorTestStubURL):
2162
2163 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2164
2165         Unreviewed, rolling out r241559 and r241566.
2166         https://bugs.webkit.org/show_bug.cgi?id=194710
2167
2168         Causes layout test crashes under GuardMalloc (Requested by
2169         ryanhaddad on #webkit).
2170
2171         Reverted changesets:
2172
2173         "[WTF] Add environment variable helpers"
2174         https://bugs.webkit.org/show_bug.cgi?id=192405
2175         https://trac.webkit.org/changeset/241559
2176
2177         "Unreviewed build fix for WinCairo Debug after r241559."
2178         https://trac.webkit.org/changeset/241566
2179
2180 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2181
2182         [LFC] Out-of-flow box is never a float box
2183         https://bugs.webkit.org/show_bug.cgi?id=194704
2184
2185         Reviewed by Antti Koivisto.
2186
2187         * LayoutReloaded/misc/LFC-passing-tests.txt:
2188
2189 2019-02-10  Darin Adler  <darin@apple.com>
2190
2191         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2192         https://bugs.webkit.org/show_bug.cgi?id=194487
2193
2194         Reviewed by Daniel Bates.
2195
2196         * DumpRenderTree/win/DumpRenderTree.cpp:
2197         (applicationId): Use makeString instead of String::format.
2198         (main): Ditto.
2199         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2200         (TestWebKitAPI::Util::createURLForResource): Ditto.
2201         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2202         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2203
2204         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2205         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2206         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2207         (WTR::createStringWithAttributes): Use appendLiteral.
2208         (WTR::AccessibilityUIElement::helpText const): Ditto.
2209         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2210         directly instead of using String::format.
2211         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2212         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2213
2214 2019-02-15  Truitt Savell  <tsavell@apple.com>
2215
2216         Unreviewed, rolling out r241564.
2217
2218         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2219
2220         Reverted changeset:
2221
2222         "[Mac] WebInspectorUI.framework does not need to be soft-
2223         linked anymore"
2224         https://bugs.webkit.org/show_bug.cgi?id=194411
2225         https://trac.webkit.org/changeset/241564
2226
2227 2019-02-15  Saam barati  <sbarati@apple.com>
2228
2229         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2230         https://bugs.webkit.org/show_bug.cgi?id=194036
2231
2232         Reviewed by Yusuke Suzuki.
2233
2234         * Scripts/run-jsc-stress-tests:
2235
2236 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2237
2238         Fix the build.
2239
2240         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2241         (WTR::UIScriptController::drawSquareInEditableImage):
2242         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2243         (TestWebKitAPI::drawSquareInEditableImage):
2244
2245 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2246
2247         Fix the build.
2248
2249         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2250         (WTR::UIScriptController::drawSquareInEditableImage):
2251         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2252         (TestWebKitAPI::drawSquareInEditableImage):
2253
2254 2019-02-14  Brian Burg  <bburg@apple.com>
2255
2256         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2257         https://bugs.webkit.org/show_bug.cgi?id=194411
2258         <rdar://problem/47787614>
2259
2260         Reviewed by Joseph Pecoraro.
2261
2262         Remove unnecessary soft linking macro usage.
2263
2264         * DumpRenderTree/mac/TestRunnerMac.mm:
2265         (TestRunner::inspectorTestStubURL):
2266         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2267         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2268         (WTR::TestRunner::inspectorTestStubURL):
2269
2270 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2271
2272         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2273         https://bugs.webkit.org/show_bug.cgi?id=194599
2274
2275         Reviewed by Lucas Forschler.
2276
2277         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2278         (StatusBubble._build_bubble):
2279
2280 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2281
2282         [ews-app] Set Foreign Key in Django build model
2283         https://bugs.webkit.org/show_bug.cgi?id=194667
2284
2285         Reviewed by Lucas Forschler.
2286
2287         * BuildSlaveSupport/ews-app/ews/models/build.py:
2288         (Build):
2289
2290 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2291
2292         [WTF] Add environment variable helpers
2293         https://bugs.webkit.org/show_bug.cgi?id=192405
2294
2295         Reviewed by Michael Catanzaro.
2296
2297         * DumpRenderTree/mac/DumpRenderTree.mm:
2298         (libraryPathForDumpRenderTree):
2299         * DumpRenderTree/win/DumpRenderTree.cpp:
2300         (libraryPathForDumpRenderTree):
2301         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2302         (setUpIOSLayoutTestCommunication):
2303         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2304         (TestWebKitAPI::strip):
2305         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2306         (beforeAll):
2307         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2308         (main):
2309         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2310         (WebKitTestBus::run):
2311         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2312         (WTR::getOutputDir):
2313         (WTR::initializeFontConfigSetting):
2314         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2315         (WTR::InjectedBundle::platformInitialize):
2316         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2317         (WTR::topLevelPath):
2318         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2319         (WTR::topLevelPath):
2320         (WTR::getOutputDir):
2321         (WTR::activateFonts):
2322         * WebKitTestRunner/TestController.cpp:
2323         (WTR::TestController::libraryPathForTesting):
2324         (WTR::TestController::generateContextConfiguration const):
2325         (WTR::TestController::generatePageConfiguration):
2326         (WTR::TestController::decideDestinationWithSuggestedFilename):
2327         (WTR::TestController::platformAdjustContext):
2328         * WebKitTestRunner/TestController.h:
2329         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2330         (WTR::TestController::cocoaPlatformInitialize):
2331         (WTR::TestController::platformAdjustContext):
2332         * WebKitTestRunner/gtk/main.cpp:
2333         (main):
2334         * WebKitTestRunner/mac/TestControllerMac.mm:
2335         (WTR::TestController::configureContentExtensionForTest):
2336         * WebKitTestRunner/wpe/main.cpp:
2337         (main):
2338         Utilize WTF::Environment where possible.
2339
2340 2019-02-14  Chris Dumez  <cdumez@apple.com>
2341
2342         [PSON] Introduce a WebContent Process cache
2343         https://bugs.webkit.org/show_bug.cgi?id=194594
2344         <rdar://problem/46793397>
2345
2346         Reviewed by Geoff Garen.
2347
2348         Update API tests to turn on the WebContent Process cache.
2349
2350         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2351
2352 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2353
2354         Unreviewed, build fix after r241480
2355
2356         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2357         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2358         (-[DragAndDropSimulator initWithWebView:]):
2359
2360 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2361
2362         AX: ARIA Reflection was disabled in error
2363         https://bugs.webkit.org/show_bug.cgi?id=194647
2364         <rdar://problem/48068336>
2365
2366         Reviewed by Ryosuke Niwa.
2367
2368         Remove test override now that this feature should be enabled by default.
2369
2370         * WebKitTestRunner/TestController.cpp:
2371         (WTR::TestController::resetPreferencesToConsistentValues):
2372
2373 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2374
2375         Unreviewed, rolling out r241486.
2376         https://bugs.webkit.org/show_bug.cgi?id=194655
2377
2378         causing API failures in builds (Requested by ShawnRoberts on
2379         #webkit).
2380
2381         Reverted changeset:
2382
2383         "[Cocoa] Media elements will restart network buffering just
2384         before suspending"
2385         https://bugs.webkit.org/show_bug.cgi?id=193691
2386         https://trac.webkit.org/changeset/241486
2387
2388 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2389
2390         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2391         https://bugs.webkit.org/show_bug.cgi?id=194622
2392
2393         Reviewed by Antti Koivisto.
2394
2395         * LayoutReloaded/misc/LFC-passing-tests.txt:
2396
2397 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2398
2399         [LFC] Shrink-to-fit-width should be constrained by min/max width
2400         https://bugs.webkit.org/show_bug.cgi?id=194653
2401
2402         Reviewed by Antti Koivisto.
2403
2404         * LayoutReloaded/misc/LFC-passing-tests.txt:
2405
2406 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2407
2408         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2409         https://bugs.webkit.org/show_bug.cgi?id=194641
2410
2411         Reviewed by Geoffrey Garen.
2412
2413         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2414         so that the test would fail without this fix.
2415
2416         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2417         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2418
2419 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2420
2421         [ews-app] Change log level for a log statement
2422
2423         Unreviewed minor fix.
2424
2425         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2426         (Patch.save_patch):
2427
2428 2019-02-13  Jer Noble  <jer.noble@apple.com>
2429
2430         [Cocoa] Media elements will restart network buffering just before suspending
2431         https://bugs.webkit.org/show_bug.cgi?id=193691
2432
2433         Reviewed by Eric Carlson.
2434
2435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2436         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2437         (TEST):
2438
2439 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2440
2441         [ews-app] Fetch builder id to name mapping
2442         https://bugs.webkit.org/show_bug.cgi?id=194355
2443
2444         Reviewed by Lucas Forschler.
2445
2446         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2447         (Buildbot.get_builder_id_to_name_mapping):
2448         (Buildbot._get_display_name_from_builder_name):
2449
2450 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2451
2452         Further restricting webarchive loads
2453         https://bugs.webkit.org/show_bug.cgi?id=194567
2454         <rdar://problem/47610130>
2455
2456         Reviewed by Youenn Fablet.
2457
2458         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2459         navigations on drop.
2460
2461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2462         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2463         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2464         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2465         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2466         (TestWebKitAPI::TEST):
2467         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2468         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2469         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2470         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2471         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2472         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2473         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2474
2475 2019-02-13  John Wilander  <wilander@apple.com>
2476
2477         Store Ad Click Attribution requests in the network process
2478         https://bugs.webkit.org/show_bug.cgi?id=194510
2479         <rdar://problem/47650118>
2480
2481         Reviewed by Alex Christensen and Daniel Bates.
2482
2483         This patch adds two TestRunner functions:
2484         - dumpAdClickAttribution()
2485         - clearAdClickAttribution()
2486
2487         They call into the network process to dump and clear Ad Click
2488         Attribution state, respectively.
2489
2490         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2491         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2492         (WTR::TestRunner::dumpAdClickAttribution):
2493         (WTR::TestRunner::clearAdClickAttribution):
2494         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2495         * WebKitTestRunner/TestController.cpp:
2496         (WTR::TestController::resetStateToConsistentValues):
2497         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2498         (WTR::adClickAttributionStringResultCallback):
2499         (WTR::TestController::dumpAdClickAttribution):
2500         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2501         (WTR::adClickAttributionVoidCallback):
2502         (WTR::TestController::clearAdClickAttribution):
2503         * WebKitTestRunner/TestController.h:
2504         * WebKitTestRunner/TestInvocation.cpp:
2505         (WTR::TestInvocation::dumpResults):
2506         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2507         (WTR::TestInvocation::dumpAdClickAttribution):
2508         * WebKitTestRunner/TestInvocation.h:
2509
2510 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2511
2512         [ews-app] Generate status-bubble
2513         https://bugs.webkit.org/show_bug.cgi?id=194572
2514
2515         Reviewed by Lucas Forschler.
2516
2517         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2518         (StatusBubble._build_bubble):
2519         (StatusBubble._should_show_bubble_for):
2520         (StatusBubble._build_bubbles_for_patch):
2521
2522 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2523
2524         [ews-app] Add status bubble html template
2525         https://bugs.webkit.org/show_bug.cgi?id=194571
2526
2527         Reviewed by Lucas Forschler.
2528
2529         * BuildSlaveSupport/ews-app/ews/templates: Added.
2530         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2531
2532 2019-02-12  Chris Dumez  <cdumez@apple.com>
2533
2534         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2535         https://bugs.webkit.org/show_bug.cgi?id=194568
2536         <rdar://problem/47944490>
2537
2538         Reviewed by Ryosuke Niwa.
2539
2540         Add API test coverage.
2541
2542         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2543         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2544
2545 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2546
2547         webkitpy: Remove bug_dummy from parsed test expectations
2548         https://bugs.webkit.org/show_bug.cgi?id=194562
2549         <rdar://problem/47853999>
2550
2551         Reviewed by Lucas Forschler.
2552
2553         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2554         (TestExpectationParser):
2555         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2556         skipped tests.
2557         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2558
2559 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2560
2561         [ews-app] Add method to fetch patch
2562         https://bugs.webkit.org/show_bug.cgi?id=194518
2563
2564         Reviewed by Lucas Forschler.
2565
2566         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2567         (Patch.get_patch):
2568
2569 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2570
2571         [LFC] Expand tests coverage (60 new tests -> 860)
2572
2573         Unreviewed test gardening (run-singly, --child-processes=1).
2574
2575         * LayoutReloaded/misc/LFC-passing-tests.txt:
2576
2577 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2578
2579         Allow pages to trigger programmatic paste from script on iOS
2580         https://bugs.webkit.org/show_bug.cgi?id=194271
2581         <rdar://problem/47808810>
2582
2583         Reviewed by Tim Horton.
2584
2585         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2586
2587         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2588         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2589         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2590         (WTR::UIScriptController::rectForMenuAction const):
2591
2592         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2593         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2594         for when the menu is shown or hidden.
2595
2596         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2597         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2598         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2599         (WTR::UIScriptController::setDidShowMenuCallback):
2600         (WTR::UIScriptController::didShowMenuCallback const):
2601         (WTR::UIScriptController::setDidHideMenuCallback):
2602         (WTR::UIScriptController::didHideMenuCallback const):
2603         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2604         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2605         (WTR::UIScriptController::rectForMenuAction const):
2606         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2607         * WebKitTestRunner/TestController.cpp:
2608         (WTR::TestController::resetPreferencesToConsistentValues):
2609         (WTR::updateTestOptionsFromTestHeader):
2610         * WebKitTestRunner/TestOptions.h:
2611
2612         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2613         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2614
2615         (WTR::TestOptions::hasSameInitializationOptions const):
2616         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2617         (WTR::UIScriptController::calendarType const):
2618         (WTR::UIScriptController::platformUndoManager const):
2619         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2620         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2621         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2622         (-[TestRunnerWKWebView dealloc]):
2623         (-[TestRunnerWKWebView _didShowMenu]):
2624         (-[TestRunnerWKWebView _didHideMenu]):
2625
2626         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2627
2628         * WebKitTestRunner/ios/TestControllerIOS.mm:
2629         (WTR::handleMenuWillHideNotification):
2630         (WTR::handleMenuDidHideNotification):
2631         (WTR::TestController::platformInitialize):
2632         (WTR::TestController::platformDestroy):
2633         (WTR::TestController::platformResetStateToConsistentValues):
2634
2635         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2636         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2637
2638         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2639         (WTR::forEachViewInHierarchy):
2640         (WTR::findViewInHierarchyOfType):
2641
2642         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2643         functions that dig through a given view's hierarchy in search of a view of a given class.
2644
2645         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2646         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2647         (WTR::UIScriptController::selectionCaretViewRect const):
2648         (WTR::UIScriptController::selectionRangeViewRects const):
2649         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2650         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2651
2652         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2653
2654         (WTR::UIScriptController::rectForMenuAction const):
2655
2656         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2657         callout bar) whose label matches the given string.
2658
2659         (WTR::UIScriptController::platformContentView const):
2660
2661         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2662         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2663         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2664
2665         (WTR::UIScriptController::platformUndoManager const): Deleted.
2666         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2667         (WTR::UIScriptController::platformContentView const):
2668         (WTR::UIScriptController::platformUndoManager const): Deleted.
2669
2670 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2671
2672         webkitpy: No option to only show unexpected failures in results.html for iPad
2673         https://bugs.webkit.org/show_bug.cgi?id=194554
2674         <rdar://problem/47922442>
2675
2676         Rubber-stamped by Aakash Jain.
2677
2678         Just because a TestExpecations file does not exist for a specific platform does not mean that
2679         TestExpecations are not being used, given that platforms inherit test expectations.
2680
2681         * Scripts/webkitpy/port/base.py:
2682         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2683         * Scripts/webkitpy/port/base_unittest.py:
2684         (PortTest.test_uses_test_expectations_file):
2685
2686 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2687
2688         Remove setDefersLoading infrastructure from WebKit2
2689         https://bugs.webkit.org/show_bug.cgi?id=194506
2690
2691         Reviewed by Brady Eidson.
2692
2693         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2694         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2695         (WTR::TestRunner::setDefersLoading): Deleted.
2696         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2697
2698 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2699
2700         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2701         https://bugs.webkit.org/show_bug.cgi?id=194522
2702         <rdar://problem/47789393>
2703
2704         Reviewed by Chris Dumez.
2705
2706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2707         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2708         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2709         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2710
2711 2019-02-12  Andy Estes  <aestes@apple.com>
2712
2713         [iOSMac] Enable Parental Controls Content Filtering
2714         https://bugs.webkit.org/show_bug.cgi?id=194521
2715         <rdar://39732376>
2716
2717         Reviewed by Tim Horton.
2718
2719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2720
2721 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2722
2723         [LFC][IFC] Add intrinsic width support for float boxes.
2724         https://bugs.webkit.org/show_bug.cgi?id=194528
2725
2726         Reviewed by Antti Koivisto.
2727
2728         Expand tests coverage (2 new tests -> 800).
2729         (This is the correct test ordering --runs-singly --child-processes=1)
2730
2731         * LayoutReloaded/misc/LFC-passing-tests.txt:
2732
2733 2019-02-12  Rob Buis  <rbuis@igalia.com>
2734
2735         Implement serializing in MIME type parser
2736         https://bugs.webkit.org/show_bug.cgi?id=193909
2737
2738         Reviewed by Darin Adler.
2739
2740         Add various tests involving upper case, non-ASCII, control/null characters,
2741         various HTTP whitespace, single quotes and an unpaired surrogate.
2742
2743         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2744         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2745         (TestWebKitAPI::serializeIfValid):
2746         (TestWebKitAPI::TEST):
2747
2748 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2749
2750         [Cocoa] Ask platform for generic font family mappings
2751         https://bugs.webkit.org/show_bug.cgi?id=187723
2752         <rdar://problem/41892438>
2753
2754         Reviewed by Brent Fulgham.
2755
2756         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2757
2758         * DumpRenderTree/mac/DumpRenderTree.mm:
2759         (allowedFontFamilySet):
2760         * WebKitTestRunner/mac/TestControllerMac.mm:
2761         (WTR::allowedFontFamilySet):
2762
2763 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2764
2765         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2766         https://bugs.webkit.org/show_bug.cgi?id=193622
2767
2768         Reviewed by Michael Catanzaro.
2769
2770         This adds support for loading content extension rule sets from the JSON files which
2771         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2772         of WKTR for this could be removed, but that is left for a follow-up patch with
2773         cleanups.
2774
2775         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2776         * WebKitTestRunner/TestController.cpp:
2777         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2778         avoid having the null-terminator copied into the result.
2779         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2780         part of the preparations to run a test.
2781         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2782         (WTR::contentExtensionStoreCallback): Added.
2783         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2784         used for content extensions test.
2785         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2786         extensions and compiling the JSON rule set for tests involving content extensions.
2787         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2788         testing and disables content extensions.
2789         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2790         resetContentExtensions().
2791         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2792         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2793         configureContentExtensionForTest(), and userContentController().
2794
2795 2019-02-11  Daniel Bates  <dabates@apple.com>
2796
2797         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2798         https://bugs.webkit.org/show_bug.cgi?id=191446
2799         <rdar://problem/45929460>
2800
2801         Reviewed by Tim Horton.
2802
2803         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2804
2805         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2806         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2807         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2808         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2809         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2810         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2811         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2812         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2813         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2814         (WTR::arrayLength):
2815         (WTR::parseModifierArray):
2816         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2817         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2818         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2819         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2820
2821 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2822
2823         Unreviewed, rolling out r241272 and r241276.
2824         https://bugs.webkit.org/show_bug.cgi?id=194514
2825
2826         Broke the Apple Internal build and the fix requires human
2827         intervention :( (Requested by dydz on #webkit).
2828
2829         Reverted changesets:
2830
2831         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2832         https://bugs.webkit.org/show_bug.cgi?id=191446
2833         https://trac.webkit.org/changeset/241272
2834
2835         "Fix internal iOS build after r241272"
2836         https://bugs.webkit.org/show_bug.cgi?id=191446
2837         https://trac.webkit.org/changeset/241276
2838
2839 2019-02-11  Truitt Savell  <tsavell@apple.com>
2840
2841         Unreviewed, rolling out r241269.
2842
2843         Caused 5 layout tests crashes on Mac WK1
2844
2845         Reverted changeset:
2846
2847         "DumpRenderTree should report unknown options"
2848         https://bugs.webkit.org/show_bug.cgi?id=191303
2849         https://trac.webkit.org/changeset/241269
2850
2851 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2852
2853         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2854         https://bugs.webkit.org/show_bug.cgi?id=194313
2855
2856         Reviewed by Tim Horton.
2857
2858         Add a helper to determine whether the web view is presenting modal UI.
2859
2860         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2861         (WTR::UIScriptController::isPresentingModally const):
2862         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2863         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2864         (WTR::UIScriptController::isPresentingModally const):
2865         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2866         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2867         (WTR::UIScriptController::calendarType const): Deleted.
2868         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2869         (WTR::UIScriptController::isPresentingModally const):
2870         (WTR::UIScriptController::calendarType const):
2871         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2872         (WTR::UIScriptController::calendarType const):
2873
2874 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2875
2876         GCHeapInspector: Show the retained sizes in more places
2877         https://bugs.webkit.org/show_bug.cgi?id=194464
2878
2879         Reviewed by Simon Fraser.
2880
2881         * GCHeapInspector/gc-heap-inspector.html:
2882         * GCHeapInspector/script/interface.js:
2883         (HeapInspectorUtils.humanReadableSize):
2884         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2885         (HeapInspectorUtils.spanForNode.span.span):
2886         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2887         (HeapSnapshotInspector.prototype.buildRoots):
2888
2889 2019-02-11  Daniel Bates  <dabates@apple.com>
2890
2891         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2892         https://bugs.webkit.org/show_bug.cgi?id=191446
2893         <rdar://problem/45929460>
2894
2895         Reviewed by Tim Horton.
2896
2897         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2898
2899         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2900         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2901         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2902         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2903         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2904         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2905         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2906         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2907         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2908         (WTR::arrayLength):
2909         (WTR::parseModifierArray):
2910         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2911         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2912         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2913         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2914
2915 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2916
2917         DumpRenderTree should report unknown options
2918         https://bugs.webkit.org/show_bug.cgi?id=191303
2919
2920         Reviewed by Frédéric Wang.
2921
2922         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2923         to report unknown options.
2924         Added and assigned test options which are currently used in tests.
2925
2926         * DumpRenderTree/TestOptions.cpp:
2927         (TestOptions::TestOptions):
2928
2929 2019-02-11  Truitt Savell  <tsavell@apple.com>
2930
2931         Unreviewed, rolling out r241229.
2932
2933         Revision broke internal builds for watchOS.
2934
2935         Reverted changeset:
2936
2937         "[Cocoa] Ask platform for generic font family mappings"
2938         https://bugs.webkit.org/show_bug.cgi?id=187723
2939         https://trac.webkit.org/changeset/241229
2940
2941 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2942
2943         [WinCairo][MiniBrowser] Basic authentication always fails.
2944         https://bugs.webkit.org/show_bug.cgi?id=194496
2945
2946         Reviewed by Don Olmstead.
2947
2948         * MiniBrowser/win/DialogHelper.h:
2949         (Dialog::getText):
2950
2951 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2952
2953         [GStreamer] GstMappedBuffer testsuite build fails
2954         https://bugs.webkit.org/show_bug.cgi?id=194495
2955
2956         Reviewed by Carlos Garcia Campos.
2957
2958         Fix the build by explicitely adding the gstreamer1.0-audio include
2959         directories to the include path.
2960
2961         * TestWebKitAPI/PlatformGTK.cmake:
2962         * TestWebKitAPI/PlatformWPE.cmake:
2963
2964 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2965
2966         [GTK][WPE] Add enable-javascript-markup setting
2967         https://bugs.webkit.org/show_bug.cgi?id=193439
2968
2969         Reviewed by Michael Catanzaro.
2970
2971         Add test cases to check the new setting.
2972
2973         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2974         (testWebKitSettings):
2975         (testWebKitSettingsJavaScriptMarkup):
2976         (beforeAll):
2977
2978 2019-02-10  Darin Adler  <darin@apple.com>
2979
2980         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2981         https://bugs.webkit.org/show_bug.cgi?id=194485
2982
2983         Reviewed by Daniel Bates.
2984
2985         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2986
2987 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2988
2989         Add more tests for clampTo<>()
2990         https://bugs.webkit.org/show_bug.cgi?id=194462
2991
2992         Reviewed by Geoffrey Garen.
2993
2994         Darin suggested to test the very last floating point number
2995         at the boundaries when truncating to integer.
2996         I added test for max/min and max-1/min-1.
2997
2998         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2999         (TestWebKitAPI::TEST):
3000
3001 2019-02-09  Darin Adler  <darin@apple.com>
3002
3003         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
3004         https://bugs.webkit.org/show_bug.cgi?id=194021
3005
3006         Reviewed by Geoffrey Garen.
3007
3008         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3009         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
3010         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
3011
3012 2019-02-09  Zalan Bujtas  <zalan@apple.com>
3013
3014         [LFC][IFC] Add intrinsic width support for basic inline containers
3015         https://bugs.webkit.org/show_bug.cgi?id=194473
3016
3017         Reviewed by Antti Koivisto.
3018
3019         Expand tests coverage (11 new tests -> 798)
3020
3021         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
3022
3023 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3024
3025         Fix MiniBrowser's entitlements
3026         https://bugs.webkit.org/show_bug.cgi?id=192431
3027
3028         Reviewed by Joseph Pecoraro.
3029
3030         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
3031         files, making it impossible to load any extension.
3032
3033         * MiniBrowser/MiniBrowser.entitlements:
3034
3035 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
3036
3037         [Cocoa] Ask platform for generic font family mappings
3038         https://bugs.webkit.org/show_bug.cgi?id=187723
3039         <rdar://problem/41892438>
3040
3041         Reviewed by Brent Fulgham.
3042
3043         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3044
3045         * DumpRenderTree/mac/DumpRenderTree.mm:
3046         (allowedFontFamilySet):
3047         * WebKitTestRunner/mac/TestControllerMac.mm:
3048         (WTR::allowedFontFamilySet):
3049
3050 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
3051
3052         [GTK] Implement back/forward touchpad gesture
3053         https://bugs.webkit.org/show_bug.cgi?id=193919
3054
3055         Reviewed by Michael Catanzaro.
3056
3057         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3058         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
3059
3060 2019-02-08  Alex Christensen  <achristensen@webkit.org>
3061
3062         Add SPI to use networking daemon instead of XPC service
3063         https://bugs.webkit.org/show_bug.cgi?id=194427
3064
3065         Reviewed by Geoffrey Garen
3066
3067         * MiniBrowser/MiniBrowser.entitlements:
3068
3069 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3070
3071         [ews-build] Ensure that every builder in config.json has short name
3072         https://bugs.webkit.org/show_bug.cgi?id=194461
3073
3074         Reviewed by Lucas Forschler.
3075
3076         * BuildSlaveSupport/ews-build/loadConfig.py:
3077         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3078
3079 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3080
3081         [ews-build] Add short name to config.json
3082         https://bugs.webkit.org/show_bug.cgi?id=194456
3083
3084         Reviewed by Lucas Forschler.
3085
3086         * BuildSlaveSupport/ews-build/config.json: Added short name.
3087         * BuildSlaveSupport/ews-build/loadConfig.py:
3088         (loadBuilderConfig): Set the short name as the builder description.
3089
3090 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
3091
3092         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
3093         https://bugs.webkit.org/show_bug.cgi?id=194418
3094
3095         Reviewed by Lucas Forschler.
3096
3097         Do not include errors trying when finding crashlogs at the end of
3098         a run-webkit-tests run since we don't process those errors.
3099
3100         * Scripts/webkitpy/port/darwin.py:
3101         (DarwinPort._look_for_all_crash_logs_in_log_dir):
3102         * Scripts/webkitpy/port/ios_device.py:
3103         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
3104         * Scripts/webkitpy/port/watch_device.py:
3105         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
3106
3107 2019-02-08  Beth Dakin  <bdakin@apple.com>
3108
3109         Add afterScreenUpdates to WKSnapshotConfiguration
3110         https://bugs.webkit.org/show_bug.cgi?id=194362
3111         -and corresponding-
3112         <rdar://problem/40655528> Please add an "after screen updates" property to 
3113         WKSnapshotConfiguration (to solve blank snapshots)
3114
3115         Reviewed by Tim Horton.
3116
3117         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3118         (TEST):
3119
3120 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
3121
3122         clampTo(): do not convert the input to double when dealing with integers
3123         https://bugs.webkit.org/show_bug.cgi?id=194263
3124         <rdar://problem/47692312>
3125
3126         Reviewed by Darin Adler.
3127
3128         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3129         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
3130         (TestWebKitAPI::testClampFloatingPointToInteger):
3131         (TestWebKitAPI::testClampSameSignIntegers):
3132         (TestWebKitAPI::testClampUnsignedToSigned):
3133         (TestWebKitAPI::testClampSignedToUnsigned):
3134
3135 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
3136
3137         webkitpy: Respect --dedicated-simulators flag
3138         https://bugs.webkit.org/show_bug.cgi?id=194416
3139         <rdar://problem/47894722>
3140
3141         Reviewed by Lucas Forschler.
3142
3143         * Scripts/webkitpy/port/device_port.py:
3144         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
3145         available devices can be safely ignored.
3146
3147 2019-02-07  Keith Rollin  <krollin@apple.com>
3148
3149         Remove extra copy of 100x100-red.tga
3150         https://bugs.webkit.org/show_bug.cgi?id=194371
3151         <rdar://problem/47873465>
3152
3153         Reviewed by Said Abou-Hallawa.
3154
3155         In order to help it pass its tests, Bug 194190 added a second copy of
3156         the file 100x100-red.tga. However, it turns out that this additional
3157         file wasn't actually needed, and that that sole previous copy was
3158         sufficient. At the same time, this second copy -- which was copied to
3159         the same location in the build output as the first copy -- now caused
3160         XCBuild to complain because there were two production rules for the
3161         same output file. Address this by removing the newly-added extra copy.
3162
3163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3164         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
3165
3166 2019-02-07  Alex Christensen  <achristensen@webkit.org>
3167
3168         Deprecate WKBundlePageSetDefersLoading
3169         https://bugs.webkit.org/show_bug.cgi?id=191394
3170
3171         Reviewed by Dean Jackson.
3172
3173         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3174         (WTR::TestRunner::setDefersLoading):
3175
3176 2019-02-07  Zalan Bujtas  <zalan@apple.com>
3177
3178         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
3179         https://bugs.webkit.org/show_bug.cgi?id=194391
3180
3181         Reviewed by Antti Koivisto.
3182
3183         * LayoutReloaded/misc/LFC-passing-tests.txt:
3184
3185 2019-02-06  Keith Rollin  <krollin@apple.com>
3186
3187         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
3188         https://bugs.webkit.org/show_bug.cgi?id=193975
3189         <rdar://problem/47643306>
3190
3191         Reviewed by Tim Horton.
3192
3193         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
3194         the Info.plist file into the bundle. This step is not necessary as the
3195         implicit "bundle up all the build products into a framework" build
3196         phase does this already. Having the Copy Bundle Resources phase do
3197         this causes a conflict under XCBuild, which objects to two build
3198         phases producing the same file (Info.plist). Address this by removing
3199         Info.plist from the Copy Bundle Resources phase.
3200
3201         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3202
3203 2019-02-06  Keith Rollin  <krollin@apple.com>
3204
3205         Really enable the automatic checking and regenerations of .xcfilelists during builds
3206         https://bugs.webkit.org/show_bug.cgi?id=194357
3207         <rdar://problem/47861231>
3208
3209         Reviewed by Chris Dumez.
3210
3211         Bug 194124 was supposed to enable the automatic checking and
3212         regenerating of .xcfilelist files during the build. While related
3213         changes were included in that patch, the change to actually enable the
3214         operation somehow was omitted. This patch actually enables the
3215         operation. The check-xcfilelist.sh scripts now check
3216         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3217         from the checking.
3218
3219         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3220         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3221
3222 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3223
3224         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3225         <https://webkit.org/b/194286>
3226         <rdar://problem/47815558>
3227
3228         Reviewed by Alexey Proskuryakov.
3229
3230         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3231         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3232         WKRetainPtr<> to avoid leaking the WKDataRef.
3233
3234 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3235
3236         Unreviewed, fix a typo
3237
3238         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3239
3240 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3241
3242         [GTK][WPE] force libpsl build to use ICU in jhbuild
3243         https://bugs.webkit.org/show_bug.cgi?id=194288
3244
3245         Reviewed by Carlos Garcia Campos.
3246
3247         * gtk/jhbuild.modules:
3248         Require ICU for libpsl build in jhbuild, like done in WPE.
3249
3250 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3251
3252         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3253         https://bugs.webkit.org/show_bug.cgi?id=194209
3254
3255         Reviewed by Carlos Garcia Campos.
3256
3257         Enhance TestCookieManager to ensure this doesn't happen again.
3258
3259         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3260         (testCookieManagerPersistentStorage):
3261         (beforeAll):
3262
3263 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3264
3265         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3266         https://bugs.webkit.org/show_bug.cgi?id=194324
3267
3268         Reviewed by Andy Estes.
3269
3270         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3271         part of the name is already implicit, since this is in testing code in TestOptions.
3272
3273         * WebKitTestRunner/TestController.cpp:
3274         (WTR::TestController::generateContextConfiguration const):
3275         (WTR::updateTestOptionsFromTestHeader):
3276         * WebKitTestRunner/TestOptions.h:
3277         (WTR::TestOptions::hasSameInitializationOptions const):
3278
3279 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3280
3281         [ews-build] Allow * as platform for builders and workers
3282         https://bugs.webkit.org/show_bug.cgi?id=188533
3283
3284         Reviewed by Lucas Forschler.
3285
3286         * BuildSlaveSupport/ews-build/loadConfig.py:
3287         (checkWorkersAndBuildersForConsistency):
3288
3289 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3290
3291         [ews-build] Add few bots to config.json
3292         https://bugs.webkit.org/show_bug.cgi?id=194304
3293
3294         Reviewed by Lucas Forschler.
3295
3296         * BuildSlaveSupport/ews-build/config.json:
3297
3298 2019-02-05  Keith Rollin  <krollin@apple.com>
3299
3300         Enable the automatic checking and regenerations of .xcfilelists during builds
3301         https://bugs.webkit.org/show_bug.cgi?id=194124
3302         <rdar://problem/47721277>
3303
3304         Reviewed by Tim Horton.
3305
3306         Bug 193790 add a facility for checking -- during build time -- that
3307         any needed .xcfilelist files are up-to-date and for updating them if
3308         they are not. This facility was initially opt-in by setting
3309         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3310         the process seemed robust. Its now time to enable this facility and
3311         make it opt-out. If there is a need to disable this facility, set and
3312         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3313         running `make` or `build-webkit`, or before running Xcode from the
3314         command line.
3315
3316         Additionally, remove the step that generates a list of source files
3317         going into the UnifiedSources build step. It's only necessarily to
3318         specify Sources.txt and SourcesCocoa.txt as inputs.
3319
3320         * Scripts/generate-xcfilelists:
3321
3322 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3323
3324         [GTK][WPE] force libpsl build to use ICU in jhbuild
3325         https://bugs.webkit.org/show_bug.cgi?id=194288
3326
3327         Reviewed by Philippe Normand.
3328
3329         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3330         This can cause build failures if libidn is detected but libunistring is not available.
3331
3332         Make sure that ICU is used for runtime and builtin PSL data.
3333
3334         * gtk/jhbuild.modules:
3335         * wpe/jhbuild.modules:
3336
3337 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3338
3339         [ews-app] Modified timestamp should be updated on updating data
3340         https://bugs.webkit.org/show_bug.cgi?id=194295
3341
3342         Reviewed by Lucas Forschler.
3343
3344         * BuildSlaveSupport/ews-app/ews/models/build.py:
3345         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3346         * BuildSlaveSupport/ews-app/ews/models/step.py:
3347
3348 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3349
3350         Unreviewed, rolling out r240742.
3351
3352         Causes crashes on iOS simulator.
3353
3354         Reverted changeset:
3355
3356         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3357         not focused in a content-editable element"
3358         https://bugs.webkit.org/show_bug.cgi?id=192824
3359         https://trac.webkit.org/changeset/240742
3360
3361 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3362
3363         run-webkit-tests emits message "...running None" when running tests
3364         https://bugs.webkit.org/show_bug.cgi?id=194133
3365         <rdar://problem/47724738>
3366
3367         Reviewed by Lucas Forschler.
3368
3369         * Scripts/webkitpy/xcode/device_type.py:
3370         (DeviceType.__str__): Use both version mapping tables and use just the variant
3371         name if no version name is available.
3372         * Scripts/webkitpy/xcode/device_type_unittest.py:
3373         (DeviceTypeTest):
3374         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3375         an associated named.
3376
3377 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3378
3379         [WPE] require python3-setuptools for meson build in jhbuild
3380         https://bugs.webkit.org/show_bug.cgi?id=194287
3381
3382         Reviewed by Philippe Normand.
3383
3384         python3-setuptools is needed to build meson in jhbuild.
3385         It is already required by the GTK port.
3386
3387         * wpe/install-dependencies:
3388
3389 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3390
3391         [ews-app] Add method to save BuilderMapping to database
3392         https://bugs.webkit.org/show_bug.cgi?id=194264
3393
3394         Reviewed by Lucas Forschler.
3395
3396         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3397         (BuilderMapping.__str__):
3398         (BuilderMapping):
3399         (BuilderMapping.save_mapping):
3400         (BuilderMapping.update_mapping):
3401         (BuilderMapping.get_existing_mapping):
3402         (BuilderMapping.is_valid_mapping):
3403
3404 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3405
3406         [ews-app] Add timestamp fields for BuilderMappings
3407         https://bugs.webkit.org/show_bug.cgi?id=194266
3408
3409         Reviewed by Lucas Forschler.
3410
3411         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3412         (BuilderMapping):
3413
3414 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3415
3416         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3417         https://bugs.webkit.org/show_bug.cgi?id=174816
3418
3419         Reviewed by Michael Catanzaro.
3420
3421         Add tests for webkit_uri_for_display().
3422
3423         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3424         (testURIForDisplayUnaffected):
3425         (testURIForDisplayAffected):
3426         (beforeAll):
3427         (afterAll):
3428         * TestWebKitAPI/glib/CMakeLists.txt:
3429
3430 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3431
3432         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3433         https://bugs.webkit.org/show_bug.cgi?id=194158
3434         <rdar://problem/47737268>
3435
3436         Rubber-stamped by Aakash Jain.
3437
3438         * Scripts/webkitpy/port/device_port.py:
3439         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3440
3441 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3442
3443         [CG] Enable setAdditionalSupportedImageTypes for WK1
3444         https://bugs.webkit.org/show_bug.cgi?id=194190
3445
3446         Reviewed by Tim Horton.
3447
3448         Add a test similar to the one under WebKit Cocoa but make it create a
3449         WebView instead of a WKWebView.
3450
3451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3452         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3453         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3454         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3455         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3456         (TestWebKitAPI::runTest):
3457         (TestWebKitAPI::TEST):
3458
3459 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3460
3461         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3462         https://bugs.webkit.org/show_bug.cgi?id=194168
3463
3464         Reviewed by Simon Fraser.
3465
3466         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3467
3468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3469         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3470         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3471         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3472         (TEST):
3473         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3474         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3475
3476 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3477
3478         REGRESSION (r237269): webkit-patch what-broke is broken 
3479         https://bugs.webkit.org/show_bug.cgi?id=193025
3480
3481         Reviewed by Aakash Jain.
3482
3483         * Scripts/webkitpy/common/host.py:
3484         (Host.buildbot):
3485         (Host.bugzilla): Renamed to 'buildbot'.
3486
3487 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3488
3489         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3490         https://bugs.webkit.org/show_bug.cgi?id=194207
3491
3492         Reviewed by Tim Horton.
3493
3494         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3495         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3496         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3497         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3498         start and delete forwards to remove the original attachment.
3499
3500         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3501         (TestWebKitAPI::TEST):
3502
3503 2019-02-04  Youenn Fablet  <youenn@apple.com>
3504
3505         Capture state should be managed consistently when doing process swapping
3506         https://bugs.webkit.org/show_bug.cgi?id=194122
3507         <rdar://problem/47609293>
3508
3509         Reviewed by Eric Carlson.
3510
3511         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3512         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3513         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3514         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3515         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3516         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3517         (WTR::TestRunner::isDoingMediaCapture const):
3518         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3519         * WebKitTestRunner/TestController.cpp:
3520         (WTR::TestController::isDoingMediaCapture const):
3521         * WebKitTestRunner/TestController.h:
3522         * WebKitTestRunner/TestInvocation.cpp:
3523         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3524         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3525         (WTR::TestController::isDoingMediaCapture const):
3526
3527 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3528
3529         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3530         https://bugs.webkit.org/show_bug.cgi?id=194142
3531
3532         Reviewed by Ross Kirsling.
3533
3534         There three 'separator' variables in TestController.cpp. Renamed
3535         it 'pathSeparator', and unified them.
3536
3537         * WebKitTestRunner/TestController.cpp:
3538         (WTR::TestController::generateContextConfiguration const):
3539         (WTR::createTestURL):
3540         (WTR::TestController::platformAdjustContext):
3541
3542 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3543
3544         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3545         https://bugs.webkit.org/show_bug.cgi?id=194198
3546
3547         Reviewed by Antti Koivisto.
3548
3549         No need to set the banner heights on navigation now, since Page stores them.
3550
3551         * MiniBrowser/mac/WK2BrowserWindowController.m:
3552         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3553
3554 2019-02-03  John Wilander  <wilander@apple.com>
3555
3556         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3557         https://bugs.webkit.org/show_bug.cgi?id=194104
3558         <rdar://problem/47649991>
3559
3560         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3561
3562         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3563         (TestWebKitAPI::TEST):
3564             Changed numeric types from unsigned short to uint32_t.
3565
3566 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3567
3568         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3569         <https://webkit.org/b/194178>
3570         <rdar://problem/47753473>
3571
3572         Reviewed by Alexey Proskuryakov.
3573
3574         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3575         (WTR::uninstallFakeHelvetica): Pass nullptr into
3576         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3577
3578 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3579
3580         [LFC] Initialize ICB's style with fixed width/height.
3581         https://bugs.webkit.org/show_bug.cgi?id=194188
3582
3583         Reviewed by Antti Koivisto.
3584
3585         * LayoutReloaded/misc/LFC-passing-tests.txt:
3586
3587 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3588
3589         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3590         https://bugs.webkit.org/show_bug.cgi?id=194185
3591
3592         Reviewed by Antti Koivisto.
3593
3594         * LayoutReloaded/misc/LFC-passing-tests.txt:
3595
3596 2018-12-16  Darin Adler  <darin@apple.com>
3597
3598         Convert additional String::format clients to alternative approaches
3599         https://bugs.webkit.org/show_bug.cgi?id=192746
3600
3601         Reviewed by Alexey Proskuryakov.
3602
3603         * WebKitTestRunner/TestController.cpp:
3604         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3605         as an intermediate in code that ultimately constructs a WTF::String.
3606         (WTR::userMediaOriginHash): Use makeString.
3607         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3608         (WTR::TestController::didPerformClientRedirect): Ditto.
3609         (WTR::TestController::didPerformServerRedirect): Ditto.
3610         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3611
3612 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3613
3614         [ews-build] Add unit test to verify builder keys
3615         https://bugs.webkit.org/show_bug.cgi?id=194152
3616
3617         Reviewed by Lucas Forschler.
3618
3619         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3620         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3621
3622 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3623
3624         [LFC] Expand tests coverage (12 new tests -> 787)
3625
3626         Unreviewed test gardening.
3627
3628         * LayoutReloaded/misc/LFC-passing-tests.txt:
3629
3630 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3631
3632         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3633         https://bugs.webkit.org/show_bug.cgi?id=194163
3634
3635         Reviewed by Simon Fraser.
3636
3637         775
3638
3639         * LayoutReloaded/misc/LFC-passing-tests.txt:
3640
3641 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3642
3643         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3644         https://bugs.webkit.org/show_bug.cgi?id=194140
3645         <rdar://problem/47728098>
3646
3647         Reviewed by Tim Horton.
3648
3649         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3650         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3651         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3652
3653         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3654         test to induce an IPC deadlock when presenting a modal alert during touch start.
3655
3656         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3657         * WebKitTestRunner/TestController.cpp:
3658         (WTR::runJavaScriptAlert):
3659
3660         Add a client callback function for running JavaScript alerts.
3661
3662         (WTR::TestController::createOtherPage):
3663         (WTR::TestController::generateContextConfiguration const):
3664
3665         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3666         the fix in this patch.
3667
3668         (WTR::TestController::createWebViewWithOptions):
3669
3670         Plumb TestOptions to generateContextConfiguration.
3671
3672         (WTR::TestController::resetPreferencesToConsistentValues):
3673         (WTR::TestController::resetStateToConsistentValues):
3674         (WTR::updateTestOptionsFromTestHeader):
3675         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3676         (WTR::TestController::handleJavaScriptAlert):
3677         * WebKitTestRunner/TestController.h:
3678         * WebKitTestRunner/TestInvocation.cpp:
3679         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3680         * WebKitTestRunner/TestOptions.h:
3681         (WTR::TestOptions::hasSameInitializationOptions const):
3682
3683 2019-02-01  Chris Dumez  <cdumez@apple.com>
3684
3685         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3686         https://bugs.webkit.org/show_bug.cgi?id=193740
3687         <rdar://problem/47527267>
3688
3689         Reviewed by Alex Christensen.
3690
3691         Add API test coverage.
3692
3693         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3694
3695 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3696
3697         [ews-app] Add display name field to BuilderMapping model
3698         https://bugs.webkit.org/show_bug.cgi?id=194153
3699
3700         Reviewed by Lucas Forschler.
3701
3702         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3703         (BuilderMapping):
3704
3705 2019-02-01  Youenn Fablet  <youenn@apple.com>
3706
3707         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3708         https://bugs.webkit.org/show_bug.cgi?id=194155
3709
3710         Reviewed by Eric Carlson.
3711
3712         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3713         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3714         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3715
3716 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3717
3718         [LFC] Adjust replaced element's intrinsic ratio
3719         https://bugs.webkit.org/show_bug.cgi?id=194154
3720
3721         Reviewed by Antti Koivisto.
3722
3723         761
3724
3725         * LayoutReloaded/misc/LFC-passing-tests.txt:
3726
3727 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3728
3729         [WPE] Show test results in minibrowser
3730         https://bugs.webkit.org/show_bug.cgi?id=194150
3731
3732         Reviewed by Žan Doberšek.
3733
3734         * Scripts/webkitpy/port/wpe.py:
3735         (WPEPort.show_results_html_file):
3736
3737 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3738
3739         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3740         https://bugs.webkit.org/show_bug.cgi?id=194151
3741
3742         Reviewed by Žan Doberšek.
3743
3744         ALT + <- go back
3745         ALT + -> go forward
3746
3747         * MiniBrowser/wpe/main.cpp:
3748         (main):
3749
3750 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3751
3752         [LFC] Set intrinsic size on Layout::Replaced
3753         https://bugs.webkit.org/show_bug.cgi?id=194139
3754
3755         Reviewed by Antti Koivisto.
3756
3757         744
3758
3759         * LayoutReloaded/misc/LFC-passing-tests.txt:
3760
3761 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3762
3763         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3764         https://bugs.webkit.org/show_bug.cgi?id=194146
3765
3766         Reviewed by Xabier Rodriguez-Calvar.
3767
3768         It allows to open relative paths.
3769
3770         * MiniBrowser/wpe/main.cpp:
3771         (main):
3772
3773 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3774
3775         Update flakiness dashboard configuration after recent queue changes
3776         https://bugs.webkit.org/show_bug.cgi?id=194127
3777
3778         Rubber-stamped by Aakash Jain.
3779
3780         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3781
3782         * TestResultServer/static-dashboards/builders.jsonp:
3783
3784 2019-01-31  Youenn Fablet  <youenn@apple.com>
3785
3786         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3787         https://bugs.webkit.org/show_bug.cgi?id=194106
3788         <rdar://problem/47676333>
3789
3790         Reviewed by Ryosuke Niwa.
3791
3792         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3793         (TestWebKitAPI::didFinishNavigation):
3794         (TestWebKitAPI::TEST):
3795         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3796
3797 2019-01-31  Chris Dumez  <cdumez@apple.com>
3798
3799         Page zoom level is lost after a process swap or a crash
3800         https://bugs.webkit.org/show_bug.cgi?id=194105
3801         <rdar://problem/47610781>
3802
3803         Reviewed by Alex Christensen.
3804
3805         Add API test coverage.
3806
3807         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3808         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3809
3810 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3811
3812         Revert r238819 which is unneeded and caused a performance regression.
3813         https://bugs.webkit.org/show_bug.cgi?id=192272
3814         <rdar://problem/46664625>
3815
3816         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3817         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3818         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3819
3820 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3821
3822         Formalize WebKitAdditions mechanism of LoadOptimizer
3823         https://bugs.webkit.org/show_bug.cgi?id=193886
3824         <rdar://problem/47696809>
3825
3826         Reviewed by Brent Fulgham.
3827
3828         * MiniBrowser/MiniBrowser.entitlements:
3829         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3830
3831 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3832
3833         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3834         https://bugs.webkit.org/show_bug.cgi?id=194090
3835
3836         Reviewed by Antti Koivisto.
3837
3838         * LayoutReloaded/misc/LFC-passing-tests.txt:
3839
3840 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3841
3842         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3843         https://bugs.webkit.org/show_bug.cgi?id=194074
3844
3845         Reviewed by Antti Koivisto.
3846
3847         * LayoutReloaded/misc/LFC-passing-tests.txt:
3848
3849 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3850
3851         [LFC][BFC] Add support for block level replaced box.
3852         https://bugs.webkit.org/show_bug.cgi?id=194071
3853
3854         Reviewed by Antti Koivisto.
3855
3856         * LayoutReloaded/misc/LFC-passing-tests.txt:
3857
3858 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3859
3860         Fix WebKitTestRunner's testPath with Windows full paths
3861         https://bugs.webkit.org/show_bug.cgi?id=194012
3862
3863         Reviewed by Alex Christensen.
3864
3865         updateTestOptionsFromTestHeader failed to open test files because
3866         testPath returned wrong file paths. It returned a path "/C:/..."
3867         if a URL "file:///C:/..." was given.
3868
3869         * WebKitTestRunner/TestController.cpp:
3870         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3871
3872 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3873
3874         [WPE] Bump font related dependencies to match the GTK+ port
3875         https://bugs.webkit.org/show_bug.cgi?id=194017
3876
3877         Reviewed by Žan Doberšek.
3878
3879         * wpe/jhbuild.modules:
3880         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3881         * wpe/patches/icudata-stdlibs.patch: Added.
3882
3883 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3884
3885         Enable swipe tests on iOS
3886         https://bugs.webkit.org/show_bug.cgi?id=194076
3887
3888         Reviewed by Geoffrey Garen.
3889
3890         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3891         it causes a debug assertion failure in runUIScript.
3892
3893         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3894         (WTR::UIScriptController::beginBackSwipe):
3895         (WTR::UIScriptController::completeBackSwipe):
3896
3897 2019-01-30  Keith Rollin  <krollin@apple.com>
3898
3899         Use correct printf format specifier
3900         https://bugs.webkit.org/show_bug.cgi?id=194062
3901         <rdar://problem/47686167>
3902
3903         Reviewed by Alexey Proskuryakov.
3904
3905         LayoutTestSpellChecker.mm is trying to format a variable of type
3906         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3907         actually an unsigned long long. Fix this by formatting with %llu.
3908
3909         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3910         (-[LayoutTestTextCheckingResult description]):
3911
3912 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3913
3914         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3915         https://bugs.webkit.org/show_bug.cgi?id=193979
3916
3917         Reviewed by Wenson Hsieh.
3918
3919         Fix the test for iOS. Make the test work with iOS UA string.
3920
3921         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3922
3923 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3924
3925         Replace High Sierra LLINT CLoop bot due to hardware failure
3926         https://bugs.webkit.org/show_bug.cgi?id=194066
3927
3928         Reviewed by Aakash Jain.
3929
3930         * BuildSlaveSupport/build.webkit.org-config/config.json:
3931
3932 2019-01-30  Keith Rollin  <krollin@apple.com>
3933
3934         [NSDragItem init] is unavailable
3935         https://bugs.webkit.org/show_bug.cgi?id=194059
3936         <rdar://problem/47685715>
3937
3938         Reviewed by Wenson Hsieh.
3939
3940         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3941         DumpRenderTree and TestWebKitAPI, which both try to create an
3942         NSDragItem in a manner that invokes this method. Address this by using
3943         -initWithPasteboardWriter instead.
3944
3945         Note that the parameter passed to initWithPasteboardWriter is likely
3946         incorrect. In both cases, the object passed does not conform to
3947         NSPasteboardWriting. However, with this fix, we're no worse off than
3948         before, and can now perform builds with newer compilers and SDKs until
3949         a real fix can be crafted. That work is tracked in
3950         https://bugs.webkit.org/show_bug.cgi?id=194060
3951
3952         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3953         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3954         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3955         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3956
3957 2019-01-30  Daniel Bates  <dabates@apple.com>
3958
3959         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3960         https://bugs.webkit.org/show_bug.cgi?id=192824
3961         <rdar://problem/47100332>
3962
3963         Reviewed by Wenson Hsieh.
3964
3965         Fix a bug where the wrong usage code was used for F13 thru F24.
3966
3967         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3968         (keyCodeForDOMFunctionKey):
3969
3970 2019-01-30  Chris Dumez  <cdumez@apple.com>
3971
3972         Regression(PSON) Load hang can occur on history navigation
3973         https://bugs.webkit.org/show_bug.cgi?id=194030
3974         <rdar://problem/47656939>
3975
3976         Reviewed by Antti Koivisto.
3977
3978         Add API test coverage.
3979
3980         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3981
3982 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3983
3984         [LFC] Expand tests coverage.
3985
3986         Unreviewed test gardening.
3987
3988         * LayoutReloaded/misc/LFC-passing-tests.txt:
3989
3990 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3991
3992         [Flatpak] Add openjpeg support
3993         https://bugs.webkit.org/show_bug.cgi?id=194019
3994
3995         Reviewed by Michael Catanzaro.
3996
3997         * flatpak/org.webkit.CommonModules.yaml:
3998
3999 2019-01-30  Commit Queue  <commit-queue@webkit.org>
4000
4001         Unreviewed, rolling out r240708.
4002         https://bugs.webkit.org/show_bug.cgi?id=194022
4003
4004         It broke WPE build (Requested by KaL on #webkit).
4005
4006         Reverted changeset:
4007
4008         "[WPE] Bump font related dependencies to match the GTK+ port"
4009         https://bugs.webkit.org/show_bug.cgi?id=194017
4010         https://trac.webkit.org/changeset/240708
4011
4012 2019-01-30  Zalan Bujtas  <zalan@apple.com>
4013
4014         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
4015         https://bugs.webkit.org/show_bug.cgi?id=194001
4016
4017         Reviewed by Antti Koivisto.
4018
4019         * LayoutReloaded/misc/LFC-passing-tests.txt:
4020
4021 2019-01-30  Zalan Bujtas  <zalan@apple.com>
4022
4023         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
4024         https://bugs.webkit.org/show_bug.cgi?id=194020
4025
4026         Reviewed by Antti Koivisto.
4027
4028         * LayoutReloaded/misc/LFC-passing-tests.txt:
4029
4030 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
4031
4032         AX: Support color well on iOS
4033         https://bugs.webkit.org/show_bug.cgi?id=194010
4034
4035         Reviewed by Joanmarie Diggs.
4036
4037         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4038         (WTR::AccessibilityUIElement::stringAttributeValue):
4039
4040 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4041
4042         [WPE] Bump font related dependencies to match the GTK+ port
4043         https://bugs.webkit.org/show_bug.cgi?id=194017
4044
4045         Reviewed by Žan Doberšek.
4046
4047         * wpe/jhbuild.modules:
4048         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4049         * wpe/patches/icudata-stdlibs.patch: Added.
4050
4051 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
4052
4053         [Mac] Update window scale API usage
4054         https://bugs.webkit.org/show_bug.cgi?id=193991
4055         rdar://problem/47614795
4056
4057         Reviewed by Tim Horton.
4058
4059         * DumpRenderTree/mac/DumpRenderTree.mm:
4060         (changeWindowScaleIfNeeded):
4061         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4062         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4063         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4064
4065 2019-01-29  Chris Dumez  <cdumez@apple.com>
4066
4067         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
4068         https://bugs.webkit.org/show_bug.cgi?id=193977
4069         <rdar://problem/47643716>
4070
4071         Reviewed by Geoff Garen.
4072
4073         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
4074         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
4075         to the previous provisional committing *before* we make the last load. 
4076
4077         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4078
4079 2019-01-29  Youenn Fablet  <youenn@apple.com>
4080
4081         Adopt new SPI to evaluate server certificate trust
4082         https://bugs.webkit.org/show_bug.cgi?id=193355
4083
4084         Reviewed by Alex Christensen.
4085
4086         Add infrastructure to handle HTTPS server trust evaluation testing.
4087
4088         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4089         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4090         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
4091         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
4092         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
4093         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4094         * WebKitTestRunner/TestController.cpp:
4095         (WTR::TestController::resetPreferencesToConsistentValues):
4096         (WTR::TestController::didReceiveAuthenticationChallenge):
4097         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
4098         * WebKitTestRunner/TestController.h:
4099         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
4100         * WebKitTestRunner/TestInvocation.cpp:
4101         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4102         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4103         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
4104
4105 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4106
4107         [ews-build] Add build step to print bot Configuration
4108         https://bugs.webkit.org/show_bug.cgi?id=193887
4109
4110         Reviewed by Lucas Forschler.
4111
4112         * BuildSlaveSupport/ews-build/steps.py:
4113         (PrintConfiguration): Build step to print configuration.
4114         * BuildSlaveSupport/ews-build/factories.py:
4115
4116 2019-01-29  Chris Dumez  <cdumez@apple.com>
4117
4118         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
4119         https://bugs.webkit.org/show_bug.cgi?id=193967
4120         <rdar://problem/47635348>
4121
4122         Reviewed by Alex Christensen.
4123
4124         Add API test coverage.
4125
4126         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4127         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
4128
4129 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4130
4131         [ews-app] Handle incoming results data
4132         https://bugs.webkit.org/show_bug.cgi?id=193973
4133
4134         Reviewed by Lucas Forschler.
4135
4136         * BuildSlaveSupport/ews-app/ews/views/results.py:
4137
4138 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4139
4140         [ews-app] Make the results url generic
4141         https://bugs.webkit.org/show_bug.cgi?id=193928
4142
4143         Reviewed by Lucas Forschler.
4144
4145         * BuildSlaveSupport/ews-app/ews/urls.py:
4146
4147 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4148
4149         [ews-build] Configure buildbot to send events to ews-app
4150         https://bugs.webkit.org/show_bug.cgi?id=193968
4151
4152         Reviewed by Lucas Forschler.
4153
4154         * BuildSlaveSupport/ews-build/events.py: Added.
4155         * BuildSlaveSupport/ews-build/master.cfg:
4156
4157 2019-01-29  Keith Rollin  <krollin@apple.com>
4158
4159         Add .xcfilelists to Run Script build phases
4160         https://bugs.webkit.org/show_bug.cgi?id=193792
4161         <rdar://problem/47201785>
4162
4163         Reviewed by Alex Christensen.
4164
4165         As part of supporting XCBuild, update the necessary Run Script build
4166         phases in their Xcode projects to refer to their associated
4167         .xcfilelist files.
4168
4169         Note that the addition of these files bumps the Xcode project version
4170         number to something that's Xcode 10 compatible. This change means that
4171         older versions of the Xcode IDE can't read these projects. Nor can it
4172         fully load workspaces that refer to these projects (the updated
4173         projects are shown as non-expandable placeholders). `xcodebuild` can
4174         still build these projects; it's just that the IDE can't open them.
4175
4176         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4177         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4178
4179 2019-01-29  John Wilander  <wilander@apple.com>
4180
4181         Add data abstraction and validation for Ad Click Attribution
4182         https://bugs.webkit.org/show_bug.cgi?id=193916
4183         <rdar://problem/47603481>
4184
4185         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
4186
4187         Ad click attribution has two steps. First, the storage of an ad
4188         campaign ID for a click that takes the user to a destination
4189         site. Second, a conversion on the destination site that can be
4190         attributed to the ad click.
4191
4192         This patch adds a class that represents a request for ad click
4193         attribution. Validation makes sure that the bits of entropy
4194         reported through this mechanism is limited.
4195
4196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4197         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
4198         (TestWebKitAPI::TEST):
4199
4200 2019-01-29  Chris Dumez  <cdumez@apple.com>
4201
4202         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
4203         https://bugs.webkit.org/show_bug.cgi?id=193932
4204         <rdar://problem/47598947>
4205
4206         Reviewed by Brady Eidson.
4207
4208         Add API test coverage.
4209
4210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4211
4212 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4213
4214         Adding new passing LFC tests.
4215
4216         Unreviewed test gardening.
4217
4218         * LayoutReloaded/misc/LFC-passing-tests.txt:
4219
4220 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4221
4222         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
4223         https://bugs.webkit.org/show_bug.cgi?id=193964
4224
4225         Reviewed by Antti Koivisto.
4226
4227         * LayoutReloaded/misc/LFC-passing-tests.txt:
4228
4229 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4230
4231         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
4232         https://bugs.webkit.org/show_bug.cgi?id=193954
4233
4234         Reviewed by Antti Koivisto.
4235
4236         * LayoutReloaded/misc/LFC-passing-tests.txt:
4237
4238 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4239
4240         WebDriver: add support for running subtests
4241         https://bugs.webkit.org/show_bug.cgi?id=193904
4242
4243         Reviewed by Michael Catanzaro.
4244
4245         pytest already supports it by passing test.py::subtest, so we can do the same.
4246
4247         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
4248         (get_item_name): Made this global.
4249         (CollectRecorder.__init__): Receive the parameter to ignore.
4250         (CollectRecorder.pytest_collectreport): Collect also the subtests.
4251         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
4252         (collect): Add parameter to ignore.
4253         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
4254         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
4255         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
4256         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
4257         (WebDriverTestRunnerSelenium.run): Ditto.
4258         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
4259         (WebDriverTestRunnerW3C.collect_tests): Ditto.
4260         (WebDriverTestRunnerW3C.run): Ditto.
4261
4262 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
4263
4264         User agent string override for navigator.userAgent should be site specific quirks
4265         https://bugs.webkit.org/show_bug.cgi?id=193950
4266
4267         Reviewed by Brent Fulgham.
4268
4269         Updated per the _WKWebsitePolicies rename.
4270
4271         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4272         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4273
4274 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
4275
4276         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
4277         https://bugs.webkit.org/show_bug.cgi?id=193941
4278
4279         Reviewed by Alex Christensen.
4280
4281         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
4282         * TestWebKitAPI/Tests/WTF/Condition.cpp:
4283         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4284         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
4285         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
4286         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
4287         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
4288         * TestWebKitAPI/Tests/WTF/Time.cpp:
4289         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
4290         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
4291         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
4292         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
4293
4294 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
4295
4296         Unreviewed, reorder my emails to fix autocomplete in bugzilla
4297
4298         * Scripts/webkitpy/common/config/contributors.json:
4299
4300 2019-01-28  Andy Estes  <aestes@apple.com>
4301
4302         [watchOS] Enable Parental Controls content filtering
4303         https://bugs.webkit.org/show_bug.cgi?id=193939
4304         <rdar://problem/46641912>
4305
4306         Reviewed by Ryosuke Niwa.
4307
4308         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4309
4310 2019-01-28  David Kilzer  <ddkilzer@apple.com>
4311
4312         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
4313         <https://webkit.org/b/193884>
4314
4315         Reviewed by Jiewen Tan.
4316
4317         * Scripts/webkitpy/style/checkers/cpp.py:
4318         (check_language): Add LocalAuthentication to
4319         `frameworks_with_soft_links`.
4320
4321 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
4322
4323         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
4324         https://bugs.webkit.org/show_bug.cgi?id=193891
4325
4326         Reviewed by Ross Kirsling.
4327
4328         There were three problems in window sizes of WebView and the host window.
4329         1. The sizes of pixel image output were incorrect.
4330         2. The host window is going to appear after window.resize was invoked.
4331         3. window.resize resized only the host window, not WebView.
4332
4333         This change solves them with a following approach.
4334         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
4335         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
4336            as well as DumpRenderTree in order to match the client area and the window area.
4337         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
4338         d. PlatformWebView::setWindowFrame changes both window sizes.
4339         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
4340
4341         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4342         (WTR::PlatformWebView::PlatformWebView): Create the host window
4343         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
4344         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
4345         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
4346
4347 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4348
4349         [ews-app] Add method to save Step data to database
4350         https://bugs.webkit.org/show_bug.cgi?id=193890
4351
4352         Reviewed by Lucas Forschler.
4353
4354         * BuildSlaveSupport/ews-app/ews/models/step.py:
4355         (Step.save_step): Method to save step data.
4356         (Step.update_step): Method to update step data.
4357         (Step.get_existing_step): Method to fetch existing step from database.
4358         (Step.is_valid_result): Method to validate valid step result.
4359
4360 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4361
4362         [ews-app] Add method to save Build data to database
4363         https://bugs.webkit.org/show_bug.cgi?id=193735
4364
4365         Reviewed by Lucas Forschler.
4366
4367         * BuildSlaveSupport/ews-app/ews/models/build.py:
4368         (Build.save_build): Method to save build information to database.
4369         (Build.get_existing_build): Method to fetch existing build from database.
4370         (Build.is_valid_result): Method to validate build result.
4371         * BuildSlaveSupport/ews-app/ews/common/util.py:
4372         (is_valid_int_id): Method to validate valid id.
4373
4374 2019-01-28  Chris Dumez  <cdumez@apple.com>
4375
4376         Regression(PSON) Crash under WebPageProxy::didStartProgress()
4377         https://bugs.webkit.org/show_bug.cgi?id=193915
4378         <rdar://problem/47560907>
4379
4380         Reviewed by Alex Christensen.
4381
4382         Add API test coverage.
4383
4384         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4385
4386 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4387
4388         [ews-app] Rename id variables
4389         https://bugs.webkit.org/show_bug.cgi?id=193883
4390
4391         Reviewed by Lucas Forschler.
4392
4393         * BuildSlaveSupport/ews-app/ews/models/build.py:
4394         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
4395         * BuildSlaveSupport/ews-app/ews/models/step.py:
4396         * BuildSlaveSupport/ews-app/ews/urls.py:
4397         * BuildSlaveSupport/ews-app/ews/views/patch.py:
4398         * BuildSlaveSupport/ews-app/ews/views/results.py:
4399         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4400
4401 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4402
4403         [ews-app] Allow certain fields to be empty
4404         https://bugs.webkit.org/show_bug.cgi?id=193892
4405
4406         Reviewed by Lucas Forschler.
4407