Update LLVM binary drops and scripts to the latest version from SVN
[WebKit-https.git] / Tools / ChangeLog
1 2013-08-22  Filip Pizlo  <fpizlo@apple.com>
2
3         Update LLVM binary drops and scripts to the latest version from SVN
4         https://bugs.webkit.org/show_bug.cgi?id=120184
5
6         Reviewed by Mark Hahnenberg.
7
8         * ReducedFTL/build.sh:
9         * Scripts/configure-llvm: Added.
10         * Scripts/copy-webkitlibraries-to-product-directory:
11         * Scripts/export-llvm-build:
12
13 2013-08-22  Andy Estes  <aestes@apple.com>
14
15         <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
16
17         Reviewed by David Kilzer.
18
19         * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
20         OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
21         DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
22
23 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
24
25         NRWT: Add the ability to upload test results to new test results server
26         https://bugs.webkit.org/show_bug.cgi?id=120146
27
28         Reviewed by Andreas Kling.
29         
30         For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
31         that contains the full summary of the test run including information about passed tests.
32
33         Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
34         --build-slave
35         --got-revision
36         --results-server-host
37
38         The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
39         so we should be able to delete --test-results-server in time.
40
41         * Scripts/webkitpy/layout_tests/controllers/manager.py:
42         (Manager.run):
43         (Manager._upload_json_files):
44         (Manager):
45         (Manager.upload_results):
46         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
47         (summarize_results):
48         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
49         (summarized_results):
50         (SummarizedResultsTest.test_summarized_results_wontfix):
51         (SummarizedResultsTest):
52         (SummarizedResultsTest.test_summarized_results_include_passes):
53         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
54         (parse_args):
55
56 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
57
58         WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
59
60         * Scripts/webkitpy/tool/bot/irc_command.py:
61         (Hi.execute):
62
63 2013-08-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
64
65         [Qt] DRT bug revealed/caused by r154300
66         https://bugs.webkit.org/show_bug.cgi?id=120151
67
68         Reviewed by Simon Hausmann.
69
70         Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
71         the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
72         in r154300.
73
74         DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
75         between native Qt methods and JSC bound methods. This patch changes the check to see if the 
76         property is writable since the Qt methods are ReadOnly.
77
78         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
79         (DumpRenderTree::initJSObjects):
80
81 2013-08-21  Joseph Pecoraro  <pecoraro@apple.com>
82
83         <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
84
85         Reviewed by Benjamin Poulain.
86
87         WTFString moved the is8bit bit by one in r152201.
88
89         * lldb/lldb_webkit.py:
90         (WTFStringImplProvider.is_8bit):
91
92 2013-08-21  Tim Horton  <timothy_horton@apple.com>
93
94         Revert http://trac.webkit.org/changeset/154022, as it failed to update
95         a variety of scripts that depended on the old format.
96
97         See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
98
99         * Scripts/prepare-ChangeLog:
100         (main):
101         (generateNewChangeLogs):
102
103 2013-08-21  Brent Fulgham  <bfulgham@apple.com>
104
105         [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
106
107         * WinLauncher/WinLauncher.cpp:
108         (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
109
110 2013-08-21  Zan Dobersek  <zdobersek@igalia.com>
111
112         <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
113
114         Reviewed by Andreas Kling.
115
116         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
117         (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
118         (WTR::activateFonts): Ditto.
119
120 2013-08-21  Brian Holt  <brian.holt@samsung.com>
121
122         [GTK] Suppress irrelevant or known leaks for Valgrind
123         https://bugs.webkit.org/show_bug.cgi?id=119448
124
125         Reviewed by Martin Robinson.
126
127         Add a suppressions file to suppress known leaks for Valgrind.
128         Valgrind also takes longer when using suppressions and
129         times out unless the driver timeout is increased.
130
131         * Scripts/valgrind/suppressions.txt: Added.
132         * Scripts/webkitpy/port/gtk.py:
133         (GtkPort.driver_stop_timeout):
134         (GtkPort.setup_environ_for_server):
135
136 2013-08-20  Alex Christensen  <achristensen@apple.com>
137
138         [Windows] Linking fix for Win64.
139
140         Rubberstamped by Brent Fulgham.
141
142         * win/DLLLauncher/DLLLauncherMain.cpp:
143         (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
144
145 2013-08-20  Brent Fulgham  <bfulgham@apple.com>
146
147         <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
148
149         Reviewed by Tim Horton.
150
151         * win/DLLLauncher/DLLLauncherMain.cpp:
152         (getLastErrorString): New method to convert GetLastError to text.
153         (wWinMain): Use new error formatter to provide useful diagnostic text to user.
154
155 2013-08-19  Gustavo Noronha Silva  <gns@gnome.org>
156
157         <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
158
159         Reviewed by Martin Robinson.
160
161         * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
162         from naming/enum_casing rules, since it needs to provide GObject-style APIs.
163
164 2013-08-20  Anton Obzhirov  <a.obzhirov@samsung.com>
165
166         <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
167
168         Reviewed by Martin Robinson.
169
170         Added stop button in MiniBrowser
171
172         * MiniBrowser/gtk/BrowserWindow.c:
173         (reloadOrStopCallback): Callback to handle stop or reload button click.
174         (webViewLoadProgressChanged): Update reload or stop button icon.
175         (browser_window_init): Save button pointer for further icon updates.
176
177 2013-08-20  Simon Pena  <simon.pena@samsung.com>
178
179         <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
180
181         Reviewed by Alexey Proskuryakov.
182
183         Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
184         printing didFailLoadWithError.
185
186         Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
187         DumpRenderTree, printing didFailLoadWithError.
188
189         * DumpRenderTree/gtk/DumpRenderTree.cpp:
190         (webFrameLoadStatusNotified):
191
192 2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>
193
194         <https://webkit.org/b/120049> Delete code for Snow Leopard
195
196         Reviewed by Benjamin Poulain.
197
198         * DumpRenderTree/mac/CheckedMalloc.cpp:
199         (protectionOfRegion):
200         (makeLargeMallocFailSilently):
201         * DumpRenderTree/mac/DumpRenderTree.mm:
202         (resetDefaultsToConsistentValues):
203         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
204         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
205         * DumpRenderTree/mac/FrameLoadDelegate.mm:
206         (testPathFromURL):
207         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
208         * DumpRenderTree/mac/LayoutTestHelper.m:
209         * DumpRenderTree/mac/TestRunnerMac.mm:
210         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
211         (WTR::InjectedBundle::platformInitialize):
212         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
213         (WTR::testPathFromURL):
214         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
215
216 2013-08-19  Alexey Proskuryakov  <ap@apple.com>
217
218         https://bugs.webkit.org/show_bug.cgi?id=119915
219         REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
220
221         Reviewed by Darin Adler.
222
223         The issue was that we ended up having no CFNetwork cache in the testing session due
224         to an incorrect cache model. There is a number of things not implemented when it
225         comes to dynamically changing cache model as attempted by WebKitTestRunner, but
226         the easiest way to get this going is to initialize it to correct value upfront.
227
228         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
229
230 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
231
232         REGRESSION(r154275): webkitpy tests failing
233         https://bugs.webkit.org/show_bug.cgi?id=120010
234
235         Reviewed by Jocelyn Turcotte.
236
237         Update unit-tests to tests the new search-path structure,
238         but reverting the architecture search path addition.
239
240         * Scripts/webkitpy/port/qt.py:
241         (QtPort):
242         (QtPort.__init__):
243         (QtPort._generate_all_test_configurations):
244         (QtPort.qt_architecture):
245         * Scripts/webkitpy/port/qt_unittest.py:
246         (QtPortTest):
247         (QtPortTest._assert_search_path):
248         (QtPortTest._assert_expectations_files):
249         (QtPortTest._qt_version):
250
251 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
252
253         [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
254
255         Unreviewed meta gardening.
256
257         We need to keep using the qt-5.0-wk2 path until it is fully migrated.
258
259         * Scripts/webkitpy/port/qt.py:
260         (QtPort._search_paths):
261
262 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
263
264         Restructure Qt test expectations
265
266         Unreviewed meta gardening.
267
268         Removed 5.0 name from WK1 and WK2 results and made it possible to set
269         expectations by both Qt version and mayor architectures.
270
271         * Scripts/webkitpy/port/qt.py:
272         (QtPort._wk2_port_name):
273         (QtPort.__init__):
274         (QtPort.qt_version):
275         (QtPort.architecture):
276         (QtPort._search_paths):
277         (QtPort._port_specific_expectations_files):
278
279 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
280
281         [Windows] DRT is not using the same preferences as the Mac build.
282         https://bugs.webkit.org/show_bug.cgi?id=119822
283
284         Reviewed by Darin Adler.
285
286         * DumpRenderTree/win/DumpRenderTree.cpp:
287         (runTest): Process Windows message queue using CFRunLoop to allow
288         dispatch routines to run properly.
289         (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
290         to prevent problems on WinCairo port.
291
292 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
293
294         [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
295         https://bugs.webkit.org/show_bug.cgi?id=119583
296
297         Reviewed by Alexey Proskuryakov.
298
299         * DumpRenderTree/win/DumpRenderTree.cpp:
300         (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
301         component if the URL does not contain the expected base URL.
302
303 2013-08-16  Pratik Solanki  <psolanki@apple.com>
304
305         <https://webkit.org/b/119852> Frame::scriptController() should return a reference
306
307         Reviewed by Andreas Kling.
308
309         m_script is never NULL so we can just return a reference. Also remove some pointless null
310         checks as a result of doing this.
311
312         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
313         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
314
315 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
316
317         [WK2] NetworkProcess should use a temporary storage session for test
318         https://bugs.webkit.org/show_bug.cgi?id=119855
319
320         Reviewed by Darin Adler.
321
322         Use a new API that takes care of both WebProcess and NetworkProcess.
323
324         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
325         (WTR::InjectedBundle::initialize):
326         * WebKitTestRunner/TestController.cpp:
327         (WTR::TestController::initialize):
328
329 2013-08-15  Bem Jones-Bey  <bjonesbe@adobe.com>
330
331         <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
332
333         Reviewed by Dirk Pranke.
334
335         This is a port from Blink of
336         https://src.chromium.org/viewvc/blink?revision=155647&view=revision
337         originally by Dirk Pranke.
338
339         From the original commit:
340
341         This gives something like a 15x speedup over compiling and matching
342         one property at a time and doing multiple passes over the file.
343
344         * Scripts/webkitpy/w3c/test_converter.py:
345         (W3CTestConverter.__init__):
346         (W3CTestConverter.convert_prefixed_properties):
347         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
348
349 2013-08-15  Dan Bernstein  <mitz@apple.com>
350
351         <https://webkit.org/b/119856> Improve extract-localizable-strings messages
352
353         Reviewed by Darin Adler.
354
355         * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
356         added a message that points to the source code. Removed some unnecessary repetition of what
357         is already in the file.
358
359 2013-08-15  Andy Estes  <aestes@apple.com>
360
361         <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
362
363         Reviewed by Brady Eidson.
364
365         Wrote an API test that verifies -[WebView stopLoading:] can be called
366         inside webView:resource:didFinishLoadingFromDataSource: without crashing.
367
368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
369         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
370         (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
371         (TestWebKitAPI::TEST):
372
373 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
374
375         Adding Myles Maxfield to contributors.json.
376
377         Oops, wrong section, fixing.
378
379         * Scripts/webkitpy/common/config/contributors.json:
380
381 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
382
383         Adding Myles Maxfield to contributors.json.
384
385         * Scripts/webkitpy/common/config/contributors.json:
386
387 2013-08-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
388
389         [Qt] Do not check specifically for version 5.0
390         https://bugs.webkit.org/show_bug.cgi?id=119846
391
392         Reviewed by Jocelyn Turcotte.
393
394         For Qt 5.x we should always use both wk1 and wk2 basepath results.
395
396         * Scripts/webkitpy/port/qt.py:
397         (QtPort._search_paths):
398
399 2013-08-15  Simon Pena  <simon.pena@samsung.com>
400
401         <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
402
403         Reviewed by Gustavo Noronha Silva.
404
405         Following a similar approach as in r153977, return a path string
406         that is relative to main frame URL or just file name if the
407         resource is not in the same directory subtree, and replace empty
408         strings with "(null)".
409
410         Update pathFromSoupURI so it behaves more closely to the other
411         ports, and remove the unused code after we no longer print
412         <unknown> in certain cases. Also move
413         soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
414         be used both in TestRunnerGtk and in DumpRenderTree.
415
416         * DumpRenderTree/gtk/DumpRenderTree.cpp:
417         (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
418         we can print Soup URIs with the password, since soup_uri_to_string
419         doesn't preserve them.
420         (pathFromSoupURI): Updated following EFL implementation in
421         r153977, and return a WTFString instead of a CString.
422         (convertSoupMessageToURLPath): Return "(null)" instead of empty
423         strings, and handle the new return type of pathFromSoupURI.
424         (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
425         reference, and handle the new return type of pathFromSoupURI.
426         (descriptionSuitableForTestResult): Remove unused code.
427         (didFinishLoading): Use convertResourceToURLPath.
428         (didFailLoadingWithError): Use convertResourceToURLPath.
429         (authenticationCallback): Display the URL of the authentication
430         challenge.
431         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
432         soupURIToStringPreservingPassword.
433         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
434         soupURIToStringPreservingPassword.
435
436 2013-08-14  Tim Horton  <timothy_horton@apple.com>
437
438         Un-inline dataLog dumpers for IntSize and IntPoint
439         https://bugs.webkit.org/show_bug.cgi?id=119697
440
441         Reviewed by Sam Weinig.
442
443         * TestWebKitAPI/GNUmakefile.am:
444
445 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
446
447         Flakiness dashboard build fix.
448
449         * TestResultServer/static-dashboards/flakiness_dashboard.js:
450         (processTestRunsForBuilder):
451
452 2013-08-14  Martin Robinson  <mrobinson@igalia.com>
453
454         [GTK] [CMake] Add support for building TestWebKitAPI
455         https://bugs.webkit.org/show_bug.cgi?id=116987
456
457         Reviewed by Philippe Normand.
458
459         * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
460         platform-specific file, so that GTK+ can override them.
461         * TestWebKitAPI/PlatformGTK.cmake: Added.
462
463 2013-08-14  Brent Fulgham  <bfulgham@apple.com>
464
465         [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
466         https://bugs.webkit.org/show_bug.cgi?id=119775
467
468         This bug updates the WinLauncher program with a few useful menu
469         options to toggle certain debugging and development features of
470         WebKit.
471
472         Reviewed by Tim Horton.
473
474         * WinLauncher/WinLauncher.cpp:
475         (dllLauncherEntryPoint): Clean up preference objects on exit.
476         (ToggleMenuItem): New function.
477         (LaunchInspector): New function.
478         (WndProc): Add handler for new menu items. Also properly terminate
479         CFRunLoop operation on program exit.
480         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
481         menu items.
482         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
483         resource folder to search path.
484         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
485         for new menu items.
486
487 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
488
489         Add a hyperlink from build.webkit.org to the flakiness dashboard.
490
491         Rubbers-tamped by Simon Fraser.
492
493         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
494
495 2013-08-14  Benjamin Dupont   <bdupont@nds.com>
496
497         [Qt] Activate visibility API layout tests
498         https://bugs.webkit.org/show_bug.cgi?id=119790
499
500         Reviewed by Allan Sandfeld Jensen.
501
502         * DumpRenderTree/qt/TestRunnerQt.cpp:
503         (TestRunner::resetPageVisibility):
504         (TestRunner::setPageVisibility):
505
506 2013-08-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
507
508         [GTK] WK does not link properly against libxslt
509         https://bugs.webkit.org/show_bug.cgi?id=119688
510
511         Reviewed by Gustavo Noronha Silva.
512
513         * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
514         MiniBrowser.
515         * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
516
517 2013-08-13  Alexey Proskuryakov  <ap@apple.com>
518
519         [Mac] fast/dom/attr-style-too-lazy.html is flaky
520         https://bugs.webkit.org/show_bug.cgi?id=119763
521
522         Reviewed by Darin Adler.
523
524         * DumpRenderTree/mac/UIDelegate.mm:
525         (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
526         a test, it would just semi-randomly leak to the next one.
527         (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
528         for good measure.
529
530 2013-08-13  Tim Horton  <timothy_horton@apple.com>
531
532         [mac] Give MiniBrowser a reasonable bundle identifier
533         https://bugs.webkit.org/show_bug.cgi?id=119773
534
535         Rubber-stamped by Simon Fraser.
536
537         Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
538
539         * MiniBrowser/mac/Info.plist:
540         * MiniBrowser/mac/WebBundle/Info.plist:
541
542 2013-08-13  Dean Jackson  <dino@apple.com>
543
544         <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
545
546         Reviewed by Mark Rowe.
547
548         Have prepare-ChangeLog produce webkit.org/b/id style
549         URLs rather than exposing the inner workings of our
550         cgi. I was going to use the term "Future Proofing"
551         but that seems excessive :)
552
553         * Scripts/prepare-ChangeLog:
554         (main): Generate a more human readable form.
555         (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
556
557 2013-08-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
558
559         [EFL][DRT] Simplify call to reverseFind()
560         https://bugs.webkit.org/show_bug.cgi?id=119746
561
562         Reviewed by Christophe Dumez.
563
564         Follow-up to r153977.
565
566         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
567         (pathSuitableForTestResult): Instead of defining a static variable
568         that's only used in a single place, pass '/' to reverseFind() directly.
569
570 2013-08-13  Alberto Garcia  <berto@igalia.com>
571
572         [GTK] Closing inspector window crashes wk
573         https://bugs.webkit.org/show_bug.cgi?id=110865
574
575         Reviewed by Carlos Garcia Campos.
576
577         Disconnect all signal handlers if the inspector window is
578         destroyed.
579
580         * GtkLauncher/LauncherInspectorWindow.c:
581         (inspectorWindowDestroyed):
582         (launcherInspectorWindowNew):
583
584 2013-08-12  Dan Bernstein  <mitz@apple.com>
585
586         extract-localizable-strings output is not suited for parsing by Xcode
587         https://bugs.webkit.org/show_bug.cgi?id=119728
588
589         Reviewed by Darin Adler.
590
591         Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
592         removed “ERROR” since messages that refer to a line in a file are shown as error by default,
593         added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
594         with 0).
595
596         * Scripts/extract-localizable-strings:
597
598 2013-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
599
600         [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
601         https://bugs.webkit.org/show_bug.cgi?id=119585
602
603         Reviewed by Gyuyoung Kim.
604
605         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
606         (pathSuitableForTestResult):
607         Return path string that's relative to main frame URL, or just file name if
608         the resource is not in the same directory subtree.
609         Referenced WebKitTestRunner code in r153852.
610         (descriptionSuitableForTestResult):
611         (DumpRenderTreeChrome::onFrameRedirectRequested):
612         (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
613
614 2013-08-12  Dan Bernstein  <mitz@apple.com>
615
616         extract-localizable-strings doesn't know how to verify an existing strings file
617         https://bugs.webkit.org/show_bug.cgi?id=119704
618
619         Reviewed by Darin Adler.
620
621         * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
622         exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
623         exceptions file name to omitting the --exceptions option. Added a --skip option, changing
624         the way directories to skip are specified from prefixing the directory with a “-” to
625         specifying it with --skip.
626         Finally, added a --verify option. When specified, the strings file is not written to, but
627         instead read in and checked for consistency with the comments, keys and values derived from
628         the source files and the exceptions file. Missing keys, unused keys, mismatching values and
629         mismatching comments are reported as errors.
630         * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
631         directories to skip and no exceptions file.
632
633 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
634
635         http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
636         https://bugs.webkit.org/show_bug.cgi?id=85522
637
638         Reviewed by Andy Estes.
639
640         * DumpRenderTree/mac/UIDelegate.mm:
641         (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
642         when already done with a test. We already had this check in all UI delegate functions,
643         except for -webView:addMessageToConsole:withSource: somehow.
644
645 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
646
647         https://bugs.webkit.org/show_bug.cgi?id=119693
648         [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
649         because of connect-src-websocket-allowed.html
650
651         Reviewed by Darin Adler.
652
653         Starting a load of about:blank and immediately stopping it cancels outstanding
654         resource loads, but the page has to transition to committed state to have timers
655         or WebSockets stopped too.
656
657         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
658         ensure that transition to committed state happens before we start the next test.
659
660 2013-08-12  Beth Dakin  <bdakin@apple.com>
661
662         The LayoutMilestones didLayout callback should only fire for the main frame
663         https://bugs.webkit.org/show_bug.cgi?id=119457
664
665         Reviewed by Sam Weinig.
666
667         Now that the didLayout callback only fires for the main frame, we want to make 
668         sure it will fire even when all of the content is in a subframe.
669
670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
671         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
672         (TestWebKitAPI::didLayout):
673         (TestWebKitAPI::TEST):
674         * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
675
676 2013-08-12  Beth Dakin  <bdakin@apple.com>
677
678         Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
679         https://bugs.webkit.org/show_bug.cgi?id=119658
680
681         Reviewed by Darin Adler.
682
683         * MiniBrowser/mac/WK2BrowserWindowController.m:
684         (-[WK2BrowserWindowController awakeFromNib]):
685         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
686         (WTR::InjectedBundlePage::InjectedBundlePage):
687         * WebKitTestRunner/TestController.cpp:
688         (WTR::TestController::createWebViewWithOptions):
689
690 2013-08-12  Seokju Kwon  <seokju@webkit.org>
691
692         Remove glu's libtest rule from checker.py
693         https://bugs.webkit.org/show_bug.cgi?id=119674
694
695         Reviewed by Darin Adler.
696
697         * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
698
699 2013-08-11  ChangSeok Oh  <changseok.oh@collabora.com>
700
701         Unreviewed. Change my primary mail address.
702
703         * Scripts/webkitpy/common/config/contributors.json:
704
705 2013-08-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
706
707         [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
708         https://bugs.webkit.org/show_bug.cgi?id=115751
709
710         Reviewed by Martin Robinson.
711
712         * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
713         with yum.
714
715 2013-08-09  Beth Dakin  <bdakin@apple.com>
716
717         AX: Not able to use arrow keys to read text in a WK2 app
718         https://bugs.webkit.org/show_bug.cgi?id=119605
719         -and corresponding-
720         <rdar://problem/14281275>
721
722         Reviewed by Darin Adler.
723
724         New test verifies that didNotHandleKeyEvent will be called when there is nothing 
725         to scroll. 
726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
727         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
728         (TestWebKitAPI::didFinishLoadForFrame):
729         (TestWebKitAPI::didNotHandleKeyEventCallback):
730         (TestWebKitAPI::TEST):
731
732 2013-08-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
733
734         Add support for KeyboardEvent.location attribute
735         https://bugs.webkit.org/show_bug.cgi?id=119326
736
737         Reviewed by Benjamin Poulain.
738
739         Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
740
741         * DumpRenderTree/mac/EventSendingController.mm:
742         (-[EventSendingController keyDown:withModifiers:withLocation:]):
743         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
744         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
745         (-[EventSendingController handleEvent:]):
746         (-[EventSendingController fireKeyboardEventsToElement:]):
747
748 2013-08-09  Alexey Proskuryakov  <ap@apple.com>
749
750         <unknown> is often dumped instead of path in test output
751         https://bugs.webkit.org/show_bug.cgi?id=119590
752
753         Reviewed by Anders Carlsson.
754
755         There were two reasons for <unknown>:
756         1. When delegate logging is enabled via a testRunner call, that obviously happens
757         after main resource load starts, so we don't record its URL.
758         2. Authentication delegate logging relied on URL recording, but it's only turned on
759         when enabling resource loading delegate logging, not auth one.
760
761         URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
762         landed without posted rationale and unreviewed. Just undoing that change now.
763
764         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
765         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
766         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
767         (WTR::InjectedBundlePage::didInitiateLoadForResource):
768
769 2013-08-08  Alex Christensen  <achristensen@apple.com>
770
771         Windows build fixes.
772
773         Rubberstamped by Brent Fulgham.
774
775         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
776         Removed /SAFESEH link option which doesn't work with x64.
777
778 2013-08-08  Daniel Bates  <dabates@apple.com>
779
780         Add iOS support to run-javascriptcore-tests
781         https://bugs.webkit.org/show_bug.cgi?id=119602
782
783         Reviewed by Joseph Pecoraro.
784
785         Make run-javascriptcore-tests work for iOS WebKit.
786
787         * Scripts/run-javascriptcore-tests:
788
789 2013-08-08  Alexey Proskuryakov  <ap@apple.com>
790
791         [WK2] loader/go-back-cached-main-resource.html fails
792         https://bugs.webkit.org/show_bug.cgi?id=116491
793
794         Reviewed by Tim Horton.
795
796         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
797         * DumpRenderTree/gtk/DumpRenderTree.cpp:
798         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
799         * DumpRenderTree/win/DumpRenderTree.cpp:
800         Added FIXMEs about making path printing normalization more compatible.
801
802         * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
803         Return last path component in cases where we used to return a full path, which is
804         never desirable. Added a null check to basePath to prevent potentially getting
805         an Objective C exception.
806
807         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
808         (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
809         for a currently loading one (which is different for tests that use multiple windows).
810         Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
811         last path component as last fallback.
812         (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
813         frame URL here, and it was potentially a wrong frame.
814         (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
815         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
816         (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
817         (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
818         (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
819
820 2013-08-08  Alex Christensen  <achristensen@apple.com>
821
822         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
823         https://bugs.webkit.org/show_bug.cgi?id=116125
824
825         Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
826
827         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
828         (WTR::pathSuitableForTestResult):
829         Changed string operations to match _drt_descriptionSuitableForTestResult.
830         (WTR::dumpRequestDescriptionSuitableForTestResult):
831         (WTR::dumpResponseDescriptionSuitableForTestResult):
832         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
833         (WTR::InjectedBundlePage::didInitiateLoadForResource):
834         (WTR::InjectedBundlePage::willSendRequestForFrame):
835         (WTR::InjectedBundlePage::didReceiveResponseForResource):
836         Pass the main frame's URL to pathSuitableForTestResult.
837         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
838         Added WKBundlePageRef to willPerformClientRedirectForFrame.
839
840 2013-08-07  Simon Fraser  <simon.fraser@apple.com>
841
842         Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
843         https://bugs.webkit.org/show_bug.cgi?id=119317
844
845         Reviewed by Tim Horton.
846         
847         The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
848         the test to complete, which is not power friendly. Although DRT instances
849         are generally busy anyway, not sitting in a busy loop should free up some CPU
850         cycles for other instances of DRT.
851         
852         Editing tests continue to pass. All Java tests are skipped and were not
853         tested, but when run fail similarly with and without the patch.
854
855         * DumpRenderTree/mac/DumpRenderTree.mm:
856         (dump):
857         (runTest):
858
859 2013-08-07  Daniel Bates  <dabates@apple.com>
860
861         Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
862         <https://bugs.webkit.org/show_bug.cgi?id=119558>
863
864         Reviewed by Martin Robinson.
865
866         Currently we build the command line to execute jsDriver.pl twice so as to both
867         print it to standard output and actually execute it. We should only build up
868         this command line once. Moreover, we should print to standard output the actual
869         command line that we are going to use including the GTK- and EFL-specific call
870         to /Tools/jhbuild/jhbuild-wrapper.
871
872         * Scripts/run-javascriptcore-tests:
873
874 2013-08-07  Mario Sanchez Prada  <mario.prada@samsung.com>
875
876         [EFL] REGRESSION after r153432: some accessibility tests crash.
877         https://bugs.webkit.org/show_bug.cgi?id=119333
878
879         Reviewed by Darin Adler.
880
881         Use a RefPtr to store a reference to the parent element of
882         an AccessibilityUIElement instead of the raw pointer, so we
883         never derefence a function from an invalid pointer.
884
885         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
886         (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
887
888 2013-08-07  Cosmin Truta  <ctruta@blackberry.com>
889
890         Unreviewed. Add myself as a committer.
891
892         * Scripts/webkitpy/common/config/contributors.json:
893
894 2013-08-04  Sam Weinig  <sam@webkit.org>
895
896         Remove support for HTML5 MicroData
897         https://bugs.webkit.org/show_bug.cgi?id=119480
898
899         Reviewed by Anders Carlsson.
900
901         * Scripts/webkitperl/FeatureList.pm:
902         * qmake/mkspecs/features/features.pri:
903
904 2013-07-23  David Farler  <dfarler@apple.com>
905
906         Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
907         https://bugs.webkit.org/show_bug.cgi?id=117762
908
909         Reviewed by Mark Rowe.
910
911         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
912         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
913         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
914         Add ASAN_OTHER_LDFLAGS.
915         * MiniBrowser/Configurations/DebugRelease.xcconfig:
916         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
917         * Scripts/check-for-weak-vtables-and-externals:
918         Ignore ___asan externals, these are populated by compiler-rt.
919         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
920         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
921         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
922         Add ASAN_OTHER_LDFLAGS.
923         * WebKitLauncher/Configurations/Base.xcconfig:
924         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
925         * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
926         Add ASAN_OTHER_LDFLAGS.
927         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
928         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
929         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
930         Add ASAN_OTHER_LDFLAGS.
931         * asan/asan.xcconfig: Added.
932         * asan/webkit-asan-ignore.txt: Added.
933
934 2013-08-05  Brian Holt  <brian.holt@samsung.com>
935
936         [GTK] Implement leak checking with valgrind
937         https://bugs.webkit.org/show_bug.cgi?id=118785
938
939         Reviewed by Dirk Pranke.
940
941         Launch the DRT under Valgrind to generate xml files with details
942         of leaks found.
943
944         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
945         (parse_args):
946         * Scripts/webkitpy/port/gtk.py:
947         (GtkPort.__init__):
948         (GtkPort.default_timeout_ms): Allow extra time to run under
949         Valgrind.
950         (GtkPort.setup_environ_for_server): Pass Valgrind instructions
951         using environment variables.
952
953 2013-08-02  Mario Sanchez Prada  <mario.prada@samsung.com>
954
955         [EFL] REGRESSION after r153432: some accessibility tests crash.
956         https://bugs.webkit.org/show_bug.cgi?id=119333
957
958         Reviewed by Gustavo Noronha Silva.
959
960         Add missing null-check to avoid dereferencing a non-existent parent.
961
962         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
963         (WTR::attributesOfElement): Ditto.
964
965 2013-08-02  Patrick Gansterer  <paroga@webkit.org>
966
967         Add --rmdir option to git svn dcommit
968         https://bugs.webkit.org/show_bug.cgi?id=119398
969
970         Reviewed by Ryosuke Niwa.
971
972         Add this option tells git-svn to remove empty directories
973         from the svn tree so they do not leave over there.
974
975         * Scripts/webkitpy/common/checkout/scm/git.py:
976         (Git.push_local_commits_to_server):
977
978 2013-08-01  Brent Fulgham  <bfulgham@apple.com>
979
980         [Windows] WebKit1 Fullscreen Video Play is Broken
981         https://bugs.webkit.org/show_bug.cgi?id=119415
982
983         Reviewed by Jer Noble.
984
985         * WinLauncher/WinLauncher.cpp:
986         (dllLauncherEntryPoint): Activate full screen mode via
987         IWebPreferencesInternal interface.
988
989 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
990
991         Unreviewed. Add an alternative address to show my affiliation in team.html.
992
993         * Scripts/webkitpy/common/config/contributors.json:
994
995 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
996
997         Duplicate property names can cause test to fail
998         https://bugs.webkit.org/show_bug.cgi?id=119399
999
1000         Reviewed by Dirk Pranke.
1001
1002         This problem was noticed when porting the patch for
1003         http://wkb.ug/119357 to Blink: a test would fail because the converted
1004         and test property lists weren't the same length, but they contained
1005         all of the same property names. It looks like this is actually caused
1006         by a bug in converting the HTML, which is being currently rewritten.
1007         In the meantime, as long as this compares the number of unique
1008         properties, it makes the test more robust.
1009
1010         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1011         (verify_prefixed_properties):
1012
1013 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
1014
1015         Unreviewed. Adding my expertise.
1016
1017         * Scripts/webkitpy/common/config/contributors.json:
1018
1019 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
1020
1021         Unreviewed. Add myself as a committer. Yoo-hoo! \o/
1022
1023         * Scripts/webkitpy/common/config/contributors.json:
1024
1025 2013-08-01  Commit Queue  <commit-queue@webkit.org>
1026
1027         Unreviewed, rolling out r153518.
1028         http://trac.webkit.org/changeset/153518
1029         https://bugs.webkit.org/show_bug.cgi?id=119386
1030
1031         The Jhbuild dep bump of GTK+ is not actually required by
1032         layout testing, is causing pango dep problems (Requested by
1033         zdobersek on #webkit).
1034
1035         * gtk/jhbuild.modules:
1036
1037 2013-08-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1038
1039         Unreviewed. Add myself as a committer.
1040
1041         * Scripts/webkitpy/common/config/contributors.json:
1042
1043 2013-08-01  Jaehun Lim  <ljaehun.lim@samsung.com>
1044
1045         Unreviewed. Add myself as a committer.
1046
1047         * Scripts/webkitpy/common/config/contributors.json:
1048
1049 2013-07-31  Jinwoo Song  <jinwoo7.song@samsung.com>
1050
1051         Unreviewed. Add myself as a committer.
1052
1053         * Scripts/webkitpy/common/config/contributors.json:
1054
1055 2013-08-01  Alberto Garcia  <berto@igalia.com>
1056
1057         Unreviewed. Add myself as a committer.
1058
1059         * Scripts/webkitpy/common/config/contributors.json:
1060
1061 2013-07-31  Seokju Kwon  <seokju@webkit.org>
1062
1063         Unreviewed. Add myself as a committer.
1064
1065         * Scripts/webkitpy/common/config/contributors.json:
1066
1067 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1068
1069         W3C test import script prefixes some properties that it shouldn't
1070         https://bugs.webkit.org/show_bug.cgi?id=119357
1071
1072         Reviewed by Dirk Pranke.
1073
1074         Some prefixed properties also have unprefixed implemetations, but when
1075         the implementations aren't identical, they aren't declared in
1076         CSSPropertyNames.in on the same line. This fixes the import script so
1077         that it catches all instances of prefixed properties that have an
1078         unprefixed variant, and does not add the prefix in those cases.
1079
1080         * Scripts/webkitpy/w3c/test_converter.py:
1081         (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
1082         the properties on every line and record if they are prefixed or not.
1083         Use this information to only return prefixed properties that do not
1084         have any unprefixed variant. The prefixed property list has also
1085         changed to not include the '-webkit-' prefix, making it much easier to
1086         do the comparison, and removing the need to remove the prefix later.
1087         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
1088         longer needs to remove the '-webkit-' prefix, but needs to add it in
1089         the case where a property that needs a prefix is found.
1090         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1091         (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
1092         for '-webkit-' prefix, as it is no longer included in the properties
1093         in the prefixed property list.
1094
1095 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1096
1097         Update location of w3c shapes tests to reflect new import location
1098         https://bugs.webkit.org/show_bug.cgi?id=118156
1099
1100         Reviewed by Dirk Pranke.
1101
1102         Partial imports should not be imported to the same place as the full
1103         import, so this adds an option to allow importing to a different
1104         location than the default. In doing that, I found that imports from
1105         contributor directories didn't seem to be working correctly, so I
1106         updated the import to be smarter about both contributor directories
1107         and the test status directories. It should now be more likely that the
1108         script guesses the root directory properly.
1109
1110         * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
1111             script not working with the full set of contributors, as that is
1112             no longer true, and I didn't see a good way to keep that behavior.
1113             Also update documentation to properly explain what happens when a
1114             contributor dir is imported.
1115         (main): Attempt to find the proper repo dir by looking at the
1116             directory above the "test status" in the given path, this is still
1117             not exactly right, but is less error prone than just trimming.
1118         (parse_args): Add -d option to set the import directory.
1119         (TestImporter.__init__): Stop appending the subdirs to the
1120             destination_directory because it was making things more complex
1121             and isn't really needed.
1122         (TestImporter.update_test_status): Remove hardcoded strings and use
1123             the TEST_STATUS constants instead.
1124         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1125         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
1126             support for new option.
1127         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1128
1129 2013-07-31  Brent Fulgham  <bfulgham@apple.com>
1130
1131         [Windows] Winlauncher shouldn't look for Safari Install Directory
1132         https://bugs.webkit.org/show_bug.cgi?id=119351
1133
1134         Reviewed by Darin Adler.
1135
1136         * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
1137         the Safari install location. Instead, use the proper support
1138         library path for the build architecture.
1139
1140 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1141
1142         Update scripts to reference contributors.json instead of committers.py in messaging
1143         https://bugs.webkit.org/show_bug.cgi?id=119342
1144
1145         Reviewed by Ryosuke Niwa.
1146
1147         Change the scripts to point people to contributors.json instead of
1148         committers.py since the latter no longer contains the list of
1149         contributors.
1150
1151         * Scripts/webkitpy/common/config/committervalidator.py:
1152         (CommitterValidator._contributors_json_path):
1153         (CommitterValidator._flag_permission_rejection_message):
1154         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1155         (CommitterValidatorTest.test_flag_permission_rejection_message):
1156         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1157         (Bugzilla._commit_queue_flag):
1158         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1159         (WatchListParser._validate):
1160         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1161         (WatchListParserTest.test_cc_rule_with_invalid_email):
1162         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1163         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1164         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1165         (ValidateReviewer.run):
1166
1167 2013-07-31  Roger Fong  <roger_fong@apple.com>
1168
1169         Unreviewed. Re-enable WinEWS tests following r153527.
1170
1171         * Scripts/webkitpy/common/config/ews.json:
1172
1173 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1174
1175         Unreviewed: Adding myself to the committers' list.
1176
1177         * Scripts/webkitpy/common/config/contributors.json:
1178
1179 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1180
1181         [Qt] Build WebKit with C++11
1182         https://bugs.webkit.org/show_bug.cgi?id=119337
1183
1184         Reviewed by Csaba Osztrogonác.
1185
1186         Enable building with C++11.
1187
1188         * qmake/mkspecs/features/default_pre.prf:
1189         * qmake/mkspecs/features/unix/default_post.prf:
1190         * qmake/mkspecs/features/unix/default_pre.prf:
1191
1192 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1193
1194         [Qt] ASSERTS trigger in release builds
1195         https://bugs.webkit.org/show_bug.cgi?id=119336
1196
1197         Reviewed by Jocelyn Turcotte.
1198
1199         Ensure the qmake also defaults to release if no configuration is known.
1200
1201         * qmake/mkspecs/features/default_post.prf:
1202
1203 2013-07-31  Zan Dobersek  <zdobersek@igalia.com>
1204
1205         [texmap][GStreamer][GTK] composited video shows tearing
1206         https://bugs.webkit.org/show_bug.cgi?id=118253
1207
1208         Reviewed by Martin Robinson.
1209
1210         * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
1211         The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
1212         screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
1213
1214 2013-07-30  Ruth Fong  <ruth_fong@apple.com>
1215
1216         Unreviewed: Adding myself to the committers' list.
1217
1218         * Scripts/webkitpy/common/config/contributors.json:
1219
1220 2013-07-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1221
1222         Unreviewed, add my new email to contributors.json.
1223
1224         * Scripts/webkitpy/common/config/contributors.json:
1225
1226 2013-07-30  Krzysztof Czech  <k.czech@samsung.com>
1227
1228         [EFL] REGRESSION after r153439: layout tests do not run.
1229         https://bugs.webkit.org/show_bug.cgi?id=119240
1230
1231         Reviewed by Christophe Dumez.
1232
1233         Changed attribute name from check_xvfb to check_driver.
1234
1235         * Scripts/webkitpy/port/efl.py:
1236         (EflPort.check_sys_deps):
1237
1238 2013-07-29  Commit Queue  <commit-queue@webkit.org>
1239
1240         Unreviewed, rolling out r152860.
1241         http://trac.webkit.org/changeset/152860
1242         https://bugs.webkit.org/show_bug.cgi?id=119227
1243
1244         Disable WinEWS tests until tests stop crashing (Requested by
1245         rfong on #webkit).
1246
1247         * Scripts/webkitpy/common/config/ews.json:
1248
1249 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1250
1251         [GTK] Add WestonDriver, use it when appropriate
1252         https://bugs.webkit.org/show_bug.cgi?id=119100
1253
1254         Reviewed by Dirk Pranke.
1255
1256         Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
1257         and sets up an environment that enables the test runner to run inside it.
1258
1259         The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
1260         environment variable is set, that is when NRWT is being run under a Wayland display.
1261
1262         * Scripts/webkitpy/port/base.py:
1263         (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
1264         * Scripts/webkitpy/port/gtk.py:
1265         (GtkPort):
1266         (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
1267         should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
1268         (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
1269         instead of hard-coding the XvfbDriver class in the check.
1270         * Scripts/webkitpy/port/westondriver.py: Added.
1271         (WestonDriver):
1272         (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
1273         (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
1274         (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
1275         driver and then launches the driver in said environment, using the driver's Weston display.
1276         (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
1277         (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
1278         and returns the absolute path to it.
1279         * Scripts/webkitpy/port/xvfbdriver.py:
1280         (XvfbDriver.check_driver): Renamed from check_xvfb.
1281         (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
1282
1283 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1284
1285         [ATK] Implement attributesOfChildren() for AccessibilityUIElement
1286         https://bugs.webkit.org/show_bug.cgi?id=118967
1287
1288         Reviewed by Gustavo Noronha Silva.
1289
1290         Implemented AccessibilityUIElement::attributesOfChildren() both
1291         in DumpRenderTree and the WebKitTestRunner.
1292
1293         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1294         (AccessibilityUIElement::attributesOfChildren): Implemented.
1295
1296         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1297         (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
1298
1299 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1300
1301         [ATK] Implement allAttributes() for AccessibilityUIElement
1302         https://bugs.webkit.org/show_bug.cgi?id=118966
1303
1304         Reviewed by Gustavo Noronha Silva.
1305
1306         Implemented AccessibilityUIElement::allAttributes() both in
1307         DumpRenderTree and the WebKitTestRunner.
1308
1309         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1310         (getAtkAttributeSetAsString): Moved up in the file, and refactored
1311         to use StringBuilder and return a String instead of a gchar*.
1312         (roleToString): Changed not to return the "AXRole: " prefix, so
1313         we can use it as well from attributesOfElement().
1314         (attributesOfElement): New function to dump attributes for an object.
1315         (AccessibilityUIElement::allAttributes): Call attributesOfElement().
1316         (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1317
1318         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1319         (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
1320         a String instead of a gchar*.
1321
1322         (WTF::roleToString): Changed not to return the "AXRole: " prefix,
1323         so we can use it as well from attributesOfElement().
1324         (WTF::attributesOfElement): New function to dump attributes for an object.
1325         (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
1326         (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1327
1328 2013-07-29  Daniel Bates  <dabates@apple.com>
1329
1330         Add support infrastructure for iOS WebKit port
1331         https://bugs.webkit.org/show_bug.cgi?id=119168
1332
1333         Reviewed by Ryosuke Niwa.
1334
1335         Implement support infrastructure towards building iOS WebKit.
1336
1337         * Scripts/webkitdirs.pm:
1338         (xcodeSDKPlatformName): Added.
1339         (determineConfigurationProductDir):
1340         (builtDylibPathForName):
1341         (willUseIOSDeviceSDKWhenBuilding): Added.
1342         (willUseIOSSimulatorSDKWhenBuilding): Added.
1343         (isIOSWebKit): Added.
1344         (copyInspectorFrontendFiles):
1345
1346 2013-07-29  Sergio Correia  <sergio.correia@openbossa.org>
1347
1348         CoordinatedGraphics: Add API to get and set the active state of a WebView
1349         https://bugs.webkit.org/show_bug.cgi?id=119067
1350
1351         Reviewed by Noam Rosenthal.
1352
1353         Added API tests for WKViewIsActive and WKViewSetIsActive.
1354
1355         * TestWebKitAPI/PlatformEfl.cmake:
1356         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
1357         (TestWebKitAPI::didFinishLoadForFrame):
1358         (TestWebKitAPI::webProcessCrashed):
1359         (TestWebKitAPI::webProcessRelaunched):
1360         (TestWebKitAPI::TEST):
1361         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1362         Bundle added to allow crashing the WebProcess and testing the active state of a view
1363         under such condition.
1364         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
1365         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
1366
1367 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1368
1369         [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
1370         https://bugs.webkit.org/show_bug.cgi?id=119212
1371
1372         Reviewed by Carlos Garcia Campos.
1373
1374         * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
1375         variables that are not defined during the configuration process.
1376         * TestWebKitAPI/GNUmakefile.am: Ditto.
1377         * WebKitTestRunner/GNUmakefile.am: Ditto.
1378
1379 2013-07-28  Andy Estes  <aestes@apple.com>
1380
1381         Include <stdio.h> to declare perror()
1382         https://bugs.webkit.org/show_bug.cgi?id=119198
1383
1384         Reviewed by Andreas Kling.
1385
1386         Silences an implicit declaration warning.
1387
1388         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
1389
1390 2013-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
1391
1392         [EFL] Bump required version of EFL to 1.7
1393         https://bugs.webkit.org/show_bug.cgi?id=119144
1394
1395         Reviewed by Christophe Dumez.
1396
1397         * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
1398
1399 2013-07-26  Filip Pizlo  <fpizlo@apple.com>
1400
1401         WKTR should know about the JSC extensions to testRunner
1402         https://bugs.webkit.org/show_bug.cgi?id=119154
1403
1404         Reviewed by Mark Hahnenberg and Geoffrey Garen.
1405         
1406         This makes some fast/js tests pass.
1407
1408         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1410         (WTR::TestRunner::numberOfDFGCompiles):
1411         (WTR::TestRunner::neverInlineFunction):
1412         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1413
1414 2013-07-25  Mark Rowe  <mrowe@apple.com>
1415
1416         Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
1417
1418         * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
1419         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
1420         so they pull the version out of the SDK.
1421
1422 2013-07-25  Anders Carlsson  <andersca@apple.com>
1423
1424         Localizable.strings generated by extract-localizable-strings should be UTF-8
1425         https://bugs.webkit.org/show_bug.cgi?id=119106
1426
1427         Reviewed by Mark Rowe.
1428
1429         Output strings as UTF-8.
1430
1431         * Scripts/extract-localizable-strings:
1432
1433 2013-07-25  Sam Weinig  <sam@webkit.org>
1434
1435         -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
1436         https://bugs.webkit.org/show_bug.cgi?id=119099
1437         <rdar://problem/13439291>
1438
1439         Reviewed by Enrica Casucci.
1440
1441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1442         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1443         (TestWebKitAPI::attributedString):
1444         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1445         (TestWebKitAPI::AttributedStringTest_CustomFont::url):
1446         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
1447         (TestWebKitAPI::TEST_F):
1448         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1449         (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
1450         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
1451         * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
1452         Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
1453         to make adding more easier in the future.
1454
1455 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1456
1457         fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
1458         https://bugs.webkit.org/show_bug.cgi?id=118948
1459
1460         Reviewed by Sam Weinig.
1461         
1462         - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
1463           by exporting it as a function.
1464         
1465         - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
1466           it even if you know that you've already done so. See processIRDump.sh.
1467         
1468         - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
1469           runs it through ReducedFTL automatically. You typically want to say something like:
1470           
1471           jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
1472           ./processIRDump.sh --timing < jsc-output.txt
1473
1474         * ReducedFTL/ReducedFTL.c:
1475         (webkit_osr_exit):
1476         * ReducedFTL/combineModules.rb:
1477         * ReducedFTL/processIRDump.sh: Added.
1478
1479 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1480
1481         fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
1482         https://bugs.webkit.org/show_bug.cgi?id=118947
1483
1484         Reviewed by Dan Bernstein.
1485
1486         * Scripts/copy-webkitlibraries-to-product-directory:
1487
1488 2013-07-16  Filip Pizlo  <fpizlo@apple.com>
1489
1490         fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
1491         https://bugs.webkit.org/show_bug.cgi?id=118647
1492
1493         Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
1494
1495         Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
1496         way that the FTL would.
1497         
1498         Also add a tool that combines multiple LLVM modules generated by FTL into a
1499         single module.
1500
1501         * ReducedFTL: Added.
1502         * ReducedFTL/ReducedFTL.c: Added.
1503         (usage):
1504         (currentTime):
1505         (MemorySection):
1506         (mmAllocateCodeSection):
1507         (mmAllocateDataSection):
1508         (mmApplyPermissions):
1509         (mmDestroy):
1510         (symbolLookupCallback):
1511         (main):
1512         * ReducedFTL/build.sh: Added.
1513         * ReducedFTL/combineModules.rb: Added.
1514
1515 2013-06-09  Filip Pizlo  <fpizlo@apple.com>
1516
1517         Unreviewed, fix minor goof in profiling output layout. We weren't accounting
1518         for the "/" that is printed between engine counts.
1519
1520         * Scripts/display-profiler-output:
1521
1522 2013-05-28  Filip Pizlo  <fpizlo@apple.com>
1523
1524         testRunner should have a way of disabling inlining of functions
1525         https://bugs.webkit.org/show_bug.cgi?id=116875
1526
1527         Reviewed by Mark Hahnenberg.
1528
1529         * DumpRenderTree/TestRunner.cpp:
1530         (neverInlineFunction):
1531         (TestRunner::staticFunctions):
1532
1533 2013-05-27  Filip Pizlo  <fpizlo@apple.com>
1534
1535         testRunner should be able to tell you if a function is DFG compiled
1536         https://bugs.webkit.org/show_bug.cgi?id=116847
1537
1538         Reviewed by Mark Hahnenberg.
1539
1540         * DumpRenderTree/TestRunner.cpp:
1541         (numberOfDFGCompiles):
1542         (TestRunner::staticFunctions):
1543
1544 2013-05-21  Filip Pizlo  <fpizlo@apple.com>
1545
1546         fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
1547         https://bugs.webkit.org/show_bug.cgi?id=116556
1548
1549         Reviewed by Oliver Hunt.
1550         
1551         This adds three new capabilities:
1552         
1553         - 'display' now accepts negative compilation indices, and allows specifying
1554           wildcard hashes combined with combination indices. Previously you could say
1555           'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
1556           latter would display every compilation. This improves this so that you can
1557           say 'display *-<index>-<engine>'. It also makes it so that you can give a
1558           negative index, which allows you to say things like 'display blah--1-dfg',
1559           which displays just the last DFG compilation. Also you can say
1560           'display *--1-dfg', which displays the last DFG compilation for each code
1561           block. I realize that this is kind of ugly, but gosh is it practical.
1562         
1563         - You can now say 'sort hash', which will henceforth sort all of the output
1564           by code hash rather than by the time when it was compiled. This means that
1565           if you're doing 'dispay *--1-dfg' and then want to diff the results against
1566           something else, you can ensure that this doesn't get confused just by
1567           changes in compilation order.
1568         
1569         - You can now say 'counts off', which will henceforth disable the display of
1570           execution counts from 'bytecode' and 'display'. This is also useful for
1571           diffs, since if you're trying to figure out why two compilations are
1572           different, they probably have radically different counts. 'counts off' gets
1573           this out of the output so that it doesn't confuse your diff.
1574         
1575         Note that to use this effectively you should also have a script that scrubs
1576         pointers from text so that the diff doesn't get confused by pointers. I'll
1577         post my elimptr script to the bug. Maybe at some point I'll integrate that
1578         into display-profiler-output.
1579         
1580         Put together this is pretty awesome. I was able to do the following:
1581         
1582         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
1583         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
1584         diff -u richards-serial.asm richards-concurrent.asm
1585         
1586         And this immediately told me that the reason why richards is slower in the
1587         concurrent compilation case is just that we end up compiling *tons* more
1588         functions, most of which are trivially inlineable. Basically, concurrent
1589         compilation breaks our previous heuristics for delaying compilation of
1590         inlineables just enough that they never trigger compilation. We should fix
1591         that in a separate bug.
1592
1593         * Scripts/display-profiler-output:
1594
1595 2013-04-30  Filip Pizlo  <fpizlo@apple.com>
1596
1597         fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
1598
1599         Rubber stamped by Mark Rowe.
1600
1601         * Scripts/copy-webkitlibraries-to-product-directory:
1602
1603 2013-07-16  Oliver Hunt <oliver@apple.com>
1604
1605         Merge dfgFourthTier r148853
1606
1607     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1608
1609         fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
1610         https://bugs.webkit.org/show_bug.cgi?id=114933
1611
1612         Reviewed by Andy Estes.
1613         
1614         This makes it easy to get set up for tandem LLVM builds.
1615
1616         * Scripts/copy-webkitlibraries-to-product-directory:
1617
1618 2013-07-16  Oliver Hunt <oliver@apple.com>
1619
1620         Merge dfgFourthTier r148850
1621
1622     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1623
1624         fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
1625         https://bugs.webkit.org/show_bug.cgi?id=114926
1626
1627         Reviewed by Geoffrey Garen.
1628         
1629         If the LLVM libraries change, then touch a phony header, which will force relink
1630         of JavaScriptCore.
1631
1632         * Scripts/copy-webkitlibraries-to-product-directory:
1633         (unpackIfNecessary):
1634
1635 2013-07-16  Oliver Hunt <oliver@apple.com>
1636
1637         Merge dfgFourthTier r148848
1638
1639     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1640
1641         fourthTier: developing LLVM in tandem with WebKit should be fun and easy
1642         https://bugs.webkit.org/show_bug.cgi?id=114925
1643
1644         Reviewed by Geoffrey Garen.
1645         
1646         This enables building LLVM along with WebKit, so that build-jsc and build-webkit
1647         will also optionally build LLVM and quickly symlink LLVM's built products into
1648         the right places.
1649         
1650         Most WebKit and JSC hackers will want to rely on the checked-in already-built
1651         versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
1652         increasingly common use-case for me, and it may become a common use case for a
1653         handful of others. Currently, this is really painful: you first have to build
1654         LLVM, then you have to export-llvm-build (which takes a while), and then you
1655         have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
1656         variables are set to point to the thing you exported. The whole process loses
1657         track of dependencies very quickly: making a tiny change in LLVM requires
1658         packaging, and then unpackaging, a large number of potentially large headers and
1659         static libraries. Not only is this slow but it then causes the WebKit build
1660         system to rebuild anything that transitively includes any LLVM header, which is
1661         now quite a few files. While this sort of use pattern is still worthwhile if
1662         you're trying to package a binary drop and test it, it's not great if you're
1663         just trying to do experimental development that involves making small changes
1664         in both trees.
1665         
1666         This change fixes this use case while keeping the old use cases intact. You can
1667         do tandem development using one of two modes:
1668         
1669         Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
1670         the LLVM directory you're using. Once this is done, any invocation of a WebKit
1671         build via build-jsc or build-webkit will also build LLVM, and then quickly
1672         symlink things into place without perturbing dependency tracking.
1673         
1674         Internal LLVM directory: if you check out llvm into a directory called 'llvm'
1675         right off of the WebKit source tree, then the build system will automatically
1676         use this.
1677         
1678         Here's how this takes care of dependencies:
1679         
1680         Headers: the include/llvm and include/llvm-c directories are symlinked into
1681         $productsDir/usr/local/include. And then everything just works.
1682         
1683         Libraries: the build system detects, by reading LLVM's Makefile.config, which
1684         mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
1685         the .a files into $productsDir/<thingy>. It will ranlib those libraries only
1686         if they have changed, by checking both the modification time and also whether
1687         the last time we had a symlink, that symlink was from the same directory.
1688         This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
1689         but that build wasn't yet ranlib'd.
1690         
1691         One problem that this does not yet solve is that xcodebuild will not relink
1692         JavaScriptCore if the only thing that changed was the libraries. I will work
1693         on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
1694
1695         * Scripts/copy-webkitlibraries-to-product-directory:
1696         (unpackIfNecessary):
1697         (fileContains):
1698         (fileContentsEquals):
1699
1700 2013-04-15  Filip Pizlo  <fpizlo@apple.com>
1701
1702         fourthTier: Update LLVM-related build scripts to copy generated headers as well
1703         https://bugs.webkit.org/show_bug.cgi?id=114551
1704
1705         Reviewed by Oliver Hunt.
1706         
1707         Also added the ability to use something other than bzip2 compression, since although
1708         it is great for checking things into the tree, it increases turn-around times when
1709         experimenting.
1710
1711         * Scripts/copy-webkitlibraries-to-product-directory:
1712         (unpackIfNecessary):
1713         * Scripts/export-llvm-build:
1714
1715 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
1716
1717         fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
1718         https://bugs.webkit.org/show_bug.cgi?id=113921
1719
1720         Reviewed by Oliver Hunt.
1721
1722         The LLVM community wants us to continue including all of LLVM's C++ headers. Change
1723         the export script to do this.
1724         
1725         * Scripts/export-llvm-build:
1726
1727 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1728
1729         fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
1730         https://bugs.webkit.org/show_bug.cgi?id=113452
1731
1732         Rubber stamped by Mark Hahnenberg.
1733
1734         * Scripts/copy-webkitlibraries-to-product-directory:
1735         * Scripts/export-llvm-build:
1736
1737 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1738
1739         fourthTier: FTL JIT should be able run some simple function
1740         https://bugs.webkit.org/show_bug.cgi?id=113481
1741
1742         Reviewed by Geoffrey Garen.
1743         
1744         Give the scripts the ability to find an LLVM build and use it.
1745         
1746         Also added a script, export-llvm-build, that allows you to take your
1747         own build of LLVM and package it for use by WebKit's build system.
1748         
1749         The build system treats a "build" of LLVM as a pair of .tar.bz2's,
1750         one for the library archives and one for the headers. It then unpacks
1751         them into your built products directory in a mannner that is mostly
1752         analogous to how WebKitSystemInterface works.
1753
1754         * Scripts/build-jsc:
1755         * Scripts/copy-webkitlibraries-to-product-directory:
1756         (unpackIfNecessary):
1757         (dittoHeaders):
1758         * Scripts/export-llvm-build: Added.
1759
1760 2013-07-24  Anders Carlsson  <andersca@apple.com>
1761
1762         Crash when calling WKPageGetProcessIdentifier after aborted process launch
1763         https://bugs.webkit.org/show_bug.cgi?id=119069
1764         <rdar://problem/14494064>
1765
1766         Reviewed by Andreas Kling.
1767
1768         Add a test.
1769
1770         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1771         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
1772         (TestWebKitAPI::didFinishLoadForFrame):
1773         (TestWebKitAPI::TEST):
1774
1775 2013-07-24  Zan Dobersek  <zdobersek@igalia.com>
1776
1777         Make KURL::hasPath private
1778         https://bugs.webkit.org/show_bug.cgi?id=118279
1779
1780         Reviewed by Darin Adler.
1781
1782         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1783         (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
1784
1785 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1786
1787         [GTK] TestInspectorServer unit test is timing out
1788         https://bugs.webkit.org/show_bug.cgi?id=105866
1789
1790         Reviewed by Gustavo Noronha Silva.
1791
1792         * Scripts/run-gtk-tests:
1793         (TestRunner):
1794
1795 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1796
1797         [GTK] [WK2] Handle wheel event with delta zero
1798         https://bugs.webkit.org/show_bug.cgi?id=118973
1799
1800         Reviewed by Gustavo Noronha Silva.
1801
1802         Added handling of zero mouse scroll deltas in EventSenderProxy similar
1803         to WK1 and Qt/EFL ports.
1804
1805         fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
1806         failing on WK2.
1807
1808         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1809         (WTR::EventSenderProxy::mouseScrollBy):
1810
1811 2013-07-23  Andreas Kling  <akling@apple.com>
1812
1813         REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
1814         <rdar://problem/14324895>
1815         <http://webkit.org/b/119023>
1816
1817         Reviewed by Simon Fraser.
1818
1819         Add a test for this rather specific problem.
1820
1821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1822         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
1823         (TestWebKitAPI::TEST):
1824         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
1825         (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
1826         (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
1827         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1828
1829 2013-07-23  Tim Horton  <timothy_horton@apple.com>
1830
1831         Add a test for plug-in unavailability indicator obscurity detection
1832         https://bugs.webkit.org/show_bug.cgi?id=119007
1833
1834         Reviewed by Anders Carlsson.
1835
1836         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
1837
1838         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1840         (WTR::TestRunner::setBlockAllPlugins):
1841         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1842         * WebKitTestRunner/TestInvocation.cpp:
1843         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1844         Add testRunner.setBlockAllPlugins function (and corresponding message to
1845         forward it through to TestController).
1846
1847         * WebKitTestRunner/TestController.cpp:
1848         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
1849
1850         (WTR::TestController::createWebViewWithOptions):
1851         Register our pluginLoadPolicy callback.
1852
1853         (WTR::TestController::resetStateToConsistentValues):
1854         Reset m_shouldBlockAllPlugins to false.
1855
1856         (WTR::TestController::pluginLoadPolicy):
1857         Return the existing plugin load policy, unless setBlockAllPlugins(true)
1858         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
1859
1860         * WebKitTestRunner/TestController.h:
1861         (WTR::TestController::setBlockAllPlugins):
1862
1863 2013-07-21  Andreas Kling  <akling@apple.com>
1864
1865         KURL creates duplicate strings when completing data: URIs.
1866         <http://webkit.org/b/118952>
1867         <rdar://problem/14504480>
1868
1869         Reviewed by Anders Carlsson.
1870
1871         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1872         (TestWebKitAPI::TEST_F):
1873
1874 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
1875
1876         AX: VoiceOver not detecting misspelled words don't work in all cases
1877         https://bugs.webkit.org/show_bug.cgi?id=118924
1878
1879         Reviewed by Tim Horton.
1880
1881         Make the misspelled detection dependent on both types of attributes being present.
1882
1883         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1884         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1885         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1886         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1887
1888 2013-07-19  Alex Christensen  <achristensen@apple.com>
1889
1890         Improved code coverage generation.
1891         https://bugs.webkit.org/show_bug.cgi?id=118926
1892
1893         Reviewed by Tim Horton.
1894
1895         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
1896         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
1897         (generateReport): Moved report generation to a subroutine.
1898
1899 2013-07-19  Stephanie Lewis  <slewis@apple.com>
1900
1901         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
1902
1903         Unreviewed.
1904
1905         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
1906
1907         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1908         (TestWebKitAPI::didLayout):
1909
1910 2013-07-19  Daniel Bates  <dabates@apple.com>
1911
1912         Make Perl tools work when using git bisect with Git branch build setup
1913         https://bugs.webkit.org/show_bug.cgi?id=118512
1914
1915         Reviewed by Martin Robinson.
1916
1917         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
1918         during a git bisect session with a Git branch build setup (i.e. git config
1919         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
1920         specific build of WebKit because they cannot determine the branch Git is on (since
1921         git bisect puts Git into a detached HEAD state). We should teach our tooling to
1922         parse the file .git/BISECT_START (created by git bisect start) for the name of the
1923         branch Git was on when we began a git bisect session. Then the tools can determine
1924         the path to the built WebKit.
1925
1926         * Scripts/VCSUtils.pm:
1927         (gitDirectory): Added.
1928         (gitBisectStartBranch): Added.
1929         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
1930         HEAD (e.g. running git bisect).
1931         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
1932         the .git directory in the Git checkout.
1933
1934 2013-07-19  Alex Christensen  <achristensen@apple.com>
1935
1936         Added x64 configuration to Visual Studio build.
1937         https://bugs.webkit.org/show_bug.cgi?id=118888
1938
1939         Reviewed by Brent Fulgham.
1940
1941         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1942         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1943         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1944         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1945         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1946         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1947         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1948         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1949         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1950         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1951         * win/record-memory/record-memory.vcxproj:
1952
1953 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
1954
1955         Add a couple people to the MathML watchlist
1956         https://bugs.webkit.org/show_bug.cgi?id=118909
1957
1958         Reviewed by Andreas Kling.
1959
1960         Add a couple people to the MathML watchlist and add Kalyan's other
1961         email address to fix style checker warnings about the watchlist
1962         contents.
1963
1964         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
1965         list of contributors and add Kalyan's second email address.
1966         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
1967         watchlist.
1968
1969 2013-07-19  Simon Pena  <simon.pena@samsung.com>
1970
1971         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
1972         https://bugs.webkit.org/show_bug.cgi?id=118895
1973
1974         Reviewed by Philippe Normand.
1975
1976         In r152782 an uri is used to create an string representation without checking first if it
1977         is valid. That fails later when the string is used to check for existing redirections. This
1978         patch ensures that the uri is valid before using it.
1979
1980         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1981         (willSendRequestCallback): Ensure an uri is valid before using it.
1982
1983 2013-07-18  Timothy Hatcher  <timothy@apple.com>
1984
1985         Add extract-localizable-js-strings and use it for WebInspectorUI.
1986
1987         https://bugs.webkit.org/show_bug.cgi?id=118851
1988
1989         Reviewed by Joseph Pecoraro.
1990
1991         * Scripts/extract-localizable-js-strings: Added.
1992         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
1993         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
1994         the WebInspectorUI project.
1995
1996 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
1997
1998         [Windows] Build correction #2 after r152861.
1999
2000         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
2001
2002 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
2003
2004         [Windows] Build correction after r152861.
2005
2006         * WinLauncher/WinLauncher.cpp: Don't reference private header.
2007
2008 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
2009
2010         [Win] Support in-band text tracks.
2011         https://bugs.webkit.org/show_bug.cgi?id=103770
2012
2013         Reviewed by Eric Carlson.
2014
2015         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
2016         libdispatch and CFRunLoop elements are services during the run loop.
2017
2018         * WinLauncher/WinLauncher.cpp:
2019         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
2020         a CoreFoundation (or CFLite) support library.
2021         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
2022         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
2023         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
2024         and WinLauncherCFLite.props.
2025
2026 2013-07-18  Roger Fong  <roger_fong@apple.com>
2027
2028         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
2029
2030         * Scripts/webkitpy/common/config/ews.json:
2031
2032 2013-07-18  Daniel Bates  <dabates@apple.com>
2033
2034         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
2035         https://bugs.webkit.org/show_bug.cgi?id=118854
2036         <rdar://problem/14081339>
2037
2038         Reviewed by David Kilzer.
2039
2040         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
2041         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
2042         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
2043         listen on these ports so that we can run tests that use port 8443 and 8080.
2044
2045         * Scripts/old-run-webkit-tests:
2046         (configureAndOpenHTTPDIfNeeded):
2047
2048 2013-07-17  Tim Horton  <timothy_horton@apple.com>
2049
2050         Update blocked/missing plug-in UI
2051         https://bugs.webkit.org/show_bug.cgi?id=118347
2052         <rdar://problem/14209318>
2053
2054         Reviewed by Sam Weinig.
2055
2056         * MiniBrowser/mac/WK2BrowserWindowController.m:
2057         (-[WK2BrowserWindowController awakeFromNib]):
2058         * WebKitTestRunner/TestController.cpp:
2059         (WTR::TestController::createWebViewWithOptions):
2060         Match new WKPageLoaderClient entry.
2061
2062 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2063
2064         Unreviewed, rolling out r152701, r152703, r152739, r152754,
2065         and r152756.
2066         http://trac.webkit.org/changeset/152701
2067         http://trac.webkit.org/changeset/152703
2068         http://trac.webkit.org/changeset/152739
2069         http://trac.webkit.org/changeset/152754
2070         http://trac.webkit.org/changeset/152756
2071         https://bugs.webkit.org/show_bug.cgi?id=118821
2072
2073         this was a buggy fix and we're going to try something
2074         different (Requested by thorton on #webkit).
2075
2076         * MiniBrowser/mac/WK2BrowserWindowController.m:
2077         (-[WK2BrowserWindowController awakeFromNib]):
2078         * WebKitTestRunner/TestController.cpp:
2079         (WTR::TestController::createWebViewWithOptions):
2080
2081 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2082
2083         Unreviewed, rolling out r151535.
2084         http://trac.webkit.org/changeset/151535
2085         https://bugs.webkit.org/show_bug.cgi?id=118804
2086
2087         Re-disable WinEWS tests (Requested by rfong on #webkit).
2088
2089         * Scripts/webkitpy/common/config/ews.json:
2090
2091 2013-07-17  Simon Pena  <simon.pena@samsung.com>
2092
2093         [GTK] Make DRT obbey testRunner's addURLToRedirect
2094         https://bugs.webkit.org/show_bug.cgi?id=118239
2095
2096         Reviewed by Gustavo Noronha Silva.
2097
2098         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
2099         to the proper URI when indicated.
2100
2101         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2102         (willSendRequestCallback):
2103
2104 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2105
2106         Add a new find-resolved-bugs command to webkit-patch.
2107         https://bugs.webkit.org/show_bug.cgi?id=118060
2108
2109         Reviewed by Csaba Osztrogonác.
2110
2111         * Scripts/webkitpy/tool/commands/queries.py:
2112         (PrintBaselines._platform_for_path):
2113         (FindResolvedBugs):
2114         (FindResolvedBugs.execute):
2115
2116 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
2117
2118         [CMake] Undefined references should be detected at build time
2119         https://bugs.webkit.org/show_bug.cgi?id=110236
2120
2121         Reviewed by Christophe Dumez.
2122
2123         Add library dependencies that were not defined explicitly before.
2124
2125         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2126         * TestWebKitAPI/CMakeLists.txt:
2127         * WebKitTestRunner/CMakeLists.txt:
2128
2129 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
2130
2131         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
2132         https://bugs.webkit.org/show_bug.cgi?id=118755
2133
2134         Reviewed by Ryosuke Niwa.
2135
2136         Fix r152719 to check "using namespace foo;" only in headers.
2137
2138         * Scripts/webkitpy/style/checkers/cpp.py:
2139         (check_using_namespace):
2140         (check_style):
2141         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2142         (WebKitStyleTest.test_using_namespace):
2143
2144 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2145
2146         Get rid of multiple inheritance support from the bindings generators
2147         https://bugs.webkit.org/show_bug.cgi?id=118353
2148
2149         Reviewed by Kentaro Hara.
2150
2151         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
2152         deprecated domInterface->parents.
2153
2154         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2155         (_parentInterface):
2156
2157 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2158
2159         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
2160         https://bugs.webkit.org/show_bug.cgi?id=57241
2161
2162         Reviewed by Ryosuke Niwa.
2163
2164         Added check for "using namespace foo" and unit test.
2165
2166         * Scripts/webkitpy/style/checkers/cpp.py:
2167         (check_using_namespace):
2168         (check_style):
2169         (CppChecker):
2170         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2171         (WebKitStyleTest.test_using_namespace):
2172
2173 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
2174
2175         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
2176         https://bugs.webkit.org/show_bug.cgi?id=110222
2177
2178         Reviewed by Gustavo Noronha Silva.
2179
2180         Added handling of zero mouse scroll deltas in EventSender.
2181
2182         * DumpRenderTree/gtk/EventSender.cpp:
2183         (mouseScrollByCallback):
2184
2185 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2186
2187         webkitpy: replace urllib with urllib2 for downloading additional modules
2188         https://bugs.webkit.org/show_bug.cgi?id=118671
2189
2190         Reviewed by Ryosuke Niwa.
2191
2192         Urllib2 is available whereever urllib is, but has better proxy support.
2193
2194         * Scripts/webkitpy/common/system/autoinstall.py:
2195         (AutoInstaller._download_to_stream):
2196
2197 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
2198
2199         [ATK] Adds support for aria-haspopup property.
2200         https://bugs.webkit.org/show_bug.cgi?id=117834
2201
2202         Reviewed by Christophe Dumez.
2203
2204         Adds implementation for testing aria-haspopup property.
2205
2206         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2207         (getAttributeSetValueForId):
2208         (AccessibilityUIElement::stringAttributeValue):
2209         (AccessibilityUIElement::hasPopup):
2210         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2211         (WTR::getAttributeSetValueForId):
2212         (WTR::AccessibilityUIElement::stringAttributeValue):
2213         (WTR::AccessibilityUIElement::hasPopup):
2214
2215 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
2216
2217         [Qt] Replace Nokia references.
2218         https://bugs.webkit.org/show_bug.cgi?id=118728
2219
2220         Reviewed by Simon Hausmann.
2221
2222         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2223         (MiniBrowserApplication::MiniBrowserApplication):
2224         * QtTestBrowser/qttestbrowser.cpp:
2225         (LauncherApplication::LauncherApplication):
2226
2227 2013-07-15  Tim Horton  <timothy_horton@apple.com>
2228
2229         Update blocked/missing plug-in UI
2230         https://bugs.webkit.org/show_bug.cgi?id=118347
2231         <rdar://problem/14209318>
2232
2233         Reviewed by Sam Weinig.
2234
2235         * MiniBrowser/mac/WK2BrowserWindowController.m:
2236         (-[WK2BrowserWindowController awakeFromNib]):
2237         * WebKitTestRunner/TestController.cpp:
2238         (WTR::TestController::createWebViewWithOptions):
2239         Match new WKPageLoaderClient entry.
2240
2241 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
2242
2243         Update James Craig's email address.
2244
2245         * Scripts/webkitpy/common/config/contributors.json:
2246
2247 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
2248
2249         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
2250         https://bugs.webkit.org/show_bug.cgi?id=118583
2251
2252         Reviewed by Christophe Dumez.
2253
2254         There're many fails on efl webkit2 API test if opengl is not available.
2255         So, add fallback to non-opengl evas engine.
2256
2257         * TestWebKitAPI/efl/PlatformWebView.cpp:
2258         (TestWebKitAPI::initEcoreEvas):
2259
2260 2013-07-15  Brian Holt  <brian.holt@samsung.com>
2261
2262         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2263         https://bugs.webkit.org/show_bug.cgi?id=118592
2264
2265         Reviewed by Martin Robinson.
2266
2267         Added a suppression for pylint false positives and a unit test.
2268
2269         * Scripts/webkitpy/style/checkers/python.py:
2270         (Pylinter):
2271         * Scripts/webkitpy/style/checkers/python_unittest.py:
2272         (PythonCheckerTest.test_check):
2273         (PythonCheckerTest):
2274         (PythonCheckerTest.test_pylint_false_positives):
2275         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
2276         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2277         (test_popen):
2278
2279 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2280
2281         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
2282         https://bugs.webkit.org/show_bug.cgi?id=115166
2283
2284         Reviewed by Philippe Normand.
2285
2286         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2287
2288 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
2289
2290         Unreviewed. Add an email address and update my domain of experts.
2291
2292         * Scripts/webkitpy/common/config/contributors.json:
2293
2294 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2295
2296         [jhbuild] Avoid restarting from scratch failed initial checkouts
2297         https://bugs.webkit.org/show_bug.cgi?id=118603
2298
2299         Reviewed by Martin Robinson.
2300
2301         If the initial checkout is interrupted midway (eg. because the internet
2302         connection went down) config files do not get generated and that causes
2303         the next checkout to start from scratch (the missing files cause the
2304         script to delete the build root and the downloaded sources).
2305
2306         By generating the files before invoking jhbuild, subsequent runs are able
2307         to start where the previous run left.
2308
2309         * Scripts/update-webkit-libs-jhbuild:
2310         (saveJhbuildMd5): invoke it before runJhbuild().
2311
2312 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
2313
2314         [Windows] Remove single-worker restriction on tests.
2315
2316         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
2317
2318 2013-07-12  Commit Queue  <commit-queue@webkit.org>
2319
2320         Unreviewed, rolling out r152599.
2321         http://trac.webkit.org/changeset/152599
2322         https://bugs.webkit.org/show_bug.cgi?id=118612
2323
2324         This patch includes a failing unit test (Requested by
2325         mrobinson on #webkit).
2326
2327         * Scripts/webkitpy/style/checkers/python.py:
2328         (Pylinter):
2329         * Scripts/webkitpy/style/checkers/python_unittest.py:
2330         (PythonCheckerTest.test_check):
2331         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
2332
2333 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2334
2335         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
2336         https://bugs.webkit.org/show_bug.cgi?id=91223
2337
2338         Reviewed by Martin Robinson.
2339
2340         When run on a clean checkout, `build-webkit` complains that no
2341         GNUmakefile exists when trying to detect the previously configured
2342         architecture, but in this case there's no previous configuration so
2343         the warning is pointless.
2344
2345         * Scripts/webkitdirs.pm:
2346         (determineArchitecture): Redirect grep stderr to /dev/null.
2347
2348 2013-07-12  Brian Holt  <brian.holt@samsung.com>
2349
2350         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2351         https://bugs.webkit.org/show_bug.cgi?id=118592
2352
2353         Reviewed by Martin Robinson.
2354
2355         Added a suppression for pylint false positives and a unit test.
2356
2357         * Scripts/webkitpy/style/checkers/python.py:
2358         (Pylinter):
2359         * Scripts/webkitpy/style/checkers/python_unittest.py:
2360         (PythonCheckerTest.test_check):
2361         (PythonCheckerTest):
2362         (PythonCheckerTest.test_pylint_false_positives):
2363         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
2364         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2365         (test_popen):
2366
2367 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
2368
2369         Unreviewed. Add myself as a committer.
2370
2371         * Scripts/webkitpy/common/config/contributors.json:
2372
2373 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
2374
2375         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
2376         https://bugs.webkit.org/show_bug.cgi?id=118538
2377
2378         Reviewed by Christophe Dumez.
2379
2380         When attempting some odd url such as ``foo'', MiniBrowser will now show an
2381         error message such as "Cannot resolve hostname (foo)".
2382
2383         Previously, it had the following behavior if MiniBrowser was started with
2384         such urls, e.g ``./MiniBrowser foo'':
2385
2386         - Debug:
2387         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
2388
2389         - Release:
2390         No asserts, naturally, but the view would remain blank, even if we tried to
2391         change to a valid url.
2392
2393         * MiniBrowser/efl/main.c:
2394         (window_create):
2395
2396 2013-07-10  Simon Pena  <simon.pena@samsung.com>
2397
2398         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
2399         https://bugs.webkit.org/show_bug.cgi?id=118509
2400
2401         Reviewed by Martin Robinson.
2402
2403         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
2404         when trying to remove an event already removed, if another event is
2405         processed in the middle. By using a Deque's takeFirst, we ensure the
2406         element is removed before we dispatch it.
2407
2408         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
2409         crashes after this fix is added.
2410
2411         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
2412         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2413         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
2414         from the queue.
2415
2416 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
2417
2418         [EFL] Add ewk_view_device_pixel_ratio_set
2419         https://bugs.webkit.org/show_bug.cgi?id=118521
2420
2421         Reviewed by Gyuyoung Kim.
2422
2423         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
2424         (windowCreate):
2425         (parseUserArguments):
2426
2427 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
2428
2429         Unreviewed change of my email addresses.
2430         https://bugs.webkit.org/show_bug.cgi?id=100122
2431
2432         * Scripts/webkitpy/common/config/contributors.json:
2433
2434 2013-07-09  Anders Carlsson  <andersca@apple.com>
2435
2436         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
2437         https://bugs.webkit.org/show_bug.cgi?id=118514
2438         <rdar://problem/13686836>
2439
2440         Reviewed by Sam Weinig.
2441
2442         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
2443
2444         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
2445         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
2446         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2447         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2448         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
2449
2450         * DumpRenderTree/mac/DumpRenderTree.mm:
2451         (allocateGlobalControllers):
2452         Allocate a DefaultPolicyDelegate object.
2453
2454         (resetWebViewToConsistentStateBeforeTesting):
2455         Set the policy delegate to the default policy delegate.
2456
2457         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2458         Declare the defaultPolicyDelegate object.
2459
2460         * DumpRenderTree/mac/TestRunnerMac.mm:
2461         (TestRunner::setCustomPolicyDelegate):
2462         Set the policy delegate to the default delegate if setDelegate is false.
2463
2464 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
2465
2466         KURL unit test fixture class should have a meaningful name
2467         https://bugs.webkit.org/show_bug.cgi?id=118467
2468
2469         Reviewed by Sam Weinig.
2470
2471         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2472         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
2473         instead of the generic and inappropriate 'WebCore' name.
2474
2475 2013-07-08  Antti Koivisto  <antti@apple.com>
2476
2477         Add Deque::removeLast
2478         https://bugs.webkit.org/show_bug.cgi?id=118466
2479
2480         Reviewed by Andreas Kling.
2481
2482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2483         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
2484         (TestWebKitAPI::TEST):
2485
2486 2013-07-08  Brian Holt  <brian.holt@samsung.com>
2487
2488         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
2489         https://bugs.webkit.org/show_bug.cgi?id=118412
2490
2491         Reviewed by Martin Robinson.
2492
2493         An adoptRef is required to balance ref and deref calls.
2494
2495         * DumpRenderTree/gtk/EventSender.cpp:
2496         (beginDragWithFilesCallback):
2497
2498 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
2499
2500         Update list of EFL WK2 API tests
2501         https://bugs.webkit.org/show_bug.cgi?id=118443
2502
2503         Reviewed by Christophe Dumez.
2504
2505         The following tests were included:
2506
2507         Passing:
2508         - CloseThenTerminate
2509         - DidAssociateFormControls
2510         - PageVisibilityState
2511         - ResponsivenessTimerDoesntFireEarly
2512         - TerminateTwice
2513         - WillLoad
2514
2515         Failing:
2516         - ResizeReversePaginatedWebView
2517         - ScrollPinningBehaviors
2518
2519         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
2520         alphabetical order.
2521
2522         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
2523         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
2524
2525 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2526
2527         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
2528         https://bugs.webkit.org/show_bug.cgi?id=118439
2529         <rdar://problem/14366120>
2530
2531         Reviewed by Anders Carlsson.
2532
2533         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2534         (TestWebKitAPI::didLayout):
2535         (TestWebKitAPI::TEST):
2536         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
2537         - Assert that we got the right number of pages for sanity.
2538         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
2539             so much memory that SharedMemory asserts and makes the test time out.
2540         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
2541             because paint doesn't fire if the window is offscreen.
2542
2543 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2544
2545         [wk2] Add API to lock the scroll position at the top or bottom of the page
2546         https://bugs.webkit.org/show_bug.cgi?id=118429
2547         <rdar://problem/14120323>
2548
2549         Reviewed by Anders Carlsson.
2550
2551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2552         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
2553         (TestWebKitAPI::didFinishDocumentLoadForFrame):
2554         (TestWebKitAPI::TEST):
2555         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
2556         all work correctly in the face of resizing the view and scrolling from JS.
2557
2558 2013-07-05  Michael Pruett  <michael@68k.org>
2559
2560         Unreviewed. Add myself as a committer.
2561
2562         * Scripts/webkitpy/common/config/contributors.json:
2563
2564 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2565
2566         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
2567         https://bugs.webkit.org/show_bug.cgi?id=111434
2568
2569         Reviewed by Carlos Garcia Campos.
2570
2571         * Scripts/run-gtk-tests:
2572         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
2573
2574 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
2575
2576         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
2577         https://bugs.webkit.org/show_bug.cgi?id=118370
2578
2579         Reviewed by Christophe Dumez.
2580
2581         Add fallback to software X11 engine if opengl_x11 engine creation fails.
2582
2583         * DumpRenderTree/efl/DumpRenderTree.cpp:
2584         (initEcoreEvas):
2585
2586 2013-07-04  Brian Holt  <brian.holt@samsung.com>
2587
2588         [ATK] Leak: AtkAttributeSet* should be freed
2589         https://bugs.webkit.org/show_bug.cgi?id=118307
2590
2591         Reviewed by Christophe Dumez.
2592
2593         Fixed memory leaks for AtkAttributeSet by calling
2594         atk_attribute_set_free().
2595
2596         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2597         (AccessibilityController::childElementById):
2598         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2599         (getAtkAttributeSetAsString):
2600         (AccessibilityUIElement::allAttributes):
2601         (AccessibilityUIElement::stringAttributeValue):
2602         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2603         (WTR::childElementById):
2604         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2605         (WTR::getAtkAttributeSetAsString):
2606         (WTR::AccessibilityUIElement::allAttributes):
2607         (WTR::AccessibilityUIElement::stringAttributeValue):
2608
2609 2013-07-03  David Farler  <dfarler@apple.com>
2610
2611         Add Makefile to WebKitLauncher
2612         https://bugs.webkit.org/show_bug.cgi?id=118365
2613
2614         Reviewed by Mark Rowe.
2615
2616         * WebKitLauncher/Makefile: Added.
2617
2618 2013-07-03  Brian Holt  <brian.holt@samsung.com>
2619
2620         [ATK] Leak: more leaks in AccessibilityUIElement
2621         https://bugs.webkit.org/show_bug.cgi?id=118362
2622
2623         Reviewed by Christophe Dumez.
2624
2625         Free the memory created by g_strdup_printf.
2626
2627         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2628         (AccessibilityUIElement::language):
2629         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2630         (WTR::AccessibilityUIElement::language):
2631
2632 2013-07-03  Jer Noble  <jer.noble@apple.com>
2633
2634         Xcode often gets in a state where the debugger is completely unresponsive
2635         https://bugs.webkit.org/show_bug.cgi?id=118157
2636
2637         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
2638         Rather than pull the character data out of the debugger one byte at a time
2639         through the GetPointeeData() API, retrieve the memory contents of the string through
2640         the ReadMemory() API, and convert the retrieved memory into a python string.
2641
2642         Reviewed by Anders Carlsson.
2643
2644         * lldb/lldb_webkit.py:
2645         (__lldb_init_module.lldb_webkit):
2646         (guess_string_length):
2647         (ustring_to_string):
2648         (lstring_to_string):
2649
2650 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
2651
2652         [GTK] Let F5 refresh the page in MiniBrowser
2653         https://bugs.webkit.org/show_bug.cgi?id=117638
2654
2655         Reviewed by Carlos Garcia Campos.
2656
2657         Also use the correct icon for the refresh button that was already there.
2658
2659         * MiniBrowser/gtk/BrowserWindow.c:
2660         (browser_window_init):
2661
2662 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
2663
2664         Unreviewed. Add my email to a few watchlists.
2665
2666         * Scripts/webkitpy/common/config/watchlist:
2667
2668 2013-07-02  David Farler  <dfarler@apple.com>
2669
2670         Unreviewed. Adding myself to contributors.json.
2671
2672         * Scripts/webkitpy/common/config/contributors.json:
2673
2674 2013-07-02  Brian Holt  <brian.holt@samsung.com>
2675
2676         [ATK] Leak: leaks in AccessibilityUIElement
2677         https://bugs.webkit.org/show_bug.cgi?id=118297
2678
2679         Fixed memory leak.
2680
2681         Reviewed by Christophe Dumez.
2682
2683         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2684         (AccessibilityUIElement::stringValue):
2685
2686 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
2687
2688         Fix WebKitTestRunner crashes.
2689         https://bugs.webkit.org/show_bug.cgi?id=117630
2690
2691         Reviewed by Darin Adler.
2692
2693         Create static function to dump for WebProcess unresponsiveness status,
2694         and use it before calling TestController::runTest().
2695
2696         Accessing TestController::m_currentInvocation before calling
2697         TestController::runTest() can make crash because the invocation
2698         instance will be assigned at the function.
2699
2700         * WebKitTestRunner/TestController.cpp:
2701         (WTR::TestController::run):
2702         * WebKitTestRunner/TestInvocation.cpp:
2703         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2704         * WebKitTestRunner/TestInvocation.h:
2705
2706 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2707
2708         [Qt][WK1] Support WebGL with EGL on Linux
2709         https://bugs.webkit.org/show_bug.cgi?id=118251
2710
2711         Reviewed by Kenneth Rohde Christiansen.
2712
2713         * qmake/mkspecs/features/features.prf:
2714
2715 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
2716
2717         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
2718         https://bugs.webkit.org/show_bug.cgi?id=118267
2719
2720         Reviewed by Gyuyoung Kim.
2721
2722         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
2723         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
2724         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
2725
2726         * efl/jhbuildrc:
2727         * gtk/jhbuildrc:
2728
2729 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2730
2731         [GTK] Remove unsupported AC backends
2732         https://bugs.webkit.org/show_bug.cgi?id=117362
2733
2734         Reviewed by Martin Robinson.
2735
2736         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
2737         and cogl, so removed.
2738
2739 2013-07-01  Timothy Hatcher  <timothy@apple.com>
2740
2741         Link to WebInspectorUI.framework at build time instead of soft linking.
2742
2743         https://bugs.webkit.org/show_bug.cgi?id=118261
2744
2745         Reviewed by Joseph Pecoraro.
2746
2747         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
2748
2749 2013-07-01  Tim Horton  <timothy_horton@apple.com>
2750
2751         Maximum scroll position can be negative in some cases
2752         https://bugs.webkit.org/show_bug.cgi?id=118175
2753         <rdar://problem/14301217>
2754
2755         Reviewed by Anders Carlsson.
2756
2757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2758         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
2759         (TestWebKitAPI::didRunJavaScript):
2760         (TestWebKitAPI::didLayout):
2761         (TestWebKitAPI::TEST):
2762         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
2763         Add a test that loads a vertical-lr document, paginates it horizontally
2764         from right to left, resizes the view to fit the entire document, and
2765         verifies that the scroll position is negative, as it must be for the
2766         document to be enclosed by the view.
2767
2768 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2769
2770         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
2771         https://bugs.webkit.org/show_bug.cgi?id=117249
2772
2773         Reviewed by Brent Fulgham.
2774
2775         Finish converting all use cases of WEBKITOUTPUTDIR to
2776         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
2777
2778         * DumpRenderTree/efl/FontManagement.cpp:
2779         (getCustomBuildDir):
2780         (getPlatformFontsPath):
2781         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2782         (getOutputDir):
2783         * Scripts/webkitdirs.pm:
2784         (determineBaseProductDir):
2785         (usesPerConfigurationBuildDirectory):
2786         * Scripts/webkitpy/port/base.py:
2787         (Port.to.setup_environ_for_server):
2788         * Scripts/webkitpy/port/driver.py:
2789         (Driver._setup_environ_for_driver):
2790         * Scripts/webkitpy/port/gtk.py:
2791         (GtkPort.setup_environ_for_server):
2792         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2793         (WTR::getOutputDir):
2794         * jhbuild/jhbuildutils.py:
2795         (get_dependencies_path):
2796
2797 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
2798
2799         Unreviewed change of my email address.
2800
2801         * Scripts/webkitpy/common/config/contributors.json:
2802
2803 2013-06-28  Andreas Kling  <akling@apple.com>
2804
2805         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
2806
2807         * DumpRenderTree/win/DumpRenderTree.cpp:
2808         (addFontFallbackIfPresent):
2809         (removeFontFallbackIfPresent):
2810
2811 2013-06-28  Anders Carlsson  <andersca@apple.com>
2812
2813         Remove String::deprecatedCharactersWithNullTermination() and related code
2814         https://bugs.webkit.org/show_bug.cgi?id=118211
2815
2816         Reviewed by Benjamin Poulain.
2817
2818         Remove all hasTerminatingNullCharacter() checks.
2819
2820         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2821         (TestWebKitAPI::TEST):
2822         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2823         (TestWebKitAPI::TEST):
2824         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2825         (TestWebKitAPI::TEST):
2826
2827 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
2828
2829         [Mac] Crash when loading is stopped from -didReceiveResponse
2830         https://bugs.webkit.org/show_bug.cgi?id=118209
2831         <rdar://problem/14259249>
2832
2833         Reviewed by Brady Eidson.
2834
2835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2836         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
2837         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
2838         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
2839         (TestWebKitAPI::TEST):
2840
2841 2013-06-28  Andy Estes  <aestes@apple.com>
2842
2843         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
2844         https://bugs.webkit.org/show_bug.cgi?id=118208
2845
2846         Reviewed by Mark Rowe.
2847
2848         Newer versions of clang use a default template depth of 128, but this
2849         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
2850         previous default.
2851
2852         Clang lowered the default to keep recursive template instantiation
2853         from overflowing the stack (see <rdar://problem/13935016>), but
2854         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
2855         higher limit. If for some reason this starts happening then we can
2856         lower the limit back down.
2857
2858         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
2859
2860 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
2861
2862         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
2863         https://bugs.webkit.org/show_bug.cgi?id=118195
2864
2865         Reviewed by Daniel Bates.
2866
2867         Currently, ports that use jhbuild fail to determine jhbuild directory
2868         when "webKitBranchBuild" git configuration property is enabled. To reproduce
2869         that issue in Efl port, enable that flag in .git/config, switch to a git branch
2870         other than "master" and try to build webkit. The build will fail to
2871         locate dependencies due to lack of pkg-config paths which should be set
2872         by jhbuild.
2873
2874         For more details about "webKitBranchBuild" option, see:
2875         https://trac.webkit.org/wiki/UsingGitWithWebKit
2876
2877         * Scripts/webkitdirs.pm:
2878         (getJhbuildPath):
2879
2880 2013-06-28  Jessie Berlin  <jberlin@apple.com>
2881
2882         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
2883         https://bugs.webkit.org/show_bug.cgi?id=118201
2884
2885         Reviewed by Dean Jackson.
2886
2887         * WebKitTestRunner/mac/main.mm:
2888         (main):
2889         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
2890         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
2891
2892 2013-06-28  David Farler  <dfarler@apple.com>
2893
2894         Upstream WebKit Nightly’s WebKitLauncher
2895         https://bugs.webkit.org/show_bug.cgi?id=117418
2896
2897         Reviewed by Mark Rowe.
2898
2899         Literal patch from Nightly's OpenSource repo.
2900
2901         * WebKitLauncher/Configurations/Base.xcconfig:
2902         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
2903         * WebKitLauncher/Info.plist:
2904         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2905         * WebKitLauncher/WebKitLauncherURLProtocol.m:
2906         (+[WebKitLauncherURLProtocol load]):
2907         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
2908         (-[WebKitLauncherURLProtocol startLoading]):
2909         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
2910         (-[WebKitLauncherURLProtocol resourceNotFound]):
2911         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2912         (initializeSparkle):
2913         * WebKitLauncher/main.m:
2914         (determineExecutablePath):
2915         (currentMacOSXVersion):
2916         (main):
2917         * WebKitLauncher/start.html:
2918
2919 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
2920
2921         [EFL] back/forward keyboard shortcuts are non-intuitive
2922         https://bugs.webkit.org/show_bug.cgi?id=118193
2923
2924         Reviewed by Christophe Dumez.
2925
2926         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
2927
2928         * EWebLauncher/main.c:
2929         (on_key_down):
2930         * MiniBrowser/efl/main.c:
2931         (on_key_down):
2932
2933 2013-06-28  Roger Fong  <roger_fong@apple.com>
2934
2935         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
2936         https://bugs.webkit.org/show_bug.cgi?id=118194.
2937
2938         Reviewed by Brent Fulgham.
2939
2940         * DumpRenderTree/win/DumpRenderTree.cpp:
2941         (dllLauncherEntryPoint):
2942         * WinLauncher/WinLauncher.cpp:
2943         (dllLauncherEntryPoint):
2944
2945 2013-06-28  Roger Fong  <roger_fong@apple.com>
2946
2947         Unreviewed build fix for AppleWin port. Fix some file paths.
2948
2949         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2950         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2951
2952 2013-06-27  Roger Fong  <roger_fong@apple.com>
2953
2954         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
2955         https://bugs.webkit.org/show_bug.cgi?id=118160.
2956
2957         Reviewed by Brent Fulgham.
2958
2959         * WinLauncher/AccessibilityDelegate.cpp: Added.
2960         (AccessibilityDelegate::QueryInterface):
2961         (AccessibilityDelegate::AddRef):
2962         (AccessibilityDelegate::Release):
2963         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
2964         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
2965         * WinLauncher/AccessibilityDelegate.h: Added.
2966         (AccessibilityDelegate::AccessibilityDelegate):
2967         * WinLauncher/WinLauncher.cpp:
2968         (dllLauncherEntryPoint):
2969         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2970         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2971
2972 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2973
2974         Clean up temporary files created by the bindings test script
2975         https://bugs.webkit.org/show_bug.cgi?id=118189
2976
2977         Reviewed by Kentaro Hara.
2978
2979         Remove temporary files created by preprocess-idls.pl script after
2980         the bindings tests are executed.
2981
2982         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
2983
2984         * Scripts/webkitpy/bindings/main.py:
2985         (BindingsTests.main):
2986
2987 2013-06-26  Dean Jackson  <dino@apple.com>
2988
2989         [Mac] Add Mavericks system font to Test systems
2990         https://bugs.webkit.org/show_bug.cgi?id=118109
2991
2992         Reviewed by Simon Fraser.
2993
2994         OS X Mavericks uses a different font for system controls. Tell DRT and
2995         WKTR about them otherwise they use a fallback font. Unfortunately the
2996         fonts are hidden (not found in the list of available fonts) so I
2997         had to add them manually.
2998
2999         Even though there is only one at the moment, I implemented this
3000         as a set so it will be easier to add new fonts if necessary.
3001
3002         * DumpRenderTree/mac/DumpRenderTree.mm:
3003         (allowedFontFamilySet): Fixed typo.
3004         (systemHiddenFontFamilySet): New method that returns the system control font.
3005         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
3006         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3007         (WTR::allowedFontFamilySet): Fixed typo.
3008         (WTR::systemHiddenFontFamilySet): As above.
3009         (WTR::wtr_NSFontManager_availableFonts):
3010
3011 2013-06-27  Anders Carlsson  <andersca@apple.com>
3012
3013         Get rid of the last uses of deprecatedCharactersWithNullTermination()
3014         https://bugs.webkit.org/show_bug.cgi?id=118159
3015
3016         Reviewed by Andreas Kling.
3017
3018         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
3019
3020         * DumpRenderTree/win/DumpRenderTree.cpp:
3021         (findFontFallback):
3022
3023 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
3024
3025         Sync up w3c import script with changes in Blink
3026         https://bugs.webkit.org/show_bug.cgi?id=118149
3027
3028         Reviewed by Dirk Pranke.
3029
3030         This is a port of the following blink changes:
3031
3032         https://codereview.chromium.org/15366004
3033         https://chromiumcodereview.appspot.com/15592005
3034         https://codereview.chromium.org/16021006
3035         https://codereview.chromium.org/15590004
3036         https://codereview.chromium.org/15901008
3037         https://codereview.chromium.org/16171009
3038         https://codereview.chromium.org/16465007
3039         https://codereview.chromium.org/15981013
3040
3041         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3042         (setUp):
3043         (test_commit_message_for_this_commit):
3044         * Scripts/webkitpy/port/base.py:
3045         (Port):
3046         * Scripts/webkitpy/port/test.py:
3047         * Scripts/webkitpy/w3c/test_converter.py:
3048         (W3CTestConverter.__init__):
3049         (W3CTestConverter.read_webkit_prefixed_css_property_list):
3050         (W3CTestConverter.convert_for_webkit):
3051         (W3CTestConverter.convert_css):
3052         (W3CTestConverter.convert_html):
3053         (W3CTestConverter.convert_testharness_paths):
3054         (W3CTestConverter.convert_prefixed_properties):
3055         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3056         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3057         * Scripts/webkitpy/w3c/test_importer.py:
3058         (main):
3059         (configure_logging):
3060         (configure_logging.LogHandler):
3061         (configure_logging.LogHandler.format):
3062         (parse_args):
3063         (TestImporter.__init__):
3064         (TestImporter.find_importable_tests):
3065         (TestImporter.import_tests):
3066         (TestImporter.setup_destination_directory):
3067         (TestImporter.remove_deleted_files):
3068         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3069         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3070         (TestImporterTest.test_import_dir_with_no_tests):
3071         (TestImporterTest):
3072         * Scripts/webkitpy/w3c/test_parser.py:
3073         (TestParser.load_file):
3074         (TestParser.analyze_test):
3075         (TestParser.support_files):
3076         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3077
3078 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
3079
3080         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
3081         https://bugs.webkit.org/show_bug.cgi?id=118128
3082
3083         Reviewed by Ryosuke Niwa.
3084
3085         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
3086         https://bugs.webkit.org/show_bug.cgi?id=117831
3087
3088         * Scripts/webkitpy/tool/commands/download.py:
3089         (AbstractPatchSequencingCommand):
3090         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
3091         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
3092         (AbstractPatchSequencingCommand._prepare_state): Added.
3093
3094 2013-06-27  Brendan Long  <b.long@cablelabs.com>
3095
3096         [Qt] Build overrides -j when given --makeargs="-sj40"
3097         https://bugs.webkit.org/show_bug.cgi?id=116897
3098
3099         Reviewed by Csaba Osztrogonác.
3100
3101         * Scripts/webkitdirs.pm:
3102         (buildQMakeProjects):
3103         Change regex checking for -j* to also check for -*j*
3104
3105 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3106
3107         Remove [NoInterfaceObject] from WorkerGlobalScope
3108         https://bugs.webkit.org/show_bug.cgi?id=118071
3109
3110         Reviewed by Kentaro Hara.
3111
3112         Update bindings test script to pass 2 additional parameters
3113         now needed by the preprocess-idls.pl script.
3114
3115         * Scripts/webkitpy/bindings/main.py:
3116         (BindingsTests.generate_supplemental_dependency):
3117         (BindingsTests.main):
3118
3119 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3120
3121         Fixing some compiler warnings
3122         https://bugs.webkit.org/show_bug.cgi?id=117791
3123
3124         Reviewed by Martin Robinson.
3125
3126         * GNUmakefile.am: Silenced format warning.
3127         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3128         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
3129         Solved warning about uninitialized variable.
3130
3131 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3132
3133         Fix bindings tests after r152080
3134         https://bugs.webkit.org/show_bug.cgi?id=118118
3135
3136         Reviewed by Gyuyoung Kim.
3137
3138         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
3139         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
3140         accordingly.
3141
3142         * Scripts/webkitpy/bindings/main.py:
3143         (BindingsTests.generate_supplemental_dependency):
3144         (BindingsTests.main):
3145
3146 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
3147
3148         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
3149         https://bugs.webkit.org/show_bug.cgi?id=117982
3150
3151         Reviewed by Rob Buis.
3152
3153         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3154         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
3155         m_policyDelegateIsPermissive.
3156         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3157         Reset m_policyDelegateIsPermissive.
3158         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
3159         m_policyDelegateIsPermissive.
3160         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3161         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
3162         Return whether custom policy is enabled.
3163         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
3164         Return whether custom policy is permissive.
3165
3166 2013-06-26  Anders Carlsson  <andersca@apple.com>
3167
3168         Deprecate StringImpl::charactersWithNullTermination
3169         https://bugs.webkit.org/show_bug.cgi?id=118108
3170
3171         Reviewed by Beth Dakin.
3172
3173         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
3174
3175         * DumpRenderTree/win/DumpRenderTree.cpp:
3176         (findFontFallback):
3177         (addFontFallbackIfPresent):
3178         (removeFontFallbackIfPresent):
3179
3180 2013-06-26  Nico Weber  <thakis@chromium.org>
3181
3182         Remove detect-mismached-virtual-const.
3183         https://bugs.webkit.org/show_bug.cgi?id=117999
3184
3185         Reviewed by Anders Carlsson.
3186
3187         Clang warns on mismatched virtual const, so there's no need for this
3188         script any more.
3189
3190         * Scripts/detect-mismatched-virtual-const: Removed.
3191
3192 2013-06-26  Alex Christensen  <achristensen@apple.com>
3193
3194         Added a code coverage report.
3195         https://bugs.webkit.org/show_bug.cgi?id=117941
3196
3197         Reviewed by Joseph Pecoraro.
3198
3199         * CodeCoverage: Added.
3200         * CodeCoverage/results-template.html: Added.
3201         * Scripts/generate-coverage-data: Generate and open the new report.
3202
3203 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3204
3205         gdb: Remove the webcore.py pretty printer.
3206         https://bugs.webkit.org/show_bug.cgi?id=117992
3207
3208         Reviewed by Jochen Eisinger.
3209
3210         webcore.py has been only a placeholder for backwards compatibility
3211         for almost 3 years. It should be safe enough to remove it now.
3212
3213         * gdb/webcore.py: Removed.
3214
3215 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
3216
3217         Creating cURL watchlist and adding myself to it.
3218
3219         Reviewed by Csaba Osztrogonác.
3220
3221         * Scripts/webkitpy/common/config/watchlist:
3222
3223 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3224
3225         Unreviewed, change my email address for watch list.
3226
3227         * Scripts/webkitpy/common/config/watchlist:
3228
3229 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
3230
3231         [EFL] Add a script to install dependencies.
3232         https://bugs.webkit.org/show_bug.cgi?id=117968
3233
3234         Reviewed by Christophe Dumez.
3235
3236         Add a script which installs basic dependencies for building WebKit EFL.
3237
3238         The dependencies are from the current EFLWebKit wiki page.
3239         After this patch is landed, the wiki page will be updated to use
3240         this script.
3241
3242         * efl/install-dependencies: Added.
3243
3244 2013-06-24  Dean Jackson  <dino@apple.com>
3245
3246         [Mac] Update font used for Chinese in test systems
3247         https://bugs.webkit.org/show_bug.cgi?id=117970
3248
3249         Reviewed by Alexey Proskuryakov.
3250
3251         Add "Songti TC" and "Songti SC" to the list of allowed fonts
3252         in DRT and WKTR.
3253
3254         * DumpRenderTree/mac/DumpRenderTree.mm:
3255         (allowedFontFamilySet):
3256         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3257         (WTR::allowedFontFamilySet):
3258
3259 2013-06-24  Tim Horton  <timothy_horton@apple.com>
3260
3261         Make MiniBrowser paginated mode work with WebKit1
3262         https://bugs.webkit.org/show_bug.cgi?id=117950
3263
3264         Reviewed by Beth Dakin.
3265
3266         * MiniBrowser/mac/WK1BrowserWindowController.m:
3267         (-[WK1BrowserWindowController isPaginated]):
3268         (-[WK1BrowserWindowController togglePaginationMode:]):
3269         Hook up isPaginated and togglePaginationMode just as for WebKit2.
3270
3271 2013-06-24  David Kilzer  <ddkilzer@apple.com>
3272
3273         bisect-builds: improve heuristic for choosing the next build after a broken build
3274         <http://webkit.org/b/117918>
3275
3276         Reviewed by Simon Fraser.
3277
3278         * Scripts/bisect-builds: When a build is broken, use a heuristic
3279         that "bisects" the left side or the right side of the remaining
3280         revisions to pick a revision that's sufficiently different from
3281         the revision of the broken build.  This heuristic assumes there
3282         is a sequential range of broken builds whenever one broken build
3283         is found.
3284
3285 2013-06-24  Chris Rogers  <crogers@google.com>
3286
3287         WaveTable name has changed to PeriodicWave
3288         https://bugs.webkit.org/show_bug.cgi?id=117748
3289
3290         Reviewed by Jer Noble.
3291
3292         * Scripts/do-webcore-rename:
3293
3294 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
3295
3296         [EFL] Add support for MHTML save/load feature to MiniBrowser
3297         https://bugs.webkit.org/show_bug.cgi?id=106620
3298
3299         Reviewed by Christophe Dumez.
3300
3301         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
3302         from filesystem.
3303
3304         * MiniBrowser/efl/CMakeLists.txt:
3305         * MiniBrowser/efl/main.c:
3306         (page_contents_callback):
3307         (on_key_down):
3308         (show_file_entry_dialog): generic function to show file enrty
3309         selector dialogue
3310
3311 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
3312
3313         [Windows] Unreviewed crash protection for DRT
3314
3315         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
3316         to avoid crashing during test runs.
3317
3318 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3319
3320         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
3321         https://bugs.webkit.org/show_bug.cgi?id=117825
3322
3323         Reviewed by Kentaro Hara.
3324
3325         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
3326
3327         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3328         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3329         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3330         (TestRunner::overridePreference):
3331
3332 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
3333
3334         [ATK] Added support for aria-required attribute.
3335         https://bugs.webkit.org/show_bug.cgi?id=117730
3336
3337         Reviewed by Chris Fleizach.
3338
3339         Added support for testing aria-required attribute.
3340
3341         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3342         (AccessibilityUIElement::isRequired):
3343         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3344         (WTR::AccessibilityUIElement::isRequired):
3345
3346 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
3347
3348         [CMAKE][EFL] Enable DOM4 Events Constructor
3349         https://bugs.webkit.org/show_bug.cgi?id=117858
3350
3351         Reviewed by Laszlo Gombos.
3352
3353         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
3354
3355 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3356
3357         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
3358         https://bugs.webkit.org/show_bug.cgi?id=117827
3359
3360         Reviewed by Rob Buis.
3361
3362         Reset the passed in request if willSendRequestReturnsNull() is
3363         true or willSendRequestReturnsNullOnRedirect() is true and it's a
3364         redirection.
3365
3366         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3367         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
3368         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3369
3370 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
3371
3372         Commit queue shouldn't reopen unrelated bugs because of flakiness
3373         https://bugs.webkit.org/show_bug.cgi?id=117503
3374
3375         Reviewed by Ryosuke Niwa.
3376
3377         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3378         (_follow_duplicate_chain):
3379         (_update_bug_for_flaky_test):
3380
3381 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
3382
3383         [Windows] AX: Expand notification support.
3384         https://bugs.webkit.org/show_bug.cgi?id=117761
3385
3386         Reviewed by Anders Carlsson.
3387
3388         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3389         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
3390         (AccessibilityUIElement::press): Provide implementation.
3391
3392 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
3393
3394         Use the PlatformEvent timestamp when creating a DOM Event
3395         https://bugs.webkit.org/show_bug.cgi?id=117179
3396
3397         Reviewed by Darin Adler.
3398
3399         * WebKitTestRunner/mac/EventSenderProxy.mm:
3400         (WTR::EventSenderProxy::mouseDown):
3401         (WTR::EventSenderProxy::mouseUp):
3402         (WTR::EventSenderProxy::mouseMoveTo):
3403         (WTR::EventSenderProxy::keyDown):
3404
3405 2013-06-18  Alex Christensen  <achristensen@apple.com>
3406
3407         Working on coverage script, added xml to json data extraction script.
3408         https://bugs.webkit.org/show_bug.cgi?id=117648
3409
3410         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
3411         coverage data, runs the tests, and collects all of the data in json format.
3412
3413         Reviewed by Stephanie Lewis.
3414
3415         * Scripts/generate-coverage-data:
3416         (parseGcovrOutput):
3417         (getFileHitsAndBranches):
3418         (addLineCounts):
3419         (createResultName):
3420         * Scripts/webkitpy/tool/gcovr: Added.
3421
3422 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
3423
3424         Unreviewed build fix after r151699.
3425
3426         * TestWebKitAPI/CMakeLists.txt:
3427         * WebKitTestRunner/CMakeLists.txt:
3428         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
3429
3430 2013-06-18  Roger Fong  <roger_fong@apple.com>
3431
3432         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
3433         <rdar://problem/14118143>.
3434
3435         Rubberstamped by Brent Fulgham.
3436
3437         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3438         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3439         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3440         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3441         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3442         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3443         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3444         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3445         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3446         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3447         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3448         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3449         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3450         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3451         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3452         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3453         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3454         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3455         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3456         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3457         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3458         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3459         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3460         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3461         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3462         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3463         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3464         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3465         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3466         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3467         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3468         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3469         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3470         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3471         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3472         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3473         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3474         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3475         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3476         * win/record-memory/record-memory.vcxproj:
3477         * win/record-memory/record-memoryDebug.props:
3478         * win/record-memory/record-memoryDebugWinCairo.props:
3479         * win/record-memory/record-memoryProduction.props:
3480         * win/record-memory/record-memoryRelease.props:
3481         * win/record-memory/record-memoryReleaseWinCairo.props:
3482
3483 2013-06-17  Kangil Han  <kangil.han@samsung.com>
3484
3485         Unreviewed. Add my email to a DOM watchlist.
3486
3487         * Scripts/webkitpy/common/config/watchlist:
3488
3489 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
3490
3491         Unreviewed GTK gardening.
3492
3493         * Scripts/run-gtk-tests:
3494         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
3495
3496 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
3497
3498         Unreviewed. Reorder my email addresses.
3499         https://bugs.webkit.org/show_bug.cgi?id=100122
3500
3501         * Scripts/webkitpy/common/config/contributors.json:
3502
3503 2013-06-14  Enrica Casucci  <enrica@apple.com>
3504
3505         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
3506         https://bugs.webkit.org/show_bug.cgi?id=117647
3507         <rdar://problem/13881024>
3508
3509         Reviewed by Darin Adler.
3510         
3511         The test now uses content with a selection and tests both
3512         forwards and backward find as well as the case of a find
3513         that has no matches after the user selection.
3514
3515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3516         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3517         (TestWebKitAPI::didFindStringMatches):
3518         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
3519
3520 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3521
3522         Remove myself from Qt build system watchlist
3523
3524         Reviewed by Simon Hausmann.
3525
3526         * Scripts/webkitpy/common/config/watchlist:
3527
3528 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
3529
3530         [Qt][Mac] Disable QTKit video on OS X.
3531         https://bugs.webkit.org/show_bug.cgi?id=117591
3532
3533         Reviewed by Tor Arne Vestbø.
3534
3535         Deployment of Qt binaries to different Mac OS X
3536         platform version makes it impossible to link against
3537         the correct version of the WebKitSystemInterface library,
3538         so we need to disable QTKit for media elements.
3539
3540         * qmake/mkspecs/features/features.prf:
3541
3542 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3543
3544         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
3545         https://bugs.webkit.org/show_bug.cgi?id=116610
3546
3547         Reviewed by Noam Rosenthal.
3548
3549         Remove unnecessary code adjusting context menu position to webview position.
3550         Now position is calculcated in EwkView.
3551
3552         * MiniBrowser/efl/main.c:
3553         (on_context_menu_show):
3554
3555 2013-06-12  Roger Fong  <roger_fong@apple.com>
3556
3557         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
3558
3559         * Scripts/webkitpy/common/config/ews.json:
3560
3561 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
3562
3563         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
3564         https://bugs.webkit.org/show_bug.cgi?id=115647
3565
3566         Reviewed by Martin Robinson.
3567
3568         Locale resolution is moved to WebKitAccessibleWrapperAtk using
3569         AtkObject::get_object_locale() API. Now, implementation of
3570         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
3571         be leveraged to get_object_locale() of AtkObject.
3572
3573         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
3574         method.
3575
3576         No new functionality, no new tests.
3577
3578         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3579         (AccessibilityUIElement::language): Leverage locale resolution to
3580         AtkObject::get_object_locale().
3581         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3582         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
3583         AtkObject::get_object_locale().
3584
3585 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
3586
3587         Remove last bits of GYP from build-webkit and update-webkit scripts
3588         https://bugs.webkit.org/show_bug.cgi?id=117557
3589
3590         Reviewed by Ryosuke Niwa.
3591
3592         * Scripts/build-webkit:
3593         * Scripts/update-webkit:
3594
3595 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
3596
3597         Remove forgotten unused Tools/Script/make-gypi script
3598         https://bugs.webkit.org/show_bug.cgi?id=117558
3599
3600         Reviewed by Ryosuke Niwa.
3601
3602         This script isn't used since the GYP removal from WebKit.
3603
3604         * Scripts/make-gypi: Removed.
3605
3606 2013-06-12  Andres Gomez  <agomez@igalia.com>
3607
3608         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
3609         https://bugs.webkit.org/show_bug.cgi?id=117533
3610
3611         Reviewed by Carlos Garcia Campos.
3612
3613         MiniBrowser now starts automatically the download of the documents
3614         that cannot be shown just by WebKit itself on link left clicking.
3615
3616         * MiniBrowser/gtk/BrowserWindow.c:
3617         (webViewDecidePolicy): handled the
3618         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
3619
3620 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
3621
3622         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
3623         https://bugs.webkit.org/show_bug.cgi?id=116723
3624
3625         Reviewed by Carlos Garcia Campos.
3626
3627         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
3628         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
3629         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
3630         not expensive and produces a working archive without problems even on incremental builds.
3631
3632 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
3633
3634         [EFL] Window resize should close the popupmenu
3635         https://bugs.webkit.org/show_bug.cgi?id=117391
3636
3637         Reviewed by Christophe Dumez.
3638         
3639         Added the code to close the popup when main window is resized.
3640
3641         * MiniBrowser/efl/main.c:
3642         (on_window_resize):
3643
3644 2013-06-11  Alex Christensen  <achristensen@apple.com>
3645
3646         Removed old broken code coverage tool.
3647         https://bugs.webkit.org/show_bug.cgi?id=117520
3648
3649         Reviewed by Sam Weinig.
3650
3651         * CodeCoverage: Removed.
3652         * CodeCoverage/README: Removed.
3653         * CodeCoverage/amber.png: Removed.
3654         * CodeCoverage/cov.py: Removed.
3655         * CodeCoverage/emerald.png: Removed.
3656         * CodeCoverage/gcov.css: Removed.
3657         * CodeCoverage/glass.png: Removed.
3658         * CodeCoverage/regenerate-coverage-display: Removed.
3659         * CodeCoverage/ruby.png: Removed.
3660         * CodeCoverage/run-generate-coverage-data: Removed.
3661         * CodeCoverage/snow.png: Removed.
3662
3663 2013-06-11  Timothy Hatcher  <timothy@apple.com>
3664