f45c369281e2f3191cd51d1a8c6960cfe57c628c
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed. Fix the GTK+ build.
4
5         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
6
7 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
8
9         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
10         works properly).
11
12         * Scripts/webkitpy/common/config/committers.py:
13
14 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
15
16         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
17         WebKit scripts expect, so other scripts work properly with wx.
18
19         * waf/build/build_utils.py:
20         * waf/build/settings.py:
21
22 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
23
24         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
25         to build on Mac.
26
27         * waf/build/settings.py:
28         * wx/install-unix-extras:
29
30 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
31
32         [wx] Unreviewed build fixes for recent trunk changes.
33
34         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
35         (LayoutTestController::setTextDirection):
36         * waf/build/settings.py:
37
38 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
39
40         Fix the GTK+ build.
41
42         * GNUmakefile.am: Add some missing newline escape.
43
44 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
45
46         Try to fix the GTK+ bulid.
47
48         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
49         source list.
50
51 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
52
53         Reviewed by Adam Barth.
54
55         nrwt: should skip chromium test expectation overrides on upstream bots
56         https://bugs.webkit.org/show_bug.cgi?id=61888
57
58         * Scripts/webkitpy/layout_tests/port/chromium.py:
59         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
60
61 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
62
63         Reviewed by Ojan Vafai.
64
65         new-run-webkit-tests: minor logging, code cleanup
66         https://bugs.webkit.org/show_bug.cgi?id=62055
67
68         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
69         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
70
71 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
72
73         Try to fix the build failure on the GTK+ 32-bit Release bot.
74
75         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
76
77 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
78
79         Reviewed by Ryosuke Niwa.
80
81         [GTK] Support smart replace for the pasteboard
82         https://bugs.webkit.org/show_bug.cgi?id=61734
83
84         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
85         This is required to produce consistent test results.
86
87         * DumpRenderTree/gtk/DumpRenderTree.cpp:
88         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
89         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
90         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
91         methods which calls into DumpRenderTreeSupportGtk.
92
93 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
94
95         Reviewed by Dimitri Glazkov.
96
97         Teach Gtk build about window.internals
98         https://bugs.webkit.org/show_bug.cgi?id=61071
99
100         * DumpRenderTree/gtk/DumpRenderTree.cpp:
101         (webViewWindowObjectCleared): Inject the new internals object when the
102         window object clears.
103         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
104         Also do a little bit of cleanup.
105
106 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
107
108         Reviewed by Tony Chang.
109
110         Worker may not be stopped after LT.
111         https://bugs.webkit.org/show_bug.cgi?id=61847
112
113         Re-submit a variant of the first fix for this bug. It's possible
114         that actually calling cleanup() in the worker threads was taking
115         too long and we triggered the assertions in the manager thread.
116
117         I've bumped up the timeout in the manager and added better
118         diagnostics. I also cleaned up the cleanup() code a bit because
119         there was some unnecessary if-checks.
120
121         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
122         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
123
124 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
125
126         Reviewed by Tony Chang.
127
128         nrwt: fix duplicate logging regression
129         https://bugs.webkit.org/show_bug.cgi?id=61981
130
131         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
132
133 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
134
135         Reviewed by Adam Barth.
136
137         Modified addTouchPoint to correctly re-use touchPoint id values starting
138         from the lowest not-un-use touchPoint id as is done by the embedder
139         APIs. (Fixes BUGCR36415)
140
141         https://bugs.webkit.org/show_bug.cgi?id=62016
142
143         * DumpRenderTree/chromium/EventSender.cpp:
144         (EventSender::addTouchPoint):
145
146 2011-06-03  Cary Clark  <caryclark@google.com>
147
148         Reviewed by Eric Seidel.
149
150         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
151         https://bugs.webkit.org/show_bug.cgi?id=61534
152
153         Skia on Mac uses Skia to render WebKit, and CG
154         to render UI elements. The CG elements need a
155         transcribed graphics context that preserves the
156         canvas matrix, and the canvas clip.
157
158         The SkiaBitLocker utility class sets up a CGContext
159         from the SkCanvas, locks the bitmap's bits, and
160         releases the lock when the class goes out of scope.
161
162         The SkiaBitLocker implementation is described by
163         this patch:
164         http://codereview.chromium.org/7031006/
165
166         When WebKit uses Skia for rendering, the WebCanvas
167         is an SkCanvas. Create an equivalent CGContext to
168         draw the scrollbar thumb.
169
170         As the Chrome Mac port does not yet use Skia, this
171         patch has no effect and requires no tests.
172
173         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
174         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
175
176 2011-06-03  Andras Becsi  <abecsi@webkit.org>
177
178         Unreviewed build fix.
179
180         Fix typo.
181
182         * Scripts/old-run-webkit-tests:
183
184 2011-06-03  Andras Becsi  <abecsi@webkit.org>
185
186         Reviewed by Csaba Osztrogonác.
187
188         Print error message when there is no httpd present on the system
189         https://bugs.webkit.org/show_bug.cgi?id=61939
190
191         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
192         * Scripts/webkitperl/httpd.pm:
193
194 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
195
196         Reviewed by Yury Semikhatsky.
197
198         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
199         https://bugs.webkit.org/show_bug.cgi?id=61533
200
201         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
202
203         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
204         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
205         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
206         * DumpRenderTree/chromium/LayoutTestController.cpp:
207         (LayoutTestController::LayoutTestController):
208         (LayoutTestController::setJavaScriptProfilingEnabled):
209         * DumpRenderTree/chromium/LayoutTestController.h:
210         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
211         (LayoutTestController::setJavaScriptProfilingEnabled):
212         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
213         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
214         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
215
216 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
217
218         Reviewed by Tony Chang.
219
220         NRWT needs a way to log to a file without including backspaces without needing --verbose
221         https://bugs.webkit.org/show_bug.cgi?id=60328
222
223         This change modifies NRWT so that if it can tell if it is
224         writing to a terminal, it will overwrite any messages printed
225         in the 'one-line-progress' and 'updates' print options, and if
226         not (or if --verbose was specified) the messages will be printed
227         without backspaces.
228
229         If the overwriting updates are disabled, one-line-progress will
230         only print every 10 seconds instead of on every update. This
231         ensures that we still get updates once in a while while the
232         tests are running, even if we're not in --verbose mode. Note
233         that one-line-progress will now still be printed in --verbose,
234         since it's useful as long as you're not flooded with the
235         updates.
236
237         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
238         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
239         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
240
241 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
242
243         Reviewed by Gustavo Noronha Silva.
244
245         [GTK] autogen.sh is run twice for each buld on the bots
246         https://bugs.webkit.org/show_bug.cgi?id=61951
247
248         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
249         for the WebKit project. This prevents build-jsc runs from forcing subsequent
250         build-webkit runs to re-rerun autogen.sh.
251
252 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
253
254         Unreviewed, rolling out r87946.
255         http://trac.webkit.org/changeset/87946
256         https://bugs.webkit.org/show_bug.cgi?id=61965
257
258         Cause NRWT to break (Requested by abarth|gardener on #webkit).
259
260         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
261
262 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
263
264         Reviewed by Darin Adler.
265
266         Add build logistics and plumbing for window.internals object.
267         https://bugs.webkit.org/show_bug.cgi?id=60313
268
269         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
270         * DumpRenderTree/chromium/TestShell.cpp:
271         (TestShell::bindJSObjectsToWindow): Added injection code.
272         * DumpRenderTree/mac/FrameLoadDelegate.mm:
273         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
274
275 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
276
277         Reviewed by Dirk Pranke.
278
279         Call cleanup() explicitly at the end of worker.run().
280         https://bugs.webkit.org/show_bug.cgi?id=61847
281
282         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
283
284 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
285
286         Unreviewed, rolling out r87926.
287         http://trac.webkit.org/changeset/87926
288         https://bugs.webkit.org/show_bug.cgi?id=60313
289
290         Fails to find WebCoreTestSupport.dylib on bots.
291
292         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
293         * DumpRenderTree/chromium/TestShell.cpp:
294         (TestShell::bindJSObjectsToWindow):
295         * DumpRenderTree/mac/FrameLoadDelegate.mm:
296         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
297
298 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
299
300         Reviewed by Darin Adler.
301
302         Add build logistics and plumbing for window.internals object.
303         https://bugs.webkit.org/show_bug.cgi?id=60313
304
305         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
306         * DumpRenderTree/chromium/TestShell.cpp:
307         (TestShell::bindJSObjectsToWindow): Added injection code.
308         * DumpRenderTree/mac/FrameLoadDelegate.mm:
309         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
310
311 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
312
313         Reviewed by Eric Seidel.
314
315         Adjust efl coding style to more efl directories
316         https://bugs.webkit.org/show_bug.cgi?id=61903
317
318         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
319
320 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
321
322         Reviewed by Tony Chang.
323
324         old-run-webkit-tests: add support for audio files
325         https://bugs.webkit.org/show_bug.cgi?id=57992
326
327         * Scripts/old-run-webkit-tests:
328
329 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
330
331         Reviewed by Adam Barth.
332
333         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
334         https://bugs.webkit.org/show_bug.cgi?id=34314
335
336         * DumpRenderTree/DumpRenderTree.gypi:
337         * DumpRenderTree/chromium/LayoutTestController.cpp:
338         (LayoutTestController::LayoutTestController):
339         (LayoutTestController::setImagesAllowed):
340         (LayoutTestController::setStorageAllowed):
341         * DumpRenderTree/chromium/LayoutTestController.h:
342         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
343         (WebPermissions::WebPermissions):
344         (WebPermissions::~WebPermissions):
345         (WebPermissions::allowImages):
346         (WebPermissions::allowStorage):
347         (WebPermissions::setImagesAllowed):
348         (WebPermissions::setStorageAllowed):
349         (WebPermissions::reset):
350         * DumpRenderTree/chromium/WebPermissions.h:
351
352 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
353
354         Reviewed by Tony Chang.
355
356         Test plugin should support event logging on the windows port.
357         https://bugs.webkit.org/show_bug.cgi?id=61721
358
359         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
360         (handleEventWin): Well, handle them.
361
362 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
363
364         Reviewed by Tony Chang.
365
366         [chromium] Use correct file name for dragging out images.
367         https://bugs.webkit.org/show_bug.cgi?id=24887
368
369         * DumpRenderTree/chromium/EventSender.cpp:
370         (EventSender::EventSender):
371         (EventSender::dumpFilenameBeingDragged):
372         * DumpRenderTree/chromium/EventSender.h:
373
374 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
375
376         Reviewed by Tony Chang.
377
378         nrwt: make webaudio work w/o content-length header
379         https://bugs.webkit.org/show_bug.cgi?id=61819
380
381         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
382         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
383         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
384         * Scripts/webkitpy/layout_tests/port/webkit.py:
385
386 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
387
388         Reviewed by Andreas Kling.
389
390         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
391         https://bugs.webkit.org/show_bug.cgi?id=61802
392
393         Add command line parameter and menu item to MiniBrowser application 
394         enabling use of QGLWidget for browser viewport.
395
396         * MiniBrowser/qt/BrowserWindow.cpp:
397         (BrowserWindow::BrowserWindow):
398         (BrowserWindow::toggleGLViewport):
399         * MiniBrowser/qt/BrowserWindow.h:
400         * MiniBrowser/qt/MiniBrowserApplication.cpp:
401         (MiniBrowserApplication::handleUserOptions):
402         * MiniBrowser/qt/MiniBrowserApplication.h:
403         (WindowOptions::WindowOptions):
404
405 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
406
407         Reviewed by Xan Lopez.
408
409         Print out autogen arguments when they differ from the last set, to help
410         with debugging build issues.
411
412         * Scripts/webkitdirs.pm: Print out previous and current build arguments
413         when they differ.
414
415 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
416
417         Reviewed by Martin Robinson.
418
419         [GTK] run-launcher should run MiniBrowser in WebKit2
420         https://bugs.webkit.org/show_bug.cgi?id=61858
421
422         * Scripts/run-launcher: Check whether -2 command line option has
423         been passed and run MiniBrowser instead of GtkLauncher.
424
425 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
426
427         Reviewed by Dirk Pranke.
428
429         Fix exception in verbose printing mode.
430         https://bugs.webkit.org/show_bug.cgi?id=61723
431
432         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
433
434 2011-05-31  Yong Li  <yoli@rim.com>
435
436         Reviewed by Eric Seidel.
437
438         https://bugs.webkit.org/show_bug.cgi?id=54807
439         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
440         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
441         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
442         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
443         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
444         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
445         rule we should have in order to make our code independent from compilers and compiler flags.
446
447         * Scripts/webkitpy/style/checkers/cpp.py:
448
449 2011-05-31  Hironori Bono  <hbono@chromium.org>
450
451         Reviewed by Eric Seidel.
452
453         Add a JavaScript function layoutTestController.setTextDirection().
454         https://bugs.webkit.org/show_bug.cgi?id=50952
455
456         This change adds a new JavaScript function setTextDirection() to the
457         LayoutTestController class of Safari and Chrome to write layout tests
458         that changes the text direction of an editable element.
459
460         * DumpRenderTree/LayoutTestController.cpp:
461         (setTextDirectionCallback):
462         (LayoutTestController::staticFunctions):
463         * DumpRenderTree/LayoutTestController.h:
464         * DumpRenderTree/chromium/LayoutTestController.cpp:
465         (LayoutTestController::LayoutTestController):
466         (LayoutTestController::setTextDirection):
467         * DumpRenderTree/chromium/LayoutTestController.h:
468         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
469         (LayoutTestController::setTextDirection):
470         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
471         (LayoutTestController::setTextDirection):
472         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
473         (LayoutTestController::setTextDirection):
474
475 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
476
477         Reviewed by Simon Hausmann.
478
479         [Qt] User-agent list of Qt test browsers is very outdated
480         https://bugs.webkit.org/show_bug.cgi?id=61531
481
482         The user can edit the user-agent manually, so there's no need to have
483         a super complete and up to date list, but it's nice to have it
484         minimally updated.
485
486         * MiniBrowser/qt/useragentlist.txt:
487         * QtTestBrowser/useragentlist.txt:
488
489 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
490
491         Reviewed by Adam Roben.
492
493         [GTK] [WebKit2] Implement a basic WebKitTestRunner
494         https://bugs.webkit.org/show_bug.cgi?id=57068
495
496         Add an implementation of WebKitTestRunner for GTK+.
497
498         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
499         * Scripts/old-run-webkit-tests: Ditto.
500         * Scripts/run-launcher: Ditto.
501         * Scripts/webkitdirs.pm: Ditto.
502         * WebKitTestRunner/GNUmakefile.am: Added.
503         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
504         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
505         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
506         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
507         * WebKitTestRunner/PlatformWebView.h:
508         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
509         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
510         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
511         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
512         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
513         (main): Added.
514
515 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
516
517         Reviewed by Tony Chang.
518
519         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
520         https://bugs.webkit.org/show_bug.cgi?id=60241
521
522         * Scripts/new-run-webkit-tests:
523
524 2011-05-31  Eric Seidel  <eric@webkit.org>
525
526         Reviewed by David Kilzer.
527
528         webkitpy should create zips with zip -9
529         https://bugs.webkit.org/show_bug.cgi?id=61789
530
531         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
532
533         * Scripts/webkitpy/common/system/workspace.py:
534         * Scripts/webkitpy/common/system/workspace_unittest.py:
535
536 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
537
538         Reviewed by Csaba Osztrogonác.
539
540         [Qt] Implement find feature for QtTestBrowser
541         https://bugs.webkit.org/show_bug.cgi?id=61425
542
543         Buildfix for --minimal and CONFIG+=qt_minimal build.
544
545         * QtTestBrowser/launcherwindow.cpp:
546         (LauncherWindow::LauncherWindow):
547         (LauncherWindow::createChrome):
548         * QtTestBrowser/launcherwindow.h:
549
550 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
551
552         Reviewed by Csaba Osztrogonác.
553
554         [Qt] Implement find feature for QtTestBrowser
555         https://bugs.webkit.org/show_bug.cgi?id=61425
556
557         * QtTestBrowser/launcherwindow.cpp:
558         (LauncherWindow::LauncherWindow):
559         (LauncherWindow::createChrome):
560         (LauncherWindow::showFindBar):
561         (LauncherWindow::find):
562         * QtTestBrowser/launcherwindow.h:
563
564 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
565
566         Reviewed by Martin Robinson.
567
568         [GTK] Implement JavaScript dialogs in MiniBrowser
569         https://bugs.webkit.org/show_bug.cgi?id=61725
570
571         * MiniBrowser/gtk/BrowserWindow.c:
572         (WKStringGetCString): Helper function to get a UTF-8 c string from
573         a WKStringRef.
574         (WKURLGetCString): Helper function to get a UTF-8 c string from a
575         WKURLRef.
576         (browserWindowUpdateURL): Update to use WKURLGetCString.
577         (didReceiveTitleForFrame): Update to use WKStringGetCString.
578         (createMessageDialog): Create a GtkMessageDialog.
579         (runJavaScriptAlert):
580         (runJavaScriptConfirm):
581         (runJavaScriptPrompt):
582         (browserWindowUIClientInit):
583
584 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
585
586         Reviewed by Kent Tamura.
587
588         WebSocket closing handshake
589         https://bugs.webkit.org/show_bug.cgi?id=35721
590
591         * Scripts/webkitpy/thirdparty/__init__.py:
592         Pull in pywebsocket 0.6b1. We need to update pywebsocket
593         to get the right behavior of closing handshake.
594
595 2011-05-29  Daniel Bates  <dbates@rim.com>
596
597         Reviewed by David Kilzer.
598
599         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
600         https://bugs.webkit.org/show_bug.cgi?id=61162
601
602         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
603         that omits a line count. In particular, the chunk range regular expression does
604         not match a chunk range line that omits a line count. GNU diff(1) will omit the
605         line count in the chunk range if the line count is exactly 1. For example, appending
606         a new line to the end of an existing file F that contains exactly one line of text will
607         be represented in a diff with a chunk range line that omits the line count for F.
608
609         * Scripts/VCSUtils.pm:
610           (parseChunkRange): Added.
611         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
612         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
613           - Added unit test "Git: Append new line to the end of an existing file".
614
615 2011-05-28  Adam Barth  <abarth@webkit.org>
616
617         Reviewed by Eric Seidel.
618
619         EWS builds patches that fail to build twice, which seems useless and slows down the bots
620         https://bugs.webkit.org/show_bug.cgi?id=55585
621
622         This patch switches all the early warning system bots over to the new
623         PatchAnalysisTask-based infrastructure.  This patch makes these bots
624         more efficient (in the case where patches fail to build) and paves the
625         way for running tests on these bots!
626
627         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
628         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
629         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
630         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
631         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
632         * Scripts/webkitpy/tool/commands/queues.py:
633
634 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
635
636         Reviewed by Kent Tamura.
637
638         Add bashi as a committer.
639
640         https://bugs.webkit.org/show_bug.cgi?id=61685
641
642         * Scripts/webkitpy/common/config/committers.py:
643
644 2011-05-27  Adam Barth  <abarth@webkit.org>
645
646         Reviewed by Eric Seidel.
647
648         When checking whether the tree is red, the EWS posts a link to the wrong log
649         https://bugs.webkit.org/show_bug.cgi?id=61072
650
651         We need to cache the original script error because that contains the
652         failure log we want to upload.  If we don't cache that script error,
653         self._script_error will get overwritten when we sanity check the clean
654         tree (and it also has test failures).
655
656         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
657             - This testing approach is slightly goofy.  We'd like to use
658               assertRaisesRegexp, but that's not available until Python 2.7.
659         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
660
661 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
662
663         Reviewed by Adam Barth.
664
665         Add layoutTestController.setStorageAllowed() to control whether access
666         to the localStorage API is enabled via the WebPermissionClient
667         https://bugs.webkit.org/show_bug.cgi?id=61581
668
669         * DumpRenderTree/chromium/LayoutTestController.cpp:
670         (LayoutTestController::LayoutTestController):
671         (LayoutTestController::setStorageAllowed):
672         * DumpRenderTree/chromium/LayoutTestController.h:
673         * DumpRenderTree/chromium/TestShell.cpp:
674         (TestShell::TestShell):
675         (TestShell::createNewWindow):
676         * DumpRenderTree/chromium/TestShell.h:
677         * DumpRenderTree/chromium/WebPermissions.h: Added.
678         (WebPermissions::WebPermissions):
679         (WebPermissions::allowStorage):
680         (WebPermissions::setStorageAllowed):
681         (WebPermissions::reset):
682
683 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
684
685         Reviewed by Eric Seidel.
686
687         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
688         https://bugs.webkit.org/show_bug.cgi?id=60326
689
690         This patch removes a lot of the complexity from the
691         metered_stream implementation that was unnecessary since there
692         was only one caller and the logic could be coordinated better.
693
694         There should be no functional changes in this patch, just code
695         getting deleted and cleaned up.
696
697         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
698         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
699         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
700         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
701
702 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
703
704         Reviewed by Eric Seidel.
705
706         NRWT: minor cleanup in printing module
707         https://bugs.webkit.org/show_bug.cgi?id=60329
708
709         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
710
711 2011-05-27  Steve Lacey  <sjl@chromium.org>
712
713         Reviewed by David Levin.
714
715         Add sjl@chromium.org as a committer.
716
717         https://bugs.webkit.org/show_bug.cgi?id=61672
718
719         * Scripts/webkitpy/common/config/committers.py:
720
721 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
722
723         Reviewed by Adam Barth.
724
725         NRWT: remove --print detailed-progress
726         https://bugs.webkit.org/show_bug.cgi?id=60324
727
728         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
729         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
730         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
731         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
732
733 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
734
735         Reviewed by Ojan Vafai.
736
737         NRWT: debug messages from the workers are being logged twice
738         https://bugs.webkit.org/show_bug.cgi?id=60428
739
740         It looks like when the workers are run in separate processes
741         we end up getting two copies of every log message they print.
742         This has to do with the multiprocessing module on UNIX cloning
743         the log configuration in a way I wasn't expecting, and so two
744         log handlers end up getting registered.
745
746         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
747         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
748         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
749         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
750
751 2011-05-27  Adam Roben  <aroben@apple.com>
752
753         Always decode tester names from location.hash
754
755         When navigating directly to a tester-specific URL (e.g.,
756         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
757         with a URL-encoded tester name in the page, and then the encoded name could make its way
758         into Bugzilla bugs. Bad!
759
760         Reviewed by David Kilzer.
761
762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
763         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
764         decodeURIComponent before trying to use it.
765
766 2011-05-27  Adam Roben  <aroben@apple.com>
767
768         Remove testing code that snuck into r87528
769
770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
771         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
772
773 2011-05-27  Adam Roben  <aroben@apple.com>
774
775         Add links to TestFailures to easily file bugs about failing tests
776
777         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
778         links to file bugs for failing tests
779
780         Reviewed by David Kilzer.
781
782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
783         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
784         for a particular build.
785         (Builder.prototype._getFailingTests): Use resultsPageURL.
786
787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
788         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
789         failures.
790         (ViewController.prototype._domForBuildName): Use resultsPageURL.
791         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
792         new bug link. The bug has a title, description, and URL already filled in for you!
793
794 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
795
796         Unreviewed, rolling out r87464.
797         http://trac.webkit.org/changeset/87464
798         https://bugs.webkit.org/show_bug.cgi?id=61643
799
800         client-close/server-close tests are flaky on Chromium Mac and
801         Windows (Requested by aklein on #webkit).
802
803         * Scripts/webkitpy/thirdparty/__init__.py:
804
805 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
806
807         Added Douglas Davidson to contributors list for easier CC'ing.
808
809         * Scripts/webkitpy/common/config/committers.py:
810
811 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
812
813         Reviewed by Adam Barth.
814
815         Fix worldID and destinationDomain argument names
816         https://bugs.webkit.org/show_bug.cgi?id=61571
817
818         As part of working on r87423, I noticed a couple of inconsistencies in
819         argument names:
820         - We would use worldId in .h files but worldID in .cpp files.
821           Standardize on the latter
822         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
823           destinationDomains argument, even though the actual parameter was for
824           a single domain (renamed to be singular).
825
826         * DumpRenderTree/LayoutTestController.h:
827         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
828         (LayoutTestController::evaluateScriptInIsolatedWorld):
829
830 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
831
832         Reviewed by Kent Tamura.
833
834         WebSocket closing handshake
835         https://bugs.webkit.org/show_bug.cgi?id=35721
836
837         * Scripts/webkitpy/thirdparty/__init__.py:
838         Pull in pywebsocket 0.6b1. We need to update pywebsocket
839         to get the right behavior of closing handshake.
840
841 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
842
843         Reviewed by Andreas Kling.
844
845         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
846         https://bugs.webkit.org/show_bug.cgi?id=42676
847
848         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
849
850         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
851         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
852         (WTR::InjectedBundle::beginTesting):
853         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
854         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
855         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
856
857 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
858
859         Reviewed by Andreas Kling.
860
861         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
862         https://bugs.webkit.org/show_bug.cgi?id=61527
863
864         The setMaximumHeight() call is unecessary and breaks the dialog at
865         least on my setup.
866
867         * QtTestBrowser/launcherwindow.cpp:
868         (LauncherWindow::showUserAgentDialog):
869
870 2011-05-02  Robert Hogan  <robert@webkit.org>
871
872         Reviewed by Adam Roben.
873
874         [Qt] Allow popup windows from plugins when initiated by a user gesture
875
876         https://bugs.webkit.org/show_bug.cgi?id=41292
877
878         Support parameters introduced in plugin-initiate-popup-window.html
879
880         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
881         (webkit_test_plugin_new_instance):
882         (webkit_test_plugin_handle_event):
883
884 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
885
886         Reviewed by Adam Barth.
887
888         Support cross-origin XMLHttpRequest in isolated worlds
889         https://bugs.webkit.org/show_bug.cgi?id=59843
890
891         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
892
893         * DumpRenderTree/chromium/LayoutTestController.cpp:
894         (LayoutTestController::LayoutTestController):
895         (LayoutTestController::setIsolatedWorldSecurityOrigin):
896         * DumpRenderTree/chromium/LayoutTestController.h:
897
898 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
899
900         Reviewed by Adam Roben.
901
902         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
903         https://bugs.webkit.org/show_bug.cgi?id=61474
904         <rdar://problem/9468337>
905
906         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
907         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
908
909 2011-05-26  Andreas Kling  <kling@webkit.org>
910
911         Unreviewed, correct address to webkit-committers mailing list.
912
913         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
914
915 2011-05-25  Adam Roben  <aroben@apple.com>
916
917         Don't assume that builds finish in the order they were started
918
919         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
920         build when one slave is taking a long time to finish a build
921
922         Reviewed by Antti Koivisto.
923
924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
925         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
926         newer than the oldest in-progress build are also themselves in progress. Just check whether
927         each build is actually in progress (as signified by its presence in the currentBuilds set).
928
929 2011-05-25  Adam Roben  <aroben@apple.com>
930
931         Correctly detect cases where only a single test failed/crashed/timed out
932
933         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
934         failing test
935
936         Reviewed by Darin Adler.
937
938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
939         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
940         will be singular when only a single test fails/crashes/times out.
941
942         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
943         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
944         failed/crashed/timed out.
945
946 2011-05-26  Tom Hudson  <tomhudson@google.com>
947
948         Reviewed by Tony Chang.
949
950         Add flags to Chromium ImageDiff to write image comparison metrics on
951         stdout.
952         https://bugs.webkit.org/show_bug.cgi?id=60569
953
954         * DumpRenderTree/chromium/ImageDiff.cpp:
955         (Image::createFromStdin): Fix spelling.
956         (maxOf3): New function to do 3-way maximum.
957         (getRedComponent): Extract red component from ABGR packed encoding.
958         (getGreenComponent): Extract green component from ABGR packed encoding.
959         (getBlueComponent): Extract blue component from ABGR packed encoding.
960         (weightedPercentageDifferent): Determine % of pixels different in two
961         images multiplied by intensity difference of each pixel.
962         (printHelp): Document new arguments.
963         (compareImages): Parameterize.
964         (untestedCompareImages): Parameterize.
965         (diffImages): Parameterize; write results on stdout if requested.
966         (main): Parse new arguments.
967
968 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
969
970         Reviewed by Simon Hausmann.
971
972         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
973         https://bugs.webkit.org/show_bug.cgi?id=42697
974
975         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
976
977         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
978         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
979         (WTR::InjectedBundle::beginTesting):
980         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
981         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
982         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
983
984 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
985
986         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
987         https://bugs.webkit.org/show_bug.cgi?id=61428
988         <rdar://problem/9457006>
989
990         Reviewed by Adam Roben.
991
992         The crash occurs when Flash posts a message to a window that it
993         creates, and in processing the message, it calls NPN_Evaluate to
994         evaluate JavaScript that removes the plug-in from the page. Flash then
995         crashes when we return to Flash code.
996
997         This test emulates that behavior.
998
999         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1000         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1001         Initialize member vars.
1002         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1003         Remove our custom property from the message window, and destroy it.
1004         (CallJSThatDestroysPlugin::NPP_Destroy):
1005         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1006         layout test controller that we're done.
1007         (wndProc):
1008         Get the PluginTest object, and call its runTest() function.
1009         (CallJSThatDestroysPlugin::NPP_New):
1010         Setup the test: register a class for the message-only window, create
1011         it, and post a message to it to run the test.
1012         (CallJSThatDestroysPlugin::runTest):
1013         Execute JS that removes the plug-in from the page, and if we're not
1014         destroyed, log a success message.
1015
1016         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1017         Add new test to project.
1018
1019 2011-05-25  Tony Chang  <tony@chromium.org>
1020
1021         Reviewed by Adam Barth.
1022
1023         webkitpy's NetworkTransaction shouldn't use mechanize
1024         https://bugs.webkit.org/show_bug.cgi?id=61450
1025
1026         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1027         use urllib2 directly.  Re-add NetworkTransaction to
1028         test_results_uploader.py (reverting r87124).
1029
1030         * Scripts/webkitpy/common/net/networktransaction.py:
1031         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1032
1033 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1034
1035         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1036         until the port begins using those export macros.
1037
1038         * DumpRenderTree/chromium/config.h:
1039
1040 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1041
1042         Unreviewed, rolling out r87257.
1043         http://trac.webkit.org/changeset/87257
1044         https://bugs.webkit.org/show_bug.cgi?id=61457
1045
1046         This broke layout tests, see bug 61431. (Requested by
1047         hwennborg on #webkit).
1048
1049         * DumpRenderTree/chromium/LayoutTestController.cpp:
1050         (LayoutTestController::LayoutTestController):
1051         (LayoutTestController::clearAllDatabases):
1052         * DumpRenderTree/chromium/LayoutTestController.h:
1053
1054 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1055
1056         Reviewed by Andreas Kling.
1057
1058         [Qt] fast/css/disabled-author-styles.html failed
1059         https://bugs.webkit.org/show_bug.cgi?id=61438
1060
1061         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1062
1063         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1064         (WebCore::WebPage::resetSettings):
1065         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1066         (LayoutTestController::setAuthorAndUserStylesEnabled):
1067         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1068
1069 2011-05-25  Adam Roben  <aroben@apple.com>
1070
1071         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1072
1073         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1074         started exiting early due to too many crashes, timeouts, or failures
1075
1076         Reviewed by David Kilzer.
1077
1078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1079         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1080         run-webkit-tests exits early due to too many failures, pass that information in another
1081         argument to the callback.
1082         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1083         the new structure of the object passed to the callback.
1084         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1085         getNumberOfFailingTests and to pass that along to our own callbacks.
1086         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1087         from _getFailingTests and to store that value in the history object.
1088
1089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1090         (.info): Added.
1091
1092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1093         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1094         object and to add a note when run-webkit-tests exited early due to too many failures.
1095         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1096         latestBuildInfos since each entry now contains more than just the tester and failure count.
1097         Now displays a message for testers where the latest build exited early due to too many
1098         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1099         store that value in latestBuildInfos.
1100
1101 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1102
1103         Reviewed by Kent Tamura.
1104
1105         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1106         https://bugs.webkit.org/show_bug.cgi?id=61273
1107
1108         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1109
1110 2011-05-24  Greg Simon  <gregsimon@chromium.org>
1111
1112         Reviewed by Dimitri Glazkov.
1113
1114         Control Indexeddb backends from LayoutTestController
1115         https://bugs.webkit.org/show_bug.cgi?id=61000
1116
1117         * DumpRenderTree/chromium/LayoutTestController.cpp:
1118         (LayoutTestController::LayoutTestController):
1119         (LayoutTestController::setOverrideIndexedDBBackingStore):
1120         (LayoutTestController::clearAllDatabases):
1121         * DumpRenderTree/chromium/LayoutTestController.h:
1122
1123 2011-05-24  Robert Hogan  <robert@webkit.org>
1124
1125         Reviewed by Ryosuke Niwa.
1126
1127         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
1128         https://bugs.webkit.org/show_bug.cgi?id=61393
1129
1130         * DumpRenderTree/qt/EventSenderQt.h:
1131         * DumpRenderTree/qt/EventSenderQt.cpp:
1132         (getModifiers): static function for interpreting modifiers
1133         (EventSender::mouseDown): Respect keyboard modifiers
1134         (EventSender::keyDown): use new static function
1135         (EventSender::sendOrQueueEvent): whitespace fix
1136
1137 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
1138
1139         Reviewed by Adam Barth.
1140
1141         Adding MHTML reading support.
1142         https://bugs.webkit.org/show_bug.cgi?id=7168
1143
1144         * Scripts/build-webkit:
1145         * Scripts/old-run-webkit-tests:
1146         * Scripts/webkitperl/features.pm:
1147         * Scripts/webkitpy/layout_tests/port/test_files.py:
1148         * Scripts/webkitpy/layout_tests/port/webkit.py:
1149
1150 2011-05-24  Stephen White  <senorblanco@chromium.org>
1151
1152         Reviewed by Kenneth Russell.
1153
1154         Remove most style checks on Source/ThirdParty/glu, since it doesn't
1155         follow WebKit style.
1156         https://bugs.webkit.org/show_bug.cgi?id=61365
1157
1158         * Scripts/webkitpy/style/checker.py:
1159
1160 2011-05-24  Adam Roben  <aroben@apple.com>
1161
1162         Don't allow forcing builds through the build.webkit.org web interface
1163
1164         Someone has been forcing bogus builds.
1165
1166         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1167
1168 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
1169
1170         Reviewed by Adam Roben.
1171
1172         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1173         https://bugs.webkit.org/show_bug.cgi?id=42669
1174
1175         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
1176         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
1177         Because that case changed the setting.
1178
1179         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1180         (WTR::InjectedBundle::beginTesting):
1181
1182 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1183
1184         Reviewed by Kenneth Rohde Christiansen.
1185
1186         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
1187         https://bugs.webkit.org/show_bug.cgi?id=61052
1188
1189         * Scripts/old-run-webkit-tests:
1190
1191 2011-05-24  Adam Roben  <aroben@apple.com>
1192
1193         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
1194
1195         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
1196         that don't have any failing tests, which isn't useful
1197
1198         Reviewed by David Kilzer.
1199
1200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
1201         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
1202         instead of name strings.
1203         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
1204         builder names into an array of builders.
1205
1206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1207         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
1208         the most recently completed build, or -1 if there is no such build.
1209         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
1210         in the given build, or -1 if the number could not be determined. Some of this code came from
1211         _getFailingTests.
1212         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
1213         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
1214         getNumberOfFailingTests functions.
1215
1216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1217         (ViewController.prototype._displayTesters): Get the current number of test failures for each
1218         tester and show it in the list. Omit testers that have no failures at all. We keep the
1219         testers and failure counts in an array and sort it before displaying the current data, as
1220         the order in which data will be fetched is unpredictable.
1221
1222 2011-05-23  Tony Chang  <tony@chromium.org>
1223
1224         Reviewed by Ojan Vafai.
1225
1226         [nrwt] don't use NetworkTranslation when uploading results
1227         https://bugs.webkit.org/show_bug.cgi?id=61315
1228
1229         This avoids autoinstalling mechanize.  It didn't matter anyway
1230         because test_results_uploader.py wasn't using mechanize to make the
1231         request so NetworkTransaction::run wasn't doing anything extra
1232         (it only matters if it catches mechanize.HTTPError).
1233
1234         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1235
1236 2011-05-23  Tony Chang  <tony@chromium.org>
1237
1238         Reviewed by Dirk Pranke.
1239
1240         [chromium] fix the rebaseline tool to work with Linux GPU failures
1241         https://bugs.webkit.org/show_bug.cgi?id=61312
1242
1243         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1244
1245 2011-05-23  Darin Adler  <darin@apple.com>
1246
1247         Ignore generated .pyc files in a directory full of python code.
1248
1249         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
1250
1251 2011-05-23  Adam Barth  <abarth@webkit.org>
1252
1253         Reviewed by Eric Seidel.
1254
1255         sheriffbot should give more details about the failures in IRC
1256         https://bugs.webkit.org/show_bug.cgi?id=61233
1257
1258         With this patch, sheriffbot will annonce the set of failing tests,
1259         which might help folks triage the problem.
1260
1261         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1262         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1263
1264 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1265
1266         Unreviewed, rolling out r87078.
1267         http://trac.webkit.org/changeset/87078
1268         https://bugs.webkit.org/show_bug.cgi?id=61294
1269
1270         Patch contains errors and seems likely to break a bunch of
1271         bots (Requested by abarth on #webkit).
1272
1273         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1274         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1275         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1276
1277 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
1278
1279         Reviewed by Ojan Vafai.
1280
1281         Convert json_results_generator.py to output version 4 JSON.
1282         https://bugs.webkit.org/show_bug.cgi?id=60869
1283
1284         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1285         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1286         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1287
1288 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
1289
1290         Reviewed by Adam Barth.
1291
1292         Move generation of shell_command from port to executive
1293         https://bugs.webkit.org/show_bug.cgi?id=61251
1294
1295         After move it's possible to use the code in other places too.
1296
1297         * Scripts/webkitpy/common/config/ports.py:
1298         * Scripts/webkitpy/common/system/executive.py:
1299
1300 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
1301
1302         Reviewed by Darin Adler.
1303
1304         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1305         https://bugs.webkit.org/show_bug.cgi?id=42669
1306
1307         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
1308
1309         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1310         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1311         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
1312         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1313
1314 2011-05-22  Robert Hogan  <robert@webkit.org>
1315
1316         Reviewed by Kenneth Rohde Christiansen.
1317
1318         Fix policyDelegate in Qt DRT
1319         https://bugs.webkit.org/show_bug.cgi?id=61247
1320
1321         Use the 'policy delegate' implemented in FrameLoaderClient
1322         for layout tests. The partial implementation in DumpRenderTreeQt
1323         is redundant, so remove it.
1324
1325         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1326         (WebCore::WebPage::acceptNavigationRequest):
1327         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1328         (LayoutTestController::waitForPolicyDelegate):
1329
1330 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
1331
1332         Reviewed by Darin Adler.
1333
1334         Use double quotes for filename arguments
1335         https://bugs.webkit.org/show_bug.cgi?id=61250
1336
1337         Windows does not support single quotes on the command line,
1338         so replace them with double quotes.
1339
1340         * Scripts/prepare-ChangeLog:
1341
1342 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
1343
1344         Reviewed by Sam Weinig.
1345
1346         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
1347         https://bugs.webkit.org/show_bug.cgi?id=42550
1348         
1349         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
1350
1351         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1352         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1353         Copy the code for pausing animations, FIXME comments and all.
1354         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1355         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1356
1357 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
1358
1359         Reviewed by Stephen White.
1360
1361         Adding myself to the committers list.
1362
1363         * Scripts/webkitpy/common/config/committers.py:
1364
1365 2011-05-19  Adam Roben  <aroben@apple.com>
1366
1367         Test that the WebKit2 UI process doesn't crash when starting a download
1368
1369         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
1370         (preceded by assertion) in fastMalloc when downloading a file
1371
1372         Reviewed by Darin Adler.
1373
1374         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
1375
1376         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
1377         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
1378         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
1379         started, cancel the download, and return a bogus string.
1380
1381         (TestWebKitAPI::setContextDownloadClient):
1382         (TestWebKitAPI::setPagePolicyClient):
1383         Simple helper functions.
1384
1385         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
1386         our policy client, and run until we know that the download was started. If we haven't
1387         crashed, we win!
1388
1389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1390         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1391         * TestWebKitAPI/win/copy-resources.cmd:
1392         Added new files.
1393
1394 2011-05-20  Kent Tamura  <tkent@chromium.org>
1395
1396         Reviewed by Ryosuke Niwa.
1397
1398         Fix style errors in DumpRenderTree/chromium/.
1399         https://bugs.webkit.org/show_bug.cgi?id=61172
1400
1401         * DumpRenderTree/chromium/CppBoundClass.cpp:
1402         (CppBoundClass::getAsCppVariant):
1403         (CppBoundClass::bindToJavascript):
1404         * DumpRenderTree/chromium/CppBoundClass.h:
1405         (CppBoundClass::GetterCallback::~GetterCallback):
1406         (CppBoundClass::CppBoundClass):
1407         (CppBoundClass::Callback::~Callback):
1408         (CppBoundClass::MemberCallback::MemberCallback):
1409         (CppBoundClass::MemberCallback::~MemberCallback):
1410         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
1411         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
1412         * DumpRenderTree/chromium/CppVariant.h:
1413         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1414         (DRTDevToolsAgent::~DRTDevToolsAgent):
1415         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1416         (DRTDevToolsClient::sendFrontendLoaded):
1417         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1418         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1419         (main):
1420         * DumpRenderTree/chromium/EventSender.cpp:
1421         (SavedEvent::SavedEvent):
1422         (EventSender::EventSender):
1423         (EventSender::keyDown):
1424         * DumpRenderTree/chromium/EventSender.h:
1425         * DumpRenderTree/chromium/ImageDiff.cpp:
1426         (Image::Image):
1427         * DumpRenderTree/chromium/LayoutTestController.cpp:
1428         (LayoutTestController::LayoutTestController):
1429         (LayoutTestController::WorkQueue::reset):
1430         (WorkItemBackForward::WorkItemBackForward):
1431         (WorkItemLoadingScript::WorkItemLoadingScript):
1432         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1433         (WorkItemLoad::WorkItemLoad):
1434         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1435         (LayoutTestController::pathToLocalResource):
1436         * DumpRenderTree/chromium/LayoutTestController.h:
1437         (LayoutTestController::WorkItem::~WorkItem):
1438         (LayoutTestController::WorkQueue::WorkQueue):
1439         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1440         (MockSpellCheck::MockSpellCheck):
1441         (MockSpellCheck::~MockSpellCheck):
1442         * DumpRenderTree/chromium/MockSpellCheck.h:
1443         * DumpRenderTree/chromium/NotificationPresenter.h:
1444         (NotificationPresenter::NotificationPresenter):
1445         * DumpRenderTree/chromium/Task.cpp:
1446         (WebTask::WebTask):
1447         * DumpRenderTree/chromium/Task.h:
1448         (TaskList::TaskList):
1449         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1450         (DRTPrinter::DRTPrinter):
1451         (TestShellPrinter::TestShellPrinter):
1452         * DumpRenderTree/chromium/TestNavigationController.cpp:
1453         (TestNavigationEntry::TestNavigationEntry):
1454         (TestNavigationEntry::~TestNavigationEntry):
1455         (TestNavigationController::TestNavigationController):
1456         (TestNavigationController::reload):
1457         (TestNavigationController::loadEntry):
1458         (TestNavigationController::didNavigateToEntry):
1459         * DumpRenderTree/chromium/TestNavigationController.h:
1460         (TestShellExtraData::TestShellExtraData):
1461         * DumpRenderTree/chromium/TestShell.cpp:
1462         (dumpHistoryItem):
1463         * DumpRenderTree/chromium/TestShell.h:
1464         (TestParams::TestParams):
1465         * DumpRenderTree/chromium/TestShellWin.cpp:
1466         (TestShell::waitTestFinished):
1467         * DumpRenderTree/chromium/TestWebWorker.h:
1468         (TestWebWorker::startWorkerContext):
1469         (TestWebWorker::terminateWorkerContext):
1470         (TestWebWorker::postMessageToWorkerContext):
1471         (TestWebWorker::clientDestroyed):
1472         (TestWebWorker::postMessageToWorkerObject):
1473         (TestWebWorker::postExceptionToWorkerObject):
1474         (TestWebWorker::postConsoleMessageToWorkerObject):
1475         (TestWebWorker::confirmMessageFromWorkerObject):
1476         (TestWebWorker::reportPendingActivity):
1477         (TestWebWorker::workerContextClosed):
1478         (TestWebWorker::~TestWebWorker):
1479         * DumpRenderTree/chromium/TextInputController.cpp:
1480         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1481         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1482         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1483         (WebThemeEngineDRTWin::paintButton):
1484         (WebThemeEngineDRTWin::paintMenuList):
1485         (WebThemeEngineDRTWin::paintTrackbar):
1486         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1487         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1488         * DumpRenderTree/chromium/WebViewHost.cpp:
1489         (WebViewHost::navigate):
1490         (WebViewHost::updateSessionHistory):
1491         (WebViewHost::paintInvalidatedRegion):
1492         * DumpRenderTree/chromium/WebViewHost.h:
1493
1494 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1495
1496         Reviewed by Adam Roben.
1497
1498         Detect hangs in run-api-tests
1499         https://bugs.webkit.org/show_bug.cgi?id=48043
1500
1501         * Scripts/run-api-tests: Added test timeouts
1502
1503 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1504
1505         Reviewed by Adam Roben.
1506
1507         run-api-tests should run one test per process
1508         https://bugs.webkit.org/show_bug.cgi?id=61088
1509
1510         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
1511         return code, and parsing GTest output format.
1512
1513 2011-05-15  Robert Hogan  <robert@webkit.org>
1514
1515         Reviewed by Antonio Gomes.
1516
1517         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
1518         https://bugs.webkit.org/show_bug.cgi?id=60834
1519         Fix unix test plugin for plugins/get-url-with-javascript-url.html
1520
1521         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1522         (webkit_test_plugin_new_stream):
1523         (webkit_test_plugin_write_ready):
1524         (webkit_test_plugin_write):
1525
1526 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1527
1528         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
1529         http://trac.webkit.org/changeset/86869
1530         http://trac.webkit.org/changeset/86873
1531         http://trac.webkit.org/changeset/86875
1532         http://trac.webkit.org/changeset/86877
1533         https://bugs.webkit.org/show_bug.cgi?id=61139
1534
1535         broke builds and debug DRT (Requested by rniwa on #webkit).
1536
1537         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1538         * DumpRenderTree/chromium/TestShell.cpp:
1539         (TestShell::bindJSObjectsToWindow):
1540         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1541         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1542
1543 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
1544
1545         Reviewed by Darin Adler.
1546
1547         Add build logistics and plumbing for window.internals object.
1548         https://bugs.webkit.org/show_bug.cgi?id=60313
1549
1550         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1551         * DumpRenderTree/chromium/TestShell.cpp:
1552         (TestShell::bindJSObjectsToWindow): Added injection code.
1553         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1554         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1555
1556 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1557
1558         Reviewed by Csaba Osztrogonác.
1559
1560         [Qt] Implement eventSender.scalePageBy
1561         https://bugs.webkit.org/show_bug.cgi?id=60015
1562
1563         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1564         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1565         * DumpRenderTree/qt/EventSenderQt.cpp:
1566         (EventSender::scalePageBy):
1567         * DumpRenderTree/qt/EventSenderQt.h:
1568
1569 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
1570
1571         Reviewed by Kent Tamura.
1572
1573         [Chromium] IME candidate window appears wrong position in an iframe
1574         https://bugs.webkit.org/show_bug.cgi?id=61023
1575
1576         Call the focused frame's firstRectForCharacterRange() instead of the
1577         main frame so that DRT behaves as the same as Chromium.
1578
1579         * DumpRenderTree/chromium/TextInputController.cpp:
1580         (TextInputController::firstRectForCharacterRange):
1581
1582 2011-05-18  Adam Roben  <aroben@apple.com>
1583
1584         Add a new page to build.webkit.org to help find when tests started failing
1585
1586         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
1587         right now, but already shows some useful information. It's somewhat similar to webkit-patch
1588         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
1589         little more convenient than either of them, though, because it's all done in the browser
1590         (and thus it's easy to go directly to the relevant test results).
1591
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
1593         (Buildbot): This class represents a Buildbot server.
1594         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
1595         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
1596         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
1597         callback.
1598         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
1599         be implemented by a derived class that understands this server's build naming scheme.
1600         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1601         particular build.
1602
1603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
1604         (Builder): This class represents one builder on the buildbot.
1605         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
1606         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
1607         information about a particular test failure.
1608         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
1609         information about when tests started failing.
1610         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1611         particular build.
1612         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
1613         callback.
1614         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
1615         extracts all the failing tests listed in it, passing them to the callback.
1616         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
1617         build, merges them into the build history, and calls the callback telling it whether the
1618         next build should be fetched to provide more information.
1619
1620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1621         Added. Just some simple styles.
1622
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
1624         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
1625         (getResource): Wrapper around XMLHttpRequest.
1626         (Array.prototype.findFirst): Finds the first element matching the given predicate and
1627         returns it.
1628         (Array.prototype.last): Returns the last element of the array.
1629
1630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
1631         (ViewController): This class contains the main logic for displaying the page.
1632         (ViewController.loaded): Just calls through to parseHash.
1633         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
1634         shows the list of all testers so one can be chosen. This function is called when the page
1635         loads and whenever we get a hashchange event.
1636         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
1637         as it is fetched. The display ends up grouping tests by when they started failing.
1638         (ViewController._displayTesters): Gets the list of testers and displays it.
1639
1640         (ViewController._domForBuildName):
1641         (ViewController._domForFailedTest):
1642         Helper functions to create descriptions and links for a particular build or failed test.
1643
1644         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
1645         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
1646         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
1647
1648         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
1649         loads all the files and sets up a ViewController, which does the rest.
1650
1651         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
1652         page.
1653
1654 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1655
1656         Reviewed by Csaba Osztrogonác.
1657
1658         [Qt] Implement layoutTestController.setValueForUser()
1659         https://bugs.webkit.org/show_bug.cgi?id=60956
1660
1661         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1662         (LayoutTestController::setValueForUser):
1663         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1664
1665 2011-05-16  Robert Hogan  <robert@webkit.org>
1666
1667         Reviewed by Kenneth Rohde Christiansen.
1668
1669         plugins/invalidate_rect.html fails on linux ports
1670
1671         - Make the unix test netscape plugin recognize the onPaintEvent
1672           and windowedPlugin parameters.
1673
1674         https://bugs.webkit.org/show_bug.cgi?id=54051
1675
1676         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1677         (handleEventX11):
1678         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1679         (LayoutTestController::displayInvalidatedRegion):
1680         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1681         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1682         (webkit_test_plugin_new_instance):
1683         (webkit_test_plugin_handle_event):
1684
1685 2011-05-17  Tony Chang  <tony@chromium.org>
1686
1687         Reviewed by Ojan Vafai.
1688
1689         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
1690         https://bugs.webkit.org/show_bug.cgi?id=60895
1691
1692         Update the tools to handle the move.  Lucid 32 results now go in
1693         chromium-linux-x86 and the default platform on Linux is now x86_64.
1694
1695         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
1696         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1697         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
1698         * Scripts/webkitpy/layout_tests/port/base.py: ditto
1699         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
1700         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1701         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
1702         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
1703         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
1704
1705 2011-05-17  Adam Roben  <aroben@apple.com>
1706
1707         Make run-api-tests work on Windows when there are spaces in the path
1708
1709         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
1710         spaces in the path to TestWebKitAPI.exe
1711
1712         Reviewed by David Levin.
1713
1714         * Scripts/run-api-tests:
1715         (runTestTool): Use the "direct object" form of system() to avoid having the path to
1716         TestWebKitAPI.exe be split by the shell.
1717
1718 2011-05-16  Ian Henderson  <ianh@apple.com>
1719
1720         Reviewed by Joseph Pecoraro.
1721
1722         Page::goToItem doesn't work while loading is deferred
1723         https://bugs.webkit.org/show_bug.cgi?id=60412
1724
1725         Add setDefersLoading and goBack methods to LayoutTestController.  We
1726         need to use goBack() instead of history.back() because the latter goes
1727         through NavigationScheduler, hence doesn't exhibit the bug.
1728
1729         * DumpRenderTree/LayoutTestController.cpp:
1730         (goBackCallback):
1731         (setDefersLoadingCallback):
1732         (LayoutTestController::staticFunctions):
1733         * DumpRenderTree/LayoutTestController.h:
1734         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1735         (LayoutTestController::goBack):
1736         (LayoutTestController::setDefersLoading):
1737         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1738         (LayoutTestController::goBack):
1739         (LayoutTestController::setDefersLoading):
1740         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1741         (LayoutTestController::goBack):
1742         (LayoutTestController::setDefersLoading):
1743         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1744         (LayoutTestController::goBack):
1745         (LayoutTestController::setDefersLoading):
1746
1747 2011-05-16  Sam Weinig  <sam@webkit.org>
1748
1749         Reviewed by Anders Carlsson.
1750
1751         TestWebKitAPI should build with clang if it can
1752         https://bugs.webkit.org/show_bug.cgi?id=60918
1753
1754         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1755         Update CompilerVersion.xcconfig to match others.
1756
1757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1758         Add CompilerVersion.xcconfig to the project.
1759
1760         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1761         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1762         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1763         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1764         Add some casts to quiet warnings from clang.
1765
1766 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
1767
1768         Reviewed by David Levin.
1769
1770         add dpranke as a reviewer
1771         https://bugs.webkit.org/show_bug.cgi?id=60919
1772
1773         * Scripts/webkitpy/common/config/committers.py:
1774
1775 2011-05-16  Robert Hogan  <robert@webkit.org>
1776
1777         Reviewed by Anders Carlsson.
1778
1779         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
1780
1781         https://bugs.webkit.org/show_bug.cgi?id=60838
1782
1783         The unix test plugin needs to call the test's NPP_URLNotify
1784         rather than the browsers.
1785
1786         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1787         (webkit_test_plugin_url_notify):
1788
1789 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
1790
1791         Rubber-stamped by Adam Roben.
1792
1793         Adding myself as a reviewer.
1794         * Scripts/webkitpy/common/config/committers.py:
1795
1796 2011-05-16  Sam Weinig  <sam@webkit.org>
1797
1798         Fix typo pointed out by Dave Levin.
1799
1800         * TestWebKitAPI/PlatformUtilities.h:
1801         (TestWebKitAPI::Util::assertWKStringEqual):
1802         Strig -> String.
1803
1804 2011-05-16  Sam Weinig  <sam@webkit.org>
1805
1806         Reviewed by David Levin.
1807
1808         Convert api tester over to using gtest expectations directly
1809         https://bugs.webkit.org/show_bug.cgi?id=60862
1810
1811         * TestWebKitAPI/PlatformUtilities.cpp:
1812         (TestWebKitAPI::Util::toSTD):
1813         * TestWebKitAPI/PlatformUtilities.h:
1814         (TestWebKitAPI::Util::assertWKStrigEqual):
1815         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
1816         the implementation of the macro simpler.
1817
1818         * TestWebKitAPI/Test.h:
1819         Remove TEST_ASSERT forwarder.
1820
1821         [Test changes elided]
1822
1823 2011-05-16  David Kilzer  <ddkilzer@apple.com>
1824
1825         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
1826         <rdar://problem/9446430>
1827
1828         Reviewed by Mark Rowe.
1829
1830         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
1831         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1832         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1833
1834 2011-05-16  Jon Lee  <jonlee@apple.com>
1835
1836         Reviewed by Simon Fraser.
1837
1838         Can't horizontally scroll iframes and overflow because wheel events are always accepted
1839         https://bugs.webkit.org/show_bug.cgi?id=60779
1840
1841         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1842         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
1843
1844 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1845
1846         Reviewed by Csaba Osztrogonác.
1847
1848         [Qt] Tools.pro misses include(common.pri)
1849         https://bugs.webkit.org/show_bug.cgi?id=60883
1850
1851         It includes features.pri, which depends on common.pri (the build is
1852         not broken today with the default options, but this is the right
1853         thing to do).
1854
1855         * Tools.pro:
1856
1857 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
1858
1859         Unreviewed: adding myself to committers.py.
1860
1861         * Scripts/webkitpy/common/config/committers.py:
1862
1863 2011-05-15  Daniel Bates  <dbates@webkit.org>
1864
1865         Reviewed by Chris Jerdonek.
1866
1867         svn-apply can't handle Git diff that only changes executable bit
1868         https://bugs.webkit.org/show_bug.cgi?id=60848
1869
1870         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
1871         that only has an executable bit change.
1872
1873         * Scripts/VCSUtils.pm:
1874           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
1875         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
1876         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
1877         * Scripts/svn-apply:
1878         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
1879         * Scripts/svn-unapply:
1880         (patch): Ditto.
1881         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1882           - Updated expected results for test cases to account for numTextChunks.
1883           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
1884           - Added test case "Git: file that only has an executable bit change".
1885         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1886           - Updated expected results for test cases to account for numTextChunks.
1887
1888 2011-05-15  Sam Weinig  <sam@webkit.org>
1889
1890         Fix windows build.
1891
1892         * TestWebKitAPI/win/main.cpp:
1893         (main):
1894
1895 2011-05-15  Sam Weinig  <sam@webkit.org>
1896
1897         Reviewed by David Levin.
1898
1899         Make API tester more gtest friendly
1900         https://bugs.webkit.org/show_bug.cgi?id=60859
1901
1902         * Scripts/run-api-tests:
1903         Numerous changes:
1904         - Remove logic to run tests one at a time.
1905         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
1906           the test runner and allow gtest to print it for us.
1907         - Forward stdout from the test tool to stdout, even in non-verbose runs.
1908         - Run test tool from the current working directory instead of the root webkit
1909           directory.
1910
1911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1912         Move plist to be with other bundle sources.
1913
1914         * TestWebKitAPI/TestsController.cpp:
1915         (TestWebKitAPI::TestsController::TestsController):
1916         (TestWebKitAPI::TestsController::run):
1917         * TestWebKitAPI/TestsController.h:
1918         * TestWebKitAPI/mac/main.mm:
1919         Simplify TestController down to a single run function. We should consider removing the class
1920         entirely at some point.
1921
1922 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1923
1924         Unreviewed, rolling out r86504.
1925         http://trac.webkit.org/changeset/86504
1926         https://bugs.webkit.org/show_bug.cgi?id=60853
1927
1928         "Broke Qt EventSender in editing/selection tests" (Requested
1929         by mwenge on #webkit).
1930
1931         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1932         (WebCore::WebPage::WebPage):
1933         (WebCore::DumpRenderTree::DumpRenderTree):
1934         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1935         (WebCore::DumpRenderTree::initJSObjects):
1936         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1937         (WebCore::DumpRenderTree::eventSender):
1938         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1939         (webkit_test_plugin_new_instance):
1940         (webkit_test_plugin_set_window):
1941         (webkit_test_plugin_handle_event):
1942
1943 2011-05-12  Robert Hogan  <robert@webkit.org>
1944
1945         Reviewed by Benjamin Poulain.
1946
1947         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1948
1949         The support for this test added to the unix test plugin here
1950         may allow other platforms to pass it (nearly everyone
1951         skips it). On Qt it required a bit of trickiness with
1952         the page's EventSender object to get it working fully though,
1953         so only unskipping Qt here.
1954
1955         https://bugs.webkit.org/show_bug.cgi?id=60722
1956
1957         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1958         (WebCore::WebPage::WebPage):
1959         (WebCore::WebPage::eventSender):
1960         (WebCore::DumpRenderTree::DumpRenderTree):
1961         (WebCore::DumpRenderTree::initJSObjects):
1962         (WebCore::DumpRenderTree::createWindow):
1963         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1964         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1965         (webkit_test_plugin_new_instance):
1966         (webkit_test_plugin_set_window):
1967         (webkit_test_plugin_handle_event):
1968
1969 2011-05-14  Arno Renevier  <arno@renevier.net>
1970
1971         Reviewed by Martin Robinson.
1972
1973         make run-gtk-tests executable
1974         https://bugs.webkit.org/show_bug.cgi?id=59278
1975
1976         * Scripts/run-gtk-tests:
1977
1978 2011-05-14  Anders Carlsson  <andersca@apple.com>
1979
1980         Reviewed by Kevin Decker.
1981
1982         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1983         https://bugs.webkit.org/show_bug.cgi?id=60823
1984         <rdar://problem/9430386>
1985
1986         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1987
1988         * DumpRenderTree/DumpRenderTree.gypi:
1989         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1990         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
1991         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
1992         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
1993         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
1994         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1995         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1996         * GNUmakefile.am:
1997
1998 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1999
2000         Unreviewed, rolling out r86476.
2001         http://trac.webkit.org/changeset/86476
2002         https://bugs.webkit.org/show_bug.cgi?id=60832
2003
2004         It made plugins/get-url-notify-with-url-that-fails-to-
2005         load.html crash on GTK (Requested by Ossy on #webkit).
2006
2007         * DumpRenderTree/DumpRenderTree.gypi:
2008         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2009         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2010         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2011         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2012         * GNUmakefile.am:
2013
2014 2011-05-13  Anders Carlsson  <andersca@apple.com>
2015
2016         Reviewed by Sam Weinig.
2017
2018         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2019         https://bugs.webkit.org/show_bug.cgi?id=60823
2020         <rdar://problem/9430386>
2021
2022         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2023
2024         * DumpRenderTree/DumpRenderTree.gypi:
2025         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2026         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2027         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2028         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2029         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2030         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2031         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2032         * GNUmakefile.am:
2033
2034 2011-05-13  Anders Carlsson  <andersca@apple.com>
2035
2036         Build fix.
2037
2038         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2039
2040 2011-05-13  Anders Carlsson  <andersca@apple.com>
2041
2042         Reviewed by Sam Weinig.
2043
2044         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2045         https://bugs.webkit.org/show_bug.cgi?id=60810
2046
2047         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2048
2049         * DumpRenderTree/DumpRenderTree.gypi:
2050         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2051         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2052         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2053         * GNUmakefile.am:
2054         Add files.
2055
2056         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2057         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2058         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2059
2060         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2061         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2062         (GetURLWithJavaScriptURL::NPP_New):
2063         (GetURLWithJavaScriptURL::NPP_NewStream):
2064         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2065         (GetURLWithJavaScriptURL::NPP_WriteReady):
2066         (GetURLWithJavaScriptURL::NPP_Write):
2067         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2068         (NPP_NewStream):
2069         (NPP_WriteReady):
2070         (NPP_Write):
2071         (NPP_URLNotify):
2072         call the PluginTest NPP wrappers.
2073
2074 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2075
2076         Unreviewed, rolling out r86447.
2077         http://trac.webkit.org/changeset/86447
2078         https://bugs.webkit.org/show_bug.cgi?id=60809
2079
2080         "Broke some uses of EventSender object on Qt" (Requested by
2081         mwenge on #webkit).
2082
2083         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2084         (WebCore::WebPage::WebPage):
2085         (WebCore::DumpRenderTree::DumpRenderTree):
2086         (WebCore::DumpRenderTree::initJSObjects):
2087         (WebCore::DumpRenderTree::createWindow):
2088         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2089         (WebCore::DumpRenderTree::eventSender):
2090         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2091         (webkit_test_plugin_new_instance):
2092         (webkit_test_plugin_set_window):
2093         (webkit_test_plugin_handle_event):
2094
2095 2011-05-13  Robert Hogan  <robert@webkit.org>
2096
2097         Reviewed by Benjamin Poulain.
2098
2099         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2100
2101         The support for this test added to the unix test plugin here
2102         may allow other platforms to pass it (nearly everyone
2103         skips it). On Qt it required a bit of trickiness with
2104         the page's EventSender object to get it working fully though,
2105         so only unskipping Qt here.
2106
2107         https://bugs.webkit.org/show_bug.cgi?id=60722
2108
2109         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2110         (WebCore::WebPage::WebPage):
2111         (WebCore::WebPage::eventSender):
2112         (WebCore::DumpRenderTree::DumpRenderTree):
2113         (WebCore::DumpRenderTree::initJSObjects):
2114         (WebCore::DumpRenderTree::createWindow):
2115         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2116         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2117         (webkit_test_plugin_new_instance):
2118         (webkit_test_plugin_set_window):
2119         (webkit_test_plugin_handle_event):
2120
2121 2011-05-13  Adam Roben  <aroben@apple.com>
2122
2123         Exclude the Leopard NRWT bot from the core builder set
2124
2125         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
2126
2127         Reviewed by Darin Adler.
2128
2129         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2130         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
2131         in the core builder set.
2132
2133         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2134         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
2135         regexps.
2136
2137 2011-05-13  Adam Roben  <aroben@apple.com>
2138
2139         Group all the NRWT bots together
2140
2141         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
2142         bots are experimental, it seems best not to clutter up the non-experimental bots with
2143         experimental ones.
2144
2145         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
2146         on build.webkit.org
2147
2148         Reviewed by Dan Bernstein.
2149
2150         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
2151         Chromium testers, which also use new-run-webkit-tests.
2152
2153 2011-05-13  Adam Roben  <aroben@apple.com>
2154
2155         Add a plugin test that dumps the plugin window's rect
2156
2157         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
2158         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
2159
2160         Reviewed by Dan Bernstein.
2161
2162         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
2163         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
2164         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
2165         harness window and log it.
2166
2167         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
2168
2169 2011-05-13  Adam Roben  <aroben@apple.com>
2170
2171         Move code required for most tests of plugin window geometry into a base class
2172
2173         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
2174         having all the trickiness in a shared base class, writing new window geometry tests will be
2175         much easier.
2176
2177         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
2178
2179         Reviewed by Anders Carlsson.
2180
2181         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2182         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
2183         WindowGeometryTest base class. Most of the code from this class was moved to the new base
2184         class.
2185         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
2186         This is called by the base class when it is safe to check the window's geometry. Note that
2187         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
2188         just vestigial code from an earlier version of this test.
2189
2190         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
2191         WindowGeometryTest class.
2192
2193         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
2194         WindowRegionIsSetToClipRect.
2195         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
2196         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
2197         Subclasses can implement that function to perform their own tests.
2198
2199         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
2200
2201 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
2202
2203         Reviewed by Csaba Osztrogonác.
2204
2205         Missing 2nd #EOF if WebProcess is killed.
2206         https://bugs.webkit.org/show_bug.cgi?id=60761
2207
2208         If the WebProcess is killed, only one #EOF is yielded
2209         by WebKitTestRunner. However, run-webkit-test wait for
2210         a second #EOF, which signals the finishing of pixel dump.
2211         Since this never happens, run-webkit-test waits forever.
2212
2213         * WebKitTestRunner/TestInvocation.cpp:
2214         (WTR::TestInvocation::dump):
2215         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2216         * WebKitTestRunner/TestInvocation.h:
2217
2218 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2219
2220         Reviewed by Csaba Osztrogonác.
2221
2222         [NRWT] chromium-linux tests shouldn't run on other platforms
2223         https://bugs.webkit.org/show_bug.cgi?id=60162
2224
2225         Remove _tests_for_other_platforms defs because r82753
2226         implemented it properly in the baseclass in webkit.py.
2227
2228         * Scripts/webkitpy/layout_tests/port/gtk.py:
2229         * Scripts/webkitpy/layout_tests/port/qt.py:
2230         * Scripts/webkitpy/layout_tests/port/win.py:
2231
2232 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
2233
2234         Reviewed by Antonio Gomes.
2235
2236         [EFL] Remove unused option of EWeblauncher
2237         https://bugs.webkit.org/show_bug.cgi?id=60747
2238
2239         Remove sudo-workaround option.
2240         This option is not used and make other option wrong.
2241
2242         * EWebLauncher/main.c:
2243
2244 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2245
2246         Reviewed by Stephanie Lewis.
2247
2248         Fix config.json to address missing WK2 builder/tester config.
2249         Fix naming of machines (xserve not macpro)
2250
2251         * BuildSlaveSupport/build.webkit.org-config/config.json:
2252
2253 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2254
2255         Reviewed by Stephanie Lewis.
2256
2257         Add SnowLeopard Debug builder and Test bot.
2258         apple-xserve-8 = SL Debug Tester.
2259         apple-xserve-9 = SL Debug Builder.
2260         
2261         * BuildSlaveSupport/build.webkit.org-config/config.json:
2262
2263 2011-05-12  Adam Barth  <abarth@webkit.org>
2264
2265         This patch disables sheriffbot's bug postings.  He's just been way too
2266         spammy recently due to test flakiness.
2267
2268         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2269         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2270
2271 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2272
2273         Reviewed by Anders Carlsson.
2274
2275         After relaunching an unresponsive web process, web page stops responding to mouse movement
2276         https://bugs.webkit.org/show_bug.cgi?id=60669
2277         <rdar://problem/9409934>
2278         
2279         This test follows the steps needed to reproduce this bug:
2280         1) Hang the web process
2281         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
2282         3) Kill and restart the WebProcess
2283         4) Move the mouse
2284         
2285         We are testing that we receive mouse move events after the WebProcess has restarted.
2286
2287         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
2288         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
2289         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
2290         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
2291         (TestWebKitAPI::setPageLoaderClient):
2292         (TestWebKitAPI::TEST):
2293         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
2294         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
2295         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
2296         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
2297
2298         * TestWebKitAPI/PlatformWebView.h:
2299         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2300         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
2301         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2302         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
2303
2304         Add new files.
2305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2306         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2307         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2308         * TestWebKitAPI/win/copy-resources.cmd:
2309
2310 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
2311
2312         Reviewed by Antonio Gomes.
2313
2314         [EFL] Added initialization/shutdown for ecore_file library
2315         https://bugs.webkit.org/show_bug.cgi?id=60457
2316
2317         Added initialization and shuthown for ecore_file library and replaced
2318         realpath function to ecore_file_realpath.
2319
2320         * EWebLauncher/main.c:
2321         (quit):
2322         (findThemePath):
2323         (main):
2324
2325 2011-05-12  Young Han Lee  <joybro@company100.net>
2326
2327         Reviewed by Kenneth Rohde Christiansen.
2328
2329         [Qt] Implement layoutTestController.layerTreeAsText()
2330         https://bugs.webkit.org/show_bug.cgi?id=60367
2331
2332         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2333         (LayoutTestController::layerTreeAsText):
2334         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2335
2336 2011-05-11  Eric Seidel  <eric@webkit.org>
2337
2338         Reviewed by David Levin.
2339
2340         Teach validate-committer-lists how to validate committers bugzilla_email()
2341         https://bugs.webkit.org/show_bug.cgi?id=60651
2342
2343         It turns out we currently have 9 committers with invalid values for their
2344         bugzilla_email field (meaning we don't know what email is their bugzilla account).
2345         "Alexander Kellett" <lypanov@mac.com>
2346         "Andre Boule" <aboule@apple.com>
2347         "Cameron McCormack" <cam@webkit.org>
2348         "Chris Petersen" <cpetersen@apple.com>
2349         "Eli Fidler" <eli@staikos.net>
2350         "Matt Lilek" <webkit@mattlilek.com>
2351         "Pierre d'Herbemont" <pdherbemont@free.fr>
2352         "Scott Violet" <sky@chromium.org>
2353         "Adam Treat" <treat@kde.org>
2354
2355         Most of those haven't committed in a very long time, so it's not suprising
2356         that we haven't noticed that their bugzilla emails are bogus.
2357
2358         * Scripts/validate-committer-lists:
2359         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2360         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2361
2362 2011-05-11  Dmitry Lomov  <dslomov@google.com>
2363
2364         Reviewed by David Levin.
2365
2366         https://bugs.webkit.org/show_bug.cgi?id=59561
2367         Switch TestWebKitAPI to GTest
2368
2369         Fixes Makefiles and WinCairo build as well
2370
2371         * Makefile:
2372         * Scripts/build-api-tests:
2373         * Scripts/run-api-tests:
2374         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2375         * TestWebKitAPI/Test.h:
2376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2377         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2378         (TestWebKitAPI::TEST):
2379         * TestWebKitAPI/TestsController.cpp:
2380         (TestWebKitAPI::TestsController::TestsController):
2381         (TestWebKitAPI::TestsController::dumpTestNames):
2382         (TestWebKitAPI::TestsController::runTestNamed):
2383         (TestWebKitAPI::TestsController::runAllTests):
2384         * TestWebKitAPI/TestsController.h:
2385         * TestWebKitAPI/mac/main.mm:
2386         (main):
2387
2388 2011-05-11  Eric Seidel  <eric@webkit.org>
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         Add Luke Macpherson to committers.py as a Contributor
2393         https://bugs.webkit.org/show_bug.cgi?id=60639
2394
2395         * Scripts/webkitpy/common/config/committers.py:
2396
2397 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
2398
2399         Reviewed by Kenneth Rohde Christiansen.
2400
2401         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
2402         https://bugs.webkit.org/show_bug.cgi?id=60439
2403
2404         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
2405
2406         * Scripts/build-webkit:
2407
2408 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2409
2410         Reviewed by Adam Roben.
2411
2412         REGRESSION (r86161): WKPreferences API test failing on Windows
2413         https://bugs.webkit.org/show_bug.cgi?id=60658
2414
2415         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2416         (TestWebKitAPI::TEST):
2417
2418 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
2419
2420         Reviewed by Ojan Vafai.
2421
2422         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
2423         https://bugs.webkit.org/show_bug.cgi?id=60521
2424
2425         First steps towards making the results JSON all hierarchical.
2426
2427         * TestResultServer/model/jsonresults.py:
2428         * TestResultServer/model/jsonresults_unittest.py:
2429
2430 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
2431
2432         [wx] Build fix, adding new LayoutTestController method stubs.
2433
2434         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2435         (LayoutTestController::localStorageDiskUsageForOrigin):
2436         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2437
2438 2011-05-11  Jessie Berlin  <jberlin@apple.com>
2439
2440         Reviewed by Darin Adler.
2441
2442         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
2443         about the usage for both the origin overall and the database in question.
2444         https://bugs.webkit.org/show_bug.cgi?id=60573
2445
2446         * WebKitTestRunner/TestController.cpp:
2447         (WTR::exceededDatabaseQuota):
2448
2449 2011-05-10  Stephen White  <senorblanco@chromium.org>
2450
2451         Reviewed by David Levin.
2452
2453         Adding myself as a reviewer.
2454         https://bugs.webkit.org/show_bug.cgi?id=60587
2455
2456         * Scripts/webkitpy/common/config/committers.py:
2457
2458 2011-05-11  Eric Seidel  <eric@webkit.org>
2459
2460         Reviewed by Csaba Osztrogonác.
2461
2462         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
2463         https://bugs.webkit.org/show_bug.cgi?id=60614
2464
2465         AppEngine has a result limit of 1000.  We hit that when trying
2466         to find out how many patches the style-queue (and other queues)
2467         have passed in the last 30 days.  So lets display 1000+ instead
2468         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
2469
2470         I also made the status pages show "never" instead of just "ago" when we
2471         haven't seen a pass or boot message in the last 1000 messages.
2472
2473         * QueueStatusServer/handlers/queuestatus.py:
2474         * QueueStatusServer/templates/queuestatus.html:
2475
2476 2011-05-11  Adam Barth  <abarth@webkit.org>
2477
2478         Reviewed by Eric Seidel.
2479
2480         sheriffbot shouldn't spam bugs when it can't figure out who to blame
2481         https://bugs.webkit.org/show_bug.cgi?id=60613
2482
2483         This patch limits the number of bugs sheriffbot will spam to three.
2484         Ideally, we'd come up with some smarter huerstics, but hopefully this
2485         will cut down on the bugmail spam for slow bots.
2486
2487         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2488
2489 2011-05-10  Eric Seidel  <eric@webkit.org>
2490
2491         Reviewed by Adam Barth.
2492
2493         EWS bots should be robust against test-webkitpy hangs
2494         https://bugs.webkit.org/show_bug.cgi?id=60579
2495
2496         Added a killAfterTimeout subroutine, which takes a child_pid
2497         and timeout, and will setup a watchdog process to kill that child
2498         after the timeout.  killAfterTimeout will waitpid on the child.
2499
2500         * EWSTools/start-queue.sh:
2501
2502 2011-05-10  MORITA Hajime  <morrita@google.com>
2503
2504         Unreviewed, moved myself to the reviewers list.
2505
2506         * Scripts/webkitpy/common/config/committers.py:
2507
2508 2011-05-10  Anton D'Auria  <adauria@apple.com>
2509
2510         Reviewed by David Levin.
2511
2512         StorageTracker should report actual local storage usage on disk
2513         https://bugs.webkit.org/show_bug.cgi?id=60558
2514
2515         * DumpRenderTree/LayoutTestController.cpp:
2516         (localStorageDiskUsageForOriginCallback):
2517         (LayoutTestController::staticFunctions):
2518         * DumpRenderTree/LayoutTestController.h:
2519         * DumpRenderTree/chromium/LayoutTestController.cpp:
2520         (LayoutTestController::LayoutTestController):
2521         (LayoutTestController::localStorageDiskUsageForOrigin):
2522         * DumpRenderTree/chromium/LayoutTestController.h:
2523         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2524         (LayoutTestController::localStorageDiskUsageForOrigin):
2525         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2526         (LayoutTestController::localStorageDiskUsageForOrigin):
2527         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2528         (LayoutTestController::localStorageDiskUsageForOrigin):
2529         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2530         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2531         (LayoutTestController::localStorageDiskUsageForOrigin):
2532
2533 2011-05-10  Anton D'Auria  <adauria@apple.com>
2534
2535         Reviewed by Alexey Proskuryakov.
2536
2537         Add ApplicationCache API to get disk usage per origin
2538         https://bugs.webkit.org/show_bug.cgi?id=57127
2539
2540         Added test that loads two frames with ~15Kb image, checks usage,
2541         deletes app cache, verifies usage is 0.
2542
2543         * DumpRenderTree/LayoutTestController.cpp:
2544         (applicationCacheDiskUsageForOriginCallback):
2545         (LayoutTestController::staticFunctions):
2546         * DumpRenderTree/LayoutTestController.h:
2547         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2548         (LayoutTestController::LayoutTestController):
2549         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2550         * DumpRenderTree/chromium/LayoutTestController.h:
2551         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2552         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2553         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2554         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2555         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2556         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2557         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2558         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2559         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2560
2561 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2562
2563         Unreviewed, adding Rafael Antognolli as a committer.
2564
2565         * Scripts/webkitpy/common/config/committers.py:
2566
2567 2011-05-10  Chris Evans  <cevans@chromium.org>
2568
2569         Reviewed by Adam Barth.
2570
2571         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
2572         https://bugs.webkit.org/show_bug.cgi?id=58378
2573
2574         * DumpRenderTree/chromium/LayoutTestController.cpp:
2575         (LayoutTestController::LayoutTestController):
2576         (LayoutTestController::setAllowDisplayOfInsecureContent):
2577         (LayoutTestController::setAllowRunningOfInsecureContent):
2578         * DumpRenderTree/chromium/LayoutTestController.h:
2579         * DumpRenderTree/chromium/WebPreferences.cpp:
2580         (WebPreferences::reset):
2581         (WebPreferences::applyTo):
2582         * DumpRenderTree/chromium/WebPreferences.h:
2583         Add plumbing for new settings to Chromium DRT.
2584
2585 2011-05-10  Enrica Casucci  <enrica@apple.com>
2586
2587         Reviewed by Beth Dakin.
2588
2589         Added my name to the reviewers list and removed my name from
2590         to committer-only list.
2591
2592         * Scripts/webkitpy/common/config/committers.py:
2593
2594 2011-05-10  David Levin  <levin@chromium.org>
2595
2596         Reviewed by Shinichiro Hamaji.
2597
2598         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
2599         https://bugs.webkit.org/show_bug.cgi?id=60466
2600
2601         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
2602         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
2603           that property was removed.
2604         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
2605           filtering for errors.
2606         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
2607           verify that the line filtering is turned off.
2608         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
2609           and remove the unused file_path parameter.
2610         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
2611           line filtering is turned off (and fix test_no_error).
2612         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
2613           of errors based on the lines changed in the patch.
2614         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
2615           the filtering.
2616
2617 2011-05-10  Adam Roben  <aroben@apple.com>
2618
2619         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
2620
2621         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
2622         platform/win/plugins/window-geometry-initialized-before-set-window.html and
2623         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
2624         (WebKit2 Tests)
2625
2626         Reviewed by Anders Carlsson.
2627
2628         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
2629         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
2630         WindowedPluginTest::testHarnessWindow function.
2631
2632         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
2633         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
2634         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
2635         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
2636         created for.
2637
2638         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2639         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
2640         WindowedPluginTest, and initialized new members.
2641         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
2642         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
2643         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
2644         then clean up and tell the test harness we're done.
2645         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
2646         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
2647         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
2648         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
2649         window becomes visible.
2650         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
2651         if it was hidden at the start of the test.
2652         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
2653         This should cause our window to become visible and our window region to get set. When we get
2654         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
2655         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
2656         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
2657         "startTest".
2658         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
2659
2660         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
2661         (WindowedPluginTest::testHarnessWindow):
2662         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
2663         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
2664
2665 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2666
2667         Reviewed by Kenneth Rohde Christiansen.
2668
2669         [Qt] Add new qt-4.8 platform for layout testing
2670         https://bugs.webkit.org/show_bug.cgi?id=60544
2671
2672         * Scripts/old-run-webkit-tests:
2673         * Scripts/webkitdirs.pm:
2674
2675 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2676
2677         Unreviewed, rolling out r86108.
2678         http://trac.webkit.org/changeset/86108
2679         https://bugs.webkit.org/show_bug.cgi?id=60533
2680
2681         Broke makefile based builds and Cairo (Requested by weinig on
2682         #webkit).
2683
2684         * Scripts/build-api-tests:
2685         * Scripts/run-api-tests:
2686         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2687         * TestWebKitAPI/Test.h:
2688         (TestWebKitAPI::Test::~Test):
2689         (TestWebKitAPI::Test::name):
2690         (TestWebKitAPI::Test::Register::Register):
2691         (TestWebKitAPI::Test::Register::create):
2692         (TestWebKitAPI::Test::Test):
2693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2694         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2695         (TestWebKitAPI::TEST):
2696         * TestWebKitAPI/TestsController.cpp:
2697         (TestWebKitAPI::TestsController::TestsController):
2698         (TestWebKitAPI::TestsController::dumpTestNames):
2699         (TestWebKitAPI::TestsController::runTestNamed):
2700         (TestWebKitAPI::TestsController::testFailed):
2701         (TestWebKitAPI::TestsController::registerCreateTestFunction):
2702         * TestWebKitAPI/TestsController.h:
2703         * TestWebKitAPI/mac/main.mm:
2704         (main):
2705
2706 2011-05-09  Hayato Ito  <hayato@chromium.org>
2707
2708         Reviewed by Ojan Vafai.
2709
2710         Skip reftests if pixel tests are disabled.
2711
2712         https://bugs.webkit.org/show_bug.cgi?id=59078
2713
2714         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2715         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2716         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2717         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2718
2719 2011-05-09  Chang Shu  <cshu@webkit.org>
2720
2721         Reviewed by Kenneth Rohde Christiansen.
2722
2723         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
2724         https://bugs.webkit.org/show_bug.cgi?id=60499
2725
2726         The implementation is similar to gtk.
2727
2728         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2729         (TextInputController::unmarkText):
2730         * DumpRenderTree/qt/TextInputControllerQt.h:
2731
2732 2011-05-09  James Robinson  <jamesr@chromium.org>
2733
2734         Reviewed by Eric Seidel.
2735
2736         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
2737         https://bugs.webkit.org/show_bug.cgi?id=60520
2738
2739         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2740
2741 2011-05-09  Dmitry Lomov  <dslomov@google.com>
2742
2743         Reviewed by Sam Weinig.
2744
2745         Switch TestWebKitAPI to GTest
2746         https://bugs.webkit.org/show_bug.cgi?id=59561
2747
2748         * Scripts/build-api-tests:
2749         * Scripts/run-api-tests:
2750         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2751         * TestWebKitAPI/Test.h:
2752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2753         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2754         (TestWebKitAPI::TEST):
2755         * TestWebKitAPI/TestsController.cpp:
2756         (TestWebKitAPI::TestsController::TestsController):
2757         (TestWebKitAPI::TestsController::dumpTestNames):
2758         (TestWebKitAPI::TestsController::runTestNamed):
2759         (TestWebKitAPI::TestsController::runAllTests):
2760         * TestWebKitAPI/TestsController.h:
2761         * TestWebKitAPI/mac/main.mm:
2762         (main):
2763
2764 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
2765
2766         Reviewed by Andreas Kling.
2767
2768         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
2769         https://bugs.webkit.org/show_bug.cgi?id=60487
2770
2771         When adding a new touch point, the start position of this point needs to be set.
2772
2773         * DumpRenderTree/qt/EventSenderQt.cpp:
2774         (EventSender::addTouchPoint):
2775
2776 2011-05-09  Robert Hogan  <robert@webkit.org>
2777
2778         Reviewed by Adam Roben.
2779
2780         https://bugs.webkit.org/show_bug.cgi?id=57137
2781
2782         Unskip plugins/embed-prefers-plugins-for-images.html
2783
2784         Add image/png mime-type to test netscape plugin on Unix.
2785
2786         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2787         (NP_GetMIMEDescription):
2788
2789 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
2790
2791         Reviewed by Ojan Vafai.
2792
2793         Pull jsonresults_unittest test cases out into separate test methods.
2794         https://bugs.webkit.org/show_bug.cgi?id=60418
2795
2796         * TestResultServer/model/jsonresults_unittest.py:
2797
2798 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2799
2800         Reviewed by Andreas Kling.
2801
2802         [Qt] fix fast/dom/Geolocation/window-close-crash.html
2803         https://bugs.webkit.org/show_bug.cgi?id=60458
2804
2805         Update all pages with Mock position/error/permission.
2806
2807         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2808         (LayoutTestController::setGeolocationPermission):
2809         (LayoutTestController::setMockGeolocationError):
2810         (LayoutTestController::setMockGeolocationPosition):
2811
2812 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
2813
2814         Reviewed by Tony Gentilcore.
2815
2816         Implement Page Visibility API.
2817         https://bugs.webkit.org/show_bug.cgi?id=54181
2818
2819         * DumpRenderTree/LayoutTestController.cpp:
2820         (setPageVisibilityCallback):
2821         (resetPageVisibilityCallback):
2822         (LayoutTestController::staticFunctions):
2823         * DumpRenderTree/LayoutTestController.h:
2824         (LayoutTestController::setPageVisibility):
2825         (LayoutTestController::resetPageVisibility):
2826         * DumpRenderTree/chromium/LayoutTestController.cpp:
2827         (LayoutTestController::LayoutTestController):
2828         (LayoutTestController::resetPageVisibility):
2829         (LayoutTestController::setPageVisibility):
2830         * DumpRenderTree/chromium/LayoutTestController.h:
2831
2832 2011-05-07  Adam Barth  <abarth@webkit.org>
2833
2834         Reviewed by Eric Seidel.
2835
2836         Testing EWS spins on patches with a large number of failures
2837         https://bugs.webkit.org/show_bug.cgi?id=60441
2838
2839         In cases where the tree has a small number of persistent failures but a
2840         patch has a large number of failures, we weren't believing any results.
2841         That lead to us retrying the patch forever while we waited for
2842         trustworthy results that would never come.
2843
2844         This patch loosens the semantics of unexpected_failures to return a
2845         subset (rather than the exact set) of unexpected failures.  In the case
2846         where the tree has a bounded number of failures and the patch has an
2847         unbounded number of failures, we can accurately compute such a subset
2848         and reject the patch.
2849
2850         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2851         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2852         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2853         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2854         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2855
2856 2011-05-07  Joe Mason  <jmason@rim.com>
2857
2858         Reviewed by Daniel Bates.
2859
2860         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
2861         https://bugs.webkit.org/show_bug.cgi?id=52211
2862
2863         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
2864         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
2865
2866         * DumpRenderTree/chromium/WebViewHost.cpp:
2867         (WebViewHost::willPerformClientRedirect):
2868         (WebViewHost::didStartProvisionalLoad):
2869         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2870         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2871
2872 2011-05-07  Daniel Bates  <dbates@webkit.org>
2873
2874         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
2875         <http://trac.webkit.org/changeset/86007> (bug #60438).
2876
2877         * Scripts/old-run-webkit-tests:
2878           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
2879             file local variable. 
2880
2881 2011-05-07  Pratik Solanki  <psolanki@apple.com>
2882
2883         Reviewed by Darin Adler.
2884
2885         Remove references to Tiger in scripts
2886         https://bugs.webkit.org/show_bug.cgi?id=60438
2887
2888         Remove isTiger() and all of the code that depends on it.
2889
2890         * Scripts/build-webkit:
2891         * Scripts/ensure-valid-python:
2892         * Scripts/gdb-safari:
2893         * Scripts/webkitdirs.pm:
2894
2895 2011-05-06  David Grogan  <dgrogan@chromium.org>
2896
2897         Reviewed by Eric Seidel.
2898
2899         update link to message about mac 64bit git binaries
2900         https://bugs.webkit.org/show_bug.cgi?id=60411
2901
2902         The original message implied (correctly, at-the-time) that
2903         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
2904         binaries. The new message notes that they do. This might prevent someone
2905         else from spending a few minutes confused.
2906
2907         * Scripts/webkitpy/common/checkout/scm/git.py:
2908
2909 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
2910
2911         Reviewed by Ojan Vafai.
2912
2913         new-run-webkit-tests: crashes in race with crashing DRT
2914         https://bugs.webkit.org/show_bug.cgi?id=60238
2915
2916         This fixes a race where if we wrote the URL to DRT and
2917         DRT crashed immediately, we could get a broken pipe
2918         error back during the write() and not handle it correctly,
2919         causing NRWT to also crash.
2920
2921         * Scripts/webkitpy/layout_tests/port/server_process.py:
2922         * Scripts/webkitpy/layout_tests/port/webkit.py:
2923
2924 2011-05-06  Adam Barth  <abarth@webkit.org>
2925
2926         Reviewed by Eric Seidel.
2927
2928         Add a --skip-integrationtests mode to test-webkitpy
2929         https://bugs.webkit.org/show_bug.cgi?id=60354
2930
2931         These two test suites account for 2/3 of test-webkitpy's running time
2932         because they're not actually unit tests.  They're integration tests.
2933         This patch adds the ability to skip integration tests by passing a
2934         command line argument to test-webkitpy.  The buildbots will continue to
2935         run these integration tests to make sure they don't regress.  This
2936         option is for use by developers when working on parts of the code that
2937         are well-covered by unit tests.
2938
2939         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
2940         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2941         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
2942         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
2943         * Scripts/webkitpy/test/main.py:
2944
2945 2011-05-06  Adam Barth  <abarth@webkit.org>
2946
2947         Reviewed by Eric Seidel.
2948
2949         The results.zip generated by the Chromium EWS are too big
2950         https://bugs.webkit.org/show_bug.cgi?id=60352
2951
2952         Currently results.zip created by the Chromium EWS bot contain roughly
2953         1000 tests that we expect to fail.  These test results are not helpful
2954         to contributors.
2955
2956         There are several approaches to solving this problem:
2957
2958         1) We could be more selective about which files to include in the zip.
2959         2) We could ask new-run-webkit-tests not to generate results for
2960            expected failures.
2961         3) We could ask new-run-webkit-tests not to run tests that we expect to
2962            fail.
2963
2964         This patch takes approach (3).  Currently, we're ignoring the outcome
2965         of failing tests anyway, so there's not much point in actually running
2966         them.  As a side benefit, this will speed up the test run by about 6%.
2967         In the future, we might revisit this decision and choose another
2968         approach.
2969
2970         * Scripts/webkitpy/common/config/ports.py:
2971         * Scripts/webkitpy/common/config/ports_unittest.py:
2972
2973 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
2974
2975         Reviewed by Csaba Osztrogonác.
2976
2977         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
2978
2979         * Scripts/old-run-webkit-tests:
2980
2981 2011-05-06  Adam Barth  <abarth@webkit.org>
2982
2983         Reviewed by Ojan Vafai.
2984
2985         Add an option to NRWT to skip failing tests
2986         https://bugs.webkit.org/show_bug.cgi?id=60295
2987
2988         This option is similar to the way old-run-webkit-tests works.  We're
2989         planning to use this option on the testing EWS bots because they don't
2990         use information from failing tests yet.
2991
2992         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2993         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2994         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2995
2996 2011-05-04  Philippe Normand  <pnormand@igalia.com>
2997
2998         Reviewed by Dimitri Glazkov.
2999
3000         Implement LayoutTestController::pseudoShadowId()
3001         https://bugs.webkit.org/show_bug.cgi?id=60034
3002
3003         shadowPseudoId support in the various LayoutTestController
3004         implementations.
3005
3006         * DumpRenderTree/LayoutTestController.cpp:
3007         (shadowPseudoIdCallback):
3008         (LayoutTestController::staticFunctions):
3009         * DumpRenderTree/LayoutTestController.h:
3010         * DumpRenderTree/chromium/LayoutTestController.cpp:
3011         (LayoutTestController::LayoutTestController):
3012         (LayoutTestController::shadowPseudoId):
3013         * DumpRenderTree/chromium/LayoutTestController.h:
3014         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3015         (LayoutTestController::shadowPseudoId):
3016         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3017         (LayoutTestController::shadowPseudoId):
3018         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3019         (LayoutTestController::shadowPseudoId):
3020         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3021         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3022         (LayoutTestController::shadowPseudoId):
3023         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3024         (LayoutTestController::shadowPseudoId):
3025         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3026         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3027         (WTR::LayoutTestController::shadowPseudoId):
3028         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3029
3030 2011-05-06  Adam Barth  <abarth@webkit.org>
3031
3032         EWS can't reject patches
3033         https://bugs.webkit.org/show_bug.cgi?id=60345
3034
3035         We're supposed to use patch.id() for the attachment ID, silly.
3036
3037         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3038         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3039
3040 2011-05-05  Steve Lacey  <sjl@chromium.org>
3041
3042         Reviewed by Ojan Vafai.
3043
3044         Fix generation of results html file by passing relative path to scm
3045         methods.
3046         Generate diff images for results html file.
3047
3048         https://bugs.webkit.org/show_bug.cgi?id=60086
3049
3050         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3051         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3052
3053 2011-05-05  Andy Estes  <aestes@apple.com>
3054
3055         Reviewed by Daniel Bates.
3056
3057         update-webkit should handle Internal using a different VCS than OpenSource.
3058         https://bugs.webkit.org/show_bug.cgi?id=60310
3059
3060         isGit() and isSVN() cache their results, so Internal will always be
3061         updated using the VCS commands used for OpenSource. If Internal uses a
3062         different VCS, this will fail. Fix this by calling isGitDirectory() and
3063         isSVNDirectory() instead, which do not cache their results.
3064
3065         * Scripts/update-webkit:
3066
3067 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3068
3069         Reviewed by Ojan Vafai.
3070
3071         nrwt: revamp integration tests incl. tests for servers
3072         https://bugs.webkit.org/show_bug.cgi?id=59985
3073
3074         This change adds the ability to run "integration tests" that
3075         depend on (and affect) the local environment on your machine.
3076         These tests can be run manually by invoking python on the
3077         test file in question and passing the '-i' flag, but are
3078         not run automatically as part of test-webkitpy.
3079
3080         Integration tests are identified by being methods named as
3081         "integration_test_*" instead of "test_*", and we use a
3082         custom TestLoader instead of the default one provided by
3083         unittest.
3084
3085         This change also adds a protected "_default_to_apache" method
3086         to the port object so we can do the right thing when starting
3087         and stopping web servers with less mechanism.
3088
3089         * Scripts/webkitpy/layout_tests/port/base.py:
3090         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3091         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3092         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3093         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3094         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3095
3096 2011-05-05  Adam Roben  <aroben@apple.com>
3097
3098         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
3099
3100         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
3101         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
3102         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
3103         safeguard against this, we fill the alpha channel with constant full opacity after the
3104         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
3105         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
3106         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
3107         results need an alpha channel, too.)
3108
3109         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
3110         generated due to alpha channel weirdness
3111
3112         Reviewed by Sam Weinig.
3113
3114         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3115         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
3116         constant full opacity.
3117         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
3118         in a CGContext or cairo_surface.
3119
3120 2011-05-05  Adam Roben  <aroben@apple.com>
3121
3122         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
3123
3124         Passing true tells the test harness to dump pixels even though we're not dumping a render
3125         tree.
3126
3127         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
3128         WebKitTestRunner doesn't result in pixel results being generated
3129
3130         Reviewed by Sam Weinig.
3131
3132         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
3133         argument to dumpAsText.
3134
3135         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3136         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
3137
3138         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3139         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
3140
3141         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
3142
3143         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
3144         developers.
3145
3146 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3147
3148         Reviewed by Ojan Vafai.
3149
3150         new-run-webkit-tests: merge os, version fields in test config
3151         https://bugs.webkit.org/show_bug.cgi?id=60004
3152
3153         This change removes the 'o/s' field from the TestConfiguration
3154         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
3155         the expectations file to macros that expand to the version names
3156         for each platform.
3157
3158         This means that you can once again put any subset of the
3159         operating system versions on a single line, e.g.:
3160           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
3161
3162         This change will break any existing test_expectations.txt
3163         file that uses the "OS-VERSION" macros, which are no longer
3164         needed. It turns out they were never needed, as just VERSION
3165         by itself was sufficient. The test_expectations.txt file should
3166         be updated accordingly prior to landing this change.
3167
3168         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3169         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3170         * Scripts/webkitpy/layout_tests/port/base.py:
3171
3172 2011-05-05  Tony Chang  <tony@chromium.org>
3173
3174         Reviewed by Adam Barth.
3175
3176         [chromium] switch from Lucida to free fonts for Hindi and Thai
3177         https://bugs.webkit.org/show_bug.cgi?id=60287
3178
3179         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
3180         packages on Lucid. There are actually multiple Thai fonts in the
3181         package, so I just picked one.
3182
3183         * DumpRenderTree/chromium/TestShellGtk.cpp:
3184         (setupFontconfig):
3185
3186 2011-05-05  Tony Chang  <tony@chromium.org>
3187
3188         Reviewed by Ojan Vafai.
3189
3190         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
3191         https://bugs.webkit.org/show_bug.cgi?id=60290
3192
3193         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
3194         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
3195         lucid64.  Because of that, google-chrome-64 used to skip the
3196         chromium-linux-x86_64 results since they were more incorrect.
3197
3198         Now that we're switching to lucid for google-chrome, we want
3199         google-chrome-64 to fall back to chromium-linux-x86_64.
3200
3201         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3202
3203 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3204
3205         Reviewed by Ojan Vafai.
3206
3207         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
3208         https://bugs.webkit.org/show_bug.cgi?id=60002
3209
3210         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3211         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3212         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3213         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3214         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3215         * Scripts/webkitpy/style/checkers/test_expectations.py:
3216
3217 2011-05-05  Eric Seidel  <eric@webkit.org>
3218
3219         Reviewed by Adam Barth.
3220
3221         commit-queue should reject patches which fail ewses
3222         https://bugs.webkit.org/show_bug.cgi?id=47534
3223
3224         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3225         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3226         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3227
3228 2011-05-05  Chang Shu  <cshu@webkit.org>
3229
3230         Reviewed by Andreas Kling.
3231
3232         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
3233         https://bugs.webkit.org/show_bug.cgi?id=59638
3234
3235         1. Call QGraphicsWKView constructor with pageGroupRef.
3236         2. Disable setFontFamily calls as it breaks Qt test fonts.
3237
3238         * WebKitTestRunner/TestController.cpp:
3239         (WTR::TestController::resetStateToConsistentValues):
3240         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3241         (WTR::WebView::WebView):
3242         (WTR::PlatformWebView::PlatformWebView):
3243
3244 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
3245
3246         Reviewed by David Kilzer.
3247
3248         Add --only-webkit option to build-webkit
3249         https://bugs.webkit.org/show_bug.cgi?id=60245
3250
3251         * Scripts/build-webkit: If --only-webkit was specified
3252         just build the WebKit project, and not its dependencies.
3253
3254 2011-05-05  Jeff Miller  <jeffm@apple.com>
3255
3256         Reviewed by Darin Adler.
3257
3258         Add didNotHandleWheelEvent callback to WKPageUIClient
3259         https://bugs.webkit.org/show_bug.cgi?id=60203
3260
3261         * MiniBrowser/gtk/BrowserWindow.c:
3262         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
3263         * MiniBrowser/mac/BrowserWindowController.m:
3264         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
3265         * MiniBrowser/win/BrowserView.cpp:
3266         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
3267         * WebKitTestRunner/TestController.cpp:
3268         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
3269         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
3270
3271 2011-05-04  Eric Seidel  <eric@webkit.org>
3272
3273         Reviewed by Adam Barth.
3274
3275         Add more missing imports from scm refactor
3276         https://bugs.webkit.org/show_bug.cgi?id=60239
3277
3278         * Scripts/webkitpy/common/checkout/scm/git.py:
3279         * Scripts/webkitpy/common/checkout/scm/svn.py:
3280
3281 2011-05-04  Eric Seidel  <eric@webkit.org>
3282
3283         Reviewed by Adam Barth.
3284
3285         sheriff-bot is having more exception trouble
3286         https://bugs.webkit.org/show_bug.cgi?id=60233
3287
3288         A webpage-forced build was causing SB to throw an exception.
3289         We've long had this bug, but we just didn't notice it until now.
3290
3291         In debugging this I found we fetch an absurd amount of data now
3292         that we use buildbot's json (instead of xmlrpc), so I added
3293         the filter=1 parameter to reduce it a little.  That required
3294         me to handle the case where filter=1 would strip
3295         result=0 in some cases (it's unclear why it does that).
3296
3297         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3298         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3299
3300 2011-05-04  Cris Neckar  <cdn@chromium.org>
3301
3302         Unreviewed, Adding Cris Neckar as a committer
3303
3304         * Scripts/webkitpy/common/config/committers.py:
3305
3306 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3307
3308         Reviewed by Laszlo Gombos.
3309
3310         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
3311         https://bugs.webkit.org/show_bug.cgi?id=59462
3312
3313         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
3314
3315 2011-05-04  Eric Seidel  <eric@webkit.org>
3316
3317         Reviewed by Adam Barth.
3318
3319         The testing EWS bots should upload layout-test-results.zip to bugs after failures
3320         https://bugs.webkit.org/show_bug.cgi?id=60223
3321
3322         This required sharing a bit of code between the commit-queue
3323         (which already knew how to do this) and the new EWS testing bots.
3324
3325         In the process I also cleaned up EWS testing a little and
3326         removed some dead code from the commit-queue.
3327
3328         * Scripts/webkitpy/common/config/committervalidator.py:
3329         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3330         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3331         * Scripts/webkitpy/tool/commands/queues.py:
3332         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3333
3334 2011-05-04  James Kozianski  <koz@chromium.org>
3335
3336         Reviewed by Eric Seidel.
3337
3338         Add method to make a Port able to retrieve TestOutputSets from its builders.
3339         https://bugs.webkit.org/show_bug.cgi?id=58211
3340
3341         This will be used in the new rebaseline script - TestOutputs are
3342         potential new baselines.
3343
3344         * Scripts/webkitpy/common/config/urls.py:
3345         * Scripts/webkitpy/layout_tests/port/base.py:
3346         * Scripts/webkitpy/layout_tests/port/chromium.py:
3347         * Scripts/webkitpy/layout_tests/port/factory.py:
3348         * Scripts/webkitpy/layout_tests/port/webkit.py:
3349
3350 2011-05-04  Eric Seidel  <eric@webkit.org>
3351
3352         Reviewed by Ojan Vafai.
3353
3354         sheriff-bot can't parse results.html
3355         https://bugs.webkit.org/show_bug.cgi?id=60196
3356
3357         The problem was that the NRWT bots are currently core
3358         and so sheriff-bot was trying to diagnose failures on
3359         them.  It was trying to parse their results.html file
3360         and BeautifulSoup was throwing an exception.
3361
3362         It seems our version of BeautifulSoup was quite old
3363         and unable to handle <script> tags correctly.
3364         This moves us to 3.2 which doesn't seem to have this bug.
3365
3366         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
3367
3368 2011-05-04  Adam Barth  <abarth@webkit.org>
3369
3370         Reviewed by Eric Seidel.
3371
3372         Make the EWS test logging less verbose
3373         https://bugs.webkit.org/show_bug.cgi?id=60201
3374
3375         This should help us generate less than a hundred MB of logs per hour.
3376
3377         * Scripts/webkitpy/common/config/ports.py:
3378         * Scripts/webkitpy/common/config/ports_unittest.py:
3379
3380 2011-05-04  Tao Bai  <michaelbai@chromium.org>
3381
3382         Reviewed by David Kilzer.
3383
3384         Populate touch-icon url to FrameLoaderClient
3385         https://bugs.webkit.org/show_bug.cgi?id=59143
3386
3387         Disable touch icon by default. 
3388
3389         * Scripts/build-webkit:
3390
3391 2011-05-04  Justin Novosad  <junov@chromium.org>
3392
3393         Reviewed by Kenneth Russell.
3394
3395         [Chromium] Add gpu acceleration flags to DumpRenderTree
3396         https://bugs.webkit.org/show_bug.cgi?id=60168
3397         Adding support for command line flags 
3398         enable-accelerated-2d-canvas an
3399         enable-accelerated-drawing in DumpRenderTree.
3400
3401         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3402         (main):
3403         * DumpRenderTree/chromium/TestShell.cpp:
3404         (TestShell::TestShell):
3405         (TestShell::resetWebSettings):
3406         * DumpRenderTree/chromium/TestShell.h:
3407         (TestShell::setLegacyAccelerated2dCanvasEnabled):
3408         (TestShell::setAcceleratedDrawingEnabled):
3409         * DumpRenderTree/chromium/WebPreferences.cpp:
3410         (WebPreferences::reset):
3411         (WebPreferences::applyTo):
3412         * DumpRenderTree/chromium/WebPreferences.h:
3413
3414 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3415
3416         Reviewed by Csaba Osztrogonác.
3417
3418         [Qt] run-qtwebkit-tests misses exec bit
3419         https://bugs.webkit.org/show_bug.cgi?id=60188
3420
3421         Also removing an unecessary import (mostly to let this bugfix goes
3422         through the system, as this is just a chmod).
3423
3424         * Scripts/run-qtwebkit-tests:
3425
3426 2011-05-04  Adam Barth  <abarth@webkit.org>
3427
3428         Fix import of ircproxy module to actually import the module.  I don't
3429         really understand how this code could have worked before.
3430
3431         * Scripts/webkitpy/common/host.py:
3432
3433 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3434
3435         Reviewed by Andreas Kling.
3436
3437         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
3438         https://bugs.webkit.org/show_bug.cgi?id=60172
3439
3440         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
3441         (BrowserWindow::BrowserWindow):
3442
3443 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
3444
3445         Reviewed by Ojan Vafai.
3446
3447         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
3448         https://bugs.webkit.org/show_bug.cgi?id=60088
3449         
3450         Makes --new-baseline put new baselines into the first entry in the
3451         baseline search path, including any additional directories passed in via
3452         --additional-platform-directory.
3453         
3454         Simplifies baseline_path() by making it return the first entry in the
3455         baseline search path instead of requiring each port to have an
3456         implementation (should not result in any behavior change).
3457
3458         * Scripts/webkitpy/layout_tests/port/base.py:
3459         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3460         * Scripts/webkitpy/layout_tests/port/chromium.py:
3461         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3462         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3463         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3464         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3465         * Scripts/webkitpy/layout_tests/port/mac.py:
3466         * Scripts/webkitpy/layout_tests/port/test.py:
3467         * Scripts/webkitpy/layout_tests/port/webkit.py:
3468
3469 2011-05-04  Adam Barth  <abarth@webkit.org>
3470
3471         Reviewed by Eric Seidel.
3472
3473         Fix circular dependency in webkitpy
3474         https://bugs.webkit.org/show_bug.cgi?id=60075
3475
3476         These functions don't belong in bugzilla.py.  They only exist there
3477         because they are old.  Really, these functions shouldn't be free
3478         functions at all, but that's a patch for another day.
3479
3480         * Scripts/webkitpy/common/checkout/changelog.py:
3481         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3482         * Scripts/webkitpy/common/checkout/checkout.py:
3483         * Scripts/webkitpy/common/config/urls.py:
3484         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3485         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3486         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3487         * Scripts/webkitpy/style/checkers/changelog.py:
3488         * Scripts/webkitpy/tool/bot/irc_command.py:
3489         * Scripts/webkitpy/tool/bot/sheriff.py:
3490         * Scripts/webkitpy/tool/commands/upload.py:
3491
3492 2011-05-03  Pratik Solanki  <psolanki@apple.com>
3493
3494         Reviewed by Dan Bernstein.
3495
3496         https://bugs.webkit.org/show_bug.cgi?id=60141
3497         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
3498
3499         * Scripts/build-webkit:
3500
3501 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
3502
3503         Reviewed by Ojan Vafai.
3504
3505         Update rebaseline queue server to handle hierarchical test results
3506         https://bugs.webkit.org/show_bug.cgi?id=60063
3507         
3508         Update test result parsing done by the rebaseline queue server to handle
3509         the hierarchical test result output that is generated as of r85254.
3510
3511         * RebaselineQueueServer/templates/builder-queue-edit.html:
3512
3513 2011-05-03  Eric Seidel  <eric@webkit.org>
3514
3515         Reviewed by Adam Roben.
3516
3517         webkit-patch post-commits HEAD^.. throws an exception
3518         https://bugs.webkit.org/show_bug.cgi?id=60027
3519
3520         * Scripts/webkitpy/common/checkout/scm/git.py:
3521
3522 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
3523
3524         Reviewed by Kenneth Rohde Christiansen.
3525
3526         [Qt] Layout tests may timeout if loadFinished receives false
3527         https://bugs.webkit.org/show_bug.cgi?id=60064
3528
3529         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
3530         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
3531         a response is ignored, like it should be for 204 responses. It is a problem for creating
3532         tests for 204 responses for example.
3533
3534         This change has been tested and it causes no regressions in layout tests.
3535
3536         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3537         (LayoutTestController::maybeDump):
3538
3539 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3540
3541         Unreviewed, rolling out r85659.
3542         http://trac.webkit.org/changeset/85659
3543         https://bugs.webkit.org/show_bug.cgi?id=59977
3544
3545         restarting isn't working correctly
3546
3547         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3548         * Scripts/webkitpy/layout_tests/port/http_server.py:
3549         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3550         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3551
3552 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3553
3554         Reviewed by Ojan Vafai.
3555
3556         new-run-webkit-tests: fix http server startup/shutdown
3557
3558         Previous versions of the code had three problems that made startup
3559         and shutdown flaky. The first is that it would throw exceptions
3560         if it couldn't delete stale log files, which was overly
3561         paranoid. The second is that some of the exceptions weren't
3562         defined properly. The third, and most important, is that it was
3563         using urllib to check if ports were available, which was leaving
3564         sockets in a half-closed state, and keeping ports from being
3565         reused. By switching to raw sockets, we are able to now reliably
3566         restart.
3567
3568         This change also switches the code to using Executives to stop
3569         processes, which will let us delete a bunch of code in the
3570         port/* implementations and fix a weird layering problem in a
3571         subsequent patch.
3572
3573         https://bugs.webkit.org/show_bug.cgi?id=59977
3574
3575         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3576         * Scripts/webkitpy/layout_tests/port/http_server.py:
3577         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3578         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3579
3580 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3581
3582         Reviewed by Adam Barth.
3583
3584         fix failing printing_unittest on win32
3585         https://bugs.webkit.org/show_bug.cgi?id=59963
3586
3587         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3588
3589 2011-05-03  Adam Roben  <aroben@apple.com>
3590
3591         Fix most strict PassOwnPtr violations on Windows
3592
3593         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
3594         enabled
3595
3596         Reviewed by Anders Carlsson.
3597
3598         * WebKitAPITest/Test.h: Use adoptPtr.
3599
3600 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3601
3602         Reviewed by Andreas Kling.
3603
3604         Add myself to the committers list.
3605
3606         * Scripts/webkitpy/common/config/committers.py:
3607
3608 2011-05-03  James Robinson  <jamesr@chromium.org>
3609
3610         Reviewed by Kenneth Russell.
3611
3612         [chromium] Layout test animations/3d/replace-filling-transform.html failing
3613         https://bugs.webkit.org/show_bug.cgi?id=59839
3614
3615         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
3616
3617         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3618
3619 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3620
3621         Unreviewed, rolling out r85471.
3622         http://trac.webkit.org/changeset/85471
3623         https://bugs.webkit.org/show_bug.cgi?id=59922
3624
3625         The rule of thumb in EFL is that you init in all the places
3626         you use it. So, if in your application you call ecore_evas_*
3627         functions, you have to call ecore_evas_init() first.
3628
3629         * EWebLauncher/main.c: always call *_init() functions when you use
3630         that namespace.
3631         (quit):
3632         (main):
3633
3634 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3635
3636         Reviewed by Tony Chang.
3637
3638         remove no longer used method
3639         https://bugs.webkit.org/show_bug.cgi?id=59981
3640
3641         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3642         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3643
3644 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3645
3646         Reviewed by Tony Chang.
3647
3648         add image toggling behavior from old-run-webkit-tests
3649         https://bugs.webkit.org/show_bug.cgi?id=59978
3650
3651         Output -diffs.html files. This matches old-run-webkit-tests.
3652         In theory, we could use data urls in the results.html file, but
3653         data urls don't currently have access to local files.
3654
3655         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3656
3657 2011-05-02  Tony Chang  <tony@chromium.org>
3658
3659         Reviewed by Ojan Vafai.
3660
3661         [nrwt] remove some obsolete references to .checksum files
3662         https://bugs.webkit.org/show_bug.cgi?id=59971
3663
3664         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3665         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3666         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3667         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3668         * Scripts/webkitpy/layout_tests/port/test.py:
3669         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3670
3671 2011-05-02  Adam Roben  <aroben@apple.com>
3672
3673         Take advantage of implicit nullptr_t -> PassOwnPtr conversion
3674
3675         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
3676         doesn't work, but should
3677
3678         Reviewed by Adam Barth.
3679
3680         * DumpRenderTree/chromium/CppBoundClass.h:
3681         * DumpRenderTree/chromium/WebViewHost.cpp:
3682
3683 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3684
3685         Reviewed by Xan Lopez.
3686
3687         [GTK] Compiler warning in Tools/MiniBrowser/main.c
3688         https://bugs.webkit.org/show_bug.cgi?id=59986
3689
3690         Remove a compiler warning.
3691
3692         * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
3693         from complaining.
3694
3695 2011-05-02  Adam Barth  <abarth@webkit.org>
3696
3697         Reviewed by Eric Seidel.
3698
3699         Add runtests_unittest.py
3700         https://bugs.webkit.org/show_bug.cgi?id=59955
3701
3702         I forgot to add this file in a previous patch.
3703
3704         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
3705
3706 2011-05-02  Adam Barth  <abarth@webkit.org>
3707
3708         Change the testing EWS to log failures explicitly to avoid an infinite loop.
3709
3710         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3711
3712 2011-05-02  Adrienne Walker  <enne@google.com>
3713
3714         Unreviewed, fix misspelled contributor name.
3715
3716         * Scripts/webkitpy/common/config/committers.py:
3717
3718 2011-05-02  Adam Barth  <abarth@webkit.org>
3719
3720         Reviewed by Eric Seidel.
3721
3722         cr-linux-ews should run tests
3723         https://bugs.webkit.org/show_bug.cgi?id=59272
3724
3725         This patch turns on testing for the cr-linux-ews.  Yay!
3726
3727         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3728         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3729         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3730         * Scripts/webkitpy/tool/steps/runtests.py:
3731         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3732
3733 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3734
3735         Incorporate a review comment that I mistakenly omitted from my last commit.
3736
3737         * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
3738
3739 2011-05-02  Adam Barth  <abarth@webkit.org>
3740
3741         Reviewed by Eric Seidel.
3742
3743         EWS should report the list of unexpected failures
3744         https://bugs.webkit.org/show_bug.cgi?id=59923
3745
3746         We cache the results of the first layout test results run on the task
3747         so the EWS can grab them later.  Another option is to include them in
3748         the exception that's thrown, but this approach seemed slightly more
3749         aesthetic.
3750
3751         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3752         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3753
3754 2011-05-02  Adam Barth  <abarth@webkit.org>
3755
3756         Reviewed by Eric Seidel.
3757
3758         Add base case for a test-running EWS
3759         https://bugs.webkit.org/show_bug.cgi?id=59920
3760
3761         Later I will subclass this to run the Chromium Linux EWS.
3762
3763         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
3764         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3765         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3766
3767 2011-05-02  Anders Carlsson  <andersca@apple.com>
3768
3769         Build fix.
3770
3771         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3772         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3773
3774 2011-05-02  Nico Weber  <thakis@chromium.org>
3775
3776         Reviewed by Mihai Parparita.
3777
3778         Add --no-webkit2 to the output of "build-webkit -h"
3779         https://bugs.webkit.org/show_bug.cgi?id=59942
3780
3781         * Scripts/build-webkit:
3782
3783 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3784
3785         Reviewed by Xan Lopez.
3786
3787         [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
3788         https://bugs.webkit.org/show_bug.cgi?id=59943
3789
3790         Disable the Ubuntu overlay scrollbar while testing, by injecting the
3791         LIBOVERLAY_SCROLLBAR=0 environment variable.
3792
3793         * Scripts/old-run-webkit-tests:
3794
3795 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
3796
3797         Reviewed by Eric Seidel.
3798
3799         [GTK] editing/selection/select-out-of-editable.html failing after r83967
3800         https://bugs.webkit.org/show_bug.cgi?id=58667
3801
3802         Do not trigger mouse down events when the EventSender knows that a mouse button is
3803         already down. These type of situations can confuse Xvfb and cause dragging failures.
3804
3805         * DumpRenderTree/gtk/EventSender.cpp:
3806         (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
3807         is already down. This can interfere with drags in Xvfb.
3808
3809 2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3810
3811         Reviewed by Csaba Osztrogonác.
3812
3813         DRT sideeffect revealed by r71268.
3814         https://bugs.webkit.org/show_bug.cgi?id=48958
3815
3816         Reset QWebSettings::ZoomTextOnly attribute before all tests. 
3817
3818         Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and 
3819         PageZoomFactor too. It should be done before resetsettings() 
3820         to guarantee resetting QWebSettings::ZoomTextOnly correctly.
3821
3822         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3823         (WebCore::WebPage::resetSettings):
3824         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3825
3826 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3827
3828         Unreviewed, rolling out r85469.
3829         http://trac.webkit.org/changeset/85469
3830         https://bugs.webkit.org/show_bug.cgi?id=59928
3831
3832         Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
3833         bbandix on #webkit).
3834
3835         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
3836         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3837         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3838
3839 2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>
3840
3841         Reviewed by Kenneth Rohde Christiansen.
3842
3843         Cleanup EFL initialization/shutdown in the EWebLauncher
3844         https://bugs.webkit.org/show_bug.cgi?id=59922
3845
3846         Removed ecore_evas_init and edje_init form main function due to they
3847         are also called in the ewk_init. Moved ewk_shutdown to quit function.
3848
3849         * EWebLauncher/main.c:
3850         (quit):
3851         (main):
3852
3853 2011-05-02  Adam Barth  <abarth@webkit.org>
3854
3855         Reviewed by Eric Seidel.
3856
3857         Add base case for a test-running EWS
3858         https://bugs.webkit.org/show_bug.cgi?id=59920
3859
3860         Later I will subclass this to run the Chromium Linux EWS.
3861
3862         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
3863         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3864         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3865
3866 2011-05-02  Adam Barth  <abarth@webkit.org>
3867
3868         Reviewed by Eric Seidel.
3869
3870         Add the ability to skip python and perl unit tests on EC2
3871         https://bugs.webkit.org/show_bug.cgi?id=59918
3872
3873         * Scripts/webkitpy/common/config/ports.py:
3874             - This is slightly ugly, but it's useful...
3875         * Scripts/webkitpy/common/config/ports_unittest.py:
3876         * Scripts/webkitpy/tool/mocktool.py:
3877         * Scripts/webkitpy/tool/steps/runtests.py:
3878
3879 2011-05-02  Adam Barth  <abarth@webkit.org>
3880
3881         Reviewed by Eric Seidel.
3882
3883         webkit-patch --non-interactive is incompatible with new-run-webkit-tests
3884         https://bugs.webkit.org/show_bug.cgi?id=59919
3885
3886         new-run-webkit-tests doesn't support --wait-for-httpd (because it
3887         always waits for HTTPD, as I understand things).  It turns out we're
3888         not really using this flag for anything, so we should just remove it.
3889
3890         * Scripts/webkitpy/tool/steps/runtests.py:
3891         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3892
3893 2011-05-01  Eric Seidel  <eric@webkit.org>
3894
3895         Reviewed by Adam Barth.
3896
3897         The bots should learn from expected failures without having to retry
3898         https://bugs.webkit.org/show_bug.cgi?id=59279
3899
3900         Rather than re-trying the whole patch, we can just check whether we now
3901         expect the failures we see with the patch applied, saving a lot of time.
3902
3903         This patch also teaches the CommitQueue how to reject patches even
3904         when the tree is red using the new unexpected_failures() method on
3905         ExpectedFailures.
3906
3907         Finally in testing we found a bug in ExpectedFailures where it would
3908         "trust" results which had many many failures, due to using an
3909         equal sign instead of a less-than sign.
3910
3911         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
3912         * Scripts/webkitpy/tool/bot/expectedfailures.py
3913         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
3914         * Scripts/webkitpy/tool/bot/patchanalysistask.py
3915
3916
3917 2011-05-02  Adam Barth  <abarth@webkit.org>
3918
3919         Reviewed by Eric Seidel.
3920
3921         workspace.py fails to import ScriptError
3922         https://bugs.webkit.org/show_bug.cgi?id=59915
3923
3924         If the workspace fails to create a zip, webkitpy crashes instead of
3925         handling the error as expected.
3926
3927         * Scripts/webkitpy/common/system/workspace.py:
3928         * Scripts/webkitpy/common/system/workspace_unittest.py:
3929         * Scripts/webkitpy/tool/mocktool.py:
3930
3931 2011-05-01  Adam Barth  <abarth@webkit.org>
3932
3933         Remove unadvertantly added file.
3934
3935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3936
3937 2011-05-01  Adam Barth  <abarth@webkit.org>
3938
3939         Reviewed by Eric Seidel.
3940
3941         expectedfailures.py should report the unexpected failures when asked
3942         https://bugs.webkit.org/show_bug.cgi?id=59916
3943
3944         This information is useful when the EWS runs tests.
3945
3946         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3947         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3948
3949 2011-05-01  Adam Barth  <abarth@webkit.org>
3950
3951         Reviewed by Eric Seidel.
3952
3953         JSONTestResult needs to handle multiple results
3954         https://bugs.webkit.org/show_bug.cgi?id=59269
3955
3956         This case occurs when a test is flaky because NRWT will run the test
3957         twice and report both results as "actual."
3958
3959         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3960         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3961
3962 2011-05-01  Adam Barth  <abarth@webkit.org>
3963
3964         Reviewed by Eric Seidel.
3965
3966         Move checkout/api.py to checkout/checkout.py
3967         https://bugs.webkit.org/show_bug.cgi?id=59906
3968
3969         This is more consistent with Python style.
3970
3971         * Scripts/webkitpy/common/checkout/__init__.py:
3972         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3973         * Scripts/webkitpy/common/host.py:
3974         * Scripts/webkitpy/tool/main.py:
3975
3976 2011-05-01  Eric Seidel  <eric@webkit.org>
3977
3978         Reviewed by Adam Barth.
3979
3980         scm.py should be split into many pieces
3981         https://bugs.webkit.org/show_bug.cgi?id=59908
3982
3983         Forgot an AuthenticationError import.
3984
3985         * Scripts/webkitpy/common/checkout/scm/git.py:
3986         * Scripts/webkitpy/common/checkout/scm/svn.py:
3987
3988 2011-05-01  Arno Renevier  <arno@renevier.net>
3989
3990         Reviewed by Eric Seidel.
3991
3992         wrong exception raised in Lighttpd start method
3993         https://bugs.webkit.org/show_bug.cgi?id=59283
3994
3995         raise standard Exception instead of non existent
3996         google.httpd_utils.HttpdNotStarted
3997
3998         * Scripts/webkitpy/layout_tests/port/http_server.py:
3999
4000 2011-05-01  Eric Seidel  <eric@webkit.org>
4001
4002         Reviewed by Adam Barth.
4003
4004         scm.py should be split into many pieces
4005         https://bugs.webkit.org/show_bug.cgi?id=59908
4006
4007         * Scripts/webkitpy/common/checkout/scm/__init__.py:
4008         * Scripts/webkitpy/common/checkout/scm/commitmessage.py: Added.
4009         * Scripts/webkitpy/common/checkout/scm/git.py: Added.
4010         * Scripts/webkitpy/common/checkout/scm/scm.py:
4011         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4012         * Scripts/webkitpy/common/checkout/scm/svn.py: Added.
4013
4014 2011-05-01  Eric Seidel  <eric@webkit.org>
4015
4016         Reviewed by Adam Barth.
4017
4018         Make most scm.py tests pass in preparation for splitting them up
4019         https://bugs.webkit.org/show_bug.cgi?id=59904
4020
4021         There is one remaining failure:
4022         webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
4023         which identifies a difference between the SVN and Git versions of the
4024         SCM api.  I'm not going to bother fixing that until we split out all
4025         the tests.
4026
4027         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4028
4029 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
4030
4031         [WIN] Unreviewed buildfix after r85440.
4032
4033         * DumpRenderTree/win/UIDelegate.cpp:
4034         (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
4035
4036 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
4037
4038         [WIN] Unreviewed buildfix after r85434.
4039
4040         * DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
4041         * DumpRenderTree/win/UIDelegate.cpp: Ditto.
4042
4043 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
4044
4045         [WIN] Unreviewed buildfix after r85434.
4046
4047         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4048         (FrameLoadDelegate::FrameLoadDelegate):
4049         * DumpRenderTree/win/UIDelegate.cpp:
4050         (DRTUndoManager::DRTUndoManager):
4051         (UIDelegate::UIDelegate):
4052         (UIDelegate::resetUndoManager):
4053
4054 2011-05-01  Eric Seidel  <eric@webkit.org>
4055
4056         Reviewed by Adam Barth.
4057
4058         Move scm.py into its own module in preparation for splitting it up
4059         https://bugs.webkit.org/show_bug.cgi?id=59884
4060
4061         * Scripts/webkitpy/common/checkout/scm/__init__.py: Added.
4062         * Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
4063         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
4064         * Scripts/webkitpy/test/main.py:
4065
4066 2011-05-01  Adam Barth  <abarth@webkit.org>
4067
4068         Reviewed by Eric Seidel.
4069
4070         webkit-patch fails when not run from root
4071         https://bugs.webkit.org/show_bug.cgi?id=59882
4072
4073         We need to set the CWD when running svn so that svn interprets file
4074         paths relative to the root of the working copy.
4075
4076         * Scripts/webkitpy/common/checkout/scm.py:
4077
4078 2011-04-29  Eric Seidel  <eric@webkit.org>
4079
4080         Reviewed by Adam Barth.
4081
4082         land-safely patches should show show their place in the commit-queue
4083         https://bugs.webkit.org/show_bug.cgi?id=59853
4084
4085         This complicated the "should we show the bubbles or the submit-to-ews button"
4086         logic substantially. :(  But now we'll show both the commit-queue position
4087         as well as the submit-to-ews button for land-safely (cq+ only) patches.
4088         Previously we would only show the submit-to-ews button.
4089
4090         * QueueStatusServer/handlers/statusbubble.py:
4091         * QueueStatusServer/templates/statusbubble.html:
4092
4093 2011-04-29  Naoki Takano  <takano.naoki@gmail.com>
4094
4095         Reviewed by Adam Barth.
4096
4097         Add my name to contributers.
4098         https://bugs.webkit.org/show_bug.cgi?id=59854
4099
4100         * Scripts/webkitpy/common/config/committers.py:
4101
4102 2011-04-29  Keith Kyzivat  <keith.kyzivat@nokia.com>
4103
4104         Reviewed by Csaba Osztrogonác.
4105
4106         [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
4107         https://bugs.webkit.org/show_bug.cgi?id=59772
4108
4109         * Tools.pro:
4110
4111 2011-04-29  Stephanie Lewis  <slewis@apple.com>
4112
4113         Rubber-stamped by Adam Roben.   
4114
4115         Remove the production configuration guard since installs only happen in production anyway.  
4116         Works around a bug in Xcode
4117
4118         * DumpRenderTree/mac/PerlSupport/Makefile:
4119
4120 2011-04-29  Adam Roben  <aroben@apple.com>
4121
4122         Remove a PHP setting that is now provided by httpd.conf
4123
4124         r85155 added this setting, but putting it in httpd.conf makes more sense (since the setting
4125         isn't dependent on paths that could be different on each user's machine).
4126
4127         Reviewed by Sam Weinig.
4128
4129         * Scripts/webkitperl/httpd.pm:
4130         (getDefaultConfigForTestDirectory): Removed log_errors setting.
4131
4132 2011-04-29  Jon Lee  <jonlee@apple.com>
4133
4134         Unreviewed, Adding Jon Lee as a committer
4135
4136         * Scripts/webkitpy/common/config/committers.py:
4137
4138 2011-04-28  Ojan Vafai  <ojan@chromium.org>
4139
4140         Reviewed by Tony Chang.
4141
4142         fix pretty_patch_available and wdiff_available
4143         https://bugs.webkit.org/show_bug.cgi?id=59761
4144
4145         These methods rely on the check_* method being called first.
4146         This would only happen when we actually tried to compute a diff,
4147         but computing the diff happens on a different process.
4148         
4149         Also fix setting _wdiff_avialable to True by default.
4150
4151         * Scripts/webkitpy/layout_tests/port/base.py:
4152         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4153         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4154
4155 2011-04-29  Ojan Vafai  <ojan@chromium.org>
4156
4157         Reviewed by Eric Seidel.
4158
4159         exclude skipped tests from the summarized results
4160         https://bugs.webkit.org/show_bug.cgi?id=59813
4161
4162         If we find a need fo skipped tests later, we should either create
4163         a skipped.json file or expose this some other way. As it is, the data
4164         is unused and is hugely bloating the size of full_results.json.
4165
4166         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
4167
4168 2011-04-29  Adam Roben  <aroben@apple.com>
4169
4170         Make DumpRenderTreeSupport get installed when the default configuration is built
4171
4172         The default configuration is Production, but in that case the CONFIGURATION environment
4173         variable is set to the empty string.
4174
4175         Reviewed by Sam Weinig.
4176
4177         * DumpRenderTree/mac/PerlSupport/Makefile: Set CONFIGURATION to Production if it isn't
4178         already set so that later logic that depends on CONFIGURATION having that value will work.
4179
4180 2011-04-29  Dean Jackson  <dino@apple.com>
4181
4182         Reviewed by Simon Fraser.
4183
4184         Add ENABLE macro for WebKitAnimation
4185         https://bugs.webkit.org/show_bug.cgi?id=59729
4186
4187         Add new feature to toggle WebKit Animation API.
4188
4189         * Scripts/build-webkit:
4190
4191 2011-04-29  Sam Weinig  <sam@webkit.org>
4192
4193         Reviewed by Adam Roben.
4194
4195         Make production the default build type for WebKitTestRunner, matching
4196         all other projects.
4197
4198         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4199
4200 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
4201
4202         [wx] Unreviewed build fix, add new directory to the build.
4203
4204         * waf/build/settings.py:
4205
4206 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4207
4208         Reviewed by Martin Robinson.
4209
4210         [GTK] Implement UI client in minibrowser
4211         https://bugs.webkit.org/show_bug.cgi?id=58416
4212
4213         It also allows to open more than one minibrowser window from the
4214         command line.
4215
4216         * MiniBrowser/gtk/BrowserWindow.c:
4217         (browserWindowFinalize):
4218         (browser_window_init):
4219         (browserWindowConstructed):
4220         (createNewPage):
4221         (showPage):
4222         (closePage):
4223         (runJavaScriptAlert):
4224         (browserWindowUIClientInit):
4225         * MiniBrowser/gtk/main.c:
4226         (loadURI):
4227         (main):
4228
4229 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4230
4231         Reviewed by Martin Robinson.
4232
4233         [GTK] Implement page loader client in MiniBrowser
4234         https://bugs.webkit.org/show_bug.cgi?id=58024
4235
4236         A new class BrowserWindow has been added to implement the page
4237         loader client. It makes supporting multiple windows easier. Window
4238         title and url entry are now updated during the loading process.
4239
4240         * MiniBrowser/gtk/BrowserWindow.c: Added.
4241         (activateUriEntryCallback):
4242         (goBackCallback):
4243         (goForwardCallback):
4244         (browserWindowFinalize):
4245         (browserWindowGetProperty):
4246         (browserWindowSetProperty):
4247         (browser_window_init):
4248         (browserWindowConstructed):
4249         (browser_window_class_init):
4250         (browserWindowUpdateTitle):
4251         (browserWindowSetTitle):
4252         (browserWindowSetLoadProgress):
4253         (browserWindowUpdateURL):
4254         (didStartProvisionalLoadForFrame):
4255         (didReceiveServerRedirectForProvisionalLoadForFrame):
4256         (didFailProvisionalLoadWithErrorForFrame):
4257         (didCommitLoadForFrame):
4258         (didFinishDocumentLoadForFrame):
4259         (didFinishLoadForFrame):
4260         (didFailLoadWithErrorForFrame):
4261         (didReceiveTitleForFrame):
4262         (didFirstLayoutForFrame):
4263         (didFirstVisuallyNonEmptyLayoutForFrame):
4264         (didRemoveFrameFromHierarchy):
4265         (didStartProgress):
4266         (didChangeProgress):
4267         (didFinishProgress):
4268         (didBecomeUnresponsive):
4269         (didBecomeResponsive):
4270         (browserWindowLoaderClientInit):
4271         (browser_window_new):
4272         (browser_window_get_view):
4273         * MiniBrowser/gtk/BrowserWindow.h: Added.
4274         * MiniBrowser/gtk/GNUmakefile.am:
4275         * MiniBrowser/gtk/main.c:
4276         (createWindow):
4277
4278 2011-04-28  Stephanie Lewis  <slewis@apple.com>
4279
4280         Reviewed by Mark Rowe.
4281
4282         http://bugs.webkit.org/show_bug.cgi?id=59743
4283         <rdar://problem/9040413> Add an install target for production builds.
4284
4285         * DumpRenderTree/mac/PerlSupport/Makefile:
4286
4287 2011-04-28  Adam Roben  <aroben@apple.com>
4288
4289         Stop and restart ATSServer before each test run on Leopard
4290
4291         This is to work around an ATSServer leak that eventually causes tests
4292         to fail.
4293
4294         Fixes <http://webkit.org/b/51807> <rdar://problem/9273894>
4295         fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
4296         (due to ATSServer leak)
4297
4298         Reviewed by Dan Bernstein.
4299
4300         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4301         (StopATSServer):
4302         (StartATSServer):
4303         Added these new commands to stop and start ATSServer.
4304
4305         (TestFactory.__init__): Stop and start ATSServer on Leopard before running tests.
4306
4307 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
4308
4309         Reviewed by Adam Roben.
4310
4311         add Leopard NRWT bot to the scheduler
4312         https://bugs.webkit.org/show_bug.cgi?id=59766
4313
4314         * BuildSlaveSupport/build.webkit.org-config/config.json:
4315
4316 2011-04-28  Sam Weinig  <sam@webkit.org>
4317
4318         Fix WebKitTestRunner build.
4319
4320         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4321         The Derived Sources target needs a product name.
4322
4323 2011-04-28  Sam Weinig  <sam@webkit.org>
4324
4325         Reviewed by Mark Rowe.
4326
4327         Add install support for WebKitTestRunner.
4328         <rdar://problem/9349055>
4329
4330         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4331         Add missing CompilerVersion.xcconfig.
4332
4333         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
4334         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
4335         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4336         Add install path and tell it not to skip installation.
4337
4338         Add missing CompilerVersion.xcconfig.
4339
4340 2011-04-28  David Levin  <levin@chromium.org>