Dashboard should show performance bots.
[WebKit-https.git] / Tools / ChangeLog
1 2014-09-03  Dana Burkart  <dburkart@apple.com>
2
3         Dashboard should show performance bots.
4         https://bugs.webkit.org/show_bug.cgi?id=136386
5
6         Reviewed by Alexey Proskuryakov.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
9         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
10         (BuildbotIteration.prototype._parseData):
11         Support possible performance failures.
12
13         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
14         New QueueView to manage the way we present performance data.
15
16         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
17         (BuildbotQueue):
18         Support new 'performance' and 'performanceTestName' keys.
19
20
21         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
22         Add performance column to the main page.
23
24         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
25         (WebKitBuildbot):
26         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
27         (body):
28         Make sure everything fits on 13 inch screens.
29
30         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
31
32 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
33
34         GMainLoopSource is exposed to race conditions
35         https://bugs.webkit.org/show_bug.cgi?id=135800
36
37         Reviewed by Carlos Garcia Campos.
38
39         Add a unit test for GMainLoopSource that tests different
40         types of rescheduling tasks on already-active sources.
41
42         * TestWebKitAPI/PlatformGTK.cmake:
43         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
44         (GMainLoopSourceTest::GMainLoopSourceTest):
45         (GMainLoopSourceTest::~GMainLoopSourceTest):
46         (GMainLoopSourceTest::runLoop):
47         (GMainLoopSourceTest::finish):
48         (GMainLoopSourceTest::source):
49         (testGMainLoopSourceBasicRescheduling):
50         (testGMainLoopSourceReentrantRescheduling):
51         (testGMainLoopSourceDifferentThreadRescheduling):
52         (beforeAll):
53         (afterAll):
54         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
55         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
56         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
57         (TestWebKitAPI::GMainLoopSourceTest::finish):
58         (TestWebKitAPI::GMainLoopSourceTest::source):
59         (TestWebKitAPI::TEST):
60
61 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
62
63         Make sure WK1 prefs are initialized in MiniBrowser
64         https://bugs.webkit.org/show_bug.cgi?id=136465
65
66         Reviewed by Tim Horton.
67         
68         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
69         for WK2 windows, to make sure that WebPreferences are updated (to get
70         layer borders to work consistently).
71
72         * MiniBrowser/mac/WK1BrowserWindowController.m:
73         (-[WK1BrowserWindowController awakeFromNib]):
74
75 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
76
77         check-webkit-style should complain about C++ comments in Platform.h
78         https://bugs.webkit.org/show_bug.cgi?id=133802
79
80         Reviewed by Csaba Osztrogonác.
81
82         * Scripts/webkitpy/style/checkers/cpp.py:
83         (check_platformh_comments):
84         (_process_lines):
85         (CppChecker):
86         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
87         (CppStyleTest.test_platformh_comment):
88
89 2014-09-02  Brendan Long  <self@brendanlong.com>
90
91         [Gtk] Make install-dependencies work on Arch Linux
92         https://bugs.webkit.org/show_bug.cgi?id=136374
93
94         Reviewed by Philippe Normand.
95
96         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
97
98 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
99
100         Provide column numbers to DTrace willExecute/didExecute probes
101         https://bugs.webkit.org/show_bug.cgi?id=136434
102
103         Reviewed by Antti Koivisto.
104
105         Create a directory for DTrace scripts. Add an example script that
106         shows how to use static probes provided by JavaScriptCore's profiler.
107
108         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
109
110 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
111
112         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
113         https://bugs.webkit.org/show_bug.cgi?id=136431
114
115         Reviewed by Martin Robinson.
116
117         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
118         Add missing dependencies for librsvg (glib and cairo).
119
120 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
121
122         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
123         https://bugs.webkit.org/show_bug.cgi?id=136425
124
125         Reviewed by Martin Robinson.
126
127         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
128
129 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
130
131         Update my list of email addresses in contributors.json
132         https://bugs.webkit.org/show_bug.cgi?id=136424
133
134         Reviewed by Gyuyoung Kim.
135
136         * Scripts/webkitpy/common/config/contributors.json:
137
138 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
139
140         [RJST] eager-no-cjit should really mean eager
141         https://bugs.webkit.org/show_bug.cgi?id=136407
142
143         Reviewed by Mark Hahnenberg.
144         
145         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
146         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
147         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
148         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
149         threshold setting that NO_CJIT_OPTIONS was currently setting
150         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
151         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
152         
153         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
154
155         * Scripts/run-jsc-stress-tests:
156
157 2014-08-29  Daniel Bates  <dabates@apple.com>
158
159         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
160         https://bugs.webkit.org/show_bug.cgi?id=136388
161
162         Reviewed by David Kilzer.
163
164         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
165         support building a command line tool for the iOS Simulator. You must run this
166         script as root.
167
168         The script uses the xcspec files in the OS X SDK to create xcspec files in the
169         iOS Simulator SDK with the product- and package- type definitions to build a
170         command line tool, if applicable.
171
172         * Scripts/configure-xcode-for-ios-development: Added.
173
174 2014-08-29  Tim Horton  <timothy_horton@apple.com>
175
176         Remove Windows WebKit2 code from TestWebKitAPI
177         https://bugs.webkit.org/show_bug.cgi?id=136385
178
179         Reviewed by Alexey Proskuryakov.
180
181         * TestWebKitAPI/PlatformUtilities.h:
182         * TestWebKitAPI/PlatformWebView.h:
183         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
184         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
185         (TestWebKitAPI::TEST): Deleted.
186         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
187         (TestWebKitAPI::TEST):
188         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
189         (TestWebKitAPI::TEST):
190         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
191         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
192         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
193         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
194         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
195         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
196         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
197
198 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
199
200         [JSC] Some JSC tests are dependent on the machine time zone.
201         https://bugs.webkit.org/show_bug.cgi?id=136363
202
203         Reviewed by Filip Pizlo.
204
205         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
206         Unskip the tests that were skipped on r99580.
207
208 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
209
210         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
211         https://bugs.webkit.org/show_bug.cgi?id=135560
212
213         Reviewed by Gyuyoung Kim.
214
215         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
216
217 2014-08-28  Daniel Bates  <dabates@apple.com>
218
219         [Win] update-webkit should update auxiliary libs by default
220
221         Reviewed by Dan Bernstein.
222
223         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
224         from updating the Windows auxiliary libs by default. We should make update-webkit update the
225         Windows auxiliary libs by default. This will make its behavior match its usage text.
226
227         * Scripts/update-webkit:
228
229 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
230
231         build-webkit --inspector-frontend tries to copy files from old inspector path
232         https://bugs.webkit.org/show_bug.cgi?id=136346
233
234         Reviewed by Timothy Hatcher.
235
236         Remove the old code path for copying inspector resources. It doesn't work.
237         Complain if this option is passed to CMake-based builds.
238
239         * Scripts/build-webkit:
240         * Scripts/webkitdirs.pm:
241         (copyInspectorFrontendFiles): Deleted.
242
243 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
244
245         Dashboard metrics page could show longest stretch of red
246         https://bugs.webkit.org/show_bug.cgi?id=136334
247
248         Reviewed by Sam Weinig.
249
250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
251         (Analyzer.prototype._updateStretchOfRedCounters):
252         (Analyzer.prototype._countPercentageOfGreen):
253         When counting percentage of green, also keep track of how long the page was red.
254
255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
256         (MetricsView.prototype._update.addDivider):
257         (MetricsView.prototype._update.appendQueueResults):
258         Show it in aggregate queues (can't think of a reason to have it in individual ones).
259
260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
261         Changed to use an explicit divider element between green time and performance groups,
262         as there are too many combinations to easily express in CSS.
263
264 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
265
266         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
267         https://bugs.webkit.org/show_bug.cgi?id=136248
268
269         Reviewed by Gustavo Noronha Silva.
270
271         Add new test case for webkit_uri_response_get_http_headers().
272
273         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
274         (testURIResponseHTTPHeaders):
275         (serverCallback):
276         (beforeAll):
277
278 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
279
280         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
281         https://bugs.webkit.org/show_bug.cgi?id=131668
282
283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
284         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
285
286 2014-08-27  Zalan Bujtas  <zalan@apple.com>
287
288         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
289         https://bugs.webkit.org/show_bug.cgi?id=136264
290
291         Reviewed by Simon Fraser.
292         
293         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
294         functions. ->snappedIntSize()/snapSizeToDevicePixel().
295         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
296
297         Covered by existing tests.
298
299         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
300         (TestWebKitAPI::TEST): Deleted.
301
302 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
303
304         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
305         https://bugs.webkit.org/show_bug.cgi?id=131668
306
307         Reviewed by Daniel Bates.
308
309         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
310         to not just hardcode.
311
312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
313         (EWS.prototype.queueStatusURL): Added.
314
315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
316         (EWSQueue.prototype.get statusPageURL): Use the above function.
317         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
318
319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
320         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
321         are no patches in the queue. The popover has other useful information, such as charts
322         link and bot status.
323
324 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
325
326         https://bugs.webkit.org/show_bug.cgi?id=136317
327         Dashboard metrics page sometimes shows 0 for best time
328
329         Reviewed by Tim Horton.
330
331         This also affects regular dashboard display in a good way - iterations that failed
332         due to infrastructure misbehavior will more reliably show up as yellow and not red.
333
334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
335         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
336         updated if we rename steps.
337         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
338         do it once.
339         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
340         that failed e.g. at downloading built archive step are not productive.
341
342 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
343
344         [Win] Unreviewed gardening.
345
346         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
347         of logs assembled into the final build output.
348
349 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
350
351         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
352         https://bugs.webkit.org/show_bug.cgi?id=136196
353
354         Reviewed by Timothy Hatcher.
355
356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
361         A date range picker control with dependencies.
362         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
363         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
364         (it didn't happen again upon re-opening the picker).
365         - Made made style tweaks to match Dashboard UI.
366
367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
368         Don't create objects that are not needed by the given app, and thus are not loaded at all.
369
370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
371         Math to count all the things. Only supports open source tree and trunk at the moment,
372         but written with internal tree and branches in mind.
373
374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
375         Like dashboard Main.js, draws the UI and creates all necessary objects.
376
377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
378         A view for table cells.
379
380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
381         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
382         Metrics page has individual platforms initially scrolled away form the view, so 
383         it needs to scroll down to reveal what's being configured.
384
385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
386         Added Array.prototype.average and Array.prototype.median.
387
388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
389         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
390         in settings mode.
391
392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
393         Additional style rules.
394
395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
396         The metrics page.
397
398 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
399
400         Remove networkinfo watch category in watchlist
401         https://bugs.webkit.org/show_bug.cgi?id=136279
402
403         Reviewed by Alexey Proskuryakov.
404
405         Network info was removed. So, it is not needed anymore.
406
407         * Scripts/webkitpy/common/config/watchlist:
408
409 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
410
411         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
412         https://bugs.webkit.org/show_bug.cgi?id=136281
413
414         Reviewed by Tim Horton.
415
416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
417         Track and expose whether the itertion is being loaded. Made update() a no-op if
418         the iteration is already being loaded.
419
420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
421         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
422         loading everything at once, ask the queue to load a little more. We can always repeat
423         if we still don't have enough data.
424
425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
426         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
427         10 more iterations intelligently.
428
429 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
430
431         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
432         https://bugs.webkit.org/show_bug.cgi?id=136283
433
434         Reviewed by Tim Horton.
435
436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
437         Don't.
438
439 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
440
441         build.webkit.org/dashboard raises an exception after a hidden platform is removed
442         https://bugs.webkit.org/show_bug.cgi?id=136282
443
444         Reviewed by Tim Horton.
445
446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
447         (updateHiddenPlatforms): Check that the platform is still valid.
448
449 2014-08-26  Matt Lilek  <mrl@apple.com>
450
451         Add WebKit SPI to control the navigator.standalone property
452         https://bugs.webkit.org/show_bug.cgi?id=136189
453
454         Reviewed by Andy Estes.
455
456         Add API test for WKPreferences
457
458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
459         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
460         (TEST):
461
462 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
463
464         Remove ENABLE_DRT environment variable to enable SHARED_CORE
465         https://bugs.webkit.org/show_bug.cgi?id=136205
466
467         Reviewed by Andrei Bucur.
468
469         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
470         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
471
472         * Scripts/webkitdirs.pm:
473         (generateBuildSystemFromCMakeProject):
474
475 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
476
477         [Win] Version stamp should include package-level version
478         https://bugs.webkit.org/show_bug.cgi?id=136266
479         <rdar://problem/18134138>
480
481         Reviewed by David Kilzer.
482
483         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
484         tests for the full 3+ digit version.
485         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
486         Confirm that the final output DLL uses the 3+ digit version.
487
488 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
489
490         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
491         https://bugs.webkit.org/show_bug.cgi?id=136258
492         <rdar://problem/18134138>
493
494         Reviewed by Tim Horton.
495
496         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
497         values from passing through the 32-bit OLE_HANDLE data type.
498
499         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
500         (AccessibilityController::rootElement):
501         * DumpRenderTree/win/DumpRenderTree.cpp:
502         (resetWebViewToConsistentStateBeforeTesting):
503         (runTest):
504         (createWebViewAndOffscreenWindow):
505         * DumpRenderTree/win/FrameLoadDelegate.h:
506         (FrameLoadDelegate::didReceiveIcon):
507         * DumpRenderTree/win/TestRunnerWin.cpp:
508         (TestRunner::setWindowIsKey):
509         * DumpRenderTree/win/UIDelegate.cpp:
510         (UIDelegate::trackCustomPopupMenu):
511         (UIDelegate::drawHeaderInRect):
512         (UIDelegate::drawFooterInRect):
513         (UIDelegate::webViewClose):
514         (UIDelegate::webViewFocus):
515         (UIDelegate::webViewSetCursor):
516         (UIDelegate::drawBackground):
517         * DumpRenderTree/win/UIDelegate.h:
518         (UIDelegate::webViewFirstResponder):
519         (UIDelegate::makeFirstResponder):
520         (UIDelegate::contextMenuItemsForElement):
521         (UIDelegate::addCustomMenuDrawingData):
522         (UIDelegate::cleanUpCustomMenuDrawingData):
523         (UIDelegate::webViewLostFocus):
524         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
525         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
526         * WinLauncher/PrintWebUIDelegate.cpp:
527         (PrintWebUIDelegate::drawHeaderInRect):
528         (PrintWebUIDelegate::drawFooterInRect):
529         * WinLauncher/PrintWebUIDelegate.h:
530         (PrintWebUIDelegate::webViewFirstResponder):
531         (PrintWebUIDelegate::makeFirstResponder):
532         (PrintWebUIDelegate::contextMenuItemsForElement):
533         (PrintWebUIDelegate::trackCustomPopupMenu):
534         (PrintWebUIDelegate::addCustomMenuDrawingData):
535         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
536         * WinLauncher/WinLauncher.cpp:
537         (WinLauncher::prepareViews):
538         * WinLauncher/WinLauncherWebHost.h:
539         (WinLauncherWebHost::didReceiveIcon):
540
541 2014-08-26  Daniel Bates  <dabates@apple.com>
542
543         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
544
545         Rubber-stamped by Tim Horton.
546
547         The Windows and iOS ports are the only ports that make use of WebCore headers
548         in DumpRenderTree.
549
550         * DumpRenderTree/config.h:
551
552 2014-08-26  Dan Bernstein  <mitz@apple.com>
553
554         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
555         https://bugs.webkit.org/show_bug.cgi?id=136254
556
557         Reviewed by Tim Horton.
558
559         * Scripts/webkitdirs.pm:
560         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
561         not the invoking script.
562
563 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
564
565         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
566         https://bugs.webkit.org/show_bug.cgi?id=136127
567
568         Reviewed by Gyuyoung Kim.
569
570         Add espeak dependency.
571
572         * efl/install-dependencies:
573
574 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
575
576         Remove a little more accidentally landed code from r172891.
577
578         iteration.branch also wasn't meant to be landed.
579
580         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
581         (BuildbotIteration.prototype._parseData):
582
583 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
584
585         REGRESSION (r172891): Internal dashboard is broken.
586
587         Removing some accidentally landed code - I needed "changes" for another patch, but
588         not here, and then I decided to not use it anyway.
589
590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
591         (BuildbotIteration.prototype._parseData):
592
593 2014-08-25  Daniel Bates  <dabates@apple.com>
594
595         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
596         (https://bugs.webkit.org/show_bug.cgi?id=136108)
597
598         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
599         so that we can compile DumpRenderTree for iOS.
600
601         * DumpRenderTree/config.h:
602
603 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
604
605         Make build.webkit.org/dashboard work with changeset_show_files=location
606         https://bugs.webkit.org/show_bug.cgi?id=136237
607
608         Reviewed by Tim Horton.
609
610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
611         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
612         from description before getting title, and also actually parse the location into
613         result object when available.
614
615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
616         (String.prototype.startsWith): Added.
617
618 2014-08-25  Tanay C  <tanay.c@samsung.com>
619
620         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
621         https://bugs.webkit.org/show_bug.cgi?id=135795
622
623         Reviewed by Gyuyoung Kim.
624
625         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
626         (history_list_hide): Hiding and dereferencing the history list and items
627         (on_key_down):
628         (on_mouse_down):
629         (on_back_button_clicked): Early return for longpress 
630         (on_forward_button_clicked): Early return for longpress 
631         (list_item_label_get): Populate item labels
632         (on_list_item_select): Navigates on selection from history list
633         (navigation_button_longpress_process): Populates the history list and displays it
634         (on_forward_button_longpress):
635         (on_back_button_longpress):
636         (window_create): Add the widget for history list
637
638 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
639
640         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
641         https://bugs.webkit.org/show_bug.cgi?id=136152
642
643         Reviewed by Philippe Normand.
644
645         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
646         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
647         Cherry pick upstream patches daa194 and 4e3d101.
648
649 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
650
651         GenericHashTraits::peek() is producing copies of passed-in temporary values
652         https://bugs.webkit.org/show_bug.cgi?id=131461
653
654         Reviewed by Darin Adler.
655
656         Add a test case that checks the number of copies and moves of the mapped objects
657         when calling HashMap::get(). Exactly one copy of the mapped value should be
658         performed when there exists a value that is mapped to the specified key, and
659         exactly one move and no copies of the empty value should be performed when there
660         isn't any mapped value for the specified key.
661
662         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
663         (CopyMoveCounter::TestingScope::TestingScope):
664         (CopyMoveCounter::CopyMoveCounter):
665         (CopyMoveCounter::operator=):
666         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
667         (TestWebKitAPI::TEST):
668
669 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
670
671         [EFL] Introduce DEVELOPER_MODE
672         https://bugs.webkit.org/show_bug.cgi?id=135884
673
674         Reviewed by Gyuyoung Kim.
675
676         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
677         (generateBuildSystemFromCMakeProject):
678
679 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
680
681         build.webkit.org/dashboard unnecessarily loads results of hidden queues
682         https://bugs.webkit.org/show_bug.cgi?id=136195
683
684         Reviewed by Tim Horton.
685
686         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
687
688         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
689         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
690         Don't start an update just because a queue object was created. Periodic updates
691         are triggered by views, so it only makes sense to do the same for the initial update.
692
693         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
694         Now that Trac object doesn't auto-load, start loading here.
695
696         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
697         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
698         a data member added by subclasses later. With this.platform being undefined, it
699         always looked like this queue was not hidden.
700         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
701
702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
703         (Trac): Don't load anything here, the client may choose to load a custom date range.
704         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
705
706 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
707
708         build.webkit.org/dashboard: Further improve Trac loading
709         https://bugs.webkit.org/show_bug.cgi?id=136174
710
711         Reviewed by Timothy Hatcher.
712
713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
714         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
715         error, the oldest commit within the range wasn't returned. The correct argument for
716         "no limit" is 0.
717         (Trac.prototype.load): Added a function to load a specific time range.
718         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
719         positioned with regards to ones that were already known.
720
721 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
722
723         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
724         https://bugs.webkit.org/show_bug.cgi?id=136182
725
726         Reviewed by Timothy Hatcher.
727
728         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
729         Make it possible to create a complete BuildbotIteration object with JSON, not only by
730         loading data from the network.
731
732         An iteration has three states:
733         1. Just created, it only knows the revision, and whether it's already finished.
734         BuildbotIteration constructor used to create these.
735         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
736         3. Data about tests is fetched.
737
738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
739         Make it possible to pull all data from a buildbot queue. This needs to be better
740         optimized eventually, as it's somewhat slow.
741
742 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
743
744         Remove LevelDB.
745         https://bugs.webkit.org/show_bug.cgi?id=136170
746
747         Reviewed by Gyuyoung Kim.
748
749         * Scripts/webkitpy/common/config/watchlist:
750         * Scripts/webkitpy/style/checker.py:
751
752 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
753
754         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
755         https://bugs.webkit.org/show_bug.cgi?id=136153
756
757         Reviewed by Martin Robinson.
758
759         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
760
761 2014-08-21  Alex Christensen  <achristensen@webkit.org>
762
763         [Win] Another unreviewed build fix.
764
765         * DumpRenderTree/config.h:
766         Defined WEBCORE_EXPORT on Windows.
767
768 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
769
770         [EFL][WK2] Minibrowser : Add stop button to abort page load
771         https://bugs.webkit.org/show_bug.cgi?id=136122
772
773         Reviewed by Gyuyoung Kim.
774
775         * MiniBrowser/efl/main.c:
776         (on_key_down):
777         (on_stop_button_clicked): Callback for stop button press.
778         (window_create):
779
780 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
781
782         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
783         https://bugs.webkit.org/show_bug.cgi?id=134070
784
785         Reviewed by Martin Robinson.
786
787         * Scripts/webkitpy/port/base.py:
788         (Port.__init__): Set default _jhbuild_wrapper variable.
789         (Port._should_use_jhbuild): Implement generic check.
790         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
791         to make it consistent with the other ports.
792         * Scripts/webkitpy/port/gtk.py:
793         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
794         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
795         querying the jhbuild with printenv. Also check that the path contains
796         the libraries we expect. Preload this path only for XvfbDriver.
797         * Scripts/webkitpy/port/xvfbdriver.py:
798         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
799         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
800         configured at setup_environ_for_server()
801         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
802         (XvfbDriverTest.make_driver): Get the port default environment.
803         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
804         should include the environment that is passed when running Xvfb.
805         (XvfbDriverTest.test_start_pixel_tests): Ditto.
806         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
807         (XvfbDriverTest.test_start_next_worker): Ditto.
808         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
809         prevent future problems when the version is raised. Add also a
810         comment with a warning.
811         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
812         that has the llvm optimized Gallium libGL libraries.
813
814 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
815
816         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
817         https://bugs.webkit.org/show_bug.cgi?id=136125
818
819         Reviewed by Csaba Osztrogonác.
820
821         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
822         (RunLLINTCLoopTests.countFailures):
823         (Run32bitJSCTests.countFailures):
824         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
825         (RunLLINTCLoopTestsTest):
826         (RunLLINTCLoopTestsTest.assertResults):
827         (RunLLINTCLoopTestsTest.test_failures):
828         (RunLLINTCLoopTestsTest.test_failure):
829         (RunLLINTCLoopTestsTest.test_no_failure):
830         (Run32bitJSCTestsTest):
831         (Run32bitJSCTestsTest.assertResults):
832         (Run32bitJSCTestsTest.test_failures):
833         (Run32bitJSCTestsTest.test_failure):
834         (Run32bitJSCTestsTest.test_no_failure):
835
836 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
837
838         Unreviewed, EFL build fix since r172814.
839
840         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
841
842 2014-08-20  Alex Christensen  <achristensen@webkit.org>
843
844         Introducing WEBCORE_EXPORT macro.
845         https://bugs.webkit.org/show_bug.cgi?id=136108
846
847         Reviewed by Antti Koivisto.
848
849         * TestWebKitAPI/config.h:
850         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
851
852 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
853
854         import-w3c-tests doesn't import .svg support files
855         https://bugs.webkit.org/show_bug.cgi?id=135928
856
857         Reviewed by Bem Jones-Bey.
858
859         This patch fixes the W3C import script to not treat all
860         files with an xml mimetype as convertible tests, which
861         was causing SVG support files to not be imported.
862
863         * Scripts/webkitpy/w3c/test_importer.py:
864         (TestImporter.find_importable_tests):
865
866 2014-08-19  Dan Bernstein  <mitz@apple.com>
867
868         update-webkit should not check for the presence of Apple’s Internal directory
869         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
870
871         Reviewed by Tim Horton.
872
873         * Scripts/update-webkit:
874
875 2014-08-19  Zalan Bujtas  <zalan@apple.com>
876
877         Remove ENABLE(SUBPIXEL_LAYOUT).
878         https://bugs.webkit.org/show_bug.cgi?id=136077
879
880         Reviewed by Simon Fraser.
881
882         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
883
884         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
885
886 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
887
888         Let the caller define JSC_timeout for run-javascriptcore-tests
889         https://bugs.webkit.org/show_bug.cgi?id=136068
890
891         Reviewed by Csaba Osztrogonác.
892
893         Keep the 60 second timeout for jsc tests as the default setting but
894         don't override the value of JSC_timeout if already set.
895
896         * Scripts/run-javascriptcore-tests:
897
898 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
899
900         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
901         https://bugs.webkit.org/show_bug.cgi?id=136039
902
903         Reviewed by Csaba Osztrogonác.
904
905         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
906         (RunJavaScriptCoreTests.commandComplete):
907         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
908         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
909         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
910         (RunJavaScriptCoreTestsTest):
911         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
912         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
913         (test_layout_failure_new_output): Deleted.
914         (test_layout_crash_new_output): Deleted.
915         (test_mozilla_and_layout_failure_new_output): Deleted.
916         (test_jsc_stress_failure_new_output): Deleted.
917         (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
918
919 2014-08-19  Alexey Proskuryakov  <ap@apple.com>
920
921         build.webkit.org/dashboard should not request 50 revisions from trac each time
922         https://bugs.webkit.org/show_bug.cgi?id=127130
923
924         build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
925         https://bugs.webkit.org/show_bug.cgi?id=127131
926
927         Reviewed by Timothy Hatcher.
928
929         Turns out that requesting 50 builds is much slower than requesting by date - even
930         if the request ends up returning more than 50 results. There is no way to only
931         request updates, but this change brings request time from 6-8 seconds down to
932         less than a second.
933
934         This patch generalizes date handling for later use in metrics code. As part of the
935         rewrite, I made newly fetched data update author e-mail in previously fetched
936         revisions, as it changes after commit queue first lands.
937
938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
939         Updated for event rename. I changed the trac event to not contain the list of new
940         commits, as we now sometimes update old commits, and that couldn't be expressed
941         in event data. We never used the list anywhere in the first place.
942
943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
944         (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
945         without arguments, return commits for today and yesterday.
946         (Trac.prototype._loaded):
947         (Trac.prototype.update): Moved the function for processing loaded results out of
948         here for clarity, and also because I'm going to have a separate loading code path
949         for metrics.
950
951 2014-08-18  Dan Bernstein  <mitz@apple.com>
952
953         Added an update-webkit option to override the ../Internal check.
954         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
955
956         Reviewed by Tim Horton.
957
958         * Scripts/update-webkit:
959         Added an explicit --internal option to control updating ../Internal, defaulting to whether
960         ../Internal exists.
961         (runSvnUpdate): Moved to webkitdirs.pm.
962         (runGitUpdate): Ditto.
963         * Scripts/webkitdirs.pm:
964         (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
965         (runGitUpdate): Moved from update-webkit.
966
967 2014-08-18  Pratik Solanki  <psolanki@apple.com>
968
969         Make update-webkit more lenient for pure git svn repositories
970         https://bugs.webkit.org/show_bug.cgi?id=135805
971
972         Reviewed by Oliver Hunt.
973
974         Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
975         call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
976         provide an optimization when you have a git repository setup. We should not fail if the
977         git setup does not have svn-remote.svn.fetch set.
978
979         * Scripts/update-webkit:
980         (runGitUpdate):
981
982 2014-08-18  Simon Fraser  <simon.fraser@apple.com>
983
984         Enable Web Inspector in MiniBrowser WK2 windows
985         https://bugs.webkit.org/show_bug.cgi?id=136045
986
987         Reviewed by Tim Horton.
988         
989         Set the pref to enable developer extras for all WK2 windows.
990
991         * MiniBrowser/mac/WK2BrowserWindowController.m:
992         (-[WK2BrowserWindowController awakeFromNib]):
993
994 2014-08-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
995
996         master.cfg should handle special return codes of run-perf-tests
997         https://bugs.webkit.org/show_bug.cgi?id=135974
998
999         Reviewed by Ryosuke Niwa.
1000
1001         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1002         (RunAndUploadPerfTests.getText2):
1003         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1004         (RunAndUploadPerfTestsTest):
1005         (RunAndUploadPerfTestsTest.assertResults):
1006         (RunAndUploadPerfTestsTest.test_tests_failed):
1007         (RunAndUploadPerfTestsTest.test_build_bad_build):
1008         (RunAndUploadPerfTestsTest.test_build_bad_source_json):
1009         (RunAndUploadPerfTestsTest.test_build_bad_marge):
1010         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
1011         (RunAndUploadPerfTestsTest.test_build_bad_preparation):
1012
1013 2014-08-17  Brent Fulgham  <bfulgham@apple.com>
1014
1015         [Win] Unreviewed change to force rebuild
1016         (plus drive-by add an accessor I wanted for
1017         some future tooling).
1018
1019         * WinLauncher/WinLauncher.h:
1020         (WinLauncher::webView): Added.
1021
1022 2014-08-16  Mark Hahnenberg  <mhahnenb@gmail.com>
1023
1024         Update contributors.json for my new email
1025         https://bugs.webkit.org/show_bug.cgi?id=136021
1026
1027         Reviewed by Filip Pizlo.
1028
1029         * Scripts/webkitpy/common/config/contributors.json:
1030
1031 2014-08-15  Alexey Proskuryakov  <ap@apple.com>
1032
1033         REGRESSION (r172660): WebKit2.TerminateTwice asserts
1034         https://bugs.webkit.org/show_bug.cgi?id=136012
1035
1036         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
1037
1038 2014-08-15  Ryuan Choi  <ryuan.choi@samsung.com>
1039
1040         Unreviewed build fix attempt on the CMake based pots since r172665
1041
1042         * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
1043
1044 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
1045
1046         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
1047         https://bugs.webkit.org/show_bug.cgi?id=131596
1048
1049         Reviewed by Joseph Pecoraro.
1050
1051         * Scripts/run-inspector-generator-tests: Added.
1052         (main):
1053         * Scripts/webkitpy/inspector/__init__.py: Added.
1054         * Scripts/webkitpy/inspector/main.py: Added.
1055         (InspectorGeneratorTests):
1056         (InspectorGeneratorTests.__init__):
1057         (InspectorGeneratorTests.generate_from_json):
1058         (InspectorGeneratorTests.write_error_file):
1059         (InspectorGeneratorTests.detect_changes):
1060         (InspectorGeneratorTests.run_tests):
1061         (InspectorGeneratorTests.main):
1062
1063 2014-08-15  Rebecca Hauck  <rhauck@adobe.com>
1064
1065         run-webkit-tests should skip 'support' directories
1066         https://bugs.webkit.org/show_bug.cgi?id=135910
1067
1068         Reviewed by Bem Jones-Bey.
1069         
1070         This patch adds the 'support' directory to the list
1071         of dirs to skip when looking for runnable tests.
1072         the W3C uses this name for support files, so tests
1073         imported from the W3C will not work without this change
1074         or without many edits.
1075
1076         * Scripts/webkitpy/port/base.py:
1077         (Port._real_tests):
1078
1079 2014-08-14  Brent Fulgham  <bfulgham@apple.com>
1080
1081         [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
1082         https://bugs.webkit.org/show_bug.cgi?id=135948
1083         <rdar://problem/18022221>
1084
1085         Reviewed by David Kilzer.
1086
1087         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
1088         for RC_ProjectBuildVersion.
1089
1090 2014-08-05  David Farler  <dfarler@apple.com>
1091
1092         [iOS] run-webkit-tests runs webkit-build-directory on every test
1093         https://bugs.webkit.org/show_bug.cgi?id=135409
1094
1095         Reviewed by Daniel Bates.
1096
1097         * Scripts/webkitpy/port/ios.py:
1098         (IOSSimulatorPort.__init__): Cache Mac build directory.
1099         (IOSSimulatorPort.relay_path): Use cached build directory.
1100         (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
1101
1102 2014-08-14  Zan Dobersek  <zdobersek@igalia.com>
1103
1104         Initialize a separate variable (TestWTF_SOURCES) with the list of files
1105         that are built into the TestWTF executable and move it above the platform-specific
1106         config file inclusion. This makes it possible to add platform-specific files to that
1107         list (e.g. GUniquePtr.cpp for the GTK port).
1108
1109         Rubber-stamped by Carlos Garcia Campos.
1110
1111         * TestWebKitAPI/CMakeLists.txt:
1112         * TestWebKitAPI/PlatformGTK.cmake:
1113
1114 2014-08-13  Akos Kiss  <akiss@inf.u-szeged.hu>
1115
1116         [EFL] Bump up and patch dependencies to allow building for aarch64
1117         https://bugs.webkit.org/show_bug.cgi?id=135885
1118
1119         Reviewed by Gyuyoung Kim.
1120
1121         The currently used versions of pixman, libffi, glib, glib-networking,
1122         and fontconfig fail to configure for aarch64, so they are bumped up to
1123         the latest stable version.
1124
1125         Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
1126         ARM NEON assembly support, so it is patched with a change that has been
1127         accepted by upstream.
1128
1129         * efl/jhbuild.modules:
1130         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
1131
1132 2014-08-13  Mark Rowe  <mrowe@apple.com>
1133
1134         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
1135
1136         Reviewed by Darin Adler.
1137
1138         * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
1139
1140 2014-08-13  Alex Christensen  <achristensen@webkit.org>
1141
1142         Progress towards CMake on Mac.
1143         https://bugs.webkit.org/show_bug.cgi?id=135819
1144
1145         Reviewed by Laszlo Gombos.
1146
1147         * WebKitTestRunner/CMakeLists.txt:
1148         Added new cpp parameter for the extension of the generated files.
1149
1150 2014-08-13  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
1151
1152         Make check-webkit-style run sort-export-file
1153         https://bugs.webkit.org/show_bug.cgi?id=135877
1154
1155         Reviewed by Csaba Osztrogonác.
1156
1157         * Scripts/webkitpy/style/checker.py:
1158         (_all_categories):
1159         (FileType):
1160         (CheckerDispatcher._file_type):
1161         (CheckerDispatcher._create_checker):
1162         * Scripts/webkitpy/style/checkers/exportfile.py: Added.
1163         (ExportFileChecker):
1164         (ExportFileChecker.__init__):
1165         (ExportFileChecker.check):
1166         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
1167         (handle_style_error):
1168         (MockErrorHandler):
1169         (MockErrorHandler.__init__):
1170         (MockErrorHandler.turn_off_line_filtering):
1171         (MockErrorHandler.__call__):
1172         (ExportFileTest):
1173         (ExportFileTest.setUp):
1174         (ExportFileTest.tearDown):
1175         (ExportFileTest.test_sorted):
1176         (ExportFileTest.test_non_sorted):
1177         (ExportFileTest.test_parse_error):
1178
1179 2014-08-13  Jinwoo Song  <jinwoo7.song@samsung.com>
1180
1181         [EFL] Sets the persistent storage for cookies in MiniBrowser
1182         https://bugs.webkit.org/show_bug.cgi?id=135875
1183
1184         Reviewed by Gyuyoung Kim.
1185
1186         In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
1187         for non-session cookies can be stored persistently.
1188
1189         * MiniBrowser/efl/main.c:
1190         (elm_main):
1191
1192 2014-08-12  Daniel Bates  <dabates@apple.com>
1193
1194         [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
1195         https://bugs.webkit.org/show_bug.cgi?id=135845
1196
1197         Reviewed by Andy Estes.
1198
1199         Towards building the iOS WebKit port using the public SDK, remove the logic
1200         added to build-webkit to build projects WebKitSystemInterface and
1201         WebKitAdditions when building the iOS WebKit port.
1202
1203         * Scripts/build-webkit:
1204
1205 2014-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1206
1207         [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
1208         https://bugs.webkit.org/show_bug.cgi?id=135850
1209
1210         Reviewed by Philippe Normand.
1211
1212         After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
1213         Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
1214
1215         * gtk/install-dependencies:
1216
1217 2014-08-12  Eduardo Lima Mitev  <elima@igalia.com>
1218
1219         [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
1220         https://bugs.webkit.org/show_bug.cgi?id=135798
1221
1222         Reviewed by Philippe Normand.
1223
1224         * Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to
1225             toggle SUBTLE_CRYPTO feature.
1226
1227 2014-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
1228
1229         [EFL] Disable ecore logs about bad fd
1230         https://bugs.webkit.org/show_bug.cgi?id=135831
1231
1232         Reviewed by Gyuyoung Kim.
1233
1234         ecore checks EBADF and prints the warnings.
1235         But, it looks noise in layout test because it's not webkit issue.
1236         This patch disables it until we found right solution.
1237
1238         * efl/jhbuild.modules:
1239         * efl/patches/ecore_remove_warnings.patch: Added.
1240
1241 2014-08-12  Shivakumar JM  <shiva.jm@samsung.com>
1242
1243         [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
1244         https://bugs.webkit.org/show_bug.cgi?id=135791
1245
1246         Reviewed by Gyuyoung Kim.
1247
1248         Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
1249         user.
1250
1251         * MiniBrowser/efl/main.c:
1252         (on_download_request):
1253
1254 2014-08-11  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1255
1256         [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
1257         https://bugs.webkit.org/show_bug.cgi?id=135606
1258
1259         Reviewed by Gyuyoung Kim.
1260
1261         TestWebKitAPI does not initialize EWebkit using ewk_init()
1262         which is not recommended.
1263
1264         * TestWebKitAPI/efl/PlatformWebView.cpp:
1265         (TestWebKitAPI::createEcoreEvas):
1266         Renamed from initEcoreEvas() since it doesn't not initialize
1267         ecore evas.
1268
1269         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1270         Call ewk_init() that initalizes all EFL modules needed by EWebKit
1271         instead of ecore_evas_init() only.
1272
1273         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1274         Call ewk_shutdown() to finalize EWebkit.
1275         (TestWebKitAPI::initEcoreEvas): Deleted.
1276
1277 2014-08-11  Dan Bernstein  <mitz@apple.com>
1278
1279         Added an update-webkit option to update the auxiliary libraries or not.
1280         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
1281
1282         Reviewed by Tim Horton.
1283
1284         * Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless
1285         an Internal directory exists alongside the WebKit root directory.
1286
1287 2014-08-11  Bem Jones-Bey  <bjonesbe@adobe.com>
1288
1289         Remove hg changeset from w3c-import.log
1290         https://bugs.webkit.org/show_bug.cgi?id=135735
1291
1292         Reviewed by Ryosuke Niwa.
1293
1294         Since the csswg's test suite is now accessible via github and it is
1295         possible to push changes by creating github pull requests, the hg
1296         changeset makes less sense, as many people will just use a clone of
1297         the git repo. There isn't an obvious thing to replace it with, so
1298         might as well remove it for now instead of having it just be set to
1299         UNKNOWN in imports.
1300
1301         This also adds a pointer to the github repo in the generated comments
1302         in the w3c-import.log.
1303
1304         * Scripts/webkitpy/w3c/test_importer.py:
1305         (TestImporter.__init__): Remove changeset handling.
1306         (TestImporter.do_import): Ditto.
1307         (TestImporter.write_import_log): Ditto.
1308         (TestImporter.load_changeset): Deleted.
1309
1310 2014-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1311
1312         Unreviewed. Fix GTK+ make distcheck.
1313
1314         * gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.
1315
1316 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
1317
1318         Unbreak webkitpy unit tests by checking for the existence of the image diff template
1319         file before trying to open it (as the tests do for results.html).
1320
1321         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1322         (TestResultWriter.write_image_diff_files):
1323
1324 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
1325
1326         Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
1327         https://bugs.webkit.org/show_bug.cgi?id=135780
1328
1329         Reviewed by Dan Bates.
1330         
1331         Pull the HTML for the image diff file into a separate file, for easier hackability.
1332
1333         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1334         (TestResultWriter.write_image_diff_files):
1335
1336 2014-08-08  Mark Lam  <mark.lam@apple.com>
1337
1338         Gardening: fix Windows build after r172259.
1339
1340         Not reviewed.
1341
1342         * DumpRenderTree/win/TestRunnerWin.cpp:
1343         (TestRunner::addMockSpeechInputResult): Deleted.
1344         (TestRunner::setMockSpeechInputDumpRect): Deleted.
1345         (TestRunner::startSpeechInput): Deleted.
1346
1347 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
1348
1349         make clean does not work in OpenSource, fails in WebKitLibraries
1350         https://bugs.webkit.org/show_bug.cgi?id=135734
1351
1352         Reviewed by David Kilzer.
1353
1354         * Scripts/copy-webkitlibraries-to-product-directory:
1355         Add a --clean switch that removes possible WebKitSystemInterface
1356         and LLVM libraries and headers that may have been copied to the
1357         product directory.
1358
1359 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
1360
1361         commit-log-message has extra blank line at the top of pre-populated message
1362         https://bugs.webkit.org/show_bug.cgi?id=135744
1363
1364         Reviewed by Csaba Osztrogonác.
1365
1366         Do not add a blank leading line in single ChangeLog commit messages.
1367
1368         * Scripts/commit-log-editor:
1369         (createCommitMessage):
1370         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1371         (test_commit_message_for_one_reviewed_changelog):
1372         (test_commit_message_for_one_rollout_changelog):
1373
1374 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
1375
1376         [Win] Unreviewed gardening.
1377
1378         Have 'Assemble Build Logs' step work properly for DebugSuffix target
1379         (both 32-bit and 64-bit).
1380
1381         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1382
1383 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
1384
1385         Get rid of INPUT_SPEECH
1386         https://bugs.webkit.org/show_bug.cgi?id=135672
1387
1388         Reviewed by Andreas Kling.
1389
1390         * DumpRenderTree/TestRunner.cpp:
1391         (TestRunner::staticFunctions):
1392         (addMockSpeechInputResultCallback): Deleted.
1393         (setMockSpeechInputDumpRectCallback): Deleted.
1394         * DumpRenderTree/TestRunner.h:
1395         * DumpRenderTree/mac/TestRunnerMac.mm:
1396         (TestRunner::addMockSpeechInputResult): Deleted.
1397         (TestRunner::setMockSpeechInputDumpRect): Deleted.
1398         (TestRunner::startSpeechInput): Deleted.
1399
1400 2014-08-07  Bem Jones-Bey  <bjonesbe@adobe.com>
1401
1402         The support directory shouldn't be skipped unconditionally in test import
1403         https://bugs.webkit.org/show_bug.cgi?id=135660
1404
1405         Reviewed by Ryosuke Niwa.
1406
1407         The 'DIRS_TO_SKIP' should only be skipped when in the root directory
1408         of the test repo, as that's the only time they are special. In
1409         addition, instead of hardcoding .hg and .git as special, skip all
1410         directories that begin with '.', just like with files that begin with '.'.
1411         
1412         In order to make this work, the root directory must always be
1413         passed in, so the interface to the script has been changed to take the
1414         root directory, and if one wants to only import a subset of the tests,
1415         a new -t option can be used to limit the tests imported.
1416
1417         * Scripts/webkitpy/w3c/test_importer.py:
1418         (main): Remove repo_dir command line argument.
1419         (parse_args): Add -t option and set expected non-option args to 1.
1420         (TestImporter.__init__): Remove repo_dir.
1421         (TestImporter.do_import): Handle the varying number of import
1422             directories.
1423         (TestImporter.should_keep_subdir): Helper for find_importable_tests to
1424             determine if a subdirectory should be skipped.
1425         (TestImporter.find_importable_tests): Filter directories using new
1426             helper.
1427         (TestImporter.import_tests): Remove use of repo_dir.
1428         (TestImporter.setup_destination_directory): Unused, Deleted. 
1429         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1430         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
1431             new API.
1432         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1433
1434 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1435
1436         [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
1437         https://bugs.webkit.org/show_bug.cgi?id=135695
1438
1439         Reviewed by Gustavo Noronha Silva.
1440
1441         Use WebKitNavigationAction API.
1442
1443         * MiniBrowser/gtk/BrowserWindow.c:
1444         (webViewDecidePolicy):
1445         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1446         (testNavigationPolicy):
1447
1448 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1449
1450         [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
1451         https://bugs.webkit.org/show_bug.cgi?id=135696
1452
1453         Reviewed by Sergio Villar Senin.
1454
1455         Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
1456         exception (that happens when testing the script hasn't been injected) the JavaScript
1457         result is NULL.
1458
1459         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1460         (isScriptInjectedForURLAtPath):
1461
1462 2014-08-07  Csaba Osztrogonác  <ossy@webkit.org>
1463
1464         [GTK] Disable IndexedDB
1465         https://bugs.webkit.org/show_bug.cgi?id=135692
1466
1467         Reviewed by Carlos Garcia Campos.
1468
1469         * Scripts/webkitperl/FeatureList.pm:
1470
1471 2014-08-06  Dean Jackson  <dino@apple.com>
1472
1473         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
1474         https://bugs.webkit.org/show_bug.cgi?id=135675
1475
1476         Reviewed by Sam Weinig.
1477
1478         * Scripts/webkitperl/FeatureList.pm:
1479
1480 2014-08-06  David Farler  <dfarler@apple.com>
1481
1482         Set DSYMUTIL_NUM_THREADS to the number of logical cores
1483         https://bugs.webkit.org/show_bug.cgi?id=135655
1484
1485         Reviewed by Mark Rowe.
1486
1487         * Scripts/webkitdirs.pm:
1488         (buildXCodeProject): Set before calling xcodebuild.
1489
1490 2014-08-06  Adrian Perez de Castro  <aperez@igalia.com>
1491
1492         [GTK] Add support for user scripts to WebKitUserContentManager
1493         https://bugs.webkit.org/show_bug.cgi?id=134738
1494
1495         Reviewed by Carlos Garcia Campos.
1496
1497         Add support for user scripts, to complement the user style sheet
1498         support already present in WebKitUserContentManager. Most of the
1499         moving parts are already present, so this just adds a boxed type
1500         for user scripts (WebKitUserScript) and the corresponding methods
1501         to add and remove scripts from the WebKitUserContentManager.
1502
1503         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1504         Add test case for injected user scripts.
1505         (isScriptInjectedForURLAtPath):
1506         (removeOldInjectedContentAndResetLists):
1507         (testUserContentManagerInjectedStyleSheet):
1508         (testUserContentManagerInjectedScript):
1509         (beforeAll):
1510         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
1511
1512 2014-08-06  Philippe Normand  <pnormand@igalia.com>
1513
1514         [GTK] run-launcher --gtk still fails
1515         https://bugs.webkit.org/show_bug.cgi?id=135642
1516
1517         Reviewed by Carlos Garcia Campos.
1518
1519         The perl interpreter is confused by the combination of string
1520         concatenation and a ternary in the same line. Using a separate
1521         variable to determine the library file extension fixes this issue.
1522
1523         * Scripts/webkitdirs.pm:
1524         (builtDylibPathForName): Use an intermediate variable, it's more
1525         readable and unambiguous.
1526
1527 2014-07-29  Filip Pizlo  <fpizlo@apple.com>
1528
1529         Merge r170564, r170571, r170604, r170628, r170672, r170680, r170724, r170728, r170729, r170819, r170821, r170836, r170855, r170860, r170890, r170907, r170929, r171052, r171106, r171152, r171153, r171214 from ftlopt.
1530
1531     2014-06-25  Filip Pizlo  <fpizlo@apple.com>
1532     
1533             [ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
1534             https://bugs.webkit.org/show_bug.cgi?id=134333
1535     
1536             Reviewed by Geoffrey Garen.
1537     
1538             * Scripts/display-profiler-output:
1539     
1540 2014-08-05  David Farler  <dfarler@apple.com>
1541
1542         [iOS] Run ImageDiff in the sim bootstrap
1543         https://bugs.webkit.org/show_bug.cgi?id=135624
1544
1545         Reviewed by David Kilzer.
1546
1547         * Scripts/webkitpy/port/image_diff.py:
1548         (ImageDiffer.stop):
1549         (IOSSimulatorImageDiffer):
1550         (IOSSimulatorImageDiffer._start):
1551         * Scripts/webkitpy/port/ios.py:
1552         (IOSSimulatorPort.diff_image):
1553
1554 2014-08-05  David Farler  <dfarler@apple.com>
1555
1556         [iOS] run-webkit-tests: defaults for --runtime and --device-type flags
1557         https://bugs.webkit.org/show_bug.cgi?id=135441
1558
1559         Reviewed by Tim Horton.
1560
1561         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1562         (parse_args):
1563         (_set_up_derived_options):
1564         If using the ios-simulator platform and runtime or device-type
1565         aren't defined, get the latest runtime from the active Xcode.app
1566         and pick a default device type based on the desired architecture:
1567         iPhone 5 for i386 and iPhone 5s for x86_64.
1568         * Scripts/webkitpy/xcode/__init__.py: Added.
1569         * Scripts/webkitpy/xcode/simulator.py: Added.
1570
1571 2014-08-05  David Farler  <dfarler@apple.com>
1572
1573         [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
1574         https://bugs.webkit.org/show_bug.cgi?id=135626
1575
1576         Reviewed by Dan Bernstein.
1577
1578         * Scripts/webkitpy/port/ios.py:
1579         (IOSSimulatorPort.setup_test_run):
1580         Remove call to simctl shutdown <device> - telling the simulator app to quit
1581         will shut down all booted devices.
1582
1583 2014-08-05  Alexey Proskuryakov  <ap@apple.com>
1584
1585         Remove an unused argument from BuildbotQueue.update()
1586         https://bugs.webkit.org/show_bug.cgi?id=135623
1587
1588         Reviewed by Timothy Hatcher.
1589
1590         Also remaned a constant to better match what it means.
1591
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1593
1594 2014-08-05  Vivek Galatage  <vivek.vg@samsung.com>
1595
1596         [gtk] Include llvm-dev(el) package to satisfy mesa build configuration
1597         https://bugs.webkit.org/show_bug.cgi?id=135555
1598
1599         Reviewed by Philippe Normand.
1600
1601         Initial setup of gtk on linux requires this package to be installed.
1602         This is required during the build configuration of mesa through jhbuild.
1603
1604         * gtk/install-dependencies:
1605
1606 2014-08-05  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1607
1608         Fix the commit-log-editor after r167243 and add more unit tests
1609         https://bugs.webkit.org/show_bug.cgi?id=131727
1610
1611         Reviewed by Csaba Osztrogonác.
1612
1613         * Scripts/commit-log-editor:
1614         (createCommitMessage):
1615         (removeLongestCommonPrefixEndingInNewline):
1616         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1617         (CommitMessageForThisCommitTest):
1618         (CommitMessageForThisCommitTest.mock_changelog):
1619         (CommitMessageForThisCommitTest.mock_checkout_for_test):
1620         (CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages):
1621         (test_commit_message_for_one_reviewed_changelog):
1622         (test_commit_message_for_changelogs_with_same_messages):
1623         (test_commit_message_for_changelogs_with_different_messages):
1624         (test_commit_message_for_one_rollout_changelog):
1625         (test_commit_message_for_rollout_changelogs_with_different_directories):
1626         (setUp): Deleted.
1627         (test_commit_message_for_this_commit): Deleted.
1628
1629 2014-08-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1630
1631         [GTK] run-launcher --gtk is broken
1632         https://bugs.webkit.org/show_bug.cgi?id=135571
1633
1634         Reviewed by Martin Robinson.
1635
1636         * Scripts/webkitdirs.pm:
1637         (builtDylibPathForName): Search for libwebkit2gtk-4.0
1638
1639 2014-08-04  Matt Baker  <mattbaker@apple.com>
1640
1641         lldb_webkit.py throws exception when generating summary of null StringImpl
1642         https://bugs.webkit.org/show_bug.cgi?id=129448
1643
1644         Reviewed by Jer Noble.
1645
1646         Added checks for null StringImpl and 0 byte ReadMemory calls.
1647
1648         * lldb/lldb_webkit.py:
1649         (WTFStringImpl_SummaryProvider):
1650         (ustring_to_string):
1651         (lstring_to_string):
1652         (WTFStringImplProvider.to_string):
1653         (WTFStringImplProvider.is_initialized):
1654
1655 2014-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1656
1657         [GTK] Do not include JavaScriptCore stress tests in release tarballs
1658         https://bugs.webkit.org/show_bug.cgi?id=135503
1659
1660         Reviewed by Martin Robinson.
1661
1662         * gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
1663
1664 2014-07-30  David Farler  <dfarler@apple.com>
1665
1666         build-webkittestrunner doesn't build the app target for iOS SDKs
1667         https://bugs.webkit.org/show_bug.cgi?id=135433
1668
1669         Reviewed by Dan Bernstein.
1670
1671         * Scripts/build-dumprendertree: Build the app target on iOS.
1672         * Scripts/build-webkittestrunner: Build the app target on iOS.
1673         * Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
1674         (buildXCodeProject):
1675         * Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
1676         (IOSSimulatorPort._build_driver_flags):
1677
1678 2014-07-30  David Farler  <dfarler@apple.com>
1679
1680         Remove iOS Perl DumpRenderTree support target
1681         https://bugs.webkit.org/show_bug.cgi?id=135271
1682
1683         Reviewed by Dan Bernstein.
1684
1685         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
1686         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
1687         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
1688         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
1689         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
1690         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
1691         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
1692         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
1693         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
1694         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
1695         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
1696         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
1697         * DumpRenderTree/ios/PerlSupport/Makefile: Removed.
1698
1699 2014-07-30  David Farler  <dfarler@apple.com>
1700
1701         Remove old-run-webkit-tests
1702         https://bugs.webkit.org/show_bug.cgi?id=135374
1703
1704         Reviewed by Csaba Osztrogonác.
1705
1706         * Scripts/old-run-webkit-tests: Removed.
1707
1708 2014-08-02  Dan Bernstein  <mitz@apple.com>
1709
1710         prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
1711         https://bugs.webkit.org/show_bug.cgi?id=135542
1712
1713         Reviewed by Tim Horton.
1714
1715         * Scripts/prepare-ChangeLog:
1716         (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
1717         findChangeLogs.
1718         (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
1719         requireChangeLogToExist argument is true.
1720
1721 2014-08-01  Dan Bernstein  <mitz@apple.com>
1722
1723         commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
1724         https://bugs.webkit.org/show_bug.cgi?id=135527
1725
1726         Reviewed by Tim Horton.
1727
1728         * Scripts/commit-log-editor:
1729         In the case of a git repository when there are no changed ChangeLog files, changed to pass
1730         the --delimiters option to prepare-ChangeLog, then process each entry in the output using
1731         commitMessageFromChangeLogEntry.
1732         (commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
1733         (sortKey): Factored out from createCommitMessage.
1734         (createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
1735         subroutines.
1736
1737         * Scripts/prepare-ChangeLog:
1738         (main): Parse new --delimiters option.
1739         (generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
1740         the label before each change log entry, and a "~" delimiter on a new line after each entry.
1741
1742 2014-08-01  Bear Travis  <betravis@adobe.com>
1743
1744         [Feature Queries] Enable Feature Queries on EFL/GTK
1745         https://bugs.webkit.org/show_bug.cgi?id=134902
1746
1747         Reviewed by Benjamin Poulain.
1748
1749         Turn the feature on by default for the build script.
1750
1751         * Scripts/webkitperl/FeatureList.pm:
1752
1753 2014-08-01  Timothy Horton  <timothy_horton@apple.com>
1754
1755         Build fix for 32-bit after r171926.
1756
1757         * MiniBrowser/mac/SettingsController.h:
1758         * MiniBrowser/mac/SettingsController.m:
1759
1760 2014-08-01  Tim Horton  <timothy_horton@apple.com>
1761
1762         Confusing build fix after r171926.
1763
1764         * MiniBrowser/mac/AppDelegate.h:
1765         * MiniBrowser/mac/AppDelegate.m:
1766         * MiniBrowser/mac/SettingsController.m:
1767
1768 2014-08-01  Tim Horton  <timothy_horton@apple.com>
1769
1770         Make it easer to add switches to MiniBrowser
1771         https://bugs.webkit.org/show_bug.cgi?id=135499
1772
1773         Reviewed by Simon Fraser.
1774
1775         Add a single class to manage a set of persistent, global settings for MiniBrowser.
1776         Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
1777
1778         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1779         Add SettingsController.{m, h}.
1780
1781         * MiniBrowser/mac/AppDelegate.h:
1782         Move _browserWindowControllers to the implementation.
1783         Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
1784         of that; instead, we'll receive didChangeSettings.
1785
1786         * MiniBrowser/mac/AppDelegate.m:
1787         Move the default URL, default URL preference key, and use-WebKit2-by-default
1788         preference key into SettingsController.
1789
1790         (-[BrowserAppDelegate awakeFromNib]):
1791         Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
1792
1793         (-[BrowserAppDelegate newWindow:]):
1794         Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
1795
1796         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1797         SettingsController now takes care of reading the default URL preference.
1798         WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
1799
1800         (-[BrowserAppDelegate didChangeSettings]):
1801         When settings change, update the key equivalents for the new-window menu items, as they
1802         might have changed (as use-WebKit2-by-default is one of the settings).
1803
1804         Dispatch settings change notifications to all live BrowserControllers.
1805
1806         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1807         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
1808         (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
1809         (-[BrowserAppDelegate validateMenuItem:]): Deleted.
1810         All menu item validation for settings is moved into SettingsController.
1811
1812         * MiniBrowser/mac/BrowserWindowController.h:
1813         Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
1814         the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
1815
1816         * MiniBrowser/mac/MainMenu.xib:
1817         Remove the settings menu items from the "Debug" menu.
1818
1819         * MiniBrowser/mac/SettingsController.h: Added.
1820         * MiniBrowser/mac/SettingsController.m: Added.
1821         (+[SettingsController shared]):
1822         (-[SettingsController menu]):
1823
1824         (-[SettingsController _addItemWithTitle:action:indented:]):
1825         (-[SettingsController _addHeaderWithTitle:]):
1826         NSMenuItem-creating helpers.
1827
1828         (-[SettingsController _populateMenu]):
1829         Build the menu. Ideally this and the validation step would eventually be made more dynamic.
1830
1831         (-[SettingsController validateMenuItem:]):
1832         Validate menu items; since they can be used to toggle the default state of a setting,
1833         we'll always return YES. However, we will use this opportunity to set the 'checked' state
1834         of each item.
1835
1836
1837         (-[SettingsController _toggleBooleanDefault:]):
1838         Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
1839
1840         (-[SettingsController toggleUseWebKit2ByDefault:]):
1841         (-[SettingsController useWebKit2ByDefault]):
1842         (-[SettingsController toggleUseTransparentWindows:]):
1843         (-[SettingsController useTransparentWindows]):
1844         (-[SettingsController toggleUsePaginatedMode:]):
1845         (-[SettingsController usePaginatedMode]):
1846         (-[SettingsController toggleUseUISideCompositing:]):
1847         (-[SettingsController useUISideCompositing]):
1848         (-[SettingsController toggleShowLayerBorders:]):
1849         (-[SettingsController layerBordersVisible]):
1850         (-[SettingsController toggleShowTiledScrollingIndicator:]):
1851         (-[SettingsController tiledScrollingIndicatorVisible]):
1852         (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
1853         (-[SettingsController subPixelCSSOMMetricsEnabled]):
1854         (-[SettingsController defaultURL]):
1855         Toggle or return the current state of each preference.
1856
1857         * MiniBrowser/mac/WK1BrowserWindowController.m:
1858         (-[WK1BrowserWindowController awakeFromNib]):
1859         (-[WK1BrowserWindowController validateMenuItem:]):
1860         (-[WK1BrowserWindowController windowWillClose:]):
1861         (-[WK1BrowserWindowController find:]):
1862         (-[WK1BrowserWindowController dumpSourceToConsole:]):
1863         (-[WK1BrowserWindowController didChangeSettings]):
1864         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
1865         (-[WK1BrowserWindowController isPaginated]): Deleted.
1866         (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
1867         (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
1868         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
1869         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
1870         (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
1871         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
1872         * MiniBrowser/mac/WK2BrowserWindowController.m:
1873         (-[WK2BrowserWindowController awakeFromNib]):
1874         (-[WK2BrowserWindowController validateMenuItem:]):
1875         (-[WK2BrowserWindowController forceRepaint:]):
1876         (-[WK2BrowserWindowController windowWillClose:]):
1877         (-[WK2BrowserWindowController didChangeSettings]):
1878         (-[WK2BrowserWindowController isPaginated]): Deleted.
1879         (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
1880         (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
1881         (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
1882         (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
1883         (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
1884         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
1885         (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
1886         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
1887
1888 2014-08-01  Tim Horton  <timothy_horton@apple.com>
1889
1890         MiniBrowser doesn't support data URLs
1891         https://bugs.webkit.org/show_bug.cgi?id=135492
1892
1893         Reviewed by Simon Fraser.
1894
1895         * MiniBrowser/mac/BrowserWindowController.m:
1896         (-[BrowserWindowController addProtocolIfNecessary:]):
1897         Don't add http:// to data: URLs.
1898
1899         * MiniBrowser/mac/WK2BrowserWindowController.m:
1900         (-[WK2BrowserWindowController fetch:]):
1901         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1902         Percent-escape the contents of the address field before trying to make a URL.
1903         Percent-unescape the URL when displaying it in the address field.
1904         This is not great, but trivial and good-enough-for-Minibrowser.
1905
1906 2014-07-31  Ryuan Choi  <ryuan.choi@samsung.com>
1907
1908         [EFL][WK2] MiniBrower comes to crash when combo box is pressed
1909         https://bugs.webkit.org/show_bug.cgi?id=135378
1910
1911         Reviewed by Gyuyoung Kim.
1912
1913         "clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
1914         and removes Ewk_Popup_Menu instance.
1915
1916         * MiniBrowser/efl/main.c:
1917         (on_popup_menu_show):
1918         (on_popup_menu_discarded): Deleted.
1919
1920 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
1921
1922         [Win] Use RC_PROJECTBUILDVERSION as build portion of version
1923         https://bugs.webkit.org/show_bug.cgi?id=135478
1924
1925         Reviewed by David Kilzer.
1926
1927         Add new test suite for the version-stamp program.
1928
1929         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
1930
1931 2014-07-31  Dan Bernstein  <mitz@apple.com>
1932
1933         Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
1934         which loads HTTPS content without calling the delegate.
1935
1936         Rubber-stamped by Alexey Proskuryakov.
1937
1938         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1939         (WTR::InjectedBundle::platformInitialize):
1940         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1941         (WTR::InjectedBundle::platformInitialize):
1942
1943 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
1944
1945         Unreviewed typo correction (and build fix).
1946
1947         * MiniBrowser/mac/WK2BrowserWindowController.m:
1948         (-[WK2BrowserWindowController awakeFromNib]): Use correct
1949         property name (_fullScreenIsEnabled -> _fullScreenEnabled)
1950
1951 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
1952
1953         MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
1954         https://bugs.webkit.org/show_bug.cgi?id=135482
1955
1956         Reviewed by Simon Fraser.
1957
1958         * MiniBrowser/mac/WK2BrowserWindowController.m:
1959         (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
1960         feature.
1961
1962 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
1963
1964         [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
1965         https://bugs.webkit.org/show_bug.cgi?id=135472
1966
1967         Reviewed by Dan Bernstein.
1968
1969         We now handle server trust challenges, and don't need such hacks.
1970
1971         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1972         (WTR::InjectedBundle::platformInitialize):
1973         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1974         (WTR::InjectedBundle::platformInitialize):
1975
1976 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
1977
1978         media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
1979         on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
1980         https://bugs.webkit.org/show_bug.cgi?id=135418
1981
1982         Reviewed by Anders Carlsson.
1983
1984         This was only happening in shared web process mode, because WKBundlePostMessage
1985         has different behavior then. When there is no process, the message is dropped on
1986         the floor in multiple process mode, but it's stored to be delivered after launch
1987         in shared process mode.
1988
1989         So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
1990         that was delivered immediately after launch, when there was nothing to reset.
1991
1992         We don't actually need to reset anything at this point, as the previous call has
1993         already reset everything UI process side, and web process is brand new. All we need
1994         is to reattach the page to a process, as invoke() expects one to exist.
1995
1996         * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
1997         * WebKitTestRunner/TestController.h:
1998         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
1999
2000 2014-07-31  Dan Bernstein  <mitz@apple.com>
2001
2002         [WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
2003         https://bugs.webkit.org/show_bug.cgi?id=115282
2004
2005         Reviewed by Sam Weinig.
2006
2007         * WebKitTestRunner/TestController.cpp:
2008         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
2009         local host server trust protection space.
2010         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
2011         credential to server trust challenges.
2012
2013 2014-07-31  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2014
2015         [webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
2016         https://bugs.webkit.org/show_bug.cgi?id=135381
2017
2018         Reviewed by Csaba Osztrogonác.
2019
2020         * Scripts/webkitpy/port/base.py:
2021         (Port.diff_text):
2022         * Scripts/webkitpy/port/base_unittest.py:
2023         (PortTest.test_diff_text):
2024
2025 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2026
2027         Unreviewed. Fix GTK+ make distcheck.
2028
2029         * gtk/make-dist.py:
2030         (ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
2031         version to find the pkg-config file.
2032         * gtk/manifest.txt: Add missing resource to the tarball.
2033
2034 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2035
2036         [GTK] make distcheck is building from sources dir instead of dist dir
2037         https://bugs.webkit.org/show_bug.cgi?id=135457
2038
2039         Reviewed by Philippe Normand.
2040
2041         * gtk/make-dist.py:
2042         (Distcheck.configure): Use dist_dir as source dir.
2043         (Distcheck.check): Pass dist_dir to configure().
2044
2045 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2046
2047         [GTK] Do not include files that are not in git in the tarball
2048         https://bugs.webkit.org/show_bug.cgi?id=134804
2049
2050         Reviewed by Philippe Normand.
2051
2052         Skip all files in the source tree that are not under version control
2053         except for files added from the build dir like the documentation.
2054
2055         * gtk/make-dist.py:
2056         (Directory.__init__): Initialize the list of files under control version.
2057         (Directory.list_cms_files): Helper function to list all files
2058         under the control version for the current source root.
2059         (Directory.should_skip_file): Return True for files that are not
2060         under control version only when the source root is also under
2061         control version.
2062         (Directory.get_files): Filter the files also using should_skip_file().
2063
2064 2014-07-29  David Farler  <dfarler@apple.com>
2065
2066         iOS Simulator LayoutTestRelay
2067         https://bugs.webkit.org/show_bug.cgi?id=135269
2068
2069         Reviewed by David Kilzer.
2070
2071         * LayoutTestRelay/Configurations/Base.xcconfig: Added.
2072         * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
2073         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
2074         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
2075         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
2076         (-[LTPipeRelay inPipePath]):
2077         (-[LTPipeRelay outPipePath]):
2078         (-[LTPipeRelay errorPipePath]):
2079         (-[LTPipeRelay outputStream]):
2080         (-[LTPipeRelay initWithPrefix:]):
2081         (-[LTPipeRelay setup]):
2082         (-[LTPipeRelay tearDown]):
2083         (-[LTPipeRelay connect]):
2084         (-[LTPipeRelay disconnect]):
2085         (-[LTPipeRelay createFIFOs]):
2086         (-[LTPipeRelay destroyFIFOs]):
2087         (-[LTPipeRelay relayStream:]):
2088         (-[LTPipeRelay stream:handleEvent:]):
2089         * LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
2090         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
2091         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
2092         (-[LTRelayController uniqueAppPath]):
2093         (-[LTRelayController uniqueAppURL]):
2094         (-[LTRelayController uniqueAppIdentifier]):
2095         (-[LTRelayController processName]):
2096         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
2097         (-[LTRelayController readFileHandle:]):
2098         (-[LTRelayController receivedStandardOutputData:]):
2099         (-[LTRelayController receivedStandardErrorData:]):
2100         (-[LTRelayController disconnected]):
2101         (-[LTRelayController connected]):
2102         (-[LTRelayController crashWithMessage:]):
2103         (-[LTRelayController launchSimulator]):
2104         (-[LTRelayController bootDevice]):
2105         (-[LTRelayController createUniqueApp]):
2106         (-[LTRelayController killApp]):
2107         (-[LTRelayController launchApp]):
2108         (-[LTRelayController start]):
2109         * LayoutTestRelay/LayoutTestRelay/main.m: Added.
2110         (usage):
2111         (getTestingSimDevice):
2112         (getRequiredStringArgument):
2113         (getRemainderArguments):
2114         (main):
2115         * LayoutTestRelay/Makefile: Added.
2116         * Tools/Scripts/build-layouttestrelay: Added.
2117
2118 2014-07-29  Brent Fulgham  <bfulgham@apple.com>
2119
2120         [Win] Modify version numbering scheme to support 5-tuple versions
2121         https://bugs.webkit.org/show_bug.cgi?id=135400
2122         <rdar://problem/17849033>
2123
2124         Reviewed by David Kilzer.
2125
2126         Update test cases to recognize that we can only support Major
2127         values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
2128         Micro values from 0-64, and Nano values from 0-999.
2129
2130         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update
2131         test expectations for physical limits.
2132
2133 2014-07-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2134
2135         [GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
2136         https://bugs.webkit.org/show_bug.cgi?id=135411
2137
2138         Reviewed by Sergio Villar Senin.
2139
2140         Recent versions of GTK+ now warn at runtime when a deprecated
2141         property or signal is used. A diagnostic mode was added that is
2142         enabled by default, but that can be disabled by setting
2143         G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
2144         failures by gtester, so we need to run the tests with the
2145         diganostic mode disabled.
2146
2147         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
2148         (main):
2149
2150 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2151
2152         [GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
2153         https://bugs.webkit.org/show_bug.cgi?id=134830
2154
2155         Reviewed by Gustavo Noronha Silva.
2156
2157         Update the SSL test for the API changes.
2158
2159         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2160         (testLoadFailedWithTLSErrors):
2161
2162 2014-07-24  David Farler  <dfarler@apple.com>
2163
2164         Add knowledge of the iOS Simulator to webkitpy
2165         http://bugs.webkit.org/show_bug.cgi?id=133963
2166
2167         Reviewed by Simon Fraser.
2168
2169         * Scripts/webkitdirs.pm:
2170         (argumentsForConfiguration): Add --ios-sim*
2171         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2172         --runtime and --device-type args added.
2173         * Scripts/webkitpy/port/base.py:
2174         * Scripts/webkitpy/port/driver.py: Add simulator driver.
2175         (IOSSimulatorDriver): Added.
2176         * Scripts/webkitpy/port/factory.py: Add simulator platform.
2177         * Scripts/webkitpy/port/ios.py: Added.
2178
2179 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
2180
2181         fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
2182         https://bugs.webkit.org/show_bug.cgi?id=135398
2183
2184         Reviewed by Zalan Bujtas.
2185
2186         * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
2187         "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
2188
2189         * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
2190         For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
2191         sure why.
2192
2193 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
2194
2195         PPT: run-webkit-tests doesn't upload crash logs to bots
2196         https://bugs.webkit.org/show_bug.cgi?id=135391
2197
2198         Reviewed by Joseph Pecoraro.
2199
2200         * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
2201         Not a fix to be proud of, but better than not having it work at all.
2202
2203 2014-07-29  Adrian Perez de Castro  <aperez@igalia.com>
2204
2205         [GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
2206         https://bugs.webkit.org/show_bug.cgi?id=133729
2207
2208         Reviewed by Carlos Garcia Campos.
2209
2210         Removes WebKitWebViewGroup, effectively reverting the changes
2211         introduced by r149117. The motivation for WebKitWebViewGroup
2212         was using the user style sheet injection API, which has been
2213         moved into WebKitUserContentManager, rendering it unneeded.
2214
2215         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
2216         for WebKitWebViewGroup.
2217         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2218         (testWebViewSettings):
2219         Restore the assertions that check that settings objects are
2220         released. Add test for webkit_web_view_new_with_settings().
2221         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
2222
2223 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2224
2225         Implement webkit_web_view_load_string() in WebKit2
2226         https://bugs.webkit.org/show_bug.cgi?id=134735
2227
2228         Reviewed by Sergio Villar Senin.
2229
2230         Add /webkit2/WebKitWebView/load-bytes test case and simplify
2231         TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
2232         instead of a soup server just to sent the Content-type header.
2233
2234         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
2235         (testWebKitDOMXPathNSResolverNative):
2236         (testWebKitDOMXPathNSResolverCustom):
2237         (beforeAll):
2238         (afterAll):
2239         (serverCallback): Deleted.
2240         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2241         (testLoadBytes):
2242         (beforeAll):
2243         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2244         (LoadTrackingTest::loadBytes):
2245         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2246         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2247         (WebViewTest::loadBytes):
2248         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2249
2250 2014-07-28  Daniel Bates  <dabates@apple.com>
2251
2252         Add support for running the Clang static analyzer when building WebKit and JSC
2253         https://bugs.webkit.org/show_bug.cgi?id=134955
2254
2255         Reviewed by Brent Fulgham.
2256
2257         * Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
2258         * Scripts/build-webkit: Add --analyze command line option to build-webkit to enable
2259         running the Clang static analyzer.
2260         * Scripts/webkitdirs.pm:
2261         (XcodeStaticAnalyzerOption): Added.
2262
2263 2014-07-24  David Farler  <dfarler@apple.com>
2264
2265         Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
2266         https://bugs.webkit.org/show_bug.cgi?id=135272
2267
2268         Reviewed by Simon Fraser.
2269
2270         * DumpRenderTree/mac/DumpRenderTree.mm:
2271         (dumpRenderTree): Remove hard-coding of FIFO paths.
2272         (-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
2273         (DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.
2274         * DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
2275         * Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
2276         * WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
2277         * WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
2278         * WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.
2279         (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
2280         (main): Set WebKitTestRunnerApp as UIApplication delegate.
2281
2282 2014-07-24  David Farler  <dfarler@apple.com>
2283
2284         ImageDiff builds for the simulator when running iOS layout tests
2285         https://bugs.webkit.org/show_bug.cgi?id=135270
2286
2287         Reviewed by Simon Fraser.
2288
2289         * Scripts/build-imagediff: Added.
2290
2291 2014-07-28  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2292
2293         Followup fix after r171594
2294         https://bugs.webkit.org/show_bug.cgi?id=135048
2295
2296         Reviewed by Csaba Osztrogonác.
2297
2298         * Scripts/sort-export-file: Removed extra newlines from help.
2299
2300 2014-07-25  Anders Carlsson  <andersca@apple.com>
2301
2302         WKNavigation's properties are either always nil or don't behave as documented
2303         https://bugs.webkit.org/show_bug.cgi?id=135267
2304         <rdar://problem/17730536>
2305
2306         Reviewed by Andreas Kling.
2307
2308         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2309         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
2310         (TEST):
2311         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
2312         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2313
2314 2014-07-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2315
2316         [GTK] install-dependencies needs to install perl-CGI on Fedora
2317         https://bugs.webkit.org/show_bug.cgi?id=135302
2318
2319         Reviewed by Martin Robinson.
2320
2321         * gtk/install-dependencies:
2322         Add perl-CGI to yum dependencies needed for tests
2323
2324 2014-07-25  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2325
2326         Add --dry-run option to sort-export-file
2327         https://bugs.webkit.org/show_bug.cgi?id=135048
2328
2329         Reviewed by Csaba Osztrogonác.
2330
2331         Added --dry-run option to sort-export-file. Running the script with --dry-run
2332         option does not sort the export files but creates a list of the files that
2333         need to be sorted.
2334
2335         * Scripts/sort-export-file:
2336         (sawError):
2337
2338 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2339
2340         GTK jhbuild modules needs to build xserver with --disable-local-transport
2341         https://bugs.webkit.org/show_bug.cgi?id=135262
2342
2343         Reviewed by Martin Robinson.
2344
2345         * gtk/jhbuild.modules:
2346         Build X server with --disable-local-transport, since local transport
2347         is only supported on Solaris, SCO, and System V. Fixes build on
2348         Fedora.
2349
2350 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2351
2352         [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
2353         https://bugs.webkit.org/show_bug.cgi?id=135065
2354
2355         Reviewed by Martin Robinson.
2356
2357         * jhbuild/jhbuild-wrapper:
2358         (ensure_jhbuild): do not assume jhbuild sets ACLOCAL_FLAGS
2359
2360 2014-07-23  Joseph Pecoraro  <pecoraro@apple.com>
2361
2362         Unreviewed iOS build fix after r171355.
2363
2364         * TestWebKitAPI/Configurations/Base.xcconfig:
2365         Since all the Tests/WebKit2Cocoa tests are already explicitly skipped on iOS,
2366         simplify to skipping all the tests in the directory. PlatformUtilities are not
2367         building on iOS, which means we are missing necessary Util functions.
2368
2369 2014-07-23  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2370
2371         [EFL] Fix build after r171454
2372         https://bugs.webkit.org/show_bug.cgi?id=135191
2373
2374         Reviewed by Csaba Osztrogonác.
2375
2376         * MiniBrowser/efl/CMakeLists.txt: Add path to new EWebKit2.h location .
2377
2378 2014-07-23  Ryuan Choi  <ryuan.choi@samsung.com>
2379
2380         [EFL] Do not generate forwarding header for ewk headers
2381         https://bugs.webkit.org/show_bug.cgi?id=135147
2382
2383         Reviewed by Gyuyoung Kim.
2384
2385         * WebKitTestRunner/EventSenderProxy.h:
2386
2387 2014-07-21  Sam Weinig  <sam@webkit.org>
2388
2389         [Cocoa] WKScriptMessageHandlers don't seem to function properly after navigating
2390         https://bugs.webkit.org/show_bug.cgi?id=135148
2391
2392         Reviewed by Geoffrey Garen.
2393
2394         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2395         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Added.
2396         (-[SimpleNavigationDelegate webView:didFinishNavigation:]):
2397         (-[ScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2398
2399 2014-07-22  Brent Fulgham  <bfulgham@apple.com>
2400
2401         Correct handling of __VERSION_TEXT__ for 4+-tuple versions
2402         https://bugs.webkit.org/show_bug.cgi?id=135161
2403         <rdar://problem/17763546>
2404
2405         Reviewed by David Kilzer.
2406
2407         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
2408         Add additional test cases to catch errors in multiple-tuple
2409         version string handling.
2410
2411 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2412
2413         Extend exception fuzzing to the LLInt
2414         https://bugs.webkit.org/show_bug.cgi?id=135076
2415
2416         Reviewed by Oliver Hunt.
2417
2418         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2419
2420 2014-07-22  Jochen Eisinger  <jochen@chromium.org>
2421
2422         Fix my email address in contributors.json
2423         https://bugs.webkit.org/show_bug.cgi?id=135156
2424
2425         Reviewed by Gyuyoung Kim.
2426
2427         * Scripts/webkitpy/common/config/contributors.json:
2428
2429 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2430
2431         Unreviewed test fix.
2432
2433         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Revert
2434         to older Perl 5.8 syntax for iterating over hashes to allow tests to
2435         run on Mountain Lion bots.
2436
2437 2014-07-21  Alexey Proskuryakov  <ap@apple.com>
2438
2439         https://bugs.webkit.org/show_bug.cgi?id=135137
2440         build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
2441
2442         Reviewed by Darin Adler.
2443
2444         webkitperl results are binary, handle them the same way we handle bindings test results.
2445
2446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2447         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2448         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2449
2450 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2451
2452         [Win] Follow-up for r171324.
2453
2454         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Cygwin
2455         perl reports itself as 'cygwin'; native Windows Perl reports as
2456         'MSWin32'. We need to handle both cases.
2457
2458 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2459
2460         Unreviewed build fix after r171319.
2461
2462         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: This test should
2463         only execute on Windows. It will fail on other platforms, so give it a way to
2464         successfully exit.
2465
2466 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2467
2468         [Win] Extend auto-version.pl to support 5-tuple versions
2469         https://bugs.webkit.org/show_bug.cgi?id=135124
2470         <rdar://problem/17750334>
2471
2472         Reviewed by David Kilzer.
2473
2474         Add test cases for auto-version.pl.
2475
2476         * Scripts/webkitperl/auto-version_unittest: Added.
2477         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Added.
2478
2479 2014-07-21  Dean Jackson  <dino@apple.com>
2480
2481         Allow MiniBrowser WK1 to do element fullscreen
2482         https://bugs.webkit.org/show_bug.cgi?id=135125
2483
2484         Reviewed by Simon Fraser.
2485
2486         Allow WK1 windows to go fullscreen using the DOM API.
2487
2488         * MiniBrowser/mac/WK1BrowserWindowController.m:
2489         (-[WK1BrowserWindowController awakeFromNib]): Enable the preference for
2490         fullscreen.
2491
2492 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2493
2494         [GTK] Documentation files are added twice to the tarball
2495         https://bugs.webkit.org/show_bug.cgi?id=135115
2496
2497         Reviewed by Sergio Villar Senin.
2498
2499         * gtk/manifest.txt: Remove duplicated rules.
2500
2501 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2502
2503         [GTK] Simplify make-dist command line arguments
2504         https://bugs.webkit.org/show_bug.cgi?id=134832
2505
2506         Reviewed by Martin Robinson.
2507
2508         Remove --tarball-root and -o command line options and add
2509         --version, since the version can be used to build both, the
2510         tarball root and the output filename. When the version it's not
2511         provided, the pkg-config file is used to get the version. Also
2512         change the default value of build-dir to the current directory,
2513         since it's very common to call make-dist.py from the build dir.
2514
2515         * gtk/make-dist.py:
2516         (get_tarball_root_and_output_filename_from_arguments):
2517
2518 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2519
2520         [GTK] Reduce the size of the tarball generated by distcheck
2521         https://bugs.webkit.org/show_bug.cgi?id=134802
2522
2523         Reviewed by Martin Robinson.
2524
2525         Add more rules to the manifest to decide what files to add:
2526
2527           - Do not include platform specific directories of other ports.
2528           - Do not include port specific cmake files.
2529           - Do not include Objective-C sources.
2530           - Do not include .orig and .rej files.
2531           - Do not include mac specific sandbox files.
2532           - Only include the resources we actually build.
2533
2534         * gtk/manifest.txt:
2535
2536 2014-07-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2537
2538         [EFL] Enable mpg123 feature for gst-plugin-bad.
2539         https://bugs.webkit.org/show_bug.cgi?id=135016
2540
2541         Reviewed by Laszlo Gombos.
2542
2543         enable-mpg123 feature is added to jhbuild in order to support playback of mp3 format.
2544
2545         * efl/install-dependencies:
2546         * efl/jhbuild.modules:
2547
2548 2014-07-20  Dan Bernstein  <mitz@apple.com>
2549
2550         Test for <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
2551         https://bugs.webkit.org/show_bug.cgi?id=135107
2552
2553         Reviewed by Sam Weinig.
2554
2555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2556         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm: Added.
2557         (-[RenderedImageFromDOMNodeFrameLoadDelegate webView:didFinishLoadForFrame:]):
2558         (TestWebKitAPI::TEST):
2559
2560 2014-07-20  David Kilzer  <ddkilzer@apple.com>
2561
2562         Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
2563         <http://webkit.org/b/135096>
2564
2565         Reviewed by Alexey Proskuryakov.
2566
2567         * DumpRenderTree/mac/LayoutTestHelper.m:
2568         (lockDownDiscreteGraphics): Check the return values of
2569         IOServiceOpen() and IOObjectRelease(), and log if not
2570         KERN_SUCCESS.
2571
2572 2014-07-19  Anders Carlsson  <andersca@apple.com>
2573
2574         Update.
2575
2576         * Scripts/webkitpy/common/config/watchlist:
2577
2578 2014-07-18  Sam Weinig  <sam@webkit.org>
2579
2580         Revert accidental commit to MiniBrowser to make everything layer backed.
2581
2582         * MiniBrowser/mac/BrowserWindowController.m:
2583         (-[BrowserWindowController windowDidLoad]):
2584
2585 2014-07-18  Dana Burkart  <dburkart@apple.com>
2586
2587         Add a new 'analyze' target to the makefile. This will make use of a new
2588         'PATH_TO_SCAN_BUILD' which, if set will wrap xcodebuild in the clang
2589         static analyzer.
2590         https://bugs.webkit.org/show_bug.cgi?id=135057
2591         <rdar://problem/10193187>
2592
2593         Reviewed by David Kilzer.
2594
2595         * Makefile:
2596
2597 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2598
2599         Fix EFL+GTK.
2600
2601         * Scripts/run-jsc-stress-tests:
2602
2603 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2604
2605         Exception fuzzing should work on iOS
2606         https://bugs.webkit.org/show_bug.cgi?id=135070
2607
2608         Reviewed by Mark Hahnenberg.
2609
2610         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2611         (fail):
2612         * Scripts/run-jsc-stress-tests:
2613
2614 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2615
2616         run-jsc-stress-tests should be able to run helper-based tests in remote mode
2617         https://bugs.webkit.org/show_bug.cgi?id=135064
2618
2619         Reviewed by Mark Hahnenberg.
2620
2621         * Scripts/run-jsc-stress-tests:
2622
2623 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2624
2625         run-jsc-stress-tests: rename $copy to $doNotMessWithVMPath
2626         https://bugs.webkit.org/show_bug.cgi?id=135061
2627
2628         Rubber stamped by Mark Hahnenberg.
2629
2630         * Scripts/run-jsc-stress-tests:
2631
2632 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2633
2634         Refactor run-jsc-stress-tests VM copying code to remove some abstractions
2635         https://bugs.webkit.org/show_bug.cgi?id=135059
2636
2637         Reviewed by Mark Lam.
2638         
2639         This is meant to make it easier for me to extend the copying functionality to copy things other than
2640         the framework.
2641
2642         * Scripts/run-jsc-stress-tests:
2643
2644 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2645
2646         Fix cloop build.
2647
2648         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2649
2650 2014-07-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2651
2652         Fix -v|--verbose option in sort-export-file script.
2653         https://bugs.webkit.org/show_bug.cgi?id=135043
2654
2655         Reviewed by Tim Horton.
2656
2657         -v|--verbose option does not work. Option added to getOptionsResult.
2658
2659         * Scripts/sort-export-file:
2660
2661 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2662
2663         Really remove dependency on ShellQuote.
2664
2665         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2666
2667 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2668
2669         Unreviewed, fix build for platforms that don't have ShellQuote.
2670         
2671         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
2672         * Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
2673
2674 2014-07-15  Filip Pizlo  <fpizlo@apple.com>
2675
2676         Need ability to fuzz exception throwing
2677         https://bugs.webkit.org/show_bug.cgi?id=134945
2678         <rdar://problem/17722027>
2679
2680         Reviewed by Sam Weinig.
2681         
2682         Adds a new script, js-exception-fuzz, which will run some jsc command-line using
2683         exception fuzzing. This means that we will force exceptions to be thrown in random
2684         places to see how the engine reacts. This is now integrated with the various test
2685         drivers, so run-javascriptcore-tests will run some exception fuzzing tests by
2686         default.
2687
2688         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Added.
2689         (fail):
2690         * Scripts/run-javascriptcore-tests:
2691         * Scripts/run-jsc-stress-tests:
2692
2693 2014-07-17  Sam Weinig  <sam@webkit.org>
2694
2695         Fix failing API tests.
2696
2697         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2698         (-[ActiveOffscreenWindow isVisible]):
2699         Override isVisible to make the NSWindows pretend they are visible.
2700
2701 2014-07-17  Alexey Proskuryakov  <ap@apple.com>
2702
2703         Disable button animations in regression tests
2704         https://bugs.webkit.org/show_bug.cgi?id=133647
2705         <rdar://problem/16677530>
2706
2707         Reviewed by Dean Jackson.
2708
2709         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2710         We already did this for WebKit2, let's do it for WebKit1 too.
2711
2712 2014-07-16  Alexey Proskuryakov  <ap@apple.com>
2713
2714         A test that hangs at cleanup stage confuses webkitpy hugely
2715         https://bugs.webkit.org/show_bug.cgi?id=122475
2716         <rdar://problem/17184354>
2717
2718         Reviewed by Anders Carlsson.
2719
2720         Terminate WebContent process if it freezes between tests. Ideally, we should report
2721         this somehow, but this is better than blaming the wrong test.
2722
2723         * WebKitTestRunner/TestController.cpp:
2724         (WTR::TestController::terminateWebContentProcess):
2725         * WebKitTestRunner/TestController.h:
2726         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
2727
2728 2014-07-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2729
2730         Change style check path with EFL WK2's path in checker_unittest.py
2731         https://bugs.webkit.org/show_bug.cgi?id=134967
2732
2733         Reviewed by Csaba Osztrogonác.
2734
2735         * Scripts/webkitpy/style/checker_unittest.py: Change ewk_view.h path.
2736         (GlobalVariablesTest.test_path_rules_specifier):
2737
2738 2014-07-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2739
2740         Unreviewed. Added myself to the list of committers.
2741
2742         * Scripts/webkitpy/common/config/contributors.json:
2743
2744 2014-07-15  Ryuan Choi  <ryuan.choi@samsung.com>
2745
2746         [EFL] Remove EFL WK1 directory from the checker.py
2747         https://bugs.webkit.org/show_bug.cgi?id=134954
2748
2749         Reviewed by Gyuyoung Kim.
2750
2751         * Scripts/webkitpy/style/checker.py:
2752
2753 2014-07-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2754
2755         Adding myself to contributors.json breaks a webkitpy test
2756         https://bugs.webkit.org/show_bug.cgi?id=134958
2757
2758         Reviewed by Ryosuke Niwa.
2759
2760         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2761         (IRCCommandTest.test_whois): Be more specific and include also the
2762         first name when asking for the whois of Xan in the unit test.
2763
2764 2014-07-14  Daniel Bates  <dabates@apple.com>
2765
2766         check-webkit-style should apply C++ rules to Objective-C++ files
2767         https://bugs.webkit.org/show_bug.cgi?id=134884
2768
2769         Reviewed by Joseph Pecoraro.
2770
2771         Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
2772         Objective-C++ files.
2773
2774         Currently check-webkit-style doesn't apply the following rules to Objective-C++
2775         files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
2776         Instead, we should teach check-webkit-style to apply these rules because, as
2777         its name implies, an Objective-C++ file may contain C++ code.
2778
2779         * Scripts/webkitpy/style/checkers/cpp.py:
2780         (_FileState.__init__): Add instance variable _is_objective_cpp to track whether a file has
2781         extension mm (i.e. an Objective-C++ file).
2782         (_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
2783         has extension m or mm or if the file has extension h and contains Objective-C directives.
2784         (check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
2785         (check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for
2786         _FileState.is_c_or_objective_c()
2787         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2788         (WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
2789         (WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
2790         (WebKitStyleTest.test_min_macro): Ditto.
2791         (WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.
2792
2793 2014-07-14  Anders Carlsson  <andersca@apple.com>
2794
2795         Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI
2796         https://bugs.webkit.org/show_bug.cgi?id=134889
2797
2798         Reviewed by Beth Dakin.
2799
2800         Bump loader version number to 5.
2801
2802         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2803         (TestWebKitAPI::setPageLoaderClient):
2804         * WebKitTestRunner/TestController.cpp:
2805         (WTR::TestController::createWebViewWithOptions):
2806
2807 2014-07-14  Daniel Bates  <dabates@apple.com>
2808
2809         Teach check-webkit-style to suggest WTF::move() when it sees std::move()
2810         https://bugs.webkit.org/show_bug.cgi?id=134620
2811
2812         Reviewed by Joseph Pecoraro.
2813
2814         * Scripts/webkitpy/style/checkers/cpp.py:
2815         (check_max_min_macros): Fix up comment so that it reads well.
2816         (check_wtf_move): Added.
2817         (check_style): Modified to call check_wtf_move().
2818         (CppChecker): Add category "runtime/wtf_move".
2819         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2820         (WebKitStyleTest.test_wtf_move): Added.
2821
2822 2014-07-12  Peter Szanka  <h868064@stud.u-szeged.hu>
2823
2824         Style checker complains about namespace indentation when there is no namespace
2825         https://bugs.webkit.org/show_bug.cgi?id=105427
2826
2827         Reviewed by Darin Adler.
2828
2829         * Scripts/webkitpy/style/checkers/cpp.py:
2830         (check_namespace_indentation):
2831         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2832         (WebKitStyleTest.test_indentation):
2833
2834         The indentation level depends on the parantheses too, to avoid false warning in case of several statements inside macros.
2835
2836 2014-07-12  Daker Fernandes Pinheiro  <daker.pinheiro@openbossa.org>
2837
2838         Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
2839         https://bugs.webkit.org/show_bug.cgi?id=125317
2840
2841         Reviewed by Darin Adler.
2842
2843         * Scripts/webkitpy/style/checkers/cpp.py:
2844         (_EnumState.process_clean_line):
2845
2846 2014-07-12  Brian Holt  <brian.holt@samsung.com>
2847
2848         Style Checker should prevent enums in bitfields
2849         https://bugs.webkit.org/show_bug.cgi?id=57352
2850
2851         Reviewed by Darin Adler.
2852
2853         Added check that enums are not used as types for bitfields
2854         and a unit test.
2855
2856         * Scripts/webkitpy/style/checkers/cpp.py:
2857         (check_language):
2858         (CppChecker):
2859         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2860         (CppStyleTest):
2861         (CppStyleTest.test_enum_bitfields):
2862         (CppStyleTest.test_plain_integral_bitfields):
2863
2864 2014-07-10  Myles C. Maxfield  <mmaxfield@apple.com>
2865
2866         [iOS] Pasting rich content does not perform a two-step paste
2867         https://bugs.webkit.org/show_bug.cgi?id=134795
2868
2869         Reviewed by Benjamin Poulain.
2870
2871         Two-step paste requires setting InputViewObeysDOMFocus on the UIWebBrowserView.
2872
2873         * DumpRenderTree/mac/DumpRenderTree.mm:
2874         (createWebViewAndOffscreenWindow):
2875
2876 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
2877
2878         [GTK][CMake] Add a 'distcheck' target
2879         https://bugs.webkit.org/show_bug.cgi?id=130675
2880
2881         Reviewed by Gustavo Noronha Silva.
2882
2883         Add --check option to make-dist script that builds and installs the tarball.
2884
2885         * gtk/make-dist.py:
2886         (Distcheck.__init__):
2887         (Distcheck.extract_tarball): Extratc the tarball.
2888         (Distcheck.configure): Run cmake.
2889         (Distcheck.configure.create_dir): Helper function to create a directory.
2890         (Distcheck.build): Run make.
2891         (Distcheck.install): Run make install.
2892         (Distcheck.clean): Clean up the extracted tarball.
2893         (Distcheck.check): Run all previous methods in order.
2894         * gtk/manifest.txt: Add missing file.
2895
2896 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2897
2898         [GTK] Use the same default options for production builds that previous stable releases
2899         https://bugs.webkit.org/show_bug.cgi?id=134589
2900
2901         Reviewed by Martin Robinson.
2902
2903         Make sure all features enabled in production builds are also
2904         enabled in developer mode.
2905
2906         * Scripts/webkitperl/FeatureList.pm: Enable ACCELERATED_2D_CANVAS
2907         and CSS_FILTERS for the GTK port.
2908
2909 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
2910
2911         [Win] Remove uses of 'bash' in build system
2912         https://bugs.webkit.org/show_bug.cgi?id=134782
2913         <rdar://problem/17615533>
2914
2915         Reviewed by Dean Jackson.
2916
2917         Remove uses of 'bash' by replacing Windows-specific bash scripts
2918         with Perl equivalents.
2919
2920         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
2921         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
2922         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
2923         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
2924         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
2925         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
2926
2927 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
2928
2929         [Win] Remove use of 'grep' in build steps
2930         https://bugs.webkit.org/show_bug.cgi?id=134770
2931         <rdar://problem/17608783>
2932
2933         Reviewed by Tim Horton.
2934
2935         Replace uses of the grep command in Windows builds with the equivalent
2936         Perl program.
2937
2938         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
2939         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
2940         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
2941         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
2942         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
2943         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
2944
2945 2014-07-09  Commit Queue  <commit-queue@webkit.org>
2946
2947         Unreviewed, rolling out r170889.
2948         https://bugs.webkit.org/show_bug.cgi?id=134754
2949
2950         This patch is wrong (Requested by philn on #webkit).
2951
2952         Reverted changeset:
2953
2954         "[GTK] Gstreamer missing from the install-dependencies script"
2955         https://bugs.webkit.org/show_bug.cgi?id=134727
2956         http://trac.webkit.org/changeset/170889
2957
2958 2014-07-08  Brian J. Burg  <burg@cs.washington.edu>
2959
2960         resolve-ChangeLogs fails when WebKit repository is a git submodule
2961         https://bugs.webkit.org/show_bug.cgi?id=134734
2962
2963         Reviewed by David Kilzer.
2964
2965         When using resolve-ChangeLogs in a WebKit git repository with a
2966         non-default arrangement of GIT_DIR and GIT_WORK_TREE, incorrect
2967         paths are computed and the script fails mysteriously.
2968
2969         We were naively computing GIT_WORK_TREE as being one level above
2970         GIT_DIR, but this is not the case for submodules or a manually
2971         configured GIT_WORK_TREE or GIT_DIR location.
2972
2973         * Scripts/VCSUtils.pm:
2974         (gitTreeDirectory): Added. Find the equivalent of GIT_WORK_TREE.
2975         (determineVCSRoot): Calculate the working tree root directly.
2976
2977 2014-07-08  Tim Horton  <timothy_horton@apple.com>
2978
2979         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
2980         https://bugs.webkit.org/show_bug.cgi?id=134645
2981
2982         Reviewed by Dan Bernstein.
2983
2984         * MiniBrowser/mac/BrowserWindowController.h:
2985         * MiniBrowser/mac/MainMenu.xib:
2986         Add menu items for layer borders and the tiled scrolling indicator.
2987
2988         * MiniBrowser/mac/WK1BrowserWindowController.m:
2989         (-[WK1BrowserWindowController validateMenuItem:]):
2990         (-[WK1BrowserWindowController layerBordersAreVisible]):
2991         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]):
2992         Add getters/setters/validators for layer borders.
2993
2994         * MiniBrowser/mac/WK2BrowserWindowController.m:
2995         (-[WK2BrowserWindowController awakeFromNib]):
2996         (-[WK2BrowserWindowController validateMenuItem:]):
2997         (-[WK2BrowserWindowController layerBordersAreVisible]):
2998         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]):
2999         (-[WK2BrowserWindowController tiledScrollingIndicatorIsVisible]):
3000         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]):
3001         Add getters/setters/validators for layer borders and the tiled scrolling indicator.
3002
3003         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
3004         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
3005         Remove the WebKit2 version of the subpixel metrics pref, because it doesn't work, because
3006         nothing in WebKit2 reads this default, and there is no WebKit2 API for adjusting this preference.
3007
3008 2014-07-08  Adrian Perez de Castro  <aperez@igalia.com>
3009
3010         [GTK] Move user style sheet API out of WebKitWebViewGroup
3011         https://bugs.webkit.org/show_bug.cgi?id=134551
3012
3013         Reviewed by Carlos Garcia Campos.
3014
3015         Removes testing user style sheet injection from
3016         TestWebKitWebViewGroup and moves that into a new
3017         TestWebKitUserContentManager, adapting the existing tests to the new
3018         API. Also, it contains a new test case for
3019         webkit_web_view_new_with_user_content_manager().
3020
3021         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3022         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.
3023         (UserContentManagerTest::UserContentManagerTest):
3024         (testWebViewNewWithUserContentManager):
3025         (isStyleSheetInjectedForURLAtPath):
3026         (fillURLListFromPaths):
3027         (removeOldInjectedStyleSheetsAndResetLists):
3028         (testUserContentManagerInjectedStyleSheet):
3029         (serverCallback):
3030         (beforeAll):
3031         (afterAll):
3032         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
3033         (beforeAll):
3034         (afterAll):
3035         (isStyleSheetInjectedForURLAtPath): Deleted.
3036         (fillURLListFromPaths): Deleted.
3037         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
3038         (testWebViewGroupInjectedStyleSheet): Deleted.
3039         (serverCallback): Deleted.
3040         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3041         (WebViewTest::WebViewTest):
3042         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3043
3044 2014-07-08  Ziran Sun  <ziran.sun@samsung.com>
3045
3046         [GTK] Gstreamer missing from the install-dependencies script
3047         https://bugs.webkit.org/show_bug.cgi?id=134727
3048
3049         Reviewed by Mario Sanchez Prada.
3050
3051         Added missing gstreamer dependencies for debian based systems.
3052
3053         * gtk/install-dependencies: Added 2 dependencies for apt-get.
3054
3055 2014-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
3056
3057         Add myself to the watchlist for text-related files
3058         https://bugs.webkit.org/show_bug.cgi?id=134707
3059
3060         Reviewed by Timothy Horton.
3061
3062         * Scripts/webkitpy/common/config/watchlist:
3063
3064 2014-07-08  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3065
3066         Add option to specify output file location in sunspider.
3067         https://bugs.webkit.org/show_bug.cgi?id=134339
3068
3069         Reviewed by Darin Adler.
3070
3071         * Scripts/run-sunspider:
3072
3073 2014-07-07  Alex Christensen  <achristensen@webkit.org>
3074
3075         Unreviewed build fix.
3076
3077         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3078         Make Common.cpp excluded from both 32-bit and 64-bit builds.
3079
3080 2014-07-07  Simon Fraser  <simon.fraser@apple.com>
3081
3082         Have MiniBrowser log and reload if the Web Content Process crashes
3083         https://bugs.webkit.org/show_bug.cgi?id=134691
3084
3085         Reviewed by Tim Horton.
3086         
3087         Implement _webViewWebProcessDidCrash, log and reload when the web process
3088         crashes.
3089
3090         * MiniBrowser/mac/WK2BrowserWindowController.m:
3091         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]):
3092
3093 2014-07-07  Alberto Garcia  <berto@igalia.com>
3094
3095         update-webkitgtk-libs script fails by unsatisfied dependencies
3096         https://bugs.webkit.org/show_bug.cgi?id=134547
3097
3098         Reviewed by Martin Robinson.
3099
3100         Install libxcb-xfixes0-dev, needed to build Mesa.
3101
3102         * gtk/install-dependencies:
3103
3104 2014-07-06  Yoav Weiss  <yoav@yoav.ws>
3105
3106         Turn on img@sizes compile flag
3107         https://bugs.webkit.org/show_bug.cgi?id=134634
3108
3109         Reviewed by Benjamin Poulain.
3110
3111         * Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
3112
3113 2014-07-06  Hyowon Kim  <hw1008.kim@samsung.com>
3114
3115         Unreviewed. Adding myself to committers.
3116
3117         * Scripts/webkitpy/common/config/contributors.json:
3118
3119 2014-07-05  KwangHyuk Kim  <hyuki.kim@samsung.com>
3120
3121         [EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
3122         https://bugs.webkit.org/show_bug.cgi?id=134648
3123
3124         Reviewed by Gyuyoung Kim.
3125
3126         As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
3127
3128         * efl/install-dependencies:
3129
3130 2014-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3131
3132         [EFL] Support Geolocation
3133         https://bugs.webkit.org/show_bug.cgi?id=134439
3134
3135         Reviewed by Antonio Gomes.
3136
3137         * Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
3138
3139 2014-07-04  Shivakumar JM  <shiva.jm@samsung.com>
3140
3141         [EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
3142         https://bugs.webkit.org/show_bug.cgi?id=134485
3143
3144         Reviewed by Gyuyoung Kim.
3145
3146         Use script_execute_callback to get selected/highlighted text and show in search bar.
3147
3148         * MiniBrowser/efl/main.c:
3149         (script_execute_callback):
3150         (on_key_down):
3151
3152 2014-07-04  Dan Bernstein  <mitz@apple.com>
3153
3154         Build fix after r170811.
3155
3156         * MiniBrowser/mac/WK2BrowserWindowController.m:
3157         (-[WK2BrowserWindowController reload:]):
3158
3159 2014-07-04  Timothy Horton  <timothy_horton@apple.com>
3160
3161         Typo in watchlist config means four specific people get Cc'd on everything
3162         https://bugs.webkit.org/show_bug.cgi?id=134626
3163
3164         Reviewed by Gyuyoung Kim.
3165
3166         * Scripts/webkitpy/common/config/watchlist:
3167         Remove leading pipe, which meant that this rule matched everything!
3168
3169 2014-07-03  Shivakumar JM  <shiva.jm@samsung.com>
3170
3171         [EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
3172         https://bugs.webkit.org/show_bug.cgi?id=134486
3173
3174         Reviewed by Gyuyoung Kim.
3175
3176         Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.
3177
3178         * MiniBrowser/efl/main.c:
3179         (search_box_show):
3180         (search_box_hide):
3181         (on_search_close_button_clicked):
3182         (on_search_text_found):
3183         (window_create):
3184
3185 2014-07-03  Daniel Bates  <dabates@apple.com>
3186
3187         Add WTF::move()
3188         https://bugs.webkit.org/show_bug.cgi?id=134500
3189
3190         Rubber-stamped by Anders Carlsson.
3191
3192         Substitute WTF::move() for std::move().
3193
3194         * DumpRenderTree/win/DRTDataObject.cpp:
3195         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3196         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3197         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3198         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3199         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3200         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
3201         aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
3202         ConstructionFromSameType, and ConstructionFromSimilarType.
3203         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3204
3205 2014-07-03  László Langó  <llango.u-szeged@partner.samsung.com>
3206
3207         [JavaScriptCore] Add --cmakeargs option to build-jsc.
3208         https://bugs.webkit.org/show_bug.cgi?id=134590
3209
3210         Reviewed by Ryosuke Niwa.
3211
3212         * Scripts/build-jsc:
3213
3214 2014-07-03  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3215
3216         Add option to specify jsc args in run-sunspider.
3217         https://bugs.webkit.org/show_bug.cgi?id=134341
3218
3219         Reviewed by Csaba Osztrogonác.
3220
3221         * Scripts/run-sunspider:
3222
3223 2014-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3224
3225         [GTK] Unreviewed gardening.
3226
3227         * Scripts/run-gtk-tests:
3228         (TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
3229
3230 2014-07-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3231
3232         Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
3233         https://bugs.webkit.org/show_bug.cgi?id=134581
3234
3235         Reviewed by Tim Horton.
3236
3237         Should be removed unused EFL bot info.
3238
3239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3241         (EWS):
3242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3243         (WebKitBuildbot):
3244         * TestResultServer/static-dashboards/builders.jsonp:
3245         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3246         (test):
3247
3248 2014-07-02  Alex Christensen  <achristensen@webkit.org>
3249
3250         Unreviewed.  Moved self to reviewers list.
3251
3252         * Scripts/webkitpy/common/config/contributors.json:
3253         Moved self to reviewers list, added WebGL to expertise.
3254
3255 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3256
3257         [GTK] Make dist only works when run from the source directory
3258         https://bugs.webkit.org/show_bug.cgi?id=134543
3259
3260         Reviewed by Martin Robinson.
3261
3262         Since the paths in the manifest are relative to the source dir,
3263         and the script expects the current working directory to be the
3264         source directory, resolve all passed in relative paths while
3265         parsing the arguments and then change the current working
3266         directory.
3267
3268         * gtk/make-dist.py:
3269
3270 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3271
3272         [GTK] make dist is broken
3273         https://bugs.webkit.org/show_bug.cgi?id=134542
3274
3275         Reviewed by Martin Robinson.
3276
3277         * gtk/make-dist.py: Rename command line options to match what cmake uses.
3278         * gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
3279
3280 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3281
3282         [GTK] WebKitWebView::create should receive information about the navigation action
3283         https://bugs.webkit.org/show_bug.cgi?id=133680
3284
3285         Reviewed by Martin Robinson.
3286
3287         Add unit test to check the WebKitNavigationAction passed to
3288         WebKitWebView::create callback.
3289
3290         * MiniBrowser/gtk/BrowserWindow.c:
3291         (webViewCreate): Add WebKitNavigationAction parameter.
3292         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3293         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3294         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3295         (testWebViewCreateNavigationData):
3296         (beforeAll):
3297         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
3298         (createCallback):
3299
3300 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3301
3302         [GTK] Do not add forward declaration of class struct for interfaces
3303         https://bugs.webkit.org/show_bug.cgi?id=134297
3304
3305         Reviewed by Martin Robinson.
3306
3307         Add Iface symbol to documentation instead of Class for interfaces.
3308
3309         * gtk/webkitdom.py:
3310         (WebKitDOMDocGeneratorSections.write_section):
3311
3312 2014-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3313
3314         [GTK] XPathNSResolver should be exposed as an interface instead of as a class
3315         https://bugs.webkit.org/show_bug.cgi?id=134028
3316
3317         Reviewed by Gustavo Noronha Silva.
3318
3319         Add unit tests to check WebKitDOMXPathNSResolver API when using the
3320         native one and a user provided one.
3321
3322         * Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
3323         to the list of GTK+ public API exceptions.
3324         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
3325         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
3326         (webkitXPathNSResolverLookupNamespaceURI):
3327         (webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
3328         (webkit_xpath_ns_resolver_init):
3329         (webkit_xpath_ns_resolver_class_init):
3330         (WebKitDOMXPathNSResolverTest::create):
3331         (WebKitDOMXPathNSResolverTest::webPageFromArgs):
3332         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3333         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3334         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3335         (WebKitDOMXPathNSResolverTest::runTest):
3336         (registerTests):
3337         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
3338         (runTest):
3339         (testWebKitDOMXPathNSResolverNative):
3340         (testWebKitDOMXPathNSResolverCustom):
3341         (serverCallback):
3342         (beforeAll):
3343         (afterAll):
3344         * gtk/webkitdom.py:
3345         (WebKitDOMDocGeneratorSections.write_section): Add
3346         WebKitDOMXPathNSResolver to the list of interfaces.
3347
3348 2014-07-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3349
3350         Fix build break on EFL and GTK ports since r170683
3351         https://bugs.webkit.org/show_bug.cgi?id=134536
3352
3353         Unreviewed, build fix.
3354
3355         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3356
3357 2014-07-01  Sam Weinig  <sam@webkit.org>
3358
3359         [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
3360         <rdar://problem/17523159>
3361         https://bugs.webkit.org/show_bug.cgi?id=134496
3362
3363         Reviewed by Beth Dakin.
3364
3365         * MiniBrowser/mac/BrowserWindowController.m:
3366         (-[BrowserWindowController windowDidLoad]):
3367         Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
3368
3369 2014-07-01  Zan Dobersek  <zdobersek@igalia.com>
3370
3371         [CMake] Add necessary support for building for the Wayland target
3372         https://bugs.webkit.org/show_bug.cgi?id=134160
3373
3374         Reviewed by Darin Adler.
3375
3376         * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
3377         the X11 windowing target is enabled.
3378
3379 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
3380
3381         AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
3382         https://bugs.webkit.org/show_bug.cgi?id=134492
3383
3384         Reviewed by Andreas Kling.
3385
3386         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3387         (AccessibilityUIElement::isIndeterminate):
3388         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3389         (WTR::AccessibilityUIElement::isIndeterminate):
3390
3391 2014-07-01  Daniel Bates  <dabates@apple.com>
3392
3393         Remove unnecessary calls to std::move()
3394         https://bugs.webkit.org/show_bug.cgi?id=134493
3395
3396         Reviewed by Anders Carlsson.
3397
3398         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3399         (TestWebKitAPI::TEST):
3400         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3401         (TestWebKitAPI::TEST):
3402
3403 2014-07-01  Pratik Solanki  <psolanki@apple.com>
3404
3405         Unreviewed. Adding myself to the reviewers list to make commit bot happy.
3406
3407         * Scripts/webkitpy/common/config/contributors.json:
3408
3409 2014-07-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3410
3411         webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
3412         https://bugs.webkit.org/show_bug.cgi?id=40095
3413
3414         Reviewed by Csaba Osztrogonác.
3415
3416         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3417         (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
3418         (Bugzilla):
3419         (Bugzilla.bug_id_for_attachment_id): ditto.
3420
3421 2014-07-01  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3422
3423         [webkitpy] Refactor pluralizer in grammar.py
3424         https://bugs.webkit.org/show_bug.cgi?id=133067
3425
3426         Reviewed by Csaba Osztrogonác.
3427
3428         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3429         (LayoutTestRunner.run_tests):
3430         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3431         (Manager.run):
3432         * Scripts/webkitpy/layout_tests/views/printing.py:
3433         (Printer.print_found):
3434         (Printer.print_workers_and_shards):
3435         (Printer._print_one_line_summary):
3436         * Scripts/webkitpy/test/printer.py:
3437         (Printer.print_result):
3438         * Scripts/webkitpy/tool/bot/feeders.py:
3439         (EWSFeeder.feed):
3440         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3441         (FlakyTestReporter._lookup_bug_for_flaky_test):
3442         * Scripts/webkitpy/tool/bot/irc_command.py:
3443         (Rollout._check_diff_failure):
3444         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3445         (IRCCommandTest.test_rollout):
3446         * Scripts/webkitpy/tool/commands/download.py:
3447         (AbstractPatchProcessingCommand._process_patch.execute):
3448         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3449         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3450         * Scripts/webkitpy/tool/commands/queries.py:
3451         (WhatBroke.execute):
3452         * Scripts/webkitpy/tool/commands/suggestnominations.py:
3453         (SuggestNominations._print_nominations):
3454         (SuggestNominations._print_counts):
3455         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3456         (_make_options):
3457         (test_basic):
3458         (test_with_verbose):
3459         * Scripts/webkitpy/tool/commands/upload.py:
3460         (PostCommits.execute):
3461         * Scripts/webkitpy/tool/grammar.py:
3462         (pluralize):
3463         * Scripts/webkitpy/tool/grammar_unittest.py:
3464         (GrammarTest.test_join_with_separators):
3465         (GrammarTest):
3466         (GrammarTest.test_plural):
3467         (GrammarTest.test_pluralize):
3468         * Scripts/webkitpy/tool/multicommandtool.py:
3469         (Command.check_arguments_and_execute):
3470         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3471         (ObsoletePatches.run):
3472         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3473         (PrepareChangeLogForRevert._message_for_revert):
3474
3475 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
3476
3477         [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
3478         https://bugs.webkit.org/show_bug.cgi?id=134133
3479
3480         Reviewed by Simon Fraser.
3481
3482         Replace it with CTFontManagerRegisterGraphicsFont
3483
3484         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3485         * DumpRenderTree/mac/DumpRenderTree.mm:
3486         (activateFontIOS):
3487
3488 2014-06-30  Michael Saboff  <msaboff@apple.com>
3489
3490         Add option to run-jsc-stress-testes to filter out tests that use large heaps
3491         https://bugs.webkit.org/show_bug.cgi?id=134458
3492
3493         Reviewed by Filip Pizlo.
3494
3495         Added new --memory-limited to filter out tests that have large heap usage.
3496         Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
3497
3498         * Scripts/run-jsc-stress-tests:
3499
3500 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
3501
3502         DRT in iOS sim crashes while loading fonts
3503         https://bugs.webkit.org/show_bug.cgi?id=134451
3504
3505         Reviewed by Geoffrey Garen.
3506
3507         The magic linker symbols had the same name, and were therefore being unified
3508         to a single font file. Then, adding the same file twice was failing.
3509
3510         * DumpRenderTree/mac/DumpRenderTree.mm:
3511         (activateFontsIOS):
3512
3513 2014-06-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3514
3515         Remove Qt cruft from webkitpy
3516         https://bugs.webkit.org/show_bug.cgi?id=134445
3517
3518         Reviewed by Csaba Osztrogonác.
3519
3520         * Scripts/webkitpy/common/config/ports.py:
3521         (DeprecatedPort.port):
3522         (QtPort): Deleted.
3523         (QtPort.build_webkit_command): Deleted.
3524         (QtPort.run_webkit_tests_command): Deleted.
3525         (QtWK2Port): Deleted.
3526         (QtWK2Port.build_webkit_command): Deleted.
3527         (QtWK2Port.run_webkit_tests_command): Deleted.
3528         * Scripts/webkitpy/common/config/ports_unittest.py:
3529         (DeprecatedPortTest): Deleted.
3530         (DeprecatedPortTest.test_qt_port): Deleted.
3531         (DeprecatedPortTest.test_qt_wk2_port): Deleted.
3532
3533 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
3534
3535         Add support for HTMLImageElement's sizes attribute
3536         https://bugs.webkit.org/show_bug.cgi?id=133620
3537
3538         Reviewed by Dean Jackson.
3539
3540         Added an ENABLE_PICTURE_SIZES compile flag.
3541
3542         * Scripts/webkitperl/FeatureList.pm:
3543
3544 2014-06-27  Tim Horton  <timothy_horton@apple.com>
3545
3546         check-webkit-style should check the order of #imports as well as #includes
3547         https://bugs.webkit.org/show_bug.cgi?id=134428
3548
3549         Reviewed by Dan Bernstein.
3550
3551         * Scripts/webkitpy/style/checkers/cpp.py:
3552         Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
3553
3554 2014-06-27  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3555
3556         [EFL] Remove efl-wk2 from baseline search path
3557         https://bugs.webkit.org/show_bug.cgi?id=134391
3558
3559         Reviewed by Gyuyoung Kim.
3560
3561         As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
3562         are merged efl-wk2 search path should be removed.
3563
3564         * Scripts/webkitpy/port/base.py:
3565         (Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
3566         * Scripts/webkitpy/port/efl.py:
3567         (EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
3568         (EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
3569         * Scripts/webkitpy/port/port_testcase.py:
3570         (PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
3571         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3572         (TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
3573         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3574         (TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
3575
3576 2014-06-26  Dan Bernstein  <mitz@apple.com>
3577
3578         prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
3579         https://bugs.webkit.org/show_bug.cgi?id=134387
3580
3581         Reviewed by Tim Horton.
3582
3583         * Scripts/prepare-ChangeLog:
3584         (get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
3585
3586 2014-06-26  Dan Bernstein  <mitz@apple.com>
3587
3588         prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
3589         https://bugs.webkit.org/show_bug.cgi?id=134383
3590
3591         Reviewed by Tim Horton.
3592
3593         * Scripts/prepare-ChangeLog:
3594         (method_decl_to_selector): Strip out the return type and parameter types before splitting at
3595         colons.
3596
3597 2014-06-26  Brady Eidson  <beidson@apple.com>
3598
3599         MiniBrowser should support a preference to override the default URL
3600         https://bugs.webkit.org/show_bug.cgi?id=134373
3601
3602         Reviewed by Darin Adler.
3603
3604         * MiniBrowser/mac/AppDelegate.m:
3605         (-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
3606           overriding the default URL, and use it if there is.
3607
3608 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
3609
3610         [Win] Fix potential buffer overrun in DLLLauncher
3611         https://bugs.webkit.org/show_bug.cgi?id=134351
3612         <rdar://problem/17469185>
3613
3614         Reviewed by Darin Adler.
3615
3616         * win/DLLLauncher/DLLLauncherMain.cpp: Correct error
3617         in end-of-buffer calculation.
3618
3619 2014-06-26  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3620
3621         [EFL] Missing dependency between freetype6 and fontconfig libs.
3622         https://bugs.webkit.org/show_bug.cgi?id=134190
3623
3624         Reviewed by Gyuyoung Kim.
3625
3626         The external dependencies contain the freetype6 and the fontconfig libs.
3627         The fontconfig lib requires freetype, but the dependency is not set in
3628         the efl/jhbuild.modules file. So, during building the external libs,
3629         fontconfig uses the freetype package of the system, while WebKit
3630         binaries will use freetype from the WebKitBuild/Dependency directory.
3631         There are more similar dependencies that were not indicated in the
3632         jhbuild.modules file.
3633
3634         * efl/jhbuild.modules:
3635           Added dependencies between libs.
3636
3637 2014-06-25  Brent Fulgham  <bfulgham@apple.com>
3638
3639         [Win] Expose Cache Information to WinLauncher
3640         https://bugs.webkit.org/show_bug.cgi?id=134318
3641
3642         Reviewed by Dean Jackson.
3643
3644         * WinLauncher/Common.cpp: Update for new dialog.
3645         * WinLauncher/WinLauncher.cpp: Add support for WebCache
3646         and WebCoreStatistics.
3647         * WinLauncher/WinLauncher.h:
3648         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3649         Update for new Cache Dialog.
3650         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
3651         WTF.lib
3652         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
3653         for new Dialog.
3654
3655 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
3656
3657         [Win] Unreviewed gardening. Use consistent line-endings in file.
3658
3659         * WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
3660         '\r\n' EOL.
3661
3662 2014-06-25  László Langó  <llango.u-szeged@partner.samsung.com>
3663
3664         [JavaScriptCore] Make build-jsc output format better.
3665         https://bugs.webkit.org/show_bug.cgi?id=133547
3666
3667         Reviewed by Ryosuke Niwa.
3668
3669         * Scripts/build-jsc: Emit built time information on successful builds.
3670         (writeCongrats):