f3cd1ab210b25a735696699272dab567b3163959
[WebKit-https.git] / Tools / ChangeLog
1 2020-04-21  Philippe Normand  <pnormand@igalia.com>
2
3         [Flatpak SDK] Silence git stderr output
4         https://bugs.webkit.org/show_bug.cgi?id=210789
5
6         Reviewed by Sergio Villar Senin.
7
8         * flatpak/flatpakutils.py:
9         (WebkitFlatpak.is_branch_build): Don't display git errors, usually
10         emitted when operating on a SVN checkout.
11
12 2020-04-21  Philippe Normand  <pnormand@igalia.com>
13
14         [CMake][Flatpak SDK] gst-build-backed build fails
15         https://bugs.webkit.org/show_bug.cgi?id=210742
16
17         Reviewed by Xabier Rodriguez-Calvar.
18
19         Add non-core GStreamer include-dirs necessary for the compilation
20         of the GStreamer API test. Usually GSTREAMER_INCLUDE_DIRS is
21         sufficient because on a GStreamer system-wide installation, all
22         headers are stored in the same root include dir, the same as the
23         core GStreamer library.
24
25         But when building with gst-build, include-dirs are scattered all
26         over the place.
27
28         * TestWebKitAPI/PlatformGTK.cmake:
29         * TestWebKitAPI/PlatformWPE.cmake:
30
31 2020-04-20  Ross Kirsling  <ross.kirsling@sony.com>
32
33         Classes marked final should not use protected access specifier
34         https://bugs.webkit.org/show_bug.cgi?id=210775
35
36         Reviewed by Daniel Bates.
37
38         * DumpRenderTree/win/DefaultPolicyDelegate.h:
39         * DumpRenderTree/win/UIDelegate.h:
40
41 2020-04-20  Peng Liu  <peng.liu6@apple.com>
42
43         Fix build failures when video fullscreen and picture-in-picture is disabled
44         https://bugs.webkit.org/show_bug.cgi?id=210777
45
46         Reviewed by Eric Carlson.
47
48         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
49
50 2020-04-20  Alex Christensen  <achristensen@webkit.org>
51
52         SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
53         https://bugs.webkit.org/show_bug.cgi?id=210533
54
55         Reviewed by Brady Eidson.
56
57         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
58         (-[TLSNavigationDelegate waitForDidNegotiateModernTLS]):
59         (-[TLSNavigationDelegate _webView:didNegotiateModernTLS:]):
60         (TestWebKitAPI::TEST):
61
62 2020-04-20  Kate Cheney  <katherine_cheney@apple.com>
63
64         App-bound domain behavior should abide by the limitsNavigationsToAppBoundDomains argument in WKWebView configuration
65         https://bugs.webkit.org/show_bug.cgi?id=210769
66         <rdar://problem/62065241>
67
68         Reviewed by Brent Fulgham.
69
70         Removes any tests for swapping between app-bound and non app-bound
71         domains as this behavior is no longer supported.
72
73         Sets the limitsNavigationsToAppBoundDomains flag for tests which should
74         have app-bound behavior to maintain test functionality.
75
76         Adds 5 new tests for new behavior.
77
78         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
79         (TEST):
80         (-[AppBoundDomainDelegate webView:didFinishNavigation:]):
81         (-[AppBoundDomainDelegate webView:didFailProvisionalNavigation:withError:]):
82         (-[AppBoundDomainDelegate waitForDidFinishNavigation]):
83         (-[AppBoundDomainDelegate waitForDidFailProvisionalNavigationError]):
84
85 2020-04-20  Megan Gardner  <megan_gardner@apple.com>
86
87         Date and Time form controls not showing correct initial values on immediate second invocation.
88         https://bugs.webkit.org/show_bug.cgi?id=210613
89
90         Reviewed by Wenson Hsieh.
91
92         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
93         * TestRunnerShared/UIScriptContext/UIScriptController.h:
94         (WTR::UIScriptController::timePickerValueHour const):
95         (WTR::UIScriptController::timePickerValueMinute const):
96         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
97         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
98         (WTR::UIScriptControllerIOS::timePickerValueHour const):
99         (WTR::UIScriptControllerIOS::timePickerValueMinute const):
100
101 2020-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
102
103         Text manipulation sometimes fails to replace text in title elements
104         https://bugs.webkit.org/show_bug.cgi?id=210750
105         <rdar://problem/61066103>
106
107         Reviewed by Tim Horton and Darin Adler.
108
109         Add a new API test to verify that a single title or option element may be replaced with multiple tokens, as long
110         as all the token identifiers match.
111
112         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
113
114 2020-04-20  Stephan Szabo  <stephan.szabo@sony.com>
115
116         [PlayStation] Fix build after r260277
117         https://bugs.webkit.org/show_bug.cgi?id=210756
118
119         Reviewed by Don Olmstead.
120
121         * TestWebKitAPI/PlatformPlayStation.cmake:
122
123 2020-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
124
125         Oversized caret and selection rects in text fields on ganji.com and netflix.com/login
126         https://bugs.webkit.org/show_bug.cgi?id=210622
127         <rdar://problem/45945636>
128
129         Reviewed by Darin Adler.
130
131         Rebaseline some expected selection and caret rects in some iOS API tests.
132
133         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
134         (TestWebKitAPI::TEST):
135         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
136         (TEST):
137         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
138         (TestWebKitAPI::TEST):
139
140 2020-04-20  Darin Adler  <darin@apple.com>
141
142         Use #import instead of #include in Objective-C and don't use #pragma once
143         https://bugs.webkit.org/show_bug.cgi?id=210724
144
145         Reviewed by David Kilzer.
146
147         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
148         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
149         * DumpRenderTree/mac/AccessibilityCommonMac.h:
150         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
151         * TestRunnerShared/cocoa/ClassMethodSwizzler.mm:
152         * TestRunnerShared/cocoa/InstanceMethodSwizzler.mm:
153         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
154         * TestRunnerShared/mac/NSPasteboardAdditions.h:
155         * TestRunnerShared/spi/AppKitTestSPI.h:
156         * TestRunnerShared/spi/PencilKitTestSPI.h:
157         * TestWebKitAPI/DataDetectorsCoreSPI.h:
158         * TestWebKitAPI/EditingTestHarness.h:
159         * TestWebKitAPI/EditingTestHarness.mm:
160         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
161         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
162         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
163         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
164         * TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm:
165         * TestWebKitAPI/Tests/WebKit/AccessibilityRemoteUIApp.mm:
166         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm:
167         * TestWebKitAPI/Tests/WebKit/Battery.mm:
168         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
169         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
170         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
171         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm:
172         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
173         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm:
174         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm:
175         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
176         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
177         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm:
178         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
179         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
180         * TestWebKitAPI/Tests/WebKit/ViewportSizeForViewportUnits.mm:
181         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
182         * TestWebKitAPI/Tests/WebKit/WebFilter.mm:
183         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
184         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
185         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.h:
186         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
187         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter_Bundle.mm:
188         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
189         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
190         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
191         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
192         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
193         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm:
194         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm:
195         * TestWebKitAPI/Tests/WebKitCocoa/CookieAcceptPolicy.mm:
196         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
197         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
198         * TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm:
199         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
200         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm:
201         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
202         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
203         * TestWebKitAPI/Tests/WebKitCocoa/DeviceManagementRestrictions.mm:
204         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
205         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
206         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
207         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
208         * TestWebKitAPI/Tests/WebKitCocoa/FindInPageAPI.mm:
209         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm:
210         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
211         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm:
212         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
213         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
214         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
215         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
216         * TestWebKitAPI/Tests/WebKitCocoa/JavaScriptDuringNavigation.mm:
217         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm:
218         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
219         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
220         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm:
221         * TestWebKitAPI/Tests/WebKitCocoa/MediaType.mm:
222         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
223         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
224         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:
225         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
226         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:
227         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:
228         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
229         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
230         * TestWebKitAPI/Tests/WebKitCocoa/ObservedRenderingProgressEventsAfterCrash.mm:
231         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
232         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
233         * TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm:
234         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm:
235         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
236         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
237         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
238         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
239         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
240         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
241         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
242         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
243         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm:
244         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
245         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
246         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimerDoesntFireEarly.mm:
247         * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm:
248         * TestWebKitAPI/Tests/WebKitCocoa/ShouldGoToBackForwardListItem.mm:
249         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
250         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
251         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm:
252         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
253         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
254         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
255         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm:
256         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h:
257         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm:
258         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
259         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm:
260         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm:
261         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm:
262         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
263         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
264         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm:
265         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
266         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
267         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
268         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
269         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
270         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
271         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
272         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
273         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
274         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
275         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm:
276         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
277         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
278         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm:
279         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
280         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
281         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
282         * TestWebKitAPI/Tests/ios/SelectionByWord.mm:
283         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
284         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
285         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
286         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
287         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
288         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
289         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
290         * TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm:
291         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
292         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm:
293         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
294         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
295         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
296         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
297         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
298         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
299         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
300         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
301         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
302         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
303         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
304         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
305         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
306         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
307         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
308         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm:
309         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm:
310         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
311         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm:
312         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
313         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
314         * TestWebKitAPI/cocoa/NSItemProviderAdditions.h:
315         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
316         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
317         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
318         * TestWebKitAPI/cocoa/TestProtocol.mm:
319         * TestWebKitAPI/cocoa/TestUIDelegate.h:
320         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
321         * TestWebKitAPI/ios/PencilKitTestSPI.h:
322         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
323         * TestWebKitAPI/mac/NSFontPanelTesting.h:
324         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
325         * TestWebKitAPI/mac/OffscreenWindow.h:
326         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
327         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
328         * TestWebKitAPI/mac/TestDraggingInfo.h:
329         * TestWebKitAPI/mac/TestFilePromiseReceiver.h:
330         * TestWebKitAPI/mac/TestFontOptions.h:
331         * TestWebKitAPI/mac/TestInspectorBar.h:
332         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
333         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
334         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
335         * WebKitTestRunner/mac/PoseAsClass.mm:
336         More #import, less #pragma once.
337
338 2020-04-20  Diego Pino Garcia  <dpino@igalia.com>
339
340         [Flatpak SDK] Prevent exception when calling git in a non-git repository
341         https://bugs.webkit.org/show_bug.cgi?id=210737
342
343         Reviewed by Philippe Normand.
344
345         * flatpak/flatpakutils.py:
346         (WebkitFlatpak.is_branch_build): Return false if command executes in a
347         non-git repository (i.e SVN).
348
349 2020-04-20  Philippe Normand  <pnormand@igalia.com>
350
351         [Flatpak SDK] Drive-by fixes
352         https://bugs.webkit.org/show_bug.cgi?id=210557
353
354         Reviewed by Žan Doberšek.
355
356         * flatpak/flatpakutils.py:
357         (WebkitFlatpak.run_in_sandbox): Properly format error message.
358         (WebkitFlatpak.main): Show flatpak update output.
359
360 2020-04-20  Sergio Villar Senin  <svillar@igalia.com>
361
362         [WebXR][WPE] Let XR_RUNTIME_JSON environment variable go through for testing
363         https://bugs.webkit.org/show_bug.cgi?id=210738
364
365         Reviewed by Žan Doberšek.
366
367         The OpenXR loader might be instructed to load a specific runtime by
368         using the XR_RUNTIME_JSON environment variable. Let it get in for testing.
369
370         * Scripts/webkitpy/port/wpe.py:
371         (WPEPort.setup_environ_for_server): Copy XR_RUNTIME_JSON if set.
372
373 2020-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
374
375         [GTK][WPE] Enable resource load statistics
376         https://bugs.webkit.org/show_bug.cgi?id=210184
377
378         Reviewed by Žan Doberšek.
379
380         Implement TestController::loadedThirdPartyDomains() and TestController::clearLoadedThirdPartyDomains() for
381         non-cocoa ports.
382
383         * WebKitTestRunner/TestController.cpp:
384         (WTR::LoadedThirdPartyDomainsCallbackContext::LoadedThirdPartyDomainsCallbackContext):
385         (WTR::loadedThirdPartyDomainsCallback):
386         (WTR::TestController::loadedThirdPartyDomains):
387         (WTR::TestController::clearLoadedThirdPartyDomains):
388
389 2020-04-20  David Kilzer  <ddkilzer@apple.com>
390
391         check-webkit-style should not complain about missing config.h header in WebKitLegacy source files
392         <https://webkit.org/b/210734>
393
394         Reviewed by Darin Adler.
395
396         * Scripts/webkitpy/style/checkers/cpp.py:
397         (_NO_CONFIG_H_PATH_PATTERNS):
398         - Add '^Source/WebKitLegacy/' to the list.
399         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
400         (OrderOfIncludesTest.test_primary_header):
401         - Add test for Source/WebKitLegacy source file.
402
403 2020-04-19  Brady Eidson  <beidson@apple.com>
404
405         Add WKScriptMessageHandler API that asynchronously responds with a promise.
406         rdar://problem/57243492 and https://bugs.webkit.org/show_bug.cgi?id=206398
407
408         Reviewed by Andy Estes.
409
410         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
411         (TEST):
412         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
413         (-[AsyncScriptMessageHandler userContentController:didReceiveScriptMessage:replyHandler:]):
414
415 2020-04-19  Ross Kirsling  <ross.kirsling@sony.com>
416
417         [ECMA-402] Intl.RelativeTimeFormat missing in WebKit
418         https://bugs.webkit.org/show_bug.cgi?id=209770
419
420         Reviewed by Darin Adler.
421
422         * Scripts/run-jsc-stress-tests:
423         Add runIntlRelativeTimeFormatEnabled.
424
425 2020-04-19  Don Olmstead  <don.olmstead@sony.com>
426
427         [CMake] Consolidate TestNetscapePlugin build
428         https://bugs.webkit.org/show_bug.cgi?id=210691
429
430         Reviewed by Fujii Hironori.
431
432         The DumpRenderTree CMakeLists.txt contained a definition of TestNetscapePlugIn
433         which was used for WebKitLegacy ports. The TestNetscapePlugIn directory also had
434         a CMakeLists.txt used by GTK for its port. The definitions in DumpRenderTree's
435         CMake are moved into the TestNetscapePlugIn CMake to provide a common definition
436         for all ports that ENABLE_NETSCAPE_PLUGIN_API.
437
438         * DumpRenderTree/CMakeLists.txt:
439         * DumpRenderTree/PlatformWin.cmake:
440         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
441         * DumpRenderTree/TestNetscapePlugIn/PlatformGTK.cmake: Added.
442         * DumpRenderTree/TestNetscapePlugIn/PlatformWin.cmake: Added.
443         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugIn.def: Renamed from Tools/DumpRenderTree/win/TestNetscapePlugin.def.
444         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugIn.rc: Renamed from Tools/DumpRenderTree/win/TestNetscapePlugin.rc.
445         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from Tools/DumpRenderTree/win/resource.h.
446
447 2020-04-19  Emilio Cobos Álvarez  <emilio@crisal.io>
448
449         Allow to override sccache server port.
450         https://bugs.webkit.org/show_bug.cgi?id=210722
451
452         Reviewed by Philippe Normand.
453
454         This is useful so that sccache can work both inside and outside the sandbox,
455         without getting confused about flatpak's chroot.
456
457         * flatpak/flatpakutils.py:
458         (WebkitFlatpak.run_in_sandbox):
459
460 2020-04-19  Darin Adler  <darin@apple.com>
461
462         REGRESSION (r260334): SpacebarScrolling.cpp (test in TestWebKitAPI) fails to compile because it includes an Objective-C header
463         https://bugs.webkit.org/show_bug.cgi?id=210723
464
465         Reviewed by Brady Eidson.
466
467         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp: Instead of including
468         WKPreferencesPrivate.h, an Objective-C header, include WKPreferencesRefPrivate.h,
469         the header with the functions this test is trying to use.
470
471 2020-04-18  Darin Adler  <darin@apple.com>
472
473         Update header postprocessing version cutoff to keep Apple internal builds working
474         https://bugs.webkit.org/show_bug.cgi?id=210708
475
476         Reviewed by Brady Eidson.
477
478         * DumpRenderTree/ios/TextInputControllerIOS.m:
479         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
480         * DumpRenderTree/mac/EditingDelegate.mm:
481         * DumpRenderTree/mac/EventSendingController.h:
482         * DumpRenderTree/mac/EventSendingController.mm:
483         * DumpRenderTree/mac/FrameLoadDelegate.mm:
484         * DumpRenderTree/mac/ObjCPlugin.m:
485         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
486         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
487         * DumpRenderTree/mac/UIScriptControllerMac.mm:
488         Removed includes of <WebKit/WebKit.h>, the header for modern WebKit, from the files
489         here that are intending to use WebKitLegacy. This is harmless, except for if someone
490         builds DumpRenderTree *before* building WebKit as I just did.
491
492 2020-04-18  Brady Eidson  <beidson@apple.com>
493
494         Fix WebUserContentControllerProxy vs ContentWorld lifetime
495         https://bugs.webkit.org/show_bug.cgi?id=210700
496
497         Reviewed by Alex Christensen.
498
499         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
500         (-[DummyMessageHandler userContentController:didReceiveScriptMessage:]):
501         (TEST): Make sure removing a script message handler from a particular world
502           doesn't also destroy the other JavaScript contents of that world.
503
504 2020-04-18  Daniel Bates  <dabates@apple.com>
505
506         Add some more tests for -focusTextInputContext:placeCaretAt:completionHandler:
507         https://bugs.webkit.org/show_bug.cgi?id=210624
508
509         Reviewed by Simon Fraser.
510
511         Test behavior when the target element is already focused, when the target element
512         is programmatically replaced, and focusing the target element after the page was
513         navigated away.
514
515         Also while I am here, fix up the test FocusFieldAndPlaceCaretOutsideField to
516         use the size of the exampleText constant - 1 instead of hardcoding this value.
517         This will future proof this test should the example text string literal change.
518
519         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
520         (TEST):
521
522 2020-04-18  Alex Christensen  <achristensen@webkit.org>
523
524         Fix client certificate authentication when using non-default WKWebsiteDataStores
525         https://bugs.webkit.org/show_bug.cgi?id=210681
526
527         Reviewed by Brady Eidson.
528
529         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
530         (TestWebKitAPI::TEST):
531
532 2020-04-17  Kate Cheney  <katherine_cheney@apple.com>
533
534         Enable service workers for app-bound domains
535         https://bugs.webkit.org/show_bug.cgi?id=210451
536         <rdar://problem/61479474>
537
538         Reviewed by Brent Fulgham.
539
540         Adds 2 test cases to make sure service workers behave properly on
541         app bound domains, and that the APIs are not available on non-app
542         bound domains.
543
544         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
545         (-[SWInAppBrowserPrivacyMessageHandler userContentController:didReceiveScriptMessage:]):
546
547 2020-04-17  Alex Christensen  <achristensen@webkit.org>
548
549         NetworkSessionCocoa should request client certificate only once per host/port
550         https://bugs.webkit.org/show_bug.cgi?id=210626
551         <rdar://problem/60340449>
552
553         Reviewed by Geoffrey Garen.
554
555         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
556         (TestWebKitAPI::clientCertServerWithCertVerifier):
557         (TestWebKitAPI::TEST):
558         * TestWebKitAPI/cocoa/HTTPServer.h:
559         (TestWebKitAPI::HTTPServer::HTTPResponse::HTTPResponse):
560         * TestWebKitAPI/cocoa/HTTPServer.mm:
561         (TestWebKitAPI::HTTPServer::HTTPServer):
562
563 2020-04-17  David Kilzer  <ddkilzer@apple.com>
564
565         Bug 210645: REGRESSION (r211095): [iOS] TestRunnerWKWebView leaks @property accessibilitySpeakSelectionContent
566         <https://webkit.org/b/210645>
567         <rdar://problem/61927607>
568
569         Reviewed by Chris Fleizach.
570
571         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
572         (-[TestRunnerWKWebView dealloc]):
573         - Release accessibilitySpeakSelectionContent in -dealloc.
574
575 2020-04-17  Brady Eidson  <beidson@apple.com>
576
577         Pass sandbox extensions for back/forward list navigations after the policy is decided at process-swap time.
578         <rdar://problem/59535167> and https://bugs.webkit.org/show_bug.cgi?id=210623
579
580         Reviewed by Geoff Garen.
581
582         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
583
584 2020-04-17  Brent Fulgham  <bfulgham@apple.com>
585
586         Unreviewed build fix after r260269.
587
588         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
589         (TEST): Correct argument order.
590
591 2020-04-17  Jer Noble  <jer.noble@apple.com>
592
593         Bring Fullscreen API + alert() behavior from iOS to macOS
594         https://bugs.webkit.org/show_bug.cgi?id=210662
595
596         Reviewed by Eric Carlson.
597
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm: Added.
600         (TestWebKitAPI::TEST):
601
602 2020-04-17  Don Olmstead  <don.olmstead@sony.com>
603
604         [CMake] Add WebKit::WebCore target
605         https://bugs.webkit.org/show_bug.cgi?id=210445
606
607         Reviewed by Michael Catanzaro.
608
609         Use the WebKit::WebCore target within tests and developer tools.
610
611         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
612         * MiniBrowser/wpe/CMakeLists.txt:
613         * TestWebKitAPI/CMakeLists.txt:
614         * TestWebKitAPI/PlatformGTK.cmake:
615         * TestWebKitAPI/PlatformWPE.cmake:
616         * TestWebKitAPI/PlatformWin.cmake:
617         * TestWebKitAPI/glib/CMakeLists.txt:
618
619 2020-04-17  Antoine Quint  <graouts@apple.com>
620
621         Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled
622         https://bugs.webkit.org/show_bug.cgi?id=210606
623
624         Unreviewed build fix after r260261.
625
626         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
627         (TEST):
628
629 2020-04-17  Claudio Saavedra  <csaavedra@igalia.com>
630
631         [GTK] Update for GdkKeymap API changes
632         https://bugs.webkit.org/show_bug.cgi?id=210642
633
634         Reviewed by Adrian Perez de Castro.
635
636         No new tests needed.
637
638         gdk_keymap_get_default() is deprecated in GTK+ 3.22, so use
639         gdk_keymap_get_for_display() instead. Since in GTK4 this method is
640         removed to gdk_display_get_keymap(), add a helper to
641         GtkVersioning.h to avoid cluttering with ifdefs all over the
642         place.
643
644         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
645         (WebViewTest::keyStroke):
646         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
647         (TestWebKitAPI::doKeyStroke):
648         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
649         (WTR::EventSenderProxy::keyDown):
650
651 2020-04-17  Antoine Quint  <graouts@apple.com>
652
653         Allow the UserStyleLevel to be set through _WKUserStyleSheet
654         https://bugs.webkit.org/show_bug.cgi?id=210653
655         <rdar://problem/60506645>
656
657         Reviewed by Tim Horton.
658
659         Add new tests for the "level" parameter when creating a _WKUserStyleSheet.
660
661         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
662         (TEST):
663
664 2020-04-17  David Kilzer  <ddkilzer@apple.com>
665
666         REGRESSION (r162729): [iOS] WebKitTestRunner over-releases UITextField in WTR::PlatformWebView::removeChromeInputField()
667         <https://webkit.org/b/210643>
668         <rdar://problem/61927190>
669
670         Reviewed by Wenson Hsieh.
671
672         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
673         (WTR::PlatformWebView::removeChromeInputField):
674         - Remove unnecessary -release.
675
676 2020-04-17  Per Arne Vollan  <pvollan@apple.com>
677
678         [iOS] Deny iokit open access to graphics related classes
679         https://bugs.webkit.org/show_bug.cgi?id=210616
680
681         Reviewed by Darin Adler.
682
683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
684         * TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm: Added.
685         (TEST):
686
687 2020-04-17  Philippe Normand  <pnormand@igalia.com>
688
689         [Flatpak SDK] Not fully hooked in BuildSlaveSupport
690         https://bugs.webkit.org/show_bug.cgi?id=210548
691
692         Reviewed by Carlos Alberto Lopez Perez.
693
694         * Scripts/webkitdirs.pm:
695         (determineBaseProductDir): Flatpak SDK builds use a dedicated product directory per port.
696
697 2020-04-16  Lauro Moura  <lmoura@igalia.com>
698
699         [GTK] A couple of API tests are flaky failing on X11.
700
701         Unreviewed test gardening.
702
703         * TestWebKitAPI/glib/TestExpectations.json:
704
705 2020-04-16  Daniel Bates  <dabates@apple.com>
706
707         Remove unused -_focusTextInputContext
708         https://bugs.webkit.org/show_bug.cgi?id=210619
709
710         Reviewed by Darin Adler.
711
712         Remove test now that the SPI was removed.
713
714         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
715         (-[TestWKWebView synchronouslyFocusTextInputContext:]): Deleted.
716
717 2020-04-16  Yusuke Suzuki  <ysuzuki@apple.com>
718
719         Add slack-aware WKR implementation
720         https://bugs.webkit.org/show_bug.cgi?id=210425
721
722         Reviewed by Alexey Proskuryakov.
723
724         This patch adds new WKR implementation, which is posting changes to #changes in WebKit slack.
725         Currently, we are polling git.webkit.org's feed once a minute. The more efficient way to implement
726         this bot is introducing post-commit hook, but for now, this polling strategy just works.
727
728         * WKR/.gitignore: Added.
729         * WKR/ReadMe.md: Added.
730         * WKR/WKR.mjs: Added.
731         * WKR/data/.gitignore: Added.
732         * WKR/package-lock.json: Added.
733         * WKR/package.json: Added.
734
735 2020-04-16  Daniel Bates  <dabates@apple.com>
736
737         [iOS] Add a way to focus a text input and place a caret
738         https://bugs.webkit.org/show_bug.cgi?id=210611
739         <rdar://problem/61893062>
740
741         Reviewed by Darin Adler.
742
743         Add some tests.
744
745         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
746         (-[TestWKWebView synchronouslyFocusTextInputContext:placeCaretAt:]): Added.
747         (webViewLoadHTMLStringAndWaitForAllFramesToPaint): Use the bundle's TestWebKitAPI.resources directory
748         as the base URL so that we have a valid file URL. Some of the tests will then
749         call -_setAllowUniversalAccessFromFileURLs to allow the main frame access to
750         the unique-origin child frame contents.
751         (TEST):
752
753 2020-04-16  Daniel Bates  <dabates@apple.com>
754
755         REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable
756         https://bugs.webkit.org/show_bug.cgi?id=210558
757         <rdar://problem/61798347>
758
759         Reviewed by Wenson Hsieh.
760
761         Add a test.
762
763         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
764         (TEST):
765
766 2020-04-16  Daniel Bates  <dabates@apple.com>
767
768         Move -_requestTextInputContextsInRect to WKContentView to simplify implementation
769         https://bugs.webkit.org/show_bug.cgi?id=210398
770         <rdar://problem/61656931>
771
772         Reviewed by Darin Adler.
773
774         Update test now that -_requestTextInputContextsInRect has moved from WKWebView to WKContentView.
775         I expose new testing-only WKWebView SPI to access it on the content view.
776
777         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
778         (-[TestWKWebView synchronouslyRequestDocumentContext:]): Added; due to category name change.
779         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]): Added; due to category name change.
780         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
781         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]): Deleted; due to category name change.
782         (-[WKWebView synchronouslyFocusTextInputContext:]): Deleted; due to category name change.
783         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
784         (WTR::UIScriptControllerIOS::mayContainEditableElementsInRect): Convert from content coordinates
785         to WKWebView coordinates now that -_mayContainEditableElementsInRect expects it.
786
787 2020-04-16  Philippe Normand  <pnormand@igalia.com>
788
789         Unreviewed, GTK clean build fix after r260132.
790
791         * TestWebKitAPI/gtk/main.cpp:
792         (main): Don't use GtkVersioning here. A dependency on the WebCore
793         private headers for this single file is overkill.
794
795 2020-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
796
797         [GTK] MiniBrowser opens new windows too small causing failures on some WPT tests
798         https://bugs.webkit.org/show_bug.cgi?id=210206
799
800         Reviewed by Carlos Garcia Campos.
801
802         Add two API test to check that window.open() by default gets a size
803         request equal to the old window if there is no default window size,
804         or to the default window if there is a default window size.
805
806         A new function helper setCreateNewWebViewsInWindowsWithDefaultSize()
807         its added to create new webviews in new windows automatically, which
808         its needed to test the case of having a default window size.
809
810         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
811         (testWebViewWindowProperties):
812         (testWebViewOpenWindowDefaultSize):
813         (testWebViewOpenWindowNoDefaultSize):
814         (beforeAll):
815
816 2020-04-15  Tim Horton  <timothy_horton@apple.com>
817
818         REGRESSION (r258337): Crash when right clicking on link that uses the system UI font with optimizeLegibility on Mojave
819         https://bugs.webkit.org/show_bug.cgi?id=210575
820         <rdar://problem/61646717>
821
822         Reviewed by Darin Adler.
823
824         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
825         (TEST):
826         Add an API test ensuring that we can encode and decode a NSAttributedString
827         that includes a system-ui font with optimizeLegibility on.
828
829 2020-04-15  John Wilander  <wilander@apple.com>
830
831         Add SPI to configure WebsiteDataStores with a URL for standalone web applications and use it to disable first-party website data removal in ITP
832         https://bugs.webkit.org/show_bug.cgi?id=209634
833         <rdar://problem/60943970>
834
835         Reviewed by Alex Christensen.
836
837         Added a new test option called standaloneWebApplicationURL so that layout tests can
838         configure the website data store accordingly. Picking it up and using it requires
839         creating a new website data store with a configuration that has the standalone web
840         application URL.
841
842         * WebKitTestRunner/TestController.cpp:
843         (WTR::TestController::configureWebsiteDataStoreTemporaryDirectories):
844         (WTR::TestController::defaultWebsiteDataStore):
845         (WTR::parseStringTestHeaderValueAsURL):
846         (WTR::updateTestOptionsFromTestHeader):
847         * WebKitTestRunner/TestController.h:
848         * WebKitTestRunner/TestOptions.h:
849         (WTR::TestOptions::hasSameInitializationOptions const):
850         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
851         (WTR::TestController::platformCreateWebView):
852
853 2020-04-15  Chris Dumez  <cdumez@apple.com>
854
855         [IPC Hardening] MachMessage::messageSize() should use checked arithmetic
856         https://bugs.webkit.org/show_bug.cgi?id=210567
857         <rdar://problem/61734355>
858
859         Reviewed by Geoff Garen.
860
861         Add API test coverage for / operator in Checked.
862
863         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
864         (TestWebKitAPI::TEST):
865
866 2020-04-15  Brent Fulgham  <bfulgham@apple.com>
867
868         [Cocoa] Remove generic parameter serialization fallback
869         https://bugs.webkit.org/show_bug.cgi?id=210509
870         <rdar://problem/55522650>
871
872         Reviewed by Geoffrey Garen.
873
874         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegate.mm:
875         (WKWebProcessPlugInWithoutRegisteredCustomClass): Update to reflect
876         fact that we block serialization of unregistered classes.
877
878 2020-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
879
880         [GTK4] Fix use of gtk init functions
881         https://bugs.webkit.org/show_bug.cgi?id=210550
882
883         Reviewed by Adrian Perez de Castro.
884
885         Include GtkVersioning.h instead of gtk.h.
886
887         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
888         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
889         * TestWebKitAPI/gtk/main.cpp:
890         * WebKitTestRunner/gtk/main.cpp:
891
892 2020-04-15  Jonathan Bedard  <jbedard@apple.com>
893
894         REGRESSION: [ Mojave+ Debug WK1 ] Layout Test imported/blink/storage/indexeddb/blob-basics-metadata.html is a flaky timeout
895         https://bugs.webkit.org/show_bug.cgi?id=199117
896         <rdar://problem/52967035>
897
898         Reviewed by Alexey Proskuryakov.
899
900         * Scripts/run-javascriptcore-tests: Set JSC_useKernTCSM to false.
901         * Scripts/webkitpy/port/base.py:
902         (Port.setup_environ_for_server): Forward JSC_useKernTCSM.
903         * Scripts/webkitpy/port/driver.py:
904         (Driver._setup_environ_for_driver): Set JSC_useKernTCSM to false.
905
906 2020-04-15  Devin Rousso  <drousso@apple.com>
907
908         [ESNext] Implement logical assignment operators
909         https://bugs.webkit.org/show_bug.cgi?id=209716
910
911         Reviewed by Ross Kirsling.
912
913         * Scripts/run-jsc-stress-tests:
914
915 2020-04-14  Jer Noble  <jer.noble@apple.com>
916
917         WKTR always enables capturing audio/video in GPUProcess
918         https://bugs.webkit.org/show_bug.cgi?id=210319
919
920         Reviewed by Tim Horton.
921
922         Capturing in the GPUProcess should be off by default. GPU capture can be enabled at runtime via
923         the --internal-feature flag of run-webkit-tests.
924
925         * WebKitTestRunner/TestOptions.h:
926
927 2020-04-14  Peng Liu  <peng.liu6@apple.com>
928
929         Adopt interface AVAudioRoutingArbiter for Mac
930         https://bugs.webkit.org/show_bug.cgi?id=210167
931
932         Reviewed by Eric Carlson.
933
934         Add test for softlink of AVAudioRoutingArbiter.
935
936         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
937         (TestWebKitAPI::TEST):
938
939 2020-04-14  Per Arne Vollan  <pvollan@apple.com>
940
941         [iOS] Content filtering needs access to the frontboard service
942         https://bugs.webkit.org/show_bug.cgi?id=210505
943
944         Reviewed by Geoffrey Garen.
945
946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
947         * TestWebKitAPI/Tests/WebKit/WebFilter.mm: Added.
948         (isManagedSessionMethodOverride):
949         (TEST):
950
951 2020-04-14  Andres Gonzalez  <andresg_22@apple.com>
952
953         Make WTR::AccessibilityUIElements calls to accessibilitySetValue run on AX secondary thread.
954         https://bugs.webkit.org/show_bug.cgi?id=210500
955
956         Reviewed by Chris Fleizach.
957
958         Needed to test accessibility isolated tree mode. Follow up to
959         https://bugs.webkit.org/show_bug.cgi?id=210392.
960
961         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
962         (AccessibilityUIElement::setBoolAttributeValue):
963         (AccessibilityUIElement::resetSelectedTextMarkerRange):
964         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
965         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
966         (WTR::setAttributeValue):
967         (WTR::attributesOfElement):
968         (WTR::descriptionOfElements):
969         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
970         (WTR::AccessibilityUIElement::stringAttributeValue):
971         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
972         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
973         (WTR::AccessibilityUIElement::boolAttributeValue):
974         (WTR::AccessibilityUIElement::setBoolAttributeValue):
975         (WTR::AccessibilityUIElement::setValue):
976         (WTR::AccessibilityUIElement::setSelectedTextRange):
977         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
978         (WTR::AccessibilityUIElement::setSelectedChild const):
979         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
980         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
981         (WTR::AccessibilityUIElement::takeFocus):
982         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
983
984 2020-04-14  Brent Fulgham  <bfulgham@apple.com>
985
986         InjectedBundle parameters often need initialization function called before unarchiving
987         https://bugs.webkit.org/show_bug.cgi?id=189709
988         <rdar://problem/44573653>
989
990         Reviewed by Ryosuke Niwa.
991
992         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
993         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
994
995 2020-04-14  Sergio Villar Senin  <svillar@igalia.com>
996
997         [Flatpak] Make run-webkit-tests obey WEBKIT_JHBUILD
998         https://bugs.webkit.org/show_bug.cgi?id=210497
999
1000         Reviewed by Philippe Normand.
1001
1002         run-webkit-tests in linux uses the flatpak SDK if the flatpak
1003         directories are found in the build directory. However it might the the case
1004         that a developer wants to run them using the jhbuild SDK which can be
1005         configured in parallel. We have the WEBKIT_JHBUILD environment variable to
1006         force other scripts to use jhbuild instead of flatpak so we can use it as well
1007         for this use case.
1008
1009         * flatpak/flatpakutils.py:
1010         (run_in_sandbox_if_available):
1011
1012 2020-04-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1013
1014         [GTK] Bring back support for rendering scrollbars using the system appearance
1015         https://bugs.webkit.org/show_bug.cgi?id=209805
1016
1017         Reviewed by Michael Catanzaro.
1018
1019         Do not use system appearance for scrollbars in MiniBrowser and unit tests.
1020
1021         * MiniBrowser/gtk/main.c:
1022         (main):
1023         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1024         (Test::Test):
1025
1026 2020-04-13  Devin Rousso  <drousso@apple.com>
1027
1028         REGRESSION (r259900) : Speedometer failing on Catalina-Release-WK2-Perf bot
1029         https://bugs.webkit.org/show_bug.cgi?id=210442
1030         <rdar://problem/61727169>
1031
1032         Reviewed by Stephanie Lewis.
1033
1034         * Scripts/webkitpy/performance_tests/perftest.py:
1035         (PerfTest):
1036
1037 2020-04-13  David Kilzer  <ddkilzer@apple.com>
1038
1039         check-webkit-style should warn about attributes that appear after function definitions
1040         <https://webkit.org/b/210459>
1041
1042         Reviewed by Darin Adler.
1043
1044         * Scripts/webkitpy/style/checkers/cpp.py:
1045         (_FunctionState.attributes_after_definition): Add.
1046         - Return list of attributes that appear after a function
1047           definition.
1048         (check_function_definition):
1049         - Add new check for attributes that appear after a function
1050           definition.
1051
1052         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1053         (CppStyleTest.test_decode_functions_missing_warn_unused_return):
1054         - Update test to fix new warning.
1055         (CppStyleTest.test_function_readability_for_attributes): Add.
1056         - Add tests.
1057
1058 2020-04-13  Kate Cheney  <katherine_cheney@apple.com>
1059
1060         http/tests/in-app-browser-privacy/app-bound-domain.html is a constant failure on iOS
1061         https://bugs.webkit.org/show_bug.cgi?id=210344
1062         <rdar://problem/61583925>
1063
1064         Reviewed by Brent Fulgham.
1065
1066         This patch creates a new TestOption parameter for enabling In-App
1067         Browser Privacy because its NSUserDefaults key is not set using the 
1068         internal or experimental keywords. It enables this flag for
1069         WebKitTestRunner if the option is set (and disables it otherwise).
1070
1071         * WebKitTestRunner/TestController.cpp:
1072         (WTR::updateTestOptionsFromTestHeader):
1073         * WebKitTestRunner/TestOptions.h:
1074         (WTR::TestOptions::hasSameInitializationOptions const):
1075         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1076         (WTR::TestController::platformAddTestOptions const):
1077         * WebKitTestRunner/ios/TestControllerIOS.mm:
1078         (WTR::TestController::platformResetStateToConsistentValues):
1079
1080 2020-04-13  Per Arne Vollan  <pvollan@apple.com>
1081
1082         [iOS] Remove unused UTType swizzler code
1083         https://bugs.webkit.org/show_bug.cgi?id=210435
1084
1085         Unreviewed rollout of r258120.
1086
1087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1088         * TestWebKitAPI/Tests/WebKit/UTIFromTag.mm: Removed.
1089
1090 2020-04-13  Andres Gonzalez  <andresg_22@apple.com>
1091
1092         Make WTR::AccessibilityUIElement methods run on AX secondary thread.
1093         https://bugs.webkit.org/show_bug.cgi?id=210392
1094
1095         Reviewed by Chris Fleizach.
1096
1097         In order to test accessibility isolated tree mode, it is necessary to
1098         run WTR::AccessibilityUIElement methods on the AX secondary thread. This
1099         change uses the functionality built-in AccessibilityController to
1100         dispatch the calls to WebAccessibilityObjectWrapper to the AX thread.
1101
1102         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1103         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1104         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1105         (WTR::supportedAttributes):
1106         (WTR::attributeValue):
1107         (WTR::descriptionOfValue):
1108         (WTR::attributesOfElement):
1109         (WTR::AccessibilityUIElement::getLinkedUIElements):
1110         (WTR::AccessibilityUIElement::getDocumentLinks):
1111         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1112         (WTR::AccessibilityUIElement::getChildren):
1113         (WTR::AccessibilityUIElement::getChildrenWithRange):
1114         (WTR::AccessibilityUIElement::rowHeaders const):
1115         (WTR::AccessibilityUIElement::columnHeaders const):
1116         (WTR::AccessibilityUIElement::elementAtPoint):
1117         (WTR::AccessibilityUIElement::indexOfChild):
1118         (WTR::AccessibilityUIElement::elementForAttribute const):
1119         (WTR::AccessibilityUIElement::elementForAttributeAtIndex const):
1120         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1121         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1122         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1123         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1124         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
1125         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
1126         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1127         (WTR::AccessibilityUIElement::rowAtIndex):
1128         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
1129         (WTR::AccessibilityUIElement::selectedChildrenCount const):
1130         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1131         (WTR::AccessibilityUIElement::titleUIElement):
1132         (WTR::AccessibilityUIElement::parentElement):
1133         (WTR::AccessibilityUIElement::disclosedByRow):
1134         (WTR::AccessibilityUIElement::numberAttributeValue):
1135         (WTR::AccessibilityUIElement::isAttributeSupported):
1136         (WTR::AccessibilityUIElement::isSelected const):
1137         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1138
1139 2020-04-13  Lauro Moura  <lmoura@igalia.com>
1140
1141         [Flatpak SDK] test262-runner fails to run with WEBKIT_JHBUILD enabled
1142         https://bugs.webkit.org/show_bug.cgi?id=210430
1143
1144         Make sure we check the WEBKIT_JHBUILD env var directly to avoid
1145         requiring webkitdirs early and messing up Runner.pm compilation.
1146
1147         Reviewed by Philippe Normand.
1148
1149         * Scripts/test262-runner:
1150
1151 2020-04-13  David Kilzer  <ddkilzer@apple.com>
1152
1153         Add WARN_UNUSED_RETURN to decode methods in Source/WebKit
1154         <https://webkit.org/b/210423>
1155         <rdar://problem/61715582>
1156
1157         Reviewed by Alex Christensen.
1158
1159         * Scripts/webkitpy/style/checkers/cpp.py:
1160         (check_function_definition):
1161         - Add check for platformDecode() methods.
1162         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1163         (CppStyleTest):
1164         - Add tests for platformDecode() methods.
1165
1166 2020-04-13  Aakash Jain  <aakash_jain@apple.com>
1167
1168         [ews] Improve handling of unexpected network issues while communicating with Bugzilla
1169         https://bugs.webkit.org/show_bug.cgi?id=210377
1170
1171         Reviewed by Jonathan Bedard.
1172
1173         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1174         (BugzillaBeautifulSoup.authenticate):
1175
1176 2020-04-13  Aakash Jain  <aakash_jain@apple.com>
1177
1178         ews status-bubble hover-over message include unhelpful message 'Crash collection has quiesced'
1179         https://bugs.webkit.org/show_bug.cgi?id=210378
1180
1181         Reviewed by Jonathan Bedard.
1182
1183         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1184         (StatusBubble):
1185
1186 2020-04-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1187
1188         [macOS] [WK1] Touch Bar flashes when typing in Vietnamese in Mail
1189         https://bugs.webkit.org/show_bug.cgi?id=210394
1190         <rdar://problem/60099560>
1191
1192         Reviewed by Tim Horton.
1193
1194         Add an API test that inserts an attributed string with the text replacement attribute, and verifies that we
1195         show the candidate list when inserting the string, and also don't temporarily hide the candidate list in the
1196         process of doing so.
1197
1198         To achieve this, we swizzle out calls to -[NSCandidateListTouchBarItem updateWithInsertionPointVisibility:] to
1199         detect when the candidate list is either hidden or made visible.
1200
1201         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
1202         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1203
1204         Fix a leak in an adjacent test too, while I'm touching this file.
1205
1206         (TestWebKitAPI::updateCandidateListWithVisibility):
1207
1208 2020-04-11  Aakash Jain  <aakash_jain@apple.com>
1209
1210         Buildbot: Force crash log submission after each test run (follow-up fix)
1211         https://bugs.webkit.org/show_bug.cgi?id=210202
1212         <rdar://problem/60508929>
1213
1214         Unreviewed follow-up fix.
1215
1216         * BuildSlaveSupport/ews-build/steps.py:
1217         (WaitForCrashCollection): Remove spaces from step name.
1218
1219 2020-04-11  Aakash Jain  <aakash_jain@apple.com>
1220
1221         Buildbot: Force crash log submission after each test run (follow-up fix)
1222         https://bugs.webkit.org/show_bug.cgi?id=210202
1223         <rdar://problem/60508929>
1224
1225         Unreviewed follow-up fix.
1226
1227         * BuildSlaveSupport/wait-for-crash-collection: Improved error message.
1228
1229 2020-04-11  David Kilzer  <ddkilzer@apple.com>
1230
1231         check-webkit-style should warn about 'decode' functions with missing WARN_UNUSED_RETURN attribute
1232         <https://webkit.org/b/210336>
1233         <rdar://problem/61585835>
1234
1235         Reviewed by Jonathan Bedard.
1236
1237         * Scripts/webkitpy/style/checkers/cpp.py:
1238         (_FunctionState.post_modifiers): Add.  Returns string of text
1239         that appears after the function definition's list of parameters.
1240         This is used to find the WARN_UNUSED_RETURN attribute in
1241         function declarations in header files.
1242         (_FunctionState.has_attribute): Add.  Takes a string (or regex)
1243         and searchs before and after the function definition for the
1244         attribute.
1245         (_FunctionState.has_return_type): Add.  Takes a string (or
1246         regex) and checks the return type of the fuction.
1247         (_FunctionState.is_static): Add.  Returns True for functions
1248         with the 'static' modifier.
1249         (check_function_definition): Add check for decode() functions
1250         with missing WARN_UNUSED_RETURN attribute.
1251         (CppChecker): Add 'security/missing_warn_unused_return' to the
1252         list of enabled style checkers.
1253
1254         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1255         (CppStyleTestBase.perform_function_definition_check): Add.  This
1256         runs the check_function_definition() function in cpp.py.
1257         (CppStyleTest.test_decode_functions_missing_warn_unused_return): Add.
1258         Tests for the new warning.
1259
1260 2020-04-10  Alex Christensen  <achristensen@webkit.org>
1261
1262         Add SPI to handle proxy authentication and require secure proxy connections
1263         https://bugs.webkit.org/show_bug.cgi?id=210343
1264         <rdar://problem/61546396> <rdar://problem/61546519> and <rdar://problem/61546658>
1265
1266         Reviewed by Geoffrey Garen.
1267
1268         * TestWebKitAPI/TCPServer.cpp:
1269         (TestWebKitAPI::TCPServer::startSecureConnection):
1270         (TestWebKitAPI::TCPServer::TCPServer):
1271         * TestWebKitAPI/TCPServer.h:
1272         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1273         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1274         (-[ProxyDelegate waitForAlert]):
1275         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1276         (TestWebKitAPI::TEST):
1277
1278 2020-04-10  Devin Rousso  <drousso@apple.com>
1279
1280         Changes to shared testing JS files should not cause test failures due to console message line numbers changing
1281         https://bugs.webkit.org/show_bug.cgi?id=210303
1282
1283         Reviewed by Simon Fraser.
1284
1285         * DumpRenderTree/mac/UIDelegate.mm:
1286         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1287         * DumpRenderTree/win/UIDelegate.cpp:
1288         (UIDelegate::webViewAddMessageToConsole):
1289         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1290         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1291         (WTR::InjectedBundlePage::willAddMessageToConsole):
1292
1293 2020-04-10  Simon Fraser  <simon.fraser@apple.com>
1294
1295         Reset view navigation gesture state between tests
1296         https://bugs.webkit.org/show_bug.cgi?id=210283
1297
1298         Re-land r259818 with a null-check on m_webPageProxyForBackForwardListForCurrentSwipe.
1299
1300         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1301         (WTR::TestController::cocoaResetStateToConsistentValues):
1302
1303 2020-04-10  Alicia Boya García  <aboya@igalia.com>
1304
1305         [WTF] DataMutex: Add runUnlocked()
1306         https://bugs.webkit.org/show_bug.cgi?id=209811
1307
1308         Reviewed by Xabier Rodriguez-Calvar.
1309
1310         Tests for runUnlocked() and DataMutex checks are introduced.
1311
1312         * TestWebKitAPI/Tests/WTF/DataMutex.cpp:
1313         (TestWebKitAPI::TEST):
1314
1315 == Rolled over to ChangeLog-2020-04-10 ==