[GTK][CMake] Add support for building with Clang
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2
3         [GTK][CMake] Add support for building with Clang
4         https://bugs.webkit.org/show_bug.cgi?id=130260
5
6         Reviewed by Martin Robinson.
7
8         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
9         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
10         included GTest framework headers.
11         * gtk/generate-gtkdoc:
12         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
13         in case of using Clang since that is now set by the CMake rule.
14
15 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
16
17         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
18         https://bugs.webkit.org/show_bug.cgi?id=130476
19
20         Reviewed by Anders Carlsson.
21         
22         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
23
24         * MiniBrowser/mac/WK1BrowserWindowController.m:
25         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
26         Remove log.
27         * MiniBrowser/mac/WK2BrowserWindowController.m:
28         (-[WK2BrowserWindowController awakeFromNib]):
29         (-[WK2BrowserWindowController validateMenuItem:]):
30         (-[WK2BrowserWindowController reload:]):
31         Hook up reload.
32         (-[WK2BrowserWindowController toggleZoomMode:]):
33         (-[WK2BrowserWindowController resetZoom:]):
34         (-[WK2BrowserWindowController canResetZoom]):
35         (-[WK2BrowserWindowController currentZoomFactor]):
36         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
37         (-[WK2BrowserWindowController canZoomIn]):
38         (-[WK2BrowserWindowController canZoomOut]):
39
40 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
41
42         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
43         https://bugs.webkit.org/show_bug.cgi?id=130463
44
45         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
46
47 2014-03-18  Samuel White  <samuel_white@apple.com>
48
49         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
50         https://bugs.webkit.org/show_bug.cgi?id=130250
51
52         Reviewed by Chris Fleizach.
53
54         Added ability to toggle enhanced accessibility on and off to support tests that require it.
55
56         * DumpRenderTree/AccessibilityController.cpp:
57         (enableEnhancedAccessibilityCallback):
58         (getEnhancedAccessibilityEnabledCallback):
59         (AccessibilityController::getJSClass):
60         * DumpRenderTree/AccessibilityController.h:
61         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
62         (AccessibilityController::enableEnhancedAccessibility):
63         (AccessibilityController::enhancedAccessibilityEnabled):
64         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
65         (AccessibilityController::enableEnhancedAccessibility):
66         (AccessibilityController::enhancedAccessibilityEnabled):
67         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
68         (AccessibilityController::enableEnhancedAccessibility):
69         (AccessibilityController::enhancedAccessibilityEnabled):
70         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
71         (AccessibilityController::enableEnhancedAccessibility):
72         (AccessibilityController::enhancedAccessibilityEnabled):
73         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
74         (WTR::AccessibilityController::enableEnhancedAccessibility):
75         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
76         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
77         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
78
79 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
80
81         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
82         yet).
83
84         * Scripts/webkitpy/common/config/contributors.json:
85
86 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
87
88         Web Inspector: Remove stale ReportMemoryUsagePlugin
89         https://bugs.webkit.org/show_bug.cgi?id=130405
90
91         Reviewed by Andreas Kling.
92
93         This clang plugin looks like it was used for the old Inspector memory
94         instrumentation that was removed. So the tool can be removed.
95
96         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
97         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
98         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
99         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
100
101 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
102
103         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
104         https://bugs.webkit.org/show_bug.cgi?id=130220
105
106         Reviewed by Csaba Osztrogonác.
107
108         * Scripts/webkitpy/common/checkout/changelog.py:
109         (ChangeLog.set_reviewer):
110         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
111         (test_set_reviewer):
112
113 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
114
115         More FTL enabling.
116
117         Rubber stamped by Dan Bernstein.
118
119         * Tools/Scripts/build-webkit:
120
121 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
122
123         Renable pagination mode in WK2 MiniBrowser
124         https://bugs.webkit.org/show_bug.cgi?id=130374
125
126         Reviewed by Anders Carlsson.
127         
128         Put the implementation of togglePaginationMode: back, and correctly
129         enable the menu item.
130
131         * MiniBrowser/mac/WK2BrowserWindowController.m:
132         (-[WK2BrowserWindowController validateMenuItem:]):
133         (-[WK2BrowserWindowController isPaginated]):
134         (-[WK2BrowserWindowController togglePaginationMode:]):
135
136 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
137
138         Add --reset option to Tools/Scripts/set-webkit-configuration script
139         https://bugs.webkit.org/show_bug.cgi?id=130401
140
141         Reviewed by Csaba Osztrogonác.
142
143         * Scripts/set-webkit-configuration:
144
145 2014-03-18  Alberto Garcia  <berto@igalia.com>
146
147         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
148         https://bugs.webkit.org/show_bug.cgi?id=130388
149
150         Reviewed by Sergio Villar Senin.
151
152         * Scripts/webkitdirs.pm:
153         (shouldRemoveCMakeCache): make sure that the build directory
154         exists before attempting to create a file in it.
155
156 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
157
158         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
159         https://bugs.webkit.org/show_bug.cgi?id=130336
160
161         Reviewed by Gyuyoung Kim.
162
163         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
164         requires a space between literal and string macro [-Wliteral-suffix]'
165         warning treated as error.
166
167         This patch applies a solution from r162448 to the EFL port.
168
169         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
170         * efl/jhbuild.modules: Added appropriate patch section.
171
172 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
173
174         webkitpy test rebaseline.
175
176         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
177         (MainTest.test_default_args):
178
179 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
180
181         --profile should imply --test-runner-count=1 in run-perf-tests
182         https://bugs.webkit.org/show_bug.cgi?id=130375
183
184         Reviewed by Benjamin Poulain.
185
186         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
187
188         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
189         (PerfTestsRunner._parse_args): Use -1 as the default value.
190         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
191         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
192         should be 1.
193
194 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
195
196         Address some style nits.
197
198         * MiniBrowser/mac/WK2BrowserWindowController.m:
199
200 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
201
202         Add transparent window support back into MiniBrowser
203         https://bugs.webkit.org/show_bug.cgi?id=130363
204
205         Reviewed by Anders Carlsson.
206         
207         Re-enable transparent window support for WK2.
208
209         * MiniBrowser/mac/WK2BrowserWindowController.m:
210         (-[WK2BrowserWindowController validateMenuItem:]):
211         (-[WK2BrowserWindowController toggleTransparentWindow:]):
212
213 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
214
215         Fix the 32-bit build; make the open panel make a WK1 window.
216
217         * MiniBrowser/mac/AppDelegate.m:
218         (-[BrowserAppDelegate openDocument:]):
219
220 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
221
222         Convert MiniBrowser to use WKWebView API
223         https://bugs.webkit.org/show_bug.cgi?id=130061
224
225         Reviewed by Anders Carlsson.
226         
227         Convert the MiniBrowser WK2 window to use WebKit2 API as much
228         as possible.
229         
230         Some functionality was removed temporarily:
231             - text zoom, page zoom
232             - reload
233             - pagination mode
234             - transparent window
235             - dumping source
236             - window.open support
237             - beforeUnload panel
238             - find in page
239
240         * MiniBrowser/mac/AppDelegate.h:
241         * MiniBrowser/mac/AppDelegate.m:
242         (-[BrowserAppDelegate init]):
243         (-[BrowserAppDelegate newWindow:]):
244         (-[BrowserAppDelegate applicationWillTerminate:]):
245         (-[BrowserAppDelegate openDocument:]):
246         * MiniBrowser/mac/WK2BrowserWindowController.h:
247         * MiniBrowser/mac/WK2BrowserWindowController.m:
248         (-[WK2BrowserWindowController awakeFromNib]):
249         (-[WK2BrowserWindowController dealloc]):
250         (-[WK2BrowserWindowController fetch:]):
251         (-[WK2BrowserWindowController validateMenuItem:]):
252         (-[WK2BrowserWindowController reload:]):
253         (-[WK2BrowserWindowController goBack:]):
254         (-[WK2BrowserWindowController goForward:]):
255         (-[WK2BrowserWindowController toggleZoomMode:]):
256         (-[WK2BrowserWindowController resetZoom:]):
257         (-[WK2BrowserWindowController canResetZoom]):
258         (-[WK2BrowserWindowController dumpSourceToConsole:]):
259         (-[WK2BrowserWindowController togglePaginationMode:]):
260         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
261         (-[WK2BrowserWindowController windowShouldClose:]):
262         (-[WK2BrowserWindowController applicationTerminating]):
263         (-[WK2BrowserWindowController currentZoomFactor]):
264         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
265         (-[WK2BrowserWindowController toggleTransparentWindow:]):
266         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
267         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
268         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
269         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
270         (-[WK2BrowserWindowController find:]):
271         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
272         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
273         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
274         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
275         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
276         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
277         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
278         * WebKitTestRunner/PlatformWebView.h:
279         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
280         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
281
282 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
283
284         Use RunLoop objects through references instead of pointers
285         https://bugs.webkit.org/show_bug.cgi?id=130313
286
287         Reviewed by Andreas Kling.
288
289         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
290         return RunLoop reference instead of a pointer.
291
292         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
293         (loadedCallback):
294         (clickedCallback):
295
296 2014-03-17  Tim Horton  <timothy_horton@apple.com>
297
298         sort-export-file --help doesn't work (missing 'use')
299         https://bugs.webkit.org/show_bug.cgi?id=130338
300
301         Reviewed by Anders Carlsson.
302
303         * Scripts/sort-export-file:
304         Add a missing 'use', and fix a typo in an error message.
305
306 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
307
308         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
309         https://bugs.webkit.org/show_bug.cgi?id=130155
310
311         Reviewed by Philippe Normand.
312
313         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
314
315 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
316
317         [GTK] MiniBrowser fails to load injected bundle lib
318         https://bugs.webkit.org/show_bug.cgi?id=130332
319
320         Reviewed by Anders Carlsson.
321
322         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
323
324         * MiniBrowser/gtk/main.c:
325         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
326         process is spawn.
327
328 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
329
330         [EFL] Enable TOUCH_SLIDER macro
331         https://bugs.webkit.org/show_bug.cgi?id=130185
332
333         Reviewed by Gyuyoung Kim.
334
335         * Scripts/webkitperl/FeatureList.pm:
336
337 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
338
339         [GTK][CMake] Build with -fno-rtti
340         https://bugs.webkit.org/show_bug.cgi?id=130261
341
342         Reviewed by Martin Robinson.
343
344         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
345         defined to 0 to prevent typeid use in included GTest headers.
346
347 2014-03-16  Brian Burg  <bburg@apple.com>
348
349         Web Inspector: vended backend commands file should be generated as part of the build
350         https://bugs.webkit.org/show_bug.cgi?id=130110
351
352         Reviewed by Timothy Hatcher.
353
354         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
355
356 2014-03-16  Diego Pino García  <dpino@igalia.com>
357
358         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
359         https://bugs.webkit.org/show_bug.cgi?id=128999
360
361         Reviewed by Philippe Normand.
362
363         * MiniBrowser/gtk/BrowserWindow.c:
364         (reloadPage):
365         (reloadPageIgnoringCache):
366         (browser_window_init):
367
368 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
369
370         [GTK] Improve ninja detection in webkitdirs.pm
371         https://bugs.webkit.org/show_bug.cgi?id=129902
372
373         Reviewed by Daniel Bates.
374
375         * Scripts/webkitdirs.pm:
376         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
377         us to look for ninja-build as well.
378
379 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
380
381         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
382         https://bugs.webkit.org/show_bug.cgi?id=130276
383         <rdar://problem/16266927>
384         
385         Reviewed by Simon Fraser.
386
387         * BuildSlaveSupport/build-launcher-app:
388         * BuildSlaveSupport/build-launcher-dmg:
389         * DumpRenderTree/DumpRenderTree.h:
390         * DumpRenderTree/DumpRenderTreePrefix.h:
391         * DumpRenderTree/GCController.cpp:
392         * DumpRenderTree/GCController.h:
393         * DumpRenderTree/JavaScriptThreading.cpp:
394         * DumpRenderTree/JavaScriptThreading.h:
395         * DumpRenderTree/PixelDumpSupport.cpp:
396         * DumpRenderTree/PixelDumpSupport.h:
397         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
398         * DumpRenderTree/TestRunner.cpp:
399         * DumpRenderTree/TestRunner.h:
400         * DumpRenderTree/WorkQueue.cpp:
401         * DumpRenderTree/WorkQueue.h:
402         * DumpRenderTree/WorkQueueItem.h:
403         * DumpRenderTree/atk/AccessibilityCallbacks.h:
404         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
405         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
406         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
407         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
408         * DumpRenderTree/cg/PixelDumpSupportCG.h:
409         * DumpRenderTree/efl/EditingCallbacks.cpp:
410         * DumpRenderTree/efl/EditingCallbacks.h:
411         * DumpRenderTree/efl/EventSender.cpp:
412         * DumpRenderTree/efl/EventSender.h:
413         * DumpRenderTree/efl/GCControllerEfl.cpp:
414         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
415         * DumpRenderTree/efl/TestRunnerEfl.cpp:
416         * DumpRenderTree/gtk/DumpRenderTree.cpp:
417         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
418         * DumpRenderTree/gtk/EditingCallbacks.cpp:
419         * DumpRenderTree/gtk/EditingCallbacks.h:
420         * DumpRenderTree/gtk/EventSender.cpp:
421         * DumpRenderTree/gtk/EventSender.h:
422         * DumpRenderTree/gtk/GCControllerGtk.cpp:
423         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
424         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
425         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
426         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
427         * DumpRenderTree/gtk/TextInputController.cpp:
428         * DumpRenderTree/gtk/TextInputController.h:
429         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
430         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
431         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
432         * DumpRenderTree/mac/AppleScriptController.h:
433         * DumpRenderTree/mac/AppleScriptController.m:
434         * DumpRenderTree/mac/CheckedMalloc.cpp:
435         * DumpRenderTree/mac/CheckedMalloc.h:
436         * DumpRenderTree/mac/DumpRenderTree.mm:
437         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
438         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
439         * DumpRenderTree/mac/DumpRenderTreeMac.h:
440         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
441         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
442         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
443         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
444         * DumpRenderTree/mac/EditingDelegate.h:
445         * DumpRenderTree/mac/EditingDelegate.mm:
446         * DumpRenderTree/mac/EventSendingController.h:
447         * DumpRenderTree/mac/EventSendingController.mm:
448         * DumpRenderTree/mac/FrameLoadDelegate.h:
449         * DumpRenderTree/mac/FrameLoadDelegate.mm:
450         * DumpRenderTree/mac/GCControllerMac.mm:
451         * DumpRenderTree/mac/MockWebNotificationProvider.h:
452         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
453         * DumpRenderTree/mac/NavigationController.h:
454         * DumpRenderTree/mac/NavigationController.m:
455         * DumpRenderTree/mac/ObjCController.h:
456         * DumpRenderTree/mac/ObjCController.m:
457         * DumpRenderTree/mac/ObjCPlugin.h:
458         * DumpRenderTree/mac/ObjCPlugin.m:
459         * DumpRenderTree/mac/ObjCPluginFunction.h:
460         * DumpRenderTree/mac/ObjCPluginFunction.m:
461         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
462         * DumpRenderTree/mac/PolicyDelegate.h:
463         * DumpRenderTree/mac/PolicyDelegate.mm:
464         * DumpRenderTree/mac/ResourceLoadDelegate.h:
465         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
466         * DumpRenderTree/mac/TestRunnerMac.mm:
467         * DumpRenderTree/mac/TextInputController.h:
468         * DumpRenderTree/mac/TextInputController.m:
469         * DumpRenderTree/mac/UIDelegate.h:
470         * DumpRenderTree/mac/UIDelegate.mm:
471         * DumpRenderTree/mac/WorkQueueItemMac.mm:
472         * DumpRenderTree/win/DRTDataObject.cpp:
473         * DumpRenderTree/win/DRTDataObject.h:
474         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
475         * DumpRenderTree/win/DRTDropSource.cpp:
476         * DumpRenderTree/win/DRTDropSource.h:
477         * DumpRenderTree/win/DraggingInfo.h:
478         * DumpRenderTree/win/DumpRenderTree.cpp:
479         * DumpRenderTree/win/DumpRenderTreeWin.h:
480         * DumpRenderTree/win/EditingDelegate.cpp:
481         * DumpRenderTree/win/EditingDelegate.h:
482         * DumpRenderTree/win/EventSender.cpp:
483         * DumpRenderTree/win/EventSender.h:
484         * DumpRenderTree/win/FrameLoadDelegate.cpp:
485         * DumpRenderTree/win/FrameLoadDelegate.h:
486         * DumpRenderTree/win/GCControllerWin.cpp:
487         * DumpRenderTree/win/HistoryDelegate.cpp:
488         * DumpRenderTree/win/HistoryDelegate.h:
489         * DumpRenderTree/win/MD5.cpp:
490         * DumpRenderTree/win/MD5.h:
491         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
492         * DumpRenderTree/win/PolicyDelegate.cpp:
493         * DumpRenderTree/win/PolicyDelegate.h:
494         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
495         * DumpRenderTree/win/ResourceLoadDelegate.h:
496         * DumpRenderTree/win/TestRunnerWin.cpp:
497         * DumpRenderTree/win/TextInputController.cpp:
498         * DumpRenderTree/win/TextInputController.h:
499         * DumpRenderTree/win/TextInputControllerWin.cpp:
500         * DumpRenderTree/win/UIDelegate.cpp:
501         * DumpRenderTree/win/UIDelegate.h:
502         * DumpRenderTree/win/WorkQueueItemWin.cpp:
503         * EWebLauncher/main.c:
504         * GtkLauncher/main.c:
505         * ImageDiff/efl/ImageDiff.cpp:
506         * ImageDiff/gtk/ImageDiff.cpp:
507         * MiniBrowser/gtk/main.c:
508         * Scripts/SpacingHeuristics.pm:
509         * Scripts/VCSUtils.pm:
510         * Scripts/bisect-builds:
511         * Scripts/build-dumprendertree:
512         * Scripts/build-jsc:
513         * Scripts/build-webkit:
514         * Scripts/check-dom-results:
515         * Scripts/check-for-exit-time-destructors:
516         * Scripts/check-for-global-initializers:
517         * Scripts/commit-log-editor:
518         * Scripts/compare-timing-files:
519         * Scripts/debug-minibrowser:
520         * Scripts/debug-safari:
521         * Scripts/do-file-rename:
522         * Scripts/find-extra-includes:
523         * Scripts/generate-coverage-data:
524         * Scripts/make-script-test-wrappers:
525         * Scripts/malloc-tree:
526         * Scripts/old-run-webkit-tests:
527         * Scripts/parse-malloc-history:
528         * Scripts/report-include-statistics:
529         * Scripts/resolve-ChangeLogs:
530         * Scripts/run-bindings-tests:
531         * Scripts/run-iexploder-tests:
532         * Scripts/run-javascriptcore-tests:
533         * Scripts/run-jsc:
534         * Scripts/run-launcher:
535         * Scripts/run-leaks:
536         * Scripts/run-mangleme-tests:
537         * Scripts/run-minibrowser:
538         * Scripts/run-pageloadtest:
539         * Scripts/run-regexp-tests:
540         * Scripts/run-safari:
541         * Scripts/run-sunspider:
542         * Scripts/run-webkit-app:
543         * Scripts/sampstat:
544         * Scripts/set-webkit-configuration:
545         * Scripts/sort-Xcode-project-file:
546         * Scripts/sort-export-file:
547         * Scripts/split-file-by-class:
548         * Scripts/sunspider-compare-results:
549         * Scripts/svn-apply:
550         * Scripts/svn-create-patch:
551         * Scripts/svn-unapply:
552         * Scripts/test-webkit-scripts:
553         * Scripts/update-javascriptcore-test-results:
554         * Scripts/update-webkit:
555         * Scripts/update-webkit-auxiliary-libs:
556         * Scripts/update-webkit-dependency:
557         * Scripts/update-webkit-localizable-strings:
558         * Scripts/update-webkit-support-libs:
559         * Scripts/update-webkit-wincairo-libs:
560         * Scripts/webkit-build-directory:
561         * Scripts/webkitdirs.pm:
562         (installedSafariPath):
563         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
564         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
565         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
566         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
567         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
568         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
569         * Scripts/webkitperl/features.pm:
570         * Scripts/webkitperl/httpd.pm:
571         * Scripts/webkitpy/bindings/main.py:
572         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
573         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
574         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
575         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
576         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
577         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
578         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
579         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
580         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
581         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
582         * WebKitTestRunner/PixelDumpSupport.cpp:
583         * WebKitTestRunner/PixelDumpSupport.h:
584         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
585         * WinLauncher/WinLauncher.cpp:
586         * WinLauncher/WinLauncher.h:
587         * WinLauncher/stdafx.cpp:
588         * WinLauncher/stdafx.h:
589
590 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
591
592         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
593         https://bugs.webkit.org/show_bug.cgi?id=130265
594
595         Reviewed by Michael Saboff.
596
597         * Scripts/build-webkit:
598         * Scripts/copy-webkitlibraries-to-product-directory:
599
600 2014-03-14  Landry Breuil  <landry@openbsd.org>
601
602         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
603         Also allow to set MAKE in the environment.
604         https://bugs.webkit.org/show_bug.cgi?id=129991
605
606         Reviewed by Andreas Kling.
607
608         * Scripts/webkitdirs.pm:
609         (determineArchitecture):
610         (determineNumberOfCPUs):
611         (isBSD):
612         (buildAutotoolsProject):
613         * Scripts/webkitpy/common/system/platforminfo.py:
614         (PlatformInfo.__init__):
615         (PlatformInfo.is_openbsd):
616         (PlatformInfo):
617         (PlatformInfo.is_netbsd):
618         (PlatformInfo._determine_os_name):
619
620 2014-03-14  Dean Jackson  <dino@apple.com>
621
622         Remove libWebKitSystemInterfaceLion.a
623         https://bugs.webkit.org/show_bug.cgi?id=130254
624
625         Reviewed by Geoffrey Garen and Andreas Kling.
626
627         No need to copy the Lion libraries into the build.
628
629         * Scripts/copy-webkitlibraries-to-product-directory:
630
631 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
632
633         [EFL][MiniBrowser] Revise help messages of command line parameters
634         https://bugs.webkit.org/show_bug.cgi?id=130222
635
636         Reviewed by Csaba Osztrogonác.
637
638         Correct the default value description and make help messages to be consistent.
639
640         * MiniBrowser/efl/main.c:
641
642 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
643
644         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
645         https://bugs.webkit.org/show_bug.cgi?id=129612
646
647         Reviewed by Darin Adler.
648
649         For new code use static NeverDestroyed<T> instead.
650
651         * DumpRenderTree/JavaScriptThreading.cpp:
652         (javaScriptThreadsMutex):
653         (javaScriptThreads):
654         * DumpRenderTree/efl/EventSender.cpp:
655         (touchPointList):
656         (delayedEventQueue):
657         * DumpRenderTree/win/FrameLoadDelegate.cpp:
658         (delegatesWithDelayedWork):
659         * Scripts/check-for-exit-time-destructors:
660         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
661         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
662         (testsMap):
663
664 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
665
666         [EFL][WK2] Fix compilation warning in Minibrowser
667         https://bugs.webkit.org/show_bug.cgi?id=130132
668
669         Reviewed by Csaba Osztrogonác.
670
671         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
672
673         * MiniBrowser/efl/main.c:
674         (on_download_request):
675
676 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
677
678         FTL should support IsBlah
679         https://bugs.webkit.org/show_bug.cgi?id=130202
680
681         Reviewed by Geoffrey Garen.
682         
683         Running existing JSRegress tests with noInline gives us coverage for these
684         changes. Chances are, this will also give coverage for other interesting things
685         as well.
686
687         * Scripts/run-jsc-stress-tests:
688
689 2014-03-12  Brian Burg  <bburg@apple.com>
690
691         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
692         https://bugs.webkit.org/show_bug.cgi?id=129744
693
694         Reviewed by Timothy Hatcher.
695
696         * DumpRenderTree/TestRunner.cpp:
697         (evaluateInWebInspectorCallback):
698         * DumpRenderTree/TestRunner.h:
699         * DumpRenderTree/efl/TestRunnerEfl.cpp:
700         (TestRunner::evaluateInWebInspector):
701         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
702         (TestRunner::evaluateInWebInspector):
703         * DumpRenderTree/mac/TestRunnerMac.mm:
704         (TestRunner::evaluateInWebInspector):
705         * DumpRenderTree/win/TestRunnerWin.cpp:
706         (TestRunner::evaluateInWebInspector):
707         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
708         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
709         (WTR::TestRunner::evaluateInWebInspector):
710         * WebKitTestRunner/InjectedBundle/TestRunner.h:
711
712 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
713
714         [GTK] build-webkit shouldn't show error message when ninja isn't installed
715         https://bugs.webkit.org/show_bug.cgi?id=130129
716
717         Reviewed by Csaba Osztrogonác.
718
719         * Scripts/webkitdirs.pm:
720         (canUseNinja): Redirecting stderr to /dev/null
721
722 2014-03-13  Andres Gomez  <agomez@igalia.com>
723
724         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
725         https://bugs.webkit.org/show_bug.cgi?id=130092
726
727         Reviewed by Csaba Osztrogonác.
728
729         Added "python-dev" as dependency for deb based distros. It is
730         already present for rpm based distros. This dependency will allow
731         libxml2 to generate its python bindings, needed by gtk-doc.
732
733         * gtk/install-dependencies:
734
735 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
736
737         Unreviewed. Fix GTK+ cmake build after r165488.
738
739         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
740
741 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
742
743         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
744         https://bugs.webkit.org/show_bug.cgi?id=130014
745
746         Reviewed by Martin Robinson.
747
748         Include cmake or autotools config header.
749
750         * MiniBrowser/gtk/BrowserDownloadsBar.c:
751         * MiniBrowser/gtk/BrowserSearchBar.c:
752         * MiniBrowser/gtk/BrowserWindow.c:
753         * MiniBrowser/gtk/main.c:
754
755 2014-03-12  Commit Queue  <commit-queue@webkit.org>
756
757         Unreviewed, rolling out r165471.
758         https://bugs.webkit.org/show_bug.cgi?id=130139
759
760         Didn't really fix the issue and broke another bot (Requested
761         by mrobinson on #webkit).
762
763         Reverted changeset:
764
765         "[CMake] Newer versions of CMake cannot find older versions of
766         Freetype"
767         https://bugs.webkit.org/show_bug.cgi?id=130107
768         http://trac.webkit.org/changeset/165471
769
770 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
771
772         It should be possible to build WebKit with FTL on iOS
773         https://bugs.webkit.org/show_bug.cgi?id=130116
774
775         Reviewed by Dan Bernstein.
776
777         * Scripts/build-webkit:
778         * Scripts/copy-webkitlibraries-to-product-directory:
779
780 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
781
782         [Win] Remove use of QTSDK
783         https://bugs.webkit.org/show_bug.cgi?id=130049
784
785         Reviewed by Darin Adler.
786
787         * DumpRenderTree/win/DumpRenderTree.cpp:
788         (initialize): Remove QuickTime code.
789         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
790         building QTMovieWin.
791
792 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
793
794         [GTK][CMAKE] Too verbose build output
795         https://bugs.webkit.org/show_bug.cgi?id=130076
796
797         Reviewed by Carlos Garcia Campos.
798
799         Instead of building with cmake --build which isn't smart about pretty printing and
800         colors, we build with a script which calls the proper build command.
801
802         * Scripts/webkitdirs.pm:
803         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
804         the CMake configuration pass.
805
806 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
807
808         [CMake] Newer versions of CMake cannot find older versions of Freetype
809         https://bugs.webkit.org/show_bug.cgi?id=130107
810
811         Reviewed by Gustavo Noronha Silva.
812
813         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
814         to CMake during jhbuild initialization.
815
816 2014-03-12  Zalan Bujtas  <zalan@apple.com>
817
818         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
819         https://bugs.webkit.org/show_bug.cgi?id=129961
820
821         Reviewed by Simon Fraser.
822
823         Now scaled content can go through the window capturing mechanism too for compositing content.
824         AppleMagnifiedMode is redundant.
825
826         * DumpRenderTree/mac/DumpRenderTree.mm:
827         (setDefaultsToConsistentValuesForTesting):
828         (runTest):
829         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
830         (createBitmapContextFromWebView):
831         * WebKitTestRunner/PlatformWebView.h:
832         * WebKitTestRunner/cg/TestInvocationCG.cpp:
833         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
834         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
835         (WTR::PlatformWebView::didInitializeClients):
836         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
837         (WTR::PlatformWebView::forceWindowFramesChanged):
838         * WebKitTestRunner/mac/main.mm:
839         (setDefaultsToConsistentValuesForTesting):
840
841 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
842
843         Unreviewed. Add myself as a committer.
844
845         * Scripts/webkitpy/common/config/contributors.json:
846
847 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
848
849         Unreviewed build fix on the EFL port when used lower version of ATK
850
851         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
852         (WTR::AccessibilityUIElement::y): Fixed typo.
853
854 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
855
856         Some images are blank in the rebaseline server UI
857         https://bugs.webkit.org/show_bug.cgi?id=130104
858
859         Reviewed by Tim Horton.
860
861         Let the server check for images in the 'retries' directory
862         if it can't find an image otherwise.
863
864         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
865         (RebaselineHTTPRequestHandler.test_result):
866
867 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
868
869         [GTK][CMake] --update-gtk has no effect
870         https://bugs.webkit.org/show_bug.cgi?id=130088
871
872         Reviewed by Philippe Normand.
873
874         * Scripts/webkitdirs.pm:
875         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
876         as an argument.
877
878 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
879
880         Add "System Font" to the list of whitelisted DRT fonts
881         https://bugs.webkit.org/show_bug.cgi?id=130046
882
883         Reviewed by Darin Adler.
884
885         * DumpRenderTree/mac/DumpRenderTree.mm:
886         (allowedFontFamilySet):
887         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
888
889 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
890
891         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
892         https://bugs.webkit.org/show_bug.cgi?id=130064
893
894         Reviewed by Philippe Normand.
895
896         * efl/jhbuildrc: Remove duplicated code.
897         * gtk/jhbuildrc: Remove duplicated code.
898         * jhbuild/jhbuildrc_common.py:
899         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
900         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
901         and is apparently necessary for GTK+.
902
903 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
904
905         check-webkit-style failed to complain about missing braces
906         https://bugs.webkit.org/show_bug.cgi?id=34189
907
908         Reviewed by Ryosuke Niwa.
909
910         * Scripts/webkitpy/style/checkers/cpp.py:
911         (check_braces):
912         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
913         (WebKitStyleTest.test_braces):
914
915 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
916
917         Remove Qt cruft from style checker.
918         https://bugs.webkit.org/show_bug.cgi?id=130085
919
920         Reviewed by Csaba Osztrogonác.
921
922         There is no 'foreach' keyword in c++. That was a Qt feature
923         added in: http://trac.webkit.org/changeset/46113
924         Qt was removed from WebKit, so we should remove the checks
925         of this keyword from check-webkit-style scripts.
926
927         * Scripts/webkitpy/style/checkers/cpp.py:
928         (check_spacing_for_function_call):
929         (check_spacing):
930         (check_braces):
931         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
932         (CppStyleTest.test_mismatching_spaces_in_parens):
933         (CppStyleTest.test_spacing_for_fncall):
934         (WebKitStyleTest.test_braces):
935
936 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
937
938         [GTK] update-webkitgtk-libs needs itstool
939         https://bugs.webkit.org/show_bug.cgi?id=130082
940
941         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
942         itstool is a dependency of building gtk-doc from version 1.19, so it should
943         be added to Tools/gtk/install-dependencies script, too.
944
945         Reviewed by Philippe Normand.
946
947         * gtk/install-dependencies:
948
949 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
950
951         webkitbot rollout ChangeLogs should be nicer
952         https://bugs.webkit.org/show_bug.cgi?id=122654
953
954         Reviewed by Csaba Osztrogonác.
955
956         Added bug urls and descriptions of rolled out patches to the rollout changelog
957         if they are present in the original changelog. Additionally removed the list of
958         changed files and functions.
959
960         * Scripts/webkitpy/common/checkout/changelog.py:
961         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
962         * Scripts/webkitpy/common/checkout/checkout.py:
963         (Checkout._changelog_data_for_revision): Store bug description.
964         * Scripts/webkitpy/common/checkout/checkout_mock.py:
965         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
966         (CheckoutTest.test_commit_info_for_revision):
967         * Scripts/webkitpy/common/checkout/commitinfo.py:
968         (CommitInfo.bug_description): Added.
969         (CommitInfo.to_json):
970         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
971         (CommitInfoTest.test_commit_info_creation):
972         * Scripts/webkitpy/tool/commands/download.py:
973         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
974         out patches for creating rollout changelog.
975         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
976         caused the regression is stored in state["bug_blocked"] now.
977         * Scripts/webkitpy/tool/commands/download_unittest.py:
978         (test_prepare_rollout):
979         (test_create_rollout_multiple_revision):
980         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
981         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
982         rolled out patches to the changelog.
983         (PrepareChangeLogForRevert.run):
984         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
985         (UpdateChangeLogsForRevertTest):
986         (test_message_for_revert):
987         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
988         (ReopenBugAfterRollout.run):
989
990 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
991
992         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
993         https://bugs.webkit.org/show_bug.cgi?id=130021
994
995         Reviewed by Mario Sanchez Prada.
996
997         Replace deprecated functions to use new API from ATK 2.11.90.
998
999         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1000         (AccessibilityUIElement::x):
1001         (AccessibilityUIElement::y):
1002         (AccessibilityUIElement::width):
1003         (AccessibilityUIElement::height):
1004         (AccessibilityUIElement::clickPointX):
1005         (AccessibilityUIElement::clickPointY):
1006         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1007         (WTR::AccessibilityUIElement::x):
1008         (WTR::AccessibilityUIElement::y):
1009         (WTR::AccessibilityUIElement::width):
1010         (WTR::AccessibilityUIElement::height):
1011         (WTR::AccessibilityUIElement::clickPointX):
1012         (WTR::AccessibilityUIElement::clickPointY):
1013
1014 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1015
1016         [ATK] Expose aria-posinset and aria-setsize through object attributes
1017         https://bugs.webkit.org/show_bug.cgi?id=130011
1018
1019         Reviewed by Chris Fleizach.
1020
1021         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1022
1023         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1024         (AccessibilityUIElement::numberAttributeValue):
1025         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1026         (WTR::AccessibilityUIElement::numberAttributeValue):
1027
1028 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1029
1030         [Win] Unreviewed build fix.
1031
1032         Some bad Windows code was committed at some point that prevents the Apple Windows port
1033         from finding its runtime dependencies reliably.
1034
1035         * win/DLLLauncher/DLLLauncherMain.cpp:
1036         (appleApplicationSupportDirectory): Restored this function.
1037         (modifyPath): Update to use appleApplicationSupportDirectory function.
1038
1039 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1040
1041         Let the user define the full address of the performance-site-server for uploading results
1042         https://bugs.webkit.org/show_bug.cgi?id=129819
1043
1044         Reviewed by Ryosuke Niwa.
1045
1046         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1047         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1048         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1049         protocol for now, in order to avoid breaking the perf bots.
1050
1051         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1052         (_upload_json):
1053         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1054         (MainTest.test_upload_json):
1055
1056 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1057
1058         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1059         https://bugs.webkit.org/show_bug.cgi?id=130023
1060
1061         Reviewed by Dean Jackson.
1062
1063         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1064         /SAFESEH flag to DLL launcher process.
1065
1066 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1067
1068         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1069         https://bugs.webkit.org/show_bug.cgi?id=129980
1070
1071         Reviewed by Carlos Garcia Campos.
1072
1073         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1074
1075 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1076
1077         [GTK] Remove the WebView source-mode WebKit1 test
1078         https://bugs.webkit.org/show_bug.cgi?id=129976
1079
1080         Reviewed by Carlos Garcia Campos.
1081
1082         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1083
1084 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1085
1086         Unreviewed build fix for GTKbuild after the switch to CMake
1087
1088         * gtk/common.py:
1089         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1090         test-only bot doesn't have any build files.
1091
1092 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1093
1094         [GTK] built-product-archive does not handle GTK+ CMake build
1095         https://bugs.webkit.org/show_bug.cgi?id=129941
1096
1097         * BuildSlaveSupport/built-product-archive:
1098         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1099         the CMake build.
1100
1101 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1102
1103         [GTK] Include CMake into install-dependencies script
1104         https://bugs.webkit.org/show_bug.cgi?id=129909
1105
1106         Reviewed by Martin Robinson.
1107
1108         As since r165267 buid-webkit uses CMake by default, the dependency
1109         with 'cmake' package should be introduced.
1110
1111         * gtk/install-dependencies: Ditto.
1112
1113 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1114
1115         REGRESSION(165267): Broke a webkitpy unit tests
1116         https://bugs.webkit.org/show_bug.cgi?id=129904
1117
1118         Reviewed by Jon Honeycutt.
1119
1120         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1121         (GtkPort._is_cmake_build):
1122
1123 2014-03-07  Andres Gomez  <agomez@igalia.com>
1124
1125         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1126         https://bugs.webkit.org/show_bug.cgi?id=129893
1127
1128         Reviewed by Martin Robinson.
1129
1130         Added "git-svn" as dependency for deb based distros and,
1131         additionally, "subversion" for rpm based distros.
1132
1133         * gtk/install-dependencies:
1134
1135 2014-03-07  Roger Fong  <roger_fong@apple.com>
1136
1137         Remove dummy setSystemWebGLLoadPolicy client method.
1138         https://bugs.webkit.org/show_bug.cgi?id=129873.
1139
1140         Reviewed by Dean Jackson.
1141
1142         * WebKitTestRunner/TestController.cpp:
1143         (WTR::TestController::createWebViewWithOptions):
1144
1145 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1146
1147         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1148         https://bugs.webkit.org/show_bug.cgi?id=129886
1149
1150         Reviewed by Mark Lam.
1151
1152         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1153         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1154         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1155         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1156         make it through when in non-verbose mode.
1157
1158 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1159
1160         [GTK] buid-webkit should use CMake by default
1161         https://bugs.webkit.org/show_bug.cgi?id=129855
1162
1163         Reviewed by Carlos Garcia Campos.
1164
1165         Make the CMake build the default GTK+ build when using build-webkit. This will
1166         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1167         so that we have --gtk and --gtkautotools.
1168
1169         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1170         * Scripts/webkitpy/port/gtk.py: Ditto.
1171
1172 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1173
1174         [CMake] [GTK] Build with ninja when it is available
1175         https://bugs.webkit.org/show_bug.cgi?id=129805
1176
1177         Reviewed by Philippe Normand.
1178
1179         * Scripts/webkitdirs.pm:
1180         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1181         if it's available on the system.
1182         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1183         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1184
1185 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1186
1187         If the FTL is build-time enabled then it should be run-time enabled.
1188
1189         Rubber stamped by Geoffrey Garen.
1190
1191         * Scripts/run-jsc-stress-tests:
1192
1193 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1194
1195         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1196         https://bugs.webkit.org/show_bug.cgi?id=129837
1197
1198         Reviewed by Michael Saboff.
1199
1200         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1201         The fix is to use find instead of ls like we do in shell-runner.sh.
1202
1203         * Scripts/run-jsc-stress-tests:
1204
1205 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1206
1207         filter-build-webkit should not strip .o
1208         https://bugs.webkit.org/show_bug.cgi?id=129614
1209
1210         Reviewed by Dean Jackson.
1211
1212         This makes it much easier to jump from the failing output at
1213         the end back up to the compile errors earlier in the output.
1214
1215         * Scripts/filter-build-webkit:
1216
1217 2014-03-06  Anders Carlsson  <andersca@apple.com>
1218
1219         Build WebKit2 before building WebKit
1220         https://bugs.webkit.org/show_bug.cgi?id=129831
1221         <rdar://problem/15920020>
1222
1223         Reviewed by Dan Bernstein.
1224
1225         * Scripts/build-webkit:
1226         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1227
1228 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1229
1230         make-3.82 fails to build on ARM/Linux
1231         https://bugs.webkit.org/show_bug.cgi?id=107926
1232
1233         Reviewed by Martin Robinson.
1234
1235         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1236         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1237         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1238         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1239
1240         * gtk/patches/make-3.82-arg-list-length.patch:
1241
1242 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1243
1244         [GTK] Close the page when the view is disposed instead of when finalized
1245         https://bugs.webkit.org/show_bug.cgi?id=129783
1246
1247         Reviewed by Sergio Villar Senin.
1248
1249         Add test case but disabled for now because it's affetected by bug #129684.
1250
1251         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1252         (testProcessPerWebView):
1253
1254 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1255
1256         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1257         https://bugs.webkit.org/show_bug.cgi?id=129738
1258
1259         Reviewed by Sergio Villar Senin.
1260
1261         The problem is that we are calling g_object_unref() for the
1262         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1263         view only increases the reference counter when the settings is not
1264         the same it currently has. We should release our reference once.
1265
1266         * MiniBrowser/gtk/main.c:
1267         (createBrowserWindow):
1268         (main):
1269
1270 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1271
1272         [GTK][CMake] Tarball is created with wrong tarball paths
1273         https://bugs.webkit.org/show_bug.cgi?id=129496
1274
1275         Reviewed by Daniel Bates.
1276
1277         * gtk/make-dist.py:
1278         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1279         landing the original patch with some suggestions from the reviewer. With the
1280         checks corrected, the tarball path is constructed properly.
1281
1282 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1283
1284         Unreviewed. Update my email in contributors.json
1285
1286         * Scripts/webkitpy/common/config/contributors.json:
1287
1288 2014-03-05  Dean Jackson  <dino@apple.com>
1289
1290         [WebGL] Use WKSI to see what the system policy for WebGL is
1291         https://bugs.webkit.org/show_bug.cgi?id=129722
1292         <rdar://problem/15790542>
1293
1294         Reviewed by Tim Horton.
1295
1296         Dummy entry for setSystemWebGLLoadPolicy.
1297
1298         * WebKitTestRunner/TestController.cpp:
1299         (WTR::TestController::createWebViewWithOptions):
1300
1301 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1302
1303         [GTK][CMake] Generate documentation for the DOM bindings
1304         https://bugs.webkit.org/show_bug.cgi?id=126211
1305
1306         Reviewed by Carlos Garcia Campos.
1307
1308         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1309         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1310         * gtk/generate-webkitdom-doc-files: Removed.
1311         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1312         that it can be called by generate-gtkdoc.
1313
1314 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1315
1316         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1317         https://bugs.webkit.org/show_bug.cgi?id=129380
1318
1319         Reviewed by Philippe Normand.
1320
1321         * Scripts/webkitdirs.pm:
1322         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1323         skipping CMake execution.
1324
1325 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1326
1327         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1328         https://bugs.webkit.org/show_bug.cgi?id=129651
1329
1330         Reviewed by Philippe Normand.
1331
1332         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1333
1334 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1335
1336         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1337         https://bugs.webkit.org/show_bug.cgi?id=129637
1338
1339         Reviewed by Carlos Garcia Campos.
1340
1341         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1342         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1343         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1344         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1345         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1346         (TestFactory.__init__): Add the test for GTK+.
1347         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1348
1349 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1350
1351         [ATK] Expose missing functionalities of AtkTableCell to AT
1352         https://bugs.webkit.org/show_bug.cgi?id=129492
1353
1354         Reviewed by Mario Sanchez Prada.
1355
1356         Reducing some code by using new API of AtkTableCell.
1357
1358         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1359         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1360
1361 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1362
1363         Preparing to run layout tests on Wincairo.
1364         https://bugs.webkit.org/show_bug.cgi?id=129709
1365
1366         Reviewed by Brent Fulgham.
1367
1368         * Scripts/webkitdirs.pm:
1369         (setPathForRunningWebKitApp):
1370         Add GStreamer directory for WinCairo running layout tests.
1371         * win/DLLLauncher/DLLLauncherMain.cpp:
1372         (modifyPath):
1373         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1374
1375 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1376
1377         [GTK] Simplify the GObject DOM bindings API break check into one step
1378         https://bugs.webkit.org/show_bug.cgi?id=129571
1379
1380         Reviewed by Carlos Garcia Campos.
1381
1382         * GNUmakefile.am: Add the API break check to 'make check.'
1383         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1384         * gtk/check-gdom-symbols: Removed.
1385         * gtk/webkitdom.py: Added.
1386         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1387         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1388
1389 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1390
1391         Add Jeremy Jones to the contributors list as a contributor.
1392
1393         * Scripts/webkitpy/common/config/contributors.json:
1394
1395 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1396
1397         Unreviewed. Update contact email.
1398         https://bugs.webkit.org/show_bug.cgi?id=129610
1399
1400         * Scripts/webkitpy/common/config/contributors.json:
1401
1402 2014-03-02  Brian Burg  <bburg@apple.com>
1403
1404         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1405         https://bugs.webkit.org/show_bug.cgi?id=129460
1406
1407         Reviewed by Dan Bernstein.
1408
1409         Don't unconditionally open the inspector before running an inspector test.
1410         Instead, the test should request that the inspector open when it's ready.
1411
1412         This change was lost during a rebase, but is the same change made to
1413         DumpRenderTree.
1414
1415         * WebKitTestRunner/TestInvocation.cpp:
1416         (WTR::TestInvocation::invoke): 
1417
1418 2014-03-02  Darin Adler  <darin@apple.com>
1419
1420         Split TextIteratorBehavior into a separate header
1421         https://bugs.webkit.org/show_bug.cgi?id=129578
1422
1423         Reviewed by Sam Weinig.
1424
1425         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1426         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1427         task easy, but the remove is still a bit of a pain.
1428
1429 2014-03-02  Darin Adler  <darin@apple.com>
1430
1431         Sort Mac platform export files so they merge better
1432         https://bugs.webkit.org/show_bug.cgi?id=129581
1433
1434         Reviewed by Sam Weinig.
1435
1436         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1437         Mac export files in a "canonical" order for this project.
1438
1439 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1440
1441         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1442         https://bugs.webkit.org/show_bug.cgi?id=129438
1443
1444         Reviewed by Simon Fraser.
1445
1446         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1447         offscreen window. It makes testing subpixel rendering and positioning possible.
1448
1449         Both the offscreen window's and WebKit's scaling are set accordingly.
1450
1451         * DumpRenderTree/mac/DumpRenderTree.mm:
1452         (createWebViewAndOffscreenWindow): cleanup
1453         (destroyWebViewAndOffscreenWindow): cleanup
1454         (dumpRenderTree):
1455         (changeWindowScaleIfNeeded):
1456         (runTest):
1457         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1458         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1459         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1460         * WebKitTestRunner/PlatformWebView.h:
1461         * WebKitTestRunner/TestInvocation.cpp:
1462         (WTR::changeWindowScaleIfNeeded):
1463         (WTR::TestInvocation::invoke):
1464         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1465         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1466         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1467         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1468         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1469         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1470         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1471         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1472
1473 2014-02-28  Anders Carlsson  <andersca@apple.com>
1474
1475         Remove logging.
1476
1477         Reviewed by Dan Bernstein.
1478
1479         * MiniBrowser/mac/WK2BrowserWindowController.m:
1480         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1481
1482 2014-02-28  Daniel Bates  <dabates@apple.com>
1483
1484         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1485         https://bugs.webkit.org/show_bug.cgi?id=129163
1486
1487         Reviewed by David Kilzer.
1488
1489         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1490         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1491         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1492         bundle.
1493
1494         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1495         which is specified either explicitly when building with MAKE(1) or implicitly by
1496         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1497         the OS X SDK and toolchain since the built products are only applicable to OS X.
1498
1499         * DumpRenderTree/ios/PerlSupport/Makefile:
1500
1501 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1502
1503         Unreviewed, rolling out r164859.
1504         http://trac.webkit.org/changeset/164859
1505         https://bugs.webkit.org/show_bug.cgi?id=129483
1506
1507         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
1508         #webkit).
1509
1510         * DumpRenderTree/mac/DumpRenderTree.mm:
1511         (createWebViewAndOffscreenWindow):
1512         (dumpRenderTree):
1513         (runTest):
1514         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1515         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1516         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1517         * WebKitTestRunner/PlatformWebView.h:
1518         * WebKitTestRunner/TestInvocation.cpp:
1519         (WTR::TestInvocation::invoke):
1520         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1521         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1522         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1523         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1524         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1525
1526 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1527
1528         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1529         https://bugs.webkit.org/show_bug.cgi?id=129438
1530
1531         Reviewed by Simon Fraser.
1532
1533         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1534         offscreen window. It makes testing subpixel rendering and positioning possible.
1535
1536         Both the offscreen window's and WebKit's scaling are set accordingly.
1537
1538         * DumpRenderTree/mac/DumpRenderTree.mm:
1539         (createWebViewAndOffscreenWindow): unrelated cleanup.
1540         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
1541         (dumpRenderTree):
1542         (changeOffscreenWindowScaleIfNeeded):
1543         (runTest):
1544         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1545         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1546         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
1547         * WebKitTestRunner/PlatformWebView.h:
1548         * WebKitTestRunner/TestInvocation.cpp:
1549         (WTR::changeOffscreenWindowScaleIfNeeded):
1550         (WTR::TestInvocation::invoke):
1551         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1552         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
1553
1554 2014-02-27  Brian Burg  <bburg@apple.com>
1555
1556         Web Inspector: model tests should use a special Test.html inspector page
1557         https://bugs.webkit.org/show_bug.cgi?id=129190
1558
1559         Reviewed by Timothy Hatcher.
1560
1561         Remove code that immediately opens the Web Inspector based on the file path of the test.
1562         Instead, the test page should request that the inspector open inside its `test()` method.
1563
1564         This change is necessary because otherwise, the inspector would be opened too early for
1565         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
1566         will get loaded instead of the minimal test page.
1567
1568         * DumpRenderTree/efl/DumpRenderTree.cpp:
1569         (createTestRunner):
1570         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1571         (runTest):
1572         * DumpRenderTree/mac/DumpRenderTree.mm:
1573         (runTest):
1574         * DumpRenderTree/win/DumpRenderTree.cpp:
1575         (runTest):
1576
1577 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1578
1579         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
1580         https://bugs.webkit.org/show_bug.cgi?id=127076
1581
1582         Reviewed by Anders Carlsson.
1583
1584         Avoid match for :: as start of a member initialization list. Modify expression to match
1585         after a colon either non-colon character or end of line.
1586
1587         * Scripts/webkitpy/style/checkers/cpp.py:
1588         (check_member_initialization_list):
1589         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1590         (WebKitStyleTest.test_member_initialization_list):
1591
1592 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
1593
1594         Unreviewed. Update my email addresses in contributors.json.
1595
1596         * Scripts/webkitpy/common/config/contributors.json:
1597
1598 2014-02-27  Alberto Garcia  <berto@igalia.com>
1599
1600         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
1601         https://bugs.webkit.org/show_bug.cgi?id=128927
1602
1603         Reviewed by Philippe Normand.
1604
1605         Encode manually the data for sys.{stdout,stderr}.write.
1606
1607         * gtk/gtkdoc.py:
1608         (GTKDoc._run_command):
1609
1610 2014-02-27  Andres Gomez  <agomez@igalia.com>
1611
1612         Unreviewed. Add myself to watchlists
1613
1614         * Scripts/webkitpy/common/config/watchlist: Add myself to
1615         watchlists.
1616
1617 2014-02-27  Andres Gomez  <agomez@igalia.com>
1618
1619         Unreviewed, rolling out r164790.
1620         http://trac.webkit.org/changeset/164790
1621
1622         Revert r164790 because of erroneous commit log
1623
1624         * Scripts/webkitpy/common/config/watchlist:
1625
1626 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
1627
1628         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
1629         https://bugs.webkit.org/show_bug.cgi?id=129250
1630
1631         Reviewed by Mario Sanchez Prada.
1632
1633         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
1634         Implementing methods so that we could test column/row headers represented as an array of cells.
1635
1636         * DumpRenderTree/AccessibilityUIElement.cpp:
1637         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1638         (AccessibilityUIElement::columnHeaders):
1639         (AccessibilityUIElement::rowHeaders):
1640         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
1641         (AccessibilityUIElement::columnHeaders):
1642         (AccessibilityUIElement::rowHeaders):
1643         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1644         (WTR::AccessibilityUIElement::rowHeaders):
1645         (WTR::AccessibilityUIElement::columnHeaders):
1646         * efl/jhbuild.modules:
1647         * gtk/jhbuild.modules:
1648
1649 2014-02-27  Andres Gomez  <agomez@igalia.com>
1650
1651         Unreviewed. Add myself to watchlists
1652
1653         * Scripts/webkitpy/common/config/watchlist: Add myself to
1654         watchlists.
1655
1656 2014-02-27  Andres Gomez  <agomez@igalia.com>
1657
1658         Unreviewed. Add myself as a committer.
1659
1660         * Scripts/webkitpy/common/config/contributors.json:
1661
1662 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1663
1664         Unreviewed. Add Víctor Jáquez and myself to watchlists
1665
1666         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
1667         myself to watchlists.
1668
1669 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
1670
1671         Unreviewed. Add myself as a committer.
1672
1673         * Scripts/webkitpy/common/config/contributors.json:
1674
1675 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1676
1677         Unreviewed. Moved myself to the list of committers.
1678
1679         * Scripts/webkitpy/common/config/contributors.json:
1680
1681 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1682
1683         [GTK] Reduplicate common.top_level_path in scripts
1684         https://bugs.webkit.org/show_bug.cgi?id=129291
1685
1686         Reviewed by Philippe Normand.
1687
1688         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
1689         path manipulation and weird dependencies on the jhbuild infrastructure.
1690
1691         * Scripts/run-gtk-tests: Use common again.
1692         (TestRunner._setup_testing_environment): Ditto.
1693         * gtk/check-gdom-symbols: Ditto.
1694         * gtk/common.py:
1695         (top_level_path): Re-add top_level_path..
1696         (get_build_path): Use the builtin top_level_path again.
1697         * gtk/find-make-dist-errors: Use common again.
1698         (get_missing_headers): Ditto.
1699         * gtk/generate-inspector-gresource-manifest.py: Ditto.
1700
1701 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1702
1703         runscript: line 42: /bin/ls: Argument list too long
1704         https://bugs.webkit.org/show_bug.cgi?id=129376
1705
1706         Reviewed by Michael Saboff.
1707
1708         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
1709         We should use find instead, which generates the list of files rather than expanding them all on 
1710         the command line and spitting them back out.
1711
1712         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
1713
1714 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1715
1716         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
1717         https://bugs.webkit.org/show_bug.cgi?id=129377
1718
1719         Reviewed by Csaba Osztrogonác.
1720
1721         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
1722
1723 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
1724
1725         [GTK] Re-enable gtk-doc in EWS
1726         https://bugs.webkit.org/show_bug.cgi?id=128369
1727
1728         Reviewed by Carlos Garcia Campos.
1729
1730         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1731
1732         * Scripts/webkitpy/common/config/ports.py:
1733         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1734         (GtkWK2Port.build_webkit_command): Ditto.
1735         * Scripts/webkitpy/common/config/ports_unittest.py:
1736         (DeprecatedPortTest.test_gtk_port): Ditto.
1737         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1738
1739 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1740
1741         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
1742         https://bugs.webkit.org/show_bug.cgi?id=129319
1743
1744         Reviewed by Carlos Garcia Campos.
1745
1746         * gtk/generate-gtkdoc:
1747         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
1748
1749 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
1750
1751         Unreviewed. Add myself as a committer.
1752
1753         * Scripts/webkitpy/common/config/contributors.json:
1754
1755 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
1756
1757         [CSS Grid Layout] Add ENABLE flag
1758         https://bugs.webkit.org/show_bug.cgi?id=129153
1759
1760         Reviewed by Simon Fraser.
1761
1762         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
1763         all ports for developer builds.
1764
1765         * Scripts/webkitperl/FeatureList.pm:
1766
1767 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1768
1769         Added myself as a committer.
1770
1771         Unreviewed.
1772
1773         * Scripts/webkitpy/common/config/contributors.json:
1774
1775 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1776
1777         Unreviewed. Moved myself to the list of committers.
1778
1779         * Scripts/webkitpy/common/config/contributors.json:
1780
1781 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1782
1783         Move myself to the committers list.
1784
1785         Unreviewed.
1786
1787         * Scripts/webkitpy/common/config/contributors.json:
1788
1789 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
1790
1791         Unreviewed. Add myself as a committer.
1792
1793         * Scripts/webkitpy/common/config/contributors.json:
1794
1795 2014-02-25  Commit Queue  <commit-queue@webkit.org>
1796
1797         Unreviewed, rolling out r164639.
1798         http://trac.webkit.org/changeset/164639
1799         https://bugs.webkit.org/show_bug.cgi?id=129302
1800
1801         gtk-doc still have problems in EWS (Requested by rego on
1802         #webkit).
1803
1804         * Scripts/webkitpy/common/config/ports.py:
1805         (GtkPort.build_webkit_command):
1806         (GtkWK2Port.build_webkit_command):
1807         * Scripts/webkitpy/common/config/ports_unittest.py:
1808         (DeprecatedPortTest.test_gtk_port):
1809         (DeprecatedPortTest.test_gtk_wk2_port):
1810
1811 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
1812
1813         [GTK] Re-enable gtk-doc in EWS
1814         https://bugs.webkit.org/show_bug.cgi?id=128369
1815
1816         Reviewed by Carlos Garcia Campos.
1817
1818         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1819
1820         * Scripts/webkitpy/common/config/ports.py:
1821         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1822         (GtkWK2Port.build_webkit_command): Ditto.
1823         * Scripts/webkitpy/common/config/ports_unittest.py:
1824         (DeprecatedPortTest.test_gtk_port): Ditto.
1825         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1826
1827 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1828
1829         [GTK] Mark view source mode methods as deprecated
1830         https://bugs.webkit.org/show_bug.cgi?id=128920
1831
1832         Reviewed by Martin Robinson.
1833
1834         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1835         (beforeAll): Remove view mode test.
1836
1837 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1838
1839         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
1840         https://bugs.webkit.org/show_bug.cgi?id=128417
1841
1842         Reviewed by Carlos Garcia Campos.
1843
1844         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
1845         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
1846         a makefile. This allows accepting a header list from the build system, which can be used
1847         to dynamically build a list of ignored files. We can ignore any source file that doesn't
1848         have a corresponding header file on the header list. 
1849         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
1850         source directories to gtkdoc-scan.
1851
1852 2014-02-24  Anders Carlsson  <andersca@apple.com>
1853
1854         Add a DefaultVisitedLinkProvider and route visited link actions through it
1855         https://bugs.webkit.org/show_bug.cgi?id=129285
1856
1857         Reviewed by Dan Bernstein.
1858
1859         * MiniBrowser/mac/AppDelegate.m:
1860         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1861         Set a shared history so we'll get visited link tracking.
1862
1863         * MiniBrowser/mac/WK1BrowserWindowController.m:
1864         (-[WK1BrowserWindowController awakeFromNib]):
1865         Set a group name.
1866
1867 2014-02-24  Dan Bernstein  <mitz@apple.com>
1868
1869         iOS build fix after r164577.
1870
1871         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1872         (AccessibilityUIElement::selectedChildrenCount):
1873         (AccessibilityUIElement::selectedChildAtIndex):
1874
1875 2014-02-24  David Kilzer  <ddkilzer@apple.com>
1876
1877         [ASan] Remove methods from ignore list that no longer cause crashes
1878         <http://webkit.org/b/129257>
1879
1880         Reviewed by Anders Carlsson.
1881
1882         * asan/webkit-asan-ignore.txt: Remove old methods.
1883
1884 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1885
1886         Extract common parts from jhbuildrc files.
1887         https://bugs.webkit.org/show_bug.cgi?id=125986
1888
1889         Reviewed by Csaba Osztrogonác.
1890
1891         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
1892
1893         * Scripts/run-gtk-tests:
1894         (TestRunner._setup_testing_environment):
1895         * efl/common.py: Removed.
1896         * efl/jhbuildrc:
1897         * gtk/check-gdom-symbols:
1898         * gtk/common.py:
1899         (binary_build_path):
1900         (get_build_path):
1901         * gtk/find-make-dist-errors:
1902         (get_missing_headers):
1903         * gtk/generate-gtkdoc:
1904         (get_webkit2_options):
1905         (get_webkit1_options.src_path):
1906         (get_webkit1_options):
1907         (get_webkitdom_options.src_path):
1908         (get_webkitdom_options):
1909         * gtk/generate-inspector-gresource-manifest.py:
1910         * gtk/jhbuildrc:
1911         * jhbuild/jhbuildrc_common.py: Added.
1912         (script_path):
1913         (top_level_path):
1914         (init):
1915
1916 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
1917
1918         Unreviewed. Fix code indentation and spacing.
1919
1920         * Scripts/webkitpy/style/checkers/js.py:
1921         (SingleQuoteChecker.check):
1922
1923 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
1924
1925         [ATK] Wrong selected element at a given index in a list box.
1926         https://bugs.webkit.org/show_bug.cgi?id=129039
1927
1928         Reviewed by Chris Fleizach.
1929
1930         Added missing implementation and proposed some new function for testing selection
1931         in a list boxes.
1932
1933         * DumpRenderTree/AccessibilityUIElement.cpp:
1934         (setSelectedChildAtIndexCallback):
1935         (removeSelectionAtIndexCallback):
1936         (AccessibilityUIElement::getJSClass):
1937         * DumpRenderTree/AccessibilityUIElement.h:
1938         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1939         (AccessibilityUIElement::selectedChildrenCount):
1940         (AccessibilityUIElement::selectedChildAtIndex):
1941         (AccessibilityUIElement::setSelectedChildAtIndex):
1942         (AccessibilityUIElement::removeSelectionAtIndex):
1943         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1944         (AccessibilityUIElement::selectedChildrenCount):
1945         (AccessibilityUIElement::selectedChildAtIndex):
1946         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1947         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1948         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1949         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1950         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1951         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1952         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1953         (WTR::AccessibilityUIElement::selectedChildrenCount):
1954         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1955         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1956
1957 2014-02-23  Diego Pino García  <dpino@igalia.com>
1958
1959         [GTK] Fix build after Web Inspector code reorganization (r164543)
1960         https://bugs.webkit.org/show_bug.cgi?id=129231
1961
1962         Reviewed by Dean Jackson.
1963
1964         * gtk/generate-inspector-gresource-manifest.py:
1965         Modify paths to Web Inspector code.
1966
1967 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1968
1969         [GTK] generate-gtkdoc should use argparse
1970         https://bugs.webkit.org/show_bug.cgi?id=128418
1971
1972         Reviewed by Carlos Garcia Campos.
1973
1974         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
1975         to all functions, and guard the main routine with a __name__ == __main__ check.
1976
1977 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1978
1979         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
1980         https://bugs.webkit.org/show_bug.cgi?id=129191
1981
1982         Reviewed by Anders Carlsson.
1983
1984         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
1985         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
1986         name of the directory is "lib" and not "libs". Instead we should use the CMake
1987         variable specifically assigned to this task.
1988
1989 2014-02-23  David Kilzer  <ddkilzer@apple.com>
1990
1991         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
1992         <http://webkit.org/b/129209>
1993
1994         Reviewed by Geoffrey Garen.
1995
1996         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
1997         ignore list to make ASan builds usable again.  Follow-up
1998         investigation is tracked by <rdar://problem/16055903>.
1999
2000 2014-02-20  David Farler  <dfarler@apple.com>
2001
2002         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2003         https://bugs.webkit.org/show_bug.cgi?id=128622
2004
2005         Reviewed by Simon Fraser.
2006
2007         With this change, we now have layout tests running in both DumpRenderTree
2008         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2009         simulator.
2010
2011         * Scripts/old-run-webkit-tests:
2012         In general, make any specific reference to DumpRenderTree
2013         able to refer to WebKitTestRunner wherever possible:
2014         - Rename functions to remove DRT-specific naming.
2015         - Name FIFOs after the tool that is being used.
2016         -- Clean up FIFO creation code
2017         Other necessary changes:
2018         - Allow use of an ios-sim-wk2 platform.
2019         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2020         * WebKitTestRunner/TestController.cpp:
2021         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2022         (WTR::TestController::TestController):
2023         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2024         Copy the injected bundle into the app bundle.
2025
2026 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2027
2028         run-webkit-httpd fails to find httpd configuation file.
2029
2030         Reviewed by Ryosuke Niwa.
2031
2032         * Scripts/webkitperl/httpd.pm:
2033         (getHTTPDConfigPathForTestDirectory):
2034
2035 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2036
2037         Fix TimeRanges layering violations
2038         https://bugs.webkit.org/show_bug.cgi?id=128717
2039
2040         Reviewed by Jer Noble.
2041
2042         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2043         (TestWebKitAPI::TEST):
2044
2045 2014-02-21  Diego Pino García  <dpino@igalia.com>
2046
2047         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2048         https://bugs.webkit.org/show_bug.cgi?id=128422
2049
2050         Reviewed by Joseph Pecoraro.
2051
2052         * Scripts/webkitpy/style/checkers/js.py:
2053         (JSChecker.__init__):
2054         (JSChecker.check):
2055         (SingleQuoteChecker):
2056         (SingleQuoteChecker.__init__):
2057         (SingleQuoteChecker.check):
2058         * Scripts/webkitpy/style/checkers/js_unittest.py:
2059         (JSTestCase.assertError.error_for_test):
2060         (JSTestCase.assertError):
2061         (JSTestCase.test_no_error):
2062         (JSTestCase.test_error):
2063
2064 == Rolled over to ChangeLog-2014-02-20 ==