[WPE] Update jhbuild dependencies
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-31  Charlie Turner  <cturner@igalia.com>
2
3         [WPE] Update jhbuild dependencies
4         https://bugs.webkit.org/show_bug.cgi?id=182286
5
6         This upgrades the following packages,
7         glib 2.44.1 -> 2.54.3
8         glib-networking 2.42.0 -> 2.54.1
9         libsoup 2.48.0 -> 2.60.3
10
11         The initial reason for performing these upgrades was that when
12         visiting https://youtube.com, WPE was getting TLS certificate
13         errors. After upgrading glib-networking, these were fixed, but the
14         upgrade introduced dependencies on newer versions of the other
15         packages upgraded in this commit.
16
17         The upgrade to glib caused a linking error in gstreamer, the
18         following errors were being logged during linking,
19
20         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
21         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
22         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
23
24         This was fixed by adding the glib package built in the jhbuild to
25         harfbuzz.
26
27         Finally, the upgrade of glib caused the glib-warning-fix.patch to
28         no longer apply, so this patch was removed.
29
30         Reviewed by Michael Catanzaro.
31
32         * wpe/jhbuild.modules: Added dependecies.
33         * wpe/patches/glib-warning-fix.patch: Removed.
34
35 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
36
37         Unreviewed, rolling out r227782.
38
39         It didn't fix the problem
40
41         Reverted changeset:
42
43         "Unreviewed. Try to avoid webdriver tests step timing out in
44         the bots."
45         https://trac.webkit.org/changeset/227782
46
47 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
48
49         WebDriver: add domains to server config in w3c tests
50         https://bugs.webkit.org/show_bug.cgi?id=182294
51
52         Reviewed by Carlos Alberto Lopez Perez.
53
54         Several cookie tests expect server_config to have a domains key.
55
56         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
57                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
58
59         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
60         (WebDriverW3CExecutor.__init__):
61
62 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
63
64         Unreviewed. Update W3C WebDriver imported tests.
65
66         Show full pytest failure logs.
67
68         pytest truncates long lists when printing a failed assertion.
69         This is not great for debugging and arguably it should be the
70         default to show the full diff when comparing lists.
71
72         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
73         (run):
74
75 2018-01-30  John Wilander  <wilander@apple.com>
76
77         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
78         https://bugs.webkit.org/show_bug.cgi?id=181958
79         https://bugs.webkit.org/show_bug.cgi?id=182072
80         <rdar://problem/36801804>
81         <rdar://problem/36845795>
82
83         Reviewed by Brent Fulgham.
84
85         Because of the asynchronous nature of XPC and cookies,
86         we need callbacks in these TestRunner functions so that
87         the layout tests can wait for state changes to finish
88         before checking test conditions.
89
90         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
91         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
92         (WTR::InjectedBundle::didReceiveMessageToPage):
93         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
94         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
95         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
96         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
97         * WebKitTestRunner/InjectedBundle/TestRunner.h:
98         * WebKitTestRunner/TestInvocation.cpp:
99         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
100         * WebKitTestRunner/TestInvocation.h:
101         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
102         (WTR::TestController::statisticsUpdateCookiePartitioning):
103         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
104
105 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
106
107         [webkitpy] Config file for apache is copied twice.
108         https://bugs.webkit.org/show_bug.cgi?id=182131
109
110         Reviewed by Daniel Bates.
111
112         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
113         (LayoutTestApacheHttpd.__init__):
114         (LayoutTestApacheHttpd._copy_apache_config_file):
115         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
116
117 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
118
119         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
120         https://bugs.webkit.org/show_bug.cgi?id=182312
121
122         Reviewed by Michael Catanzaro.
123
124         * DumpRenderTree/config.h:
125         * TestWebKitAPI/config.h:
126         * WebKitTestRunner/config.h:
127
128 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
129
130         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
131         https://bugs.webkit.org/show_bug.cgi?id=182307
132         <rdar://problem/36041485>
133
134         Reviewed by Ryosuke Niwa.
135
136         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
137         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
138         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
139         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
140
141         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
142         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
143         (TestWebKitAPI::TEST):
144
145 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
146
147         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
148         https://bugs.webkit.org/show_bug.cgi?id=182284
149
150         Reviewed by Michael Catanzaro.
151
152         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
153         * wpe/manifest.txt.in: Ditto.
154
155 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
156
157         Unreviewed, try to fix JSCOnly build
158         https://bugs.webkit.org/show_bug.cgi?id=177202
159
160         * CMakeLists.txt:
161
162 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
163
164         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
165
166         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
167         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
168         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
169         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
170
171         * Scripts/run-webdriver-tests:
172         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
173         (WebDriverTestRunner.dump_results_to_json_file):
174
175 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
176
177         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
178         https://bugs.webkit.org/show_bug.cgi?id=177202
179
180         Reviewed by Alex Christensen.
181
182         * CMakeLists.txt:
183
184 2018-01-29  Alex Christensen  <achristensen@webkit.org>
185
186         Clean up API after bugs 178240 and 176474
187         https://bugs.webkit.org/show_bug.cgi?id=182259
188
189         Reviewed by Dan Bernstein.
190
191         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
192         (TEST):
193         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
194
195 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
196
197         [WebAuthN] Add a compile-time feature flag
198         https://bugs.webkit.org/show_bug.cgi?id=182211
199         <rdar://problem/36936365>
200
201         Reviewed by Brent Fulgham.
202
203         * Scripts/webkitperl/FeatureList.pm:
204         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
205
206 2018-01-29  Brady Eidson  <beidson@apple.com>
207
208         Make the API test added in r227737 be Mac-only.
209
210         Unreviewed gardening.
211
212         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
213
214 2018-01-29  Matt Lewis  <jlewis3@apple.com>
215
216         Unreviewed, rolling out r227731.
217
218         This caused and assertion failure in API tests.
219
220         Reverted changeset:
221
222         "Layout Test fast/events/beforeunload-dom-manipulation-
223         crash.html is crashing"
224         https://bugs.webkit.org/show_bug.cgi?id=181204
225         https://trac.webkit.org/changeset/227731
226
227 2018-01-29  Youenn Fablet  <youenn@apple.com>
228
229         WPT test exporter should add WebKit export in its PR description
230         https://bugs.webkit.org/show_bug.cgi?id=182246
231
232         Reviewed by Chris Dumez.
233
234         Updating PR description body to contain the words 'WebKit export'.
235         That way, WPT PR bot will mark the PR as reviewed downstream.
236
237         * Scripts/webkitpy/w3c/test_exporter.py:
238         (TestExporter.__init__):
239         (TestExporter.make_pull_request):
240         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
241         (TestExporterTest.test_export):
242
243 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
244
245         Add the support for running Speedometer 2.0 to run-benchmark
246         https://bugs.webkit.org/show_bug.cgi?id=182231
247
248         Reviewed by Antti Koivisto.
249
250         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
251         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
252         requires aggregating the geometric mean out of total time spent in each suite.
253
254         Also added --show-iteration-values to show individual measured values in each iteration.
255
256         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
257         (BenchmarkResults.format): Added show_iteration_values as an option.
258         (BenchmarkResults._format_tests): Ditto.
259         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
260         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
261         is easily parsable as a JSON array.
262         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
263         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
264         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
265         had exactly one aggregator.
266         (BenchmarkResults._lint_results):
267         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
268         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
269         parent_aggregator_list.
270         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
271         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
272         (BenchmarkResults._lint_configuration):
273         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
274         (test_format_values_with_no_unit_scaling): Added.
275         (test_format_values_with_iteration_values): Added.
276         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
277         (test_aggregate_results_from_another_aggregator): Added.
278         (test_lint_results): Added a test case.
279         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
280         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
281         (BenchmarkRunner._run_benchmark): Ditto.
282         (BenchmarkRunner.show_results): Ditto.
283         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
284         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
285         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
286         (parse_args): Added --show-iteration-values as a boolean argument.
287         (run_benchmark_plan): Ditto.
288         (start): Ditto.
289         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
290         (WebServerBenchmarkRunner.__init__): Ditto.
291
292 2018-01-29  Brady Eidson  <beidson@apple.com>
293
294         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
295         https://bugs.webkit.org/show_bug.cgi?id=182229
296
297         Reviewed by Chris Dumez.
298
299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
300         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
301
302 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
303
304         WebDriver: properly recover w3c tests after a webdriver server crash
305         https://bugs.webkit.org/show_bug.cgi?id=182242
306
307         Reviewed by Carlos Alberto Lopez Perez.
308
309         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
310         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
311         relaunching the server after every test failure, because other failures, even when not crashing the server,
312         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
313         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
314
315         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
316         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
317         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
318         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
319         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
320         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
321         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
322         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
323
324 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
325
326         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
327         https://bugs.webkit.org/show_bug.cgi?id=181204
328         <rdar://problem/36256274>
329
330         Reviewed by Ryosuke Niwa.
331
332         Implement 'testRunner.forceImmediateCompletion()' for WK1.
333
334         * DumpRenderTree/TestRunner.cpp:
335         (forceImmediateCompletionCallback):
336         (TestRunner::staticFunctions):
337
338 2018-01-29  Frederic Wang  <fwang@igalia.com>
339
340         Unreviewed, add myself to some watch lists.
341
342         * Scripts/webkitpy/common/config/watchlist:
343
344 2018-01-27  Dan Bernstein  <mitz@apple.com>
345
346         HaveInternalSDK includes should be "#include?"
347         https://bugs.webkit.org/show_bug.cgi?id=179670
348
349         * DumpRenderTree/mac/Configurations/Base.xcconfig:
350
351 2018-01-26  Chris Dumez  <cdumez@apple.com>
352
353         Make sure service worker code does not launch a StorageProcess unnecessarily
354         https://bugs.webkit.org/show_bug.cgi?id=182192
355         <rdar://problem/36927427>
356
357         Reviewed by Geoffrey Garen.
358
359         Add API test coverage.
360
361         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
362
363 2018-01-26  Chris Dumez  <cdumez@apple.com>
364
365         Offlined content does not work for apps on home screen
366         https://bugs.webkit.org/show_bug.cgi?id=182070
367         <rdar://problem/36843906>
368
369         Reviewed by Youenn Fablet.
370
371         Add API test coverage to make sure an already registered service worker is able to intercept
372         the very first load.
373
374         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
375         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
376
377 2018-01-26  Chris Nardi  <cnardi@chromium.org>
378
379         Addressing post-review comments after r226614
380         https://bugs.webkit.org/show_bug.cgi?id=182151
381
382         Reviewed by Myles C. Maxfield.
383
384         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
385         (TestWebKitAPI::TEST):
386
387 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
388
389         Unreviewed, rolling out r224920.
390
391         Some Win EWS bots are not coming back up after starting reboot.
392
393         * EWSTools/start-queue-win.sh:
394
395 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
396
397         WebDriver: simplify the tests json report
398         https://bugs.webkit.org/show_bug.cgi?id=182171
399
400         Reviewed by Carlos Alberto Lopez Perez.
401
402         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
403         form the subtest name. We should do the same for simplicity and compatibility with WPT.
404
405         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
406         (WebDriverTestRunner.dump_results_to_json_file):
407
408 2018-01-25  Alex Christensen  <achristensen@webkit.org>
409
410         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
411         https://bugs.webkit.org/show_bug.cgi?id=182152
412
413         Reviewed by Joseph Pecoraro.
414
415         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
416         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
417         (TEST):
418
419 2018-01-25  Youenn Fablet  <youenn@apple.com>
420
421         WebPluginInfoProvider should handle null host queries
422         https://bugs.webkit.org/show_bug.cgi?id=182112
423
424         Reviewed by Chris Dumez.
425
426         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
427         (TEST):
428
429 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
430
431         [webkitpy] Stop modifying path information only when running on Cygwin
432         https://bugs.webkit.org/show_bug.cgi?id=182136
433
434         On LayoutTestApacheHttpd, some path configuration is modified when platform
435         is Windows. This modification is only required for AppleWin running on Cygwin.
436         WinCairo uses native Windows environment, so the condition should be changed.
437
438         Reviewed by Per Arne Vollan.
439
440         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
441         (LayoutTestApacheHttpd.__init__):
442         (LayoutTestApacheHttpd._get_apache_config_file_path):
443
444 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
445
446         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
447         https://bugs.webkit.org/show_bug.cgi?id=182038
448         <rdar://problem/36812083>
449
450         Reviewed by Jer Noble.
451
452         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
453         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
454
455 2018-01-24  Daniel Bates  <dabates@apple.com>
456
457         webkit-patch upload emits irrelevant simulator warnings
458         https://bugs.webkit.org/show_bug.cgi?id=181702
459         <rdar://problem/36556359>
460
461         Reviewed by Aakash Jain.
462
463         Remove warning when a person explicitly passes --child-processes with a value greater than
464         the default number of simulator instances webkitpy would have used had --child-processes
465         been omitted. Moreover, the placement of the warning logic to support printing such a message
466         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
467
468         By default, webkitpy will parallelize running tests using the maximum number of simulator
469         instances that can be supported based on available system resources at the time run-webkit-tests
470         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
471         by specifying --child-processes knows what they are doing. The effects of picking a large
472         value be obvious, the system may become sluggish.
473
474         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
475         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
476
477         * Scripts/webkitpy/port/ios_simulator.py:
478         (IOSSimulatorPort.__init__):
479
480 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
481
482         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
483         https://bugs.webkit.org/show_bug.cgi?id=182102
484
485         Reviewed by Carlos Garcia Campos.
486
487         * MiniBrowser/gtk/main.c:
488         (main): Removed the call to set_enable_webvr().
489
490 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
491
492         WebDriver: add support for slow tests
493         https://bugs.webkit.org/show_bug.cgi?id=182095
494
495         Reviewed by Carlos Alberto Lopez Perez.
496
497         Add timeout mark to slow tests.
498
499         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
500         (TestExpectationsMarker.__init__): Save the timeout.
501         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
502         (run): Pass timeout to TestExpectationsMarker constructor.
503
504 2018-01-24  Alex Christensen  <achristensen@webkit.org>
505
506         Gracefully recover from NetworkProcess crashes in private browsing
507         https://bugs.webkit.org/show_bug.cgi?id=182073
508         <rdar://problem/36572023>
509
510         Reviewed by Geoff Garen.
511
512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
513         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
514         (-[CrashDelegate webView:didFinishNavigation:]):
515         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
516         (-[CrashDelegate webView:didFailNavigation:withError:]):
517         (TEST):
518
519 2018-01-24  Ali Juma  <ajuma@chromium.org>
520
521         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
522         https://bugs.webkit.org/show_bug.cgi?id=182052
523
524         Reviewed by Simon Fraser.
525
526         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
527         immediately.
528
529         Test: fast/visual-viewport/viewport-dimensions.html
530
531         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
532         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
533
534 2018-01-24  Alex Christensen  <achristensen@webkit.org>
535
536         Remove pre-Sierra-OS-specific code in Tools
537         https://bugs.webkit.org/show_bug.cgi?id=182034
538
539         Reviewed by Tim Horton.
540
541         * DumpRenderTree/mac/DumpRenderTree.mm:
542         (setDefaultsToConsistentValuesForTesting):
543         * MiniBrowser/mac/BrowserWindowController.m:
544         (-[BrowserWindowController windowDidLoad]):
545         (-[BrowserWindowController share:]):
546         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
547         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
548         (-[EventStreamPlayer playbackTimerFired:]):
549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
550         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
551         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
552         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
553         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
554         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
555         (WTR::InjectedBundle::platformInitialize):
556         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
557         (WTR::initializeWebViewConfiguration):
558
559 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
560
561         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
562         https://bugs.webkit.org/show_bug.cgi?id=181400
563         <rdar://problem/36358768>
564
565         Reviewed by Joseph Pecoraro.
566
567         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
568
569         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
570         Always disable poisoning when running with --leaks, as this should work locally,
571         not just on bots.
572
573 2018-01-24  Daniel Bates  <dabates@apple.com>
574
575         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
576         https://bugs.webkit.org/show_bug.cgi?id=181993
577         <rdar://problem/36421080>
578
579         Reviewed by David Hyatt.
580
581         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
582         as we no longer support this strategy.
583
584         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
585
586 2018-01-24  David Kilzer  <ddkilzer@apple.com>
587
588         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
589         <https://webkit.org/b/182015>
590         <rdar://problem/36449728>
591
592         Reviewed by Tim Horton.
593
594         * Scripts/webkitpy/style/checkers/cpp.py:
595         (regex_for_lambdas_and_blocks): Update regex to include
596         optional return type for block argument in Objective-C.
597         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
598         (WebKitStyleTest.test_braces): Add test.
599
600 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
601
602         WPE-focused test gardening.
603         https://bugs.webkit.org/show_bug.cgi?id=182051
604
605         Unreviewed test gardening.
606
607         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
608
609 2018-01-23  Mark Lam  <mark.lam@apple.com>
610
611         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
612         https://bugs.webkit.org/show_bug.cgi?id=182017
613         <rdar://problem/36795513>
614
615         Reviewed by Filip Pizlo and JF Bastien.
616
617         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
618         (TestWebKitAPI::TEST):
619         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
620         (TestWebKitAPI::TEST):
621         (TestWebKitAPI::passWithRef):
622         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
623         (TestWebKitAPI::TEST):
624         (TestWebKitAPI::f1):
625         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
626         (TestWebKitAPI::TEST):
627         (TestWebKitAPI::poisonedPtrFoo):
628         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
629         (TestWebKitAPI::TEST):
630         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
631         (TestWebKitAPI::TEST):
632
633 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
634
635         [WebVR] Add OpenVR to the tree and to the build
636         https://bugs.webkit.org/show_bug.cgi?id=177298
637
638         Reviewed by Žan Doberšek.
639
640         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
641         with reduced style checks.
642
643 2018-01-24  Chris Nardi  <cnardi@chromium.org>
644
645         Add Chris Nardi to contributors list
646         https://bugs.webkit.org/show_bug.cgi?id=182029
647
648         Reviewed by Antti Koivisto.
649
650         * Scripts/webkitpy/common/config/contributors.json:
651
652 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
653
654         Mac Sierra perf bots have been failing due to CG errors
655         https://bugs.webkit.org/show_bug.cgi?id=181955
656
657         Reviewed by Antti Koivisto.
658
659         Ignore the CoreGraphics error messages on macOS Sierra.
660
661         Also added tests for ignoring lines in stdout and stderr.
662
663         * Scripts/webkitpy/performance_tests/perftest.py:
664         (PerfTest.run_failed): Refactored for clarity.
665         (PerfTest):
666         (PerfTest.filter_ignored_lines): Added.
667         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
668         are now used to ignore lines in other kinds of tests than parser tests.
669         (PerfTest._errors_to_ignore_in_sierra): Added.
670         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
671         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
672         (test_parse_output_with_ignored_stdout): Added.
673         (test_parse_output_with_ignored_stderr): Added.
674         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
675
676 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
677
678         Resign NowPlaying status when no media element is eligible
679         https://bugs.webkit.org/show_bug.cgi?id=181914
680         <rdar://problem/35294116>
681
682         Reviewed by Jer Noble.
683
684         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
685         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
686         (TestWebKitAPI::TEST):
687         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
688
689 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
690
691         [WinCairo] Use 64-bit toolset
692         https://bugs.webkit.org/show_bug.cgi?id=181979
693
694         Reviewed by Alex Christensen.
695
696         Use 64-bit toolset for 64-bit build in order to improve build time. 
697
698         * Scripts/webkitdirs.pm:
699         (generateBuildSystemFromCMakeProject):
700
701 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
702
703         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
704         https://bugs.webkit.org/show_bug.cgi?id=181741
705         rdar://problem/36593581
706
707         Reviewed by Tim Horton.
708         
709         If zoomToScale:animated: is called with the current zoom level, call the callback
710         rather than doing nothing.
711
712         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
713         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
714
715 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
716
717         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
718         https://bugs.webkit.org/show_bug.cgi?id=180820
719
720         Reviewed by David Kilzer.
721
722         * Scripts/webkitpy/common/checkout/scm/git.py:
723         (Git.in_working_directory):
724         (Git.clone):
725         (Git.read_git_config):
726         (Git.apply_reverse_diff):
727         * Scripts/webkitpy/common/checkout/scm/scm.py:
728         (SCM.run):
729         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
730         * Scripts/webkitpy/common/checkout/scm/svn.py:
731         (SVNRepository.has_authorization_for_realm):
732         * Scripts/webkitpy/common/net/credentials_unittest.py:
733         * Scripts/webkitpy/common/system/abstractexecutive.py:
734         (AbstractExecutive.run_command):
735         * Scripts/webkitpy/common/system/executive.py:
736         (Executive.kill_process.is):
737         (Executive.running_pids):
738         (Executive.kill_all):
739         (Executive.run_command):
740         * Scripts/webkitpy/common/system/executive_mock.py:
741         (MockExecutive.run_command):
742         (MockExecutive2.run_command):
743         * Scripts/webkitpy/common/system/executive_unittest.py:
744         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
745         * Scripts/webkitpy/common/system/platforminfo.py:
746         (PlatformInfo.xcode_sdk_version):
747         * Scripts/webkitpy/layout_tests/servers/http_server.py:
748         (Lighttpd._check_and_kill):
749         * Scripts/webkitpy/port/base.py:
750         (Port._symbols_string):
751         * Scripts/webkitpy/port/gtk.py:
752         (GtkPort.setup_environ_for_server):
753         * Scripts/webkitpy/port/win.py:
754         (WinPort._runtime_feature_list):
755         (WinPort.read_registry_value):
756         * Scripts/webkitpy/port/win_unittest.py:
757         (WinPortTest.test_runtime_feature_list):
758         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
759         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
760
761 2018-01-23  Commit Queue  <commit-queue@webkit.org>
762
763         Unreviewed, rolling out r227279 and r227373.
764         https://bugs.webkit.org/show_bug.cgi?id=181988
765
766         The LayoutTest crash fix introduced an API test failure.
767         (Requested by ryanhaddad on #webkit).
768
769         Reverted changesets:
770
771         "Resign NowPlaying status when no media element is eligible"
772         https://bugs.webkit.org/show_bug.cgi?id=181914
773         https://trac.webkit.org/changeset/227279
774
775         "Resign NowPlaying status when no media element is eligible"
776         https://bugs.webkit.org/show_bug.cgi?id=181914
777         https://trac.webkit.org/changeset/227373
778
779 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
780
781         Unreviewed. Add test case for slow in test_expectations.py.
782
783         I forgot to also check slow tests in test_expectations.py unit tests.
784
785         * Scripts/webkitpy/common/test_expectations_unittest.py:
786         (assert_slow):
787         (test_build_type):
788         (test_slow):
789
790 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
791
792         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
793
794         * TestWebKitAPI/glib/TestExpectations.json:
795
796 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
797
798         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
799         https://bugs.webkit.org/show_bug.cgi?id=181616
800         <rdar://problem/36484908>
801
802         Reviewed by Wenson Hsieh.
803
804         Added tests to make sure we sanitize plain HTML, not just web archives,
805         when and only when custom pasteboard data is enabled.
806
807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
808         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
809         (writeHTMLToPasteboard): Added.
810         (createWebViewWithCustomPasteboardDataSetting): Added.
811
812 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
813
814         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
815         https://bugs.webkit.org/show_bug.cgi?id=181400
816         rdar://problem/36358768
817
818         Reviewed by JF Bastien.
819
820         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
821
822 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
823
824         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
825         https://bugs.webkit.org/show_bug.cgi?id=181929
826
827         Reviewed by Michael Catanzaro.
828
829         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
830         the website data completion callback is not called immediately, and a new file is created when the operation
831         finishes. We need to check that the file was removing after calling clear.
832
833         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
834         (fileChangedCallback):
835         (testWebsiteDataResourceLoadStatistics):
836
837 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
838
839         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
840
841         * TestWebKitAPI/glib/TestExpectations.json:
842
843 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
844
845         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
846
847         Partially revert r226782, the fix was wrong for the GLib version we currently use.
848
849         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
850         (testWebKitConsoleMessageNetworkError):
851
852 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
853
854         Unreviewed. Remove unused verbose mode from GLib API tests runner.
855
856         * glib/api_test_runner.py:
857         (add_options):
858
859 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
860
861         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
862         https://bugs.webkit.org/show_bug.cgi?id=181918
863
864         Reviewed by Tim Horton.
865
866         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
867
868         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
869
870 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
871
872         Resign NowPlaying status when no media element is eligible
873         https://bugs.webkit.org/show_bug.cgi?id=181914
874         <rdar://problem/35294116>
875
876         Reviewed by Jer Noble.
877
878         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
879         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
880         (TestWebKitAPI::TEST):
881         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
882
883 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
884
885         Fix broken unit-tests after r227192
886         https://bugs.webkit.org/show_bug.cgi?id=181909
887
888         Reviewed by Carlos Garcia Campos.
889
890         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
891
892 2018-01-20  Chris Dumez  <cdumez@apple.com>
893
894         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
895         https://bugs.webkit.org/show_bug.cgi?id=174984
896         <rdar://problem/33665676>
897
898         Reviewed by Alexey Proskuryakov.
899
900         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
901
902         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
903         (TEST):
904
905 2018-01-20  Brian Burg  <bburg@apple.com>
906
907         WebDriver: fix some nits that prevent running W3C tests on Mac
908         https://bugs.webkit.org/show_bug.cgi?id=181864
909
910         Reviewed by Carlos Garcia Campos.
911
912         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
913         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
914         as we assume that the property exists later.
915
916         (WebDriverW3CWebServer.stop): If the temporary file doesn't
917         exist for some reason, the remove call will raise and exception.
918         Gracefully handle the case where the file isn't created due to
919         a problem/exception that happened elsewhere.
920
921 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
922
923         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
924         https://bugs.webkit.org/show_bug.cgi?id=181881
925
926         Reviewed by Alexey Proskuryakov.
927
928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
929         (BubbleQueueServer):
930         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
932         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
933
934 2018-01-19  Youenn Fablet  <youenn@apple.com>
935
936         Do not go to the storage process when registering a service worker client if there is no service worker registered
937         https://bugs.webkit.org/show_bug.cgi?id=181740
938         <rdar://problem/36650400>
939
940         Reviewed by Chris Dumez.
941
942         Add support for internals inside API tests.
943
944         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
945         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
946         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
947         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
948         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
949         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
950         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
951         (setConfigurationInjectedBundlePath):
952         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
953
954 2018-01-19  John Wilander  <wilander@apple.com>
955
956         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
957         https://bugs.webkit.org/show_bug.cgi?id=181822
958         https://bugs.webkit.org/show_bug.cgi?id=175263
959         https://bugs.webkit.org/show_bug.cgi?id=178536
960         https://bugs.webkit.org/show_bug.cgi?id=181223
961         https://bugs.webkit.org/show_bug.cgi?id=181482
962         <rdar://problem/33491222>
963         <rdar://problem/33805293>
964         <rdar://problem/36332683>
965         <rdar://problem/36549026>
966
967         Reviewed by Alex Christensen.
968
969         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
971         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
972         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
973         * WebKitTestRunner/InjectedBundle/TestRunner.h:
974         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
975         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
976         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
977
978 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
979
980         run-webkit-tests fails when there is a curly brace in Xcode build output
981         https://bugs.webkit.org/show_bug.cgi?id=181254
982         <rdar://problem/36453374>
983
984         Reviewed by Daniel Bates.
985
986         * Scripts/webkitpy/port/base.py:
987         (Port._run_script): Encode script output before logging it.
988
989 2018-01-19  Chris Dumez  <cdumez@apple.com>
990
991         Service worker registrations restored from disk may not be reused when the JS calls register() again
992         https://bugs.webkit.org/show_bug.cgi?id=181810
993         <rdar://problem/36591711>
994
995         Reviewed by Youenn Fablet.
996
997         Add API test coverage.
998
999         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1000         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
1001         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
1002
1003 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
1004
1005         Remove El Capitan queues from flakiness dashboard
1006         https://bugs.webkit.org/show_bug.cgi?id=181860
1007
1008         Reviewed by Aakash Jain.
1009
1010         * TestResultServer/static-dashboards/builders.jsonp:
1011
1012 2018-01-19  Keith Miller  <keith_miller@apple.com>
1013
1014         HaveInternalSDK includes should be "#include?"
1015         https://bugs.webkit.org/show_bug.cgi?id=179670
1016
1017         Reviewed by Dan Bernstein.
1018
1019         * MiniBrowser/Configurations/Base.xcconfig:
1020         * MobileMiniBrowser/Configurations/Base.xcconfig:
1021         * TestWebKitAPI/Configurations/Base.xcconfig:
1022         * WebKitTestRunner/Configurations/Base.xcconfig:
1023
1024 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1025
1026         WebDriver: driver environment not passed to pytest when running w3c tests
1027         https://bugs.webkit.org/show_bug.cgi?id=181852
1028
1029         Reviewed by Carlos Alberto Lopez Perez.
1030
1031         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
1032
1033         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1034         (WebDriverW3CExecutor.run):
1035
1036 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1037
1038         [GTK] WebDriver: wayland display no used in wayland bot
1039         https://bugs.webkit.org/show_bug.cgi?id=181851
1040
1041         Reviewed by Carlos Alberto Lopez Perez.
1042
1043         We need to handle the additionalArguments property in the WebDriverTests step.
1044
1045         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1046         (RunWebDriverTests.start):
1047
1048 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1049
1050         [GTK] TERM environment variable is not passed to the test driver.
1051         https://bugs.webkit.org/show_bug.cgi?id=181847
1052
1053         Rubber-stamped by by Carlos Garcia Campos.
1054
1055         * Scripts/webkitpy/port/base.py:
1056         (Port.to.setup_environ_for_server):
1057
1058 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1059
1060         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
1061         https://bugs.webkit.org/show_bug.cgi?id=181844
1062
1063         Reviewed by Carlos Alberto Lopez Perez.
1064
1065         We always try to create the directory where to store the json file, but when the filename is given directly,
1066         like in the bots, the current dir is used.
1067
1068         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1069         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
1070         empty string.
1071
1072 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1073
1074         [GTK] WebDriver tests are running outside the jhbuild env
1075         https://bugs.webkit.org/show_bug.cgi?id=181842
1076
1077         Reviewed by Žan Doberšek.
1078
1079         We need to enter jhbuild env in run-webdriver-tests.
1080
1081         * Scripts/run-webdriver-tests:
1082
1083 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1084
1085         [GTK] Run WebDriver tests in the bots
1086         https://bugs.webkit.org/show_bug.cgi?id=181787
1087
1088         Reviewed by Michael Catanzaro.
1089
1090         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
1091         factory for the GTK port for now.
1092
1093         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1094         (TestFactory.__init__):
1095         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1096         (RunWebDriverTests):
1097         (RunWebDriverTests.start):
1098         (RunWebDriverTests.commandComplete):
1099         (RunWebDriverTests.evaluateCommand):
1100         (RunWebDriverTests.getText):
1101         (RunWebDriverTests.getText2):
1102
1103 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1104
1105         [WinCairo] Pass correct url for http test to test driver.
1106         https://bugs.webkit.org/show_bug.cgi?id=181814
1107
1108         Reviewed by Alex Christensen.
1109
1110         * Scripts/webkitpy/port/driver.py:
1111         (Driver):
1112         (Driver.http_test_path_to_uri):
1113         (Driver.is_secure_path):
1114         (Driver.http_base_url):
1115         (Driver.uri_to_test):
1116
1117 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1118
1119         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
1120
1121         * BuildSlaveSupport/build.webkit.org-config/config.json:
1122
1123 2018-01-18  Dan Bernstein  <mitz@apple.com>
1124
1125         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1126         https://bugs.webkit.org/show_bug.cgi?id=181803
1127
1128         Reviewed by Tim Horton.
1129
1130         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
1131         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
1132         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
1133         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
1134         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
1135         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1136         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1137         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
1138         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
1139           helpers.
1140         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
1141           settings useful for defining settings that depend on the target macOS version.
1142         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
1143         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
1144
1145 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
1146
1147         Remove Opensource El Capitan queues from buildbot
1148         https://bugs.webkit.org/show_bug.cgi?id=181712
1149
1150         Reviewed by Aakash Jain.
1151
1152         * BuildSlaveSupport/build.webkit.org-config/config.json:
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1154         (WebKitBuildbot):
1155         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1156
1157 2018-01-18  Chris Dumez  <cdumez@apple.com>
1158
1159         Service Workers restored from persistent storage have 'redundant' state
1160         https://bugs.webkit.org/show_bug.cgi?id=181749
1161         <rdar://problem/36556486>
1162
1163         Reviewed by Youenn Fablet.
1164
1165         Add API test coverage.
1166
1167         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1168         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
1169
1170 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1171
1172         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
1173         https://bugs.webkit.org/show_bug.cgi?id=176796
1174
1175         Reviewed by Chris Fleizach.
1176
1177         Add sanity check that we have a URL before calling g_strstr_len().
1178
1179         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1180         (WTR::AccessibilityUIElement::url):
1181
1182 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1183
1184         Add triggers for Sierra test262 and perf queues
1185         https://bugs.webkit.org/show_bug.cgi?id=181799
1186
1187         Reviewed by Aakash Jain.
1188
1189         * BuildSlaveSupport/build.webkit.org-config/config.json:
1190
1191 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1192
1193         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
1194         https://bugs.webkit.org/show_bug.cgi?id=181783
1195         <rdar://problem/35785445>
1196
1197         Reviewed by Ryosuke Niwa.
1198
1199         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
1200         copying an image contains a relevant title.
1201
1202         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1203         (TestWebKitAPI::TEST):
1204         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1205         * TestWebKitAPI/ios/UIKitSPI.h:
1206
1207 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1208
1209         WebDriver: ignore the driver in selenium test names when getting expectations
1210         https://bugs.webkit.org/show_bug.cgi?id=181738
1211
1212         Reviewed by Carlos Alberto Lopez Perez.
1213
1214         In selenium tests, the driver is added as a parameter to every test which results in tests names like
1215         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
1216         driver name in the test expectations file, so we need to remove it when querying the expectations.
1217
1218         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1219         (TestExpectationsMarker.__init__): Save the param to ignore.
1220         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
1221         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
1222         (run): Pass param to ignore to TestExpectationsMarker().
1223         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1224         (WebDriverSeleniumExecutor.__init__): Save the driver name.
1225         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
1226
1227 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1228
1229         [GTK][WPE] Show unit tests unexpectedly passing in the bots
1230         https://bugs.webkit.org/show_bug.cgi?id=181726
1231
1232         Reviewed by Michael Catanzaro.
1233
1234         Now that we have the info, let's show it also in the bots.
1235
1236         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1237         (RunGLibAPITests.commandComplete):
1238
1239 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
1240
1241         Fix broken unittest after r227048
1242         https://bugs.webkit.org/show_bug.cgi?id=181760
1243
1244         Reviewed by Aakash Jain.
1245
1246
1247 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1248
1249         WEBKIT_FRAMEWORK should not modify file-global include directories
1250         https://bugs.webkit.org/show_bug.cgi?id=181656
1251
1252         Reviewed by Konstantin Tokarev.
1253
1254         * TestWebKitAPI/PlatformWPE.cmake:
1255         * TestWebKitAPI/glib/CMakeLists.txt:
1256
1257 2018-01-17  Alicia Boya García  <aboya@igalia.com>
1258
1259         Unreviewed, mark Alicia as committer in contributors.json
1260
1261         * Scripts/webkitpy/common/config/contributors.json:
1262
1263 2018-01-17  Youenn Fablet  <youenn@apple.com>
1264
1265         Put fetch Request.keepalive behind a runtime flag
1266         https://bugs.webkit.org/show_bug.cgi?id=181592
1267
1268         Reviewed by Chris Dumez.
1269
1270         * DumpRenderTree/mac/DumpRenderTree.mm:
1271         (enableExperimentalFeatures):
1272         * DumpRenderTree/win/DumpRenderTree.cpp:
1273         (enableExperimentalFeatures):
1274         * WebKitTestRunner/TestController.cpp:
1275         (WTR::TestController::resetPreferencesToConsistentValues):
1276
1277 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1278
1279         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1280         https://bugs.webkit.org/show_bug.cgi?id=181637
1281         <rdar://problem/36508471>
1282
1283         Reviewed by Tim Horton.
1284
1285         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
1286         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
1287
1288         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1289         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1290         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
1291
1292         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
1293         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
1294
1295         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1296         (webViewForTestingAttachments):
1297         (-[TestWKWebView tagsInBody]):
1298         (-[TestWKWebView expectElementTagsInOrder:]):
1299         (-[TestWKWebView expectElementTag:toComeBefore:]):
1300
1301         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
1302         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
1303
1304         (TestWebKitAPI::TEST):
1305         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1306         (WTR::InjectedBundlePage::InjectedBundlePage):
1307
1308 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1309
1310         WebDriver: add support for test expectations
1311         https://bugs.webkit.org/show_bug.cgi?id=180420
1312
1313         Reviewed by Carlos Alberto Lopez Perez.
1314
1315         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
1316
1317         * Scripts/run-webdriver-tests: Get the retval from process_results().
1318         * Scripts/webkitpy/thirdparty/__init__.py:
1319         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
1320         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1321         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
1322         (TestExpectationsMarker.__init__): Initialize expectations.
1323         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
1324         (run): Create and use TestExpectationsMarker plugin.
1325         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1326         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
1327         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1328         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
1329         (WebDriverTestRunner.run): Do not count results here.
1330         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
1331         amount of failures. Printing the test summary while processing results will be made optional in a follow up
1332         patch.
1333         (WebDriverTestRunner.process_results.report): Return the amount of failures.
1334         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1335         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
1336         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
1337         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
1338         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1339         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
1340         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
1341         (WebDriverTestRunnerW3C._scan_directory): Ditto.
1342         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
1343         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1344         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
1345
1346 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1347
1348         Unreviewed WPE gardening. Mark some known unit test failures.
1349
1350         * TestWebKitAPI/glib/TestExpectations.json:
1351
1352 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1353
1354         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
1355         https://bugs.webkit.org/show_bug.cgi?id=181724
1356
1357         Reviewed by Philippe Normand.
1358
1359         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
1360         reason to use different names. This way we can refer to the same test names for both and we can share the
1361         expectations in the TestExpectations.json file.
1362
1363         * TestWebKitAPI/glib/TestExpectations.json:
1364         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
1365
1366 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1367
1368         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
1369
1370         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
1371         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
1372
1373         * glib/api_test_runner.py:
1374         (TestRunner._run_test_glib):
1375         (TestRunner._run_google_test):
1376
1377 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1378
1379         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
1380         https://bugs.webkit.org/show_bug.cgi?id=179914
1381
1382         Reviewed by Žan Doberšek.
1383
1384         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
1385         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
1386         all symbols listed in the script are present in the library.
1387
1388         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
1389         (bss_symbols):
1390         * Scripts/check-for-invalid-symbols-in-version-script: Added.
1391         (script_symbols):
1392         * Scripts/make-dist:
1393         (Distcheck.build):
1394         (Distcheck):
1395         (Distcheck.check_symbols):
1396         (Distcheck.check):
1397
1398 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1399
1400         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
1401         https://bugs.webkit.org/show_bug.cgi?id=181722
1402
1403         Reviewed by Žan Doberšek.
1404
1405         I forgot to pass the parameters to run() when restarting.
1406
1407         * glib/glib_test_runner.py:
1408         (GLibTestRunner.run):
1409
1410 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1411
1412         [CMake] Remove WebCoreDerivedSources library target
1413         https://bugs.webkit.org/show_bug.cgi?id=181664
1414
1415         Reviewed by Carlos Garcia Campos.
1416
1417         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
1418         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1419
1420 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
1421
1422         Move Debug Test262, Release Test262 and Performance queues to Sierra
1423         https://bugs.webkit.org/show_bug.cgi?id=181692
1424
1425         Unreviewed
1426
1427 2018-01-16  Zach Li  <zachli@apple.com>
1428
1429         Add pop-up policy support in website policies.
1430         https://bugs.webkit.org/show_bug.cgi?id=181544.
1431         rdar://problem/30521400.
1432
1433         Reviewed by Alex Christensen.
1434
1435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1436         Added pop-up-check.html.
1437
1438         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
1439
1440         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1441         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1442         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1443         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1444         (TEST):
1445
1446 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1447
1448         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
1449         https://bugs.webkit.org/show_bug.cgi?id=181638
1450         <rdar://problem/36508702>
1451
1452         Reviewed by Dan Bernstein.
1453
1454         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
1455         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
1456
1457         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1458         (-[AttachmentUpdateObserver init]):
1459         (-[AttachmentUpdateObserver sourceForIdentifier:]):
1460         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
1461         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
1462         (TestWebKitAPI::TEST):
1463         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
1464
1465 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1466
1467         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
1468
1469         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
1470
1471         * glib/api_test_runner.py:
1472         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
1473         * glib/glib_test_runner.py:
1474         (GLibTestRunner.run): Use given env.
1475
1476 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1477
1478         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
1479         https://bugs.webkit.org/show_bug.cgi?id=181676
1480
1481         Reviewed by Carlos Alberto Lopez Perez.
1482
1483         The option was removed in r226967.
1484
1485         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1486         (RunGtkAPITests):
1487         (RunWPEAPITests):
1488
1489 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1490
1491         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
1492
1493         The bots are still passing that option and the step is failing because it was removed in r226967.
1494
1495         * glib/api_test_runner.py:
1496         (add_options):
1497
1498 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1499
1500         [GTK][WPE] Improve the way glib tests are run
1501         https://bugs.webkit.org/show_bug.cgi?id=181674
1502
1503         Reviewed by Žan Doberšek.
1504
1505         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
1506         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
1507         tests failing due to an expected assert in the test and unexpected crashes.
1508         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
1509         not showing the subtest name in stdout in case of timeouts.
1510         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
1511         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
1512         of every test case.
1513
1514         * glib/api_test_runner.py:
1515         (TestRunner._run_test_glib): Use GLibTestRunner.
1516         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
1517         (add_options):
1518         * glib/glib_test_runner.py: Added.
1519         (TestTimeout):
1520         (Message):
1521         (Message.__init__):
1522         (Message.create):
1523         (Message.create.read_unsigned):
1524         (Message.create.read_double):
1525         (Message.create.read_string):
1526         (GLibTestRunner):
1527         (GLibTestRunner.__init__):
1528         (GLibTestRunner._process_data):
1529         (GLibTestRunner._process_message):
1530         (GLibTestRunner._read_from_pipe):
1531         (GLibTestRunner._read_from_stderr):
1532         (GLibTestRunner._start_timeout):
1533         (GLibTestRunner._start_timeout._alarm_handler):
1534         (GLibTestRunner._stop_timeout):
1535         (GLibTestRunner._subtest_start):
1536         (GLibTestRunner._subtest_message):
1537         (GLibTestRunner._subtest_stderr):
1538         (GLibTestRunner._subtest_end):
1539         (GLibTestRunner.run):
1540
1541 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1542
1543         Unreviewed, add Thibault to contributors.json
1544
1545         It's a bit weird to add someone here before their first contribution, but this affects
1546         Bugzilla autocomplete, and that is serious business.
1547
1548         * Scripts/webkitpy/common/config/contributors.json:
1549
1550 2018-01-15  JF Bastien  <jfbastien@apple.com>
1551
1552         Remove makePoisonedUnique
1553         https://bugs.webkit.org/show_bug.cgi?id=181630
1554         <rdar://problem/36498623>
1555
1556         Reviewed by Mark Lam.
1557
1558         Update tests.
1559
1560         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1561         (TestWebKitAPI::TEST):
1562         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1563         (TestWebKitAPI::TEST):
1564
1565 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
1566
1567         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
1568         https://bugs.webkit.org/show_bug.cgi?id=181476
1569
1570         Reviewed by Michael Catanzaro.
1571
1572         Update to xorg-server 1.19.6 which depends on libxfont2, and change
1573         the lists of packages to install libxfont2-devel (or equivalent).
1574
1575         * gtk/install-dependencies:
1576         * gtk/jhbuild.modules:
1577
1578 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1579
1580         [GTK][WPE] Add support for unit test expectations
1581         https://bugs.webkit.org/show_bug.cgi?id=181589
1582
1583         Reviewed by Michael Catanzaro.
1584
1585         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
1586         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
1587         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
1588         script itself is not a good idea either.
1589
1590         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
1591         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
1592         convenient methods to query them.
1593
1594         * Scripts/run-gtk-tests:
1595         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
1596         * Scripts/run-wpe-tests:
1597         (WPETestRunner): Ditto.
1598         * Scripts/webkitpy/common/test_expectations.py: Added.
1599         (TestExpectations):
1600         (TestExpectations.__init__):
1601         (TestExpectations._port_name_for_expected):
1602         (TestExpectations._expected_value):
1603         (TestExpectations.skipped_tests):
1604         (TestExpectations.skipped_subtests):
1605         (TestExpectations._expectation_value):
1606         (TestExpectations.is_slow):
1607         (TestExpectations.get_expectation):
1608         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
1609         (MockTestExpectations):
1610         (MockTestExpectations.__init__):
1611         (MockTestExpectations.is_skip):
1612         (ExpectationsTest):
1613         (assert_exp):
1614         (assert_not_exp):
1615         (assert_bad_exp):
1616         (assert_skip):
1617         (test_basic):
1618         (test_skip):
1619         (test_flaky):
1620         (test_build_type):
1621         * TestWebKitAPI/glib/TestExpectations.json: Added.
1622         * glib/api_test_runner.py:
1623         (TestRunner): Remove SkippedTest implementation.
1624         (TestRunner.__init__): Create a TestExpectations.
1625         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
1626         (TestRunner._should_run_test_program): Ditto.
1627         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
1628         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
1629         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
1630         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
1631         (TestRunner.run_tests.report): Helper to write report to stdout.
1632
1633 2018-01-13  Mark Lam  <mark.lam@apple.com>
1634
1635         Replace all use of ConstExprPoisoned with Poisoned.
1636         https://bugs.webkit.org/show_bug.cgi?id=181542
1637         <rdar://problem/36442138>
1638
1639         Reviewed by JF Bastien.
1640
1641         1. Converted tests to using new uintptr_t& poison type.
1642         2. Added tests for Poisoned comparison operators.
1643
1644         * TestWebKitAPI/CMakeLists.txt:
1645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1646         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
1647         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1648         (TestWebKitAPI::TEST):
1649         (TestWebKitAPI::initializeTestPoison): Deleted.
1650         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1651         (TestWebKitAPI::TEST):
1652         (TestWebKitAPI::passWithRef):
1653         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1654         (TestWebKitAPI::TEST):
1655         (TestWebKitAPI::f1):
1656         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1657         (TestWebKitAPI::TEST):
1658         (TestWebKitAPI::poisonedPtrFoo):
1659         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1660         (TestWebKitAPI::TEST):
1661         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1662         (TestWebKitAPI::TEST):
1663
1664 2018-01-13  David Kilzer  <ddkilzer@apple.com>
1665
1666         check-webkit-style: false positive for [whitespace/braces] with os_log format string
1667         <https://webkit.org/b/181606>
1668
1669         Reviewed by Darin Adler.
1670
1671         * Scripts/webkitpy/style/checkers/cpp.py:
1672         (check_spacing): Modify regular expression to ignore
1673         os_log format strings like '%{public}'.
1674         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1675         (CppStyleTest.test_spacing_before_braces): Add os_log
1676         format string test.
1677
1678 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1679
1680         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
1681         https://bugs.webkit.org/show_bug.cgi?id=181626
1682
1683         Reviewed by Joseph Pecoraro.
1684
1685         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
1686         Additionally, write a new API test covering the change in r226915.
1687
1688         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1689         (webViewForTestingAttachments):
1690         (TestWebKitAPI::TEST):
1691
1692 2018-01-12  Alex Christensen  <achristensen@webkit.org>
1693
1694         History state should be updated during client redirects with asynchronous policy decisions
1695         https://bugs.webkit.org/show_bug.cgi?id=181358
1696         <rdar://problem/35547689>
1697
1698         Reviewed by Andy Estes.
1699
1700         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
1701         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
1702         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1703         (TEST):
1704
1705 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
1706
1707         webkitpy: Refactor simulator code (Part 4)
1708         https://bugs.webkit.org/show_bug.cgi?id=180555
1709         <rdar://problem/36131381>
1710
1711         Reviewed by Aakash Jain.
1712
1713         Move new_simulated_device.py to simulated_device.py.
1714
1715         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
1716         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
1717         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
1718         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
1719         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
1720
1721 2018-01-12  Alex Christensen  <achristensen@webkit.org>
1722
1723         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
1724         https://bugs.webkit.org/show_bug.cgi?id=181595
1725
1726         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
1727         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
1728         I change the < and > to $ to make this test pass and continue to test what it used to.
1729
1730         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
1731         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1732         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1733
1734 2018-01-11  Keith Miller  <keith_miller@apple.com>
1735
1736         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1737         https://bugs.webkit.org/show_bug.cgi?id=181573
1738
1739         Reviewed by Simon Fraser.
1740
1741         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1742
1743 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
1744
1745         [WebAuthN] Import a CBOR coder from Chromium
1746         https://bugs.webkit.org/show_bug.cgi?id=181522
1747         <rdar://problem/36055729>
1748
1749         Reviewed by Brent Fulgham.
1750
1751         This patch also imports all unit tests into our API tests to ensure all
1752         workarounds and modification against the original codebase doesn't change
1753         any original functionalities.
1754
1755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1756         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
1757         (TestWebKitAPI::TEST):
1758         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
1759         (TestWebKitAPI::TEST):
1760         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
1761         (TestWebKitAPI::eq):
1762         Workarounds applied.
1763         (TestWebKitAPI::TEST):
1764
1765 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1766
1767         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
1768         https://bugs.webkit.org/show_bug.cgi?id=181538
1769         <rdar://problem/36440580>
1770
1771         Reviewed by Aakash Jain.
1772
1773         When disambiguating a device type, it is possible that the provided device type is sufficiently
1774         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
1775         will result in a failure to disambiguate the type.
1776
1777         * Scripts/webkitpy/xcode/new_simulated_device.py:
1778         (SimulatedDeviceManager._disambiguate_device_type):
1779
1780 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
1781
1782         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
1783         https://bugs.webkit.org/show_bug.cgi?id=181136
1784         <rdar://problem/36116604>
1785
1786         Reviewed by Chris Dumez.
1787
1788         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
1789         browsing sessions.
1790
1791         * Scripts/run-gtk-tests:
1792         (GtkTestRunner): Unskip test now that it passes.
1793         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1794         (TEST): Add new WebsiteDataStoreEphemeral test.
1795
1796 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1797
1798         Unreviewed, rolling out r226816.
1799
1800         This change broke LayoutTests on the bots.
1801
1802         Reverted changeset:
1803
1804         "run-webkit-tests fails when there is a curly brace in Xcode
1805         build output"
1806         https://bugs.webkit.org/show_bug.cgi?id=181254
1807         https://trac.webkit.org/changeset/226816
1808
1809 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1810
1811         webkitpy: Fix flakey webserver tests
1812         https://bugs.webkit.org/show_bug.cgi?id=181555
1813         <rdar://problem/36448273>
1814
1815         Reviewed by Aakash Jain.
1816
1817         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1818         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
1819         determine if a specific server is running.
1820
1821 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1822
1823         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
1824         https://bugs.webkit.org/show_bug.cgi?id=181561
1825         <rdar://problem/36452652>
1826
1827         Reviewed by Aakash Jain.
1828
1829         BeautifulSoup.find may return None, this case should be gracefully handled.
1830
1831         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1832         (BugzillaQueries._parse_result_count):
1833         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
1834
1835 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
1836
1837         run-webkit-tests fails when there is a curly brace in Xcode build output
1838         https://bugs.webkit.org/show_bug.cgi?id=181254
1839
1840         Reviewed by Daniel Bates.
1841
1842         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1843         (MeteredStream.write):
1844
1845 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1846
1847         webkitpy: Reimplement simulator code (Part 3)
1848         https://bugs.webkit.org/show_bug.cgi?id=180555
1849         <rdar://problem/36131381>
1850
1851         Reviewed by Aakash Jain.
1852
1853         Remove old simulator code.
1854
1855         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
1856         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
1857         * Scripts/webkitpy/xcode/simulator.py: Removed.
1858         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
1859
1860 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1861
1862         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
1863         https://bugs.webkit.org/show_bug.cgi?id=181337
1864         <rdar://problem/36324813>
1865
1866         Reviewed by Tim Horton.
1867
1868         Add 3 new API tests for attachment element dragging.
1869
1870         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1871         (-[TestWKWebView expectElementTag:toComeBefore:]):
1872         (-[NSItemProvider expectType:withData:]):
1873         (TestWebKitAPI::TEST):
1874
1875 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
1876
1877         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
1878         https://bugs.webkit.org/show_bug.cgi?id=179621
1879         <rdar://problem/35589585>
1880
1881         Unreviewed infrastructure fix.
1882
1883         * Scripts/webkitpy/port/mac.py:
1884         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
1885         list if we are the VERSION_MAX, which usually corresponds with future.
1886
1887 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
1888
1889         CodeBlocks should be in IsoSubspaces
1890         https://bugs.webkit.org/show_bug.cgi?id=180884
1891
1892         Reviewed by Saam Barati.
1893         
1894         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
1895         shouldn't take a long time due to benchmarks we don't optimize for.
1896         
1897         * Scripts/run-jsc-benchmarks:
1898
1899 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
1900
1901         Test gardening for GTK.
1902         https://bugs.webkit.org/show_bug.cgi?id=181477
1903
1904         Unreviewed test gardening.
1905
1906         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
1907         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
1908
1909 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1910
1911         Add the new JSCOnly bot to the scheduler.
1912         https://bugs.webkit.org/show_bug.cgi?id=181487
1913
1914         Unreviewed follow-up patch after r226729
1915
1916         On r226729 I missed to add the new JSCOnly bot the default scheduler.
1917         This is needed to make the bot automatically pick each commit for testing.
1918
1919         * BuildSlaveSupport/build.webkit.org-config/config.json:
1920
1921 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1922
1923         [Attachment Support] Support dragging attachment elements out as files on iOS
1924         https://bugs.webkit.org/show_bug.cgi?id=181199
1925         <rdar://problem/36299316>
1926
1927         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
1928
1929         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
1930         attachment API tests.
1931
1932         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1933         (-[NSItemProvider expectType:withData:]):
1934         (TestWebKitAPI::TEST):
1935
1936         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
1937         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
1938         -expectType:withData: helper to inspect the item providers created from the drag source.
1939
1940         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1941         (TestWebKitAPI::TEST):
1942         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1943         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1944         (-[MockDragSession localContext]):
1945         (-[MockDragSession setLocalContext:]):
1946         (-[DataInteractionSimulator _resetSimulatedState]):
1947         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
1948         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1949         (-[DataInteractionSimulator _advanceProgress]):
1950         (-[DataInteractionSimulator endDataTransfer]):
1951
1952         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
1953         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
1954         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
1955         MockDragSession to hold on to a localContext.
1956
1957 2018-01-11  Ali Juma  <ajuma@chromium.org>
1958
1959         Unreviewed. Add Ali Juma as contributor
1960
1961         * Scripts/webkitpy/common/config/contributors.json:
1962
1963 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1964
1965         Unreviewed. Update Selenium WebDriver imported tests.
1966
1967         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
1968         environment variables.
1969
1970         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1971         (collect): Reorder the arguments to make pytest happy.
1972         (run): Ditto.
1973         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1974         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
1975
1976 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
1977
1978         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
1979         https://bugs.webkit.org/show_bug.cgi?id=181492
1980         <rdar://problem/36359679>
1981
1982         Reviewed by Alexey Proskuryakov. 
1983
1984 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
1985
1986         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
1987         https://bugs.webkit.org/show_bug.cgi?id=181475
1988
1989         Reviewed by Michael Catanzaro.
1990
1991         * gtk/install-dependencies: Update package list for Arch Linux, extend
1992         message shown at end of installation with additional tips.
1993
1994 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1995
1996         REGRESSION(r222507): Composition highlight doesn't render when using IME
1997         https://bugs.webkit.org/show_bug.cgi?id=181485
1998         <rdar://problem/35896516>
1999
2000         Reviewed by Ryosuke Niwa.
2001
2002         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
2003         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
2004         allow rendering composition backgrounds (see InlineTextBox::paint).
2005
2006         * DumpRenderTree/ios/TextInputControllerIOS.m:
2007         (+[TextInputController isSelectorExcludedFromWebScript:]):
2008         (+[TextInputController webScriptNameForSelector:]):
2009         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2010         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2011         * DumpRenderTree/mac/TextInputControllerMac.m:
2012         (+[TextInputController isSelectorExcludedFromWebScript:]):
2013         (+[TextInputController webScriptNameForSelector:]):
2014         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2015         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2016         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2017         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2018         (WTR::TextInputController::setMarkedText):
2019         * WebKitTestRunner/InjectedBundle/TextInputController.h:
2020
2021 2018-01-10  JF Bastien  <jfbastien@apple.com>
2022
2023         Poison small JSObject derivatives which only contain pointers
2024         https://bugs.webkit.org/show_bug.cgi?id=181483
2025         <rdar://problem/36407127>
2026
2027         Reviewed by Mark Lam.
2028
2029         Test the new move-assign and move-copy from unique_ptr, as well as
2030         nullptr_t ctors.
2031
2032         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2033         (TestWebKitAPI::TEST):
2034         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2035         (TestWebKitAPI::TEST):
2036         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2037         (TestWebKitAPI::TEST):
2038
2039 2018-01-10  Chris Dumez  <cdumez@apple.com>
2040
2041         Multiple http/wpt/beacon/contentextensions/ test are flaky.
2042         https://bugs.webkit.org/show_bug.cgi?id=179256
2043         <rdar://problem/35401978>
2044
2045         Reviewed by Alex Christensen.
2046
2047         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
2048         instance gets its own folder to avoid conflicts and flakiness.
2049
2050         * WebKitTestRunner/mac/TestControllerMac.mm:
2051         (WTR::TestController::platformConfigureViewForTest):
2052
2053 2018-01-10  Tim Horton  <timothy_horton@apple.com>
2054
2055         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
2056         https://bugs.webkit.org/show_bug.cgi?id=181269
2057         <rdar://problem/35110344>
2058
2059         Reviewed by Simon Fraser.
2060
2061         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2062         (WTR::UIScriptController::beginBackSwipe):
2063         (WTR::UIScriptController::completeBackSwipe):
2064         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2065         (WTR::UIScriptController::beginBackSwipe):
2066         (WTR::UIScriptController::completeBackSwipe):
2067         (WTR::UIScriptController::overridePreference):
2068         (WTR::UIScriptController::replaceTextAtRange):
2069         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2070         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2071         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2072         (WTR::UIScriptController::beginBackSwipe):
2073         (WTR::UIScriptController::completeBackSwipe):
2074         Implement beginBackSwipe and completeBackSwipe on iOS (they already
2075         exist on Mac) in terms of the new WKWebView testing SPI.
2076
2077 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2078
2079         REGRESSION (r226715): ignore WARNING output in linter tests
2080         https://bugs.webkit.org/show_bug.cgi?id=181486
2081         <rdar://problem/36408847>
2082
2083         Reviewed by Aakash Jain.
2084
2085         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
2086
2087         * Scripts/webkitpy/common/system/outputcapture.py:
2088         (OutputCapture.__init__): Pass logging level to be captured.
2089         * Scripts/webkitpy/style/main_unittest.py:
2090         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
2091         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
2092         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
2093         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
2094         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
2095         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
2096         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
2097         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
2098
2099 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2100
2101         Add a JSCOnly MIPS buildbot
2102         https://bugs.webkit.org/show_bug.cgi?id=181487
2103
2104         Reviewed by Michael Catanzaro.
2105
2106         Add the new bot configs definitions for the master and update the unit tests.
2107
2108         * BuildSlaveSupport/build.webkit.org-config/config.json:
2109         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2110
2111 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2112
2113         REGRESSION (r226715): don't re-check number of simulators in child processes
2114         https://bugs.webkit.org/show_bug.cgi?id=181484
2115         <rdar://problem/36407151>
2116
2117         Reviewed by Aakash Jain.
2118
2119         * Scripts/webkitpy/port/ios_simulator.py:
2120         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
2121         are already initialized.
2122
2123 2018-01-10  Commit Queue  <commit-queue@webkit.org>
2124
2125         Unreviewed, rolling out r226667 and r226673.
2126         https://bugs.webkit.org/show_bug.cgi?id=181488
2127
2128         This caused a flaky crash. (Requested by mlewis13 on #webkit).
2129
2130         Reverted changesets:
2131
2132         "CodeBlocks should be in IsoSubspaces"
2133         https://bugs.webkit.org/show_bug.cgi?id=180884
2134         https://trac.webkit.org/changeset/226667
2135
2136         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
2137         https://bugs.webkit.org/show_bug.cgi?id=180884
2138         https://trac.webkit.org/changeset/226673
2139
2140 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2141
2142         Follow-up fix to r226715
2143         https://bugs.webkit.org/show_bug.cgi?id=180555
2144         <rdar://problem/36131381>
2145
2146         Unreviewed infrastructure fix.
2147
2148         * Scripts/webkitpy/xcode/new_simulated_device.py:
2149         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
2150         of delete.
2151
2152 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2153
2154         webkitpy: Refactor simulator code (Part 2)
2155         https://bugs.webkit.org/show_bug.cgi?id=180555
2156         <rdar://problem/36131381>
2157
2158         Reviewed by Aakash Jain.
2159
2160         The patch leverages the SimulatedDeviceManager when running layout tests.
2161         This patch is primarily code removal, since much of the IOSSimulatorPort
2162         was dedicated to managing simulators. The removed code is either now owned by the
2163         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
2164         boot multiple simulators which was made obsolete in Xcode 9.
2165
2166         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2167         (Manager._custom_device_for_test.in): Device names now have spaces in them,
2168         strip those spaces.
2169         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2170         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
2171         * Scripts/webkitpy/port/ios.py:
2172         (IOSPort.__init__): The _current_device idiom is no longer required since the
2173         SimulatedDeviceManager keeps track of any previously booted devices.
2174         (IOSPort.target_host): Even when only a single device is used, it will be accessed
2175         through the array of managed devices.
2176         (IOSPort.using_multiple_devices): Deleted.
2177         * Scripts/webkitpy/port/ios_device.py:
2178         (IOSDevicePort.using_multiple_devices): Deleted.
2179         * Scripts/webkitpy/port/ios_simulator.py:
2180         (IOSSimulatorPort): Remove constants required to manage simulators, change device
2181         class strings so they can be parsed by the DeviceType class.
2182         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
2183         the number of simulators currently booted, the number of child processes specified
2184         and the maximum number of simulators supported by this system.
2185         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
2186         devices owned by the SimulatedDeviceManager.
2187         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
2188         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
2189         the maximum number of supported simulators on this system.
2190         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
2191         request for each child process and send this list to the SimulatedDeviceManager to
2192         initialize the devices.
2193         (IOSSimulatorPort.clean_up_test_run):
2194         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
2195         specified version of iOS.
2196         (IOSSimulatorPort.reset_preferences):
2197         (IOSSimulatorPort.simulator_runtime): Deleted.
2198         (IOSSimulatorPort.simulator_device_type): Deleted.
2199         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
2200         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
2201         (IOSSimulatorPort._create_simulators): Deleted.
2202         (IOSSimulatorPort._quit_ios_simulator): Deleted.
2203         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
2204         (IOSSimulatorPort.using_multiple_devices): Deleted.
2205         (IOSSimulatorPort._create_device): Deleted.
2206         (IOSSimulatorPort.get_simulator_path): Deleted.
2207         (IOSSimulatorPort._createSimulatorApps): Deleted.
2208         (IOSSimulatorPort._createSimulatorApp): Deleted.
2209         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2210         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
2211         maximum number of simulators run on this system.
2212         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
2213         * Scripts/webkitpy/xcode/new_simulated_device.py:
2214         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
2215
2216 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2217
2218         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
2219         https://bugs.webkit.org/show_bug.cgi?id=181474
2220
2221         Reviewed by Carlos Alberto Lopez Perez.
2222
2223         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
2224         name as the name.
2225
2226         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2227         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
2228         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
2229
2230 2018-01-09  Andy Estes  <aestes@apple.com>
2231
2232         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
2233         https://bugs.webkit.org/show_bug.cgi?id=181459
2234
2235         Reviewed by Dan Bernstein.
2236
2237         * ImageDiff/cg/Configurations/Base.xcconfig:
2238
2239 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
2240
2241         font-display:fallback can cause a visual flash (which is supposed to be impossible)
2242         https://bugs.webkit.org/show_bug.cgi?id=181374
2243
2244         Reviewed by Simon Fraser.
2245
2246         The test requires Palatino.
2247
2248         * DumpRenderTree/mac/DumpRenderTree.mm:
2249         (allowedFontFamilySet):
2250         * WebKitTestRunner/mac/TestControllerMac.mm:
2251         (WTR::allowedFontFamilySet):
2252
2253 2018-01-09  Saam Barati  <sbarati@apple.com>
2254
2255         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
2256         https://bugs.webkit.org/show_bug.cgi?id=181449
2257
2258         Reviewed by JF Bastien.
2259
2260         This allows me to Cmd+f in my terminal to search for things without
2261         having the results become misaligned.
2262
2263         * Scripts/display-profiler-output:
2264
2265 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2266
2267         [webkitpy] PlatformInfo should have default argument for casual use
2268         https://bugs.webkit.org/show_bug.cgi?id=180827
2269
2270         Reviewed by David Kilzer.
2271
2272         PlatformInfo should be the only way to check platform specific thing instead
2273         of sys.platform or other various checks. If there is something you want to check,
2274         it should be placed in PlatformInfo.
2275
2276         Currently to instantiate PlatformInfo, it requires arguments, which is usually
2277         sys, platform and Executive(). They are straight forward and should be handled
2278         by default arguments. Then we can instantiate PlatformInfo more casual.
2279
2280         * Scripts/webkitpy/common/system/platforminfo.py:
2281         (PlatformInfo): Use relative module path import
2282         (PlatformInfo.__init__):
2283         (PlatformInfo.executive): Lazy instantiation of Executive()
2284         (PlatformInfo.total_bytes_memory): Accessing via above property
2285         (PlatformInfo.xcode_sdk_version): Ditto
2286         (PlatformInfo.xcode_simctl_list): Ditto
2287         (PlatformInfo.xcode_version): Ditto
2288         (PlatformInfo._win_version_str): Ditto
2289         * Scripts/webkitpy/common/system/systemhost.py:
2290         (SystemHost.__init__):
2291         * Scripts/webkitpy/common/system/user.py:
2292         (User.__init__):
2293
2294 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2295
2296         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
2297         https://bugs.webkit.org/show_bug.cgi?id=176443
2298
2299         Reviewed by Darin Adler.
2300
2301         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
2302         (TEST):
2303
2304 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
2305
2306         check-webkit-style: Verify syntax for WK_API_AVAILABLE
2307         https://bugs.webkit.org/show_bug.cgi?id=181394
2308
2309         Reviewed by Darin Adler.
2310
2311         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
2312         as the second parameter instead of ios(WK_IOS_TBA). This generally
2313         builds for iOS on EWS but not when using the public SDK. See r224057,
2314         r223207 and r226211 for example. This patch adds a basic style check
2315         for that macro to prevent this kind of mistake.
2316
2317         * Scripts/webkitpy/style/checkers/cpp.py:
2318         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
2319         (check_style): Run new style check.
2320         (CppChecker): Add build type for the new style check.
2321         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2322         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
2323
2324 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2325
2326         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
2327         https://bugs.webkit.org/show_bug.cgi?id=181420
2328         <rdar://problem/36365827>
2329
2330         Reviewed by Alex Christensen.
2331
2332         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
2333         of corresponding _WKAttachments.
2334
2335         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2336         (TestWebKitAPI::TEST):
2337
2338 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2339
2340         Add WKNavigationDelegate SPI exposing WebProcess crash reason
2341         https://bugs.webkit.org/show_bug.cgi?id=181410
2342         <rdar://problem/36167199>
2343
2344         Reviewed by Wenson Hsieh.
2345
2346         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2347         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
2348         (TEST):
2349
2350 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2351
2352         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
2353         https://bugs.webkit.org/show_bug.cgi?id=181408
2354         <rdar://problem/35884960>
2355
2356         Reviewed by Tim Horton.
2357
2358         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
2359         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2360
2361 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2362
2363         [Attachment Support] Expose file name and content type of WKAttachment
2364         https://bugs.webkit.org/show_bug.cgi?id=181390
2365         <rdar://problem/36336837>
2366
2367         Reviewed by Tim Horton.
2368
2369         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
2370
2371         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2372         (-[_WKAttachment synchronouslyRequestInfo:]):
2373         (-[_WKAttachment synchronouslyRequestData:]):
2374
2375         Reimplement this in terms of -synchronouslyRequestInfo:.
2376
2377         (-[_WKAttachment expectRequestedDataToBe:]):
2378         (TestWebKitAPI::TEST):
2379
2380 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2381
2382         Copying, pasting, and then deleting an attachment element breaks attachment data requests
2383         https://bugs.webkit.org/show_bug.cgi?id=181365
2384         <rdar://problem/36340647>
2385
2386         Reviewed by Tim Horton.
2387
2388         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
2389         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
2390         detail.
2391
2392         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2393         (TestWebKitAPI::TEST):
2394
2395 2018-01-08  Youenn Fablet  <youenn@apple.com>
2396
2397         navigator.onLine does not work inside service workers
2398         https://bugs.webkit.org/show_bug.cgi?id=181079
2399         <rdar://problem/36178606>
2400
2401         Reviewed by Darin Adler.
2402
2403         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2404         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
2405
2406 2018-01-07  Saam Barati  <sbarati@apple.com>
2407
2408         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
2409         https://bugs.webkit.org/show_bug.cgi?id=181372
2410
2411         Reviewed by Filip Pizlo.
2412
2413         Adding these sorting modes makes it easier to analyze functions
2414         that recompile a lot and exit a lot.
2415
2416         * Scripts/display-profiler-output:
2417
2418 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
2419
2420         Unreviewed, remove my Cisco email from contributors.json
2421
2422         * Scripts/webkitpy/common/config/contributors.json:
2423
2424 2018-01-05  JF Bastien  <jfbastien@apple.com>
2425
2426         WebAssembly: poison JS object's secrets
2427         https://bugs.webkit.org/show_bug.cgi?id=181339
2428         <rdar://problem/36325001>
2429
2430         Reviewed by Mark Lam.
2431
2432         Update tests for swap(Poisoned<k, T>, T*)
2433
2434         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
2435         (TestWebKitAPI::TEST):
2436         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2437         (TestWebKitAPI::TEST):
2438         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2439         (TestWebKitAPI::TEST):
2440
2441 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2442
2443         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
2444         https://bugs.webkit.org/show_bug.cgi?id=181359
2445
2446         Reviewed by Tim Horton.
2447
2448         Ensure that these tests still pass using older SDKs.
2449
2450         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2451         (TestWebKitAPI::TEST):
2452
2453 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2454
2455         Rebase API test after r226469
2456         https://bugs.webkit.org/show_bug.cgi?id=181308
2457
2458         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
2459         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2460         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
2461
2462 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2463
2464         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
2465         https://bugs.webkit.org/show_bug.cgi?id=181217
2466
2467         Reviewed by Tim Horton.
2468
2469         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2470         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2471         (TEST):
2472
2473 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2474
2475         Add WKBundleFrameCreateFrameHandle
2476         https://bugs.webkit.org/show_bug.cgi?id=181232
2477         <rdar://problem/35926696>
2478
2479         Reviewed by Tim Horton.
2480
2481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2482         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
2483         (mouseDidMoveOverElement):
2484         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
2485         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2486         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
2487         (TEST):
2488
2489 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
2490
2491         iOS: Build fix after r226432.
2492         
2493         Unreviewed. Stop duplicating speakAs symbols for iOS.
2494
2495         * DumpRenderTree/AccessibilityUIElement.cpp:
2496         (AccessibilityUIElement::speakAs):
2497
2498 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
2499
2500         Unreviewed, added myself as WebKit reviewer
2501
2502         * Scripts/webkitpy/common/config/contributors.json:
2503
2504 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
2505
2506         WPE: Build fix after r226432.
2507
2508         Unreviewed. Rename ::speak() to ::speakAs().
2509         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2510         (WTR::AccessibilityUIElement::speakAs):
2511         (WTR::AccessibilityUIElement::speak): Deleted.
2512
2513 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
2514
2515         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
2516         https://bugs.webkit.org/show_bug.cgi?id=180361
2517
2518         Reviewed by Zalan Bujtas.
2519
2520         * DumpRenderTree/AccessibilityUIElement.cpp:
2521         (speakAsCallback):
2522         (AccessibilityUIElement::speakAs):
2523         (AccessibilityUIElement::getJSClass):
2524         (speakCallback): Deleted.
2525         (AccessibilityUIElement::speak): Deleted.
2526         * DumpRenderTree/AccessibilityUIElement.h:
2527         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2528         (AccessibilityUIElement::speakAs):
2529         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2530         (AccessibilityUIElement::speakAs):
2531         (AccessibilityUIElement::speak): Deleted.
2532         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2533         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2534         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2535         (WTR::AccessibilityUIElement::speakAs):
2536         (WTR::AccessibilityUIElement::speak): Deleted.
2537         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2538         (WTR::AccessibilityUIElement::speakAs):
2539         (WTR::AccessibilityUIElement::speak): Deleted.
2540
2541 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
2542
2543         REGRESSION (r226395): test-webkitperl test expectations incorrect
2544         https://bugs.webkit.org/show_bug.cgi?id=181307
2545         <rdar://problem/36306558>
2546
2547         Rubber-stamped by Aakash Jain.
2548
2549         r226395 added two lines towards the beginning of
2550         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
2551         numbers in the test expectations need to update.
2552
2553         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2554
2555 2018-01-04  Tim Horton  <timothy_horton@apple.com>
2556
2557         WKWebView loses minimum layout size overrides that happen while the process is terminated
2558         https://bugs.webkit.org/show_bug.cgi?id=181306
2559         <rdar://problem/34398288>
2560
2561         Reviewed by Dan Bernstein.
2562
2563         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2564         (TEST):
2565         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
2566         while the process is terminated results in the page getting the correct
2567         minimum layout size.
2568
2569 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
2570
2571         [MediaStream] Add Mock screen capture source
2572         https://bugs.webkit.org/show_bug.cgi?id=181291
2573         <rdar://problem/36298164>
2574
2575         Reviewed by Dean Jackson.
2576
2577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
2578         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2579         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2580
2581 2018-01-04  Lucas Forschler  <lforschler@apple.com>
2582
2583         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
2584
2585         Reviewed by Ling Ho.
2586
2587         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2588
2589 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2590
2591         [Attachment Support] Create attachment elements when dropping files on iOS
2592         https://bugs.webkit.org/show_bug.cgi?id=181192
2593         <rdar://problem/36280945>
2594
2595         Reviewed by Tim Horton.
2596
2597         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
2598         switch is enabled. See below for more details.
2599
2600         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2601         (-[NSItemProvider registerData:type:]):
2602         (platformCopyPNG):
2603         (TestWebKitAPI::TEST):
2604         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2605
2606         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
2607         source item provider when dragging rich text *without* attachments, so this should have been a check for just
2608         kUTTypeRTF instead.
2609
2610         (TestWebKitAPI::TEST):
2611
2612         Tests a few cases of inserting attachment elements via drop:
2613         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
2614             Instead of inserting the contents as inline web content, this should generate attachment elements.
2615         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
2616             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
2617             back to inserting the content as an attachment.
2618         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
2619             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
2620             or at the end).
2621
2622         * TestWebKitAPI/cocoa/TestWKWebView.h:
2623         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2624         (-[TestWKWebView objectByEvaluatingJavaScript:]):
2625
2626         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
2627         -stringByEvaluatingJavaScript to just turn around and call this.
2628
2629         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2630
2631 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
2632
2633         Replace hard-coded paths in shebangs with #!/usr/bin/env
2634         https://bugs.webkit.org/show_bug.cgi?id=181040
2635
2636         Reviewed by Alex Christensen.
2637
2638         * BuildSlaveSupport/build-launcher-app:
2639         * BuildSlaveSupport/build-launcher-dmg:
2640         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2641         * BuildSlaveSupport/built-product-archive:
2642         * BuildSlaveSupport/clean-build:
2643         * BuildSlaveSupport/delete-stale-build-files:
2644         * BuildSlaveSupport/download-built-product:
2645         * BuildSlaveSupport/gtk/buildbot/log/run:
2646         * BuildSlaveSupport/gtk/buildbot/run:
2647         * BuildSlaveSupport/gtk/pulseaudio/run:
2648         * BuildSlaveSupport/kill-old-processes:
2649         * BuildSlaveSupport/test-result-archive:
2650         * BuildSlaveSupport/win/kill-old-processes:
2651         * Scripts/SpacingHeuristics.pm:
2652         * Scripts/add-include:
2653         * Scripts/build-api-tests:
2654         * Scripts/build-dumprendertree:
2655         * Scripts/build-imagediff:
2656         * Scripts/build-jsc:
2657         * Scripts/build-webkit:
2658         * Scripts/build-webkittestrunner:
2659         * Scripts/check-Xcode-source-file-types:
2660         * Scripts/check-dom-results:
2661         * Scripts/check-for-exit-time-destructors:
2662         * Scripts/check-for-global-initializers:
2663         * Scripts/check-for-inappropriate-objc-class-names:
2664         * Scripts/check-for-weak-vtables-and-externals:
2665         * Scripts/clean-header-guards:
2666         * Scripts/compare-timing-files:
2667         * Scripts/configure-xcode-for-ios-development:
2668         * Scripts/copy-webkitlibraries-to-product-directory:
2669         * Scripts/create-exports:
2670         * Scripts/debug-minibrowser:
2671         * Scripts/debug-safari:
2672         * Scripts/debug-test-runner:
2673         * Scripts/do-file-rename:
2674         * Scripts/do-webcore-rename:
2675         * Scripts/dump-webkit-tests-run:
2676         * Scripts/ensure-valid-python:
2677         * Scripts/execAppWithEnv:
2678         * Scripts/extract-localizable-js-strings:
2679         * Scripts/filter-build-webkit:
2680         * Scripts/find-extra-includes:
2681         * Scripts/fix-blink-patch:
2682         * Scripts/generate-coverage-data:
2683         * Scripts/git-add-reviewer:
2684         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2685         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
2686         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
2687         * Scripts/make-new-script-test:
2688         * Scripts/make-script-test-wrappers:
2689         * Scripts/package-root:
2690         * Scripts/parse-malloc-history:
2691         * Scripts/report-include-statistics:
2692         * Scripts/resolve-ChangeLogs:
2693         * Scripts/run-api-tests:
2694         * Scripts/run-bindings-tests:
2695         * Scripts/run-content-extension-tester:
2696         * Scripts/run-iexploder-tests:
2697         * Scripts/run-javascriptcore-tests:
2698         * Scripts/run-jsc:
2699         * Scripts/run-leaks:
2700         * Scripts/run-mangleme-tests:
2701         * Scripts/run-minibrowser:
2702         * Scripts/run-pageloadtest:
2703         * Scripts/run-regexp-tests:
2704         * Scripts/run-safari:
2705         * Scripts/run-sunspider:
2706         * Scripts/run-test-runner:
2707         * Scripts/run-webkit-app:
2708         * Scripts/run-webkit-httpd:
2709         * Scripts/run-webkit-websocketserver:
2710         * Scripts/set-webkit-configuration:
2711         * Scripts/show-pretty-diff:
2712         * Scripts/sort-Xcode-project-file:
2713         * Scripts/split-file-by-class:
2714         * Scripts/sunspider-compare-results:
2715         * Scripts/svn-apply:
2716         * Scripts/svn-unapply:
2717         * Scripts/test-webkit-scripts:
2718         * Scripts/test-webkitperl:
2719         * Scripts/update-iexploder-cssproperties:
2720         * Scripts/update-javascriptcore-test-results:
2721         * Scripts/update-webkit:
2722         * Scripts/update-webkit-auxiliary-libs:
2723         * Scripts/update-webkit-dependency:
2724         * Scripts/update-webkit-libs-jhbuild:
2725         * Scripts/update-webkit-localizable-strings:
2726         * Scripts/update-webkit-support-libs:
2727         * Scripts/update-webkitgtk-libs:
2728         * Scripts/update-webkitwpe-libs:
2729         * Scripts/webkit-build-directory:
2730         * Scripts/webkitperl/LoadAsModule.pm:
2731         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
2732         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2733         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
2734         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
2735         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
2736         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
2737         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
2738         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2739         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2740         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2741         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
2742         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
2743         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
2744         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2745         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
2746         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2747         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2748         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
2749         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
2750         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
2751         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
2752         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
2753         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
2754         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
2755         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
2756         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2757         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
2758         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
2759         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
2760         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2761         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2762         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
2763         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
2764         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
2765         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
2766         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
2767         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
2768         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
2769         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
2770         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
2771         * ccache/ccache-clang:
2772         * ccache/ccache-clang++:
2773         * ccache/ccache-wrapper:
2774         * gtk/install-dependencies:
2775         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
2776         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
2777         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
2778         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
2779         * iExploder/iexploder-1.3.2/tools/showtest.rb:
2780         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
2781         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
2782         * iExploder/iexploder-1.7.2/src/webserver.rb:
2783         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
2784         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
2785         * wpe/install-dependencies:
2786
2787 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
2788
2789         filter-build-webkit filters out useful compiler error lines
2790         https://bugs.webkit.org/show_bug.cgi?id=179864
2791
2792         Reviewed by Tim Horton.
2793
2794         Don't filter out lines that contain information about build errors by always showing lines
2795         after a line that contains "note:" or "error:".
2796
2797         * Scripts/filter-build-webkit:
2798         (shouldShowSubsequentLine):
2799         (shouldIgnoreLine):
2800
2801 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2802
2803         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
2804         https://bugs.webkit.org/show_bug.cgi?id=173915
2805
2806         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
2807         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
2808         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
2809         empty string in this case.
2810
2811         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2812         (emitFormSubmissionEvent):
2813
2814 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2815
2816         [GTK] Add web process API to detect when form is submitted via JavaScript
2817         https://bugs.webkit.org/show_bug.cgi?id=173915
2818
2819         Reviewed by Carlos Garcia Campos.
2820
2821         Test it.
2822
2823         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2824         (FormSubmissionTest::FormSubmissionTest):
2825         (FormSubmissionTest::~FormSubmissionTest):
2826         (FormSubmissionTest::testFormSubmissionResult):
2827         (FormSubmissionTest::willSendDOMEventCallback):
2828         (FormSubmissionTest::willCompleteCallback):
2829         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
2830         (testWebExtensionFormSubmissionSteps):
2831         (beforeAll):
2832         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2833         (DelayedSignal::DelayedSignal):
2834         (emitFormSubmissionEvent):
2835         (handleFormSubmissionCallback):
2836         (willSubmitFormCallback):
2837         (pageCreatedCallback):
2838
2839 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2840
2841         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
2842         https://bugs.webkit.org/show_bug.cgi?id=181251
2843
2844         * Scripts/run-gtk-tests:
2845         (GtkTestRunner):
2846
2847 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2848
2849         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
2850         https://bugs.webkit.org/show_bug.cgi?id=181136
2851
2852         * Scripts/run-gtk-tests:
2853         (GtkTestRunner):
2854
2855 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
2856
2857         [macOS, iOS] Adopt new secure coding APIs in WebKit
2858         https://bugs.webkit.org/show_bug.cgi?id=181085
2859         <rdar://problem/34837397>
2860
2861         Reviewed by Tim Horton.
2862
2863         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
2864         capable of supporting NSSecureCoding, so pass through the current coding routines.
2865
2866         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
2867         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2868         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
2869         routines if necessary.
2870         (TEST): Updated for NSSecureCoding.
2871         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
2872         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
2873
2874 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2875
2876         Remove std::chrono completely
2877         https://bugs.webkit.org/show_bug.cgi?id=181186
2878
2879         Reviewed by Alex Christensen.
2880
2881         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2882         (WTR::TestController::platformRunUntil):
2883
2884 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2885
2886         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
2887         https://bugs.webkit.org/show_bug.cgi?id=181231
2888
2889         Reviewed by Alex Christensen.
2890
2891         Implement TestController APIs needed by ResourceLoadStatistics tests.
2892
2893         * WebKitTestRunner/TestController.cpp:
2894         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2895         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2896
2897 2018-01-02  Tim Horton  <timothy_horton@apple.com>
2898
2899         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
2900         https://bugs.webkit.org/show_bug.cgi?id=181219
2901
2902         Reviewed by Wenson Hsieh.
2903
2904         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2905
2906 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2907
2908         Add a WebAuthentication runtime feature flag
2909         https://bugs.webkit.org/show_bug.cgi?id=181220
2910         <rdar://problem/36055305>
2911
2912         Reviewed by Brent Fulgham.
2913
2914         Renames the CredentialManagement runtime feature flag into WebAuthentication.
2915
2916         * DumpRenderTree/TestOptions.h:
2917         * DumpRenderTree/TestOptions.mm:
2918         (TestOptions::TestOptions):
2919         * DumpRenderTree/mac/DumpRenderTree.mm:
2920         (enableExperimentalFeatures):
2921         (setWebPreferencesForTestOptions):
2922         * WebKitTestRunner/TestController.cpp:
2923         (WTR::TestController::resetPreferencesToConsistentValues):
2924         (WTR::updateTestOptionsFromTestHeader):
2925         * WebKitTestRunner/TestOptions.h:
2926         (WTR::TestOptions::hasSameInitializationOptions const):
2927
2928 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2929
2930         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
2931         https://bugs.webkit.org/show_bug.cgi?id=181143
2932         <rdar://problem/36200381>
2933
2934         Reviewed by Tim Horton.
2935
2936         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
2937         attachment elements are enabled.
2938
2939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2940         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2941         (TestWebKitAPI::TEST):
2942
2943 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
2944
2945         Update Credential Management API for WebAuthentication
2946         https://bugs.webkit.org/show_bug.cgi?id=181082
2947         <rdar://problem/36055239>
2948
2949         Reviewed by Brent Fulgham.
2950
2951         Enable Credential Management API for testing.
2952
2953         * DumpRenderTree/TestOptions.h:
2954         * WebKitTestRunner/TestOptions.h:
2955
2956 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2957
2958         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
2959         https://bugs.webkit.org/show_bug.cgi?id=168194
2960
2961         Reviewed by Carlos Garcia Campos.
2962
2963         Fix an assertion and unskip the test. The order that form controls are associated is not
2964         guaranteed.
2965
2966         * Scripts/run-gtk-tests:
2967         (GtkTestRunner):
2968         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2969         (didAssociateFormControlsCallback):
2970
2971 2018-01-02  Alex Christensen  <achristensen@webkit.org>
2972
2973         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
2974         https://bugs.webkit.org/show_bug.cgi?id=180897
2975         <rdar://problem/35535328>
2976
2977         Reviewed by Brent Fulgham.
2978
2979         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
2980
2981         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2982         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2983         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
2984         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2985         (websiteDataStoreTestWebView):
2986         (TEST):
2987
2988 == Rolled over to ChangeLog-2018-01-01 ==