One esc to exit fullscreen and pointer lock
[WebKit-https.git] / Tools / ChangeLog
1 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
2
3         One esc to exit fullscreen and pointer lock
4         https://bugs.webkit.org/show_bug.cgi?id=165416
5         rdar://problem/29430711
6
7         Reviewed by Jer Noble.
8
9         Implement WKPageUIClientV8 for pointer lock support.
10         Add "escape" key support in EventSenderProxy.
11
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::requestPointerLock):
14         (WTR::TestController::createOtherPage):
15         (WTR::TestController::createWebViewWithOptions):
16         * WebKitTestRunner/mac/EventSenderProxy.mm:
17         (WTR::EventSenderProxy::keyDown):
18
19 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
20
21         Add system trace points for JavaScript VM entry/exit
22         https://bugs.webkit.org/show_bug.cgi?id=165550
23
24         Reviewed by Tim Horton.
25
26         Add trace points for entry/exit into/out of the JS VM.
27
28         * Tracing/SystemTracePoints.plist:
29
30 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
31
32         [GTK] Cannot build GTK+ with CUPS 2.* versions
33         https://bugs.webkit.org/show_bug.cgi?id=163591
34
35         Reviewed by Michael Catanzaro.
36
37         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
38         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
39         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
40         old gtk+ since it requires not only bumping up glib accordingly and its consequence
41         causes many printing test failures. So, I propose to fix the configuration issue by
42         applying the change to the configure file directly. By doing this, we don't need to
43         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
44
45         * gtk/jhbuild.modules:
46         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
47
48 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
49
50         Fix use of enum in a WK2 C SPI header.
51         rdar://problem/28725583
52
53         Followup to correctly prefix the enum values.
54
55         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
56         (WTR::InjectedBundlePage::prepare):
57
58 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
59
60         Fix use of enum in a WK2 C SPI header.
61         rdar://problem/28725583
62
63         Reviewed by Dan Bernstein.
64
65         Use correct enum style for a C SPI header and fix the callers.
66
67         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
68         (WTR::InjectedBundlePage::prepare):
69
70 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
71
72         Add a new project for recording and playing back editing commands in editable web content
73         https://bugs.webkit.org/show_bug.cgi?id=165114
74         <rdar://problem/29408135>
75
76         Reviewed by Beth Dakin.
77
78         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
79         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
80         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
81         then be dragged into the playback test harness.
82
83         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
84         steps:
85
86         1. Load the capture harness and perform test-specific editing on the web view.
87         2. Let originalState be a dump of the DOM at this point in time.
88         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
89         4. Rewind all editing to the beginning.
90         5. Playback all editing to the end.
91         6. Dump the state of the DOM. This should be identical to originalState.
92
93         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
94         * EditingHistory/EditingHistory/Info.plist: Added.
95         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
96         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
97         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
98         * EditingHistory/EditingHistory/TestRunner.h: Added.
99         * EditingHistory/EditingHistory/TestRunner.m: Added.
100         (injectedMessageEventHandlerScript):
101         (-[TestRunner init]):
102         (-[TestRunner deleteBackwards:]):
103         (-[TestRunner typeString:]):
104         (-[TestRunner bodyElementSubtree]):
105         (-[TestRunner bodyTextContent]):
106         (-[TestRunner editingHistoryJSON]):
107         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
108         (-[TestRunner numberOfUpdates]):
109         (-[TestRunner jumpToUpdateIndex:]):
110         (-[TestRunner expectEvents:afterPerforming:]):
111         (-[TestRunner loadCaptureTestHarness]):
112         (-[TestRunner setTextObfuscationEnabled:]):
113         (-[TestRunner isDoneWaitingForPendingEvents]):
114         (-[TestRunner userContentController:didReceiveScriptMessage:]):
115
116         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
117         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
118
119         * EditingHistory/EditingHistory/TestUtil.h: Added.
120         * EditingHistory/EditingHistory/TestUtil.m: Added.
121         (waitUntilWithTimeout):
122         (waitUntil):
123
124         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
125
126         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
127         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
128         (-[WKWebView loadPageFromBundleNamed:]):
129         (-[WKWebView typeCharacter:]):
130         (-[WKWebView keyPressWithCharacters:keyCode:]):
131         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
132
133         Provides utilities for simulating interaction in a web view.
134
135         * EditingHistory/EditingHistory/main.m: Added.
136         (main):
137         * EditingHistory/EditingHistoryTests/Info.plist: Added.
138         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
139         (-[RewindAndPlaybackTests setUp]):
140         (-[RewindAndPlaybackTests tearDown]):
141         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
142         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
143         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
144         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
145         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
146
147 2016-12-07  Philippe Normand  <pnormand@igalia.com>
148
149         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
150         https://bugs.webkit.org/show_bug.cgi?id=165525
151
152         Reviewed by Carlos Garcia Campos.
153
154         * gtk/jhbuild.modules: gst-plugins-good should depend on the
155         libvpx package built within jhbuild.
156
157 2016-12-07  Philippe Normand  <pnormand@igalia.com>
158
159         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
160         https://bugs.webkit.org/show_bug.cgi?id=165520
161
162         Reviewed by Carlos Garcia Campos.
163
164         * gtk/jhbuild.modules: Added missing dependency on openh264 in
165         gst-plugins-bad, along with 2 upstream patches fixing the build
166         against OpenSSL 1.1.0.
167         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
168         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
169
170 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
171
172         Correct SDKROOT values in xcconfig files
173         https://bugs.webkit.org/show_bug.cgi?id=165487
174         rdar://problem/29539209
175
176         Reviewed by Dan Bernstein.
177
178         Fix suggested by Dan Bernstein.
179
180         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
181         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
182         * MiniBrowser/Configurations/DebugRelease.xcconfig:
183         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
184         * WebEditingTester/Configurations/DebugRelease.xcconfig:
185         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
186
187 2016-12-06  Daniel Bates  <dabates@apple.com>
188
189         WebKitTestRunner: Plugins are disabled in new windows
190         https://bugs.webkit.org/show_bug.cgi?id=165410
191
192         Reviewed by Alex Christensen.
193
194         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
195         a new window and loads a plugin will fail. We should enable plugins in all windows by
196         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
197
198         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
199         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
200         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
201
202         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
203         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
204         WKBundleSetPluginsEnabled().
205         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
206         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
207         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
208
209 2016-12-05  Dean Jackson  <dino@apple.com>
210
211         pointer lock needs to be feature detectable
212         https://bugs.webkit.org/show_bug.cgi?id=165426
213         <rdar://problem/29486715>
214
215         Reviewed by Antoine Quint.
216
217         Expose the comment line to turn on/off pointer lock.
218
219         * DumpRenderTree/TestOptions.h:
220         * DumpRenderTree/TestOptions.mm:
221         (TestOptions::TestOptions):
222         * DumpRenderTree/mac/DumpRenderTree.mm:
223         (resetWebPreferencesToConsistentValues):
224         * WebKitTestRunner/TestController.cpp:
225         (WTR::TestController::resetPreferencesToConsistentValues):
226         (WTR::updateTestOptionsFromTestHeader):
227         * WebKitTestRunner/TestOptions.h:
228         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
229         (WTR::PlatformWebView::viewSupportsOptions):
230         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
231         (WTR::PlatformWebView::viewSupportsOptions):
232
233 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
234
235         Make it possible to use an existing simulator instance for one-off testing
236         https://bugs.webkit.org/show_bug.cgi?id=164568
237         <rdar://problem/29189133>
238
239         Reviewed by Daniel Bates.
240
241         With this patch, if a simulator is currently running on the machine and
242         '--dedicated-simulators' is not passed into the application, only one simulator
243         instance will be used, and this instance will be the existing instance.
244         If no simulator is running or '--dedicated-simulators' is passed to the script,
245         previous behavior will be used.
246
247         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
248         (parse_args):
249         * Scripts/webkitpy/port/ios.py:
250         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
251         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
252         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
253         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
254         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
255         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
256         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
257         * Scripts/webkitpy/xcode/simulator.py:
258         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
259         (Simulator.current_device): Get currently running device.
260
261 2016-12-05  Dan Bernstein  <mitz@apple.com>
262
263         Disable a crashing test on iOS.
264
265         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
266
267 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
268
269         Fix a build break on EFL since r209303.
270
271         Unreviewed build fix.
272
273         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
274
275 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
276
277         Refactor SymbolImpl layout
278         https://bugs.webkit.org/show_bug.cgi?id=165247
279
280         Reviewed by Darin Adler.
281
282         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
283         (TestWebKitAPI::TEST):
284
285 2016-12-03  Dan Bernstein  <mitz@apple.com>
286
287         Fixed the build after r209307.
288
289         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
290         (TEST):
291
292 2016-12-03  Dan Bernstein  <mitz@apple.com>
293
294         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
295         https://bugs.webkit.org/show_bug.cgi?id=165276
296         <rdar://problem/29467040>
297
298         Reviewed by Darin Adler.
299
300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
301         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
302         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
303         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
304         (TEST):
305         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
306         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
307         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
308         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
309         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
310         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
311
312 2016-12-02  Andy Estes  <aestes@apple.com>
313
314         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
315         https://bugs.webkit.org/show_bug.cgi?id=164492
316
317         Reviewed by Dan Bernstein.
318
319         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
320         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
321         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
322         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
323         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
324         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
325         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
326         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
327         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
328         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
329         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
330         com.apple.$(PRODUCT_NAME:rfc1034identifier).
331         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
332         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
333         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
334         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
335         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
336         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
337         com.apple.$(PRODUCT_NAME:rfc1034identifier).
338         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
339         com.apple.$(PRODUCT_NAME:rfc1034identifier).
340         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
341         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
342         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
343         value ${PRODUCT_BUNDLE_IDENTIFIER}.
344         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
345         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
346         com.apple.WebKitTestRunner.InjectedBundle.
347         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
348         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
349         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
350         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
351         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
352         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
353         ${PRODUCT_BUNDLE_IDENTIFIER}.
354
355 2016-12-02  Brady Eidson  <beidson@apple.com>
356
357         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
358         https://bugs.webkit.org/show_bug.cgi?id=165330
359
360         Reviewed by Alex Christensen.
361
362         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
363
364         Problem is that doesn't reliably destroy the view.
365         We should explicitly kill the process instead.
366
367         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
368         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
369
370         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
371         (TEST):
372
373 2016-12-02  Commit Queue  <commit-queue@webkit.org>
374
375         Unreviewed, rolling out r209136.
376         https://bugs.webkit.org/show_bug.cgi?id=165337
377
378         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
379
380         Reverted changeset:
381
382         "Make it possible to use an existing simulator instance for
383         one-off testing"
384         https://bugs.webkit.org/show_bug.cgi?id=164568
385         http://trac.webkit.org/changeset/209136
386
387 2016-12-02  Chris Dumez  <cdumez@apple.com>
388
389         [Mac][WK1] Implement new HTML interactive form validation user interface
390         https://bugs.webkit.org/show_bug.cgi?id=164483
391
392         Reviewed by Simon Fraser.
393
394         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
395         on Mac DRT as this is needed by the HTML form validation layout tests.
396
397         * DumpRenderTree/mac/UIScriptControllerMac.mm:
398         (WTR::UIScriptController::contentsOfUserInterfaceItem):
399
400 2016-12-02  Brady Eidson  <beidson@apple.com>
401
402         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
403         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
404
405         Reviewed by Alexey Proskuryakov.
406
407         These tests had "run-loop races."
408         
409         The test spins the runloop waiting for one message.
410         Two messages might come in from the WebProcess in short succession, and both be delivered to the
411         UIProcess in the same spin of the runloop.
412
413         Therefore by the time the test stops spinning the runloop, notified that a message was received,
414         the first message has been overwritten by the second.
415
416         These tests are fixed by queueing the incoming messages instead of just storing one.
417
418         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
419         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
420         (getNextMessage):
421         (TEST):
422
423         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
424         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
425         (getNextMessage):
426         (TEST):
427
428 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
429
430         Add a runtime flag for SubtleCrypto
431         https://bugs.webkit.org/show_bug.cgi?id=164982
432
433         Reviewed by Brent Fulgham.
434
435         * DumpRenderTree/mac/DumpRenderTree.mm:
436         (resetWebPreferencesToConsistentValues):
437         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
438         (WTR::InjectedBundle::beginTesting):
439         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
440         (WTR::TestRunner::setSubtleCryptoEnabled):
441         * WebKitTestRunner/InjectedBundle/TestRunner.h:
442
443 2016-12-01  Alexey Proskuryakov  <ap@apple.com>
444
445         Remove webkitpy dependency on Eliza
446         https://bugs.webkit.org/show_bug.cgi?id=164979
447
448         Reviewed by Daniel Bates.
449
450         This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
451
452         * Scripts/webkitpy/thirdparty/__init__.py:
453         * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
454         test buildbot instead of eliza.
455         * Scripts/webkitpy/tool/bot/ircbot.py:
456         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
457
458 2016-12-01  Beth Dakin  <bdakin@apple.com>
459
460         Force clicking tests fail on some machines
461         https://bugs.webkit.org/show_bug.cgi?id=165263
462
463         Reviewed by Tim Horton.
464
465         Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on 
466         the user account having this feature enabled. 
467         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
468         (WTR::InjectedBundle::platformInitialize):
469         * WebKitTestRunner/mac/main.mm:
470         (setDefaultsToConsistentValuesForTesting):
471
472 2016-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
473
474         Introduce StringImpl::StaticStringImpl with constexpr constructor
475         https://bugs.webkit.org/show_bug.cgi?id=165093
476
477         Reviewed by Darin Adler.
478
479         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
480         (TestWebKitAPI::TEST):
481
482 2016-11-30  Antoine Quint  <graouts@apple.com>
483
484         [Modern Media Controls] Add an HTML comment flag to turn the feature on
485         https://bugs.webkit.org/show_bug.cgi?id=165226
486
487         Reviewed by Dean Jackson.
488
489         Add a new flag to turn Modern Media Controls on in the test runners.
490
491         * DumpRenderTree/TestOptions.h:
492         * DumpRenderTree/TestOptions.mm:
493         (TestOptions::TestOptions):
494         * DumpRenderTree/mac/DumpRenderTree.mm:
495         (resetWebPreferencesToConsistentValues):
496         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
497         (WTR::InjectedBundle::beginTesting):
498         * WebKitTestRunner/TestController.cpp:
499         (WTR::TestController::resetPreferencesToConsistentValues):
500         (WTR::updateTestOptionsFromTestHeader):
501         * WebKitTestRunner/TestOptions.h:
502         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
503         (WTR::PlatformWebView::viewSupportsOptions):
504         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
505         (WTR::PlatformWebView::viewSupportsOptions):
506
507 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
508
509         Add separate settings and preferences to enable/disable async decoding for large images and animated images
510         https://bugs.webkit.org/show_bug.cgi?id=165177
511
512         Reviewed by Simon Fraser.
513         
514         Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.
515
516         * MiniBrowser/mac/SettingsController.h:
517         * MiniBrowser/mac/SettingsController.m:
518         (-[SettingsController _populateMenu]):
519         (-[SettingsController validateMenuItem:]):
520         (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
521         (-[SettingsController largeImageAsyncDecodingEnabled]):
522         (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
523         (-[SettingsController animatedImageAsyncDecodingEnabled]):
524         (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
525         (-[SettingsController asyncImageDecodingEnabled]): Deleted.
526         * MiniBrowser/mac/WK1BrowserWindowController.m:
527         (-[WK1BrowserWindowController didChangeSettings]):
528         * MiniBrowser/mac/WK2BrowserWindowController.m:
529         (-[WK2BrowserWindowController didChangeSettings]):
530
531 2016-11-30  Jonathan Bedard  <jbedard@apple.com>
532
533         Make it possible to use an existing simulator instance for one-off testing
534         https://bugs.webkit.org/show_bug.cgi?id=164568
535         <rdar://problem/29189133>
536
537         Reviewed by Daniel Bates.
538
539         With this patch, if a simulator is currently running on the machine and
540         '--dedicated-simulators' is not passed into the application, only one simulator
541         instance will be used, and this instance will be the existing instance.
542         If no simulator is running or '--dedicated-simulators' is passed to the script,
543         previous behavior will be used.
544
545         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
546         (parse_args):
547         * Scripts/webkitpy/port/ios.py:
548         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
549         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
550         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
551         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
552         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
553         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
554         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
555         * Scripts/webkitpy/xcode/simulator.py:
556         (Simulator.current_device): Get currently running device.
557
558 2016-11-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
559
560         [Linux] run-benchmark should be able to execute the benchmarks with more browsers.
561         https://bugs.webkit.org/show_bug.cgi?id=164792
562
563         Reviewed by Michael Catanzaro.
564
565         This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script,
566         and adds a new LinuxBrowserDriver with a platform 'linux'.
567
568         It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser).
569
570         The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter.
571
572         The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to
573         kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before).
574         We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed.
575         This depends on psutil, so this will only be done if psutil is installed.
576
577         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
578         (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK.
579         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
580         (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test.
581         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added.
582         (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers.
583         (LinuxBrowserDriver.__init__):
584         (LinuxBrowserDriver.prepare_env):
585         (LinuxBrowserDriver.restore_env):
586         (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file <Tools/Scripts/webkitpy/benchmark_runner/README.md>)
587         (LinuxBrowserDriver.launch_url):
588         (LinuxBrowserDriver._get_first_executable_path_from_list):
589         (LinuxBrowserDriver._screen_size):
590         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
591         (LinuxChromeDriver):
592         (LinuxChromeDriver.launch_url):
593         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py.
594         (EpiphanyBrowserDriver):
595         (EpiphanyBrowserDriver.launch_url):
596         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
597         (LinuxFirefoxDriver):
598         (LinuxFirefoxDriver.launch_url):
599         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
600         (GTKMiniBrowserDriver):
601         (GTKMiniBrowserDriver.launch_url):
602         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
603         (SimpleHTTPServerDriver):
604         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
605         (getplatform):
606         (getdefaultbrowser):
607         (parse_args):
608         * Scripts/webkitpy/benchmark_runner/utils.py:
609         (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded.
610         We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file,
611         we can do that by matching against the base_class_file pattern when the list is created.
612
613 2016-11-29  Andy Estes  <aestes@apple.com>
614
615         [Cocoa] Enable two clang warnings recommended by Xcode
616         https://bugs.webkit.org/show_bug.cgi?id=164498
617
618         Reviewed by Mark Lam.
619
620         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
621         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
622         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
623         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
624
625 2016-11-29  Eric Carlson  <eric.carlson@apple.com>
626
627         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
628         https://bugs.webkit.org/show_bug.cgi?id=164760
629         <rdar://problem/29261266>
630
631         Reviewed by Youenn Fablet.
632         
633         Allow scripts to determine the number of times the user has been prompted for capture device access.
634
635         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
636         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
637         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
638         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
639         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
640         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
641         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
642         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
643         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
644         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
645         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
646         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
647         * WebKitTestRunner/InjectedBundle/TestRunner.h:
648         * WebKitTestRunner/TestController.cpp:
649         (WTR::TestController::resetStateToConsistentValues):
650         (WTR::OriginSettings::incrementRequestCount):
651         (WTR::OriginSettings::resetRequestCount):
652         (WTR::OriginSettings::requestCount):
653         (WTR::TestController::saltForOrigin):
654         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
655         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
656         (WTR::TestController::settingsForOrigin):
657         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
658         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
659         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
660         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
661         * WebKitTestRunner/TestController.h:
662         * WebKitTestRunner/TestInvocation.cpp:
663         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
664         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
665
666 2016-11-29  Simon Fraser  <simon.fraser@apple.com>
667
668         intersection-observer-entry-interface.html test fails on the bots
669         https://bugs.webkit.org/show_bug.cgi?id=165133
670
671         Reviewed by Darin Adler.
672         
673         Tests that enabled Intersection Observer via <!-- webkit-test-runner [ enableIntersectionObserver=true ] -->
674         would fail sometimes, because TestController::ensureViewSupportsOptionsForTest() failed to check
675         to see if this option required creating a new web view, so would just use the old view without
676         even resetting preferences.
677         
678         In general, TestController doesn't distinguish properly between options that require the creation
679         of a new view (like mock scrollbars), and those that can be simply reset as resetPreferencesToConsistentValues()
680         does.
681         
682         Do the easy fix of having viewSupportsOptions() check options.enableIntersectionObserver. We should probably
683         just call resetPreferencesToConsistentValues() even when re-use the same view.
684         
685         * WebKitTestRunner/TestController.cpp:
686         (WTR::TestController::resetPreferencesToConsistentValues):
687         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
688         (WTR::PlatformWebView::viewSupportsOptions):
689         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
690         (WTR::PlatformWebView::viewSupportsOptions):
691
692 2016-11-28  Ryan Haddad  <ryanhaddad@apple.com>
693
694         Unreviewed, rolling out r209008.
695
696         This change appears to have caused two fast/mediastrem
697         LayoutTests to fail.
698
699         Reverted changeset:
700
701         "[MediaStream] Don't request user permission for a device if
702         it has already been granted in the current browsing context"
703         https://bugs.webkit.org/show_bug.cgi?id=164760
704         http://trac.webkit.org/changeset/209008
705
706 2016-11-28  Daniel Bates  <dabates@apple.com>
707
708         Teach webkitpy how to read CSSProperties.json r209001
709         https://bugs.webkit.org/show_bug.cgi?id=165108
710
711         Reviewed by Simon Fraser.
712
713         Fix webkitpy logic so that it can read CSS property names from CSSProperties.json following r209001.
714
715         Following r209001 CSSPropertyNames.in no longer exists as it was replaced with CSSProperties.json.
716         We need to modify the webkitpy machinery that processed CSSPropertyNames.in to process CSSProperties.json.
717
718         * Scripts/webkitpy/w3c/test_converter.py:
719         (_W3CTestConverter.__init__): Make self._css_property_file and self._css_property_value_file local
720         variables as it is unnecessary for them to be instance variables. Call read_webkit_prefixed_css_property_list()
721         to read the property names from file CSSProperties.json. Call legacy_read_webkit_prefixed_css_property_list() to
722         read CSS keyword values from CSSValueKeywords.in.
723         (_W3CTestConverter.read_webkit_prefixed_css_property_list): Added.
724         (_W3CTestConverter):
725         (_W3CTestConverter.legacy_read_webkit_prefixed_css_property_list): Renamed from read_webkit_prefixed_css_property_list.
726         * Scripts/webkitpy/w3c/test_importer_unittest.py:
727         (TestImporterTest.test_harnesslinks_conversion): Substitute CSSProperties.json for CSSPropertyNames.in.
728
729 2016-11-28  Eric Carlson  <eric.carlson@apple.com>
730
731         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
732         https://bugs.webkit.org/show_bug.cgi?id=164760
733         <rdar://problem/29261266>
734
735         Reviewed by Youenn Fablet.
736         
737         Allow scripts to determine the number of times the user has been prompted for capture device access.
738
739         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
740         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
741         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
742         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
743         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
744         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
745         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
746         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
747         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
748         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
749         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
750         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
751         * WebKitTestRunner/InjectedBundle/TestRunner.h:
752         * WebKitTestRunner/TestController.cpp:
753         (WTR::TestController::resetStateToConsistentValues):
754         (WTR::OriginSettings::incrementRequestCount):
755         (WTR::OriginSettings::resetRequestCount):
756         (WTR::OriginSettings::requestCount):
757         (WTR::TestController::saltForOrigin):
758         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
759         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
760         (WTR::TestController::settingsForOrigin):
761         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
762         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
763         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
764         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
765         * WebKitTestRunner/TestController.h:
766         * WebKitTestRunner/TestInvocation.cpp:
767         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
768         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
769
770 2016-11-18  Jer Noble  <jer.noble@apple.com>
771
772         Add some performance tests for various aspects of media loading and playback.
773         https://bugs.webkit.org/show_bug.cgi?id=164977
774
775         Reviewed by Darin Adler.
776
777         Allow callers to pass in extra alias/directory pairs to run-webkit-httpd.
778
779         * Scripts/run-webkit-httpd:
780         (parse_args):
781         (main):
782
783 2016-11-27  Simon Fraser  <simon.fraser@apple.com>
784
785         Another fix for CMake.
786
787         * DumpRenderTree/TestOptions.h:
788         * DumpRenderTree/TestOptions.mm:
789
790 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
791
792         Better fix for the Mac CMake build.
793
794         * DumpRenderTree/PlatformMac.cmake:
795
796 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
797
798         Attempt to fix Mac CMake build.
799
800         * DumpRenderTree/PlatformMac.cmake:
801
802 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
803
804         [WTF] Import std::optional reference implementation as WTF::Optional
805         https://bugs.webkit.org/show_bug.cgi?id=164199
806
807         Reviewed by Saam Barati and Sam Weinig.
808
809         Use WTF::Optional::value_or.
810
811         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
812         (WTR::UIScriptController::stableStateOverride):
813         (WTR::UIScriptController::setStableStateOverride):
814         * TestRunnerShared/Bindings/JSWrappable.h:
815         (WTR::JSValueMakeBooleanOrNull):
816         (WTR::JSValueToNullableBoolean):
817         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
818         (WTR::UIScriptController::stableStateOverride):
819         (WTR::UIScriptController::setStableStateOverride):
820         * TestRunnerShared/UIScriptContext/UIScriptController.h:
821         * TestWebKitAPI/Tests/WTF/Optional.cpp:
822         (TestWebKitAPI::TEST):
823         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
824         (TestWebKitAPI::testParseHTMLInteger):
825         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
826         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
827         (TestWebKitAPI::checkURL):
828         (TestWebKitAPI::checkRelativeURL):
829         (TestWebKitAPI::checkURLDifferences):
830         (TestWebKitAPI::checkRelativeURLDifferences):
831         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
832         (WTR::UIScriptController::stableStateOverride):
833         (WTR::UIScriptController::setStableStateOverride):
834
835 2016-11-26  Sam Weinig  <sam@webkit.org>
836
837         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
838         https://bugs.webkit.org/show_bug.cgi?id=164965
839
840         Reviewed by Simon Fraser.
841
842         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
843         Add new files.
844
845         * DumpRenderTree/TestOptions.h: Added.
846         * DumpRenderTree/TestOptions.mm: Added.
847         (parseBooleanTestHeaderValue):
848         (TestOptions::TestOptions):
849         Port TestOption parsing from WKTR to DRT.
850
851         * DumpRenderTree/mac/DumpRenderTree.mm:
852         (resetWebPreferencesToConsistentValues):
853         (resetWebViewToConsistentStateBeforeTesting):
854         (runTest):
855         * WebKitTestRunner/TestController.cpp:
856         Pass TestOptions down to resetWebPreferencesToConsistentValues to allow setting
857         preferences conditionally.
858
859         (WTR::TestController::resetPreferencesToConsistentValues):
860         (WTR::updateTestOptionsFromTestHeader):
861         * WebKitTestRunner/TestOptions.h:
862         Add a new test option header, enableIntersectionObserver, to enable IntersectionObserver.
863
864 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
865
866         Migrate some layout timer-related code from std::chrono to Seconds and MonotonicTime
867         https://bugs.webkit.org/show_bug.cgi?id=164992
868
869         Reviewed by Darin Adler.
870         
871         Use Seconds::zero().
872
873         * TestWebKitAPI/Tests/WTF/Condition.cpp:
874
875 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
876
877         Add literals for various time units
878         https://bugs.webkit.org/show_bug.cgi?id=165074
879
880         Reviewed by Filip Pizlo.
881         
882         Add tests for new time literals. Add new tests for units.
883
884         * TestWebKitAPI/Tests/WTF/Time.cpp:
885         (TestWebKitAPI::TEST):
886
887 2016-11-25  Csaba Osztrogonác  <ossy@webkit.org>
888
889         Fix compile warnings after r208415
890         https://bugs.webkit.org/show_bug.cgi?id=165061
891
892         Reviewed by Andy Estes.
893
894         * TestWebKitAPI/Tests/WTF/Time.cpp:
895         (TestWebKitAPI::TEST):
896
897 2016-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
898
899         [GTK] Notifications API does not expose or respect the "tag" attribute
900         https://bugs.webkit.org/show_bug.cgi?id=164771
901
902         Reviewed by Gustavo Noronha Silva.
903
904         Verify that showing a notification with the same tag as another notification closes the
905         previous notification before the new notification is shown.
906
907         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
908         (testWebViewNotification):
909
910 2016-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
911
912         Unreviewed. Fix GTK+ test /webkit2/WebKitWebContext/get-plugins after r208429.
913
914         Test plugin library was renamed as libTestNetscapePlugIn.so in r208429.
915
916         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
917         (testWebContextGetPlugins): Update the library name.
918
919 2016-11-22  Darin Adler  <darin@apple.com>
920
921         Make normal case fast in the input element limitString function
922         https://bugs.webkit.org/show_bug.cgi?id=165023
923
924         Reviewed by Dan Bernstein.
925
926         * TestWebKitAPI/CMakeLists.txt: Added TextBreakIterator.cpp.
927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
928         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp: Added.
929         Contains some tests for the numGraphemeClusters and
930         numCharactersInGraphemeClusters functions that I used to make sure
931         that the new fast paths I added work correctly.
932
933 2016-11-22  Tomas Popela  <tpopela@redhat.com>
934
935         Unreviewed, add myself as a WebKit committer.
936
937         * Scripts/webkitpy/common/config/contributors.json:
938
939 2016-11-21  Mark Lam  <mark.lam@apple.com>
940
941         Hasher::addCharacters() should be able to handle zero length strings.
942         https://bugs.webkit.org/show_bug.cgi?id=165024
943
944         Reviewed by Yusuke Suzuki.
945
946         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
947         (TestWebKitAPI::TEST):
948
949 2016-11-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
950
951         [CMake] build fails after update to cmake 3.7
952         https://bugs.webkit.org/show_bug.cgi?id=165008
953
954         Reviewed by Dan Bernstein.
955
956         When we remove the CMake cache, we should remove both the
957         CMakeCache.txt file and the CMakeFiles directory.
958         See: https://gitlab.kitware.com/cmake/cmake/issues/14820
959
960         * Scripts/webkitdirs.pm:
961         (cmakeFilesPath):
962         (removeCMakeCache):
963
964 2016-11-16  Philippe Normand  <pnormand@igalia.com>
965
966         [GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer
967         https://bugs.webkit.org/show_bug.cgi?id=164817
968
969         Reviewed by Alejandro G. Castro.
970
971         This is temporary, hopefully. The OpenWebRTC patches will/should
972         be soon reviewed and upstream but meanwhile it makes sense to use
973         the Igalia downstream fork so that the WebRTC testing is easier.
974
975         Recent GStreamer patches are also needed for RTP bundling support
976         and RTP retransmission fixes.
977
978         * gtk/jhbuild.modules:
979         * gtk/openwebrtc.modules: Removed.
980         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Added.
981         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Added.
982         * gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
983
984 2016-11-20  Zan Dobersek  <zdobersek@igalia.com>
985
986         [EncryptedMedia] Make EME API runtime-enabled
987         https://bugs.webkit.org/show_bug.cgi?id=164927
988
989         Reviewed by Jer Noble.
990
991         Enable the EME API via the WKTR InjectedBundle whenever testing
992         commences. This does not have any effect unless the EME feature
993         is enabled at compile-time, but it's still added to match other
994         features and for future use.
995
996         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
997         (WTR::InjectedBundle::beginTesting):
998         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
999         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1000         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1001
1002 2016-11-19  Simon Fraser  <simon.fraser@apple.com>
1003
1004         Fix the Mac and iOS bulds.
1005
1006         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1007         (-[TestRunnerWKWebView _stableStateOverride]):
1008         (-[TestRunnerWKWebView _setStableStateOverride:]):
1009
1010 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
1011
1012         Make it possible to test non-stable-state scrolling on iOS
1013         https://bugs.webkit.org/show_bug.cgi?id=164905
1014
1015         Reviewed by Dan Bernstein.
1016
1017         Make it possible for an iOS layout test to force every visible rect update
1018         from the UI process to the web process to be in a non-stable state. This emulates
1019         what happens during panning and zooming interactions, and allows us to test the
1020         scrolling and layer trees in these transient states.
1021         
1022         This is done by adding a testing property on WKWebView, _stableStateOverride, whose
1023         getters and setters are overridden in TestRunnerWKWebView. When non-nil, we _updateVisibleContentRectAfterScrollInView
1024         consults the NSNumber's boolValue and uses it to override the stable state.
1025         
1026         To facilitate this kind of testing, also add immediateScrollToOffset() and
1027         immediateZoomToScale() to UIScriptController. Finally, add doAfterPresentationUpdate()
1028         which provides a callback that fires after one trip to the web process and back.
1029         
1030         Add code generation support for optional boolean attributes in IDL.
1031
1032         Align CodeGeneratorDumpRenderTree.pm and CodeGeneratorTestRunner.pm.
1033
1034         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1035         (_generateImplementationFile):
1036         (_platformTypeConstructor):
1037         (_returnExpression):
1038         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1039         (WTR::UIScriptController::doAfterPresentationUpdate):
1040         (WTR::contentOffsetBoundedInValidRange):
1041         (WTR::UIScriptController::scrollToOffset):
1042         (WTR::UIScriptController::immediateScrollToOffset):
1043         (WTR::UIScriptController::immediateZoomToScale):
1044         (WTR::UIScriptController::stableStateOverride):
1045         (WTR::UIScriptController::setStableStateOverride):
1046         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1047         (WTR::UIScriptController::doAfterPresentationUpdate):
1048         * TestRunnerShared/Bindings/JSWrappable.h:
1049         (WTR::JSValueMakeBooleanOrNull):
1050         (WTR::JSValueToNullableBoolean):
1051         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1052         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1053         (WTR::UIScriptController::immediateScrollToOffset):
1054         (WTR::UIScriptController::immediateZoomToScale):
1055         (WTR::UIScriptController::stableStateOverride):
1056         (WTR::UIScriptController::setStableStateOverride):
1057         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1058         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1059         (_classRefGetter):
1060         (_platformTypeConstructor):
1061         (_returnExpression):
1062         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1063         (-[TestRunnerWKWebView dealloc]):
1064         (-[TestRunnerWKWebView _stableStateOverride]):
1065         (-[TestRunnerWKWebView _setStableStateOverride:]):
1066         * WebKitTestRunner/ios/TestControllerIOS.mm:
1067         (WTR::TestController::platformResetStateToConsistentValues):
1068         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1069         (WTR::UIScriptController::doAsyncTask):
1070         (WTR::UIScriptController::doAfterPresentationUpdate):
1071         (WTR::UIScriptController::zoomToScale):
1072         (WTR::UIScriptController::immediateScrollToOffset):
1073         (WTR::UIScriptController::immediateZoomToScale):
1074         (WTR::UIScriptController::stableStateOverride):
1075         (WTR::UIScriptController::setStableStateOverride):
1076         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1077         (WTR::UIScriptController::doAfterPresentationUpdate):
1078
1079 2016-11-19  Joanmarie Diggs  <jdiggs@igalia.com>
1080
1081         AX: [ATK] Expose aria-busy via ATK_STATE_BUSY
1082         https://bugs.webkit.org/show_bug.cgi?id=164909
1083
1084         Reviewed by Chris Fleizach.
1085
1086         Implement boolAttributeValue() for ATK so we can test AXElementBusy.
1087
1088         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1089         (WTR::AccessibilityUIElement::boolAttributeValue):
1090
1091 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
1092
1093         [iOS WK2] Eliminate a source of flakiness in layout tests by forcing WebPage into "responsive" mode for all tests, with an internals override
1094         https://bugs.webkit.org/show_bug.cgi?id=164980
1095
1096         Reviewed by Chris Dumez.
1097
1098         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1099         (WTR::InjectedBundlePage::prepare):
1100
1101 2016-11-18  Dean Jackson  <dino@apple.com>
1102
1103         AX: "(inverted-colors)" media query only matches on page reload; should match on change
1104         https://bugs.webkit.org/show_bug.cgi?id=163564
1105         <rdar://problem/28807350>
1106
1107         Reviewed by Simon Fraser.
1108
1109         Add a UIScriptController method that tricks WebKit into thinking
1110         it has received a notification that accessibility settings have
1111         changed. Combined with our forced overrides, this allows us to
1112         test if a page would react to the notifications.
1113
1114         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1115         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
1116         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1117         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
1118         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1119         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1120         (WTR::simulateAccessibilitySettingsChangeNotification):
1121         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1122         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1123         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
1124         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1125         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
1126
1127 2016-11-18  Alex Christensen  <achristensen@webkit.org>
1128
1129         Fix API test after r208902
1130         https://bugs.webkit.org/show_bug.cgi?id=144194
1131
1132         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
1133         (TestWebKitAPI::TEST):
1134         The fullwidth solidus, U+FF0F, changed encoding from IDN2003 to IDN2008, probably to prevent domains from using it
1135         to spoof other domains.  https://webkit.org/blog/ and https://webkit.org\uFF0Fblog/ would otherwise look 
1136         too similar when rendered.
1137
1138 2016-11-17  Alex Christensen  <achristensen@webkit.org>
1139
1140         Support IDN2008 with UTS #46 instead of IDN2003
1141         https://bugs.webkit.org/show_bug.cgi?id=144194
1142
1143         Reviewed by Darin Adler.
1144
1145         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1146         (TestWebKitAPI::TEST_F):
1147         Add some tests from http://unicode.org/faq/idn.html verifying that we follow UTS46's deviations from IDN2008.
1148         Add some tests based on https://tools.ietf.org/html/rfc5893 verifying that we check for bidirectional text.
1149         Add a test based on https://tools.ietf.org/html/rfc5892 verifying that we do not do ContextO check.
1150         Add a test for U+321D and U+321E which have particularly interesting punycode encodings.  We match Firefox here now.
1151         Also add a test from http://www.unicode.org/reports/tr46/#IDNAComparison verifying we are not using IDN2003.
1152         We should consider importing all of http://www.unicode.org/Public/idna/9.0.0/IdnaTest.txt as URL domain tests.
1153
1154 2016-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1155
1156         Downloads started by context menu actions should also have a web view associated
1157         https://bugs.webkit.org/show_bug.cgi?id=164364
1158
1159         Reviewed by Michael Catanzaro.
1160
1161         Add a GTK+ unit tests to check that downloads started by the context menu have a web view associated.
1162
1163         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1164         (downloadLocalFileSuccessfully):
1165         (testDownloadOverwriteDestinationDisallowed):
1166         (testDownloadLocalFileError):
1167         (testDownloadRemoteFile):
1168         (testDownloadRemoteFileError):
1169         (testDownloadMIMEType):
1170         (contextMenuCallback):
1171         (testContextMenuDownloadActions):
1172         (beforeAll):
1173
1174 2016-11-17  Ryosuke Niwa  <rniwa@webkit.org>
1175
1176         Add an experimental API to find elements across shadow boundaries
1177         https://bugs.webkit.org/show_bug.cgi?id=164851
1178         <rdar://problem/28220092>
1179
1180         Reviewed by Sam Weinig.
1181
1182         Added test cases for window.collectMatchingElementsInFlatTree to WebKit2.InjectedBundleMakeAllShadowRootOpen.
1183
1184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1185         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRoot*s*Open_Bundle.cpp: Renamed
1186         from InjectedBundleMakeAllShadowRootOpen_Bundle.cpp.
1187         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Added test cases for
1188         window.collectMatchingElementsInFlatTree by calling alert() many times.
1189         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1190         (TestWebKitAPI::runJavaScriptAlert): Added expectations for multiple test cases. Each test case
1191         finishes with a call to alert, and moves testNumber forward.
1192         (TestWebKitAPI::TEST): Use the newly added closed-shadow-tree-test.html
1193         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Added. Creates a shadow tree with slots
1194         and tests that window.collectMatchingElementsInFlatTree is not present when
1195         an event named "testnormalworld" is dispatched by the injected bundle.
1196
1197 2016-11-17  Brady Eidson  <beidson@apple.com>
1198
1199         Add _WKIconLoadingDelegate SPI.
1200         https://bugs.webkit.org/show_bug.cgi?id=164894
1201
1202         Reviewed by Alex Christensen.
1203
1204         Add MiniBrowser support for this new SPI, configurable with a setting.
1205
1206         * MiniBrowser/mac/SettingsController.h:
1207         * MiniBrowser/mac/SettingsController.m:
1208         (-[SettingsController _populateMenu]):
1209         (-[SettingsController validateMenuItem:]):
1210         (-[SettingsController loadsAllSiteIcons]):
1211         (-[SettingsController toggleLoadsAllSiteIcons:]):
1212         * MiniBrowser/mac/WK2BrowserWindowController.m:
1213         (-[WK2BrowserWindowController awakeFromNib]):
1214         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]):
1215
1216 2016-11-17  Caitlin Potter  <caitp@igalia.com>
1217
1218         [JSC] remove leftover references to ES2017_ASYNCFUNCTION_SYNTAX flag
1219         https://bugs.webkit.org/show_bug.cgi?id=164879
1220
1221         Reviewed by Alex Christensen.
1222
1223         The flag was referenced in FeatureList.pm and in one of the
1224         FeatureDefines.xcconfig files, despite being removed.
1225
1226         * Scripts/webkitperl/FeatureList.pm:
1227         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1228
1229 2016-11-17  Per Arne Vollan  <pvollan@apple.com>
1230
1231         [Win] run-api-tests is failing.
1232         https://bugs.webkit.org/show_bug.cgi?id=164818
1233
1234         Reviewed by Alexey Proskuryakov.
1235
1236         Make sure Visual Studio interprets string literal as utf8.
1237  
1238         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1239         (TestWebKitAPI::TEST_F):
1240
1241 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
1242
1243         [JSC] WTF::TemporaryChange with WTF::SetForScope
1244         https://bugs.webkit.org/show_bug.cgi?id=164761
1245
1246         Reviewed by Saam Barati.
1247
1248         * TestWebKitAPI/CMakeLists.txt:
1249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1250         * TestWebKitAPI/Tests/WTF/SetForScope.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp.
1251         (TestWebKitAPI::TEST):
1252         * WebKitTestRunner/TestController.cpp:
1253         (WTR::TestController::resetStateToConsistentValues):
1254
1255 2016-11-16  Alexey Proskuryakov  <ap@apple.com>
1256
1257         REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing
1258         https://bugs.webkit.org/show_bug.cgi?id=164572
1259
1260         Reviewed by Tim Horton.
1261
1262         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetStateToConsistentValues):
1263         Use the correct constant.
1264
1265 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1266
1267         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
1268         https://bugs.webkit.org/show_bug.cgi?id=164827
1269
1270         Reviewed by Ryosuke Niwa.
1271
1272         Enabled ES6 Modules in test runners.
1273
1274         * DumpRenderTree/mac/DumpRenderTree.mm:
1275         (resetWebPreferencesToConsistentValues):
1276         * DumpRenderTree/win/DumpRenderTree.cpp:
1277         (resetWebPreferencesToConsistentValues):
1278         * Scripts/webkitperl/FeatureList.pm:
1279         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1280         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1281         (WTR::InjectedBundle::beginTesting):
1282         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1283         (WTR::TestRunner::setES6ModulesEnabled):
1284         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1285
1286 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
1287
1288         Hard to write reliable UIScriptController scrollingTreeAsText tests
1289         https://bugs.webkit.org/show_bug.cgi?id=164764
1290
1291         Reviewed by Wenson Hsieh.
1292
1293         Fix one cause of flakiness by resetting the WKWebView's UIScrollView scale
1294         and scroll position between tests.
1295
1296         * WebKitTestRunner/ios/TestControllerIOS.mm:
1297         (WTR::TestController::platformResetStateToConsistentValues):
1298
1299 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
1300
1301         UIScriptController: script with no async tasks fails if an earlier script registered a callback
1302         https://bugs.webkit.org/show_bug.cgi?id=164762
1303
1304         Reviewed by Wenson Hsieh.
1305         
1306         Make TestRunner::callUIScriptCallback() async in DumpRenderTree to match WebKitTestRunner behavior.
1307         This fixes ui-side-script-with-callback.html in WK1, which failed because the second runUIScript()
1308         would occur inside the completion callback from the first. This no longer happens.
1309
1310         * DumpRenderTree/TestRunner.cpp:
1311         (TestRunner::callUIScriptCallback):
1312         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1313         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1314
1315 2016-11-16  Ryan Haddad  <ryanhaddad@apple.com>
1316
1317         Unreviewed, rolling out r208770.
1318
1319         The test added with this change is timing out on mac-wk1.
1320
1321         Reverted changeset:
1322
1323         "UIScriptController: script with no async tasks fails if an
1324         earlier script registered a callback"
1325         https://bugs.webkit.org/show_bug.cgi?id=164762
1326         http://trac.webkit.org/changeset/208770
1327
1328 2016-11-16  Per Arne Vollan  <pvollan@apple.com>
1329
1330         [Win] WebCore test is failing.
1331         https://bugs.webkit.org/show_bug.cgi?id=164772
1332
1333         Reviewed by Brent Fulgham.
1334
1335         The value of CGRectInfinite is not the same on Windows as on Mac.
1336
1337         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1338         (TestWebKitAPI::TEST):
1339
1340 2016-11-15  Alexey Proskuryakov  <ap@apple.com>
1341
1342         Update Youenn's e-mail addresses.
1343
1344         * Scripts/webkitpy/common/config/contributors.json:
1345
1346 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
1347
1348         UIScriptController: script with no async tasks fails if an earlier script registered a callback
1349         https://bugs.webkit.org/show_bug.cgi?id=164762
1350
1351         Reviewed by Wenson Hsieh.
1352         
1353         UIScriptContext::runUIScript() considers a script to be "immediate" if that script doesn't
1354         queue any async tasks. However, if an earlier UI script registered a callback, UIScriptContext::runUIScript()
1355         would consider that an outstanding task.
1356         
1357         Fix by unregistering any callbacks associated with the current UI script when uiScriptComplete() is called.
1358
1359         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1360         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1361
1362 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
1363
1364         UIScriptController: setting a callback to undefined should unregister it
1365         https://bugs.webkit.org/show_bug.cgi?id=164796
1366
1367         Reviewed by Dean Jackson.
1368         
1369         "Immediate" UI scripts (those that don't schedule any async tasks) should return
1370         immediately, without the need to call uiScriptComplete(). However, this is broken if
1371         an earlier UI script registered a callback (since no-one clears that callback after the
1372         first script completes).
1373
1374         Make possible the workaround of setting the callback to undefined, which previously did
1375         not clear the callback registration.
1376
1377         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1378         (UIScriptContext::registerCallback):
1379         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1380         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1381         (WTR::UIScriptController::platformClearAllCallbacks):
1382
1383 2016-11-14  Mark Lam  <mark.lam@apple.com>
1384
1385         Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations.
1386         https://bugs.webkit.org/show_bug.cgi?id=164695
1387
1388         Reviewed by Keith Miller.
1389
1390         This gives us more flexibility when specific tests needs to enable special JSC
1391         options in order to exercise specific code paths to be tested.  It also saves us
1392         from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest.
1393         We can now just use runFTLNoCJIT in its place.
1394
1395         Also replaced the ifJSCArgIsntProvidedAreWeReleaseBuild variable with $buildType
1396         so that we have the ability to skip certain tests for release or debug builds.
1397         This will be needed in the upcoming patch for https://webkit.org/b/155145.
1398
1399         * Scripts/run-jsc-stress-tests:
1400
1401 2016-11-14  Joanmarie Diggs  <jdiggs@igalia.com>
1402
1403         AX: [ATK] Expose STATE_SINGLE_LINE and STATE_MULTI_LINE for ARIA searchbox role
1404         https://bugs.webkit.org/show_bug.cgi?id=164712
1405
1406         Reviewed by Chris Fleizach.
1407
1408         Add AccessibilityUIElement::isSingleLine, AccessibilityUIElement::isMultiLine
1409         to DRT and WKTR. Implement it for ATK.
1410
1411         * DumpRenderTree/AccessibilityUIElement.h:
1412         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1413         (AccessibilityUIElement::isSingleLine):
1414         (AccessibilityUIElement::isMultiLine):
1415         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1416         (AccessibilityUIElement::isSingleLine):
1417         (AccessibilityUIElement::isMultiLine):
1418         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1419         (AccessibilityUIElement::isSingleLine):
1420         (AccessibilityUIElement::isMultiLine):
1421         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1422         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1423         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1424         (WTR::AccessibilityUIElement::isSingleLine):
1425         (WTR::AccessibilityUIElement::isMultiLine):
1426         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1427         (WTR::AccessibilityUIElement::isSingleLine):
1428         (WTR::AccessibilityUIElement::isMultiLine):
1429         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1430         (WTR::AccessibilityUIElement::isSingleLine):
1431         (WTR::AccessibilityUIElement::isMultiLine):
1432
1433 2016-11-14  Youenn Fablet  <youenn@apple.com>
1434
1435         Support WPT templated tests
1436         https://bugs.webkit.org/show_bug.cgi?id=164707
1437
1438         Reviewed by Sam Weinig.
1439
1440         * Scripts/webkitpy/w3c/test_importer.py:
1441         (TestImporter.write_html_files_for_templated_js_tests): Generating empty HTML files for templated JS tests.
1442         (TestImporter.import_tests):
1443
1444 2016-11-13  JF Bastien  <jfbastien@apple.com>
1445
1446         Implement WTF::Expected
1447         https://bugs.webkit.org/show_bug.cgi?id=164526
1448
1449         Reviewed by Yusuke Suzuki.
1450
1451         std::expected isn't in C++17, and may be in C++20. It's a nice
1452         complement to std::any / std::optional because it's a type-tagged
1453         union which has a single expected result but could also contain an
1454         error.
1455
1456         This would be useful in the WebAssembly parser, for example.
1457
1458         Using this implementation will allow us to provide feedback to the
1459         standards committee and guide std::expected's design before it
1460         gets standardized. I've already sent a bunch of feedback to the
1461         author based on my experience implementing this.
1462
1463         This could supplement WTF::Either and WTF::ExceptionOr.
1464
1465         * TestWebKitAPI/CMakeLists.txt:
1466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1467         * TestWebKitAPI/Tests/WTF/Expected.cpp: Added.
1468         (WTF::operator<<):
1469         (TestWebKitAPI::TEST):
1470         (TestWebKitAPI::foo::foo):
1471         (TestWebKitAPI::foo::~foo):
1472         (TestWebKitAPI::foo::operator==):
1473         (TestWebKitAPI::operator<<):
1474
1475 2016-11-12  Simon Fraser  <simon.fraser@apple.com>
1476
1477         Add a way to get the UI-side scrolling tree as text via UIScriptController
1478         https://bugs.webkit.org/show_bug.cgi?id=164697
1479
1480         Reviewed by Zalan Bujtas.
1481
1482         Add UIScriptController::scrollingTreeAsText(), which gets the state of the scrolling
1483         tree in the UI process, including the current positions of CALayers. This will be used
1484         to test UI-side scrolling and visual viewports.
1485
1486         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1487         (WTR::UIScriptController::scrollingTreeAsText):
1488         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1489         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1490         (WTR::UIScriptController::scrollingTreeAsText):
1491         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1492         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1493         (WTR::UIScriptController::scrollingTreeAsText):
1494
1495 2016-11-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1496
1497         The main content heuristic should be robust when handling large media elements
1498         https://bugs.webkit.org/show_bug.cgi?id=164676
1499         <rdar://problem/29211503>
1500
1501         Reviewed by Eric Carlson.
1502
1503         Added a new test verifying that enormous video elements are handled gracefully when put through the main
1504         content heuristic.
1505
1506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1507         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1508         (TestWebKitAPI::TEST):
1509         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Added.
1510
1511 2016-11-12  Dan Bernstein  <mitz@apple.com>
1512
1513         run-safari does not work for open source contributors
1514         https://bugs.webkit.org/show_bug.cgi?id=164667
1515         <rdar://problem/29229894>
1516
1517         Reviewed by Joseph Pecoraro.
1518
1519         * Scripts/run-api-tests:
1520         (archCommandLineArgumentsForRestrictedEnvironmentVariables): Moved from here…
1521         * Scripts/webkitdirs.pm:
1522         (archCommandLineArgumentsForRestrictedEnvironmentVariables): …to here
1523         (runMacWebKitApp): Have arch(1) carry the DYLD_* variables we set in our environmet over
1524           to the environment of the app being run.
1525
1526 2016-11-11  Joseph Pecoraro  <pecoraro@apple.com>
1527
1528         Removed unused INCLUDE_OPTIONS_FOR_DEBUGGING
1529         https://bugs.webkit.org/show_bug.cgi?id=164664
1530
1531         Reviewed by Dan Bernstein.
1532
1533         * Scripts/debug-minibrowser:
1534         * Scripts/debug-safari:
1535         * Scripts/debug-test-runner:
1536         * Scripts/webkitdirs.pm:
1537         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
1538         There are no debug specific options anymore.
1539
1540 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1541
1542         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
1543         https://bugs.webkit.org/show_bug.cgi?id=164538
1544         <rdar://problem/8418711>
1545
1546         Reviewed by Ryosuke Niwa.
1547
1548         Adds support for being able to test autocorrect and autocapitalize attributes in contenteditable areas. To do
1549         this, we add removeAllDynamicDictionaries to UIScriptController in order to ensure that autocorrect suggestions
1550         are reset to their defaults prior to running contenteditable-autocorrect-off.html.
1551
1552         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1553         (WTR::UIScriptController::removeAllDynamicDictionaries):
1554         * Scripts/webkitpy/port/ios.py:
1555         (IOSSimulatorPort._createSimulatorApp):
1556         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1557         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1558         (WTR::UIScriptController::removeAllDynamicDictionaries):
1559         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1560         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1561         (-[TestRunnerWKWebView _keyboardDidShow:]):
1562         (-[TestRunnerWKWebView _keyboardDidHide:]):
1563
1564         Work around an issue where consecutive UIKeyboardDidShowNotification would cause keyboard appearance callbacks
1565         to be fired multiple times. This was causing a single key press to cause two characters to be typed. While this
1566         does not affect the correctness of existing tests, the new autocorrection test requires this workaround.
1567
1568         * WebKitTestRunner/ios/UIKitSPI.h:
1569         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1570         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1571         (WTR::UIScriptController::removeAllDynamicDictionaries):
1572
1573 2016-11-11  Alex Christensen  <achristensen@webkit.org>
1574
1575         Build all Mac API tests
1576         https://bugs.webkit.org/show_bug.cgi?id=164633
1577
1578         Reviewed by Gyuyoung Kim.
1579
1580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1581         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
1582
1583 2016-11-11  Alex Christensen  <achristensen@webkit.org>
1584
1585         Allow mutable lambdas in HashMap::ensure
1586         https://bugs.webkit.org/show_bug.cgi?id=164642
1587
1588         Reviewed by Sam Weinig.
1589
1590         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1591         (TestWebKitAPI::TEST):
1592
1593 2016-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1594
1595         Composition state should be cleared when changing focus to a non-editable element
1596         https://bugs.webkit.org/show_bug.cgi?id=164595
1597         <rdar://problem/26412551>
1598
1599         Reviewed by Enrica Casucci.
1600
1601         Adds support for window.textInputController in DumpRenderTree on iOS. So far, only the methods needed for the
1602         new layout test (editing/focus-change-with-marked-text.html) are supported. These are insertText, setMarkedText,
1603         and markedRange.
1604
1605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1606         * DumpRenderTree/TextInputController.h: Renamed from Tools/DumpRenderTree/mac/TextInputController.h.
1607
1608         Remove the PLATFORM(MAC) guard for defining the TextInputController. Also, move the TextInputController header
1609         out of the /mac platform directory.
1610
1611         * DumpRenderTree/ios/TextInputControllerIOS.m: Added.
1612         (+[TextInputController isSelectorExcludedFromWebScript:]):
1613         (+[TextInputController webScriptNameForSelector:]):
1614         (-[TextInputController initWithWebView:]):
1615         (-[TextInputController markedRange]):
1616         (-[TextInputController insertText:]):
1617         (-[TextInputController setMarkedText:selectedFrom:length:]):
1618
1619         Introduces TextInputControllerIOS.m, which contains an iOS implementation of TextInputController. Only a subset
1620         of the methods available on the Mac version will be available on iOS for now (see above).
1621
1622         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1623
1624         Remove the PLATFORM(MAC) guard for initializing the TextInputController and binding it to the window object.
1625
1626         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1627         * DumpRenderTree/mac/TextInputControllerMac.m: Renamed from Tools/DumpRenderTree/mac/TextInputController.m.
1628         (-[WebHTMLView interpretKeyEvents:]):
1629         (-[WebNSRange initWithNSRange:]):
1630         (-[WebNSRange location]):
1631         (-[WebNSRange length]):
1632         (+[WebNSRange isSelectorExcludedFromWebScript:]):
1633         (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
1634         (+[NSMutableAttributedString webScriptNameForSelector:]):
1635         (-[NSMutableAttributedString getLength]):
1636         (-[NSMutableAttributedString ranges]):
1637         (-[NSMutableAttributedString attributeNamesAtIndex:]):
1638         (-[NSMutableAttributedString valueOfAttribute:atIndex:]):
1639         (-[NSMutableAttributedString addAttribute:value:]):
1640         (-[NSMutableAttributedString addAttribute:value:from:length:]):
1641         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:]):
1642         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:from:length:]):
1643         (-[NSMutableAttributedString addFontAttribute:fontName:size:]):
1644         (-[NSMutableAttributedString addFontAttribute:fontName:size:from:length:]):
1645         (+[TextInputController isSelectorExcludedFromWebScript:]):
1646         (+[TextInputController webScriptNameForSelector:]):
1647         (-[TextInputController initWithWebView:]):
1648         (-[TextInputController dealloc]):
1649         (-[TextInputController textInput]):
1650         (-[TextInputController insertText:]):
1651         (-[TextInputController doCommand:]):
1652         (-[TextInputController setMarkedText:selectedFrom:length:]):
1653         (-[TextInputController unmarkText]):
1654         (-[TextInputController hasMarkedText]):
1655         (-[TextInputController conversationIdentifier]):
1656         (-[TextInputController substringFrom:length:]):
1657         (-[TextInputController attributedSubstringFrom:length:]):
1658         (-[TextInputController legacyAttributedString:]):
1659         (-[TextInputController markedRange]):
1660         (-[TextInputController selectedRange]):
1661         (-[TextInputController firstRectForCharactersFrom:length:]):
1662         (-[TextInputController characterIndexForPointX:Y:]):
1663         (-[TextInputController validAttributesForMarkedText]):
1664         (-[TextInputController attributedStringWithString:]):
1665         (-[TextInputController stringWithUndoGroupingInsertion:]):
1666         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
1667         (-[TextInputController setInputMethodHandler:]):
1668         (-[TextInputController interpretKeyEvents:withSender:]):
1669
1670         Fixes miscellaneous style issues.
1671
1672 2016-11-11  Philippe Normand  <pnormand@igalia.com>
1673
1674         [GTK][JHbuild] bump libnice version in openwebrtc.modules
1675         https://bugs.webkit.org/show_bug.cgi?id=164586
1676
1677         Reviewed by Michael Catanzaro.
1678
1679         Update to a recent libnice git snapshot and remove patches already
1680         upstream or not applying anymore. The patches not upstream yet
1681         will be reported in Phabricator.
1682
1683         * gtk/openwebrtc.modules:
1684         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Removed.
1685         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Removed.
1686         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Removed.
1687         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Removed.
1688         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Removed.
1689
1690 2016-11-10  Alex Christensen  <achristensen@webkit.org>
1691
1692         Fix assertion after r208534.
1693         https://bugs.webkit.org/show_bug.cgi?id=160497
1694
1695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1696         * TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
1697         (TestWebKitAPI::TEST):
1698         Add a regression test.
1699
1700 2016-11-10  Chris Dumez  <cdumez@apple.com>
1701
1702         REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
1703         https://bugs.webkit.org/show_bug.cgi?id=164570
1704
1705         Reviewed by Simon Fraser.
1706
1707         Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
1708         avoid flakiness.
1709
1710         * WebKitTestRunner/TestController.cpp:
1711         (WTR::TestController::resetStateToConsistentValues):
1712
1713 2016-11-10  Miguel Gomez  <magomez@igalia.com>
1714
1715         Unreviewed. Added myself to the list of committers.
1716
1717         * Scripts/webkitpy/common/config/contributors.json:
1718
1719 2016-10-27  Sergio Villar Senin  <svillar@igalia.com>
1720
1721         [GTK] New API to notify about dynamically added forms
1722         https://bugs.webkit.org/show_bug.cgi?id=164050
1723
1724         Reviewed by Carlos Garcia Campos.
1725
1726         Added a new test case to verify that dinamically added forms correctly trigger the
1727         "form-controls-associated" signal from WebPage.
1728
1729         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1730         (didAssociateFormControlsCallback):
1731         (testWebExtensionFormControlsAssociated):
1732         (beforeAll):
1733         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1734         (DelayedSignal::DelayedSignal):
1735         (emitFormControlsAssociated):
1736         (formControlsAssociatedCallback):
1737         (pageCreatedCallback):
1738
1739 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
1740
1741         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
1742         https://bugs.webkit.org/show_bug.cgi?id=164501
1743         <rdar://problem/29152282>
1744
1745         Reviewed by Sam Weinig.
1746
1747         * DumpRenderTree/mac/TextInputController.m:
1748         (-[TextInputController legacyAttributedString:]):
1749
1750 2016-11-09  Chris Dumez  <cdumez@apple.com>
1751
1752         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
1753         https://bugs.webkit.org/show_bug.cgi?id=164458
1754         <rdar://problem/28905514>
1755
1756         Reviewed by Darin Adler.
1757
1758         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
1759         tests can request that such resources are downloaded instead of being ignored.
1760
1761         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1762         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1763         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1764         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1765         * WebKitTestRunner/TestController.cpp:
1766         (WTR::TestController::decidePolicyForNavigationResponse):
1767         * WebKitTestRunner/TestController.h:
1768         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
1769         * WebKitTestRunner/TestInvocation.cpp:
1770         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1771
1772 2016-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1773
1774         NetworkSession: Network process crash when converting main resource to download
1775         https://bugs.webkit.org/show_bug.cgi?id=164220
1776
1777         Reviewed by Alex Christensen.
1778
1779         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
1780         converted to a download and another one to test the cancellation as the test was doing before. When doing the
1781         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
1782         download.
1783
1784         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1785         (testPolicyResponseDownload):
1786         (testPolicyResponseDownloadCancel):
1787         (beforeAll):
1788
1789 2016-11-09  KwangHyuk Kim  <hyuki.kim@samsung.com>
1790
1791         [EFL] fix error message caused by eina log
1792         https://bugs.webkit.org/show_bug.cgi?id=164546
1793
1794         Reviewed by Gyuyoung Kim.
1795
1796         Fix error message caused by eina log when MiniBrowser is working with help option.
1797
1798         * MiniBrowser/efl/main.c:
1799         (quit):
1800
1801 2016-11-09  Brent Fulgham  <bfulgham@apple.com>
1802
1803         Unreviewed build fix after r208509.
1804
1805         * DumpRenderTree/win/TestRunnerWin.cpp:
1806         (TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Add missing TestRunner implementation."
1807
1808 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1809
1810         Unreviewed, rolling out r208438.
1811
1812         crashes
1813
1814         Reverted changeset:
1815
1816         "[WK2][NETWORK_SESSION] Add support for downloading file
1817         backed blobs"
1818         https://bugs.webkit.org/show_bug.cgi?id=164458
1819         http://trac.webkit.org/changeset/208438
1820
1821 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
1822
1823         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
1824         https://bugs.webkit.org/show_bug.cgi?id=155185
1825         <rdar://problem/11101440>
1826
1827         Reviewed by Brady Eidson.
1828
1829         * DumpRenderTree/TestRunner.cpp:
1830         (setNeedsLocalStorageQuirkCallback): Added.
1831         (TestRunner::staticFunctions):
1832         * DumpRenderTree/TestRunner.h:
1833         * DumpRenderTree/mac/DumpRenderTree.mm:
1834         (resetWebPreferencesToConsistentValues): Update for new quirk setting.
1835         * DumpRenderTree/mac/TestRunnerMac.mm:
1836         (TestRunner::setNeedsLocalStorageQuirk):
1837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1838         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
1839         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1840         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm:
1841         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Added.
1842         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Added.
1843         (-[LocalStorageQuirkMessageHandler userContentController:didReceiveScriptMessage:]):
1844         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1845         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1846         (WTR::InjectedBundle::beginTesting): Update for new quirk setting.
1847         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1848         (WTR::TestRunner::setNeedsLocalStorageQuirk): Added.
1849         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1850
1851 2016-11-09  Alex Christensen  <achristensen@webkit.org>
1852
1853         URLParser should not consider path of URLs with no host to start at the first slash after the colon
1854         https://bugs.webkit.org/show_bug.cgi?id=164555
1855
1856         Reviewed by Tim Horton.
1857
1858         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1859         (TestWebKitAPI::TEST_F):
1860
1861 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
1862
1863         test-webkitpy failing test_create_patch_is_full_patch unit test
1864         https://bugs.webkit.org/show_bug.cgi?id=164385
1865
1866         Reviewed by Darin Adler.
1867
1868         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Fixed expected output to match output.
1869
1870 2016-11-09  Chris Dumez  <cdumez@apple.com>
1871
1872         [Mac] Stop using deprecated AppKit enumeration values
1873         https://bugs.webkit.org/show_bug.cgi?id=164494
1874
1875         Reviewed by Darin Adler.
1876
1877         Stop using deprecated AppKit enumeration values.
1878
1879         * DumpRenderTree/mac/EventSendingController.mm:
1880         (eventTypeForMouseButtonAndAction):
1881         (modifierFlags):
1882         (-[EventSendingController mouseMoveToX:Y:]):
1883         (-[EventSendingController contextClick]):
1884         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1885         * DumpRenderTree/mac/TextInputController.m:
1886         (-[TextInputController interpretKeyEvents:withSender:]):
1887         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
1888         (simulateCommandArrow):
1889         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1890         (TestWebKitAPI::TEST):
1891         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm:
1892         (TestWebKitAPI::TEST):
1893         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1894         (TestWebKitAPI::TEST):
1895         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1896         (TEST):
1897         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm:
1898         (UserInitiatedActionTest::SetUp):
1899         (UserInitiatedActionTest::click):
1900         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1901         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1902         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1903         (TestWebKitAPI::contextMenuCopyLink):
1904         (TestWebKitAPI::TEST):
1905         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
1906         (TestWebKitAPI::TEST):
1907         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1908         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1909         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1910         (TestWebKitAPI::TEST):
1911         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1912         (TestWebKitAPI::Util::isKeyDown):
1913         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1914         (TestWebKitAPI::PlatformWebView::initialize):
1915         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
1916         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1917         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1918         (TestWebKitAPI::eventTypeForButton):
1919         (TestWebKitAPI::modifierFlagsForWKModifiers):
1920         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
1921         (__simulated_forceClickAssociatedEventsMask):
1922         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1923         (-[TestWKWebView _setUpTestWindow:]):
1924         (-[TestWKWebView typeCharacter:]):
1925         * WebKitTestRunner/mac/EventSenderProxy.mm:
1926         (WTR::eventTypeForMouseButtonAndAction):
1927         (WTR::buildModifierFlags):
1928         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
1929         (WTR::EventSenderProxy::mouseForceClick):
1930         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
1931         (WTR::EventSenderProxy::mouseMoveTo):
1932         (WTR::EventSenderProxy::keyDown):
1933         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1934         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1935         (WTR::PlatformWebView::PlatformWebView):
1936         * WebKitTestRunner/mac/TestControllerMac.mm:
1937         (WTR::TestController::platformResetStateToConsistentValues):
1938
1939 2016-11-09  Beth Dakin  <bdakin@apple.com>
1940
1941         Support TouchBar in WebKit
1942         https://bugs.webkit.org/show_bug.cgi?id=164437
1943         -and corresponding-
1944         rdar://problem/28876524
1945
1946         Reviewed by Darin Adler.
1947
1948         This makes MiniBrowser support TouchBar customization. 
1949
1950         * MiniBrowser/mac/AppDelegate.m:
1951         (-[BrowserAppDelegate awakeFromNib]):
1952
1953 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1954
1955         [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest
1956         https://bugs.webkit.org/show_bug.cgi?id=164461
1957
1958         Reviewed by Michael Catanzaro.
1959
1960         As GTK port in r208297, EFL port starts to use libgcrypt instead of GnuTLS as well.
1961
1962         * efl/install-dependencies: Add libgcript package dependecy.
1963
1964 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1965
1966         [EFL] Remove unused function in MiniBrowser
1967         https://bugs.webkit.org/show_bug.cgi?id=164398
1968
1969         Reviewed by Darin Adler.
1970
1971         * MiniBrowser/efl/main.c:
1972         (window_find_with_elm_window): Deleted because it is not used anywhere.
1973
1974 2016-11-09  Chris Dumez  <cdumez@apple.com>
1975
1976         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
1977         https://bugs.webkit.org/show_bug.cgi?id=164458
1978         <rdar://problem/28905514>
1979
1980         Reviewed by Darin Adler.
1981
1982         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
1983         tests can request that such resources are downloaded instead of being ignored.
1984
1985         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1986         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1987         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1988         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1989         * WebKitTestRunner/TestController.cpp:
1990         (WTR::TestController::decidePolicyForNavigationResponse):
1991         * WebKitTestRunner/TestController.h:
1992         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
1993         * WebKitTestRunner/TestInvocation.cpp:
1994         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1995
1996 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
1997
1998         Make rpaths more robust for iOS Simulators
1999         https://bugs.webkit.org/show_bug.cgi?id=164521
2000
2001         Reviewed by Simon Fraser.
2002
2003         * Scripts/webkitpy/port/ios.py:
2004         (IOSSimulatorPort._createSimulatorApp): Added more robust path.
2005
2006 2016-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2007
2008         Fix Tools build on case sensitive file systems
2009         https://bugs.webkit.org/show_bug.cgi?id=164474
2010
2011         Unreviewed buildfix.
2012
2013         * DumpRenderTree/CMakeLists.txt:
2014         * DumpRenderTree/PlatformMac.cmake:
2015         * DumpRenderTree/PlatformWin.cmake:
2016         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2017         * MiniBrowser/mac/CMakeLists.txt:
2018
2019 2016-11-04  Filip Pizlo  <fpizlo@apple.com>
2020
2021         WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows
2022         https://bugs.webkit.org/show_bug.cgi?id=152045
2023
2024         Reviewed by Andy Estes.
2025
2026         * TestWebKitAPI/CMakeLists.txt:
2027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2028         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2029         (TestWebKitAPI::TEST):
2030         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
2031         (TestWebKitAPI::ToUpperConverter::stopProducing):
2032         (TestWebKitAPI::ToUpperConverter::stopConsuming):
2033         * TestWebKitAPI/Tests/WTF/Time.cpp: Added.
2034         (WTF::operator<<):
2035         (TestWebKitAPI::TEST):
2036
2037 2016-11-04  Alex Christensen  <achristensen@webkit.org>
2038
2039         Unreviewed, rolling out r208293.
2040
2041         asserts in API tests.
2042
2043         Reverted changeset:
2044
2045         "NetworkSession: Network process crash when converting main
2046         resource to download"
2047         https://bugs.webkit.org/show_bug.cgi?id=164220
2048         http://trac.webkit.org/changeset/208293
2049
2050 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2051
2052         Add a setting and preferences to enable/disable async image decoding
2053         https://bugs.webkit.org/show_bug.cgi?id=164417
2054
2055         Reviewed by Simon Fraser.
2056
2057         Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
2058
2059         * MiniBrowser/mac/SettingsController.h:
2060         * MiniBrowser/mac/SettingsController.m:
2061         (-[SettingsController _populateMenu]):
2062         (-[SettingsController validateMenuItem:]):
2063         (-[SettingsController toggleAsyncImageDecodingEnabled:]):
2064         (-[SettingsController asyncImageDecodingEnabled]):
2065         * MiniBrowser/mac/WK1BrowserWindowController.m:
2066         (-[WK1BrowserWindowController didChangeSettings]):
2067         * MiniBrowser/mac/WK2BrowserWindowController.m:
2068         (-[WK2BrowserWindowController didChangeSettings]):
2069
2070 2016-11-04  Brady Eidson  <beidson@apple.com>
2071
2072         REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
2073         https://bugs.webkit.org/show_bug.cgi?id=164390
2074
2075         Reviewed by Geoffrey Garen.
2076
2077         Operating under the assumption that the behavior change is okay/desirable, this updates the test.
2078
2079         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2080         (TestWebKitAPI::TEST):
2081
2082 2016-11-04  Joanmarie Diggs  <jdiggs@igalia.com>
2083
2084         AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash
2085         https://bugs.webkit.org/show_bug.cgi?id=164331
2086
2087         Reviewed by Chris Fleizach.
2088
2089         Add AccessibilityUIElement::clearSelectedChildren() to DRT and WKTR.
2090         Implement it for ATK.
2091
2092         * DumpRenderTree/AccessibilityUIElement.h:
2093         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2094         (AccessibilityUIElement::clearSelectedChildren):
2095         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2096         (AccessibilityUIElement::clearSelectedChildren):
2097         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2098         (AccessibilityUIElement::clearSelectedChildren):
2099         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2100         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2101         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2102         (WTR::AccessibilityUIElement::clearSelectedChildren):
2103         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2104         (WTR::AccessibilityUIElement::clearSelectedChildren):
2105         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2106         (WTR::AccessibilityUIElement::clearSelectedChildren):
2107
2108 2016-11-04  Per Arne Vollan  <pvollan@apple.com>
2109
2110         [Win] Page visibility tests are timing out.
2111         https://bugs.webkit.org/show_bug.cgi?id=164363
2112
2113         Reviewed by Brent Fulgham.
2114
2115         Implement methods to set page visibility.
2116
2117         * DumpRenderTree/win/TestRunnerWin.cpp:
2118         (TestRunner::resetPageVisibility):
2119         (TestRunner::setPageVisibility):
2120
2121 2016-11-03  Simon Fraser  <simon.fraser@apple.com>
2122
2123         Give all the geometry classes a single-argument scale() function for consistency
2124         https://bugs.webkit.org/show_bug.cgi?id=164400
2125
2126         Reviewed by Zalan Bujtas.
2127         
2128         Test single-argument scale().
2129
2130         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp:
2131         (TestWebKitAPI::TEST):
2132
2133 2016-11-03  Chris Dumez  <cdumez@apple.com>
2134
2135         [WK2][Cocoa] Implement user interface for HTML form validation
2136         https://bugs.webkit.org/show_bug.cgi?id=164143
2137         <rdar://problem/28944652>
2138
2139         Reviewed by Simon Fraser.
2140
2141         Add support for UIScriptController::contentsOfUserInterfaceItem("validationBubble")
2142         on both Mac and iOS to retrieve the currently displayed validation message.
2143
2144         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2145         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2146         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2147         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2148         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2149         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2150         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2151
2152 2016-11-03  Konstantin Tokarev  <annulen@yandex.ru>
2153
2154         Fixes to build JSCOnly on macOS
2155         https://bugs.webkit.org/show_bug.cgi?id=164379
2156
2157         Reviewed by Michael Catanzaro.
2158
2159         * TestWebKitAPI/PlatformJSCOnly.cmake: Moved BUILDING_JSCONLY__
2160         definition to OptionsJSCOnly.cmake
2161
2162 2016-11-03  Dan Bernstein  <mitz@apple.com>
2163
2164         WKWebView’s _observedRenderingProgressEvents not restored after web process crash
2165         https://bugs.webkit.org/show_bug.cgi?id=164368
2166         <rdar://problem/29091954>
2167
2168         Reviewed by Anders Carlsson.
2169
2170         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2171         * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Added.
2172         (TEST):
2173
2174 2016-11-03  Alex Christensen  <achristensen@webkit.org>
2175
2176         Purge PassRefPtr from Tools
2177         https://bugs.webkit.org/show_bug.cgi?id=164358
2178
2179         Reviewed by Michael Catanzaro.
2180
2181         * ImageDiff/efl/ImageDiff.cpp:
2182         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
2183         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2184         (WTR::AccessibilityController::create):
2185         (WTR::AccessibilityController::rootElement):
2186         (WTR::AccessibilityController::focusedElement):
2187         (WTR::AccessibilityController::elementAtPoint):
2188         (WTR::AccessibilityController::addNotificationListener): Deleted.
2189         (WTR::AccessibilityController::removeNotificationListener): Deleted.
2190         (WTR::AccessibilityController::accessibleElementById): Deleted.
2191         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2192         (WTR::AccessibilityController::resetToConsistentState): Deleted.
2193         (WTR::AccessibilityController::platformName): Deleted.
2194         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2195         (WTR::AccessibilityController::logAccessibilityEvents):
2196         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2197         (WTR::AccessibilityTextMarker::create):
2198         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h:
2199         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2200         (WTR::AccessibilityTextMarkerRange::create):
2201         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h:
2202         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2203         (WTR::AccessibilityUIElement::create):
2204         (WTR::AccessibilityUIElement::linkedElement):
2205         (WTR::AccessibilityUIElement::headerElementAtIndex):
2206         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2207         (WTR::AccessibilityUIElement::characterAtOffset):
2208         (WTR::AccessibilityUIElement::wordAtOffset):
2209         (WTR::AccessibilityUIElement::lineAtOffset):
2210         (WTR::AccessibilityUIElement::sentenceAtOffset):
2211         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2212         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2213         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2214         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2215         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2216         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2217         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2218         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2219         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2220         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2221         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2222         (WTR::AccessibilityUIElement::AccessibilityUIElement): Deleted.
2223         (WTR::AccessibilityUIElement::~AccessibilityUIElement): Deleted.
2224         (WTR::AccessibilityUIElement::isEqual): Deleted.
2225         (WTR::AccessibilityUIElement::elementAtPoint): Deleted.
2226         (WTR::AccessibilityUIElement::childAtIndex): Deleted.
2227         (WTR::AccessibilityUIElement::indexOfChild): Deleted.
2228         (WTR::AccessibilityUIElement::childrenCount): Deleted.
2229         (WTR::AccessibilityUIElement::titleUIElement): Deleted.
2230         (WTR::AccessibilityUIElement::parentElement): Deleted.
2231         (WTR::AccessibilityUIElement::takeFocus): Deleted.
2232         (WTR::AccessibilityUIElement::takeSelection): Deleted.
2233         (WTR::AccessibilityUIElement::addSelection): Deleted.
2234         (WTR::AccessibilityUIElement::removeSelection): Deleted.
2235         (WTR::AccessibilityUIElement::allAttributes): Deleted.
2236         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements): Deleted.
2237         (WTR::AccessibilityUIElement::linkedUIElementAtIndex): Deleted.
2238         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Deleted.
2239         (WTR::AccessibilityUIElement::attributesOfChildren): Deleted.
2240         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Deleted.
2241         (WTR::AccessibilityUIElement::increment): Deleted.
2242         (WTR::AccessibilityUIElement::decrement): Deleted.
2243         (WTR::AccessibilityUIElement::showMenu): Deleted.
2244         (WTR::AccessibilityUIElement::press): Deleted.
2245         (WTR::AccessibilityUIElement::stringAttributeValue): Deleted.
2246         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): Deleted.
2247         (WTR::AccessibilityUIElement::uiElementAttributeValue): Deleted.
2248         (WTR::AccessibilityUIElement::numberAttributeValue): Deleted.
2249         (WTR::AccessibilityUIElement::boolAttributeValue): Deleted.
2250         (WTR::AccessibilityUIElement::isAttributeSupported): Deleted.
2251         (WTR::AccessibilityUIElement::isAttributeSettable): Deleted.
2252         (WTR::AccessibilityUIElement::isPressActionSupported): Deleted.
2253         (WTR::AccessibilityUIElement::isIncrementActionSupported): Deleted.
2254         (WTR::AccessibilityUIElement::isDecrementActionSupported): Deleted.
2255         (WTR::AccessibilityUIElement::role): Deleted.
2256         (WTR::AccessibilityUIElement::subrole): Deleted.
2257         (WTR::AccessibilityUIElement::roleDescription): Deleted.
2258         (WTR::AccessibilityUIElement::computedRoleString): Deleted.
2259         (WTR::AccessibilityUIElement::title): Deleted.
2260         (WTR::AccessibilityUIElement::description): Deleted.
2261         (WTR::AccessibilityUIElement::language): Deleted.
2262         (WTR::AccessibilityUIElement::stringValue): Deleted.
2263         (WTR::AccessibilityUIElement::accessibilityValue): Deleted.
2264         (WTR::AccessibilityUIElement::helpText): Deleted.
2265         (WTR::AccessibilityUIElement::orientation): Deleted.
2266         (WTR::AccessibilityUIElement::x): Deleted.
2267         (WTR::AccessibilityUIElement::y): Deleted.
2268         (WTR::AccessibilityUIElement::width): Deleted.
2269         (WTR::AccessibilityUIElement::height): Deleted.
2270         (WTR::AccessibilityUIElement::intValue): Deleted.
2271         (WTR::AccessibilityUIElement::minValue): Deleted.
2272         (WTR::AccessibilityUIElement::maxValue): Deleted.
2273         (WTR::AccessibilityUIElement::valueDescription): Deleted.
2274         (WTR::AccessibilityUIElement::insertionPointLineNumber): Deleted.
2275         (WTR::AccessibilityUIElement::selectedTextRange): Deleted.
2276         (WTR::AccessibilityUIElement::isEnabled): Deleted.
2277         (WTR::AccessibilityUIElement::isRequired): Deleted.
2278         (WTR::AccessibilityUIElement::isFocused): Deleted.
2279         (WTR::AccessibilityUIElement::isFocusable): Deleted.
2280         (WTR::AccessibilityUIElement::isSelected): Deleted.
2281         (WTR::AccessibilityUIElement::isSelectedOptionActive): Deleted.
2282         (WTR::AccessibilityUIElement::isSelectable): Deleted.
2283         (WTR::AccessibilityUIElement::isMultiSelectable): Deleted.
2284         (WTR::AccessibilityUIElement::setSelectedChild): Deleted.
2285         (WTR::AccessibilityUIElement::setSelectedChildAtIndex): Deleted.
2286         (WTR::AccessibilityUIElement::removeSelectionAtIndex): Deleted.
2287         (WTR::AccessibilityUIElement::selectedChildrenCount): Deleted.
2288         (WTR::AccessibilityUIElement::selectedChildAtIndex): Deleted.
2289         (WTR::AccessibilityUIElement::isExpanded): Deleted.
2290         (WTR::AccessibilityUIElement::isChecked): Deleted.
2291         (WTR::AccessibilityUIElement::isIndeterminate): Deleted.
2292         (WTR::AccessibilityUIElement::isVisible): Deleted.
2293         (WTR::AccessibilityUIElement::isOffScreen): Deleted.
2294         (WTR::AccessibilityUIElement::isCollapsed): Deleted.
2295         (WTR::AccessibilityUIElement::isIgnored): Deleted.
2296         (WTR::AccessibilityUIElement::hasPopup): Deleted.
2297         (WTR::AccessibilityUIElement::hierarchicalLevel): Deleted.
2298         (WTR::AccessibilityUIElement::clickPointX): Deleted.
2299         (WTR::AccessibilityUIElement::clickPointY): Deleted.
2300         (WTR::AccessibilityUIElement::documentEncoding): Deleted.
2301         (WTR::AccessibilityUIElement::documentURI): Deleted.
2302         (WTR::AccessibilityUIElement::url): Deleted.
2303         (WTR::AccessibilityUIElement::speak): Deleted.
2304         (WTR::AccessibilityUIElement::attributesOfColumnHeaders): Deleted.
2305         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Deleted.
2306         (WTR::AccessibilityUIElement::attributesOfColumns): Deleted.
2307         (WTR::AccessibilityUIElement::attributesOfRows): Deleted.
2308         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Deleted.
2309         (WTR::AccessibilityUIElement::attributesOfHeader): Deleted.
2310         (WTR::AccessibilityUIElement::indexInTable): Deleted.
2311         (WTR::AccessibilityUIElement::rowIndexRange): Deleted.
2312         (WTR::AccessibilityUIElement::columnIndexRange): Deleted.
2313         (WTR::AccessibilityUIElement::rowCount): Deleted.
2314         (WTR::AccessibilityUIElement::columnCount): Deleted.
2315         (WTR::AccessibilityUIElement::rowHeaders): Deleted.
2316         (WTR::AccessibilityUIElement::columnHeaders): Deleted.
2317         (WTR::AccessibilityUIElement::selectedRowAtIndex): Deleted.
2318         (WTR::AccessibilityUIElement::disclosedByRow): Deleted.
2319         (WTR::AccessibilityUIElement::disclosedRowAtIndex): Deleted.
2320         (WTR::AccessibilityUIElement::rowAtIndex): Deleted.
2321         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Deleted.
2322         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): Deleted.
2323         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): Deleted.
2324         (WTR::AccessibilityUIElement::ariaIsGrabbed): Deleted.
2325         (WTR::AccessibilityUIElement::ariaDropEffects): Deleted.
2326         (WTR::AccessibilityUIElement::classList): Deleted.
2327         (WTR::AccessibilityUIElement::lineForIndex): Deleted.
2328         (WTR::AccessibilityUIElement::rangeForLine): Deleted.
2329         (WTR::AccessibilityUIElement::rangeForPosition): Deleted.
2330         (WTR::AccessibilityUIElement::boundsForRange): Deleted.
2331         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
2332         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
2333         (WTR::AccessibilityUIElement::stringForRange): Deleted.
2334         (WTR::AccessibilityUIElement::attributedStringForRange): Deleted.
2335         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): Deleted.
2336         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): Deleted.
2337         (WTR::AccessibilityUIElement::uiElementForSearchPredicate): Deleted.
2338         (WTR::AccessibilityUIElement::selectTextWithCriteria): Deleted.
2339         (WTR::AccessibilityUIElement::cellForColumnAndRow): Deleted.
2340         (WTR::AccessibilityUIElement::horizontalScrollbar): Deleted.
2341         (WTR::AccessibilityUIElement::verticalScrollbar): Deleted.
2342         (WTR::AccessibilityUIElement::addNotificationListener): Deleted.
2343         (WTR::AccessibilityUIElement::removeNotificationListener): Deleted.
2344         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Deleted.
2345         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Deleted.
2346         (WTR::AccessibilityUIElement::textMarkerRangeLength): Deleted.
2347         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Deleted.
2348         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Deleted.
2349         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Deleted.
2350         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Deleted.
2351         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Deleted.
2352         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Deleted.
2353         (WTR::AccessibilityUIElement::textMarkerForPoint): Deleted.
2354         (WTR::AccessibilityUIElement::previousTextMarker): Deleted.
2355         (WTR::AccessibilityUIElement::nextTextMarker): Deleted.
2356         (WTR::AccessibilityUIElement::startTextMarker): Deleted.
2357         (WTR::AccessibilityUIElement::endTextMarker): Deleted.
2358         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Deleted.
2359         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Deleted.
2360         (WTR::AccessibilityUIElement::indexForTextMarker): Deleted.
2361         (WTR::AccessibilityUIElement::isTextMarkerValid): Deleted.
2362         (WTR::AccessibilityUIElement::textMarkerForIndex): Deleted.
2363         (WTR::AccessibilityUIElement::scrollToMakeVisible): Deleted.
2364         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Deleted.
2365         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): Deleted.
2366         (WTR::AccessibilityUIElement::supportedActions): Deleted.
2367         (WTR::AccessibilityUIElement::mathPostscriptsDescription): Deleted.
2368         (WTR::AccessibilityUIElement::mathPrescriptsDescription): Deleted.
2369         (WTR::AccessibilityUIElement::pathDescription): Deleted.
2370         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2371         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2372         (WTR::EventSendingController::create):
2373         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2374         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2375         (WTR::GCController::create):
2376         * WebKitTestRunner/InjectedBundle/GCController.h:
2377         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2378         (WTR::InjectedBundle::beginTesting):
2379         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2380         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2381         (WTR::TestRunner::create):
2382         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2383         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2384         (WTR::TextInputController::create):
2385         * WebKitTestRunner/InjectedBundle/TextInputController.h:
2386         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2387         (WTR::AccessibilityController::accessibleElementById):
2388         (WTR::AccessibilityController::rootElement):
2389         (WTR::AccessibilityController::focusedElement):
2390         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2391         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
2392         (WTR::AccessibilityNotificationHandler::create):
2393         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2394         (WTR::AccessibilityUIElement::elementAtPoint):
2395         (WTR::AccessibilityUIElement::childAtIndex):
2396         (WTR::accessibilityElementAtIndex):
2397         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2398         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2399         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2400         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2401         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2402         (WTR::AccessibilityUIElement::rowAtIndex):
2403         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2404         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2405         (WTR::AccessibilityUIElement::titleUIElement):
2406         (WTR::AccessibilityUIElement::parentElement):
2407         (WTR::AccessibilityUIElement::disclosedByRow):
2408         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2409         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2410         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2411         (WTR::AccessibilityUIElement::horizontalScrollbar):
2412         (WTR::AccessibilityUIElement::verticalScrollbar):
2413         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2414         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2415         (WTR::AccessibilityUIElement::previousTextMarker):
2416         (WTR::AccessibilityUIElement::nextTextMarker):
2417         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2418         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2419         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2420         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2421         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2422         (WTR::AccessibilityUIElement::textMarkerForPoint):
2423         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2424         (WTR::AccessibilityUIElement::textMarkerForIndex):
2425         (WTR::AccessibilityUIElement::startTextMarker):
2426         (WTR::AccessibilityUIElement::endTextMarker):
2427         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2428         (WTR::AccessibilityController::accessibleElementById):
2429         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2430         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2431         (WTR::AccessibilityUIElement::headerElementAtIndex):
2432         (WTR::AccessibilityUIElement::linkedElement):
2433         (WTR::AccessibilityUIElement::elementAtPoint):
2434         (WTR::AccessibilityUIElement::childAtIndex):
2435         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2436         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2437         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2438         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2439         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2440         (WTR::AccessibilityUIElement::rowAtIndex):
2441         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2442         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2443         (WTR::AccessibilityUIElement::titleUIElement):
2444         (WTR::AccessibilityUIElement::parentElement):
2445         (WTR::AccessibilityUIElement::disclosedByRow):
2446         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2447         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2448         (WTR::AccessibilityUIElement::rangeForLine):
2449         (WTR::AccessibilityUIElement::rangeForPosition):
2450         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2451         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2452         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2453         (WTR::AccessibilityUIElement::horizontalScrollbar):
2454         (WTR::AccessibilityUIElement::verticalScrollbar):
2455         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2456         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2457         (WTR::AccessibilityUIElement::previousTextMarker):
2458         (WTR::AccessibilityUIElement::nextTextMarker):
2459         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2460         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2461         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2462         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2463         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2464         (WTR::AccessibilityUIElement::textMarkerForPoint):
2465         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2466         (WTR::AccessibilityUIElement::textMarkerForIndex):
2467         (WTR::AccessibilityUIElement::startTextMarker):
2468         (WTR::AccessibilityUIElement::endTextMarker):
2469         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2470         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2471         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2472         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2473         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2474         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2475         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2476         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2477         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2478         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2479         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2480         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2481         (WTR::AccessibilityUIElement::supportedActions):
2482         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2483         (WTR::AccessibilityController::accessibleElementById):
2484         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2485         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2486         (makeValueRefForValue):
2487         (-[AccessibilityNotificationHandler _notificationReceived:]):
2488         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2489         (WTR::AccessibilityUIElement::elementAtPoint):
2490         (WTR::AccessibilityUIElement::childAtIndex):
2491         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2492         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2493         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2494         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2495         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2496         (WTR::AccessibilityUIElement::rowAtIndex):
2497         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2498         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2499         (WTR::AccessibilityUIElement::titleUIElement):
2500         (WTR::AccessibilityUIElement::parentElement):
2501         (WTR::AccessibilityUIElement::disclosedByRow):
2502         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2503         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2504         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2505         (WTR::AccessibilityUIElement::horizontalScrollbar):
2506         (WTR::AccessibilityUIElement::verticalScrollbar):
2507         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2508         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2509         (WTR::AccessibilityUIElement::previousTextMarker):
2510         (WTR::AccessibilityUIElement::nextTextMarker):
2511         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2512         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2513         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2514         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2515         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2516         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2517         (WTR::AccessibilityUIElement::textMarkerForPoint):
2518         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2519         (WTR::AccessibilityUIElement::textMarkerForIndex):
2520         (WTR::AccessibilityUIElement::startTextMarker):
2521         (WTR::AccessibilityUIElement::endTextMarker):
2522         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2523         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2524         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2525         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2526         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2527         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2528         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2529         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2530         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2531         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2532         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2533         (WTR::keyPadName):
2534         (WTR::keyName):
2535
2536 2016-11-02  Alex Christensen  <achristensen@webkit.org>
2537
2538         Remove Battery Status API from the tree
2539         https://bugs.webkit.org/show_bug.cgi?id=164213
2540
2541         Reviewed by Sam Weinig.
2542
2543         * Scripts/webkitperl/FeatureList.pm:
2544         * Scripts/webkitpy/common/config/watchlist:
2545
2546 2016-11-02  Olivier Blin  <olivier.blin@softathome.com>
2547
2548         [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation
2549         https://bugs.webkit.org/show_bug.cgi?id=163125
2550
2551         Reviewed by Michael Catanzaro.
2552
2553         * gtk/install-dependencies: List libgcrypt for WebKitGTK+ build, and gnutls for jhbuild only.
2554         gnutls is useful for glib-networking in jhbuild.
2555
2556 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2557
2558         NetworkSession: Network process crash when converting main resource to download
2559         https://bugs.webkit.org/show_bug.cgi?id=164220
2560
2561         Reviewed by Alex Christensen.
2562
2563         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
2564         converted to a download and another one to test the cancellation as the test was doing before. When doing the
2565         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
2566         download.
2567
2568         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2569         (testPolicyResponseDownload):
2570         (testPolicyResponseDownloadCancel):
2571         (beforeAll):
2572
2573 2016-11-01  Alex Christensen  <achristensen@webkit.org>
2574
2575         Remove PassRefPtr from DumpRenderTree
2576         https://bugs.webkit.org/show_bug.cgi?id=164307
2577
2578         Reviewed by Sam Weinig.
2579
2580         * DumpRenderTree/PixelDumpSupport.h:
2581         * DumpRenderTree/TestRunner.cpp:
2582         (TestRunner::create):
2583         * DumpRenderTree/TestRunner.h:
2584         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2585         (createBitmapContext):
2586         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2587         (BitmapContext::createByAdoptingBitmapAndContext):
2588         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2589         (createBitmapContextFromWebView):
2590         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2591         (createBitmapContextFromWebView):
2592         (createPagedBitmapContext):
2593         * DumpRenderTree/mac/TestRunnerMac.mm:
2594         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2595         (createBitmapContextFromWebView):
2596         * DumpRenderTree/win/TextInputController.h:
2597
2598 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2599
2600         [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp
2601         https://bugs.webkit.org/show_bug.cgi?id=161481
2602
2603         Reviewed by Michael Catanzaro.
2604
2605         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
2606         (WebKitTestBus::WebKitTestBus):
2607         (WebKitTestBus::~WebKitTestBus):
2608         (WebKitTestBus::run):
2609         (WebKitTestBus::getOrCreateConnection):
2610         (WebKitTestBus::createProxy):
2611         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
2612
2613 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2614
2615         Unreviewed. Fix /webkit2/WebKitWebContext/get-plugins in the bots after r208273.
2616
2617         The test fails now if WEBKIT_TEST_PLUGIN_DIR contains symlinks, which is the case of the GTK+ bots.
2618
2619         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2620         (testWebContextGetPlugins): Use realpath with WEBKIT_TEST_PLUGIN_DIR when building the expected plugins path.
2621
2622 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2623
2624         [Readable Streams API] Enable creation of ReadableByteStreamController
2625         https://bugs.webkit.org/show_bug.cgi?id=164014
2626
2627         Reviewed by Youenn Fablet.
2628
2629         Enable the byte stream part of Readable Streams API by default.
2630
2631         * Scripts/webkitperl/FeatureList.pm:
2632         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2633
2634 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
2635
2636         Remove CUSTOM_ELEMENTS build flag
2637         https://bugs.webkit.org/show_bug.cgi?id=164267
2638
2639         Reviewed by Antti Koivisto.
2640
2641         Removed the build flag.
2642
2643         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2644
2645 2016-11-01  Alex Christensen  <achristensen@webkit.org>
2646
2647         Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
2648         https://bugs.webkit.org/show_bug.cgi?id=164290
2649
2650         Reviewed by Tim Horton.
2651
2652         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2653         (TestWebKitAPI::checkRelativeURL):
2654         (TestWebKitAPI::checkURLDifferences):
2655         (TestWebKitAPI::checkRelativeURLDifferences):
2656         Move helper functions to the top so I can use them from any tests.
2657         (TestWebKitAPI::shouldFail):
2658         (TestWebKitAPI::checkURL):
2659         (TestWebKitAPI::TEST_F):
2660
2661 2016-11-01  Hyowon Kim  <hw1008.kim@samsung.com>
2662
2663         [GTK] Failed to generate GeoClue2Interface files.
2664         https://bugs.webkit.org/show_bug.cgi?id=164270
2665
2666         Reviewed by Michael Catanzaro.
2667
2668         To generate codes for D-Bus interfaces,
2669         geoclue-2.0 package including D-Bus introspection XML files should be installed.
2670
2671         * gtk/install-dependencies: add geoclue-2.0 package.
2672
2673 2016-11-01  Fujii Hironori  <Hironori.Fujii@sony.com>
2674
2675         [CMake] generate-bindings-all.pl uses USES_TERMINAL which leaves a noisy line in interactive Ninja build
2676         https://bugs.webkit.org/show_bug.cgi?id=163868
2677
2678         Reviewed by Michael Catanzaro.
2679
2680         It takes long time for generate-bindings-all.pl to generate all
2681         bindings.  So, it shows the progress while running and
2682         USES_TERMINAL option of add_custom_target have been used to invoke
2683         the command.  However, USES_TERMINAL leaves a noisy line in
2684         Ninja's neat build log of interactive build.
2685
2686         A new CMake option SHOW_BINDINGS_GENERATION_PROGRESS is added to
2687         stop using USES_TERMINAL only in case of interactive Ninja build.
2688
2689         * Scripts/webkitdirs.pm:
2690         (generateBuildSystemFromCMakeProject): Enable
2691         SHOW_BINDINGS_GENERATION_PROGRESS not in case of interactive
2692         Ninja build.
2693
2694 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
2695
2696         Add basic visual/layout viewport support for fixed position layout
2697         https://bugs.webkit.org/show_bug.cgi?id=164261
2698
2699         Reviewed by Dean Jackson.
2700
2701         Don't give tests in the "visual-viewport" directory a flexible viewport.
2702
2703         * DumpRenderTree/mac/DumpRenderTree.mm:
2704         (shouldMakeViewportFlexible):
2705         * WebKitTestRunner/TestOptions.cpp:
2706         (WTR::shouldMakeViewportFlexible):
2707
2708 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
2709
2710         JSC should support SharedArrayBuffer
2711         https://bugs.webkit.org/show_bug.cgi?id=163986
2712
2713         Reviewed by Keith Miller.
2714         
2715         Use the right kind of typed array API.
2716
2717         * DumpRenderTree/TestRunner.cpp:
2718         (setAudioResultCallback):
2719
2720 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
2721
2722         Make UIScriptController::zoomToScale() work on Mac WK1 and WK2
2723         https://bugs.webkit.org/show_bug.cgi?id=164238
2724
2725         Reviewed by Dean Jackson.
2726
2727         Implement UIScriptController::zoomToScale() for WTR and DRT on Mac.
2728
2729         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2730         (WTR::UIScriptController::zoomToScale):
2731         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2732         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2733         (WTR::UIScriptController::zoomToScale):
2734
2735 2016-10-31  Dewei Zhu  <dewei_zhu@apple.com>
2736
2737         Update twisted version in webkitpy.thirdparty.autoinstalled module.
2738         https://bugs.webkit.org/show_bug.cgi?id=154667
2739
2740         Reviewed by Ryosuke Niwa.
2741
2742         Use twisted_15_5_0 for the twisted module used by run-benchmark because there is a bug in twisted 12.1.0 which sometimes stops the test.
2743         Installing twisted was introduced in https://bugs.webkit.org/show_bug.cgi?id=147082 for run-benchmark script.
2744         Since buildbot relies on twisted 12.1.0 and has not been verified the compatibility on twisted 15.5.0, it would be more secure to use an individual version for run-benchmark script.
2745
2746         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2747         * Scripts/webkitpy/thirdparty/__init__.py:
2748         (AutoinstallImportHook.find_module):
2749         (AutoinstallImportHook._install_twisted_15_5_0):
2750         (AutoinstallImportHook._install_twisted): Deleted.
2751
2752 2016-10-31  Ryosuke Niwa  <rniwa@webkit.org>
2753
2754         Enable custom elements by default everywhere
2755         https://bugs.webkit.org/show_bug.cgi?id=164242
2756
2757         Reviewed by Antti Koivisto.
2758
2759         Enable custom elements API on every port by default.
2760
2761         * Scripts/webkitperl/FeatureList.pm:
2762
2763 2016-10-31  Nan Wang  <n_wang@apple.com>
2764
2765         AX: aria-sort is not exposed on iOS
2766         https://bugs.webkit.org/show_bug.cgi?id=164245
2767
2768         Reviewed by Chris Fleizach.
2769
2770         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2771         (AccessibilityUIElement::stringAttributeValue):
2772         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2773         (WTR::AccessibilityUIElement::stringAttributeValue):
2774
2775 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
2776
2777         Implement IntersectionObserver
2778         https://bugs.webkit.org/show_bug.cgi?id=159475
2779
2780         Reviewed by Ryosuke Niwa.
2781         
2782         Add ENABLE_INTERSECTION_OBSERVER, enabled by default.
2783
2784         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2785
2786 2016-10-31  Ryan Haddad  <ryanhaddad@apple.com>
2787
2788         Unreviewed, rolling out r208154.
2789
2790         This change caused an assertion failure during API tests on
2791         macOS.
2792
2793         Reverted changeset:
2794
2795         "NetworkSession: Network process crash when converting main
2796         resource to download"
2797         https://bugs.webkit.org/show_bug.cgi?id=164220
2798         http://trac.webkit.org/changeset/208154
2799
2800 2016-10-31  Said Abou-Hallawa  <sabouhallawa@apple.com>
2801
2802         Unreviewed, change my status to be a WebKit reviewer
2803
2804         * Scripts/webkitpy/common/config/contributors.json:
2805
2806 2016-10-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2807
2808         NetworkSession: Network process crash when converting main resource to download
2809         https://bugs.webkit.org/show_bug.cgi?id=164220
2810
2811         Reviewed by Alex Christensen.
2812
2813         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
2814         converted to a download and another one to test the cancellation as the test was doing before. When doing the
2815         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
2816         download.
2817
2818         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2819         (testPolicyResponseDownload):
2820         (testPolicyResponseDownloadCancel):
2821         (beforeAll):
2822
2823 2016-10-31  Keith Miller  <keith_miller@apple.com>
2824
2825         Unreviewed, fix watchlist regexp for wasm.
2826
2827         * Scripts/webkitpy/common/config/watchlist:
2828
2829 2016-10-31  Keith Miller  <keith_miller@apple.com>
2830
2831         autogenerated files from wasm.json should be in derived sources.
2832         https://bugs.webkit.org/show_bug.cgi?id=164152
2833
2834         Reviewed by Filip Pizlo.
2835
2836         Add message to make sure that people keep the wasm.jsons up to date.
2837
2838         * Scripts/webkitpy/common/config/watchlist:
2839
2840 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2841
2842         Holding down a key to choose an accented character should fire "insertReplacementText" input events
2843         https://bugs.webkit.org/show_bug.cgi?id=164209
2844         <rdar://problem/29019305>
2845
2846         Reviewed by Darin Adler.
2847
2848         Adds test support for inserting replacement text on Mac. This is equivalent to holding down a vowel key (e.g.
2849         'a') to bring up the menu containing accented version of the character, then selecting an accented character to
2850         insert in place of the typed character. This is exposed via UIScriptController.insertText, which takes a string
2851         and an insertion range.
2852
2853         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2854         (WTR::UIScriptController::insertText):
2855         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2856
2857         Note that there is no callback argument to insertText, since UIScriptController::insertText is synchronous in
2858         the UI process. The tests end when corresponding input events fired as a result of insertText have been received
2859         in the web process. Please see the new layout tests for more detail.
2860
2861         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2862         (WTR::UIScriptController::insertText):
2863         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2864         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2865         (WTR::nsStringFromJSString):
2866         (WTR::UIScriptController::insertText):
2867
2868 2016-10-30  Sam Weinig  <sam@webkit.org>
2869
2870         [WebIDL] Restructure IDLParser structs to better match modern WebIDL concepts
2871         https://bugs.webkit.org/show_bug.cgi?id=164208
2872
2873         Reviewed by Darin Adler.
2874
2875         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2876         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2877         Update for new struct types.
2878
2879 2016-10-29  Darin Adler  <darin@apple.com>
2880
2881         Fix failing ExtendedColor tests.
2882
2883         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp:
2884         Changed the tests in two ways: First, use EXPECT_EQ instead of EXPECT_TRUE
2885         for the string equality comparisons. This required including WTFStringUtilities.h.
2886         Second, change expected results to match what the code is currently generating,
2887         so alpha channels are "0.25" rather than "0.25 / 1". I'll let Dean fix both these
2888         tests and the code if these results are incorrect.
2889
2890 2016-10-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2891
2892         UIScriptControllerIOS.mm should not be soft-linking UIKit
2893         https://bugs.webkit.org/show_bug.cgi?id=164171
2894
2895         Reviewed by Darin Adler.
2896
2897         Follow-up to r208090. Instead of soft-linking, we can simply grab UIKeyboardPredictionView by name instead.
2898
2899         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2900         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
2901
2902 2016-10-28  Darin Adler  <darin@apple.com>
2903
2904         Move all classes in the HTML directory from ExceptionCode to Exception
2905         https://bugs.webkit.org/show_bug.cgi?id=163876
2906
2907         Reviewed by Sam Weinig.
2908
2909         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:
2910         (TestWebKitAPI::ToString): Updated for changes to the TimeRanges class.
2911         (TestWebKitAPI::TEST): Ditto.
2912
2913 2016-10-28  Devin Rousso  <dcrousso+webkit@gmail.com>
2914
2915         Unreviewed, changed Devin Rousso's email and nick.
2916
2917         * Scripts/webkitpy/common/config/contributors.json:
2918
2919 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2920
2921         Unreviewed, fix the iOS build after r208090.
2922
2923         Use soft-linking as needed in UIScriptControllerIOS.mm.
2924
2925         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2926         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
2927
2928 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2929
2930         iOS autocorrection does not trigger an input event of inputType "insertReplacementText"
2931         https://bugs.webkit.org/show_bug.cgi?id=164077
2932         <rdar://problem/28987810>
2933
2934         Reviewed by Simon Fraser.
2935
2936         Adds test support for inserting text candidates on iOS in the form of
2937         UIScriptController.selectTextCandidateAtIndex(index, callback), which selects the text candidate at a given
2938         index (this needs to be a value between 0-2 on iOS) and fires the callback when done.
2939
2940         To implement this, we wait for the text prediction view to have predictions (we determine this by polling at a
2941         given interval) and then tap the center of the text prediction view at the given index.
2942
2943         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2944         (WTR::UIScriptController::selectTextCandidateAtIndex):
2945         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2946         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2947         (WTR::UIScriptController::selectTextCandidateAtIndex):
2948         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
2949         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2950         * WebKitTestRunner/ios/UIKitSPI.h:
2951         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2952         (WTR::UIScriptController::selectTextCandidateAtIndex):
2953         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
2954
2955 2016-10-28  Commit Queue  <commit-queue@webkit.org>
2956
2957         Unreviewed, rolling out r207700.
2958         https://bugs.webkit.org/show_bug.cgi?id=164168
2959
2960         We are ready after r208086 (Requested by alexchristensen on
2961         #webkit).
2962
2963         Reverted changeset:
2964
2965         "Unreviewed, rolling out r207582."
2966         https://bugs.webkit.org/show_bug.cgi?id=163819
2967         http://trac.webkit.org/changeset/207700
2968
2969 2016-10-28  Alex Christensen  <achristensen@webkit.org>
2970
2971         Partially revert 207805 after resolution in URL spec issue 87
2972         https://bugs.webkit.org/show_bug.cgi?id=164142
2973
2974         Reviewed by Andy Estes.
2975
2976         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2977         (TestWebKitAPI::TEST_F):
2978
2979 2016-10-28  Alex Christensen  <achristensen@webkit.org>
2980
2981         URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
2982         https://bugs.webkit.org/show_bug.cgi?id=164154
2983
2984         Reviewed by Andy Estes.
2985
2986         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2987         (TestWebKitAPI::TEST_F):
2988
2989 2016-10-28  Sam Weinig  <sam@webkit.org>
2990
2991         [WebIDL] Update parser and code generators to only access type information through the type property
2992         https://bugs.webkit.org/show_bug.cgi?id=164141
2993
2994         Reviewed by Anders Carlsson.
2995
2996         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2997         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2998         Update to always access type information through type accessors. Remove use of removed
2999         properties.
3000
3001 2016-10-28  Frederic Wang  <fwang@igalia.com>
3002
3003         [GTK] Upgrade HarfBuzz to version 1.3.3
3004         https://bugs.webkit.org/show_bug.cgi?id=162719
3005
3006         Reviewed by Michael Catanzaro.
3007
3008         * gtk/jhbuild.modules:
3009
3010 2016-10-27  Chris Dumez  <cdumez@apple.com>
3011
3012         Regression(r203601): Caused crashes in iBooks
3013         https://bugs.webkit.org/show_bug.cgi?id=164093
3014         <rdar://problem/28745634>
3015
3016         Reviewed by Darin Adler.
3017
3018         Add API test coverage.
3019
3020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3021         * TestWebKitAPI/Tests/mac/DOMNode.mm: Added.
3022         (-[DOMNodeTest webView:didFinishLoadForFrame:]):
3023         (TestWebKitAPI::TEST):
3024
3025 2016-10-27  Sam Weinig  <sam@webkit.org>
3026
3027         [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType
3028         https://bugs.webkit.org/show_bug.cgi?id=164089
3029
3030         Reviewed by Alex Christensen.
3031
3032         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3033         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3034         Update for the removal of domSignature::type, and new signatures of helper predicates.
3035
3036 2016-10-27  Commit Queue  <commit-queue@webkit.org>
3037
3038         Unreviewed, rolling out r207992.
3039         https://bugs.webkit.org/show_bug.cgi?id=164070
3040
3041         triggered aclocal version conflict (Requested by mcatanzaro on
3042         #webkit).
3043
3044         Reverted changeset:
3045
3046         "[GTK] Bump glib to 2.50.1 (or find alternative solution to
3047         Gtk+ CUPS build issue)"
3048         https://bugs.webkit.org/show_bug.cgi?id=163689
3049         http://trac.webkit.org/changeset/207992
3050
3051 2016-10-27  Joanmarie Diggs  <jdiggs@igalia.com>
3052
3053         [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)
3054         https://bugs.webkit.org/show_bug.cgi?id=163689
3055
3056         Reviewed by Michael Catanzaro.
3057
3058         In order to fix bug #163591, we need to apply an upstream patch to GTK+.
3059         But GTK+ won't build with that patch due to the following error:
3060
3061             m4_copy: won't overwrite defined macro: glib_DEFUN
3062
3063         There is an upstream GLib patch which solves that issue. We should apply
3064         that patch as well, until we bump GLib to 2.50.1 or later.
3065
3066         * gtk/jhbuild.modules: Apply upstream GLib patch.
3067         * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added.
3068
3069 2016-10-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3070
3071         Unreviewed fix of GTK and EFL test bots.
3072
3073         * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and
3074         legacy-encrypted-media by default for GTK and EFL.
3075
3076 2016-10-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3077
3078         [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly
3079         https://bugs.webkit.org/show_bug.cgi?id=163846
3080
3081         Reviewed by Michael Catanzaro.
3082
3083         WebAssembly is now developed for Darwin right now.
3084         Disable WASM tests in the other platforms.
3085
3086         * Scripts/run-jsc-stress-tests:
3087
3088 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
3089
3090         [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
3091         https://bugs.webkit.org/show_bug.cgi?id=162928
3092
3093         Reviewed by Xabier Rodriguez-Calvar.
3094
3095         Explicitly enable MSE and EME on WebKitGTK+ buildbots.
3096
3097         This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
3098
3099         * Scripts/webkitperl/FeatureList.pm:
3100
3101 2016-10-25  Antoine Quint  <graouts@apple.com>
3102
3103         [Modern Media Controls] Media Controller: skip back support
3104         https://bugs.webkit.org/show_bug.cgi?id=163725
3105         <rdar://problem/27989480>
3106
3107         Reviewed by Dean Jackson.
3108
3109         * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
3110         access the modern-media-controls source files through the web server.
3111
3112 2016-10-19  Jer Noble  <jer.noble@apple.com>
3113
3114         Add WKWebView fullscreen delegate SPI
3115         https://bugs.webkit.org/show_bug.cgi?id=163674
3116
3117         Reviewed by Anders Carlsson.
3118
3119         Add a new API test which verifies that the fullscreen delegate receives notifications.
3120
3121         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
3122         (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]):
3123         (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]):
3124         (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]):
3125         (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]):
3126         (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]):
3127         (TestWebKitAPI::TEST):
3128
3129 2016-10-24  Alex Christensen  <achristensen@webkit.org>
3130
3131         URLParser should match old URL::parse with %2E in path
3132         https://bugs.webkit.org/show_bug.cgi?id=163929
3133
3134         Reviewed by Alexey Proskuryakov.
3135
3136         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3137         (TestWebKitAPI::TEST_F):
3138
3139 2016-10-24  Ryan Haddad  <ryanhaddad@apple.com>
3140
3141         Unreviewed, rolling out r207795.
3142
3143         Introduced API test failures on iOS and macOS.
3144
3145         Reverted changeset:
3146
3147         "URLParser should match old URL::parse with %2E in path"
3148         https://bugs.webkit.org/show_bug.cgi?id=163929
3149         http://trac.webkit.org/changeset/207795
3150
3151 2016-10-24  Alex Christensen  <achristensen@webkit.org>
3152
3153         URLParser should match old URL::parse with %2E in path
3154         https://bugs.webkit.org/show_bug.cgi?id=163929
3155
3156         Reviewed by Alexey Proskuryakov.
3157
3158         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3159         (TestWebKitAPI::TEST_F):
3160
3161 2016-10-21  Alex Christensen  <achristensen@webkit.org>
3162
3163         URL::port should return Optional<uint16_t>
3164         https://bugs.webkit.org/show_bug.cgi?id=163806
3165
3166         Reviewed by Darin Adler.
3167
3168         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3169         (TestWebKitAPI::TEST_F):
3170         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3171         (TestWebKitAPI::checkURL):
3172         (TestWebKitAPI::checkRelativeURL):
3173         (TestWebKitAPI::checkURLDifferences):
3174         (TestWebKitAPI::checkRelativeURLDifferences):
3175         (TestWebKitAPI::TEST_F):
3176
3177 2016-10-24  Youenn Fablet  <youenn@apple.com>
3178
3179         Activate WEB_RTC compilation flags for Mac bots
3180         https://bugs.webkit.org/show_bug.cgi?id=163886
3181
3182         Reviewed by Eric Carlson.
3183
3184         * Scripts/webkitperl/FeatureList.pm:
3185         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3186
3187 2016-10-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3188
3189         Unreviewed, add myself as a WebKit reviewer
3190
3191         * Scripts/webkitpy/common/config/contributors.json:
3192
3193 2016-10-22  Dan Bernstein  <mitz@apple.com>
3194
3195         Improve MiniBrowser window titles for URLs without paths and with no title
3196         <https://webkit.org/b/163843>
3197
3198         Reviewed by Darin Adler.
3199
3200         * MiniBrowser/mac/WK1BrowserWindowController.m:
3201         (-[WK1BrowserWindowController fetch:]): While we’re here, deploy
3202           +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController
3203           version of this method.
3204         (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
3205           use the entire URL.
3206         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here,
3207           deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController
3208           behavior.
3209
3210         * MiniBrowser/mac/WK2BrowserWindowController.m:
3211         (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
3212           use the entire URL.
3213
3214 2016-10-21  David Kilzer  <ddkilzer@apple.com>
3215
3216         Bug 163762: IntSize::area() should used checked arithmetic
3217         <https://webkit.org/b/163762>
3218
3219         Reviewed by Darin Adler.
3220
3221         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
3222         (TestWebKitAPI::TEST): Call unsafeGet().
3223         * TestWebKitAPI/Tests/WebCore/IntSize.cpp:
3224         (TestWebKitAPI::TEST): Ditto.
3225
3226 2016-10-21  James Craig  <jcraig@apple.com>
3227
3228         Unreviewed: Added Aaron Chu <aaron_chu@apple.com> to contributors list.
3229
3230         * Scripts/webkitpy/common/config/contributors.json:
3231
3232 2016-10-21  Commit Queue  <commit-queue@webkit.org>
3233
3234         Unreviewed, rolling out r207582.
3235         https://bugs.webkit.org/show_bug.cgi?id=163819
3236
3237         Not quite ready rdar://problem/28897179 (Requested by
3238         alexchristensen on #webkit).
3239
3240         Reverted changeset:
3241
3242         "Re-enable URLParser for non-Safari Cocoa apps after r207321"
3243         https://bugs.webkit.org/show_bug.cgi?id=163690
3244         http://trac.webkit.org/changeset/207582
3245
3246 2016-10-21  Jonathan Bedard  <jbedard@apple.com>
3247
3248         WebKitTestRunnerApp packages .idl file
3249         https://bugs.webkit.org/show_bug.cgi?id=163788
3250
3251         Reviewed by Darin Adler.
3252
3253         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon.
3254
3255 2016-10-21  Csaba Osztrogonác  <ossy@webkit.org>
3256
3257         [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
3258         https://bugs.webkit.org/show_bug.cgi?id=163733
3259
3260         Reviewed by Gyuyoung Kim.
3261
3262         * efl/install-dependencies: Added geoclue-2.0 package.
3263
3264 2016-10-21  Commit Queue  <commit-queue@webkit.org>
3265
3266         Unreviewed, rolling out r207609.
3267         https://bugs.webkit.org/show_bug.cgi?id=163776
3268
3269         As glib bump was rollout, we need to rollout this too
3270         (Requested by rego on #webkit).
3271
3272         Reverted changeset:
3273
3274         "[GTK] Cannot build GTK+ with CUPS 2.* versions"
3275         https://bugs.webkit.org/show_bug.cgi?id=163591
3276         http://trac.webkit.org/changeset/207609
3277
3278 2016-10-20  Chris Dumez  <cdumez@apple.com>
3279
3280         "Download Linked File" context menu action should use 'download' attribute as suggested filename
3281         https://bugs.webkit.org/show_bug.cgi?id=163742
3282         <rdar://problem/28840734>
3283
3284         Reviewed by Darin Adler.
3285
3286         Add API test coverage.
3287
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289         * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Added.
3290         * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Added.
3291         (TestWebKitAPI::didFinishLoadForFrame):
3292         (TestWebKitAPI::getContextMenuFromProposedMenu):
3293         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
3294         (TestWebKitAPI::TEST):
3295
3296 2016-10-20  Commit Queue  <commit-queue@webkit.org>
3297
3298         Unreviewed, rolling out r207589.
3299         https://bugs.webkit.org/show_bug.cgi?id=163765
3300
3301         Introduced 17 new layout test failures (Requested by
3302         mcatanzaro on #webkit).
3303
3304         Reverted changeset:
3305
3306         "[GTK] Bump glib to 2.50.1"
3307         https://bugs.webkit.org/show_bug.cgi?id=163689
3308         http://trac.webkit.org/changeset/207589
3309
3310 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
3311
3312         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
3313         https://bugs.webkit.org/show_bug.cgi?id=163374
3314
3315         Reviewed by Darin Adler.
3316
3317         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3318
3319 2016-10-20  Sam Weinig  <sam@webkit.org>
3320
3321         Add convenience function that combines WTF::visit(...) with WTF::makeVisitor(...)
3322         https://bugs.webkit.org/show_bug.cgi?id=163713
3323
3324         Reviewed by Dan Bernstein.
3325
3326         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3327         Add test for WTF::switchOn()
3328
3329 2016-10-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3330
3331         [CMake] CMake does not support the dep files for implicit dependency
3332         https://bugs.webkit.org/show_bug.cgi?id=161433
3333
3334         Reviewed by Brent Fulgham.
3335
3336         Created a Perl script to generate all IDL bindings for CMake.
3337         This script can regenerate outdated bindings by based on the
3338         supplemental dependency and dep files created by
3339         '--write-dependencies' switch of generate-bindings.pl.
3340
3341         add_custom_target is used to invoke the script instead of
3342         add_custom_command because Ninja deletes all output files before
3343         executing the command in case of add_custom_command.
3344
3345         USES_TERMINAL option of add_custom_target has two effects:
3346         1) Not buffering output of the command
3347         2) Invoking the command in the special Ninja pool which inhibits parallel build
3348         One needs to use CMake 3.2 or later to enable this feature.
3349
3350         * DumpRenderTree/CMakeLists.txt: Specified a target name for
3351         GENERATE_BINDINGS. Added dependency for the target.
3352         * WebKitTestRunner/CMakeLists.txt: Ditto.
3353
3354 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
3355
3356         [GTK] Cannot build GTK+ with CUPS 2.* versions
3357         https://bugs.webkit.org/show_bug.cgi?id=163591
3358
3359         Reviewed by Michael Catanzaro.
3360
3361         GTK+ is wrongly checking about the available CUPS version,
3362         so if you have CUPS 2.* the configure step fails.
3363
3364         This has been already fixed upstream and included in 2.30 series:
3365         https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b
3366
3367         Added patch on JHBuild so we can now build GTK+ with CUPS 2.*.
3368
3369         * gtk/jhbuild.modules: Applied patch and avoid using "configure" script directly
3370         as the patch modifies "configure.ac".
3371         * gtk/patches/configure-fix-detecting-CUPS-2.x.patch: Added.
3372
3373 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
3374
3375         [GTK] Bump glib to 2.50.1
3376         https://bugs.webkit.org/show_bug.cgi?id=163689
3377
3378         Reviewed by Michael Catanzaro.
3379
3380         This is need in order to fix GTK+ build with CUPS 2.* (bug #163591).
3381
3382         * gtk/jhbuild.modules: Bump glib version. Pass --disable-libmount to build properly.
3383         Also we don't need the patches anymore.
3384         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
3385         * gtk/patches/glib-warning-fix.patch: Removed.
3386
3387 2016-10-19  Alex Christensen  <achristensen@webkit.org>
3388
3389         Re-enable URLParser for non-Safari Cocoa apps after r207321
3390         https://bugs.webkit.org/show_bug.cgi?id=163690
3391
3392         Reviewed by Darin Adler.
3393
3394         * DumpRenderTree/mac/DumpRenderTree.mm:
3395         (DumpRenderTreeMain):
3396         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
3397         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3398         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3399         (TestWebKitAPI::TEST):
3400         * WebKitTestRunner/TestController.cpp:
3401         (WTR::TestController::TestController):
3402
3403 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
3404
3405         Unreviewed, rolling out r207557.
3406
3407         This change caused animations/font-variations tests to time
3408         out on pre-Sierra Macs.
3409
3410         Reverted changeset:
3411
3412         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
3413         iOS 9"
3414         https://bugs.webkit.org/show_bug.cgi?id=163374
3415         http://trac.webkit.org/changeset/207557
3416
3417 2016-10-19  Andy Estes  <aestes@apple.com>
3418
3419         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
3420         https://bugs.webkit.org/show_bug.cgi?id=163476
3421         <rdar://problem/26941395>
3422
3423         Reviewed by Andreas Kling.
3424
3425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3426         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
3427         (TEST): Added an API test that passes a nil MIMEType to
3428         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
3429
3430 2016-10-19  Jer Noble  <jer.noble@apple.com>
3431
3432         Modify testrunner to mute audio during tests
3433         https://bugs.webkit.org/show_bug.cgi?id=162582
3434
3435         Reviewed by Alexey Proskuryakov.
3436
3437         * DumpRenderTree/mac/DumpRenderTree.mm:
3438         (createWebViewAndOffscreenWindow):
3439         * WebKitTestRunner/TestController.cpp:
3440         (WTR::TestController::resetStateToConsistentValues):
3441
3442 2016-10-19  Joseph Pecoraro  <pecoraro@apple.com>
3443
3444         check-webkit-style: fix false-positive warnings about using #pragma once header guard
3445         https://bugs.webkit.org/show_bug.cgi?id=163575
3446
3447         Reviewed by Brady Eidson.
3448
3449         There were some false positive warnings about header guards
3450         for ObjC headers that don't need guards. This changes the
3451         style checker to no longer warn if there is no #pragma once.
3452         It only warns if there are #ifndef that should be #pragma once.
3453
3454         * Scripts/webkitpy/style/checkers/cpp.py:
3455         (check_for_header_guard):
3456         Change when we output an error.
3457
3458         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3459         (CppStyleTest.test_build_header_guard):
3460         Update tests.
3461
3462 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
3463
3464         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
3465         https://bugs.webkit.org/show_bug.cgi?id=163374
3466
3467         Reviewed by Darin Adler.
3468
3469         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3470
3471 2016-10-18  Philippe Normand  <pnormand@igalia.com>
3472
3473         WebRTC: [GTK] Update jhbuild environment for OpenWebRTC
3474         https://bugs.webkit.org/show_bug.cgi?id=163330
3475
3476         Reviewed by Michael Catanzaro.
3477
3478         Bring back the openwebrtc JHBuild moduleset in the time being. It
3479         should be removed after the bump to GStreamer 1.10 is complete and
3480         the libnice patches have been upstreamed. The GStreamer git
3481         snapshots used in this patch are the ones configured in Ericsson's
3482         GStreamer Cerbero fork.
3483
3484         * gtk/openwebrtc.modules: Added.
3485         * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Added.
3486         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Added.
3487         * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Added.
3488         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Added.
3489         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Added.
3490         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Added.
3491         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Added.
3492
3493 2016-10-18  Sam Weinig  <sam@webkit.org>
3494
3495         Replace std::experimental::variant with WTF::Variant (or similar)
3496         https://bugs.webkit.org/show_bug.cgi?id=163626
3497
3498         Reviewed by Chris Dumez.
3499
3500         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
3501         into the WTF namespace.
3502
3503         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3504         (TestWebKitAPI::TEST):
3505
3506 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
3507
3508         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
3509         https://bugs.webkit.org/show_bug.cgi?id=163627
3510
3511         Reviewed by Dean Jackson.
3512
3513         Rename setScale: to setViewScale: and add setPageScale:, hooking it up for WK1 (via exisiting SPI)
3514         and WK2 (via new SPI).
3515
3516         * MiniBrowser/mac/BrowserWindowController.h:
3517         * MiniBrowser/mac/BrowserWindowController.m:
3518         (-[BrowserWindowController pageScaleForMenuItemTag:]):
3519         (-[BrowserWindowController setPageScale:]):
3520         (-[BrowserWindowController setViewScale:]):
3521         (-[BrowserWindowController setScale:]): Deleted.
3522         * MiniBrowser/mac/MainMenu.xib:
3523         * MiniBrowser/mac/WK1BrowserWindowController.m:
3524         (-[WK1BrowserWindowController setPageScale:]):
3525         (-[WK1BrowserWindowController setViewScale:]):
3526         (areEssentiallyEqual):
3527         (-[WK1BrowserWindowController validateMenuItem:]):
3528         (-[WK1BrowserWindowController setScale:]): Deleted.
3529         * MiniBrowser/mac/WK2BrowserWindowController.m:
3530         (-[WK2BrowserWindowController setPageScale:]):
3531         (-[WK2BrowserWindowController viewScaleForMenuItemTag:]):
3532         (-[WK2BrowserWindowController setViewScale:]):
3533         (areEssentiallyEqual):
3534         (-[WK2BrowserWindowController validateMenuItem:]):
3535         (viewScaleForMenuItemTag): Deleted.
3536         (-[WK2BrowserWindowController setScale:]): Deleted.
3537
3538 2016-10-18  Anders Carlsson  <andersca@apple.com>
3539
3540         Add an beforeunload alert to the WebKitLegacy MiniBrowser
3541         https://bugs.webkit.org/show_bug.cgi?id=163634
3542
3543         Reviewed by Sam Weinig.
3544
3545         * MiniBrowser/mac/WK1BrowserWindowController.m:
3546         (-[WK1BrowserWindowController webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
3547
3548 2016-10-18  Commit Queue  <commit-queue@webkit.org>
3549
3550         Unreviewed, rolling out r207443.
3551         https://bugs.webkit.org/show_bug.cgi?id=163616
3552
3553         "Caused 5% PLT regression" (Requested by krollin on #webkit).
3554
3555         Reverted changeset:
3556
3557         "Crash in ASCIICaseInsensitiveHash::hash() when a response has
3558         a null MIME type"
3559         https://bugs.webkit.org/show_bug.cgi?id=163476
3560         http://trac.webkit.org/changeset/207443
3561
3562 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
3563
3564         [MediaStream] Resolve constraints and enumerate devices in the UI process
3565         https://bugs.webkit.org/show_bug.cgi?id=162147
3566         <rdar://problem/28803569>
3567
3568         Reviewed by Darin Adler.
3569
3570         * WebKitTestRunner/TestController.cpp:
3571         (WTR::TestController::resetPreferencesToConsistentValues): Enable mock capture devices.
3572         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update for API changes.
3573
3574 2016-10-17  Megan Gardner  <megan_gardner@apple.com>
3575
3576         Add test and infrastructure for link popover
3577         https://bugs.webkit.org/show_bug.cgi?id=163406
3578
3579         Reviewed by Simon Fraser.
3580
3581         Added functionality test for link popovers.
3582         Can query for what URL is loaded, and that the popover has appeared or has
3583         been dismissed.
3584         Added a link popover test.
3585
3586         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3587         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
3588         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
3589         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
3590         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3591         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3592         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3593         (WTR::UIScriptController::setDidShowForcePressPreviewCallback):
3594         (WTR::UIScriptController::didShowForcePressPreviewCallback):
3595         (WTR::UIScriptController::setDidDismissForcePressPreviewCallback):