f219050f1d8c45511bccba4a8c4c535982de6989
[WebKit-https.git] / Tools / ChangeLog
1 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2
3         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
4         https://bugs.webkit.org/show_bug.cgi?id=149639
5
6         Reviewed by Alex Christensen.
7
8         * Scripts/VCSUtils.pm:
9         (exitStatus): Use 'isWindows()' method.
10         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
11         an error. This method could probably just go away.
12         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
13         always changing to Unix style. 
14         (unixPath): Added. Needed so Windows can always show a Unix path in the
15         ChangeLog file.
16         (changeLogName): Work around the fact that 'getpwuid' is not available on
17         a pure Windows build of Perl.
18         * Scripts/prepare-ChangeLog:
19         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
20         path on Windows.
21         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
22         support using arrays for 'open' arguments.
23         (resolveChangeLogsPath): Ditto.
24         (resolveConflictedChangeLogs): Use new helper functions.
25         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
26         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
27         quotes. Unix systems are happy either way.
28         (statusCommand): Ditto.
29         * Scripts/webkitdirs.pm:
30         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
31
32 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
33
34         [Win] Unreviewed 64-bit build fix after switch to CMake.
35
36         * Scripts/webkitdirs.pm:
37         (determineIsWin64FromArchitecture): Added.
38
39 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
40
41         printing does not use minimum page zoom factor
42         https://bugs.webkit.org/show_bug.cgi?id=108507
43
44         Reviewed by Darin Adler.
45
46         WebKitTestRunner always takes the snapshots from the UI process
47         (expect for IOS), so in the case of printing, the layout in the
48         web view is not the expected one. When printing, we need to take
49         the snapshot in the web process and ensure it's rendered with a
50         PrintContext.
51
52         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
53         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
54         kWKSnapshotOptionsPrinting option to
55         WKBundlePageCreateSnapshotWithOptions() when printing.
56
57 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
58
59         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
60         https://bugs.webkit.org/show_bug.cgi?id=149595
61
62         Reviewed by Tim Horton.
63
64         All ports except IOS implement
65         PlatformWebView::windowSnapshotImage() to generate the snapshot
66         for the pixel tests in the UI process. But we are still generating
67         a snapshot for pixel tests in the Web process too, that is passed
68         to the UI process but ignored.
69         Whether a pixel result is needed or not, is only known by the web
70         process depending on whether the test called dumpAsText with
71         dumpPixels == true or not. Since the pixels are now dump in the UI
72         process, we need to pass that information to the UI process when
73         the test is done. For that we set a PixelResultIsPending bool
74         parameter to the Done message, and we only add the PixelResult
75         when UI process doesn't need to generate the pixels dump.
76
77         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
78         (WTR::InjectedBundle::didReceiveMessageToPage): Set
79         m_pixelResultIsPending to false on reset.
80         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
81         Done message, and set the PixelResult if m_pixelResultIsPending is false.
82         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
83         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
84         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
85         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
86         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
87         port.
88         * WebKitTestRunner/TestInvocation.cpp:
89         (WTR::TestInvocation::dumpResults): Use either the pixel result
90         from the web process or generate a pixel result from the web view
91         if need it.
92         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
93         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
94         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
95         is created by the caller now, but the CG implementation needs to
96         know if it's a Web or UI process snapshot.
97         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
98         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
99         cairo surface for the given image.
100         * WebKitTestRunner/cg/TestInvocationCG.cpp:
101         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
102         CGContext for the given image.
103
104 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
105
106         Fix JS errors on dashboard metrics page
107         https://bugs.webkit.org/show_bug.cgi?id=149608
108
109         Reviewed by Alexey Proskuryakov.
110
111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
112         (initPlatformsByFamily): 
113         (updateHiddenPlatforms):
114         (parsePlatformFamily): Deleted.
115         (updateToggleButtons): Deleted.
116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
117         (updateHiddenPlatforms): Added to remove errors.
118         (initPlatformsByFamily): Added to remove errors.
119         (unhiddenQueues): Updated to use Settings.
120         (documentReady): Added logic to add toggle buttons to the settings menu.
121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
122         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
123         MetricsMain.js to Settings.
124         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
125         MetricsMain.js to Settings.
126         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
127         (QueueView.prototype._updateHiddenState): Updated to use Settings.
128
129 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
130
131         Appscale query fails because of missing index
132         https://bugs.webkit.org/show_bug.cgi?id=149609
133
134         Reviewed by Darin Adler.
135
136         * QueueStatusServer/index.yaml: Added the required index.
137
138 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
139
140         [Win] Fix the 64-bit build after switch to cmake.
141
142         Reviewed by Alex Christensen.
143
144         * Scripts/webkitdirs.pm:
145         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
146         run a 64-bit build.
147
148 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
149
150         [Win] Allow Windows to run test-webkitpy without Cygwin
151         https://bugs.webkit.org/show_bug.cgi?id=149602
152
153         Reviewed by Alex Christensen.
154
155         These changes mostly shift from hard-coded paths using UNIX-style
156         separators to Python's "os.path.join" syntax that uses the correct
157         path separator for each platform.
158         
159         * Scripts/webkitpy/common/system/path.py:
160         (cygpath): Don't pass paths through Cygpath on native Windows.
161         * Scripts/webkitpy/port/win.py:
162         (WinPort._path_to_apache): Use os.path.join.
163         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
164         in 64-bit environments).
165         * Scripts/webkitpy/style/checker.py: Use os.path.join.
166         * Scripts/webkitpy/style/checker_unittest.py:
167         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
168         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
169         (GlobalVariablesTest): Ditto.
170         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
171         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
172         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
173         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
174         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
175         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
176         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
177         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
178         (StyleProcessor_CodeCoverageTest): Ditto.
179         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
180         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
181         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
182         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
183         manual string concatenation of paths.
184
185 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
186
187         Add bugzilla addresses of committers to contributors.json
188         https://bugs.webkit.org/show_bug.cgi?id=149520
189
190         Reviewed by Darin Adler.
191
192         * Scripts/webkitpy/common/config/contributors.json:
193
194 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
195
196         validate-committer-lists -b shouldn't need edituser privileges
197         https://bugs.webkit.org/show_bug.cgi?id=149519
198
199         Reviewed by Darin Adler.
200
201         * Scripts/validate-committer-lists:
202         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
203         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
204         (BugzillaQueries.is_invalid_bugzilla_email):
205         (BugzillaQueries): Deleted.
206         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
207
208 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
209
210         Unreviewed. Gardening: skip media stream tests failing after r190262.
211
212         * Scripts/run-gtk-tests:
213         (TestRunner):
214
215 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
216
217         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
218         https://bugs.webkit.org/show_bug.cgi?id=149571
219
220         Reviewed by Dan Bernstein.
221
222         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
223
224         * DumpRenderTree/mac/Configurations/Base.xcconfig:
225         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
226         * LayoutTestRelay/Configurations/Base.xcconfig:
227         * MiniBrowser/Configurations/Base.xcconfig:
228         * MiniBrowser/Configurations/DebugRelease.xcconfig:
229         * TestWebKitAPI/Configurations/Base.xcconfig:
230         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
231         * WebEditingTester/Configurations/Base.xcconfig:
232         * WebEditingTester/Configurations/DebugRelease.xcconfig:
233         * WebKitTestRunner/Configurations/Base.xcconfig:
234         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
235         * WebKitTestRunner/iOS.xcconfig: Removed.
236
237 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
238
239         Clean up user media request internal API
240         https://bugs.webkit.org/show_bug.cgi?id=149527
241
242         Reviewed by Tim Horton.
243
244         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
245         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
246
247         * WebKitTestRunner/TestController.cpp:
248         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
249
250 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
251
252         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
253         https://bugs.webkit.org/show_bug.cgi?id=149577
254
255         Reviewed by Tim Horton.
256         
257         When calling testRunner.runUIScript() from a page load event, the script could run
258         in the UI process before the current remote layer tree transaction had been handled
259         there. This meant that runUIScript() could query state which was about to change.
260         
261         Fix by delaying the execution of the UI script until a layer tree transaction has
262         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
263
264         * WebKitTestRunner/TestInvocation.cpp:
265         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
266         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
267         * WebKitTestRunner/TestInvocation.h:
268
269 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
270
271         [Mac] Media tests start to time out after a few days of bot uptime
272         https://bugs.webkit.org/show_bug.cgi?id=149468
273
274         Reviewed by Darin Adler.
275
276         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
277         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
278         all temporary and cache files go to a custom location.
279
280         * Scripts/webkitpy/port/base.py:
281         * Scripts/webkitpy/port/driver.py:
282         * Scripts/webkitpy/port/mac.py:
283         * Scripts/webkitpy/port/win.py:
284         (WinPort._driver_tempdir_for_environment): Deleted unused function.
285
286 2015-09-25  Dan Bernstein  <mitz@apple.com>
287
288         Removed MiniBrowser.entitlements.
289
290         Rubber-stamped by Anders Carlsson.
291
292         The entitlements weren’t used anyway.
293
294         * MiniBrowser/MiniBrowser.entitlements: Removed.
295         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
296
297 2015-09-24  Daniel Bates  <dabates@apple.com>
298
299         Add WebKitSystemInterface for iOS 9.0
300         https://bugs.webkit.org/show_bug.cgi?id=149550
301
302         Rubber-stamped by Alexey Proskuryakov.
303
304         * Scripts/copy-webkitlibraries-to-product-directory:
305
306 2015-09-24  Daniel Bates  <dabates@apple.com>
307
308         Support building for arbitrary architectures
309         https://bugs.webkit.org/show_bug.cgi?id=149539
310
311         Reviewed by Alexey Proskuryakov.
312
313         Teach buildbot to pass the architectures associated with the builder to build-webkit
314         when building on OS X and iOS. As a side effect of this change we now support building
315         universal binaries when multiples architectures are specified.
316
317         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
318         (CompileWebKit.start):
319
320 2015-09-24  Daniel Bates  <dabates@apple.com>
321
322         Fix the build after <http://trac.webkit.org/changeset/190212>
323         (http://trac.webkit.org/changeset/190212)
324
325         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
326
327         * BuildSlaveSupport/built-product-archive:
328         (main):
329
330 2015-09-24  Daniel Bates  <dabates@apple.com>
331
332         Support running unit tests on iOS Simulator test bot
333         https://bugs.webkit.org/show_bug.cgi?id=149536
334
335         Reviewed by Alexey Proskuryakov.
336
337         Implements support for running unit tests on a iOS test bot. At the time of writing,
338         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
339
340         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
341         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
342         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
343
344 2015-09-24  Daniel Bates  <dabates@apple.com>
345
346         Add support infrastructure for OpenSource iOS builders and testers
347         https://bugs.webkit.org/show_bug.cgi?id=149534
348
349         Reviewed by Darin Adler.
350
351         Towards setting up OpenSource iOS build bots, teach buildbot and its support
352         scripts about iOS.
353
354         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
355         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
356         --ios-simulator or --device for a builder/tester whose full platform name begins with
357         "ios-simulator" or "ios", respectively.
358         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
359         * BuildSlaveSupport/built-product-archive:
360         (main): Pass the full platform name to determineWebKitBuildDirectory().
361         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
362         command line flag when building for iOS.
363         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
364         parameter fullPlatform. This parameter was originally added in r125066 to support the
365         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
366         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
367         * BuildSlaveSupport/clean-build:
368         (main): Call script webkit-build-directory with the appropriate command line flag when
369         building for iOS.
370         * BuildSlaveSupport/delete-stale-build-files:
371         (main): Use the same logic for iOS as we do for Mac.
372         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
373         flag when building for iOS.
374         * BuildSlaveSupport/test-result-archive:
375         (archiveTestResults): Use the same logic for iOS as we do for Mac.
376
377 2015-09-24  Daniel Bates  <dabates@apple.com>
378
379         Remove Chromium-specific changes to script built-product-archive
380         https://bugs.webkit.org/show_bug.cgi?id=149530
381
382         Rubber-stamped by Csaba Osztrogonác.
383
384         Reverts changes made in r113074 and r113067 to support Chromium testers. The
385         Chromium code has long since been removed from the OpenSource WebKit Project.
386
387         * BuildSlaveSupport/built-product-archive:
388         (createZipManually):
389         (createZip):
390         (archiveBuiltProduct):
391
392 2015-09-24  Dan Bernstein  <mitz@apple.com>
393
394         Build fix.
395
396         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
397
398 2015-09-24  Mark Lam  <mark.lam@apple.com>
399
400         Unreviewed. Make Lucas Forschler a WebKit reviewer.
401
402         * Scripts/webkitpy/common/config/contributors.json:
403
404 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
405
406         Unreviewed. Fix GObject DOM API breaks after r190120.
407
408         Bring back code removed in r169931 to handle documentation of
409         deleted classes.
410
411         * gtk/webkitdom.py:
412         (WebKitDOMDocGenerator):
413         (WebKitDOMDocGenerator.write_deleted_classes):
414         (WebKitDOMDocGenerator.generate):
415         (write_deleted_classes):
416         (WebKitDOMDocGeneratorSections._deleted_class):
417         (WebKitDOMDocGeneratorSections._deleted_class.in):
418         (WebKitDOMDocGeneratorSections.write_deleted_classes):
419         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
420
421 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
422
423         [Cocoa] [Font Features] Implement font-variant-*
424         https://bugs.webkit.org/show_bug.cgi?id=148413
425
426         Reviewed by Darin Adler.
427
428         Update test font to use "lnum" feature.
429
430         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
431         (Generator::appendGSUBTable):
432
433 2015-09-22  Andy Estes  <aestes@apple.com>
434
435         ContentFiltering.AllowDownloadAfterAddData is very flaky
436         https://bugs.webkit.org/show_bug.cgi?id=148885
437         <rdar://problem/22729563>
438
439         Reviewed by Alexey Proskuryakov.
440
441         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
442         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
443         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
444
445         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
446         (downloadTest):
447
448 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
449
450         Mavericks: Media tests start to time out after a few days of bot uptime
451         https://bugs.webkit.org/show_bug.cgi?id=149468
452
453         Reviewed by Chris Dumez.
454
455         * Scripts/webkitpy/port/base.py:
456         * Scripts/webkitpy/port/driver.py:
457         * Scripts/webkitpy/port/mac.py:
458
459 2015-09-22  Nan Wang  <n_wang@apple.com>
460
461         Unreviewed, add myself to the committers list.
462
463         * Scripts/webkitpy/common/config/contributors.json:
464
465 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
466
467         Remove 'nullable' to fix older iOS builds.
468
469         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
470         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
471
472 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
473
474         [Win] Show tiled drawing debug overlay on Windows
475         https://bugs.webkit.org/show_bug.cgi?id=149426
476
477         Reviewed by Dean Jackson.
478
479         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
480         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
481         * MiniBrowser/win/Common.cpp:
482         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
483         flag if needed.
484         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
485
486 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
487
488         [Win] Use command-line argument to launch in regular or High DPI mode.
489         https://bugs.webkit.org/show_bug.cgi?id=149417
490
491         Reviewed by Dean Jackson.
492
493         * MiniBrowser/win/Common.cpp:
494         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
495         very start of execution, before the MiniBrowser.dll is loaded.
496         * win/DLLLauncher/DLLLauncherMain.cpp:
497         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
498         present. On WinCairo, always use High DPI.
499
500 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
501
502         32-bit Mac build fix attempt after r190065.
503
504         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
505
506 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
507
508         [OS X] Update for Xcode 7.0 on Yosemite
509         https://bugs.webkit.org/show_bug.cgi?id=149389
510
511         Reviewed by Dan Bernstein.
512
513         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
514         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
515         Removed unneeded declarations - conforming to a protocol is sufficient.
516
517         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
518         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
519         Changed the definitions to be compiled whenever the SDK requires it (so we will have
520         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
521
522 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
523
524         Add the ability for tests to run script in the UI process in WebKitTestRunner
525         https://bugs.webkit.org/show_bug.cgi?id=149356
526
527         Reviewed by Tim Horton.
528
529         This change adds testRunner.runUIScript(script, callback), which allows a test
530         to execute script in a JSContext which runs in the UI process. That context
531         has bindings exposed through the UIScriptController interface; currently one test
532         function, and some iOS-specific functions are included. UIScriptController can be
533         async with a callback, and runUIScript() itself is asynchronous. When the UI 
534         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
535         is a string passed back to the web process, and given to the runUIScript()
536         callback function.
537         
538         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
539
540         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
541         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
542         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
543         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
544         complete, call back into TestRunner.
545         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
546         (WTR::nextUIScriptCallbackID):
547         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
548         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
549         * WebKitTestRunner/InjectedBundle/TestRunner.h:
550         * WebKitTestRunner/PlatformWebView.h:
551         * WebKitTestRunner/TestController.cpp:
552         (WTR::updateTestOptionsFromTestHeader):
553         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
554         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
555         * WebKitTestRunner/TestInvocation.cpp:
556         (WTR::TestInvocation::shouldUseFixedLayout):
557         (WTR::TestInvocation::shouldUseThreadedScrolling):
558         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
559         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
560         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
561         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
562         * WebKitTestRunner/TestInvocation.h:
563         * WebKitTestRunner/TestOptions.h:
564         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
565         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
566         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
567         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
568         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
569         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
570         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
571         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
572         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
573         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
574         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
575         (WTR::UIScriptController::doAsyncTask):
576         (WTR::UIScriptController::zoomToScale):
577         (WTR::UIScriptController::zoomScale):
578         (WTR::UIScriptController::minimumZoomScale):
579         (WTR::UIScriptController::maximumZoomScale):
580         (WTR::UIScriptController::contentVisibleRect):
581         * WebKitTestRunner/mac/EventSenderProxy.mm:
582         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
583         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
584         * WebKitTestRunner/mac/TestControllerMac.mm:
585         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
586         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
587         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
588         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
589         (UIScriptContext::UIScriptContext):
590         (UIScriptContext::~UIScriptContext):
591         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
592         asynchronous, call the callback.
593         (UIScriptContext::nextTaskCallbackID):
594         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
595         that has a callback). Has to store the callbackID of the script, so code called from the completion
596         callback knows which UI script invoked it.
597         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
598         (UIScriptContext::uiScriptComplete):
599         (UIScriptContext::objectFromRect): Make a JS object from a rect.
600         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
601         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
602         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
603         (WTR::UIScriptController::UIScriptController):
604         (WTR::UIScriptController::makeWindowObject):
605         (WTR::UIScriptController::wrapperClass):
606         (WTR::UIScriptController::doAsyncTask):
607         (WTR::UIScriptController::zoomToScale):
608         (WTR::UIScriptController::zoomScale):
609         (WTR::UIScriptController::minimumZoomScale):
610         (WTR::UIScriptController::maximumZoomScale):
611         (WTR::UIScriptController::contentVisibleRect):
612         (WTR::UIScriptController::uiScriptComplete):
613         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
614         (WTR::UIScriptController::create):
615         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
616
617 2015-09-21  Tim Horton  <timothy_horton@apple.com>
618
619         Turn on threaded scrolling by default in the tests
620         https://bugs.webkit.org/show_bug.cgi?id=149377
621
622         Reviewed by Simon Fraser.
623
624         * WebKitTestRunner/mac/TestControllerMac.mm:
625         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
626         (WTR::shouldUseThreadedScrolling): Deleted.
627         Turn on threaded scrolling by default.
628
629 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
630
631         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
632         https://bugs.webkit.org/show_bug.cgi?id=149252
633
634         Reviewed by Darin Adler.
635
636         In case of glib tests the test runner notifies about tests
637         crashing, but for google tests we don't get any feedback, which
638         means that in case of a test crashing we get a list of **PASS**
639         messages and at the summary we are notified that the test suite
640         has failed, but it's impossible to know which test cases have failed.
641
642         * Scripts/run-gtk-tests:
643         (TestRunner._run_google_test): Add a **CRASH** message if test
644         case crashed.
645
646 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
647
648         WebKitTestRunner can leak user content script results between tests
649         https://bugs.webkit.org/show_bug.cgi?id=149391
650
651         Reviewed by Sam Weinig.
652
653         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
654         about:blank, and thus about:blank doesn't have unintended side effects.
655
656         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
657         (WTR::InjectedBundle::beginTesting):
658         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
659         (WTR::InjectedBundlePage::resetAfterTest):
660
661 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
662
663         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
664         https://bugs.webkit.org/show_bug.cgi?id=149384
665
666         Reviewed by Chris Fleizach.
667
668         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
669         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
670         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
671         regardless of whether someone else holds a reference (we also call -stopListening in
672         -dealloc).
673
674         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
675         (AccessibilityController::platformResetToConsistentState):
676         (AccessibilityController::addNotificationListener):
677         Ditto.
678
679 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
680
681         Remove XHR_TIMEOUT compilation guard
682         https://bugs.webkit.org/show_bug.cgi?id=149260
683
684         Reviewed by Benjamin Poulain.
685
686         * Scripts/webkitperl/FeatureList.pm:
687
688 2015-09-19  Dan Bernstein  <mitz@apple.com>
689
690         Attempted build fix.
691
692         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
693
694 2015-09-18  Commit Queue  <commit-queue@webkit.org>
695
696         Unreviewed, rolling out r189908.
697         https://bugs.webkit.org/show_bug.cgi?id=149368
698
699         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
700
701         Reverted changeset:
702
703         "printing does not use minimum page zoom factor"
704         https://bugs.webkit.org/show_bug.cgi?id=108507
705         http://trac.webkit.org/changeset/189908
706
707 2015-09-18  Andy Estes  <aestes@apple.com>
708
709         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
710         https://bugs.webkit.org/show_bug.cgi?id=149360
711
712         Reviewed by Tim Horton.
713
714         Added an API test.
715
716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
717         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
718         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
719         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
720         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
721         (TEST):
722         * TestWebKitAPI/ios/pages.pages: Added.
723
724 2015-09-18  Nan Wang  <n_wang@apple.com>
725
726         AX: Implement ARIA 1.1 @aria-current on iOS
727         https://bugs.webkit.org/show_bug.cgi?id=149297
728
729         Reviewed by Chris Fleizach.
730
731         Added support to test aria-current on iOS.
732
733         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
734         (AccessibilityUIElement::stringAttributeValue):
735         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
736         (WTR::AccessibilityUIElement::stringAttributeValue):
737
738 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
739
740         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
741         https://bugs.webkit.org/show_bug.cgi?id=149352
742
743         Reviewed by Simon Fraser.
744
745         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
746         m_context can be null. This may indicate a bug in webkitpy too, but
747         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
748         wrong with opening and immediately closing it.
749
750 2015-09-18  Daniel Bates  <dabates@apple.com>
751
752         isGitSVNDirectory() returns true when Git is not installed
753         https://bugs.webkit.org/show_bug.cgi?id=149351
754
755         Reviewed by Alexey Proskuryakov.
756
757         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
758         Git is not installed on the machine.
759
760         * Scripts/VCSUtils.pm:
761         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
762         status code 0 (success).
763
764 2015-09-18  Alex Christensen  <achristensen@webkit.org>
765
766         Prevent build-webkit from building four times on Windows 
767         https://bugs.webkit.org/show_bug.cgi?id=149336
768
769         Reviewed by Brent Fulgham.
770
771         * Scripts/build-webkit:
772         Move the Windows code out of the for loop iterating over each subdirectory to be build.
773         They're built all at once.
774         * Scripts/webkitdirs.pm:
775         (buildVisualStudioProject):
776         (cmakeGeneratedBuildfile):
777         Don't generate the Visual Studio solution if it already exists.
778         It will run CMake again if necessary.
779
780 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
781
782         [iOS WK2] WTR fails to set the key window in the UIKit sense
783         https://bugs.webkit.org/show_bug.cgi?id=149325
784
785         Reviewed by Tim Horton.
786
787         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
788         This causes UIKit to bypass code that actually sets the key window, resulting in
789         [UIAppliation sharedApplication].keyWindow always being nil.
790
791         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
792         -[WebKitTestRunnerWindow isKeyWindow] call super.
793
794         * WebKitTestRunner/PlatformWebView.h:
795         (WTR::PlatformWebView::setWindowIsKey): Deleted.
796         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
797         (WTR::PlatformWebView::setWindowIsKey):
798         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
799         (WTR::PlatformWebView::setWindowIsKey):
800         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
801         (-[WebKitTestRunnerWindow isKeyWindow]):
802         (WTR::PlatformWebView::PlatformWebView):
803         (WTR::PlatformWebView::~PlatformWebView):
804         (WTR::PlatformWebView::setWindowIsKey):
805         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
806         (WTR::PlatformWebView::setWindowIsKey):
807
808 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
809
810         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
811         https://bugs.webkit.org/show_bug.cgi?id=149321
812
813         Reviewed by Tim Horton.
814         
815         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
816         enabled the "testing" viewport configuration, which disables page scaling.
817         
818         If we're running viewport tests, we want the normal web page configuration.
819         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
820         based on whether the test is in a "viewport" directory.
821
822         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
823         (WTR::InjectedBundle::beginTesting):
824         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
825         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
826         * WebKitTestRunner/TestInvocation.cpp:
827         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
828         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
829         (WTR::TestInvocation::shouldMakeViewportFlexible):
830         (WTR::TestInvocation::invoke):
831         * WebKitTestRunner/TestInvocation.h:
832         * WebKitTestRunner/ios/TestControllerIOS.mm:
833         (WTR::TestController::platformConfigureViewForTest):
834         (WTR::shouldMakeViewportFlexible): Deleted.
835
836 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
837
838         Give iOS WebKitTestRunner a launch storyboard
839         https://bugs.webkit.org/show_bug.cgi?id=149314
840
841         Reviewed by Dan Bates.
842         
843         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
844         that it's been built for specific device configurations, and puts the window
845         at the top of the screen. This simplifies coordinate conversions in a future patch.
846
847         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
848         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
849         * WebKitTestRunner/ios/Launch.storyboard: Added.
850
851 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
852
853         Update licence in r189890
854         https://bugs.webkit.org/show_bug.cgi?id=149306
855
856         Reviewed by Dean Jackson.
857
858         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
859         * FontWithFeatures/FontWithFeatures/FontCreator.h:
860         * FontWithFeatures/FontWithFeatures/main.cpp:
861
862 2015-09-17  Mark Lam  <mark.lam@apple.com>
863
864         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
865         https://bugs.webkit.org/show_bug.cgi?id=149285
866
867         Reviewed by Saam Barati.
868
869         Just need to add an option to pass --no-jit to run-jsc-stress-test.
870
871         * Scripts/run-javascriptcore-tests:
872         (runJSCStressTests):
873
874 2015-09-17  Alex Christensen  <achristensen@webkit.org>
875
876         Switch AppleWin build to use CMake
877         https://bugs.webkit.org/show_bug.cgi?id=149163
878
879         Reviewed by Brent Fulgham.
880
881         * Scripts/build-webkit:
882         * Scripts/run-api-tests:
883         (runTest):
884         (listAllTests):
885         (prepareEnvironmentForRunningTestTool):
886         (testToolPaths):
887         (testToolPath): Deleted.
888         Run the API tests as separate executables on Windows.
889         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
890         * Scripts/webkitdirs.pm:
891         (checkRequiredSystemConfig):
892         (jhbuildWrapperPrefixIfNeeded):
893         (generateBuildSystemFromCMakeProject):
894         Fix configuration quirks.
895
896 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
897
898         Added toggle options for hiding and showing certain platform families on the dashboard.
899         https://bugs.webkit.org/show_bug.cgi?id=148403
900
901         Reviewed by David Kilzer.
902
903         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
904         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
905         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
906         in lieu of an "all" button in the toggle menu.
907
908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
909         (parsePlatformFamily): Helper function to parse out a platform family.
910         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
911         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
912         (updateToggleButtons): Updates the status of the toggle buttons.
913         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
914         (documentReady): Added creation of toggle buttons.
915         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
916         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
917         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
918         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
919         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
921         (QueueView): Updated to use hiddenPlatformFamilies.
922         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
924         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
925         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
926         (Settings.prototype.toggleHiddenPlatform): Deleted.
927         (Settings.prototype.clearHiddenPlatforms): Deleted.
928         (Settings.prototype.toggleShowPlatformFamily): Deleted.
929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
930         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
931         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
932         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
933         (table.queue-grid tr.headers th):
934         (div.settingsWrapper.hide):
935         (div.settingsWrapper):
936         (div.familyToggleWrapper):
937         (div.platformFamilyToggleButton):
938         (div.platformFamilyShowToggleButton:not(:last-child)):
939         (div.familyShown):
940         (div.accessibilityButton):
941         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
942         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
943         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
944         platformFamilyToggleButton and settingsWrapper class.
945         (.accessibilityButton): Deleted.
946
947 2015-09-17  Tim Horton  <timothy_horton@apple.com>
948
949         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
950         https://bugs.webkit.org/show_bug.cgi?id=148904
951
952         Reviewed by Myles Maxfield.
953
954         * WebKitTestRunner/TestController.cpp:
955         (WTR::parseBooleanTestHeaderValue):
956         (WTR::updateViewOptionsFromTestHeader):
957         Check for the key "useThreadedScrolling".
958         Add some code to check for "true" and "false" for boolean options.
959
960         (WTR::TestController::viewOptionsForTest):
961         Apply the test's overrides last, even after the platform's.
962
963 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
964
965         printing does not use minimum page zoom factor
966         https://bugs.webkit.org/show_bug.cgi?id=108507
967
968         Reviewed by Darin Adler.
969
970         WebKitTestRunner always takes the snapshots from the UI process
971         (expect for IOS), so in the case of printing, the layout in the
972         web view is not the expected one. When printing, we need to take
973         the snapshot in the web process and ensure it's rendered with a
974         PrintContext.
975
976         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
977         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
978         kWKSnapshotOptionsPrinting option to
979         WKBundlePageCreateSnapshotWithOptions() when printing. When not
980         printing, don't even create the snapshot, since it will be ignored
981         by the UI process that always creates its own from the WebView (expect for IOS platform)
982         * WebKitTestRunner/TestInvocation.cpp:
983         (WTR::TestInvocation::dumpResults): Use always the snapshot image
984         received from the web process if any when comparing pixel
985         results. Now we only receive a snapshot from the web process in
986         case of printing, or when platform is IOS. Otherwhise, generate
987         the snapshot from the WebView as usual.
988         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
989         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
990         is created by the caller now, but the CG implementation needs to
991         know if it's a Web or UI process snapshot.
992         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
993         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
994         cairo surface for the given image.
995         * WebKitTestRunner/cg/TestInvocationCG.cpp:
996         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
997         CGContext for the given image.
998
999 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1000
1001         Create a font which can be used for testing font features
1002         https://bugs.webkit.org/show_bug.cgi?id=149237
1003
1004         Reviewed by Simon Fraser.
1005
1006         This patch adds a new project in the Tools/ directory which generates a font which can
1007         be used for testing font features. This is a standalone project consisting of two files:
1008         1. A file which actually generates the byte vector representing the font. This file has
1009         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1010         specific, and only relies on the C++ STL.
1011         2. A file with a main() which calls generateFont() and writes out the font, as well as
1012         uses the font to render some demonstration text into a .png file. This file is platform
1013         specific.
1014
1015         The font itself only supports the following characters:
1016         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1017         However, the shape of these letters are either an X or a check mark.
1018
1019         The letter "A" always is a check mark.
1020         The letter "B" always is an X.
1021         Without any font features turned on, the rest of the letters are shown as X.
1022
1023         Each font feature has an letter associated with it. When the font feature is enabled,
1024         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1025         as a check mark.
1026
1027         Here are the mappings of font features to letters:
1028         liga: C
1029         clig: D
1030         dlig: E
1031         hlig: F
1032         calt: G
1033         subs: H
1034         sups: I
1035         smcp: J
1036         c2sc: K
1037         pcap: L
1038         c2pc: M
1039         unic: N
1040         titl: O
1041         onum: P
1042         pnum: Q
1043         tnum: R
1044         frac: S
1045         afrc: T
1046         ordn: U
1047         zero: V
1048         hist: W
1049         jp78: X
1050         jp83: Y
1051         jp90: Z
1052         jp04: a
1053         smpl: b
1054         trad: c
1055         fwid: d
1056         pwid: e
1057         ruby: f
1058
1059         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1060         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1061         (integralLog2):
1062         (roundDownToPowerOfTwo):
1063         (isFourByteAligned):
1064         (clampTo):
1065         (append32):
1066         (writeCFFEncodedNumber):
1067         (CFFBuilder::CFFBuilder):
1068         (CFFBuilder::takeResult):
1069         (CFFBuilder::moveTo):
1070         (CFFBuilder::lineTo):
1071         (CFFBuilder::curveToCubic):
1072         (CFFBuilder::closePath):
1073         (CFFBuilder::writePoint):
1074         (generateBoxCharString):
1075         (generateCheckCharString):
1076         (generateXCharString):
1077         (charStringForGlyph):
1078         (Generator::generate):
1079         (Generator::Placeholder::Placeholder):
1080         (Generator::Placeholder::populate):
1081         (Generator::Placeholder::~Placeholder):
1082         (Generator::placeholder):
1083         (Generator::append16):
1084         (Generator::append32):
1085         (Generator::append32BitCode):
1086         (Generator::overwrite16):
1087         (Generator::overwrite32):
1088         (Generator::appendCFFTable):
1089         (Generator::appendSubstitutionSubtable):
1090         (Generator::appendScriptSubtable):
1091         (Generator::appendGSUBTable):
1092         (Generator::appendOS2Table):
1093         (Generator::appendFormat12CMAPTable):
1094         (Generator::appendFormat4CMAPTable):
1095         (Generator::appendCMAPTable):
1096         (Generator::appendHEADTable):
1097         (Generator::appendHHEATable):
1098         (Generator::appendHMTXTable):
1099         (Generator::appendMAXPTable):
1100         (Generator::appendNAMETable):
1101         (Generator::appendPOSTTable):
1102         (Generator::calculateChecksum):
1103         (Generator::appendTable):
1104         (generateFont):
1105         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1106         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1107         (drawTextWithFeature):
1108         (main):
1109
1110 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1111
1112         Unreviewed, rolling out r189875 and r189878.
1113         https://bugs.webkit.org/show_bug.cgi?id=149235
1114
1115         cygwin cmake build not ready yet (Requested by alexchristensen
1116         on #webkit).
1117
1118         Reverted changesets:
1119
1120         "Switch AppleWin build to use CMake"
1121         https://bugs.webkit.org/show_bug.cgi?id=149163
1122         http://trac.webkit.org/changeset/189875
1123
1124         "Cygwin build fix after r189875"
1125         http://trac.webkit.org/changeset/189878
1126
1127 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1128
1129         Cygwin build fix after r189875
1130
1131         * Scripts/build-webkit:
1132         * Scripts/webkitdirs.pm:
1133         (jhbuildWrapperPrefixIfNeeded):
1134         (generateBuildSystemFromCMakeProject):
1135         Make things work with cygwin and cmake.
1136
1137 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1138
1139         Switch AppleWin build to use CMake
1140         https://bugs.webkit.org/show_bug.cgi?id=149163
1141
1142         Reviewed by Brent Fulgham.
1143
1144         * Scripts/build-webkit:
1145         Build with CMake.
1146         * Scripts/run-api-tests:
1147         (runTest):
1148         (listAllTests):
1149         (prepareEnvironmentForRunningTestTool):
1150         (testToolPaths):
1151         (testToolPath): Deleted.
1152         Run the API tests as separate executables on Windows.
1153         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1154
1155 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1156
1157         Add newer build.webkit.org pages to robots.txt
1158         https://bugs.webkit.org/show_bug.cgi?id=149219
1159
1160         Reviewed by Darin Adler.
1161
1162         Indexing bot watcher's dashboard can't be good.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1165
1166 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1167
1168         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1169
1170         * BuildSlaveSupport/built-product-archive:
1171         (unzipArchive):
1172
1173 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1174
1175         [EFL] Fix the help message of separated web process option of MiniBrowser
1176         https://bugs.webkit.org/show_bug.cgi?id=149212
1177
1178         Reviewed by Gyuyoung Kim.
1179
1180         * MiniBrowser/efl/main.c:
1181
1182 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1183
1184         Fix python syntax after r189851.
1185
1186         * BuildSlaveSupport/built-product-archive:
1187         (unzipArchive):
1188         For loops need a colon.
1189
1190 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1191
1192         Fix Windows test bots after changing to non-cygwin build
1193         https://bugs.webkit.org/show_bug.cgi?id=149196
1194
1195         Reviewed by Daniel Bates.
1196
1197         * BuildSlaveSupport/built-product-archive:
1198         (unzipArchive):
1199         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1200         prevent us from executing files from the archive on the test bots.
1201
1202 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1203
1204         Add ShadowRoot interface and Element.prototype.attachShadow
1205         https://bugs.webkit.org/show_bug.cgi?id=149187
1206
1207         Reviewed by Antti Koivisto.
1208
1209         * Scripts/webkitperl/FeatureList.pm:
1210
1211 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1212
1213         Appscale queue status json output lacks bots
1214         https://bugs.webkit.org/show_bug.cgi?id=149194
1215         <rdar://problem/22171089>
1216
1217         Reviewed by Alexey Proskuryakov.
1218
1219         * QueueStatusServer/handlers/queuestatusjson.py:
1220         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1221         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1222
1223 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1224
1225         [Win] Provide a means for viewing the layer tree
1226         https://bugs.webkit.org/show_bug.cgi?id=149165
1227
1228         Reviewed by Simon Fraser.
1229
1230         Update MiniBrowser with a new Debug menu option that will
1231         dump the current layer tree to the debug console.
1232         
1233         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1234         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1235         * MiniBrowser/win/Common.cpp:
1236         (WndProc): Add handler for 'Print Layer Tree' menu option.
1237         * MiniBrowser/win/MiniBrowser.cpp:
1238         (MiniBrowser::printLayerTree): Added Handler.
1239         * MiniBrowser/win/MiniBrowser.h:
1240
1241 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
1242
1243         WebKitTestRunner declarative language setting is broken for iOS
1244         https://bugs.webkit.org/show_bug.cgi?id=149119
1245
1246         Unreviewed.
1247
1248         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
1249         lost in the final version which got committed. This simply implements the existing
1250         OS X behavior on iOS.
1251
1252         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1253         (WTR::InjectedBundle::platformInitialize):
1254
1255 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
1256
1257         Unreviewed, add myself to committers list.
1258
1259         * Scripts/webkitpy/common/config/contributors.json:
1260
1261 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1262
1263         [Cocoa] Allow testing with the system language
1264         https://bugs.webkit.org/show_bug.cgi?id=148671
1265
1266         Reviewed by Anders Carlsson and Alexey Proskuryakov.
1267
1268         React to tests marked with language=lang1,lang2,etc in their header.
1269         Once this information is parsed, pass it to
1270         WKContextConfigurationSetOverrideLanguages().
1271
1272         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1273         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
1274         list.
1275         * WebKitTestRunner/TestController.cpp:
1276         (WTR::TestController::createWebViewWithOptions): Call
1277         WKContextConfigurationSetOverrideLanguages().
1278         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
1279         * WebKitTestRunner/TestOptions.h:
1280         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1281         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
1282         option to restart the web process.
1283         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1284         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
1285
1286 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1287
1288         [WKTR] Allow changing the WKContextConfiguration between successive tests
1289         https://bugs.webkit.org/show_bug.cgi?id=148833
1290
1291         Reviewed by Tim Horton.
1292
1293         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1294         However, there are certain tests which require specifying options in this object. This patch makes
1295         our existing code for recreating the test runner web view also recreate the WKContext.
1296
1297         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1298         class.
1299
1300         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1301         * WebKitTestRunner/PlatformWebView.h:
1302         (WTR::PlatformWebView::options):
1303         * WebKitTestRunner/TestController.cpp:
1304         (WTR::TestController::initialize):
1305         (WTR::TestController::generateContextConfiguration):
1306         (WTR::TestController::generatePageConfiguration):
1307         (WTR::TestController::createWebViewWithOptions):
1308         (WTR::TestController::ensureViewSupportsOptionsForTest):
1309         (WTR::updateContextConfigurationOptionsFromTestHeader):
1310         (WTR::TestController::contextConfigurationOptionsForTest):
1311         (WTR::TestController::platformCreateWebView):
1312         (WTR::TestController::platformCreateOtherPage):
1313         (WTR::updateViewOptionsFromTestHeader): Deleted.
1314         (WTR::TestController::viewOptionsForTest): Deleted.
1315         * WebKitTestRunner/TestController.h:
1316         (WTR::TestController::injectedBundlePath):
1317         (WTR::TestController::testPluginDirectory):
1318         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1319         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1320         (WTR::TestController::platformCreateWebView):
1321         (WTR::TestController::platformCreateOtherPage):
1322         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1323         (WTR::PlatformWebView::PlatformWebView):
1324         (WTR::PlatformWebView::viewSupportsOptions):
1325         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1326         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1327         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1328         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1329         (WTR::PlatformWebView::PlatformWebView):
1330         (WTR::PlatformWebView::viewSupportsOptions):
1331         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1332         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1333         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1334         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1335         (WTR::PlatformWebView::PlatformWebView):
1336         (WTR::PlatformWebView::viewSupportsOptions):
1337         * WebKitTestRunner/ios/TestControllerIOS.mm:
1338         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1339         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1340         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1341         (WTR::PlatformWebView::PlatformWebView):
1342         (WTR::PlatformWebView::viewSupportsOptions):
1343         * WebKitTestRunner/mac/TestControllerMac.mm:
1344         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1345         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1346
1347 2015-09-11  Michael Saboff  <msaboff@apple.com>
1348
1349         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
1350         https://bugs.webkit.org/show_bug.cgi?id=149083
1351
1352         Reviewed by Alexey Proskuryakov.
1353
1354         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
1355
1356         * DumpRenderTree/mac/LayoutTestHelper.m:
1357         (colorProfileURLForDisplay):
1358
1359 2015-09-11  Saam barati  <sbarati@apple.com>
1360
1361         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
1362         https://bugs.webkit.org/show_bug.cgi?id=149058
1363
1364         Reviewed by Geoffrey Garen.
1365
1366         * Scripts/run-jsc-stress-tests:
1367
1368 2015-09-10  Commit Queue  <commit-queue@webkit.org>
1369
1370         Unreviewed, rolling out r189595.
1371         https://bugs.webkit.org/show_bug.cgi?id=149052
1372
1373         The tests still fail (Requested by ap on #webkit).
1374
1375         Reverted changeset:
1376
1377         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
1378         error -1"
1379         https://bugs.webkit.org/show_bug.cgi?id=142929
1380         http://trac.webkit.org/changeset/189595
1381
1382 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
1383
1384         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
1385         https://bugs.webkit.org/show_bug.cgi?id=142929
1386
1387         Reviewed by Brent Fulgham.
1388
1389         Silence the logging. We'll track fixing the root cause in Radar.
1390
1391         * Scripts/webkitpy/port/mac.py:
1392         (MacPort.stderr_patterns_to_strip): Added a FIXME.
1393
1394         * Scripts/webkitpy/port/win.py:
1395         (WinPort.logging_patterns_to_strip): Added.
1396
1397 2015-09-09  Andy Estes  <aestes@apple.com>
1398
1399         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
1400         https://bugs.webkit.org/show_bug.cgi?id=149022
1401
1402         Reviewed by Daniel Bates.
1403
1404         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
1405         did not account for this.
1406
1407         * Scripts/webkitpy/xcode/simulator.py:
1408         (Simulator): Optionally matched a revision at the end of a runtime version number.
1409         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
1410
1411 2015-09-09  Andy Estes  <aestes@apple.com>
1412
1413         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
1414         https://bugs.webkit.org/show_bug.cgi?id=149029
1415         <rdar://problem/22432624>
1416
1417         Reviewed by Daniel Bates.
1418
1419         * Scripts/webkitpy/xcode/simulator.py:
1420         (Simulator): Taught to parse tvOS runtimes.
1421         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1422
1423 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1424
1425         Fix bit rot on bot watcher's dashboard page
1426         https://bugs.webkit.org/show_bug.cgi?id=149012
1427
1428         Reviewed by Tim Horton.
1429
1430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1431         The code path used by the metrics page was trying to add properties to an undefined.
1432
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1434         Silence an expection that would occur when the step has no logs. This should never
1435         happen, but it did (perhaps buildbot was misconfigured for a while).
1436
1437 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1438
1439         Update LayoutTestRelay xcconfig file.
1440
1441         Rubber-stamped by Dan Bernstein.
1442
1443         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1444
1445 2015-09-09  Saam barati  <sbarati@apple.com>
1446
1447         DFG should have a debugging option that runs a phase that flushes all locals
1448         https://bugs.webkit.org/show_bug.cgi?id=148916
1449
1450         Reviewed by Filip Pizlo.
1451
1452         * Scripts/run-jsc-stress-tests:
1453
1454 2015-09-09  Commit Queue  <commit-queue@webkit.org>
1455
1456         Unreviewed, rolling out r189530 and r189534.
1457         https://bugs.webkit.org/show_bug.cgi?id=148996
1458
1459         Caused assertion failures on Yosemite (Requested by litherum
1460         on #webkit).
1461
1462         Reverted changesets:
1463
1464         "[WKTR] Allow changing the WKContextConfiguration between
1465         successive tests"
1466         https://bugs.webkit.org/show_bug.cgi?id=148833
1467         http://trac.webkit.org/changeset/189530
1468
1469         "[Cocoa] Fix the tests after r189530"
1470         http://trac.webkit.org/changeset/189534
1471
1472 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1473
1474         [Cocoa] Fix the tests after r189530
1475
1476         Unreviewed.
1477
1478         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1479         (WTR::initializeWebViewConfiguration):
1480
1481 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1482
1483         [WKTR] Allow changing the WKContextConfiguration between successive tests
1484         https://bugs.webkit.org/show_bug.cgi?id=148833
1485
1486         Reviewed by Tim Horton.
1487
1488         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1489         However, there are certain tests which require specifying options in this object. This patch makes
1490         our existing code for recreating the test runner web view also recreate the WKContext.
1491
1492         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1493         class.
1494
1495         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1496         * WebKitTestRunner/PlatformWebView.h:
1497         (WTR::PlatformWebView::options):
1498         * WebKitTestRunner/TestController.cpp:
1499         (WTR::TestController::initialize):
1500         (WTR::TestController::generateContextConfiguration):
1501         (WTR::TestController::generatePageConfiguration):
1502         (WTR::TestController::createWebViewWithOptions):
1503         (WTR::TestController::ensureViewSupportsOptionsForTest):
1504         (WTR::updateContextConfigurationOptionsFromTestHeader):
1505         (WTR::TestController::contextConfigurationOptionsForTest):
1506         (WTR::TestController::platformCreateWebView):
1507         (WTR::TestController::platformCreateOtherPage):
1508         (WTR::updateViewOptionsFromTestHeader): Deleted.
1509         (WTR::TestController::viewOptionsForTest): Deleted.
1510         * WebKitTestRunner/TestController.h:
1511         (WTR::TestController::injectedBundlePath):
1512         (WTR::TestController::testPluginDirectory):
1513         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1514         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1515         (WTR::TestController::platformCreateWebView):
1516         (WTR::TestController::platformCreateOtherPage):
1517         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1518         (WTR::PlatformWebView::PlatformWebView):
1519         (WTR::PlatformWebView::viewSupportsOptions):
1520         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1521         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1522         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1523         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1524         (WTR::PlatformWebView::PlatformWebView):
1525         (WTR::PlatformWebView::viewSupportsOptions):
1526         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1527         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1528         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1529         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1530         (WTR::PlatformWebView::PlatformWebView):
1531         (WTR::PlatformWebView::viewSupportsOptions):
1532         * WebKitTestRunner/ios/TestControllerIOS.mm:
1533         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1534         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1535         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1536         (WTR::PlatformWebView::PlatformWebView):
1537         (WTR::PlatformWebView::viewSupportsOptions):
1538         * WebKitTestRunner/mac/TestControllerMac.mm:
1539         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1540         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1541
1542 2015-09-08  Daniel Bates  <dabates@apple.com>
1543
1544         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
1545         https://bugs.webkit.org/show_bug.cgi?id=148980
1546
1547         Reviewed by Alexey Proskuryakov.
1548
1549         Add setting to enable/disable accelerated drawing so as to support testing
1550         this feature in MiniBrowser on Mac.
1551
1552         * MiniBrowser/mac/SettingsController.h:
1553         * MiniBrowser/mac/SettingsController.m:
1554         (-[SettingsController _populateMenu]): Add menu item.
1555         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
1556         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
1557         (-[SettingsController acceleratedDrawingEnabled]): Added.
1558         * MiniBrowser/mac/WK1BrowserWindowController.m:
1559         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
1560         * MiniBrowser/mac/WK2BrowserWindowController.m:
1561         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
1562
1563 2015-09-08  Jason Marcell  <jmarcell@apple.com>
1564
1565         Unreviewed. Added myself as a commiter in contributors.json.
1566
1567         * Scripts/webkitpy/common/config/contributors.json:
1568
1569 2015-09-08  Keith Miller  <keith_miller@apple.com>
1570
1571         Unreviewed, added myself to the list of contributors.
1572
1573         * Scripts/webkitpy/common/config/contributors.json:
1574
1575 2015-09-08  Daniel Bates  <dabates@apple.com>
1576
1577         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
1578         https://bugs.webkit.org/show_bug.cgi?id=148921
1579
1580         Reviewed by Alexey Proskuryakov.
1581
1582         The ring image is positioned above the platform icon in markup and we specify the CSS
1583         property z-index for the ring image so that it is painted on top of the platform icon
1584         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
1585         of the ring image, switch the order of these DOM elements and remove the use of the CSS
1586         property z-index to achieve a similar effect.
1587
1588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1589         (documentReady): Create the platform icon image element before the ring image such that
1590         the ring image is painted on top of the platform icon.
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1592         (table.queue-grid td.logo img.ring): Removed property z-index.
1593
1594 2015-09-08  Daniel Bates  <dabates@apple.com>
1595
1596         Dashboard: Remove duplicate gear icon data URLs
1597         https://bugs.webkit.org/show_bug.cgi?id=148920
1598
1599         Reviewed by Alexey Proskuryakov.
1600
1601         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
1602         background-image associated with each of the three gear icon states: collapsed (.settings), hover
1603         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
1604         as a mask and make use of the CSS background-color to define the fill color for each of these three
1605         states.
1606
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1608         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
1609         (.settings:hover): Override CSS background-color for hover state.
1610         (.settings-visible .settings): Override CSS background-color for expanded state.
1611
1612 2015-09-07  Andy Estes  <aestes@apple.com>
1613
1614         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
1615         https://bugs.webkit.org/show_bug.cgi?id=148946
1616         <rdar://problem/22603981>
1617
1618         Reviewed by Dan Bernstein.
1619
1620         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1621         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1622
1623 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
1624
1625         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
1626         https://bugs.webkit.org/show_bug.cgi?id=148927
1627
1628         Reviewed by Csaba Osztrogonác.
1629
1630         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1631         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
1632
1633         * WebKitTestRunner/TestController.cpp:
1634         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
1635         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1636         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
1637
1638 2015-09-07  Andy Estes  <aestes@apple.com>
1639
1640         Fix the Production build after r189455.
1641
1642         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
1643         In-App Purchase template instead of the Aggregate template. Whoops.
1644
1645 2015-09-06  Andy Estes  <aestes@apple.com>
1646
1647         WebKit.xcworkspace should be be able to build iOS platforms
1648         https://bugs.webkit.org/show_bug.cgi?id=148881
1649
1650         Reviewed by Daniel Bates.
1651
1652         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
1653         for all supported platforms.
1654
1655         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
1656         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
1657         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
1658         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
1659
1660 2015-09-06  Andy Estes  <aestes@apple.com>
1661
1662         WebKitTestRunner should build for iOS using the default target
1663         https://bugs.webkit.org/show_bug.cgi?id=148918
1664
1665         Reviewed by Daniel Bates.
1666
1667         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
1668         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
1669         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
1670
1671         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
1672         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
1673         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
1674         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
1675         WebKitTestRunner is skipped when installing on iOS.
1676
1677         The target dependency graph now looks like this:
1678
1679             All
1680                 WebKitTestRunnerApp
1681                     WebKitTestRunner (Library)
1682                         WebKitTestRunnerInjectedBundle
1683                             Derived Sources
1684                 WebKitTestRunner
1685                     WebKitTestRunner (Library)
1686                         WebKitTestRunnerInjectedBundle
1687                             Derived Sources
1688
1689         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
1690         * Scripts/build-webkittestrunner: Ditto.
1691         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
1692         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
1693         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
1694         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
1695         excluded iOS-only files, and skipped installing on iOS.
1696         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
1697         excluded Mac-only files, and skipped installing on Mac.
1698         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
1699         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
1700         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
1701         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
1702         new configuration files.
1703
1704 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
1705
1706         Web Inspector: Improve prepare-ChangeLog for multiple cases
1707         https://bugs.webkit.org/show_bug.cgi?id=148875
1708
1709         Reviewed by Timothy Hatcher.
1710
1711         * Scripts/prepare-ChangeLog:
1712         (get_function_line_ranges_for_javascript):
1713         - We were ignoring everything inside of an anonymous function expression,
1714           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
1715           Better handle this by inserting a few tweaks.
1716         - Allow method syntax outside of classes as long as they are at the global level.
1717         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
1718
1719         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1720         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1721         (Foo.prototype.method1):
1722         (Foo.prototype.method2):
1723         (Foo.prototype.method3.innerFunction):
1724         (Foo.prototype.method3):
1725         (insideGlobalAnonymousFunctionExpression):
1726         (foo.insideGlobalFunctionExpression):
1727         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
1728         (IssueWithMapGetAndSet.prototype.method1):
1729         (IssueWithMapGetAndSet.prototype.method2):
1730         (IssueWithMapGetAndSet.prototype.method3):
1731         (IssueWithMapGetAndSet):
1732
1733 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1734
1735         [ES6] Enable ES6 Module in JSC shell by default
1736         https://bugs.webkit.org/show_bug.cgi?id=148689
1737
1738         Reviewed by Geoffrey Garen.
1739
1740         * Scripts/run-javascriptcore-tests:
1741         (runJSCStressTests):
1742         * Scripts/run-jsc-stress-tests:
1743
1744 2015-09-04  Basile Clement  <basile_clement@apple.com>
1745
1746         Unreviewed, change my email address.
1747
1748         * Scripts/webkitpy/common/config/contributors.json:
1749
1750 2015-09-04  Beth Dakin  <bdakin@apple.com>
1751
1752         Should have a test to make sure links don't navigate after a cancelled force 
1753         click
1754         https://bugs.webkit.org/show_bug.cgi?id=148846
1755
1756         Reviewed by Tim Horton.
1757
1758         New EventSender function for a started then cancelled force click.
1759         * WebKitTestRunner/EventSenderProxy.h:
1760         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1761         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1762         (WTR::EventSendingController::mouseForceClick):
1763         (WTR::EventSendingController::startAndCancelMouseForceClick):
1764         (WTR::EventSendingController::mouseForceDown):
1765         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1766         * WebKitTestRunner/TestController.cpp:
1767         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1768         * WebKitTestRunner/mac/EventSenderProxy.mm:
1769         (WTR::EventSenderProxy::mouseForceClick):
1770         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
1771         (WTR::EventSenderProxy::mouseForceDown):
1772         (WTR::EventSenderProxy::mouseMoveTo):
1773
1774 2015-09-04  Tim Horton  <timothy_horton@apple.com>
1775
1776         Add a test for r179736 (programmatic navigation during swipe causing a crash)
1777         https://bugs.webkit.org/show_bug.cgi?id=148830
1778
1779         Reviewed by Beth Dakin.
1780
1781         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1782         (WTR::InjectedBundle::beginTesting):
1783         Make sure that TestRunner callbacks don't leak between tests!
1784
1785 2015-09-04  Anders Carlsson  <andersca@apple.com>
1786
1787         It should be possible to pass relative HTTP test paths to DumpRenderTree
1788         https://bugs.webkit.org/show_bug.cgi?id=148825
1789         <rdar://problem/22583866>
1790
1791         Reviewed by Tim Horton.
1792
1793         Convert the path to an absolute path if needed.
1794
1795         * DumpRenderTree/mac/DumpRenderTree.mm:
1796         (computeTestURL):
1797
1798 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1799
1800         Fix Swift unit tests for prepare-ChangeLog.
1801         https://bugs.webkit.org/show_bug.cgi?id=148817
1802
1803         Reviewed by Alexey Proskuryakov.
1804
1805         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
1806         Swift unit tests for prepare-ChangeLog.
1807
1808 2015-09-04  Lucas Forschler  <lforschler@apple.com>
1809
1810         Modifications to the webkit-nightly logic.
1811         
1812         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
1813         (updateAlertPanel):
1814         * WebKitLauncher/main.m:
1815         (displayErrorAndQuit):
1816
1817 2015-09-04  Beth Dakin  <bdakin@apple.com>
1818
1819         Speculative build fix.
1820
1821         * WebKitTestRunner/mac/EventSenderProxy.mm:
1822
1823 2015-09-04  Brian Burg  <bburg@apple.com>
1824
1825         Web Inspector: InspectorController should support multiple frontend channels
1826         https://bugs.webkit.org/show_bug.cgi?id=148538
1827
1828         Reviewed by Joseph Pecoraro.
1829
1830         InspectorClients must explicitly disconnect their frontend channel(s) from the
1831         inspected page's InspectorController.
1832
1833         To make this possible, DumpRenderTree should not destroy non-primary views until
1834         it has tried to close any abandoned Web Inspector instances. Performing teardown
1835         in the reverse order prevents disconnection of the frontend channel because that
1836         prematurely destroys the inspector frontend client.
1837
1838         * DumpRenderTree/mac/DumpRenderTree.mm:
1839         (runTest):
1840         * DumpRenderTree/win/DumpRenderTree.cpp:
1841         (runTest):
1842
1843 2015-09-04  Beth Dakin  <bdakin@apple.com>
1844
1845         Need to be able to test default behaviors on force click
1846         https://bugs.webkit.org/show_bug.cgi?id=148758
1847
1848         Reviewed by Tim Horton.
1849
1850         This patch adds a new eventSender method to do a full, completed force click, 
1851         and it re-works all of the existing force methods to dispatch their events in 
1852         such a way that they will trigger the NSImmediateAction gesture recognizer. 
1853         To do this, first we need to send the events to the app rather than straight 
1854         to the view, and also needed to tweak some state and send the events in a 
1855         delayed fashion.
1856
1857         New public function mouseForceClick() and private helper functions to make 
1858         NSEvents.
1859         * WebKitTestRunner/EventSenderProxy.h:
1860
1861         New public function mouseForceClick().
1862         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1863         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1864         (WTR::EventSendingController::mouseMoveTo):
1865         (WTR::EventSendingController::mouseForceClick):
1866         (WTR::EventSendingController::mouseForceDown):
1867         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1868         * WebKitTestRunner/TestController.cpp:
1869         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1870
1871         initPressureEventAtLocation needs to take a stageTransition and a window.
1872         * WebKitTestRunner/mac/EventSenderProxy.mm:
1873         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1874         (-[EventSenderSyntheticEvent stageTransition]):
1875         (-[EventSenderSyntheticEvent timestamp]):
1876         (-[EventSenderSyntheticEvent _cgsEventRecord]):
1877         (-[EventSenderSyntheticEvent window]):
1878
1879         In order to enter the gesture recognizer, we need to start with a mouse down 
1880         that has a NSEventMaskPressure modifier.
1881         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
1882
1883         This ensures that the events queue properly for the force monitor in AppKit.
1884         (WTR::spinRunLoopForForce):
1885
1886          We need to start the pressure change events with a began.
1887         (WTR::EventSenderProxy::beginPressureEvent):
1888
1889         These functions can be used to create the NSEvent for a pressure change every 
1890         time we need one.
1891         (WTR::EventSenderProxy::pressureChangeEvent):
1892
1893         Send the right series of events to emulate a full, completed force click.
1894         (WTR::EventSenderProxy::mouseForceClick):
1895
1896         Use all of the new things for these existing functions.
1897         (WTR::EventSenderProxy::mouseForceDown):
1898         (WTR::EventSenderProxy::mouseForceUp):
1899         (WTR::EventSenderProxy::mouseForceChanged):
1900
1901         Set NSFakeForceTouchDevice to YES.
1902         * WebKitTestRunner/mac/main.mm:
1903         (setDefaultsToConsistentValuesForTesting):
1904
1905 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1906
1907         prepare-ChangeLog needs to know how to parse Swift files.
1908         https://bugs.webkit.org/show_bug.cgi?id=148784
1909         <rdar://problem/22510062>
1910
1911         Reviewed by Darin Adler.
1912
1913         * Scripts/prepare-ChangeLog:
1914         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
1915         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
1916         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
1917         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
1918         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
1919         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
1920         (freeFunction): Ditto.
1921         (MyClass.function): Ditto.
1922         (MyClass.functionWithArgument(_:)): Ditto.
1923         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
1924         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
1925         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
1926         (MyClass.classFunction): Ditto.
1927         (MyClass.readWriteComputedVariable): Ditto.
1928         (MyClass.readOnlyComputedVariable): Ditto.
1929
1930 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
1931
1932         Import css/css-color-3
1933         https://bugs.webkit.org/show_bug.cgi?id=148803
1934
1935         Reviewed by Chris Dumez.
1936
1937         Fixed a bug that the imported reference files used the same extention as tests.
1938         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
1939
1940         * Scripts/webkitpy/w3c/test_importer.py:
1941         (TestImporter.find_importable_tests):
1942
1943 2015-09-03  Commit Queue  <commit-queue@webkit.org>
1944
1945         Unreviewed, rolling out r189338.
1946         https://bugs.webkit.org/show_bug.cgi?id=148785
1947
1948         Caused tons of crashes (Requested by cdumez on #webkit).
1949
1950         Reverted changeset:
1951
1952         "Web Inspector: InspectorController should support multiple
1953         frontend channels"
1954         https://bugs.webkit.org/show_bug.cgi?id=148538
1955         http://trac.webkit.org/changeset/189338
1956
1957 2015-09-03  Brian Burg  <bburg@apple.com>
1958
1959         Web Inspector: InspectorController should support multiple frontend channels
1960         https://bugs.webkit.org/show_bug.cgi?id=148538
1961
1962         Reviewed by Joseph Pecoraro.
1963
1964         InspectorClients must explicitly disconnect their frontend channel(s) from the
1965         inspected page's InspectorController.
1966
1967         To make this possible, DumpRenderTree should not destroy non-primary views until
1968         it has tried to close any abandoned Web Inspector instances. Performing teardown
1969         in the reverse order prevents disconnection of the frontend channel because that
1970         prematurely destroys the inspector frontend client.
1971
1972         * DumpRenderTree/mac/DumpRenderTree.mm:
1973         (runTest):
1974         * DumpRenderTree/win/DumpRenderTree.cpp:
1975         (runTest):
1976
1977 2015-09-03  Timothy Hatcher  <timothy@apple.com>
1978
1979         Update WebKit nightly icon to be more like Safari
1980         https://bugs.webkit.org/show_bug.cgi?id=148768
1981
1982         Reviewed by Joseph Pecoraro.
1983
1984         * WebKitLauncher/webkit.icns:
1985
1986 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
1987
1988         JavaScriptCore should have some ES6 conformance tests
1989         https://bugs.webkit.org/show_bug.cgi?id=148771
1990
1991         Reviewed by Chris Dumez.
1992
1993         * Scripts/run-javascriptcore-tests:
1994         (runJSCStressTests): Added es6 as a test suite.
1995
1996         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
1997
1998         Some of these tests currently fail, so I also added a way to expect
1999         failure for now. We'll migrate failing tests to expected passes as we
2000         fix them.
2001
2002 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2003
2004         Add a test for swipe-start hysteresis
2005         https://bugs.webkit.org/show_bug.cgi?id=148756
2006
2007         Reviewed by Anders Carlsson.
2008
2009         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2010         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2011         (WTR::cacheTestRunnerCallback):
2012         (WTR::TestRunner::clearTestRunnerCallbacks):
2013         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2014         Make sure that we log if a client tries to install a callback twice
2015         (since we use .add, the second call would not work).
2016
2017         Also, add clearTestRunnerCallbacks so tests can swap out installed
2018         callbacks.
2019
2020 2015-09-03  Anders Carlsson  <andersca@apple.com>
2021
2022         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2023         https://bugs.webkit.org/show_bug.cgi?id=148746
2024         rdar://problem/22568073
2025
2026         Reviewed by Tim Horton.
2027
2028         * DumpRenderTree/mac/DumpRenderTree.mm:
2029         (computeTestURL):
2030         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
2031
2032         (runTest):
2033         Call computeTestURL.
2034
2035         (testPathFromURL):
2036         Get rid of this; computeTestURL does this for us now.
2037
2038         * Scripts/webkitpy/port/driver.py:
2039         (Driver._command_from_driver_input):
2040         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2041
2042 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2043
2044         Swipe tests fail on Mavericks
2045         https://bugs.webkit.org/show_bug.cgi?id=148752
2046
2047         Reviewed by Beth Dakin.
2048
2049         * WebKitTestRunner/mac/EventSenderProxy.mm:
2050
2051 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2052
2053         Fix the 32-bit build
2054
2055         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2056         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2057
2058 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2059
2060         Remove some logging that wasn't meant to be in the tree
2061
2062         * WebKitTestRunner/mac/EventSenderProxy.mm:
2063         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2064
2065 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2066
2067         [Mac] Add support for testing swipes
2068         https://bugs.webkit.org/show_bug.cgi?id=148700
2069
2070         Reviewed by Beth Dakin.
2071
2072         * WebKitTestRunner/EventSenderProxy.h:
2073         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2074         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2075         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2076         (WTR::cgEventPhaseFromString):
2077         (WTR::cgEventMomentumPhaseFromString):
2078         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2079         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2080         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2081         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2082         (WTR::InjectedBundle::didReceiveMessageToPage):
2083         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2084         (WTR::TestRunner::installDidBeginSwipeCallback):
2085         (WTR::TestRunner::installWillEndSwipeCallback):
2086         (WTR::TestRunner::installDidEndSwipeCallback):
2087         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2088         (WTR::TestRunner::callDidBeginSwipeCallback):
2089         (WTR::TestRunner::callWillEndSwipeCallback):
2090         (WTR::TestRunner::callDidEndSwipeCallback):
2091         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2092         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2093         * WebKitTestRunner/TestController.cpp:
2094         (WTR::TestController::createOtherPage):
2095         (WTR::TestController::createWebViewWithOptions):
2096         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2097         (WTR::TestController::didBeginNavigationGesture):
2098         (WTR::TestController::willEndNavigationGesture):
2099         (WTR::TestController::didEndNavigationGesture):
2100         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2101         * WebKitTestRunner/TestController.h:
2102         * WebKitTestRunner/TestInvocation.cpp:
2103         (WTR::TestInvocation::didBeginSwipe):
2104         (WTR::TestInvocation::willEndSwipe):
2105         (WTR::TestInvocation::didEndSwipe):
2106         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2107         * WebKitTestRunner/TestInvocation.h:
2108         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2109         when the snapshot is removed.
2110
2111         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2112         mouseScrollBy function.
2113
2114         * WebKitTestRunner/mac/EventSenderProxy.mm:
2115         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2116         (-[EventSenderSyntheticEvent type]):
2117         (-[EventSenderSyntheticEvent subtype]):
2118         (-[EventSenderSyntheticEvent locationInWindow]):
2119         (-[EventSenderSyntheticEvent location]):
2120         (-[EventSenderSyntheticEvent momentumPhase]):
2121         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2122         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2123         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2124         more adjustable values.
2125
2126         (WTR::EventSenderProxy::mouseForceDown):
2127         (WTR::EventSenderProxy::mouseForceUp):
2128         (WTR::EventSenderProxy::mouseForceChanged):
2129         Adopt EventSenderSyntheticEvent.
2130
2131         (WTR::nsEventPhaseFromCGEventPhase):
2132         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2133         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2134
2135         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2136         (WTR::PlatformWebView::PlatformWebView):
2137         Enable swipe.
2138
2139 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2140
2141         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2142         https://bugs.webkit.org/show_bug.cgi?id=148723
2143
2144         Reviewed by Anders Carlsson.
2145
2146         * WebKitTestRunner/TestController.cpp:
2147         (WTR::testPath):
2148         (WTR::updateViewOptionsFromTestHeader):
2149         (WTR::TestController::viewOptionsForTest):
2150
2151 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2152
2153         Test commit.
2154
2155 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2156
2157         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2158         https://bugs.webkit.org/show_bug.cgi?id=148693
2159
2160         Reviewed by Anders Carlsson.
2161
2162         * WebKitTestRunner/TestController.cpp:
2163         (WTR::TestController::createOtherPage):
2164         (WTR::TestController::createWebViewWithOptions):
2165
2166 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2167
2168         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2169         https://bugs.webkit.org/show_bug.cgi?id=148529
2170
2171         Reviewed by Darin Adler.
2172
2173         When there are pending EventSender messages after a test finishes,
2174         they could be processed in the main loop started by the
2175         resetStateToConsistentValues(), but the old EventSender has been
2176         replaced by a new one at that point. The new Eventsender can crash
2177         when processing messages that were sent to the old one. To avoid
2178         this, we return early when receiving an EventSender message and
2179         the TestController state is not RunningTest.
2180
2181         * WebKitTestRunner/TestController.cpp:
2182         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2183         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2184
2185 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2186
2187         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2188         https://bugs.webkit.org/show_bug.cgi?id=148528
2189
2190         Reviewed by Darin Adler.
2191
2192         Before r188548 resetStateToConsistentValues() was called in
2193         TestController::run(), before tests are run, but now it's called
2194         for every test in TestInvocation::invoke(), after m_status has
2195         changed to RunningTest.
2196
2197         * WebKitTestRunner/TestController.cpp:
2198         (WTR::TestController::resetStateToConsistentValues): Use
2199         TemporaryChange to reset m_state ot its previous value after reset
2200         is done.
2201
2202 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2203
2204         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2205         that are marked as requiring corresponding tests.
2206         https://bugs.webkit.org/show_bug.cgi?id=148498
2207         <rdar://problem/21555314>
2208
2209         Reviewed by Dan Bernstein and David Kilzer.
2210
2211         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2212         simulate Git's attribute behevaior.
2213         (main): Added "requiresTests" array to contain files that require tests.
2214         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2215         section in ChangeLog.
2216         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2217         however, we check if the file or any containing folder has the given property set to "1" and
2218         return 1 if so; return 0 otherwise.
2219         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2220         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2221
2222 2015-08-26  Andy Estes  <aestes@apple.com>
2223
2224         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2225         https://bugs.webkit.org/show_bug.cgi?id=148506
2226
2227         Reviewed by Brady Eidson.
2228
2229         Added download API tests covering every decision and decision point.
2230         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2231
2232         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2233         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2234         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2235         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2236         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2237         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2238         decision and decision point as a bundle parameter.
2239         (+[MockContentFilterEnabler supportsSecureCoding]):
2240         (-[MockContentFilterEnabler copyWithZone:]):
2241         (-[MockContentFilterEnabler initWithCoder:]):
2242         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
2243         (-[MockContentFilterEnabler encodeWithCoder:]):
2244         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
2245         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
2246         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
2247         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
2248         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
2249         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
2250         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
2251         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
2252         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
2253         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
2254         (+[MockContentFilterEnabler supportsSecureCoding]):
2255         (-[MockContentFilterEnabler copyWithZone:]):
2256         (-[MockContentFilterEnabler initWithCoder:]):
2257         (-[MockContentFilterEnabler dealloc]):
2258         (-[MockContentFilterEnabler encodeWithCoder:]):
2259         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
2260         (-[ContentFilteringPlugIn dealloc]): Stop observing.
2261         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
2262         (+[ServerRedirectPlugIn initialize]): Deleted.
2263         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2264         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2265         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
2266         (TEST): Deleted.
2267
2268 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
2269
2270         Skip slow lock tests on Windows/debug
2271         https://bugs.webkit.org/show_bug.cgi?id=148643
2272
2273         Reviewed by Alexey Proskuryakov.
2274
2275         The lock tests simulate a critical section by doing some floating point math, and then either
2276         make those critical sections very long or invoke them many times. This appears to be
2277         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
2278         that kind of computation slow.
2279
2280         These tests are almost as useful in release as they are in debug, so it's probably better to
2281         just skip the in debug on platforms where this causes timeouts.
2282
2283         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2284         (TestWebKitAPI::runLockTest):
2285         (TestWebKitAPI::skipSlow):
2286         (TestWebKitAPI::TEST):
2287
2288 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
2289
2290         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
2291         https://bugs.webkit.org/show_bug.cgi?id=125720
2292
2293         Reviewed by Daniel Bates.
2294
2295         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
2296
2297         * DumpRenderTree/AccessibilityUIElement.cpp:
2298         (pressCallback):
2299         (scrollToMakeVisibleWithSubFocusCallback):
2300         (scrollToGlobalPointCallback):
2301         (scrollToMakeVisibleCallback):
2302         (AccessibilityUIElement::getJSClass):
2303         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2304         (AccessibilityUIElement::scrollToMakeVisible):
2305         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2306         (AccessibilityUIElement::scrollToGlobalPoint):
2307         (AccessibilityUIElement::selectedTextRange):
2308         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2309         (AccessibilityUIElement::AccessibilityUIElement):
2310         (AccessibilityUIElement::mathPrescriptsDescription):
2311         (AccessibilityUIElement::scrollToMakeVisible):
2312         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2313         (AccessibilityUIElement::scrollToGlobalPoint):
2314         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2315         (WTR::AccessibilityUIElement::isTextMarkerValid):
2316         (WTR::AccessibilityUIElement::textMarkerForIndex):
2317         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2318         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2319         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2320         (WTR::AccessibilityUIElement::supportedActions):
2321         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2322         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2323         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2324         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2325         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2326         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2327         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2328         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2329         (WTR::AccessibilityUIElement::selectedTextRange):
2330         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2331         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2332         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2333         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2334         (WTR::AccessibilityUIElement::selectedTextRange):
2335
2336 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2337
2338         Add a mysteriously nonproblematic missing comma.
2339
2340         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2341         (TestExpectationParser._collect_matching_tests):
2342         (TestExpectationParser):
2343
2344 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2345
2346         Remove an old temporary script that has served its purpose
2347
2348         * Scripts/convert-test-expectations: Removed.
2349
2350 2015-08-28  Jer Noble  <jer.noble@apple.com>
2351
2352         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
2353         https://bugs.webkit.org/show_bug.cgi?id=148579
2354
2355         Reviewed by Anders Carlsson.
2356
2357         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
2358
2359         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
2360         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
2361
2362         * DumpRenderTree/mac/DumpRenderTree.mm:
2363         (resetWebPreferencesToConsistentValues):
2364         (resetWebViewToConsistentStateBeforeTesting): 
2365         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2366         (WTR::initializeWebViewConfiguration):
2367
2368 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2369
2370         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
2371         https://bugs.webkit.org/show_bug.cgi?id=148592
2372
2373         Reviewed by Tim Horton.
2374
2375         * Scripts/webkitpy/port/base.py:
2376         (Port.to.setup_environ_for_server):
2377         (Port.to):
2378         (Port.to._append_value_colon_separated):
2379         (Port.to.show_results_html_file):
2380         * Scripts/webkitpy/port/ios.py:
2381         (IOSSimulatorPort.setup_environ_for_server):
2382         * Scripts/webkitpy/port/mac.py:
2383         (MacPort.setup_environ_for_server):
2384
2385 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
2386
2387         LICM should be sound even if the CFG has changed
2388         https://bugs.webkit.org/show_bug.cgi?id=148259
2389
2390         Reviewed by Benjamin Poulain.
2391
2392         Add a utility for creating tests that set some uncommon option.
2393
2394         * Scripts/run-jsc-stress-tests:
2395
2396 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
2397
2398         [Win] Unreviewed EWS correction.
2399
2400         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
2401
2402 2015-08-28  Jer Noble  <jer.noble@apple.com>
2403
2404         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
2405         https://bugs.webkit.org/show_bug.cgi?id=147512
2406
2407         Reviewed by Anders Carlsson.
2408
2409         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
2410         to a consistent (true) value.
2411
2412         * DumpRenderTree/mac/DumpRenderTree.mm:
2413         (setDefaultsToConsistentValuesForTesting):
2414         * WebKitTestRunner/TestController.cpp:
2415         (WTR::TestController::resetPreferencesToConsistentValues):
2416
2417 2015-08-28  Tim Horton  <timothy_horton@apple.com>
2418
2419         Add navigation gesture callbacks to WKPageNavigationClient
2420         https://bugs.webkit.org/show_bug.cgi?id=148568
2421         <rdar://problem/22371346>
2422
2423         Reviewed by Anders Carlsson.
2424
2425         * WebKitTestRunner/TestController.cpp:
2426         (WTR::TestController::createOtherPage):
2427         (WTR::TestController::createWebViewWithOptions):
2428         Add some zeroes.
2429
2430 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2431
2432         [Mac] kill-old-processes should kill more processes
2433         https://bugs.webkit.org/show_bug.cgi?id=148577
2434
2435         Reviewed by Tim Horton.
2436
2437         * BuildSlaveSupport/kill-old-processes:
2438
2439 2015-08-28  Jason Marcell  <jmarcell@apple.com>
2440
2441         The status message for combined builder queues should say "all builds succeeded" if everything
2442         built correctly.
2443         https://bugs.webkit.org/show_bug.cgi?id=148535
2444
2445         Reviewed by David Kilzer and Alexey Proskuryakov.
2446
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2448         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
2449         say "all builds succeeded" if everything built correctly.
2450
2451 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2452
2453         [GTK] Simplify the internal API to create a WebView
2454         https://bugs.webkit.org/show_bug.cgi?id=148570
2455
2456         Reviewed by Žan Doberšek.
2457
2458         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
2459         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2460         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
2461         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
2462         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
2463         passing the received PageConfiguration.
2464         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2465         (WTR::PlatformWebView::PlatformWebView): Create the WebView
2466         passing the received PageConfiguration.
2467
2468 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
2469
2470         iOS Simulator API tests fails as Simulator is not running
2471         https://bugs.webkit.org/show_bug.cgi?id=148501
2472         rdar://problem/22447525
2473
2474         Reviewed by Daniel Bates.
2475
2476         This change is a workaround for <rdar://problem/22388812>.
2477
2478          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
2479          and quit it on program termination when running tests on the iOS port.
2480          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
2481          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
2482
2483 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2484
2485         Make DLLLauncherMain executables dependent on dll
2486         https://bugs.webkit.org/show_bug.cgi?id=148548
2487
2488         Reviewed by Brent Fulgham.
2489
2490         * DumpRenderTree/CMakeLists.txt:
2491         * DumpRenderTree/PlatformWin.cmake:
2492         * MiniBrowser/win/CMakeLists.txt:
2493         * TestWebKitAPI/CMakeLists.txt:
2494         * TestWebKitAPI/PlatformWin.cmake:
2495
2496 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2497
2498         Remove Mac slaves 188/189 after being replaced with 400/401.
2499         
2500         Unreviewed.
2501         
2502         * BuildSlaveSupport/build.webkit.org-config/config.json:
2503
2504 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2505
2506         Add two bots to the Mac Yosemite queue.
2507         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
2508         
2509         Unreviewed.
2510         
2511         * BuildSlaveSupport/build.webkit.org-config/config.json:
2512
2513 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2514
2515         [Win CMake] Fix incremental build after r188673
2516         https://bugs.webkit.org/show_bug.cgi?id=148539
2517
2518         Reviewed by Brent Fulgham.
2519
2520         * TestWebKitAPI/PlatformWin.cmake:
2521         Copy forwarding headers from WebCore before building in case that was not yet done.
2522         It used to be done when running CMake, but now it's a build step.
2523
2524 2015-08-27  Nan Wang  <n_wang@apple.com>
2525
2526         AX: Fix accessibility/select-element-at-index.html test
2527         https://bugs.webkit.org/show_bug.cgi?id=148516
2528
2529         Reviewed by Chris Fleizach.
2530
2531         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
2532
2533         * DumpRenderTree/AccessibilityUIElement.cpp:
2534         (setSelectedChildCallback):
2535         (setSelectedChildAtIndexCallback):
2536         (removeSelectionAtIndexCallback):
2537         (elementAtPointCallback):
2538         (sentenceAtOffsetCallback):
2539         (stringForSelectionCallback):
2540         (AccessibilityUIElement::getJSClass):
2541         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2542         (AccessibilityUIElement::setSelectedChild):
2543         (AccessibilityUIElement::setSelectedChildAtIndex):
2544         (AccessibilityUIElement::removeSelectionAtIndex):
2545         (AccessibilityUIElement::accessibilityValue):
2546         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2547         (WTR::AccessibilityUIElement::wordAtOffset):
2548         (WTR::AccessibilityUIElement::lineAtOffset):
2549         (WTR::AccessibilityUIElement::sentenceAtOffset):
2550         (WTR::AccessibilityUIElement::isSelectable):
2551         (WTR::AccessibilityUIElement::isMultiSelectable):
2552         (WTR::AccessibilityUIElement::setSelectedChild):
2553         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2554         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2555         (WTR::AccessibilityUIElement::selectedChildrenCount):
2556         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2557         (WTR::AccessibilityUIElement::isExpanded):
2558         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2559         (WTR::AccessibilityUIElement::setSelectedChild):
2560         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2561         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2562         (WTR::AccessibilityUIElement::accessibilityValue):
2563
2564 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2565
2566         Build fix after r188982
2567
2568         * MiniBrowser/win/CMakeLists.txt:
2569         The directory structure changed in the move.
2570
2571 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2572
2573         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
2574
2575         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
2576
2577         * gtk/install-dependencies:
2578
2579 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2580
2581         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
2582
2583         * Scripts/run-gtk-tests:
2584         (TestRunner):
2585
2586 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2587
2588         Fix GTK+ WTR crashes in initializeMainRunLoop()
2589
2590         Rubber-stamped by Žan Doberšek.
2591
2592         Initialize threading and main thread before
2593         RunLoop::initializeMainRunLoop(), since the GLib implementation of
2594         the RunLoop uses isMainThread() to decide whether to create a new
2595         GMainContext or use the default one. Also use RunLoop::run() and
2596         ::stop() instead of gtk_main/quit.
2597
2598         * WebKitTestRunner/TestController.cpp:
2599         (WTR::TestController::initialize):
2600         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2601         (WTR::TestController::notifyDone):
2602         (WTR::TestController::platformRunUntil):
2603
2604 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
2605
2606         Unreviewed, further shorten a test that times out because it's very long
2607         running.
2608
2609         I've locally run these tests on repeat for 24 hours and found no genuine
2610         failures, like deadlocks. So, the timeouts are probably because the test
2611         machine is slow and debug is slow. We should just run this test for fewer
2612         iterations.
2613
2614         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2615         (TestWebKitAPI::TEST):
2616
2617 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2618
2619         Unreviewed build fix attempt on EFL
2620
2621         * WebKitTestRunner/PlatformEfl.cmake:
2622
2623 2015-08-26  Alex Christensen  <achristensen@webkit.org>
2624
2625         Build fix after r188982
2626
2627         * MiniBrowser/win/CMakeLists.txt:
2628         Find .rc files in correct directory.
2629
2630 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2631
2632         [EFL] Bump cairo version to 1.14.2
2633         https://bugs.webkit.org/show_bug.cgi?id=148474
2634
2635         Reviewed by Csaba Osztrogonác.
2636
2637         * efl/jhbuild.modules:
2638
2639 2015-08-26  Andy Estes  <aestes@apple.com>
2640
2641         Crash when following a Google search link to Twitter with Limit Adult Content enabled
2642         https://bugs.webkit.org/show_bug.cgi?id=147651
2643
2644         Rubber-stamped by Brady Eidson.
2645
2646         Taught TestRunner how to decide the navigation policy after a delay.
2647
2648         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2649         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2650         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2651         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2652         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2653         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2654         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2655         * WebKitTestRunner/TestController.cpp:
2656         (WTR::TestController::initialize):
2657         (WTR::TestController::resetStateToConsistentValues):
2658         (WTR::TestController::decidePolicyForNavigationAction):
2659         * WebKitTestRunner/TestController.h:
2660         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2661         * WebKitTestRunner/TestInvocation.cpp:
2662         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2663
2664 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2665
2666         [Win] Rename 'WinLauncher' to 'MiniBrowser'
2667         https://bugs.webkit.org/show_bug.cgi?id=148485
2668
2669         Reviewed by Alex Christensen
2670
2671         Move the WinLauncher project and source files to a subdirectory
2672         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
2673         source code and project files.
2674         
2675         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
2676         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
2677         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
2678         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
2679         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
2680         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
2681         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
2682         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
2683         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
2684         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
2685         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
2686         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
2687         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
2688         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
2689         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
2690         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
2691         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
2692         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
2693         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
2694         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
2695         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
2696         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
2697         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
2698         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
2699         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
2700         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
2701         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
2702         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
2703         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
2704         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
2705         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
2706         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
2707         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
2708         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
2709         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2710         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
2711         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
2712         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2713         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2714         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
2715         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
2716         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
2717         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
2718         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
2719         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
2720         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
2721         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
2722         * MiniBrowser/win: Copied from WinLauncher.
2723         * MiniBrowser/win/Common.cpp:
2724         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
2725         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
2726         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
2727         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
2728         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
2729         * MiniBrowser/win/PageLoadTestClient.cpp:
2730         * MiniBrowser/win/PageLoadTestClient.h:
2731         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2732         * MiniBrowser/win/ResourceLoadDelegate.h:
2733         * MiniBrowser/win/WinLauncher.cpp: Removed.
2734         * MiniBrowser/win/WinLauncher.h: Removed.
2735         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
2736         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2737         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2738         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2739         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2740         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2741         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2742         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2743         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2744         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2745         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2746         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2747         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2748         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2749         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2750         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2751         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2752         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2753         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2754         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2755         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2756         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2757         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2758         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2759         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
2760         * MiniBrowser/win/WinLauncherReplace.h: Removed.
2761         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
2762         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
2763         * MiniBrowser/win/WinMain.cpp:
2764         * WinLauncher: Removed.
2765         * WinLauncher/AccessibilityDelegate.cpp: Removed.
2766         * WinLauncher/AccessibilityDelegate.h: Removed.
2767         * WinLauncher/CMakeLists.txt: Removed.
2768         * WinLauncher/Common.cpp: Removed.
2769         * WinLauncher/DOMDefaultImpl.cpp: Removed.
2770         * WinLauncher/DOMDefaultImpl.h: Removed.
2771         * WinLauncher/PageLoadTestClient.cpp: Removed.
2772         * WinLauncher/PageLoadTestClient.h: Removed.
2773         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
2774         * WinLauncher/PrintWebUIDelegate.h: Removed.
2775         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
2776         * WinLauncher/ResourceLoadDelegate.h: Removed.
2777         * WinLauncher/WebDownloadDelegate.cpp: Removed.
2778         * WinLauncher/WebDownloadDelegate.h: Removed.
2779         * WinLauncher/WinLauncher.cpp: Removed.
2780         * WinLauncher/WinLauncher.h: Removed.
2781         * WinLauncher/WinLauncher.vcxproj: Removed.
2782         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2783         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2784         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2785         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2786         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2787         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2788         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2789         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2790         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2791         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2792         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2793         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2794         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2795         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2796         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2797         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2798         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2799         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2800         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2801         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2802         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2803         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2804         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2805         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
2806         * WinLauncher/WinLauncherReplace.h: Removed.
2807         * WinLauncher/WinLauncherWebHost.cpp: Removed.
2808         * WinLauncher/WinLauncherWebHost.h: Removed.
2809         * WinLauncher/WinMain.cpp: Removed.
2810         * WinLauncher/resource.h: Removed.
2811         * WinLauncher/stdafx.cpp: Removed.
2812         * WinLauncher/stdafx.h: Removed.
2813         * win/AssembleBuildLogs/AssembleLogs.cmd:
2814
2815 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2816
2817         [Win] Simplify menu handling code in WinLauncher
2818         https://bugs.webkit.org/show_bug.cgi?id=148461
2819
2820         Reviewed by Zalan Bujtas.
2821
2822         Revise 'ToggleMenuItem' to return a boolean value indicating if
2823         it handled the message. Revise WndProc to use this to decide if it
2824         should pass the message on to the default handler, rather than
2825         duplicating the logic in both places.
2826         
2827         * WinLauncher/Common.cpp:
2828         (ToggleMenuItem): Return true if the menu item message was handled.
2829         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
2830         the message tothe default handler.
2831
2832 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
2833
2834         Remove unused code after r188948
2835         https://bugs.webkit.org/show_bug.cgi?id=148467
2836
2837         Reviewed by Gyuyoung Kim.
2838
2839         * WebKitTestRunner/TestController.cpp:
2840         (WTR::TestController::platformPreferences): Deleted.
2841
2842 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2843
2844         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
2845         https://bugs.webkit.org/show_bug.cgi?id=148377
2846
2847         Reviewed by Carlos Garcia Campos.
2848
2849         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
2850         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
2851         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
2852         EFL and GTK at the moment.
2853
2854         * WebKitTestRunner/TestController.cpp:
2855         (WTR::TestController::platformWillRunTest):
2856         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2857         (WTR::TestController::platformPreferences):
2858         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2859         (WTR::TestController::platformPreferences):
2860
2861 2015-08-25  Nan Wang  <n_wang@apple.com>
2862
2863         AX: Enable accessibility/aria-controls.html test for mac
2864         https://bugs.webkit.org/show_bug.cgi?id=148458
2865
2866         Reviewed by Chris Fleizach.
2867
2868         Implemented ariaControlsElementAtIndex(unsigned index).
2869
2870         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2871         (AccessibilityUIElement::ariaControlsElementAtIndex):
2872         (AccessibilityUIElement::disclosedRowAtIndex):
2873         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2874         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2875
2876 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2877
2878         Remove python tests for PassRefPtr 
2879         https://bugs.webkit.org/show_bug.cgi?id=148463
2880
2881         Reviewed by Andy Estes.
2882
2883         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
2884
2885         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2886         (PassPtrTest): Deleted.
2887         (PassPtrTest.assert_pass_ptr_check): Deleted.
2888         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
2889         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
2890         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
2891         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
2892         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
2893         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
2894
2895 2015-08-25  Andy Estes  <aestes@apple.com>
2896
2897         [iOS] run-webkit-tests fails if watchOS SDK is installed
2898         https://bugs.webkit.org/show_bug.cgi?id=148453
2899
2900         Reviewed by David Kilzer.
2901
2902         * Scripts/webkitpy/xcode/simulator.py:
2903         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
2904         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2905
2906 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
2907
2908         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
2909         https://bugs.webkit.org/show_bug.cgi?id=148197
2910         rdar://problem/22334382
2911
2912         Reviewed by Daniel Bates.
2913
2914         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
2915         * Scripts/webkitpy/port/ios.py:
2916         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
2917         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
2918         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
2919         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
2920         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
2921
2922 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2923
2924         Remove PassRefPtr style check rule
2925         https://bugs.webkit.org/show_bug.cgi?id=148432
2926
2927         Reviewed by Andreas Kling.
2928
2929         PassRefPtr is being removed. Thus style rule needs to be removed as well.
2930
2931         * Scripts/webkitpy/style/checkers/cpp.py:
2932         (_check_parameter_name_against_text): Deleted.
2933         (check_function_definition_and_pass_ptr): Deleted.
2934         (check_function_definition): Deleted.
2935         (check_pass_ptr_usage): Deleted.
2936         (process_line): Deleted.
2937         (CppChecker): Deleted.
2938
2939 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
2940
2941         [Win] Expose "Inverted Colors" option in WinLauncher
2942         https://bugs.webkit.org/show_bug.cgi?id=148451
2943
2944         Reviewed by Tim Horton.
2945
2946         Add the ability to toggle the "Inverted Colors" preference
2947         in WinLauncher.
2948         
2949         * WinLauncher/Common.cpp:
2950         (ToggleMenuItem): Toggle the feature when the menu item
2951         is selected.
2952         (WndProc): Recognize the new menu option.
2953         * WinLauncher/WinLauncher.cpp:
2954         (WinLauncher::setToDefaultPreferences): Launch with "Invert
2955         Colors" turned off.
2956         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
2957         entry for "Invert Colors".
2958         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2959
2960 2015-08-25  Nan Wang  <n_wang@apple.com>
2961
2962         [Mac] accessibility/document-attributes.html fails
2963         https://bugs.webkit.org/show_bug.cgi?id=116636
2964
2965         Reviewed by Chris Fleizach.
2966
2967         Implemented documentURI() and documentEncoding().
2968
2969         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2970         (AccessibilityUIElement::documentEncoding):
2971         (AccessibilityUIElement::documentURI):
2972         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2973         (WTR::AccessibilityUIElement::documentEncoding):
2974         (WTR::AccessibilityUIElement::documentURI):
2975
2976 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
2977
2978         [Win] Unreviewed test gardening.
2979
2980         Fix another case where the logging string is constructed using the variable 'frame',
2981         but the method argument is not given a name. This causes the global 'frame' value to
2982         be used, producing incorrect output.
2983
2984         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2985         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
2986         argument.
2987
2988 2015-08-24  Tim Horton  <timothy_horton@apple.com>
2989
2990         (Finally...) get rid of WKViewIOS
2991         https://bugs.webkit.org/show_bug.cgi?id=148404
2992
2993         Reviewed by Anders Carlsson.
2994
2995         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2996         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2997         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2998         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2999         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3000         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3001         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3002         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3003         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3004         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3005         Mark tests that use WKBrowsingContextController as Mac-only.
3006
3007         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3008         (WTR::AccessibilityController::addNotificationListener):
3009         * WebKitTestRunner/ios/mainIOS.mm:
3010         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3011         Import UIKit instead of depending on WKView.h to do so.
3012
3013 2015-08-24  Jason Marcell  <jmarcell@apple.com>
3014
3015         Add support to dashboard for displaying Git SHA's as revisions.
3016         https://bugs.webkit.org/show_bug.cgi?id=148387
3017
3018         Reviewed by Daniel Bates.
3019
3020         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3021         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
3022         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3023         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
3025         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
3026
3027 2015-08-24  Andy Estes  <aestes@apple.com>
3028
3029         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
3030
3031         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
3032
3033 2015-08-23  Andy Estes  <aestes@apple.com>
3034
3035         Addressed a missed piece of review feedback from r188851.
3036
3037         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3038
3039 2015-08-23  Andy Estes  <aestes@apple.com>
3040
3041         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
3042         https://bugs.webkit.org/show_bug.cgi?id=147872
3043         rdar://problem/22044000
3044
3045         Reviewed by Dan Bernstein.
3046         
3047         Added an API test.
3048
3049         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
3050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3051         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
3052         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
3053         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
3054         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
3055         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
3056         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
3057         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
3058         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
3059         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
3060
3061 2015-08-23  Andy Estes  <aestes@apple.com>
3062
3063         Fixed the 32-bit Mac build after r188844.
3064
3065         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
3066         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
3067
3068 2015-08-22  Andy Estes  <aestes@apple.com>
3069
3070         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
3071         https://bugs.webkit.org/show_bug.cgi?id=148317
3072
3073         Reviewed by Dan Bernstein.
3074
3075         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
3076         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
3077         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
3078         when creating WKWebViews.
3079
3080         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
3081         added a new API test for bundle parameters.
3082
3083         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
3084         named its executable TestWebKitAPI.bundle.
3085         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
3086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
3087         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
3088         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
3089         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
3090         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
3091         bundle parameter and asked for an initial notification.
3092         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
3093         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
3094         mirror its value in the main frame's JSContext.
3095         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
3096         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
3097         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
3098         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
3099         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
3100         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
3101         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
3102         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
3103         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
3104         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
3105
3106 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
3107
3108         URTBF after r188828.
3109
3110         * WebKitTestRunner/PlatformWebView.h:
3111
3112 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3113
3114         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
3115         https://bugs.webkit.org/show_bug.cgi?id=148356
3116
3117         Reviewed by Darin Adler.
3118
3119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3120         (BuildbotCombinedQueueView.prototype.update):
3121
3122 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3123
3124         build.webkit.org/dashboard: Respect step's hidden flag
3125         https://bugs.webkit.org/show_bug.cgi?id=148357
3126
3127         Reviewed by Darin Adler.
3128
3129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3130         (BuildbotIteration.prototype._parseData):
3131
3132 2015-08-23  Nan Wang  <n_wang@apple.com>
3133
3134         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
3135         https://bugs.webkit.org/show_bug.cgi?id=148328
3136
3137         Reviewed by Darin Adler.
3138
3139         We should only expose stringValue() when value attribute is set.
3140
3141         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3142         (AccessibilityUIElement::stringValue):
3143         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3144         (WTR::AccessibilityUIElement::stringValue):
3145
3146 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3147
3148         Remove style checking rule regarding OwnPtr and PassOwnPtr
3149         https://bugs.webkit.org/show_bug.cgi?id=148360
3150
3151         Reviewed by Darin Adler.
3152
3153         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
3154         Removed it.
3155
3156         * Scripts/do-webcore-rename:
3157         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3158         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
3159         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3160         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
3161         (WebKitStyleTest.test_names): Deleted.
3162
3163 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
3164
3165         WebKitTestRunner should use WKWebView on OS X and iOS
3166         https://bugs.webkit.org/show_bug.cgi?id=143743
3167         <rdar://problem/16947123>
3168
3169         Reviewed by Anders Carlsson.
3170         Patch by Enrica Casucci and myself.
3171
3172         * WebKitTestRunner/PlatformWebView.h:
3173         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3174         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3175         instead of WKContext and WKPageGroup.
3176
3177         Remove the unused, always-true windowSnapshotEnabled().
3178         While technically some platforms don't have window snapshotting,
3179         they just return null instead of implementing windowSnapshotEnabled().
3180
3181         * WebKitTestRunner/TestController.h:
3182         * WebKitTestRunner/TestController.cpp:
3183         (WTR::TestController::createOtherPage):
3184         (WTR::TestController::initialize):
3185         (WTR::TestController::createWebViewWithOptions):
3186         Delegate to the various platforms for creating PlatformWebView instances,
3187         for creating WKContexts, and for accessing WKPreferences,
3188         so that they can do special things (like, use WKWebView instead!).
3189
3190         (WTR::TestController::resetPreferencesToConsistentValues):
3191         Make explicit WebKitTestRunner's desired default for two preferences
3192         which have differing defaults between the antique and modern API,
3193         for consistency's sake.
3194
3195         (WTR::TestController::resetStateToConsistentValues):
3196         Add platformResetStateToConsistentValues.
3197
3198         * WebKitTestRunner/TestInvocation.cpp:
3199         (WTR::TestInvocation::dumpResults):
3200         Adjust to the aforementioned removal of windowSnapshotEnabled().
3201
3202         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3203         (WTR::TestController::platformResetStateToConsistentValues):
3204         (WTR::TestController::platformPreferences):
3205         (WTR::TestController::platformCreateWebView):
3206         (WTR::TestController::platformCreateOtherPage):
3207         (WTR::TestController::platformInitializeConfiguration):
3208         Implement the new platform functions for the Modern WebKit2 API,
3209         in a new TestControllerCocoa file that is shared between iOS and Mac.
3210         
3211         For platformMaybeCreateContext, use the trick that we know we can cast
3212         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3213         WKWebView's configuration.
3214
3215         Ditto for WKPreferencesRef and WKPreferences.
3216
3217         Remove user content filters on the WKWebView's userContentController.
3218
3219         * WebKitTestRunner/mac/TestControllerMac.mm:
3220         * WebKitTestRunner/ios/TestControllerIOS.mm:
3221         Move code into TestControllerCocoa.
3222
3223         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3224         (WTR::InjectedBundle::beginTesting):
3225         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3226         (WTR::TestRunner::addUserScript):
3227         (WTR::TestRunner::addUserStyleSheet):
3228         Adopt WKBundlePage API for user scripts/sheets.
3229
3230         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3231         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3232         Make and keep a WKWebView instead of a WKView.
3233         
3234         * WebKitTestRunner/mac/EventSenderProxy.mm:
3235         (WTR::EventSenderProxy::mouseUp):
3236         (WTR::EventSenderProxy::mouseMoveTo):
3237         Reach inside the WKWebView to the WKView when dispatching events.
3238         This is fairly ugly and we should come up with a better solution.
3239         Also, fix some flipping and style errors.
3240
3241 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3242
3243         Unreviewed, attempt to fix GTK build after r188718
3244
3245         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3246         (WTR::PlatformWebView::PlatformWebView):
3247
3248 2015-08-21  Commit Queue  <commit-queue@webkit.org>
3249
3250         Unreviewed, rolling out r188807, r188813, and r188815.
3251         https://bugs.webkit.org/show_bug.cgi?id=148349
3252
3253         lots of 32-bit build problems, better to resolve separately
3254         and try again (Requested by thorton on #webkit).
3255
3256         Reverted changesets:
3257
3258         "WebKitTestRunner should use WKWebView on OS X and iOS"
3259         https://bugs.webkit.org/show_bug.cgi?id=143743
3260         http://trac.webkit.org/changeset/188807
3261
3262         "Stop building WebKitTestRunner for 32-bit platforms"
3263         https://bugs.webkit.org/show_bug.cgi?id=143743
3264         http://trac.webkit.org/changeset/188813
3265
3266         "Stop building WebKitTestRunner for 32-bit platforms"
3267         https://bugs.webkit.org/show_bug.cgi?id=143743
3268         http://trac.webkit.org/changeset/188815
3269
3270 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3271
3272         Stop building WebKitTestRunner for 32-bit platforms
3273         https://bugs.webkit.org/show_bug.cgi?id=143743
3274         <rdar://problem/16947123>
3275
3276         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3277         This is a restriction on the valid set, not the desired set.
3278
3279 2015-08-21  Jason Marcell  <jmarcell@apple.com>
3280
3281         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
3282         to work with these new objects.
3283         https://bugs.webkit.org/show_bug.cgi?id=148188
3284
3285         Reviewed by Daniel Bates.
3286
3287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3288         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3290         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
3291         (repository, "branch name")-pair.
3292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
3293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3294         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3295         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3296         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
3297         objects which represent a (repository, "branch name")-pair.
3298         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3299         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3300         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
3301         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
3302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
3303         BuildbotQueue.branch to BuildbotQueue.branches.
3304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3305         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
3306
3307 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3308
3309         Stop building WebKitTestRunner for 32-bit platforms
3310         https://bugs.webkit.org/show_bug.cgi?id=143743
3311         <rdar://problem/16947123>
3312
3313         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3314         WKWebView is not available on 32-bit OS X.
3315
3316 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
3317
3318         [Win] Unreviewed test correction after r188709.
3319
3320         I removed a function argument that happened to be mirrored by a global
3321         value with the same name. This prevented a compile error, but testing
3322         showed that the wrong value was being used in the function.
3323
3324         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3325         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
3326         back
3327
3328 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
3329
3330         WebKitTestRunner should use WKWebView on OS X and iOS
3331         https://bugs.webkit.org/show_bug.cgi?id=143743
3332         <rdar://problem/16947123>
3333
3334         Reviewed by Anders Carlsson.
3335         Patch by Enrica Casucci and myself.
3336
3337         * WebKitTestRunner/PlatformWebView.h:
3338         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3339         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3340         instead of WKContext and WKPageGroup.
3341
3342         Remove the unused, always-true windowSnapshotEnabled().
3343         While technically some platforms don't have window snapshotting,
3344         they just return null instead of implementing windowSnapshotEnabled().
3345
3346         * WebKitTestRunner/TestController.h:
3347         * WebKitTestRunner/TestController.cpp:
3348         (WTR::TestController::createOtherPage):
3349         (WTR::TestController::initialize):
3350         (WTR::TestController::createWebViewWithOptions):
3351         Delegate to the various platforms for creating PlatformWebView instances,
3352         for creating WKContexts, and for accessing WKPreferences,
3353         so that they can do special things (like, use WKWebView instead!).
3354
3355         (WTR::TestController::resetPreferencesToConsistentValues):
3356         Make explicit WebKitTestRunner's desired default for two preferences
3357         which have differing defaults between the antique and modern API,
3358         for consistency's sake.
3359
3360         (WTR::TestController::resetStateToConsistentValues):
3361         Add platformResetStateToConsistentValues.
3362
3363         * WebKitTestRunner/TestInvocation.cpp:
3364         (WTR::TestInvocation::dumpResults):
3365         Adjust to the aforementioned removal of windowSnapshotEnabled().
3366
3367         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3368         (WTR::TestController::platformResetStateToConsistentValues):
3369         (WTR::TestController::platformPreferences):
3370         (WTR::TestController::platformCreateWebView):
3371         (WTR::TestController::platformCreateOtherPage):
3372         (WTR::TestController::platformInitializeConfiguration):
3373         Implement the new platform functions for the Modern WebKit2 API,
3374         in a new TestControllerCocoa file that is shared between iOS and Mac.
3375         
3376         For platformMaybeCreateContext, use the trick that we know we can cast
3377         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3378         WKWebView's configuration.
3379
3380         Ditto for WKPreferencesRef and WKPreferences.
3381
3382         Remove user content filters on the WKWebView's userContentController.
3383
3384         * WebKitTestRunner/mac/TestControllerMac.mm:
3385         * WebKitTestRunner/ios/TestControllerIOS.mm:
3386         Move code into TestControllerCocoa.
3387
3388         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3389         (WTR::InjectedBundle::beginTesting):
3390         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3391         (WTR::TestRunner::addUserScript):
3392         (WTR::TestRunner::addUserStyleSheet):
3393         Adopt WKBundlePage API for user scripts/sheets.
3394
3395         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3396         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3397         Make and keep a WKWebView instead of a WKView.
3398         
3399         * WebKitTestRunner/mac/EventSenderProxy.mm:
3400         (WTR::EventSenderProxy::mouseUp):
3401         (WTR::EventSenderProxy::mouseMoveTo):
3402         Reach inside the WKWebView to the WKView when dispatching events.
3403         This is fairly ugly and we should come up with a better solution.
3404         Also, fix some flipping and style errors.
3405
3406 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
3407
3408         Improve how UI events are dispatched by WebKitTestRunner
3409         https://bugs.webkit.org/show_bug.cgi?id=148326
3410
3411         Reviewed by Anders Carlsson.
3412
3413         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3414         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3415         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
3416         asynchronous (and really, it has always been for the most part).
3417
3418         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3419         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
3420         (WTR::EventSendingController::mouseUp): Ditto.
3421         (WTR::EventSendingController::mouseMoveTo): Ditto.
3422         (WTR::EventSendingController::mouseForceDown): Ditto.
3423         (WTR::EventSendingController::mouseForceUp): Ditto.
3424         (WTR::EventSendingController::mouseForceChanged): Ditto.
3425         (WTR::EventSendingController::leapForward): Ditto.
3426         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
3427         (WTR::EventSendingController::keyDown): Ditto.
3428         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
3429         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
3430         to be done in custom WebKit2 code for test wheel event handling.
3431         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
3432         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
3433         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
3434         (WTR::EventSendingController::addTouchPoint): Ditto.
3435         (WTR::EventSendingController::updateTouchPoint): Ditto.
3436         (WTR::EventSendingController::setTouchModifier): Ditto.
3437         (WTR::EventSendingController::setTouchPointRadius): Ditto.
3438         (WTR::EventSendingController::touchStart): Ditto.
3439         (WTR::EventSendingController::touchMove): Ditto.
3440         (WTR::EventSendingController::touchEnd): Ditto.
3441         (WTR::EventSendingController::touchCancel): Ditto.
3442         (WTR::EventSendingController::clearTouchPoints): Ditto.
3443         (WTR::EventSendingController::releaseTouchPoint): Ditto.
3444         (WTR::EventSendingController::cancelTouchPoint): Ditto.
3445
3446         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3447         (WTR::InjectedBundle::postSetWindowIsKey):
3448         (WTR::InjectedBundle::postSimulateWebNotificationClick):
3449         (WTR::InjectedBundle::isGeolocationProviderActive):
3450         (WTR::InjectedBundle::shouldProcessWorkQueue):
3451         Updated for WKBundlePagePostSynchronousMessage renaming.
3452
3453         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3454         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
3455
3456         * WebKitTestRunner/TestController.cpp:
3457         (WTR::TestController::initialize): Allow handling the new test style messages.
3458         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
3459         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
3460         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3461         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
3462         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
3463
3464         * WebKitTestRunner/mac/EventSenderProxy.mm:
3465         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
3466         (WTR::EventSenderProxy::keyDown): Ditto.
3467         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
3468         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
3469
3470 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3471
3472         Skip no-llint tests that fail due to running out of executable memory after r188969
3473         https://bugs.webkit.org/show_bug.cgi?id=148273
3474
3475         Reviewed by Michael Saboff.
3476
3477         * Scripts/run-jsc-stress-tests:
3478
3479 2015-08-21  Nan Wang  <n_wang@apple.com>
3480
3481         [Mac] accessibility/selection-states.html fails
3482         https://bugs.webkit.org/show_bug.cgi?id=116637
3483
3484         Reviewed by Chris Fleizach.
3485
3486         Implemented isSelectable() and isMultiSelectable().
3487
3488         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3489         (AccessibilityUIElement::isSelectable):
3490         (AccessibilityUIElement::isMultiSelectable):
3491         (AccessibilityUIElement::isSelectedOptionActive):
3492         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3493         (WTR::AccessibilityUIElement::isSelectable):
3494         (WTR::AccessibilityUIElement::isMultiSelectable):
3495         (WTR::AccessibilityUIElement::isVisible):
3496
3497 2015-08-21  Jason Marcell  <jmarcell@apple.com>
3498
3499         Fix iteration over repositories on bot watcher's dashboard.
3500
3501         Reviewed by Alexey Proskuryakov.
3502
3503         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3504         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
3505
3506 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
3507
3508         [EFL] Revise PlatformWebView ctor according to r188718
3509         https://bugs.webkit.org/show_bug.cgi?id=148282
3510
3511         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
3512         instead of WKContextRef and WKPageGroupRef respectively.
3513
3514         Reviewed by Gyuyoung Kim.
3515
3516         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3517         (WTR::PlatformWebView::PlatformWebView):
3518
3519 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
3520
3521         Unreviewed, changed Devin Rousso's email.
3522
3523         * Scripts/webkitpy/common/config/contributors.json:
3524
3525 2015-08-20  Anders Carlsson  <andersca@apple.com>
3526
3527         Use WKPageConfigurationRef in WebKitTestRunner
3528         https://bugs.webkit.org/show_bug.cgi?id=147996
3529
3530         Reviewed by Tim Horton.
3531
3532         * WebKitTestRunner/TestController.cpp:
3533         (WTR::TestController::createOtherPage):
3534         (WTR::TestController::initialize):
3535         (WTR::TestController::createWebViewWithOptions):
3536         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3537         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
3538         (WTR::PlatformWebView::PlatformWebView):
3539         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
3540
3541 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
3542
3543         [Win] Update Windows tools for revised MIDL interfaces
3544         https://bugs.webkit.org/show_bug.cgi?id=148249
3545
3546         Reviewed by Dean Jackson.
3547
3548         This is a follow-up to Bug 148001.
3549
3550         Revise the testing software to use compatible signatures and
3551         implementations to match the requirements of the IDL generated
3552         with the SAL annotations.
3553
3554         * DumpRenderTree/win/DRTDataObject.cpp:
3555         * DumpRenderTree/win/DRTDataObject.h:
3556         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3557         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3558         * DumpRenderTree/win/DRTDropSource.cpp:
3559         * DumpRenderTree/win/DRTDropSource.h:
3560         * DumpRenderTree/win/DumpRenderTree.cpp:
3561         * DumpRenderTree/win/EditingDelegate.cpp:
3562         * DumpRenderTree/win/EditingDelegate.h:
3563         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3564         * DumpRenderTree/win/FrameLoadDelegate.h:
3565         * DumpRenderTree/win/HistoryDelegate.cpp:
3566         * DumpRenderTree/win/HistoryDelegate.h:
3567         * DumpRenderTree/win/PolicyDelegate.cpp:
3568         * DumpRenderTree/win/PolicyDelegate.h:
3569         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3570         * DumpRenderTree/win/ResourceLoadDelegate.h:
3571         * DumpRenderTree/win/TestRunnerWin.cpp:
3572         * DumpRenderTree/win/UIDelegate.cpp:
3573         * DumpRenderTree/win/UIDelegate.h:
3574         * WinLauncher/AccessibilityDelegate.cpp:
3575         * WinLauncher/AccessibilityDelegate.h:
3576         * WinLauncher/Common.cpp:
3577         * WinLauncher/DOMDefaultImpl.cpp:
3578         * WinLauncher/DOMDefaultImpl.h:
3579         * WinLauncher/PageLoadTestClient.cpp:
3580         * WinLauncher/PageLoadTestClient.h:
3581         * WinLauncher/PrintWebUIDelegate.cpp:
3582         * WinLauncher/PrintWebUIDelegate.h:
3583         * WinLauncher/ResourceLoadDelegate.cpp:
3584         * WinLauncher/ResourceLoadDelegate.h:
3585         * WinLauncher/WebDownloadDelegate.cpp:
3586         * WinLauncher/WebDownloadDelegate.h:
3587         * WinLauncher/WinLauncherWebHost.cpp:
3588         * WinLauncher/WinLauncherWebHost.h:
3589         * WinLauncher/WinMain.cpp:
3590         * win/DLLLauncher/DLLLauncherMain.cpp:
3591
3592 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
3593
3594         Unreviewed, shorten a test that runs too long and times out.
3595
3596         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3597         (TestWebKitAPI::TEST):
3598
3599 2015-08-20  Alex Christensen  <achristensen@webkit.org>
3600
3601         Clean up CMake build after r188673
3602         https://bugs.webkit.org/show_bug.cgi?id=148234
3603
3604         Reviewed by Tim Horton.
3605
3606         * DumpRenderTree/PlatformWin.cmake:
3607         * TestWebKitAPI/CMakeLists.txt:
3608         * TestWebKitAPI/PlatformWin.cmake:
3609         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
3610         gtest needs to be a static library on Windows to not crash.
3611
3612 2015-08-19  Alex Christensen  <achristensen@webkit.org>
3613
3614         CMake Windows build should not include files directly from other Source directories
3615         https://bugs.webkit.org/show_bug.cgi?id=148198
3616
3617         Reviewed by Brent Fulgham.
3618
3619         * DumpRenderTree/DumpRenderTreePrefix.h:
3620         Include cmakeconfig.h to properly define all enabled features.
3621         * DumpRenderTree/PlatformWin.cmake:
3622         * TestWebKitAPI/PlatformWin.cmake:
3623
3624 2015-08-19  Alex Christensen  <achristensen@webkit.org>
3625
3626         Build TestWTF on Mac with CMake.
3627         https://bugs.webkit.org/show_bug.cgi?id=147972
3628
3629         Reviewed by Tim Horton.
3630
3631         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
3632         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
3633
3634         * TestWebKitAPI/CMakeLists.txt:
3635         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
3636         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
3637         * TestWebKitAPI/PlatformMac.cmake: Added.
3638         * TestWebKitAPI/config.h:
3639         Postpone some build fixes until WebKit builds completely on Mac with CMake.
3640
3641 2015-08-19  Brian Burg  <bburg@apple.com>
3642
3643         Unreviewed, add Aleksandr Skachkov to the list of contributors.
3644
3645         * Scripts/webkitpy/common/config/contributors.json:
3646
3647 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3648
3649         REGRESSION(r188548): [GTK] Build broken.
3650         https://bugs.webkit.org/show_bug.cgi?id=148154
3651
3652         Reviewed by Martin Robinson.
3653
3654         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3655         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3656         Even if we don't need to add/override any settings in ViewOptions,
3657         we need to define this as an empty function to make it build.
3658
3659 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3660
3661         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
3662         https://bugs.webkit.org/show_bug.cgi?id=148073
3663
3664         Reviewed by Alexey Proskuryakov.
3665
3666         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
3667         (TestWebKitAPI::TEST):
3668
3669 2015-08-18  Anders Carlsson  <andersca@apple.com>
3670
3671         Fix test failure fallout from r188602 by using a V5 page ui client struct.
3672
3673         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3674         (TestWebKitAPI::setUpClients):
3675
3676 2015-08-18  Brian Burg  <bburg@apple.com>
3677
3678         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
3679         https://bugs.webkit.org/show_bug.cgi?id=147955
3680
3681         Reviewed by Timothy Hatcher.
3682
3683         To enable sharing of common test code between protocol and model tests,
3684         start loading the protocol TestStub.js through the WebInspectorUI bundle.
3685
3686         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
3687         protocol-test.js uses to load the inspector frontend stub into its iframe
3688         from an arbitrary local file URL.
3689
3690         * DumpRenderTree/TestRunner.cpp:
3691         (getInspectorTestStubURLCallback):
3692         (TestRunner::staticValues):
3693         * DumpRenderTree/TestRunner.h:
3694         * DumpRenderTree/mac/TestRunnerMac.mm:
3695         (SOFT_LINK_STAGED_FRAMEWORK):
3696         (TestRunner::inspectorTestStubURL):
3697         * DumpRenderTree/win/TestRunnerWin.cpp:
3698         (TestRunner::inspectorTestStubURL):
3699         * WebKitTestRunner/Configurations/Base.xcconfig:
3700         Since WebKitTestRunner now includes WebCore private headers, also search
3701         for the WebCore framework inside the WebKit umbrella framework.
3702
3703         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3704         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3705         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3706         (WTR::TestRunner::inspectorTestStubURL):
3707         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3708         (WTR::TestRunner::inspectorTestStubURL):
3709         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3710         (WTR::TestRunner::inspectorTestStubURL):
3711
3712 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
3713
3714         Unreviewed, fix GTK build.
3715
3716         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3717         (TestWebKitAPI::TEST):
3718
3719 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
3720
3721         Replace all remaining uses of WTF::Mutex with WTF::Lock
3722         https://bugs.webkit.org/show_bug.cgi?id=148089
3723
3724         Reviewed by Geoffrey Garen.
3725
3726         * DumpRenderTree/JavaScriptThreading.cpp:
3727         (javaScriptThreadsMutex):
3728         (runJavaScriptThread):
3729         (startJavaScriptThreads):
3730         (stopJavaScriptThreads):
3731         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
3732         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3733         (TestWebKitAPI::TEST):
3734         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3735         (TestWebKitAPI::TEST):
3736
3737 2015-08-17  Commit Queue  <commit-queue@webkit.org>
3738
3739         Unreviewed, rolling out r188539, r188544, r188552, and
3740         r188564.
3741         https://bugs.webkit.org/show_bug.cgi?id=148122
3742
3743         Broke tests and some build styles (Requested by ap on
3744         #webkit).
3745
3746         Reverted changesets:
3747
3748         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
3749         bundle"
3750         https://bugs.webkit.org/show_bug.cgi?id=147955
3751         http://trac.webkit.org/changeset/188539
3752
3753         "Web Inspector: split TestStub.js into multiple files and
3754         modernize it"
3755         https://bugs.webkit.org/show_bug.cgi?id=148077
3756         http://trac.webkit.org/changeset/188544
3757
3758         "Web Inspector: InspectorTest should be a subclass of
3759         TestHarness"
3760         https://bugs.webkit.org/show_bug.cgi?id=148079
3761         http://trac.webkit.org/changeset/188552
3762
3763         "Unreviewed internal build fix attempt after r188539."
3764         http://trac.webkit.org/changeset/188564
3765
3766 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
3767
3768         [OS X] Remove support for composite fonts
3769         https://bugs.webkit.org/show_bug.cgi?id=147920
3770
3771         Reviewed by Dan Bernstein.
3772
3773         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3774         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
3775         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3776         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3777         * DumpRenderTree/mac/DumpRenderTree.mm:
3778         (allowedFontFamilySet): Deleted.
3779         (activateTestingFonts): Deleted.
3780         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3781         (WTR::allowedFontFamilySet): Deleted.
3782         (WTR::activateFonts): Deleted.
3783         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3784         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
3785         * WebKitTestRunner/mac/TestControllerMac.mm:
3786         (WTR::allowedFontFamilySet): Deleted.
3787
3788 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
3789
3790         Unreviewed internal build fix attempt after r188539.
3791
3792         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3793
3794 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
3795
3796         Fix the build
3797
3798         Unreviewed.
3799
3800         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3801
3802 2015-08-17  Alex Christensen  <achristensen@webkit.org>
3803
3804         Build Debug Suffix on Windows with CMake
3805         https://bugs.webkit.org/show_bug.cgi?id=148083
3806
3807         Reviewed by Brent Fulgham.
3808
3809         * TestWebKitAPI/CMakeLists.txt:
3810         * TestWebKitAPI/PlatformWin.cmake:
3811         Add DEBUG_SUFFIX
3812
3813 2015-08-17  Anders Carlsson  <andersca@apple.com>
3814
3815         Simplify how PlatformWebViews are created when view options change
3816         https://bugs.webkit.org/show_bug.cgi?id=148093
3817
3818         Reviewed by Sam Weinig.
3819
3820         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
3821
3822         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
3823         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
3824         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
3825
3826         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
3827
3828         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
3829         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
3830
3831         * WebKitTestRunner/TestController.cpp:
3832         (WTR::TestController::ensureViewSupportsOptionsForTest):
3833         (WTR::shouldUseFixedLayout):
3834         (WTR::TestController::viewOptionsForTest):
3835         (WTR::TestController::updateWebViewSizeForTest):
3836         (WTR::TestController::updateWindowScaleForTest):
3837         (WTR::TestController::configureViewForTest):
3838         (WTR::TestController::initialize): Deleted.
3839         (WTR::TestController::ensureViewSupportsOptions): Deleted.
3840         (WTR::TestController::updateLayoutTypeForTest): Deleted.
3841         (WTR::TestController::platformConfigureViewForTest): Deleted.
3842         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
3843         (WTR::TestController::run): Deleted.
3844         * WebKitTestRunner/TestController.h:
3845         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3846         (WTR::shouldUseFixedLayout):
3847         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3848         (WTR::TestController::platformConfigureViewForTest):
3849         (WTR::TestController::platformResetPreferencesToConsistentValues):
3850         * WebKitTestRunner/ios/TestControllerIOS.mm:
3851         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3852         * WebKitTestRunner/mac/TestControllerMac.mm:
3853         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3854         (WTR::TestController::platformConfigureViewForTest):
3855
3856 2015-08-17  Sam Weinig  <sam@webkit.org>
3857
3858         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
3859         https://bugs.webkit.org/show_bug.cgi?id=148097
3860
3861         Reviewed by Anders Carlsson.
3862
3863         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
3864         Add tests for WebsiteDataStores in the WKPageConfiguration.
3865
3866 2015-08-17  Brian Burg  <bburg@apple.com>
3867
3868         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
3869         https://bugs.webkit.org/show_bug.cgi?id=147955
3870
3871         Reviewed by Timothy Hatcher.
3872
3873         To enable sharing of common test code between protocol and model tests,
3874         start loading the protocol TestStub.js through the WebInspectorUI bundle.
3875
3876         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
3877         protocol-test.js uses to load the inspector frontend stub into its iframe
3878         from an arbitrary local file URL.
3879
3880         * DumpRenderTree/TestRunner.cpp:
3881         (getInspectorTestStubURLCallback):
3882         (TestRunner::staticValues):
3883         * DumpRenderTree/TestRunner.h:
3884         * DumpRenderTree/mac/TestRunnerMac.mm:
3885         (SOFT_LINK_STAGED_FRAMEWORK):
3886         (TestRunner::inspectorTestStubURL):
3887         * DumpRenderTree/win/TestRunnerWin.cpp:
3888         (TestRunner::inspectorTestStubURL):
3889         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3890         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3891         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3892         (WTR::TestRunner::inspectorTestStubURL):
3893         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3894         (WTR::TestRunner::inspectorTestStubURL):
3895         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3896         (WTR::TestRunner::inspectorTestStubURL):
3897
3898 2015-08-17  Saam barati  <sbarati@apple.com>
3899
3900         Change email address from saambarati1@gmail.com to sbarati@apple.com
3901
3902         * Scripts/webkitpy/common/config/contributors.json:
3903
3904 2015-08-17  Jason Marcell  <jmarcell@apple.com>
3905
3906         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
3907         repositories other than "openSource" and "internal".
3908         https://bugs.webkit.org/show_bug.cgi?id=147961
3909
3910         Reviewed by Daniel Bates.
3911
3912         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3913         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
3914         generically with repositories other than "openSource" and "internal".
3915
3916 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
3917
3918         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
3919         https://bugs.webkit.org/show_bug.cgi?id=148081
3920
3921         Reviewed by Tim Horton.
3922
3923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3924         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3925
3926 2015-08-11  Andy Estes  <aestes@apple.com>
3927
3928         [Cocoa] Add redirect support to CustomProtocolManager
3929         https://bugs.webkit.org/show_bug.cgi?id=147871
3930
3931         Reviewed by Dan Bernstein.
3932
3933         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
3934
3935         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3936         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
3937         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
3938         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3939         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
3940         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
3941         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
3942         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
3943         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
3944         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3945         (TestWebKitAPI::TEST): Unregistered TestProtocol.
3946         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
3947         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
3948         (-[TestProtocol startLoading]): Taught to handle redirect responses.
3949
3950 2015-08-13  Andy Estes  <aestes@apple.com>
3951
3952         [Cocoa] Downloads do not start if policy decision is made asynchronously
3953         https://bugs.webkit.org/show_bug.cgi?id=147985
3954
3955         Reviewed by Brady Eidson.
3956
3957         Added a new API test.
3958
3959         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3960         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3961         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
3962         (TEST):
3963
3964 2015-08-14  Commit Queue  <commit-queue@webkit.org>
3965
3966         Unreviewed, rolling out r187357.
3967         https://bugs.webkit.org/show_bug.cgi?id=148032
3968
3969         webkit-patch generates incorrect patches that cannot be
3970         applied (Requested by dydz on #webkit).
3971
3972         Reverted changeset:
3973
3974         "Call fixChangeLogPatch when generating patches from webkit-
3975         patch"
3976         https://bugs.webkit.org/show_bug.cgi?id=147248
3977         http://trac.webkit.org/changeset/187357
3978
3979 2015-08-14  Jason Marcell  <jmarcell@apple.com>
3980
3981         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
3982         other than "openSource" and "internal".
3983         https://bugs.webkit.org/show_bug.cgi?id=147938
3984
3985         Reviewed by Daniel Bates.
3986
3987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3988         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
3989         repositories other than "openSource" and "internal".
3990
3991 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
3992
3993         Unreviewed, shorten another test that is timing out.
3994
3995         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3996         (TestWebKitAPI::TEST):
3997
3998 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
3999
4000         AppScale: Assertion hit when hovering a webkit-queue bubble
4001         https://bugs.webkit.org/show_bug.cgi?id=147997
4002
4003         Reviewed by Alexey Proskuryakov.
4004
4005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
4006         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
4007
4008 2015-08-13  Lucas Forschler  <lforschler@apple.com>
4009
4010         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
4011         
4012         Unreviewed.
4013         
4014         * Scripts/copy-webkitlibraries-to-product-directory:
4015
4016 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
4017
4018         Run benchmark customized Dromaeo should not assume there is an internet connection.
4019         https://bugs.webkit.org/show_bug.cgi?id=147995
4020
4021         Reviewed by Ryosuke Niwa.
4022
4023         Add several dependency js libs to local.
4024
4025         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
4026
4027 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
4028
4029         WTF should have a compact Condition object to use with Lock
4030         https://bugs.webkit.org/show_bug.cgi?id=147986
4031
4032         Reviewed by Geoffrey Garen.
4033
4034         Add a test for WTF::Condition.
4035
4036         * TestWebKitAPI/CMakeLists.txt:
4037         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4039         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
4040         (TestWebKitAPI::TEST):
4041         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4042         (TestWebKitAPI::runLockTest): Change the name of the thread.
4043
4044 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
4045
4046         Unreviewed, shorten another test. It's timing out in debug on some bot.
4047
4048         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4049         (TestWebKitAPI::TEST):
4050
4051 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
4052
4053         WTF::Lock should not suffer from the thundering herd
4054         https://bugs.webkit.org/show_bug.cgi?id=147947
4055
4056         Reviewed by Geoffrey Garen.
4057
4058         Add testing that checks that locks return to a pristine state after contention is over.
4059
4060         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4061         (TestWebKitAPI::LockInspector::isFullyReset):
4062         (TestWebKitAPI::runLockTest):
4063         (TestWebKitAPI::TEST):
4064
4065 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
4066
4067         Benchmarks supported by run_benchmark script should not assume we have internet access.
4068         https://bugs.webkit.org/show_bug.cgi?id=147959
4069
4070         Reviewed by Ryosuke Niwa.
4071
4072         For JSBench we should not request jquery.min.js from google through the internet.
4073
4074         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
4075
4076 2015-08-12  Jason Marcell  <jmarcell@apple.com>
4077
4078         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
4079         other than "openSource" and "internal".
4080         https://bugs.webkit.org/show_bug.cgi?id=147796
4081
4082         Reviewed by Daniel Bates.
4083
4084         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4085         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
4086         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
4087         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
4088         and another assertion that, if the previousIteration is non-null, the given repository is in
4089         previousIteration.revision.
4090         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
4091         with repositories other than "openSource" and "internal". Also added an assertion that the returned
4092         fragment has at least one child node.
4093
4094 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
4095
4096         Add a tool that dumps class and struct member layout, showing padding
4097         https://bugs.webkit.org/show_bug.cgi?id=147898
4098
4099         Reviewed by Zalan Bujtas.
4100         
4101         This 'dump-class-layout' script uses the lldb Python bindings to collect data
4102         about data member layout, and displays it.
4103         
4104         Sample output:
4105
4106               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
4107               +0 < 56>     WebCore::URL m_value;
4108               +0 <  8>         WTF::String m_string;
4109               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
4110               +0 <  8>                 WTF::StringImpl * m_ptr;
4111               +8 <  1>         bool:1 m_isValid;
4112               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
4113               +9 <  3>         <PADDING>
4114              +12 <  4>         int m_schemeEnd;
4115              +16 <  4>         int m_userStart;
4116              +20 <  4>         int m_userEnd;
4117              +24 <  4>         int m_passwordEnd;
4118              +28 <  4>         int m_hostEnd;
4119              +32 <  4>         int m_portEnd;
4120              +36 <  4>         int m_pathAfterLastSlash;
4121              +40 <  4>         int m_pathEnd;
4122              +44 <  4>         int m_queryEnd;
4123              +48 <  4>         int m_fragmentEnd;
4124              +52 <  4>         <PADDING>
4125              +52 <  4>     <PADDING>
4126              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
4127              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
4128             Total byte size: 72
4129             Total pad bytes: 11
4130             Padding percentage: 15.28 %
4131
4132         * Scripts/dump-class-layout: Added.
4133         (webkit_build_dir):
4134         (developer_dir):
4135         (import_lldb):
4136         (find_build_directory):
4137         (verify_type):
4138         (verify_type_recursive):
4139         (dump_class):
4140         (main):
4141         (main.or):
4142
4143 2015-08-12  Alex Christensen  <achristensen@webkit.org>
4144
4145         Fix Debug CMake builds on Windows
4146         https://bugs.webkit.org/show_bug.cgi?id=147940
4147
4148         Reviewed by Chris Dumez.
4149
4150         * DumpRenderTree/PlatformWin.cmake:
4151         * TestWebKitAPI/PlatformWin.cmake:
4152         The BitmapImage test is not enabled on the AppleWin port.
4153         * WinLauncher/CMakeLists.txt:
4154         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
4155
4156 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4157
4158         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
4159
4160         In r188125 I added a way to mark tests as slow to use a longer
4161         timeout. But it seems it was not enough for
4162         WTF_Lock.ContendedShortSection, so let's try again with a longer
4163         timeout now.
4164
4165         * Scripts/run-gtk-tests:
4166         (TestRunner._run_google_test):
4167
4168 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
4169
4170         Allow --debug option in run-jsc
4171         https://bugs.webkit.org/show_bug.cgi?id=147923
4172
4173         Reviewed by Csaba Osztrogonác.
4174
4175         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
4176
4177         * Scripts/run-jsc:
4178
4179 2015-08-11  Alex Christensen  <achristensen@webkit.org>
4180
4181         Fix test after build fix in r188286.
4182         https://bugs.webkit.org/show_bug.cgi?id=147907
4183
4184         Reviewed by Anders Carlsson.
4185
4186         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
4187         sleep_for can now be used, but we need to include <thread>
4188
4189 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
4190
4191         Always use a byte-sized lock implementation
4192         https://bugs.webkit.org/show_bug.cgi?id=147908