watchlist: Add a stylecheck to do validity checks for the watchlist config.
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-19  David Levin  <levin@chromium.org>
2
3         watchlist: Add a stylecheck to do validity checks for the watchlist config.
4         https://bugs.webkit.org/show_bug.cgi?id=69487
5
6         Reviewed by Adam Barth.
7
8         * Scripts/webkitpy/style/checker.py: Add the watchlist file type.
9         * Scripts/webkitpy/style/checkers/watchlist.py: Added.
10         * Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
11
12 2011-10-19  Eric Seidel  <eric@webkit.org>
13
14         NRWT ServerProcess can't read lines from stderr and stdio separately
15         https://bugs.webkit.org/show_bug.cgi?id=70435
16
17         Reviewed by Adam Barth.
18
19         This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
20         DRT expects RWT to read one line at a time from stderr and stdout independently.
21         This allows DRT to communicate errors over stderr and have them responded to immediately
22         regardless of what state the stdio stream may be in.  Previously NRWT's ServerProcess
23         class only exposed a read_line function which would read a line from stdout
24         and batch all output from stderr into an error buffer.  Callers would only be able
25         to respond to commands over stderr if they happened to correspond with a stdout line boundary.
26
27         * Scripts/webkitpy/layout_tests/port/server_process.py:
28         * Scripts/webkitpy/layout_tests/port/webkit.py:
29
30 2011-10-19  Chang Shu  <cshu@webkit.org>
31
32         [Qt] Support WK1-only Skipped list
33         https://bugs.webkit.org/show_bug.cgi?id=70254
34
35         Reviewed by Csaba Osztrogonác.
36
37         Added a new search path qt-wk1 for skipping WK1-only tests.
38
39         * Scripts/webkitpy/layout_tests/port/qt.py: NRWT
40         * Scripts/old-run-webkit-tests: ORWT
41
42 2011-10-19  Gabor Rapcsanyi  <rgabor@webkit.org>
43
44         [GTK] Enable to use built-product-archive on GTK platform
45         https://bugs.webkit.org/show_bug.cgi?id=70319
46
47         Reviewed by Csaba Osztrogonác.
48
49         * BuildSlaveSupport/built-product-archive:
50
51 2011-10-18  David Levin  <levin@chromium.org>
52
53         watchlist: Should try to run if it can and not throw on mistakes.
54         https://bugs.webkit.org/show_bug.cgi?id=70358
55
56         Reviewed by Adam Barth.
57
58         * Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
59         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
60         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
61         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
62         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
63         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
64
65 2011-10-18  Sam Weinig  <sam@webkit.org>
66
67         Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
68         https://bugs.webkit.org/show_bug.cgi?id=70387
69
70         Reviewed by Dan Bernstein.
71
72         * MiniBrowser/mac/BrowserWindowController.m:
73         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
74         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
75         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
76         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
77         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
78         Update to include WKViewPrivate.h where necessary.
79
80 2011-10-18  Joseph Pecoraro  <joepeck@webkit.org>
81
82         Web Inspector: Some localizedStrings.js Updates
83         https://bugs.webkit.org/show_bug.cgi?id=70365
84
85         Reviewed by Darin Adler.
86
87         * Scripts/check-inspector-strings:
88         Updated to the new webkitpy way to determine checkout root.
89
90         * Scripts/webkitdirs.pm:
91         (copyInspectorFrontendFiles):
92         Made it so build-webkit --inspector-frontend copies over
93         the localizedStrings.js file as well as the frontend files.
94
95 2011-10-18  Raphael Kubo da Costa  <kubo@profusion.mobi>
96
97         [EFL] DRT: Clear list of visited pages before each test.
98         https://bugs.webkit.org/show_bug.cgi?id=70355
99
100         Reviewed by Antonio Gomes.
101
102         r97596 uncovered a bug in the implementation: the list of visited
103         links was not cleared between tests, which caused tests such as
104         fast/repaint/outline-repaint-glitch.html to be flaky (the link color
105         changed depending on whether fast/repaint/border-repaint-glitch.html
106         was visited before or not).
107
108         Call ewk_history_clear to make sure the visited links list does not
109         persist between tests.
110
111         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
112         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
113
114 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
115
116         Split TestExpectationsEditor into its own file.
117         https://bugs.webkit.org/show_bug.cgi?id=70348
118
119         Reviewed by Adam Barth.
120
121         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
122         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
123         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
124         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
125         * Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
126
127 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
128
129         [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
130         https://bugs.webkit.org/show_bug.cgi?id=70313
131
132         Reviewed by Adam Barth.
133
134         Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
135         this parameter because build-webkit and other scripts don't accept it.
136
137         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
138
139 2011-10-18  Adam Barth  <abarth@webkit.org>
140
141         Subscribe myself to WebIDL changes
142         https://bugs.webkit.org/show_bug.cgi?id=70341
143
144         Reviewed by David Levin.
145
146         I've also added some documentation and refactored my previous
147         subscriptions to make it eaiser for others to subscribe as well.
148
149         * Scripts/webkitpy/common/config/watchlist:
150
151 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
152
153         Add myself to the newfangled watchlist plumbing.
154         https://bugs.webkit.org/show_bug.cgi?id=70338
155
156         Reviewed by David Levin.
157
158         * Scripts/webkitpy/common/config/watchlist: Added sheepishly.
159
160 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
161
162         Fix a unit test in TestFailures.
163         https://bugs.webkit.org/show_bug.cgi?id=70337
164
165         Reviewed by Adam Barth.
166
167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
168             the value of a method property should always be lowercase.
169
170 2011-10-18  Adam Barth  <abarth@webkit.org>
171
172         Always enable ENABLE(XPATH)
173         https://bugs.webkit.org/show_bug.cgi?id=70217
174
175         Reviewed by Eric Seidel.
176
177         * Scripts/build-webkit:
178
179 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
180
181         garden-o-matic should not report flaking in expected failures as failures.
182         https://bugs.webkit.org/show_bug.cgi?id=70279
183
184         Reviewed by Adam Barth.
185
186         On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
187         For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
188         same for garden-o-matic.
189
190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
191             rewrote the logic for determining expected or unexpected failures as a central analysis tool.
192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
193
194 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
195
196         [Gtk] Support for client-based geolocation
197         https://bugs.webkit.org/show_bug.cgi?id=64970
198
199         Reviewed by Martin Robinson.
200
201         Add support for testing client-based geolocation tests in DumpRenderTree.
202
203         * DumpRenderTree/gtk/DumpRenderTree.cpp:
204         (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
205         (createWebView): Create web view after declaring DumpRenderTree mode.
206         That way a mock client for geolocation is used instead of a GeoClue
207         client if a web view is created when testing.
208         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
209         geolocation layout tests.
210         (LayoutTestController::setMockGeolocationPosition):
211         (LayoutTestController::setMockGeolocationError):
212         (LayoutTestController::setGeolocationPermission):
213         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
214         * Scripts/build-webkit: Note that the Gtk port is using client-based
215         geolocation, even though changing this flag has no effect on compilation.
216
217 2011-10-07  Andrey Kosyakov  <caseq@chromium.org>
218
219         [Chromium] suppress console output from DevTools window
220         https://bugs.webkit.org/show_bug.cgi?id=69632
221
222         Reviewed by Pavel Feldman.
223
224         * DumpRenderTree/chromium/TestShell.cpp:
225         (TestShell::showDevTools):
226         * DumpRenderTree/chromium/WebViewHost.cpp:
227         (WebViewHost::didAddMessageToConsole):
228         (WebViewHost::reset):
229         (WebViewHost::setLogConsoleOutput):
230         * DumpRenderTree/chromium/WebViewHost.h:
231
232 2011-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
233
234         Unreviewed, rolling out r97735.
235         http://trac.webkit.org/changeset/97735
236         https://bugs.webkit.org/show_bug.cgi?id=70317
237
238         some people apparently use build-jsc with the qt port without
239         building webkit first (Requested by torarne on #webkit).
240
241         * Scripts/build-webkit:
242         * Scripts/webkitdirs.pm:
243         (buildQMakeProject):
244         (buildQMakeQtProject):
245
246 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
247
248         [Qt] Remove dead code in build-webkit
249
250         build-webkit will iterate over a list of subdirectories to build,
251         but this feature is only used by the Apple ports. For QtWebKit we
252         always pass an empty directory to buildQMakeProject, which makes
253         the logic for dealing with sub-projects in buildQMakeProject just
254         added noise.
255
256         If we do want this feature at some point, we should redo it in
257         the context of the upcoming build system changes for Qt.
258
259         Reviewed by Simon Hausmann.
260
261         * Scripts/build-webkit:
262         * Scripts/webkitdirs.pm:
263         (buildQt):
264
265 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
266
267         Remove traces of Symbian support from the build scripts
268
269         Reviewed by Simon Hausmann.
270
271         * Scripts/build-webkit:
272         * Scripts/webkitdirs.pm:
273         (determineBaseProductDir):
274         (argumentsForConfiguration):
275         (usesPerConfigurationBuildDirectory):
276         (buildQMakeProject):
277
278 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
279
280         Build fix after r97672.
281
282         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
283
284 2011-10-17  Kent Tamura  <tkent@chromium.org>
285
286         A follow-up of r97716.
287         https://bugs.webkit.org/show_bug.cgi?id=68803
288
289         * DumpRenderTree/chromium/LayoutTestController.cpp:
290         (LayoutTestController::reset): Initialize m_dumpCreateView.
291
292 2011-10-17  Jochen Eisinger  <jochen@chromium.org>
293
294         [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
295         https://bugs.webkit.org/show_bug.cgi?id=68803
296
297         Reviewed by Nate Chapin.
298
299         * DumpRenderTree/chromium/LayoutTestController.cpp:
300         (LayoutTestController::LayoutTestController):
301         (LayoutTestController::dumpCreateView):
302         * DumpRenderTree/chromium/LayoutTestController.h:
303         (LayoutTestController::shouldDumpCreateView):
304         * DumpRenderTree/chromium/WebViewHost.cpp:
305         (WebViewHost::createView):
306
307 2011-10-17  Nate Chapin  <japhet@chromium.org>
308
309         Add myself to watchlists, and add a watch
310         for Source/WebCore/loader/.
311         https://bugs.webkit.org/show_bug.cgi?id=70263
312
313         Reviewed by David Levin.
314
315         * Scripts/webkitpy/common/config/watchlist:
316
317 2011-10-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
318
319         [EFL] DRT: Make non-recognized keys work in events as well.
320         https://bugs.webkit.org/show_bug.cgi?id=69860
321
322         Reviewed by Antonio Gomes.
323
324         fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
325         here: it has a select box with a few non-latin options, and one of them
326         is selected via the keyboard.
327
328         In this specific case, we need to make EventHandler::keyEvent send a
329         keyPressEvent to SelectElement, so that
330         SelectElement::defaultEventHandler calls typeAheadFind(). This happens
331         only when PlatformKeyEvent::text() is not empty, which was not the case
332         so far.
333
334         * DumpRenderTree/efl/EventSender.cpp:
335         (keyDownCallback):
336
337 2011-10-17  Alok Priyadarshi  <alokp@chromium.org>
338
339         Add layout tests for WebPlugin compositor path
340         https://bugs.webkit.org/show_bug.cgi?id=69027
341
342         Reviewed by James Robinson.
343
344         * DumpRenderTree/DumpRenderTree.gypi:
345         * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
346         (premultiplyAlpha):
347         (TestWebPlugin::TestWebPlugin):
348         (TestWebPlugin::~TestWebPlugin):
349         (TestWebPlugin::mimeType):
350         (TestWebPlugin::initialize):
351         (TestWebPlugin::destroy):
352         (TestWebPlugin::updateGeometry):
353         (TestWebPlugin::parsePrimitive):
354         (TestWebPlugin::parseColor):
355         (TestWebPlugin::parseOpacity):
356         (TestWebPlugin::initScene):
357         (TestWebPlugin::drawScene):
358         (TestWebPlugin::destroyScene):
359         (TestWebPlugin::initProgram):
360         (TestWebPlugin::initPrimitive):
361         (TestWebPlugin::drawPrimitive):
362         (TestWebPlugin::loadShader):
363         (TestWebPlugin::loadProgram):
364         * DumpRenderTree/chromium/TestWebPlugin.h: Added.
365         (TestWebPlugin::scriptableObject):
366         (TestWebPlugin::paint):
367         (TestWebPlugin::updateFocus):
368         (TestWebPlugin::updateVisibility):
369         (TestWebPlugin::acceptsInputEvents):
370         (TestWebPlugin::handleInputEvent):
371         (TestWebPlugin::didReceiveResponse):
372         (TestWebPlugin::didReceiveData):
373         (TestWebPlugin::didFinishLoading):
374         (TestWebPlugin::didFailLoading):
375         (TestWebPlugin::didFinishLoadingFrameRequest):
376         (TestWebPlugin::didFailLoadingFrameRequest):
377         (TestWebPlugin::Scene::Scene):
378         * DumpRenderTree/chromium/WebViewHost.cpp:
379         (WebViewHost::createPlugin):
380
381 2011-10-17  Ryosuke Niwa  <rniwa@webkit.org>
382
383         [nrwt] Add new category for MISSING
384         https://bugs.webkit.org/show_bug.cgi?id=69990
385
386         Reviewed by Dirk Pranke.
387
388         Treat missing results as a new category in summerize_results.
389
390         Because Chromium port wants to turn bots red when there are tests with missing results,
391         extracted the logic to compute the exit code as exit_code_from_summarized_results in
392         base and chromium ports.
393
394         * Scripts/webkitpy/layout_tests/controllers/manager.py:
395         * Scripts/webkitpy/layout_tests/port/base.py:
396         * Scripts/webkitpy/layout_tests/port/chromium.py:
397         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
398
399 2011-10-17  Dimitri Glazkov  <dglazkov@chromium.org>
400
401         garden-o-matic operations fail because of CSP.
402         https://bugs.webkit.org/show_bug.cgi?id=70249
403
404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
405
406 2011-10-17  Ada Chan  <adachan@apple.com>
407
408         Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
409         https://bugs.webkit.org/show_bug.cgi?id=70168
410
411         Reviewed by Alexey Proskuryakov.
412
413         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
414         (TestWebKitAPI::didFinishLoadForFrame):
415         (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
416
417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
418         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
419         Add the new file.
420
421 2011-10-17  Darin Adler  <darin@apple.com>
422
423         Add some more *.pyc ignores in directories with Python scripts.
424
425         * QueueStatusServer: Added property svn:ignore.
426         * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
427         * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
428         * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
429
430 2011-10-17  Alexis Menard  <alexis.menard@openbossa.org>
431
432         [Qt][WK2][meta] Fix failing API tests
433         https://bugs.webkit.org/show_bug.cgi?id=70236
434
435         Reviewed by Csaba Osztrogonác.
436
437         In order to run WebKit2 API tests we need the WebProcess to be in
438         the path so let's add the bin directory when running the API tests of Qt.
439
440         * Scripts/run-qtwebkit-tests:
441
442 2011-10-17  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
443
444         [Qt][WK2] Build dependency problems
445         https://bugs.webkit.org/show_bug.cgi?id=68456
446
447         Reviewed by Csaba Osztrogonác.
448
449         * Scripts/webkitdirs.pm:
450         (buildQMakeProject):
451
452 2011-10-17  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
453
454         [build] Introduce Qt/SH4 buildbot
455         https://bugs.webkit.org/show_bug.cgi?id=70227
456
457         Reviewed by Adam Roben.
458
459         Add buildslave for Linux/Qt/SH4.
460
461         * BuildSlaveSupport/build.webkit.org-config/config.json:
462
463 2011-10-16  Adam Barth  <abarth@webkit.org>
464
465         Always enable ENABLE(DOM_STORAGE)
466         https://bugs.webkit.org/show_bug.cgi?id=70189
467
468         Reviewed by Eric Seidel.
469
470         * Scripts/build-webkit:
471         * waf/build/settings.py:
472
473 2011-10-15  Adam Barth  <abarth@webkit.org>
474
475         Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
476         https://bugs.webkit.org/show_bug.cgi?id=70194
477
478         Reviewed by Daniel Bates.
479
480         * Scripts/build-webkit:
481
482 2011-10-15  Ojan Vafai  <ojan@chromium.org>
483
484         run-webkit-tests should accept --child-processes
485         https://bugs.webkit.org/show_bug.cgi?id=69713
486
487         Reviewed by Adam Barth.
488
489         Only set --child-processes=1 if --child-processes it not
490         passed on the commandline.
491
492         * Scripts/run-webkit-tests:
493
494 2011-10-15  Daniel Bates  <dbates@webkit.org>
495
496         Extract common gdb code into its own function; Remove script gdb-safari
497         https://bugs.webkit.org/show_bug.cgi?id=68499
498
499         Reviewed by David Kilzer.
500
501         Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
502         runSafari}() and in the script gdb-safari to launch gdb to debug an application.
503         We should extract the common parts into a function that can be shared by all callers
504         so as to remove duplicate code.
505
506         As a side effect of removing duplicate code we can remove the script gdb-safari since
507         its code has been incorporated into webkitdirs::debugSafari() which is called by the
508         script debug-safari.
509
510         * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
511         * Scripts/gdb-safari: Removed.
512         * Scripts/webkitdirs.pm:
513         (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
514         debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
515         script gdb-safari to here.
516         (debugSafari): Added.
517         (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
518         Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
519         runSafari() always returns 1 on Windows and the script run-safari exits using this
520         value as its exit status. Hence, the script run-safari always exits with a nonzero
521         exit status (i.e. abnormal termination) on Windows. Instead, we should return the
522         exit status of the WebKit launcher application.
523         (debugMiniBrowser): Modified to call debugMacWebKitApp().
524         (debugWebKitTestRunner): Ditto.
525
526 2011-10-15  Robert Hogan  <robert@webkit.org>
527
528         [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
529         https://bugs.webkit.org/show_bug.cgi?id=70056
530
531         Reviewed by Adam Barth.
532
533         The preferred file-order for patches is LayoutTests at the end and
534         ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use 
535         it when creating patches for review and landing.
536
537         * Scripts/webkitpy/common/checkout/scm/git.py:
538         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
539         * Scripts/webkitpy/common/config/orderfile: Added.
540
541 2011-10-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
542
543         [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
544         https://bugs.webkit.org/show_bug.cgi?id=69920
545
546         Reviewed by Kenneth Rohde Christiansen.
547
548         * DumpRenderTree/qt/DumpRenderTree.pro:
549         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
550         (WebCore::DumpRenderTree::open):
551         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
552         * QtTestBrowser/QtTestBrowser.pro:
553         * QtTestBrowser/launcherwindow.cpp:
554         (LauncherWindow::screenshot):
555         (LauncherWindow::showFPS):
556         (LauncherWindow::updateFPS):
557         * QtTestBrowser/launcherwindow.h:
558         (WindowOptions::WindowOptions):
559         * QtTestBrowser/mainwindow.cpp:
560         (MainWindow::buildUI):
561         * Scripts/webkitpy/style/checker.py: Remove rules for the
562         WebKit/qt/symbian/platformplugin directory.
563         * Scripts/webkitpy/style/checker_unittest.py:
564         * Tools.pro:
565         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
566         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
567         (WTR::LayoutTestController::platformInitialize):
568         * WebKitTestRunner/qt/TestControllerQt.cpp:
569         (WTR::isExistingLibrary):
570         * WebKitTestRunner/qt/WebKitTestRunner.pro:
571
572 2011-10-15  Adam Barth  <abarth@webkit.org>
573
574         Fix typo in webkitpy help
575         https://bugs.webkit.org/show_bug.cgi?id=70169
576
577         Reviewed by Eric Seidel.
578
579         * Scripts/webkitpy/tool/commands/upload.py:
580
581 2011-10-15  Tony Chang  <tony@chromium.org>
582
583         fix another typo in treemap.html
584         https://bugs.webkit.org/show_bug.cgi?id=70149
585
586         Reviewed by Ojan Vafai.
587
588         Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
589
590         * TestResultServer/static-dashboards/treemap.html:
591
592 2011-10-14  Adam Barth  <abarth@webkit.org>
593
594         Hide status bubbles from queues which are very far behind
595         https://bugs.webkit.org/show_bug.cgi?id=70133
596
597         Reviewed by Eric Seidel.
598
599         The mac-ews is so far behind that we shouldn't show its status bubble.
600         The status bubble just makes contributors sad.
601
602         * QueueStatusServer/handlers/statusbubble.py:
603
604 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
605
606         Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
607         https://bugs.webkit.org/show_bug.cgi?id=70143
608
609         Reviewed by Adam Barth.
610
611         * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
612         * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
613
614 2011-10-14  David Levin  <levin@chromium.org>
615
616         watchlist: Add a validation check for the email names in the list.
617         https://bugs.webkit.org/show_bug.cgi?id=70154
618
619         Reviewed by Adam Barth.
620
621         If an email is listed which doesn't have a bugzilla log in, then any emails
622         added to the bug along with that email will fail to happen, so try to prevent this
623         from happening by validating that emails added to the watchlist are known to be
624         contributors.
625
626         * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
627         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
628         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
629
630 2011-10-14  David Levin  <levin@chromium.org>
631
632         watchlist: If the style check fails, then the watchlist will not be run.
633         https://bugs.webkit.org/show_bug.cgi?id=69484
634
635         Reviewed by Adam Barth.
636
637         * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
638         if the style part fails and don't allow watch list failures turn the
639         bot run red.
640         * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
641         * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
642
643 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
644
645         Plumb style-checker filter up to command options and make land-cowboy use it.
646         https://bugs.webkit.org/show_bug.cgi?id=70119
647
648         Reviewed by Adam Barth.
649
650         * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
651         * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
652         * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
653         * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
654         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
655         * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
656         * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
657
658 2011-10-14  Sam Weinig  <sam@webkit.org>
659
660         Remove the Leopard slaves.
661
662         Reviewed by Adam Roben.
663
664         * BuildSlaveSupport/build.webkit.org-config/config.json:
665
666 2011-10-14  Peter Beverloo  <peter@chromium.org>
667
668         [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
669         https://bugs.webkit.org/show_bug.cgi?id=70028
670
671         Reviewed by Adam Barth.
672
673         * Scripts/update-webkit-chromium:
674         * Scripts/webkitdirs.pm:
675         (buildChromiumMakefile):
676         (buildChromium):
677
678 2011-10-14  Leandro Pereira  <leandro@profusion.mobi>
679
680         Unreviewed; add missing #includes.
681
682         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
683         * DumpRenderTree/efl/EventSender.cpp:
684
685 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
686
687         [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
688         https://bugs.webkit.org/show_bug.cgi?id=69770
689
690         Reviewed by Antonio Gomes.
691
692         We were just appending the given URL to the absolute URI of the main
693         frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
694         instead of "file:///foo/bar/theother/url.html".
695
696         This should make fast/dom/navigation-type-navigate.html behave
697         better (it still fails, but later).
698
699         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
700         (LayoutTestController::queueLoad):
701
702 2011-10-13  Arko Saha  <arko@motorola.com>
703
704         Microdata: Basic implementation of document.getItems() method.
705         https://bugs.webkit.org/show_bug.cgi?id=68610
706
707         Reviewed by Ryosuke Niwa.
708
709         Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
710         Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
711
712         * Scripts/build-webkit:
713
714 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
715
716         new-run-webkit-tests does not support qt-4.8 results
717         https://bugs.webkit.org/show_bug.cgi?id=64071
718
719         Roll-back second part of r97252. :)
720
721         * Scripts/webkitpy/layout_tests/port/qt.py:
722
723 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
724
725         [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
726         https://bugs.webkit.org/show_bug.cgi?id=70106
727
728         Reviewed by Antonio Gomes.
729
730         OwnFastMallocPtr was being used as a smart pointer that automatically called
731         free() on the strings returned by the EFL or by ewk.
732
733         However, when WTF is built in release mode, it uses its own memory management
734         code instead of using the system malloc(), free() and friends. This means bad
735         things will happen when one uses WTF's free() on memory allocated with system
736         malloc() by the EFL or ewk.
737
738         The easiest way to solve this is to call free() ourselves.
739
740         * DumpRenderTree/efl/DumpRenderTree.cpp:
741         (dumpFramesAsText):
742         (getFinalTestURL):
743
744 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
745
746         [EFL] Add DumpRenderTreeSupportEfl
747         https://bugs.webkit.org/show_bug.cgi?id=68458
748
749         Reviewed by Kenneth Rohde Christiansen.
750
751         Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
752
753         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
754         (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
755         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
756         (DumpRenderTreeChrome::onWindowObjectCleared):
757         (DumpRenderTreeChrome::onDocumentLoadFinished):
758         * DumpRenderTree/efl/GCControllerEfl.cpp:
759         (GCController::collect):
760         (GCController::collectOnAlternateThread):
761         (GCController::getJSObjectCount):
762         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
763         (LayoutTestController::counterValueForElementById):
764         (LayoutTestController::pageNumberForElementById):
765         (LayoutTestController::numberOfPages):
766         (LayoutTestController::workerThreadCount):
767         (LayoutTestController::findString):
768         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
769         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
770         (LayoutTestController::sampleSVGAnimationForElementAtTime):
771         (LayoutTestController::numberOfActiveAnimations):
772         (LayoutTestController::suspendAnimations):
773         (LayoutTestController::resumeAnimations):
774         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
775         (createBitmapContextFromWebView):
776
777 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
778
779         [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
780
781         Unreviewed.
782
783         * Scripts/run-webkit-tests:
784         (useNewRunWebKitTests):
785
786 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
787
788         new-run-webkit-tests does not support qt-4.8 results
789         https://bugs.webkit.org/show_bug.cgi?id=64071
790
791         Roll-back r97252 with unit test fix.
792
793         Reviewed by Csaba Osztrogonác.
794
795         * Scripts/webkitpy/layout_tests/port/qt.py:
796         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
797
798 2011-10-13  Ojan Vafai  <ojan@chromium.org>
799
800         Make filter-build-webkit exit 1 if the build fails.
801         https://bugs.webkit.org/show_bug.cgi?id=70080
802
803         Reviewed by Eric Seidel.
804
805         This only works if you redirect stderr to stdout, but it at least makes it possible.
806         This is useful if you want to run a followup command (e.g. run-webkit-tests) but
807         only if the build succeeds.
808
809         * Scripts/filter-build-webkit:
810
811 2011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
812
813         land-cowboy should at least check style.
814         https://bugs.webkit.org/show_bug.cgi?id=70073
815
816         Reviewed by Adam Barth.
817
818         * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
819
820 2011-10-13  Tony Chang  <tony@chromium.org>
821
822         fix regex in layout test times dashboard
823         https://bugs.webkit.org/show_bug.cgi?id=70059
824
825         This fixes the treemapfocus query param.
826
827         Reviewed by Ojan Vafai.
828
829         * TestResultServer/static-dashboards/treemap.html:
830
831 2011-10-13  Beth Dakin  <bdakin@apple.com>
832
833         https://bugs.webkit.org/show_bug.cgi?id=70050
834         DRT and WRT should have HiDPI testing capabilities
835
836         Reviewed by Darin Adler.
837
838         New layoutTestController function setBackingScaleFactor takes a double for a scale 
839         factor and a callback function to call once the backing scale factor has 
840         successfully been set for the view.
841         * DumpRenderTree/LayoutTestController.cpp:
842         (setBackingScaleFactorCallback):
843         (LayoutTestController::staticFunctions):
844
845         On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other 
846         platforms do nothing.
847         * DumpRenderTree/LayoutTestController.h:
848         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
849         (LayoutTestController::setBackingScaleFactor):
850         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
851         (LayoutTestController::setBackingScaleFactor):
852         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
853         (LayoutTestController::setBackingScaleFactor):
854
855         Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a 
856         value of 0, which resets to the system default.
857         * DumpRenderTree/mac/DumpRenderTree.mm:
858         (resetWebViewToConsistentStateBeforeTesting):
859
860         When generating the pixel dump, create a Bitmap of the appropriate size based on 
861         the backing scale factor. If it is a HiDPI view, paint into the context using 
862         displayRectIgnoringOpacity.
863         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
864         (createBitmapContextFromWebView):
865
866         And now the same stuff for WK2. Again, new layoutTestController function 
867         setBackingScaleFactor takes a double for a scale factor and a callback function. 
868         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
869         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
870         (WTR::LayoutTestController::setBackingScaleFactor):
871         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
872         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
873
874         The InjectedBundle sends a message to the UI process to set the backing scale 
875         factor. It also processes a message the UI process will send back once it 
876         completes this task, and at that time, the InjectedBundle calls the callback.
877         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
878         (WTR::InjectedBundle::didReceiveMessage):
879         (WTR::InjectedBundle::postSetBackingScaleFactor):
880         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
881
882         Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor 
883         with a value of 0, which resets to the system default.
884         * WebKitTestRunner/TestController.cpp:
885         (WTR::TestController::resetStateToConsistentValues):
886
887         Upon receiving the SetBackingScaleFactor message, call 
888         WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message 
889         back to InjectedBundle to say it has been done.
890         * WebKitTestRunner/TestInvocation.cpp:
891         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
892         
893         Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a 
894         window's scale factor so we have to avoid that.
895         * WebKitTestRunner/cg/TestInvocationCG.cpp:
896         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
897
898 2011-10-13  John Knottenbelt  <jknotten@chromium.org>
899
900         [Chromium] Allow building without speech input enabled.
901         https://bugs.webkit.org/show_bug.cgi?id=69867
902
903         Reviewed by Darin Fisher.
904
905         * DumpRenderTree/chromium/LayoutTestController.cpp:
906         (LayoutTestController::addMockSpeechInputResult):
907
908 2011-10-13  Kent Tamura  <tkent@chromium.org>
909
910         [Chromium] A DRT fix for r97348.
911
912         * DumpRenderTree/chromium/LayoutTestController.cpp:
913         (LayoutTestController::overridePreference):
914         Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
915         print an error message.
916
917 2011-10-12  Lucas Forschler  <lforschler@apple.com>
918
919         Update kill-old-processes logic.
920         https://bugs.webkit.org/show_bug.cgi?id=63651
921
922         Reviewed by Ryosuke Niwa.
923
924         Remove unused mac platform specific folder.
925         Update master.config to use new kill-old-processes.
926
927         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
928         * BuildSlaveSupport/kill-old-processes:
929         * BuildSlaveSupport/mac: Removed.
930
931 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
932
933         [NRWT] New tests without expected files are reported as flakey tests
934         https://bugs.webkit.org/show_bug.cgi?id=67268
935
936         Reviewed by Dirk Pranke.
937
938         The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
939         and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
940         for missing results in retry_summary.
941
942         Fixed the bug by treating missing results separately.
943
944         * Scripts/webkitpy/layout_tests/controllers/manager.py:
945         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
946
947 2011-10-12  Adam Barth  <abarth@webkit.org>
948
949         Remove ENABLE(XHTMLMP) and associated code
950         https://bugs.webkit.org/show_bug.cgi?id=69729
951
952         Reviewed by David Levin.
953
954         * Scripts/build-webkit:
955         * Scripts/old-run-webkit-tests:
956         * Scripts/webkitperl/features.pm:
957         * Scripts/webkitpy/layout_tests/port/webkit.py:
958         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
959
960 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
961
962         Kill old run-webkit-tests processes in kill-process on Mac
963         https://bugs.webkit.org/show_bug.cgi?id=69976
964
965         Reviewed by Dirk Pranke.
966
967         Add a system call to remove all python processes running run-webkit-tests.
968
969         * BuildSlaveSupport/kill-old-processes:
970         * BuildSlaveSupport/mac: Removed.
971
972 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
973
974         Many WK2 snapshots are blank
975         https://bugs.webkit.org/show_bug.cgi?id=69953
976
977         Reviewed by Beth Dakin.
978         
979         Two fixes:
980         1. negating a size_t in CGContextTranslateCTM() fails, because
981         size_t is unsigned. Fix by casing to CGFloat before negation.
982         
983         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
984         Autodisplay is necessary to kick off Core Animation rendering.
985
986         * WebKitTestRunner/cg/TestInvocationCG.cpp:
987         (WTR::createCGContextFromImage):
988         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
989         (WTR::PlatformWebView::PlatformWebView):
990
991 2011-10-12  Adam Barth  <abarth@webkit.org>
992
993         commit-queue doesn't have a friendly error message when the reviewer line is messed up
994         https://bugs.webkit.org/show_bug.cgi?id=69979
995
996         Reviewed by Eric Seidel.
997
998         Rather than combining the ChangeLog validation with a more complicated
999         command, this patch has the commit-queue run it as a separate command,
1000         which will give us more control over the error message.
1001
1002         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1003         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1004         * Scripts/webkitpy/tool/commands/download.py:
1005         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1006         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1007         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1008
1009 2011-10-12  Eric Seidel  <eric@webkit.org>
1010
1011         Layout tests asserting in LayoutTestController::pathToLocalResource()
1012         https://bugs.webkit.org/show_bug.cgi?id=69898
1013
1014         Reviewed by Simon Fraser.
1015
1016         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
1017
1018         * Scripts/old-run-webkit-tests:
1019         (openDumpTool):
1020
1021 2011-10-12  Adam Barth  <abarth@webkit.org>
1022
1023         The commit-queue doesn't tell me which tests my patch broke
1024         https://bugs.webkit.org/show_bug.cgi?id=69975
1025
1026         Reviewed by Eric Seidel.
1027
1028         We now print the list of newly failing tests, like we do for the EWS.
1029
1030         * Scripts/webkitpy/tool/commands/queues.py:
1031         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1032
1033 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
1034
1035         Added myself as a committer.
1036
1037         * Scripts/webkitpy/common/config/committers.py:
1038
1039 2011-10-12  Adam Barth  <abarth@webkit.org>
1040
1041         _run_tests is a confusing variable name in webkitpy
1042         https://bugs.webkit.org/show_bug.cgi?id=69971
1043
1044         Reviewed by Eric Seidel.
1045
1046         Eric and I thought this was a function.
1047
1048         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1049
1050 2011-10-12  Tony Chang  <tony@chromium.org>
1051
1052         Fix test-webkitpy after r97307 and r97293.
1053
1054         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
1055           is None during tests so add back the check.
1056         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
1057           output directory is now build/Debug.
1058
1059 2011-10-12  Tony Chang  <tony@chromium.org>
1060
1061         [chromium] remove old build dirs on chromium-win
1062         https://bugs.webkit.org/show_bug.cgi?id=69961
1063
1064         Reviewed by Adam Barth.
1065
1066         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
1067           always in build and never in chrome or webkit.
1068
1069 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
1070
1071         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
1072         https://bugs.webkit.org/show_bug.cgi?id=69954
1073
1074         Also renamed the action and associated event name to address an FIXME.
1075
1076         Reviewed by Adam Barth.
1077
1078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
1079         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
1081
1082 2011-10-12  Tony Chang  <tony@chromium.org>
1083
1084         stop spamming 'stopping test driver timed out, killing it' when running rwt
1085         https://bugs.webkit.org/show_bug.cgi?id=69938
1086
1087         Reviewed by Adam Barth.
1088
1089         In http://trac.webkit.org/changeset/95875 , we made the timeout for
1090         stopping the driver based on time_out_ms, but we based it on the wrong
1091         default times.
1092
1093         * Scripts/webkitpy/layout_tests/port/chromium.py:
1094
1095 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
1096
1097         3D transforms are flattened in WebKit2 snapshots
1098         https://bugs.webkit.org/show_bug.cgi?id=68276
1099
1100         Reviewed by Adam Roben.
1101         
1102         Fix WKImage leak noticed by Adam.
1103
1104         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1105         (WTR::PlatformWebView::windowSnapshotImage):
1106
1107 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
1108
1109         garden-o-matic should color-code test failure types.
1110         https://bugs.webkit.org/show_bug.cgi?id=69945
1111
1112         Reviewed by Adam Barth.
1113
1114         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
1117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
1118
1119 2011-10-12  Adam Barth  <abarth@webkit.org>
1120
1121         webkitpy tests are failing on Mac bots
1122         https://bugs.webkit.org/show_bug.cgi?id=69929
1123
1124         Reviewed by Simon Fraser.
1125
1126         Admit that Lion exists.
1127
1128         * Scripts/webkitpy/layout_tests/port/chromium.py:
1129         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1130
1131 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
1132
1133         Improve output of run-api-tests to make time-outs more obvious
1134         https://bugs.webkit.org/show_bug.cgi?id=69788
1135
1136         Reviewed by Adam Roben.
1137         
1138         List the tests that failed and timed out at the bottom of the output,
1139         if run with --verbose.
1140
1141         * Scripts/run-api-tests:
1142         (runAllTests):
1143         (runTest):
1144
1145 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1146
1147         Unreviewed, rolling out r97252.
1148         http://trac.webkit.org/changeset/97252
1149         https://bugs.webkit.org/show_bug.cgi?id=69944
1150
1151         Broke test-webkpy (Requested by abarth on #webkit).
1152
1153         * Scripts/webkitpy/layout_tests/port/qt.py:
1154         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1155
1156 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1157
1158         new-run-webkit-tests does not support qt-4.8 results
1159         https://bugs.webkit.org/show_bug.cgi?id=64071
1160
1161         Reviewed by Csaba Osztrogonác.
1162
1163         * Scripts/webkitpy/layout_tests/port/qt.py:
1164         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1165
1166 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
1167
1168         [GTK] [WebKit2] Make adding another unit test easier
1169         https://bugs.webkit.org/show_bug.cgi?id=69409
1170
1171         Reviewed by Gustavo Noronha Silva.
1172
1173         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
1174         new WebKit2 tests.
1175
1176 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
1177
1178         [WebSocket] update pywebsocket to 0.6b6.
1179         https://bugs.webkit.org/show_bug.cgi?id=69824
1180
1181         Reviewed by Kent Tamura.
1182
1183         WebKit supports WebSocket with version 8 based protocol for now.
1184         We should update its protocol to version 13 based one like hybi-17.
1185         pywebsocket 0.6b6 supports both of version 8 and 13.
1186
1187         * Scripts/webkitpy/thirdparty/__init__.py:
1188
1189 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
1190
1191         WebKitTestRunner needs to link with WebKit for NSURL category methods
1192         https://bugs.webkit.org/show_bug.cgi?id=69892
1193
1194         Reviewed by Sam Weinig.
1195         
1196         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
1197         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
1198         WebKit.framework to fix this.
1199
1200         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1201
1202 2011-10-11  Adam Barth  <abarth@webkit.org>
1203
1204         sheriffbot takes too long to acknowledge rollout commands
1205         https://bugs.webkit.org/show_bug.cgi?id=69871
1206
1207         Reviewed by Eric Seidel.
1208
1209         We used to update the working copy before acknowledging the command
1210         because we wanted to ping all the relevant IRC nicks.  That's caused a
1211         bunch of frustration because folks don't know whether the bot has heard
1212         their commands.
1213
1214         This patch makes the bot reply immediately before updating the working
1215         copy.  All the relevenat folks are still pinged when the bot finishes
1216         preparing the rollout.
1217
1218         * Scripts/webkitpy/tool/bot/irc_command.py:
1219         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1220
1221 2011-10-11  Adam Barth  <abarth@webkit.org>
1222
1223         test-webkitpy fails on Lion
1224         https://bugs.webkit.org/show_bug.cgi?id=69873
1225
1226         Reviewed by Eric Seidel.
1227
1228         This patch fixes one of the two failures.  I'll need to track down the
1229         other failure another time.
1230
1231         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1232
1233 2011-10-11  Adam Barth  <abarth@webkit.org>
1234
1235         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
1236         https://bugs.webkit.org/show_bug.cgi?id=65230
1237
1238         Reviewed by Dimitri Glazkov.
1239
1240         This patch causes us to treat crashed or hung run-webkit-tests runs
1241         similarly to how we treat compile failures.  In some sense, they're
1242         similar because they prevent us from getting test coverage.
1243
1244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1246
1247 2011-10-11  Adam Barth  <abarth@webkit.org>
1248
1249         Failing builder display in garden-o-matic should have the same visual style as the failure grid
1250         https://bugs.webkit.org/show_bug.cgi?id=69876
1251
1252         Reviewed by Dimitri Glazkov.
1253
1254         This patch generalizes the view we use for failing builders in the
1255         FailureGrid so that we can use it for the list of builders that aren't
1256         compiling.
1257
1258         One downside of this patch is that it makes it harder to tell when
1259         debug builders are failing (as opposed to release builders) because
1260         that information isn't presented in this view.  A future patch will
1261         improve this aspect.
1262
1263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
1268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1269
1270 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
1271
1272         Some API tests are timing out in Release
1273         https://bugs.webkit.org/show_bug.cgi?id=69787
1274
1275         Reviewed by Mark Rowe.
1276         
1277         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
1278         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
1279
1280         * TestWebKitAPI/Configurations/Base.xcconfig:
1281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1282         * TestWebKitAPI/config.h:
1283
1284 2011-10-11  Adam Barth  <abarth@webkit.org>
1285
1286         garden-o-matic links to flakiness dashboard should open in a new tab
1287         https://bugs.webkit.org/show_bug.cgi?id=69864
1288
1289         Reviewed by Dimitri Glazkov.
1290
1291         This bug was obvious in the first five minutes of using this new
1292         feature.  :)
1293
1294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1296
1297 2011-10-11  Adam Barth  <abarth@webkit.org>
1298
1299         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
1300         that * doesn't really mean "all".  I've emailed the W3C working group
1301         about changing the spec.
1302
1303         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1304
1305 2011-10-11  Adam Barth  <abarth@webkit.org>
1306
1307         garden-o-matic should link to the flakiness dashboard
1308         https://bugs.webkit.org/show_bug.cgi?id=69862
1309
1310         Reviewed by Dimitri Glazkov.
1311
1312         The flakiness dashboard has lots of great information about the failure
1313         history of each test.  This patch adds a link from garden-o-matic to
1314         the flakiness dashboard so the gardener can look at this information.
1315
1316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1319
1320 2011-10-11  David Levin  <levin@chromium.org>
1321
1322         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
1323         https://bugs.webkit.org/show_bug.cgi?id=69789
1324
1325         Reviewed by Eric Seidel.
1326
1327         Made the signature of _assertRaisesRegexp match that of Python 2.7.
1328
1329         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
1330         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
1331         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
1332         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
1333
1334 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
1335
1336         [EFL] DRT: Do not abort() when an unknown key is pressed.
1337         https://bugs.webkit.org/show_bug.cgi?id=69856
1338
1339         Reviewed by Antonio Gomes.
1340
1341         A lot of tests crash due to the previous behaviour. Just using the
1342         received name of the pressed key works most of the time, and when it
1343         does not the failing tests should tell us.
1344
1345         * DumpRenderTree/efl/EventSender.cpp:
1346         (keyPadNameFromJSValue):
1347         (keyNameFromJSValue):
1348         (keyDownCallback):
1349
1350 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1351
1352         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
1353         https://bugs.webkit.org/show_bug.cgi?id=68016
1354
1355         Reviewed by Chang Shu.
1356
1357         * Scripts/webkitpy/layout_tests/port/qt.py:
1358
1359 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
1360
1361         [EFL] DRT: Return the right window count in LayoutTestController.
1362         https://bugs.webkit.org/show_bug.cgi?id=69764
1363
1364         Reviewed by Antonio Gomes.
1365
1366         Follow-up to r96943: now that we have DumpRenderTreeChrome and
1367         DumpRenderTreeView in the tree, we can correctly count the number of
1368         open windows in DRT.
1369
1370         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1371         (LayoutTestController::windowCount):
1372
1373 2011-10-11  Jer Noble  <jer.noble@apple.com>
1374
1375         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
1376         https://bugs.webkit.org/show_bug.cgi?id=69800
1377
1378         Reviewed by Csaba Osztrogonác.
1379
1380         Enable WEB_AUDIO at runtime.
1381
1382         * DumpRenderTree/mac/DumpRenderTree.mm:
1383         (resetDefaultsToConsistentValues):
1384
1385 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
1386
1387         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
1388         https://bugs.webkit.org/show_bug.cgi?id=69769
1389
1390         Reviewed by Antonio Gomes.
1391
1392         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1393         (LayoutTestController::setIconDatabaseEnabled):
1394
1395 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1396
1397         [Qt] Remove all references to QTDIR_build and standalone_package
1398
1399         Qt is now modularized, which means we no longer import WebKit into
1400         the Qt source tree. Instead we use git submodules, and building
1401         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
1402
1403         To decrease the number of buildsystem configurations we also remove
1404         the standalone_package code-path used when we were providing tarballs
1405         with the derived sources pre-generated.
1406
1407         Reviewed by Simon Hausmann.
1408
1409         * MiniBrowser/qt/MiniBrowser.pro:
1410         * QtTestBrowser/QtTestBrowser.pro:
1411         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1412
1413 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
1414
1415         Update Chromium accessibility support in DRT.
1416         https://bugs.webkit.org/show_bug.cgi?id=69676
1417
1418         Reviewed by Chris Fleizach.
1419
1420         Adds several missing properties and methods to enable more
1421         tests to pass, and in particular adds support for notification
1422         callbacks.
1423
1424         * DumpRenderTree/chromium/AccessibilityController.cpp:
1425         (AccessibilityController::AccessibilityController):
1426         (AccessibilityController::reset):
1427         (AccessibilityController::getFocusedElement):
1428         (AccessibilityController::shouldLogAccessibilityEvents):
1429         (AccessibilityController::notificationReceived):
1430         (AccessibilityController::logAccessibilityEventsCallback):
1431         * DumpRenderTree/chromium/AccessibilityController.h:
1432         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1433         (getHelpText):
1434         (getStringValue):
1435         (getOrientation):
1436         (AccessibilityUIElement::AccessibilityUIElement):
1437         (AccessibilityUIElement::getChildAtIndex):
1438         (AccessibilityUIElement::isEqual):
1439         (AccessibilityUIElement::notificationReceived):
1440         (AccessibilityUIElement::roleGetterCallback):
1441         (AccessibilityUIElement::titleGetterCallback):
1442         (AccessibilityUIElement::descriptionGetterCallback):
1443         (AccessibilityUIElement::helpTextGetterCallback):
1444         (AccessibilityUIElement::stringValueGetterCallback):
1445         (AccessibilityUIElement::xGetterCallback):
1446         (AccessibilityUIElement::yGetterCallback):
1447         (AccessibilityUIElement::widthGetterCallback):
1448         (AccessibilityUIElement::heightGetterCallback):
1449         (AccessibilityUIElement::intValueGetterCallback):
1450         (AccessibilityUIElement::minValueGetterCallback):
1451         (AccessibilityUIElement::maxValueGetterCallback):
1452         (AccessibilityUIElement::childrenCountGetterCallback):
1453         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
1454         (AccessibilityUIElement::selectedTextRangeGetterCallback):
1455         (AccessibilityUIElement::isEnabledGetterCallback):
1456         (AccessibilityUIElement::isRequiredGetterCallback):
1457         (AccessibilityUIElement::isFocusedGetterCallback):
1458         (AccessibilityUIElement::isFocusableGetterCallback):
1459         (AccessibilityUIElement::isSelectedGetterCallback):
1460         (AccessibilityUIElement::isSelectableGetterCallback):
1461         (AccessibilityUIElement::isMultiSelectableGetterCallback):
1462         (AccessibilityUIElement::isExpandedGetterCallback):
1463         (AccessibilityUIElement::isCheckedGetterCallback):
1464         (AccessibilityUIElement::isVisibleGetterCallback):
1465         (AccessibilityUIElement::isOffScreenGetterCallback):
1466         (AccessibilityUIElement::isCollapsedGetterCallback):
1467         (AccessibilityUIElement::hasPopupGetterCallback):
1468         (AccessibilityUIElement::isValidGetterCallback):
1469         (AccessibilityUIElement::orientationGetterCallback):
1470         (AccessibilityUIElement::showMenuCallback):
1471         (AccessibilityUIElement::pressCallback):
1472         (AccessibilityUIElement::isEqualCallback):
1473         (AccessibilityUIElement::addNotificationListenerCallback):
1474         (AccessibilityUIElement::removeNotificationListenerCallback):
1475         (AccessibilityUIElement::takeFocusCallback):
1476         (AccessibilityUIElement::fallbackCallback):
1477         (RootAccessibilityUIElement::getChildAtIndex):
1478         (AccessibilityUIElementList::getOrCreate):
1479         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1480         * DumpRenderTree/chromium/CppVariant.cpp:
1481         (CppVariant::invokeDefault):
1482         * DumpRenderTree/chromium/CppVariant.h:
1483         * DumpRenderTree/chromium/LayoutTestController.cpp:
1484         (LayoutTestController::LayoutTestController):
1485         (LayoutTestController::reset):
1486         * DumpRenderTree/chromium/LayoutTestController.h:
1487         * DumpRenderTree/chromium/WebViewHost.cpp:
1488         (WebViewHost::postAccessibilityNotification):
1489
1490 2011-10-10  Adam Klein  <adamk@chromium.org>
1491
1492         Support Distributed-CompileC as an action name in filter-build-webkit
1493         https://bugs.webkit.org/show_bug.cgi?id=69783
1494
1495         Reviewed by Ojan Vafai.
1496
1497         * Scripts/filter-build-webkit:
1498
1499 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
1500
1501         3D transforms are flattened in WebKit2 snapshots
1502         https://bugs.webkit.org/show_bug.cgi?id=68276
1503
1504         Reviewed by Anders Carlsson.
1505         
1506         Use a snapshot of the window, rather than an image from the web process
1507         for pixel testing in WebKitTestRunner. This correctly captures compositing
1508         layers, so works for 3D transform tests.
1509
1510         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
1511         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1512         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
1513         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
1514         use that instead of the image we get from the web process.
1515         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1516         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
1517         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1518         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
1519         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1520         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
1521         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1522         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
1523
1524 2011-10-10  David Levin  <levin@chromium.org>
1525
1526         Quick fix for watchlist unit test failures when using Python 2.7+
1527         Reviewed by Adam Barth.
1528
1529         Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
1530         better fix.
1531
1532         * Scripts/webkitpy/common/webkitunittest.py: Always use our
1533         version of assertRaisesRegexp.
1534
1535 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1536
1537         Unreviewed, rolling out r97082.
1538         http://trac.webkit.org/changeset/97082
1539         https://bugs.webkit.org/show_bug.cgi?id=69784
1540
1541         broke Windows build (Requested by smfr on #webkit).
1542
1543         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1544         * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
1545         (WTR::createCGContextFromImage):
1546         (WTR::computeMD5HashStringForContext):
1547         (WTR::dumpBitmap):
1548         (WTR::paintRepaintRectOverlay):
1549         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1550         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1551         (WTR::PlatformWebView::PlatformWebView):
1552
1553 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
1554
1555         3D transforms are flattened in WebKit2 snapshots
1556         https://bugs.webkit.org/show_bug.cgi?id=68276
1557
1558         Reviewed by Anders Carlsson.
1559         
1560         The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
1561         flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
1562         the window when doing pixel tests.
1563         
1564         Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
1565
1566         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
1567         * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
1568         (WTR::createBitmapCGContext): Utility function to create a bitmap context.
1569         (WTR::computeMD5HashStringForContext):
1570         (WTR::dumpBitmap):
1571         (WTR::paintRepaintRectOverlay):
1572         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
1573         grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
1574         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1575         (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
1576         We need the window to autodisplay for Core Animation to render layers and start animations.
1577
1578 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
1579
1580         WebKitTestRunner needs layoutTestController.setWindowIsKey
1581         https://bugs.webkit.org/show_bug.cgi?id=42688
1582
1583         Reviewed by Anders Carlsson.
1584
1585         Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
1586         This sets a flag that the platform layer uses to indicate that
1587         the window is the key window, which fixes focus ring drawing
1588         in pixel results.
1589         
1590         Also focus the web view when we get a 'didCommitLoad' for the main
1591         frame, as DumpRenderTree does.
1592
1593         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1594         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1595         (WTR::InjectedBundle::postSetWindowIsKey):
1596         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1597         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1598         (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
1599         (WTR::LayoutTestController::addChromeInputField):
1600         (WTR::LayoutTestController::removeChromeInputField):
1601         (WTR::LayoutTestController::focusWebView):
1602         (WTR::LayoutTestController::setWindowIsKey):
1603         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
1604         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
1605         (WTR::LayoutTestController::callFocusWebViewCallback):
1606         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1607         * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
1608         so that we can override -isKeyWindow. Use a boolean member variable
1609         to track window key status.
1610         (WTR::PlatformWebView::setWindowIsKey):
1611         (WTR::PlatformWebView::windowIsKey):
1612         * WebKitTestRunner/TestController.cpp:
1613         (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
1614         (WTR::closeOtherPage): Use the same cast as other functions.
1615         (WTR::focus): Implement to call setWindowIsKey(true)
1616         (WTR::unfocus): Implement to call setWindowIsKey(false)
1617         (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
1618         (WTR::TestController::initialize):
1619         (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
1620         * WebKitTestRunner/TestController.h:
1621         * WebKitTestRunner/TestInvocation.cpp:
1622         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1623         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1624         (WTR::PlatformWebView::PlatformWebView):
1625         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1626         (-[WebKitTestRunnerWindow isKeyWindow]):
1627         (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
1628         (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
1629         (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
1630         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1631         (WTR::PlatformWebView::PlatformWebView):
1632         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1633         (WTR::PlatformWebView::PlatformWebView):
1634
1635 2011-10-10  Raphael Kubo da Costa  <kubo@profusion.mobi>
1636
1637         check-webkit-style: Add readability exception for Ewk_* data types.
1638         https://bugs.webkit.org/show_bug.cgi?id=69763
1639
1640         Reviewed by David Levin.
1641
1642         Many EFL-related files (such as EditorClientEfl.h or
1643         DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
1644         struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
1645         check-webkit-style.
1646
1647         Add an exception for them, just like there are exceptions for
1648         Evas_*, Ecore_* and others.
1649
1650         * Scripts/webkitpy/style/checkers/cpp.py:
1651         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1652
1653 2011-10-10  Dominic Mazzoni  <dmazzoni@google.com>
1654
1655         [Chromium] Get rid of WebAccessibilityCache.
1656         https://bugs.webkit.org/show_bug.cgi?id=68224
1657
1658         Reviewed by Dimitri Glazkov.
1659
1660         * DumpRenderTree/chromium/AccessibilityController.cpp:
1661         (AccessibilityController::bindToJavascript):
1662
1663 2011-10-09  Adam Barth  <abarth@webkit.org>
1664
1665         Remove "near miss" XSS vulnerabilities in garden-o-matic
1666         https://bugs.webkit.org/show_bug.cgi?id=69708
1667
1668         Reviewed by David Levin.
1669
1670         Collin Jackson did a security audit of garden-o-matic.  He hasn't found
1671         any actual vulnerabilities yet, but he did identify a couple "near
1672         misses" where a slight change in garden-o-matic could lead to a
1673         vulnerability.  This patch removes those potential issues.
1674
1675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1677
1678 2011-10-07  Adam Barth  <abarth@webkit.org>
1679
1680         Add a Content-Security-Policy to garden-o-matic
1681         https://bugs.webkit.org/show_bug.cgi?id=69668
1682
1683         Reviewed by David Levin.
1684
1685         This will help mitigate cross-site script and will also help us dogfood CSP.
1686
1687         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1688
1689 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
1690
1691         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
1692         https://bugs.webkit.org/show_bug.cgi?id=66380
1693
1694         Reviewed by Antonio Gomes.
1695
1696         This encapsulates EWebKit into an object that manages multiple windows
1697         and provides a cleaner interface to EFL's DumpRenderTree.
1698
1699         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
1700         (DumpRenderTreeChrome::create):
1701         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1702         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
1703         (DumpRenderTreeChrome::createNewWindow):
1704         (DumpRenderTreeChrome::createView):
1705         (DumpRenderTreeChrome::removeWindow):
1706         (DumpRenderTreeChrome::initialize):
1707         (DumpRenderTreeChrome::extraViews):
1708         (DumpRenderTreeChrome::mainFrame):
1709         (DumpRenderTreeChrome::mainView):
1710         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1711         (DumpRenderTreeChrome::onWindowObjectCleared):
1712         (DumpRenderTreeChrome::onLoadStarted):
1713         (DumpRenderTreeChrome::processWork):
1714         (DumpRenderTreeChrome::onLoadFinished):
1715         (DumpRenderTreeChrome::onStatusbarTextSet):
1716         (DumpRenderTreeChrome::onTitleChanged):
1717         (DumpRenderTreeChrome::onDocumentLoadFinished):
1718         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
1719         * DumpRenderTree/efl/EventSender.cpp:
1720         (sendClick): Use browser->mainFrame() instead of mainFrame.
1721         (mouseDownCallback): Ditto.
1722         (mouseUpCallback): Ditto.
1723         (mouseMoveToCallback): Ditto.
1724         (mouseScrollByCallback): Ditto.
1725         (keyDownCallback): Ditto.
1726         (scalePageByCallback): Ditto.
1727         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1728         (LayoutTestController::counterValueForElementById): Use
1729         browser->mainFrame() instead of mainFrame.
1730         (LayoutTestController::pageNumberForElementById): Ditto.
1731         (LayoutTestController::numberOfPages): Ditto.
1732         (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
1733         (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
1734         (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
1735         (LayoutTestController::numberOfActiveAnimations): Ditto.
1736         (LayoutTestController::suspendAnimations): Ditto.
1737         (LayoutTestController::resumeAnimations): Ditto.
1738         (LayoutTestController::setWebViewEditable): Ditto.
1739         (LayoutTestController::webHistoryItemCount): Use browser->mainView()
1740         instead of browser.
1741         (LayoutTestController::queueLoad): Ditto.
1742         (LayoutTestController::setAcceptsEditing): Ditto.
1743         (LayoutTestController::setUserStyleSheetEnabled): Ditto.
1744         (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
1745         (LayoutTestController::setFrameFlatteningEnabled): Ditto.
1746         (LayoutTestController::setSpatialNavigationEnabled): Ditto.
1747         (LayoutTestController::setPluginsEnabled): Ditto.
1748         (LayoutTestController::findString): Ditto.
1749         (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
1750         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1751         (createBitmapContextFromWebView): Use browser->mainFrame() instead of
1752         mainFrame.
1753         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1754         (LoadItem::invoke): Ditto.
1755         (LoadHTMLStringItem::invoke): Ditto.
1756         (ScriptItem::invoke): Ditto.
1757         (ReloadItem::invoke): Use browser->mainView() instead of browser.
1758
1759 2011-10-07  Simon Hausmann  <simon.hausmann@nokia.com>
1760
1761         [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
1762         https://bugs.webkit.org/show_bug.cgi?id=69617
1763
1764         Reviewed by Andreas Kling.
1765
1766         Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
1767         the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
1768         events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
1769         events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
1770         logic.
1771
1772         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1773         (MiniBrowserApplication::MiniBrowserApplication):
1774         (MiniBrowserApplication::notify):
1775         * MiniBrowser/qt/MiniBrowserApplication.h:
1776
1777 2011-10-06  Adam Barth  <abarth@webkit.org>
1778
1779         Port PixelZoomer to work in garden-o-matic
1780         https://bugs.webkit.org/show_bug.cgi?id=69577
1781
1782         Reviewed by David Levin.
1783
1784         This implementation of PixelZoomer is basically a fork of the
1785         implementation used by results.html.  These two apps have different
1786         requirements on where this code lives.  results.html wants to be
1787         self-contained whereas garden-o-matic wants to live in the public_html
1788         folder of the buildbot.  We could do something fancy here to share the
1789         code, but that's not likely to be of much benefit.
1790
1791         I had to change a few things about pixelzoomer to accounter for the
1792         differences in DOM between results.html and garden-o-matic, but
1793         surprisingly little.  I also moved all the code into an anonymous
1794         function, which is the style we're suing for module separation in
1795         garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
1796         want to drag along too many extra functions from results.html.
1797
1798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
1801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1802         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
1803         (.pixel-zoom-container):
1804         (.pixel-zoom-container > *):
1805         (.pixel-zoom-container .scaled-image-container):
1806         (.scaled-image-container > img):
1807
1808 2011-10-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1809
1810         [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
1811         https://bugs.webkit.org/show_bug.cgi?id=69505
1812
1813         Reviewed by Andreas Kling.
1814
1815         * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
1816         (on_viewport_changed):
1817
1818 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
1819
1820         [WinCairo] Unreviewed test correction.
1821
1822         * Scripts/webkitdirs.pm:
1823         (argumentsForConfiguration): Add 'wincairo' option to the set of
1824         configuration flags used by run-javascript-core tests, so that it
1825         does not attempt to run Apple's release version.
1826
1827 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
1828
1829         [WinCairo] Unreviewed test correction.
1830
1831         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
1832          of known build slave types so that test-result-archive won't fail
1833          when running tests.
1834
1835 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
1836
1837         The GTK+ WebKit2 headers produce a lot of style warnings
1838         https://bugs.webkit.org/show_bug.cgi?id=69481
1839
1840         Reviewed by David Levin.
1841
1842         Prevent emitting so many style warnings for GTK+ API. We skip header
1843         files in the WebKit2 GTK+ API directory and also avoid warnings about
1844         identifier names that begin with "webkit_" in files that contain the
1845         string "gtk".
1846
1847         * Scripts/webkitpy/style/checker.py: Do not check header files in
1848         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
1849         adding the ability to specify a regular expression in the skip list. Remove
1850         a few files from the skipped list that no longer exist.
1851         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
1852         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
1853         about identifiers that begin with "webkit_".
1854         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
1855
1856 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
1857
1858         [WinCairo] Correct config.json for WinCairo Test builds.
1859         https://bugs.webkit.org/show_bug.cgi?id=69272
1860
1861         Reviewed by Ryosuke Niwa.
1862
1863         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
1864          old 'WinCairo Debug (Build)' label and replace with correct
1865          'WinCairo Release' label.
1866
1867 2011-10-06  David Levin  <levin@chromium.org>
1868
1869         Add a style checker watchlist definition and add myself to it.
1870         https://bugs.webkit.org/show_bug.cgi?id=69564
1871
1872         Reviewed by Daniel Bates.
1873
1874         * Scripts/webkitpy/common/config/watchlist:
1875
1876 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
1877
1878         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
1879         https://bugs.webkit.org/show_bug.cgi?id=69450
1880
1881         Reviewed by Ryosuke Niwa.
1882
1883         This should avoid stderr messages when running
1884         webarchive/test-link-rel-icon.html.
1885
1886         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1887         (LayoutTestController::setIconDatabaseEnabled):
1888
1889 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
1890
1891         [WK2] [GTK] Add Skipped file for Webkit2 test runner
1892         https://bugs.webkit.org/show_bug.cgi?id=69517
1893
1894         Use the shared WK2 skipped file also in GTK port.
1895
1896         Reviewed by Martin Robinson.
1897
1898         * Scripts/old-run-webkit-tests:
1899         (readSkippedFiles):
1900
1901 2011-10-06  Elliot Poger  <epoger@google.com>
1902
1903         allow new-run-webkit-tests to run on Lion
1904         https://bugs.webkit.org/show_bug.cgi?id=69429
1905
1906         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
1907         directory to fallback lists (even though that directory doesn't exist yet)
1908
1909         Reviewed by Adam Barth.
1910
1911         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1912         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1913
1914 2011-10-03  Hans Wennborg  <hans@chromium.org>
1915
1916         IndexedDB: Remove SQLite-LevelDB migration code
1917         https://bugs.webkit.org/show_bug.cgi?id=69264
1918
1919         Reviewed by Tony Chang.
1920
1921         Remove setOverrideIndexedDBBackingStore. It was used in the layout
1922         test for migration.
1923
1924         * DumpRenderTree/chromium/LayoutTestController.cpp:
1925         (LayoutTestController::LayoutTestController):
1926         * DumpRenderTree/chromium/LayoutTestController.h:
1927
1928 2011-10-05  James Robinson  <jamesr@chromium.org>
1929
1930         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
1931         https://bugs.webkit.org/show_bug.cgi?id=69498
1932
1933         Reviewed by Adam Barth.
1934
1935         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1936         (main):
1937         * DumpRenderTree/chromium/TestShell.cpp:
1938         (TestShell::TestShell):
1939         (TestShell::resetWebSettings):
1940         * DumpRenderTree/chromium/TestShell.h:
1941         (TestShell::setThreadedCompositingEnabled):
1942         * DumpRenderTree/chromium/WebPreferences.cpp:
1943         (WebPreferences::reset):
1944         (WebPreferences::applyTo):
1945         * DumpRenderTree/chromium/WebPreferences.h:
1946         * Scripts/webkitpy/layout_tests/port/chromium.py:
1947         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1948
1949 2011-10-05  Erik Arvidsson  <arv@chromium.org>
1950
1951         [QT] Fix DRT after r96779
1952
1953         unreviewed.
1954
1955         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1956         (WebCore::dumpHistoryItem):
1957
1958 2011-10-05  Erik Arvidsson  <arv@chromium.org>
1959
1960         window.location.href and others needlessly decodes URI-encoded characters
1961         https://bugs.webkit.org/show_bug.cgi?id=30225
1962
1963         Reviewed by Darin Adler.
1964
1965         * DumpRenderTree/chromium/TestShell.cpp:
1966         (normalizeLayoutTestURLInternal): Remove extra encode.
1967
1968 2011-10-05  Darin Adler  <darin@apple.com>
1969
1970         Fix build.
1971
1972         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1973         (TestWebKitAPI::TEST): Remove underscore prefix from call to
1974         WKContextRegisterURLSchemeAsEmptyDocument.
1975
1976 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
1977
1978         [WinCairo] Switch to building Release target, and activate tests.
1979         https://bugs.webkit.org/show_bug.cgi?id=69272
1980
1981         Reviewed by Adam Barth.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/config.json:
1984         Change from debug to release target. Switch from "Build" to
1985         "BuildAndTest"
1986
1987 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
1988
1989         In WebKitTestRunner, text has font smoothing in pixel snapshots
1990         https://bugs.webkit.org/show_bug.cgi?id=69396
1991
1992         Reviewed by Darin Adler.
1993         
1994         Call the new WKContext method that disables font smoothing in
1995         WebKitTestRunner, so that pixel snapshots don't have font smoothing
1996         enabled. Remove leading underscore from a WKContext function call.
1997
1998         * WebKitTestRunner/TestController.cpp:
1999         (WTR::TestController::resetStateToConsistentValues):
2000
2001 2011-10-05  David Levin  <levin@chromium.org>
2002
2003         Improve the watchlist for threading entries.
2004         https://bugs.webkit.org/show_bug.cgi?id=69463
2005
2006         Reviewed by Adam Barth.
2007
2008         * Scripts/webkitpy/common/config/watchlist:
2009
2010 2011-10-05  Adam Roben  <aroben@apple.com>
2011
2012         Add tests for using RetainPtrs inside HashMap and HashSet
2013
2014         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
2015         in HashMap/HashSet fails to compile
2016
2017         Reviewed by John Sullivan.
2018
2019         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
2020         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
2021         and value type of HashMap.
2022
2023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2024         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2025         Added new file.
2026
2027 2011-10-05  Adam Barth  <abarth@webkit.org>
2028
2029         Mark as Expected in garden-o-matic is confusing
2030         https://bugs.webkit.org/show_bug.cgi?id=69452
2031
2032         Reviewed by David Levin.
2033
2034         krit didn't understand the difference between this button and the
2035         Rebaseline button because both of them seem to indicate that the new
2036         behavior is expected.  This patch renames "Mark as Expected" to "Expect
2037         Failure" to make it clear that we're just expecting the test to fail
2038         rather than accepting the new results as passing.  We might need to
2039         iterate on these names a bit more if folks continue to find them
2040         confusing.
2041
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2043
2044 2011-10-05  Adam Barth  <abarth@webkit.org>
2045
2046         Add watchlist entries for abarth
2047         https://bugs.webkit.org/show_bug.cgi?id=69461
2048
2049         Reviewed by David Levin.
2050
2051         I might have gone a bit overboard.  We'll see if this is too much spam
2052         for me.
2053
2054         * Scripts/webkitpy/common/config/watchlist:
2055
2056 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
2057
2058         [WinCairo] Teach old-run-webkit-tests about wincairo.
2059         https://bugs.webkit.org/show_bug.cgi?id=69280
2060
2061         Reviewed by Adam Roben.
2062
2063         * Scripts/old-run-webkit-tests: Handle wincairo case.
2064         (buildPlatformResultHierarchy):
2065         (readSkippedFiles): Ditto
2066         * Scripts/webkitdirs.pm: Deal with wincairo build case.
2067         (determineConfiguration):
2068
2069 2011-10-05  Chang Shu  <cshu@webkit.org>
2070
2071         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
2072         https://bugs.webkit.org/show_bug.cgi?id=68924
2073
2074         Added TextInputController files and JS interfaces for the above functions.
2075
2076         Reviewed by Darin Adler.
2077
2078         * WebKitTestRunner/DerivedSources.make:
2079         * WebKitTestRunner/DerivedSources.pro:
2080         * WebKitTestRunner/GNUmakefile.am:
2081         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
2082         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2083         (WTR::InjectedBundle::beginTesting):
2084         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2085         (WTR::InjectedBundle::textInputController):
2086         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2087         (WTR::InjectedBundlePage::didClearWindowForFrame):
2088         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
2089         (WTR::TextInputController::create):
2090         (WTR::TextInputController::TextInputController):
2091         (WTR::TextInputController::~TextInputController):
2092         (WTR::TextInputController::wrapperClass):
2093         (WTR::TextInputController::makeWindowObject):
2094         (WTR::TextInputController::setMarkedText):
2095         (WTR::TextInputController::hasMarkedText):
2096         (WTR::TextInputController::unmarkText):
2097         (WTR::TextInputController::insertText):
2098         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
2099         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2100         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2101         * WebKitTestRunner/win/InjectedBundle.vcproj:
2102
2103 2011-10-04  Oliver Hunt  <oliver@apple.com>
2104
2105         Add rudimentary filtering to write barriers
2106         https://bugs.webkit.org/show_bug.cgi?id=69392
2107
2108         Reviewed by Filip Pizlo.
2109
2110         When we're recording gc phase times Heap.o picks up
2111         some exit time destructors, so we'll just ignore Heap.o
2112         in this check.
2113
2114         * Scripts/check-for-exit-time-destructors:
2115
2116 2011-10-05  Chang Shu  <cshu@webkit.org>
2117
2118         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
2119         https://bugs.webkit.org/show_bug.cgi?id=69365
2120
2121         Reviewed by Darin Adler.
2122
2123         Added js API in WTR LayoutTestController.
2124
2125         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2126         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2127         (WTR::LayoutTestController::dumpConfigurationForViewport):
2128         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2129
2130 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2131
2132         [EFL] ImageDiff: Do not clear the image before it is processed and compared
2133         https://bugs.webkit.org/show_bug.cgi?id=69378
2134
2135         Reviewed by Antonio Gomes.
2136
2137         Commit 61836 to Evas added a few cleanup calls to some
2138         evas_object_image functions which effectively made ImageDiff consider
2139         all images to be equal.
2140
2141         It turns out that now evas_object_image_colorspace_set clears any
2142         data set, so the call to evas_object_image_data_set was not having any
2143         effect.
2144
2145         * DumpRenderTree/efl/ImageDiff.cpp:
2146         (readImageFromStdin): Call evas_object_image_data_set after
2147         evas_object_image_colorspace_set.
2148
2149 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2150
2151         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
2152         https://bugs.webkit.org/show_bug.cgi?id=68449
2153
2154         Reviewed by Antonio Gomes.
2155
2156         evas_render() must be called to close up temporary files and unmap unused
2157         resources. evas_object_image_data_set() must be called after an
2158         evas_object_image_data_get() to balance an internal reference count.
2159
2160         * DumpRenderTree/efl/ImageDiff.cpp:
2161         (differenceImageFromDifferenceBuffer):
2162         (calculateDifference):
2163         (printImage):
2164         (printImageDifferences):
2165
2166 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
2167
2168         [Qt][WK2] Unreviewed build fix.
2169
2170         Don't use WebCore directly in WTR.
2171
2172         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2173         (WTR::PlatformWebView::addChromeInputField):
2174         (WTR::PlatformWebView::removeChromeInputField):
2175         (WTR::PlatformWebView::makeWebViewFirstResponder):
2176
2177 2011-10-05  David Levin  <levin@chromium.org>
2178
2179         watchlist: Add more rules for chromium public api and sort the file.
2180         https://bugs.webkit.org/show_bug.cgi?id=69323
2181
2182         Reviewed by Adam Barth.
2183
2184         * Scripts/webkitpy/common/config/watchlist:
2185
2186 2011-10-05  David Levin  <levin@chromium.org>
2187
2188         watchlist: Don't add the same message to a bug more than once.
2189         https://bugs.webkit.org/show_bug.cgi?id=69303
2190
2191         Reviewed by Adam Barth.
2192
2193         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
2194         if a message is in the comments already.
2195         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
2196         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2197         Pick a bug supplied by the mock. Change the test due to different output
2198         from the mock watch list tool.
2199         * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
2200         another email so it will be filtered out, fix bugs to have the cc and comment fields,
2201         and fix fetch_bug to handle bug_id's which are text (because that took me way too long
2202         to debug).
2203         * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
2204         and/or cc's that are already in the bug.
2205         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
2206         and remove a comment that is filtered out.
2207
2208 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
2209
2210         [Qt][WK2] Unreviewed build fix after r96643.
2211
2212         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2213         (WTR::PlatformWebView::addChromeInputField):
2214         (WTR::PlatformWebView::removeChromeInputField):
2215         (WTR::PlatformWebView::makeWebViewFirstResponder):
2216
2217 2011-10-04  Kent Tamura  <tkent@chromium.org>
2218
2219         Introduce feature flags for incomplete input types
2220         https://bugs.webkit.org/show_bug.cgi?id=68971
2221
2222         Reviewed by Hajime Morita.
2223
2224         * Scripts/build-webkit:
2225         Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
2226         They are disabled by default.
2227
2228 2011-10-04  Adam Barth  <abarth@webkit.org>
2229
2230         garden-o-matic doesn't launch it's UI on Lion
2231         https://bugs.webkit.org/show_bug.cgi?id=69349
2232
2233         Reviewed by Darin Adler.
2234
2235         It turns out that Lion is a bit more picky about file URLs.  This patch
2236         switches us from using a path to using an actual file URL, silencing
2237         the warning and making the tool actually launch on Lion.
2238
2239         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2240
2241 2011-10-04  Daniel Bates  <dbates@rim.com>
2242
2243         Fix Perl undefined variable warning when using run-safari after
2244         <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
2245
2246         Rubber-stamped by Alexey Proskuryakov.
2247
2248         * Scripts/webkitdirs.pm:
2249         (runMacWebKitApp): Check that the optional function argument $useOpenCommand
2250         is defined before using it in a comparison operation.
2251
2252 2011-10-04  Scott Graham  <scottmg@chromium.org>
2253
2254         Add GAMEPAD feature flag
2255         https://bugs.webkit.org/show_bug.cgi?id=66859
2256
2257         Reviewed by Darin Fisher.
2258
2259         * Scripts/build-webkit:
2260
2261 2011-10-04  Jon Lee  <jonlee@apple.com>
2262
2263         REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
2264         https://bugs.webkit.org/show_bug.cgi?id=68412
2265         <rdar://problem/9988252>
2266
2267         Reviewed by Darin Adler.
2268
2269         In order to create a test for the bug, I had to update DRT and WKTR to create some
2270         widget that allows first responder status to move away from the main web view.
2271
2272         Three methods were added to layoutTestController: addChromeInputField,
2273         removeChromeInputField, and focusWebView. addChromeInputField adds a text field
2274         that is a sibling to the web view, and sets up the key event loop between the two.
2275         removeChromeInputField removes that field. focusWebView moves first responder
2276         status to the web view.
2277
2278         The test makes the call via layoutTestController and passes a callback that it
2279         assumes will be executed once the task is completed. In DRT the callback is called
2280         synchronously. In WKTR this is handled with message passing between the two
2281         processes.
2282
2283         * DumpRenderTree/LayoutTestController.cpp:
2284         (addChromeInputFieldCallback):
2285         (removeChromeInputFieldCallback):
2286         (focusWebViewCallback):
2287         (LayoutTestController::staticFunctions):
2288         * DumpRenderTree/LayoutTestController.h:
2289         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2290         (LayoutTestController::addChromeInputField):
2291         (LayoutTestController::removeChromeInputField):
2292         (LayoutTestController::focusWebView):
2293         * DumpRenderTree/mac/DumpRenderTree.mm:
2294         (resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
2295         make sure to remove the chrome input field.
2296         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2297         (LayoutTestController::addChromeInputField):
2298         (LayoutTestController::removeChromeInputField):
2299         (LayoutTestController::focusWebView):
2300         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2301         (LayoutTestController::addChromeInputField):
2302         (LayoutTestController::removeChromeInputField):
2303         (LayoutTestController::focusWebView):
2304         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2305         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2306         (WTR::InjectedBundle::didReceiveMessage):
2307         (WTR::InjectedBundle::postAddChromeInputField):
2308         (WTR::InjectedBundle::postRemoveChromeInputField):
2309         (WTR::InjectedBundle::postFocusWebView):
2310         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2311         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2312         (WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
2313         through JS.
2314         (WTR::cacheLayoutTestControllerCallback):
2315         (WTR::callLayoutTestControllerCallback):
2316         (WTR::LayoutTestController::addChromeInputField):
2317         (WTR::LayoutTestController::removeChromeInputField):
2318         (WTR::LayoutTestController::focusWebView):
2319         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
2320         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
2321         (WTR::LayoutTestController::callFocusWebViewCallback):
2322         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2323         * WebKitTestRunner/PlatformWebView.h:
2324         * WebKitTestRunner/TestController.cpp:
2325         (WTR::TestController::resetStateToConsistentValues):
2326         * WebKitTestRunner/TestInvocation.cpp:
2327         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2328         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2329         (WTR::PlatformWebView::addChromeInputField):
2330         (WTR::PlatformWebView::removeChromeInputField):
2331         (WTR::PlatformWebView::makeWebViewFirstResponder):
2332         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2333         (WTR::PlatformWebView::addChromeInputField):
2334         (WTR::PlatformWebView::removeChromeInputField):
2335         (WTR::PlatformWebView::makeWebViewFirstResponder):
2336         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2337         (WTR::PlatformWebView::addChromeInputField):
2338         (WTR::PlatformWebView::removeChromeInputField):
2339         (WTR::PlatformWebView::makeWebViewFirstResponder):
2340
2341         * DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
2342         with the patch-- just cleaning up style.
2343         (LayoutTestController::addDisallowedURL):
2344         (originsArrayToJS):
2345         (LayoutTestController::queueLoad):
2346         (LayoutTestController::setMockDeviceOrientation):
2347         (LayoutTestController::setIconDatabaseEnabled):
2348         (LayoutTestController::setEditingBehavior):
2349
2350 2011-10-04  Simon Fraser  <simon.fraser@apple.com>
2351
2352         Move font-fixup code in WebKitTestRunner to a better place
2353         https://bugs.webkit.org/show_bug.cgi?id=69356
2354
2355         Reviewed by Sam Weinig.
2356         
2357         Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
2358         already contains font-related code.
2359
2360         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2361         (WTR::InjectedBundle::initialize):
2362         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2363         (WTR::allowedFontFamilySet):
2364         (WTR::drt_NSFontManager_availableFontFamilies):
2365         (WTR::drt_NSFontManager_availableFonts):
2366         (WTR::swizzleNSFontManagerMethods):
2367         (WTR::activateFonts):
2368         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2369         (WTR::InjectedBundle::platformInitialize):
2370
2371 2011-10-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
2372
2373         [EFL] DRT: Add DumpRenderTree.cpp
2374         https://bugs.webkit.org/show_bug.cgi?id=62034
2375
2376         Reviewed by Antonio Gomes.
2377
2378         This is the main implementation file for EFL's DumpRenderTree.
2379
2380         * DumpRenderTree/efl/DumpRenderTree.cpp: Added.
2381         (dumpFramesAsText):
2382         (dumpFrameScrollPosition):
2383         (shouldLogFrameLoadDelegates):
2384         (shouldDumpAsText):
2385         (sendPixelResultsEOF):
2386         (invalidateAnyPreviousWaitToDumpWatchdog):
2387         (onEcoreEvasResize):
2388         (onCloseWindow):
2389         (useLongRunningServerMode):
2390         (parseCommandLineOptions):
2391         (getFinalTestURL):
2392         (getExpectedPixelHash):
2393         (createLayoutTestController):
2394         (runTest):
2395         (runTestingServerLoop):
2396         (adjustOutputTypeByMimeType):
2397         (dumpFrameContentsAsText):
2398         (shouldDumpFrameScrollPosition):
2399         (shouldDumpPixelsAndCompareWithExpected):
2400         (shouldDumpBackForwardList):
2401         (initEfl):
2402         (shutdownEfl):
2403         (displayWebView):
2404         (dump):
2405         (initEcoreEvas):
2406         (main):
2407
2408 2011-10-03  Adam Barth  <abarth@webkit.org>
2409
2410         garden-o-matic should remove builders from the failure grid once they start to pass
2411         https://bugs.webkit.org/show_bug.cgi?id=69309
2412
2413         Unreviewed.  dglazkov is on vacation.  I need to interest someone else
2414         in reviewing these patches.
2415
2416         This patch follows the update/purge model from UpdateTracker.  This
2417         patch is less awesome than it could be because it causes the UI to
2418         flash slightly.  In a future patch, we'll want to use these
2419         update/purge notifications to update the UI without flashing.  However,
2420         that's not such a big deal because this UI is hidden in the default
2421         view.
2422
2423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2427
2428 2011-10-03  David Levin  <levin@chromium.org>
2429
2430         webkitpy: Expose cc_emails and comments from bug.py
2431         https://bugs.webkit.org/show_bug.cgi?id=69308
2432
2433         Reviewed by Adam Barth.
2434
2435         * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
2436         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
2437         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
2438         to comments being exposed.
2439
2440 2011-10-03  James Robinson  <jamesr@chromium.org>
2441
2442         Add myself to the watchlist for platform/graphics/chromium
2443         https://bugs.webkit.org/show_bug.cgi?id=69297
2444
2445         Reviewed by David Levin.
2446
2447         * Scripts/webkitpy/common/config/watchlist:
2448
2449 2011-10-03  Anders Carlsson  <andersca@apple.com>
2450
2451         Remove custom scrollbar painting hooks
2452         https://bugs.webkit.org/show_bug.cgi?id=69163
2453
2454         Reviewed by Alexey Proskuryakov.
2455
2456         * DumpRenderTree/chromium/WebPreferences.cpp:
2457         (WebPreferences::applyTo):
2458         No need to enable custom scrollbar painting.
2459
2460 2011-10-03  David Levin  <levin@chromium.org>
2461
2462         watchlist: Make watchlist run on a bot.
2463         https://bugs.webkit.org/show_bug.cgi?id=68974
2464
2465         Reviewed by Adam Barth.
2466
2467         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
2468         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2469         Change to log what is run so that we can see the style command
2470         and the watchlist command being run.
2471
2472 2011-10-03  David Levin  <levin@chromium.org>
2473
2474         watchlist: Allow specified a bug to attach the watchlist info to.
2475         https://bugs.webkit.org/show_bug.cgi?id=69288
2476
2477         Reviewed by Eric Seidel.
2478
2479         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
2480         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2481         Add tests and fix an existing test because the unit tests do not go through the
2482         normal command line processing (so the -g argument remained when we determined bug ids).
2483         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
2484         get the assert raises regex method.
2485         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
2486
2487 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
2488
2489         [EFL] DRT: Add JSStringUtils.{cpp,h}
2490         https://bugs.webkit.org/show_bug.cgi?id=66397
2491
2492         Reviewed by Ryosuke Niwa.
2493         
2494         Adds helper functions to compare the equality of C-style strings and
2495         JSStringRef objects.
2496
2497         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
2498         (equals):
2499         * DumpRenderTree/efl/JSStringUtils.h: Added.
2500
2501 2011-10-03  Adam Barth  <abarth@webkit.org>
2502
2503         garden-o-matic should work in Safari 5.1
2504         https://bugs.webkit.org/show_bug.cgi?id=69290
2505
2506         Reviewed by Sam Weinig.
2507
2508         My old implementation of bind was too clever by half.  This one seems
2509         to work better, at least according to this test.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2513
2514 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2515
2516         Unreviewed: change my e-mail in commiters.py
2517
2518         (I'm leaving the company and my @openbossa.org will be no more)
2519
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2521
2522 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
2523
2524         Correct post-build step for WinCairo test runs.
2525         https://bugs.webkit.org/show_bug.cgi?id=69191 
2526
2527         Reviewed by Brian Weinstein.
2528
2529         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
2530         shell case to handle the CFLite build.
2531
2532 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
2533
2534         Added myself to reviewers, because I'm now a reviewer.
2535
2536         * Scripts/webkitpy/common/config/committers.py:
2537
2538 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
2539
2540         Bencher script makes it difficult to do automated performance testing
2541         https://bugs.webkit.org/show_bug.cgi?id=69207
2542
2543         Reviewed by Sam Weinig.
2544         
2545         This adds two new features:
2546         
2547         The ability to disable automatic VM detection, which is flaky if any
2548         profiling features are enabled in jsc.
2549         
2550         The ability to compute, and report, a scaled result for all benchmark
2551         suites. It is the geometric mean of three numbers: SunSpider's
2552         arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
2553         It is also possible to turn off all other output from bencher and just
2554         get this number with the --brief option.
2555
2556         * Scripts/bencher:
2557
2558 2011-10-01  Sam Weinig  <sam@webkit.org>
2559
2560         WTR is not successfully changing the NSUserDefaults
2561         https://bugs.webkit.org/show_bug.cgi?id=69204
2562
2563         Reviewed by Dan Bernstein.
2564
2565         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2566         (WTR::InjectedBundle::platformInitialize):
2567         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
2568         get our overrides picked up.
2569
2570 2011-09-30  Daniel Bates  <dbates@rim.com>
2571
2572         Cleanup: Extract code to launch a Mac WebKit application into a common function
2573         https://bugs.webkit.org/show_bug.cgi?id=68662
2574
2575         Reviewed by Adam Roben.
2576
2577         Extracts common code to launch a WebKit application on Mac OS X into a function
2578         so that we can remove duplicate code.
2579
2580         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
2581         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
2582         (runMacWebKitApp): Added.
2583         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
2584         (runMiniBrowser): Ditto.
2585         (runWebKitTestRunner): Ditto.
2586         (runTestWebKitAPI): Ditto.
2587
2588 2011-09-29  David Levin  <levin@chromium.org>
2589
2590         watchlist: Add webkit-patch command to run watchlist.
2591         https://bugs.webkit.org/show_bug.cgi?id=68973
2592
2593         Reviewed by Eric Seidel.
2594
2595         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
2596         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
2597         the cc and messages as sorted lists. To allow for deterministic ordering.
2598         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
2599         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
2600         that it will be exposed as a command by webkit-patch.
2601         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
2602         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
2603         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
2604         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
2605         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
2606         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
2607         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
2608         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
2609
2610 2011-09-30  David Levin  <levin@chromium.org>
2611
2612         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
2613         https://bugs.webkit.org/show_bug.cgi?id=69031
2614
2615         Reviewed by Adam Barth.
2616
2617         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
2618         a comment to explain something important about the email addresses, and
2619         a comment to let emacs know to treat the file as a python file.
2620         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
2621         Detects increases or decreases in a pattern.
2622         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
2623         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2624         Added unit tests for watchlist which has "more" or "less".
2625         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
2626         Added support for "more" or "less".
2627
2628 2011-09-30  Sam Weinig  <sam@webkit.org>
2629
2630         Add support for eventSender.mouseScrollBy in WTR
2631         https://bugs.webkit.org/show_bug.cgi?id=69189
2632
2633         Add implementation of eventSender.mouseScrollBy for the mac.
2634
2635         Reviewed by Simon Fraser.
2636
2637         * WebKitTestRunner/EventSenderProxy.h:
2638         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2639         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2640         (WTR::EventSendingController::keyDown):
2641         (WTR::EventSendingController::mouseScrollBy):
2642         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2643         * WebKitTestRunner/TestController.cpp:
2644         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2645         * WebKitTestRunner/mac/EventSenderProxy.mm:
2646         (WTR::EventSenderProxy::mouseScrollBy):
2647
2648 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
2649
2650         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
2651         https://bugs.webkit.org/show_bug.cgi?id=35273
2652
2653         Reviewed by Dan Bernstein.
2654         
2655         There are two types of font issue that can cause layout test failure.
2656         First, the user may have non-standard fonts installed that affect the layout
2657         of some tests. For example, some tests use the MS Gothic font if installed.
2658         
2659         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
2660         which override the system fonts (e.g. a copy of Arial from MS Office). For
2661         some tests, this can affect font metrics or fallback behavior.
2662         
2663         This change addresses the first problem only. It limits the set of fonts
2664         available through NSFontManager, by swizzling some methods to return
2665         a list of fonts or font families which only include fonts from a hardcoded
2666         whitelist.
2667         
2668         * DumpRenderTree/mac/DumpRenderTree.mm:
2669         (allowedFontFamilySet):
2670         (drt_NSFontManager_availableFontFamilies):
2671         (drt_NSFontManager_availableFonts):
2672         (swizzleNSFontManagerMethods):
2673         (activateTestingFonts):
2674         (adjustFonts):
2675         (createWebViewAndOffscreenWindow):
2676         (prepareConsistentTestingEnvironment):
2677         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2678         (WTR::allowedFontFamilySet):
2679         (WTR::drt_NSFontManager_availableFontFamilies):
2680         (WTR::drt_NSFontManager_availableFonts):
2681         (WTR::swizzleNSFontManagerMethods):
2682         (WTR::InjectedBundle::platformInitialize):
2683
2684 2011-09-30  David Levin  <levin@chromium.org>
2685
2686         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
2687         https://bugs.webkit.org/show_bug.cgi?id=69039
2688
2689         Reviewed by Adam Barth.
2690
2691         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2692         Actually skip only one specific test that is failing on Windows.
2693
2694 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2695
2696         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
2697
2698         For DRT we didn't install the message handler early enough to
2699         catch output while constructing the QApplication. For WTR we
2700         didn't even install a message handler.
2701
2702         Since the UI process will forward any output from the web process
2703         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
2704         in WTR before the web process is started. This is picked up by the
2705         web process which installs its own message handler.
2706
2707         The environment variable can be overriden on the command line if you
2708         want to see output from the web process, or you can pass --verbose to
2709         WTR to see output from both processes.
2710
2711         https://bugs.webkit.org/show_bug.cgi?id=69132
2712
2713         Reviewed by Andreas Kling.
2714
2715         * DumpRenderTree/qt/main.cpp:
2716         * WebKitTestRunner/qt/main.cpp:
2717
2718 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2719
2720         [Qt] Make sure WTR sizes the window and item correctly
2721
2722         Revision 96345 changed the logic for how the view and
2723         window was created, but missed a vital part, setting
2724         the size.
2725
2726         We now use a QSGView for the window, that has a simple
2727         item as its root object that is always resized to fit
2728         within the window. The webview is then parented to the
2729         root object and set to anchors.fill: parent. That way
2730         any window geometry changes will propagate to the web
2731         view.
2732
2733         https://bugs.webkit.org/show_bug.cgi?id=69134
2734
2735         Reviewed by Andreas Kling.
2736
2737         * WebKitTestRunner/PlatformWebView.h:
2738         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2739
2740 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
2741
2742         [EFL] Only save the current viewport in PixelDumpSupportEfl.
2743         https://bugs.webkit.org/show_bug.cgi?id=68450
2744
2745         Reviewed by Antonio Gomes.
2746
2747         The previous implementation saved the whole page contents in the final
2748         PNG, however the baselines and expectations in the tree only want the
2749         current viewport (with a scrollbar, if needed), so we now only save the
2750         currently visible contents.
2751
2752         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2753         (createBitmapContextFromWebView): Use
2754         ewk_frame_visible_content_geometry_get instead of
2755         ewk_frame_contents_size_get.
2756
2757 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
2758
2759         [EFL] Support and keep track of extra windows (views).
2760         https://bugs.webkit.org/show_bug.cgi?id=68454
2761
2762         Reviewed by Antonio Gomes.
2763
2764         So far, window.open and related JavaScript code would not work, as
2765         DRTView did not implementation
2766         Ewk_View_Smart_Class::window_{open,close}. The default implementation
2767         in ewk just returns the current window/view, which broke any
2768         layouttest which relied on window.open.
2769
2770         We now properly create and remove these new views. Unfortunately, the
2771         current way ewk works (and due to the fact that we cannot pass class
2772         methods as function pointers to the EFL functions), DRTView needs to
2773         know that DRTChrome exists and call `browser' directly in some points.
2774
2775         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2776         (onWindowCreate):
2777         (onWindowCloseDelayed):
2778         (onWindowClose):
2779         (drtViewTiledAdd):
2780
2781 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
2782
2783         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
2784         https://bugs.webkit.org/show_bug.cgi?id=42698
2785
2786         Reviewed by Andreas Kling.
2787
2788         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
2789         and call clearApplicationCache when layoutTest start up.
2790
2791         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2792         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2793         (WTR::InjectedBundle::beginTesting):
2794         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2795         (WTR::LayoutTestController::clearAllApplicationCaches):
2796         (WTR::LayoutTestController::setAppCacheMaximumSize):
2797         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2798
2799 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
2800
2801         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
2802         https://bugs.webkit.org/show_bug.cgi?id=69145
2803
2804         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
2805         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
2806         and is perfectly suitable for SceneGraph as well. GraphicsScene events
2807         will not be available in QtGui anymore in future. Therefore we also have to change
2808         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
2809
2810         Reviewed by Chang Shu.
2811
2812         * WebKitTestRunner/EventSenderProxy.h:
2813         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2814         (WTR::EventSenderProxy::createMouseEvent):
2815         (WTR::EventSenderProxy::mouseDown):
2816         (WTR::EventSenderProxy::mouseUp):
2817         (WTR::EventSenderProxy::mouseMoveTo):
2818
2819 2011-09-30  James Robinson  <jamesr@chromium.org>
2820
2821         [chromium] Add WebKit API for sending input events to the compositor thread
2822         https://bugs.webkit.org/show_bug.cgi?id=69117
2823
2824         Reviewed by Darin Fisher.
2825
2826         Adds support for creating and setting a compositor thread in DRT.
2827
2828         * DumpRenderTree/chromium/WebViewHost.cpp:
2829         (WebViewHost::WebViewHost):
2830         * DumpRenderTree/chromium/WebViewHost.h:
2831
2832 2011-09-29  David Levin  <levin@chromium.org>
2833
2834         watchlist: Add cross-checks for WatchList once it is filled.
2835         https://bugs.webkit.org/show_bug.cgi?id=68975
2836
2837         Reviewed by Eric Seidel.
2838
2839         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
2840         instead of having trivial getter and setters.
2841         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
2842         pass the validation checks.
2843         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
2844         and fix a few style nits.
2845         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
2846         validation checks.
2847         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
2848
2849 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
2850
2851         run-api-tests fails on chromium-win bot
2852         https://bugs.webkit.org/show_bug.cgi?id=69121
2853
2854         On Windows running a perl script needs the interpreter.
2855
2856         Reviewed by Adam Barth.
2857
2858         * Scripts/run-api-tests:
2859         (buildTestTool):
2860
2861 2011-09-29  Adam Barth  <abarth@webkit.org>
2862
2863         Attempt to make this tool work on Windows.
2864
2865         * Scripts/run-api-tests:
2866         (buildTestTool):
2867
2868 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2869
2870         [Qt] Try to fix the minial build
2871
2872         * QtTestBrowser/launcherwindow.cpp:
2873         * QtTestBrowser/webpage.cpp:
2874
2875 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2876
2877         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
2878
2879         QWidget and friends now live in the QtWidgets library. We update
2880         includes in implementation files and private headers to us the
2881         non-module-prefixed path, and leave the lookup for the include
2882         path. For public headers we have to ifdef the includes as the
2883         user might now have the modules we need in his QT config.
2884
2885         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
2886         have to update our code and use windowHandle() for setting the
2887         parent relationships.
2888
2889         https://bugs.webkit.org/show_bug.cgi?id=68687
2890
2891         Reviewed by Andreas Kling.
2892
2893         * DumpRenderTree/qt/DumpRenderTree.pro:
2894         * DumpRenderTree/qt/ImageDiff.pro:
2895         * MiniBrowser/qt/BrowserView.cpp:
2896         * MiniBrowser/qt/BrowserView.h:
2897         * MiniBrowser/qt/BrowserWindow.cpp:
2898         * MiniBrowser/qt/BrowserWindow.h:
2899         * MiniBrowser/qt/MiniBrowser.pro:
2900         * MiniBrowser/qt/MiniBrowserApplication.h:
2901         * MiniBrowser/qt/main.cpp:
2902         * QtTestBrowser/QtTestBrowser.pro:
2903         * QtTestBrowser/launcherwindow.cpp:
2904         * QtTestBrowser/launcherwindow.h:
2905         * QtTestBrowser/locationedit.h:
2906         * QtTestBrowser/main.cpp:
2907         * QtTestBrowser/mainwindow.cpp:
2908         * QtTestBrowser/mainwindow.h:
2909         * QtTestBrowser/webinspector.h:
2910         * QtTestBrowser/webpage.cpp:
2911         * QtTestBrowser/webview.cpp:
2912         * WebKitTestRunner/PlatformWebView.h:
2913         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2914
2915 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
2916
2917         Initial implementation of WebInspector for WebKit2 GTK port.
2918         https://bugs.webkit.org/show_bug.cgi?id=68235
2919
2920         Reviewed by Martin Robinson.
2921
2922         * MiniBrowser/gtk/BrowserWindow.c:
2923         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
2924
2925 2011-09-29  Adam Barth  <abarth@webkit.org>
2926
2927         Unbreak the "update expectatations" button by using the existing
2928         machinery to create the failureInfo objects.
2929
2930         Unbreak the "close" button on the progress dialog by using |this|
2931         instead of the old name of the object.
2932
2933         Teach the controllers unit test not to talk to the actual network.
2934
2935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
2937         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2938
2939 2011-09-29  Hans Wennborg  <hans@chromium.org>
2940
2941         IndexedDB: Use LevelDB also for in-memory databases
2942         https://bugs.webkit.org/show_bug.cgi?id=68903
2943
2944         Reviewed by Steve Block.
2945
2946         Remove the temporary dir that was necessary before LevelDB supported
2947         in-memory databases.
2948
2949         * DumpRenderTree/chromium/TestShell.cpp:
2950         (TestShell::TestShell):
2951         * DumpRenderTree/chromium/TestShell.h:
2952
2953 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
2954
2955         Run TestWebKitAPI on Chromium buildbots
2956         https://bugs.webkit.org/show_bug.cgi?id=68678
2957
2958         Reviewed by Tony Chang.
2959
2960         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2961
2962 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
2963
2964         garden-o-matic results should anticipate 0 unexpected failures.
2965         https://bugs.webkit.org/show_bug.cgi?id=69036
2966
2967         Also fixes controllers: UnexpectedFailures test.
2968
2969         Reviewed by Adam Barth.
2970
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
2972
2973 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
2974
2975         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
2976
2977         https://bugs.webkit.org/show_bug.cgi?id=67253
2978
2979         Reviewed by Eric Seidel.
2980
2981         Nearly all of the work in this was done by Simon Fraser; I'm
2982         just repackaging it and cleaning it up a bit. This change
2983         modifies port.diff_image() to return a tuple of (pass/fail,
2984         %age), adds the value to the FailureImageHashMismatch, and
2985         writes the value into the full_results.json files to be
2986         displayed in the results page.
2987
2988         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2989         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2990         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2991         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2992         * Scripts/webkitpy/layout_tests/port/base.py:
2993         * Scripts/webkitpy/layout_tests/port/chromium.py:
2994         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2995         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2996         * Scripts/webkitpy/layout_tests/port/test.py:
2997         * Scripts/webkitpy/layout_tests/port/webkit.py:
2998         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2999
3000 2011-09-25  Kentaro Hara  <haraken@chromium.org>
3001
3002         Unreviewed. Adding myself to committers.py.
3003
3004         * Scripts/webkitpy/common/config/committers.py:
3005
3006 2011-09-28  Adam Barth  <abarth@webkit.org>
3007
3008         garden-o-matic shouldn't depend on test-results.appspot.com
3009         https://bugs.webkit.org/show_bug.cgi?id=69019
3010
3011         Reviewed by Dimitri Glazkov.
3012
3013         This patch moves garden-o-matic from getting full_results.json from
3014         test-results.appspot.com to getting that information directly from the
3015         buildbot.  This patch improve the load time and accuracy of
3016         garden-o-matic because test-results.appspot.com is slow and is dropping
3017         a significant number of writes (see
3018         https://bugs.webkit.org/show_bug.cgi?id=68748).
3019
3020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3023
3024 2011-09-28  David Levin  <levin@chromium.org>
3025
3026         watchlist: Add a way to load the watchlist from config.
3027         https://bugs.webkit.org/show_bug.cgi?id=68991
3028
3029         Reviewed by Eric Seidel.
3030
3031         * Scripts/webkitpy/common/config/watchlist: Added.
3032         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
3033         Support for loading the watch list.
3034         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
3035         Tests for the loading.
3036         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
3037         Adjusted to use the common base class.
3038         * Scripts/webkitpy/common/webkitunittest.py: Added.
3039         Made a common base class for functionality used in more than one.
3040
3041 2011-09-28  David Levin  <levin@chromium.org>
3042
3043         Attempt fix for Leopard python unit test run.
3044
3045         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
3046
3047 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
3048
3049         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
3050         https://bugs.webkit.org/show_bug.cgi?id=68938
3051
3052         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
3053
3054         Reviewed by David Hyatt.
3055
3056         * DumpRenderTree/chromium/WebViewHost.cpp:
3057         (WebViewHost::didUpdateLayout): Added width/height queries.
3058         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
3059
3060 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
3061
3062         Get rebaseline server running again
3063         https://bugs.webkit.org/show_bug.cgi?id=69020
3064
3065         Reviewed by Adam Barth.
3066
3067         Make rebaseline server run again after r90337 (missing format_date_time
3068         import, results_json wasn't outputting anything).
3069
3070         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3071         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3072
3073 2011-09-28  David Grogan  <dgrogan@chromium.org>
3074
3075         Move dgrogan from contributor to committer
3076         https://bugs.webkit.org/show_bug.cgi?id=69021
3077
3078         * Scripts/webkitpy/common/config/committers.py:
3079
3080 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
3081
3082         Add Mac Skia GPU bots to builders.py
3083         https://bugs.webkit.org/show_bug.cgi?id=69016
3084
3085         Reviewed by Eric Seidel.
3086
3087         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
3088         GPU tests.
3089
3090         * Scripts/webkitpy/layout_tests/port/builders.py:
3091         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3092
3093 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3094
3095         Second try at fixing the GTK+ build.
3096
3097         * GNUmakefile.am:
3098
3099 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
3100
3101         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
3102         https://bugs.webkit.org/show_bug.cgi?id=68680
3103
3104         Reviewed by Tony Chang.
3105
3106         * Scripts/run-chromium-webkit-unit-tests:
3107         * Scripts/webkitdirs.pm:
3108         (determineBaseProductDir):
3109
3110 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3111
3112         [Gtk] Implement textInputController.doCommand
3113         https://bugs.webkit.org/show_bug.cgi?id=66496
3114
3115         Reviewed by Martin Robinson.
3116
3117         * DumpRenderTree/gtk/TextInputController.cpp:
3118         (doCommandCallback): Callback function for textInputController.doCommand
3119
3120 2011-09-28  David Levin  <levin@chromium.org>
3121
3122         watchlist: Suggest corrections for typos and improve error message consistency.
3123         https://bugs.webkit.org/show_bug.cgi?id=68976
3124
3125         Reviewed by Adam Barth.
3126
3127         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
3128         for typos and improve consistency of the error messages.
3129         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
3130         and improve the regex that were already present.
3131
3132 2011-09-28  David Levin  <levin@chromium.org>
3133
3134         watchlist: Add support for matching added or deleted lines.
3135         https://bugs.webkit.org/show_bug.cgi?id=68972
3136
3137         Reviewed by Adam Barth.
3138
3139         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
3140         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
3141         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
3142         to the pattern match to only have the diff lines instead of the DiffFile.
3143         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
3144         Add tests for the new patterns and combinations of the patterns.
3145         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
3146         Sort imports. Add changeline support.
3147
3148 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3149
3150         [GTK] Add WebKitError to GTK+ WebKit2 API
3151         https://bugs.webkit.org/show_bug.cgi?id=68508
3152
3153         Reviewed by Martin Robinson.
3154
3155         * GNUmakefile.am: Add path to webkitgtk derived sources to the
3156         include path.
3157
3158 2011-09-28  Philippe Normand  <pnormand@igalia.com>
3159
3160         [GTK] missing WebKit2 support in run-gtk-tests
3161         https://bugs.webkit.org/show_bug.cgi?id=68992
3162
3163         Rubber-stamped by Andreas Kling.
3164
3165         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
3166         webkit2 directory.
3167
3168 2011-09-27  Philippe Normand  <pnormand@igalia.com>
3169
3170         [GTK] build-webkit --no-webkit2 still builds WebKit2
3171         https://bugs.webkit.org/show_bug.cgi?id=68892
3172
3173         Reviewed by Martin Robinson.
3174
3175         Take the --no-webkit2 option in account when building WebKitGTK+.
3176
3177         * Scripts/build-webkit:
3178         * Scripts/webkitdirs.pm:
3179         (buildAutotoolsProject):
3180         (buildGtkProject):
3181
3182 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3183
3184         Make Chromium Win Release (Tests) a core builder
3185         https://bugs.webkit.org/show_bug.cgi?id=68906
3186
3187         Reviewed by Adam Barth.
3188
3189         Add Chromium Win Release (Tests) to the list of core builders.
3190
3191         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3192         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3193
3194 2011-09-27  Adam Barth  <abarth@webkit.org>
3195
3196         garden-o-matic should load faster and inform the user what is happening
3197         https://bugs.webkit.org/show_bug.cgi?id=68954
3198
3199         Reviewed by Dimitri Glazkov.
3200
3201         This test disables the expected failures tab.  The web inspector showed
3202         that loading the data for this tab was slowing down the loading time
3203         for the whole app.  We need to find a way to load that data lazily.
3204
3205         This patch also improves the update message to better describe the
3206         progress the app is making analyzing data from the buildbot.
3207
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3211
3212 2011-09-27  Adam Barth  <abarth@webkit.org>
3213
3214         garden-o-matic should show the first result when examining results
3215         https://bugs.webkit.org/show_bug.cgi?id=68960
3216
3217         Reviewed by Dimitri Glazkov.
3218
3219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3220
3221 2011-09-27  David Levin  <levin@chromium.org>
3222
3223         watchlist: Add support for cc and message rules.
3224         https://bugs.webkit.org/show_bug.cgi?id=68950
3225
3226         Reviewed by Adam Barth.
3227
3228         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
3229         the cc's and messages for a patch.
3230         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
3231         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
3232         for the rules.
3233         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
3234         A generic encapsulation of either a message list or a cc list.
3235         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
3236
3237 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
3238
3239         webkit-patch doesn't like UTF-8 characters in reviewers names
3240         https://bugs.webkit.org/show_bug.cgi?id=63452
3241
3242         Reviewed by Eric Seidel.
3243
3244         * Scripts/webkit-patch:
3245
3246 2011-09-27  Adam Barth  <abarth@webkit.org>
3247
3248         garden-o-matic examine buttons shows both expected and unexpected failures
3249         https://bugs.webkit.org/show_bug.cgi?id=68918
3250
3251         Reviewed by Dimitri Glazkov.
3252
3253         This was a copy/paste error when I refactored this classes to share
3254         more code.
3255
3256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3257
3258 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
3259
3260         Add Kaustubh Atrawalkar to the list of contributors.
3261
3262         * Scripts/webkitpy/common/config/committers.py:
3263
3264 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
3265
3266         [Chromium] Fixed layout mode tests break subsequent tests
3267         https://bugs.webkit.org/show_bug.cgi?id=68923
3268         
3269         Reviewed by Adam Barth.        
3270
3271         Reset fixed layout mode between tests, so that tests that run after
3272         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
3273         regular 800x600 non-fixed layout.
3274
3275         * DumpRenderTree/chromium/TestShell.cpp:
3276         (TestShell::resetTestController):
3277
3278 2011-09-27  David Levin  <levin@chromium.org>
3279
3280         watchlist: Add the filename pattern for definitions.
3281         https://bugs.webkit.org/show_bug.cgi?id=68917
3282
3283         Reviewed by Adam Barth.
3284
3285         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
3286         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
3287         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
3288         for definitions.
3289         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
3290         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
3291
3292 2011-09-27  Adam Barth  <abarth@webkit.org>
3293
3294         garden-o-matic results view should sort test and builder names
3295         https://bugs.webkit.org/show_bug.cgi?id=68488
3296
3297         Reviewed by Andy Estes.
3298
3299         Previously, the test and builder names were displayed in an arbitrary
3300         order that changed from time to time.  That confused one user study
3301         participant.  This patch sorts the lists so that they occur in a
3302         predictable order.
3303
3304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3305
3306 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3307
3308         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
3309         http://trac.webkit.org/changeset/96108
3310         http://trac.webkit.org/changeset/96111
3311         http://trac.webkit.org/changeset/96113
3312         http://trac.webkit.org/changeset/96116
3313         https://bugs.webkit.org/show_bug.cgi?id=68913
3314
3315         Wait for working Qt5 (Requested by ossy on #webkit).
3316
3317         * DumpRenderTree/qt/DumpRenderTree.pro:
3318         * DumpRenderTree/qt/ImageDiff.pro:
3319         * MiniBrowser/qt/BrowserView.cpp:
3320         (BrowserView::BrowserView):
3321         * MiniBrowser/qt/BrowserView.h:
3322         * MiniBrowser/qt/BrowserWindow.cpp:
3323         (BrowserWindow::BrowserWindow):
3324         (BrowserWindow::urlChanged):
3325         (BrowserWindow::~BrowserWindow):
3326         * MiniBrowser/qt/BrowserWindow.h:
3327         * MiniBrowser/qt/MiniBrowser.pro:
3328         * MiniBrowser/qt/MiniBrowserApplication.h:
3329         * MiniBrowser/qt/main.cpp:
3330         * QtTestBrowser/QtTestBrowser.pro:
3331         * QtTestBrowser/launcherwindow.cpp:
3332         * QtTestBrowser/launcherwindow.h:
3333         * QtTestBrowser/locationedit.h:
3334         * QtTestBrowser/main.cpp:
3335         * QtTestBrowser/mainwindow.cpp:
3336         * QtTestBrowser/mainwindow.h:
3337         * QtTestBrowser/webinspector.h:
3338         * QtTestBrowser/webpage.cpp:
3339         * QtTestBrowser/webview.cpp:
3340         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3341         * WebKitTestRunner/PlatformWebView.h:
3342         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3343         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3344         (WTR::WebView::wkView):
3345         (WTR::WebView::pageRef):
3346         (WTR::WebView::~WebView):
3347         (WTR::WebView::WebView):
3348         (WTR::PlatformWebView::PlatformWebView):
3349         (WTR::PlatformWebView::sendEvent):
3350         (WTR::PlatformWebView::postEvent):
3351         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3352
3353 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3354
3355         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
3356         https://bugs.webkit.org/show_bug.cgi?id=65178
3357
3358         Reviewed by Martin Robinson.
3359
3360         * GNUmakefile.am:
3361         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
3362
3363 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
3364
3365         [Qt][WK2] Buildfix after r96108.
3366
3367         Rubber-stamped by Andreas Kling.
3368
3369         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3370         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3371         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3372
3373 2011-09-27  David Levin  <levin@chromium.org>
3374
3375         watchlist: Change watchlistparser.py to be class based.
3376         https://bugs.webkit.org/show_bug.cgi?id=68869
3377
3378         Reviewed by Eric Seidel.
3379
3380         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
3381         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
3382
3383 2011-09-27  David Levin  <levin@chromium.org>
3384
3385         watchlist: Break out the diff boilerplate to allow for re-use.
3386         https://bugs.webkit.org/show_bug.cgi?id=68871
3387
3388         Reviewed by Eric Seidel.
3389
3390         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3391         Break out the diff into a new file.
3392         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
3393
3394 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
3395
3396         Web Inspector: UI performance: introduce heap size tracking stats.
3397         https://bugs.webkit.org/show_bug.cgi?id=68901
3398
3399         It is interesting how much the heap memory is used by Inspector in order of running the test.
3400
3401         Reviewed by Yury Semikhatsky.
3402
3403         * DumpRenderTree/chromium/TestShell.cpp:
3404         (TestShell::showDevTools):
3405         (TestShell::closeDevTools):
3406
3407 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3408
3409         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
3410
3411         QWidget and friends now live in the QtWidgets library. We update
3412         includes in implementation files and private headers to us the
3413         non-module-prefixed path, and leave the lookup for the include
3414         path. For public headers we have to ifdef the includes as the
3415         user might now have the modules we need in his QT config.
3416
3417         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
3418         have to update our code and use windowHandle() for setting the
3419         parent relationships.
3420
3421         https://bugs.webkit.org/show_bug.cgi?id=68687
3422
3423         Reviewed by Andreas Kling.
3424
3425         * DumpRenderTree/qt/DumpRenderTree.pro:
3426         * DumpRenderTree/qt/ImageDiff.pro:
3427         * MiniBrowser/qt/BrowserView.cpp:
3428         * MiniBrowser/qt/BrowserView.h:
3429         * MiniBrowser/qt/BrowserWindow.cpp:
3430         * MiniBrowser/qt/BrowserWindow.h:
3431         * MiniBrowser/qt/MiniBrowser.pro:
3432         * MiniBrowser/qt/MiniBrowserApplication.h:
3433         * MiniBrowser/qt/main.cpp:
3434         * QtTestBrowser/QtTestBrowser.pro:
3435         * QtTestBrowser/launcherwindow.cpp:
3436         * QtTestBrowser/launcherwindow.h:
3437         * QtTestBrowser/locationedit.h:
3438         * QtTestBrowser/main.cpp:
3439         * QtTestBrowser/mainwindow.cpp:
3440         * QtTestBrowser/mainwindow.h:
3441         * QtTestBrowser/webinspector.h:
3442         * QtTestBrowser/webpage.cpp:
3443         * QtTestBrowser/webview.cpp:
3444         * WebKitTestRunner/PlatformWebView.h:
3445         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3446
3447 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3448
3449         [Qt][WK2] Add support for hover API in Qt WebKit2
3450         https://bugs.webkit.org/show_bug.cgi?id=68369
3451
3452         Reviewed by Andreas Kling.
3453
3454         Change the statusbar to show the link URL when hovering links in
3455         MiniBrowser using QDesktopWebView.
3456
3457         * MiniBrowser/qt/BrowserWindow.cpp:
3458         (BrowserWindow::BrowserWindow):
3459         (BrowserWindow::onLinkHovered):
3460         * MiniBrowser/qt/BrowserWindow.h:
3461
3462 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
3463
3464         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
3465         https://bugs.webkit.org/show_bug.cgi?id=68864
3466
3467         Reviewed by Adam Barth.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
3470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
3471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
3472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
3473
3474 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
3475
3476         [Qt][WK2] One more unreviewed buildfix after r96005.
3477
3478         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
3479
3480 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
3481
3482         [Qt][WK2] Unreviewed buildfix after r96005.
3483
3484         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3485         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3486
3487 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
3488
3489         garden-o-matic should be pretty in Open Sans.
3490         https://bugs.webkit.org/show_bug.cgi?id=68845
3491
3492         Reviewed by Adam Barth.
3493
3494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
3495
3496 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
3497
3498         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
3499         https://bugs.webkit.org/show_bug.cgi?id=68841
3500
3501         Reviewed by Adam Barth.
3502
3503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
3505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
3506
3507 2011-09-26  David Levin  <levin@chromium.org>
3508
3509         watchlist: Add parsing for definition section.
3510         https://bugs.webkit.org/show_bug.cgi?id=68850
3511
3512         Reviewed by Adam Barth.
3513
3514         * Scripts/webkitpy/common/watchlist/watchlist.py:
3515         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
3516         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
3517
3518 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
3519
3520         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
3521
3522         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3523         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3524         * WebKitTestRunner/win/TestInvocationWin.cpp:
3525         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3526
3527 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
3528
3529         Repaint tests don't work in WebKit2
3530         https://bugs.webkit.org/show_bug.cgi?id=68453
3531
3532         Reviewed by Sam Weinig.
3533         
3534         Convert DumpRenderTree to use use the repaint rects
3535         exposed via WebKit API when generating the repaint test
3536         overlay.
3537         
3538         Fix WebKitTestRunner to work with repaint tests, again
3539         using the repaint rects exposed from WK2.
3540         
3541         In both cases, layoutTestController.display() now just
3542         forces a display of the web view, and turns on repaint
3543         rect tracking on the main FrameView.
3544         
3545         Later, when pixel results are requested, the alpha overlay
3546         that shows the repaint rects is generated using the list
3547         of rects supplied by WebCore.
3548
3549         * DumpRenderTree/mac/DumpRenderTree.mm:
3550         (resetDefaultsToConsistentValues):
3551         (resetWebViewToConsistentStateBeforeTesting):
3552         (displayWebView):
3553         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3554         (paintRepaintRectOverlay):
3555         (createBitmapContextFromWebView):
3556         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3557         (WTR::InjectedBundle::beginTesting):
3558         (WTR::InjectedBundle::done):
3559         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3560         (WTR::InjectedBundle::setRepaintRects):
3561         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3562         (WTR::InjectedBundlePage::reset):
3563         (WTR::InjectedBundlePage::dump):
3564         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3565         (WTR::LayoutTestController::display):
3566         * WebKitTestRunner/TestInvocation.cpp:
3567         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3568         * WebKitTestRunner/TestInvocation.h:
3569         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3570         (WTR::paintRepaintRectOverlay):
3571         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3572
3573 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
3574
3575         Get hover'ed element URL from HitTest.
3576
3577         mouseDidMoveOverElement now gets the hover'ed element link using
3578         WKHitTestResult API's.
3579         https://bugs.webkit.org/show_bug.cgi?id=68426 
3580
3581         Reviewed by Anders Carlsson.
3582
3583         * MiniBrowser/gtk/BrowserWindow.c:
3584         (mouseDidMoveOverElement):
3585
3586 2011-09-26  David Levin  <levin@chromium.org>
3587
3588         Add skeleton parsing for a WatchList.
3589         https://bugs.webkit.org/show_bug.cgi?id=68823
3590
3591         Reviewed by Adam Barth.
3592
3593         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
3594         Parses the top level watch list sections -- none are defined yet -- and
3595         throws an exception if an invalid one is listed.
3596         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
3597         Verify the exception for an invalid section in a watch list.
3598         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
3599
3600 2011-09-26  Adam Roben  <aroben@apple.com>
3601
3602         Clean up code imported from WebKitAPITest
3603
3604         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
3605         TestWebKitAPI conventions
3606
3607         Reviewed by David Levin.
3608
3609         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
3610         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
3611         namespace name.
3612
3613         (TestWebKitAPI::WebViewDestruction::SetUp):
3614         (TestWebKitAPI::WebViewDestruction::webViewCount):
3615         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3616         (TestWebKitAPI::WebViewDestruction::runMessagePump):
3617         (TestWebKitAPI::WebViewDestruction::TearDown):
3618         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
3619         Moved functionality from free functions into these new test fixtures.
3620
3621         * TestWebKitAPI/win/HostWindow.cpp:
3622         * TestWebKitAPI/win/HostWindow.h:
3623         Prefixed Win32 API calls with ::. Updated namespace name.
3624
3625 2011-09-23  Adam Roben  <aroben@apple.com>
3626
3627         Merge WebKitAPITest into TestWebKitAPI
3628
3629         This also means that our formerly-WebKitAPITest tests will be run on the bots!
3630
3631         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
3632         them more idiomatic in a separate pass.
3633
3634         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
3635         functionality (and names!)
3636
3637         Reviewed by Anders Carlsson.
3638
3639         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
3640         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
3641         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
3642
3643         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
3644
3645         * TestWebKitAPI/win/main.cpp:
3646         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.