Follow-up fix for r218996
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2
3         Follow-up fix for r218996
4
5         Unreviewed infrastructure fix.
6
7         Repeated calls to 'ios_version' make the log noisy, memoize the function.
8
9         * Scripts/webkitpy/port/ios_simulator.py:
10         (IOSSimulatorPort): Memoize ios_version().
11
12 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
13
14         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
15         https://bugs.webkit.org/show_bug.cgi?id=174017
16         <rdar://problem/32959782>
17
18         Reviewed by Simon Fraser.
19
20         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
21         changes, the caret would appear outside of the iframe.
22
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
25         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
26         (checkDragCaretRectIsContainedInRect):
27         (TestWebKitAPI::TEST):
28         * TestWebKitAPI/ios/DataInteractionSimulator.h:
29         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
30         (-[DataInteractionSimulator _resetSimulatedState]):
31         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
32         (-[DataInteractionSimulator _advanceProgress]):
33         (-[DataInteractionSimulator lastKnownDragCaretRect]):
34
35 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
36
37         Add support for different versions of iOS when loading test expectations
38         https://bugs.webkit.org/show_bug.cgi?id=173774
39         <rdar://problem/32951132>
40
41         Rubber-stamped by Aakash Jain.
42
43         When running layout tests, we should support multiple version of iOS the same way we do Mac.
44
45         * Scripts/webkitpy/port/ios.py:
46         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
47         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
48         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
49         * Scripts/webkitpy/port/ios_device.py:
50         (IOSDevicePort.ios_version): Ask connected devices for implementation.
51         * Scripts/webkitpy/port/ios_device_unittest.py:
52         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
53         (IOSDeviceTest.test_baseline_searchpath): Ditto.
54         (IOSDeviceTest.test_expectations_ordering): Ditto.
55         * Scripts/webkitpy/port/ios_simulator.py:
56         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
57         ask the platform.
58
59 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
60
61         Fontconfig build breaks with glibc 2.15+
62         https://bugs.webkit.org/show_bug.cgi?id=174019
63
64         Reviewed by Carlos Alberto Lopez Perez.
65
66         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
67
68         * wpe/jhbuild.modules:
69         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
70
71 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
72
73         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
74         https://bugs.webkit.org/show_bug.cgi?id=174010
75         <rdar://problem/32597802>
76
77         Reviewed by Tim Horton.
78
79         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
80         snapshot fails for any reason.
81
82         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
83         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
84         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
85         (TestWebKitAPI::TEST):
86
87 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
88
89         AX: Cannot call setValue() on contenteditable or ARIA text controls
90         https://bugs.webkit.org/show_bug.cgi?id=173520
91
92         Reviewed by Ryosuke Niwa.
93
94         Add setValue() method to WKTR (already existed in DRT).
95
96         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
97         (WTR::AccessibilityUIElement::setValue):
98         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
99         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
100         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
101         (WTR::AccessibilityUIElement::setValue):
102
103 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
104
105         getBoundingClientRect returns wrong value for combination of page zoom and scroll
106         https://bugs.webkit.org/show_bug.cgi?id=173841
107         rdar://problem/32983841
108
109         Reviewed by Dean Jackson.
110
111         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
112         always did text zooming.
113
114         * MiniBrowser/mac/WK1BrowserWindowController.m:
115         (-[WK1BrowserWindowController zoomIn:]):
116         (-[WK1BrowserWindowController zoomOut:]):
117         (-[WK1BrowserWindowController canResetZoom]):
118         (-[WK1BrowserWindowController resetZoom:]):
119
120 2017-06-29  John Wilander  <wilander@apple.com>
121
122         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
123         https://bugs.webkit.org/show_bug.cgi?id=173940
124         <rdar://problem/33018125>
125
126         Reviewed by Brent Fulgham.
127
128         This change allows the TestController to turn off
129         regular resource load statistics telemetry submission
130         and to manually control when telemetry is calculated
131         and submitted.
132
133         * WebKitTestRunner/TestController.cpp:
134         (WTR::TestController::initialize):
135             Turns off automatic resource load statistics telemetry submission.
136
137 2017-06-29  Commit Queue  <commit-queue@webkit.org>
138
139         Unreviewed, rolling out r218512.
140         https://bugs.webkit.org/show_bug.cgi?id=173981
141
142         "It changes the behavior of the JS API's JSEvaluateScript
143         which breaks TurboTax" (Requested by saamyjoon on #webkit).
144
145         Reverted changeset:
146
147         "test262: Completion values for control flow do not match the
148         spec"
149         https://bugs.webkit.org/show_bug.cgi?id=171265
150         http://trac.webkit.org/changeset/218512
151
152 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
153
154         Add WebKitSystemInterface for iOS 11
155         https://bugs.webkit.org/show_bug.cgi?id=173936
156
157         Reviewed by Lucas Forschler.
158
159         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
160
161 2017-06-28  Keith Miller  <keith_miller@apple.com>
162
163         VMTraps has some races
164         https://bugs.webkit.org/show_bug.cgi?id=173941
165
166         Reviewed by Michael Saboff.
167
168         Add new testing mode for testing the Watchdog with our stress
169         tests.
170
171         * Scripts/run-jsc-stress-tests:
172
173 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
174
175         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
176         https://bugs.webkit.org/show_bug.cgi?id=173877
177
178         Reviewed by Brady Eidson.
179
180         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
181         the next tests.
182
183         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
184         (testGetFavicon):
185
186 2017-06-28  Tim Horton  <timothy_horton@apple.com>
187
188         MobileSafari was constantly using 10-15% CPU viewing a PDF
189         https://bugs.webkit.org/show_bug.cgi?id=173944
190         <rdar://problem/33039910>
191
192         Reviewed by Simon Fraser.
193
194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
195         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
196         Add a test that we ever call the stable presentation update callback
197         when we have a WKPDFView up, instead of infinitely looping.
198
199 2017-06-28  Alex Christensen  <achristensen@webkit.org>
200
201         Prevent displaying URLs with small capital letters
202         https://bugs.webkit.org/show_bug.cgi?id=173949
203         <rdar://problem/32952058>
204
205         Reviewed by Brent Fulgham.
206
207         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
208         (TestWebKitAPI::TEST):
209
210 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
211
212         Unreviewed test fix.
213
214         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
215
216         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
217
218 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
219
220         Teach ResourceLoadStatistics to recognize changes in the file system
221         https://bugs.webkit.org/show_bug.cgi?id=173800
222         <rdar://problem/32937842>
223
224         Reviewed by Chris Dumez.
225
226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
227         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
228         (TestWebKitAPI::FileMonitorTest::tempFilePath):
229         (TestWebKitAPI::handleFileModification):
230         (TestWebKitAPI::handleFileDeletion):
231         (TestWebKitAPI::resetTestState):
232         (TestWebKitAPI::TEST_F):
233
234 2017-06-28  Brady Eidson  <beidson@apple.com>
235
236         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
237         https://bugs.webkit.org/show_bug.cgi?id=173874
238
239         Reviewed by Alex Christensen.
240
241         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
242
243 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
244
245         Unreviewed, adding Don Olmstead to contributors.json
246
247         * Scripts/webkitpy/common/config/contributors.json:
248
249 2017-06-28  Alex Christensen  <achristensen@webkit.org>
250
251         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
252         https://bugs.webkit.org/show_bug.cgi?id=173886
253         <rdar://problem/32543191>
254
255         Reviewed by Andy Estes.
256
257         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
258         (ParsedRange::ParsedRange):
259         (-[TestSchemeHandler initWithVideoData:]):
260         (-[TestSchemeHandler webView:startURLSchemeTask:]):
261         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
262         (TEST):
263
264 2017-06-27  JF Bastien  <jfbastien@apple.com>
265
266         WebAssembly: running out of executable memory should throw OoM
267         https://bugs.webkit.org/show_bug.cgi?id=171537
268         <rdar://problem/32963338>
269
270         Reviewed by Saam Barati.
271
272         * Scripts/run-jsc-stress-tests: add a configuration which runs the
273         tests under limited executable memory and avoids non-WebAssembly
274         code generation so that we more reliably run out of executable
275         memory in WebAssembly.
276
277 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
278
279         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
280         https://bugs.webkit.org/show_bug.cgi?id=173854
281         <rdar://problem/32236827>
282
283         Reviewed by Ryosuke Niwa and Tim Horton.
284
285         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
286
287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
288         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
289         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
290         (TestWebKitAPI::TEST):
291
292 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
293
294         [PAL] Add symbol export macros for PAL
295         https://bugs.webkit.org/show_bug.cgi?id=171519
296
297         Reviewed by Konstantin Tokarev.
298
299         * DumpRenderTree/config.h:
300         * TestWebKitAPI/CMakeLists.txt:
301         * TestWebKitAPI/config.h:
302         * WebKitTestRunner/config.h:
303
304 2017-06-27  John Wilander  <wilander@apple.com>
305
306         Resource Load Statistics: Add telemetry
307         https://bugs.webkit.org/show_bug.cgi?id=173499
308         <rdar://problem/32826094>
309
310         Reviewed by Brent Fulgham.
311
312         Adds three new testRunner functions:
313         - installStatisticsDidRunTelemetryCallback()
314         - statisticsFireTelemetryHandler()
315         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
316
317         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
318         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
319         (WTR::InjectedBundle::didReceiveMessageToPage):
320         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
321         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
322         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
323         (WTR::TestRunner::statisticsFireTelemetryHandler):
324         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
325         * WebKitTestRunner/InjectedBundle/TestRunner.h:
326         * WebKitTestRunner/TestController.cpp:
327         (WTR::TestController::resetStateToConsistentValues):
328         (WTR::TestController::statisticsFireTelemetryHandler):
329         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
330         * WebKitTestRunner/TestController.h:
331         * WebKitTestRunner/TestInvocation.cpp:
332         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
333
334 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
335
336         Add missing includes to fix compilation error on FreeBSD
337         https://bugs.webkit.org/show_bug.cgi?id=172919
338
339         Reviewed by Mark Lam.
340
341         * ImageDiff/cairo/PlatformImageCairo.cpp:
342
343 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
344
345         Unreviewed, rolling out r218783.
346
347         Causing accessibility/mac/setting-attributes-is-
348         asynchronous.html to crash consistently on mac-wk2 Debug
349
350         Reverted changeset:
351
352         "AX: Cannot call setValue() on contenteditable or ARIA text
353         controls"
354         https://bugs.webkit.org/show_bug.cgi?id=173520
355         http://trac.webkit.org/changeset/218783
356
357 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
358
359         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
360         https://bugs.webkit.org/show_bug.cgi?id=173825
361
362         Reviewed by Saam Barati.
363
364         * DumpRenderTree/JavaScriptThreading.cpp:
365         (runJavaScriptThread):
366         (startJavaScriptThreads):
367         * DumpRenderTree/mac/DumpRenderTree.mm:
368         (runThread):
369         (runPthread):
370         (testThreadIdentifierMap):
371
372 2017-06-26  David Kilzer  <ddkilzer@apple.com>
373
374         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
375         <https://webkit.org/b/173837>
376
377         Reviewed by Geoffrey Garen.
378
379         The clang static analyzer can't reason about objects that are
380         assigned to a delegate as +1 retained, and then released
381         later in a different method when the delegate is cleared.
382
383         Instead, use a common idiom where the object setting the
384         delegate retains it as an instance variable on initialization.
385         Then the same object clears the delegate and releases its
386         instance variable during teardown.
387
388         Also add EXPECT_TRUE() tests to make sure the delegate objects
389         match before teardown.
390
391         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
392         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
393         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
394         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
395         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
396         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
397
398 2017-06-26  David Kilzer  <ddkilzer@apple.com>
399
400         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
401         <https://webkit.org/b/173836>
402
403         Reviewed by Brady Eidson.
404
405         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
406         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
407         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
408         objects in this test.
409
410 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
411
412         [ATK] Add support for aria-details and aria-errormessage
413         https://bugs.webkit.org/show_bug.cgi?id=172588
414
415         Reviewed by Chris Fleizach.
416
417         Add additional methods to test ARIA properties which are exposed via
418         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
419         to versions which support the details and error-message relation types.
420
421         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
422         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
423         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
424         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
425         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
426         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
427         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
428         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
429         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
430         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
431         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
432         * gtk/jhbuild.modules:
433
434 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
435
436         Unreviewed. Add libfii to GTK+ install dependencies script.
437
438         * gtk/install-dependencies:
439
440 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
441
442         Unreviewed, rolling out r215190.
443
444         Broke product select element on GNOME Bugzilla
445
446         Reverted changeset:
447
448         "[GTK] Misplaced right click menu on web page due to
449         deprecated gtk_menu_popup()"
450         https://bugs.webkit.org/show_bug.cgi?id=170553
451         http://trac.webkit.org/changeset/215190
452
453 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
454
455         Remove Reflect.enumerate
456         https://bugs.webkit.org/show_bug.cgi?id=173806
457
458         Reviewed by Yusuke Suzuki.
459
460         * Scripts/run-jsc-stress-tests:
461
462 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
463
464         AX: Cannot call setValue() on contenteditable or ARIA text controls
465         https://bugs.webkit.org/show_bug.cgi?id=173520
466
467         Reviewed by Ryosuke Niwa.
468
469         Add setValue() method to WKTR (already existed in DRT).
470
471         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
472         (WTR::AccessibilityUIElement::setValue):
473         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
474         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
475         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
476         (WTR::AccessibilityUIElement::setValue):
477
478 2017-06-23  Keith Miller  <keith_miller@apple.com>
479
480         Switch VMTraps to use halt instructions rather than breakpoint instructions
481         https://bugs.webkit.org/show_bug.cgi?id=173677
482
483         Reviewed by JF Bastien.
484
485         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
486         (TEST):
487
488 2017-06-23  Youenn Fablet  <youenn@apple.com>
489
490         Set getUserMedia permission to true by default on WTR
491         https://bugs.webkit.org/show_bug.cgi?id=173610
492
493         Reviewed by Alex Christensen.
494
495         Adding a way to reset the getUserMedia permission to pending.
496
497         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
498         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
499         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
500         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
502         (WTR::TestRunner::setUserMediaPermissionAsUnset):
503         * WebKitTestRunner/InjectedBundle/TestRunner.h:
504         * WebKitTestRunner/TestController.cpp:
505         (WTR::TestController::resetStateToConsistentValues):
506         (WTR::TestController::setUserMediaPermissionAsUnset):
507         * WebKitTestRunner/TestController.h:
508         * WebKitTestRunner/TestInvocation.cpp:
509         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
510
511 2017-06-23  Alex Christensen  <achristensen@webkit.org>
512
513         Add SPI to WKURLSchemeTask for redirection
514         https://bugs.webkit.org/show_bug.cgi?id=173730
515
516         Reviewed by Brady Eidson.
517
518         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
519         (-[SchemeHandler webView:startURLSchemeTask:]):
520         (-[SchemeHandler webView:stopURLSchemeTask:]):
521         (TEST):
522         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
523         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
524         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
525         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
526         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
527
528 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
529
530         [WPE] Use JSC API to send script messages from web extension in tests
531         https://bugs.webkit.org/show_bug.cgi?id=173757
532
533         Reviewed by Žan Doberšek.
534
535         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
536         to run postMessage().
537
538         Fixes: /wpe/WebKitSecurityManager/file-xhr
539                /wpe/WebKitConsoleMessage/console-api
540                /wpe/WebKitConsoleMessage/js-exception
541                /wpe/WebKitConsoleMessage/network-error
542                /wpe/WebKitConsoleMessage/security-error
543
544         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
545         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
546         (beforeAll): Ditto.
547         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
548         (testWebContextSecurityFileXHR): Ditto.
549         (beforeAll): Ditto.
550         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
551         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
552         (pageCreatedCallback): Remove ifdefs.
553
554 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
555
556         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
557
558         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
559         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
560         doesn't exist yet in WPE.
561
562         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
563         (testWebViewJavaScriptDialogs):
564         (testWebViewWindowProperties):
565
566 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
567
568         [GTK] Upgrade pixman and cairo in jhbuild
569         https://bugs.webkit.org/show_bug.cgi?id=173710
570
571         Reviewed by Carlos Alberto Lopez Perez.
572
573         * gtk/jhbuild.modules:
574
575 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
576
577         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
578         https://bugs.webkit.org/show_bug.cgi?id=173711
579
580         Reviewed by Carlos Alberto Lopez Perez.
581
582         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
583         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
584
585         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
586         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
587
588 2017-06-22  David Kilzer  <ddkilzer@apple.com>
589
590         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
591         <https://webkit.org/b/173721>
592
593         Reviewed by Joseph Pecoraro.
594
595         Use RetainPtr<> to create NSMutableDictionary and NSNumber
596         objects to fix leaks and to avoid the autoreleasepool.
597
598         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
599         (TEST):
600
601 2017-06-22  Matt Lewis  <jlewis3@apple.com>
602
603         Unreviewed, rolling out r218633.
604
605         The test is failing frequently on Sierra Debug and Windows
606
607         Reverted changeset:
608
609         "AX: Cannot call setValue() on contenteditable or ARIA text
610         controls"
611         https://bugs.webkit.org/show_bug.cgi?id=173520
612         http://trac.webkit.org/changeset/218633
613
614 2017-06-22  David Kilzer  <ddkilzer@apple.com>
615
616         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
617         <https://webkit.org/b/173690>
618
619         Reviewed by Chris Dumez.
620
621         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
622         ownership of malloc()-ed memory, then frees it when it's
623         released.  These tests were passing global variables into the
624         method, which is not malloc()-ed memory, which violates the API
625         contract.
626
627         The fix is to switch to use
628         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
629         NO for the last argument.
630
631         Caught by the clang static analyzer.
632
633         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
634         (TEST):
635         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
636         (TEST):
637
638 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
639
640         [GTK] Upgrade Harfbuzz to version 1.4.2
641         https://bugs.webkit.org/show_bug.cgi?id=173592
642
643         Reviewed by Carlos Alberto Lopez Perez.
644
645         * gtk/jhbuild.modules:
646
647 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
648
649         [WPE] Update WPEBackend-mesa
650         https://bugs.webkit.org/show_bug.cgi?id=173705
651
652         Reviewed by Carlos Alberto Lopez Perez.
653
654         A crash has been fixed, needed for unit tests to work.
655
656         * wpe/jhbuild.modules:
657
658 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
659
660         Remove unused coordinated graphics C API
661         https://bugs.webkit.org/show_bug.cgi?id=173706
662
663         Reviewed by Žan Doberšek.
664
665         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
666         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
667         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
668         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
669         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
670         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
671
672 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
673
674         [WPE] Build glib API tests
675         https://bugs.webkit.org/show_bug.cgi?id=173702
676
677         Reviewed by Žan Doberšek.
678
679         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
680         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
681         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
682         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
683         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
684         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
685         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
686         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
687         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
688         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
689         and implement the missing features.
690
691         * CMakeLists.txt:
692         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
693         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
694         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
695         (testAutomationSessionRequestSession):
696         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
697         (testWebKitWebViewSessionState):
698         (testWebKitWebViewSessionStateWithFormData):
699         (testWebKitWebViewNavigationAfterSessionRestore):
700         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
701         (beforeAll):
702         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
703         (testCookieManagerEphemeral):
704         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
705         (testBlobDownload):
706         (beforeAll):
707         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
708         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
709         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
710         (testProcessPerWebView):
711         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
712         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
713         (testWebViewCreateNavigationData):
714         (testWebViewJavaScriptDialogs):
715         (testWebViewWindowProperties):
716         (testWebViewMouseTarget):
717         (testWebViewGeolocationPermissionRequests):
718         (testWebViewUserMediaPermissionRequests):
719         (testWebViewAudioOnlyUserMediaPermissionRequests):
720         (testWebViewFileChooserRequest):
721         (beforeAll):
722         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
723         (beforeAll):
724         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
725         (testPrivateBrowsing):
726         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
727         (testFindControllerHide):
728         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
729         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
730         (testWebKitSettings):
731         (beforeAll):
732         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
733         (testWebViewNewWithUserContentManager):
734         (beforeAll):
735         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
736         (testWebContextEphemeral):
737         (testWebContextProxySettings):
738         (beforeAll):
739         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
740         (testWebViewWebContext):
741         (testWebViewWebContextLifetime):
742         (testWebViewEphemeral):
743         (testWebViewSettings):
744         (testWebViewCanShowMIMEType):
745         (testWebViewPageVisibility):
746         (testWebViewIsPlayingAudio):
747         (beforeAll):
748         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
749         (testWebsiteDataEphemeral):
750         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
751         (documentLoadedCallback):
752         (pageCreatedCallback):
753         (methodCallCallback):
754         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
755         * TestWebKitAPI/glib/CMakeLists.txt:
756         * TestWebKitAPI/glib/PlatformGTK.cmake:
757         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
758         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
759         (main):
760         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
761         (Test::adoptView):
762         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
763         (WebKitTestBus::run):
764         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
765         (WebViewTest::~WebViewTest):
766         (WebViewTest::initializeWebView):
767         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
768         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
769         (WebViewTest::platformDestroy):
770         (WebViewTest::platformInitializeWebView):
771         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
772         (WebViewTest::resizeView):
773         (WebViewTest::hideView):
774         (parentWindowMapped):
775         (WebViewTest::showInWindow):
776         (WebViewTest::showInWindowAndWaitUntilMapped):
777         (WebViewTest::mouseMoveTo):
778         (WebViewTest::clickMouseButton):
779         (WebViewTest::emitPopupMenuSignal):
780         (WebViewTest::keyStroke):
781         (WebViewTest::doMouseButtonEvent):
782         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
783         (WebViewTest::platformDestroy):
784         (WebViewTest::platformInitializeWebView):
785         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
786         (WebViewTest::resizeView):
787         (WebViewTest::hideView):
788         (WebViewTest::mouseMoveTo):
789         (WebViewTest::clickMouseButton):
790         (WebViewTest::keyStroke):
791
792 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
793
794         [GTK] Move WebKit2 GLib API tests to glib directories
795         https://bugs.webkit.org/show_bug.cgi?id=173642
796
797         Reviewed by Žan Doberšek.
798
799         * CMakeLists.txt:
800         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
801         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
802         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
803         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
804         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
805         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
806         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
807         (testWebKitConsoleMessageNetworkError):
808         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
809         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
810         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
811         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
812         (testLoadFromGResource):
813         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
814         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
815         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
816         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
817         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
818         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
819         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
820         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
821         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
822         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
823         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
824         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
825         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
826         (testWebViewRunJavaScript):
827         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
828         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
829         (registerGResource):
830         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
831         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
832         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
833         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
834         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
835         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
836         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
837         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
838         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
839         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
840         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
841         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
842         * TestWebKitAPI/glib/CMakeLists.txt: Added.
843         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
844         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
845         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
846         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
847         (registerGResource):
848         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
849         (Test::getResourcesDir):
850         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
851         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
852         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
853         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
854         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
855         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
856
857 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
858
859         [WPE] Add initial web extensions API
860         https://bugs.webkit.org/show_bug.cgi?id=173640
861
862         Reviewed by Žan Doberšek.
863
864         Add style checker exceptions for WPE web extensions API files.
865
866         * Scripts/webkitpy/style/checker.py:
867
868 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
869
870         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
871         https://bugs.webkit.org/show_bug.cgi?id=173659
872         <rdar://problem/32879788>
873
874         Reviewed by Tim Horton.
875
876         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
877
878         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
879
880         Augment this test page to log dragend and dragstart events on the drag source as well.
881
882         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
883         (checkStringArraysAreEqual):
884         (TestWebKitAPI::TEST):
885
886 2017-06-21  Antoine Quint  <graouts@apple.com>
887
888         Ensure DRT always logs rAF suspension debugging code
889         https://bugs.webkit.org/show_bug.cgi?id=173681
890
891         Reviewed by Tim "Mr. T" Horton.
892
893         * DumpRenderTree/mac/DumpRenderTree.mm:
894         (resetWebPreferencesToConsistentValues):
895
896 2017-06-21  Chris Dumez  <cdumez@apple.com>
897
898         Allow constructing a WTF:Function from a function pointer
899         https://bugs.webkit.org/show_bug.cgi?id=173660
900
901         Reviewed by Alex Christensen.
902
903         Add API test coverage.
904
905         * TestWebKitAPI/Tests/WTF/Function.cpp:
906         (TestWebKitAPI::returnThree):
907         (TestWebKitAPI::returnFour):
908         (TestWebKitAPI::returnPassedValue):
909         (TestWebKitAPI::TEST):
910
911 2017-06-21  Antoine Quint  <graouts@apple.com>
912
913         Add logging to identify when the Page suspends scripted animations
914         https://bugs.webkit.org/show_bug.cgi?id=173626
915
916         Reviewed by Tim Horton.
917
918         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
919
920         * DumpRenderTree/mac/DumpRenderTree.mm:
921         (resetWebPreferencesToConsistentValues):
922
923 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
924
925         AX: Cannot call setValue() on contenteditable or ARIA text controls
926         https://bugs.webkit.org/show_bug.cgi?id=173520
927
928         Reviewed by Ryosuke Niwa.
929
930         Add setValue() method to WKTR (already existed in DRT).
931
932         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
933         (WTR::AccessibilityUIElement::setValue):
934         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
935         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
936         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
937         (WTR::AccessibilityUIElement::setValue):
938
939 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
940
941         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
942         as one of the dependencies required to build the product.
943
944         Rubber-stamped by Carlos Garcia Campos.
945
946         * gtk/install-dependencies:
947         * wpe/install-dependencies:
948
949 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
950
951         Disable font variations on macOS Sierra and iOS 10
952         https://bugs.webkit.org/show_bug.cgi?id=173618
953         <rdar://problem/32879164>
954
955         Reviewed by Jon Lee.
956
957         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
958
959 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
960
961         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
962         https://bugs.webkit.org/show_bug.cgi?id=173578
963         <rdar://problem/32825028>
964
965         Reviewed by Tim Horton.
966
967         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
968         a custom popover does not cause dragging to fail when the popover is presented.
969
970         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
971         (-[DataInteractionSimulator _advanceProgress]):
972
973 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
974
975         [WPE] Add initial implementation of glib API
976         https://bugs.webkit.org/show_bug.cgi?id=173546
977
978         Reviewed by Žan Doberšek.
979
980         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
981         include WPE glib API files.
982
983         * Scripts/webkitperl/FeatureList.pm:
984         * Scripts/webkitpy/style/checker.py:
985         * Scripts/webkitpy/style/checkers/cpp.py:
986         (check_identifier_name_in_declaration):
987
988 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
989
990         [GTK] Upgrade to ICU to version 57.1
991         https://bugs.webkit.org/show_bug.cgi?id=173538
992
993         Reviewed by Žan Doberšek.
994
995         * gtk/jhbuild.modules:
996
997 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
998
999         [GTK] Remove unneeded modules from the jhbuild
1000         https://bugs.webkit.org/show_bug.cgi?id=170540
1001
1002         Reviewed by Michael Catanzaro.
1003
1004         We are building libxslt and libffi that we don't really need to build from sources.
1005
1006         * gtk/jhbuild.modules:
1007
1008 2017-06-19  Frederic Wang  <fwang@igalia.com>
1009
1010         [Mac] Add an experimental feature setting for async frame scrolling
1011         https://bugs.webkit.org/show_bug.cgi?id=173359
1012
1013         Reviewed by Simon Fraser.
1014
1015         * DumpRenderTree/mac/DumpRenderTree.mm:
1016         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
1017         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
1018         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1019         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
1020
1021 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
1022
1023         Unreviewed, adding myself to contributors.json
1024
1025         * Scripts/webkitpy/common/config/contributors.json:
1026
1027 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
1028
1029         test262: Completion values for control flow do not match the spec
1030         https://bugs.webkit.org/show_bug.cgi?id=171265
1031
1032         Reviewed by Saam Barati.
1033
1034         * Scripts/run-jsc-stress-tests:
1035         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
1036
1037 2017-06-19  Zalan Bujtas  <zalan@apple.com>
1038
1039         Opening certain mails brings up a mail that grows indefinitely.
1040         https://bugs.webkit.org/show_bug.cgi?id=173562
1041         <rdar://problem/32766579>
1042
1043         Reviewed by Tim Horton.
1044
1045         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1046         (TEST):
1047
1048 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1049
1050         [iOS DnD] Support .zip archives for file uploads via drag and drop
1051         https://bugs.webkit.org/show_bug.cgi?id=173511
1052         <rdar://problem/32521025>
1053
1054         Reviewed by Tim Horton.
1055
1056         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
1057         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
1058
1059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1060         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
1061         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1062         (testZIPArchive):
1063         (TestWebKitAPI::TEST):
1064
1065 2017-06-18  Darin Adler  <darin@apple.com>
1066
1067         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
1068         https://bugs.webkit.org/show_bug.cgi?id=173526
1069
1070         Reviewed by Sam Weinig.
1071
1072         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
1073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1074
1075         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
1076         tests for assignment before destruction ones.
1077
1078         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
1079         as a function, so it can be used in WTF::Function tests.
1080
1081         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
1082         Added tests for swap and for assignment before deref.
1083
1084         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
1085         to inline everything. Also removed the unnecessary clearing of the log every time
1086         the DerivedRefLogger constructor is called.
1087         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
1088
1089         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
1090         Added tests for assignment before deref and similar for releaseNonNull.
1091
1092 2017-06-19  Sam Weinig  <sam@webkit.org>
1093
1094         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
1095         https://bugs.webkit.org/show_bug.cgi?id=173513
1096
1097         Reviewed by Alex Christensen.
1098
1099         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1100         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1101         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
1102
1103 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
1104
1105         [Win] fast/dom/assign-to-window-status.html is flaky.
1106         https://bugs.webkit.org/show_bug.cgi?id=173512
1107
1108         Reviewed by Alex Christensen.
1109
1110         We should not dump status callbacks when test is done.
1111
1112         * DumpRenderTree/win/UIDelegate.cpp:
1113         (UIDelegate::setStatusText):
1114
1115 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1116
1117         [WPE][JHBuild] Update WPEBackend-mesa
1118         https://bugs.webkit.org/show_bug.cgi?id=173433
1119
1120         Unreviewed.
1121
1122         Update WPEBackend-mesa back (like it was done originally in r218344)
1123         after fixing the issue with the DISPLAY environment variables that
1124         caused the crashes.
1125
1126         * wpe/jhbuild.modules:
1127
1128 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1129
1130         Rename unit test file after r218482
1131         https://bugs.webkit.org/show_bug.cgi?id=173483
1132
1133         Unreviewed.
1134
1135         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
1136
1137 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1138
1139         Unreviewed. Fix wrong style checker condition added in r218487.
1140
1141         * Scripts/webkitpy/style/checkers/cpp.py:
1142         (check_identifier_name_in_declaration):
1143
1144 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
1145
1146         Missing <functional> includes make builds fail with GCC 7.x
1147         https://bugs.webkit.org/show_bug.cgi?id=173544
1148
1149         Unreviewed gardening.
1150
1151         Fix compilation with GCC 7.
1152
1153         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1154         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1155
1156 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1157
1158         [GTK] Move GTK+ API files that could be shared to glib dirs
1159         https://bugs.webkit.org/show_bug.cgi?id=173545
1160
1161         Reviewed by Žan Doberšek.
1162
1163         Update paths of GTK+ API in watchlist and style checker.
1164
1165         * Scripts/webkitpy/common/config/watchlist:
1166         * Scripts/webkitpy/style/checker.py:
1167         * Scripts/webkitpy/style/checkers/cpp.py:
1168         (check_identifier_name_in_declaration):
1169
1170 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1171
1172         Port setup_environ_for_server should not set environment variables related with the driver.
1173         https://bugs.webkit.org/show_bug.cgi?id=173483
1174
1175         Reviewed by Carlos Garcia Campos.
1176
1177         The port setup_environ_for_server() should not set environment variables
1178         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
1179         This varibles should be only set on the driver setup_environ_for_test().
1180
1181         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
1182         into the test environment even when running the tests with a driver
1183         that is not the Xorg or Xvfb one.
1184
1185         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
1186         (Port.to.setup_environ_for_server):
1187         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
1188         (Driver._setup_environ_for_driver):
1189         * Scripts/webkitpy/port/driver_unittest.py:
1190         (DriverTest.test_setup_environ_for_test):
1191         (DriverTest):
1192         (DriverTest.test_setup_environ_base_vars):
1193         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
1194         (GtkPort.setup_environ_for_server):
1195         * Scripts/webkitpy/port/wayland_unittest.py: Added.
1196         (WaylandDriverTest):
1197         (WaylandDriverTest.make_driver):
1198         (WaylandDriverTest.make_environment):
1199         (WaylandDriverTest.test_checkdriver):
1200         (WaylandDriverTest.test_environment_needed_variables):
1201         (WaylandDriverTest.test_environment_forbidden_variables):
1202         (WaylandDriverTest.test_environment_optional_variables):
1203         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
1204         (WaylandDriver.check_driver):
1205         (WaylandDriver._setup_environ_for_test):
1206         * Scripts/webkitpy/port/xorgdriver.py:
1207         (XorgDriver.check_driver):
1208         (XorgDriver._setup_environ_for_test):
1209         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
1210         (XorgDriverTest):
1211         (XorgDriverTest.make_driver):
1212         (XorgDriverTest.make_environment):
1213         (XorgDriverTest.test_checkdriver):
1214         (XorgDriverTest.test_environment_needed_variables):
1215         (XorgDriverTest.test_environment_forbidden_variables):
1216         (XorgDriverTest.test_environment_optional_variables):
1217         * Scripts/webkitpy/port/xvfbdriver.py:
1218         (XvfbDriver._setup_environ_for_test):
1219         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1220         (XvfbDriverTest.assertDriverStartSuccessful):
1221
1222
1223 2017-05-14 Frederic Wang  <fwang@igalia.com>
1224
1225         Add heuristic to avoid flattening "fullscreen" iframes
1226         https://bugs.webkit.org/show_bug.cgi?id=171914
1227
1228         Reviewed by Simon Fraser.
1229
1230         * DumpRenderTree/mac/DumpRenderTree.mm:
1231         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
1232
1233 2017-06-18  Chris Dumez  <cdumez@apple.com>
1234
1235         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
1236         https://bugs.webkit.org/show_bug.cgi?id=173522
1237         <rdar://problem/31185739>
1238
1239         Reviewed by Darin Adler.
1240
1241         Add API test for re-entering Function's assignment operators.
1242
1243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1244         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
1245         (TestWebKitAPI::TestObject::TestObject):
1246         (TestWebKitAPI::TestObject::~TestObject):
1247         (TestWebKitAPI::TestObject::operator()):
1248         (TestWebKitAPI::TEST):
1249
1250 2017-06-16  Dan Bernstein  <mitz@apple.com>
1251
1252         [Cocoa] Some declarations have missing or incorrect availability attributes
1253         https://bugs.webkit.org/show_bug.cgi?id=173508
1254
1255         Reviewed by Tim Horton.
1256
1257         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1258         (TestWebKitAPI::TEST): Updated for renames.
1259
1260 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1261
1262         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
1263         https://bugs.webkit.org/show_bug.cgi?id=173366
1264         <rdar://problem/32767014>
1265
1266         Reviewed by Tim Horton.
1267
1268         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
1269         change in behavior.
1270
1271         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1273         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1274         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1275         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
1276         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
1277         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
1278         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1279         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1280         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1281         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
1282         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
1283         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
1284         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
1285         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1286         (-[MockDragDropSession initWithItems:location:window:]):
1287         (-[MockDragDropSession allowsMoveOperation]):
1288         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1289         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1290         (-[MockDragDropSession canLoadObjectsOfClass:]):
1291         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1292         (-[MockDragDropSession items]):
1293         (-[MockDragDropSession setItems:]):
1294         (-[MockDragDropSession locationInView:]):
1295         (-[MockDataOperationSession initWithProviders:location:window:]):
1296         (-[MockDataOperationSession session]):
1297         (-[MockDataOperationSession isLocal]):
1298         (-[MockDataOperationSession progress]):
1299         (-[MockDataOperationSession setProgressIndicatorStyle:]):
1300         (-[MockDataOperationSession progressIndicatorStyle]):
1301         (-[MockDataOperationSession operationMask]):
1302         (-[MockDataOperationSession localDragSession]):
1303         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
1304         (-[MockDataOperationSession canCreateItemsOfClass:]):
1305         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
1306         (-[MockDataInteractionSession initWithWindow:]):
1307         (-[MockDataInteractionSession localOperationMask]):
1308         (-[MockDataInteractionSession externalOperationMask]):
1309         (-[MockDataInteractionSession session]):
1310         (-[DataInteractionSimulator _advanceProgress]):
1311
1312 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1313
1314         Show punycode to user if a URL has dotless i or j followed by diacritic dot
1315         https://bugs.webkit.org/show_bug.cgi?id=173431
1316
1317         Reviewed by Darin Adler.
1318
1319         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1320         (TestWebKitAPI::TEST):
1321
1322 2017-06-16  Chris Dumez  <cdumez@apple.com>
1323
1324         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
1325         https://bugs.webkit.org/show_bug.cgi?id=173472
1326         <rdar://problem/28858817>
1327
1328         Reviewed by Brady Eidson.
1329
1330         Add API test coverage.
1331
1332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1333         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
1334         (TEST):
1335
1336 2017-06-16  Brady Eidson  <beidson@apple.com>
1337
1338         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
1339         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
1340
1341         Reviewed by Daniel Bates.
1342
1343         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1344
1345 2017-06-16  Chris Dumez  <cdumez@apple.com>
1346
1347         DRT fails to reset page visibility between tests
1348         https://bugs.webkit.org/show_bug.cgi?id=173485
1349
1350         Reviewed by Alexey Proskuryakov.
1351
1352         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
1353         Fix this to address flakiness.
1354
1355         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
1356         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
1357         The test became flaky without the DRT change and was no longer flaky with the DRT
1358         change.
1359
1360         WebKitTestRunner already does this.
1361
1362         * DumpRenderTree/mac/DumpRenderTree.mm:
1363         (resetWebViewToConsistentStateBeforeTesting):
1364
1365 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1366
1367         Implement basic authentication in MiniBrowser
1368         https://bugs.webkit.org/show_bug.cgi?id=173443
1369
1370         Reviewed by Tim Horton.
1371
1372         * MiniBrowser/mac/WK2BrowserWindowController.m:
1373         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1374
1375 2017-06-16  Jer Noble  <jer.noble@apple.com>
1376
1377         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1378         https://bugs.webkit.org/show_bug.cgi?id=173398
1379         <rdar://problem/32592961>
1380
1381         Reviewed by Eric Carlson.
1382
1383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1384         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1385         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1386         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1387         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1388         (TestWebKitAPI::TEST):
1389         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1390
1391 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1392
1393         Unreviewed, rolling out r218375.
1394
1395         The API test MediaStreamTrackDetached is still timing out
1396         after the patch
1397
1398         Reverted changeset:
1399
1400         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1401         reports no recording to WebKit clients"
1402         https://bugs.webkit.org/show_bug.cgi?id=173398
1403         http://trac.webkit.org/changeset/218375
1404
1405 2017-06-15  Jer Noble  <jer.noble@apple.com>
1406
1407         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1408         https://bugs.webkit.org/show_bug.cgi?id=173398
1409         <rdar://problem/32592961>
1410
1411         Reviewed by Eric Carlson.
1412
1413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1414         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1415         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1416         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1417         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1418         (TestWebKitAPI::TEST):
1419         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1420
1421 2017-06-15  Matt Lewis  <jlewis3@apple.com>
1422
1423         Unreviewed, rolling out r218365.
1424
1425         The revision caused API timeouts on all builds.
1426
1427         Reverted changeset:
1428
1429         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1430         reports no recording to WebKit clients"
1431         https://bugs.webkit.org/show_bug.cgi?id=173398
1432         http://trac.webkit.org/changeset/218365
1433
1434 2017-06-15  Jer Noble  <jer.noble@apple.com>
1435
1436         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1437         https://bugs.webkit.org/show_bug.cgi?id=173398
1438         <rdar://problem/32592961>
1439
1440         Reviewed by Eric Carlson.
1441
1442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1443         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1444         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1445         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1446         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1447         (TestWebKitAPI::TEST):
1448         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1449
1450 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1451
1452         REGRESSION(r218344): [WPE] Thousands of layout test crashes
1453         https://bugs.webkit.org/show_bug.cgi?id=173433
1454
1455         Unreviewed.
1456
1457         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
1458
1459 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1460
1461         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
1462         https://bugs.webkit.org/show_bug.cgi?id=173061
1463
1464         Reviewed by Žan Doberšek.
1465
1466         Launch dyz <https://github.com/Igalia/dyz> with the script
1467         run-minibrowser for the wpe port. It is now built as part of the
1468         WPE dependencies with JHBuild.
1469
1470         * Scripts/run-minibrowser:
1471         * Scripts/webkitdirs.pm:
1472         (launcherPath):
1473         (launcherName):
1474         * wpe/install-dependencies: Luajit is needed for building dyz.
1475         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
1476
1477 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1478
1479         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
1480         https://bugs.webkit.org/show_bug.cgi?id=173338
1481         <rdar://problem/32777720>
1482
1483         Reviewed by Tim Horton.
1484
1485         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
1486         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
1487         these remaining items on drop.
1488
1489         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1490         (TestWebKitAPI::TEST):
1491         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1492         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1493
1494         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
1495
1496         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
1497
1498 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
1499
1500         [Win] Crash in accessibility layout test.
1501         https://bugs.webkit.org/show_bug.cgi?id=173401
1502
1503         Reviewed by Brent Fulgham.
1504
1505         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
1506         member will be automatically released when the _variant_t object goes out of scope if the vt member
1507         does not equal VT_UNKNOWN | VT_BYREF.
1508         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
1509
1510         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1511         (AccessibilityUIElement::titleUIElement):
1512
1513 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1514
1515         [GTK] Add API to allow overriding popup menus
1516         https://bugs.webkit.org/show_bug.cgi?id=172905
1517
1518         Reviewed by Michael Catanzaro.
1519
1520         Add a unit test to check the new API.
1521
1522         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1523         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
1524         (OptionMenuTest::OptionMenuTest):
1525         (OptionMenuTest::~OptionMenuTest):
1526         (OptionMenuTest::destroyMenu):
1527         (OptionMenuTest::showOptionMenuCallback):
1528         (OptionMenuTest::menuCloseCallback):
1529         (OptionMenuTest::showOptionMenu):
1530         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
1531         (OptionMenuTest::close):
1532         (OptionMenuTest::activateItem):
1533         (OptionMenuTest::selectItem):
1534         (testOptionMenuSimple):
1535         (testOptionMenuGroups):
1536         (testOptionMenuActivate):
1537         (testOptionMenuSelect):
1538         (beforeAll):
1539         (afterAll):
1540
1541 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1542
1543         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
1544         https://bugs.webkit.org/show_bug.cgi?id=173399
1545
1546         Reviewed by Per Arne Vollan.
1547
1548         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
1549         Curl port needs to do nothing because libcurl doesn't have disk cache.
1550
1551         * DumpRenderTree/win/DumpRenderTree.cpp:
1552         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
1553         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
1554
1555 2017-06-14  Tomas Popela  <tpopela@redhat.com>
1556
1557         [GTK] integer expression expected if running Tools/gtk/install-dependencies
1558         https://bugs.webkit.org/show_bug.cgi?id=173356
1559
1560         Reviewed by Michael Catanzaro.
1561
1562         Use the correct operator to compare the strings.
1563
1564         * gtk/install-dependencies:
1565
1566 2017-06-14  Commit Queue  <commit-queue@webkit.org>
1567
1568         Unreviewed, rolling out r218285.
1569         https://bugs.webkit.org/show_bug.cgi?id=173391
1570
1571         API test fails on iOS (Requested by alexchristensen on
1572         #webkit).
1573
1574         Reverted changeset:
1575
1576         "Add SPI for immediate injection of user scripts"
1577         https://bugs.webkit.org/show_bug.cgi?id=173342
1578         http://trac.webkit.org/changeset/218285
1579
1580 2017-06-14  Chris Dumez  <cdumez@apple.com>
1581
1582         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
1583         https://bugs.webkit.org/show_bug.cgi?id=173384
1584         <rdar://problem/32723779>
1585
1586         Reviewed by Dan Bernstein.
1587
1588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1589         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
1590         Add API test coverage.
1591
1592         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1593         (TestWebKitAPI::Util::sleep):
1594         Update implementation of Util::sleep() so that we actually run the run loop.
1595         Otherwise, we don't process events while sleeping.
1596
1597 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1598
1599         Add SPI for immediate injection of user scripts
1600         https://bugs.webkit.org/show_bug.cgi?id=173342
1601         <rdar://problem/29202285>
1602
1603         Reviewed by Brady Eidson.
1604
1605         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1606         (waitForMessage):
1607         (TEST):
1608
1609 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
1610
1611         Add WPE to the flakiness dashboard
1612         https://bugs.webkit.org/show_bug.cgi?id=173365
1613
1614         Reviewed by Carlos Alberto Lopez Perez.
1615
1616         * TestResultServer/static-dashboards/builders.jsonp:
1617         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1618         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1619         (resetGlobals):
1620         * TestResultServer/static-dashboards/loader_unittests.js:
1621
1622 2017-06-14  Brady Eidson  <beidson@apple.com>
1623
1624         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
1625         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
1626
1627         Reviewed by Alex Christensen.
1628
1629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1630         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
1631         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
1632         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
1633         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
1634         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
1635         (TEST):
1636
1637 2017-06-14  Tim Horton  <timothy_horton@apple.com>
1638
1639         WKContentViewEditingActions API test always fails
1640         https://bugs.webkit.org/show_bug.cgi?id=173374
1641
1642         Reviewed by Wenson Hsieh.
1643
1644         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1645         (TEST):
1646         selectAll isn't working, because canPerformAction for selectAll returns NO
1647         if selectionIsNone (which is true in the non-contenteditable case).
1648         Instead, make use of r218180's test page, which knows how to select itself.
1649         Also, reset the pasteboard at the beginning of the test to reduce confusion
1650         (I landed the test broken because my simulator had the correct text
1651         stuck in its pasteboard).
1652
1653 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
1654
1655         Configure screen scale for running layout tests on plus devices
1656         https://bugs.webkit.org/show_bug.cgi?id=173319
1657
1658         Reviewed by Tim Horton.
1659
1660         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1661         * DumpRenderTree/mac/DumpRenderTree.mm:
1662         (dumpRenderTree): Set screen scale to 2.0.
1663         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
1664         add _setScale for UIScreen.
1665         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1666         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1667         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
1668         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
1669         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
1670         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
1671         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
1672         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
1673         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1674         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
1675
1676 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
1677
1678         Add iOS 11 support to the bot watcher's dashboard
1679         https://bugs.webkit.org/show_bug.cgi?id=173369
1680
1681         Reviewed by Lucas Forschler.
1682
1683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
1684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
1685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
1686         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
1687         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1688         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1689
1690 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1691
1692         [GTK][WPE] Raise the timeout values for layout tests
1693         https://bugs.webkit.org/show_bug.cgi?id=173368
1694
1695         Reviewed by Carlos Garcia Campos.
1696
1697         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
1698         When running under valgrind a 10x multiplier is applied.
1699
1700         * Scripts/webkitpy/port/gtk.py:
1701         (GtkPort.default_timeout_ms):
1702         * Scripts/webkitpy/port/gtk_unittest.py:
1703         (GtkPortTest.test_default_timeout_ms):
1704         * Scripts/webkitpy/port/wpe.py:
1705         (WPEPort.default_timeout_ms):
1706         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
1707         (WPEPortTest):
1708         (WPEPortTest.make_port):
1709         (WPEPortTest.test_default_timeout_ms):
1710         (WPEPortTest.test_get_crash_log):
1711
1712 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1713
1714         Test persistent WKHTTPCookieStorages on iOS.
1715         https://bugs.webkit.org/show_bug.cgi?id=173284
1716
1717         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1718         (TEST):
1719         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
1720
1721 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
1722
1723         [Win] DRT should not use disk cache.
1724         https://bugs.webkit.org/show_bug.cgi?id=173361
1725
1726         Reviewed by Darin Adler.
1727
1728         Like on macOS/iOS, DRT on Windows should only use memory cache.
1729
1730         * DumpRenderTree/win/DumpRenderTree.cpp:
1731         (setDefaultsToConsistentValuesForTesting):
1732         (prepareConsistentTestingEnvironment):
1733
1734 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1735
1736         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
1737         https://bugs.webkit.org/show_bug.cgi?id=171668
1738
1739         Reviewed by Jer Noble.
1740
1741         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
1742         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
1743         Infinity when the double value passed as argument is greater than 2^64.
1744
1745         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
1746         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
1747         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
1748         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
1749         method. No behavior change for rational MediaTime.
1750
1751         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
1752         (TestWebKitAPI::TEST):
1753
1754 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1755
1756         Test persistent WKHTTPCookieStorages on iOS
1757         https://bugs.webkit.org/show_bug.cgi?id=173284
1758         <rdar://problem/32260156>
1759
1760         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1761         (TEST):
1762
1763 2017-06-13  Matt Rajca  <mrajca@apple.com>
1764
1765         WebsitePolicies: let clients select specific autoplay quirks
1766         https://bugs.webkit.org/show_bug.cgi?id=173343
1767
1768         Reviewed by Alex Christensen.
1769
1770         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1771         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1772         (TEST): Updated tests.
1773
1774 2017-06-13  Daniel Bates  <dabates@apple.com>
1775
1776         Implement W3C Secure Contexts Draft Specification
1777         https://bugs.webkit.org/show_bug.cgi?id=158121
1778         <rdar://problem/26012994>
1779
1780         Reviewed by Brent Fulgham.
1781
1782         Part 4
1783
1784         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
1785         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
1786         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
1787
1788         * DumpRenderTree/TestOptions.h:
1789         * DumpRenderTree/TestOptions.mm:
1790         (TestOptions::TestOptions):
1791         * DumpRenderTree/mac/DumpRenderTree.mm:
1792         (setWebPreferencesForTestOptions):
1793         * DumpRenderTree/win/DumpRenderTree.cpp:
1794         (enableExperimentalFeatures):
1795         * WebKitTestRunner/TestController.cpp:
1796         (WTR::TestController::resetPreferencesToConsistentValues):
1797         (WTR::updateTestOptionsFromTestHeader):
1798         * WebKitTestRunner/TestOptions.h:
1799         (WTR::TestOptions::hasSameInitializationOptions):
1800
1801 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1802
1803         Test persistent WKHTTPCookieStorages on iOS
1804         https://bugs.webkit.org/show_bug.cgi?id=173284
1805         <rdar://problem/32260156>
1806
1807         Reviewed by Alexey Proskuryakov.
1808
1809         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1810         (TEST):
1811
1812 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1813
1814         [GTK] Blob download doesn't work
1815         https://bugs.webkit.org/show_bug.cgi?id=172442
1816
1817         Reviewed by Carlos Alberto Lopez Perez.
1818
1819         Add a unit test to check blob downloads.
1820
1821         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1822         (testBlobDownload):
1823         (beforeAll):
1824
1825 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1826
1827         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
1828         https://bugs.webkit.org/show_bug.cgi?id=173316
1829
1830         Reviewed by Alex Christensen.
1831
1832         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
1833
1834         * gtk/manifest.txt.in:
1835
1836 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1837
1838         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
1839         https://bugs.webkit.org/show_bug.cgi?id=173315
1840
1841         Reviewed by Darin Adler.
1842
1843         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
1844         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
1845         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
1846         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
1847         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
1848         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
1849         WKGeolocationManagerRef is not destroyed.
1850
1851         * WebKitTestRunner/GeolocationProviderMock.cpp:
1852         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1853         * WebKitTestRunner/GeolocationProviderMock.h:
1854
1855 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1856
1857         Unable to paste text that was copied from a page into the universal search field
1858         https://bugs.webkit.org/show_bug.cgi?id=173293
1859         <rdar://problem/32440918>
1860
1861         Reviewed by Ryosuke Niwa.
1862
1863         Adds 2 new unit tests for copying plain and rich selected web content.
1864         See WebCore and WebKit ChangeLogs for more detail.
1865
1866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1867         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
1868         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
1869         (TestWebKitAPI::dataForPasteboardType):
1870         (TestWebKitAPI::setUpWebViewForPasteboardTests):
1871         (TestWebKitAPI::TEST):
1872
1873 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
1874
1875         AX: [ATK] Implement missing AtkRelation types
1876         https://bugs.webkit.org/show_bug.cgi?id=155494
1877
1878         Reviewed by Darin Adler.
1879
1880         Add additional methods to test ARIA properties which are exposed via
1881         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
1882
1883         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1884         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1885         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1886         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1887         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1888         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1889         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1890         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1891         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1892         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1893         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1894         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1895         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1896         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1897         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1898         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1899         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1900         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1901
1902 2017-06-12  Daniel Bates  <dabates@apple.com>
1903
1904         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
1905         https://bugs.webkit.org/show_bug.cgi?id=173286
1906         <rdar://problem/32726102>
1907
1908         Reviewed by Brent Fulgham.
1909
1910         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1911         (TestWebKitAPI::TEST_F):
1912
1913 2017-06-12  Lucas Forschler  <lforschler@apple.com>
1914
1915         <rdar://problem/32683422>
1916         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
1917
1918         Reviewed by Conrad Schultz.
1919
1920         * Scripts/copy-webkitlibraries-to-product-directory:
1921
1922 2017-06-12  Tim Horton  <timothy_horton@apple.com>
1923
1924         [iOS] Cmd-C doesn't copy text from WKWebView
1925         https://bugs.webkit.org/show_bug.cgi?id=173277
1926         <rdar://problem/32396742>
1927
1928         Reviewed by Dan Bernstein.
1929
1930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1931         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1932         Add a test ensuring that -copy on WKContentView will cause text to be copied.
1933
1934 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
1935
1936         [WebCrypto] Remove experimental feature flag of SubtleCrypto
1937         https://bugs.webkit.org/show_bug.cgi?id=173197
1938         <rdar://problem/32688148>
1939
1940         Reviewed by Brent Fulgham.
1941
1942         * DumpRenderTree/mac/DumpRenderTree.mm:
1943         (enableExperimentalFeatures):
1944         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1945         (WTR::InjectedBundle::beginTesting):
1946         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1947         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
1948         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1949
1950 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1951
1952         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
1953         https://bugs.webkit.org/show_bug.cgi?id=173238
1954         <rdar://problem/31943370>
1955
1956         Reviewed by Ryosuke Niwa and Tim Horton.
1957
1958         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
1959         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
1960         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
1961
1962         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1963         (TestWebKitAPI::TEST):
1964         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1965         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1966         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
1967         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
1968
1969 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1970
1971         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
1972         https://bugs.webkit.org/show_bug.cgi?id=173225
1973         <rdar://problem/32713144>
1974
1975         Reviewed by Tim Horton.
1976
1977         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
1978         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
1979
1980         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1981         (TestWebKitAPI::TEST):
1982
1983 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
1984
1985         Return correct process names for iOS on-device testing
1986         https://bugs.webkit.org/show_bug.cgi?id=173263
1987
1988         Reviewed by Alex Christensen.
1989
1990         When running tests on iOS devices, process names do not end with '.Development'
1991         as they do on Mac and iOS simulator.
1992
1993         * WebKitTestRunner/TestController.cpp:
1994         (WTR::TestController::webProcessName): Return correct process name without '.Development'
1995         for iOS on-device testing.
1996         (WTR::TestController::networkProcessName): Ditto.
1997         (WTR::TestController::databaseProcessName): Ditto.
1998
1999 2017-06-12  Chris Dumez  <cdumez@apple.com>
2000
2001         Regression(r217867): Legacy SessionHistoryEntryData format should not change
2002         https://bugs.webkit.org/show_bug.cgi?id=173267
2003         <rdar://problem/32701257>
2004
2005         Reviewed by Simon Fraser.
2006
2007         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
2008         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
2009         though as this covers the crash that r217867 was fixing.
2010
2011         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
2012         (TestWebKitAPI::createSessionStateData):
2013         (TestWebKitAPI::TEST):
2014         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
2015
2016 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2017
2018         [GTK] Stop dismissing menus attached to the web view for every injected event
2019         https://bugs.webkit.org/show_bug.cgi?id=172708
2020
2021         Reviewed by Alex Christensen.
2022
2023         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
2024         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
2025         events while the menu is open.
2026
2027         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2028         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
2029         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2030         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
2031
2032 2017-06-12  Miguel Gomez  <magomez@igalia.com>
2033
2034         [GTK][WPE] Enable GStreamer GL on development builds
2035         https://bugs.webkit.org/show_bug.cgi?id=173248
2036
2037         Enable GStreamer GL for GTK and WPE.
2038
2039         Reviewed by Carlos Garcia Campos.
2040
2041         * Scripts/webkitperl/FeatureList.pm:
2042
2043 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2044
2045         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
2046
2047         Notifications are no longer cleared on page navigation.
2048
2049         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2050         (testWebViewNotification):
2051
2052 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2053
2054         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
2055
2056         DBus interface and object path names were updated in r217831.
2057
2058         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
2059
2060 2017-06-10  Dan Bernstein  <mitz@apple.com>
2061
2062         Reverted r218056 because it made the IDE reindex constantly.
2063
2064         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2065         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2066         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2067         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2068         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2069         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2070         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2071         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2072
2073 2017-06-10  Dan Bernstein  <mitz@apple.com>
2074
2075         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
2076         https://bugs.webkit.org/show_bug.cgi?id=173223
2077
2078         Reviewed by Sam Weinig.
2079
2080         The rebuilds were happening due to a difference in the compiler options that the IDE and
2081         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
2082         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
2083         specify an appropriate path in CLANG_INDEX_STORE_PATH.
2084
2085         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2086         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2087         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2088         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2089         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2090         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2091         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2092         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2093
2094 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
2095
2096         webkitpy: Reduce polling in ServerProcess
2097         https://bugs.webkit.org/show_bug.cgi?id=173116
2098
2099         Reviewed by Ryosuke Niwa.
2100
2101         We should be smarter about polling. We do not need to poll every time a line is read from
2102         stdout and stderr since lines are usually read from cached data. We should only poll
2103         when extracting that cached data from stdout and stderr.
2104
2105         * Scripts/webkitpy/port/driver.py:
2106         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
2107         and on ServerProcess to poll the process if not data is available in stdout and stderr.
2108         * Scripts/webkitpy/port/driver_unittest.py:
2109         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
2110         ServerProcess.
2111         * Scripts/webkitpy/port/server_process.py:
2112         (ServerProcess._read): Allow for data to be read from _output even if the process has
2113         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
2114         * Scripts/webkitpy/port/server_process_mock.py:
2115         (MockServerProcess): Add number_of_times_polled.
2116         (MockServerProcess.poll): Increment number_of_times_polled.
2117         (MockServerProcess.has_crashed): Poll before returning crash state.
2118         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
2119         just like a ServerProcess would.
2120         (MockServerProcess.read_stdout): Ditto.
2121         * Scripts/webkitpy/port/server_process_unittest.py:
2122         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
2123         process from ending before stdout and stderr are read. This is the reason this test was flakey.
2124         (TestServerProcess):
2125         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
2126         the processes is polled.
2127         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
2128         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
2129
2130 2017-06-10  Andy Estes  <aestes@apple.com>
2131
2132         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
2133         https://bugs.webkit.org/show_bug.cgi?id=173190
2134         <rdar://problem/31360659>
2135
2136         Reviewed by Brady Eidson.
2137         
2138         Added a release assert that tries to create a proper test failure if the web process crashes.
2139
2140         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2141         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
2142
2143 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2144
2145         [iOS DnD] Add a hook to perform two-step drops in editable content
2146         https://bugs.webkit.org/show_bug.cgi?id=172992
2147         <rdar://problem/32590174>
2148
2149         Reviewed by Tim Horton.
2150
2151         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
2152         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
2153                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
2154
2155         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2156         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2157         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
2158
2159         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
2160         be overridden. Currently, this is overridden to just return true.
2161
2162         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2163         (TestWebKitAPI::TEST):
2164         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2165         (WTR::InjectedBundlePage::InjectedBundlePage):
2166
2167 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2168
2169         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
2170         https://bugs.webkit.org/show_bug.cgi?id=173103
2171
2172         Reviewed by Xabier Rodriguez-Calvar.
2173
2174         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
2175         when building the WPE port through build-webkit.
2176
2177 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2178
2179         [WPE] Enable MEDIA_SOURCE for build-webkit builds
2180         https://bugs.webkit.org/show_bug.cgi?id=173136
2181
2182         Reviewed by Xabier Rodriguez-Calvar.
2183
2184         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
2185
2186 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2187
2188         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
2189         https://bugs.webkit.org/show_bug.cgi?id=173098
2190
2191         Reviewed by Žan Doberšek.
2192
2193         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
2194         assuming that all tests containing forms define ids for the form elements like
2195         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
2196
2197         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2198         (formControlsAssociatedCallback):
2199
2200 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
2201
2202         webkitpy: Run sample/spindump on iOS devices
2203         https://bugs.webkit.org/show_bug.cgi?id=171881
2204         <rdar://problem/32084602>
2205
2206         Reviewed by Daniel Bates.
2207
2208         * Scripts/webkitpy/port/darwin.py:
2209         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
2210         requires sudo to run spindump.
2211         * Scripts/webkitpy/port/ios_device.py:
2212         (IOSDevicePort.look_for_new_samples): Deleted.
2213         (IOSDevicePort.sample_process): Deleted.
2214         * Scripts/webkitpy/port/ios_device_unittest.py:
2215         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
2216         (IOSDeviceTest.test_spindump):
2217         (IOSDeviceTest.test_sample_process):
2218         (IOSDeviceTest.test_sample_process_exception):
2219         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2220         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
2221
2222 2017-06-08  Keith Miller  <keith_miller@apple.com>
2223
2224         WebAssembly: We should only create wrappers for functions that can be exported
2225         https://bugs.webkit.org/show_bug.cgi?id=173088
2226
2227         Reviewed by Saam Barati.
2228
2229         Add quick mode for wasm tests.
2230
2231         * Scripts/run-jsc-stress-tests:
2232
2233 2017-06-08  Darin Adler  <darin@apple.com>
2234
2235         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
2236         https://bugs.webkit.org/show_bug.cgi?id=173106
2237
2238         Reviewed by Sam Weinig.
2239
2240         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
2241         destroyed last.
2242         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
2243         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2244
2245 2017-06-07  Dan Bernstein  <mitz@apple.com>
2246
2247         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
2248         https://bugs.webkit.org/show_bug.cgi?id=173086
2249
2250         Reviewed by Andy Estes.
2251
2252         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2253         (TEST):
2254
2255 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
2256
2257         Add High Sierra support to WebKit tools
2258         https://bugs.webkit.org/show_bug.cgi?id=173080
2259
2260         Rubber-stamped by Daniel Bates.
2261
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
2264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2266         Added dashboard support.
2267
2268         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2269         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2270         Trigger the right build queues on check-in.
2271
2272         * Scripts/webkitpy/common/system/platforminfo.py:
2273         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2274         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2275         * Scripts/webkitpy/port/mac.py:
2276         * Scripts/webkitpy/port/mac_unittest.py:
2277         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2278         Added cases for Sierra, and updated tests for new baseline search paths.
2279
2280 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
2281
2282         Unreviewed, rolling out r217902.
2283
2284         This change appears to have caused imported/w3c/web-platform-
2285         tests/fetch/api/cors tests to fail on El Capitan.
2286
2287         Reverted changeset:
2288
2289         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
2290         https://bugs.webkit.org/show_bug.cgi?id=172930
2291         http://trac.webkit.org/changeset/217902
2292
2293 2017-06-07  Daniel Bates  <dabates@apple.com>
2294
2295         Teach run-webkit-tests how to run HTTPS Web Platform Tests
2296         https://bugs.webkit.org/show_bug.cgi?id=172930
2297         <rdar://problem/32570201>
2298
2299         Reviewed by Youenn Fablet.
2300
2301         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
2302         that is conditioned on the page being delivered over a secure protocol. One example of such
2303         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
2304
2305         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
2306         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
2307         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
2308
2309         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2310         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
2311         to the Web Platform Tests HTTPS server.
2312         * Scripts/webkitpy/port/base.py:
2313         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
2314         * Scripts/webkitpy/port/driver.py:
2315         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
2316         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
2317         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
2318         indicate that they should be considered private instance variables.
2319         (Driver.is_web_platform_test): Update code for renamed instance variables.
2320         (Driver):
2321         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
2322         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
2323         determine the base URL to use to access the test.
2324         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
2325         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
2326
2327 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
2328
2329         Support removal of authentication data through the Website data store API.
2330         https://bugs.webkit.org/show_bug.cgi?id=171217
2331
2332         Reviewed by Brady Eidson.
2333
2334         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2335         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2336         (WTR::InjectedBundle::didReceiveMessageToPage):
2337         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2338         (WTR::TestRunner::removeAllSessionCredentials):
2339         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
2340         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2341         * WebKitTestRunner/TestController.h:
2342         * WebKitTestRunner/TestInvocation.cpp:
2343         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2344         (WTR::TestInvocation::didRemoveAllSessionCredentials):
2345         * WebKitTestRunner/TestInvocation.h:
2346         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2347         (WTR::TestController::removeAllSessionCredentials):
2348
2349 2017-06-07  Charlie Turner  <cturner@igalia.com>
2350
2351         Add Charlie Turner as contributor
2352         https://bugs.webkit.org/show_bug.cgi?id=173055
2353
2354         Reviewed by Carlos Alberto Lopez Perez.
2355
2356         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
2357         of webkit-patch upload, which reordered some fields and removed a newline.
2358
2359         * Scripts/webkitpy/common/config/contributors.json:
2360
2361 2017-06-06  Chris Dumez  <cdumez@apple.com>
2362
2363         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
2364         https://bugs.webkit.org/show_bug.cgi?id=173033
2365         <rdar://problem/32591099>
2366
2367         Reviewed by Simon Fraser.
2368
2369         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
2370         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
2371
2372         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2373         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
2374         (TestWebKitAPI::didFinishLoadForFrame):
2375         (TestWebKitAPI::setPageLoaderClient):
2376         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
2377         (TestWebKitAPI::TEST):
2378
2379 2017-06-06  Andy Estes  <aestes@apple.com>
2380
2381         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
2382         https://bugs.webkit.org/show_bug.cgi?id=172849
2383         <rdar://problem/32567454>
2384
2385         Reviewed by Darin Adler.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
2389         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2390         (TestWebKitAPI::TEST):
2391
2392 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
2393
2394         [preload] Conditional support for media preloading and align media `as` values.
2395         https://bugs.webkit.org/show_bug.cgi?id=172501
2396
2397         Reviewed by Dean Jackson.
2398
2399         Turn on media preloading preference for tests.
2400
2401         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
2402         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
2403         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
2404
2405 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2406
2407         webkitpy: Return correct process names from SimulatorProcess
2408         https://bugs.webkit.org/show_bug.cgi?id=172940
2409
2410         Reviewed by Aakash Jain.
2411
2412         * Scripts/webkitpy/port/darwin.py:
2413         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
2414         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
2415         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
2416         * Scripts/webkitpy/port/driver.py:
2417         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
2418         _server_process.name() will not return the correct process name for iOS.
2419         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2420         (Driver._read_block): Ditto.
2421         * Scripts/webkitpy/port/driver_unittest.py:
2422         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
2423         process_name() instead of name().
2424         * Scripts/webkitpy/port/server_process.py:
2425         (ServerProcess._start): Use process_name() instead of name().
2426         (ServerProcess.stop): Ditto.
2427         (ServerProcess.name): Deleted.
2428         * Scripts/webkitpy/port/simulator_process.py:
2429         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2430
2431 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
2432
2433         test-webkitpy: stop forking unsafely from within a spawned process
2434         https://bugs.webkit.org/show_bug.cgi?id=172774
2435
2436         Reviewed by Darin Adler.
2437
2438         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2439         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
2440         it's going to be used.
2441         (Builder.force_build):
2442
2443 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2444
2445         webkitpy: Process crash-logs for iOS devices
2446         https://bugs.webkit.org/show_bug.cgi?id=171976
2447         <rdar://problem/32134551>
2448
2449         Reviewed by David Kilzer.
2450
2451         When running layout tests on an iOS device, crash logs should be processed.
2452         Implement crash log searching and parsing for iOS devices.
2453
2454         * Scripts/webkitpy/common/system/crashlogs.py:
2455         (CrashLogs): Moved process regular expression for Darwin to class variable.
2456         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
2457         (CrashLogs.find_newest_log): Add iOS as a potential platform.
2458         (CrashLogs.find_all_logs): Ditto.
2459         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
2460         Do not assume that a Darwin crash log starts with the process.
2461         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
2462         shared code for parsing Darwin crash logs.
2463         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
2464         object so that crash logs already on the system before testing are not parsed.
2465         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
2466         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
2467         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
2468         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2469         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
2470         * Scripts/webkitpy/common/system/systemhost.py:
2471         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2472         systems is just the crashlog, use this behavior by default.
2473         * Scripts/webkitpy/common/system/systemhost_mock.py:
2474         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2475         systems is just the crashlog, use this behavior by default.
2476         * Scripts/webkitpy/port/apple.py:
2477         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
2478         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
2479         the system before testing begins
2480         * Scripts/webkitpy/port/base.py:
2481         (Port._get_crash_log): Pass optional target host when getting crash logs.
2482         * Scripts/webkitpy/port/darwin.py:
2483         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
2484         CrashLogs object.
2485         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2486         logs to be skipped to CrashLogs object.
2487         * Scripts/webkitpy/port/darwin_testcase.py:
2488         (DarwinTest.test_get_crash_log): Removed unused local function.
2489         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
2490         * Scripts/webkitpy/port/device.py:
2491         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
2492         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
2493         * Scripts/webkitpy/port/driver.py:
2494         (Driver._get_crash_log): Pass optional target host when getting crash logs.
2495         * Scripts/webkitpy/port/gtk.py:
2496         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
2497         * Scripts/webkitpy/port/ios.py: Ditto.
2498         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
2499         to be skipped for each host.
2500         * Scripts/webkitpy/port/ios_device.py:
2501         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
2502         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
2503         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
2504         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
2505         host is specified. Else, search all connected devices for the specified crash-log.
2506         (IOSDevicePort.look_for_new_crash_logs): Deleted.
2507         * Scripts/webkitpy/port/ios_device_unittest.py:
2508         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
2509         (IOSDeviceTest.test_get_crash_log): Ditto.
2510         * Scripts/webkitpy/port/simulator_process.py:
2511         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2512         * Scripts/webkitpy/port/win.py:
2513         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2514         logs to be skipped to CrashLogs object.
2515         * Scripts/webkitpy/port/wpe.py:
2516         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
2517
2518 2017-06-06  David Kilzer  <ddkilzer@apple.com>
2519
2520         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
2521         <https://webkit.org/b/172804>
2522
2523         Reviewed by Darin Adler.
2524
2525         WTF_ATTRIBUTE_PRINTF() only works outside the current
2526         compilation unit if it's on the declaration, not the
2527         implementation, of a function or class method.
2528
2529         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2530         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2531         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2532         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2533         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
2534         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2535         - Remove redundant CRASH() macro definition.  Use the one from
2536           <wtf/Assertions.h> instead.
2537
2538 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
2539
2540         Move Resource Timing / User Timing from experimental features into main preferences
2541         https://bugs.webkit.org/show_bug.cgi?id=172950
2542
2543         Reviewed by Darin Adler.
2544
2545         * DumpRenderTree/mac/DumpRenderTree.mm:
2546         (enableExperimentalFeatures):
2547         (resetWebPreferencesToConsistentValues):
2548         * DumpRenderTree/win/DumpRenderTree.cpp:
2549         (enableExperimentalFeatures):
2550         (resetWebPreferencesToConsistentValues):
2551         * WebKitTestRunner/TestController.cpp:
2552         (WTR::TestController::resetPreferencesToConsistentValues):
2553         Move out no longer experimental features to the main list.
2554
2555 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2556
2557         [WPE] Add an install-dependencies script
2558         https://bugs.webkit.org/show_bug.cgi?id=172948
2559
2560         Reviewed by Žan Doberšek.
2561
2562         It is based on the gtk/install-dependencies script.
2563         Includes support for Debian based distrubutions, Fedora and Arch.
2564         It has been tested on a minimal Debian 9 chroot.
2565
2566         * wpe/install-dependencies: Added.
2567
2568 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2569
2570         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
2571         https://bugs.webkit.org/show_bug.cgi?id=172891
2572         <rdar://problem/32204540>
2573
2574         Reviewed by Darin Adler.
2575
2576         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
2577         contenteditable. See WebCore ChangeLog for more details.
2578
2579         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2580         (TestWebKitAPI::TEST):
2581
2582 2017-06-05  Daniel Bates  <dabates@apple.com>
2583
2584         webkitpy: Abstract Executive class
2585         https://bugs.webkit.org/show_bug.cgi?id=172928
2586         <rdar://problem/32569531>
2587
2588         Reviewed by Ryosuke Niwa.
2589
2590         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
2591         This will make it straightforward to create additional derived classes that
2592         adhere to the same interface, say for iOS on-device testing.
2593
2594         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
2595         (AbstractExecutive):
2596         (AbstractExecutive.run_and_throw_if_fail):
2597         (AbstractExecutive.cpu_count):
2598         (AbstractExecutive.interpreter_for_script):
2599         (AbstractExecutive.shell_command_for_script):
2600         (AbstractExecutive.kill_process):
2601         (AbstractExecutive.check_running_pid):
2602         (AbstractExecutive.running_pids):
2603         (AbstractExecutive.wait_newest):
2604         (AbstractExecutive.wait_limited):
2605         (AbstractExecutive.interrupt):
2606         (AbstractExecutive.default_error_handler):
2607         (AbstractExecutive.ignore_error):
2608         (AbstractExecutive._stringify_args):
2609         (AbstractExecutive.command_for_printing):
2610         (AbstractExecutive.run_command):
2611         (AbstractExecutive.popen):
2612         (AbstractExecutive.run_in_parallel):
2613         * Scripts/webkitpy/common/system/executive.py:
2614         (Executive):
2615         (Executive.cpu_count):
2616         (Executive.running_pids):
2617         (Executive.kill_all):
2618         (Executive._compute_stdin):
2619         (Executive.interpreter_for_script): Deleted.
2620         (Executive.shell_command_for_script): Deleted.
2621         (Executive.wait_newest): Deleted.
2622         (Executive.wait_limited): Deleted.
2623         (Executive.default_error_handler): Deleted.
2624         (Executive.ignore_error): Deleted.
2625         (Executive.command_for_printing): Deleted.
2626
2627 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
2628
2629         webkitpy: Add iOS to platform
2630         https://bugs.webkit.org/show_bug.cgi?id=172931
2631
2632         Reviewed by Daniel Bates.
2633
2634         * Scripts/webkitpy/common/system/platforminfo.py:
2635         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
2636         (PlatformInfo.is_ios): Added.
2637         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
2638         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2639         (MockPlatformInfo.is_ios): Added.
2640
2641 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2642
2643         [WPE][JHBuild] Switch github repository from git:// to https://
2644         https://bugs.webkit.org/show_bug.cgi?id=172921
2645
2646         Reviewed by Alex Christensen.
2647
2648         * wpe/jhbuild.modules:
2649
2650 2017-06-05  Tim Horton  <timothy_horton@apple.com>
2651
2652         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
2653         https://bugs.webkit.org/show_bug.cgi?id=172887
2654         <rdar://problem/32546061>
2655
2656         Reviewed by Sam Weinig.
2657
2658         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2659         (WTR::UIScriptController::applyAutocorrection):
2660         applyAutocorrection can call its completion handler synchronously,
2661         which makes UIScriptController unhappy (see bug 172884).
2662
2663 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
2664
2665         webkitpy: Add contextmanager to disable logging for a block
2666         https://bugs.webkit.org/show_bug.cgi?id=172876
2667
2668         Reviewed by Daniel Bates.
2669
2670         Add a context manager which will use an OutputCapture object to capture logging
2671         in a block and hold it in a variable.
2672
2673         * Scripts/webkitpy/common/system/outputcapture.py:
2674         (OutputCaptureScope):
2675         (OutputCaptureScope.__init__): Construct with OutputCapture object.
2676         (OutputCaptureScope.__enter__): Begin capturing output. 
2677         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
2678         output and retain the resulting log.
2679         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2680         (OutputCaptureTest.test_output_capture_scope): Added.
2681
2682 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2683
2684         Cleanup FrameView::autoSizeIfEnabled.
2685         https://bugs.webkit.org/show_bug.cgi?id=172889
2686         <rdar://problem/32550783>
2687
2688         Reviewed by Tim Horton.
2689
2690         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2691         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
2692         (TEST):
2693
2694 2017-06-02  Chris Dumez  <cdumez@apple.com>
2695
2696         ResourceLoadStatistics are not using unique paths during test runs
2697         https://bugs.webkit.org/show_bug.cgi?id=172861
2698         <rdar://problem/32442251>
2699
2700         Reviewed by Darin Adler.
2701
2702         Make sure WebKitTestRunner sets a temporary path for saving resource
2703         load statistics.
2704
2705         * WebKitTestRunner/TestController.cpp:
2706         (WTR::TestController::generateContextConfiguration):
2707
2708 2017-06-02  Brady Eidson  <beidson@apple.com>
2709
2710         Prevent scheme handlers from handling all built-in URL schemes.
2711         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
2712
2713         Reviewed by Andy Estes.
2714
2715         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2716
2717 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
2718
2719         [JSCOnly] Build static jsc.exe on Windows
2720         https://bugs.webkit.org/show_bug.cgi?id=172833
2721
2722         Reviewed by Konstantin Tokarev.
2723
2724         * CMakeLists.txt:
2725         * Scripts/build-jsc:
2726
2727 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2728
2729         Disable ViewportSizeForViewportUnits tests on iOS.
2730         https://bugs.webkit.org/show_bug.cgi?id=172872
2731
2732         Reviewed by Tim Horton.
2733
2734         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
2735
2736 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2737
2738         Allow clients to override viewport size for CSS viewport units.
2739         https://bugs.webkit.org/show_bug.cgi?id=172838
2740         <rdar://problem/32523441>
2741
2742         Reviewed by Tim Horton.
2743
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
2746         (TEST):
2747
2748 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
2749
2750         Get <chrono> out of StdLibExtras.h
2751         https://bugs.webkit.org/show_bug.cgi?id=172744
2752
2753         Reviewed by Zalan Bujtas.
2754
2755         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2756
2757 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
2758
2759         [WPE] Enable SUBTLE_CRYPTO
2760         https://bugs.webkit.org/show_bug.cgi?id=172756
2761
2762         Reviewed by Michael Catanzaro.
2763
2764         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
2765         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
2766         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
2767         exhausting entropy when running the crypto layout tests.
2768
2769 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2770
2771         [GTK] Bump GTK+ and its dependencies in jhbuild
2772         https://bugs.webkit.org/show_bug.cgi?id=171918
2773
2774         Reviewed by Carlos Alberto Lopez Perez.
2775
2776         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2777         (WTR::initializeGtkSettings):
2778         * gtk/jhbuild.modules:
2779         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
2780         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
2781
2782 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2783
2784         [GTK] Bump wayland and weston in jhbuild
2785         https://bugs.webkit.org/show_bug.cgi?id=171921
2786
2787         Reviewed by Carlos Alberto Lopez Perez.
2788
2789         * gtk/jhbuild.modules:
2790         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
2791
2792 2017-06-01  Andy Estes  <aestes@apple.com>
2793
2794         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
2795         https://bugs.webkit.org/show_bug.cgi?id=172828
2796
2797         Reviewed by Beth Dakin.
2798
2799         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2800
2801 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2802
2803         webkitpy: Remove unneeded simulator teardown
2804         https://bugs.webkit.org/show_bug.cgi?id=171891
2805
2806         Reviewed by Aakash Jain.
2807
2808         * Scripts/webkitpy/port/ios_simulator.py:
2809         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
2810         for communication between Python and WebKitTestRunner/DumpRenderTree.
2811
2812 2017-06-01  Keith Miller  <keith_miller@apple.com>
2813
2814         Undo rollout in r217638 with bug fix
2815         https://bugs.webkit.org/show_bug.cgi?id=172824
2816
2817         Unreviewed, reland patch with unused set_state code removed.
2818
2819         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2820         (runThreadMessageTest):
2821         (TEST):
2822
2823 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2824
2825         webkitpy: Do not send 0 or -1 as a pid to kill_process
2826         https://bugs.webkit.org/show_bug.cgi?id=172818
2827
2828         Reviewed by Darin Adler.
2829
2830         Sending a signal to process 0 will result in all processes in the group receiving 
2831         the signal. Sending a signal to process -1 will result in all non-system processes
2832         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
2833         should consider these cases
2834
2835         * Scripts/webkitpy/common/system/executive.py:
2836         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
2837         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
2838         never be running, although os.kill may succeed.
2839         * Scripts/webkitpy/port/simulator_process.py:
2840         (SimulatorProcess.stop): Do not kill process if it is undefined.
2841
2842 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
2843
2844         JSC EWS bot does not run on WTF only patches
2845         https://bugs.webkit.org/show_bug.cgi?id=172777
2846         rdar://problem/32495975
2847
2848         Reviewed by Aakash Jain.
2849
2850         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
2851         (CheckPatchRelevance): Add a missing comma.
2852
2853 2017-05-31  Commit Queue  <commit-queue@webkit.org>
2854
2855         Unreviewed, rolling out r217611 and r217631.
2856         https://bugs.webkit.org/show_bug.cgi?id=172785
2857
2858         "caused wasm-hashset-many.html to become flaky." (Requested by
2859         keith_miller on #webkit).
2860
2861         Reverted changesets:
2862
2863         "Reland r216808, underlying lldb bug has been fixed."
2864         https://bugs.webkit.org/show_bug.cgi?id=172759
2865         http://trac.webkit.org/changeset/217611
2866
2867         "Use dispatch queues for mach exceptions"
2868         https://bugs.webkit.org/show_bug.cgi?id=172775
2869         http://trac.webkit.org/changeset/217631
2870
2871 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2872
2873         EWS bots should reboot themselves more frequently
2874         https://bugs.webkit.org/show_bug.cgi?id=172402
2875
2876         Reviewed by Alexey Proskuryakov.
2877
2878         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
2879
2880         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
2881
2882 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2883
2884         Reallocate hardware for iOS bots.
2885         https://bugs.webkit.org/show_bug.cgi?id=172657
2886
2887         Reviewed by Alexey Proskuryakov.
2888
2889         * BuildSlaveSupport/build.webkit.org-config/config.json:
2890
2891 2017-05-31  Andy Estes  <aestes@apple.com>
2892
2893         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
2894         https://bugs.webkit.org/show_bug.cgi?id=172366
2895
2896         Reviewed by Daniel Bates.
2897
2898         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2899
2900 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
2901
2902         Unreviewed, add Jiewen Tan as a reviewer
2903
2904         * Scripts/webkitpy/common/config/contributors.json:
2905
2906 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
2907
2908         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
2909         https://bugs.webkit.org/show_bug.cgi?id=172770
2910
2911         Reviewed by Michael Catanzaro.
2912
2913         * MiniBrowser/gtk/BrowserWindow.c:
2914         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
2915         which caused the body of the if-clause to be accidentally empty.
2916
2917 2017-05-31  Keith Miller  <keith_miller@apple.com>
2918
2919         Reland r216808, underlying lldb bug has been fixed.
2920         https://bugs.webkit.org/show_bug.cgi?id=172759
2921
2922         Unreviewed, relanding old patch. See: rdar://problem/31183352
2923
2924         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2925         (runThreadMessageTest):
2926         (TEST):
2927
2928 2017-05-31  Matt Lewis  <jlewis3@apple.com>
2929
2930         Unreviewed, rolling out r217603.
2931
2932         This patch broke the internal builds.
2933
2934         Reverted changeset:
2935
2936         "Get <chrono> out of StdLibExtras.h"
2937         https://bugs.webkit.org/show_bug.cgi?id=172744
2938         http://trac.webkit.org/changeset/217603
2939
2940 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
2941
2942         Make ResourceLoadStatistics testing more reliable
2943         https://bugs.webkit.org/show_bug.cgi?id=172730
2944         <rdar://problem/32028373>
2945
2946         Reviewed by Andy Estes.
2947
2948         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
2949         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
2950
2951         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2952         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2953
2954 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2955
2956         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
2957         https://bugs.webkit.org/show_bug.cgi?id=172757
2958
2959         Reviewed by Xabier Rodriguez-Calvar.
2960
2961         When needed, add the jhbuild wrapper at the beginning of the array
2962         that will be invoked to execute the run-jsc-stress-test or testapi
2963         commands.
2964
2965         * Scripts/run-javascriptcore-tests:
2966         (runJSCStressTests):
2967         * Scripts/webkitdirs.pm:
2968         (shouldUseJhbuild):
2969
2970 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
2971
2972         Get <chrono> out of StdLibExtras.h
2973         https://bugs.webkit.org/show_bug.cgi?id=172744
2974
2975         Reviewed by Saam Barati.
2976
2977         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2978
2979 2017-05-30  Tim Horton  <timothy_horton@apple.com>
2980
2981         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
2982         https://bugs.webkit.org/show_bug.cgi?id=172735
2983         <rdar://problem/32015977>
2984
2985         Reviewed by Enrica Casucci.
2986
2987         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2988         (WTR::UIScriptController::applyAutocorrection):
2989         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2990         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2991         (WTR::UIScriptController::applyAutocorrection):
2992         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2993         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2994         (WTR::UIScriptController::applyAutocorrection):
2995         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
2996         because I don't know how to tap the button in the autocorrection bar from a test.
2997
2998 2017-05-30  Daniel Bates  <dabates@apple.com>
2999
3000         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
3001         https://bugs.webkit.org/show_bug.cgi?id=172671
3002
3003         Reviewed by Alex Christensen.
3004
3005         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
3006         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
3007
3008         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
3009         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
3010         to trigger a navigation to test it.
3011         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
3012         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
3013
3014 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
3015
3016         webkitpy: Start servers before setting-up for testing
3017         https://bugs.webkit.org/show_bug.cgi?id=172176
3018         <rdar://problem/32225538>
3019
3020         Reviewed by Alexey Proskuryakov.
3021
3022         On-device testing requires that servers are started before ports set-up their
3023         test environments.
3024
3025         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3026         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3027         Servers are unconditionally stopped on exit.
3028         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
3029         Manager now stops servers.
3030         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
3031         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
3032         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3033         (Manager.__init__): Delay construction of the test runner until we can determine
3034         if servers need to be started.
3035         (Manager.run): Determine if servers need to be started and construct the test runner.
3036         Shut servers down when the test run is finished.
3037         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3038         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3039         (is_wpt_server_running): Server is not running if no config is found.
3040         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3041         (PyWebSocket.is_running): Check if this WebSocket server is running.
3042         * Scripts/webkitpy/port/base.py:
3043         (Port.__init__): Define secure WebSocket server.
3044         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
3045
3046 2017-05-30  Daniel Bates  <dabates@apple.com>
3047
3048         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
3049         https://bugs.webkit.org/show_bug.cgi?id=172603
3050         <rdar://problem/32471306>
3051
3052         Reviewed by Brady Eidson.
3053
3054         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
3055         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
3056         unloading is initiated for a page that registered a onbeforeunload handler.
3057
3058         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
3059         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
3060         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
3061
3062         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
3063         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
3064         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
3065         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
3066
3067         * MiniBrowser/mac/WK2BrowserWindowController.m:
3068         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3069         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
3070         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
3071         (sawDialog):
3072         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3073         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3074         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3075
3076 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3077
3078         Update libwebrtc configuration
3079         https://bugs.webkit.org/show_bug.cgi?id=172727
3080
3081         Reviewed by Geoffrey Garen.
3082
3083         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3084
3085 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3086
3087         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
3088         https://bugs.webkit.org/show_bug.cgi?id=172702
3089
3090         Reviewed by Alex Christensen.
3091
3092         EGL PlatformDisplay needs to be shut down before existing a
3093         program on Windows.
3094
3095         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
3096         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
3097         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3098         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
3099
3100 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3101
3102         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3103         https://bugs.webkit.org/show_bug.cgi?id=172709
3104
3105         Reviewed by Brent Fulgham.
3106
3107         Exit fullscreen mode after a fullscreen test.
3108
3109         * DumpRenderTree/win/DumpRenderTree.cpp:
3110         (resetWebViewToConsistentStateBeforeTesting):
3111
3112 2017-05-30  Antti Koivisto  <antti@apple.com>
3113
3114         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
3115         https://bugs.webkit.org/show_bug.cgi?id=172713
3116
3117         Reviewed by Zalan Bujtas.
3118
3119         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3120         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
3121
3122             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
3123             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
3124             because on Mac WK1 it may get invoked from middle of a layout.
3125
3126             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
3127
3128 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3129
3130         Add a WPE EWS queue
3131         https://bugs.webkit.org/show_bug.cgi?id=172693
3132
3133         Reviewed by Carlos Garcia Campos.
3134
3135         * QueueStatusServer/config/queues.py:
3136         * QueueStatusServer/model/queues.py: Capitalize the name of the
3137         port on the tooltip of the bubbles. Do the same for the GTK port.
3138         (Queue.display_name):
3139         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
3140         for the GTK+ EWS also. Set for both ports as watcher the alias
3141         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
3142         * Scripts/webkitpy/common/config/ports.py:
3143         (DeprecatedPort.port):
3144         (WpePort):
3145         (WpePort.build_webkit_command):
3146         (WpePort.run_webkit_tests_command):
3147         * Scripts/webkitpy/common/config/ports_unittest.py:
3148         (DeprecatedPortTest):
3149         (DeprecatedPortTest.test_wpe_port):
3150         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3151         (test_ews_name):
3152
3153 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
3154
3155         Unreviewed. Bumping the WPEBackend-mesa dependency version.
3156
3157         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
3158         priorities for IPC communication.
3159
3160 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
3161
3162         [JSC] Map and Set constructors should have fast path for cloning
3163         https://bugs.webkit.org/show_bug.cgi?id=172413
3164
3165         Reviewed by Saam Barati.
3166
3167         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3168         (TestWebKitAPI::TEST):
3169
3170 2017-05-27  Zalan Bujtas  <zalan@apple.com>
3171
3172         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
3173         https://bugs.webkit.org/show_bug.cgi?id=172676
3174
3175         Reviewed by Simon Fraser.
3176
3177         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3178         (TestWebKitAPI::TEST):
3179
3180 2017-05-26  Zalan Bujtas  <zalan@apple.com>
3181
3182         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
3183         https://bugs.webkit.org/show_bug.cgi?id=172674
3184
3185         Reviewed by Simon Fraser.
3186
3187         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3188         (TestWebKitAPI::TEST):
3189
3190 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3191
3192         Add test resources back into TestWebKitAPI Copy Resources phase
3193
3194         Rubber-stamped by Beth Dakin.
3195
3196         Add two files back into the Copy Resources phase after they were unintentionally
3197         removed in r217447 and r217496.
3198
3199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3200
3201 2017-05-26  Beth Dakin  <bdakin@apple.com>
3202
3203         Media documents inside iframes should not get controls in the TouchBar unless the 
3204         video is playing
3205         https://bugs.webkit.org/show_bug.cgi?id=172620
3206         -and corresponding-
3207         rdar://problem/32165477
3208
3209         Reviewed by Jon Lee.
3210
3211         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3212         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3213         (TestWebKitAPI::TEST):
3214         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
3215
3216 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
3217
3218         _WKUserStyleSheet and WKUserScript leak string data
3219         https://bugs.webkit.org/show_bug.cgi?id=172583
3220         <rdar://problem/32395209>
3221
3222         Reviewed by Sam Weinig.
3223
3224         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3225         We should not have been adopting an autoreleased object.
3226
3227 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
3228
3229         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
3230         https://bugs.webkit.org/show_bug.cgi?id=172554
3231         <rdar://problem/31247133>
3232
3233         Reviewed by Simon Fraser.
3234
3235         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
3236         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
3237         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
3238         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
3239         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
3240         codepath.
3241
3242         * DumpRenderTree/TestOptions.h:
3243         * DumpRenderTree/TestOptions.mm:
3244         (TestOptions::TestOptions):
3245         (TestOptions::webViewIsCompatibleWithOptions):
3246         * DumpRenderTree/mac/DumpRenderTree.mm:
3247         (shouldIgnoreWebCoreNodeLeaks):
3248         (allowedFontFamilySet):
3249         (-[DRTMockScroller rectForPart:]):
3250         (-[DRTMockScroller drawKnob]):
3251         (-[DRTMockScroller drawRect:]):
3252         (createWebViewAndOffscreenWindow):
3253         (initializeGlobalsFromCommandLineOptions):
3254         (prepareConsistentTestingEnvironment):
3255         (dumpRenderTree):
3256         (dumpAudio):
3257         (dumpHistoryItem):
3258         (dumpBackForwardListForWebView):
3259         (resetWebViewToConsistentStateBeforeTesting):
3260         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
3261         (runTest):
3262
3263 2017-05-25  Sam Weinig  <sam@webkit.org>
3264
3265         [WebIDL] Use the term 'operation' more consistently
3266         https://bugs.webkit.org/show_bug.cgi?id=172601
3267
3268         Reviewed by Chris Dumez.
3269
3270         We were using the term 'operation', a WebIDL term for function-like
3271         constructs, inconsistently in the code generator. Now, when we use
3272         'operation' when referring to the IDL concept (usually the object the
3273         parser produces) and 'function' when referring to code being generated.
3274
3275         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3276         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3277
3278 2017-05-25  Jer Noble  <jer.noble@apple.com>
3279
3280         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
3281
3282         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
3283
3284 2017-05-25  Jer Noble  <jer.noble@apple.com>
3285
3286         System sleeps while playing to wireless target, ending stream.
3287         https://bugs.webkit.org/show_bug.cgi?id=172541
3288
3289         Reviewed by Eric Carlson.
3290
3291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3292         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
3293         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
3294         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3295         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3296         (TestWebKitAPI::simulateKeyDown):
3297         (TestWebKitAPI::hasAssertionType):
3298         (TestWebKitAPI::TEST):
3299
3300 2017-05-25  Commit Queue  <commit-queue@webkit.org>
3301
3302         Unreviewed, rolling out r217423 and r217424.
3303         https://bugs.webkit.org/show_bug.cgi?id=172607
3304
3305         These caused an api failure on all testers. (Requested by
3306         mlewis13 on #webkit).
3307
3308         Reverted changesets:
3309
3310         "REGRESSION (r216977): 4 leaks introduced in new
3311         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
3312         https://bugs.webkit.org/show_bug.cgi?id=172558
3313         http://trac.webkit.org/changeset/217423
3314
3315         "REGRESSION (r217423): Fix last-second typo in 'auto'"
3316         http://trac.webkit.org/changeset/217424
3317
3318 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
3319
3320         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
3321         https://bugs.webkit.org/show_bug.cgi?id=172355
3322
3323         Reviewed by Chris Fleizach.
3324
3325         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
3326         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
3327         releases which support the new platform footnote accessibility role.
3328
3329         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3330         * gtk/jhbuild.modules:
3331
3332 2017-05-25  David Kilzer  <ddkilzer@apple.com>
3333
3334         REGRESSION (r217423): Fix last-second typo in 'auto'
3335
3336         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3337         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
3338
3339 2017-05-24  David Kilzer  <ddkilzer@apple.com>
3340
3341         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
3342         <https://webkit.org/b/172558>
3343
3344         Reviewed by Sam Weinig.
3345
3346         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3347         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
3348
3349 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
3350
3351         [CMake] Consolidate CMake code related to Cairo
3352         https://bugs.webkit.org/show_bug.cgi?id=172568
3353
3354         Reviewed by Alex Christensen.
3355
3356         * DumpRenderTree/config.h:
3357         * TestWebKitAPI/config.h:
3358
3359 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3360
3361         Plumb additional image metadata to item providers when beginning data interaction on an image
3362         https://bugs.webkit.org/show_bug.cgi?id=172536
3363         <rdar://problem/32371300>
3364
3365         Reviewed by Beth Dakin.
3366
3367         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
3368         source item providers.
3369
3370         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3371         (checkSuggestedNameAndEstimatedSize):
3372         (TestWebKitAPI::TEST):
3373
3374 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3375
3376         [Win] Create unique network storage session for each DRT.
3377         https://bugs.webkit.org/show_bug.cgi?id=172540
3378
3379         Reviewed by Brent Fulgham.
3380
3381         During layout testing, each DRT instance should have its own network storage session.
3382
3383         * DumpRenderTree/win/DumpRenderTree.cpp:
3384         (prepareConsistentTestingEnvironment):
3385
3386 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3387
3388         Respect image UTIs when writing to item providers when beginning data interaction on an image
3389         https://bugs.webkit.org/show_bug.cgi?id=172436
3390         <rdar://problem/31786569>
3391
3392         Reviewed by Beth Dakin.
3393
3394         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
3395         details.
3396
3397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3398         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
3399         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
3400
3401         Create a new test page containing a GIF and a file input.
3402
3403         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3404         (checkTypeIdentifierIsRegisteredAtIndex):
3405         (TestWebKitAPI::TEST):
3406
3407 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
3408
3409         [Win] Increase test timeout for slow tests.
3410         https://bugs.webkit.org/show_bug.cgi?id=172449
3411
3412         Reviewed by Alexey Proskuryakov.
3413
3414         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
3415         timeout member in the TestRunner class.
3416
3417         * DumpRenderTree/win/TestRunnerWin.cpp:
3418         (TestRunner::setWaitToDump):
3419
3420 2017-05-15  Matt Rajca  <mrajca@apple.com>
3421
3422         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
3423         https://bugs.webkit.org/show_bug.cgi?id=172138
3424
3425         Reviewed by Alex Christensen.
3426
3427         Added API tests.
3428
3429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3430         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
3431         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3432         (TEST):
3433         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
3434
3435 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
3436
3437         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
3438         https://bugs.webkit.org/show_bug.cgi?id=172522
3439         rdar://problem/31071812
3440
3441         Reviewed by Sam Weinig.
3442
3443         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
3444         We set this in the .xib file now.
3445
3446         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3447
3448 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
3449
3450         Snapshotting via -renderInContext: should do synchronous image decodes
3451         https://bugs.webkit.org/show_bug.cgi?id=172485
3452         rdar://problem/32276146
3453
3454         Reviewed by Tim Horton.
3455
3456         New API test.
3457
3458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3459         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
3460         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
3461         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
3462         (TestWebKitAPI::getPixelIndex):
3463         (TestWebKitAPI::TEST):
3464
3465 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
3466
3467         Remove dead ENABLE(FONT_LOAD_EVENTS) code
3468         https://bugs.webkit.org/show_bug.cgi?id=172517
3469
3470         Rubber-stamped by Simon Fraser.
3471
3472         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3473
3474 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3475
3476         Multiple links should be inserted separately when performing data interaction
3477         https://bugs.webkit.org/show_bug.cgi?id=172489
3478         <rdar://problem/31510832>
3479
3480         Reviewed by Dan Bernstein.
3481
3482         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
3483
3484         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3485         (TestWebKitAPI::TEST):
3486
3487 2017-05-23  Tim Horton  <timothy_horton@apple.com>
3488
3489         REGRESSION: API test WebKit2.WKObject is failing
3490         https://bugs.webkit.org/show_bug.cgi?id=172497
3491         <rdar://problem/31694641>
3492
3493         Reviewed by Geoff Garen.
3494
3495         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3496         (TestWebKitAPI::TEST):
3497         Add a test that ensures that we pretend to at least be *some* kind of
3498         NSString, which my first fix would not have passed.
3499
3500 2017-05-23  youenn fablet  <youenn@apple.com>
3501
3502         There should be an easy way to run HTTP/WPT served tests on a browser
3503         https://bugs.webkit.org/show_bug.cgi?id=172068
3504
3505         Reviewed by Sam Weinig.
3506
3507         Adding a new script open-layout-test to open a layout-test in a
3508         browser and making sure it is served as done through run-webkit-tests.
3509         In case tests should be run using a server, detecting whether the
3510         server are running. If not, calling run-webkit-httpd to run the
3511         servers and open the URL in a browser.
3512         Otherwise, open directly the URL.
3513
3514         Adding an option in run-webkit-httpd to open an URL after having
3515         started the servers.
3516
3517         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
3518         This allows running run-webkit-httpd once and not having to restart
3519         servers everytime a test should be served.
3520
3521         Moving most of run-webkit-httpd logic in its own python file to reuse
3522         it in open-layout-test script.
3523
3524         Adding routines to check whether HTTP and WPT servers are running.
3525
3526         * Scripts/open-layout-test: Added.
3527         (parse_args):
3528         (main):
3529         * Scripts/run-webkit-httpd:
3530         (main):
3531         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3532         (LayoutTestFinder.find_tests):
3533         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3534         (LayoutTestRunner.run_tests):
3535         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3536         (parse_args):
3537         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3538         (HttpServerBase._is_server_running_on_all_ports):
3539         (HttpServerBase):
3540         (HttpServerBase._is_running_on_port):
3541         (HttpServerBase._check_that_all_ports_are_available):
3542         (is_http_server_running):
3543         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
3544         (parse_args):
3545         (main):
3546         (run_server):
3547         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3548         (is_wpt_server_running):
3549         * Scripts/webkitpy/port/base.py:
3550         (Port.to.is_http_server_running):
3551         (Port.to):
3552         (Port.to.is_wpt_server_running):
3553         (Port.to.start_web_platform_test_server):
3554         * Scripts/webkitpy/port/driver.py:
3555         (DriverProxy.is_web_platform_test):
3556         (DriverProxy):
3557         (DriverProxy.is_webkit_specific_web_platform_test):
3558
3559 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
3560
3561         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3562         https://bugs.webkit.org/show_bug.cgi?id=171984
3563
3564         Reviewed by Antti Koivisto.
3565
3566         * DumpRenderTree/mac/DumpRenderTree.mm:
3567         (enableExperimentalFeatures):
3568         * WebKitTestRunner/TestController.cpp:
3569         (WTR::TestController::resetPreferencesToConsistentValues):
3570
3571 2017-05-20  Alex Christensen  <achristensen@webkit.org>
3572
3573         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
3574         https://bugs.webkit.org/show_bug.cgi?id=172406
3575         <rdar://32109532>
3576
3577         Reviewed by Brady Eidson.
3578
3579         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3580         (TestWebKitAPI::checkBuffer):
3581         (TestWebKitAPI::TEST_F):
3582
3583 2017-05-22  Jason Marcell  <jmarcell@apple.com>
3584
3585         Do not enter Subversion-specific logic when parsing Git-based Trac data.
3586         https://bugs.webkit.org/show_bug.cgi?id=172433
3587         <rdar://problem/32234188>
3588
3589         Reviewed by Alexey Proskuryakov.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3592         (Trac.prototype._convertCommitInfoElementToObject):
3593
3594 2017-05-22  Tim Horton  <timothy_horton@apple.com>
3595
3596         ExplicitSnapshotsChangeUponNavigation API test often fails
3597         https://bugs.webkit.org/show_bug.cgi?id=172475
3598         <rdar://problem/31688322>
3599
3600         Reviewed by Simon Fraser.
3601
3602         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3603         (-[TestWKWebView _setUpTestWindow:]):
3604         Make TestWKWebView's window layer-backed. This is now the default,
3605         and it's also easy to accidentally write a test that depends on it
3606         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
3607         which becomes layer backed, just like the WKWebView, but with no
3608         common layer-backed ancestor).
3609
3610 2017-05-22  youenn fablet  <youenn@apple.com>
3611
3612         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
3613         https://bugs.webkit.org/show_bug.cgi?id=172426
3614
3615         Reviewed by Chris Dumez.
3616
3617         * Scripts/webkitpy/w3c/test_importer.py:
3618         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
3619
3620 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
3621
3622         Unreviewed, change my status to&