Tools/ChangeLog

   1 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
   2
   3         Remove TextRun::allowsRoundingHacks()
   4         https://bugs.webkit.org/show_bug.cgi?id=153185
   5
   6         Reviewed by Simon Fraser.
   7
   8         * DumpRenderTree/mac/DumpRenderTree.mm:
   9         (resetWebViewToConsistentStateBeforeTesting): Deleted.
  10
  11 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
  12
  13         [webkitdirs] Avoid list form of open because it broke WinCairo
  14         https://bugs.webkit.org/show_bug.cgi?id=153106
  15
  16         Reviewed by Alex Christensen.
  17
  18         * Scripts/webkitdirs.pm:
  19         (determineArchitecture):
  20
  21 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
  22
  23         Add kdebug_trace signposts for a few WebCore operations
  24         https://bugs.webkit.org/show_bug.cgi?id=153136
  25         rdar://problem/24208487
  26
  27         Reviewed by Sam Weinig.
  28
  29         Plist used by kdebug_trace() viewing tools.
  30
  31         * Tracing/SystemTracePoints.plist: Added.
  32
  33 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
  34
  35         [webkitdirs] Replaced grep invocation with perl code
  36         https://bugs.webkit.org/show_bug.cgi?id=153106
  37
  38         Reviewed by Alex Christensen.
  39
  40         * Scripts/webkitdirs.pm:
  41         (determineArchitecture):
  42
  43 2016-01-14  Brian Burg  <bburg@apple.com>
  44
  45         prepare-changelog does not read paths containing spaces properly
  46         https://bugs.webkit.org/show_bug.cgi?id=137982
  47
  48         Reviewed by Joseph Pecoraro.
  49
  50         Escape whitespace in filenames before passing the file path to other functions.
  51
  52         * Scripts/prepare-ChangeLog:
  53         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
  54
  55 2016-01-14  Jason Marcell  <jmarcell@apple.com>
  56
  57         Standardize the usage of "branch" vs. "branchName".
  58         https://bugs.webkit.org/show_bug.cgi?id=152982
  59
  60         Reviewed by Daniel Bates.
  61
  62         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
  63         "branchName" implies that the variable or property in question is simply a string.
  64
  65         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
  66         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
  67         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
  68         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
  69         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
  70         (Trac.prototype.commitsOnBranch): Change branch to branchName.
  71         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
  72         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
  73         (MockTrac): Ditto.
  74
  75 2016-01-14  Jason Marcell  <jmarcell@apple.com>
  76
  77         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
  78         https://bugs.webkit.org/show_bug.cgi?id=152910
  79
  80         Reviewed by Daniel Bates.
  81
  82         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
  83         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
  84         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
  85         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
  86         the need to talk to a real Buildbot server.
  87         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
  88         without the need to talk to a real Buildbot server.
  89         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
  90         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
  91         server.
  92         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
  93         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
  94         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
  95         trying to talk to Trac.
  96         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
  97         QUnit unit tests.
  98         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
  99
 100 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
 101
 102         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
 103         https://bugs.webkit.org/show_bug.cgi?id=132599
 104
 105         Reviewed by Michael Catanzaro.
 106
 107         Check if cmake Ninja generators are installed.
 108
 109         * Scripts/webkitdirs.pm:
 110         (canUseNinjaGenerator):
 111         (canUseEclipseNinjaGenerator):
 112         (generateBuildSystemFromCMakeProject):
 113         (canUseEclipse): Deleted.
 114
 115 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
 116
 117         [Cocoa] Testing with font family name "System Font" is unused
 118         https://bugs.webkit.org/show_bug.cgi?id=153073
 119         <rdar://problem/24091683>
 120
 121         Reviewed by Brent Fulgham.
 122
 123         * DumpRenderTree/mac/DumpRenderTree.mm:
 124         (allowedFontFamilySet): Deleted.
 125         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
 126         (WTR::allowedFontFamilySet): Deleted.
 127         * WebKitTestRunner/mac/TestControllerMac.mm:
 128         (WTR::allowedFontFamilySet): Deleted.
 129
 130 2016-01-13  Daniel Bates  <dabates@apple.com>
 131
 132         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
 133         https://bugs.webkit.org/show_bug.cgi?id=152871
 134
 135         Reviewed by Brent Fulgham.
 136
 137         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
 138         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
 139
 140         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
 141
 142 2016-01-08  Andy Estes  <aestes@apple.com>
 143
 144         [Content Filtering] Lazily load platform frameworks
 145         https://bugs.webkit.org/show_bug.cgi?id=152881
 146         rdar://problem/23270886
 147
 148         Reviewed by Brady Eidson.
 149
 150         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
 151         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
 152         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
 153         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
 154         is loaded after an HTTPS request.
 155
 156         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
 157         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
 158         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
 159         also re-enabled on iOS after mistakenly being disabled by r188892.
 160
 161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 162         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
 163         (TestWebKitAPI::TEST):
 164         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
 165         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
 166         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
 167         (TEST):
 168         (downloadTest):
 169         (-[LazilyLoadPlatformFrameworksController init]):
 170         (-[LazilyLoadPlatformFrameworksController webView]):
 171         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
 172         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
 173         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
 174         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
 175         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
 176         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
 177         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
 178         (TestWebKitAPI::TEST):
 179         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
 180         (TestWebKitAPI::TEST): Deleted.
 181         * TestWebKitAPI/cocoa/TestProtocol.h:
 182         * TestWebKitAPI/cocoa/TestProtocol.mm:
 183         (+[TestProtocol registerWithScheme:]):
 184         (+[TestProtocol unregister]):
 185
 186 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
 187
 188         Fix the Sunpider converage in slow device.
 189         https://bugs.webkit.org/show_bug.cgi?id=152938
 190         <rdar://problem/22511411>
 191
 192         Reviewed by Ryosuke Niwa.
 193
 194         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
 195
 196         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
 197
 198 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
 199
 200         Add a build flag for custom element
 201         https://bugs.webkit.org/show_bug.cgi?id=153005
 202
 203         Reviewed by Alex Christensen.
 204
 205         Added --custom-elements option to enable custom elements support.
 206
 207         * Scripts/webkitperl/FeatureList.pm:
 208
 209 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
 210
 211         [JSC] Add a help message when run-jsc-stress-tests fails
 212         https://bugs.webkit.org/show_bug.cgi?id=153014
 213
 214         Reviewed by Csaba Osztrogonác.
 215
 216         * Scripts/run-jsc-stress-tests:
 217
 218 2016-01-11  Saam barati  <sbarati@apple.com>
 219
 220         run-jsc-stress-tests should try to figure out a JSC path
 221         https://bugs.webkit.org/show_bug.cgi?id=152971
 222
 223         Reviewed by Yusuke Suzuki.
 224
 225         This patch now allows run-jsc-stress-tests to be run
 226         without a "--jsc <jsc-path>" argument. It tries
 227         to take its best guess at a <jsc-path> automagically.
 228
 229         This makes it much easier to just run run-jsc-stress-tests
 230         with a directory or a yaml file as an argument.
 231         You now just do this:
 232         `run-jsc-stress-tests <path-to-yaml>`
 233         or
 234         `run-jsc-stress-tests <path-to-directory-of-js-files>`
 235
 236         I wrote this patch because I'd often find myself hacking the
 237         run-javascriptcore-tests file just to run a particular subset of tests.
 238         Because I always forget the arguments to run-jsc-stress-tests (which means
 239         I always forgot to provide a --jsc argument), I always found it easier to
 240         just hack on that file instead of calling run-jsc-stress-tests directly.
 241         No longer is this true!
 242
 243         * Scripts/run-jsc-stress-tests:
 244
 245 2016-01-09  Andy Estes  <aestes@apple.com>
 246
 247         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
 248         https://bugs.webkit.org/show_bug.cgi?id=152950
 249         rdar://problem/24066652
 250
 251         Reviewed by Tim Horton.
 252
 253         Added an API test.
 254
 255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 256         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
 257         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
 258         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
 259         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
 260         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
 261         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
 262         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
 263         (TEST):
 264
 265 2016-01-11  Commit Queue  <commit-queue@webkit.org>
 266
 267         Unreviewed, rolling out r194866.
 268         https://bugs.webkit.org/show_bug.cgi?id=152986
 269
 270         This change broke the mac build (Requested by ryanhaddad on
 271         #webkit).
 272
 273         Reverted changeset:
 274
 275         "[Cocoa] Add SPI to opt out a URL scheme from the memory
 276         cache"
 277         https://bugs.webkit.org/show_bug.cgi?id=152950
 278         http://trac.webkit.org/changeset/194866
 279
 280 2016-01-11  Andy Estes  <aestes@apple.com>
 281
 282         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
 283         https://bugs.webkit.org/show_bug.cgi?id=152950
 284         rdar://problem/24066652
 285
 286         Reviewed by Tim Horton.
 287
 288         Added an API test.
 289
 290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 291         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
 292         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
 293         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
 294         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
 295         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
 296         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
 297         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
 298         (TEST):
 299
 300 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
 301
 302         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
 303         https://bugs.webkit.org/show_bug.cgi?id=152959
 304
 305         Reviewed by Brent Fulgham.
 306
 307         * Scripts/webkitdirs.pm:
 308         (determineArchitecture):
 309
 310 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
 311
 312         [GTK] W3C CSS2.1 anonymous table tests are failing
 313         https://bugs.webkit.org/show_bug.cgi?id=152455
 314
 315         Reviewed by Mario Sanchez Prada.
 316
 317         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
 318         tests. Add upstream patches to fix detection of XHTML files.
 319
 320         * gtk/jhbuild.modules:
 321         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
 322         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
 323
 324 2016-01-10  Saam barati  <sbarati@apple.com>
 325
 326         Implement a sampling profiler
 327         https://bugs.webkit.org/show_bug.cgi?id=151713
 328
 329         Reviewed by Filip Pizlo.
 330
 331         * Scripts/run-jsc-stress-tests:
 332
 333 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
 334
 335         [webkitdirs] Try arch and uname commands on non-windows OS
 336         https://bugs.webkit.org/show_bug.cgi?id=152958
 337
 338         Reviewed by Michael Catanzaro.
 339
 340         Right now, determineArchitecture()  uses `arch` and `uname -m`
 341         commands to determine architecture in case of condition (isGtk() ||
 342         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
 343         instead, because this code is applicable to any non-windows OS WebKit
 344         supports (even Haiku which once was supported is moderately
 345         POSIX-compliant and has uname command).
 346
 347         * Scripts/webkitdirs.pm:
 348         (determineArchitecture):
 349
 350 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
 351
 352         run-webkit-tests mis-counts totals when there are other crashes
 353         https://bugs.webkit.org/show_bug.cgi?id=152894
 354         <rdar://problem/24098697>
 355
 356         Reviewed by Alexey Proskuryakov.
 357
 358         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
 359         (TestRunResults.add): Do not update result counters for other crashes.
 360
 361 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 362
 363         webkit-patch build-and-test should have an option to iterate over new tests
 364         https://bugs.webkit.org/show_bug.cgi?id=143093
 365
 366         Reviewed by Michael Catanzaro.
 367
 368         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
 369         It allows running run-webkit-tests on modified or new paths in LayoutTests.
 370         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
 371         It implements the translation of -expected.* paths to their related tests.
 372         It also implements the removal of skipped tests.
 373
 374         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
 375         (LayoutTestFinder.find_touched_tests):
 376         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
 377         (MockPort):
 378         (MockPort.__init__):
 379         (MockPort.tests):
 380         (LayoutTestFinderTests):
 381         (LayoutTestFinderTests.touched_files):
 382         (LayoutTestFinderTests.test_touched_test):
 383         (LayoutTestFinderTests.test_expected_touched_test):
 384         (LayoutTestFinderTests.test_platform_expected_touched_test):
 385         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
 386         (LayoutTestFinderTests.test_touched_but_skipped_test):
 387         * Scripts/webkitpy/port/base.py:
 388         (Port.potential_test_names_from_expected_file):
 389         * Scripts/webkitpy/tool/commands/download_unittest.py:
 390         (DownloadCommandsTest._default_options):
 391         * Scripts/webkitpy/tool/steps/options.py:
 392         (Options):
 393         * Scripts/webkitpy/tool/steps/runtests.py:
 394         (RunTests.options):
 395         (RunTests.run):
 396         (RunTests):
 397         (RunTests._new_or_modified_tests):
 398         (RunTests._run_webkit_tests):
 399         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
 400         (RunTestsTest.test_webkit_run_unit_tests):
 401         * Scripts/webkitpy/tool/steps/steps_unittest.py:
 402         (StepsTest._step_options):
 403
 404 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
 405
 406         prepare-ChangeLog should include radar number
 407         https://bugs.webkit.org/show_bug.cgi?id=152839
 408         <rdar://problem/24093563>
 409
 410         Reviewed by Daniel Bates.
 411
 412         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
 413         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
 414         in the ChangeLog description after the bug URL.
 415
 416         * Scripts/prepare-ChangeLog:
 417         (main): Update signatures.
 418         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
 419         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
 420         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
 421         (generateNewChangeLogs): Include radar URL if we found one.
 422
 423         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
 424         Tests for the radar URL extraction.
 425
 426 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
 427
 428         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
 429         https://bugs.webkit.org/show_bug.cgi?id=152390
 430         <rdar://problem/23948321>
 431
 432         Reviewed by Simon Fraser.
 433
 434         Fix two use-after-frees.
 435
 436         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
 437         but we may have already progressed to another test by the time the callback fires,
 438         having destroyed the TestInvocation.
 439         2. UIScriptController is a RefCounted object, but it has a raw pointer to
 440         UIScriptContext which has the same lifetime as a TestInvocation.
 441         As a result, completion blocks of UIScriptController actions would use a destroyed
 442         TestInvocation.
 443
 444         * WebKitTestRunner/TestInvocation.cpp:
 445         (WTR::TestInvocation::~TestInvocation):
 446         (WTR::TestInvocation::url):
 447         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 448         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
 449         (WTR::TestInvocation::runUISideScript):
 450         * WebKitTestRunner/TestInvocation.h:
 451         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
 452         (UIScriptContext::UIScriptContext):
 453         (UIScriptContext::~UIScriptContext):
 454         (UIScriptContext::runUIScript):
 455         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
 456         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
 457         (WTR::UIScriptController::UIScriptController):
 458         (WTR::UIScriptController::contextDestroyed):
 459         (WTR::UIScriptController::makeWindowObject):
 460         (WTR::UIScriptController::setWillBeginZoomingCallback):
 461         (WTR::UIScriptController::willBeginZoomingCallback):
 462         (WTR::UIScriptController::setDidEndZoomingCallback):
 463         (WTR::UIScriptController::didEndZoomingCallback):
 464         (WTR::UIScriptController::setDidEndScrollingCallback):
 465         (WTR::UIScriptController::didEndScrollingCallback):
 466         (WTR::UIScriptController::setDidShowKeyboardCallback):
 467         (WTR::UIScriptController::didShowKeyboardCallback):
 468         (WTR::UIScriptController::setDidHideKeyboardCallback):
 469         (WTR::UIScriptController::didHideKeyboardCallback):
 470         (WTR::UIScriptController::uiScriptComplete):
 471         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
 472         (WTR::UIScriptController::create):
 473         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 474         (WTR::UIScriptController::doAsyncTask):
 475         (WTR::UIScriptController::zoomToScale):
 476         (WTR::UIScriptController::singleTapAtPoint):
 477         (WTR::UIScriptController::doubleTapAtPoint):
 478         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
 479         (WTR::UIScriptController::contentVisibleRect):
 480         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
 481         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
 482         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
 483         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
 484         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
 485         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
 486         (WTR::UIScriptController::doAsyncTask):
 487
 488 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 489
 490         [buildbot] clean-build script should remove untracked files and revert local changes too
 491         https://bugs.webkit.org/show_bug.cgi?id=142400
 492
 493         Reviewed by Ryosuke Niwa.
 494
 495         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
 496         A helper routine SCM.discard_untracked_files is added for that purpose.
 497
 498         * BuildSlaveSupport/clean-build:
 499         (main): Making call to Scripts/clean-webkit
 500         * Scripts/clean-webkit: Added.
 501         (main): Revert changes and delete untracked files.
 502         * Scripts/webkitpy/common/checkout/scm/scm.py:
 503         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
 504         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 505         (SCMTest._shared_test_discard_untracked_files):
 506         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
 507
 508 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
 509
 510         Add a setting and preferences to enable display-list drawing. Does nothing yet.
 511         https://bugs.webkit.org/show_bug.cgi?id=152807
 512
 513         Reviewed by Zalan Bujtas.
 514
 515         Add an item to the Settings menu to toggle display-list drawing.
 516
 517         * MiniBrowser/mac/SettingsController.h:
 518         * MiniBrowser/mac/SettingsController.m:
 519         (-[SettingsController _populateMenu]):
 520         (-[SettingsController validateMenuItem:]):
 521         (-[SettingsController toggleDisplayListDrawingEnabled:]):
 522         (-[SettingsController displayListDrawingEnabled]):
 523         * MiniBrowser/mac/WK2BrowserWindowController.m:
 524         (-[WK2BrowserWindowController didChangeSettings]):
 525
 526 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 527
 528         Python SCM should be able to retrieve untracked files - Add GIT support
 529         https://bugs.webkit.org/show_bug.cgi?id=143135
 530
 531         Reviewed by Michael Catanzaro.
 532
 533         * Scripts/webkitpy/common/checkout/scm/git.py:
 534         (Git.untracked_files): Adding support for git.
 535         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 536         (GitTest.setUp):
 537         (GitTest.test_untracked_files): Adding test.
 538
 539 2016-01-05  Mark Lam  <mark.lam@apple.com>
 540
 541         Rename badly named JSC_timeout env var to JSCTEST_timeout.
 542         https://bugs.webkit.org/show_bug.cgi?id=152748
 543
 544         Reviewed by Geoffrey Garen.
 545
 546         Now that we validate JSC options, the badly named JSC_timeout env var causes the
 547         bots to have a bad time.
 548
 549         * Scripts/run-javascriptcore-tests:
 550         * Scripts/run-jsc-stress-tests:
 551
 552 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
 553
 554         [GTK] Allow to save and restore session
 555         https://bugs.webkit.org/show_bug.cgi?id=115600
 556
 557         Reviewed by Michael Catanzaro.
 558
 559         Add test case to check the new session API.
 560
 561         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
 562         (testWebKitWebViewSessionState):
 563         (testWebKitWebViewSessionStateWithFormData):
 564         (beforeAll):
 565
 566 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
 567
 568         [EFL] Bump EFL version to 1.16.1
 569         https://bugs.webkit.org/show_bug.cgi?id=152688
 570
 571         Reviewed by Gyuyoung Kim.
 572
 573         * efl/jhbuild.modules:
 574
 575 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
 576
 577         error running layout tests on iOS simulator on latest build
 578         https://bugs.webkit.org/show_bug.cgi?id=152719
 579         <rdar://problem/24009549>
 580
 581         Reviewed by Alexey Proskuryakov.
 582
 583         * Scripts/webkitpy/xcode/simulator.py:
 584         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
 585           before running simctl spawn command.
 586
 587 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
 588
 589         Unreviewed, move Frédéric Wang to committers list
 590
 591         He seems to be on the contributors list by accident. He has been landing his own commits for
 592         about two years now.
 593
 594         * Scripts/webkitpy/common/config/contributors.json:
 595
 596 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
 597
 598         Unreviewed, move Sebastian Dröge to committers list harder
 599
 600         He accidentally added himself to the reviewers list because the file is confusing. Then I
 601         accidentially moved him to the contributors list because the file is confusing, even though
 602         I knew the contributors list existed in this file and was attempting to add him to the
 603         committers list. Really move him to the committers list now.
 604
 605         * Scripts/webkitpy/common/config/contributors.json:
 606
 607 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 608
 609         Python SCM should be able to retrieve untracked files - Add SVN support
 610         https://bugs.webkit.org/show_bug.cgi?id=152546
 611
 612         Reviewed by Michael Catanzaro.
 613
 614         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 615         (test_untracked_files): Activating test for SVN.
 616         * Scripts/webkitpy/common/checkout/scm/svn.py:
 617         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
 618
 619 2015-12-31  Andy Estes  <aestes@apple.com>
 620
 621         Replace WTF::move with WTFMove
 622         https://bugs.webkit.org/show_bug.cgi?id=152601
 623
 624         Reviewed by Brady Eidson.
 625
 626         * DumpRenderTree/TestRunner.h:
 627         (TestRunner::setAllowedHosts):
 628         * DumpRenderTree/win/DRTDataObject.cpp:
 629         (DRTDataObject::SetData):
 630         * TestWebKitAPI/Tests/WTF/Deque.cpp:
 631         (TestWebKitAPI::TEST):
 632         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
 633         (TestWebKitAPI::TEST):
 634         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
 635         (TestWebKitAPI::TEST):
 636         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
 637         (TestWebKitAPI::TEST):
 638         * TestWebKitAPI/Tests/WTF/Ref.cpp:
 639         (TestWebKitAPI::passWithRef):
 640         (TestWebKitAPI::TEST):
 641         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
 642         (TestWebKitAPI::TEST):
 643         * TestWebKitAPI/Tests/WTF/Vector.cpp:
 644         (TestWebKitAPI::TEST):
 645         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
 646         (TestWebKitAPI::TEST):
 647         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
 648         (TestWebKitAPI::TEST):
 649         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
 650         (TestWebKitAPI::createTestValue):
 651         (TestWebKitAPI::TEST):
 652         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 653         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
 654         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
 655         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
 656         (TestWebKitAPI::createNFAs):
 657         (TestWebKitAPI::TEST_F):
 658         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
 659         (TestWebKitAPI::combine):
 660         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
 661         (TestWebKitAPI::createNFAs):
 662         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
 663         (TEST):
 664         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
 665         (WebProcessTest::add):
 666
 667 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
 668
 669         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
 670         https://bugs.webkit.org/show_bug.cgi?id=152634
 671
 672         Reviewed by Carlos Garcia Campos.
 673
 674         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
 675         (testLoadFromGResource): Added test.
 676         (beforeAll):
 677         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
 678         (registerGResource): Added.
 679         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
 680         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
 681         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
 682
 683 2015-12-31  David Kilzer  <ddkilzer@apple.com>
 684
 685         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
 686         <https://bugs.webkit.org/show_bug.cgi?id=152601>
 687
 688         Ignore unknown pragmas on older clangs.  Fixes the following
 689         build failure:
 690
 691             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
 692             #pragma clang diagnostic ignored "-Wself-move"
 693                                              ^
 694             1 error generated.
 695
 696         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
 697         (TestWebKitAPI::TEST):
 698         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
 699         (TestWebKitAPI::TEST):
 700
 701 2015-12-31  Andy Estes  <aestes@apple.com>
 702
 703         Update the style checker to advise using WTFMove() instead of WTF::move()
 704         https://bugs.webkit.org/show_bug.cgi?id=152601
 705
 706         Reviewed by Daniel Bates.
 707
 708         * Scripts/webkitpy/style/checkers/cpp.py:
 709         (check_wtf_move):
 710         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 711         (WebKitStyleTest.test_wtf_move):
 712
 713 2015-12-31  Andy Estes  <aestes@apple.com>
 714
 715         Fix warnings uncovered by migrating to WTF_MOVE
 716         https://bugs.webkit.org/show_bug.cgi?id=152601
 717
 718         Reviewed by Daniel Bates.
 719
 720         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
 721         self-move, even if doing so would trigger a warning.
 722
 723         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
 724         (TestWebKitAPI::TEST):
 725         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
 726         (TestWebKitAPI::TEST):
 727
 728 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
 729
 730         [GTK] The install-dependencies script has a syntax error
 731         https://bugs.webkit.org/show_bug.cgi?id=152613
 732
 733         Reviewed by Michael Catanzaro.
 734
 735         * gtk/install-dependencies: Add the missing 'then.'
 736
 737 2015-12-30  Philippe Normand  <pnormand@igalia.com>
 738
 739         [Mac][GTK] Jhbuild support for OSX
 740         https://bugs.webkit.org/show_bug.cgi?id=150799
 741
 742         Reviewed by Michael Catanzaro.
 743
 744         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
 745         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
 746         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
 747         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
 748
 749 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
 750
 751         Unreviewed, move Sebastian Dröge to committers list
 752
 753         He accidentally added himself to the reviewers list because the file is confusing.
 754
 755         * Scripts/webkitpy/common/config/contributors.json:
 756
 757 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
 758
 759         Remove the unused #define _USE_MATH_DEFINES
 760         https://bugs.webkit.org/show_bug.cgi?id=152034
 761
 762         Reviewed by Tim Horton.
 763
 764         Update this test to use piDouble from MathExtras.h, and
 765         std::numeric_limits<>.
 766
 767         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
 768
 769 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 770
 771         Python SCM should be able to retrieve untracked files - Generic changes
 772         https://bugs.webkit.org/show_bug.cgi?id=152536
 773
 774         Reviewed by Brent Fulgham.
 775
 776         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
 777         No support is yet added to GIT and SVN specific implementations.
 778
 779         * Scripts/webkitpy/common/checkout/scm/scm.py:
 780         (SCM.untracked_files):
 781         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 782         (SCMTest._shared_test_untracked_files):
 783
 784 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
 785
 786         SVN checkout used by RunBenchmark should be non-interactive
 787         https://bugs.webkit.org/show_bug.cgi?id=152542
 788
 789         Reviewed by Ryosuke Niwa.
 790
 791         RunBenchmark should not require user interaction while running.
 792
 793         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
 794         (BenchmarkBuilder._checkout_with_subversion):
 795
 796 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
 797
 798         Web Inspector: add support for running protocol-test.js tests on Windows
 799         https://bugs.webkit.org/show_bug.cgi?id=148037
 800         <rdar://problem/22292237>
 801
 802         Reviewed by Simon Fraser.
 803
 804         * DumpRenderTree/win/TestRunnerWin.cpp:
 805         (TestRunner::inspectorTestStubURL): Provide implementation.
 806
 807 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
 808
 809         [MediaStream] MediaDeviceInfo.label must be empty in some situations
 810         https://bugs.webkit.org/show_bug.cgi?id=152000
 811
 812         Reviewed by Brent Fulgham.
 813
 814         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 815         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 816         (WTR::InjectedBundle::setUserMediaPermission):
 817         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
 818         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 819
 820         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 821         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
 822         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 823
 824         * WebKitTestRunner/TestController.cpp:
 825         (WTR::TestController::setUserMediaPermissionForOrigin):
 826         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
 827         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add
 828           persistent permission for origin, that can be done from script now.
 829         * WebKitTestRunner/TestController.h:
 830
 831         * WebKitTestRunner/TestInvocation.cpp:
 832         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
 833           SetUserMediaPermissionForOrigin.
 834
 835 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
 836
 837         [Win] Unreviewed build fix: Recognize Windows 10 variants.
 838
 839         * Scripts/webkitpy/common/system/platforminfo.py:
 840         (PlatformInfo._determine_win_version):
 841
 842 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
 843
 844         Content blockers should be able to promote http to https
 845         https://bugs.webkit.org/show_bug.cgi?id=148966
 846
 847         Reviewed by Benjamin Poulain.
 848
 849         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 850         (WebCore::ContentExtensions::operator<<):
 851         (TestWebKitAPI::TEST_F):
 852
 853 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
 854
 855         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
 856         https://bugs.webkit.org/show_bug.cgi?id=152516
 857
 858         Reviewed by Gyuyoung Kim.
 859
 860         * MiniBrowser/efl/main.c:
 861
 862 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
 863
 864         Unreviewed: Add John Wilander as a contributor.
 865
 866         * Scripts/webkitpy/common/config/contributors.json:
 867
 868 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
 869
 870         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
 871         https://bugs.webkit.org/show_bug.cgi?id=152482
 872
 873         Reviewed by Brent Fulgham.
 874
 875         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
 876         for the same property. On WK2, the element returned will not be valid, but is still present and
 877         that can lead to looping.
 878
 879         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 880         (AccessibilityUIElement::horizontalScrollbar):
 881         (AccessibilityUIElement::verticalScrollbar):
 882         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 883         (WTR::AccessibilityUIElement::horizontalScrollbar):
 884         (WTR::AccessibilityUIElement::verticalScrollbar):
 885
 886 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 887
 888         Unreviewed.
 889
 890         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
 891
 892 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
 893
 894         [EFL] test_ewk2_context failed after r192808
 895         https://bugs.webkit.org/show_bug.cgi?id=151846
 896
 897         Reviewed by Gyuyoung Kim.
 898
 899         Used the added ewk_context_web_process_count_limit_set api
 900         instead of the deprecated ewk_context_process_model_set.
 901
 902         * MiniBrowser/efl/main.c:
 903         (elm_main):
 904
 905 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
 906
 907         Unreviewed, move myself to reviewer list.
 908
 909         * Scripts/webkitpy/common/config/contributors.json:
 910
 911 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
 912
 913         Unreviewed, add myself to the committers list.
 914
 915         * Scripts/webkitpy/common/config/contributors.json:
 916
 917 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
 918
 919         [GTK] jquery.min.js violates DFSG
 920         https://bugs.webkit.org/show_bug.cgi?id=152428
 921
 922         Reviewed by Joseph Pecoraro.
 923
 924         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
 925         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
 926
 927         * gtk/manifest.txt.in:
 928
 929 2015-12-19  Dan Bernstein  <mitz@apple.com>
 930
 931         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
 932         https://bugs.webkit.org/show_bug.cgi?id=152462
 933
 934         Reviewed by Alexey Proskuryakov.
 935
 936         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
 937           OS X 10.9:
 938
 939         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 940         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
 941         * MiniBrowser/Configurations/DebugRelease.xcconfig:
 942         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
 943         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 944
 945         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
 946           never getting compiled:
 947
 948         * DumpRenderTree/mac/TextInputController.m:
 949         * MiniBrowser/mac/BrowserWindowController.m:
 950         * TestWebKitAPI/Tests/mac/AttributedString.mm:
 951         * WebKitTestRunner/mac/EventSenderProxy.mm:
 952
 953 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
 954
 955         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
 956
 957         This is to make it easy to CC it on Bugzilla.
 958
 959         * Scripts/webkitpy/common/config/contributors.json:
 960
 961 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
 962
 963         Pasteboard get messed up after running kill-old-processes
 964         https://bugs.webkit.org/show_bug.cgi?id=152426
 965
 966         Reviewed by Alexey Proskuryakov.
 967
 968         * BuildSlaveSupport/kill-old-processes:
 969         (main): Do not kill pasteboard anymore.
 970
 971 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
 972
 973         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
 974         https://bugs.webkit.org/show_bug.cgi?id=152157
 975         <rdar://problem/23851817>
 976
 977         Reviewed by Alexey Proskuryakov.
 978
 979         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
 980         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
 981         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 982         (Manager._get_test_inputs): Common method to calculate test_inputs.
 983         (Manager._update_worker_count): Calculate and update required number of workers.
 984
 985 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
 986
 987         run-webkit-tests fails to delete Simulator device during cleanup
 988         https://bugs.webkit.org/show_bug.cgi?id=152363
 989
 990         Reviewed by Alexey Proskuryakov.
 991
 992         * Scripts/webkitpy/xcode/simulator.py:
 993         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
 994
 995 2015-12-16  Tim Horton  <timothy_horton@apple.com>
 996
 997         [mac-wk2] fast/events force click tests crashing
 998         https://bugs.webkit.org/show_bug.cgi?id=152339
 999
1000         Reviewed by Beth Dakin.
1001
1002         * WebKitTestRunner/mac/EventSenderProxy.mm:
1003         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1004         Set the NSEvent's _type member in addition to overriding -type,
1005         because there are assertions in touch event handling code that depend on it.
1006
1007 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1008
1009         Enforce temporarily bots to sync WebKit and WPT testharness.js
1010         https://bugs.webkit.org/show_bug.cgi?id=152334
1011
1012         Reviewed by Darin Adler.
1013
1014         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1015         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1016
1017 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1018
1019         [Fetch API] Add fetch API compile time flag
1020         https://bugs.webkit.org/show_bug.cgi?id=152254
1021
1022         Reviewed by Darin Adler.
1023
1024         * Scripts/webkitperl/FeatureList.pm:
1025
1026 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1027
1028         Unreviewed.
1029
1030         Added files that have impact in building Streams API to the watchlist.
1031
1032         * Scripts/webkitpy/common/config/watchlist:
1033
1034 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1035
1036         Unreviewed.
1037
1038         Added imported tests to Streams API watchlist.
1039
1040         * Scripts/webkitpy/common/config/watchlist:
1041
1042 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1043
1044         Remove default copy of wpt testharness.js when launching wpt server
1045         https://bugs.webkit.org/show_bug.cgi?id=152298
1046
1047         Reviewed by Darin Adler.
1048
1049         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1050         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1051
1052 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1053
1054         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1055         <http://webkit.org/b/152314>
1056
1057         Reviewed by Daniel Bates.
1058
1059         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1060         code path to exit immediately when calling main().
1061         Unfortunately, DumpRenderTreeMain.mm was used for both
1062         DumpRenderTree command-line binary and DumpRenderTree.app, which
1063         meant that the app would exit immediately with no error code
1064         when run!
1065
1066         The workaround is to introduce a separate source file called
1067         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1068         already does.
1069
1070         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1071         DumpRenderTreeAppMain.mm to the project.  Make it the only
1072         compiled source for the DumpRenderTree.app target.
1073         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1074         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1075         case someone tries mistakenly to use the app.
1076         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1077         Link to JavaScriptCore.framework on iOS for the assert.
1078         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1079         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1080         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1081         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1082         (main): Add assert for iOS so that a crash occurs if someone
1083         tries to run the wrong command.
1084
1085 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1086
1087         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1088         https://bugs.webkit.org/show_bug.cgi?id=152266
1089         <rdar://problem/22092676>
1090
1091         Reviewed by Simon Fraser.
1092
1093         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1094         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1095         Add a test that crashed before this change, and doesn't crash after.
1096
1097 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1098
1099         AX: iOS: Text field variations do not have the correct traits
1100         https://bugs.webkit.org/show_bug.cgi?id=152237
1101
1102         Reviewed by Mario Sanchez Prada.
1103
1104         Add iOS calls for determing if an object is a search field or a text area.
1105
1106         * DumpRenderTree/AccessibilityUIElement.cpp:
1107         (getIsSearchFieldCallback):
1108         (getIsTextAreaCallback):
1109         (stringForSelectionCallback):
1110         (AccessibilityUIElement::getJSClass):
1111         * DumpRenderTree/AccessibilityUIElement.h:
1112         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1113         (AccessibilityUIElement::identifier):
1114         (AccessibilityUIElement::isTextArea):
1115         (AccessibilityUIElement::isSearchField):
1116         (AccessibilityUIElement::traits):
1117         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1118         (WTR::AccessibilityUIElement::scrollPageRight):
1119         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1120         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1121         (WTR::AccessibilityUIElement::isSearchField):
1122         (WTR::AccessibilityUIElement::isTextArea):
1123         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1124         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1125         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1126         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1127         (WTR::AccessibilityUIElement::isTextArea):
1128         (WTR::AccessibilityUIElement::isSearchField):
1129         (WTR::AccessibilityUIElement::rowCount):
1130
1131 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1132
1133         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1134         https://bugs.webkit.org/show_bug.cgi?id=152252
1135
1136         Reviewed by Sergio Villar Senin.
1137
1138         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1139         for building the JHBuild on Debian systems.
1140
1141 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1142
1143         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1144         https://bugs.webkit.org/show_bug.cgi?id=152156
1145
1146         Reviewed by Dan Bernstein.
1147
1148         Our frameworks should appropriately prefix all ObjC classes,
1149         not just external symbols.
1150
1151         * Scripts/check-for-inappropriate-objc-class-names:
1152         Remove the -g switch to check all ObjC class names.
1153
1154 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1155
1156         [MediaStream] Expose media capture devices persistent permissions to WebCore
1157         https://bugs.webkit.org/show_bug.cgi?id=152087
1158
1159         Add support for the new user media permission checker page UI client method.
1160
1161         Reviewed by Chris Dumez.
1162
1163         * WebKitTestRunner/TestController.cpp:
1164         (WTR::decidePolicyForUserMediaPermissionRequest):
1165         (WTR::checkUserMediaPermissionForOrigin):
1166         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1167         (WTR::TestController::createWebViewWithOptions): Ditto.
1168         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1169         (WTR::originUserVisibleName): New, create a string for the origin.
1170         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1171           according to the state of the origin permission map.
1172         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1173           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1174         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1175           origin permission map.
1176         * WebKitTestRunner/TestController.h:
1177
1178 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1179
1180         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1181         https://bugs.webkit.org/show_bug.cgi?id=152022
1182         rdar://problem/23763584
1183
1184         Reviewed by Darin Adler.
1185
1186         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1187         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1188         (WTR::InjectedBundlePage::willSendRequestForFrame):
1189         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1190         (WTR::TestRunner::setWillSendRequestReturnsNull):
1191         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1192         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1193         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1194         (WTR::TestRunner::willSendRequestHTTPBody):
1195         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1196
1197 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1198
1199         Remove additional simulator checks before running layout-tests
1200         https://bugs.webkit.org/show_bug.cgi?id=152146
1201
1202         Reviewed by Darin Adler.
1203
1204         * Scripts/webkitpy/port/ios.py:
1205         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1206         * Scripts/webkitpy/xcode/simulator.py:
1207         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1208         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1209
1210 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1211
1212         Run atleast one simulator even if max process limit is low
1213         https://bugs.webkit.org/show_bug.cgi?id=152081
1214         <rdar://problem/23819694>
1215
1216         Reviewed by Alexey Proskuryakov.
1217
1218 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1219
1220         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1221         https://bugs.webkit.org/show_bug.cgi?id=144262
1222
1223         Reviewed by Carlos Garcia Campos.
1224
1225         Added new unit test to check the additional scenarios we now
1226         handle for custom URI schemes.
1227
1228         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1229         (generateHTMLContent): New helper function to generate big enough content.
1230         (testWebContextURIScheme): New unit test.
1231
1232 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1233
1234         [EFL] Fix unhandled web process message when launching MiniBrowser
1235         https://bugs.webkit.org/show_bug.cgi?id=152048
1236
1237         Reviewed by Gyuyoung Kim.
1238
1239         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1240         (TestWebKitAPI::TEST):
1241
1242 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1243
1244         [GTK] Add API to handle beforeunload events
1245         https://bugs.webkit.org/show_bug.cgi?id=139090
1246
1247         Reviewed by Gustavo Noronha Silva.
1248
1249         * MiniBrowser/gtk/BrowserWindow.c:
1250         (browserWindowConstructed):
1251         (browserWindowDeleteEvent):
1252         (browser_window_class_init):
1253         Handle delete-event to prevent the window from being closed when
1254         the page has beforeunload handlers. Use
1255         webkit_web_view_try_close() when the window is requested to be
1256         closed.
1257         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1258         (testWebViewJavaScriptDialogs):
1259         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1260         script dialog type.
1261
1262 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1263
1264         Refactored initialization code in LoadTrackingTest.
1265
1266         Rubber-stamped by Carlos Garcia Campos.
1267
1268         Small refactoring to make sure that the state of a LoadTrackingTest
1269         gets properly reset before loading new web content.
1270
1271         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1272         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1273         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1274         functions and reset the remaining local variables.
1275         (LoadTrackingTest::loadURI): Call reset();
1276         (LoadTrackingTest::loadHtml): Ditto.
1277         (LoadTrackingTest::loadPlainText): Ditto.
1278         (LoadTrackingTest::loadBytes): Ditto.
1279         (LoadTrackingTest::loadRequest): Ditto.
1280         (LoadTrackingTest::reload): Ditto.
1281         (LoadTrackingTest::goBack): Ditto.
1282         (LoadTrackingTest::goForward): Ditto.
1283
1284 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1285
1286         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1287         https://bugs.webkit.org/show_bug.cgi?id=151942
1288
1289         Reviewed by Darin Adler.
1290
1291         * MiniBrowser/efl/main.c:
1292         (window_create): Enable offline web application cache feature on MiniBrowser.
1293         (elm_main):
1294
1295 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1296
1297         https://bugs.webkit.org/show_bug.cgi?id=151243
1298         <rdar://problem/22955197>
1299
1300         Reviewed by Alexey Proskuryakov.
1301
1302         * LayoutTestRelay/LayoutTestRelay/main.m:
1303         (getTestingSimDevice): Use separate testing device for each worker.
1304         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1305         (Manager.run): Perform cleanup even if setup fails.
1306         * Scripts/webkitpy/port/ios.py:
1307         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1308         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1309         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1310         (IOSSimulatorPort._quit_ios_simulator): Same
1311         (IOSSimulatorPort.clean_up_test_run): Same
1312         (IOSSimulatorPort.check_sys_deps): Same
1313         (IOSSimulatorPort.testing_device): Same
1314         (IOSSimulatorPort.reset_preferences): Same
1315         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1316         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1317         * Scripts/webkitpy/xcode/simulator.py:
1318         (Device.delete): Delete the simulator device.
1319         (Simulator.delete_device): Same
1320         (Simulator.wait_until_device_is_booted): Wait for device booting.
1321
1322 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1323
1324         [EFL] Add API to provide preferences before creating ewk_view
1325         https://bugs.webkit.org/show_bug.cgi?id=151587
1326
1327         Reviewed by Gyuyoung Kim.
1328
1329         * MiniBrowser/efl/main.c:
1330         (on_key_down):
1331         (quit):
1332         (window_create):
1333         Moved settings related code to configuration() not to update settings
1334         whenever ewk_view is created.
1335         (configuration):
1336         (elm_main):
1337
1338 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1339
1340         Unreviewed. Fix GTK+ API tests after r193639.
1341
1342         The new jhbuild version needs some more variables ot be present in
1343         the builtin dict, even if they are set to None.
1344
1345         * jhbuild/jhbuildutils.py:
1346         (enter_jhbuild_environment_if_available):
1347
1348 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1349
1350         [GTK] Notify WebCore when notification is clicked
1351         https://bugs.webkit.org/show_bug.cgi?id=151951
1352
1353         Reviewed by Carlos Garcia Campos.
1354
1355         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1356         (testWebViewNotification): test the new API.
1357
1358 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1359
1360         'jhbuild build' should fail immediately when building any module fails
1361         https://bugs.webkit.org/show_bug.cgi?id=145697
1362
1363         Reviewed by Carlos Garcia Campos.
1364
1365         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1366         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1367         Everything is placed under lib instead of lib64 now.
1368         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1369         --exit-on-error when running 'jhbuild build'.
1370         * jhbuild/jhbuildrc_common.py:
1371         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1372         jhbuild should be able to handle these for us without breaking things....
1373
1374 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1375
1376         Add support to import w3c tests from a repository with a different root that the main repo dir
1377         https://bugs.webkit.org/show_bug.cgi?id=151751
1378
1379         Reviewed by Ryosuke Niwa and Youenn Fablet.
1380
1381         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1382         in a different directory than the repository root.
1383
1384         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1385         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1386         requires having the copy_path lists including tuples of origin and destination directories.
1387
1388         * Scripts/webkitpy/w3c/test_downloader.py:
1389         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1390         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1391         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1392         (TestImporterTest.test_tests_directory): Test.
1393
1394 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1395
1396         Mock TestRepositories in W3C importer tests
1397         https://bugs.webkit.org/show_bug.cgi?id=151938
1398
1399         Reviewed by Youenn Fablet.
1400
1401         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1402         is because the test repository method reading the file was using the filesystem directly instead of taking the
1403         host one. This patch changes that.
1404
1405         * Scripts/webkitpy/w3c/test_downloader.py:
1406         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1407         default one.
1408         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1409         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1410         (TestImporterTest.test_harnesslinks_conversion):
1411         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1412
1413 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1414
1415         TestNetscapePlugIn: Address review comment on 193607
1416         <http://webkit.org/b/151881>
1417
1418         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1419         (testSetStatus): Initializing std::unique_ptr<char[]> with
1420         nullptr is redundant.
1421
1422 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1423
1424         [GTK] Add webkit_uri_request_get_http_method
1425         https://bugs.webkit.org/show_bug.cgi?id=151601
1426
1427         Reviewed by Martin Robinson.
1428
1429         Add test case to check HTTP method of WebKitURIRequest.
1430
1431         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1432         (testURIRequestHTTPMethod):
1433         (serverCallback):
1434         (beforeAll):
1435         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1436         (sendRequestCallback):
1437
1438 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1439
1440         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1441         https://bugs.webkit.org/show_bug.cgi?id=79918
1442
1443         Reviewed by Gustavo Noronha Silva.
1444
1445         Add unit tests to check the different console messages.
1446
1447         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1448         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1449         (ConsoleMessageTest::ConsoleMessage::operator==):
1450         (ConsoleMessageTest::consoleMessageReceivedCallback):
1451         (ConsoleMessageTest::ConsoleMessageTest):
1452         (ConsoleMessageTest::~ConsoleMessageTest):
1453         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1454         (testWebKitConsoleMessageConsoleAPI):
1455         (testWebKitConsoleMessageJavaScriptException):
1456         (testWebKitConsoleMessageNetworkError):
1457         (testWebKitConsoleMessageSecurityError):
1458         (beforeAll):
1459         (afterAll):
1460         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1461         (consoleMessageSentCallback):
1462         (pageCreatedCallback):
1463
1464 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1465
1466         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1467         https://bugs.webkit.org/show_bug.cgi?id=151934
1468
1469         Reviewed by Csaba Osztrogonác.
1470
1471         * MiniBrowser/efl/main.c:
1472         (on_window_deletion): Revert the changes of r192767.
1473
1474 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1475
1476         [GTK] update-webkitgtk-libs cannot build mesa
1477         https://bugs.webkit.org/show_bug.cgi?id=151535
1478
1479         Reviewed by Martin Robinson.
1480
1481         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1482         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1483         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1484         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1485         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1486         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1487
1488         * gtk/jhbuild.modules:
1489
1490 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1491
1492         [GTK][Mac] libWebExtensionTest link error
1493         https://bugs.webkit.org/show_bug.cgi?id=150802
1494
1495         Reviewed by Carlos Garcia Campos.
1496
1497         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1498
1499 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1500
1501         TestNetscapePlugIn: Fix leaks found by static analyzer
1502         <http://webkit.org/b/151881>
1503
1504         Reviewed by Darin Adler.
1505
1506         Fixes the following leaks found by the static analyzer:
1507             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1508                     return false;
1509                            ^~~~~
1510             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1511                     return false;
1512                            ^~~~~
1513             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1514                     return false;
1515                            ^~~~~
1516
1517         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1518         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1519         early return if allocation fails.
1520         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1521         Make sure to call fclose() on filehandle, even for an early
1522         return.
1523         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1524
1525 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1526
1527         prepare-ChangeLog: Fix some warning messages when using svn
1528         <http://webkit.org/b/151914>
1529
1530         Reviewed by Daniel Bates.
1531
1532         * Scripts/prepare-ChangeLog:
1533         (generateFunctionLists): Simplify logic so that we never call
1534         normalizePath() with an undefined value.
1535         (attributeCommand): Quote $subPath for the shell so that we
1536         don't try to run "svn propget" on invalid paths.
1537
1538 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1539
1540         TestNetscapePlugIn: Fix remaining static analyzer warnings
1541         <http://webkit.org/b/151888>
1542
1543         Reviewed by Alexey Proskuryakov.
1544
1545         Fixes the following static analyzer warnings:
1546             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1547                     CRASH();
1548                     ^~~~~~~
1549             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1550                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1551                 ^~~~~~~~~~~~~~~~
1552             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1553                 return obj->pluginTest->NPP_SetWindow(window);
1554                        ^~~~~~~~~~~~~~~
1555             2 warnings generated.
1556
1557         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1558         (CRASH): Use __builtin_trap() for gcc/clang.
1559         (NPP_SetWindow): Add early return if obj is nullptr.
1560
1561 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1562
1563         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1564         https://bugs.webkit.org/show_bug.cgi?id=151797
1565
1566         Reviewed by Martin Robinson.
1567
1568         Since we switched to use the network process to run the unit tests
1569         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1570         sometimes passes. We are now also getting the notification for the
1571         css image. Since we wait for 3 resources, sometimes the css image
1572         is loaded before and then checkResourceData is called for it, but
1573         not handled. When the css image is the last one loaded the test
1574         passes. So, we just need to wait for the 4 resources.
1575
1576         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1577         (testWebResourceGetData):
1578
1579 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1580
1581         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1582         <http://webkit.org/b/151845>
1583
1584         Reviewed by Simon Fraser.
1585
1586         Fixes the following static analyzer warning:
1587             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1588                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1589                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1590
1591         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1592         (createBitmapContext): Free 'buffer' after using it in logging
1593         to fix the use-after-free.  Assign a value of nullptr to buffer
1594         so we don't return with it set to a freed address.
1595
1596 2015-12-03  Jer Noble  <jer.noble@apple.com>
1597
1598         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1599         https://bugs.webkit.org/show_bug.cgi?id=151830
1600
1601         Reviewed by Anders Carlsson.
1602
1603         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1604
1605         * DumpRenderTree/mac/DumpRenderTree.mm:
1606         (resetWebPreferencesToConsistentValues):
1607         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1608         (WTR::initializeWebViewConfiguration):
1609
1610 2015-12-03  Anders Carlsson  <andersca@apple.com>
1611
1612         Remove Objective-C GC support
1613         https://bugs.webkit.org/show_bug.cgi?id=151819
1614         rdar://problem/23746991
1615
1616         Reviewed by Dan Bernstein.
1617
1618         * asan/asan.xcconfig:
1619
1620 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1621
1622         Allow nil for unspecified benchmark pathes
1623         https://bugs.webkit.org/show_bug.cgi?id=151784
1624
1625         Reviewed by Filip Pizlo.
1626
1627         `Pathname.new(nil)` will raise an error.
1628         Only generate Pathname if the benchmark path is specified.
1629
1630         * Scripts/run-jsc-benchmarks:
1631
1632 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1633
1634         [Win] Run non-http tests without Cygwin
1635         https://bugs.webkit.org/show_bug.cgi?id=151721
1636
1637         Reviewed by Andy Estes.
1638
1639         Support native 32-bit and 64-bit Python (and Perl) builds
1640         for running tests:
1641
1642         1. Use "startswith('win')", rather than "== 'win32'" to support
1643         various Windows build types.
1644         2. Supply full path for some native Windows utilities, since the
1645         path environment does not always have the specified, and they are
1646         guaranteed to exist in those specific locations.
1647         3. Make sure native Windows Python test runs pass proper environment
1648         variables to run programs.
1649         4. Append 'exe' suffix when running Windows executables.
1650         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1651         command doesn't exist.
1652
1653         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1654         the current Perl executable, rather than requiring a new path search.
1655         * Scripts/webkitpy/common/find_files_unittest.py:
1656         (TestWinNormalize.test_win): Use startswith('win').
1657         * Scripts/webkitpy/common/prettypatch_unittest.py:
1658         (test_pretty_diff_encodings): Ditto.
1659         * Scripts/webkitpy/common/system/executive.py:
1660         (Executive._should_close_fds): Ditto.
1661         (Executive.shell_command_for_script): Use startswith('win').
1662         (Executive.kill_process): Use full path to killall executable.
1663         (Executive.check_running_pid): Use startswith('win').
1664         (Executive.running_pids): Ditto.
1665         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1666         running under native Windows Python.
1667         (Executive._child_process_encoding): Use startswith('win').
1668         (Executive._should_encode_child_process_arguments): Ditto.
1669         (Executive.popen): Recognize proper script engine on Windows, since it
1670         does not support the shebang syntax.
1671         (Executive.run_in_parallel): Use startswith('win').
1672         * Scripts/webkitpy/common/system/executive_unittest.py:
1673         (never_ending_command): Ditto.
1674         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1675         (ExecutiveTest.serial_test_kill_process): Ditto.
1676         (ExecutiveTest.serial_test_kill_all): Ditto.
1677         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1678         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1679         (main): Ditto.
1680         * Scripts/webkitpy/common/system/file_lock.py:
1681         (FileLock._create_lock): Ditto.
1682         (FileLock._remove_lock): Ditto.
1683         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1684         (RealFileSystemTest.test_chdir): Ditto.
1685         (RealFileSystemTest.test_chdir__notexists): Ditto.
1686         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1687         * Scripts/webkitpy/common/system/path_unittest.py:
1688         (AbspathTest.test_abspath_to_uri_win): Ditto.
1689         * Scripts/webkitpy/common/system/platforminfo.py:
1690         (PlatformInfo._determine_os_name): Ditto.
1691         * Scripts/webkitpy/common/system/user.py: Ditto.
1692         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1693         (ManagerTest.integration_test_needs_servers): Ditto.
1694         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1695         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1696         driver letters.
1697         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1698         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1699         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1700         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1701         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1702         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1703         (TestHttpServer.test_start_cmd): Ditto.
1704         * Scripts/webkitpy/port/base.py:
1705         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1706         and 'SYSTEMROOT' in environment passed to test runners.
1707         (Port._apache_config_file_name_for_platform): Use startswith('win').
1708         (Port._build_path): Ditto.
1709         (Port._path_to_driver): Include 'exe' suffix when running under native
1710         Windows.
1711         * Scripts/webkitpy/port/driver.py:
1712         (Driver._setup_environ_for_driver): Explicitly make some environment
1713         variables strings.
1714         * Scripts/webkitpy/port/server_process.py:
1715         (ServerProcess.__init__): Use startswith('win').
1716         * Scripts/webkitpy/port/win.py:
1717         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1718         registry key formats.
1719         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1720         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1721         and regtool on Cygwin.
1722         (WinPort.write_registry_value): Ditto.
1723         (WinPort.setup_crash_log_saving): Ditto.
1724         (WinPort.restore_crash_log_saving): Ditto.
1725         (WinPort.prevent_error_dialogs): Ditto.
1726         (WinPort.allow_error_dialogs): Ditto.
1727         (WinPort.find_system_pid): Revise to use Windows management
1728         infrastructure on native Windows, continue using 'ps' on Cygwin.
1729         (WinPort.read_registry_string): Deleted.
1730         (WinPort.write_registry_string): Deleted.
1731         * Scripts/webkitpy/test/main.py:
1732         (main): Use startswith('win').
1733         (Tester._parse_args): Ditto.
1734
1735 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1736
1737         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1738         https://bugs.webkit.org/show_bug.cgi?id=150792
1739
1740         Reviewed by Saam Barati.
1741
1742         * Scripts/webkitperl/FeatureList.pm:
1743
1744 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1745
1746         Unreviewed, rolling out r192914.
1747         https://bugs.webkit.org/show_bug.cgi?id=151734
1748
1749         JSC tests for this change are failing on 32 and 64-bit bots
1750         (Requested by ryanhaddad on #webkit).
1751
1752         Reverted changeset:
1753
1754         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1755         enable this feature"
1756         https://bugs.webkit.org/show_bug.cgi?id=150792
1757         http://trac.webkit.org/changeset/192914
1758
1759 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1760
1761         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1762         <http://webkit.org/b/151726>
1763
1764         Reviewed by Simon Fraser.
1765
1766         * WebKitTestRunner/mac/EventSenderProxy.mm:
1767         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1768         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1769
1770 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1771
1772         Give String and AtomicString an existingHash() function
1773         https://bugs.webkit.org/show_bug.cgi?id=151717
1774
1775         Reviewed by Andreas Kling.
1776
1777         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1778         (TestWebKitAPI::TEST):
1779         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1780         (TestWebKitAPI::TEST):
1781
1782 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1783
1784         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1785         https://bugs.webkit.org/show_bug.cgi?id=150792
1786
1787         Reviewed by Saam Barati.
1788
1789         * Scripts/webkitperl/FeatureList.pm:
1790
1791 2015-12-01  Sam Weinig  <sam@webkit.org>
1792
1793         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1794         <rdar://problem/23320863>
1795         https://bugs.webkit.org/show_bug.cgi?id=151708
1796
1797         Reviewed by Anders Carlsson.
1798
1799         * WebKitTestRunner/TestController.cpp:
1800         (WTR::TestController::createOtherPage):
1801         (WTR::TestController::createWebViewWithOptions):
1802         Update for new WKPageUIClient.
1803
1804 2015-12-01  Anders Carlsson  <andersca@apple.com>
1805
1806         Remove WebKit2.framework
1807         https://bugs.webkit.org/show_bug.cgi?id=151715
1808
1809         Reviewed by Dan Bernstein.
1810
1811         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1812         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1813         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1814         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1815         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1816         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1817         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1818
1819 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1820
1821         Unreviewed common typo fix "occurance" => "occurrence".
1822
1823         * Scripts/webkitpy/tool/commands/queries.py:
1824         (FindFlakyTests._print_statistics):
1825
1826 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1827
1828         Make ProcessModel always MultipleSecondaryProcesses
1829         https://bugs.webkit.org/show_bug.cgi?id=151662
1830
1831         Reviewed by Antti Koivisto.
1832
1833         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1834         (TestWebKitAPI::TEST):
1835         * WebKitTestRunner/TestController.cpp:
1836         (WTR::TestController::generatePageConfiguration):
1837
1838 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1839
1840         Make usesNetworkProcess always true
1841         https://bugs.webkit.org/show_bug.cgi?id=151580
1842
1843         Reviewed by Darin Adler.
1844
1845         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1846         (TestWebKitAPI::TEST):
1847         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1848         (TestWebKitAPI::TEST):
1849         * WebKitTestRunner/TestController.cpp:
1850         (WTR::TestController::generatePageConfiguration):
1851
1852 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1853
1854         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1855
1856         Add a way to skip unit tests only for Debug or Release builds and
1857         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1858
1859         * Scripts/run-gtk-tests:
1860         (SkippedTest):
1861         (SkippedTest.__init__):
1862         (SkippedTest.__str__):
1863         (SkippedTest.skip_entire_suite):
1864         (SkippedTest.skip_for_build_type):
1865         (TestRunner):
1866         (TestRunner.__init__):
1867
1868 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1869
1870         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1871
1872         It's an assert hit because we are reloading a view loaded with
1873         HTML data which is not supported. Use loadURI instead.
1874
1875         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1876         (testWebViewCustomCharset):
1877
1878 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1879
1880         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1881         https://bugs.webkit.org/show_bug.cgi?id=151633
1882
1883         Reviewed by Csaba Osztrogonác.
1884
1885         * TestWebKitAPI/PlatformGTK.cmake:
1886         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1887
1888 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1889
1890         [GTK] Remove the remaining uses of GMainLoopSource
1891         https://bugs.webkit.org/show_bug.cgi?id=151632
1892
1893         Reviewed by Žan Doberšek.
1894
1895         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1896         (testWebViewSyncRequestOnMaxConns):
1897         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1898         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1899         (WTR::TestRunner::TestRunner):
1900         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1901         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1902         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1903         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1904         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1905         (WTR::timeoutSource):
1906         (WTR::TestController::notifyDone):
1907         (WTR::TestController::platformRunUntil):
1908
1909 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1910
1911         [cmake] Add testb3 to the build system
1912         https://bugs.webkit.org/show_bug.cgi?id=151619
1913
1914         Reviewed by Gyuyoung Kim.
1915
1916         * Scripts/build-jsc:
1917
1918 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1919
1920         [jhbuild] Fix pixman build with clang
1921         https://bugs.webkit.org/show_bug.cgi?id=151441
1922
1923         Reviewed by Carlos Garcia Campos.
1924
1925         * efl/jhbuild.modules:
1926         * gtk/jhbuild.modules:
1927
1928 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1929
1930         Extract prependToEnvironmentVariableList
1931         <http://webkit.org/b/151536>
1932
1933         Reviewed by Daniel Bates.
1934
1935         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1936                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1937
1938         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1939         and prependToEnvironmentVariableList.
1940         (appendToEnvironmentVariableList): Simplify variable name.
1941         Switch to use $Config{path_sep}.
1942         (prependToEnvironmentVariableList): Add new method.
1943         (setupMacWebKitEnvironment): Switch to use
1944         prependToEnvironmentVariableList().
1945         (setupIOSWebKitEnvironment): Ditto.
1946
1947         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1948         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1949
1950 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1951
1952         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1953         https://bugs.webkit.org/show_bug.cgi?id=151567
1954
1955         Reviewed by Darin Adler.
1956
1957         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1958         (on_window_deletion):
1959
1960 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1961
1962         [GTK] Use the network process unconditionally
1963         https://bugs.webkit.org/show_bug.cgi?id=151541
1964
1965         Reviewed by Alex Christensen.
1966
1967         Fix TestInspectorServer test. Do not assume we already have the
1968         title we want when the page has been loaded, since the title is
1969         changed afterwards. So, check if the title has already been set,
1970         and if not wait for it.
1971
1972         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1973         (openRemoteDebuggingSession):
1974
1975 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1976
1977         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1978         https://bugs.webkit.org/show_bug.cgi?id=151532
1979
1980         Reviewed by Benjamin Poulain.
1981
1982         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1983         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1984         (TestWebKitAPI::TEST):
1985         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1986         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1987         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1988         Properly load about:blank in all WebViews to clean up.  Without this change, we had a
1989         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1990         so it was calling a function on a test object that had gone out of scope.
1991         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1992         but that will become the default soon and that call will be removed.
1993
1994 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1995
1996         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1997         <http://webkit.org/b/151542>
1998
1999         Reviewed by Daniel Bates.
2000
2001         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2002         (base_url): Use the Port object (already passed in) to give us
2003         the path to the LayoutTests directory, which already checks for a
2004         --layout-tests-directory command-line switch.
2005         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2006         argument since we can get this from the Port object already
2007         passed in via Port.results_directory().  Also switch to use
2008         Port.layout_tests_dir() to get the LayoutTests directory.
2009
2010         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2011         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2012         Add test case for custom LayoutTests directory.
2013         (TestWebPlatformTestServer.test_previously_spawned_instance):
2014         Update Port object to set mock results directory as if it was
2015         set on the command-line.  Remove unneeded argument from
2016         WebPlatformTestServer constructor.
2017         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2018
2019         * Scripts/webkitpy/port/base.py:
2020         (Port.to.start_web_platform_test_server): Remove unneeded
2021         argument from WebPlatformTestServer constuctor.
2022
2023 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2024
2025         [GTK] Some unit tests fail when using the network process
2026         https://bugs.webkit.org/show_bug.cgi?id=151490
2027
2028         Reviewed by Martin Robinson.
2029
2030         Run the soup server in a separate thread in TestResources test to
2031         avoid deadlocks.
2032
2033         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2034         /webkit2/WebKitWebResource/get-data when using the network process.
2035
2036         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2037         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2038         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2039         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2040         present, create a WorkQueue to run the server.
2041         (WebKitTestServer::run): Run the server in the work queue if it
2042         has been created.
2043         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2044         type into server options as flags.
2045
2046 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2047
2048         [GTK] ImageDiff should normalize the diff image
2049         https://bugs.webkit.org/show_bug.cgi?id=151261
2050
2051         Reviewed by Sergio Villar Senin.
2052
2053         * ImageDiff/gtk/ImageDiff.cpp:
2054         (readPixbufFromStdin): Fix memory leak.
2055         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2056         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2057
2058 == Rolled over to ChangeLog-2015-11-21 ==