nrwt isn't rejecting unrecognized expectations
[WebKit-https.git] / Tools / ChangeLog
1 2012-12-11  Dirk Pranke  <dpranke@chromium.org>
2
3         nrwt isn't rejecting unrecognized expectations
4         https://bugs.webkit.org/show_bug.cgi?id=104701
5
6         Reviewed by Ojan Vafai.
7
8         NRWT is silently ignoring unrecognized expectations like "Text"
9         and "Audio" (largely because I haven't fully removed support for
10         the old syntax and keywords and restructured the code to do the
11         proper checking). Temporarily change the tokenizer to reject
12         unrecognized expectations until I can make those changes.
13
14         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
15         (TestExpectationParser._tokenize_line):
16         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
17         (ExpectationSyntaxTests.test_unknown_expectation):
18         (TestExpectationSerializationTests.disabled_test_string_whitespace_stripping):
19
20 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
21
22         Fix a typo in my previous commit that is causing test failures.
23
24         Reviewed by Gustavo Noronha Silva.
25
26         There was an extra bit of statement appended after the end of a conditional. Somehow
27         this compiled and caused test failures.
28
29         * DumpRenderTree/gtk/EventSender.cpp:
30         (continuousMouseScrollByCallback):
31
32 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
33
34         [GTK] Spurious stderr output from the event sender
35         https://bugs.webkit.org/show_bug.cgi?id=104678
36
37         Reviewed by Gustavo Noronha Silva.
38
39         Eliminate some spurious stderr output from the EventSender by using an early return
40         instead of an assertion that prints a warning to the console.
41
42         * DumpRenderTree/gtk/EventSender.cpp:
43         (continuousMouseScrollByCallback): We don't support continuous scroll events that
44         move by page, but we should just fail silently instead of printing an error.
45
46 2012-12-11  Joone Hur  <joone.hur@intel.com>
47
48         [GTK] Add GraphicsLayerActor
49         https://bugs.webkit.org/show_bug.cgi?id=91940
50
51         Reviewed by Gustavo Noronha Silva.
52
53         Add GraphicsLayerActor to the list of classes that contain GObjects
54         in the style checker script so that it does not complain about GObject
55         coding style.
56
57         * Scripts/webkitpy/style/checker.py:
58
59 2012-12-11  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
60
61         [Qt] remove hack which avoids unused .obj directories all over the place
62
63         Reviewed by Simon Hausmann.
64
65         The feature is subject to upstreaming in Qt itself in
66         https://codereview.qt-project.org/#change,42011
67
68         * qmake/mkspecs/features/default_post.prf:
69
70 2012-12-11  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
71
72         [Qt] move SQLITE3SRCDIR assignment to only use site
73
74         Reviewed by Simon Hausmann.
75
76         Target.pri includes WebCore.pri the almost first thing, so that is
77         covered as well.
78
79         * qmake/mkspecs/features/default_pre.prf:
80
81 2012-12-11  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
82
83         [Qt] delete dead include paths
84
85         Reviewed by Simon Hausmann.
86
87         followup to https://bugs.webkit.org/show_bug.cgi?id=93446
88
89         * DumpRenderTree/qt/DumpRenderTree.pro:
90
91 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
92
93         [GTK] Implement some missing FrameLoaderClient message in DRT
94         https://bugs.webkit.org/show_bug.cgi?id=104444
95
96         Reviewed by Gustavo Noronha Silva.
97
98         Install a FrameLoadEvent callback that prints the necessary output for some
99         missing FrameLoader events.
100
101         * DumpRenderTree/gtk/DumpRenderTree.cpp:
102         (frameLoadEventCallback): Added.
103         (createWebView): Install the FrameLoader event callback.
104
105 2012-12-11  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
106
107         [Qt] change setup of QMAKE_MOC
108
109         Reviewed by Simon Hausmann.
110
111         don't load(moc) explicitly - turns out that this breaks
112         debug_and_release builds (the feature does not like being loaded before
113         default_post has been loaded).
114         so instead just do a minimal call to find the moc executable.
115
116         as it's in fact only two files which need it, so de-centralize this call
117         for the sake of saving some cpu cycles spent in qmake.
118
119         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
120         * qmake/mkspecs/features/default_pre.prf:
121
122 2012-12-11  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
123
124         [Qt] Fix the linking of debug builds on Mac with force_static_libs_as_shared
125         https://bugs.webkit.org/show_bug.cgi?id=104559
126
127         Reviewed by Tor Arne Vestbø.
128
129         "contains(libraries, $$TARGET): return(true)" fails for intermediate libraries since
130         at this point TARGET may contain the "_debug" suffix.
131
132         Fix it by moving the TARGET adjustment later in the file.
133
134         * qmake/mkspecs/features/default_post.prf:
135
136 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
137
138         [Coverity] [GTK] Remove some redundant null checks in DumpRenderTree
139         https://bugs.webkit.org/show_bug.cgi?id=104570
140
141         Reviewed by Daniel Bates.
142
143         * DumpRenderTree/gtk/DumpRenderTree.cpp:
144         (descriptionSuitableForTestResult): Remove a redundant null check.
145
146 2012-12-11  Alberto Garcia  <agarcia@igalia.com>
147
148         Remove unused GErrors
149         https://bugs.webkit.org/show_bug.cgi?id=104657
150
151         Reviewed by Martin Robinson.
152
153         Replace unused GErrors with null pointers.
154
155         * DumpRenderTree/gtk/DumpRenderTree.cpp:
156         (initializeFonts):
157         * DumpRenderTree/gtk/EditingCallbacks.cpp:
158         (dumpRange):
159         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
160         (WTR::inititializeFontConfigSetting):
161
162 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
163
164         [GTK] Bump the jhbuild libsoup version to fix an authentication issue
165         https://bugs.webkit.org/show_bug.cgi?id=104448
166
167         Reviewed by Gustavo Noronha Silva.
168
169         Bump the libsoup version to one from the git repository. This requires updating
170         GLib as well which in turn requires adjusting the CFLAGS we pass when compiling
171         the scanobj step of the gtkdoc generation.
172
173         * gtk/generate-gtkdoc:
174         * gtk/jhbuild.modules:
175
176 2012-12-11  Zan Dobersek  <zandobersek@gmail.com>
177
178         Unreviewed functionality fix for the GTK port.
179
180         Enable the MicroData feature support for the GTK port in the FeatureList module.
181         This feature listing now again affects which features are enabled and which disabled
182         on the development builds of the GTK port.
183
184         * Scripts/webkitperl/FeatureList.pm:
185
186 2012-12-11  Jinwoo Song  <jinwoo7.song@samsung.com>
187
188         [EFL][WK2] MiniBrowser is not built
189         https://bugs.webkit.org/show_bug.cgi?id=104629
190
191         Reviewed by Gyuyoung Kim.
192
193         As we are finding an elementary package in Tools/MiniBrowser/efl/CMakeList.txt since r137203,
194         we need to check if the package is found in the same place not in the Tools/CMakeList.txt.
195
196         * CMakeLists.txt:
197         * MiniBrowser/efl/CMakeLists.txt:
198
199 2012-12-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
200
201         [GTK][jhbuild] Switch to GStreamer 1.0 build
202         https://bugs.webkit.org/show_bug.cgi?id=91727
203
204         Reviewed by Philippe Normand.
205
206         Switch build-webkit --gtk to GStreamer 1.0 support and build the
207         necessary GStreamer git modules from JHBuild.
208
209         * gtk/jhbuild.modules: Added GStreamer 1.0.3 build support.
210
211 2012-12-11  Zan Dobersek  <zandobersek@gmail.com>
212
213         [GTK] Feature enabling/disabling should be possible through build-webkit
214         https://bugs.webkit.org/show_bug.cgi?id=99271
215
216         Reviewed by Gustavo Noronha Silva.
217
218         Refactor the code in webkitdirs.pm that builds an autotools project to generate
219         autogen.sh arguments, make arguments and installation prefix from the passed-in
220         parameters rather than generating all of that in build-webkit. The autogen.sh
221         arguments now contain only enable/disable flags for options that are actually
222         configurable in configure.ac, the flag value actually reflecting whether the feature
223         is enabled or disabled in the feature list.
224
225         Other features are overridable through modifying the GNUmakefile.features.am file.
226         All these features are now stored in the build directory and upon change trigger
227         a rerun of the autogen.sh script, pretty much like the autogen.sh arguments do.
228
229         The override-feature-defines script is called by autogen.sh, before GNUmakefile.in is
230         generated when calling autoreconf. Its task is to copy the GNUmakefile.features.am.in
231         into GNUmakefile.features.am and modify it if there's a text file in the build directory
232         that contains all the feature defines the build-webkit script has written. If the build
233         is not done through build-webkit (and there's no file in build directory listing all the
234         feature defines) the script does not advance further from copying.
235
236         This approach is taken to overcome the rigidness of the automake system as it's impossible
237         to effectively generate and use GNUmakefile.features.am or even GNUmakefile.features file
238         after the autoreconf command execution in autogen.sh.
239
240         * Scripts/build-jsc:
241         (buildMyProject):
242         * Scripts/build-webkit:
243         * Scripts/webkitdirs.pm:
244         (runAutogenForAutotoolsProjectIfNecessary):
245         (mustReRunAutogen):
246         (buildAutotoolsProject):
247         (buildGtkProject):
248         * Scripts/webkitperl/FeatureList.pm: Update the features that are currently enabled in
249         Source/WebCore/GNUmakefile.features.am.in but aren't in the feature list.
250         * Scripts/webkitpy/style/checker.py: Source/WebCore/GNUmakefile.features.am.in is recognized
251         as a text file and tabulation errors are reported. Skip the file to suppress them.
252         * gtk/override-feature-defines: Added.
253         (copy_feature_defines_makefile):
254         (adjust_feature_defines_makefile):
255         (adjust_feature_defines_makefile.override_feature_define):
256         (override_feature_defines):
257
258 2012-12-10  Yury Semikhatsky  <yurys@chromium.org>
259
260         Memory instrumentation: make sure each edge is reported only once
261         https://bugs.webkit.org/show_bug.cgi?id=104630
262
263         Reviewed by Pavel Feldman.
264
265         Test that outgoing edges are reported only once if we come to the same
266         object twice: first by an address of a base class and then by a real address
267         of the object.
268
269         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
270
271 2012-12-10  Dana Jansens  <danakj@chromium.org>
272
273         [chromium] Remove WebCompositorOutputSurface implementations from DRT
274         https://bugs.webkit.org/show_bug.cgi?id=104046
275
276         Reviewed by Darin Fisher.
277
278         The classes are now provided through WebCompositorSupport.
279
280         * DumpRenderTree/DumpRenderTree.gypi:
281         * DumpRenderTree/chromium/WebViewHost.cpp:
282         (WebViewHost::createOutputSurface):
283         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Removed.
284         * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Removed.
285         * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Removed.
286         * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Removed.
287
288 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
289
290         change --no-launch-safari to --no-show-results in scripts
291         https://bugs.webkit.org/show_bug.cgi?id=104298
292
293         Reviewed by Eric Seidel.
294
295         Since Safari only exists on the Apple ports, NRWT calls the
296         command line flag --[no-]show-results instead. This updates
297         the scripts to use the new flag (but not the buildbot config yet).
298
299         * Scripts/generate-coverage-data:
300         * Scripts/webkit-tools-completion.sh:
301         * Scripts/webkitpy/tool/steps/runtests.py:
302         (RunTests.run):
303         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
304
305 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
306
307         nrwt: fix mapping of AUDIO onto FAIL when printing unexpected results
308         https://bugs.webkit.org/show_bug.cgi?id=104597
309
310         Reviewed by Ojan Vafai.
311
312         This was broken in the recent printer refactoring.
313
314         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
315         (BuildBotPrinter.print_unexpected_results.add_result.is_expected):
316         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
317         (BuildBotPrinterTests.get_result):
318         (BuildBotPrinterTests.test_print_unexpected_results):
319         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
320         (BuildBotPrinterTests):
321
322 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
323
324         old-run-webkit-tests: add --show-results properly
325         https://bugs.webkit.org/show_bug.cgi?id=104608
326
327         Reviewed by Eric Seidel.
328
329         Rework r137219 / bug 104601 to use the correct perl idiom.
330
331         * Scripts/old-run-webkit-tests:
332
333 2012-12-10  Aaron Colwell  <acolwell@chromium.org>
334
335         Unreviewed. Adding Aaron Colwell to the contributor list.
336
337         * Scripts/webkitpy/common/config/committers.py:
338
339 2012-12-10  Anders Carlsson  <andersca@apple.com>
340
341         Remove WebKit2 tests on Windows
342         https://bugs.webkit.org/show_bug.cgi?id=104607
343
344         Reviewed by Tim Horton.
345
346         Stop building WebKit2 tests and remove associated files.
347
348         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Removed.
349         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Removed.
350         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Removed.
351         * TestWebKitAPI/win/TestWebKitAPI.sln: Removed.
352         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
353         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Removed.
354         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Removed.
355         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Removed.
356         * TestWebKitAPI/win/WindowMessageObserver.h: Removed.
357         * TestWebKitAPI/win/copy-resources.cmd: Removed.
358
359 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
360
361         old-run-webkit-tests: support --no-show-results for compatibility w/ NRWT
362         https://bugs.webkit.org/show_bug.cgi?id=104601
363
364         Reviewed by Eric Siedel.
365
366         This flag is being added so we can move all of the calling scripts
367         over to using --no-show-results instead of --no-launch-safari.
368
369         * Scripts/old-run-webkit-tests:
370
371 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
372
373         nrwt: use the default logic for skipping platform-specific tests for chromium
374         https://bugs.webkit.org/show_bug.cgi?id=104403
375
376         Reviewed by Stephen White.
377
378         I thought I had fixed this a while ago, but the chromium port was
379         using custom logic to figure out which platform/* tests to run (or
380         skip) and as a result we were getting some odd behavior (like running
381         tests in chromium-linux on chromium-mac, but only when there was
382         an expectation listed for the test).
383
384         Ports are supposed to only run the tests found under their
385         baseline_search_path() by default.
386
387         Not writing a test for this; theoretically there shouldn't been a
388         test checking that the behavior for Chromium was *different* than
389         the other ports before.
390
391         * Scripts/webkitpy/layout_tests/port/chromium.py:
392         (ChromiumPort._missing_symbol_to_skipped_tests):
393
394 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
395
396         fix regression in test-webkitpy after r137189
397         https://bugs.webkit.org/show_bug.cgi?id=104589
398
399         Reviewed by Eric Seidel.
400
401         Need to specify full port names.
402
403         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
404         (MainTest.test_build_check):
405
406 2012-12-10  Laszlo Gombos  <l.gombos@samsung.com>
407
408         [EFL] Change the minimum required EFL version to 1.6
409         https://bugs.webkit.org/show_bug.cgi?id=104431
410
411         Reviewed by Kenneth Rohde Christiansen.
412
413         Change the minimum required EFL version to 1.6 from 1.7.
414         The elementary EFL package is only required to build MiniBrowser,
415         so I moved the required only to the Minibrowser CMake file.
416
417         * MiniBrowser/efl/CMakeLists.txt: In addition removed
418         ENABLE_GLIB_SUPPORT as it is obsolete and it was always set to be on.
419
420 2012-12-10  Dean Jackson  <dino@apple.com>
421
422         Unreviewed. Adding Antoine to the contributor list so his name autocompletes in bugzilla.
423
424         * Scripts/webkitpy/common/config/committers.py:
425
426 2012-12-10  Zan Dobersek  <zandobersek@gmail.com>
427
428         REGRESSION (r118735): svg/dom/complex-svgView-specification.html, svg/dom/SVGViewSpec.html, svg/dom/viewspec-parser.html failing on GTK Linux 64-bit Release
429         https://bugs.webkit.org/show_bug.cgi?id=87734
430
431         Reviewed by Martin Robinson.
432
433         When willSendRequest should return null in testing, cancel the SoupMessage
434         instead of setting the request's URI to about:blank.
435
436         * DumpRenderTree/gtk/DumpRenderTree.cpp:
437         (willSendRequestCallback):
438
439 2012-12-10  Jochen Eisinger  <jochen@chromium.org>
440
441         [chromium] Move the test implementation of WebKit::WebPlugin to the TestRunner library
442         https://bugs.webkit.org/show_bug.cgi?id=104537
443
444         Reviewed by Tony Chang.
445
446         In order to hide implementation details from the public TestRunner API,
447         I moved the plugin to WebTestPluginImpl and added a static create
448         method to WebTestPlugin. Also, I renamed the plugin from TestWebPlugin
449         to WebTestPlugin to be more in line with other classes in the
450         TestRunner API.
451
452         * DumpRenderTree/DumpRenderTree.gypi:
453         * DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Added.
454         (WebTestRunner):
455         (WebTestPlugin):
456         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestWebPlugin.cpp.
457         (WebTestRunner::WebTestPlugin::create):
458         (WebTestRunner):
459         (WebTestRunner::WebTestPlugin::WebTestPlugin):
460         (WebTestRunner::WebTestPlugin::~WebTestPlugin):
461         (WebTestRunner::WebTestPlugin::mimeType):
462         * DumpRenderTree/chromium/TestWebPlugin.h: Removed.
463         * DumpRenderTree/chromium/WebViewHost.cpp:
464         (WebViewHost::createPlugin):
465
466 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
467
468         run_webkit_tests throws exception when DRT is not present
469         https://bugs.webkit.org/show_bug.cgi?id=104565
470
471         Reviewed by Jochen Eisinger.
472
473         Don't actually try to print the bot results if there aren't
474         any because we exited before running any tests.
475
476         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
477         (main):
478         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
479         (MainTest.test_build_check):
480
481 2012-12-10  Benjamin Poulain  <benjamin@webkit.org>
482
483         Add convenience methods to use ListHashSet for a LRU cache
484         https://bugs.webkit.org/show_bug.cgi?id=104499
485
486         Reviewed by Sam Weinig.
487
488         Test the new methods added to ListHashSet.
489
490         * TestWebKitAPI/CMakeLists.txt:
491         * TestWebKitAPI/GNUmakefile.am:
492         * TestWebKitAPI/TestWebKitAPI.gypi:
493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
494         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp: Added.
495         (TestWebKitAPI):
496         (TestWebKitAPI::TEST):
497
498 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
499
500         webkit-patch print-expectations doesn't work right for platforms w/ shared expectations
501         https://bugs.webkit.org/show_bug.cgi?id=104405
502
503         Reviewed by Eric Seidel.
504
505         If multiple ports shared a TestExpectations file, webkit-patch
506         print-expectations would use the expectation for the first port
507         using that file and print the result for all ports, rather than
508         re-parse and print each port separately (e.g., we might print
509         the chromium-linux expectation for a file for both chromium-linux
510         and chromium-mac). Discovered while testing/debugging the fix
511         for bug 104403.
512
513         * Scripts/webkitpy/layout_tests/port/test.py:
514         (TestPort._skipped_tests_for_unsupported_features):
515         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
516         (lint):
517         * Scripts/webkitpy/tool/commands/queries.py:
518         (PrintExpectations._model):
519         * Scripts/webkitpy/tool/commands/queries_unittest.py:
520         (PrintExpectationsTest.test_platform):
521
522 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
523
524         nrwt: fix total number of tests computed in the result summary
525         https://bugs.webkit.org/show_bug.cgi?id=104061
526
527         Reviewed by Jochen Eisinger.
528
529         Good thing I left this open, because I actually broke it again
530         the same way in a merge. Fix the computation of the one_line_summary
531         again, and add tests for it (also clean up some redundant tests).
532
533         Also, add constants into the test port code so that the knowledge
534         of how many tests should fail and how is next to the list of tests,
535         rather than a totally different place.
536
537         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
538         (LayoutTestRunner.run_tests):
539         * Scripts/webkitpy/layout_tests/port/test.py:
540         (TestList.__getitem__):
541         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
542         (get_test_results):
543         (MainTest.setUp):
544         (MainTest.test_basic):
545         (MainTest.test_run_singly_actually_runs_tests):
546         (MainTest.test_test_list_with_prefix):
547         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code.CustomExitCodePort):
548         (MainTest.test_tolerance.ImageDiffTestPort):
549         (EndToEndTest.parse_full_results):
550
551 2012-12-10  Mike West  <mkwst@chromium.org>
552
553         Log to console when script is blocked by sandbox attributes.
554         https://bugs.webkit.org/show_bug.cgi?id=104365
555
556         Reviewed by Ojan Vafai.
557
558         * Scripts/webkitpy/performance_tests/perftest.py:
559         (PerfTest):
560             Ignoring the new console message in perftests, as it broke parsing
561             for the Parser/html-parser.html microbenchmark.
562
563 2012-12-10  Filip Pizlo  <fpizlo@apple.com>
564
565         JSC profiling and debug dump code should use inferred names when possible
566         https://bugs.webkit.org/show_bug.cgi?id=104519
567
568         Reviewed by Oliver Hunt.
569
570         The format I'm using for referring to a code block is now name#hash. For example,
571         v8-crypto has something called bnpSquareTo#B5QFbU. The profiler allows you to use
572         either the hash, the inferred name, or the combined hash and full name when referring
573         to blocks.
574
575         * Scripts/display-profiler-output:
576
577 2012-12-09  Filip Pizlo  <fpizlo@apple.com>
578
579         Profiler should say things about OSR exits
580         https://bugs.webkit.org/show_bug.cgi?id=104497
581
582         Reviewed by Oliver Hunt.
583
584         Adds support for displaying OSR exit information for full summary (just displays the
585         counts and the number of recompilations), bytecode display (says which bytecodes
586         exited), and DFG display (annotates disassembly with taken OSR exits and their
587         counts).
588
589         * Scripts/display-profiler-output:
590
591 2012-12-10  Alexis Menard  <alexis@webkit.org>
592
593         [CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag.
594         https://bugs.webkit.org/show_bug.cgi?id=104539
595
596         Reviewed by Antonio Gomes.
597
598         As discussed on webkit-dev it is not needed to keep this feature flag 
599         as support for <position> type is a small feature that is already 
600         implemented by three other UAs. It was useful while landing this 
601         feature as partial bits were landed one after one.
602
603         * Scripts/webkitperl/FeatureList.pm:
604         * qmake/mkspecs/features/features.pri:
605
606 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
607
608         Build fix.
609
610         Add a patchfile missing from my previous commit.
611
612         * gtk/patches/harfbuzz-icu-detection-fix.patch: Added.
613
614 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
615
616         REGRESSION(137127): Causes assertion failures on the debug bots
617         https://bugs.webkit.org/show_bug.cgi?id=104549
618
619         Reviewed by Alejandro G. Castro.
620
621         After handling the new TextOutput message we should return the method
622         handling messages received.
623
624         * WebKitTestRunner/TestInvocation.cpp:
625         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a missing early return.
626
627 2012-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
628
629         [Soup] utilize multipart/x-mixed-replace support recently added to libsoup
630         https://bugs.webkit.org/show_bug.cgi?id=94515
631
632         Reviewed by Martin Robinson.
633
634         This change requires a very recent libsoup, so update our jhbuild
635         requirements.
636
637         * gtk/jhbuild.modules: depend on soup version that adds the multipart/x-mixed-replace
638         support
639         * efl/jhbuild.modules: ditto
640
641 2012-12-10  Zoltan Nyul  <zoltan.nyul@intel.com>
642
643         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner
644         https://bugs.webkit.org/show_bug.cgi?id=103886
645
646         Reviewed by Kenneth Rohde Christiansen.
647
648         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner.
649         This API is required by layout tests.
650
651         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
652         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
653         (WTR::TestRunner::setViewModeMediaFeature):
654         (WTR):
655         * WebKitTestRunner/InjectedBundle/TestRunner.h:
656         (TestRunner):
657
658 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
659
660         [GTK] Bring Harfbuzz-ng support to Gtk
661         https://bugs.webkit.org/show_bug.cgi?id=92098
662
663         Reviewed by Gustavo Noronha Silva.
664
665         Add HarfBuzz dependency.
666
667         * GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the WebCore Internals library.
668         * gtk/jhbuild.modules: Add HarfBuzz to the JHbuild and remove Pango, since it
669         should no longer affect layout test results.
670
671 2012-12-10  Simon Hausmann  <simon.hausmann@digia.com>
672
673         [Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally
674         https://bugs.webkit.org/show_bug.cgi?id=104541
675
676         Reviewed by Jocelyn Turcotte.
677
678         We now depend on a Qt 5 version that is guaranteed to have this API, so we
679         can remove the configure checks for it.
680
681         * qmake/config.tests/libexecdir/libexecdir.cpp: Removed.
682         * qmake/config.tests/libexecdir/libexecdir.pro: Removed.
683         * qmake/mkspecs/features/features.prf:
684
685 2012-12-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
686
687         REGRESSION(r135863): GtkLauncher --help no longer displays all help options
688         https://bugs.webkit.org/show_bug.cgi?id=104382
689
690         Reviewed by Philippe Normand.
691
692         Remove gst_init() because it steals the GOptionContext.
693         gst_init_get_option_group() already does the initialization job.
694
695         * GtkLauncher/main.c:
696         (main):
697
698 2012-12-10  Zan Dobersek  <zandobersek@gmail.com>
699
700         [GTK][WTR] Implement AccessibilityUIElement::titleUIElement
701         https://bugs.webkit.org/show_bug.cgi?id=102953
702
703         Reviewed by Martin Robinson.
704
705         Implement AccessibilityUIElement::titleUIElement in the ATK backend
706         in the same manner it is implemented in DumpRenderTree. Both implementations
707         are updated to unref the relation set before the final function return
708         rather than at the end of each loop through the relations held in the said
709         relation set.
710
711         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
712         (AccessibilityUIElement::titleUIElement):
713         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
714         (WTR::AccessibilityUIElement::titleUIElement):
715
716 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
717
718         Fix the WebKit2 debug build
719
720         * WebKitTestRunner/TestInvocation.cpp:
721         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a typo of WKStringGetTypeID().
722
723 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
724
725         [WTR] Move text output accumulation to the UIProcess
726         https://bugs.webkit.org/show_bug.cgi?id=104214
727
728         Reviewed by Darin Adler.
729
730         Instead of accumulating text output in the InjectedBundle and then sending it to the UIProcess 
731         once a test is finished, immediately send any text output to the UIProcess. This will allow
732         WebKitTestRunner to output text from the UIProcess as well.
733
734         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Remove the handling of the text output
735         StringBuilder. Add a method to send output to the UIProcess.
736         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
737         (InjectedBundle):
738         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Change code that appends to the StringBuilder
739         to use the new outputText method.
740         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
741         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
742         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Ditto.
743         * WebKitTestRunner/TestInvocation.cpp:
744         (WTR::TestInvocation::TestInvocation): Intialize the StringBuilder.
745         (WTR::TestInvocation::invoke): Clear the StringBuilder when a new tests starts.
746         (WTR::TestInvocation::dumpResults): m_textOutput is a StringBuilder now so the
747         method of printing the text is slightly different.
748         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the new TextOutput
749         message by appending the results to the StringBuilder.
750         * WebKitTestRunner/TestInvocation.h:
751         (TestInvocation): Switch the type of m_textOutput.
752
753 2012-12-10  Mihnea Ovidenie  <mihnea@adobe.com>
754
755         Unreviewed. Adding Mihai Maerean to the list of contributors, working on CSSRegions.
756
757         * Scripts/webkitpy/common/config/committers.py:
758
759 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
760
761         [GTK] accessibility/language-attribute.html is failing
762         https://bugs.webkit.org/show_bug.cgi?id=98369
763
764         Reviewed by Chris Fleizach.
765
766         The test is failing for two reasons: Not exposing the language
767         for accessible objects and AccessibilityUIElement::language() not
768         being implemented.
769
770         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
771         (AccessibilityUIElement::language): Implemented.
772
773 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
774
775         [GTK] accessibility/editable-webarea-context-menu-point.html is failing
776         https://bugs.webkit.org/show_bug.cgi?id=98364
777
778         Reviewed by Chris Fleizach.
779
780         The test is failing because the clickPoint values remain unchanged. The
781         values remain unchanged because ATK lacks a means to keep track of this
782         information.
783
784         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
785         (AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
786         (AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details
787
788 2012-12-09  Alejandro Piñeiro  <apinheiro@igalia.com>
789
790         [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
791         https://bugs.webkit.org/show_bug.cgi?id=104481
792
793         Reviewed by Martin Robinson.
794
795         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
796         (AccessibilityUIElement::isSelectable): Implement this by checking
797         the current state of the AtkObject.
798         (AccessibilityUIElement::isMultiSelectable): Implement this by
799         checking the current state of the AtkObject.
800
801 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
802
803         [GTK] accessibility/placeholder.html is failing
804         https://bugs.webkit.org/show_bug.cgi?id=98373
805
806         Reviewed by Martin Robinson.
807
808         The test was failing because the placeholder text was not supported and
809         AccessibilityUIElement::stringAttributeValue() was not implemented.
810
811         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
812         (coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
813         names into AtkObject attribute names
814         (AccessibilityUIElement::stringAttributeValue): implemented
815
816 2012-12-09  Dan Winship  <danw@gnome.org>
817
818         [GTK] Bump libxml2 requirement in jhbuild.modules
819         https://bugs.webkit.org/show_bug.cgi?id=104477
820
821         Reviewed by Martin Robinson.
822
823         Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
824         tests won't run if we only have libxml2 2.8.0 installed in the
825         jhbuild root.
826
827         * gtk/jhbuild.modules:
828
829 2012-12-09  Zan Dobersek  <zandobersek@gmail.com>
830
831         Remove testRunner.disableImageLoading()
832         https://bugs.webkit.org/show_bug.cgi?id=98083
833
834         Reviewed by Gustavo Noronha Silva.
835
836         Remove the disableImageLoading methods and callback.
837         No tests use the method anymore and all ports except Wx
838         now support this behavior through overriding the
839         WebKitDisplayImagesKey preference.
840
841         * DumpRenderTree/TestRunner.cpp:
842         (TestRunner::staticFunctions):
843         * DumpRenderTree/TestRunner.h:
844         (TestRunner):
845         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
846         (TestRunner::overridePreference): Add support for overriding the
847         WebKitDisplayImagesKey preference which is now the preferred way
848         of disabling image loading.
849         * DumpRenderTree/efl/TestRunnerEfl.cpp:
850         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
851         * DumpRenderTree/mac/TestRunnerMac.mm:
852         * DumpRenderTree/qt/TestRunnerQt.cpp:
853         * DumpRenderTree/qt/TestRunnerQt.h:
854         (TestRunner):
855         * DumpRenderTree/win/TestRunnerWin.cpp:
856         * DumpRenderTree/wx/TestRunnerWx.cpp:
857
858 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
859
860         [GTK] accessibility/label-for-control-hittest.html is failing
861         https://bugs.webkit.org/show_bug.cgi?id=98368
862
863         Reviewed by Martin Robinson.
864
865         The test was failing because AccessibilityUIElement::elementAtPoint was
866         not implemented.
867
868         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
869         (AccessibilityUIElement::elementAtPoint): implemented
870
871 2012-12-09  Jon Lee  <jonlee@apple.com>
872
873         [WK2] Move button image to injected bundle
874         https://bugs.webkit.org/show_bug.cgi?id=104107
875         <rdar://problem/12813842>
876
877         Reviewed by Simon Fraser.
878
879         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
880         (WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.
881
882 2012-12-08  Halton Huo  <halton.huo@intel.com>
883
884         [CMake] Add CMake style checker
885         https://bugs.webkit.org/show_bug.cgi?id=104240
886
887         Reviewed by Eric Seidel.
888
889         The CMake style checker is followed by existing style checkers like cpp, python.
890         Unit test is added as well.
891
892         * Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)
893         (FileType):
894         (CheckerDispatcher._file_type):
895         (CheckerDispatcher._create_checker):
896         * Scripts/webkitpy/style/checkers/cmake.py: Added.
897         (CMakeChecker):
898         (CMakeChecker.__init__): 
899         (CMakeChecker.check):
900         (CMakeChecker._process_line):
901         (CMakeChecker._check_trailing_whitespace):
902         (CMakeChecker._check_no_space_cmds):
903         (CMakeChecker._check_one_space_cmds):
904         (CMakeChecker._check_non_lowercase_cmd):
905         (CMakeChecker._check_indent):
906         * Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.
907         (CMakeCheckerTest):
908         (CMakeCheckerTest.test_init):
909         (CMakeCheckerTest.test_init._mock_handle_style_error):
910         (CMakeCheckerTest.test_check):
911         (CMakeCheckerTest.test_check._mock_handle_style_error):
912
913 2012-12-08  Kondapally Kalyan  <kalyan.kondapally@intel.com>
914
915         [EFL] Enable WebGL by default.
916         https://bugs.webkit.org/show_bug.cgi?id=102991.
917
918         Reviewed by Kenneth Rohde Christiansen.
919
920         Enable WebGL by default.
921
922         * Scripts/webkitperl/FeatureList.pm:
923
924 2012-12-07  Scott Violet  <sky@chromium.org>
925
926         [chromium] Remove linux theme related files and switch to default
927         https://bugs.webkit.org/show_bug.cgi?id=103897
928
929         Reviewed by Dimitri Glazkov.
930
931         * Scripts/webkitpy/common/config/build_unittest.py:
932         (ShouldBuildTest): linux->default
933
934 2012-12-07  Mike Lattanzio  <mlattanzio@rim.com>
935
936         [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
937         https://bugs.webkit.org/show_bug.cgi?id=104121
938
939         Reviewed by Rob Buis.
940
941         Update createBuffer call to reflect new BufferType enum.
942         Internal PR 254649
943         Internal Review: Jakob Petsovits
944
945         DRT is always backed for maximum compatibility.
946
947         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
948         (createBitmapContextFromWebView):
949
950 2012-12-07  Jochen Eisinger  <jochen@chromium.org>
951
952         Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
953         https://bugs.webkit.org/show_bug.cgi?id=104355
954
955         Reviewed by Dirk Pranke.
956
957         This enables chromium's content_shell driver to run with the full SUID
958         sandbox.
959
960         * Scripts/webkitpy/layout_tests/port/base.py:
961         (Port.to.setup_environ_for_server):
962
963 2012-12-07  KyungTae Kim  <ktf.kim@samsung.com>
964
965         [EFL] Fix tools for WebKit2-only builds
966         https://bugs.webkit.org/show_bug.cgi?id=103904
967
968         Reviewed by Laszlo Gombos.
969
970         The libewebkit2.so should be used for library path for EFL WebKit2.
971
972         * Scripts/webkitdirs.pm:
973         (builtDylibPathForName):
974
975 2012-12-07  Xiaobo Wang  <xbwang@torchmobile.com.cn>
976
977         [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
978         https://bugs.webkit.org/show_bug.cgi?id=104243
979
980         RIM PR 259337
981
982         Reviewed by Rob Buis.
983
984         1. Implement calculation of navigation originating in
985         didDecidePolicyForNavigationAction().
986         2. Implement policy delegate for resource response.
987         3. Enable customPolicyDelegate if waitForPolicyDelegate() is called.
988         4. Minor optional updates in dump() and dumpFrameLoadCallbacks().
989
990         The patch fixed the following tests:
991         - http/tests/download
992         - fast/forms/mailto/formenctype-attribute-button-html.html
993         - fast/forms/mailto/formenctype-attribute-input-html.html
994         - fast/encoding/mailto-always-utf-8.html
995
996         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
997         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
998         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
999         (BlackBerry::WebKit::DumpRenderTree::dump):
1000         (BlackBerry::WebKit::DumpRenderTree::didFinishLoadForFrame):
1001         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForNavigationAction):
1002         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForResponse):
1003         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate):
1004         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1005         (DumpRenderTree):
1006         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1007         (TestRunner::setCustomPolicyDelegate):
1008         (TestRunner::waitForPolicyDelegate):
1009         (TestRunner::overridePreference):
1010
1011 2012-12-07  Gwang Yoon Hwang  <ryumiel@company100.net>
1012
1013         [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
1014         https://bugs.webkit.org/show_bug.cgi?id=104348
1015
1016         Reviewed by Csaba Osztrogonác.
1017
1018         After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to
1019         Qt5WebKitWidgets. run-webkit-tests were still looking for QtWebKitWidgets
1020
1021         * Scripts/webkitpy/layout_tests/port/qt.py:
1022         (QtPort._path_to_webcore_library):
1023
1024 2012-12-07  Csaba Osztrogonác  <ossy@webkit.org>
1025
1026         Unreviewed fix, unbreak run-launcher after library renaming.
1027
1028         * Scripts/webkitdirs.pm:
1029         (builtDylibPathForName):
1030
1031 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1032
1033         Unreviewed fix after r136896, unbreak --debug-rwt to make bots result verbose again.
1034         https://bugs.webkit.org/show_bug.cgi?id=104296
1035
1036         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1037         (main):
1038
1039 2012-12-06  Rick Byers  <rbyers@chromium.org>
1040
1041         CSS cursor property should support webkit-image-set
1042         https://bugs.webkit.org/show_bug.cgi?id=99493
1043
1044         Reviewed by Beth Dakin.
1045
1046         Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default
1047
1048         * Scripts/webkitperl/FeatureList.pm:
1049         * qmake/mkspecs/features/features.pri:
1050
1051 2012-12-06  Vivek Galatage  <vivek.vg@samsung.com>
1052
1053         Unreviewed. Fixing the email address order to work correctly with bugzilla.
1054
1055         * Scripts/webkitpy/common/config/committers.py:
1056
1057 2012-12-06  Jochen Eisinger  <jochen@chromium.org>
1058
1059         [chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
1060         https://bugs.webkit.org/show_bug.cgi?id=104306
1061
1062         Reviewed by Dimitri Glazkov.
1063
1064         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1065         (TestWebPlugin::TestWebPlugin):
1066         (TestWebPlugin::handleInputEvent): add support for printing the user gesture status
1067         * DumpRenderTree/chromium/TestWebPlugin.h:
1068         (TestWebPlugin):
1069
1070 2012-12-06  Dirk Pranke  <dpranke@chromium.org>
1071
1072         new-run-webkit-tests --lint-test-files seems to be broken
1073         https://bugs.webkit.org/show_bug.cgi?id=104296
1074
1075         Unreviewed, build fix.
1076
1077         My recent refactoring caused me to not initialize the printer
1078         before calling lint(); this patch restructures the code to make
1079         the lint routine self-contained and do all the work necessary.
1080         This will also make it easier to move this code out into a standalone
1081         file.
1082
1083         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1084         (lint):
1085         (main):
1086         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1087         (LintTest.test_all_configurations):
1088         (LintTest.test_lint_test_files):
1089         (LintTest.test_lint_test_files__errors):
1090
1091 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1092
1093         DFG profiler should be helpful about gem installation
1094         https://bugs.webkit.org/show_bug.cgi?id=104217
1095
1096         Reviewed by Oliver Hunt.
1097         
1098         'json' and 'highline' are not installed by default on the ruby distributions with
1099         which I am familiar, and the default error messages don't make me happy. This makes
1100         display-profiler-output print a helpful message if those gems are not found.
1101
1102         * Scripts/display-profiler-output:
1103
1104 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1105
1106         Profiler should print a helpful message if you pass the wrong arguments
1107         https://bugs.webkit.org/show_bug.cgi?id=104222
1108
1109         Reviewed by Oliver Hunt.
1110
1111         * Scripts/display-profiler-output:
1112
1113 2012-12-06  Ojan Vafai  <ojan@chromium.org>
1114
1115         Allow for CCing a secondary email address from watchlists
1116         https://bugs.webkit.org/show_bug.cgi?id=104286
1117
1118         Reviewed by Dirk Pranke.
1119
1120         Change my watchlist CC address so I can filter these separately from
1121         when people explicitly CC me and update the watchlist parser to allow that.
1122
1123         * Scripts/webkitpy/common/config/committers.py:
1124         * Scripts/webkitpy/common/config/watchlist:
1125         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1126         (WatchListParser._validate):
1127         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1128         (WatchListParserTest.test_cc_rule_with_invalid_email):
1129         (WatchListParserTest.test_cc_rule_with_secondary_email):
1130
1131 2012-12-06  Max Vujovic  <mvujovic@adobe.com>
1132
1133         Unreviewed. Add myself to committers.py.
1134
1135         * Scripts/webkitpy/common/config/committers.py:
1136
1137 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
1138
1139         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
1140         https://bugs.webkit.org/show_bug.cgi?id=104139
1141
1142         Reviewed by Kenneth Rohde Christiansen.
1143
1144         Resize the window back to 800x600 between tests.
1145         This should be a no-op if the test did not resize the window.
1146
1147         * WebKitTestRunner/TestController.cpp:
1148         (WTR::TestController::resetStateToConsistentValues):
1149
1150 2012-12-06  Tommy Widenflycht  <tommyw@google.com>
1151
1152         Speech Recognition API: Change the error code to a string on SpeechRecognitionError
1153         https://bugs.webkit.org/show_bug.cgi?id=104254
1154
1155         Reviewed by Adam Barth.
1156
1157         Changes the mock error function to take a string instead of an int.
1158
1159         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1160         (DRTTestRunner::setMockSpeechRecognitionError):
1161         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1162         (WebTestRunner::ErrorTask::ErrorTask):
1163         (MockWebSpeechRecognizer::setError):
1164         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
1165         (MockWebSpeechRecognizer):
1166
1167 2012-12-06  Andras Becsi  <andras.becsi@digia.com>
1168
1169         [Qt][Mac] Fix libxslt and libxml2 config tests
1170         https://bugs.webkit.org/show_bug.cgi?id=104164
1171
1172         Reviewed by Simon Hausmann.
1173
1174         We should not use pkg-config on Mac instead use direct include
1175         paths and add needed libraries to the linker options to detect
1176         libxslt and libxml2 provided by the system.
1177         Previously we would always fall back to qtxmlpatterns.
1178
1179         * qmake/config.tests/libxml2/libxml2.pro:
1180         * qmake/config.tests/libxslt/libxslt.pro:
1181
1182 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1183
1184         [Qt] Fix the build if the path contains "+" character
1185         https://bugs.webkit.org/show_bug.cgi?id=104120
1186
1187         Reviewed by Tor Arne Vestbø.
1188
1189         The second parameter of qmake's replace() is regular expression, so
1190         we have to escape special characters in paths passed to replace().
1191
1192         * qmake/mkspecs/features/default_post.prf:
1193         * qmake/mkspecs/features/default_pre.prf:
1194         * qmake/mkspecs/features/functions.prf:
1195
1196 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1197
1198         Unreviewed, rolling out r136825.
1199         http://trac.webkit.org/changeset/136825
1200         https://bugs.webkit.org/show_bug.cgi?id=104251
1201
1202         It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
1203         flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).
1204
1205         * WebKitTestRunner/TestController.cpp:
1206         (WTR::TestController::resetStateToConsistentValues):
1207
1208 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
1209
1210         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
1211         https://bugs.webkit.org/show_bug.cgi?id=104139
1212
1213         Reviewed by Kenneth Rohde Christiansen.
1214
1215         Resize the window back to 800x600 between tests.
1216         This should be a no-op if the test did not resize the window.
1217
1218         * WebKitTestRunner/TestController.cpp:
1219         (WTR::TestController::resetStateToConsistentValues):
1220
1221 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1222
1223         Unreviewed, rolling out r136784 and r136802.
1224         http://trac.webkit.org/changeset/136784
1225         http://trac.webkit.org/changeset/136802
1226         https://bugs.webkit.org/show_bug.cgi?id=104231
1227
1228         breaks chromium canary (Requested by morrita on #webkit).
1229
1230         * Scripts/webkitpy/common/config/build_unittest.py:
1231         (ShouldBuildTest):
1232
1233 2012-12-05  Ryosuke Niwa  <rniwa@webkit.org>
1234
1235         Add myself to watch changes in PerformanceTests/*.
1236
1237         * Scripts/webkitpy/common/config/watchlist:
1238
1239 2012-12-05  Shinya Kawanaka  <shinyak@chromium.org>
1240
1241         [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
1242         https://bugs.webkit.org/show_bug.cgi?id=102459
1243
1244         Reviewed by Dimitri Glazkov.
1245
1246         Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
1247
1248         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1249         (WebThemeControlDRTWin::markState):
1250
1251 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1252
1253         DFG profiler should be able to display where a code block was inlined into, and what it inlined
1254         https://bugs.webkit.org/show_bug.cgi?id=104216
1255
1256         Reviewed by Oliver Hunt.
1257
1258         Added an "inlines" command that shows the inline stacks that a code block participated
1259         in. Also cleaned up some of the ways we print compilation units.
1260
1261         * Scripts/display-profiler-output:
1262
1263 2012-12-05  Halton Huo  <halton.huo@intel.com>
1264
1265         [CMake] Unify coding style for CMake files
1266         https://bugs.webkit.org/show_bug.cgi?id=103605
1267
1268         Reviewed by Laszlo Gombos.
1269
1270         Update cmake files(.cmake, CMakeLists.txt) with following style rules:
1271         1. Indentation
1272         1.1 Use spaces, not tabs.
1273         1.2 Four spaces as indent.
1274         2. Spacing
1275         2.1 Place one space between control statements and their parentheses.
1276             For eg, if (), else (), elseif (), endif (), foreach (),
1277             endforeach (), while (), endwhile (), break ().
1278         2.2 Do not place spaces between function and macro statements and
1279             their parentheses. For eg, macro(), endmacro(), function(),
1280             endfunction().
1281         2.3 Do not place spaces between a command or function or macro and its
1282             parentheses, or between a parenthesis and its content. For eg,
1283             message("testing") not message( "testing") or message ("testing" )
1284         2.4 No space at line ending.
1285         3. Lowercase when call commands macros and functions. For eg,
1286            add_executable() not ADD_EXECUTABLE(), set() not SET().
1287
1288         * CMakeLists.txt:
1289         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1290         * DumpRenderTree/efl/CMakeLists.txt:
1291         * EWebLauncher/CMakeLists.txt:
1292         * EWebLauncher/ControlTheme/CMakeLists.txt:
1293         * MiniBrowser/efl/CMakeLists.txt:
1294         * TestWebKitAPI/CMakeLists.txt:
1295         * TestWebKitAPI/PlatformEfl.cmake:
1296         * WebKitTestRunner/CMakeLists.txt:
1297         * WebKitTestRunner/PlatformEfl.cmake:
1298         * WinCELauncher/CMakeLists.txt:
1299         * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
1300
1301 2012-12-05  Scott Violet  <sky@chromium.org>
1302
1303         [chromium] Remove linux theme related files and switch to default
1304         https://bugs.webkit.org/show_bug.cgi?id=103897
1305
1306         Reviewed by Tony Chang.
1307
1308         * Scripts/webkitpy/common/config/build_unittest.py:
1309         (ShouldBuildTest): linux->default
1310
1311 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1312
1313         nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
1314         https://bugs.webkit.org/show_bug.cgi?id=78168
1315
1316         Reviewed by Ojan Vafai.
1317
1318         This patch adds a single ordered list to ResultSummary that contains
1319         the results of every test run in order of result received, and
1320         modifies the TestResults class to contain the list of references used
1321         for each test as well as the pid of the driver; this allows us to stop
1322         having to override the test drivers to record the tests, and makes the
1323         integration tests that test rdering, retries, restarts, etc. black-box
1324         tests.
1325
1326         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1327         (SingleTestRunner._run_rebaseline):
1328         (SingleTestRunner._compare_output):
1329         (SingleTestRunner._run_reftest):
1330         (SingleTestRunner._compare_output_with_reference):
1331         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1332         (ResultSummary.__init__):
1333         (ResultSummary.add):
1334         * Scripts/webkitpy/layout_tests/models/test_results.py:
1335         (TestResult.__init__):
1336         * Scripts/webkitpy/layout_tests/port/driver.py:
1337         (DriverOutput.__init__):
1338         (Driver.run_test):
1339         * Scripts/webkitpy/layout_tests/port/test.py:
1340         (TestDriver):
1341         (TestDriver.__init__):
1342         (TestDriver.run_test):
1343         (TestDriver.stop):
1344         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1345         (get_tests_run):
1346         (get_test_batches):
1347         (get_test_results):
1348         (MainTest.test_batch_size):
1349         (MainTest.test_dryrun):
1350         (MainTest.test_natural_order):
1351         (MainTest.test_natural_order_test_specified_multiple_times):
1352         (MainTest.test_random_order):
1353         (MainTest.test_random_order_test_specified_multiple_times):
1354         (MainTest.test_no_order):
1355         (MainTest.test_no_order_test_specified_multiple_times):
1356         (MainTest.test_no_order_with_directory_entries_in_natural_order):
1357         (MainTest.test_repeat_each):
1358         (MainTest.test_ignore_flag):
1359         (MainTest.test_skipped_flag):
1360         (MainTest.test_iterations):
1361         (MainTest.test_run_chunk):
1362         (MainTest.test_run_part):
1363         (MainTest.test_run_singly):
1364         (MainTest.test_skip_failing_tests):
1365         (MainTest.test_single_file):
1366         (MainTest.test_single_file_with_prefix):
1367         (MainTest.test_single_skipped_file):
1368         (MainTest.test_test_list):
1369         (MainTest.test_test_list_with_prefix):
1370         (MainTest.test_exit_after_n_failures):
1371         (MainTest.test_exit_after_n_crashes):
1372         (MainTest.test_run_order__inline):
1373         (MainTest.test_reftest_run):
1374         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
1375         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
1376         (MainTest.test_reftest_expected_html_should_be_ignored):
1377         (MainTest.test_reftest_driver_should_run_expected_html):
1378         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
1379         (MainTest.test_no_http_tests):
1380         (MainTest.test_platform_tests_are_found):
1381
1382 2012-12-05  Dana Jansens  <danakj@chromium.org>
1383
1384         [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
1385         https://bugs.webkit.org/show_bug.cgi?id=103967
1386
1387         Reviewed by James Robinson.
1388
1389         Use the WebCompositorSupport methods to create an OutputSurface. If they
1390         fail, then fall back to the WebViewHost methods.
1391
1392         Once the chromium side lands, the WebCompositorSupport methods will stop
1393         failing, and will replace the WebViewHost ones.
1394
1395         * DumpRenderTree/chromium/WebViewHost.cpp:
1396         (WebViewHost::createOutputSurface):
1397
1398 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1399
1400         nrwt: split all of the buildbot-specific output into its own file
1401         https://bugs.webkit.org/show_bug.cgi?id=104165
1402
1403         Reviewed by Ojan Vafai.
1404
1405         Now that we have the RunDetails object we can move all of the
1406         buildbot-specific knowledge out of the core test-running code
1407         and into the outermost run_webkit_tests layer.
1408
1409         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1410         (run):
1411         (main):
1412         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1413         (passing_run):
1414         (logging_run):
1415         (run_and_capture):
1416         (MainTest.test_all):
1417         (MainTest.test_max_locked_shards):
1418         (MainTest.test_child_processes_2):
1419         (MainTest.test_child_processes_min):
1420         (MainTest.test_full_results_html):
1421         (MainTest.test_hung_thread):
1422         (MainTest.test_keyboard_interrupt):
1423         (MainTest.test_no_tests_found):
1424         (MainTest.test_no_tests_found_2):
1425         (MainTest.test_repeat_each_iterations_num_tests):
1426         (MainTest.test_run_singly_actually_runs_tests):
1427         (MainTest.test_test_list):
1428         (MainTest.test_unexpected_failures):
1429         (MainTest.test_missing_and_unexpected_results):
1430         (MainTest.test_pixel_test_directories):
1431         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
1432         (MainTest.test_crash_with_stderr):
1433         (MainTest.test_no_image_failure_with_image_diff):
1434         (MainTest.test_crash_log):
1435         (MainTest.test_web_process_crash_log):
1436         (MainTest.test_exit_after_n_failures_upload):
1437         (MainTest.test_results_directory_absolute):
1438         (MainTest.test_results_directory_default):
1439         (MainTest.test_results_directory_relative):
1440         (MainTest.test_retrying_and_flaky_tests):
1441         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1442         (MainTest.test_output_diffs):
1443         (MainTest.test_unsupported_platform):
1444         (MainTest.test_verbose_in_child_processes):
1445         (EndToEndTest.test_end_to_end):
1446         (EndToEndTest.test_reftest_with_two_notrefs):
1447         (RebaselineTest.test_reset_results):
1448         (RebaselineTest.test_missing_results):
1449         (RebaselineTest.test_new_baseline):
1450         * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
1451         (BuildBotPrinter):
1452         (BuildBotPrinter.__init__):
1453         (BuildBotPrinter.print_results):
1454         (BuildBotPrinter._print):
1455         (BuildBotPrinter.print_result_summary):
1456         (BuildBotPrinter._print_result_summary_entry):
1457         (BuildBotPrinter.print_unexpected_results):
1458         (BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
1459         (BuildBotPrinter.print_unexpected_results.add_result):
1460         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
1461         (BuildBotPrinterTests):
1462         (BuildBotPrinterTests.assertEmpty):
1463         (BuildBotPrinterTests.assertNotEmpty):
1464         (BuildBotPrinterTests.get_printer):
1465         (BuildBotPrinterTests.get_result):
1466         (BuildBotPrinterTests.get_result_summary):
1467         (BuildBotPrinterTests.test_print_unexpected_results):
1468         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
1469         * Scripts/webkitpy/layout_tests/views/printing.py:
1470         (Printer):
1471         (Printer.__init__):
1472         (Printer.print_results):
1473         (Printer._print_statistics_for_test_timings):
1474         (Printer._print_baseline):
1475         (Printer._print_debug):
1476         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1477         (Testprinter.get_printer):
1478         (Testprinter.get_result):
1479         (Testprinter.test_configure_and_cleanup):
1480         (Testprinter.test_print_config):
1481         (Testprinter.test_print_one_line_summary):
1482         (Testprinter.test_test_status_line):
1483         (Testprinter.test_details):
1484
1485 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1486
1487         nrwt: collect all of the information about a run into a new RunDetails class
1488         https://bugs.webkit.org/show_bug.cgi?id=104158
1489
1490         Reviewed by Ojan Vafai.
1491
1492         This patch collects the information from both test passes (the
1493         main one and the retries) as well as the summarized results and
1494         the exit code into a RunDetails class, so that the integration
1495         tests can more easily tell what happened.
1496
1497         Also, change the way the --lint-test-files works slightly so that
1498         we don't need to create a printer object (and hence we need to
1499         rework the tests that are testing logging).
1500
1501         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1502         (RunDetails):
1503         (RunDetails.__init__):
1504         (Manager.run):
1505         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1506         (run):
1507         (main):
1508         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1509         (passing_run):
1510         (run_and_capture):
1511         (LintTest.test_lint_test_files):
1512         (LintTest.test_lint_test_files__errors):
1513         (MainTest.test_verbose_in_child_processes):
1514
1515 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1516
1517         nrwt: remove --no-record-results
1518         https://bugs.webkit.org/show_bug.cgi?id=104072
1519
1520         Reviewed by Ojan Vafai.
1521
1522         The command line flag was only being used in the unit tests and
1523         wasn't really needed once we started using a mock filesystem.
1524
1525         Also, reformat a bunch of long lines ...
1526
1527         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1528         (Manager.run):
1529         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1530         (parse_args):
1531         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1532         (parse_args):
1533         (passing_run):
1534         (logging_run):
1535         (MainTest.test_repeat_each_iterations_num_tests):
1536         (MainTest.test_test_list):
1537         (MainTest.test_missing_and_unexpected_results):
1538         (MainTest.test_pixel_test_directories):
1539         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
1540         (MainTest.test_crash_with_stderr):
1541         (MainTest.test_no_image_failure_with_image_diff):
1542         (MainTest.test_crash_log):
1543         (MainTest.test_web_process_crash_log):
1544         (MainTest.test_exit_after_n_failures_upload):
1545         (MainTest.test_results_directory_absolute):
1546         (MainTest.test_results_directory_relative):
1547         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1548         (MainTest.test_additional_expectations):
1549         (MainTest.test_output_diffs):
1550         (EndToEndTest.test_end_to_end):
1551         (EndToEndTest.test_reftest_with_two_notrefs):
1552         (RebaselineTest.test_reset_results):
1553         (RebaselineTest.test_missing_results):
1554         (RebaselineTest.test_new_baseline):
1555
1556 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1557
1558         nrwt: only summarize the results one way
1559         https://bugs.webkit.org/show_bug.cgi?id=104064
1560
1561         Reviewed by Ojan Vafai.
1562
1563         Change manager.summarize_results so that we always (and only)
1564         include both expected and unexpected results. Previously we
1565         would summarize the results twice, once with expected results
1566         and once without. This made the code much more confusing than
1567         it needed to be.
1568
1569         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1570         (summarize_results):
1571         (Manager.run):
1572         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1573         (ResultSummaryTest.summarized_results):
1574         (ResultSummaryTest.test_no_svn_revision):
1575         (ResultSummaryTest.test_svn_revision):
1576         (ResultSummaryTest.test_summarized_results_wontfix):
1577         * Scripts/webkitpy/layout_tests/views/printing.py:
1578         (Printer.print_results):
1579         (Printer._print_unexpected_results):
1580         (Printer._print_unexpected_results.add_result):
1581         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1582         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1583         (Testprinter):
1584
1585 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1586
1587         DFG profiler should display more information
1588         https://bugs.webkit.org/show_bug.cgi?id=104163
1589
1590         Reviewed by Gavin Barraclough.
1591
1592         Added the following:
1593         
1594         - Distinguish between source counts and bytecode counts.
1595         
1596         - Add a "full" summary view that shows both kinds of counts, plus inline counts.
1597         
1598         - Add a "source" command to see the source.
1599         
1600         - Add a "bytecode" command to see the bytecode and counts.
1601
1602         * Scripts/display-profiler-output:
1603
1604 2012-12-05  Yong Li  <yoli@rim.com>
1605
1606         [BlackBerry] Build with libjpegturbo
1607         https://bugs.webkit.org/show_bug.cgi?id=104152
1608
1609         Reviewed by Rob Buis.
1610
1611         RIM PR# 196975.
1612         Make sure the right include path for libjpeg is included.
1613
1614         * Scripts/webkitdirs.pm:
1615         (blackberryCMakeArguments):
1616
1617 2012-12-05  Joseph Pecoraro  <pecoraro@apple.com>
1618
1619         Remove stale check in check-for-webkit-framework-include-consistency
1620         https://bugs.webkit.org/show_bug.cgi?id=103775
1621
1622         Reviewed by David Kilzer.
1623
1624         The underlying issue was fixed in r81173.
1625
1626         * Scripts/check-for-webkit-framework-include-consistency:
1627
1628 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1629
1630         nrwt: simplify the finding of tests to retry
1631         https://bugs.webkit.org/show_bug.cgi?id=104067
1632
1633         Reviewed by Ryosuke Niwa.
1634
1635         I think this makes the code a little clearer; note that
1636         we were no longer using the include_missing flag.
1637
1638         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1639         (Manager.run):
1640         (Manager._failed_test_names):
1641
1642 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1643
1644         nrwt: remove two unused parameters from a function
1645         https://bugs.webkit.org/show_bug.cgi?id=104059
1646
1647         Reviewed by Ryosuke Niwa.
1648
1649         Also remove an old, stale FIXME.
1650
1651         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1652         (interpret_test_failures):
1653         (summarize_results):
1654         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1655         (ResultSummaryTest.test_interpret_test_failures):
1656
1657 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1658
1659         nrwt: return result_summaries from LayoutTestRunner.run_tests()
1660         https://bugs.webkit.org/show_bug.cgi?id=104051
1661
1662         Reviewed by Ojan Vafai.
1663
1664         This patch completes the refactoring that makes the result summary      
1665         an object returned from the layout test runner, rather than having      
1666         it passed in and modified. This makes the split of duties between       
1667         the manager and runner clearer and makes the data flow more             
1668         functionally.                                                           
1669
1670         Also clean up some minor lint issues.
1671
1672         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1673         (LayoutTestRunner.__init__):
1674         (LayoutTestRunner.run_tests):
1675         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
1676         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1677         (FakePrinter.print_expected):
1678         (LockCheckingRunner.__init__):
1679         (LayoutTestRunnerTests._runner):
1680         (LayoutTestRunnerTests._run_tests):
1681         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
1682         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1683         (Manager.__init__):
1684         (Manager.run):
1685         (Manager._run_tests):
1686
1687 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1688
1689         nrwt: move creation of the resultsummary objects into Manager._run_tests()
1690         https://bugs.webkit.org/show_bug.cgi?id=104048
1691
1692         Reviewed by Ojan Vafai.
1693
1694         This is a preparatory step to making the resultsummary just get
1695         returned from the layout_test_runner; this does most of manager-side
1696         changes.
1697
1698         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1699         (Manager._prepare_lists):
1700         (Manager.run):
1701         (Manager._run_tests):
1702
1703 2012-12-05  Leo Yang  <leoyang@rim.com>
1704
1705         [BlackBerry] Enable CSS_IMAGE_RESOLUTION
1706         https://bugs.webkit.org/show_bug.cgi?id=104132
1707
1708         Reviewed by Yong Li.
1709
1710         * Scripts/webkitperl/FeatureList.pm:
1711
1712 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1713
1714         JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
1715         https://bugs.webkit.org/show_bug.cgi?id=104102
1716
1717         Reviewed by Oliver Hunt.
1718
1719         Modify the profiler to not output counts for op_call_put_result, since there
1720         won't be any. Also fix a few weird bugs, like providing better error reporting
1721         when you type something incorrectly and not reporting counts for slow paths
1722         in the old JIT since those counts are actually not what you think they are
1723         (we don't actually count slow path executions separately).
1724
1725         * Scripts/display-profiler-output:
1726
1727 2012-12-05  Andras Becsi  <andras.becsi@digia.com>
1728
1729         Fix compilation for Qt5.0.0 stable branch.
1730         https://bugs.webkit.org/show_bug.cgi?id=103870
1731
1732         Reviewed by Simon Hausmann.
1733
1734         Fix the use of renamed QWindow functions.
1735         Patch by Andras Becsi <andras.becsi@digia.com>
1736
1737         * MiniBrowser/qt/BrowserWindow.cpp:
1738         (BrowserWindow::BrowserWindow):
1739         (BrowserWindow::onTitleChanged):
1740         * MiniBrowser/qt/raw/View.cpp:
1741         (View::View):
1742
1743 2012-12-05  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1744
1745         [WK2] InjectedBundle should check Intent url for null
1746         https://bugs.webkit.org/show_bug.cgi?id=104117
1747
1748         Reviewed by Kenneth Rohde Christiansen.
1749
1750         WKIntentServiceInfoCopyHref() can return null, we need to check
1751         for that in InjectedBundlePage::registerIntentServiceForFrame()
1752         to avoid crashing.
1753
1754         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1755         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1756
1757 2012-12-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1758
1759         Change email address of Jonathan Dong
1760         https://bugs.webkit.org/show_bug.cgi?id=103976
1761
1762         Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
1763         to jonathan.dong.webkit@gmail.com in committers list.
1764
1765         * Scripts/webkitpy/common/config/committers.py:
1766
1767 2012-12-04  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1768
1769         [BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
1770         https://bugs.webkit.org/show_bug.cgi?id=103986
1771
1772         Reviewed by Rob Buis.
1773
1774         Also move declaration of webSettingTransaction to before any WebSettings
1775         ::setXXX() calls so that it works as expected (commit only once in the
1776         function scope).
1777
1778         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1779         (shouldDumpAsText):
1780         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1781
1782 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1783
1784         display-profiler-output should be able to show source code
1785         https://bugs.webkit.org/show_bug.cgi?id=104073
1786
1787         Reviewed by Oliver Hunt.
1788
1789         Display source code in the summary, using a one-line shortening.
1790
1791         * Scripts/display-profiler-output:
1792
1793 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1794
1795         display-profiler-output should not use reflective infocation to resolve command names
1796
1797         Rubber stamped by Mark Hahnenberg.
1798
1799         Reflection is amazing, but here it was just kind of a bit much.
1800
1801         * Scripts/display-profiler-output:
1802
1803 2012-12-02  Filip Pizlo  <fpizlo@apple.com>
1804
1805         JSC should be able to report profiling data associated with the IR dumps and disassembly
1806         https://bugs.webkit.org/show_bug.cgi?id=102999
1807
1808         Reviewed by Gavin Barraclough.
1809
1810         Added a tool that allows you to grok the output from JSC's new profiler. Currently,
1811         this still gets confused a bit about the execution counts of a method running
1812         standalone versus a method running inlined, but other than that, it's pretty cool.
1813         See the attached "sampling profiling session" attached to the bug to see it in
1814         action.
1815         
1816         Also had to feed EFL's build system.
1817
1818         * DumpRenderTree/efl/CMakeLists.txt:
1819         * Scripts/display-profiler-output: Added.
1820
1821 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1822
1823         nrwt: fix total number of tests computed in the result summary
1824         https://bugs.webkit.org/show_bug.cgi?id=104061
1825
1826         Unreviewed, build fix.
1827
1828         One of the recent changes to the resultsummary refactoring caused
1829         us to not include the number of skipped tests in the total number
1830         of tests, throwing off the totals printed in print_one_line_summary().
1831
1832         Unfortunately, given the current state of the code it is difficult
1833         to construct an accurate unit test for this. I have verified the
1834         fix by hand, and will write a test once the remaining refactoring
1835         patches land, at which point it will be trivial to test it.
1836
1837         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1838         (Manager._prepare_lists):
1839
1840 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1841
1842         nrwt is not returning the exit status properly
1843         https://bugs.webkit.org/show_bug.cgi?id=103830
1844
1845         Unreviewed, build fix.
1846
1847         The fix in r136474 wasn't quite right either, and would return
1848         the correct exceptional status, but not the correct failing status.
1849
1850         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1851
1852 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1853
1854         nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
1855         https://bugs.webkit.org/show_bug.cgi?id=104047
1856
1857         Reviewed by Eric Seidel.
1858
1859         The code becomes cleaner if we are just passing values around rather
1860         than hanging them off the manager object, helps move _prepare_lists()
1861         to a pure function, and is needed to eventually make the
1862         result_summary object something returned from runner.run_tests()
1863         (note that two more patches are needed for that to happen).
1864
1865         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1866         (Manager.__init__):
1867         (Manager._http_tests):
1868         (Manager._prepare_lists):
1869         (Manager.needs_servers):
1870         (Manager._set_up_run):
1871         (Manager.run):
1872         (Manager._run_tests):
1873         (Manager._upload_json_files):
1874         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1875         (ManagerTest.test_needs_servers.get_manager):
1876         (ManagerTest.test_needs_servers):
1877         (ManagerTest.integration_test_needs_servers.get_manager):
1878         (ManagerTest.integration_test_needs_servers):
1879         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1880         (ManagerTest):
1881         (ManagerTest.test_look_for_new_crash_logs):
1882         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1883         (JSONLayoutResultsGenerator.__init__):
1884         (JSONLayoutResultsGenerator._get_modifier_char):
1885
1886 2012-12-04  Adam Barth  <abarth@webkit.org>
1887
1888         commit-queue can get stuck with a local commit
1889         https://bugs.webkit.org/show_bug.cgi?id=104032
1890
1891         Reviewed by Dirk Pranke.
1892
1893         Previously the commit-queue would only clean down to HEAD. If the
1894         commit-queue gets interrupted in the middle of a commit (e.g., after
1895         the local commit but before the dcommit), then it can end up with a
1896         patch locally committed. That patch will then prevent the commit-queue
1897         from functioning.
1898
1899         This patch teaches the commit-queue to clean down to the merge base,
1900         which will remove any local commits.
1901
1902         * Scripts/webkitpy/common/checkout/scm/git.py:
1903         (Git.working_directory_is_clean):
1904         (Git.clean_working_directory):
1905         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1906         * Scripts/webkitpy/tool/steps/commit.py:
1907         (Commit._commit_warning):
1908         (Commit.run):
1909
1910 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1911
1912         nrwt: store only the total number of tests in the result summary
1913         https://bugs.webkit.org/show_bug.cgi?id=103963
1914
1915         Reviewed by Ryosuke Niwa.
1916
1917         The result summary only needs the total number of tests that will
1918         be run (including repetitions) in order to provide the correct stats;
1919         it doesn't actually need to know how many unique tests there are, or
1920         or how many repetitions there are.
1921
1922         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1923         (LayoutTestRunnerTests._result_summary):
1924         (LayoutTestRunnerTests.test_update_summary_with_result):
1925         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1926         (Manager._prepare_lists):
1927         (Manager.run):
1928         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1929         (ManagerTest.test_look_for_new_crash_logs):
1930         (ResultSummaryTest.get_result_summary):
1931         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1932         (ResultSummary.__init__):
1933         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1934         (Testprinter.get_result_summary):
1935
1936 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1937
1938         nrwt: do less work when ctrl-c'ed
1939         https://bugs.webkit.org/show_bug.cgi?id=103961
1940
1941         Reviewed by Ryosuke Niwa.
1942
1943         Do less work when we are ctrl-c'ed, because the statistics aren't
1944         that useful anyway. While we're at it, modify summarize_results
1945         to be aware that we don't always retry results (instead of pretending
1946         that the retry produced the same results the initial run did).
1947
1948         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1949         (summarize_results):
1950         (Manager.run):
1951
1952 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1953
1954         nrwt: result summaries should not require a list of tests to skip
1955         https://bugs.webkit.org/show_bug.cgi?id=103951
1956
1957         Reviewed by Ryosuke Niwa.
1958
1959         We shouldn't really be passing a list of tests to skip to the
1960         ResultSummary objects; they should be handled like any other
1961         test result as much as possible.
1962
1963         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1964         (LayoutTestRunnerTests._result_summary):
1965         (LayoutTestRunnerTests.test_update_summary_with_result):
1966         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1967         (Manager._prepare_lists):
1968         (Manager.run):
1969         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1970         (ManagerTest.test_look_for_new_crash_logs):
1971         (ResultSummaryTest.get_result_summary):
1972         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1973         (ResultSummary.__init__):
1974         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1975         (TestExpectations):
1976         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1977         (Testprinter.get_result_summary):
1978
1979 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1980
1981         nrwt: derive per-thread, per-worker stats from result summaries
1982         https://bugs.webkit.org/show_bug.cgi?id=103943
1983
1984         Reviewed by Ojan Vafai.
1985
1986         This patch changes the manager and printing code to pull more           
1987         information from the ResultSummary object rather than tracking          
1988         additional statistics on the side. This allows us to consolidate        
1989         a bunch of logic and remove a bunch of free-floating lists and dicts of 
1990         of values. We add the shard_name and worker_name to each TestResult,    
1991         and then modify print_timing_statistics() and upload_json_files()       
1992         to just need the result summaries.                                      
1993
1994         Note that this patch also changes the timing statistics slightly
1995         so that the individual test times are the times to run just the
1996         tests themselves (TestResult.test_run_time) and do not include the
1997         times taken to run the ref tests, compute diffs, etc. The aggregated
1998         per-worker and per-shard statistics still use the total time to
1999         process each test (TestResult.total_run_time).
2000
2001         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2002         (LayoutTestRunner.__init__):
2003         (LayoutTestRunner.run_tests):
2004         (LayoutTestRunner._handle_finished_test_list):
2005         (LayoutTestRunner._handle_finished_test):
2006         (Worker.handle):
2007         (Worker._run_test):
2008         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2009         (summarize_results):
2010         (Manager.run):
2011         (Manager._upload_json_files):
2012         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2013         (ResultSummaryTest.summarized_results):
2014         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2015         (JSONLayoutResultsGenerator.__init__):
2016         (JSONLayoutResultsGenerator._get_test_timing):
2017         * Scripts/webkitpy/layout_tests/models/test_results.py:
2018         (TestResult.__init__):
2019         * Scripts/webkitpy/layout_tests/views/printing.py:
2020         (Printer.print_results):
2021         (Printer._print_timing_statistics):
2022         (Printer):
2023         (Printer._print_worker_statistics):
2024         (Printer._print_aggregate_test_statistics):
2025         (Printer._print_individual_test_times):
2026         (Printer._print_directory_timings):
2027         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2028         (Testprinter.test_print_unexpected_results.get_unexpected_results):
2029         (Testprinter):
2030
2031 2012-12-04  Adam Barth  <abarth@webkit.org>
2032
2033         Remove obsolete code from webkitpy
2034         https://bugs.webkit.org/show_bug.cgi?id=104029
2035
2036         Reviewed by Eric Seidel.
2037
2038         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2039         (CommitQueueTask.run):
2040         * Scripts/webkitpy/tool/steps/commit.py:
2041         (Commit.options):
2042         * Scripts/webkitpy/tool/steps/options.py:
2043         (Options):
2044
2045 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
2046
2047         [chromium] move WebPreferences and methods for modifying them to the TestRunner library
2048         https://bugs.webkit.org/show_bug.cgi?id=103841
2049
2050         Reviewed by Darin Fisher.
2051
2052         * DumpRenderTree/DumpRenderTree.gypi:
2053         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2054         (DRTTestRunner::DRTTestRunner):
2055         (DRTTestRunner::reset):
2056         * DumpRenderTree/chromium/DRTTestRunner.h:
2057         (DRTTestRunner):
2058         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
2059         (WebKit):
2060         (WebTestRunner):
2061         (WebPreferences):
2062         (WebTestRunner::WebPreferences::WebPreferences):
2063         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2064         (WebTestRunner):
2065         (WebTestDelegate):
2066         (WebTestRunner::WebTestDelegate::localFileToDataURL):
2067         (WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
2068         (WebTestRunner::WebTestDelegate::preferences):
2069         (WebTestRunner::WebTestDelegate::applyPreferences):
2070         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2071         (WebTestRunner::TestRunner::TestRunner):
2072         (WebTestRunner::TestRunner::reset):
2073         (WebTestRunner::TestRunner::setUserStyleSheetEnabled):
2074         (WebTestRunner):
2075         (WebTestRunner::TestRunner::setUserStyleSheetLocation):
2076         (WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
2077         (WebTestRunner::TestRunner::setPopupBlockingEnabled):
2078         (WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
2079         (WebTestRunner::TestRunner::setXSSAuditorEnabled):
2080         (WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
2081         (WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
2082         (WebTestRunner::TestRunner::overridePreference):
2083         (WebTestRunner::TestRunner::setPluginsEnabled):
2084         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2085         (TestRunner):
2086         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
2087         (WebTestRunner::WebPreferences::reset):
2088         (WebTestRunner):
2089         (WebTestRunner::WebPreferences::applyTo):
2090         * DumpRenderTree/chromium/TestShell.h:
2091         (TestShell::preferences):
2092         (TestShell):
2093         * DumpRenderTree/chromium/WebViewHost.cpp:
2094         (WebViewHost::localFileToDataURL):
2095         (WebViewHost::rewriteLayoutTestsURL):
2096         (WebViewHost::preferences):
2097         (WebViewHost::applyPreferences):
2098         * DumpRenderTree/chromium/WebViewHost.h:
2099         (WebViewHost):
2100
2101 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
2102
2103         Many webkitpy unit tests can be run standalone, are executable
2104         https://bugs.webkit.org/show_bug.cgi?id=103900
2105
2106         Reviewed by Eric Seidel.
2107
2108         There's no need anymore to run unit tests in standalone mode as they
2109         are now handled by test-webkitpy in a formidable fashion. This makes
2110         it possible for this patch to remove the following unnecessary bits:
2111         - remove shebang lines from unit test files,
2112         - remove calls to unittest.main(),
2113         - make unit test files non-executable.
2114
2115         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2116         (DiffParserTest.test_git_mnemonicprefix):
2117         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2118         (GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
2119         * Scripts/webkitpy/common/config/build_unittest.py:
2120         (ShouldBuildTest.test_should_build):
2121         * Scripts/webkitpy/common/config/ports_unittest.py:
2122         (DeprecatedPortTest.test_chromium_xvfb_port):
2123         * Scripts/webkitpy/common/find_files_unittest.py:
2124         (TestWinNormalize.test_win):
2125         * Scripts/webkitpy/common/lru_cache_unittest.py:
2126         (LRUCacheTest.test_set_again):
2127         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2128         (test_results_zip_url):
2129         * Scripts/webkitpy/common/net/credentials_unittest.py:
2130         (test_keyring_without_git_repo_nor_keychain):
2131         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
2132         (OmahaProxyTest.test_get_revisions):
2133         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
2134         * Scripts/webkitpy/common/newstringio_unittest.py:
2135         (NewStringIOTest.test_with):
2136         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
2137         (ReadChecksumFromPngTest.test_read_checksum):
2138         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2139         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2140         (MockFileSystemTest.test_normpath):
2141         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2142         (RealFileSystemTest.test_sep):
2143         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2144         (TestPlatformInfo.test_total_bytes_memory):
2145         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2146         (ZipFileSetTest.test_namelist):
2147         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2148         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2149         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2150         (TestResultWriterTest.test_reftest_diff_image):
2151         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2152         (JSONGeneratorTest.test_test_timings_trie):
2153         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2154         (TestExpectationSerializationTests.test_string_whitespace_stripping):
2155         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2156         (KeyCompareTest.test_test_key):
2157         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
2158         (BuildersTest.test_path_from_name):
2159         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2160         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
2161         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2162         (ChromiumLinuxPortTest.test_path_to_image_diff):
2163         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2164         (ChromiumMacPortTest.test_path_to_image_diff):
2165         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2166         (ChromiumPortLoggingTest.test_check_sys_deps):
2167         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2168         (ChromiumPortLoggingTest.test_check_sys_deps):
2169         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2170         (ConfigTest.test_default_configuration__scripterror):
2171         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2172         (DriverTest.test_start_actually_starts):
2173         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2174         (FactoryTest.test_get_from_builder_name):
2175         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
2176         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
2177         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2178         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
2179         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2180         (PortTest.disabled_test_mac_lion):
2181         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2182         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2183         (VerboseTest.test_log_args):
2184         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2185         (test_details):
2186         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2187         (TestPerfTestFactory.test_inspector_test):
2188         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2189         (test_parse_args):
2190         * Scripts/webkitpy/style/checker_unittest.py:
2191         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2192         (ChangeLogCheckerTest.test_no_error):
2193         * Scripts/webkitpy/style/checkers/common_unittest.py:
2194         (TabCheckerTest.test_tab):
2195         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2196         (CppCheckerTest.test_ne):
2197         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2198         * Scripts/webkitpy/style/checkers/png_unittest.py:
2199         (PNGCheckerTest.test_check):
2200         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2201         * Scripts/webkitpy/style/checkers/text_unittest.py:
2202         (TextCheckerTest.test_init):
2203         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2204         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2205         (XcodeProjectFileCheckerTest.test_detect_development_region):
2206         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2207         (XMLCheckerTest.test_no_error):
2208         * Scripts/webkitpy/style/patchreader_unittest.py:
2209         * Scripts/webkitpy/test/finder_unittest.py:
2210         (FinderTest.test_paths):
2211         * Scripts/webkitpy/test/runner_unittest.py:
2212         (RunnerTest.test_run):
2213         * Scripts/webkitpy/test/skip_unittest.py:
2214         (SkipTest.test_skip_if_true):
2215         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2216         (ThirdpartyTest.test_imports):
2217         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2218         (TestTranslation.test_include_rewriting):
2219         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2220         (QueueEngineTest.tearDown):
2221         * Scripts/webkitpy/tool/grammar_unittest.py:
2222         (GrammarTest.test_join_with_separators):
2223         * Scripts/webkitpy/tool/mocktool_unittest.py:
2224         (MockOptionsTest.test_kwarg__set):
2225         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2226         (test_command_help):
2227
2228 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
2229
2230         Many webkitpy module files are executable, have shebang line
2231         https://bugs.webkit.org/show_bug.cgi?id=103985
2232
2233         Reviewed by Dirk Pranke.
2234
2235         Remove the executable bit from webkitpy module files that are
2236         unnecessarily executable. Remove the shebang line from webkitpy
2237         module files, they are of no use. Only non-third-party files are
2238         changed.
2239
2240         * Scripts/webkitpy/bindings/main.py:
2241         * Scripts/webkitpy/common/config/watchlist:
2242         * Scripts/webkitpy/common/find_files.py:
2243         * Scripts/webkitpy/common/lru_cache.py:
2244         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2245         * Scripts/webkitpy/common/net/file_uploader.py:
2246         * Scripts/webkitpy/common/newstringio.py:
2247         * Scripts/webkitpy/common/read_checksum_from_png.py:
2248         * Scripts/webkitpy/common/system/autoinstall.py:
2249         * Scripts/webkitpy/common/system/file_lock.py:
2250         * Scripts/webkitpy/common/system/file_lock_mock.py:
2251         * Scripts/webkitpy/common/version_check.py:
2252         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2253         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2254         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2255         * Scripts/webkitpy/layout_tests/models/test_input.py:
2256         * Scripts/webkitpy/layout_tests/port/__init__.py:
2257         * Scripts/webkitpy/layout_tests/port/base.py:
2258         * Scripts/webkitpy/layout_tests/port/builders.py:
2259         * Scripts/webkitpy/layout_tests/port/chromium.py:
2260         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2261         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2262         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2263         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2264         * Scripts/webkitpy/layout_tests/port/config.py:
2265         * Scripts/webkitpy/layout_tests/port/factory.py:
2266         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2267         * Scripts/webkitpy/layout_tests/port/image_diff.py:
2268         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2269         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2270         * Scripts/webkitpy/layout_tests/port/server_process.py:
2271         * Scripts/webkitpy/layout_tests/port/test.py:
2272         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2273         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2274         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2275         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2276         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2277         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2278         * Scripts/webkitpy/layout_tests/views/printing.py:
2279         * Scripts/webkitpy/performance_tests/perftest.py:
2280         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2281         * Scripts/webkitpy/style/checkers/changelog.py:
2282         * Scripts/webkitpy/style/checkers/cpp.py:
2283         * Scripts/webkitpy/style/checkers/xcodeproj.py:
2284         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2285         (main): There's no need to run this module in standalone because
2286         it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
2287         * Scripts/webkitpy/tool/commands/upload.py:
2288         * Scripts/webkitpy/tool/comments.py:
2289         * Scripts/webkitpy/tool/main.py:
2290
2291 2012-12-04  Ryosuke Niwa  <rniwa@webkit.org>
2292
2293         Add a Chromium Android Release (Perf) to the list of perf. bots.
2294
2295         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2296
2297 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
2298
2299         [GTK] Insert the jhbuild wrapper command at the beginning of the command list
2300         https://bugs.webkit.org/show_bug.cgi?id=103991
2301
2302         Reviewed by Martin Robinson.
2303
2304         Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
2305         command that's being formed in multiprocessing bootstrap. The wrapper is
2306         an executable Python script while the command being wrapped perhaps isn't
2307         and therefore requires the Python interpreter to be listed at the beginning
2308         of the command sublist that is then executed by the wrapper.
2309
2310         Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
2311         is about to lose the executable bit and the Python-signaling shebang line.
2312         The Jhbuild wrapper simply executes the command that's passed, but that errs
2313         in this case unless the Python executable is executed and the module file
2314         is passed to it as an argument.
2315
2316         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2317         (run):
2318
2319 2012-12-04  Peter Beverloo  <peter@chromium.org>
2320
2321         Add the Chromium Android Release (Perf) bot
2322         https://bugs.webkit.org/show_bug.cgi?id=103891
2323
2324         Reviewed by Eric Seidel.
2325
2326         Add configuration for the bot itself. It will be triggered by the Chromium
2327         Android Release builder. When running for Android, the DownloadAndPerfTest
2328         factory will also add the OutputAndroidDeviceStatus step.
2329
2330         * BuildSlaveSupport/build.webkit.org-config/config.json:
2331         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2332         (DownloadAndPerfTestFactory.__init__):
2333
2334 2012-12-04  Peter Beverloo  <peter@chromium.org>
2335
2336         [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
2337         https://bugs.webkit.org/show_bug.cgi?id=103758
2338
2339         Reviewed by Eric Seidel.
2340
2341         Lazily initialize the adb command parameters rather than initializing it in the
2342         constructor now that there is an assert if adb is not available on the system and
2343         we're not in a Chromium Android checkout.
2344
2345         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2346         (ChromiumAndroidDriver.__init__):
2347         (ChromiumAndroidDriver._push_file_if_needed):
2348         (ChromiumAndroidDriver._run_adb_command):
2349         (ChromiumAndroidDriver.cmd_line):
2350         (ChromiumAndroidDriver._start_once):
2351         (ChromiumAndroidDriver._read_prompt):
2352         (ChromiumAndroidDriver):
2353         (ChromiumAndroidDriver._adb_command):
2354
2355 2012-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2356
2357         Dromaeo should report individual test result
2358         https://bugs.webkit.org/show_bug.cgi?id=99800
2359
2360         Reviewed by Eric Seidel.
2361
2362         Ignore subtest results spit out by Dromaeo tests.
2363
2364         * Scripts/webkitpy/performance_tests/perftest.py:
2365         (PerfTest): Added a line to ignore.
2366         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2367         (MainTest.test_parse_output_with_subtests): Added.
2368
2369 2012-12-03  Zan Dobersek  <zandobersek@gmail.com>
2370
2371         Unreviewed, functionality fix after r136437.
2372
2373         Calling sys.exit actually raises a SystemExit exception that
2374         is then handled in the second block and causes the script to
2375         return an 'exceptional' exit code rather than the code presenting
2376         the number of failed tests.
2377
2378         This is just a temporary fix to get the faultless bots green while
2379         they are unnecessarily red at the moment. The problem and a proper
2380         fix will be properly addressed.
2381
2382         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2383
2384 2012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2385
2386         Unreviewed, rolling out r136460.
2387         http://trac.webkit.org/changeset/136460
2388         https://bugs.webkit.org/show_bug.cgi?id=103958
2389
2390         This patch caused compile error when building DumpRenderTree
2391         (Requested by tasak on #webkit).
2392
2393         * Scripts/webkitpy/common/config/build_unittest.py:
2394         (ShouldBuildTest):
2395
2396 2012-12-03  Scott Violet  <sky@chromium.org>
2397
2398         [chromium] Remove linux theme related files and switch to default
2399         https://bugs.webkit.org/show_bug.cgi?id=103897
2400
2401         Reviewed by Darin Fisher.
2402
2403         * Scripts/webkitpy/common/config/build_unittest.py:
2404         (ShouldBuildTest): linux->default
2405
2406 2012-12-03  Roger Fong  <roger_fong@apple.com>
2407
2408         Disable WebKit2 API tests on Apple Windows port.
2409         https://bugs.webkit.org/show_bug.cgi?id=103929.
2410
2411         Reviewed by Timothy Horton.
2412
2413         * Scripts/run-api-tests:
2414         (runTestsBySuite):
2415
2416 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
2417
2418         webkitpy's run_webkit_tests should initialize the printer earlier on
2419         https://bugs.webkit.org/show_bug.cgi?id=103661
2420
2421         Reviewed by Eric Seidel.
2422
2423         Initialize the printer before computing the derived options
2424         from the command line arguments, so that we can safely log from
2425         port methods.
2426
2427         Also clean up a few miscellaneous lint warnings.
2428
2429         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2430         (ChromiumAndroidPort.path_to_adb):
2431         * Scripts/webkitpy/layout_tests/port/mac.py:
2432         (MacPort.default_child_processes):
2433         (MacPort.sample_process):
2434         (MacPort.start_helper):
2435         (MacPort.stop_helper):
2436         (MacPort.nm_command):
2437         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2438         (test_default_child_processes):
2439         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2440         (run):
2441         (_set_up_derived_options):
2442
2443 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
2444
2445         webkitpy: autoinstaller is failing on windows
2446         https://bugs.webkit.org/show_bug.cgi?id=103699
2447
2448         Reviewed by Tony Chang.
2449
2450         Attempt to fix the python autoinstaller to work for pylint on win32
2451         again ... it turns out one of the dependent packages contains
2452         a write-protected test file and windows will choke when it tries to move
2453         it into place. Fortunately we can just delete the file prior to
2454         installing it in the final location, but we have to jump through
2455         a couple of hoops to do so.
2456
2457         Also, make sure that we're flattening nested module names like
2458         "logilab/common" into either safe basenames (logilab_common) or
2459         host-specific subdirs (logilab\common) as needed.
2460
2461         * Scripts/webkitpy/common/system/autoinstall.py:
2462         (AutoInstaller._url_downloaded_path):
2463         (AutoInstaller._install):
2464         (AutoInstaller.install):
2465         * Scripts/webkitpy/thirdparty/__init__.py:
2466         (AutoinstallImportHook._install_pylint):
2467
2468 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
2469
2470         nrwt: clean up exception propagation / handling for interrupts and early exits
2471         https://bugs.webkit.org/show_bug.cgi?id=103830
2472
2473         Reviewed by Ojan Vafai.
2474
2475         The code for propagating early exits out of the test run was
2476         convoluted and hard to follow. By adjusting the WorkerException to
2477         derive from BaseException rather than Exception (which is a fair
2478         way of representing an error that was really unexpected/unrecoverable
2479         anyway) and pushing the TestRunInterruptedException into the
2480         ResultSummary (which is also fair since it was more of a result
2481         than an exception) this allows us to consolidate and clean up
2482         a bunch of the try/catch logic and pass fewer state flags around.
2483
2484         There are no real functional changes to this patch; there's an
2485         API change in that we stop exporting TestRunInterruptedException
2486         and WorkerException out of the Manager, and the existence of the
2487         MessagePool is now completely hidden.
2488
2489         * Scripts/webkitpy/common/message_pool.py:
2490         (WorkerException):
2491         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2492         (LayoutTestRunner.run_tests):
2493         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2494         (summarize_results):
2495         (Manager.run):
2496         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2497         (ResultSummaryTest.summarized_results):
2498         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2499         (ResultSummary.__init__):
2500         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2501         (run):
2502         (main):
2503         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2504         (MainTest.test_exception_raised.of):
2505         (MainTest.test_exception_raised):
2506         (MainTest.test_run_force):
2507         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2508         (Testprinter.test_print_unexpected_results.get_unexpected_results):
2509         (Testprinter):
2510
2511 2012-12-03  Julien BRIANCEAU   <jbrianceau@nds.com>
2512
2513         Add Qt/SH4 build slave to build.webkit.org
2514         https://bugs.webkit.org/show_bug.cgi?id=103384
2515
2516         Reviewed by Csaba Osztrogonác.
2517
2518         * BuildSlaveSupport/build.webkit.org-config/config.json:
2519
2520 2012-12-03  Alexis Menard  <alexis@webkit.org>
2521
2522         Enable CSS3 background-position offset by default
2523         https://bugs.webkit.org/show_bug.cgi?id=103917
2524
2525         Reviewed by Benjamin Poulain.
2526
2527         Even though each port may enable or not the feature we still need
2528         to pass it at configure time otherwise it will be disabled.
2529
2530         * Scripts/webkitperl/FeatureList.pm:
2531
2532 2012-12-03  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2533
2534         Unreviewed. Adding myself to committers.py.
2535
2536         * Scripts/webkitpy/common/config/committers.py:
2537
2538 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
2539
2540         [CMake] Enable building WebKit2-only build for the EFL port
2541         https://bugs.webkit.org/show_bug.cgi?id=103820
2542
2543         Reviewed by Gyuyoung Kim.
2544
2545         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
2546         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
2547         cmake directly. Initialize $cmakeArgs to avoid potential
2548         warnings when running the script.
2549
2550         * Scripts/build-webkit:
2551
2552 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
2553
2554         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
2555         https://bugs.webkit.org/show_bug.cgi?id=103407
2556
2557         Reviewed by Kentaro Hara.
2558
2559         Changing the mock to use the new results delivery API.
2560
2561         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2562
2563 2012-12-03  Alexis Menard  <alexis@webkit.org>
2564
2565         [Qt] Enable CSS3 background-position offsets by default.
2566         https://bugs.webkit.org/show_bug.cgi?id=103877
2567
2568         Reviewed by Tor Arne Vestbø.
2569
2570         Enable by default CSS3 background-position offsets.
2571
2572         * qmake/mkspecs/features/features.pri:
2573
2574 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
2575
2576         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
2577         https://bugs.webkit.org/show_bug.cgi?id=103863
2578
2579         Reviewed by Gyuyoung Kim.
2580
2581         Use float instead of int for zoomLevels variables for a clearer expression
2582
2583         * MiniBrowser/efl/main.c:
2584         (on_key_down):
2585
2586 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
2587
2588         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
2589         https://bugs.webkit.org/show_bug.cgi?id=99285
2590
2591         Reviewed by Gyuyoung Kim.
2592
2593          Add support for a zoom level setting to MiniBrowser.
2594          Shortcuts for setting operations are same as common browsers:
2595          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
2596
2597         * MiniBrowser/efl/main.c:
2598         (on_key_down):
2599
2600 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
2601
2602         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
2603         https://bugs.webkit.org/show_bug.cgi?id=103835
2604
2605         Reviewed by Kentaro Hara.
2606
2607         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
2608
2609         * MiniBrowser/efl/main.c:
2610         (elm_main):
2611
2612 2012-12-02  Mike West  <mkwst@chromium.org>
2613
2614         Garden-o-matic shouldn't die when blank JSON results are received.
2615         https://bugs.webkit.org/show_bug.cgi?id=103838
2616
2617         Reviewed by Adam Barth.
2618
2619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2620             If the JSONP string doesn't contain '(' or ')', return an empty object.
2621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2622             Check that this behavior stays in place.
2623
2624 2012-12-02  Eric Seidel  <eric@webkit.org>
2625
2626         run-perf-tests --profile should use iprofiler instead of instruments on Mac
2627         https://bugs.webkit.org/show_bug.cgi?id=103765
2628
2629         Unreviewed.  Updating the unittests after my previous change.
2630
2631         * Scripts/webkitpy/common/system/profiler_unittest.py:
2632         (ProfilerFactoryTest.test_basic):
2633
2634 2012-12-02  Julie Parent  <jparent@chromium.org>
2635
2636         Remove dead code in flakiness dashboard for obsolete buildDir option
2637         https://bugs.webkit.org/show_bug.cgi?id=103792
2638
2639         Reviewed by Dirk Pranke.
2640
2641         * TestResultServer/static-dashboards/dashboard_base.js:
2642         (initBuilders):
2643
2644 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2645
2646         nrwt: clean up logic for retrying failed tests a bit
2647         https://bugs.webkit.org/show_bug.cgi?id=103829
2648
2649         Reviewed by Ojan Vafai.
2650
2651         The code for determining when to retry test failures and
2652         show the results.html file was awkward and could stand some
2653         cleaning up. This patch should have no functional changes.
2654
2655         The routine called _get_failures() returned a dict of test names
2656         to failure types, but we only ever used the names, so I've converted
2657         it to return a list (and renamed it); also, the show_results_html()
2658         file was calling that routine to figure out if anything failed, when
2659         the information was already in the result_summary (as either
2660         unexpected_results or total_failures), so we were doing unnecessary work.
2661
2662         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2663         (Manager.__init__):
2664         (Manager.run):
2665         (Manager._run_tests):
2666         (Manager._failed_test_names):
2667         (Manager._copy_results_html_file):
2668
2669 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2670
2671         nrwt: remove unused methods in manager.py
2672         https://bugs.webkit.org/show_bug.cgi?id=103828
2673
2674         Reviewed by Eric Seidel.
2675
2676         These two methods weren't being called by anything and were no
2677         longer needed.
2678
2679         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2680         (Manager._get_failures):
2681         (Manager._upload_json_files):
2682
2683 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
2684
2685         Correct the spelling of the cmakeargs argument
2686         https://bugs.webkit.org/show_bug.cgi?id=103814
2687
2688         Reviewed by Darin Adler.
2689
2690         The script expects cmakeargs (plural), so lets get the
2691         documentation of the script report the same.
2692
2693         * Scripts/build-webkit:
2694
2695 2012-12-02  Mike West  <mkwst@chromium.org>
2696
2697         [gtk] Enable the CSP_NEXT runtime flag.
2698         https://bugs.webkit.org/show_bug.cgi?id=103810
2699
2700         Reviewed by Adam Barth.
2701
2702         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2703         (resetDefaultsToConsistentValues):
2704             Turn on the CSP_NEXT runtime flag when running tests under GTK.
2705
2706 2012-12-02  Eric Seidel  <eric@webkit.org>
2707
2708         run-perf-tests --profile should use iprofiler instead of instruments on Mac
2709         https://bugs.webkit.org/show_bug.cgi?id=103765
2710
2711         Reviewed by Ryosuke Niwa.
2712
2713         Stephanie pointed out that iprofiler is the newer command-line interface
2714         to replace /usr/bin/instruments in Instruments 4 (which according to the
2715         interblags is supported on everything since 10.6.6), so I've moved --profile
2716         to use iprofiler on Mac.
2717
2718         I also made the IProfiler class wait for iprofiler to complete so that
2719         iprofiler won't continue running after run-perf-tests is complete (and
2720         spam over the top of your shell output).
2721
2722         There are a couple of "got-chas" to this approach:
2723         1.  iprofiler will ask for your password the first time you run it, which may
2724             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
2725         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
2726             directory and basename arguments, making IProfiler a somewhat awkward
2727             baseclass of SingleFileOutputProfiler
2728
2729         I suspect we'll iterate from here.  It does seem slightly faster than
2730         /usr/bin/instruments was.
2731
2732         * Scripts/webkitpy/common/system/profiler.py:
2733         (ProfilerFactory.create_profiler):
2734         (IProfiler):
2735         (IProfiler.__init__):
2736         (IProfiler.attach_to_pid):
2737
2738 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
2739
2740         Need a method to close all idle localstorage databases immediately.
2741         https://bugs.webkit.org/show_bug.cgi?id=103469
2742
2743         Reviewed by David Kilzer.
2744
2745         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
2746         DumpRenderTree layout tests.
2747
2748         * DumpRenderTree/TestRunner.cpp:
2749         (closeIdleLocalStorageDatabasesCallback):
2750         (TestRunner::staticFunctions):
2751         * DumpRenderTree/TestRunner.h:
2752         (TestRunner):
2753         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2754         (TestRunner::closeIdleLocalStorageDatabases):
2755         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2756         (TestRunner::closeIdleLocalStorageDatabases):
2757         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2758         (TestRunner::closeIdleLocalStorageDatabases):
2759         * DumpRenderTree/mac/TestRunnerMac.mm:
2760         (TestRunner::closeIdleLocalStorageDatabases):
2761         * DumpRenderTree/win/TestRunnerWin.cpp:
2762         (TestRunner::closeIdleLocalStorageDatabases):
2763         * DumpRenderTree/wx/TestRunnerWx.cpp:
2764         (TestRunner::closeIdleLocalStorageDatabases):
2765
2766 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
2767
2768         [EFL][WK2] MiniBrowser should have a legacy mode
2769         https://bugs.webkit.org/show_bug.cgi?id=103679
2770
2771         Reviewed by Kenneth Rohde Christiansen.
2772
2773         Add an option to start MiniBrowser in legacy mode.
2774
2775         * MiniBrowser/efl/main.c:
2776         (window_create):
2777         (elm_main):
2778
2779 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2780
2781         Unreviewed, rolling out r136236.
2782         http://trac.webkit.org/changeset/136236
2783         https://bugs.webkit.org/show_bug.cgi?id=103833
2784
2785         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
2786         during GC. (Requested by mkwst on #webkit).
2787
2788         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2789
2790 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2791
2792         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
2793         https://bugs.webkit.org/show_bug.cgi?id=103806
2794
2795         Reviewed by Dirk Pranke.
2796
2797         There are occasional mishaps on builders where XvfbDriver doesn't properly
2798         clean up the Xvfb instance it was managing so the related guard lock files
2799         are still existing when the webkitpy unit tests are run. This can cause failures
2800         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
2801         with a specific number but is unable to due to the stale locks.
2802
2803         The solution to this is to use MockFileLock when inside unit test. This is achievable
2804         by creating a file lock through the SystemHost instance connected to the Port object,
2805         the latter available to the Driver.
2806
2807         * Scripts/webkitpy/common/system/file_lock_mock.py:
2808         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
2809         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
2810         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2811         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
2812         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2813         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
2814
2815 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2816
2817         [GTK] A11y tests in WK2 report badly-formatted AX roles
2818         https://bugs.webkit.org/show_bug.cgi?id=102947
2819
2820         Reviewed by Xan Lopez.
2821
2822         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
2823         These are expected in both tests and their baselines.
2824
2825         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2826         (WTR::roleToString):
2827         (WTR):
2828         (WTR::AccessibilityUIElement::role):
2829
2830 2012-11-30  Mike West  <mkwst@chromium.org>
2831
2832         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
2833         https://bugs.webkit.org/show_bug.cgi?id=103652
2834
2835         Reviewed by Adam Barth.
2836
2837         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
2838
2839         * DumpRenderTree/chromium/TestShell.cpp:
2840         (TestShell::TestShell):
2841
2842 2012-11-30  Roger Fong  <roger_fong@apple.com>
2843
2844         Unreviewed. Removed temporary debugging change from DRT (r136300).
2845
2846         * DumpRenderTree/win/DumpRenderTree.cpp:
2847         (dump):
2848
2849 2012-11-30  Roger Fong  <roger_fong@apple.com>
2850
2851         Unreviewed. Temporary change to DRT for debugging purposes.
2852
2853         * DumpRenderTree/win/DumpRenderTree.cpp:
2854         (dump):
2855
2856 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
2857
2858         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
2859         https://bugs.webkit.org/show_bug.cgi?id=103407
2860
2861         Reviewed by Adam Barth.
2862
2863         Changing the mock to use the new results delivery API.
2864
2865         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2866
2867 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
2868
2869         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
2870         https://bugs.webkit.org/show_bug.cgi?id=99314
2871
2872         Reviewed by Tor Arne Vestbø.
2873
2874         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
2875         shared libraries.
2876
2877         It's a big refactoring that mostly involves moving WebCore dependent
2878         code into QtWebKit and accessing it through exported QWebFrameAdapter
2879         and QWebPageAdapter classes.
2880
2881         * DumpRenderTree/qt/DumpRenderTree.pro:
2882         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2883         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
2884         * MiniBrowser/qt/MiniBrowser.pro:
2885         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
2886         * Scripts/webkitpy/style/checker_unittest.py:
2887         (GlobalVariablesTest.test_path_rules_specifier):
2888         * WebKitTestRunner/InjectedBundle/Target.pri:
2889         * qmake/mkspecs/features/default_post.prf:
2890         * qmake/mkspecs/features/webkit_modules.prf:
2891         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
2892
2893 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
2894
2895         [Qt] Unreviewed trivial fix.
2896
2897         Add empty.cpp back, it was removed accidentally by r129092.
2898
2899         * qmake/config.tests/gccdepends/empty.cpp: Added.
2900
2901 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2902
2903         [Qt] Add support for prepare_docs and generate_docs
2904
2905         Follow-up to changes in Qt in how documentation is built.
2906
2907         Reviewed by Simon Hausmann.
2908
2909         * qmake/mkspecs/features/default_post.prf:
2910
2911 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
2912
2913         Finally remove webkitpy.common.system.deprecated_logging
2914         https://bugs.webkit.org/show_bug.cgi?id=103624
2915
2916         Reviewed by Adam Barth.
2917
2918         Remove the deprecated logging module and its unit tests now that such logging is not
2919         used anymore in webkitpy.
2920
2921         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
2922         The tee class is renamed to Tee to conform with the usual guidelines.
2923
2924         Only unit test for the Tee class is currently provided as the OutputTee is not currently
2925         using the webkitpy Filesystem abstraction that would make its functionality testable.
2926
2927         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
2928         (Executive.run_and_throw_if_fail):
2929         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
2930         (Tee):
2931         (Tee.__init__):
2932         (Tee.write):
2933         (OutputTee):
2934         (OutputTee.__init__):
2935         (OutputTee.add_log):
2936         (OutputTee.remove_log):
2937         (OutputTee._open_log_file):
2938         (OutputTee._tee_outputs_to_files):
2939         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
2940         (SimpleTeeTest):
2941         (SimpleTeeTest.test_simple_tee):
2942         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
2943         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
2944
2945 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2946
2947         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
2948         https://bugs.webkit.org/show_bug.cgi?id=103634
2949
2950         Reviewed by Gyuyoung Kim.
2951
2952         Add support for PlatformWebView::simulateRightClick() and enable
2953         WebKit2 API test HitTestResultNodeHandle.
2954
2955         * TestWebKitAPI/PlatformEfl.cmake:
2956         * TestWebKitAPI/efl/PlatformWebView.cpp:
2957         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2958         (TestWebKitAPI):
2959
2960 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
2961
2962         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
2963         https://bugs.webkit.org/show_bug.cgi?id=101192
2964
2965         Reviewed by Hajime Morita.
2966
2967         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
2968
2969         Tests: No new tests because there is no functional change.
2970
2971         * DumpRenderTree/chromium/WebPreferences.cpp:
2972         (WebPreferences::applyTo):
2973
2974 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
2975
2976         [HTMLTemplateElement] Add feature flag
2977         https://bugs.webkit.org/show_bug.cgi?id=103694
2978
2979         Reviewed by Adam Barth.
2980
2981         This flag will guard the implementation of the HTMLTemplateElement.
2982         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
2983
2984         * Scripts/webkitperl/FeatureList.pm:
2985
2986 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2987
2988         Ignore errors when removing directories on win32 during autoinstall
2989         https://bugs.webkit.org/show_bug.cgi?id=103699
2990
2991         Unreviewed, build fix.
2992
2993         I think this will work on win32; if not, I'll have to actually
2994         reproduce this :). The problem is that the logilab files
2995         appear to contain a write-protected file, and deleting those
2996         is problematic on windows.
2997
2998         * Scripts/webkitpy/common/system/autoinstall.py:
2999         (AutoInstaller._install):
3000         (AutoInstaller.install):
3001
3002 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
3003
3004         webkitpy: autoinstaller is failing on windows
3005         https://bugs.webkit.org/show_bug.cgi?id=103699
3006
3007         Unreviewed, build fix.
3008
3009         We're attempting to create directories with forward slashes in them;
3010         this is a no-no on windows.
3011
3012         * Scripts/webkitpy/common/system/autoinstall.py:
3013         (AutoInstaller._create_scratch_directory_inner):
3014
3015 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
3016
3017         Fix python unit tests after r136158 (android port tests failing)
3018         https://bugs.webkit.org/show_bug.cgi?id=103581
3019
3020         Unreviewed, build fix.
3021
3022         The unit tests apparently weren't ran for this patch; we failed
3023         to update the mock executive calls out to adb to determine various
3024         aspects of the environment, and were failing to create drivers.
3025
3026         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3027         (MockRunCommand.mock_run_command_fn):
3028
3029 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3030
3031         Unreviewed, rolling out r136175 and r136177.
3032         http://trac.webkit.org/changeset/136175
3033         http://trac.webkit.org/changeset/136177
3034         https://bugs.webkit.org/show_bug.cgi?id=103683
3035
3036         Changes did not correct Windows build. (Requested by bfulgham
3037         on #webkit).
3038
3039         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3040
3041 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
3042
3043         [Windows, WinCairo] Unreviewed build correction. Correct debug
3044         build case on build machine.
3045
3046         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3047
3048 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
3049
3050         [Windows, WinCairo] Unreviewed build correction. Hide the
3051         unexported 'notSolidColor' symbol when testing against
3052         the BitmapImage class to avoid having to deal with a
3053         debug-only symbol in the Windows export definition file.
3054
3055         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
3056
3057 2012-11-29  Peter Beverloo  <peter@chromium.org>
3058
3059         run-perf-tests --chromium-android should not require adb in my path
3060         https://bugs.webkit.org/show_bug.cgi?id=103581
3061
3062         Reviewed by Eric Seidel.
3063
3064         Remove the need to have "adb" available in the path for Layout and Performance
3065         tests. We'll determine the versions of the "adb" version in path (if any) and
3066         the one provided in the Chromium Android checkout. Unless the "adb" available
3067         in the path is newer, the provided version will be used.
3068
3069         Some other minor nits addressed:
3070         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
3071           section, as they're not overriding anything and are used by the driver.
3072         - Make _restart_adb_as_root slightly more robust by waiting for the device
3073           to come back online regardless of the output.
3074
3075         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3076         (ChromiumAndroidPort.__init__):
3077         (ChromiumAndroidPort.check_build):
3078         (ChromiumAndroidPort.path_to_adb):
3079         (ChromiumAndroidPort):
3080         (ChromiumAndroidPort.path_to_forwarder):
3081         (ChromiumAndroidPort.path_to_md5sum):
3082         (ChromiumAndroidPort._path_to_helper):
3083         (ChromiumAndroidPort._determine_adb_version):
3084         (ChromiumAndroidPort._get_devices):
3085         (ChromiumAndroidDriver.__init__):
3086         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
3087         (ChromiumAndroidDriver._push_executable):
3088         (ChromiumAndroidDriver._restart_adb_as_root):
3089
3090 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
3091
3092         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
3093         https://bugs.webkit.org/show_bug.cgi?id=103277
3094
3095         Reviewed by Carlos Garcia Campos.
3096
3097         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
3098         during gtkdoc generation.
3099
3100         * gtk/generate-gtkdoc:
3101         (get_webkit2_options):
3102
3103 2012-11-29  Eric Seidel  <eric@webkit.org>
3104
3105         run-perf-tests --chromium-android fails due to Skia INFO logging
3106         https://bugs.webkit.org/show_bug.cgi?id=103585
3107
3108         Reviewed by Adam Barth.
3109
3110         Ignore all INFO logging from Chromium code.
3111         Also added some basic testing of the ignored-stderr lines code.
3112
3113         * Scripts/webkitpy/performance_tests/perftest.py:
3114         (PerfTest):
3115         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3116         (MainTest.test_ignored_stderr_lines):
3117
3118 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3119
3120         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
3121         https://bugs.webkit.org/show_bug.cgi?id=103252
3122
3123         Reviewed by Kenneth Rohde Christiansen.
3124
3125         Add support for PlatformWebView::simulateMouseMove() and enable
3126         WebKit2 API test MouseMoveAfterCrash.
3127
3128         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
3129         test.
3130         * TestWebKitAPI/efl/PlatformWebView.cpp:
3131         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
3132         to prevent loading an error page since the test case is reloading actual
3133         page after web process has terminated and recovered.
3134         (TestWebKitAPI):
3135         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3136         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
3137
3138 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
3139
3140         [Qt] Fix installation of QtWebProcess binary
3141         https://bugs.webkit.org/show_bug.cgi?id=101735
3142
3143         Reviewed by Simon Hausmann.
3144
3145         Add config test to detect the availability of support
3146         for "program executables" in Qt (libexec).
3147
3148         This test can be removed after the Qt5 release.
3149
3150         * Tools.pro:
3151         * qmake/mkspecs/features/features.prf:
3152         * qmake/config.tests/libexecdir/libexecdir.cpp:
3153         * qmake/config.tests/libexecdir/libexecdir.pro:
3154
3155 2012-11-29  Eric Seidel  <eric@webkit.org>
3156
3157         run-perf-tests does not work when the layout test directory does not exist
3158         https://bugs.webkit.org/show_bug.cgi?id=103572
3159
3160         Reviewed by Ryosuke Niwa.
3161
3162         Make sure that Profiler() calls maybe_make_directory for the output_dir
3163         before ever using it.  It's a little awkward to create the directory
3164         from the constructor, but its simplest that way as the various subclasses
3165         all use the directory at different times.
3166
3167         Since this required having a filesystem in Profiler (and I didn't want
3168         to grab inside Workspace to get one), I just made Profiler expect a
3169         SystemHost instead of a separate filesystem, executive and workspace.
3170
3171         * Scripts/webkitpy/common/system/profiler.py:
3172         (ProfilerFactory.create_profiler):
3173         (Profiler.__init__):
3174         (SingleFileOutputProfiler.__init__):
3175         (GooglePProf.__init__):
3176         (GooglePProf.profile_after_exit):
3177         (Instruments.__init__):
3178         (Instruments.attach_to_pid):
3179         * Scripts/webkitpy/common/system/profiler_unittest.py:
3180         (ProfilerFactoryTest.test_basic):
3181
3182 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
3183
3184         Adding secondary email id
3185         https://bugs.webkit.org/show_bug.cgi?id=103594
3186
3187         Unreviewed. Adding secondary email.
3188
3189         * Scripts/webkitpy/common/config/committers.py:
3190
3191 2012-11-28  Kent Tamura  <tkent@chromium.org>
3192
3193         garden-o-matic: Use indeterminate <progress> in the status area
3194         https://bugs.webkit.org/show_bug.cgi?id=103494
3195
3196         Reviewed by Adam Barth.
3197
3198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3199         Wrap the "Processing..." message with an indeterminate progress bar.
3200         We keep the message as a fallback content.
3201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3202         Follow the above change.
3203
3204 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
3205
3206         Adding Nima Ghanavatian to committers.py
3207         https://bugs.webkit.org/show_bug.cgi?id=103533
3208
3209         Reviewed by Rob Buis.
3210
3211         Adding myself to committers.py as a Committer.
3212
3213         * Scripts/webkitpy/common/config/committers.py:
3214
3215 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
3216
3217         [WinCairo] Crash when requesting favicon.
3218         https://bugs.webkit.org/show_bug.cgi?id=102689
3219
3220         Reviewed by Brent Fulgham.
3221
3222         * TestWebKitAPI/Tests/WebCore/win: Added.
3223         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
3224         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
3225         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
3226         (TestWebKitAPI::TEST): Added new test.
3227         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
3228        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
3229
3230 2012-11-28  Eric Seidel  <eric@webkit.org>
3231
3232         run-perf-tests should have a --profile option for easy profiling
3233         https://bugs.webkit.org/show_bug.cgi?id=99517
3234
3235         Reviewed by Adam Barth.
3236
3237         This is a very basic implementation which works on Mac and Linux
3238         and makes it trivial for anyone to profile a PerformanceTest.
3239
3240         Currently it's not "hard" to profile a PerformanceTest
3241         but lowering the barriers to entry here allows all of us to focus
3242         less on the tools and more on the code.
3243
3244         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
3245         which is actually "hard", and this option will make much easier.
3246
3247         * Scripts/webkitpy/common/system/profiler.py: Added.
3248         (ProfilerFactory):
3249         (ProfilerFactory.create_profiler):
3250         (Profiler):
3251         (Profiler.__init__):
3252         (Profiler.adjusted_environment):
3253         (Profiler.attach_to_pid):
3254         (Profiler.did_stop):
3255         (SingleFileOutputProfiler):
3256         (SingleFileOutputProfiler.__init__):
3257         (GooglePProf):
3258         (GooglePProf.__init__):
3259         (GooglePProf.adjusted_environment):
3260         (GooglePProf.did_stop):
3261         (Instruments):
3262         (Instruments.__init__):
3263         (Instruments.attach_to_pid):
3264         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
3265         (ProfilerFactoryTest):
3266         (ProfilerFactoryTest.test_basic):
3267         * Scripts/webkitpy/layout_tests/port/driver.py:
3268         (Driver.__init__):
3269         (Driver._start):
3270         (Driver.stop):
3271         (Driver.cmd_line):
3272         * Scripts/webkitpy/performance_tests/perftest.py:
3273         (PerfTest.parse_output):
3274         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3275         (MainTest.test_parse_output):
3276         (MainTest.test_parse_output_with_failing_line):
3277         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3278         (PerfTestsRunner._parse_args):
3279         (PerfTestsRunner.run):
3280
3281 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
3282
3283         Remove deprecated logging usage from QueueEngine
3284         https://bugs.webkit.org/show_bug.cgi?id=103532
3285
3286         Reviewed by Dirk Pranke.
3287
3288         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
3289         logging through the Logger object. The unit test is modified to reflect
3290         these changes.
3291
3292         After these changes the deprecated logging (i.e. logging to stderr) is not
3293         used anymore through webkitpy and can be removed.
3294
3295         * Scripts/webkitpy/tool/bot/queueengine.py:
3296         (QueueEngine.exit_after_handled_error):
3297         (QueueEngine.run):
3298         (QueueEngine._stopping):
3299         (QueueEngine._sleep):
3300         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3301         (QueueEngineTest._run_engine):
3302
3303 2012-11-28  Nate Chapin  <japhet@chromium.org>
3304
3305         Move empty loading to DocumentLoader, simplify FrameLoader::init()
3306         https://bugs.webkit.org/show_bug.cgi?id=101512
3307
3308         Reviewed by Adam Barth.
3309
3310         * DumpRenderTree/chromium/WebViewHost.cpp:
3311         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
3312             interprets them as a non-empty load. This change is required for
3313              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
3314         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
3315              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
3316         (TestWebKitAPI::didFinishLoadForFrame):
3317         (TestWebKitAPI::TEST):
3318
3319 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3320
3321         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
3322         https://bugs.webkit.org/show_bug.cgi?id=103092
3323
3324         Reviewed by Tony Chang.
3325
3326         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
3327         from touch events.
3328
3329         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3330         (parseTouchEventRequestType):
3331         (TestWebPlugin::TestWebPlugin):
3332         (TestWebPlugin::initialize):
3333         * DumpRenderTree/chromium/TestWebPlugin.h:
3334         (TestWebPlugin):
3335
3336 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3337
3338         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
3339         https://bugs.webkit.org/show_bug.cgi?id=103123
3340
3341         Reviewed by Laszlo Gombos.
3342
3343         Add support for PlatformWebView::simulateSpacebarKeyPress().
3344         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
3345         which is going to be unskipped in bug #103252.
3346
3347         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3348         (TestWebKitAPI::Util::sleep):
3349         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
3350         sleep().
3351         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3352         (TestWebKitAPI):
3353
3354 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
3355
3356         Minor cleanup in TestInvocation
3357         https://bugs.webkit.org/show_bug.cgi?id=103512
3358
3359         Reviewed by Kenneth Rohde Christiansen.
3360
3361         Remove a function declaration that is not defined and not used.
3362         Fix spelling error in m_webProcessIsUnresponsive.
3363
3364         * WebKitTestRunner/TestInvocation.cpp:
3365         (WTR::TestInvocation::TestInvocation):
3366         (WTR::TestInvocation::invoke):
3367         * WebKitTestRunner/TestInvocation.h:
3368         (TestInvocation):
3369         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3370         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3371         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3372         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3373
3374 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3375
3376         Unreviewed. Use my personal email as bugzilla email.
3377
3378         * Scripts/webkitpy/common/config/committers.py:
3379
3380 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3381
3382         Unreviewed. Adding myself to committers.py.
3383
3384         * Scripts/webkitpy/common/config/committers.py:
3385
3386 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
3387
3388         Unreviewed. Adding myself to committers.py.
3389
3390         * Scripts/webkitpy/common/config/committers.py:
3391
3392 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
3393
3394         Add basic implementation for MediaStreamAudioDestinationNode
3395         https://bugs.webkit.org/show_bug.cgi?id=101815
3396
3397         Reviewed by Chris Rogers.
3398
3399         Adds a bit of code that exercises the WebKit API.
3400
3401         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3402         (MockWebMediaStreamSourceConsumer):
3403         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
3404         (MockWebMediaStreamCenter::didCreateMediaStream):
3405
3406 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
3407
3408         Unreviewed. Adding myself to committers list.
3409
3410         * Scripts/webkitpy/common/config/committers.py:
3411
3412 2012-11-27  Li Yin  <li.yin@intel.com>
3413
3414         Unreviewed. Adding myself to committers list.
3415
3416         * Scripts/webkitpy/common/config/committers.py:
3417
3418 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
3419
3420         Unreviewed. Adding myself to committers.py.
3421
3422         * Scripts/webkitpy/common/config/committers.py:
3423
3424 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
3425
3426         Unreviewd. Adding myself to committers list.
3427
3428         * Scripts/webkitpy/common/config/committers.py:
3429
3430 2012-11-27  Tony Chang  <tony@chromium.org>
3431
3432         Bring back partytime!
3433         https://bugs.webkit.org/show_bug.cgi?id=103466
3434
3435         Reviewed by Adam Barth.
3436
3437         "code 404, message Unknown function images/partytime_gif" since we didn't
3438         allow .gif or .png files to be served.
3439
3440         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3441         (GardeningHTTPRequestHandler):
3442
3443 2012-11-27  Adam Barth  <abarth@webkit.org>
3444
3445         run-perf-tests fails on Android because of stderr output
3446         https://bugs.webkit.org/show_bug.cgi?id=103462
3447
3448         Reviewed by Ryosuke Niwa.
3449
3450         The chromium-android port produces some stderr output that causes
3451         run-perf-tests to get sad and not record the results of the performance
3452         test. This patch teaches run-perf-test to ignore this output much in
3453         the same way that it currently ignores some stdout messages.
3454
3455         * Scripts/webkitpy/performance_tests/perftest.py:
3456         (PerfTest.run):
3457         (PerfTest._should_ignore_line):
3458         (PerfTest):
3459         (PerfTest._should_ignore_line_in_stderr):
3460         (PerfTest._filter_stderr):
3461         (PerfTest._should_ignore_line_in_parser_test_result):
3462
3463 2012-11-27  Tony Chang  <tony@chromium.org>
3464
3465         Fix garden-o-matic for non-chromium ports
3466         https://bugs.webkit.org/show_bug.cgi?id=103458
3467
3468         Reviewed by Adam Barth.
3469
3470         I was getting a 403 error when trying to select any non-chromium port.
3471
3472         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3473         (ReflectionHandler._handle_request): Use the path without query params.
3474
3475 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
3476
3477         [EFL][WK2] 3D pixel tests are failing
3478         https://bugs.webkit.org/show_bug.cgi?id=102833
3479
3480         Reviewed by Kenneth Rohde Christiansen.
3481
3482         Generate a snapshot of the view in the UI process instead of the web process.
3483         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
3484
3485         * WebKitTestRunner/TestInvocation.h:
3486         (TestInvocation):
3487         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3488         (WTR::writeFunction):
3489         (WTR::paintRepaintRectOverlay):
3490         (WTR):
3491         (WTR::TestInvocation::forceRepaintDoneCallback):
3492         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3493         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3494         (WTR::PlatformWebView::windowSnapshotImage):
3495
3496 2012-11-27  Adam Barth  <abarth@webkit.org>
3497
3498         Make it possible to run performance tests on Chromium Android
3499         https://bugs.webkit.org/show_bug.cgi?id=103268
3500
3501         Reviewed by Ryosuke Niwa.
3502
3503         Based on a patch by Peter Beverloo.
3504
3505         This patch (almost) makes it possible to run WebKit performance tests
3506         on the Chromium port for Android. There are a few things I had to do
3507         in order to make this happen:
3508
3509         1) The worker number when creating a driver for a port is zero-based
3510            for layout tests and elsewhere. Android uses this to determine
3511            which device it has to run on, so make it zero based for performance
3512            tests as well.
3513
3514         2) Tests aren't available on the Android device, so we start an HTTP
3515            server that serves the tests to the device or emulator.
3516
3517         The one shortcoming of this patch is that chromium-android produces
3518         some stderr output that confuses run-perf-tests. I'll address that
3519         issue in a subsequent CL. This patch also depends on
3520         https://codereview.chromium.org/11416182 in order to work.
3521
3522         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3523         (ChromiumAndroidPort.start_http_server):
3524         (ChromiumAndroidDriver._command_from_driver_input):
3525         * Scripts/webkitpy/performance_tests/perftest.py:
3526         (ReplayPerfTest.prepare):
3527         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3528         (PerfTestsRunner.__init__):
3529         (PerfTestsRunner._parse_args):
3530         (PerfTestsRunner._start_servers):
3531         (PerfTestsRunner):
3532         (PerfTestsRunner._stop_servers):
3533         (PerfTestsRunner.run):
3534         (PerfTestsRunner._run_tests_set):
3535
3536 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
3537
3538         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
3539         https://bugs.webkit.org/show_bug.cgi?id=103408
3540
3541         Reviewed by Dirk Pranke.
3542
3543         Remove the use of the deprecated log and error methods by replacing them with
3544         logging through Python's logging.Logger objects.
3545
3546         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
3547         updates any affected unit test.
3548
3549         * Scripts/webkitpy/common/checkout/changelog.py:
3550         (ChangeLogEntry._parse_entry):
3551         * Scripts/webkitpy/common/checkout/checkout.py:
3552         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3553         (CheckoutTest.test_apply_patch):
3554         * Scripts/webkitpy/common/checkout/deps_mock.py:
3555         (MockDEPS.write_variable):
3556         * Scripts/webkitpy/common/checkout/scm/detection.py:
3557         (SCMDetector.default_scm):
3558         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3559         (SCMDetectorTest.test_detect_scm_system):
3560         * Scripts/webkitpy/common/checkout/scm/git.py:
3561         (Git._check_git_architecture):
3562         (Git._commit_on_branch):
3563         * Scripts/webkitpy/common/checkout/scm/scm.py:
3564         (SCM.ensure_clean_working_directory):
3565         (SCM.ensure_no_local_commits):
3566         (SCM.will.commit_locally_with_message):
3567         * Scripts/webkitpy/common/checkout/scm/svn.py:
3568         (SVN.apply_reverse_diff):
3569         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
3570         (Attachment._validate_flag_value):
3571         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3572         (Bugzilla._fetch_bug_page):
3573         (Bugzilla.bug_id_for_attachment_id):
3574         (Bugzilla.authenticate):
3575         (Bugzilla._commit_queue_flag):
3576         (Bugzilla.add_attachment_to_bug):
3577         (Bugzilla.add_patch_to_bug):
3578         (Bugzilla.create_bug):
3579         (Bugzilla.clear_attachment_flags):
3580         (Bugzilla.set_flag_on_attachment):
3581         (Bugzilla.obsolete_attachment):
3582         (Bugzilla.add_cc_to_bug):
3583         (Bugzilla.post_comment_to_bug):
3584         (Bugzilla.close_bug_as_fixed):
3585         (Bugzilla.reassign_bug):
3586         (reopen_bug):
3587         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3588         (MockBugzilla.create_bug):
3589         (MockBugzilla.reassign_bug):
3590         (MockBugzilla.set_flag_on_attachment):
3591         (MockBugzilla.post_comment_to_bug):
3592         (MockBugzilla.add_attachment_to_bug):
3593         (MockBugzilla.add_patch_to_bug):
3594         (MockBugzilla.reopen_bug):
3595         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3596         (test_add_cc_to_bug):
3597         (_assert_reopen):
3598         (test_reopen_bug):
3599         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3600         (MockBuilder.force_build):
3601         * Scripts/webkitpy/common/net/credentials.py:
3602         (Credentials._run_security_tool):
3603         * Scripts/webkitpy/common/net/credentials_unittest.py:
3604         (_assert_security_call):
3605         * Scripts/webkitpy/common/net/irc/irc_mock.py:
3606         (MockIRC.post):
3607         (MockIRC.disconnect):
3608         * Scripts/webkitpy/common/net/irc/ircproxy.py:
3609         (IRCProxy.__init__):
3610         (IRCProxy.disconnect):
3611         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3612         (IRCProxyTest.test_trivial):
3613         * Scripts/webkitpy/common/net/layouttestresults.py:
3614         (ORWTResultsHTMLParser._failures_from_fail_row):
3615         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3616         (test_failures_from_fail_row):
3617         * Scripts/webkitpy/common/net/networktransaction.py:
3618         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3619         (JSONTestResult._tokenize):
3620         (JSONTestResult._failure_types_from_actual_result):
3621         * Scripts/webkitpy/common/net/statusserver.py:
3622         (StatusServer.update_status):
3623         (StatusServer.update_svn_revision):
3624         * Scripts/webkitpy/common/net/statusserver_mock.py:
3625         (MockStatusServer.release_work_item):
3626         (MockStatusServer.update_work_items):
3627         (MockStatusServer.submit_to_ews):
3628         (MockStatusServer.update_status):
3629         * Scripts/webkitpy/common/net/unittestresults.py:
3630         (UnitTestResults.results_from_string):
3631         * Scripts/webkitpy/common/system/executive_mock.py:
3632         (MockExecutive.running_pids):
3633         (MockExecutive.run_and_throw_if_fail):
3634         (MockExecutive.run_command):
3635         (MockExecutive.popen):
3636         * Scripts/webkitpy/common/system/user_mock.py:
3637         (MockUser.confirm):
3638         (MockUser.open_url):
3639         * Scripts/webkitpy/common/system/workspace_unittest.py:
3640         (WorkspaceTest.test_create_zip):
3641         (WorkspaceTest.test_create_zip_exception):
3642         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
3643         (MockWatchList.determine_cc_and_messages):
3644         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3645         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
3646         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: