Stop installing localizedStrings.js in Production builds.
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-24  Brady Eidson  <beidson@apple.com>
2
3         <rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664
4          Need DOMWindow mechanism to supplement UserScripts for page cache notifications
5
6         Reviewed by Sam Weinig.
7
8         Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.
9
10         It makes sure new extensions can be added at the right times, and that all of the expected
11         callbacks are made.
12
13         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
14         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
15         (TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
16            bundle to a set of known expected messages.
17
18         Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
19         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
20         (TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
21         (TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
22         (TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
23         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
24         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
25         (TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
26         (TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
27         (TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
28         (TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
29         (TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
30         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
31         (TestWebKitAPI::didFinishLoadForFrameCallback):
32         (TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
33         (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
34         (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
35         (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
36
37         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
38         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.
39
40         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41
42 2012-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
43
44         [GTK] Build and run TestWebKitAPI unit tests
45         https://bugs.webkit.org/show_bug.cgi?id=84325
46
47         Reviewed by Philippe Normand.
48
49         We only build WTF unit tests for now. WebKit2 tests will be
50         enabled in a follow up patch.
51
52         * Scripts/run-gtk-tests:
53         (TestRunner): Add TestWebKitAPI/WTF to the list of directories
54         containing unit tests.
55         (TestRunner._run_test_glib): Run glib tests using gtester.
56         (TestRunner._run_test_google): Run google tests.
57         (TestRunner._run_test): Use _run_test_glib or _run_test_google
58         depending on whether given test is glib or google test
59         * TestWebKitAPI/GNUmakefile.am: Added.
60         * TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
61         warning with -Wundef. Include WebKit2 headers only when building
62         WebKit2.
63
64 2012-04-24  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
65
66         [Qt][WK2] Convert touch-point area
67         https://bugs.webkit.org/show_bug.cgi?id=84434
68
69         Reviewed by Kenneth Rohde Christiansen.
70
71         Fix failing test after r114917 by also adding the new EventSender API
72         to WebKitTestRunner.
73
74         * WebKitTestRunner/EventSenderProxy.h:
75         (EventSenderProxy):
76         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
77         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
78         (WTR::EventSendingController::setTouchPointRadius):
79         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
80         (EventSendingController):
81         * WebKitTestRunner/TestController.cpp:
82         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
83         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
84         (WTR::EventSenderProxy::addTouchPoint):
85         (WTR::EventSenderProxy::updateTouchPoint):
86         (WTR::EventSenderProxy::setTouchPointRadius):
87         (WTR::EventSenderProxy::clearTouchPoints):
88
89 2012-04-24  Mikhail Naganov  <mnaganov@chromium.org>
90
91         [Chromium] Unreviewed test expectations update.
92         https://bugs.webkit.org/show_bug.cgi?id=84726
93
94         Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
95
96         * Scripts/webkitpy/test/test_finder.py:
97         (TestFinder._default_names):
98
99 2012-04-24  Christophe Dumez  <christophe.dumez@intel.com>
100
101         [EFL] Enable Web Timing
102         https://bugs.webkit.org/show_bug.cgi?id=84705
103
104         Reviewed by Tony Gentilcore.
105
106         Enable web timing by default whenever build-webkit is used.
107
108         * Scripts/build-webkit:
109
110 2012-04-23  Eriq Augustine  <eaugusti@chromium.org>
111
112         Return value from executed script in Chromium.
113         https://bugs.webkit.org/show_bug.cgi?id=79851
114
115         Reviewed by Adam Barth.
116
117         Adding a function to LayoutTestController that evaluates a script in
118         an isolated wold an returns the result of the evaluation.
119
120         * DumpRenderTree/LayoutTestController.cpp:
121         (evaluateScriptInIsolatedWorldAndReturnValue):
122         (LayoutTestController::staticFunctions):
123         * DumpRenderTree/LayoutTestController.h:
124         (LayoutTestController):
125         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
126         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
127         * DumpRenderTree/chromium/LayoutTestController.cpp:
128         (LayoutTestController::LayoutTestController):
129         (LayoutTestController::setXSSAuditorEnabled):
130         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
131         * DumpRenderTree/chromium/LayoutTestController.h:
132         (LayoutTestController):
133         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
134         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
135         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
136         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
137         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
138         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
139         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
140         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
141         * DumpRenderTree/qt/LayoutTestControllerQt.h:
142         (LayoutTestController):
143         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
144         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
145         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
146         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
147
148 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
149
150         run-perf-tests fail intermittently with an exception
151         https://bugs.webkit.org/show_bug.cgi?id=83532
152
153         Reviewed by Ryosuke Niwa.
154
155         This bulletproofs port.get_option('child_processes')
156         against the case where the option wasn't set.
157
158         * Scripts/webkitpy/layout_tests/port/mac.py:
159         (MacPort._get_crash_log):
160         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
161         (test_get_crash_log):
162         (test_get_crash_log.fake_time_cb):
163
164 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
165
166         [Qt] Add desktop zooming support for QQuickWebView
167         https://bugs.webkit.org/show_bug.cgi?id=82337
168
169         Unreviewed typo fix after r114900.
170
171         * MiniBrowser/qt/BrowserWindow.cpp:
172         (BrowserWindow::BrowserWindow): Fix the mistyped
173         value of a zoom level.
174
175 2012-04-23  Hao Zheng  <zhenghao@chromium.org>
176
177         [chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
178         https://bugs.webkit.org/show_bug.cgi?id=84580
179
180         Reviewed by Ojan Vafai.
181
182         Android's first fallback font is changed to DroidSansArabic.ttf in JB.
183         Take the opportunity to get rid of the trick.
184
185         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
186         (ChromiumAndroidPort.start_helper):
187         (ChromiumAndroidPort._push_fonts):
188
189 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
190
191         test-webkitpy is failing
192         https://bugs.webkit.org/show_bug.cgi?id=84617
193
194         Reviewed by Eric Seidel.
195
196         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
197         (HttpLockTestWithRealFileSystem.clean_all_lockfile):
198
199 2012-04-23  Ojan Vafai  <ojan@chromium.org>
200
201         Split up flakiness_dashboard.html into multiple files. This is a step in the direction
202         of making the code more maintainable (e.g. being able to use qunit for testing).
203
204         * TestResultServer/static-dashboards/dashboard_base.js:
205         * TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
206         * TestResultServer/static-dashboards/flakiness_dashboard.html:
207         * TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
208         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
209         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.
210
211 2012-04-23  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
212
213         [Qt][WK2] Convert touch-point area.
214         https://bugs.webkit.org/show_bug.cgi?id=84434
215
216         Reviewed by Kenneth Rohde Christiansen.
217
218         Add feature to set touch-point radius for emitted touch-events.
219
220         * DumpRenderTree/qt/EventSenderQt.cpp:
221         (EventSender::addTouchPoint):
222         (EventSender::updateTouchPoint):
223         (EventSender::setTouchPointRadius):
224         (EventSender::clearTouchPoints):
225         * DumpRenderTree/qt/EventSenderQt.h:
226         (EventSender):
227
228 2012-04-23  Christophe Dumez  <christophe.dumez@intel.com>
229
230         [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
231         https://bugs.webkit.org/show_bug.cgi?id=84425
232
233         Reviewed by Antonio Gomes.
234
235         Use the new helper in DumpRenderTreeSupportEfl to properly
236         test whether an element performs autocompletion.
237
238         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
239         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
240
241 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
242
243         master.cfg cleanup, remove dead codes after r92792.
244         https://bugs.webkit.org/show_bug.cgi?id=84433
245
246         Relanding r114881 after typo fix in UploadBuiltProduct.
247
248         Reviewed by Ryosuke Niwa.
249
250         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
251
252 2012-04-23  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
253
254         [EFL][DRT] Need to support requestAnimationFrame
255         https://bugs.webkit.org/show_bug.cgi?id=84585
256
257         Reviewed by Martin Robinson.
258
259         Making requestAnimationFrame() support a default on the EFL build.
260
261         * Scripts/build-webkit:
262
263 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
264
265         [Qt] Add desktop zooming support for QQuickWebView
266         https://bugs.webkit.org/show_bug.cgi?id=82337
267
268         Reviewed by Simon Hausmann.
269
270         Add zooming support for MiniBrowser to
271         test the new API.
272
273         * MiniBrowser/qt/BrowserWindow.cpp:
274         (BrowserWindow::BrowserWindow):
275         (BrowserWindow::zoomIn):
276         (BrowserWindow::zoomOut):
277         (BrowserWindow::keyPressEvent):
278         (BrowserWindow::wheelEvent):
279         * MiniBrowser/qt/BrowserWindow.h:
280         (BrowserWindow):
281
282 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
283
284         Unreviewed rolling out r114881, because it broke upload buildstep.
285
286         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
287         (ConfigureBuild.__init__):
288         (ConfigureBuild.start):
289         (CompileWebKit.start):
290         (UploadBuiltProduct):
291         (UploadBuiltProduct.determineExtraFeatures):
292         (Factory.__init__):
293         (BuildFactory.__init__):
294         (TestFactory.__init__):
295         (loadBuilderConfig):
296
297 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
298
299         master.cfg cleanup, remove dead codes after r92792.
300         https://bugs.webkit.org/show_bug.cgi?id=84433
301
302         Reviewed by Ryosuke Niwa.
303
304         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
305
306 2012-04-23  Milian Wolff  <mail@milianw.de>
307
308         [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
309         https://bugs.webkit.org/show_bug.cgi?id=84327
310
311         Reviewed by Csaba Osztrogonác.
312
313         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
314         (WebCore::DumpRenderTree::dump):
315
316 2012-04-22  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
317
318         [Gtk] Added MOZ_X11 build flag for TARGET_X11
319         https://bugs.webkit.org/show_bug.cgi?id=40785
320
321         Reviewed by Anders Carlsson.
322
323         * GNUmakefile.am:
324
325 2012-04-22  Zan Dobersek  <zandobersek@gmail.com>
326
327         [TestResultsServer] Impossible to inspect builds on non-Chromium builders
328         https://bugs.webkit.org/show_bug.cgi?id=84544
329
330         Reviewed by Ryosuke Niwa.
331
332         Use the groupEnum parameter that is passed through to the onBuilderListLoad
333         function rather than an undefined attribute of the BuilderGroup object. This
334         makes it again possible to inspect builds on non-Chromium builders in the
335         test results server by not trying to always add Chromium revision links.
336
337         * TestResultServer/static-dashboards/builders.js:
338
339 2012-04-20  Martin Robinson  <mrobinson@igalia.com>
340
341         [GTK] Revert changes that disabled Cairo fonts metrics hinting
342         https://bugs.webkit.org/show_bug.cgi?id=84502
343
344         Reviewed by Daniel Bates.
345
346         Re-enable Cairo metrics hinting, which seems to ensure consistent results in
347         reference and pixel test results. This makes our font metrics a bit different
348         than the Mac port's, but it's a decent price to pay for consistent results.
349
350         * DumpRenderTree/gtk/DumpRenderTree.cpp:
351         (initializeGtkFontSettings):
352         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
353         (WTR::initializeGtkSettings):
354
355 2012-04-04  Jer Noble  <jer.noble@apple.com>
356
357         apple.com top navigation bar appears inside video during full screen exit animation
358         https://bugs.webkit.org/show_bug.cgi?id=83095
359
360         Reviewed by Eric Carlson.
361
362         Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
363         disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
364         Document methods from within the script.  This allows subtle timing bugs to be consistently reproduced
365         from within LayoutTests.
366
367         Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
368         * DumpRenderTree/LayoutTestController.cpp:
369         (setHasCustomFullScreenBehaviorCallback):
370         (LayoutTestController::staticFunctions):
371         * DumpRenderTree/LayoutTestController.h:
372         (LayoutTestController::setHasCustomFullScreenBehavior):
373         (LayoutTestController::hasCustomFullScreenBehavior):
374         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
375         (WTR::InjectedBundlePage::enterFullScreenForElement):
376         (WTR::InjectedBundlePage::exitFullScreenForElement):
377         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
378         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
379         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
380         (WTR::LayoutTestController::setHasCustomFullScreenBehavior):
381         (WTR::LayoutTestController::hasCustomFullScreenBehavior):
382         * DumpRenderTree/chromium/LayoutTestController.cpp:
383         (LayoutTestController::LayoutTestController):
384         (LayoutTestController::reset):
385         * DumpRenderTree/chromium/LayoutTestController.h:
386         (LayoutTestController::setHasCustomFullScreenBehavior):
387         (LayoutTestController::hasCustomFullScreenBehavior):
388
389         Query the new methods before calling will/did/Enter/ExitFullScreen:
390         * DumpRenderTree/chromium/WebViewHost.cpp:
391         (WebViewHost::enterFullScreenNow):
392         (WebViewHost::exitFullScreenNow):
393         * DumpRenderTree/mac/UIDelegate.mm:
394         (-[UIDelegate webView:enterFullScreenForElement:listener:]):
395         (-[UIDelegate webView:exitFullScreenForElement:listener:]):
396
397 2012-04-20  Nandor Huszka  <hnandor@inf.u-szeged.hu>
398
399         NRWT: option --skip-pixel-test-if-no-baseline support on DRT
400         https://bugs.webkit.org/show_bug.cgi?id=72841
401
402         Reviewed by Dirk Pranke
403
404         This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
405         instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
406         and 'reference_files' fields to the TestInput objects, and use those flags
407         to select the right driver to use in the DriverProxy.
408
409         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
410         (SingleTestRunner.__init__):
411         (SingleTestRunner._driver_input):
412         (SingleTestRunner._run_reftest):
413         * Scripts/webkitpy/layout_tests/controllers/worker.py:
414         (Worker.handle_test_list):
415         (Worker._update_test_input):
416         * Scripts/webkitpy/layout_tests/models/test_input.py:
417         (TestInput):
418         (TestInput.__init__):
419         (TestInput.__repr__):
420         * Scripts/webkitpy/layout_tests/port/chromium.py:
421         (ChromiumDriver._wrapper_options):
422         (ChromiumDriver.run_test):
423         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
424         (ChromiumDriverTest.test_crash_log):
425         * Scripts/webkitpy/layout_tests/port/driver.py:
426         (DriverInput.__init__):
427         (Driver.__init__):
428         (DriverProxy.__init__):
429         (DriverProxy.run_test):
430         (DriverProxy.start):
431         (DriverProxy.cmd_line):
432         * Scripts/webkitpy/layout_tests/port/gtk.py:
433         (GtkDriver._start):
434         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
435         (MockDRT.run):
436         (MockDRT.input_from_line):
437         (MockDRT.output_for_test):
438         (MockDRT.write_test_output):
439         (MockChromiumDRT.input_from_line):
440         (MockChromiumDRT.output_for_test):
441         (MockChromiumDRT.write_test_output):
442         * Scripts/webkitpy/layout_tests/port/webkit.py:
443         (WebKitDriver.cmd_line):
444         (WebKitDriver.run_test):
445         * WebKitTestRunner/TestController.cpp:
446         (WTR::TestController::TestController):
447         (WTR::TestController::initialize):
448         (WTR::TestController::runTest):
449         * WebKitTestRunner/TestController.h:
450         (TestController):
451         * WebKitTestRunner/TestInvocation.cpp:
452         (WTR::TestInvocation::TestInvocation):
453         (WTR::TestInvocation::setIsPixelTest):
454         * WebKitTestRunner/TestInvocation.h:
455         (TestInvocation):
456
457 2012-04-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
458
459         [EFL] Make it possible to define offline storage quota per origin
460         https://bugs.webkit.org/show_bug.cgi?id=84170
461
462         Improved LayoutTestController::setDatabaseQuota to set quota based on
463         origin which was causing some tests to fail. Also align the default
464         quota for testing (5MB) with others ports.
465
466         When dumpDatabaseCallbacks is set to true by, also dump some database
467         information when quota is exceed, which is also required by some tests.
468
469         Reviewed by Antonio Gomes.
470
471         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
472         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
473         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
474         (onExceededDatabaseQuota):
475         (drtViewAdd):
476         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
477         (LayoutTestController::setDatabaseQuota):
478
479 2012-04-20  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
480
481         [EFL] [DRT] Send double click event from EventSender
482         https://bugs.webkit.org/show_bug.cgi?id=82867
483
484         Reviewed by Daniel Bates.
485
486         Add support for EFL DumpRenderTree EventSender to send
487         double click events.
488
489         * DumpRenderTree/efl/EventSender.cpp:
490         (sendMouseEvent):
491
492 2012-04-20  Sergio Villar Senin  <svillar@igalia.com>
493
494         [GTK] Enable Web Timing
495         https://bugs.webkit.org/show_bug.cgi?id=42432
496
497         Reviewed by Gustavo Noronha Silva.
498
499         Build web timing by default whenever build-webkit is used.
500
501         * Scripts/build-webkit:
502
503 2012-04-20  Kamil Blank  <k.blank@samsung.com>
504
505         [EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
506         https://bugs.webkit.org/show_bug.cgi?id=84430
507
508         Reviewed by Daniel Bates.
509
510         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
511         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
512
513 2012-04-20  Ryosuke Niwa  <rniwa@webkit.org>
514
515         REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
516         https://bugs.webkit.org/show_bug.cgi?id=84424
517
518         Reviewed by Mark Rowe.
519
520         Let Windows and Chromium have their own list of files to copy.
521
522         * BuildSlaveSupport/built-product-archive:
523         (removeDirectoryIfExists):
524         (copyBuildFiles):
525         (archiveBuiltProduct):
526
527 2012-04-20  Kamil Blank  <k.blank@samsung.com>
528
529         [EFL] Add setting API for author and user styles.
530         https://bugs.webkit.org/show_bug.cgi?id=82860
531
532         Reviewed by Daniel Bates.
533
534         Implementation of setAuthorAndUserStylesEnabled.
535
536         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
537         (LayoutTestController::setAuthorAndUserStylesEnabled):
538
539 2012-04-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
540
541         [EFL] Missing keycode translation for space key
542         https://bugs.webkit.org/show_bug.cgi?id=84153
543
544         Reviewed by Antonio Gomes.
545
546         Set keyname for space key before dispatching event.
547
548         * DumpRenderTree/efl/EventSender.cpp:
549         (keyNameFromJSValue):
550
551 2012-04-19  Carlos Garcia Campos  <cgarcia@igalia.com>
552
553         [GTK] Allow to use WebInspector in GtkLauncher
554         https://bugs.webkit.org/show_bug.cgi?id=84143
555
556         Reviewed by Martin Robinson.
557
558         * GNUmakefile.am: Add new files to compilation.
559         * GtkLauncher/LauncherInspectorWindow.c: Added.
560         (launcherInspectorWindowFinalize):
561         (launcher_inspector_window_init):
562         (launcher_inspector_window_class_init):
563         (inspectedURIChanged): Update the window title based on current
564         inspected URI.
565         (showInspectorWindow): Show inspector window.
566         (closeInspectorWindow): Hide inspector window.
567         (launcherInspectorWindowNew): Create an inspector window.
568         (launcherInspectorWindowGetWebView): Return the inspected web view.
569         * GtkLauncher/LauncherInspectorWindow.h: Added.
570         * GtkLauncher/main.c:
571         (inspectorInspectWebViewCb): Create an inspector window.
572         (createBrowser): Connect to inspect-web-view signal of the view
573         inspector.
574
575 2012-04-19  Jeremy Mao  <yujie.mao@intel.com>
576
577         Media Stream API: Piece of code cleanup for the chromium port
578         https://bugs.webkit.org/show_bug.cgi?id=84328
579
580         Reviewed by Kent Tamura.
581
582         WebUserMediaClientMock use an old requestUserMedia interface and
583         Replace it with the new interface.
584
585         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
586         (WebKit::WebUserMediaClientMock::requestUserMedia):
587         Remove the old requestUserMedia and replace it with the new.
588         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
589         (WebUserMediaClientMock):
590
591 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
592
593         [EFL] DRT console messages should contain only the file name part of local URIs
594         https://bugs.webkit.org/show_bug.cgi?id=84236
595
596         Reviewed by Kentaro Hara.
597
598         Process console messages before printing them in EFL's DumpRenderTree
599         them so that they contain only the file name part of local URIs. This
600         is what is expected by test cases.
601
602         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
603         (urlSuitableForTestResult):
604         (onConsoleMessage):
605
606 2012-04-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
607
608         [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
609         https://bugs.webkit.org/show_bug.cgi?id=84169
610
611         All databases were being created inside ~/.webkit which was causing
612         flaky tests when running multiple tests in parallel, specially timeouts
613         due to concurrency.
614
615         Reviewed by Eric Seidel.
616
617         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
618         (DumpRenderTreeChrome::initialize):
619
620 2012-04-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
621
622         [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
623         https://bugs.webkit.org/show_bug.cgi?id=82484
624
625         Reviewed by Martin Robinson.
626
627         Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
628
629         * efl/jhbuild.modules:
630         * gtk/jhbuild.modules:
631
632 2012-04-19  Lucas Forschler  <lforschler@apple.com>
633
634         Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
635         
636         * BuildSlaveSupport/build.webkit.org-config/config.json:
637
638 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
639
640         [EFL] dispatchDidCancelClientRedirect needs implementation
641         https://bugs.webkit.org/show_bug.cgi?id=83669
642
643         Reviewed by Antonio Gomes.
644
645         Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
646         and print out information that is expected by several test cases if
647         LayoutTestController's dumpFrameLoadCallback() returns true.
648
649         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
650         (DumpRenderTreeChrome::createView):
651         (DumpRenderTreeChrome::onFrameCreated):
652         (DumpRenderTreeChrome::onFrameRedirectCancelled):
653         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
654         (DumpRenderTreeChrome):
655
656 2012-04-18  Hironori Bono  <hbono@chromium.org>
657
658         Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
659         https://bugs.webkit.org/show_bug.cgi?id=83748
660
661         Reviewed by Ryosuke Niwa.
662
663         This change replaces a call for SpellChecker::didCheck() with one for
664         SpellChecker::didCheckCenceled() because didCheck() has been split into
665         didCheckSucceeded() and didCheckCanceled().
666
667         * DumpRenderTree/chromium/WebViewHost.cpp:
668         (WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.
669
670 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
671
672         Fix failure in test-webkitpy after r114583.
673
674         Unreviewed, build fix.
675
676         Updating the call site in r114583 w/o updating the test caused
677         the test to fail. Somehow I forgot to run the unit tests :(.
678
679         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
680         (ChromiumDriverTest.test_crash_log):
681
682 2012-04-18  Filip Pizlo  <fpizlo@apple.com>
683
684         JSC testing should have complete coverage over typed array types
685         https://bugs.webkit.org/show_bug.cgi?id=84302
686
687         Reviewed by Geoff Garen.
688         
689         Made run-fast-jsc print something and a newline if jsc threw an exception or
690         otherwise returned with an error code, but did not crash.
691
692         * Scripts/run-fast-jsc:
693
694 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
695
696         Fix crash in chromium.py after r114877.
697
698         Unreviewed, build fix.
699
700         Missed updating one call site for get_crash_log() :(.
701
702         * Scripts/webkitpy/layout_tests/port/chromium.py:
703         (ChromiumDriver.run_test):
704
705 2012-04-18  Philippe Normand  <pnormand@igalia.com>
706
707         [GTK] NRWT bails out if more than one X server runs on the machine
708         https://bugs.webkit.org/show_bug.cgi?id=84276
709
710         Reviewed by Dirk Pranke.
711
712         Set up GTK driver's Xvfb display number based on Xorg servers
713         currently running.
714
715         * Scripts/webkitpy/layout_tests/port/gtk.py:
716         (GtkDriver._start):
717         (GtkDriver._start.x_filter):
718
719 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
720
721         run-webkit-tests picked up an old crash log
722         https://bugs.webkit.org/show_bug.cgi?id=84196
723
724         Reviewed by Ryosuke Niwa.
725
726         Modify the crash log-finding code so that we can
727         limit our search to logs newer than X - this prevents
728         us from finding old crash logs for a given process/pid
729         combination even when the PIDs might've wrapped.
730  
731         Also fix a bug in filesystem_mock where files_under() would
732         return paths that didn't exist.
733
734         * Scripts/webkitpy/common/system/crashlogs.py:
735         (CrashLogs.find_newest_log):
736         (CrashLogs._find_newest_log_darwin):
737         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
738         (CrashLogsTest.test_find_log_darwin):
739         (CrashLogsTest.test_find_log_darwin.bad_read):
740         (CrashLogsTest):
741         * Scripts/webkitpy/common/system/filesystem_mock.py:
742         (MockFileSystem.files_under):
743         * Scripts/webkitpy/layout_tests/port/base.py:
744         (Port._get_crash_log):
745         * Scripts/webkitpy/layout_tests/port/gtk.py:
746         (GtkPort._get_crash_log):
747         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
748         * Scripts/webkitpy/layout_tests/port/mac.py:
749         (MacPort._get_crash_log):
750         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
751         (PortTestCase.test_get_crash_log):
752         * Scripts/webkitpy/layout_tests/port/webkit.py:
753         (WebKitDriver.run_test):
754
755 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
756
757         nrwt: support additional test expectations files
758         https://bugs.webkit.org/show_bug.cgi?id=84222
759
760         Reviewed by Ojan Vafai.
761
762         This patch adds an --additional-expectations flag that can be
763         used to point to more files that will override the default set
764         of expectations. This will allow us to remove the
765         'google_chrome' ports and eventually help to clean up override
766         handling in the chromium ports and unify expectations files and
767         Skipped files; this can also be used to specify overrides for
768         tests that run differently on a given machine.
769
770         * Scripts/webkitpy/layout_tests/port/base.py:
771         (Port.test_expectations_overrides):
772         * Scripts/webkitpy/layout_tests/port/chromium.py:
773         (ChromiumPort.test_expectations_overrides):
774         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
775         (parse_args):
776         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
777         (MainTest.test_additional_expectations):
778
779 2012-04-18  Jer Noble  <jer.noble@apple.com>
780
781         Lion Production Test failing with error: "Failed to stop httpd: pid file still exists"
782         https://bugs.webkit.org/show_bug.cgi?id=84177
783
784         Reviewed by Dirk Pranke.
785
786         Try to delete the pid file left by Apache in the case it was killed forcefully.
787
788         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
789         (LayoutTestApacheHttpd._stop_running_server):
790
791 2012-04-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
792
793         Clean-up WheelEvent Conversion.
794         https://bugs.webkit.org/show_bug.cgi?id=84243
795
796         Reviewed by Simon Hausmann.
797         
798         Calculate proper wheel-delta from pixel-delta given.
799
800         * DumpRenderTree/qt/EventSenderQt.cpp:
801         (EventSender::EventSender):
802         (EventSender::mouseScrollBy):
803         (EventSender::continuousMouseScrollBy):
804
805 2012-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
806
807         Unreviewed, rolling out r114506.
808         http://trac.webkit.org/changeset/114506
809         https://bugs.webkit.org/show_bug.cgi?id=84254
810
811         Seems to be making gtk's DumpRenderTree crash occasionally
812         (Requested by tomz on #webkit).
813
814         * DumpRenderTree/gtk/DumpRenderTree.cpp:
815         (resetDefaultsToConsistentValues):
816
817 2012-04-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
818
819         [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
820         https://bugs.webkit.org/show_bug.cgi?id=84229
821
822         CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
823         subsequent builds, stopping WebCore from being built ever again.
824
825         Instead of trying to emulate a build target using command line options,
826         just build the existing jsc target directly.
827
828         Reviewed by Rob Buis.
829
830         * Scripts/build-jsc:
831
832 2012-04-18  Simon Pena  <spena@igalia.com>
833
834         [GTK] r114021 triggered media flakyness
835         https://bugs.webkit.org/show_bug.cgi?id=83874
836
837         Reviewed by Philippe Normand.
838
839         Now that there is gtk API to update the
840         MediaPlaybackRequiresUserGesture property, set it to false from the
841         DumpRenderTree tool when resetting defaults to consistent values.
842
843         * DumpRenderTree/gtk/DumpRenderTree.cpp:
844         (resetDefaultsToConsistentValues):
845
846 2012-04-18  Vivek Galatage  <vivekgalatage@gmail.com>
847
848         Web Inspector: Disabling Inspector causes build failure on Windows
849         https://bugs.webkit.org/show_bug.cgi?id=83557
850
851         Reviewed by Pavel Feldman.
852
853         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
854         This change brings all such API calls under the guard.
855
856         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
857         (WTR::LayoutTestController::showWebInspector):
858         (WTR::LayoutTestController::closeWebInspector):
859         (WTR::LayoutTestController::evaluateInWebInspector):
860         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
861         * WebKitTestRunner/TestInvocation.cpp:
862         (WTR::TestInvocation::invoke):
863
864 2012-04-18  Mario Sanchez Prada  <msanchez@igalia.com>
865
866         [GTK] atk/textChangedNotifications API test fails
867         https://bugs.webkit.org/show_bug.cgi?id=84010
868
869         Unreviewed, unskipping test after bug being fixed by r114311.
870
871         * Scripts/run-gtk-tests:
872         (TestRunner): Unskip now passing test.
873
874 2012-04-17  Jacky Jiang  <zhajiang@rim.com>
875
876         [BlackBerry] Viewport metatag doesn't disable double-tap zoom
877         https://bugs.webkit.org/show_bug.cgi?id=84199
878
879         Reviewed by George Staikos.
880
881         Revert a part of the change master_32/SHA:fa0f8ee9 and use
882         WebPage::setUserScalable instead.
883
884         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
885         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
886
887 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
888
889         build-webkit: make ninja work with chromium linux
890         https://bugs.webkit.org/show_bug.cgi?id=84213
891
892         Reviewed by Eric Seidel.
893
894         Fix typos so that build-webkit will use ninja to
895         build chromium if a build.ninja file exists and is up-to-date.
896
897         * Scripts/webkitdirs.pm:
898         (determineIsChromiumNinja):
899
900 2012-04-17  Ojan Vafai  <ojan@chromium.org>
901
902         Add caching to the flakiness dashboard json files
903         https://bugs.webkit.org/show_bug.cgi?id=84198
904
905         Reviewed by Dirk Pranke.
906
907         * TestResultServer/handlers/testfilehandler.py:
908         (GetFile._get_file_list):
909         (GetFile._get_file_content):
910         (GetFile._get_file_content_from_key):
911         (GetFile._get_test_list_json):
912         (GetFile._serve_json):
913         Add a Last-Modified header and handle If-Modified-Since headers.
914         (GetFile.get):
915
916 2012-04-17  Anders Carlsson  <andersca@apple.com>
917
918         Need a client callback for when the user tries to interact with an already unresponsive page
919         https://bugs.webkit.org/show_bug.cgi?id=84201
920         <rdar://problem/11140862>
921
922         Reviewed by Andreas Kling.
923
924         Add new client functions.
925
926         * MiniBrowser/mac/BrowserWindowController.m:
927         (-[BrowserWindowController awakeFromNib]):
928         * WebKitTestRunner/TestController.cpp:
929         (WTR::TestController::initialize):
930
931 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
932
933         nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
934         https://bugs.webkit.org/show_bug.cgi?id=84190
935
936         Reviewed by Ojan Vafai.
937
938         LayoutTestHelper would exit when the user typed ctrl-c, but we
939         would attempt to write to it to shut it down, generating an
940         IOError.
941
942         * Scripts/webkitpy/layout_tests/port/chromium.py:
943         (ChromiumPort.stop_helper):
944
945 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
946
947         rename --experimental-fully-parallel
948         https://bugs.webkit.org/show_bug.cgi?id=84188
949
950         Reviewed by Ojan Vafai.
951
952         I thought this was done long ago; rename
953         --experimental-fully-parallel to just --fully-parallel and
954         remove the --no- switch that AFAIK no one uses.
955
956         * Scripts/webkitpy/layout_tests/controllers/manager.py:
957         (Manager._run_tests):
958         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
959         (parse_args):
960
961 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
962
963         EFL's LayoutTestController does not implement callShouldCloseOnWebView
964         https://bugs.webkit.org/show_bug.cgi?id=82301
965
966         Reviewed by Martin Robinson.
967
968         Implement callShouldCloseOnWebView in EFL's LayoutTestController by
969         calling shouldClose() on the FrameLoader, allowing the related test
970         to be removed from the skip list.
971
972         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
973         (LayoutTestController::callShouldCloseOnWebView):
974
975 2012-04-17  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
976
977         [EFL] Add setting API to enable/disable XSSAuditor
978         https://bugs.webkit.org/show_bug.cgi?id=83281
979
980         Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
981         in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal 
982         'xss,detected' in DRT to enable a test, which is expecting a line containing
983         'didDetectXSS' in the output when reflected XSS is encountered in the page.
984
985         Reviewed by Antonio Gomes.
986
987         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
988         (DumpRenderTreeChrome::createView):
989         (DumpRenderTreeChrome::onFrameCreated):
990         (DumpRenderTreeChrome::onDidDetectXSS):
991         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
992         (DumpRenderTreeChrome):
993         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
994         (LayoutTestController::setXSSAuditorEnabled):
995
996 2012-04-17  Nandor Huszka  <hnandor@inf.u-szeged.hu>
997
998         [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
999         https://bugs.webkit.org/show_bug.cgi?id=77533
1000
1001         Reviewed by Simon Hausmann.
1002
1003         Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
1004         the corresponding parameter to the buildQMakeProjects function.
1005
1006         * Scripts/build-jsc:
1007
1008 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
1009
1010         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
1011         https://bugs.webkit.org/show_bug.cgi?id=83030
1012
1013         Reviewed by Antonio Gomes.
1014
1015         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
1016         in EFL's DumpRenderTree. Make use of the new frame argument passed to
1017         the "load,started" and "load,finished" signals.
1018
1019         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1020         (DumpRenderTreeChrome::createView):
1021         (DumpRenderTreeChrome::onLoadStarted):
1022         (DumpRenderTreeChrome::processWork):
1023         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
1024         (DumpRenderTreeChrome::onWebViewOnloadEvent):
1025         (DumpRenderTreeChrome::onInsecureContentRun):
1026         (DumpRenderTreeChrome::onInsecureContentDisplayed):
1027         (DumpRenderTreeChrome::onFrameCreated):
1028         (DumpRenderTreeChrome::onFrameProvisionalLoad):
1029         (DumpRenderTreeChrome::onFrameLoadCommitted):
1030         (DumpRenderTreeChrome::onFrameLoadFinished):
1031         (DumpRenderTreeChrome::onFrameLoadError):
1032         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1033         (DumpRenderTreeChrome):
1034
1035 2012-04-17  Sheriff Bot  <webkit.review.bot@gmail.com>
1036
1037         Unreviewed, rolling out r114376.
1038         http://trac.webkit.org/changeset/114376
1039         https://bugs.webkit.org/show_bug.cgi?id=84155
1040
1041         Wrong patch version committed, asked by the patch author.
1042         (Requested by rakuco on #webkit).
1043
1044         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1045         (DumpRenderTreeChrome::createView):
1046         (DumpRenderTreeChrome::processWork):
1047         (DumpRenderTreeChrome::onLoadFinished):
1048         (DumpRenderTreeChrome::onWillSendRequest):
1049         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1050         (DumpRenderTreeChrome):
1051
1052 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
1053
1054         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
1055         https://bugs.webkit.org/show_bug.cgi?id=83030
1056
1057         Reviewed by Antonio Gomes.
1058
1059         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
1060         in EFL's DumpRenderTree.
1061
1062         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1063         (DumpRenderTreeChrome::createView):
1064         (DumpRenderTreeChrome::processWork):
1065         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
1066         (DumpRenderTreeChrome::onWebViewOnloadEvent):
1067         (DumpRenderTreeChrome::onInsecureContentRun):
1068         (DumpRenderTreeChrome::onInsecureContentDisplayed):
1069         (DumpRenderTreeChrome::onFrameCreated):
1070         (DumpRenderTreeChrome::onFrameProvisionalLoad):
1071         (DumpRenderTreeChrome::onFrameLoadCommitted):
1072         (DumpRenderTreeChrome::onFrameLoadFinished):
1073         (DumpRenderTreeChrome::onFrameLoadError):
1074         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1075         (DumpRenderTreeChrome):
1076
1077 2012-04-17  Michael Brüning  <michael.bruning@nokia.com>
1078
1079         [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
1080         https://bugs.webkit.org/show_bug.cgi?id=83035
1081
1082         Reviewed by Simon Hausmann.
1083
1084         The force_static_libs_as_shared feature for the Qt port will remove
1085         hide_symbols from Qt's CONFIG in order to make them visible to other
1086         libraries again.
1087
1088         Due to an evaluation order problem in qmake, the flags for the C++ compiler
1089         that are set by adding hide_symbols to the CONFIG variables get applied
1090         to qmake's C++ compiler flags directly and hence trying to remove these
1091         later will not work and cause build failures when using the force_static_libs_as_shared
1092         feature of the Qt port.
1093
1094         This is fixed by removing the flags that hide the exports from the compiler flags directly.
1095
1096         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
1097
1098 2012-04-16  Ryosuke Niwa  <rniwa@webkit.org>
1099
1100         Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
1101         https://bugs.webkit.org/show_bug.cgi?id=84068
1102
1103         Reviewed by Eric Seidel.
1104
1105         Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
1106         automatically creates the build directory if needed.
1107
1108         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1109         (DownloadAndPerfTestFactory.__init__):
1110         (DownloadAndPerfTestWebKit2Factory.__init__):
1111
1112 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1113
1114         [GTK] Use configure instead of autogen.sh for gtk+
1115         https://bugs.webkit.org/show_bug.cgi?id=84112
1116
1117         Rubber-stamped by Martin Robinson.
1118
1119         * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
1120         we don't want to depend on that for now, so run configure instead - we
1121         can, since we are using a tarball
1122
1123 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1124
1125         Unreviewed, rolling out r114322.
1126         http://trac.webkit.org/changeset/114322
1127         https://bugs.webkit.org/show_bug.cgi?id=84096
1128
1129         Didn't make the debug bot happy, so back out
1130
1131         * gtk/jhbuild.modules:
1132
1133 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1134
1135         [GTK] Try to fix debug bot by adding gobject-introspection to the build
1136         https://bugs.webkit.org/show_bug.cgi?id=84096
1137
1138         Unreviewed speculative build fix.
1139
1140         * gtk/jhbuild.modules: Added gobject-introspection, since modules need
1141         an up-to-date introspection m4 for running autogen.
1142
1143 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1144
1145         [GTK] Add pango to jhbuild
1146         https://bugs.webkit.org/show_bug.cgi?id=84086
1147
1148         Unreviewed build fix.
1149
1150         * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
1151         jhbuild environment. It's required for latest stable GTK+ and some
1152         systems may lack it.
1153
1154 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1155
1156         [GTK] fonts jhbuild module needs an empty clean target
1157         https://bugs.webkit.org/show_bug.cgi?id=84085
1158
1159         Rubber-stamped by Martin Robinson.
1160
1161         * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
1162         includes a phony clean target that should make warnings and errors go
1163         away.
1164
1165 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1166
1167         [GTK] Bump dependency on GTK+ 3.x to match reality
1168         https://bugs.webkit.org/show_bug.cgi?id=84060
1169
1170         Rubber-stamped by Martin Robinson.
1171
1172         * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
1173         to their GNOME 3.4 versions.
1174         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
1175         is applied upstream.
1176
1177 2012-04-16  Vincent Scheib  <scheib@chromium.org>
1178
1179         Adding Contributors Brian Salomon and Tom Hudson to committers.py.
1180
1181         Unreviewed.
1182
1183         * Scripts/webkitpy/common/config/committers.py:
1184
1185 2012-04-16  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1186
1187         [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
1188         https://bugs.webkit.org/show_bug.cgi?id=84031
1189
1190         Reviewed by Rob Buis.
1191
1192         Implemented interface function didReceiveAuthenticationChallenge in class
1193         DumpRenderTree.
1194
1195         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1196         (drtCredentialDescription):
1197         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1198         (WebKit):
1199         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1200         (WebCore):
1201         (DumpRenderTree):
1202
1203 2012-04-16  Philippe Normand  <pnormand@igalia.com>
1204
1205         build-webkit --gtk --no-webkit2 builds WK2
1206         https://bugs.webkit.org/show_bug.cgi?id=83977
1207
1208         Reviewed by Martin Robinson.
1209
1210         * Scripts/build-webkit: Fixup ./configure option to disable
1211         WebKit2 build.
1212
1213 2012-04-16  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1214
1215         [EFL] [DRT] Feeding key events with invalid keyName
1216         https://bugs.webkit.org/show_bug.cgi?id=83797
1217
1218         Keep the keyName valid within scope of KeyEventInfo to avoid
1219         feeding key events with invalid keyName.
1220
1221         Reviewed by Philippe Normand.
1222
1223         * DumpRenderTree/efl/EventSender.cpp:
1224         (KeyEventInfo::KeyEventInfo):
1225         (KeyEventInfo):
1226         (keyPadNameFromJSValue):
1227         (keyNameFromJSValue):
1228         (createKeyEventInfo):
1229         (sendKeyDown):
1230
1231 2012-04-16  Andras Piroska  <pandras@inf.u-szeged.hu>
1232
1233         [Qt] Replace QtXmlPatterns usage with libxslt dependency
1234         <https://bugs.webkit.org/show_bug.cgi?id=76820>
1235
1236         Reviewed by Simon Hausmann.
1237
1238         The features.prf file was modified, in order to use libxml and libxslt by default.
1239         This modification only work at Qt5.
1240
1241         * qmake/config.tests/libxml2/libxml2.cpp: Added.
1242         (main):
1243         * qmake/config.tests/libxml2/libxml2.pro: Added.
1244         * qmake/config.tests/libxslt/libxslt.cpp: Added.
1245         (main):
1246         * qmake/config.tests/libxslt/libxslt.pro: Added.
1247         * qmake/mkspecs/features/features.prf:
1248         * qmake/sync.profile:
1249
1250 2012-04-16  Seokju Kwon  <seokju.kwon@samsung.com>
1251
1252         [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
1253         https://bugs.webkit.org/show_bug.cgi?id=83862
1254
1255         Reviewed by Kenneth Rohde Christiansen.
1256
1257         EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
1258         It doesn't work properly because of wrong parameter order in function call.
1259
1260         * EWebLauncher/main.c:
1261
1262 2012-04-16  Philippe Normand  <pnormand@igalia.com>
1263
1264         Unreviewed, GTK gardening.
1265
1266         * Scripts/run-gtk-tests:
1267         (TestRunner): Skip /webkit/atk/textChangedNotifications.
1268
1269 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1270
1271         Chromium perf bots should not build
1272         https://bugs.webkit.org/show_bug.cgi?id=83641
1273
1274         Reviewed by Eric Seidel.
1275
1276         Don't build on perf bots to improve the cycle time.
1277
1278         * BuildSlaveSupport/build.webkit.org-config/config.json:
1279
1280 2012-04-14  Zalan Bujtas  <zbujtas@gmail.com>
1281
1282         [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
1283         https://bugs.webkit.org/show_bug.cgi?id=81945
1284
1285         Reviewed by Dan Bernstein.
1286
1287         WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
1288         the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
1289         PageCache to be functional.
1290
1291         * WebKitTestRunner/TestController.cpp:
1292         (WTR::TestController::resetStateToConsistentValues):
1293
1294 2012-04-11  James Robinson  <jamesr@chromium.org>
1295
1296         [chromium] Remove unused compositeToTexture / compositeOffscreen setting
1297         https://bugs.webkit.org/show_bug.cgi?id=83733
1298
1299         Reviewed by Adrienne Walker.
1300
1301         Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
1302
1303         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1304         (main):
1305         * DumpRenderTree/chromium/TestShell.cpp:
1306         (TestShell::TestShell):
1307         (TestShell::resetWebSettings):
1308         * DumpRenderTree/chromium/TestShell.h:
1309         (TestShell):
1310         * DumpRenderTree/chromium/WebPreferences.cpp:
1311         (WebPreferences::reset):
1312         (WebPreferences::applyTo):
1313         * DumpRenderTree/chromium/WebPreferences.h:
1314         (WebPreferences):
1315
1316 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1317
1318         webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
1319         and also rebaseline the test results since we ignore the first run now.
1320
1321         * Scripts/webkitpy/performance_tests/perftest.py:
1322         (PageLoadingPerfTest.run):
1323         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1324         (TestPageLoadingPerfTest.test_run):
1325
1326 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1327
1328         Enable SVG page loading performance tests
1329         https://bugs.webkit.org/show_bug.cgi?id=83861
1330
1331         Reviewed by Adam Barth.
1332
1333         Add support for page loading tests. These are tests without any test running harnesses, and we use
1334         DriverOutput's test_timeout to measure the loading time.
1335
1336         Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
1337
1338         * Scripts/webkitpy/performance_tests/perftest.py:
1339         (PerfTest.run):
1340         (PerfTest):
1341         (PerfTest.run_failed):
1342         (PerfTest.parse_output):
1343         (PerfTest.output_statistics):
1344         (ChromiumStylePerfTest.parse_output):
1345         (PageLoadingPerfTest): Added.
1346         (PageLoadingPerfTest.__init__):
1347         (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
1348         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
1349         (MockPrinter):
1350         (MockPrinter.__init__):
1351         (MockPrinter.write):
1352         (MainTest):
1353         (MainTest.test_parse_output):
1354         (MainTest.test_parse_output_with_failing_line):
1355         (TestPageLoadingPerfTest):
1356         (TestPageLoadingPerfTest.assertWritten):
1357         (TestPageLoadingPerfTest.MockDriver):
1358         (TestPageLoadingPerfTest.MockDriver.__init__):
1359         (TestPageLoadingPerfTest.MockDriver.run_test):
1360         (TestPageLoadingPerfTest.test_run):
1361         (TestPageLoadingPerfTest.test_run_with_bad_output):
1362         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1363         (PerfTestsRunner):
1364         (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
1365         (PerfTestsRunner._collect_tests):
1366         (PerfTestsRunner._run_tests_set):
1367         (PerfTestsRunner._run_single_test):
1368         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1369         (test_collect_tests_with_page_load_svg):
1370         (test_collect_tests_with_page_load_svg.add_file):
1371
1372 2012-04-10  Brady Eidson  <beidson@apple.com>
1373
1374         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
1375         Need WebKit2 API to notify whether history loads are in the page cache
1376
1377         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
1378         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
1379
1380         Reviewed by Darin Adler.
1381
1382         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
1383         (TestWebKitAPI::didFinishLoadForFrame):
1384         (TestWebKitAPI::willGoToBackForwardListItem):
1385         (TestWebKitAPI::setPageLoaderClient):
1386         (TestWebKitAPI::TEST):
1387         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
1388         (ShouldGoToBackForwardListItemTest):
1389         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
1390         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
1391         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
1392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1393
1394         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1395         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
1396
1397 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1398
1399         Group EFL bots into a category on the buildbot master
1400         https://bugs.webkit.org/show_bug.cgi?id=82712
1401
1402         Reviewed by Adam Roben.
1403
1404         Creating a new category definition on the buildbot frontend.
1405
1406         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1407         (loadBuilderConfig): Determine category for EFL bots
1408         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
1409
1410 2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1411
1412         Unreviewed, rolling out r113714.
1413         http://trac.webkit.org/changeset/113714
1414         https://bugs.webkit.org/show_bug.cgi?id=83887
1415
1416         It is behaving strange on the bots and needs more
1417         investigation. (Requested by jeez_ on #webkit).
1418
1419         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1420         (WTR::PlatformWebView::PlatformWebView):
1421
1422 2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1423
1424         webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
1425         https://bugs.webkit.org/show_bug.cgi?id=83690
1426
1427         Reviewed by Tor Arne Vestbø.
1428
1429         Typing part of an email and pressing <TAB> will bash-complete it using the list in
1430         Tools/Scripts/webkitpy/common/config/committers.py
1431
1432         * Scripts/webkit-tools-completion.sh:
1433
1434 2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1435
1436         [EFL] Add API for color chooser
1437         https://bugs.webkit.org/show_bug.cgi?id=83692
1438
1439         Enables INPUT_TYPE_COLOR by default on the EFL port.
1440
1441         Reviewed by Kenneth Rohde Christiansen.
1442
1443         * Scripts/build-webkit:
1444
1445 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1446
1447         Extract PerfTest class from PerfTestRunner
1448         https://bugs.webkit.org/show_bug.cgi?id=83847
1449
1450         Reviewed by Hajime Morita.
1451
1452         Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
1453         that was previously represented by a tuple.
1454
1455         Also moved the logic to determine whether a given test is chromium style or not from run() to
1456         _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
1457         tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
1458         add new types of tests more easily.
1459
1460         * Scripts/webkitpy/performance_tests/perftest.py: Added.
1461         (PerfTest):
1462         (PerfTest.__init__):
1463         (PerfTest.test_name):
1464         (PerfTest.dirname):
1465         (PerfTest.path_or_url):
1466         (PerfTest._should_ignore_line_in_parser_test_result):
1467         (PerfTest.parse_output):
1468         (ChromiumStylePerfTest):
1469         (ChromiumStylePerfTest.__init__):
1470         (ChromiumStylePerfTest.parse_output):
1471         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1472         (PerfTestsRunner._collect_tests):
1473         (PerfTestsRunner.run):
1474         (PerfTestsRunner._run_tests_set):
1475         (PerfTestsRunner._run_single_test):
1476         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1477         (run_test):
1478         (_tests_for_runner):
1479         (test_run_test_set_with_json_output):
1480         (test_run_test_set_with_json_source):
1481         (test_run_test_set_with_multiple_repositories):
1482         (_collect_tests_and_sort_test_name):
1483         (test_collect_tests):
1484         (test_collect_tests_with_skipped_list):
1485
1486 2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>
1487
1488         [Qt] Fix WebKit1 build with V8
1489         https://bugs.webkit.org/show_bug.cgi?id=83322
1490
1491         Reviewed by Adam Barth.
1492
1493         * DumpRenderTree/qt/DumpRenderTree.pro:
1494         * qmake/mkspecs/features/default_post.prf:
1495         * qmake/mkspecs/features/default_pre.prf:
1496         * qmake/mkspecs/features/features.prf:
1497
1498 2012-04-12  Dirk Pranke  <dpranke@chromium.org>
1499
1500         test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
1501         https://bugs.webkit.org/show_bug.cgi?id=83583
1502
1503         Reviewed by Philippe Normand
1504
1505         Updated the unit test to ignore the hours and minutes of the
1506         localtime for time(0), since we can't easily guarantee which
1507         timezone we're in or what timezone rules were in effect on
1508         1/1/1970; this should be mostly fine since we can trust that
1509         time.localtime() will work, although there is the possibility
1510         that we'll screw up the time formatting of which field is the
1511         hours and which is the minutes.
1512
1513         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1514         (VerboseTest):
1515         (VerboseTest.test_basic):
1516         (VerboseTest.test_log_after_update):
1517
1518 2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>
1519
1520         Add an EFL Debug Buildbot to the master configuration
1521         https://bugs.webkit.org/show_bug.cgi?id=82711
1522
1523         Forgot to add EFL Linux Debug to scheduler.
1524
1525         Reviewed by Philippe Normand.
1526
1527         * BuildSlaveSupport/build.webkit.org-config/config.json:
1528
1529 2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1530
1531         Add an EFL Debug Buildbot to the master configuration
1532         https://bugs.webkit.org/show_bug.cgi?id=82711
1533
1534         Reviewed by Philippe Normand.
1535
1536         Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
1537
1538         * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
1539
1540 2012-04-12  George Staikos  <staikos@webkit.org>
1541
1542         Enable the fullscreen API for BlackBerry.
1543         https://bugs.webkit.org/show_bug.cgi?id=83757
1544
1545         Reviewed by Antonio Gomes.
1546
1547         * Scripts/build-webkit:
1548
1549 2012-04-12  Simon Pena  <spena@igalia.com>
1550
1551         [GTK] Test runner crashes without recent versions of pulseaudio-utils
1552         https://bugs.webkit.org/show_bug.cgi?id=83774
1553
1554         Reviewed by Philippe Normand.
1555
1556         Besides checking that pactl is available, check also that its output
1557         is the expected one, and handle gracefully when it isn't, when
1558         trying to unload pulseaudio modules.
1559
1560         * Scripts/webkitpy/layout_tests/port/gtk.py:
1561         (GtkPort._unload_pulseaudio_module):
1562         (GtkPort._restore_pulseaudio_module):
1563
1564 2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>
1565
1566         [Qt] Use QRawFont when building with Qt 5
1567         https://bugs.webkit.org/show_bug.cgi?id=78001
1568
1569         Flip the QRawFont switch for Qt 5.
1570
1571         Reviewed by Simon Hausmann.
1572
1573         * qmake/mkspecs/features/features.prf:
1574
1575 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
1576
1577         Web Inspector: Disabling Inspector causes build failure on Windows
1578         https://bugs.webkit.org/show_bug.cgi?id=83557
1579
1580         Reviewed by Pavel Feldman.
1581
1582         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
1583         This change brings all such API calls under the guard.
1584
1585         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1586         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1587         (WTR):
1588         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1589         (LayoutTestController):
1590         * WebKitTestRunner/TestInvocation.cpp:
1591         (WTR::TestInvocation::invoke):
1592
1593 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
1594
1595         Fix regression introduced in r113927.
1596
1597         Unreviewed, build fix.
1598
1599         I failed to rename skipped_tests() to skipped_layout_tests()
1600         everywhere it needed to be renamed. The unit tests didn't catch
1601         this because the TestPort was one of the places that didn't get
1602         renamed :(.
1603
1604         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1605         (Manager.parse_expectations):
1606         * Scripts/webkitpy/layout_tests/port/test.py:
1607         (TestPort.skipped_layout_tests):
1608         * Scripts/webkitpy/tool/commands/queries.py:
1609         (PrintExpectations._model):
1610
1611 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
1612
1613         new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
1614         https://bugs.webkit.org/show_bug.cgi?id=47528
1615
1616         Reviewed by Adam Barth.
1617
1618         The skipped-ports command has been replaced by 'webkit-patch
1619         print-expectations', which offers the equivalent functionality
1620         via 'webkit-patch print-expectations --platform \* -t skip'
1621         (and other features, of course).
1622         
1623         This also allows me to fix a nasty layering violation where the
1624         chromium port had to know about the TestExpectations objects in
1625         order to implement the command properly.
1626
1627         Lastly, this allows me to rename skipped_tests() to
1628         skipped_layout_tests() to more consistent with
1629         skipped_perf_tests().
1630         
1631         This patch removes skips_layout_test() from the Port interface,
1632         because that can't be implemented without the port knowing about
1633         Expectations objects (and skipped-ports was the only thing using it).
1634
1635         * Scripts/webkitpy/layout_tests/port/base.py:
1636         (Port.skipped_layout_tests):
1637         (Port.skipped_perf_tests):
1638         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1639         (PortTest.test_default_configuration_notfound):
1640         * Scripts/webkitpy/layout_tests/port/chromium.py:
1641         (ChromiumPort.test_expectations_overrides):
1642         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1643         (ChromiumPortTest.test_path_to_image_diff):
1644         * Scripts/webkitpy/layout_tests/port/webkit.py:
1645         (WebKitPort.skipped_layout_tests):
1646         * Scripts/webkitpy/tool/commands/queries.py:
1647         (execute):
1648         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1649         (QueryCommandsTest.test_tree_status):
1650
1651 2012-04-11  Mark Rowe  <mrowe@apple.com>
1652
1653         Remove a fprintf from LayoutTestController.
1654
1655         This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
1656         It was added for no apparent reason by Ryosuke in r113651.
1657
1658         * DumpRenderTree/LayoutTestController.cpp:
1659         (LayoutTestController::redirectionDestinationForURL):
1660
1661 2012-04-11  Nico Weber  <thakis@chromium.org>
1662
1663         [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
1664         https://bugs.webkit.org/show_bug.cgi?id=83709
1665
1666         Reviewed by Anders Carlsson.
1667
1668         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1669         (handleEventCarbon):
1670
1671 2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>
1672
1673         Adding myself to committers.py
1674         https://bugs.webkit.org/show_bug.cgi?id=83711
1675
1676         Unreviewed update to committers.py.
1677
1678         * Scripts/webkitpy/common/config/committers.py:
1679
1680 2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1681
1682         [EFL] LayoutTestController needs implementation of pageProperty
1683         https://bugs.webkit.org/show_bug.cgi?id=82449
1684
1685         Add missing implementation pageProperty to EFL's LayoutTestController
1686         in order to unskip printing/page-rule-selection.html
1687
1688         Reviewed by Antonio Gomes.
1689
1690         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1691         (LayoutTestController::pageProperty):
1692
1693 2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1694
1695         Unreviewed, rolling out r113836.
1696         http://trac.webkit.org/changeset/113836
1697         https://bugs.webkit.org/show_bug.cgi?id=83705
1698
1699         Broke all the WebKit2 inspector tests (Requested by andersca
1700         on #webkit).
1701
1702         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1703         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1704         (WTR::LayoutTestController::showWebInspector):
1705         (WTR::LayoutTestController::closeWebInspector):
1706         (WTR::LayoutTestController::evaluateInWebInspector):
1707         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
1708         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1709         (LayoutTestController):
1710         * WebKitTestRunner/TestInvocation.cpp:
1711         (WTR::TestInvocation::invoke):
1712
1713 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
1714
1715         Web Inspector: Disabling Inspector causes build failure on Windows
1716         https://bugs.webkit.org/show_bug.cgi?id=83557
1717
1718         Reviewed by Pavel Feldman.
1719
1720         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
1721         This change brings all such API calls under the guard.
1722
1723         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1724         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1725         (WTR):
1726         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1727         (LayoutTestController):
1728         * WebKitTestRunner/TestInvocation.cpp:
1729         (WTR::TestInvocation::invoke):
1730
1731 2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
1732
1733         [Qt][WK2] Manage graphics buffers in the web process
1734         https://bugs.webkit.org/show_bug.cgi?id=78675
1735  
1736         Make graphics surface available only for Qt 5, attempting to fix
1737         the Qt-mac build.
1738
1739         Unreviewed build fix.
1740
1741         * qmake/mkspecs/features/features.prf:
1742
1743 2012-04-11  Philippe Normand  <pnormand@igalia.com>
1744
1745         Unreviewed, GTK NRWT follow-up fix after r113849.
1746
1747         * Scripts/webkitpy/layout_tests/port/gtk.py:
1748         (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
1749
1750 2012-04-11  Simon Pena  <spena@igalia.com>
1751
1752         [GTK] media/event-attributes.html fails
1753         https://bugs.webkit.org/show_bug.cgi?id=71662
1754
1755         Reviewed by Philippe Normand.
1756
1757         PulseAudio's module "module-stream-restore" allows saving the volume
1758         of a stream, restoring it the next time it runs.
1759         This affects the tests, since DumpRenderTree's volume settings are
1760         saved between test runs, and tests relying on specific volume values
1761         would miss some volumeChange events (or get additional ones).
1762
1763         This patch hooks on the existing GtkPort setup_test_run method and
1764         creates a new clean_up_test_run method, so PulseAudio's module is
1765         unloaded (if found) before running the tests, and restored (if it
1766         was there previously) after they finished, ensuring the tests run in
1767         the right environment.
1768
1769         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1770         (Manager._clean_up_run): Invoke the port implementation of
1771         clean_up_test_run.
1772         * Scripts/webkitpy/layout_tests/port/base.py:
1773         (Port.clean_up_test_run): Add an empty implementation of
1774         clean_up_test_run.
1775         * Scripts/webkitpy/layout_tests/port/gtk.py:
1776         (GtkPort._unload_pulseaudio_module): Unloads the offending
1777         pulseaudio module, if found.
1778         (GtkPort):
1779         (GtkPort._restore_pulseaudio_module): Restores the offending
1780         pulseaudio module, if it was there previously.
1781         (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
1782         (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
1783
1784 2012-04-11  Andras Becsi  <andras.becsi@nokia.com>
1785
1786         Fix the build with gcc 4.7.0
1787         https://bugs.webkit.org/show_bug.cgi?id=83584
1788
1789         Reviewed by Alexey Proskuryakov.
1790
1791         * qmake/mkspecs/features/unix/default_post.prf:
1792         The -fuse-ld=gold option is not supported with upstream gcc.
1793
1794 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1795
1796         Refactor PerfTestRunner to include file extensions in test names
1797         https://bugs.webkit.org/show_bug.cgi?id=83677
1798
1799         Reviewed by Hajime Morita.
1800
1801         Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
1802
1803         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1804         (PerfTestsRunner._collect_tests):
1805         (PerfTestsRunner._run_tests_set):
1806         (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
1807         We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
1808         (PerfTestsRunner._run_single_test):
1809         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1810         (run_test):
1811         (_tests_for_runner):
1812         (test_run_test_set):
1813         (test_run_test_set_kills_drt_per_run):
1814         (test_run_test_pause_before_testing):
1815         (test_run_test_set_for_parser_tests):
1816         (test_collect_tests):
1817         (test_collect_tests_with_skipped_list):
1818
1819 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
1820
1821         Web Inspector: Disabling Inspector causes build failure on Windows
1822         https://bugs.webkit.org/show_bug.cgi?id=83557
1823
1824         Reviewed by Pavel Feldman.
1825
1826         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
1827         This change brings all such API calls under the guard.
1828
1829         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1830         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1831         (WTR):
1832         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1833         (LayoutTestController):
1834         * WebKitTestRunner/TestInvocation.cpp:
1835         (WTR::TestInvocation::invoke):
1836
1837 2012-04-10  Kent Tamura  <tkent@chromium.org>
1838
1839         Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
1840
1841         * Scripts/webkitpy/common/config/watchlist:
1842         * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
1843
1844 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1845
1846         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
1847         https://bugs.webkit.org/show_bug.cgi?id=82799
1848
1849         Reviewed by Ojan Vafai.
1850
1851         The tests we were skipping in _mark_interrupted_tests_as_skipped
1852         had incorrectly-constructed TestResults, and so they were not
1853         being treated as failures. The JSON generator doesn't record
1854         tests that are passed or skiped in incremental_results, so you
1855         couldn't tell these tests were being skipped at all.
1856
1857         This change changes _mark_interrupted_tests_as_skipped() to
1858         treat the skipped tests as failures; this is arguably still
1859         incorrect but is minimally invasive for now. We probably need to
1860         revisit how we are uploading information about tests that are
1861         skipped and passed altogether in a separate change.
1862
1863         This change also cleans up a couple of other nits that were
1864         unnecessary or broken in this same code path.
1865
1866         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1867         (Manager._mark_interrupted_tests_as_skipped):
1868         (Manager._upload_json_files): Deletes the check for
1869         chromium-mac-leopard (as it is no longer necessary).
1870         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1871         (JSONLayoutResultsGenerator.__init__): Here we were
1872         recalculating the failure type unnecessarily.
1873         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1874         (determine_result_type):
1875         (FailureEarlyExit): Adds a new failure type so we can tell what
1876         happened.
1877         (FailureEarlyExit.message):
1878         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1879         (MainTest.test_exit_after_n_failures_upload): Add more checks to
1880         ensure that we are recording the SKIP correctly; this is less
1881         than ideal, because we can't actually test the contents of
1882         incremental_results.json. We should fix that at some point.
1883
1884 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1885
1886         make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
1887         https://bugs.webkit.org/show_bug.cgi?id=83401
1888
1889         Reviewed by Adam Barth.
1890
1891         Last patch in the series - no longer look in mac-leopard,
1892         mac-snowleopard, or mac-lion.
1893
1894         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1895         (ChromiumMacPort):
1896         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1897
1898 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1899
1900         webkit-patch: add a print-expectations command
1901         https://bugs.webkit.org/show_bug.cgi?id=83347
1902
1903         Reviewed by Adam Barth.
1904
1905         This command will print the expected results for a given set of
1906         tests on a given set of ports matching a given set of keywords.
1907
1908         Example output (printing all the tests not expected to pass, and their
1909         expected results, on a Mac):
1910
1911         $ webkit-patch print-expectations -x pass fast/html
1912         // For mac-snowleopard
1913         fast/html/details-open4.html = TEXT
1914         fast/html/details-open2.html = TEXT
1915         fast/html/details-no-summary4.html = TEXT
1916         fast/html/details-open-javascript.html = TEXT
1917         $
1918
1919         You can also print full test-expectatons.txt lines using --full and a
1920         CSV-style report (which can be useful for post-processing) using --csv.
1921
1922         It will replace the 'skipped-files' command (which will be
1923         removed in a subsequent patch) and is a more general (and
1924         cleaner and properly layered) solution.
1925
1926         Also add an update() command to MockOptions() to make overriding keywords easier.
1927
1928         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1929         (TestExpectationSerializer.to_string):
1930         (TestExpectationSerializer):
1931         (TestExpectationSerializer.to_csv):
1932         (TestExpectationSerializer._format_result):
1933         (TestExpectationLine.create_passing_expectation):
1934         (TestExpectationsModel.get_test_set_for_keyword):
1935         (TestExpectationsModel.has_keyword):
1936         (TestExpectations.model):
1937         * Scripts/webkitpy/tool/commands/queries.py:
1938         (execute):
1939         (PrintExpectations):
1940         (PrintExpectations.__init__):
1941         (PrintExpectations.execute):
1942         (PrintExpectations._filter_tests):
1943         (PrintExpectations._format_lines):
1944         (PrintExpectations._model):
1945         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1946         (TestPrintExpectations): Added.
1947         * Scripts/webkitpy/tool/mocktool.py:
1948         (MockOptions):
1949         (MockOptions.__init__):
1950         (MockOptions.update): Added.
1951
1952 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1953
1954         webkitpy: refactor handling of --platform and related options
1955         https://bugs.webkit.org/show_bug.cgi?id=83525
1956
1957         Reviewed by Adam Barth.
1958
1959         This change moves to centralize handling of --platform, --debug,
1960         --gtk, and other similar flags into a central place next to the
1961         code that actually uses those flags in PortFactory to get the
1962         right Port object.
1963
1964         * Scripts/webkitpy/layout_tests/port/__init__.py:
1965         * Scripts/webkitpy/layout_tests/port/factory.py:
1966         (port_options):
1967         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1968         (parse_args):
1969         * Scripts/webkitpy/tool/commands/queries.py:
1970         (PrintBaselines.__init__):
1971
1972 2012-04-10  Ojan Vafai  <ojan@chromium.org>
1973
1974         Add a chromeless view to the individual tests view
1975         https://bugs.webkit.org/show_bug.cgi?id=83541
1976
1977         Reviewed by Daniel Bates.
1978
1979         This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
1980
1981         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1982         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1983         (testHtmlForIndividualTestOnAllBuilders):
1984         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
1985         (testHtmlForIndividualTestOnAllBuildersWithChrome):
1986         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
1987         (testHtmlForIndividualTests):
1988         (htmlEscape):
1989         (runTests):
1990
1991 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1992
1993         remove 'win' from chromium-win, chromium-linux fallback paths
1994         https://bugs.webkit.org/show_bug.cgi?id=83613
1995
1996         Reviewed by Ojan Vafai.
1997
1998         The chromium ports no longer need to look at the apple 'win'
1999         directory for baseline results.
2000
2001         Also remove the old '-gpu-' entries from the flakiness dashboard
2002         map since I'm touching lines nearby.
2003
2004         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2005         (ChromiumLinuxPort):
2006         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2007         (ChromiumWinPort):
2008         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2009
2010 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
2011
2012         [Qt][WK2] Manage graphics buffers in the web process
2013         https://bugs.webkit.org/show_bug.cgi?id=78675
2014
2015         Enable graphics surfaces on Mac for Qt.
2016
2017         Reviewed by Kenneth Rohde Christiansen.
2018
2019         * qmake/mkspecs/features/features.prf:
2020
2021 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
2022
2023         [CMake] Enable USE_FOLDERS property
2024         https://bugs.webkit.org/show_bug.cgi?id=83571
2025
2026         Reviewed by Daniel Bates.
2027
2028         Setting the FOLDER property on targets gives more structure
2029         to the generated Visual Studio solutions.
2030         This does not affect other CMake generators.
2031
2032         * DumpRenderTree/efl/CMakeLists.txt:
2033         * EWebLauncher/CMakeLists.txt:
2034         * WinCELauncher/CMakeLists.txt:
2035
2036 2012-04-10  David Dorwin  <ddorwin@chromium.org>
2037
2038         Add Encrypted Media Extensions methods to HTMLMediaElement
2039         https://bugs.webkit.org/show_bug.cgi?id=82971
2040
2041         Reviewed by Adam Barth.
2042
2043         The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
2044         Implementation is based on v0.1 of the draft proposal at
2045         http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
2046
2047         * DumpRenderTree/chromium/TestShell.cpp:
2048         (TestShell::TestShell):
2049
2050 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
2051
2052         [EFL][DRT] Catch the "title,changed" signal
2053         https://bugs.webkit.org/show_bug.cgi?id=82174
2054
2055         Reviewed by Gustavo Noronha Silva.
2056
2057         EFL's DumpRenderTree now catches the "title,changed" signal, and
2058         prints out the needed information.
2059
2060         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2061         (DumpRenderTreeChrome::onTitleChanged):
2062
2063 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
2064
2065         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
2066         https://bugs.webkit.org/show_bug.cgi?id=82443
2067
2068         Reviewed by Philippe Normand.
2069
2070         EFL's DRT needs to support LayoutTestController's
2071         willSendRequestReturnsNull() and return NULL when expected. This
2072         allows for several tests to be removed from the skip list.
2073
2074         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2075         (DumpRenderTreeChrome::onWillSendRequest):
2076
2077 2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2078
2079         [EFL] LayoutTestController needs implementation of addUserStyleSheet
2080         https://bugs.webkit.org/show_bug.cgi?id=82446
2081
2082         Adding missing implementation addUserStyleSheet to EFL's LayoutTestController 
2083         so that we can unskip related tests from the skip list. 
2084
2085         Reviewed by Antonio Gomes.
2086
2087         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2088         (LayoutTestController::addUserStyleSheet): Implemented.
2089
2090 2012-04-10  Philip Rogers  <pdr@google.com>
2091
2092         Adding myself to committers.py!
2093
2094         Unreviewed update to committers.py.
2095
2096         * Scripts/webkitpy/common/config/committers.py:
2097
2098 2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>
2099
2100         [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
2101         https://bugs.webkit.org/show_bug.cgi?id=82483
2102
2103         Reviewed by Kenneth Rohde Christiansen.
2104
2105         Set window title to default if there is no page title.
2106
2107         * MiniBrowser/qt/BrowserWindow.cpp:
2108         (BrowserWindow::BrowserWindow):
2109         (BrowserWindow::onTitleChanged):
2110         * MiniBrowser/qt/BrowserWindow.h:
2111         (BrowserWindow):
2112
2113 2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2114
2115         [Qt][WK2] Implement PageClient::isViewWindowActive()
2116         https://bugs.webkit.org/show_bug.cgi?id=81143
2117
2118         Reviewed by Kenneth Rohde Christiansen.
2119
2120         Fix the WrapperWindow from our PlatformWebView
2121         so it correctly creates the platform related
2122         stuff for QWindow, which is not created unless
2123         QWindow::setVisible() or QWindow::show() are called.
2124
2125         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2126         (WTR::PlatformWebView::PlatformWebView):
2127
2128 2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
2129
2130         [Qt][WK2] TestNetscapePlugin is broken
2131         https://bugs.webkit.org/show_bug.cgi?id=83024
2132
2133         Reviewed by Csaba Osztrogonác.
2134
2135         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2136         Fix X11 availability check. embedded is always true with QPA.
2137         * Tools.pro:
2138         Build the test plugin if plugins are enabled for WebKit2.
2139         * qmake/mkspecs/features/features.prf:
2140         * qmake/mkspecs/features/functions.prf:
2141         Added a convenience function to determine availability
2142         of X11 libraries.
2143
2144 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
2145
2146         [WIN] Fix build without precompiled header.
2147
2148         * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
2149
2150 2012-04-10  Arko Saha  <arko@motorola.com>
2151
2152         Unreviewed: adding myself to committers.py.
2153
2154         * Scripts/webkitpy/common/config/committers.py:
2155
2156 2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2157
2158         Unreviewed: adding myself to committers.py.
2159
2160         * Scripts/webkitpy/common/config/committers.py:
2161
2162 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2163
2164         Unreviewed, rolling out r113656.
2165         http://trac.webkit.org/changeset/113656
2166         https://bugs.webkit.org/show_bug.cgi?id=83542
2167
2168         test is broken on chromium-win (Requested by simonjam on
2169         #webkit).
2170
2171         * DumpRenderTree/chromium/WebViewHost.cpp:
2172         (WebViewHost::dispatchIntent):
2173
2174 2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>
2175
2176         Update pywebsocket to 0.7.4.
2177         https://bugs.webkit.org/show_bug.cgi?id=83461
2178
2179         Reviewed by Kent Tamura.
2180
2181         This version supports TLS by using ssl in addition to pyOpenSSL.
2182         Other functional difrerences from 0.7.2 are:
2183          - strict Sec-WebSocket-Key validation conforming RFC 4648
2184          - compression ratio logging in debug
2185
2186         * Scripts/webkitpy/thirdparty/__init__.py:
2187         (AutoinstallImportHook._install_pywebsocket):
2188
2189 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
2190
2191         add a webkit-patch print-baselines command
2192         https://bugs.webkit.org/show_bug.cgi?id=83348
2193
2194         Reviewed by Adam Barth.
2195
2196         This adds a simple 'print-baselines' command to webkit-patch
2197         that can be used in one of two forms: to print where the
2198         baselines for a given test (or set of tests) on a single port
2199         will be found, or to generate a report for multiple ports.
2200
2201         Example of the former:
2202
2203         $ webkit-patch print-baselines fast/html/keygen.html
2204         // For mac-snowleopard
2205         platform/mac/fast/html/keygen-expected.txt
2206         platform/mac/fast/html/keygen-expected.png
2207         $
2208
2209         The latter is most useful for finding out which fallback dirs are
2210         used by which ports for which tests, for example,
2211         'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
2212         No example output is given because the reports are pretty wordy :).
2213
2214         * Scripts/webkitpy/layout_tests/port/base.py:
2215         (Port.baseline_extensions): Added.
2216         (Port.expected_baseline_dict): Added.
2217         * Scripts/webkitpy/tool/commands/queries.py:
2218         (PrintBaselines):
2219         (PrintBaselines.__init__):
2220         (PrintBaselines.execute):
2221         (PrintBaselines._print_baselines):
2222         (PrintBaselines._platform_for_path):
2223
2224 2012-04-09  Florin Malita  <fmalita@chromium.org>
2225
2226         Unreviewed: adding myself to committers.py.
2227
2228         * Scripts/webkitpy/common/config/committers.py:
2229
2230 2012-04-09  Ming Xie  <mxie@rim.com>
2231
2232         [BlackBerry] Allow simulator to use GLES2 acceleration
2233         https://bugs.webkit.org/show_bug.cgi?id=81672
2234
2235         Reviewed by Rob Buis.
2236
2237         * Scripts/webkitdirs.pm:
2238         (blackberryCMakeArguments):
2239
2240 2012-04-09  Dana Jansens  <danakj@chromium.org>
2241
2242         Mark myself as a committer
2243         https://bugs.webkit.org/show_bug.cgi?id=83510
2244
2245         Reviewed by Adrienne Walker.
2246
2247         * Scripts/webkitpy/common/config/committers.py:
2248
2249 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
2250
2251         nrwt is failing to upload test results on the chromium-mac-leopard bots
2252         https://bugs.webkit.org/show_bug.cgi?id=83230
2253
2254         Unreviewed, build fix.
2255
2256         It looks like the change in r113399 to use the per-request
2257         timeout variable didn't actually work, so I am removing the
2258         timeout code altogether and counting on the idea that upload
2259         just isn't likely to take that long and the timeouts and
2260         retransmits are largely unused and largely unnecessary. We'll
2261         see if this breaks anywhere else.
2262
2263         * Scripts/webkitpy/common/net/file_uploader.py:
2264         (FileUploader.__init__):
2265         (FileUploader._upload_data.callback):
2266         (FileUploader):
2267
2268 2012-04-09  Rob Buis  <rbuis@rim.com>
2269
2270         [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
2271         https://bugs.webkit.org/show_bug.cgi?id=83469
2272
2273         Reviewed by Dirk Schulze.
2274
2275         Remove WTF:: prefixes and fix a warning with the length variable.
2276
2277         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2278         (jsStringRefToWebCoreString):
2279         (LayoutTestController::execCommand):
2280         (LayoutTestController::isCommandEnabled):
2281         (LayoutTestController::setUserStyleSheetLocation):
2282         (LayoutTestController::counterValueForElementById):
2283         (LayoutTestController::overridePreference):
2284         (LayoutTestController::setMockGeolocationError):
2285         (LayoutTestController::findString):
2286
2287 2012-04-09  Patrick Gansterer  <paroga@webkit.org>
2288
2289         Build fix for WinCE after r113570.
2290
2291         * Scripts/build-webkit: Do not use FastMalloc for WinCE.
2292
2293 2012-04-09  Eric Carlson  <eric.carlson@apple.com>
2294
2295         Subscribe eric.carlson@apple.com to Media-related changes
2296         https://bugs.webkit.org/show_bug.cgi?id=83421
2297
2298         Reviewed by Dan Bernstein.
2299
2300         * Scripts/webkitpy/common/config/watchlist:
2301
2302 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
2303
2304         check-webkit-style should ignore NULL usage in gtk_style_context_get_style
2305         https://bugs.webkit.org/show_bug.cgi?id=83412
2306
2307         Reviewed by David Levin.
2308
2309         Accept NULL as an argument for gtk_style_context_get_style, because it's
2310         used as a sentinel in a variable argument list. 
2311
2312         * Scripts/webkitpy/style/checkers/cpp.py:
2313         (check_for_null): Add an exception.
2314         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2315         (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
2316
2317 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
2318
2319         webkitpy: use the filesystem object properly in fileuploader
2320         https://bugs.webkit.org/show_bug.cgi?id=83326
2321
2322         Reviewed by Adam Barth.
2323
2324         We should be using the filesystem object rather than the codecs
2325         object.
2326
2327         * Scripts/webkitpy/common/net/file_uploader.py:
2328         (FileUploader.upload_as_multipart_form_data):
2329
2330 2012-04-09  Eric Seidel  <eric@webkit.org>
2331
2332         Enable webkit_unit_tests for commit queue and EWS while tracking failures
2333         https://bugs.webkit.org/show_bug.cgi?id=83329
2334
2335         Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
2336
2337         line 62, in _create_unit_test_results
2338          return UnitTestResults.results_from_string(results_xml)
2339          NameError: global name 'UnitTestResults' is not defined
2340
2341         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2342         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2343         (LayoutTestResultsReaderTest.test_create_unit_test_results):
2344
2345 2012-04-08  Adam Barth  <abarth@webkit.org>
2346
2347         The port object is missing unit_tests_results_path
2348         https://bugs.webkit.org/show_bug.cgi?id=83448
2349
2350         Unreviewed.
2351
2352         This is causing the cr-linux-ews to throw an exception.
2353
2354         * Scripts/webkitpy/common/config/ports.py:
2355         (DeprecatedPort.unit_tests_results_path):
2356
2357 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
2358
2359         [CMake] Cleanup WTF include directories
2360         https://bugs.webkit.org/show_bug.cgi?id=82716
2361
2362         Reviewed by Eric Seidel.
2363
2364         * DumpRenderTree/efl/CMakeLists.txt:
2365         * WinCELauncher/CMakeLists.txt:
2366
2367 2012-04-07  Rob Buis  <rbuis@rim.com>
2368
2369         [BlackBerry] Add Battery Status API support
2370         https://bugs.webkit.org/show_bug.cgi?id=82615
2371
2372         Reviewed by George Staikos.
2373
2374         Enable BATTERY_STATUS.
2375
2376         * Scripts/build-webkit:
2377
2378 2012-04-06  Ami Fischman  <fischman@chromium.org>
2379
2380         Subscribe feature-media-reviews@c.o to Media-related changes.
2381         https://bugs.webkit.org/show_bug.cgi?id=83397
2382
2383         Reviewed by David Levin.
2384
2385         * Scripts/webkitpy/common/config/committers.py:
2386         * Scripts/webkitpy/common/config/watchlist:
2387
2388 2012-04-06  Adrienne Walker  <enne@google.com>
2389
2390         [chromium] Add virtual test suite for threaded compositing
2391         https://bugs.webkit.org/show_bug.cgi?id=82263
2392
2393         Reviewed by James Robinson.
2394
2395         Add compositing/visibility as a virtual test suites to test threaded
2396         compositing with. This is a reasonable smoke test of 9 tests, none of
2397         which have any expectations in the non-threaded case.
2398
2399         To fix many of the remaining tests in this virtual test suite, there
2400         will need to be some serious refactoring to merge the conflict between
2401         the way CCScheduler wants to draw frames and the way DRT also wants to
2402         control things. So, in the short term, enable a few simple tests that
2403         are known to be passing.
2404
2405         * Scripts/webkitpy/layout_tests/port/chromium.py:
2406         (ChromiumPort.virtual_test_suites):
2407
2408 2012-04-06  Enrica Casucci  <enrica@apple.com>
2409
2410         Provide Obj-C private API to simplify markup.
2411         https://bugs.webkit.org/show_bug.cgi?id=83334
2412         <rdar://problem/11033861>
2413
2414         Reviewed by Sam Weinig.
2415
2416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2417         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
2418         (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
2419         * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
2420
2421 2012-04-06  Dirk Pranke  <dpranke@chromium.org>
2422
2423         new-run-webkit-tests: fix bugs in 'mock' drt implementation
2424         https://bugs.webkit.org/show_bug.cgi?id=83341
2425
2426         Reviewed by Eric Seidel.
2427
2428         The current implementation crashed in some circumstances for
2429         reference tests and files that were missing expected results.
2430         This patch fixes those cases and adds more unit tests; it is a
2431         precursor to adding unit tests each port that actually uses this
2432         code, in order to get better coverage of the port/*
2433         implementations.
2434
2435         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2436         (parse_options):
2437         (MockDRT.input_from_line):
2438         (MockDRT.output_for_test):
2439         (MockDRT.run_one_test):
2440         (MockChromiumDRT.input_from_line):
2441         (MockChromiumDRT.output_for_test):
2442         (MockChromiumDRT.run_one_test):
2443         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2444         (MockDRTTest.make_input_output):
2445         (MockDRTTest.expected_output):
2446         (MockDRTTest):
2447         (MockDRTTest.assertTest):
2448         (MockDRTTest.test_missing_image):
2449         (MockDRTTest.test_missing_text):
2450         (MockDRTTest.test_reftest_match):
2451         (MockDRTTest.test_reftest_mismatch):
2452         (MockChromiumDRTTest.expected_output):
2453
2454 2012-04-06  James Robinson  <jamesr@chromium.org>
2455
2456         Enable webkit_unit_tests for commit queue and EWS while tracking failures
2457         https://bugs.webkit.org/show_bug.cgi?id=83329
2458
2459         Reviewed by Adam Barth.
2460
2461         This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
2462         the commit queue and EWS can reject patches that cause regressions.
2463
2464         * Scripts/webkitpy/common/config/ports.py:
2465         (ChromiumPort.run_webkit_unit_tests_command):
2466         * Scripts/webkitpy/common/config/ports_mock.py:
2467         (MockPort.unit_tests_results_path):
2468         * Scripts/webkitpy/common/net/layouttestresults.py:
2469         (LayoutTestResults.__init__):
2470         (LayoutTestResults.failing_tests):
2471         (LayoutTestResults):
2472         (LayoutTestResults.add_unit_test_failures):
2473         * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
2474         (UnitTestResults):
2475         (UnitTestResults.results_from_string):
2476         * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
2477         (UnitTestResultsTest):
2478         (UnitTestResultsTest.test_nostring):
2479         (UnitTestResultsTest.test_emptystring):
2480         (UnitTestResultsTest.test_nofailures):
2481         (test_onefailure):
2482         (test_multiple_failures_per_test):
2483         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2484         (MockCommitQueue.test_results):
2485         (MockCommitQueue.archive_last_test_results):
2486         (FailingTestCommitQueue.test_results):
2487         (test_flaky_test_failure):
2488         (test_failed_archive):
2489         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2490         (LayoutTestResultsReader._create_unit_test_results):
2491         (LayoutTestResultsReader.results):
2492         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2493         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2494         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2495         (PatchAnalysisTaskDelegate.test_results):
2496         (PatchAnalysisTaskDelegate.archive_last_test_results):
2497         (PatchAnalysisTask._test):
2498         (PatchAnalysisTask._build_and_test_without_patch):
2499         (PatchAnalysisTask._test_patch):
2500         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2501         (AbstractEarlyWarningSystem.test_results):
2502         (AbstractEarlyWarningSystem.archive_last_test_results):
2503         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2504         (EarlyWarningSytemTest._test_testing_ews):
2505         * Scripts/webkitpy/tool/commands/queues.py:
2506         (CommitQueue.test_results):
2507         (CommitQueue.archive_last_test_results):
2508         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2509         (CommitQueueTest.test_commit_queue):
2510         (test_rollout):
2511         (test_manual_reject_during_processing):
2512         * Scripts/webkitpy/tool/steps/runtests.py:
2513         (RunTests.run):
2514         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2515         (RunTestsTest.test_webkit_run_unit_tests):
2516
2517 2012-04-06  Aaron Colwell  <acolwell@chromium.org>
2518
2519         Enable MediaSource feature for DumpRenderTree so
2520         MediaSource LayoutTests will pass for Chromium.
2521         https://bugs.webkit.org/show_bug.cgi?id=83053
2522
2523         Reviewed by Dimitri Glazkov.
2524
2525         * DumpRenderTree/chromium/TestShell.cpp:
2526         (TestShell::TestShell):
2527
2528 2012-04-06  George Staikos  <staikos@webkit.org>
2529
2530         Turn on vibration support for BlackBerry.
2531
2532         Reviewed by Rob Buis.
2533
2534         * Scripts/build-webkit:
2535
2536 2012-04-06  Dan Bernstein  <mitz@apple.com>
2537
2538         <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
2539
2540         Reviewed by Sam Weinig.
2541
2542         * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
2543
2544 2012-04-05  Dirk Pranke  <dpranke@chromium.org>
2545
2546         nrwt is failing to upload test results on the chromium-mac-leopard bots
2547         https://bugs.webkit.org/show_bug.cgi?id=83230
2548
2549         Reviewed by Ojan Vafai.
2550
2551         This should fix things properly; FileUploader() was setting the
2552         socket default timeout value, and apparently that doesn't work
2553         properly with urllib. Also, the class had a bad try/finally
2554         block that was causing the exceptions to be swallowed :(.
2555
2556         * Scripts/webkitpy/common/net/file_uploader.py:
2557         (FileUploader.__init__):
2558         (FileUploader._upload_data.callback):
2559         (FileUploader):
2560         (FileUploader._upload_data):
2561         * Scripts/webkitpy/common/net/networktransaction.py:
2562         (NetworkTimeout.__str__):
2563         (NetworkTransaction.run):
2564         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2565         (JSONResultsGeneratorBase.upload_json_files):
2566
2567 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
2568
2569         [Qt] Correct <wtf/*.h> include paths.
2570         https://bugs.webkit.org/show_bug.cgi?id=83270
2571
2572         Reviewed by Eric Seidel.
2573
2574         Modify the #include declerations so that the
2575         wtf types are included using the full path.
2576
2577         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2578
2579 2012-04-05  Philippe Normand  <pnormand@igalia.com>
2580
2581         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
2582         https://bugs.webkit.org/show_bug.cgi?id=83176
2583
2584         Reviewed by Tony Chang.
2585
2586         Refactored the test to use os.path.join() to specify the
2587         core_pattern value of the empty crash log mock.
2588
2589         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2590         (GtkPortTest):
2591         (GtkPortTest.assertLinesEqual):
2592         (GtkPortTest.test_get_crash_log):
2593         (_mock_gdb_output):
2594
2595 2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>
2596
2597         [Qt] Fix includes after QtDeclarative -> QtQML renaming
2598         https://bugs.webkit.org/show_bug.cgi?id=82195
2599
2600         Relanding r112651, because Qt5 is updated everywhere.
2601
2602         * MiniBrowser/qt/BrowserWindow.cpp:
2603         (BrowserWindow::updateVisualMockTouchPoints):
2604         * MiniBrowser/qt/main.cpp:
2605         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2606         (WTR::WrapperWindow::handleStatusChanged):
2607         * qmake/mkspecs/features/unix/default_post.prf:
2608
2609 2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>
2610
2611         [Qt] WK1/WK2 layout test results are diverging
2612         https://bugs.webkit.org/show_bug.cgi?id=82720
2613
2614         The resolving of default font families was altered in Qt5.
2615         This directly affects the font picked by DRT for layout
2616         tests. Since we want to keep the Qt4 and Qt5 results in line,
2617         we can trick DRT in picking the same font as before for now.
2618
2619         Reviewed by Csaba Osztrogonác.
2620
2621         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2622         (WebKit::initializeTestFonts):
2623
2624 2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>
2625
2626         Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
2627         https://bugs.webkit.org/show_bug.cgi?id=82592
2628
2629         Reviewed by David Levin.
2630
2631         Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
2632
2633         * DumpRenderTree/chromium/EventSender.cpp:
2634         (EventSender::beginDragWithFiles):
2635
2636 2012-04-04  Tim Horton  <timothy_horton@apple.com>
2637
2638         [mac] WKTR should always keep its windows offscreen
2639         https://bugs.webkit.org/show_bug.cgi?id=83244
2640         <rdar://problem/11188764>
2641
2642         Reviewed by Simon Fraser.
2643
2644         We don't want to allow windows onto the main display; intercept attempts to
2645         change WebKitTestRunnerWindow's frame origin and prevent it from happening.
2646
2647         Also keep around and respond with a new "fake" origin, in case someone is
2648         expecting it to change (I couldn't find any tests that expected this, however).
2649
2650         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2651         (-[WebKitTestRunnerWindow setFrameOrigin:]):
2652         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
2653         (-[WebKitTestRunnerWindow setFrame:display:]):
2654         (-[WebKitTestRunnerWindow frame]):
2655
2656 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
2657
2658         Fix typo introduced in r113271.
2659
2660         Unreviewed, build fix.
2661
2662         * Scripts/webkitpy/common/net/file_uploader.py:
2663         (FileUploader._upload_data.callback):
2664         (FileUploader):
2665
2666 2012-04-04  Scott Graham  <scottmg@google.com>
2667
2668         [Chromium, DRT] Bounds check indices on gamepadController
2669         https://bugs.webkit.org/show_bug.cgi?id=83192
2670
2671         Invalid test data would cause bad array accesses. Add simple checks to
2672         ignore such invalid data.
2673
2674         Reviewed by Kent Tamura.
2675
2676         * DumpRenderTree/chromium/GamepadController.cpp:
2677         (GamepadController::connect):
2678         (GamepadController::disconnect):
2679         (GamepadController::setId):
2680         (GamepadController::setButtonCount):
2681         (GamepadController::setButtonData):
2682         (GamepadController::setAxisCount):
2683         (GamepadController::setAxisData):
2684
2685 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
2686
2687         nrwt is failing to upload test results on the chromium-mac-leopard bots
2688         https://bugs.webkit.org/show_bug.cgi?id=83230
2689
2690         Reviewed by Ojan Vafai.
2691
2692         More debugging info and a possible fix - stop messing with the
2693         default network timeout, and don't swallow URLErrors.
2694
2695         * Scripts/webkitpy/common/net/file_uploader.py:
2696         (FileUploader._upload_data):
2697         * Scripts/webkitpy/common/net/networktransaction.py:
2698         (NetworkTransaction.run):
2699         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2700         (JSONResultsGeneratorBase.upload_json_files):
2701
2702 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
2703
2704         nrwt is failing to upload test results on the chromium-mac-leopard bots
2705         https://bugs.webkit.org/show_bug.cgi?id=83230
2706
2707         Reviewed by Ojan Vafai.
2708
2709         * Scripts/webkitpy/common/net/file_uploader.py:
2710         (FileUploader.__init__):
2711         (FileUploader._upload_data.callback):
2712         (FileUploader):
2713         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2714         (Manager._upload_json_files):
2715         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2716         (JSONResultsGeneratorBase.upload_json_files):
2717
2718 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2719
2720         WKTR needs to implement layoutTestController.setPageVisibility()
2721         https://bugs.webkit.org/show_bug.cgi?id=69554
2722
2723         Reviewed by Simon Fraser.
2724
2725         This patch implements the layoutTestController.setPageVisibility
2726         so WKTR supports the Page Visibility API implementation by using InjectedBundle
2727         to set the visibility state directly to Page.
2728
2729         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2730         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2731         (WTR::LayoutTestController::setPageVisibility):
2732         (WTR):
2733         (WTR::LayoutTestController::resetPageVisibility):
2734         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2735         (LayoutTestController):
2736
2737 2012-04-04  Adam Barth  <abarth@webkit.org>
2738
2739         [Chromium] TestWebKitAPI links in WebCore twice
2740         https://bugs.webkit.org/show_bug.cgi?id=83177
2741
2742         Reviewed by Dimitri Glazkov.
2743
2744         This is causing link errors in the Windows component build. This patch
2745         moves the dependencies a bit lower down in the dependency diagram in
2746         the hopes of removing the duplicate symbols.
2747
2748         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2749
2750 2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>
2751
2752         [EFL][DRT] Catch the "resource,request,willsend" signal
2753         https://bugs.webkit.org/show_bug.cgi?id=82192
2754
2755         Reviewed by Gustavo Noronha Silva.
2756
2757         EFL's DumpRenderTree now catches the "resource,request,willsend"
2758         signal in order to implement the "Blocked access to external URL"
2759         behavior and avoid potential network-related timeouts in the tests.
2760
2761         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2762         (DumpRenderTreeChrome::createView):
2763         (DumpRenderTreeChrome::onWillSendRequest):
2764         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2765         (DumpRenderTreeChrome):
2766
2767 2012-04-04  Patrick Gansterer  <paroga@webkit.org>
2768
2769         [EFL][DRT] Correct <wtf/*.h> include paths.
2770         https://bugs.webkit.org/show_bug.cgi?id=83168
2771
2772         Reviewed by Eric Seidel.
2773
2774         Modify the #include declarations so that the 
2775         wtf types are included using the full path.
2776
2777         * DumpRenderTree/efl/DumpRenderTree.cpp:
2778
2779 2012-04-04  Philippe Normand  <pnormand@igalia.com>
2780
2781         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
2782         https://bugs.webkit.org/show_bug.cgi?id=83176
2783
2784         Reviewed by Tony Chang.
2785
2786         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2787         (test_get_crash_log): Skip the test on non-linux platforms.
2788
2789 2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2790
2791         [EFL] DRT support for computedStyleIncludingVisitedInfo
2792         https://bugs.webkit.org/show_bug.cgi?id=82190
2793
2794         Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
2795         LayoutTestController so that we can unskip related tests from the skip list.
2796
2797         Reviewed by Antonio Gomes.
2798
2799         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2800         (LayoutTestController::computedStyleIncludingVisitedInfo):
2801
2802 2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>
2803
2804         Unreviewed; update my email address once again in the committers
2805         and watch list.
2806
2807         * Scripts/webkitpy/common/config/committers.py: Prefer my
2808         webkit.org email over my FreeBSD.org one.
2809         * Scripts/webkitpy/common/config/watchlist: Ditto.
2810
2811 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2812
2813         [Qt][WK2] QtWebKit2 should support Page Visibility API
2814         https://bugs.webkit.org/show_bug.cgi?id=81164
2815
2816         Reviewed by Kenneth Rohde Christiansen.
2817
2818         Enabling Page Visiblity API for Qt WebKit2.
2819
2820         * qmake/mkspecs/features/features.prf:
2821
2822 2012-04-04  Andras Becsi  <andras.becsi@nokia.com>
2823
2824         [Qt][WK2] Make the WebView a subclass of Flickable
2825         https://bugs.webkit.org/show_bug.cgi?id=83033
2826
2827         Reviewed by Kenneth Rohde Christiansen.
2828
2829         Remove workaround in MiniBrowser and the ScrollIndicator
2830         now that the WebView is a Flickable.
2831
2832         * MiniBrowser/qt/MiniBrowser.pro:
2833         * MiniBrowser/qt/qml/BrowserWindow.qml:
2834         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2835         * WebKitTestRunner/Target.pri:
2836
2837 2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>
2838
2839         REGRESSION(r113144): It made run-webkit-tests always fail
2840         https://bugs.webkit.org/show_bug.cgi?id=83142
2841
2842         Unreviewed trivial fix after r113144.
2843
2844         * Scripts/run-webkit-tests:
2845
2846 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2847
2848         I really hope this is the last build fix. Apparently exec doesn't quite arguments with
2849         double quotations on Windows. Use system instead.
2850
2851         Hopefully, this won't break anything.
2852
2853         * Scripts/run-webkit-tests:
2854
2855 2012-04-03  Keishi Hattori  <keishi@webkit.org>
2856
2857         Disable ENABLE_DATALIST for now
2858         https://bugs.webkit.org/show_bug.cgi?id=82871
2859
2860         Reviewed by Kent Tamura.
2861
2862         * Scripts/build-webkit: Disabled ENABLE_DATALIST.
2863
2864 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2865
2866         Sigh... this isn't going well. I can't even reproduce this issue locally.
2867         Another speculative fix.
2868
2869         * Scripts/run-webkit-tests:
2870
2871 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2872
2873         I don't know why I'm so sloppy today. Another build fix.
2874
2875         * Scripts/run-webkit-tests:
2876
2877 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2878
2879         Hopefully the last build fix for Chromium Windows.
2880
2881         Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
2882
2883         * Scripts/run-webkit-tests:
2884
2885 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
2886
2887         [Chromium] Lots of timeouts causing Mac10.6 to exit early.
2888         https://bugs.webkit.org/show_bug.cgi?id=83076
2889
2890         Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
2891
2892         Add logic to the apple mac and chromium mac code to not use
2893         too many workers; it looks like the xserves (and possibly mac
2894         pros) count hyperthreaded cores when they really shouldn't and
2895         we end up using too many workers at a time; this leads to tests
2896         thrashing and timing out.
2897
2898         This change is a temporary fix to make the bots happy while I
2899         look into more profiling and other fixes.
2900
2901         * Scripts/webkitpy/layout_tests/port/mac.py:
2902         (ChromiumMacPort.default_child_processes):
2903
2904         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2905         (ChromiumMacPort.default_child_processes):
2906
2907 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2908
2909         WebKitTestRunner's EventSender is leaky
2910         https://bugs.webkit.org/show_bug.cgi?id=83099
2911
2912         Reviewed by Beth Dakin.
2913         
2914         Fix leaks of WKNumbers by using the adoptWK idiom, and make
2915         all the code consistent.
2916
2917         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2918         (WTR::EventSendingController::mouseDown):
2919         (WTR::EventSendingController::mouseUp):
2920         (WTR::EventSendingController::mouseMoveTo):
2921         (WTR::EventSendingController::leapForward):
2922         (WTR::EventSendingController::keyDown):
2923         (WTR::EventSendingController::mouseScrollBy):
2924         (WTR::EventSendingController::addTouchPoint):
2925         (WTR::EventSendingController::updateTouchPoint):
2926         (WTR::EventSendingController::setTouchModifier):
2927         (WTR::EventSendingController::releaseTouchPoint):
2928         (WTR::EventSendingController::cancelTouchPoint):
2929
2930 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2931
2932         Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
2933
2934         * Scripts/run-webkit-tests:
2935         (useNewRunWebKitTests):
2936
2937 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2938
2939         kill-old-processes should kill apache2 and httpd
2940         https://bugs.webkit.org/show_bug.cgi?id=83065
2941
2942         Reviewed by Tony Chang.
2943
2944         Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
2945
2946         * BuildSlaveSupport/kill-old-processes:
2947
2948 2012-04-03  Tony Chang  <tony@chromium.org>
2949
2950         run the same test steps on test only bots as on build-and-test bots
2951         https://bugs.webkit.org/show_bug.cgi?id=83090
2952
2953         Reviewed by Ryosuke Niwa.
2954
2955         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2956         (TestFactory.__init__):
2957
2958 2012-04-03  Ami Fischman  <fischman@chromium.org>
2959
2960         Add a Media watchlist.
2961         https://bugs.webkit.org/show_bug.cgi?id=83071
2962
2963         Reviewed by David Levin.
2964
2965         * Scripts/webkitpy/common/config/watchlist:
2966
2967 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2968
2969         Fix large leak in WebKitTestRunner
2970         https://bugs.webkit.org/show_bug.cgi?id=83084
2971
2972         Reviewed by Beth Dakin.
2973         
2974         Fix a leak of the bimap backing store created when doing pixel and
2975         ref tests. This leak was causing serious thrash on the test bots.
2976         
2977         We don't need to allocate memory for CGBitmapContextCreate(); if we
2978         pass NULL, it will allocate and manage its own backing store.
2979
2980         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2981         (WTR::createCGContextFromImage):
2982
2983 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2984
2985         Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
2986
2987         * BuildSlaveSupport/built-product-archive:
2988         (unzipArchive):
2989
2990 2012-04-03  Ojan Vafai  <ojan@chromium.org>
2991
2992         Give more human friendly error message when builders fail to load or have stale data.
2993         https://bugs.webkit.org/show_bug.cgi?id=83058
2994
2995         Reviewed by Eric Seidel.
2996
2997         * TestResultServer/static-dashboards/dashboard_base.js:
2998         (addError):
2999         (addBuilderLoadErrors):
3000         (handleLocationChange):
3001         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3002
3003 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3004
3005         Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
3006
3007         * BuildSlaveSupport/built-product-archive:
3008         (extractBuiltProduct):
3009
3010 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3011
3012         Yet another build fix after r113067. Don't trigger Chromium testers right away
3013         since they're now triggered by builders.
3014
3015         * BuildSlaveSupport/build.webkit.org-config/config.json:
3016
3017 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3018
3019         Another build fix after r113067 for Mac port.
3020         It turned out that archiving the entire build directory doesn't work.
3021
3022         * BuildSlaveSupport/built-product-archive:
3023         (createZipManually):
3024         (createZip):
3025         (archiveBuiltProduct):
3026
3027 2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
3028
3029         [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
3030         https://bugs.webkit.org/show_bug.cgi?id=82643
3031
3032         Update LayoutTestController to accomodate the new find API.
3033         It now provides caseSensitive functionality to DRT.
3034
3035         Internal Review by Andy Chen.
3036
3037         Reviewed by Rob Buis.
3038
3039         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3040         (LayoutTestController::findString):
3041
3042 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3043
3044         Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
3045         because download-built-product creates the build directory as needed.
3046
3047         This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
3048
3049         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3050         (TestFactory.__init__):
3051
3052 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
3053
3054         Build fix after r113067. Don't delete the build directory.
3055
3056         * BuildSlaveSupport/built-product-archive:
3057         (extractBuiltProduct):
3058
3059 2012-04-02  Ojan Vafai  <ojan@chromium.org>
3060
3061         Load all builder lists from the buildbot json
3062         https://bugs.webkit.org/show_bug.cgi?id=82998
3063
3064         Reviewed by Adam Barth.
3065
3066         Also, remove an unnecessary list of test types. Now we don't hard-code
3067         builder names anywhere and we only have a single hard-coded list of
3068         test types.
3069
3070         * TestResultServer/static-dashboards/builders.js:
3071         (BuilderMaster.prototype.logPath):
3072         (BuilderMaster.prototype.builderJsonPath):
3073         (requestBuilderList.xhr.onload):
3074         (requestBuilderList.xhr.onerror):
3075         (isChromiumDepsFyiGpuTestRunner):
3076         (isChromiumTipOfTreeGpuTestRunner):
3077         (isChromiumDepsGTestRunner):
3078         (isChromiumDepsCrosGTestRunner):
3079         (isChromiumTipOfTreeGTestRunner):
3080         (onBuilderListLoad):
3081         (loadBuildersList):
3082         * TestResultServer/static-dashboards/dashboard_base.js:
3083         (parseCrossDashboardParameters):
3084         (currentBuilderGroupCategory):
3085         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3086         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3087         (testHtmlForTestsWithExpectationsButNoFailures):
3088         (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
3089         (testGenerateChromiumDepsGTestBuildersFromBuilderList):
3090         (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
3091         (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
3092         * TestResultServer/static-dashboards/timeline_explorer.html:
3093
3094 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
3095
3096         Chromium testers should extract builds instead of building on their own
3097         https://bugs.webkit.org/show_bug.cgi?id=82996
3098
3099         Reviewed by Tony Chang.
3100
3101         Make Chromium builders triggger Chromium testers and make testers download and extract builds
3102         from the buildbot master instead of building binaries on their own.
3103
3104         Add download-built-product to wrap curl used in the download-built-product step since Windows
3105         does not provide "curl" natively.
3106
3107         * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
3108         Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
3109         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3110         (DownloadBuiltProduct): Call download-built-product instead of curl.
3111         * BuildSlaveSupport/built-product-archive:
3112         (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
3113         needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
3114         (archiveBuiltProduct): Zip the configuration build directory on Mac port.
3115         (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
3116         (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
3117         * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
3118
3119 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
3120
3121         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
3122         https://bugs.webkit.org/show_bug.cgi?id=82473
3123
3124         Reviewed by Philippe Normand.
3125
3126         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
3127         was ever run.
3128
3129         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
3130         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
3131
3132 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3133
3134         [EFL] DRT support for setInteractiveFormValidationEnabled
3135         https://bugs.webkit.org/show_bug.cgi?id=82050
3136
3137         Enable interactive form validation and unskip tests from the
3138         skip list.
3139
3140         Reviewed by Antonio Gomes.
3141
3142         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3143         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3144
3145 2012-04-03  Philippe Normand  <pnormand@igalia.com>
3146
3147         Unreviewed, another test-webkitpy fix-up after r113037.
3148
3149         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
3150         crash dump depending on current environment.
3151
3152 2012-04-03  Philippe Normand  <pnormand@igalia.com>
3153
3154         Unreviewed, test-webkitpy build fix after r113037.
3155
3156         * Scripts/webkitpy/layout_tests/port/gtk.py:
3157         (GtkPort._get_crash_log):
3158
3159 2012-04-03  Philippe Normand  <pnormand@igalia.com>
3160
3161         [GTK] crash log reports support
3162         https://bugs.webkit.org/show_bug.cgi?id=81659
3163
3164         Reviewed by Martin Robinson.
3165
3166         Removed the daemontools crashmon/xvfb scripts and implemented the crash
3167         log reporting in the NRWT Gtk port. To get proper crash logs one
3168         needs to set the core pattern like this:
3169         echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
3170         Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
3171         environment variable.
3172
3173         * BuildSlaveSupport/gtk/README:
3174         * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
3175         * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
3176         * BuildSlaveSupport/gtk/crashmon/run: Removed.
3177         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
3178         * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
3179         * BuildSlaveSupport/gtk/xvfb/run: Removed.
3180         * Scripts/new-run-webkit-tests:
3181         * Scripts/webkitpy/layout_tests/port/gtk.py:
3182         (GtkDriver.stop):
3183         (GtkPort.show_results_html_file):
3184         (GtkPort):
3185         (GtkPort._get_gdb_output):
3186         (GtkPort._get_crash_log):
3187         (GtkPort._get_crash_log.match_filename):
3188         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3189         (GtkPortTest):
3190         (test_show_results_html_file):
3191         (assertLinesEqual):
3192         (_mock_gdb_output):
3193         (test_get_crash_log):
3194
3195 2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3196
3197         Enable and connect the WebInspectorServer with WebKit2 pages.
3198         https://bugs.webkit.org/show_bug.cgi?id=73094
3199
3200         Reviewed by Simon Hausmann.
3201
3202         Enable developer extras on pages in MiniBrowser for Qt.
3203
3204         * MiniBrowser/qt/qml/BrowserWindow.qml:
3205
3206 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
3207
3208         [EFL] LayoutTestController needs implementation of setDefersLoading
3209         https://bugs.webkit.org/show_bug.cgi?id=82890
3210
3211         Reviewed by Philippe Normand.
3212
3213         Implement setDefersLoading() in EFL's LayoutTestController so that the
3214         corresponding test case can be removed from the skip list.
3215
3216         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3217         (LayoutTestController::setDefersLoading):
3218
3219 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
3220
3221         [EFL] LayoutTestController needs implementation of goBack
3222         https://bugs.webkit.org/show_bug.cgi?id=81914
3223
3224         Reviewed by Philippe Normand.
3225
3226         Implement goBack() in EFL's LayoutTestController by calling
3227         ewk_frame_back().
3228
3229         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3230         (LayoutTestController::goBack):
3231
3232 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
3233
3234         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
3235         https://bugs.webkit.org/show_bug.cgi?id=82589
3236
3237         Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
3238         in order to unskip printing/page-format-data.html
3239
3240         Reviewed by Philippe Normand.
3241
3242         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3243         (LayoutTestController::pageSizeAndMarginsInPixels):
3244
3245 2012-04-03  Simon Pena  <spena@igalia.com>
3246
3247         [GTK] DRT missing didRunInsecureContent notification
3248         https://bugs.webkit.org/show_bug.cgi?id=59367
3249
3250         Reviewed by Philippe Normand.
3251
3252         Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
3253         the main WebFrame or any other WebFrame created later. Added
3254         "didRunInsecureContent" notification in the callback in order to
3255         get the LayoutTests passing.
3256
3257         * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
3258         to WebFrame's "insecure-content-run" signal and add
3259         didRunInsecureContent notification in the callback to get the
3260         LayoutTests passing.
3261         (didRunInsecureContent):
3262         (createWebView):
3263
3264 2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3265
3266         rebaseline-server: Make it possible to not launch a browser with the server.
3267         https://bugs.webkit.org/show_bug.cgi?id=82999
3268
3269         Reviewed by Adam Barth.
3270
3271         Add the `--no-show-results' option, which lets one decide not to
3272         launch a web browser when running the rebaseline server.  This is
3273         especially useful if the default browser is not the wanted one, or
3274         if the rebaseline server page is already open.
3275
3276         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
3277         (AbstractLocalServerCommand.__init__):
3278         (AbstractLocalServerCommand.execute):
3279
3280 2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3281
3282         EFL's LayoutTestController disableImageLoading implementation.
3283         https://bugs.webkit.org/show_bug.cgi?id=82848
3284
3285         Reviewed by Hajime Morita.
3286
3287         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3288         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3289         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3290         (LayoutTestController::disableImageLoading):
3291
3292 2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>
3293
3294         [EFL] LayoutTestController needs implementation of isPageBoxVisible
3295         https://bugs.webkit.org/show_bug.cgi?id=82591
3296
3297         Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
3298         in order to unskip printing/page-format-data.html
3299
3300         Reviewed by Hajime Morita.
3301
3302         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3303         (LayoutTestController::isPageBoxVisible):
3304
3305 2012-04-02  Simon Fraser  <simon.fraser@apple.com>
3306
3307         run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
3308         https://bugs.webkit.org/show_bug.cgi?id=82962
3309
3310         Reviewed by Dirk Pranke.
3311
3312         Ensure that _build_path() returns an absolute path.
3313
3314         Eric Seidel also had to deploy MockConfig in a bunch of places
3315         in order to correct previous testing errors where we were
3316         pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
3317         was a real path.  The real Config object calls run_command("webkit-build-directory")
3318         to read the WebKit build directory from the webkitdirs.pm perl code.
3319         MockConfig abstracts this away and always returns "/mock-build" during
3320         testing.  This change is much larger than one would think necessary
3321         because of needing to deploy this MockConfig class.
3322
3323         * Scripts/webkitpy/layout_tests/port/webkit.py:
3324         (WebKitPort._build_path):
3325
3326 2012-04-02  Ojan Vafai  <ojan@chromium.org>
3327
3328         Fix snafu in r112971. We were never calling parseParameter for builder.
3329
3330         * TestResultServer/static-dashboards/dashboard_base.js:
3331
3332 2012-04-02  Ojan Vafai  <ojan@chromium.org>
3333
3334         Generate the lists of all layout test builders from the buildbot json
3335         https://bugs.webkit.org/show_bug.cgi?id=82924
3336
3337         Reviewed by Mihai Parparita.
3338
3339         In order to make this work, cleaned up a lot of existing technical debt.
3340         -Got rid of expectations builder. This concept is outdated and just dead code.
3341         -Split hash parameter parsing into two functions. One for dashboard_base
3342         (crossDashboardParameters) and one for the specific dashboard html file
3343         (dashboardSpecificParameters). In the old world, parseParameters needed to
3344         be called twice and depended on it's own output the first time through.
3345         Now we only need to parse crossDashboardParameters first and crossDashboardParameters
3346         doesn't depend on the output of crossDashboardParameters.
3347         -Lots of variable/method renames due to the above.
3348         -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
3349         for that dashboard.
3350
3351         * TestResultServer/static-dashboards/aggregate_results.html:
3352         * TestResultServer/static-dashboards/builders.js:
3353         (BuilderGroup):
3354         (BuilderGroup.prototype.setup):
3355         (jsonRequest.xhr.onload):
3356         (jsonRequest.xhr.onerror):
3357         (isWebkitTestRunner):
3358         (isChromiumWebkitTipOfTreeTestRunner):
3359         (isChromiumWebkitDepsTestRunner):
3360         (generateBuildersFromBuilderList):
3361         (onLayoutTestBuilderListLoad):
3362         (onErrorLoadingBuilderList):
3363         (loadBuildersList):
3364         * TestResultServer/static-dashboards/dashboard_base.js:
3365         (handleValidHashParameterWrapper):
3366         (queryHashAsMap):
3367         (parseParameter):
3368         (parseCrossDashboardParameters):
3369         (parseDashboardSpecificParameters):
3370         (parseParameters):
3371         (diffStates):
3372         (defaultValue):
3373         (isLayoutTestResults):
3374         (isGPUTestResults):
3375         (currentBuilderGroupCategory):
3376         (currentBuilderGroup):
3377         (initBuilders):
3378         Now that we've split parameter parseing, these methods no longer need
3379         to take an optional state. They can always just use the global cross-dashboard state.
3380
3381         (pathToBuilderResultsFile):
3382         (appendJSONScriptElementFor):
3383         (appendJSONScriptElements):
3384         (handleResourceLoadError):
3385         (haveJsonFilesLoaded):
3386         (combinedDashboardState):
3387         (setQueryParameter):
3388         (permaLinkURLHash):
3389         (toggleQueryParameter):
3390         (queryParameterValue):
3391         (selectHTML):
3392         (htmlForTestTypeSwitcher):
3393         (g_handleBuildersListLoaded):
3394         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3395         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3396         (testPlatformAndBuildType):
3397         (testSubstringList):
3398         (testHtmlForTestTypeSwitcherGroup):
3399         (testLookupVirtualTestSuite):
3400         (testBaseTest):
3401         (generateBuildersFromBuilderListHelper):
3402         (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
3403         (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
3404         (assertObjectsDeepEqual):
3405         (testQueryHashAsMap):
3406         (testDiffStates):
3407         * TestResultServer/static-dashboards/timeline_explorer.html:
3408         * TestResultServer/static-dashboards/treemap.html:
3409
3410 2012-04-02  Tony Chang  <tony@chromium.org>
3411
3412         check-webkit-style errors when removing .png files
3413         https://bugs.webkit.org/show_bug.cgi?id=82933
3414
3415         Reviewed by David Levin.
3416
3417         * Scripts/webkitpy/style/patchreader.py:
3418         (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
3419         * Scripts/webkitpy/style/patchreader_unittest.py:
3420         (test_check_patch_with_png_deletion):
3421
3422 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3423
3424         Unreviewed, rolling out r112948.
3425         http://trac.webkit.org/changeset/112948
3426         https://bugs.webkit.org/show_bug.cgi?id=82961
3427
3428         Someone else already checked in a similar change (Requested by
3429         sundiamonde on #webkit).
3430
3431         * Scripts/webkitpy/layout_tests/port/webkit.py:
3432         (WebKitDriver._start):
3433
3434 2012-04-02  Adam Barth  <abarth@webkit.org>
3435
3436         garden-o-matic isn't able to rebaseline audio failures
3437         https://bugs.webkit.org/show_bug.cgi?id=82957
3438
3439         Reviewed by Chris Rogers.
3440
3441         This patch just adds "wav" to the list of test suffixes and updates the
3442         unit tests to show that we're rebaselining audio tests results now too.
3443
3444         * Scripts/webkitpy/tool/commands/rebaseline.py:
3445         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3446         (test_rebaseline_updates_expectations_file):
3447
3448 2012-04-02  Adam Barth  <abarth@webkit.org>
3449
3450         garden-o-matic should let you listen to audio failures
3451         https://bugs.webkit.org/show_bug.cgi?id=82953
3452
3453         Reviewed by Chris Rogers.
3454
3455         Now that we've actually got an audio failure on the bots, we can clean
3456         up the last stray bugs.  This patch doesn't have any tests because I'm
3457         lame.
3458
3459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3462         (.):
3463
3464 2012-04-02  Stephanie Lewis  <slewis@apple.com>
3465
3466         run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
3467         https://bugs.webkit.org/show_bug.cgi?id=82552
3468
3469         Reviewed by Dirk Pranke.
3470
3471         Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
3472
3473         * Scripts/webkitpy/layout_tests/port/webkit.py:
3474         (WebKitDriver._start):
3475
3476 2012-04-02  Dirk Pranke  <dpranke@chromium.org>
3477
3478         NRWT is not printing out the builder it's uploading JSON files for
3479         https://bugs.webkit.org/show_bug.cgi?id=82834
3480
3481         Reviewed by Ojan Vafai.
3482
3483         Handle log messages of the form log.info("%s", arg) properly ...
3484         I didn't even know you could do that :).
3485
3486         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3487         (_LogHandler.emit):
3488         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3489         (RegularTest.test_log_args):
3490         (VerboseTest.test_log_args):
3491
3492 2012-04-02  Tim Horton  <timothy_horton@apple.com>
3493
3494         [mac] LayoutTestHelper crashes if there is no main display
3495         https://bugs.webkit.org/show_bug.cgi?id=82944
3496         <rdar://problem/11162954>
3497
3498         Reviewed by Simon Fraser.
3499
3500         If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
3501         a null dictionary, so we shouldn't go ahead and try to read from it.
3502
3503         * DumpRenderTree/mac/LayoutTestHelper.m:
3504         (installLayoutTestColorProfile):
3505
3506 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
3507
3508         [Qt][WK2] Set up plugin process on Unix
3509         https://bugs.webkit.org/show_bug.cgi?id=72121
3510
3511         Reviewed by Simon Hausmann.
3512
3513         * qmake/mkspecs/features/features.prf: Reenable plugins
3514         and turn on plugin process.
3515
3516 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3517
3518         Unreviewed, rolling out r112868, r112879, and r112881.
3519         http://trac.webkit.org/changeset/112868
3520         http://trac.webkit.org/changeset/112879
3521         http://trac.webkit.org/changeset/112881
3522         https://bugs.webkit.org/show_bug.cgi?id=82901
3523
3524         "Build fail on bots." (Requested by kbalazs on #webkit).
3525
3526         * MiniBrowser/gtk/GNUmakefile.am:
3527         * qmake/mkspecs/features/features.prf:
3528
3529 2012-04-02  Philippe Normand  <pnormand@igalia.com>
3530
3531         [GTK] Enable shadow-dom in build-webkit.
3532
3533         Rubber-stamped by Gustavo Noronha Silva.
3534
3535         * Scripts/build-webkit: Enable shadow-dom build, this is need to
3536         have a working build currently.
3537
3538 2012-04-02  Andreas Kling  <kling@webkit.org>
3539
3540         Adding Zalan Bujtas to committers list.
3541
3542         * Scripts/webkitpy/common/config/committers.py:
3543
3544 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
3545
3546         [Qt][WK2] Set up plugin process on Unix
3547         https://bugs.webkit.org/show_bug.cgi?id=72121
3548
3549         Reviewed by Simon Hausmann.
3550
3551         * qmake/mkspecs/features/features.prf: Reenable plugins
3552         and turn on plugin process.
3553
3554 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3555
3556         Unreviewed, rolling out r112651.
3557         http://trac.webkit.org/changeset/112651
3558         https://bugs.webkit.org/show_bug.cgi?id=82887
3559
3560         It doesn't work with older Qt5 (Requested by Ossy on #webkit).
3561
3562         * MiniBrowser/qt/BrowserWindow.cpp:
3563         (BrowserWindow::updateVisualMockTouchPoints):
3564         * MiniBrowser/qt/main.cpp:
3565         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3566         (WTR::WrapperWindow::handleStatusChanged):
3567         * qmake/mkspecs/features/unix/default_post.prf:
3568
3569 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3570
3571         [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
3572         https://bugs.webkit.org/show_bug.cgi?id=82877
3573
3574         Reviewed by Philippe Normand.
3575
3576         * Scripts/run-gtk-tests:
3577         (TestRunner.run_tests): Use replace instead of lstrip to remove
3578         the programs_path from the full path of unit tests.
3579
3580 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3581
3582         Unreviewed. Skip flaky unit tests.
3583
3584         * Scripts/run-gtk-tests:
3585         (TestRunner):
3586
3587 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
3588
3589         webkitpy rebaseline.
3590
3591         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3592         (test_run_test_set_with_json_output):
3593         (test_run_test_set_with_json_source):
3594
3595 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
3596
3597         perf-o-matic should store test results' units
3598         https://bugs.webkit.org/show_bug.cgi?id=82852
3599
3600         Reviewed by Kentaro Hara.
3601
3602         Include units in the results JSON.
3603
3604         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3605         (PerfTestsRunner._process_chromium_style_test_result):
3606         (PerfTestsRunner._process_parser_test_result):
3607
3608 2012-04-01  Tony Tseung  <tseung@apple.com>
3609
3610         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
3611         composite fonts from existing physical fonts.
3612         <rdar://problem/10717370>
3613         https://bugs.webkit.org/show_bug.cgi?id=82810
3614             
3615         A new test font of this kind as been added to the test tools for running the webkit-tests
3616
3617         Reviewed by Dan Bernstein.
3618
3619         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3620         Added new dependency SampleFont.sfont
3621         
3622         * DumpRenderTree/fonts/SampleFont.sfont: Added.
3623         
3624         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3625         * DumpRenderTree/mac/DumpRenderTree.mm:
3626         (allowedFontFamilySet):
3627         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
3628         
3629         (activateTestingFonts):
3630         Added the registration of the Composite Font Referene sample font
3631         
3632         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3633         (WTR::allowedFontFamilySet):
3634         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
3635
3636         (WTR::activateFonts):
3637         Added the registration of the Composite Font Referene sample font
3638
3639         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3640         Added new dependency SampleFont.sfont
3641
3642         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
3643
3644 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3645
3646         Support the Network Information API
3647         https://bugs.webkit.org/show_bug.cgi?id=73528
3648
3649         Reviewed by Adam Barth.
3650
3651         Add network information API feature to build script.
3652
3653         * Scripts/build-webkit:
3654
3655 2012-03-31  Ojan Vafai  <ojan@chromium.org>
3656
3657         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
3658         https://bugs.webkit.org/show_bug.cgi?id=82839
3659
3660         Reviewed by Adam Barth.
3661
3662         Also, update various hard-coded lists for WIN7 and Lion ports.
3663         This is necessary since the new list of builders grabbed off the
3664         buildbot includes Lion.
3665
3666         * TestResultServer/static-dashboards/builders.js:
3667         (generateWebkitBuildersFromBuilderList):
3668         (xhr.onreadystatechange):
3669         Don't use dashboard_base's request method to avoid layering violation.
3670
3671         * TestResultServer/static-dashboards/dashboard_base.js:
3672         (parseParameters):
3673         (initBuilders):
3674         (haveJsonFilesLoaded):
3675         (g_handleBuildersListLoaded):
3676         Block loading the JSON files for each builder until we actually have a list of builders.
3677
3678         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3679         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3680         (testPlatformAndBuildType):
3681         (testGenerateWebkitBuildersFromBuilderList):
3682         * TestResultServer/static-dashboards/timeline_explorer.html:
3683         * TestResultServer/static-dashboards/treemap.html:
3684         Delay generating the page until the builder list has loaded.
3685
3686 2012-03-31  Ojan Vafai  <ojan@chromium.org>
3687
3688         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
3689         https://bugs.webkit.org/show_bug.cgi?id=82799
3690
3691         Reviewed by Eric Seidel.
3692
3693         If we don't run a test, mark it as skipped.
3694
3695         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3696         (Manager._mark_interrupted_tests_as_skipped):
3697         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
3698         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3699         (ManagerTest.test_interrupt_if_at_failure_limits):
3700
3701 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
3702
3703         One more build fix after r112781 for Chromium Windows.
<